[M149] [SPC] Guard SPC Controller destruction during dialog close. Original change's description: > [SPC] Guard SPC Controller destruction during dialog close. > > A `potential` UAF vulnerability exists in the browser process due to > synchronous reentrancy inside SecurePaymentConfirmationController. > > This can happen if platform-specific synchronous activation dispatch > from native_widget_->Close() that reaches > ExtensionPopup::OnWidgetDestroying() inside the same call stack. Or > CloseDialog() itself trigger a controller destruction. > > This change adds a guard to the `CloseDialog()` method that ensures the > call inside SecurePaymentConfirmationController will not continue to > prevent a memory crash. > > Fixed: 522568496 > Change-Id: Ifc0eaaebc42db33bb309e850881722df13cad35d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7959279 > Reviewed-by: Slobodan Pejic <slobodan@chromium.org> > Reviewed-by: Darwin Yang <darwinyang@chromium.org> > Commit-Queue: Xuehui Chen <xuehuichen@google.com> > Cr-Commit-Position: refs/heads/main@{#1649831} (cherry picked from commit b87b4b251a81a1e17b4388046d56f93765b646b3) Bug: 525968739,522568496 Change-Id: Ifc0eaaebc42db33bb309e850881722df13cad35d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8031405 Auto-Submit: chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7827@{#4132} Cr-Branched-From: 9f3e9aaccba63bd2ec30334e45e0bfd07ebcc8f1-refs/heads/main@{#1625079}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.