[M149] [SPC] Guard SPC Controller destruction during dialog close.

Original change's description:
> [SPC] Guard SPC Controller destruction during dialog close.
>
> A `potential` UAF vulnerability exists in the browser process due to
> synchronous reentrancy inside SecurePaymentConfirmationController.
>
> This can happen if platform-specific synchronous activation dispatch
> from native_widget_->Close() that reaches
> ExtensionPopup::OnWidgetDestroying() inside the same call stack. Or
> CloseDialog() itself trigger a controller destruction.
>
> This change adds a guard to the `CloseDialog()` method that ensures the
> call inside SecurePaymentConfirmationController will not continue to
> prevent a memory crash.
>
> Fixed: 522568496
> Change-Id: Ifc0eaaebc42db33bb309e850881722df13cad35d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7959279
> Reviewed-by: Slobodan Pejic <slobodan@chromium.org>
> Reviewed-by: Darwin Yang <darwinyang@chromium.org>
> Commit-Queue: Xuehui Chen <xuehuichen@google.com>
> Cr-Commit-Position: refs/heads/main@{#1649831}

(cherry picked from commit b87b4b251a81a1e17b4388046d56f93765b646b3)

Bug: 525968739,522568496
Change-Id: Ifc0eaaebc42db33bb309e850881722df13cad35d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8031405
Auto-Submit: chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7827@{#4132}
Cr-Branched-From: 9f3e9aaccba63bd2ec30334e45e0bfd07ebcc8f1-refs/heads/main@{#1625079}
1 file changed
tree: 052483b172383c7ed808984bff177f725b19ac0e
  1. .agents/
  2. .claude/
  3. .gemini/
  4. .github/
  5. agents/
  6. android_webview/
  7. apps/
  8. ash/
  9. base/
  10. build/
  11. build_overrides/
  12. buildtools/
  13. cc/
  14. chrome/
  15. chromecast/
  16. chromeos/
  17. codelabs/
  18. components/
  19. content/
  20. crypto/
  21. dbus/
  22. device/
  23. docs/
  24. extensions/
  25. fuchsia_web/
  26. gin/
  27. google_apis/
  28. gpu/
  29. headless/
  30. infra/
  31. ios/
  32. ipc/
  33. media/
  34. mojo/
  35. net/
  36. pdf/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webkit/
  52. .clang-format
  53. .clang-tidy
  54. .clangd
  55. .cursorignore
  56. .geminiignore
  57. .git-blame-ignore-revs
  58. .gitallowed
  59. .gitattributes
  60. .gitignore
  61. .gitmodules
  62. .gn
  63. .mailmap
  64. .rustfmt.toml
  65. .vpython3
  66. .yapfignore
  67. ATL_OWNERS
  68. AUTHORS
  69. BUILD.gn
  70. CODE_OF_CONDUCT.md
  71. codereview.settings
  72. CPPLINT.cfg
  73. CRYPTO_OWNERS
  74. DEPS
  75. DIR_METADATA
  76. LICENSE
  77. LICENSE.chromium_os
  78. OWNERS
  79. package.json
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. SECURITY_OWNERS
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.