Google Git
Sign in
chromium / chromium / src / bb5851b2be2d366f9bacc6befadbdd378c007967
commitbb5851b2be2d366f9bacc6befadbdd378c007967[log] [tgz]
authorDarren Shen <shend@chromium.org>Thu Jul 19 07:04:06 2018
committerCommit Bot <commit-bot@chromium.org>Thu Jul 19 07:04:06 2018
tree8836d7aedfabfaeb1a3d60460d1701bdddf53012
parentca740afdba5cd32ea6eae1b1acaedecbad245699 [diff]
[VK] Don't disable keyboard in IME tray due to temporary hide.

When we use the IME menu tray in laptop mode, we temporarily enable the
accessibility virtual keyboard. When the keyboard is dismissed, we
disable the accessibility keyboard again. However, when we change the
keyboard between docked and floating mode, the keyboard has to hide
first before showing again. This causes the accessibility keyboard to be
disabled and the keyboard doesn't show up again.

We fix this by adding an additional parameter to OnKeyboardHidden
which indicates whether the keyboard is hidden temporarily.

TBR=sky@chromium.org

Bug: 858953
Change-Id: I162917e5e32e6081be49127a3e7e9cf5fbeeb11c
Reviewed-on: https://chromium-review.googlesource.com/1137803
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576400}
7 files changed
tree: 8836d7aedfabfaeb1a3d60460d1701bdddf53012
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .