Revert "Automated T* -> raw_ptr<T> rewrite "refresh"" This reverts commit e407f3d9855a6a063eb8ea661a12b3f9d0a1e228. Reason for revert: Cause of crbug.com/1518884 Original change's description: > Automated T* -> raw_ptr<T> rewrite "refresh" > > PS1: automated rewrite > PS2-PS5,PS7: unrewrite to fix compilation > PS6,PS22: unrewrite non-automated exclusions > PS8-PS20: apply DanglingUntriaged > PS21: unrewrite to undo binary size increase > PS23: remove no-longer-needed RAW_PTR_EXCLUSION, #includes & comments > > The code has changed since the "big rewrite" so some exclusions no > longer apply. But also, the rewriter changed too: > - No longer applies constexpr-related exclusions (raw_ptr<> support > was added) > - union exclusion has been waived for std::optional and absl::variant, > since they invoke raw_ptr<>'s ctor/dtor correctly > - Certain paths under //base are no longer need to be excluded, as > PartitionAlloc/raw_ptr no longer depends on them > > This CL also tries to popularize a better format of exclusion reasoning > comments, e.g.: > // RAW_PTR_EXCLUSION: #addr-of, #global-scope > // RAW_PTR_EXCLUSION: Performance reasons ... > // RAW_PTR_EXCLUSION: #addr-of; Also: Another reason > One comment per block of fields will suffice, if the reason is the > same throughout, and no other comments are added in between. > This format has advantages, like brevity (no more "not a raw_ptr<> > because" blurb), and improved scriptability. > > Bug: 1446392 > Change-Id: I784ff0e461b2105bc01ad7b8570bb462613b24ce > DanglingUntriaged-notes: automated rewrite. > AX-Relnotes: n/a. > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5190661 > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Commit-Queue: Bartek Nowierski <bartekn@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Owners-Override: Keishi Hattori <keishi@chromium.org> > Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1247373} Bug: 1446392, 1518884 Change-Id: I7e5bbd0f4cbd5731ffa2cfaa24c76b17881960c3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5201861 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/main@{#1247869}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.