diff --git a/AUTHORS b/AUTHORS index 2878092..b1483b4 100644 --- a/AUTHORS +++ b/AUTHORS
@@ -569,6 +569,7 @@ Jungkee Song <jungkee.song@samsung.com> Junmin Zhu <junmin.zhu@intel.com> Junsong Li <ljs.darkfish@gmail.com> +Jun Zeng <hjunzeng6@gmail.com> Justin Okamoto <justmoto@amazon.com> Justin Ribeiro <justin@justinribeiro.com> Jüri Valdmann <juri.valdmann@qt.io> @@ -1154,6 +1155,7 @@ Xiang Long <xiang.long@intel.com> XiangYang <yangxiang12@huawei.com> Xiangze Zhang <xiangze.zhang@intel.com> +Xiaobing Yang <yangxiaobing@qianxin.com> Xiaofeng Zhang <xiaofeng.zhang@intel.com> Xiaolei Yu <dreifachstein@gmail.com> Xiaoshu Zhang <xiaoshu@amazon.com>
diff --git a/DEPS b/DEPS index 4c30a33..538853f 100644 --- a/DEPS +++ b/DEPS
@@ -293,7 +293,7 @@ # Three lines of non-changing comments so that # the commit queue can handle CLs rolling catapult # and whatever else without interference from each other. - 'catapult_revision': '4ba18870d259bfdfdfe9947cb80cae8747d2563f', + 'catapult_revision': '1bbcf82927b4633df768513bd3fa99090ce90104', # Three lines of non-changing comments so that # the commit queue can handle CLs rolling libFuzzer # and whatever else without interference from each other. @@ -341,7 +341,7 @@ # Three lines of non-changing comments so that # the commit queue can handle CLs rolling feed # and whatever else without interference from each other. - 'dawn_revision': '813a855b540484bf0c71d1e1ac33d749df9bd3dd', + 'dawn_revision': '93a75930b1fedceba9cc79ea6b96b5d48841aea1', # Three lines of non-changing comments so that # the commit queue can handle CLs rolling feed # and whatever else without interference from each other. @@ -385,11 +385,11 @@ # Three lines of non-changing comments so that # the commit queue can handle CLs rolling feed # and whatever else without interference from each other. - 'libcxxabi_revision': 'bb278658aa0d4cc88dd4ca5bc5df428f92b85ddb', + 'libcxxabi_revision': '486cb6288513c44a65f36dd9c75c111fb7df794c', # Three lines of non-changing comments so that # the commit queue can handle CLs rolling feed # and whatever else without interference from each other. - 'libunwind_revision': '333cca20381ead0d1baa7bcc38219e5bfd52f664', + 'libunwind_revision': '70006b7957faf73ffa9830063545f5dec0c72155', # Three lines of non-changing comments so that # the commit queue can handle CLs rolling feed # and whatever else without interference from each other. @@ -651,7 +651,7 @@ 'packages': [ { 'package': 'chromium/rts/model/linux-amd64', - 'version': 'aaaf82MrjaPtc7uDUksNHdTM5qFZaZ-J4dAEpM2iyVcC', + 'version': 'JCsCRWvADh9xEX_PV2s2UrX5YNpLtTgJQWPCQn5T5KUC', }, ], 'dep_type': 'cipd', @@ -1117,7 +1117,7 @@ Var('chromium_git') + '/chromium/deps/hunspell_dictionaries.git' + '@' + '18e09b9197a3b1d771c077c530d1a4ebad04c167', 'src/third_party/icu': - Var('chromium_git') + '/chromium/deps/icu.git' + '@' + 'b9dfc58bf9b02ea0365509244aca13841322feb0', + Var('chromium_git') + '/chromium/deps/icu.git' + '@' + '2a822c5626ab1ed40366758e4740b4f0ea40237d', 'src/third_party/icu4j': { 'packages': [ @@ -1343,7 +1343,7 @@ Var('chromium_git') + '/external/github.com/cisco/openh264' + '@' + '3dd5b80bc4f172dd82925bb259cb7c82348409c5', 'src/third_party/openscreen/src': - Var('chromium_git') + '/openscreen' + '@' + '616a118d38a26882a930a0c34f5881b35809544b', + Var('chromium_git') + '/openscreen' + '@' + '3eca605e12cb57e49eea49dc0a2ca80a79f93836', 'src/third_party/openxr/src': { 'url': Var('chromium_git') + '/external/github.com/KhronosGroup/OpenXR-SDK' + '@' + 'bf21ccb1007bb531b45d9978919a56ea5059c245', @@ -1360,7 +1360,7 @@ }, 'src/third_party/perfetto': - Var('android_git') + '/platform/external/perfetto.git' + '@' + '5e0184587a2853fa0bdb659e8716b0b3e6ca962f', + Var('android_git') + '/platform/external/perfetto.git' + '@' + '8a77c3ee7bace99c4a69f061ce5efad9ef88d907', 'src/third_party/perl': { 'url': Var('chromium_git') + '/chromium/deps/perl.git' + '@' + '6f3e5028eb65d0b4c5fdd792106ac4c84eee1eb3', @@ -1449,7 +1449,7 @@ 'packages': [ { 'package': 'fuchsia/third_party/aemu/linux-amd64', - 'version': 'LVzqlcQA3SZ_in57BIRK96jsF2AlRnyVHndAywtOCA8C' + 'version': 'ez3lWv5ncjyheCkRQs_v1WGTCLoiJvIecfY-dKKkXcUC' }, ], 'condition': 'host_os == "linux" and checkout_fuchsia', @@ -1589,7 +1589,7 @@ Var('chromium_git') + '/external/khronosgroup/webgl.git' + '@' + '827cad9e402b63bbe38787456115bcb681a8a152', 'src/third_party/webgpu-cts/src': - Var('chromium_git') + '/external/github.com/gpuweb/cts.git' + '@' + '10e5f3284d07b46dfb4bea5076d865655b0b2a04', + Var('chromium_git') + '/external/github.com/gpuweb/cts.git' + '@' + '385003f982d9dd0927fda093c5cee216a75c188d', 'src/third_party/webrtc': Var('webrtc_git') + '/src.git' + '@' + '51969310ef432a9c340bb091eea1f1553ca01587', @@ -1653,7 +1653,7 @@ Var('chromium_git') + '/v8/v8.git' + '@' + Var('v8_revision'), 'src-internal': { - 'url': 'https://chrome-internal.googlesource.com/chrome/src-internal.git@06c0d6a5e40abce1a05a2973e10cb428eb2c307d', + 'url': 'https://chrome-internal.googlesource.com/chrome/src-internal.git@3b466a60b26d97ac5d1ae227a6161609d343ce53', 'condition': 'checkout_src_internal', },
diff --git a/android_webview/browser/component_updater/loader_policies/aw_apps_package_names_allowlist_component_loader_policy.cc b/android_webview/browser/component_updater/loader_policies/aw_apps_package_names_allowlist_component_loader_policy.cc index 85024fc..0679b86 100644 --- a/android_webview/browser/component_updater/loader_policies/aw_apps_package_names_allowlist_component_loader_policy.cc +++ b/android_webview/browser/component_updater/loader_policies/aw_apps_package_names_allowlist_component_loader_policy.cc
@@ -30,6 +30,7 @@ #include "base/time/time.h" #include "base/values.h" #include "base/version.h" +#include "components/component_updater/android/component_loader_policy.h" #include "components/optimization_guide/core/bloom_filter.h" #include "third_party/abseil-cpp/absl/types/optional.h" @@ -155,7 +156,7 @@ // date is absent. if (!expiry_date_ms.has_value() || !num_hash.has_value() || !num_bits.has_value() || num_hash.value() <= 0 || num_bits.value() <= 0) { - ComponentLoadFailed(); + ComponentLoadFailedInternal(); return; } @@ -163,7 +164,7 @@ base::Time::UnixEpoch() + base::TimeDelta::FromMillisecondsD(expiry_date_ms.value_or(0.0)); if (expiry_date <= base::Time::Now()) { - ComponentLoadFailed(); + ComponentLoadFailedInternal(); return; } @@ -176,7 +177,7 @@ auto allowlist_iterator = fd_map.find(kAllowlistBloomFilterFileName); if (allowlist_iterator == fd_map.end()) { - ComponentLoadFailed(); + ComponentLoadFailedInternal(); return; } @@ -189,7 +190,13 @@ std::move(lookup_callback_)); } -void AwAppsPackageNamesAllowlistComponentLoaderPolicy::ComponentLoadFailed() { +void AwAppsPackageNamesAllowlistComponentLoaderPolicy::ComponentLoadFailed( + component_updater::ComponentLoadError /*error*/) { + ComponentLoadFailedInternal(); +} + +void AwAppsPackageNamesAllowlistComponentLoaderPolicy:: + ComponentLoadFailedInternal() { DCHECK(lookup_callback_); std::move(lookup_callback_).Run(absl::optional<AppPackageNameLoggingRule>()); }
diff --git a/android_webview/browser/component_updater/loader_policies/aw_apps_package_names_allowlist_component_loader_policy.h b/android_webview/browser/component_updater/loader_policies/aw_apps_package_names_allowlist_component_loader_policy.h index 5c839a6..7ac6fde 100644 --- a/android_webview/browser/component_updater/loader_policies/aw_apps_package_names_allowlist_component_loader_policy.h +++ b/android_webview/browser/component_updater/loader_policies/aw_apps_package_names_allowlist_component_loader_policy.h
@@ -65,10 +65,13 @@ const base::Version& version, base::flat_map<std::string, base::ScopedFD>& fd_map, std::unique_ptr<base::DictionaryValue> manifest) override; - void ComponentLoadFailed() override; + void ComponentLoadFailed( + component_updater::ComponentLoadError error) override; void GetHash(std::vector<uint8_t>* hash) const override; private: + void ComponentLoadFailedInternal(); + std::string app_package_name_; absl::optional<AppPackageNameLoggingRule> cached_record_;
diff --git a/android_webview/browser/component_updater/loader_policies/aw_apps_package_names_allowlist_component_loader_policy_unittest.cc b/android_webview/browser/component_updater/loader_policies/aw_apps_package_names_allowlist_component_loader_policy_unittest.cc index 579d03b7..d470a66af 100644 --- a/android_webview/browser/component_updater/loader_policies/aw_apps_package_names_allowlist_component_loader_policy_unittest.cc +++ b/android_webview/browser/component_updater/loader_policies/aw_apps_package_names_allowlist_component_loader_policy_unittest.cc
@@ -23,6 +23,7 @@ #include "base/time/time.h" #include "base/values.h" #include "base/version.h" +#include "components/component_updater/android/component_loader_policy.h" #include "components/optimization_guide/core/bloom_filter.h" #include "testing/gtest/include/gtest/gtest.h"
diff --git a/android_webview/browser/component_updater/loader_policies/origin_trials_component_loader_policy.cc b/android_webview/browser/component_updater/loader_policies/origin_trials_component_loader_policy.cc index 7a738e0..4a1af9d0 100644 --- a/android_webview/browser/component_updater/loader_policies/origin_trials_component_loader_policy.cc +++ b/android_webview/browser/component_updater/loader_policies/origin_trials_component_loader_policy.cc
@@ -16,6 +16,7 @@ #include "base/files/scoped_file.h" #include "base/values.h" #include "base/version.h" +#include "components/component_updater/android/component_loader_policy.h" #include "components/component_updater/installer_policies/origin_trials_component_installer.h" #include "components/embedder_support/origin_trials/component_updater_utils.h" @@ -40,7 +41,8 @@ std::move(manifest)); } -void OriginTrialsComponentLoaderPolicy::ComponentLoadFailed() {} +void OriginTrialsComponentLoaderPolicy::ComponentLoadFailed( + component_updater::ComponentLoadError /*error*/) {} void OriginTrialsComponentLoaderPolicy::GetHash( std::vector<uint8_t>* hash) const {
diff --git a/android_webview/browser/component_updater/loader_policies/origin_trials_component_loader_policy.h b/android_webview/browser/component_updater/loader_policies/origin_trials_component_loader_policy.h index e479051e..9a503847 100644 --- a/android_webview/browser/component_updater/loader_policies/origin_trials_component_loader_policy.h +++ b/android_webview/browser/component_updater/loader_policies/origin_trials_component_loader_policy.h
@@ -41,7 +41,8 @@ const base::Version& version, base::flat_map<std::string, base::ScopedFD>& fd_map, std::unique_ptr<base::DictionaryValue> manifest) override; - void ComponentLoadFailed() override; + void ComponentLoadFailed( + component_updater::ComponentLoadError error) override; void GetHash(std::vector<uint8_t>* hash) const override; };
diff --git a/android_webview/browser/metrics/BUILD.gn b/android_webview/browser/metrics/BUILD.gn index e236ff88..9094e73e 100644 --- a/android_webview/browser/metrics/BUILD.gn +++ b/android_webview/browser/metrics/BUILD.gn
@@ -9,8 +9,6 @@ "aw_metrics_service_accessor.h", "aw_metrics_service_client.cc", "aw_metrics_service_client.h", - "aw_stability_metrics_provider.cc", - "aw_stability_metrics_provider.h", "renderer_process_metrics_provider.cc", "renderer_process_metrics_provider.h", "visibility_metrics_logger.cc",
diff --git a/android_webview/browser/metrics/aw_metrics_service_client.cc b/android_webview/browser/metrics/aw_metrics_service_client.cc index fcf7cae..b9c2e96 100644 --- a/android_webview/browser/metrics/aw_metrics_service_client.cc +++ b/android_webview/browser/metrics/aw_metrics_service_client.cc
@@ -7,7 +7,6 @@ #include <jni.h> #include <cstdint> -#include "android_webview/browser/metrics/aw_stability_metrics_provider.h" #include "android_webview/browser_jni_headers/AwMetricsServiceClient_jni.h" #include "android_webview/common/aw_features.h" #include "android_webview/common/metrics/app_package_name_logging_rule.h" @@ -203,9 +202,6 @@ void AwMetricsServiceClient::RegisterAdditionalMetricsProviders( metrics::MetricsService* service) { - service->RegisterMetricsProvider( - std::make_unique<android_webview::AwStabilityMetricsProvider>( - pref_service())); delegate_->RegisterAdditionalMetricsProviders(service); }
diff --git a/android_webview/browser/metrics/aw_stability_metrics_provider.cc b/android_webview/browser/metrics/aw_stability_metrics_provider.cc deleted file mode 100644 index e060506f..0000000 --- a/android_webview/browser/metrics/aw_stability_metrics_provider.cc +++ /dev/null
@@ -1,68 +0,0 @@ -// Copyright 2019 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "android_webview/browser/metrics/aw_stability_metrics_provider.h" - -#include "base/macros.h" -#include "components/prefs/pref_service.h" -#include "content/public/browser/notification_details.h" -#include "content/public/browser/notification_service.h" -#include "content/public/browser/notification_source.h" -#include "content/public/browser/notification_types.h" -#include "third_party/metrics_proto/system_profile.pb.h" - -namespace android_webview { - -AwStabilityMetricsProvider::AwStabilityMetricsProvider(PrefService* local_state) - : helper_(local_state) { - registrar_.Add(this, content::NOTIFICATION_LOAD_START, - content::NotificationService::AllSources()); - registrar_.Add(this, content::NOTIFICATION_RENDER_WIDGET_HOST_HANG, - content::NotificationService::AllSources()); - registrar_.Add(this, content::NOTIFICATION_RENDERER_PROCESS_CREATED, - content::NotificationService::AllSources()); -} - -AwStabilityMetricsProvider::~AwStabilityMetricsProvider() { - registrar_.RemoveAll(); -} - -void AwStabilityMetricsProvider::OnRecordingEnabled() {} - -void AwStabilityMetricsProvider::OnRecordingDisabled() {} - -void AwStabilityMetricsProvider::ProvideStabilityMetrics( - metrics::SystemProfileProto* system_profile_proto) { - helper_.ProvideStabilityMetrics(system_profile_proto); -} - -void AwStabilityMetricsProvider::ClearSavedStabilityMetrics() { - helper_.ClearSavedStabilityMetrics(); -} - -void AwStabilityMetricsProvider::Observe( - int type, - const content::NotificationSource& source, - const content::NotificationDetails& details) { - switch (type) { - case content::NOTIFICATION_LOAD_START: - helper_.LogLoadStarted(); - break; - - case content::NOTIFICATION_RENDER_WIDGET_HOST_HANG: - helper_.LogRendererHang(); - break; - - case content::NOTIFICATION_RENDERER_PROCESS_CREATED: { - helper_.LogRendererLaunched(/*was_extension_process=*/false); - break; - } - - default: - NOTREACHED(); - break; - } -} - -} // namespace android_webview
diff --git a/android_webview/browser/metrics/aw_stability_metrics_provider.h b/android_webview/browser/metrics/aw_stability_metrics_provider.h deleted file mode 100644 index 2eab869..0000000 --- a/android_webview/browser/metrics/aw_stability_metrics_provider.h +++ /dev/null
@@ -1,61 +0,0 @@ -// Copyright 2019 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef ANDROID_WEBVIEW_BROWSER_METRICS_AW_STABILITY_METRICS_PROVIDER_H_ -#define ANDROID_WEBVIEW_BROWSER_METRICS_AW_STABILITY_METRICS_PROVIDER_H_ - -#include "base/macros.h" -#include "components/metrics/metrics_provider.h" -#include "components/metrics/stability_metrics_helper.h" -#include "content/public/browser/notification_observer.h" -#include "content/public/browser/notification_registrar.h" - -class PrefService; - -namespace content { -class NotificationDetails; -class NotificationSource; -} // namespace content - -namespace metrics { -class SystemProfileProto; -} // namespace metrics - -namespace android_webview { - -// AwStabilityMetricsProvider gathers and logs Content-embedder-specific -// stability-related metrics. TODO(ntfschr): once we've fully implemented -// stability metrics in AW, we should componentize most of this to be shared by -// weblayer and chrome. See https://crbug.com/1015655. -class AwStabilityMetricsProvider : public metrics::MetricsProvider, - public content::NotificationObserver { - public: - explicit AwStabilityMetricsProvider(PrefService* local_state); - ~AwStabilityMetricsProvider() override; - - // metrics::MetricsDataProvider: - void OnRecordingEnabled() override; - void OnRecordingDisabled() override; - void ProvideStabilityMetrics( - metrics::SystemProfileProto* system_profile_proto) override; - void ClearSavedStabilityMetrics() override; - - protected: - // content::NotificationObserver: - void Observe(int type, - const content::NotificationSource& source, - const content::NotificationDetails& details) override; - - private: - metrics::StabilityMetricsHelper helper_; - - // Registrar for receiving stability-related notifications. - content::NotificationRegistrar registrar_; - - DISALLOW_COPY_AND_ASSIGN(AwStabilityMetricsProvider); -}; - -} // namespace android_webview - -#endif // ANDROID_WEBVIEW_BROWSER_METRICS_AW_STABILITY_METRICS_PROVIDER_H_
diff --git a/android_webview/browser/metrics/aw_stability_metrics_provider_unittest.cc b/android_webview/browser/metrics/aw_stability_metrics_provider_unittest.cc deleted file mode 100644 index 07e23a6..0000000 --- a/android_webview/browser/metrics/aw_stability_metrics_provider_unittest.cc +++ /dev/null
@@ -1,111 +0,0 @@ -// Copyright 2019 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "android_webview/browser/metrics/aw_stability_metrics_provider.h" - -#include <memory> - -#include "base/macros.h" -#include "base/test/metrics/histogram_tester.h" -#include "components/metrics/stability_metrics_helper.h" -#include "components/prefs/pref_service.h" -#include "components/prefs/testing_pref_service.h" -#include "content/public/browser/notification_service.h" -#include "content/public/browser/notification_types.h" -#include "content/public/test/browser_task_environment.h" -#include "testing/gtest/include/gtest/gtest.h" -#include "third_party/metrics_proto/system_profile.pb.h" - -namespace android_webview { - -namespace { - -class AwStabilityMetricsProviderTest : public testing::Test { - protected: - AwStabilityMetricsProviderTest() - : prefs_(new TestingPrefServiceSimple), - notification_service_(content::NotificationService::Create()) { - metrics::StabilityMetricsHelper::RegisterPrefs(prefs()->registry()); - } - - TestingPrefServiceSimple* prefs() { return prefs_.get(); } - - private: - std::unique_ptr<TestingPrefServiceSimple> prefs_; - content::BrowserTaskEnvironment task_environment_; - - // AwStabilityMetricsProvider::RegisterForNotifications() requires the - // NotificationService to be up and running. Initialize it here, throw away - // the value because we don't need it directly. - std::unique_ptr<content::NotificationService> notification_service_; - - DISALLOW_COPY_AND_ASSIGN(AwStabilityMetricsProviderTest); -}; - -class TestMetricsProvider : public AwStabilityMetricsProvider { - public: - explicit TestMetricsProvider(PrefService* local_state) - : AwStabilityMetricsProvider(local_state) {} - ~TestMetricsProvider() override {} - - void Observe(int type, - const content::NotificationSource& source, - const content::NotificationDetails& details) override { - AwStabilityMetricsProvider::Observe(type, source, details); - } -}; - -} // namespace - -TEST_F(AwStabilityMetricsProviderTest, PageLoadCount) { - base::HistogramTester histogram_tester; - TestMetricsProvider provider(prefs()); - metrics::SystemProfileProto system_profile; - - // Create a fake notification. Source and details aren't checked in the - // implementation, so just use empty values. - provider.Observe(content::NOTIFICATION_LOAD_START, - content::NotificationService::AllSources(), - content::NotificationService::NoDetails()); - - provider.ProvideStabilityMetrics(&system_profile); - EXPECT_EQ(1, system_profile.stability().page_load_count()); - histogram_tester.ExpectUniqueSample( - "Stability.Counts2", metrics::StabilityEventType::kPageLoad, 1); -} - -TEST_F(AwStabilityMetricsProviderTest, RendererHangCount) { - base::HistogramTester histogram_tester; - TestMetricsProvider provider(prefs()); - metrics::SystemProfileProto system_profile; - - // Create a fake notification. Source and details aren't checked in the - // implementation, so just use empty values. - provider.Observe(content::NOTIFICATION_RENDER_WIDGET_HOST_HANG, - content::NotificationService::AllSources(), - content::NotificationService::NoDetails()); - - provider.ProvideStabilityMetrics(&system_profile); - EXPECT_EQ(1, system_profile.stability().renderer_hang_count()); - histogram_tester.ExpectUniqueSample("ChildProcess.HungRendererInForeground", - /* true */ 1, 1); - histogram_tester.ExpectTotalCount( - "ChildProcess.HungRendererAvailableMemoryMB", 1); -} - -TEST_F(AwStabilityMetricsProviderTest, RendererLaunchCount) { - TestMetricsProvider provider(prefs()); - metrics::SystemProfileProto system_profile; - - // Create a fake notification. Source and details aren't checked in the - // implementation, so just use empty values. - provider.Observe(content::NOTIFICATION_RENDERER_PROCESS_CREATED, - content::NotificationService::AllSources(), - content::NotificationService::NoDetails()); - - provider.ProvideStabilityMetrics(&system_profile); - EXPECT_EQ(1, system_profile.stability().renderer_launch_count()); -} - -} // namespace android_webview
diff --git a/android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java b/android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java index d1d7298..677213d 100644 --- a/android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java +++ b/android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java
@@ -4,8 +4,12 @@ package org.chromium.android_webview; +import android.os.SystemClock; + import org.chromium.android_webview.AwContents.VisualStateCallback; +import org.chromium.base.metrics.RecordHistogram; import org.chromium.base.task.PostTask; +import org.chromium.components.embedder_support.util.UrlConstants; import org.chromium.content_public.browser.GlobalRenderFrameHostId; import org.chromium.content_public.browser.LifecycleState; import org.chromium.content_public.browser.NavigationHandle; @@ -36,6 +40,13 @@ // Temporarily stores the URL passed the last time to didFinishLoad callback. private String mLastDidFinishLoadUrl; + // The start time for measuring time spent on a page, from commit to the start of the next + // navigation. + private long mStartTimeSpentMillis = -1; + + // The scheme for the page we're currently on and measuring time spent for. + private String mCurrentSchemeForTimeSpent; + public AwWebContentsObserver( WebContents webContents, AwContents awContents, AwContentsClient awContentsClient) { super(webContents); @@ -120,6 +131,42 @@ client.updateTitle(title, true); } + /** + * Converts a scheme to a histogram key used in Android.WebView.PageTimeSpent.{Scheme}. These + * must be kept in sync. + */ + private static String pageTimeSpentSchemeToHistogramKey(String scheme) { + switch (scheme) { + case UrlConstants.DATA_SCHEME: + return "Data"; + case UrlConstants.FILE_SCHEME: + return "File"; + case UrlConstants.HTTP_SCHEME: + return "Http"; + case UrlConstants.HTTPS_SCHEME: + return "Https"; + case UrlConstants.JAVASCRIPT_SCHEME: + return "JavaScript"; + default: + return "Other"; + } + } + + @Override + public void didStartNavigation(NavigationHandle navigation) { + // Time spent on page is measured from navigation commit to the start of the next + // navigation. + if (navigation.isInPrimaryMainFrame() && !navigation.isSameDocument() + && mStartTimeSpentMillis != -1 && mCurrentSchemeForTimeSpent != null) { + long timeSpentMillis = SystemClock.uptimeMillis() - mStartTimeSpentMillis; + String key = pageTimeSpentSchemeToHistogramKey(mCurrentSchemeForTimeSpent); + RecordHistogram.recordLongTimesHistogram100( + "Android.WebView.PageTimeSpent." + key, timeSpentMillis); + mStartTimeSpentMillis = -1; + mCurrentSchemeForTimeSpent = null; + } + } + @Override public void didFinishNavigation(NavigationHandle navigation) { String url = navigation.getUrl().getPossiblyInvalidSpec(); @@ -128,6 +175,18 @@ navigation.isInPrimaryMainFrame(), navigation.errorCode(), navigation.getUrl()); } + // Time spent on page is measured from navigation commit to the start of the next + // navigation. + if (navigation.isInPrimaryMainFrame() && !navigation.isSameDocument()) { + if (navigation.hasCommitted()) { + mStartTimeSpentMillis = SystemClock.uptimeMillis(); + mCurrentSchemeForTimeSpent = navigation.getUrl().getScheme(); + } else { + mStartTimeSpentMillis = -1; + mCurrentSchemeForTimeSpent = null; + } + } + if (!navigation.hasCommitted()) return; mCommittedNavigation = true;
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java index bf32274..7468ac89 100644 --- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java +++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java
@@ -19,7 +19,6 @@ import org.chromium.android_webview.AwContents; import org.chromium.android_webview.AwRenderProcess; -import org.chromium.android_webview.AwRenderProcessGoneDetail; import org.chromium.android_webview.renderer_priority.RendererPriority; import org.chromium.base.task.PostTask; import org.chromium.base.test.util.CallbackHelper; @@ -45,14 +44,14 @@ public AwActivityTestRule mActivityTestRule = new AwActivityTestRule(); private TestWebServer mWebServer; - private RenderProcessGoneTestAwContentsClient mContentsClient; + private TestAwContentsClient mContentsClient; private AwTestContainerView mTestView; private AwContents mAwContents; @Before public void setUp() throws Exception { mWebServer = TestWebServer.start(); - mContentsClient = new RenderProcessGoneTestAwContentsClient(); + mContentsClient = new TestAwContentsClient(); mTestView = mActivityTestRule.createAwTestContainerViewOnMainSync(mContentsClient); mAwContents = mTestView.getAwContents(); } @@ -69,46 +68,15 @@ return mWebServer.setResponse(httpPath, html, headers); } - private static class GetRenderProcessGoneHelper extends CallbackHelper { - private AwRenderProcessGoneDetail mDetail; - - public AwRenderProcessGoneDetail getAwRenderProcessGoneDetail() { - assert getCallCount() > 0; - return mDetail; - } - - public void notifyCalled(AwRenderProcessGoneDetail detail) { - mDetail = detail; - notifyCalled(); - } - } - - private static class RenderProcessGoneTestAwContentsClient extends TestAwContentsClient { - - private GetRenderProcessGoneHelper mGetRenderProcessGoneHelper; - - public RenderProcessGoneTestAwContentsClient() { - mGetRenderProcessGoneHelper = new GetRenderProcessGoneHelper(); - } - - public GetRenderProcessGoneHelper getGetRenderProcessGoneHelper() { - return mGetRenderProcessGoneHelper; - } - - @Override - public boolean onRenderProcessGone(AwRenderProcessGoneDetail detail) { - mGetRenderProcessGoneHelper.notifyCalled(detail); - return true; - } - } - interface Terminator { void terminate(); } private AwRenderProcess createAndTerminateRenderProcess( Terminator terminator, boolean expectCrash) throws Throwable { - GetRenderProcessGoneHelper helper = mContentsClient.getGetRenderProcessGoneHelper(); + TestAwContentsClient.RenderProcessGoneHelper helper = + mContentsClient.getRenderProcessGoneHelper(); + helper.setResponse(true); // Don't automatically kill the browser process. final AwRenderProcess renderProcess = TestThreadUtils.runOnUiThreadBlocking(() -> mAwContents.getRenderProcess());
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwMetricsIntegrationTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwMetricsIntegrationTest.java index 0cd5bc4e..a045c15b 100644 --- a/android_webview/javatests/src/org/chromium/android_webview/test/AwMetricsIntegrationTest.java +++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwMetricsIntegrationTest.java
@@ -40,10 +40,12 @@ import org.chromium.components.metrics.SystemProfileProtos.SystemProfileProto; import org.chromium.components.metrics.SystemProfileProtos.SystemProfileProto.ChromeComponent; import org.chromium.content_public.browser.test.util.TestThreadUtils; +import org.chromium.content_public.common.ContentUrlConstants; import org.chromium.net.test.EmbeddedTestServer; import java.util.concurrent.BlockingQueue; import java.util.concurrent.LinkedBlockingQueue; +import java.util.concurrent.TimeUnit; /** * Integration test to verify WebView's metrics implementation. This isn't a great spot to verify @@ -333,6 +335,30 @@ @Test @MediumTest @Feature({"AndroidWebView"}) + @OnlyRunIn(MULTI_PROCESS) // This functionality is specific to the OOP-renderer + public void testMetadata_stability_rendererCrashCount() throws Throwable { + TestAwContentsClient.RenderProcessGoneHelper helper = + mContentsClient.getRenderProcessGoneHelper(); + helper.setResponse(true); // Don't automatically kill the browser process. + + // Ensure that the renderer has started. + mRule.loadUrlSync(mAwContents, mContentsClient.getOnPageFinishedHelper(), + ContentUrlConstants.ABOUT_BLANK_DISPLAY_URL); + + // Crash the renderer and wait for onRenderProcessGone to be called. + int callCount = helper.getCallCount(); + mRule.loadUrlAsync(mAwContents, "chrome://crash"); + helper.waitForCallback( + callCount, 1, CallbackHelper.WAIT_TIMEOUT_SECONDS * 5, TimeUnit.SECONDS); + + Assert.assertEquals("Should have correct stability histogram kRendererCrash count", 1, + RecordHistogram.getHistogramValueCountForTesting( + "Stability.Counts2", StabilityEventType.RENDERER_CRASH)); + } + + @Test + @MediumTest + @Feature({"AndroidWebView"}) public void testMetadata_stability_browserLaunchCount() throws Throwable { // This should be triggered simply by initializing the MetricsService. This should be logged // (and persisted) even before we start collecting the first metrics log. @@ -468,7 +494,7 @@ @Test @MediumTest @Feature({"AndroidWebView"}) - @OnlyRunIn(MULTI_PROCESS) // This test is specific to the OOP-renderer + @OnlyRunIn(MULTI_PROCESS) // This functionality is specific to the OOP-renderer public void testRendererHistograms() throws Throwable { EmbeddedTestServer embeddedTestServer = EmbeddedTestServer.createAndStartServer( InstrumentationRegistry.getInstrumentation().getContext());
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java b/android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java index 03ef7cae..d2a18211 100644 --- a/android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java +++ b/android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java
@@ -9,6 +9,7 @@ import android.net.http.SslError; import org.chromium.android_webview.AwConsoleMessage; +import org.chromium.android_webview.AwRenderProcessGoneDetail; import org.chromium.base.Callback; import org.chromium.base.Log; import org.chromium.base.ThreadUtils; @@ -55,6 +56,7 @@ private final OnCreateWindowHelper mOnCreateWindowHelper; private final FaviconHelper mFaviconHelper; private final TouchIconHelper mTouchIconHelper; + private final RenderProcessGoneHelper mRenderProcessGoneHelper; public TestAwContentsClient() { super(ThreadUtils.getUiThreadLooper()); @@ -79,6 +81,7 @@ mOnCreateWindowHelper = new OnCreateWindowHelper(); mFaviconHelper = new FaviconHelper(); mTouchIconHelper = new TouchIconHelper(); + mRenderProcessGoneHelper = new RenderProcessGoneHelper(); mAllowSslError = true; } @@ -154,6 +157,10 @@ return mTouchIconHelper; } + public RenderProcessGoneHelper getRenderProcessGoneHelper() { + return mRenderProcessGoneHelper; + } + /** * Callback helper for onScaleChangedScaled. */ @@ -782,4 +789,37 @@ if (TRACE) Log.i(TAG, "onReceivedTouchIconUrl " + url); mTouchIconHelper.notifyTouchIcon(url, precomposed); } + + /** + * CallbackHelper for onRenderProcessGone. + */ + public static class RenderProcessGoneHelper extends CallbackHelper { + private AwRenderProcessGoneDetail mDetail; + private boolean mResponse; + + public AwRenderProcessGoneDetail getAwRenderProcessGoneDetail() { + assert getCallCount() > 0; + return mDetail; + } + + public void setResponse(boolean response) { + mResponse = response; + } + + /* package */ boolean getResponse() { + return mResponse; + } + + public void notifyCalled(AwRenderProcessGoneDetail detail) { + mDetail = detail; + notifyCalled(); + } + } + + @Override + public boolean onRenderProcessGone(AwRenderProcessGoneDetail detail) { + if (TRACE) Log.i(TAG, "onRenderProcessGone"); + mRenderProcessGoneHelper.notifyCalled(detail); + return mRenderProcessGoneHelper.getResponse(); + } }
diff --git a/android_webview/test/BUILD.gn b/android_webview/test/BUILD.gn index e1ecf1e..806932e 100644 --- a/android_webview/test/BUILD.gn +++ b/android_webview/test/BUILD.gn
@@ -490,6 +490,7 @@ "//base/test:test_support", "//components/autofill/core/browser", "//components/component_updater", + "//components/component_updater/android:embedded_component_loader", "//components/embedder_support/android:util", "//components/metrics", "//components/optimization_guide/core:bloomfilter", @@ -528,7 +529,6 @@ "../browser/lifecycle/aw_contents_lifecycle_notifier_unittest.cc", "../browser/metrics/aw_components_metrics_provider_unittests.cc", "../browser/metrics/aw_metrics_service_client_unittest.cc", - "../browser/metrics/aw_stability_metrics_provider_unittest.cc", "../browser/metrics/visibility_metrics_logger_unittest.cc", "../browser/permission/media_access_permission_request_unittest.cc", "../browser/permission/permission_request_handler_unittest.cc",
diff --git a/android_webview/test/browser/embedded_component_loader_test_helper.cc b/android_webview/test/browser/embedded_component_loader_test_helper.cc index 6058f104..cd70283f 100644 --- a/android_webview/test/browser/embedded_component_loader_test_helper.cc +++ b/android_webview/test/browser/embedded_component_loader_test_helper.cc
@@ -66,7 +66,7 @@ base::android::AttachCurrentThread()); } - void ComponentLoadFailed() override { + void ComponentLoadFailed(ComponentLoadError /*error*/) override { ExpectTrueToJava( false, "AvailableComponentLoaderPolicy#ComponentLoadFailed is called"); } @@ -90,7 +90,7 @@ false, "UnavailableComponentLoaderPolicy#ComponentLoaded is called"); } - void ComponentLoadFailed() override { + void ComponentLoadFailed(ComponentLoadError /*error*/) override { Java_EmbeddedComponentLoaderTest_onComponentLoadFailed( base::android::AttachCurrentThread()); }
diff --git a/ash/webui/common/resources/navigation_view_panel.html b/ash/webui/common/resources/navigation_view_panel.html index 033bbe7..9110c0f 100644 --- a/ash/webui/common/resources/navigation_view_panel.html +++ b/ash/webui/common/resources/navigation_view_panel.html
@@ -17,6 +17,7 @@ <navigation-selector menu-items={{menuItems_}} selected-item={{selectedItem}}> </navigation-selector> + <slot name="bottom-nav-content"></slot> </div> <div id="navigationBody" class="right-aligned"></div>
diff --git a/ash/webui/diagnostics_ui/resources/BUILD.gn b/ash/webui/diagnostics_ui/resources/BUILD.gn index f2ef5cb..42d3d32 100644 --- a/ash/webui/diagnostics_ui/resources/BUILD.gn +++ b/ash/webui/diagnostics_ui/resources/BUILD.gn
@@ -27,6 +27,7 @@ ":fake_system_data_provider", ":fake_system_routine_controller", ":input_list", + ":ip_config_info_drawer", ":memory_card", ":mojo_interface_provider", ":mojo_utils", @@ -171,6 +172,13 @@ ] } +js_library("ip_config_info_drawer") { + deps = [ + ":diagnostics_types", + "//third_party/polymer/v3_0/components-chromium/polymer:polymer_bundled", + ] +} + js_library("memory_card") { deps = [ ":data_point", @@ -324,6 +332,7 @@ "ethernet_info.js", "icons.js", "input_list.js", + "ip_config_info_drawer.js", "memory_card.js", "network_card.js", "network_info.js",
diff --git a/ash/webui/diagnostics_ui/resources/diagnostics_app.html b/ash/webui/diagnostics_ui/resources/diagnostics_app.html index 84ea16f..442d4a0 100644 --- a/ash/webui/diagnostics_ui/resources/diagnostics_app.html +++ b/ash/webui/diagnostics_ui/resources/diagnostics_app.html
@@ -1,8 +1,22 @@ <style include="cr-shared-style diagnostics-shared diagnostics-fonts"> + #toast { + bottom: 0; + left: 0; + } </style> <div id="diagnosticsAppContainer"> <navigation-view-panel hidden$="[[!showNavPanel_]]" id="navigationPanel"> + <div slot="bottom-nav-content" class="session-log-container"> + <cr-button on-click="onSessionLogClick_" class="session-log-button" + hidden="[[!isLoggedIn_]]"> + <iron-icon icon="diagnostics:download" id="download-icon"></iron-icon> + <span>[[i18n('sessionLog')]]</span> + </cr-button> + </div> </navigation-view-panel> <system-page hidden$="[[showNavPanel_]]"></system-page> + <cr-toast id="toast" duration="2500"> + <span>[[toastText_]]</span> + </cr-toast> </div>
diff --git a/ash/webui/diagnostics_ui/resources/diagnostics_app.js b/ash/webui/diagnostics_ui/resources/diagnostics_app.js index a6a3ef1..5c55a68e 100644 --- a/ash/webui/diagnostics_ui/resources/diagnostics_app.js +++ b/ash/webui/diagnostics_ui/resources/diagnostics_app.js
@@ -3,6 +3,7 @@ // found in the LICENSE file. import 'chrome://resources/ash/common/navigation_view_panel.js'; +import 'chrome://resources/cr_elements/cr_toast/cr_toast.m.js'; import './input_list.js'; import './network_list.js'; import './strings.m.js'; @@ -12,6 +13,8 @@ import {loadTimeData} from 'chrome://resources/js/load_time_data.m.js'; import {html, Polymer} from 'chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js'; +import {DiagnosticsBrowserProxy, DiagnosticsBrowserProxyImpl} from './diagnostics_browser_proxy.js'; + /** * @fileoverview * 'diagnostics-app' is responsible for displaying the 'system-page' which is @@ -25,6 +28,9 @@ behaviors: [I18nBehavior], + /** @private {?DiagnosticsBrowserProxy} */ + browserProxy_: null, + properties: { /** @private {boolean} */ showNavPanel_: { @@ -43,6 +49,18 @@ type: Boolean, value: loadTimeData.getBoolean('isInputEnabled'), }, + + /** @private {string} */ + toastText_: { + type: String, + value: '', + }, + }, + + /** @override */ + created() { + this.browserProxy_ = DiagnosticsBrowserProxyImpl.getInstance(); + this.browserProxy_.initialize(); }, /** @private */ @@ -68,4 +86,17 @@ } } }, + + /** @protected */ + onSessionLogClick_() { + this.browserProxy_.saveSessionLog() + .then( + /* @type {boolean} */ (success) => { + const result = success ? 'Success' : 'Failure'; + this.toastText_ = + loadTimeData.getString(`sessionLogToastText${result}`); + this.$.toast.show(); + }) + .catch(() => {/* File selection cancelled */}); + }, });
diff --git a/ash/webui/diagnostics_ui/resources/diagnostics_app_resources.grd b/ash/webui/diagnostics_ui/resources/diagnostics_app_resources.grd index 89ee734..1fa805e 100644 --- a/ash/webui/diagnostics_ui/resources/diagnostics_app_resources.grd +++ b/ash/webui/diagnostics_ui/resources/diagnostics_app_resources.grd
@@ -33,6 +33,7 @@ <include name="IDR_DIAGNOSTICS_ICONS_JS" file="${root_gen_dir}/ash/webui/diagnostics_ui/resources/icons.js" resource_path="icons.js" use_base_dir="false" type="BINDATA"/> <include name="IDR_DIAGNOSTICS_INPUT_DATA_PROVIDER_MOJO_LITE_JS" file="${root_gen_dir}/ash/webui/diagnostics_ui/mojom/input_data_provider.mojom-lite.js" resource_path="input_data_provider.mojom-lite.js" use_base_dir="false" type="BINDATA" /> <include name="IDR_DIAGNOSTICS_INPUT_LIST_JS" file="${root_gen_dir}/ash/webui/diagnostics_ui/resources/input_list.js" resource_path="input_list.js" use_base_dir="false" type="BINDATA"/> + <include name="IDR_DIAGNOSTICS_IP_CONFIG_INFO_DRAWER_JS" file="${root_gen_dir}/ash/webui/diagnostics_ui/resources/ip_config_info_drawer.js" resource_path="ip_config_info_drawer.js" use_base_dir="false" type="BINDATA"/> <include name="IDR_DIAGNOSTICS_MEMORY_CARD_JS" file="${root_gen_dir}/ash/webui/diagnostics_ui/resources/memory_card.js" resource_path="memory_card.js" use_base_dir="false" type="BINDATA"/> <include name="IDR_DIAGNOSTICS_MOJO_INTERFACE_PROVIDER_JS" file="mojo_interface_provider.js" type="BINDATA"/> <include name="IDR_DIAGNOSTICS_MOJO_UTILS_JS" file="mojo_utils.js" type="BINDATA"/>
diff --git a/ash/webui/diagnostics_ui/resources/ip_config_info_drawer.html b/ash/webui/diagnostics_ui/resources/ip_config_info_drawer.html new file mode 100644 index 0000000..2e95ca3 --- /dev/null +++ b/ash/webui/diagnostics_ui/resources/ip_config_info_drawer.html
@@ -0,0 +1,3 @@ +<style include="diagnostics-shared diagnostics-fonts"> +</style> +<div id="ipConfigInfoElement"></div>
diff --git a/ash/webui/diagnostics_ui/resources/ip_config_info_drawer.js b/ash/webui/diagnostics_ui/resources/ip_config_info_drawer.js new file mode 100644 index 0000000..b9601b5 --- /dev/null +++ b/ash/webui/diagnostics_ui/resources/ip_config_info_drawer.js
@@ -0,0 +1,21 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +import './diagnostics_fonts_css.js'; +import './diagnostics_shared_css.js'; + +import {html, Polymer} from 'chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js'; + +/** + * @fileoverview + * 'ip-config-info-drawer' displays standard IP related configuration data in a + * collapsible drawer. + */ +Polymer({ + is: 'ip-config-info-drawer', + + _template: html`{__html_template__}`, + + properties: {}, +});
diff --git a/ash/webui/diagnostics_ui/resources/system_page.html b/ash/webui/diagnostics_ui/resources/system_page.html index 48788f2..d369455 100644 --- a/ash/webui/diagnostics_ui/resources/system_page.html +++ b/ash/webui/diagnostics_ui/resources/system_page.html
@@ -98,13 +98,15 @@ </memory-card> </div> </div> - <div class="session-log-container"> - <cr-button on-click="onSessionLogClick_" class="session-log-button" - hidden="[[!isLoggedIn_]]"> - <iron-icon icon="diagnostics:download" id="download-icon"></iron-icon> - <span>[[i18n('sessionLog')]]</span> - </cr-button> - </div> + <template is="dom-if" if="[[showSessionLogButton]]"> + <div class="session-log-container"> + <cr-button on-click="onSessionLogClick_" class="session-log-button" + hidden="[[!isLoggedIn_]]"> + <iron-icon icon="diagnostics:download" id="download-icon"></iron-icon> + <span>[[i18n('sessionLog')]]</span> + </cr-button> + </div> + </template> <cr-toast id="toast" duration="2500"> <span>[[toastText_]]</span> </cr-toast>
diff --git a/ash/webui/diagnostics_ui/resources/system_page.js b/ash/webui/diagnostics_ui/resources/system_page.js index c7be4a2..5d087c8 100644 --- a/ash/webui/diagnostics_ui/resources/system_page.js +++ b/ash/webui/diagnostics_ui/resources/system_page.js
@@ -99,6 +99,12 @@ type: Boolean, value: true, }, + + /** @type {boolean} */ + showSessionLogButton: { + type: Boolean, + value: !loadTimeData.getBoolean('isNetworkingEnabled'), + }, }, /** @override */
diff --git a/ash/wm/workspace/phantom_window_controller.cc b/ash/wm/workspace/phantom_window_controller.cc index a52db50..6cc9d95e 100644 --- a/ash/wm/workspace/phantom_window_controller.cc +++ b/ash/wm/workspace/phantom_window_controller.cc
@@ -90,6 +90,9 @@ if (phantom_widget_window->parent() == window_->parent()) { phantom_widget_window->parent()->StackChildAbove(phantom_widget_window, window_); + } else { + // Ensure the phantom and its shadow do not cover the shelf. + phantom_widget_window->parent()->StackChildAtBottom(phantom_widget_window); } ui::Layer* widget_layer = phantom_widget_window->layer(); widget_layer->SetColor(SkColorSetA(SK_ColorWHITE, 0.4 * 255));
diff --git a/base/allocator/partition_allocator/partition_root.h b/base/allocator/partition_allocator/partition_root.h index 228f5fa..809cbfcc 100644 --- a/base/allocator/partition_allocator/partition_root.h +++ b/base/allocator/partition_allocator/partition_root.h
@@ -1009,6 +1009,38 @@ template <bool thread_safe> ALWAYS_INLINE void PartitionRoot<thread_safe>::RawFree(void* slot_start, SlotSpan* slot_span) { + // At this point we are about to acquire the lock, so we try to minimize the + // risk of blocking inside the locked section. + // + // For allocations that are not direct-mapped, there will always be a store at + // the beginning of |*slot_start|, to link the freelist. This is why there is + // a prefetch of it at the beginning of the free() path. + // + // However, the memory which is being freed can be very cold (for instance + // during browser shutdown, when various caches are finally completely freed), + // and so moved to either compressed memory or swap. This means that touching + // it here can cause a major page fault. This is in turn will cause + // descheduling of the thread *while locked*. Since we don't have priority + // inheritance locks on most platforms, avoiding long locked periods relies on + // the OS having proper priority boosting. There is evidence + // (crbug.com/1228523) that this is not always the case on Windows, and a very + // low priority background thread can block the main one for a long time, + // leading to hangs. + // + // To mitigate that, make sure that we fault *before* locking. Note that this + // is useless for direct-mapped allocations (which are very rare anyway), and + // that this path is *not* taken for thread cache bucket purge (since it calls + // RawFreeLocked()). This is intentional, as the thread cache is purged often, + // and the memory has a consequence the memory has already been touched + // recently (to link the thread cache freelist). + *reinterpret_cast<volatile uintptr_t*>(slot_start) = 0; + // Note: even though we write to slot_start + sizeof(void*) as well, due to + // alignment constraints, the two locations are always going to be in the same + // OS page. No need to write to the second one as well. + // + // Do not move the store above inside the locked section. + __asm__ __volatile__("" : : "r"(slot_start) : "memory"); + internal::DeferredUnmap deferred_unmap; { ScopedGuard guard{lock_};
diff --git a/base/sampling_heap_profiler/sampling_heap_profiler_unittest.cc b/base/sampling_heap_profiler/sampling_heap_profiler_unittest.cc index 02bba74..54f2cbb1a 100644 --- a/base/sampling_heap_profiler/sampling_heap_profiler_unittest.cc +++ b/base/sampling_heap_profiler/sampling_heap_profiler_unittest.cc
@@ -289,19 +289,7 @@ EXPECT_EQ(0, GetRunningSessionsCount()); } -// TODO(crbug.com/1116543): When this was part of StartStop, the whole test was -// flaky on Mac. If StartStop continues to flake, the problem is probably in -// PoissonAllocationSampler::InstallAllocatorHooksOnce, which runs on the first -// call to SamplingHeapProfiler::Start. Otherwise, try re-enabling this part -// too to see if it's still flaky; if so, the problem is probably due to -// `thread` and the main thread both calling RunStartStopLoop and contending -// over some shared resource. -#if defined(OS_MAC) -#define MAYBE_ConcurrentStartStop DISABLED_ConcurrentStartStop -#else -#define MAYBE_ConcurrentStartStop ConcurrentStartStop -#endif -TEST_F(SamplingHeapProfilerTest, MAYBE_ConcurrentStartStop) { +TEST_F(SamplingHeapProfilerTest, ConcurrentStartStop) { auto* profiler = SamplingHeapProfiler::Get(); WaitableEvent event; StartStopThread thread(&event);
diff --git a/base/threading/hang_watcher.cc b/base/threading/hang_watcher.cc index 1ec97ec..c88adfc 100644 --- a/base/threading/hang_watcher.cc +++ b/base/threading/hang_watcher.cc
@@ -137,10 +137,6 @@ return; } - DCHECK(current_hang_watch_state) - << "WatchHangsInScope can only be used on a thread that " - "registered for hang watching with HangWatcher::RegisterThread."; - #if DCHECK_IS_ON() previous_watch_hangs_in_scope_ = current_hang_watch_state->GetCurrentWatchHangsInScope(); @@ -152,25 +148,6 @@ std::tie(old_flags, old_deadline) = current_hang_watch_state->GetFlagsAndDeadline(); - const bool hangs_ignored_for_current_scope = - internal::HangWatchDeadline::IsFlagSet( - internal::HangWatchDeadline::Flag::kIgnoreCurrentWatchHangsInScope, - old_flags); - - const bool has_active_hang_watch_disabled = - internal::HangWatchDeadline::IsFlagSet( - internal::HangWatchDeadline::Flag::kHasActiveIgnoreHangsInScope, - old_flags); - - // If the current WatchHangsInScope is ignored but there are no active - // IgnoreHangsInScope instances, temporarily reactivate hang watching for - // this newly created WatchHangsInScope. On exiting hang watching is - // suspended again to return to the original state. - if (hangs_ignored_for_current_scope && !has_active_hang_watch_disabled) { - current_hang_watch_state->UnsetIgnoreCurrentWatchHangsInScope(); - set_hangs_ignored_on_exit_ = true; - } - // TODO(crbug.com/1034046): Check whether we are over deadline already for the // previous WatchHangsInScope here by issuing only one TimeTicks::Now() // and resuing the value. @@ -179,6 +156,19 @@ TimeTicks deadline = TimeTicks::Now() + timeout; current_hang_watch_state->SetDeadline(deadline); current_hang_watch_state->IncrementNestingLevel(); + + const bool hangs_ignored_for_current_scope = + internal::HangWatchDeadline::IsFlagSet( + internal::HangWatchDeadline::Flag::kIgnoreCurrentWatchHangsInScope, + old_flags); + + // If the current WatchHangsInScope is ignored, temporarily reactivate hang + // watching for newly created WatchHangsInScopes. On exiting hang watching + // is suspended again to return to the original state. + if (hangs_ignored_for_current_scope) { + current_hang_watch_state->UnsetIgnoreCurrentWatchHangsInScope(); + set_hangs_ignored_on_exit_ = true; + } } WatchHangsInScope::~WatchHangsInScope() { @@ -212,19 +202,18 @@ previous_watch_hangs_in_scope_); #endif - // If a IgnoreHangsInScope suspended hang watching during the - // lifetime of this or any nested WatchHangsInScope it can now safely be - // reactivated by clearing the ignore bit since this is the outer-most scope. - // See IgnoreHangsInScope class comments where this represents the - // destruction of |scope_1|. - if (current_hang_watch_state->nesting_level() == 1) + if (current_hang_watch_state->nesting_level() == 1) { + // If a call to InvalidateActiveExpectations() suspended hang watching + // during the lifetime of this or any nested WatchHangsInScope it can now + // safely be reactivated by clearing the ignore bit since this is the + // outer-most scope. current_hang_watch_state->UnsetIgnoreCurrentWatchHangsInScope(); - // Return to ignoring hangs since this was the previous state before hang - // watching was temporarily enabled for this WatchHangsInScope only in the - // constructor. See IgnoreHangsInScope class comments where the next line - // of code is part of the destruction of |scope_4|. - else if (set_hangs_ignored_on_exit_) + } else if (set_hangs_ignored_on_exit_) { + // Return to ignoring hangs since this was the previous state before hang + // watching was temporarily enabled for this WatchHangsInScope only in the + // constructor. current_hang_watch_state->SetIgnoreCurrentWatchHangsInScope(); + } // Reset the deadline to the value it had before entering this // WatchHangsInScope. @@ -235,49 +224,6 @@ current_hang_watch_state->DecrementNestingLevel(); } -IgnoreHangsInScope::IgnoreHangsInScope() { - internal::HangWatchState* current_hang_watch_state = - internal::HangWatchState::GetHangWatchStateForCurrentThread()->Get(); - if (!current_hang_watch_state) { - took_effect_ = false; - return; - } - - uint64_t old_flags; - base::TimeTicks old_deadline; - std::tie(old_flags, old_deadline) = - current_hang_watch_state->GetFlagsAndDeadline(); - - // If there already is an active IgnoreHangsInScope. - const bool has_active_hang_watch_disabled = - internal::HangWatchDeadline::IsFlagSet( - internal::HangWatchDeadline::Flag::kHasActiveIgnoreHangsInScope, - old_flags); - - if (has_active_hang_watch_disabled) { - took_effect_ = false; - return; - } - - current_hang_watch_state->SetIgnoreCurrentWatchHangsInScope(); - current_hang_watch_state->SetHasActiveIgnoreHangsInScope(); -} - -IgnoreHangsInScope::~IgnoreHangsInScope() { - internal::HangWatchState* current_hang_watch_state = - internal::HangWatchState::GetHangWatchStateForCurrentThread()->Get(); - - if (!current_hang_watch_state || !took_effect_) - return; - - // If this instance outlived all WatchHangsInScope instances watching - // needs to be reactivated. - if (current_hang_watch_state->nesting_level() == 0) - current_hang_watch_state->UnsetIgnoreCurrentWatchHangsInScope(); - - current_hang_watch_state->UnsetHasActiveIgnoreHangsInScope(); -} - // static void HangWatcher::InitializeOnMainThread() { DCHECK(!g_use_hang_watcher); @@ -350,6 +296,17 @@ return false; } +// static +void HangWatcher::InvalidateActiveExpectations() { + internal::HangWatchState* current_hang_watch_state = + internal::HangWatchState::GetHangWatchStateForCurrentThread()->Get(); + if (!current_hang_watch_state) { + // If the current thread is not under watch there is nothing to invalidate. + return; + } + current_hang_watch_state->SetIgnoreCurrentWatchHangsInScope(); +} + HangWatcher::HangWatcher() : monitor_period_(kMonitoringPeriod), should_monitor_(WaitableEvent::ResetPolicy::AUTOMATIC), @@ -842,9 +799,7 @@ constexpr uint64_t kPersistentFlagsAndDeadlineMask = kOnlyDeadlineMask | static_cast<uint64_t>( - HangWatchDeadline::Flag::kIgnoreCurrentWatchHangsInScope) | - static_cast<uint64_t>( - HangWatchDeadline::Flag::kHasActiveIgnoreHangsInScope); + HangWatchDeadline::Flag::kIgnoreCurrentWatchHangsInScope); } // namespace // Flag binary representation assertions. @@ -931,14 +886,6 @@ std::memory_order_relaxed); } -void HangWatchDeadline::SetHasActiveIgnoreHangsInScope() { - SetPersistentFlag(Flag::kHasActiveIgnoreHangsInScope); -} - -void HangWatchDeadline::UnsetHasActiveIgnoreHangsInScope() { - ClearPersistentFlag(Flag::kHasActiveIgnoreHangsInScope); -} - void HangWatchDeadline::SetIgnoreCurrentWatchHangsInScope() { SetPersistentFlag(Flag::kIgnoreCurrentWatchHangsInScope); } @@ -1070,14 +1017,6 @@ return TimeTicks::Now() > deadline_.GetDeadline(); } -void HangWatchState::SetHasActiveIgnoreHangsInScope() { - deadline_.SetHasActiveIgnoreHangsInScope(); -} - -void HangWatchState::UnsetHasActiveIgnoreHangsInScope() { - deadline_.UnsetHasActiveIgnoreHangsInScope(); -} - void HangWatchState::SetIgnoreCurrentWatchHangsInScope() { deadline_.SetIgnoreCurrentWatchHangsInScope(); }
diff --git a/base/threading/hang_watcher.h b/base/threading/hang_watcher.h index f81574c..a8803645 100644 --- a/base/threading/hang_watcher.h +++ b/base/threading/hang_watcher.h
@@ -85,11 +85,9 @@ // destroyed. TimeTicks previous_deadline_; - // Indicates whether the kIgnoreCurrentHang flag must be set upon exiting this - // WatchHangsInScope. This is true if the - // kIgnoreCurrentWatchHangsInScope flag was set upon entering this scope, - // but was cleared for this WatchHangsInScope because there was no active - // IgnoreHangsInScope. + // Indicates whether the kIgnoreCurrentWatchHangsInScope flag must be set upon + // exiting this WatchHangsInScope if a call to InvalidateActiveExpectations() + // previously suspended hang watching. bool set_hangs_ignored_on_exit_ = false; #if DCHECK_IS_ON() @@ -98,46 +96,6 @@ #endif }; -// Scoped object that disables hang watching on the thread. The object nullifies -// the effect of all live WatchHangsInScope instances and also that of new -// WatchHangsInScope instances created during its lifetime. Use to avoid -// capturing hangs for operations known to take unbounded time like waiting for -// user input. This does not unregister the thread so when this object is -// destroyed hang watching resumes for new WatchHangsInScopes. -// -// Example usage: -// { -// WatchHangsInScope scope_1; -// { -// WatchHangsInScope scope_2; -// IgnoreHangsInScope disabler; -// WaitForUserInput(); -// WatchHangsInScope scope_3; -// } -// -// WatchHangsInScope scope_4; -// } -// -// WatchHangsInScope scope_5; -// -// In this example hang watching is disabled for WatchHangsInScopes 1, 2 and -// 3 since they were either active at the time of the |disabler|'s creation or -// created while the disabler was still active. WatchHangsInScopes 4 and 5 -// are unaffected since they were created after the disabler was destroyed. -// -class BASE_EXPORT IgnoreHangsInScope { - public: - IgnoreHangsInScope(); - ~IgnoreHangsInScope(); - IgnoreHangsInScope(const IgnoreHangsInScope&) = delete; - IgnoreHangsInScope& operator=(const IgnoreHangsInScope&) = delete; - - private: - // Will be true if the object actually disabled hang watching and - // false if watching was already disabled by a previously declared object. - bool took_effect_ = true; -}; - // Monitors registered threads for hangs by inspecting their associated // HangWatchStates for deadline overruns. This happens at a regular interval on // a separate thread. Only one instance of HangWatcher can exist at a time @@ -185,6 +143,32 @@ // Returns true if crash dump reporting is configured for any thread type. static bool IsCrashReportingEnabled(); + // Use to avoid capturing hangs for operations known to take unbounded time + // like waiting for user input. WatchHangsInScope objects created after this + // call will take effect. To resume watching for hangs create a new + // WatchHangsInScope after the unbounded operation finishes. + // + // Example usage: + // { + // WatchHangsInScope scope_1; + // { + // WatchHangsInScope scope_2; + // InvalidateActiveExpectations(); + // WaitForUserInput(); + // } + // + // WatchHangsInScope scope_4; + // } + // + // WatchHangsInScope scope_5; + // + // In this example hang watching is disabled for WatchHangsInScopes 1 and 2 + // since they were both active at the time of the invalidation. + // WatchHangsInScopes 4 and 5 are unaffected since they were created after the + // end of the WatchHangsInScope that was current at the time of invalidation. + // + static void InvalidateActiveExpectations(); + // Sets up the calling thread to be monitored for threads. Returns a // ScopedClosureRunner that unregisters the thread. This closure has to be // called from the registered thread before it's joined. Returns a null @@ -399,13 +383,10 @@ enum class Flag : uint64_t { // Minimum value for validation purposes. Not currently used. kMinValue = bits::LeftmostBit<uint64_t>() >> 7, - // Persistent because control by the lifetime of IgnoreHangsInScope. - kHasActiveIgnoreHangsInScope = bits::LeftmostBit<uint64_t>() >> 2, // Persistent because if hang detection is disabled on a thread it should // be re-enabled manually. kIgnoreCurrentWatchHangsInScope = bits::LeftmostBit<uint64_t>() >> 1, - // Non-persistent because a new value means a new WatchHangsInScope - // started + // Non-persistent because a new value means a new WatchHangsInScope started // after the beginning of capture. It can't be implicated in the hang so we // don't want it to block. kShouldBlockOnHang = bits::LeftmostBit<uint64_t>() >> 0, @@ -450,12 +431,6 @@ // not set the flag and returns false. bool SetShouldBlockOnHang(uint64_t old_flags, TimeTicks old_deadline); - // Sets the kHasActiveIgnoreHangsInScope flag. - void SetHasActiveIgnoreHangsInScope(); - - // Clears the kHasActiveIgnoreHangsInScope flag. - void UnsetHasActiveIgnoreHangsInScope(); - // Sets the kIgnoreCurrentWatchHangsInScope flag. void SetIgnoreCurrentWatchHangsInScope(); @@ -580,22 +555,14 @@ // Sets the deadline to a new value. void SetDeadline(TimeTicks deadline); - // Mark this thread as ignored for hang watching. This means existing hang - // watch will not trigger hangs. + // Mark this thread as ignored for hang watching. This means existing + // WatchHangsInScope will not trigger hangs. void SetIgnoreCurrentWatchHangsInScope(); // Reactivate hang watching on this thread. Should be called when all // WatchHangsInScope instances that were ignored have completed. void UnsetIgnoreCurrentWatchHangsInScope(); - // Mark hang watching as disabled on this thread. This means new - // WatchHangsInScope instances will not trigger hangs. - void SetHasActiveIgnoreHangsInScope(); - - // Reactivate hang watching on this thread. New WatchHangsInScope - // instances will trigger hangs. - void UnsetHasActiveIgnoreHangsInScope(); - // Mark the current state as having to block in its destruction until hang // capture completes. bool SetShouldBlockOnHang(uint64_t old_flags, TimeTicks old_deadline);
diff --git a/base/threading/hang_watcher_unittest.cc b/base/threading/hang_watcher_unittest.cc index c627a17..b2aa359 100644 --- a/base/threading/hang_watcher_unittest.cc +++ b/base/threading/hang_watcher_unittest.cc
@@ -206,35 +206,88 @@ }; } // namespace -// Regression test for crbug.com/1196285 -TEST_F(HangWatcherTest, MultipleIgnoreHangsInScopeDoNotCancelOut) { +TEST_F(HangWatcherTest, InvalidatingExpectationsPreventsCapture) { // Register the main test thread for hang watching. auto unregister_thread_closure = HangWatcher::RegisterThread(base::HangWatcher::ThreadType::kUIThread); - // De-activate hang watching, - IgnoreHangsInScope disabler; - - { - // Redundently de-activate hang watching. - IgnoreHangsInScope disabler_2; - } - // Create a hang. WatchHangsInScope expires_instantly(base::TimeDelta{}); task_environment_.FastForwardBy(kHangTime); + // de-activate hang watching, + base::HangWatcher::InvalidateActiveExpectations(); + // Trigger a monitoring on HangWatcher thread and verify results. - // Hang is not detected since it was covered by a disabler object. The - // creation and destruction of |disabler_2| should not affect that. + // Hang is not detected. hang_watcher_.SignalMonitorEventForTesting(); monitor_event_.Wait(); ASSERT_FALSE(hang_event_.IsSignaled()); } -TEST_F( - HangWatcherTest, - ScopeDisabledCreateScopeDisabledDestroyScopeEnabledCreateScopeEnabledDestroy) { +TEST_F(HangWatcherTest, MultipleInvalidateExpectationsDoNotCancelOut) { + // Register the main test thread for hang watching. + auto unregister_thread_closure = + HangWatcher::RegisterThread(base::HangWatcher::ThreadType::kUIThread); + + // Create a hang. + WatchHangsInScope expires_instantly(base::TimeDelta{}); + task_environment_.FastForwardBy(kHangTime); + + // de-activate hang watching, + base::HangWatcher::InvalidateActiveExpectations(); + + // Redundently de-activate hang watching. + base::HangWatcher::InvalidateActiveExpectations(); + + // Trigger a monitoring on HangWatcher thread and verify results. + // Hang is not detected. + hang_watcher_.SignalMonitorEventForTesting(); + monitor_event_.Wait(); + ASSERT_FALSE(hang_event_.IsSignaled()); +} + +TEST_F(HangWatcherTest, NewInnerWatchHangsInScopeAfterInvalidationDetectsHang) { + // Register the main test thread for hang watching. + auto unregister_thread_closure = + HangWatcher::RegisterThread(base::HangWatcher::ThreadType::kUIThread); + + WatchHangsInScope expires_instantly(base::TimeDelta{}); + task_environment_.FastForwardBy(kHangTime); + + // De-activate hang watching. + base::HangWatcher::InvalidateActiveExpectations(); + + { + WatchHangsInScope also_expires_instantly(base::TimeDelta{}); + task_environment_.FastForwardBy(kHangTime); + + // Trigger a monitoring on HangWatcher thread and verify results. + hang_watcher_.SignalMonitorEventForTesting(); + monitor_event_.Wait(); + + // Hang is detected since the new WatchHangsInScope temporarily + // re-activated hang_watching. + monitor_event_.Wait(); + ASSERT_TRUE(hang_event_.IsSignaled()); + } + + // Reset to attempt capture again. + monitor_event_.Reset(); + hang_event_.Reset(); + + // Trigger a monitoring on HangWatcher thread and verify results. + hang_watcher_.SignalMonitorEventForTesting(); + monitor_event_.Wait(); + + // Hang is not detected since execution is back to being covered by + // |expires_instantly| for which expectations were invalidated. + monitor_event_.Wait(); + ASSERT_FALSE(hang_event_.IsSignaled()); +} + +TEST_F(HangWatcherTest, + NewSeparateWatchHangsInScopeAfterInvalidationDetectsHang) { // Register the main test thread for hang watching. auto unregister_thread_closure = HangWatcher::RegisterThread(base::HangWatcher::ThreadType::kUIThread); @@ -243,8 +296,8 @@ WatchHangsInScope expires_instantly(base::TimeDelta{}); task_environment_.FastForwardBy(kHangTime); - // De-activate hang watching, - IgnoreHangsInScope disabler; + // De-activate hang watching. + base::HangWatcher::InvalidateActiveExpectations(); } WatchHangsInScope also_expires_instantly(base::TimeDelta{}); @@ -254,162 +307,28 @@ hang_watcher_.SignalMonitorEventForTesting(); monitor_event_.Wait(); - // Hang is detected since the new WatchHangsInScope was not covered by the - // disabler. + // Hang is detected since the new WatchHangsInScope did not have its + // expectations invalidated. monitor_event_.Wait(); ASSERT_TRUE(hang_event_.IsSignaled()); } -TEST_F( - HangWatcherTest, - ScopeEnabledCreateScopeDisabledCreateScopeEnabledDestroyScopeDisabledDestroy) { - // Register the main test thread for hang watching. - auto unregister_thread_closure = - HangWatcher::RegisterThread(base::HangWatcher::ThreadType::kUIThread); - - absl::optional<IgnoreHangsInScope> disabler; - - // De-activate hang watching, - { - // Start a WatchHangsInScope that expires right away. Then advance - // time to make sure a hang is detected. - WatchHangsInScope expires_instantly(base::TimeDelta{}); - task_environment_.FastForwardBy(kHangTime); - - disabler.emplace(); - - // Trigger a monitoring on HangWatcher thread and verify results. - hang_watcher_.SignalMonitorEventForTesting(); - monitor_event_.Wait(); - } - - disabler.reset(); - - // Hang is ignored since a disabler was live during the lifetime of the hung - // WatchHangsInScope. - ASSERT_FALSE(hang_event_.IsSignaled()); -} - -TEST_F( - HangWatcherTest, - ScopeDisabledCreateScopeEnabledCreateScopeDisabledDestroyScopeEnabledDestroy) { - // Register the main test thread for hang watching. - auto unregister_thread_closure = - HangWatcher::RegisterThread(base::HangWatcher::ThreadType::kUIThread); - - absl::optional<IgnoreHangsInScope> disabler; - - // De-activate hang watching, - { - disabler.emplace(); - - // Start a WatchHangsInScope that expires right away. Then advance - // time to make sure a hang is detected. - WatchHangsInScope expires_instantly(base::TimeDelta{}); - task_environment_.FastForwardBy(kHangTime); - - disabler.reset(); - - // Trigger a monitoring on HangWatcher thread and verify results. - hang_watcher_.SignalMonitorEventForTesting(); - monitor_event_.Wait(); - } - - // Hang is ignored since a disabler was live during the lifetime of the hung - // WatchHangsInScope. - ASSERT_FALSE(hang_event_.IsSignaled()); -} - -TEST_F( - HangWatcherTest, - ScopeDisabledCreateScopeEnabledCreateScopeEnabledDestroyScopeDisabledDestroy) { - // Register the main test thread for hang watching. - auto unregister_thread_closure = - HangWatcher::RegisterThread(base::HangWatcher::ThreadType::kUIThread); - - // De-activate hang watching, - IgnoreHangsInScope disabler; - { - // Start a WatchHangsInScope that expires right away. Then advance - // time to make sure a hang is detected. - WatchHangsInScope expires_instantly(base::TimeDelta{}); - task_environment_.FastForwardBy(kHangTime); - - // Trigger a monitoring on HangWatcher thread and verify results. - hang_watcher_.SignalMonitorEventForTesting(); - monitor_event_.Wait(); - } - - // Hang is ignored. - ASSERT_FALSE(hang_event_.IsSignaled()); -} - -TEST_F(HangWatcherTest, ScopeCreateTempCreateTempDestroyScopeDestroy) { - // Register the main test thread for hang watching. - auto unregister_thread_closure = - HangWatcher::RegisterThread(base::HangWatcher::ThreadType::kUIThread); - { - // Start a WatchHangsInScope that expires right away. Then advance - // time to make sure a hang is detected. - WatchHangsInScope expires_instantly(base::TimeDelta{}); - task_environment_.FastForwardBy(kHangTime); - - { - // De-activate hang watching, - IgnoreHangsInScope disabler; - } - - // Trigger a monitoring on HangWatcher thread and verify results. - hang_watcher_.SignalMonitorEventForTesting(); - monitor_event_.Wait(); - } - - // Hang is ignored. - ASSERT_FALSE(hang_event_.IsSignaled()); -} - -TEST_F( - HangWatcherTest, - ScopeEnabledCreateScopeDisabledCreateScopeDisabledDestroyScopeEnabledDestroy) { - // Register the main test thread for hang watching. - auto unregister_thread_closure = - HangWatcher::RegisterThread(base::HangWatcher::ThreadType::kUIThread); - { - // Start a WatchHangsInScope that expires right away. Then advance - // time to make sure a hang is detected. - WatchHangsInScope expires_instantly(base::TimeDelta{}); - task_environment_.FastForwardBy(kHangTime); - - // De-activate hang watching, - IgnoreHangsInScope disabler; - - // Trigger a monitoring on HangWatcher thread and verify results. - hang_watcher_.SignalMonitorEventForTesting(); - monitor_event_.Wait(); - } - - // Hang is ignored. - ASSERT_FALSE(hang_event_.IsSignaled()); -} - -// Test that disabling an inner WatchHangsInScope will also prevent hang -// detection in outer scopes. +// Test that invalidating expectations from inner WatchHangsInScope will also +// prevent hang detection in outer scopes. TEST_F(HangWatcherTest, ScopeDisabledObjectInnerScope) { // Register the main test thread for hang watching. auto unregister_thread_closure = HangWatcher::RegisterThread(base::HangWatcher::ThreadType::kUIThread); // Start a WatchHangsInScope that expires right away. Then advance - // time to make sure a hang is detected. + // time to make sure no hang is detected. WatchHangsInScope expires_instantly(base::TimeDelta{}); task_environment_.FastForwardBy(kHangTime); { - // De-activate hang watching, - IgnoreHangsInScope disabler; - - // Start a WatchHangsInScope under the disabler that expires right away. - // Then advance time to make sure a hang is detected. WatchHangsInScope also_expires_instantly(base::TimeDelta{}); + + // De-activate hang watching. + base::HangWatcher::InvalidateActiveExpectations(); task_environment_.FastForwardBy(kHangTime); } @@ -428,19 +347,18 @@ HangWatcher::RegisterThread(base::HangWatcher::ThreadType::kUIThread); // Start a WatchHangsInScope that expires right away. Then advance - // time to make sure a hang is detected. + // time to make sure no hang is detected. WatchHangsInScope expires_instantly(base::TimeDelta{}); task_environment_.FastForwardBy(kHangTime); { - // De-activate hang watching, - IgnoreHangsInScope disabler; - - // Start a WatchHangsInScope under the disabler that expires right away. - // Then advance time to make sure a hang is detected. WatchHangsInScope also_expires_instantly(base::TimeDelta{}); + + // De-activate hang watching. + base::HangWatcher::InvalidateActiveExpectations(); task_environment_.FastForwardBy(kHangTime); } + // New scope for which expecations are never invalidated. WatchHangsInScope also_expires_instantly(base::TimeDelta{}); task_environment_.FastForwardBy(kHangTime); @@ -1082,10 +1000,9 @@ namespace internal { namespace { -constexpr std::array<HangWatchDeadline::Flag, 4> kAllFlags{ +constexpr std::array<HangWatchDeadline::Flag, 3> kAllFlags{ {HangWatchDeadline::Flag::kMinValue, HangWatchDeadline::Flag::kIgnoreCurrentWatchHangsInScope, - HangWatchDeadline::Flag::kHasActiveIgnoreHangsInScope, HangWatchDeadline::Flag::kShouldBlockOnHang}}; } // namespace
diff --git a/base/threading/thread_restrictions.cc b/base/threading/thread_restrictions.cc index 071d8d0..b4cf3c9 100644 --- a/base/threading/thread_restrictions.cc +++ b/base/threading/thread_restrictions.cc
@@ -294,6 +294,11 @@ base::trace_event::InternedSourceLocation::Get( &ctx, base::trace_event::TraceSourceLocation(from_here))); }); + + // Since this object is used to indicate that sync primitives will be used to + // wait for an event ignore the current operation for hang watching purposes + // since the wait time duration is unknown. + base::HangWatcher::InvalidateActiveExpectations(); } ScopedAllowBaseSyncPrimitivesOutsideBlockingScope::
diff --git a/base/threading/thread_restrictions.h b/base/threading/thread_restrictions.h index 70bf434b..5d28e0a 100644 --- a/base/threading/thread_restrictions.h +++ b/base/threading/thread_restrictions.h
@@ -609,11 +609,6 @@ std::unique_ptr<BooleanWithStack> was_disallowed_; #endif - // Since this object is used to indicate that sync primitives will be used to - // wait for an event ignore the current operation for hang watching purposes - // since the wait time duration is unknown. - base::IgnoreHangsInScope hang_watch_scope_disabled_; - DISALLOW_COPY_AND_ASSIGN(ScopedAllowBaseSyncPrimitivesOutsideBlockingScope); };
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn index e157ee9..5176e316 100644 --- a/build/config/compiler/BUILD.gn +++ b/build/config/compiler/BUILD.gn
@@ -2054,6 +2054,11 @@ "-fdata-sections", "-ffunction-sections", ] + if (!is_nacl && is_clang) { + # We don't care about unique section names, this makes object files a bit + # smaller. + common_optimize_on_cflags += [ "-fno-unique-section-names" ] + } common_optimize_on_ldflags += [ # Specifically tell the linker to perform optimizations.
diff --git a/build/fuchsia/linux.sdk.sha1 b/build/fuchsia/linux.sdk.sha1 index 76c3e9e..5ef0f9db 100644 --- a/build/fuchsia/linux.sdk.sha1 +++ b/build/fuchsia/linux.sdk.sha1
@@ -1 +1 @@ -5.20210715.1.1 +5.20210715.2.1
diff --git a/build/fuchsia/mac.sdk.sha1 b/build/fuchsia/mac.sdk.sha1 index 3eada5270..5ef0f9db 100644 --- a/build/fuchsia/mac.sdk.sha1 +++ b/build/fuchsia/mac.sdk.sha1
@@ -1 +1 @@ -5.20210715.0.1 +5.20210715.2.1
diff --git a/cc/scheduler/scheduler_unittest.cc b/cc/scheduler/scheduler_unittest.cc index c3ae694..169eb24 100644 --- a/cc/scheduler/scheduler_unittest.cc +++ b/cc/scheduler/scheduler_unittest.cc
@@ -4469,6 +4469,7 @@ ~SchedulerTestForPowerMode() override { DCHECK_EQ(this, current_test_); current_test_ = nullptr; + power_mode_arbiter_.RemoveObserver(&observer_); } void AdvanceToArbiterSnapAfter(base::TimeDelta delay) {
diff --git a/cc/trees/layer_tree_host_unittest.cc b/cc/trees/layer_tree_host_unittest.cc index b0e512c5..973fda1 100644 --- a/cc/trees/layer_tree_host_unittest.cc +++ b/cc/trees/layer_tree_host_unittest.cc
@@ -2751,6 +2751,17 @@ case 0: EXPECT_EQ(initial_local_surface_id_, host_impl->active_tree()->local_surface_id_from_parent()); + // Main creates a new |target_local_surface_id_| and posts it back to + // the Compositor thread in ChangeViewportRect. However if it is + // possible for a new Impl frame to start before the queued setting of + // |target_local_surface_id_| has been processed. So ignore those. + // + // The |source_frame_number| will not advance until a new tree has + // been committed. Which will not occur until we've passed here and + // called StopDeferringCommits. If the test times out there there is a + // bug in syncing the id. + if (!host_impl->target_local_surface_id().is_valid()) + return; EXPECT_EQ(target_local_surface_id_, host_impl->target_local_surface_id()); // On slower configurations more than one frame at the original
diff --git a/chrome/android/chrome_java_sources.gni b/chrome/android/chrome_java_sources.gni index 24c6291..a03f50e 100644 --- a/chrome/android/chrome_java_sources.gni +++ b/chrome/android/chrome_java_sources.gni
@@ -1119,7 +1119,7 @@ "java/src/org/chromium/chrome/browser/sync/ui/PassphraseCreationDialogFragment.java", "java/src/org/chromium/chrome/browser/sync/ui/PassphraseDialogFragment.java", "java/src/org/chromium/chrome/browser/sync/ui/PassphraseTypeDialogFragment.java", - "java/src/org/chromium/chrome/browser/sync/ui/TrustedVaultKeyRetrievalProxyActivity.java", + "java/src/org/chromium/chrome/browser/sync/ui/SyncTrustedVaultProxyActivity.java", "java/src/org/chromium/chrome/browser/tab/AccessibilityVisibilityHandler.java", "java/src/org/chromium/chrome/browser/tab/AuthenticatorNavigationInterceptorTabHelper.java", "java/src/org/chromium/chrome/browser/tab/AutofillSessionLifetimeController.java",
diff --git a/chrome/android/expectations/monochrome_public_bundle.AndroidManifest.expected b/chrome/android/expectations/monochrome_public_bundle.AndroidManifest.expected index a25a324..8eceb61 100644 --- a/chrome/android/expectations/monochrome_public_bundle.AndroidManifest.expected +++ b/chrome/android/expectations/monochrome_public_bundle.AndroidManifest.expected
@@ -516,12 +516,12 @@ android:autoRemoveFromRecents="true" android:theme="@style/Theme.Chromium.Activity"> </activity> # DIFF-ANCHOR: 8492e3fd - <activity # DIFF-ANCHOR: 76b60c10 - android:name="org.chromium.chrome.browser.sync.ui.TrustedVaultKeyRetrievalProxyActivity" + <activity # DIFF-ANCHOR: 45a98fa4 + android:name="org.chromium.chrome.browser.sync.ui.SyncTrustedVaultProxyActivity" android:excludeFromRecents="true" android:exported="false" android:theme="@style/Theme.MaterialComponents"> - </activity> # DIFF-ANCHOR: 76b60c10 + </activity> # DIFF-ANCHOR: 45a98fa4 <activity # DIFF-ANCHOR: 43bfa5de android:name="org.chromium.chrome.browser.test_dummy.TestDummyActivity" android:configChanges="orientation|keyboardHidden|keyboard|screenSize|mcc|mnc|screenLayout|smallestScreenSize"
diff --git a/chrome/android/expectations/trichrome_chrome_bundle.AndroidManifest.expected b/chrome/android/expectations/trichrome_chrome_bundle.AndroidManifest.expected index 0a0aada2..4596e454 100644 --- a/chrome/android/expectations/trichrome_chrome_bundle.AndroidManifest.expected +++ b/chrome/android/expectations/trichrome_chrome_bundle.AndroidManifest.expected
@@ -489,12 +489,12 @@ android:autoRemoveFromRecents="true" android:theme="@style/Theme.Chromium.Activity"> </activity> # DIFF-ANCHOR: 8492e3fd - <activity # DIFF-ANCHOR: 76b60c10 - android:name="org.chromium.chrome.browser.sync.ui.TrustedVaultKeyRetrievalProxyActivity" + <activity # DIFF-ANCHOR: 45a98fa4 + android:name="org.chromium.chrome.browser.sync.ui.SyncTrustedVaultProxyActivity" android:excludeFromRecents="true" android:exported="false" android:theme="@style/Theme.MaterialComponents"> - </activity> # DIFF-ANCHOR: 76b60c10 + </activity> # DIFF-ANCHOR: 45a98fa4 <activity # DIFF-ANCHOR: 43bfa5de android:name="org.chromium.chrome.browser.test_dummy.TestDummyActivity" android:configChanges="orientation|keyboardHidden|keyboard|screenSize|mcc|mnc|screenLayout|smallestScreenSize"
diff --git a/chrome/android/java/AndroidManifest.xml b/chrome/android/java/AndroidManifest.xml index 99edfde..563055a 100644 --- a/chrome/android/java/AndroidManifest.xml +++ b/chrome/android/java/AndroidManifest.xml
@@ -527,7 +527,7 @@ TODO(crbug.com/1093292): investigate why @android:style/Theme.NoDisplay can't be used here. --> - <activity android:name="org.chromium.chrome.browser.sync.ui.TrustedVaultKeyRetrievalProxyActivity" + <activity android:name="org.chromium.chrome.browser.sync.ui.SyncTrustedVaultProxyActivity" android:theme="@style/Theme.MaterialComponents" android:excludeFromRecents="true" android:exported="false">
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/SyncErrorInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/SyncErrorInfoBar.java index dcc91c5..5d56984 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/SyncErrorInfoBar.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/SyncErrorInfoBar.java
@@ -26,7 +26,7 @@ import org.chromium.chrome.browser.sync.settings.ManageSyncSettings; import org.chromium.chrome.browser.sync.settings.SyncSettingsUtils; import org.chromium.chrome.browser.sync.settings.SyncSettingsUtils.SyncError; -import org.chromium.chrome.browser.sync.ui.TrustedVaultKeyRetrievalProxyActivity; +import org.chromium.chrome.browser.sync.ui.SyncTrustedVaultProxyActivity; import org.chromium.components.browser_ui.settings.SettingsLauncher; import org.chromium.components.infobars.ConfirmInfoBar; import org.chromium.components.infobars.InfoBar; @@ -130,10 +130,10 @@ (intent) -> { IntentUtils.safeStartActivity(getApplicationContext(), - TrustedVaultKeyRetrievalProxyActivity - .createKeyRetrievalProxyIntent(intent, - TrustedVaultUserActionTriggerForUMA - .NEW_TAB_PAGE_INFOBAR)); + SyncTrustedVaultProxyActivity.createKeyRetrievalProxyIntent( + intent, + TrustedVaultUserActionTriggerForUMA + .NEW_TAB_PAGE_INFOBAR)); }, (exception) -> Log.w(TAG, "Error creating trusted vault key retrieval intent: ", @@ -151,7 +151,7 @@ (intent) -> { IntentUtils.safeStartActivity(getApplicationContext(), - TrustedVaultKeyRetrievalProxyActivity + SyncTrustedVaultProxyActivity .createRecoverabilityDegradedProxyIntent(intent, TrustedVaultUserActionTriggerForUMA .NEW_TAB_PAGE_INFOBAR));
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncErrorNotifier.java b/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncErrorNotifier.java index c6b33aca..b7409f3f 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncErrorNotifier.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncErrorNotifier.java
@@ -24,7 +24,7 @@ import org.chromium.chrome.browser.sync.settings.ManageSyncSettings; import org.chromium.chrome.browser.sync.settings.SyncSettingsUtils; import org.chromium.chrome.browser.sync.ui.PassphraseActivity; -import org.chromium.chrome.browser.sync.ui.TrustedVaultKeyRetrievalProxyActivity; +import org.chromium.chrome.browser.sync.ui.SyncTrustedVaultProxyActivity; import org.chromium.components.browser_ui.notifications.NotificationManagerProxy; import org.chromium.components.browser_ui.notifications.NotificationManagerProxyImpl; import org.chromium.components.browser_ui.notifications.NotificationMetadata; @@ -135,7 +135,7 @@ // Converting |intentTriggeredOnClick| into a PendingIntent is needed because it will be // handed over to the Android notification manager, a foreign application. // FLAG_UPDATE_CURRENT ensures any cached intent extras are updated. - // TODO(crbug.com/1071377): TrustedVaultKeyRetrievalProxyActivity is the only one to add + // TODO(crbug.com/1071377): SyncTrustedVaultProxyActivity is the only one to add // extras to the intent, so it should probably be responsible for passing // FLAG_UPDATE_CURRENT. PendingIntentProvider pendingIntent = @@ -240,15 +240,14 @@ TrustedVaultClient.get() .createKeyRetrievalIntent(primaryAccountInfo) - // Cf. TrustedVaultKeyRetrievalProxyActivity as to why use a proxy intent. + // Cf. SyncTrustedVaultProxyActivity as to why use a proxy intent. // TODO(crbug.com/1071377): Sync state might have changed by the time |realIntent| // is available, so showing the notification won't make sense. .then((realIntent) -> showNotification(notificationTitle, notificationTextBody, - TrustedVaultKeyRetrievalProxyActivity - .createKeyRetrievalProxyIntent(realIntent, - TrustedVaultUserActionTriggerForUMA - .NOTIFICATION)), + SyncTrustedVaultProxyActivity.createKeyRetrievalProxyIntent( + realIntent, + TrustedVaultUserActionTriggerForUMA.NOTIFICATION)), (exception) -> Log.w(TAG, "Error creating key retrieval intent: ", exception)); }
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/sync/ui/TrustedVaultKeyRetrievalProxyActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncTrustedVaultProxyActivity.java similarity index 86% rename from chrome/android/java/src/org/chromium/chrome/browser/sync/ui/TrustedVaultKeyRetrievalProxyActivity.java rename to chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncTrustedVaultProxyActivity.java index 61c2a68..0323e4b1 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/sync/ui/TrustedVaultKeyRetrievalProxyActivity.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncTrustedVaultProxyActivity.java
@@ -16,12 +16,12 @@ import org.chromium.components.sync.TrustedVaultUserActionTriggerForUMA; /** - * {@link TrustedVaultKeyRetrievalProxyActivity} has no own UI and just launches real key retrieval - * activity (passed via extra). The reason for using this proxy activity is to detect when real key - * retrieval activity finishes and notify TrustedVaultClient about changed keys. + * {@link SyncTrustedVaultProxyActivity} has no own UI and just acts as a proxy to launch an + * activity related to trusted vault user actions (passed via PendingIntent). The reason for using + * this proxy activity is to detect when the proxied activity (key retrieval or degraded + * recoverability fix UI) finishes and notify TrustedVaultClient about changes. */ -// TODO(crbug.com/1100279): Rename this class to avoid 'retrieval' in the name. -public class TrustedVaultKeyRetrievalProxyActivity extends AsyncInitializationActivity { +public class SyncTrustedVaultProxyActivity extends AsyncInitializationActivity { private static final String TAG = "SyncUI"; // Note that the implementation relies on request codes being >0 (default value for @@ -38,14 +38,14 @@ private int mRequestCode; /** - * Creates an intent that launches an TrustedVaultKeyRetrievalProxyActivity for the purpose of + * Creates an intent that launches an SyncTrustedVaultProxyActivity for the purpose of * key retrieval. * * @param keyRetrievalIntent Actual key retrieval intent, which will be launched by - * TrustedVaultKeyRetrievalProxyActivity. + * SyncTrustedVaultProxyActivity. * @param userActionTrigger Enum representing which UI surface triggered the intent. * - * @return the intent for launching TrustedVaultKeyRetrievalProxyActivity + * @return the intent for launching SyncTrustedVaultProxyActivity */ public static Intent createKeyRetrievalProxyIntent(PendingIntent keyRetrievalIntent, @TrustedVaultUserActionTriggerForUMA int userActionTrigger) { @@ -54,14 +54,14 @@ } /** - * Creates an intent that launches an TrustedVaultKeyRetrievalProxyActivity for the purpose of + * Creates an intent that launches an SyncTrustedVaultProxyActivity for the purpose of * fixing the recoverability degraded case. * * @param recoverabilityDegradedIntent Actual recoverability degraded fix intent, which will be - * launched by TrustedVaultKeyRetrievalProxyActivity. + * launched by SyncTrustedVaultProxyActivity. * @param userActionTrigger Enum representing which UI surface triggered the intent. * - * @return the intent for launching TrustedVaultKeyRetrievalProxyActivity + * @return the intent for launching SyncTrustedVaultProxyActivity */ public static Intent createRecoverabilityDegradedProxyIntent( PendingIntent recoverabilityDegradedIntent, @@ -73,7 +73,7 @@ private static Intent createProxyIntent(PendingIntent proxiedIntent, @TrustedVaultUserActionTriggerForUMA int userActionTrigger, int requestCode) { Intent proxyIntent = new Intent( - ContextUtils.getApplicationContext(), TrustedVaultKeyRetrievalProxyActivity.class); + ContextUtils.getApplicationContext(), SyncTrustedVaultProxyActivity.class); proxyIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK); proxyIntent.addFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP); proxyIntent.putExtra(EXTRA_KEY_PROXIED_INTENT, proxiedIntent);
diff --git a/chrome/app/chromeos_strings.grdp b/chrome/app/chromeos_strings.grdp index ec93937..e8071059 100644 --- a/chrome/app/chromeos_strings.grdp +++ b/chrome/app/chromeos_strings.grdp
@@ -1131,7 +1131,7 @@ Sync your Chrome browser bookmarks, passwords, history, and more </message> <message name="IDS_LOGIN_SYNC_CONSENT_SCREEN_CHROME_BROWSER_SYNC_DESCRIPTION" desc="Description of the 'Chrome browser sync' section of the sync confirmation dialog that is displayed on the first user log in."> - Google may use your history to personalize search and other Google services + Google may use your history to personalize Search and other Google services </message> <message name="IDS_LOGIN_SYNC_CONSENT_SCREEN_CHROME_SYNC_NAME" desc="Title of the 'Chrome sync' section of the sync confirmation dialog that is displayed on the first user log in."> Chrome sync
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn index b76b177..0d81f08 100644 --- a/chrome/browser/BUILD.gn +++ b/chrome/browser/BUILD.gn
@@ -3080,6 +3080,9 @@ "password_manager/android/auto_signin_prompt_controller.h", "password_manager/android/biometric_authenticator_android.cc", "password_manager/android/biometric_authenticator_android.h", + "password_manager/android/biometric_authenticator_bridge.h", + "password_manager/android/biometric_authenticator_bridge_impl.cc", + "password_manager/android/biometric_authenticator_bridge_impl.h", "password_manager/android/credential_android.cc", "password_manager/android/credential_android.h", "password_manager/android/credential_leak_controller_android.cc",
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc index 8110013..b2a3ffe 100644 --- a/chrome/browser/about_flags.cc +++ b/chrome/browser/about_flags.cc
@@ -6324,7 +6324,7 @@ {"reduce-user-agent", flag_descriptions::kReduceUserAgentName, flag_descriptions::kReduceUserAgentDescription, kOsDesktop | kOsAndroid, - FEATURE_VALUE_TYPE(blink::features::kFreezeUserAgent)}, + FEATURE_VALUE_TYPE(blink::features::kReduceUserAgent)}, #if !defined(OS_ANDROID) && !BUILDFLAG(IS_CHROMEOS_ASH) {"enable-user-data-snapshot", flag_descriptions::kUserDataSnapshotName, @@ -6994,12 +6994,6 @@ FEATURE_VALUE_TYPE(features::kSwipeToMoveCursor)}, #endif // defined(OS_ANDROID) - {"use-of-hash-affiliation-fetcher", - flag_descriptions::kUseOfHashAffiliationFetcherName, - flag_descriptions::kUseOfHashAffiliationFetcherDescription, kOsAll, - FEATURE_VALUE_TYPE( - password_manager::features::kUseOfHashAffiliationFetcher)}, - {"safety-check-weak-passwords", flag_descriptions::kSafetyCheckWeakPasswordsName, flag_descriptions::kSafetyCheckWeakPasswordsDescription, kOsDesktop, @@ -7010,6 +7004,10 @@ flag_descriptions::kSettingsLandingPageRedesignName, flag_descriptions::kSettingsLandingPageRedesignDescription, kOsDesktop, FEATURE_VALUE_TYPE(features::kSettingsLandingPageRedesign)}, + + {"webui-branding-update", flag_descriptions::kWebUIBrandingUpdateName, + flag_descriptions::kWebUIBrandingUpdateDescription, kOsDesktop, + FEATURE_VALUE_TYPE(features::kWebUIBrandingUpdate)}, #endif // !defined(OS_ANDROID) #if defined(OS_ANDROID)
diff --git a/chrome/browser/ash/arc/enterprise/cert_store/arc_cert_installer.cc b/chrome/browser/ash/arc/enterprise/cert_store/arc_cert_installer.cc index 73057f82..d57a1fc 100644 --- a/chrome/browser/ash/arc/enterprise/cert_store/arc_cert_installer.cc +++ b/chrome/browser/ash/arc/enterprise/cert_store/arc_cert_installer.cc
@@ -19,14 +19,22 @@ #include "chrome/browser/net/nss_context.h" #include "chrome/browser/profiles/profile.h" #include "chrome/common/net/x509_certificate_model_nss.h" +#include "chrome/services/keymaster/public/mojom/cert_store.mojom.h" #include "crypto/rsa_private_key.h" #include "net/cert/x509_util_nss.h" namespace arc { CertDescription::CertDescription(crypto::RSAPrivateKey* placeholder_key, - CERTCertificate* nss_cert) - : placeholder_key(placeholder_key), nss_cert(nss_cert) {} + CERTCertificate* nss_cert, + keymaster::mojom::ChapsSlot slot, + std::string label, + std::string id) + : placeholder_key(placeholder_key), + nss_cert(nss_cert), + slot(slot), + label(label), + id(id) {} CertDescription::CertDescription(CertDescription&& other) = default;
diff --git a/chrome/browser/ash/arc/enterprise/cert_store/arc_cert_installer.h b/chrome/browser/ash/arc/enterprise/cert_store/arc_cert_installer.h index 7c783575..631e82f 100644 --- a/chrome/browser/ash/arc/enterprise/cert_store/arc_cert_installer.h +++ b/chrome/browser/ash/arc/enterprise/cert_store/arc_cert_installer.h
@@ -12,6 +12,7 @@ #include <vector> #include "base/memory/weak_ptr.h" +#include "chrome/services/keymaster/public/mojom/cert_store.mojom.h" #include "components/policy/core/common/remote_commands/remote_command_job.h" #include "components/policy/core/common/remote_commands/remote_commands_queue.h" #include "crypto/rsa_private_key.h" @@ -27,17 +28,30 @@ namespace arc { +// This class is basically a value holder associating metadata relevant to an +// NSS CERTCertificate. struct CertDescription { CertDescription(crypto::RSAPrivateKey* placeholder_key, - CERTCertificate* nss_cert); + CERTCertificate* nss_cert, + keymaster::mojom::ChapsSlot slot, + std::string label, + std::string id); CertDescription(CertDescription&& other); CertDescription(const CertDescription& other) = delete; CertDescription& operator=(CertDescription&& other); CertDescription& operator=(const CertDescription& other) = delete; ~CertDescription(); + // The dummy key to be installed in ARC as a placeholder for |nss_cert|. std::unique_ptr<crypto::RSAPrivateKey> placeholder_key; + // The NSS certificate that corresponds to this object. net::ScopedCERTCertificate nss_cert; + // The chaps slot where this key is stored. + keymaster::mojom::ChapsSlot slot; + // The PKCS#11 CKA_LABEL of this key. + std::string label; + // The PKCS#11 CKA_ID of this key. + std::string id; }; // This class manages the certificates, available to ARC.
diff --git a/chrome/browser/ash/arc/enterprise/cert_store/arc_cert_installer_unittest.cc b/chrome/browser/ash/arc/enterprise/cert_store/arc_cert_installer_unittest.cc index b145f151..6e40b863 100644 --- a/chrome/browser/ash/arc/enterprise/cert_store/arc_cert_installer_unittest.cc +++ b/chrome/browser/ash/arc/enterprise/cert_store/arc_cert_installer_unittest.cc
@@ -50,6 +50,11 @@ constexpr char kFakeName2[] = "fake2"; constexpr char kFakeName3[] = "fake3"; +// Arbitrary label and ID. Note IDs can be any byte blob, not necessarily +// human readable. +constexpr char kLabel[] = "some label"; +constexpr char kId[] = "some ID"; + class MockRemoteCommandsQueueObserver : public StrictMock<policy::RemoteCommandsQueue::Observer> { public: @@ -76,7 +81,8 @@ cert = net::x509_util::CreateCERTCertificateFromBytes( reinterpret_cast<const uint8_t*>(der_cert.data()), der_cert.size()); ASSERT_TRUE(cert); - certs->push_back(CertDescription(key.release(), cert.release())); + certs->emplace_back(key.release(), cert.release(), + keymaster::mojom::ChapsSlot::kUser, kLabel, kId); } } // namespace
diff --git a/chrome/browser/ash/arc/enterprise/cert_store/cert_store_service.cc b/chrome/browser/ash/arc/enterprise/cert_store/cert_store_service.cc index 963ba0dd..b788952 100644 --- a/chrome/browser/ash/arc/enterprise/cert_store/cert_store_service.cc +++ b/chrome/browser/ash/arc/enterprise/cert_store/cert_store_service.cc
@@ -4,6 +4,7 @@ #include "chrome/browser/ash/arc/enterprise/cert_store/cert_store_service.h" +#include <algorithm> #include <map> #include <set> #include <string> @@ -15,6 +16,7 @@ #include "base/logging.h" #include "base/memory/singleton.h" #include "base/memory/weak_ptr.h" +#include "base/task/thread_pool.h" #include "chrome/browser/ash/arc/enterprise/cert_store/arc_cert_installer_utils.h" #include "chrome/browser/ash/arc/keymaster/arc_keymaster_bridge.h" #include "chrome/browser/ash/arc/policy/arc_policy_bridge.h" @@ -32,6 +34,8 @@ #include "components/policy/core/common/policy_map.h" #include "components/policy/core/common/policy_namespace.h" #include "content/public/browser/browser_context.h" +#include "content/public/browser/browser_task_traits.h" +#include "content/public/browser/browser_thread.h" #include "crypto/rsa_private_key.h" #include "net/cert/x509_util_nss.h" #include "third_party/abseil-cpp/absl/types/optional.h" @@ -77,6 +81,144 @@ } }; +// The following series of functions related to ListCerts make use of the +// NSSCertDatabase to fulfill its goal of listing certificates. The cert +// database is accessed through a raw pointer with limited lifetime guarantees +// and is not thread safe. Namely, the cert database is guaranteed valid for the +// single IO thread task where it was received. +// +// Furthermore, creating an NssCertDatabaseGetter requires a BrowserContext, +// which can only be accessed on the UI thread. +// +// ListCerts and related functions are implemented to make sure the above +// requirements are respected. Here's a diagram of the interaction between UI +// and IO threads. +// +// UI Thread IO Thread +// +// ListCerts +// | +// CreateNSSCertDatabaseGetter +// | +// \----------------------------v +// ListCertsWithDbGetterOnIO +// | +// database_getter.Run() +// | +// ListCertsOnIO +// | +// ListCertsInSlot +// | +// PostListedCertsBackToOriginalTaskRunner +// | +// v----------------------------/ +// Process certs / Repeat ListCerts for system slot +// +// ARC requires certs from both the 'user' and 'system' chaps slots to be +// processed. Because ListCertsInSlot is asynchronous, it's not possible to +// guarantee that both ListCertsInSlot calls happen in the same task execution, +// so this entire process is performed twice: first for the user slot, then for +// the system slot. The ordering of the calls is not important, other than the +// implementation lists the 'user' slot first, and uses the 'system' slot to +// signal the process is complete. +// +// The current user may not have access to the system slot, but that is only +// discoverable on the IO thread. In that case, the sequence for the system slot +// becomes: +// +// UI Thread IO Thread +// +// ListCerts +// | +// CreateNSSCertDatabaseGetter +// | +// \----------------------------v +// ListCertsWithDbGetterOnIO +// | +// database_getter.Run() +// | +// ListCertsOnIO +// | +// (Determine system slot isn't allowed) +// | +// PostListedCertsBackToOriginalTaskRunner +// | +// v----------------------------/ +// Process list of certs... + +void PostListedCertsBackToOriginalTaskRunner( + scoped_refptr<base::TaskRunner> original_task_runner, + net::NSSCertDatabase::ListCertsCallback callback, + net::ScopedCERTCertificateList cert_list) { + original_task_runner->PostTask( + FROM_HERE, base::BindOnce(std::move(callback), std::move(cert_list))); +} + +void ListCertsOnIO(scoped_refptr<base::TaskRunner> original_task_runner, + keymaster::mojom::ChapsSlot slot, + net::NSSCertDatabase::ListCertsCallback callback, + net::NSSCertDatabase* database) { + // |database->ListCertsInSlot| must be called from the IO thread. + DCHECK_CURRENTLY_ON(content::BrowserThread::IO); + + if (slot == keymaster::mojom::ChapsSlot::kSystem && + !database->GetSystemSlot()) { + // Trying to list system slot when it's not available, return empty list. + PostListedCertsBackToOriginalTaskRunner(original_task_runner, + std::move(callback), + net::ScopedCERTCertificateList()); + return; + } + + // List the certs on |database|, which may dispatch to a worker thread to + // avoid blocking. The actual result needs to make it back to the UI thread, + // but the callback will be invoked on the IO thread, so the results need + // to be forwarded onwards. + database->ListCertsInSlot( + base::BindOnce(&PostListedCertsBackToOriginalTaskRunner, + original_task_runner, std::move(callback)), + slot == keymaster::mojom::ChapsSlot::kUser + ? database->GetPrivateSlot().get() + : database->GetSystemSlot().get()); +} + +void ListCertsWithDbGetterOnIO( + scoped_refptr<base::TaskRunner> original_task_runner, + keymaster::mojom::ChapsSlot slot, + net::NSSCertDatabase::ListCertsCallback callback, + NssCertDatabaseGetter database_getter) { + // |database_getter| must be run from the IO thread. + DCHECK_CURRENTLY_ON(content::BrowserThread::IO); + + // Running |database_getter| may either return a non-null pointer + // synchronously or invoke the given callback asynchronously with a non-null + // pointer. |split_callback| is used here to handle both cases. + auto split_callback = base::SplitOnceCallback( + base::BindOnce(&ListCertsOnIO, std::move(original_task_runner), slot, + std::move(callback))); + + net::NSSCertDatabase* database = + std::move(database_getter).Run(std::move(split_callback.first)); + if (database) + std::move(split_callback.second).Run(database); +} + +// Returns the list of certificates in |slot|, making sure to fetch the cert +// database and list certs from the IO thread, while posting |callback| with the +// output list to the original caller thread. +void ListCerts(content::BrowserContext* const context, + keymaster::mojom::ChapsSlot slot, + net::NSSCertDatabase::ListCertsCallback callback) { + // |context| must be accessed on the UI thread. + DCHECK_CURRENTLY_ON(content::BrowserThread::UI); + // The NssCertDatabaseGetter must be posted to the IO thread immediately. + content::GetIOThreadTaskRunner({})->PostTask( + FROM_HERE, base::BindOnce(&ListCertsWithDbGetterOnIO, + base::ThreadTaskRunnerHandle::Get(), slot, + std::move(callback), + CreateNSSCertDatabaseGetter(context))); +} + using IsCertificateAllowedCallback = base::OnceCallback<void(bool allowed)>; void CheckCorporateFlag( @@ -93,26 +235,18 @@ std::move(callback).Run(/* allowed */ corporate_key.value()); } -void CheckKeyLocationAndCorporateFlag( - IsCertificateAllowedCallback callback, - const std::string& public_key_spki_der, - content::BrowserContext* const context, - absl::optional<bool> key_on_user_token, - chromeos::platform_keys::Status is_key_on_token_status) { - if (is_key_on_token_status != chromeos::platform_keys::Status::kSuccess) { - LOG(WARNING) << "Error while checking key location: " - << chromeos::platform_keys::StatusToString( - is_key_on_token_status); - std::move(callback).Run(/* allowed */ false); - return; - } +// Returns true if the certificate is allowed to be used by ARC. The certificate +// is allowed to be used by ARC if its key is marked for corporate usage. |cert| +// must be non-null. +void IsCertificateAllowed(IsCertificateAllowedCallback callback, + scoped_refptr<net::X509Certificate> cert, + content::BrowserContext* const context) { + // |context| must be accessed on the UI thread. + DCHECK_CURRENTLY_ON(content::BrowserThread::UI); + DCHECK(cert); - DCHECK(key_on_user_token.has_value()); - - if (!key_on_user_token.value_or(false)) { - std::move(callback).Run(/* allowed */ false); - return; - } + std::string public_key_spki_der = + chromeos::platform_keys::GetSubjectPublicKeyInfo(cert); // Check if the key is marked for corporate usage. chromeos::platform_keys::KeyPermissionsServiceFactory::GetForBrowserContext( @@ -122,70 +256,84 @@ base::BindOnce(&CheckCorporateFlag, std::move(callback))); } -// Returns true if the certificate is allowed to be used by ARC. The certificate -// is allowed to be used by ARC if its key is marked for corporate usage and -// resides on a user token. |cert| must be non-null. -void IsCertificateAllowed(IsCertificateAllowedCallback callback, - scoped_refptr<net::X509Certificate> cert, - content::BrowserContext* const context) { - DCHECK(cert); +// Creates a |CertDescription| for the given |nss_cert| known to be stored in +// |slot|. May return |absl::nullopt| if some cert metadata can't be found, e.g. +// when the cert private key is deleted while we still keep a valid pointer to +// |nss_cert|. +absl::optional<CertDescription> BuildCertDescritionOnWorkerThread( + net::ScopedCERTCertificate nss_cert, + keymaster::mojom::ChapsSlot slot) { + // Direct NSS calls must be made on a worker thread (not the IO/UI threads). + DCHECK(!content::BrowserThread::CurrentlyOn(content::BrowserThread::IO)); + DCHECK(!content::BrowserThread::CurrentlyOn(content::BrowserThread::UI)); - const std::string public_key_spki_der = - chromeos::platform_keys::GetSubjectPublicKeyInfo(cert); + // NSS cert must be non null. + if (!nss_cert) + return absl::nullopt; - // Check if the key is on the user token. - chromeos::platform_keys::PlatformKeysServiceFactory::GetForBrowserContext( - context) - ->IsKeyOnToken( - chromeos::platform_keys::TokenId::kUser, public_key_spki_der, - base::BindOnce(&CheckKeyLocationAndCorporateFlag, std::move(callback), - public_key_spki_der, context)); + // TODO(b/193771095) Use a valid wincx. + // Must have a private key in order to access label and ID. + SECKEYPrivateKey* private_key = + PK11_FindKeyByAnyCert(nss_cert.get(), nullptr /* wincx */); + // TODO(b/193771180) Investigate race condition with null private keys. + if (!private_key) + return absl::nullopt; + crypto::ScopedSECKEYPrivateKey priv_key_destroyer(private_key); + + // Must have a nickname (PKCS#11 CKA_LABEL). + char* nickname = PK11_GetPrivateKeyNickname(private_key); + if (!nickname) + return absl::nullopt; + std::string pkcs11_label(nickname); + PORT_Free(nickname); + + // Finally, must have an ID item (PKCS#11 CKA_ID). + SECItem* id_item = PK11_GetLowLevelKeyIDForPrivateKey(private_key); + if (!id_item) + return absl::nullopt; + crypto::ScopedSECItem sec_item_destroyer(id_item); + std::string pkcs11_id(id_item->data, id_item->data + id_item->len); + + // TODO(b/193784305) Try to avoid (some) key generation if possible. + // Generate the placeholder RSA key that will be installed in ARC. + auto placeholder_key = crypto::RSAPrivateKey::Create(2048); + DCHECK(placeholder_key); + + return CertDescription(placeholder_key.release(), nss_cert.release(), slot, + pkcs11_label, pkcs11_id); } -std::vector<CertDescription> PrepareCertDescriptions( - net::ScopedCERTCertificateList nss_certs) { - std::vector<CertDescription> certificates; - for (auto& nss_cert : nss_certs) { - if (!nss_cert) - continue; - // Generate the placeholder RSA key that will be installed in ARC. - auto placeholder_key = crypto::RSAPrivateKey::Create(2048); - DCHECK(placeholder_key); +using BuildCertDescritionCallback = + base::OnceCallback<void(absl::optional<CertDescription> populated_cert)>; - certificates.emplace_back(placeholder_key.release(), nss_cert.release()); - } - return certificates; +// Tries to asynchronously create a |CertDescription| for the given |nss_cert| +// known to be stored in |slot| in a worker thread. Note direct NSS calls must +// be made at a worker thread. +void BuildCertDescription(net::ScopedCERTCertificate nss_cert, + keymaster::mojom::ChapsSlot slot, + BuildCertDescritionCallback callback) { + base::ThreadPool::PostTaskAndReplyWithResult( + FROM_HERE, + {base::MayBlock(), base::TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN}, + base::BindOnce(&BuildCertDescritionOnWorkerThread, std::move(nss_cert), + slot), + std::move(callback)); } +// Returns the list of Chrome OS keys with the data arc-keymasterd needs to find +// and execute operations on the certs in |cert_descriptions| through chaps. +// Each ChromeOsKey instance contains a ChapsKeyData with its CKA_LABEL, +// CKA_ID, and the slot where it's stored. Note this slot is NOT the PKCS#11 +// CK_SLOT_ID, but a more abstract representation that can be used to find the +// corresponding CK_SLOT_ID at runtime. std::vector<keymaster::mojom::ChromeOsKeyPtr> PrepareChromeOsKeys( - const std::vector<CertDescription>& certificates) { + const std::vector<CertDescription>& cert_descriptions) { std::vector<keymaster::mojom::ChromeOsKeyPtr> chrome_os_keys; - for (const auto& certificate : certificates) { - CERTCertificate* nss_cert = certificate.nss_cert.get(); - DCHECK(nss_cert); - - // Fetch PKCS#11 CKA_LABEL. - SECKEYPrivateKey* priv_key = - PK11_FindKeyByAnyCert(nss_cert, nullptr /* wincx */); - if (!priv_key) - continue; - crypto::ScopedSECKEYPrivateKey priv_key_destroyer(priv_key); - - char* nickname = PK11_GetPrivateKeyNickname(priv_key); - if (!nickname) - continue; - std::string pkcs11_label(nickname); - - // Fetch PKCS#11 CKA_ID. - SECItem* id_item = PK11_GetLowLevelKeyIDForPrivateKey(priv_key); - if (!id_item) - continue; - crypto::ScopedSECItem sec_item_destroyer(id_item); - std::string pkcs11_id(id_item->data, id_item->data + id_item->len); - + for (const auto& certificate : cert_descriptions) { // Build a mojo ChromeOsKey and store it in the output vector. keymaster::mojom::ChapsKeyDataPtr key_data = - keymaster::mojom::ChapsKeyData::New(pkcs11_label, pkcs11_id); + keymaster::mojom::ChapsKeyData::New(certificate.label, certificate.id, + certificate.slot); keymaster::mojom::ChromeOsKeyPtr key = keymaster::mojom::ChromeOsKey::New( ExportSpki(certificate.placeholder_key.get()), keymaster::mojom::KeyData::NewChapsKeyData(std::move(key_data))); @@ -239,79 +387,101 @@ } void CertStoreService::UpdateCertificates() { - GetNSSCertDatabaseForProfile( - Profile::FromBrowserContext(context_), - base::BindOnce(&CertStoreService::OnGetNSSCertDatabaseForProfile, - weak_ptr_factory_.GetWeakPtr())); + ListCerts(context_, keymaster::mojom::ChapsSlot::kUser, + base::BindOnce(&CertStoreService::OnCertificatesListed, + weak_ptr_factory_.GetWeakPtr(), + keymaster::mojom::ChapsSlot::kUser, + std::vector<CertDescription>())); } -void CertStoreService::FilterAllowedCertificatesRecursively( - FilterAllowedCertificatesCallback callback, +void CertStoreService::OnCertificatesListed( + keymaster::mojom::ChapsSlot slot, + std::vector<CertDescription> cert_descriptions, + net::ScopedCERTCertificateList cert_list) { + base::queue<net::ScopedCERTCertificate> cert_queue; + for (auto& cert : cert_list) { + if (cert) + cert_queue.push(std::move(cert)); + } + + BuildAllowedCertDescriptionsRecursively( + base::BindOnce(&CertStoreService::OnBuiltAllowedCertDescriptions, + weak_ptr_factory_.GetWeakPtr(), slot), + slot, std::move(cert_queue), std::move(cert_descriptions)); +} + +// TODO(b/193785308) Try to simplify these recursive calls. +void CertStoreService::BuildAllowedCertDescriptionsRecursively( + BuildAllowedCertDescriptionsCallback callback, + keymaster::mojom::ChapsSlot slot, base::queue<net::ScopedCERTCertificate> cert_queue, - net::ScopedCERTCertificateList allowed_certs) const { + std::vector<CertDescription> allowed_certs) const { if (cert_queue.empty()) { std::move(callback).Run(std::move(allowed_certs)); return; } net::ScopedCERTCertificate cert = std::move(cert_queue.front()); + DCHECK(cert); cert_queue.pop(); scoped_refptr<net::X509Certificate> x509_cert = net::x509_util::CreateX509CertificateFromCERTCertificate(cert.get()); if (!x509_cert) { - FilterAllowedCertificatesRecursively( - std::move(callback), std::move(cert_queue), std::move(allowed_certs)); + BuildAllowedCertDescriptionsRecursively(std::move(callback), slot, + std::move(cert_queue), + std::move(allowed_certs)); return; } IsCertificateAllowed( - base::BindOnce(&CertStoreService::FilterAllowedCertificateAndRecurse, - weak_ptr_factory_.GetWeakPtr(), std::move(callback), + base::BindOnce(&CertStoreService::BuildAllowedCertDescriptionAndRecurse, + weak_ptr_factory_.GetWeakPtr(), std::move(callback), slot, std::move(cert_queue), std::move(allowed_certs), std::move(cert)), std::move(x509_cert), context_); } -void CertStoreService::FilterAllowedCertificateAndRecurse( - FilterAllowedCertificatesCallback callback, +void CertStoreService::BuildAllowedCertDescriptionAndRecurse( + BuildAllowedCertDescriptionsCallback callback, + keymaster::mojom::ChapsSlot slot, base::queue<net::ScopedCERTCertificate> cert_queue, - net::ScopedCERTCertificateList allowed_certs, + std::vector<CertDescription> allowed_certs, net::ScopedCERTCertificate cert, bool certificate_allowed) const { - if (certificate_allowed) - allowed_certs.push_back(std::move(cert)); - - FilterAllowedCertificatesRecursively( - std::move(callback), std::move(cert_queue), std::move(allowed_certs)); -} - -void CertStoreService::OnGetNSSCertDatabaseForProfile( - net::NSSCertDatabase* database) { - DCHECK(database); - database->ListCertsInSlot( - base::BindOnce(&CertStoreService::OnCertificatesListed, - weak_ptr_factory_.GetWeakPtr()), - database->GetPrivateSlot().get()); -} - -void CertStoreService::OnCertificatesListed( - net::ScopedCERTCertificateList cert_list) { - base::queue<net::ScopedCERTCertificate> cert_queue; - for (auto& cert : cert_list) { - cert_queue.push(std::move(cert)); + // Continue to build a CertDescription if the cert is allowed. + if (certificate_allowed) { + BuildCertDescription( + std::move(cert), slot, + base::BindOnce(&CertStoreService::AppendCertDescriptionAndRecurse, + weak_ptr_factory_.GetWeakPtr(), std::move(callback), + slot, std::move(cert_queue), std::move(allowed_certs))); + return; } - - net::ScopedCERTCertificateList allowed_certs; - FilterAllowedCertificatesRecursively( - base::BindOnce(&CertStoreService::OnFilteredAllowedCertificates, - weak_ptr_factory_.GetWeakPtr()), - std::move(cert_queue), std::move(allowed_certs)); + // Otherwise proceed to the rest of the queue recursively. + BuildAllowedCertDescriptionsRecursively(std::move(callback), slot, + std::move(cert_queue), + std::move(allowed_certs)); } -void CertStoreService::OnFilteredAllowedCertificates( - net::ScopedCERTCertificateList allowed_certs) { +void CertStoreService::AppendCertDescriptionAndRecurse( + BuildAllowedCertDescriptionsCallback callback, + keymaster::mojom::ChapsSlot slot, + base::queue<net::ScopedCERTCertificate> cert_queue, + std::vector<CertDescription> allowed_certs, + absl::optional<CertDescription> cert_description) const { + if (cert_description.has_value()) + allowed_certs.emplace_back(std::move(cert_description.value())); + + BuildAllowedCertDescriptionsRecursively(std::move(callback), slot, + std::move(cert_queue), + std::move(allowed_certs)); +} + +void CertStoreService::OnBuiltAllowedCertDescriptions( + keymaster::mojom::ChapsSlot slot, + std::vector<CertDescription> cert_descriptions) const { ArcKeymasterBridge* const keymaster_bridge = ArcKeymasterBridge::GetForBrowserContext(context_); if (!keymaster_bridge) { @@ -319,15 +489,29 @@ return; } - std::vector<CertDescription> certificates = - PrepareCertDescriptions(std::move(allowed_certs)); + if (slot == keymaster::mojom::ChapsSlot::kUser) { + // Done with the user slot, so try to process additional certs in the + // system slot. If there is no system slot (e.g. the user is not allowed + // to access it), this call won't mutate |cert_descriptions|, and only + // return the user slot certificates. However, it's necessary to perform + // this check asynchronously on the IO thread (through ListCerts), because + // that's the only thread that knows if the system slot is enabled. + ListCerts(context_, keymaster::mojom::ChapsSlot::kSystem, + base::BindOnce(&CertStoreService::OnCertificatesListed, + weak_ptr_factory_.GetWeakPtr(), + keymaster::mojom::ChapsSlot::kSystem, + std::move(cert_descriptions))); + return; + } + // At this point certs have been gathered from all available slots (i.e. user + // slot and potentially system slot if access is allowed to this user), + // proceed to send them to arc-keymaster and ARC. std::vector<keymaster::mojom::ChromeOsKeyPtr> keys = - PrepareChromeOsKeys(certificates); - + PrepareChromeOsKeys(cert_descriptions); keymaster_bridge->UpdatePlaceholderKeys( - std::move(keys), - base::BindOnce(&CertStoreService::OnUpdatedKeymasterKeys, - weak_ptr_factory_.GetWeakPtr(), std::move(certificates))); + std::move(keys), base::BindOnce(&CertStoreService::OnUpdatedKeymasterKeys, + weak_ptr_factory_.GetWeakPtr(), + std::move(cert_descriptions))); } void CertStoreService::OnUpdatedKeymasterKeys( @@ -355,11 +539,11 @@ CertStoreService::CertificateCache::~CertificateCache() = default; void CertStoreService::CertificateCache::Update( - const std::vector<CertDescription>& certificates) { + const std::vector<CertDescription>& cert_descriptions) { // Map cert name to real SPKI. key_info_by_name_cache_.clear(); std::set<std::string> new_required_cert_names; - for (const auto& certificate : certificates) { + for (const auto& certificate : cert_descriptions) { CERTCertificate* nss_cert = certificate.nss_cert.get(); DCHECK(nss_cert); @@ -367,21 +551,7 @@ std::string cert_name = x509_certificate_model::GetCertNameOrNickname(nss_cert); - // Fetch PKCS#11 CKA_ID. - SECKEYPrivateKey* priv_key = - PK11_FindKeyByAnyCert(nss_cert, nullptr /* wincx */); - if (!priv_key) - continue; - crypto::ScopedSECKEYPrivateKey priv_key_destroyer(priv_key); - - SECItem* sec_item = PK11_GetLowLevelKeyIDForPrivateKey(priv_key); - std::string pkcs11_id; - if (sec_item) { - pkcs11_id = std::string(sec_item->data, sec_item->data + sec_item->len); - SECITEM_FreeItem(sec_item, PR_TRUE); - } - - key_info_by_name_cache_[cert_name] = {cert_name, pkcs11_id}; + key_info_by_name_cache_[cert_name] = {cert_name, certificate.id}; new_required_cert_names.insert(cert_name); } need_policy_update_ = (required_cert_names_ != new_required_cert_names);
diff --git a/chrome/browser/ash/arc/enterprise/cert_store/cert_store_service.h b/chrome/browser/ash/arc/enterprise/cert_store/cert_store_service.h index cc6e9bf..a51737c 100644 --- a/chrome/browser/ash/arc/enterprise/cert_store/cert_store_service.h +++ b/chrome/browser/ash/arc/enterprise/cert_store/cert_store_service.h
@@ -14,6 +14,7 @@ #include "base/containers/queue.h" #include "base/memory/weak_ptr.h" #include "chrome/browser/ash/arc/enterprise/cert_store/arc_cert_installer.h" +#include "chrome/services/keymaster/public/mojom/cert_store.mojom.h" #include "components/keyed_service/content/browser_context_keyed_service_factory.h" #include "components/keyed_service/core/keyed_service.h" #include "content/public/browser/browser_context.h" @@ -70,6 +71,8 @@ } private: + using BuildAllowedCertDescriptionsCallback = + base::OnceCallback<void(std::vector<CertDescription> allowed_certs)>; using FilterAllowedCertificatesCallback = base::OnceCallback<void(net::ScopedCERTCertificateList allowed_certs)>; @@ -109,20 +112,50 @@ }; void UpdateCertificates(); - void FilterAllowedCertificatesRecursively( - FilterAllowedCertificatesCallback callback, + + void OnCertificatesListed(keymaster::mojom::ChapsSlot slot, + std::vector<CertDescription> certificates, + net::ScopedCERTCertificateList cert_list); + + // Processes |cert_queue| one by one recursively. Certs from from the given + // |slot|, and are accummulated in the list of |allowed_certs|, which is + // initially empty. Must be recursive because of async calls. + void BuildAllowedCertDescriptionsRecursively( + BuildAllowedCertDescriptionsCallback callback, + keymaster::mojom::ChapsSlot slot, base::queue<net::ScopedCERTCertificate> cert_queue, - net::ScopedCERTCertificateList allowed_certs) const; - void FilterAllowedCertificateAndRecurse( - FilterAllowedCertificatesCallback callback, + std::vector<CertDescription> allowed_certs) const; + // Decides to either proceed to build a |CertDescription| for the given |cert| + // when it is allowed by |certificate_allowed|, or skip it and proceed to the + // recursive call to BuildAllowedCertDescriptionsRecursively. + void BuildAllowedCertDescriptionAndRecurse( + BuildAllowedCertDescriptionsCallback callback, + keymaster::mojom::ChapsSlot slot, base::queue<net::ScopedCERTCertificate> cert_queue, - net::ScopedCERTCertificateList allowed_certs, + std::vector<CertDescription> allowed_certs, net::ScopedCERTCertificate cert, bool certificate_allowed) const; + // Appends the given |cert_description| to |allowed_certs| and proceeds to the + // the recursive call to BuildAllowedCertDescriptionsRecursively. + void AppendCertDescriptionAndRecurse( + BuildAllowedCertDescriptionsCallback callback, + keymaster::mojom::ChapsSlot slot, + base::queue<net::ScopedCERTCertificate> cert_queue, + std::vector<CertDescription> allowed_certs, + absl::optional<CertDescription> cert_description) const; + // Final callback called once all |cert_descriptions| have been processed by + // BuildAllowedCertDescriptionsRecursively on the given |slot|. May either + // restart the process to gather certificates on the system slot (when |slot| + // is the user slot), or proceed to update keymaster keys. + void OnBuiltAllowedCertDescriptions( + keymaster::mojom::ChapsSlot slot, + std::vector<CertDescription> cert_descriptions) const; - void OnGetNSSCertDatabaseForProfile(net::NSSCertDatabase* database); - void OnCertificatesListed(net::ScopedCERTCertificateList cert_list); + // Processes metadata from |allowed_certs| stored in the given |slot| and + // appends them to |certificates|. void OnFilteredAllowedCertificates( + keymaster::mojom::ChapsSlot slot, + std::vector<CertDescription> certificates, net::ScopedCERTCertificateList allowed_certs); void OnUpdatedKeymasterKeys(std::vector<CertDescription> certificates, bool success);
diff --git a/chrome/browser/ash/arc/enterprise/cert_store/cert_store_service_browsertest.cc b/chrome/browser/ash/arc/enterprise/cert_store/cert_store_service_browsertest.cc index c63bf775..e372010 100644 --- a/chrome/browser/ash/arc/enterprise/cert_store/cert_store_service_browsertest.cc +++ b/chrome/browser/ash/arc/enterprise/cert_store/cert_store_service_browsertest.cc
@@ -2,6 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <algorithm> #include <map> #include <string> #include <vector> @@ -15,8 +16,8 @@ #include "chrome/browser/ash/arc/enterprise/cert_store/cert_store_service.h" #include "chrome/browser/ash/arc/keymaster/arc_keymaster_bridge.h" #include "chrome/browser/ash/arc/session/arc_service_launcher.h" -#include "chrome/browser/ash/login/test/local_policy_test_server_mixin.h" -#include "chrome/browser/ash/policy/core/user_policy_test_helper.h" +#include "chrome/browser/ash/policy/affiliation/affiliation_mixin.h" +#include "chrome/browser/ash/policy/affiliation/affiliation_test_helper.h" #include "chrome/browser/ash/profiles/profile_helper.h" #include "chrome/browser/chromeos/platform_keys/key_permissions/key_permissions_service_factory.h" #include "chrome/browser/chromeos/platform_keys/platform_keys_service_factory.h" @@ -37,8 +38,10 @@ #include "components/arc/test/arc_util_test_support.h" #include "components/policy/policy_constants.h" #include "components/prefs/pref_service.h" +#include "content/public/browser/browser_task_traits.h" #include "content/public/browser/browser_thread.h" #include "content/public/test/browser_test.h" +#include "content/public/test/test_launcher.h" #include "crypto/scoped_test_system_nss_key_slot.h" #include "extensions/browser/extension_system.h" #include "net/cert/nss_cert_database.h" @@ -51,10 +54,42 @@ namespace { -constexpr char kFakeUserName[] = "test@example.com"; +constexpr char kFileName1[] = "client_1"; +constexpr char kFileName2[] = "client_2"; +constexpr char kFileName3[] = "client_3"; +constexpr char kFileName4[] = "client_4"; + constexpr char kFakeExtensionId[] = "fakeextensionid"; -const std::vector<std::string> kCertFiles = {"client_1", "client_2"}; +// Contains information needed for test cert parameters. +struct TestCertData { + TestCertData(const std::string& file_name, + bool is_corporate_usage, + keymaster::mojom::ChapsSlot slot) + : file_name(file_name), + is_corporate_usage(is_corporate_usage), + slot(slot) { + // Keys in system slot must be corporate usage. + DCHECK(slot != keymaster::mojom::ChapsSlot::kSystem || is_corporate_usage); + } + TestCertData(const TestCertData&) = default; + bool operator==(const TestCertData& other) const { + return std::tie(file_name, is_corporate_usage, slot) == + std::tie(other.file_name, other.is_corporate_usage, other.slot); + } + + std::string file_name; + bool is_corporate_usage; + keymaster::mojom::ChapsSlot slot; +}; + +// Associates a |test_data| to its |nss_cert| once installed. +struct InstalledTestCert { + InstalledTestCert(TestCertData test_data, net::ScopedCERTCertificate nss_cert) + : test_data(test_data), nss_cert(std::move(nss_cert)) {} + TestCertData test_data; + net::ScopedCERTCertificate nss_cert; +}; std::string GetDerCert64(CERTCertificate* cert) { std::string der_cert; @@ -140,353 +175,536 @@ return std::make_unique<CertStoreService>(profile, std::move(installer)); } +// The following series of functions related to IsSystemSlotAvailable use the +// NSSCertDatabase. The cert database is accessed through a raw pointer with +// limited lifetime guarantees and is not thread safe. Namely, the cert database +// is guaranteed valid for the single IO thread task where it was received. +// +// Furthermore, creating an NssCertDatabaseGetter requires a BrowserContext, +// which can only be accessed on the UI thread. +// +// ListCerts and related functions are implemented to make sure the above +// requirements are respected. Here's a diagram of the interaction between UI +// and IO threads. +// +// UI Thread IO Thread +// +// IsSystemSlotAvailable +// | +// run_loop.QuitClosure +// | +// CreateNSSCertDatabaseGetter +// | +// \--------------------------------v +// IsSystemSlotAvailableWithDbGetterOnIO +// | +// database_getter.Run +// | +// IsSystemSlotAvailableOnIO +// | +// GetSystemSlot +// | +// quit_closure.Run + +void IsSystemSlotAvailableOnIO(bool* out_system_slot_available, + base::OnceClosure done_closure, + net::NSSCertDatabase* cert_db) { + DCHECK_CURRENTLY_ON(content::BrowserThread::IO); + *out_system_slot_available = cert_db->GetSystemSlot() != nullptr; + std::move(done_closure).Run(); +} + +void IsSystemSlotAvailableWithDbGetterOnIO( + NssCertDatabaseGetter database_getter, + bool* out_system_slot_available, + base::OnceClosure done_closure) { + DCHECK_CURRENTLY_ON(content::BrowserThread::IO); + auto did_get_cert_db_split_callback = base::SplitOnceCallback( + base::BindOnce(&IsSystemSlotAvailableOnIO, out_system_slot_available, + std::move(done_closure))); + net::NSSCertDatabase* cert_db = + std::move(database_getter) + .Run(std::move(did_get_cert_db_split_callback.first)); + if (cert_db) { + std::move(did_get_cert_db_split_callback.second).Run(cert_db); + } +} + +// Returns trus if the test system slot was setup correctly and is available. +bool IsSystemSlotAvailable(Profile* profile) { + // |profile| must be accessed on the UI thread. + DCHECK_CURRENTLY_ON(content::BrowserThread::UI); + base::RunLoop run_loop; + bool system_slot_available = false; + // The NssCertDatabaseGetter must be posted to the IO thread immediately. + content::GetIOThreadTaskRunner({})->PostTask( + FROM_HERE, + base::BindOnce(IsSystemSlotAvailableWithDbGetterOnIO, + CreateNSSCertDatabaseGetter(profile), + &system_slot_available, run_loop.QuitClosure())); + run_loop.Run(); + return system_slot_available; +} + +// Returns the number of corporate usage certs in |test_certs|. +size_t CountCorporateUsage(const std::vector<TestCertData>& test_certs) { + return std::count_if(test_certs.begin(), test_certs.end(), + [](const TestCertData& test_data) { + return test_data.is_corporate_usage; + }); +} + +// Deletes the given |cert| from |cert_db|. +void DeleteCertAndKey(CERTCertificate* cert, + base::OnceClosure done_callback, + net::NSSCertDatabase* cert_db) { + base::ScopedAllowBlockingForTesting allow_io; + EXPECT_TRUE(cert_db->DeleteCertAndKey(cert)); + std::move(done_callback).Run(); +} + +// Called once a key has been registered as corporate usage. +void OnKeyRegisteredForCorporateUsage(base::OnceClosure done_callback, + bool is_error, + crosapi::mojom::KeystoreError error) { + ASSERT_FALSE(is_error) << static_cast<int>(error); + std::move(done_callback).Run(); +} + +// Uses |service| to register |cert| as corporate usage. +void RegisterCorporateKeyWithService( + CERTCertificate* cert, + base::OnceClosure done_callback, + std::unique_ptr<chromeos::platform_keys::ExtensionKeyPermissionsService> + service) { + std::string client_cert_spki( + cert->derPublicKey.data, + cert->derPublicKey.data + cert->derPublicKey.len); + service->RegisterKeyForCorporateUsage( + client_cert_spki, base::BindOnce(&OnKeyRegisteredForCorporateUsage, + std::move(done_callback))); +} + } // namespace -class CertStoreServiceTest : public MixinBasedInProcessBrowserTest { +class CertStoreServiceTest + : public MixinBasedInProcessBrowserTest, + public ::testing::WithParamInterface<std::vector<TestCertData>> { + public: + CertStoreServiceTest() = default; + CertStoreServiceTest(const CertStoreServiceTest& other) = delete; + CertStoreServiceTest& operator=(const CertStoreServiceTest&) = delete; + protected: - // MixinBasedInProcessBrowserTest: - void SetUpCommandLine(base::CommandLine* command_line) override { - MixinBasedInProcessBrowserTest::SetUpCommandLine(command_line); + void SetUpCommandLine(base::CommandLine* command_line) override; - arc::SetArcAvailableCommandLineForTesting(command_line); + void SetUpInProcessBrowserTestFixture() override; - policy_helper_ = std::make_unique<policy::UserPolicyTestHelper>( - kFakeUserName, &local_policy_server_); - policy_helper_->SetPolicy( - base::DictionaryValue() /* empty mandatory policy */, - base::DictionaryValue() /* empty recommended policy */); + void SetUpOnMainThread() override; - command_line->AppendSwitchASCII(chromeos::switches::kLoginUser, - kFakeUserName); - command_line->AppendSwitchASCII(chromeos::switches::kLoginProfile, - TestingProfile::kTestUserProfileDir); - // Don't require policy for our sessions - this is required because - // this test creates a secondary profile synchronously, so we need to - // let the policy code know not to expect cached policy. - command_line->AppendSwitchASCII(chromeos::switches::kProfileRequiresPolicy, - "false"); + void TearDownOnMainThread() override; - // Tell the policy subsystem to wait for an initial policy load, even - // though we are using a synchronously loaded profile. - // TODO(edmanp): `Update this test to properly use an asynchronously loaded - // user profile and remove the use of this flag (crbug.com/795737). - command_line->AppendSwitchASCII( - chromeos::switches::kWaitForInitialPolicyFetchForTest, "true"); - } + void TearDownInProcessBrowserTestFixture() override; - void SetUp() override { - chromeos::platform_keys::PlatformKeysServiceFactory::GetInstance() - ->SetTestingMode(true); + // Installs the given |certs_to_setup| in the NSS database. Will block until + // all install events are processed by CertStoreService. + void SetUpCerts(const std::vector<TestCertData>& certs_to_setup); - MixinBasedInProcessBrowserTest::SetUp(); - } + // Registers the given |cert| as corporate usage through platform keys. + void RegisterCorporateKey(CERTCertificate* cert); - void SetUpOnMainThread() override { - MixinBasedInProcessBrowserTest::SetUpOnMainThread(); + // Deletes the given |cert| from the NSS cert database. Will block until this + // delete event is processed by CertStoreService. + void DeleteCert(CERTCertificate* cert); - policy_helper_->WaitForInitialPolicy(browser()->profile()); + // Verifies the expected |test_certs| are installed correctly. + void CheckInstalledCerts(std::vector<TestCertData> test_certs, + CertStoreService* service); - // Init ArcSessionManager for testing. - ArcServiceLauncher::Get()->ResetForTesting(); + // Returns the profile for the |affiliation_mixin_| account. + Profile* profile(); - chromeos::ProfileHelper::SetAlwaysReturnPrimaryUserForTesting(true); + // Owned by the CertStoreService instance. + FakeArcCertInstaller* installer_; - browser()->profile()->GetPrefs()->SetBoolean(prefs::kArcSignedIn, true); - browser()->profile()->GetPrefs()->SetBoolean(prefs::kArcTermsAccepted, - true); + std::vector<InstalledTestCert> installed_certs_; - ArcKeymasterBridge::GetFactory()->SetTestingFactoryAndUse( - browser()->profile(), - base::BindRepeating(&BuildFakeArcKeymasterBridge)); - auto* keymaster_bridge = - ArcKeymasterBridge::GetForBrowserContext(browser()->profile()); - keymaster_bridge_ = static_cast<FakeArcKeymasterBridge*>(keymaster_bridge); - - auto installer = std::make_unique<FakeArcCertInstaller>( - browser()->profile(), std::make_unique<policy::RemoteCommandsQueue>()); - installer_ = installer.get(); - CertStoreService::GetFactory()->SetTestingFactoryAndUse( - browser()->profile(), - base::BindRepeating(&BuildCertStoreService, - base::Passed(std::move(installer)))); - - ArcServiceLauncher::Get()->OnPrimaryUserProfilePrepared( - browser()->profile()); - } - - void TearDownOnMainThread() override { - // Since ArcServiceLauncher is (re-)set up with profile() in - // SetUpOnMainThread() it is necessary to Shutdown() before the profile() - // is destroyed. ArcServiceLauncher::Shutdown() will be called again on - // fixture destruction (because it is initialized with the original Profile - // instance in fixture, once), but it should be no op. - ArcServiceLauncher::Get()->Shutdown(); - chromeos::ProfileHelper::SetAlwaysReturnPrimaryUserForTesting(false); - MixinBasedInProcessBrowserTest::TearDownOnMainThread(); - } - - void TearDown() override { - MixinBasedInProcessBrowserTest::TearDown(); - - chromeos::platform_keys::PlatformKeysServiceFactory::GetInstance() - ->SetTestingMode(false); - } - - void RegisterCorporateKey(CERTCertificate* cert) { - base::RunLoop run_loop; - chromeos::platform_keys::ExtensionKeyPermissionsServiceFactory:: - GetForBrowserContextAndExtension( - base::BindOnce(&CertStoreServiceTest::GotPermissionsForExtension, - base::Unretained(this), cert, - run_loop.QuitClosure()), - browser()->profile(), kFakeExtensionId); - run_loop.Run(); - } - - void SetUpCerts(const std::vector<std::string>& keys_file_names, - bool is_corporate_usage_key) { - // Read certs from files. - base::RunLoop loop; - GetNSSCertDatabaseForProfile( - browser()->profile(), - base::BindOnce(&CertStoreServiceTest::SetUpTestClientCerts, - base::Unretained(this), keys_file_names, - loop.QuitClosure())); - loop.Run(); - // Register certs for corporate usage if needed. - for (auto& cert : client_certs_) { - // Certificates must be imported. - ASSERT_TRUE(cert); - if (is_corporate_usage_key) - RegisterCorporateKey(cert.get()); - } - - // Import certs into database. - { - base::RunLoop loop; - GetNSSCertDatabaseForProfile( - browser()->profile(), - base::BindOnce(&CertStoreServiceTest::ImportTestClientCerts, - base::Unretained(this), loop.QuitClosure())); - loop.Run(); - } - } - - void DeleteCert(CERTCertificate* cert) { - base::RunLoop loop; - GetNSSCertDatabaseForProfile( - browser()->profile(), - base::BindOnce(&CertStoreServiceTest::DeleteCertAndKey, - base::Unretained(this), cert, loop.QuitClosure())); - loop.Run(); - } - - bool PlaceholdersContainId(const std::string& id) { - for (const auto& key : keymaster_bridge()->placeholder_keys()) { - if (key->key_data->is_chaps_key_data() && - key->key_data->get_chaps_key_data()->id == id) { - return true; - } - } - return false; - } - - void CheckInstalledCerts(size_t installed_cert_num, - CertStoreService* service) { - EXPECT_EQ(installed_cert_num, client_certs_.size()); - EXPECT_EQ(installed_cert_num, installer()->certs().size()); - EXPECT_EQ(installed_cert_num, service->get_required_cert_names().size()); - EXPECT_EQ(installed_cert_num, - keymaster_bridge()->placeholder_keys().size()); - - for (const auto& cert_name : service->get_required_cert_names()) { - bool found = false; - // Check the required cert is installed. - ASSERT_TRUE(installer()->certs().count(cert_name)); - for (const auto& cert : client_certs_) { - // Check the required cert is one of the imported for the test - // certificates. - if (GetDerCert64(cert.get()) == installer()->certs()[cert_name]) { - // Check nickname. - EXPECT_EQ(x509_certificate_model::GetCertNameOrNickname(cert.get()), - cert_name); - found = true; - // Check KeyInfo. - auto key_info = - service->GetKeyInfoForDummySpki(installer()->certs()[cert_name]); - EXPECT_TRUE(key_info.has_value()); - EXPECT_EQ(key_info.value().nickname, cert_name); - int slot_id; - // Check CKA_ID. - std::string hex_encoded_id = base::HexEncode( - key_info.value().id.data(), key_info.value().id.size()); - EXPECT_EQ(hex_encoded_id, - chromeos::NetworkCertLoader::GetPkcs11IdAndSlotForCert( - cert.get(), &slot_id)); - EXPECT_TRUE(PlaceholdersContainId(key_info.value().id)); - break; - } - } - // Check the required cert was found. - EXPECT_TRUE(found); - } - } - - FakeArcCertInstaller* installer() { return installer_; } - - FakeArcKeymasterBridge* keymaster_bridge() { return keymaster_bridge_; } - - net::ScopedCERTCertificateList client_certs_; + chromeos::DeviceStateMixin device_state_{ + &mixin_host_, + chromeos::DeviceStateMixin::State::OOBE_COMPLETED_CLOUD_ENROLLED}; + policy::DevicePolicyCrosTestHelper device_policy_helper_; + policy::AffiliationMixin affiliation_mixin_{&mixin_host_, + &device_policy_helper_}; private: - void OnKeyRegisteredForCorporateUsage( - std::unique_ptr<chromeos::platform_keys::ExtensionKeyPermissionsService> - extension_key_permissions_service, - base::OnceClosure done_callback, - bool is_error, - crosapi::mojom::KeystoreError error) { - ASSERT_FALSE(is_error) << static_cast<int>(error); - std::move(done_callback).Run(); - } - - // Register only client_cert1_ for corporate usage to test that - // client_cert2_ is not allowed. - void GotPermissionsForExtension( - CERTCertificate* cert, - base::OnceClosure done_callback, - std::unique_ptr<chromeos::platform_keys::ExtensionKeyPermissionsService> - extension_key_permissions_service) { - auto* extension_key_permissions_service_unowned = - extension_key_permissions_service.get(); - std::string client_cert_spki( - cert->derPublicKey.data, - cert->derPublicKey.data + cert->derPublicKey.len); - extension_key_permissions_service_unowned->RegisterKeyForCorporateUsage( - client_cert_spki, - base::BindOnce(&CertStoreServiceTest::OnKeyRegisteredForCorporateUsage, - base::Unretained(this), - std::move(extension_key_permissions_service), - std::move(done_callback))); - } - - void SetUpTestClientCerts(const std::vector<std::string>& key_file_names, + // Creates ScopedCERTCertificates for each |certs_to_setup| and appends them + // to |installed_certs_|. + void SetUpTestClientCerts(const std::vector<TestCertData>& certs_to_setup, base::OnceClosure done_callback, - net::NSSCertDatabase* cert_db) { - for (const auto& file_name : key_file_names) { - base::ScopedAllowBlockingForTesting allow_io; - net::ImportSensitiveKeyFromFile(net::GetTestCertsDirectory(), - file_name + ".pk8", - cert_db->GetPrivateSlot().get()); - net::ScopedCERTCertificateList certs = - net::CreateCERTCertificateListFromFile( - net::GetTestCertsDirectory(), file_name + ".pem", - net::X509Certificate::FORMAT_AUTO); - EXPECT_EQ(1U, certs.size()); - if (certs.size() != 1U) { - std::move(done_callback).Run(); - return; - } + net::NSSCertDatabase* cert_db); - client_certs_.emplace_back( - net::x509_util::DupCERTCertificate(certs[0].get())); - } - std::move(done_callback).Run(); - } + // Imports the given |nss_cert| into the NSS |cert_db|. + void ImportCert(CERTCertificate* const nss_cert, + base::OnceClosure done_callback, + net::NSSCertDatabase* cert_db); - void ImportTestClientCerts(base::OnceClosure done_callback, - net::NSSCertDatabase* cert_db) { - for (const auto& cert : client_certs_) { - // Import user certificate properly how it's done in PlatfromKeys. - cert_db->ImportUserCert(cert.get()); - } - std::move(done_callback).Run(); - } + // Checks that |keymaster_bridge_->placeholder_keys()| contains a key with + // given |id| and |slot|. + bool PlaceholdersContainIdAndSlot(const std::string& id, + keymaster::mojom::ChapsSlot slot); - void DeleteCertAndKey(CERTCertificate* cert, - base::OnceClosure done_callback, - net::NSSCertDatabase* cert_db) { - base::ScopedAllowBlockingForTesting allow_io; - EXPECT_TRUE(cert_db->DeleteCertAndKey(cert)); - std::move(done_callback).Run(); - } + // Initializes |test_system_slot_|. + void SetUpTestSystemSlot(); - std::unique_ptr<policy::UserPolicyTestHelper> policy_helper_; - chromeos::LocalPolicyTestServerMixin local_policy_server_{&mixin_host_}; + void SetUpTestSystemSlotOnIO(bool* out_system_slot_constructed_successfully); - // Owned by service. - FakeArcCertInstaller* installer_; + // Destroys |test_system_slot_|. + void TearDownTestSystemSlot(); + + void TearDownTestSystemSlotOnIO(); + + std::unique_ptr<crypto::ScopedTestSystemNSSKeySlot> test_system_slot_; + + // Owned by the CertStoreService instance. FakeArcKeymasterBridge* keymaster_bridge_; }; -// Test no corporate usage keys. -IN_PROC_BROWSER_TEST_F(CertStoreServiceTest, Basic) { - CertStoreService* service = - CertStoreService::GetForBrowserContext(browser()->profile()); - ASSERT_TRUE(service); - - // Import 2 certs into DB. No corporate usage keys. - ASSERT_NO_FATAL_FAILURE( - SetUpCerts(kCertFiles, false /* is_corporate_usage */)); - installer()->Wait(); - installer()->RunCompletionCallback(true /* success */); - - EXPECT_EQ(kCertFiles.size(), client_certs_.size()); - // No corporate usage keys installed. - EXPECT_TRUE(installer()->certs().empty()); - EXPECT_TRUE(service->get_required_cert_names().empty()); - EXPECT_TRUE(keymaster_bridge()->placeholder_keys().empty()); +void CertStoreServiceTest::SetUpCommandLine(base::CommandLine* command_line) { + MixinBasedInProcessBrowserTest::SetUpCommandLine(command_line); + arc::SetArcAvailableCommandLineForTesting(command_line); + policy::AffiliationTestHelper::AppendCommandLineSwitchesForLoginManager( + command_line); } -// Test installation of 2 corporate usage keys. -IN_PROC_BROWSER_TEST_F(CertStoreServiceTest, InstalledCorporateUsageKeys) { - CertStoreService* service = - CertStoreService::GetForBrowserContext(browser()->profile()); - EXPECT_EQ(browser()->profile(), - Profile::FromBrowserContext(browser()->profile())); +void CertStoreServiceTest::SetUpInProcessBrowserTestFixture() { + MixinBasedInProcessBrowserTest::SetUpInProcessBrowserTestFixture(); + chromeos::platform_keys::PlatformKeysServiceFactory::GetInstance() + ->SetTestingMode(true); +} + +void CertStoreServiceTest::SetUpOnMainThread() { + MixinBasedInProcessBrowserTest::SetUpOnMainThread(); + + // Pre tests need no further setup. + if (content::IsPreTest()) + return; + + policy::AffiliationTestHelper::LoginUser(affiliation_mixin_.account_id()); + + // Use fake ArcKeymasterBridge. + ArcKeymasterBridge::GetFactory()->SetTestingFactoryAndUse( + profile(), base::BindRepeating(&BuildFakeArcKeymasterBridge)); + auto* keymaster_bridge = ArcKeymasterBridge::GetForBrowserContext(profile()); + keymaster_bridge_ = static_cast<FakeArcKeymasterBridge*>(keymaster_bridge); + + // Use fake ArcCertInstaller in CertStoreService. + auto installer = std::make_unique<FakeArcCertInstaller>( + profile(), std::make_unique<policy::RemoteCommandsQueue>()); + installer_ = installer.get(); + CertStoreService::GetFactory()->SetTestingFactoryAndUse( + profile(), base::BindRepeating(&BuildCertStoreService, + base::Passed(std::move(installer)))); + + // Set up a system slot so tests can access device certs. + ASSERT_NO_FATAL_FAILURE(SetUpTestSystemSlot()); + ASSERT_TRUE(IsSystemSlotAvailable(profile())); +} + +void CertStoreServiceTest::TearDownOnMainThread() { + TearDownTestSystemSlot(); + MixinBasedInProcessBrowserTest::TearDownOnMainThread(); +} + +void CertStoreServiceTest::TearDownInProcessBrowserTestFixture() { + chromeos::platform_keys::PlatformKeysServiceFactory::GetInstance() + ->SetTestingMode(false); + MixinBasedInProcessBrowserTest::TearDownInProcessBrowserTestFixture(); +} + +void CertStoreServiceTest::SetUpCerts( + const std::vector<TestCertData>& certs_to_setup) { + // Remember current size of |installed_certs_| before new certs. + size_t initial_size = installed_certs_.size(); + + // Read certs from files. + base::RunLoop loop; + GetNSSCertDatabaseForProfile( + profile(), base::BindOnce(&CertStoreServiceTest::SetUpTestClientCerts, + base::Unretained(this), certs_to_setup, + loop.QuitClosure())); + loop.Run(); + + // Verify |certs_to_setup.size()| new certs have been installed. + ASSERT_EQ(installed_certs_.size(), certs_to_setup.size() + initial_size); + + // Process all new certs. + for (size_t i = initial_size; i < installed_certs_.size(); ++i) { + const InstalledTestCert& cert = installed_certs_[i]; + // Register cert for corporate usage if needed. + if (cert.test_data.is_corporate_usage) + RegisterCorporateKey(cert.nss_cert.get()); + // Import cert to NSS cert database. + base::RunLoop loop; + GetNSSCertDatabaseForProfile( + profile(), base::BindOnce(&CertStoreServiceTest::ImportCert, + base::Unretained(this), cert.nss_cert.get(), + loop.QuitClosure())); + loop.Run(); + // Wait till new cert event is processed by CertStoreService. + installer_->Wait(); + installer_->RunCompletionCallback(true /* success */); + } +} + +void CertStoreServiceTest::RegisterCorporateKey(CERTCertificate* cert) { + base::RunLoop run_loop; + chromeos::platform_keys::ExtensionKeyPermissionsServiceFactory:: + GetForBrowserContextAndExtension( + base::BindOnce(&RegisterCorporateKeyWithService, cert, + run_loop.QuitClosure()), + profile(), kFakeExtensionId); + run_loop.Run(); +} + +void CertStoreServiceTest::DeleteCert(CERTCertificate* cert) { + base::RunLoop loop; + GetNSSCertDatabaseForProfile( + profile(), base::BindOnce(&DeleteCertAndKey, cert, loop.QuitClosure())); + loop.Run(); + installed_certs_.pop_back(); + // Wait till deleted cert event is processed by CertStoreService. + installer_->Wait(); + installer_->RunCompletionCallback(true /* success */); +} + +void CertStoreServiceTest::CheckInstalledCerts( + std::vector<TestCertData> test_certs, + CertStoreService* service) { + // Verify the number of corporate usage certs reported is correct. + EXPECT_EQ(CountCorporateUsage(test_certs), installer_->certs().size()); + EXPECT_EQ(CountCorporateUsage(test_certs), + service->get_required_cert_names().size()); + EXPECT_EQ(CountCorporateUsage(test_certs), + keymaster_bridge_->placeholder_keys().size()); + + // Verify |test_certs| and |installed_certs_| have matching elements. + ASSERT_EQ(test_certs.size(), installed_certs_.size()); + for (size_t i = 0; i < installed_certs_.size(); ++i) + EXPECT_EQ(test_certs[i], installed_certs_[i].test_data); + + for (const auto& cert_name : service->get_required_cert_names()) { + bool found = false; + // Check the required cert is installed. + ASSERT_TRUE(installer_->certs().count(cert_name)); + for (const auto& cert : installed_certs_) { + // Check the required cert is one of the installed test certificates. + const net::ScopedCERTCertificate& nss_cert = cert.nss_cert; + + // Skip until |cert| corresponds to the current |cert_name|. + if (GetDerCert64(nss_cert.get()) != installer_->certs()[cert_name]) + continue; + + // Check nickname. + EXPECT_EQ(x509_certificate_model::GetCertNameOrNickname(nss_cert.get()), + cert_name); + found = true; + // Check KeyInfo. + auto key_info = + service->GetKeyInfoForDummySpki(installer_->certs()[cert_name]); + EXPECT_TRUE(key_info.has_value()); + EXPECT_EQ(key_info.value().nickname, cert_name); + // Check CKA_ID and slot. + int slot_id; + std::string hex_encoded_id = base::HexEncode(key_info.value().id.data(), + key_info.value().id.size()); + EXPECT_EQ(hex_encoded_id, + chromeos::NetworkCertLoader::GetPkcs11IdAndSlotForCert( + nss_cert.get(), &slot_id)); + EXPECT_TRUE(PlaceholdersContainIdAndSlot(key_info.value().id, + cert.test_data.slot)); + break; + } + // Check the required cert was found. + EXPECT_TRUE(found); + } +} + +Profile* CertStoreServiceTest::profile() { + return chromeos::ProfileHelper::Get()->GetProfileByAccountId( + affiliation_mixin_.account_id()); +} + +void CertStoreServiceTest::SetUpTestClientCerts( + const std::vector<TestCertData>& certs_to_setup, + base::OnceClosure done_callback, + net::NSSCertDatabase* cert_db) { + for (const auto& test_data : certs_to_setup) { + base::ScopedAllowBlockingForTesting allow_io; + net::ImportSensitiveKeyFromFile( + net::GetTestCertsDirectory(), test_data.file_name + ".pk8", + test_data.slot == keymaster::mojom::ChapsSlot::kUser + ? cert_db->GetPrivateSlot().get() + : cert_db->GetSystemSlot().get()); + net::ScopedCERTCertificateList certs = + net::CreateCERTCertificateListFromFile( + net::GetTestCertsDirectory(), test_data.file_name + ".pem", + net::X509Certificate::FORMAT_AUTO); + ASSERT_EQ(1U, certs.size()); + + installed_certs_.emplace_back( + test_data, net::x509_util::DupCERTCertificate(certs[0].get())); + } + std::move(done_callback).Run(); +} + +void CertStoreServiceTest::ImportCert(CERTCertificate* const nss_cert, + base::OnceClosure done_callback, + net::NSSCertDatabase* cert_db) { + // Import user certificate properly how it's done in PlatformKeys. + cert_db->ImportUserCert(nss_cert); + std::move(done_callback).Run(); +} + +bool CertStoreServiceTest::PlaceholdersContainIdAndSlot( + const std::string& id, + keymaster::mojom::ChapsSlot slot) { + for (const auto& key : keymaster_bridge_->placeholder_keys()) { + if (key->key_data->is_chaps_key_data() && + key->key_data->get_chaps_key_data()->id == id && + key->key_data->get_chaps_key_data()->slot == slot) { + return true; + } + } + return false; +} + +void CertStoreServiceTest::SetUpTestSystemSlot() { + bool system_slot_constructed_successfully = false; + base::RunLoop loop; + content::GetIOThreadTaskRunner({})->PostTaskAndReply( + FROM_HERE, + base::BindOnce(&CertStoreServiceTest::SetUpTestSystemSlotOnIO, + base::Unretained(this), + &system_slot_constructed_successfully), + loop.QuitClosure()); + loop.Run(); + ASSERT_TRUE(system_slot_constructed_successfully); +} + +void CertStoreServiceTest::SetUpTestSystemSlotOnIO( + bool* out_system_slot_constructed_successfully) { + DCHECK_CURRENTLY_ON(content::BrowserThread::IO); + test_system_slot_ = std::make_unique<crypto::ScopedTestSystemNSSKeySlot>(); + *out_system_slot_constructed_successfully = + test_system_slot_->ConstructedSuccessfully(); +} + +void CertStoreServiceTest::TearDownTestSystemSlot() { + if (!test_system_slot_) + return; + + base::RunLoop loop; + content::GetIOThreadTaskRunner({})->PostTaskAndReply( + FROM_HERE, + base::BindOnce(&CertStoreServiceTest::TearDownTestSystemSlotOnIO, + base::Unretained(this)), + loop.QuitClosure()); + loop.Run(); +} + +void CertStoreServiceTest::TearDownTestSystemSlotOnIO() { + DCHECK_CURRENTLY_ON(content::BrowserThread::IO); + test_system_slot_.reset(); +} + +IN_PROC_BROWSER_TEST_P(CertStoreServiceTest, PRE_HandlesCorporateUsageCerts) { + policy::AffiliationTestHelper::PreLoginUser(affiliation_mixin_.account_id()); +} + +IN_PROC_BROWSER_TEST_P(CertStoreServiceTest, HandlesCorporateUsageCerts) { + CertStoreService* service = CertStoreService::GetForBrowserContext(profile()); ASSERT_TRUE(service); - size_t installed_cert_num = 0; + // Install all certs from parameter at once. + ASSERT_NO_FATAL_FAILURE(SetUpCerts(GetParam())); - // Import and register corporate certificates. - for (const auto& file : kCertFiles) { + // Verify all certs are installed correctly. + ASSERT_NO_FATAL_FAILURE(CheckInstalledCerts(GetParam(), service)); +} + +IN_PROC_BROWSER_TEST_P(CertStoreServiceTest, + PRE_InstallsAndDeletesCorporateUsageCerts) { + policy::AffiliationTestHelper::PreLoginUser(affiliation_mixin_.account_id()); +} + +IN_PROC_BROWSER_TEST_P(CertStoreServiceTest, + InstallsAndDeletesCorporateUsageCerts) { + CertStoreService* service = CertStoreService::GetForBrowserContext(profile()); + ASSERT_TRUE(service); + + // Install certs from parameter one by one. + for (size_t i = 0; i < GetParam().size(); ++i) { + ASSERT_NO_FATAL_FAILURE(SetUpCerts({GetParam()[i]})); + + // Verify only the first (i+1) certs are installed so far. ASSERT_NO_FATAL_FAILURE( - SetUpCerts({file}, true /* is_corporate_usage_key */)); - installer()->Wait(); - installer()->RunCompletionCallback(true /* success */); + CheckInstalledCerts(std::vector<TestCertData>( + GetParam().begin(), GetParam().begin() + i + 1), + service)); + } - installed_cert_num++; - CheckInstalledCerts(installed_cert_num, service); + // Uninstall certs from parameter one by one, from last to first. + for (size_t i = GetParam().size(); i--;) { + DeleteCert(installed_certs_.back().nss_cert.get()); + + // Verify only the first i certs are left after the uninstall. + ASSERT_NO_FATAL_FAILURE(CheckInstalledCerts( + std::vector<TestCertData>(GetParam().begin(), GetParam().begin() + i), + service)); } } -// Test uninstallation of 2 corporate usage keys. -IN_PROC_BROWSER_TEST_F(CertStoreServiceTest, UninstalledCorporateUsageKeys) { - CertStoreService* service = - CertStoreService::GetForBrowserContext(browser()->profile()); - EXPECT_EQ(browser()->profile(), - Profile::FromBrowserContext(browser()->profile())); - ASSERT_TRUE(service); - - installer()->Wait(); - installer()->RunCompletionCallback(true /* success */); - - CheckInstalledCerts(0, service); - ASSERT_NO_FATAL_FAILURE( - SetUpCerts({kCertFiles}, true /* is_corporate_usage_key */)); - installer()->Wait(); - installer()->RunCompletionCallback(true /* success */); - CheckInstalledCerts(kCertFiles.size(), service); - - size_t installed_cert_num = kCertFiles.size(); - while (!client_certs_.empty()) { - DeleteCert(client_certs_.back().get()); - installer()->Wait(); - installer()->RunCompletionCallback(true /* success */); - - client_certs_.pop_back(); - installed_cert_num--; - CheckInstalledCerts(installed_cert_num, service); - } -} +INSTANTIATE_TEST_SUITE_P( + CertStoreTests, + CertStoreServiceTest, + ::testing::Values( + // No corporate usage keys. + std::vector<TestCertData>{ + TestCertData(kFileName1, + false /* is_corporate_usage */, + keymaster::mojom::ChapsSlot::kUser), + TestCertData(kFileName2, + false /* is_corporate_usage */, + keymaster::mojom::ChapsSlot::kUser)}, + // Corporate usage keys in user slot. + std::vector<TestCertData>{ + TestCertData(kFileName1, + true /* is_corporate_usage */, + keymaster::mojom::ChapsSlot::kUser), + TestCertData(kFileName2, + true /* is_corporate_usage */, + keymaster::mojom::ChapsSlot::kUser)}, + // Corporate usage keys in system slot. + std::vector<TestCertData>{ + TestCertData(kFileName1, + true /* is_corporate_usage */, + keymaster::mojom::ChapsSlot::kSystem), + TestCertData(kFileName2, + true /* is_corporate_usage */, + keymaster::mojom::ChapsSlot::kSystem)}, + // Corporate usage keys in both slots. + std::vector<TestCertData>{ + TestCertData(kFileName1, + true /* is_corporate_usage */, + keymaster::mojom::ChapsSlot::kUser), + TestCertData(kFileName2, + true /* is_corporate_usage */, + keymaster::mojom::ChapsSlot::kSystem), + TestCertData(kFileName3, + false /* is_corporate_usage */, + keymaster::mojom::ChapsSlot::kUser), + TestCertData(kFileName4, + true /* is_corporate_usage */, + keymaster::mojom::ChapsSlot::kSystem)})); } // namespace arc
diff --git a/chrome/browser/ash/scanning/fake_lorgnette_scanner_manager.cc b/chrome/browser/ash/scanning/fake_lorgnette_scanner_manager.cc index 78aeedb..106d0d4 100644 --- a/chrome/browser/ash/scanning/fake_lorgnette_scanner_manager.cc +++ b/chrome/browser/ash/scanning/fake_lorgnette_scanner_manager.cc
@@ -10,9 +10,61 @@ #include "base/location.h" #include "base/single_thread_task_runner.h" #include "base/threading/thread_task_runner_handle.h" +#include "third_party/re2/src/re2/re2.h" namespace ash { +namespace { + +// A list of Epson models that do not rotate alternating ADF scanned pages +// to be excluded in IsRotateAlternate(). +constexpr char kEpsonNoFlipModels[] = + "\\b(" + "DS-790WN" + "|LP-M8180A" + "|LP-M8180F" + "|LX-10020M" + "|LX-10050KF" + "|LX-10050MF" + "|LX-6050MF" + "|LX-7550MF" + "|PX-M7070FX" + "|PX-M7080FX" + "|PX-M7090FX" + "|PX-M7110F" + "|PX-M7110FP" + "|PX-M860F" + "|PX-M880FX" + "|WF-6530" + "|WF-6590" + "|WF-6593" + "|WF-C20600" + "|WF-C20600a" + "|WF-C20600c" + "|WF-C20750" + "|WF-C20750a" + "|WF-C20750c" + "|WF-C21000" + "|WF-C21000a" + "|WF-C21000c" + "|WF-C579R" + "|WF-C579Ra" + "|WF-C8610" + "|WF-C8690" + "|WF-C8690a" + "|WF-C869R" + "|WF-C869Ra" + "|WF-C878R" + "|WF-C878Ra" + "|WF-C879R" + "|WF-C879Ra" + "|WF-M21000" + "|WF-M21000a" + "|WF-M21000c" + ")\\b"; + +} // namespace + FakeLorgnetteScannerManager::FakeLorgnetteScannerManager() = default; FakeLorgnetteScannerManager::~FakeLorgnetteScannerManager() = default; @@ -30,6 +82,25 @@ FROM_HERE, base::BindOnce(std::move(callback), scanner_capabilities_)); } +bool FakeLorgnetteScannerManager::IsRotateAlternate( + const std::string& scanner_name, + const std::string& source_name) { + if (!RE2::PartialMatch(source_name, RE2("(?i)adf duplex"))) { + return false; + } + + // No implementation of GetUsableDeviceNameAndProtocol() available + // so assume scanner name is formatted as device_name. + std::string exclude_regex = std::string("^(airscan|ippusb).*(EPSON\\s+)?") + + std::string(kEpsonNoFlipModels); + if (RE2::PartialMatch(scanner_name, RE2("^(epsonds|epson2)")) || + RE2::PartialMatch(scanner_name, RE2(exclude_regex))) { + return false; + } + + return RE2::PartialMatch(scanner_name, RE2("(?i)epson")); +} + void FakeLorgnetteScannerManager::Scan(const std::string& scanner_name, const lorgnette::ScanSettings& settings, ProgressCallback progress_callback,
diff --git a/chrome/browser/ash/scanning/fake_lorgnette_scanner_manager.h b/chrome/browser/ash/scanning/fake_lorgnette_scanner_manager.h index b4cee1c..c2722e4 100644 --- a/chrome/browser/ash/scanning/fake_lorgnette_scanner_manager.h +++ b/chrome/browser/ash/scanning/fake_lorgnette_scanner_manager.h
@@ -28,6 +28,8 @@ void GetScannerNames(GetScannerNamesCallback callback) override; void GetScannerCapabilities(const std::string& scanner_name, GetScannerCapabilitiesCallback callback) override; + bool IsRotateAlternate(const std::string& scanner_name, + const std::string& source_name) override; void Scan(const std::string& scanner_name, const lorgnette::ScanSettings& settings, ProgressCallback progress_callback,
diff --git a/chrome/browser/ash/scanning/lorgnette_scanner_manager.cc b/chrome/browser/ash/scanning/lorgnette_scanner_manager.cc index 5ea1998c..7aedff4 100644 --- a/chrome/browser/ash/scanning/lorgnette_scanner_manager.cc +++ b/chrome/browser/ash/scanning/lorgnette_scanner_manager.cc
@@ -30,6 +30,53 @@ namespace { +// A list of Epson models that do not rotate alternating ADF scanned pages +// to be excluded in IsRotateAlternate(). +constexpr char kEpsonNoFlipModels[] = + "\\b(" + "DS-790WN" + "|LP-M8180A" + "|LP-M8180F" + "|LX-10020M" + "|LX-10050KF" + "|LX-10050MF" + "|LX-6050MF" + "|LX-7550MF" + "|PX-M7070FX" + "|PX-M7080FX" + "|PX-M7090FX" + "|PX-M7110F" + "|PX-M7110FP" + "|PX-M860F" + "|PX-M880FX" + "|WF-6530" + "|WF-6590" + "|WF-6593" + "|WF-C20600" + "|WF-C20600a" + "|WF-C20600c" + "|WF-C20750" + "|WF-C20750a" + "|WF-C20750c" + "|WF-C21000" + "|WF-C21000a" + "|WF-C21000c" + "|WF-C579R" + "|WF-C579Ra" + "|WF-C8610" + "|WF-C8690" + "|WF-C8690a" + "|WF-C869R" + "|WF-C869Ra" + "|WF-C878R" + "|WF-C878Ra" + "|WF-C879R" + "|WF-C879Ra" + "|WF-M21000" + "|WF-M21000a" + "|WF-M21000c" + ")\\b"; + // A prioritized list of scan protocols. Protocols that appear earlier in the // list are preferred over those that appear later in the list when // communicating with a connected scanner. @@ -108,6 +155,30 @@ } // LorgnetteScannerManager: + bool IsRotateAlternate(const std::string& scanner_name, + const std::string& source_name) override { + if (!RE2::PartialMatch(source_name, RE2("(?i)adf duplex"))) { + return false; + } + + std::string device_name; + chromeos::ScanProtocol protocol; + if (!GetUsableDeviceNameAndProtocol(scanner_name, device_name, protocol)) { + LOG(ERROR) << "Failed to get device name for " << scanner_name; + return false; + } + + std::string exclude_regex = std::string("^(airscan|ippusb).*(EPSON\\s+)?") + + std::string(kEpsonNoFlipModels); + if (RE2::PartialMatch(device_name, RE2("^(epsonds|epson2)")) || + RE2::PartialMatch(device_name, RE2(exclude_regex))) { + return false; + } + + return RE2::PartialMatch(device_name, RE2("(?i)epson")); + } + + // LorgnetteScannerManager: void Scan(const std::string& scanner_name, const lorgnette::ScanSettings& settings, ProgressCallback progress_callback,
diff --git a/chrome/browser/ash/scanning/lorgnette_scanner_manager.h b/chrome/browser/ash/scanning/lorgnette_scanner_manager.h index e2381f4..b8a98cd 100644 --- a/chrome/browser/ash/scanning/lorgnette_scanner_manager.h +++ b/chrome/browser/ash/scanning/lorgnette_scanner_manager.h
@@ -52,6 +52,11 @@ const std::string& scanner_name, GetScannerCapabilitiesCallback callback) = 0; + // Returns whether or not an ADF scanner that flips alternate pages was + // selected based on |scanner_name| and |source_name|. + virtual bool IsRotateAlternate(const std::string& scanner_name, + const std::string& source_name) = 0; + // Performs a scan with the scanner specified by |scanner_name| using the // given |scan_properties|. As each page is scanned, |progress_callback| is // called with the current progress percent from 0 to 100. As each scanned
diff --git a/chrome/browser/ash/scanning/lorgnette_scanner_manager_unittest.cc b/chrome/browser/ash/scanning/lorgnette_scanner_manager_unittest.cc index 7ce24070..9e7c18b0 100644 --- a/chrome/browser/ash/scanning/lorgnette_scanner_manager_unittest.cc +++ b/chrome/browser/ash/scanning/lorgnette_scanner_manager_unittest.cc
@@ -80,6 +80,16 @@ .value(); } +// Returns a zeroconf Scanner with |scanner_name| and device name marked +// |usable|. +Scanner CreateScannerCustomName(const std::string& scanner_name, + bool usable = true) { + return CreateSaneAirscanScanner(scanner_name, + ZeroconfScannerDetector::kEsclsServiceType, + "", net::IPAddress(192, 168, 0, 3), 5, usable) + .value(); +} + class FakeZeroconfScannerDetector final : public ZeroconfScannerDetector { public: FakeZeroconfScannerDetector() = default; @@ -170,6 +180,13 @@ base::Unretained(this))); } + // Calls LorgnetteScannerManager::IsRotateAlternate() and returns result. + bool GetRotateAlternate(const std::string& scanner_name, + const std::string& source_name) { + return lorgnette_scanner_manager_->IsRotateAlternate(scanner_name, + source_name); + } + // Calls LorgnetteScannerManager::Scan() and binds a callback to process the // result. void Scan(const std::string& scanner_name, @@ -501,6 +518,46 @@ EXPECT_EQ(failure_mode(), lorgnette::SCAN_FAILURE_MODE_UNKNOWN); } +// Test that images aren't rotated when scanner isn't an Epson scanner. +TEST_F(LorgnetteScannerManagerTest, ScanNotRotatedNonEpson) { + auto scanner = CreateZeroconfScanner(); + fake_zeroconf_scanner_detector()->AddDetections({scanner}); + CompleteTasks(); + GetScannerNames(); + WaitForResult(); + EXPECT_FALSE(GetRotateAlternate(scanner.display_name, "ADF Duplex")); +} + +// Test that images aren't rotated when scanner is a non-rotating Epson scanner. +TEST_F(LorgnetteScannerManagerTest, ScanNotRotatedEpsonException) { + auto scanner = CreateScannerCustomName("Epson WF-C579Ra"); + fake_zeroconf_scanner_detector()->AddDetections({scanner}); + CompleteTasks(); + GetScannerNames(); + WaitForResult(); + EXPECT_FALSE(GetRotateAlternate(scanner.display_name, "ADF Duplex")); +} + +// Test that images aren't rotated when scan request is non-ADF. +TEST_F(LorgnetteScannerManagerTest, ScanNotRotatedNonADF) { + auto scanner = CreateScannerCustomName("Epson XP-7100"); + fake_zeroconf_scanner_detector()->AddDetections({scanner}); + CompleteTasks(); + GetScannerNames(); + WaitForResult(); + EXPECT_FALSE(GetRotateAlternate(scanner.display_name, "Flatbed")); +} + +// Test that scanned images are rotated when scanner setup requires it. +TEST_F(LorgnetteScannerManagerTest, ScanRotated) { + auto scanner = CreateScannerCustomName("Epson XP-7100"); + fake_zeroconf_scanner_detector()->AddDetections({scanner}); + CompleteTasks(); + GetScannerNames(); + WaitForResult(); + EXPECT_TRUE(GetRotateAlternate(scanner.display_name, "ADF Duplex")); +} + // Test that scanning succeeds with a valid scanner name. TEST_F(LorgnetteScannerManagerTest, ScanOnePage) { auto scanner = CreateZeroconfScanner();
diff --git a/chrome/browser/ash/scanning/scan_service.cc b/chrome/browser/ash/scanning/scan_service.cc index 7bb5ea80..951e02b3 100644 --- a/chrome/browser/ash/scanning/scan_service.cc +++ b/chrome/browser/ash/scanning/scan_service.cc
@@ -31,7 +31,6 @@ #include "chrome/browser/ui/ash/holding_space/holding_space_keyed_service_factory.h" #include "chromeos/utils/pdf_conversion.h" #include "third_party/abseil-cpp/absl/types/optional.h" -#include "third_party/re2/src/re2/re2.h" namespace ash { @@ -209,10 +208,8 @@ } // Determine if an ADF scanner that flips alternate pages was selected. - rotate_alternate_pages_ = - RE2::PartialMatch(scanner_name, RE2("([Ee][Pp][Ss][Oo][Nn])(.*)")) && - RE2::PartialMatch(settings->source_name, - RE2("([Aa][Dd][Ff] [Dd][Uu][Pp][Ll][Ee][Xx])")); + rotate_alternate_pages_ = lorgnette_scanner_manager_->IsRotateAlternate( + scanner_name, settings->source_name); if (!FilePathSupported(settings->scan_to_path)) { std::move(callback).Run(false); @@ -426,6 +423,7 @@ void ScanService::ClearScanState() { page_save_failed_ = false; + rotate_alternate_pages_ = false; scanned_file_paths_.clear(); scanned_images_.clear(); num_pages_scanned_ = 0;
diff --git a/chrome/browser/ash/scanning/scan_service_unittest.cc b/chrome/browser/ash/scanning/scan_service_unittest.cc index 7aba59c..fb750a6 100644 --- a/chrome/browser/ash/scanning/scan_service_unittest.cc +++ b/chrome/browser/ash/scanning/scan_service_unittest.cc
@@ -62,7 +62,8 @@ constexpr char16_t kFirstTestScannerName16[] = u"Test Scanner 1"; constexpr char kSecondTestScannerName[] = "Test Scanner 2"; constexpr char16_t kSecondTestScannerName16[] = u"Test Scanner 2"; -constexpr char kEpsonTestName[] = "Epson"; +constexpr char kEpsonTestName[] = + "airscan:escl:EPSON XP-7100 Series:http://100.107.108.190:443/eSCL/"; // Document source name used for tests. constexpr char kDocumentSourceName[] = "Flatbed"; @@ -167,10 +168,12 @@ // Returns scan settings with the given path and file type. mojo_ipc::ScanSettings CreateScanSettings(const base::FilePath& scan_to_path, - const mojo_ipc::FileType& file_type) { + const mojo_ipc::FileType& file_type, + const std::string source = "") { mojo_ipc::ScanSettings settings; settings.scan_to_path = scan_to_path; settings.file_type = file_type; + settings.source_name = source; return settings; } @@ -507,8 +510,9 @@ base::Time::Now().LocalExplode(&scan_time); scan_service_->SetMyFilesPathForTesting(scanned_files_mount_->GetRootPath()); - mojo_ipc::ScanSettings settings = CreateScanSettings( - scanned_files_mount_->GetRootPath(), mojo_ipc::FileType::kPdf); + mojo_ipc::ScanSettings settings = + CreateScanSettings(scanned_files_mount_->GetRootPath(), + mojo_ipc::FileType::kPdf, "ADF Duplex"); const base::FilePath saved_scan_path = CreateSavedPdfScanPath(scanned_files_mount_->GetRootPath(), scan_time); EXPECT_FALSE(base::PathExists(saved_scan_path));
diff --git a/chrome/browser/autocomplete/search_provider_unittest.cc b/chrome/browser/autocomplete/search_provider_unittest.cc index df3838b4..0c0b53c7 100644 --- a/chrome/browser/autocomplete/search_provider_unittest.cc +++ b/chrome/browser/autocomplete/search_provider_unittest.cc
@@ -142,8 +142,7 @@ class SearchProviderFeatureTestComponent { public: - SearchProviderFeatureTestComponent( - const absl::optional<bool> warm_up_on_focus, + explicit SearchProviderFeatureTestComponent( const bool command_line_overrides); ~SearchProviderFeatureTestComponent() { @@ -155,16 +154,7 @@ }; SearchProviderFeatureTestComponent::SearchProviderFeatureTestComponent( - const absl::optional<bool> warm_up_on_focus, const bool command_line_overrides) { - if (warm_up_on_focus.has_value()) { - if (warm_up_on_focus.value()) - feature_list_.InitAndEnableFeature(omnibox::kSearchProviderWarmUpOnFocus); - else - feature_list_.InitAndDisableFeature( - omnibox::kSearchProviderWarmUpOnFocus); - } - if (command_line_overrides) { base::CommandLine::ForCurrentProcess()->AppendSwitchASCII( switches::kGoogleBaseURL, "http://www.bar.com/"); @@ -220,10 +210,8 @@ bool allowed_to_be_default_match; }; - BaseSearchProviderTest( - const absl::optional<bool> warm_up_on_focus = absl::nullopt, - const bool command_line_overrides = false) - : feature_test_component_(warm_up_on_focus, command_line_overrides) { + explicit BaseSearchProviderTest(const bool command_line_overrides = false) + : feature_test_component_(command_line_overrides) { // We need both the history service and template url model loaded. TestingProfile::Builder profile_builder; profile_builder.AddTestingFactory( @@ -343,10 +331,8 @@ // Test environment with valid suggest and search URL. class SearchProviderTest : public BaseSearchProviderTest { public: - SearchProviderTest( - const absl::optional<bool> warm_up_on_focus = absl::nullopt, - const bool command_line_overrides = false) - : BaseSearchProviderTest(warm_up_on_focus, command_line_overrides) {} + explicit SearchProviderTest(const bool command_line_overrides = false) + : BaseSearchProviderTest(command_line_overrides) {} void SetUp() override { CustomizableSetUp( @@ -3727,65 +3713,36 @@ EXPECT_FALSE(test_url_loader_factory_.IsPending("http://defaulturl/query")); } -// SearchProviderWarmUpTest -------------------------------------------------- -// -// Like SearchProviderTest. The only addition is that it's a -// TestWithParam<bool>, where the boolean parameter represents whether the -// omnibox::kSearchProviderWarmUpOnFocus feature flag should be enabled. -class SearchProviderWarmUpTest : public SearchProviderTest, - public testing::WithParamInterface<bool> { - public: - SearchProviderWarmUpTest() : SearchProviderTest(GetParam(), false) {} - - SearchProviderWarmUpTest(SearchProviderWarmUpTest const&) = delete; - SearchProviderWarmUpTest& operator=(SearchProviderWarmUpTest const&) = delete; -}; - -TEST_P(SearchProviderWarmUpTest, SendsWarmUpRequestOnFocus) { +TEST_F(SearchProviderTest, SendsWarmUpRequestOnFocus) { AutocompleteInput input(u"f", metrics::OmniboxEventProto::OTHER, ChromeAutocompleteSchemeClassifier(profile_.get())); input.set_prefer_keyword(true); input.set_focus_type(OmniboxFocusType::ON_FOCUS); - if (!GetParam()) { // The warm-up feature ought to be disabled. - // The provider immediately terminates with no matches. - provider_->Start(input, false); - // RunUntilIdle so that SearchProvider has a chance to create the - // URLFetchers (if it wants to, which it shouldn't in this case). - base::RunLoop().RunUntilIdle(); - EXPECT_TRUE(provider_->done()); - EXPECT_TRUE(provider_->matches().empty()); - } else { // The warm-up feature ought to be enabled. - provider_->Start(input, false); - // RunUntilIdle so that SearchProvider create the URLFetcher. - base::RunLoop().RunUntilIdle(); - EXPECT_FALSE(provider_->done()); - EXPECT_TRUE(provider_->matches().empty()); - // Make sure the default provider's suggest service was queried with an - // empty query. - EXPECT_TRUE(test_url_loader_factory_.IsPending("http://defaultturl2/")); - // Even if the fetcher returns results, we should still have no suggestions - // (though the provider should now be done). - test_url_loader_factory_.AddResponse("http://defaultturl2/", - R"(["",["a", "b"],[],[],{}])"); - RunTillProviderDone(); - EXPECT_TRUE(provider_->done()); - EXPECT_TRUE(provider_->matches().empty()); - } + provider_->Start(input, false); + // RunUntilIdle so that SearchProvider create the URLFetcher. + base::RunLoop().RunUntilIdle(); + EXPECT_FALSE(provider_->done()); + EXPECT_TRUE(provider_->matches().empty()); + // Make sure the default provider's suggest service was queried with an + // empty query. + EXPECT_TRUE(test_url_loader_factory_.IsPending("http://defaultturl2/")); + // Even if the fetcher returns results, we should still have no suggestions + // (though the provider should now be done). + test_url_loader_factory_.AddResponse("http://defaultturl2/", + R"(["",["a", "b"],[],[],{}])"); + RunTillProviderDone(); + EXPECT_TRUE(provider_->done()); + EXPECT_TRUE(provider_->matches().empty()); } -INSTANTIATE_TEST_CASE_P(SearchProviderTest, - SearchProviderWarmUpTest, - testing::Values(false, true)); - // SearchProviderCommandLineOverrideTest ------------------------------------- // // Like SearchProviderTest. The only addition is that it sets additional // command line flags in SearchProviderFeatureTestComponent. class SearchProviderCommandLineOverrideTest : public SearchProviderTest { public: - SearchProviderCommandLineOverrideTest() - : SearchProviderTest(absl::nullopt, true) {} + SearchProviderCommandLineOverrideTest() : SearchProviderTest(true) {} SearchProviderCommandLineOverrideTest( SearchProviderCommandLineOverrideTest const&) = delete;
diff --git a/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc b/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc index 207055f8..8f01293 100644 --- a/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc +++ b/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc
@@ -1378,18 +1378,9 @@ EXPECT_EQ(0, found) << "A non-ignored file contains the hostname."; } -// TODO(crbug.com/840080): Filesystem can't be deleted on exit correctly at the -// moment. -// TODO(crbug.com/927312): LocalStorage deletion is flaky. const std::vector<std::string> kSessionOnlyStorageTestTypes{ - "Cookie", - // "LocalStorage", - // "FileSystem", - "SessionStorage", - "IndexedDb", - "WebSql", - "ServiceWorker", - "CacheStorage", + "Cookie", "LocalStorage", "FileSystem", "SessionStorage", + "IndexedDb", "WebSql", "ServiceWorker", "CacheStorage", }; // Test that storage gets deleted if marked as SessionOnly.
diff --git a/chrome/browser/chrome_content_browser_client_receiver_bindings.cc b/chrome/browser/chrome_content_browser_client_receiver_bindings.cc index 759b6bb99..751e41b 100644 --- a/chrome/browser/chrome_content_browser_client_receiver_bindings.cc +++ b/chrome/browser/chrome_content_browser_client_receiver_bindings.cc
@@ -21,6 +21,7 @@ #include "chrome/browser/net_benchmarking.h" #include "chrome/browser/predictors/loading_predictor.h" #include "chrome/browser/predictors/loading_predictor_factory.h" +#include "chrome/browser/ui/search_engines/search_engine_tab_helper.h" #include "components/autofill/content/browser/content_autofill_driver_factory.h" #include "components/content_capture/browser/onscreen_content_provider.h" #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h" @@ -326,6 +327,15 @@ render_frame_host); return true; } + if (interface_name == + chrome::mojom::OpenSearchDescriptionDocumentHandler::Name_) { + SearchEngineTabHelper::BindOpenSearchDescriptionDocumentHandler( + mojo::PendingAssociatedReceiver< + chrome::mojom::OpenSearchDescriptionDocumentHandler>( + std::move(*handle)), + render_frame_host); + return true; + } if (interface_name == content_capture::mojom::ContentCaptureReceiver::Name_) { content_capture::OnscreenContentProvider::BindContentCaptureReceiver( mojo::PendingAssociatedReceiver<
diff --git a/chrome/browser/extensions/BUILD.gn b/chrome/browser/extensions/BUILD.gn index 481adff..936bc38 100644 --- a/chrome/browser/extensions/BUILD.gn +++ b/chrome/browser/extensions/BUILD.gn
@@ -436,8 +436,6 @@ "blocklist.h", "blocklist_check.cc", "blocklist_check.h", - "blocklist_extension_prefs.cc", - "blocklist_extension_prefs.h", "blocklist_factory.cc", "blocklist_factory.h", "blocklist_state_fetcher.cc",
diff --git a/chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc b/chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc index 66cdb35e..e450b85 100644 --- a/chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc +++ b/chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc
@@ -100,8 +100,9 @@ const RequestPinExceptFirstQuotaBucketMapper&) = delete; ~RequestPinExceptFirstQuotaBucketMapper() override = default; - void GetBucketsForArgs(const base::ListValue* args, + void GetBucketsForArgs(const base::Value* args, QuotaLimitHeuristic::BucketList* buckets) override { + DCHECK(args->is_list()); if (args->GetList().empty()) return; const base::Value& details = args->GetList()[0];
diff --git a/chrome/browser/extensions/api/developer_private/extension_info_generator.cc b/chrome/browser/extensions/api/developer_private/extension_info_generator.cc index bb87b5bd4..9a85f72 100644 --- a/chrome/browser/extensions/api/developer_private/extension_info_generator.cc +++ b/chrome/browser/extensions/api/developer_private/extension_info_generator.cc
@@ -20,7 +20,6 @@ #include "chrome/browser/extensions/api/commands/command_service.h" #include "chrome/browser/extensions/api/developer_private/inspectable_views_finder.h" #include "chrome/browser/extensions/api/extension_action/extension_action_api.h" -#include "chrome/browser/extensions/blocklist_extension_prefs.h" #include "chrome/browser/extensions/error_console/error_console.h" #include "chrome/browser/extensions/extension_allowlist.h" #include "chrome/browser/extensions/extension_service.h" @@ -34,6 +33,7 @@ #include "chrome/common/pref_names.h" #include "chrome/grit/generated_resources.h" #include "content/public/browser/render_frame_host.h" +#include "extensions/browser/blocklist_extension_prefs.h" #include "extensions/browser/blocklist_state.h" #include "extensions/browser/extension_error.h" #include "extensions/browser/extension_icon_placeholder.h"
diff --git a/chrome/browser/extensions/blocklist_extension_prefs_unittest.cc b/chrome/browser/extensions/blocklist_extension_prefs_unittest.cc index 3f8c92b..7d436f85 100644 --- a/chrome/browser/extensions/blocklist_extension_prefs_unittest.cc +++ b/chrome/browser/extensions/blocklist_extension_prefs_unittest.cc
@@ -2,9 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "chrome/browser/extensions/blocklist_extension_prefs.h" +#include "extensions/browser/blocklist_extension_prefs.h" -#include "chrome/browser/extensions/blocklist_extension_prefs.h" #include "chrome/browser/extensions/extension_service.h" #include "chrome/browser/extensions/extension_service_test_base.h" #include "extensions/browser/blocklist_state.h"
diff --git a/chrome/browser/extensions/blocklist_states_interaction_unittest.cc b/chrome/browser/extensions/blocklist_states_interaction_unittest.cc index c185e4eee..c25242d 100644 --- a/chrome/browser/extensions/blocklist_states_interaction_unittest.cc +++ b/chrome/browser/extensions/blocklist_states_interaction_unittest.cc
@@ -2,11 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "chrome/browser/extensions/blocklist_extension_prefs.h" #include "chrome/browser/extensions/extension_service.h" #include "chrome/browser/extensions/extension_service_test_base.h" #include "chrome/browser/extensions/test_blocklist.h" #include "components/safe_browsing/buildflags.h" +#include "extensions/browser/blocklist_extension_prefs.h" #include "extensions/browser/blocklist_state.h" #include "extensions/common/extension_features.h" #include "extensions/test/extension_state_tester.h"
diff --git a/chrome/browser/extensions/content_script_tracker_browsertest.cc b/chrome/browser/extensions/content_script_tracker_browsertest.cc index 5a45d18..5a38d969 100644 --- a/chrome/browser/extensions/content_script_tracker_browsertest.cc +++ b/chrome/browser/extensions/content_script_tracker_browsertest.cc
@@ -18,6 +18,7 @@ #include "content/public/browser/render_frame_host.h" #include "content/public/browser/render_process_host.h" #include "content/public/browser/web_contents.h" +#include "content/public/test/back_forward_cache_util.h" #include "content/public/test/browser_test.h" #include "content/public/test/browser_test_utils.h" #include "content/public/test/commit_message_delayer.h" @@ -214,8 +215,14 @@ // also the "RenderDocumentHostUserData race w/ Commit IPC" section in the // document here: // https://docs.google.com/document/d/1MFprp2ss2r9RNamJ7Jxva1bvRZvec3rzGceDGoJ6vW0/edit#heading=h.n2ppjzx4jpzt +// TODO(crbug.com/936696): Remove the test after RenderDocument is shipped. IN_PROC_BROWSER_TEST_F(ContentScriptTrackerBrowserTest, ProgrammaticInjectionRacingWithDidCommit) { + // The test assumes the RenderFrame stays the same after navigation. Disable + // back/forward cache to ensure that RenderFrame swap won't happen. + content::DisableBackForwardCacheForTesting( + browser()->tab_strip_model()->GetActiveWebContents(), + content::BackForwardCache::TEST_ASSUMES_NO_RENDER_FRAME_CHANGE); // Install a test extension. TestExtensionDir dir; const char kManifestTemplate[] = R"(
diff --git a/chrome/browser/extensions/extension_error_ui_default.cc b/chrome/browser/extensions/extension_error_ui_default.cc index 65c0c00..8507ee62 100644 --- a/chrome/browser/extensions/extension_error_ui_default.cc +++ b/chrome/browser/extensions/extension_error_ui_default.cc
@@ -8,13 +8,13 @@ #include "base/notreached.h" #include "base/strings/string_util.h" #include "base/strings/utf_string_conversions.h" -#include "chrome/browser/extensions/blocklist_extension_prefs.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser_finder.h" #include "chrome/browser/ui/chrome_pages.h" #include "chrome/browser/ui/global_error/global_error_bubble_view_base.h" #include "chrome/grit/generated_resources.h" +#include "extensions/browser/blocklist_extension_prefs.h" #include "extensions/browser/blocklist_state.h" #include "extensions/browser/disable_reason.h" #include "extensions/browser/extension_prefs.h"
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc index a1d4413..1e4ca08 100644 --- a/chrome/browser/extensions/extension_service.cc +++ b/chrome/browser/extensions/extension_service.cc
@@ -39,7 +39,6 @@ #include "chrome/browser/chrome_notification_types.h" #include "chrome/browser/extensions/api/content_settings/content_settings_custom_extension_provider.h" #include "chrome/browser/extensions/api/content_settings/content_settings_service.h" -#include "chrome/browser/extensions/blocklist_extension_prefs.h" #include "chrome/browser/extensions/component_loader.h" #include "chrome/browser/extensions/crx_installer.h" #include "chrome/browser/extensions/data_deleter.h" @@ -80,6 +79,7 @@ #include "content/public/browser/notification_service.h" #include "content/public/browser/render_process_host.h" #include "content/public/browser/storage_partition.h" +#include "extensions/browser/blocklist_extension_prefs.h" #include "extensions/browser/blocklist_state.h" #include "extensions/browser/disable_reason.h" #include "extensions/browser/event_router.h"
diff --git a/chrome/browser/extensions/extension_sync_service.cc b/chrome/browser/extensions/extension_sync_service.cc index 2cd4802..87afc40 100644 --- a/chrome/browser/extensions/extension_sync_service.cc +++ b/chrome/browser/extensions/extension_sync_service.cc
@@ -10,7 +10,6 @@ #include "base/callback_helpers.h" #include "base/one_shot_event.h" #include "base/strings/utf_string_conversions.h" -#include "chrome/browser/extensions/blocklist_extension_prefs.h" #include "chrome/browser/extensions/extension_management.h" #include "chrome/browser/extensions/extension_service.h" #include "chrome/browser/extensions/extension_sync_data.h" @@ -24,6 +23,7 @@ #include "components/sync/model/sync_change.h" #include "components/sync/model/sync_error_factory.h" #include "extensions/browser/app_sorting.h" +#include "extensions/browser/blocklist_extension_prefs.h" #include "extensions/browser/extension_system.h" #include "extensions/browser/extension_util.h" #include "extensions/browser/uninstall_reason.h"
diff --git a/chrome/browser/extensions/omaha_attributes_handler.cc b/chrome/browser/extensions/omaha_attributes_handler.cc index bbf4545..78b819c 100644 --- a/chrome/browser/extensions/omaha_attributes_handler.cc +++ b/chrome/browser/extensions/omaha_attributes_handler.cc
@@ -6,9 +6,9 @@ #include "base/metrics/histogram_functions.h" #include "base/values.h" -#include "chrome/browser/extensions/blocklist_extension_prefs.h" #include "chrome/browser/extensions/extension_service.h" #include "content/public/browser/browser_thread.h" +#include "extensions/browser/blocklist_extension_prefs.h" #include "extensions/browser/blocklist_state.h" #include "extensions/common/extension_features.h"
diff --git a/chrome/browser/extensions/omaha_attributes_handler_unittest.cc b/chrome/browser/extensions/omaha_attributes_handler_unittest.cc index 84356c7..06e4c227 100644 --- a/chrome/browser/extensions/omaha_attributes_handler_unittest.cc +++ b/chrome/browser/extensions/omaha_attributes_handler_unittest.cc
@@ -7,9 +7,9 @@ #include "base/test/metrics/histogram_tester.h" #include "base/test/scoped_feature_list.h" #include "base/values.h" -#include "chrome/browser/extensions/blocklist_extension_prefs.h" #include "chrome/browser/extensions/extension_service.h" #include "chrome/browser/extensions/extension_service_test_base.h" +#include "extensions/browser/blocklist_extension_prefs.h" #include "extensions/browser/disable_reason.h" #include "extensions/browser/extension_prefs.h" #include "extensions/common/extension_features.h"
diff --git a/chrome/browser/extensions/safe_browsing_verdict_handler.cc b/chrome/browser/extensions/safe_browsing_verdict_handler.cc index ded23eb..78d732854 100644 --- a/chrome/browser/extensions/safe_browsing_verdict_handler.cc +++ b/chrome/browser/extensions/safe_browsing_verdict_handler.cc
@@ -6,8 +6,8 @@ #include "base/stl_util.h" #include "base/trace_event/trace_event.h" -#include "chrome/browser/extensions/blocklist_extension_prefs.h" #include "chrome/browser/extensions/extension_service.h" +#include "extensions/browser/blocklist_extension_prefs.h" #include "extensions/browser/blocklist_state.h" #include "extensions/browser/extension_registry.h"
diff --git a/chrome/browser/extensions/safe_browsing_verdict_handler_unittest.cc b/chrome/browser/extensions/safe_browsing_verdict_handler_unittest.cc index a8932b9..fe2564b 100644 --- a/chrome/browser/extensions/safe_browsing_verdict_handler_unittest.cc +++ b/chrome/browser/extensions/safe_browsing_verdict_handler_unittest.cc
@@ -4,11 +4,11 @@ #include "chrome/browser/extensions/safe_browsing_verdict_handler.h" -#include "chrome/browser/extensions/blocklist_extension_prefs.h" #include "chrome/browser/extensions/extension_service.h" #include "chrome/browser/extensions/extension_service_test_base.h" #include "chrome/browser/extensions/test_blocklist.h" #include "components/safe_browsing/buildflags.h" +#include "extensions/browser/blocklist_extension_prefs.h" #include "extensions/test/extension_state_tester.h" // The blocklist tests rely on the safe-browsing database.
diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json index ea7a1f24..5e3f802 100644 --- a/chrome/browser/flag-metadata.json +++ b/chrome/browser/flag-metadata.json
@@ -3449,7 +3449,7 @@ }, { "name": "instant-tethering", - "owners": [ "hansberry", "khorimoto", "vecore", "cros-system-services@google.com" ], + "owners": [ "hansberry", "khorimoto", "cros-system-services@google.com" ], // Though Instant Tethering is now a launched feature, it is only marked enabled on select, // approved boards which have passed hardware verification and received server config seeds // marking it as enabled. This means it is actually disabled-by-default, and since test machines @@ -3917,12 +3917,12 @@ }, { "name": "nearby-keep-alive-fix", - "owners": [ "vecore@google.com", "cros-system-services@google.com", "cross-device-team@google.com" ], + "owners": [ "danlee@google.com", "cros-system-services@google.com", "cross-device-team@google.com" ], "expiry_milestone": 98 }, { "name": "nearby-sharing", - "owners": [ "vecore@google.com", "cros-system-services@google.com", "cross-device-team@google.com" ], + "owners": [ "danlee@google.com", "cros-system-services@google.com", "cross-device-team@google.com" ], "expiry_milestone": 95 }, { @@ -3932,12 +3932,12 @@ }, { "name": "nearby-sharing-device-contacts", - "owners": [ "vecore@google.com", "cros-system-services@google.com", "cross-device-team@google.com" ], + "owners": [ "danlee@google.com", "cros-system-services@google.com", "cross-device-team@google.com" ], "expiry_milestone": 95 }, { "name": "nearby-sharing-webrtc", - "owners": [ "vecore@google.com", "cros-system-services@google.com", "cross-device-team@google.com" ], + "owners": [ "danlee@google.com", "cros-system-services@google.com", "cross-device-team@google.com" ], "expiry_milestone": 95 }, { @@ -5444,7 +5444,7 @@ }, { "name": "updated_cellular_activation_ui", - "owners": [ "azeemarshad", "khorimoto", "vecore", "cros-connectivity@google.com" ], + "owners": [ "azeemarshad", "khorimoto", "cros-connectivity@google.com" ], "expiry_milestone": 95 }, { @@ -5468,7 +5468,7 @@ }, { "name": "use-custom-messages-domain", - "owners": [ "azeemarshad", "jonmann", "vecore" ], + "owners": [ "azeemarshad", "jonmann" ], // This flag is used for QA and development. "expiry_milestone": -1 }, @@ -5683,6 +5683,11 @@ "expiry_milestone": 91 }, { + "name": "webui-branding-update", + "owners": [ "dpapad@chromium.org", "johntlee@chromium.org" ], + "expiry_milestone": 99 + }, + { "name": "webui-dark-mode", "owners": [ "khorimoto@chromium.org", "jessejames@chromium.org" ], "expiry_milestone": 99
diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc index 5d0fd01..273053d 100644 --- a/chrome/browser/flag_descriptions.cc +++ b/chrome/browser/flag_descriptions.cc
@@ -2727,12 +2727,6 @@ "Use the provided list of origins as a First-Party Set, with the first " "valid origin as the owner of the set."; -const char kUseOfHashAffiliationFetcherName[] = - "Use of Hash Affiliation Fetcher"; -const char kUseOfHashAffiliationFetcherDescription[] = - "All requests to the affiliation fetcher are made through the hash prefix " - "lookup. Enables use of Hash Affiliation Service for non-synced users."; - const char kUsernameFirstFlowName[] = "Username first flow voting"; const char kUsernameFirstFlowDescription[] = "Support of sending votes on username first flow i.e. login " @@ -5297,6 +5291,10 @@ "Enables printing interactions with the operating system to be performed " "out-of-process."; +const char kWebUIBrandingUpdateName[] = "WebUI Branding Update"; +const char kWebUIBrandingUpdateDescription[] = + "Changes various UI components in WebUI pages to have a more modern look."; + const char kWebuiFeedbackName[] = "WebUI Feedback"; const char kWebuiFeedbackDescription[] = "If enabled, Chrome will show the Feedback WebUI, as opposed to Chrome "
diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h index 748414f..bffd4e9 100644 --- a/chrome/browser/flag_descriptions.h +++ b/chrome/browser/flag_descriptions.h
@@ -943,9 +943,6 @@ extern const char kMutingCompromisedCredentialsName[]; extern const char kMutingCompromisedCredentialsDescription[]; -extern const char kUseOfHashAffiliationFetcherName[]; -extern const char kUseOfHashAffiliationFetcherDescription[]; - extern const char kUsernameFirstFlowName[]; extern const char kUsernameFirstFlowDescription[]; @@ -3070,6 +3067,9 @@ extern const char kEnableOopPrintDriversName[]; extern const char kEnableOopPrintDriversDescription[]; +extern const char kWebUIBrandingUpdateName[]; +extern const char kWebUIBrandingUpdateDescription[]; + extern const char kWebuiFeedbackName[]; extern const char kWebuiFeedbackDescription[];
diff --git a/chrome/browser/media/history/media_history_browsertest.cc b/chrome/browser/media/history/media_history_browsertest.cc index 70626ae..cf72b37 100644 --- a/chrome/browser/media/history/media_history_browsertest.cc +++ b/chrome/browser/media/history/media_history_browsertest.cc
@@ -28,6 +28,7 @@ #include "content/public/browser/browsing_data_filter_builder.h" #include "content/public/browser/context_menu_params.h" #include "content/public/browser/media_session.h" +#include "content/public/test/back_forward_cache_util.h" #include "content/public/test/browser_test.h" #include "content/public/test/browsing_data_remover_test_util.h" #include "content/public/test/prerender_test_util.h" @@ -826,6 +827,12 @@ MAYBE_RecordWatchtime_AudioVideo) { auto* browser = CreateBrowserFromParam(); + // The test assumes the previous page gets deleted after navigation, which + // will trigger the recording. Disable back-forward cache to ensure that it + // doesn't get preserved in the cache. + content::DisableBackForwardCacheForTesting( + browser->tab_strip_model()->GetActiveWebContents(), + content::BackForwardCache::TEST_ASSUMES_NO_CACHING); // Start a page and wait for significant playback so we record watchtime. EXPECT_TRUE(SetupPageAndStartPlaying(browser, GetTestURL())); EXPECT_TRUE(WaitForSignificantPlayback(browser)); @@ -896,6 +903,12 @@ IN_PROC_BROWSER_TEST_P(MediaHistoryBrowserTest, RecordWatchtime_AudioOnly) { auto* browser = CreateBrowserFromParam(); + // The test assumes the previous page gets deleted after navigation, which + // will trigger the recording. Disable back-forward cache to ensure that it + // doesn't get preserved in the cache. + content::DisableBackForwardCacheForTesting( + browser->tab_strip_model()->GetActiveWebContents(), + content::BackForwardCache::TEST_ASSUMES_NO_CACHING); // Start a page and wait for significant playback so we record watchtime. EXPECT_TRUE(SetupPageAndStartPlayingAudioOnly(browser, GetTestURL())); @@ -960,6 +973,12 @@ IN_PROC_BROWSER_TEST_P(MediaHistoryBrowserTest, RecordWatchtime_VideoOnly) { auto* browser = CreateBrowserFromParam(); + // The test assumes the previous page gets deleted after navigation, which + // will trigger the recording. Disable back-forward cache to ensure that it + // doesn't get preserved in the cache. + content::DisableBackForwardCacheForTesting( + browser->tab_strip_model()->GetActiveWebContents(), + content::BackForwardCache::TEST_ASSUMES_NO_CACHING); // Start a page and wait for significant playback so we record watchtime. EXPECT_TRUE(SetupPageAndStartPlayingVideoOnly(browser, GetTestURL()));
diff --git a/chrome/browser/metrics/extensions_metrics_provider.cc b/chrome/browser/metrics/extensions_metrics_provider.cc index 3863f2b..30b1c9f 100644 --- a/chrome/browser/metrics/extensions_metrics_provider.cc +++ b/chrome/browser/metrics/extensions_metrics_provider.cc
@@ -16,13 +16,13 @@ #include "base/strings/stringprintf.h" #include "base/time/time.h" #include "chrome/browser/browser_process.h" -#include "chrome/browser/extensions/blocklist_extension_prefs.h" #include "chrome/browser/extensions/extension_management.h" #include "chrome/browser/extensions/install_verifier.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/profiles/profile_manager.h" #include "components/metrics/metrics_log.h" #include "components/metrics/metrics_state_manager.h" +#include "extensions/browser/blocklist_extension_prefs.h" #include "extensions/browser/disable_reason.h" #include "extensions/browser/extension_prefs.h" #include "extensions/browser/extension_registry.h"
diff --git a/chrome/browser/net/system_network_context_manager.cc b/chrome/browser/net/system_network_context_manager.cc index e8437bc..b2b2995 100644 --- a/chrome/browser/net/system_network_context_manager.cc +++ b/chrome/browser/net/system_network_context_manager.cc
@@ -633,7 +633,7 @@ std::string quic_user_agent_id; - if (base::FeatureList::IsEnabled(blink::features::kFreezeUserAgent)) { + if (base::FeatureList::IsEnabled(blink::features::kReduceUserAgent)) { quic_user_agent_id = ""; } else { // Extended stable reports as regular stable due to the similarity, and to
diff --git a/chrome/browser/net/system_network_context_manager_browsertest.cc b/chrome/browser/net/system_network_context_manager_browsertest.cc index 49726c02..320d7a20 100644 --- a/chrome/browser/net/system_network_context_manager_browsertest.cc +++ b/chrome/browser/net/system_network_context_manager_browsertest.cc
@@ -194,7 +194,7 @@ public testing::WithParamInterface<bool> { public: SystemNetworkContextManagerFreezeQUICUaBrowsertest() { - scoped_feature_list_.InitWithFeatureState(blink::features::kFreezeUserAgent, + scoped_feature_list_.InitWithFeatureState(blink::features::kReduceUserAgent, GetParam()); } ~SystemNetworkContextManagerFreezeQUICUaBrowsertest() override {}
diff --git a/chrome/browser/net/trust_token_usecounter_browsertest.cc b/chrome/browser/net/trust_token_usecounter_browsertest.cc index c17c637..078ff15 100644 --- a/chrome/browser/net/trust_token_usecounter_browsertest.cc +++ b/chrome/browser/net/trust_token_usecounter_browsertest.cc
@@ -7,6 +7,7 @@ #include "chrome/browser/ui/browser.h" #include "chrome/test/base/in_process_browser_test.h" #include "chrome/test/base/ui_test_utils.h" +#include "content/public/browser/back_forward_cache.h" #include "content/public/test/browser_test.h" #include "content/public/test/browser_test_utils.h" #include "content/public/test/test_navigation_observer.h" @@ -49,6 +50,17 @@ GURL start_url(server_.GetURL("/title1.html")); EXPECT_TRUE(ui_test_utils::NavigateToURL(browser(), start_url)); + // Ensure that the previous page won't be stored in the back/forward cache, so + // that the histogram will be recorded when the previous page is unloaded. + // TODO(https://crbug.com/1229122): Investigate if this needs further fix. + browser() + ->tab_strip_model() + ->GetActiveWebContents() + ->GetController() + .GetBackForwardCache() + .DisableForTesting( + content::BackForwardCache::TEST_ASSUMES_NO_RENDER_FRAME_CHANGE); + std::string cmd = R"( (async () => { await fetch("/page404.html", {trustToken: {type: 'token-request'}}); @@ -74,6 +86,16 @@ GURL start_url(server_.GetURL("/title1.html")); EXPECT_TRUE(ui_test_utils::NavigateToURL(browser(), start_url)); + // Ensure that the previous page won't be stored in the back/forward cache, so + // that the histogram will be recorded when the previous page is unloaded. + // TODO(https://crbug.com/1229122): Investigate if this needs further fix. + browser() + ->tab_strip_model() + ->GetActiveWebContents() + ->GetController() + .GetBackForwardCache() + .DisableForTesting(content::BackForwardCache::TEST_ASSUMES_NO_CACHING); + base::HistogramTester histograms; // Execute a Trust Tokens issuance against a nonexistent endpoint.
diff --git a/chrome/browser/page_load_metrics/integration_tests/first_input_delay_browsertest.cc b/chrome/browser/page_load_metrics/integration_tests/first_input_delay_browsertest.cc index c3ec2d7f..6706528 100644 --- a/chrome/browser/page_load_metrics/integration_tests/first_input_delay_browsertest.cc +++ b/chrome/browser/page_load_metrics/integration_tests/first_input_delay_browsertest.cc
@@ -6,6 +6,7 @@ #include "base/test/trace_event_analyzer.h" #include "chrome/test/base/ui_test_utils.h" +#include "content/public/browser/back_forward_cache.h" #include "content/public/test/browser_test.h" #include "services/metrics/public/cpp/ukm_builders.h" @@ -29,6 +30,12 @@ </script> )HTML"); + // Ensure that the previous page won't be stored in the back/forward cache, so + // that the histogram will be recorded when the previous page is unloaded. + // TODO(https://crbug.com/1229122): Investigate if this needs further fix. + web_contents()->GetController().GetBackForwardCache().DisableForTesting( + content::BackForwardCache::TEST_ASSUMES_NO_CACHING); + StartTracing({"loading"}); content::SimulateMouseClick(web_contents(), 0,
diff --git a/chrome/browser/page_load_metrics/integration_tests/user_timing_browsertest.cc b/chrome/browser/page_load_metrics/integration_tests/user_timing_browsertest.cc index 70f0f33..f086faf 100644 --- a/chrome/browser/page_load_metrics/integration_tests/user_timing_browsertest.cc +++ b/chrome/browser/page_load_metrics/integration_tests/user_timing_browsertest.cc
@@ -5,6 +5,7 @@ #include "chrome/browser/page_load_metrics/integration_tests/metric_integration_test.h" #include "chrome/test/base/ui_test_utils.h" +#include "content/public/browser/back_forward_cache.h" #include "content/public/test/browser_test.h" #include "services/metrics/public/cpp/ukm_builders.h" @@ -24,6 +25,10 @@ } </script> )HTML"); + // Ensure that the previous page won't be stored in the back/forward cache, so + // that the histogram will be recorded when the previous page is unloaded. + web_contents()->GetController().GetBackForwardCache().DisableForTesting( + content::BackForwardCache::TEST_ASSUMES_NO_CACHING); // Check web perf API. const base::ListValue eval_result =
diff --git a/chrome/browser/page_load_metrics/observers/ad_metrics/ads_page_load_metrics_observer_browsertest.cc b/chrome/browser/page_load_metrics/observers/ad_metrics/ads_page_load_metrics_observer_browsertest.cc index 5abb0d5..fd6293d 100644 --- a/chrome/browser/page_load_metrics/observers/ad_metrics/ads_page_load_metrics_observer_browsertest.cc +++ b/chrome/browser/page_load_metrics/observers/ad_metrics/ads_page_load_metrics_observer_browsertest.cc
@@ -35,6 +35,7 @@ #include "components/subresource_filter/core/common/test_ruleset_utils.h" #include "components/subresource_filter/core/mojom/subresource_filter.mojom.h" #include "components/ukm/test_ukm_recorder.h" +#include "content/public/browser/back_forward_cache.h" #include "content/public/browser/render_frame_host.h" #include "content/public/common/content_features.h" #include "content/public/common/url_constants.h" @@ -851,6 +852,16 @@ // if it continues to load resources. IN_PROC_BROWSER_TEST_F(AdsPageLoadMetricsObserverBrowserTest, DocOverwritesNavigation) { + // Ensure that the previous page won't be stored in the back/forward cache, so + // that the histogram will be recorded when the previous page is unloaded. + // TODO(https://crbug.com/1229122): Investigate if this needs further fix. + browser() + ->tab_strip_model() + ->GetActiveWebContents() + ->GetController() + .GetBackForwardCache() + .DisableForTesting(content::BackForwardCache::TEST_ASSUMES_NO_CACHING); + content::DOMMessageQueue msg_queue; ukm::TestAutoSetUkmRecorder ukm_recorder;
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc index 95f3541..9698b1d 100644 --- a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc +++ b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
@@ -71,6 +71,7 @@ #include "components/sessions/core/serialized_navigation_entry.h" #include "components/sessions/core/serialized_navigation_entry_test_helper.h" #include "components/ukm/test_ukm_recorder.h" +#include "content/public/browser/back_forward_cache.h" #include "content/public/browser/browser_thread.h" #include "content/public/browser/render_process_host.h" #include "content/public/browser/render_view_host.h" @@ -1649,6 +1650,16 @@ UseCounterUkmFeaturesLogged) { ASSERT_TRUE(embedded_test_server()->Start()); + // Ensure that the previous page won't be stored in the back/forward cache, so + // that the histogram will be recorded when the previous page is unloaded. + // TODO(https://crbug.com/1229122): Investigate if this needs further fix. + browser() + ->tab_strip_model() + ->GetActiveWebContents() + ->GetController() + .GetBackForwardCache() + .DisableForTesting(content::BackForwardCache::TEST_ASSUMES_NO_CACHING); + auto waiter = CreatePageLoadMetricsTestWaiter(); waiter->AddPageExpectation(TimingField::kLoadEvent); GURL url = embedded_test_server()->GetURL( @@ -1690,6 +1701,16 @@ https_server.AddDefaultHandlers(GetChromeTestDataDir()); ASSERT_TRUE(https_server.Start()); + // Ensure that the previous page won't be stored in the back/forward cache, so + // that the histogram will be recorded when the previous page is unloaded. + // TODO(https://crbug.com/1229122): Investigate if this needs further fix. + browser() + ->tab_strip_model() + ->GetActiveWebContents() + ->GetController() + .GetBackForwardCache() + .DisableForTesting(content::BackForwardCache::TEST_ASSUMES_NO_CACHING); + auto waiter = CreatePageLoadMetricsTestWaiter(); waiter->AddPageExpectation(TimingField::kLoadEvent); GURL url =
diff --git a/chrome/browser/password_manager/android/BUILD.gn b/chrome/browser/password_manager/android/BUILD.gn index bf40146..9c9671f 100644 --- a/chrome/browser/password_manager/android/BUILD.gn +++ b/chrome/browser/password_manager/android/BUILD.gn
@@ -74,5 +74,5 @@ } java_cpp_enum("password_manager_android_java_enums_srcjar") { - sources = [ "biometric_authenticator_android.h" ] + sources = [ "biometric_authenticator_bridge.h" ] }
diff --git a/chrome/browser/password_manager/android/biometric_authenticator_android.cc b/chrome/browser/password_manager/android/biometric_authenticator_android.cc index 7fd9843..1b9856e 100644 --- a/chrome/browser/password_manager/android/biometric_authenticator_android.cc +++ b/chrome/browser/password_manager/android/biometric_authenticator_android.cc
@@ -7,7 +7,6 @@ #include <memory> #include <utility> -#include "base/android/jni_android.h" #include "base/bind.h" #include "base/callback.h" #include "base/callback_helpers.h" @@ -16,7 +15,7 @@ #include "base/metrics/histogram_functions.h" #include "base/metrics/histogram_macros.h" #include "base/time/time.h" -#include "chrome/browser/password_manager/android/jni_headers/BiometricAuthenticatorBridge_jni.h" +#include "chrome/browser/password_manager/android/biometric_authenticator_bridge_impl.h" #include "components/autofill/core/common/autofill_features.h" #include "components/password_manager/core/browser/biometric_authenticator.h" #include "components/password_manager/core/browser/origin_credential_store.h" @@ -27,7 +26,6 @@ #include "third_party/abseil-cpp/absl/types/optional.h" #include "ui/android/view_android.h" -using base::android::AttachCurrentThread; using content::WebContents; using password_manager::BiometricAuthFinalResult; using password_manager::BiometricAuthUIResult; @@ -81,26 +79,18 @@ return nullptr; } - return base::WrapRefCounted( - new BiometricAuthenticatorAndroid(window_android)); + return base::WrapRefCounted(new BiometricAuthenticatorAndroid( + std::make_unique<BiometricAuthenticatorBridgeImpl>(window_android))); } BiometricAuthenticatorAndroid::BiometricAuthenticatorAndroid( - ui::WindowAndroid* window_android) { - java_object_ = Java_BiometricAuthenticatorBridge_create( - AttachCurrentThread(), reinterpret_cast<intptr_t>(this), - window_android->GetJavaObject()); -} + std::unique_ptr<BiometricAuthenticatorBridge> bridge) + : bridge_(std::move(bridge)) {} -BiometricAuthenticatorAndroid::~BiometricAuthenticatorAndroid() { - Java_BiometricAuthenticatorBridge_destroy(AttachCurrentThread(), - java_object_); -} +BiometricAuthenticatorAndroid::~BiometricAuthenticatorAndroid() {} BiometricsAvailability BiometricAuthenticatorAndroid::CanAuthenticate() { - BiometricsAvailability availability = static_cast<BiometricsAvailability>( - Java_BiometricAuthenticatorBridge_canAuthenticate(AttachCurrentThread(), - java_object_)); + BiometricsAvailability availability = bridge_->CanAuthenticate(); base::UmaHistogramEnumeration( "PasswordManager.BiometricAuthPwdFill.CanAuthenticate", availability); @@ -125,8 +115,10 @@ requester_ = absl::nullopt; return; } - Java_BiometricAuthenticatorBridge_authenticate(AttachCurrentThread(), - java_object_); + // `this` owns the bridge so it's safe to use base::Unretained. + bridge_->Authenticate( + base::BindOnce(&BiometricAuthenticatorAndroid::OnAuthenticationCompleted, + base::Unretained(this))); } void BiometricAuthenticatorAndroid::Cancel( @@ -137,12 +129,11 @@ return; callback_.Reset(); requester_ = absl::nullopt; - Java_BiometricAuthenticatorBridge_cancel(AttachCurrentThread(), java_object_); + bridge_->Cancel(); } -void BiometricAuthenticatorAndroid::OnAuthenticationCompleted(JNIEnv* env, - jint result) { - BiometricAuthUIResult ui_result = static_cast<BiometricAuthUIResult>(result); +void BiometricAuthenticatorAndroid::OnAuthenticationCompleted( + BiometricAuthUIResult ui_result) { bool success = IsSuccessfulResult(ui_result); if (callback_.is_null()) { if (success) {
diff --git a/chrome/browser/password_manager/android/biometric_authenticator_android.h b/chrome/browser/password_manager/android/biometric_authenticator_android.h index f839604..56c3c39 100644 --- a/chrome/browser/password_manager/android/biometric_authenticator_android.h +++ b/chrome/browser/password_manager/android/biometric_authenticator_android.h
@@ -5,34 +5,18 @@ #ifndef CHROME_BROWSER_PASSWORD_MANAGER_ANDROID_BIOMETRIC_AUTHENTICATOR_ANDROID_H_ #define CHROME_BROWSER_PASSWORD_MANAGER_ANDROID_BIOMETRIC_AUTHENTICATOR_ANDROID_H_ -#include "base/android/scoped_java_ref.h" +#include "base/callback.h" #include "base/time/time.h" +#include "chrome/browser/password_manager/android/biometric_authenticator_bridge.h" #include "chrome/browser/password_manager/chrome_biometric_authenticator.h" #include "components/password_manager/core/browser/biometric_authenticator.h" -#include "components/password_manager/core/browser/origin_credential_store.h" #include "third_party/abseil-cpp/absl/types/optional.h" -#include "ui/android/window_android.h" - -namespace password_manager { - -// The biometric authentication result as returned by the biometric prompt. -// -// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.password_manager -enum class BiometricAuthUIResult { - kSuccessWithUnknownMethod = 0, - kSuccessWithBiometrics = 1, - kSuccessWithDeviceLock = 2, - kCanceledByUser = 3, - kFailed = 4, -}; - -} // namespace password_manager - // Android implementation of the BiometricAuthenticator interface. class BiometricAuthenticatorAndroid : public ChromeBiometricAuthenticator { public: - explicit BiometricAuthenticatorAndroid(ui::WindowAndroid* window_android); + explicit BiometricAuthenticatorAndroid( + std::unique_ptr<BiometricAuthenticatorBridge> bridge); // Checks whether biometrics are available. password_manager::BiometricsAvailability CanAuthenticate() override; @@ -48,12 +32,13 @@ // destroyed. void Cancel(password_manager::BiometricAuthRequester requester) override; - // Called by Java when the authentication completes. - void OnAuthenticationCompleted(JNIEnv* env, jint result); - private: ~BiometricAuthenticatorAndroid() override; + // Called when the authentication compeletes with the result + void OnAuthenticationCompleted( + password_manager::BiometricAuthUIResult ui_result); + // Time of last successful re-auth. nullopt if there hasn't been an auth yet. absl::optional<base::TimeTicks> last_good_auth_timestamp_; @@ -64,9 +49,8 @@ // authentication. absl::optional<password_manager::BiometricAuthRequester> requester_; - // This object is an instance of BiometricAuthenticatorBridge, i.e. the Java - // counterpart to this class. - base::android::ScopedJavaGlobalRef<jobject> java_object_; + // Bridge used to call into the Java side. + std::unique_ptr<BiometricAuthenticatorBridge> bridge_; }; #endif // CHROME_BROWSER_PASSWORD_MANAGER_ANDROID_BIOMETRIC_AUTHENTICATOR_ANDROID_H_
diff --git a/chrome/browser/password_manager/android/biometric_authenticator_android_unittest.cc b/chrome/browser/password_manager/android/biometric_authenticator_android_unittest.cc new file mode 100644 index 0000000..7605af8 --- /dev/null +++ b/chrome/browser/password_manager/android/biometric_authenticator_android_unittest.cc
@@ -0,0 +1,197 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "chrome/browser/password_manager/android/biometric_authenticator_android.h" + +#include <memory> + +#include "base/callback.h" +#include "base/callback_helpers.h" +#include "base/metrics/histogram.h" +#include "base/test/gmock_callback_support.h" +#include "base/test/metrics/histogram_tester.h" +#include "base/test/mock_callback.h" +#include "base/test/task_environment.h" +#include "chrome/browser/password_manager/android/biometric_authenticator_bridge.h" +#include "components/password_manager/core/browser/biometric_authenticator.h" +#include "content/public/test/browser_task_environment.h" +#include "testing/gmock/include/gmock/gmock.h" +#include "testing/gtest/include/gtest/gtest.h" + +namespace { + +using base::Bucket; +using base::test::RunOnceCallback; +using password_manager::BiometricAuthenticator; +using password_manager::BiometricAuthFinalResult; +using password_manager::BiometricAuthRequester; +using password_manager::BiometricAuthUIResult; +using password_manager::BiometricsAvailability; +using testing::_; +using testing::ElementsAre; +using testing::Return; + +class MockBiometricAuthenticatorBridge : public BiometricAuthenticatorBridge { + public: + MOCK_METHOD(BiometricsAvailability, CanAuthenticate, (), (override)); + MOCK_METHOD(void, + Authenticate, + (base::OnceCallback<void(password_manager::BiometricAuthUIResult)> + response_callback), + (override)); + MOCK_METHOD(void, Cancel, (), (override)); +}; + +} // namespace + +class BiometricAuthenticatorAndroidTest : public testing::Test { + public: + void SetUp() override { + std::unique_ptr<MockBiometricAuthenticatorBridge> bridge = + std::make_unique<MockBiometricAuthenticatorBridge>(); + bridge_ = bridge.get(); + authenticator_ = + base::MakeRefCounted<BiometricAuthenticatorAndroid>(std::move(bridge)); + } + + BiometricAuthenticatorAndroid* authenticator() { + return authenticator_.get(); + } + + MockBiometricAuthenticatorBridge& bridge() { return *bridge_; } + + base::test::TaskEnvironment& task_environment() { return task_environment_; } + + private: + scoped_refptr<BiometricAuthenticatorAndroid> authenticator_; + base::test::TaskEnvironment task_environment_{ + base::test::TaskEnvironment::TimeSource::MOCK_TIME}; + + // This is owned by the authenticator. + MockBiometricAuthenticatorBridge* bridge_ = nullptr; +}; + +TEST_F(BiometricAuthenticatorAndroidTest, CanAuthenticateCallsBridge) { + base::HistogramTester histogram_tester; + + EXPECT_CALL(bridge(), CanAuthenticate) + .WillOnce(Return(BiometricsAvailability::kAvailable)); + EXPECT_EQ(BiometricsAvailability::kAvailable, + authenticator()->CanAuthenticate()); + + histogram_tester.ExpectUniqueSample( + "PasswordManager.BiometricAuthPwdFill.CanAuthenticate", + BiometricsAvailability::kAvailable, 1); +} + +TEST_F(BiometricAuthenticatorAndroidTest, AuthenticateRecordsRequester) { + base::HistogramTester histogram_tester; + + authenticator()->Authenticate(BiometricAuthRequester::kAllPasswordsList, + base::DoNothing()); + histogram_tester.ExpectUniqueSample( + "PasswordManager.BiometricAuthPwdFill.AuthRequester", + BiometricAuthRequester::kAllPasswordsList, 1); +} + +TEST_F(BiometricAuthenticatorAndroidTest, DoesntTriggerAuthIfWithin60Seconds) { + // Simulate a previous successful authentication + base::HistogramTester histogram_tester; + EXPECT_CALL(bridge(), Authenticate) + .WillOnce( + RunOnceCallback<0>(BiometricAuthUIResult::kSuccessWithBiometrics)); + authenticator()->Authenticate(BiometricAuthRequester::kAllPasswordsList, + base::DoNothing()); + + // The next call to `Authenticate()` should not re-trigger an authentication. + EXPECT_CALL(bridge(), Authenticate(_)).Times(0); + base::MockCallback<BiometricAuthenticator::AuthenticateCallback> + result_callback; + EXPECT_CALL(result_callback, Run(/*auth_succeeded=*/true)); + authenticator()->Authenticate(BiometricAuthRequester::kAllPasswordsList, + result_callback.Get()); + EXPECT_THAT( + histogram_tester.GetAllSamples( + "PasswordManager.BiometricAuthPwdFill.AuthResult"), + ElementsAre( + Bucket(static_cast<int>( + BiometricAuthFinalResult::kSuccessWithBiometrics), + 1), + Bucket(static_cast<int>(BiometricAuthFinalResult::kAuthStillValid), + 1))); +} + +TEST_F(BiometricAuthenticatorAndroidTest, TriggersAuthIfMoreThan60Seconds) { + base::HistogramTester histogram_tester; + // Simulate a previous successful authentication + EXPECT_CALL(bridge(), Authenticate) + .WillOnce( + RunOnceCallback<0>(BiometricAuthUIResult::kSuccessWithBiometrics)); + authenticator()->Authenticate(BiometricAuthRequester::kAllPasswordsList, + base::DoNothing()); + + task_environment().FastForwardBy(base::TimeDelta::FromSeconds(60)); + + // The next call to `Authenticate()` should re-trigger an authentication. + EXPECT_CALL(bridge(), Authenticate(_)) + .WillOnce(RunOnceCallback<0>(BiometricAuthUIResult::kFailed)); + base::MockCallback<BiometricAuthenticator::AuthenticateCallback> + result_callback; + EXPECT_CALL(result_callback, Run(/*auth_succeeded=*/false)); + authenticator()->Authenticate(BiometricAuthRequester::kAllPasswordsList, + result_callback.Get()); + + EXPECT_THAT( + histogram_tester.GetAllSamples( + "PasswordManager.BiometricAuthPwdFill.AuthResult"), + ElementsAre( + Bucket(static_cast<int>( + BiometricAuthFinalResult::kSuccessWithBiometrics), + 1), + Bucket(static_cast<int>(BiometricAuthFinalResult::kFailed), 1))); +} + +TEST_F(BiometricAuthenticatorAndroidTest, TriggersAuthIfPreviousFailed) { + base::HistogramTester histogram_tester; + // Simulate a previous failed authentication + EXPECT_CALL(bridge(), Authenticate) + .WillOnce(RunOnceCallback<0>(BiometricAuthUIResult::kFailed)); + authenticator()->Authenticate(BiometricAuthRequester::kAllPasswordsList, + base::DoNothing()); + + // The next call to `Authenticate()` should re-trigger an authentication. + EXPECT_CALL(bridge(), Authenticate(_)) + .WillOnce( + RunOnceCallback<0>(BiometricAuthUIResult::kSuccessWithBiometrics)); + base::MockCallback<BiometricAuthenticator::AuthenticateCallback> + result_callback; + EXPECT_CALL(result_callback, Run(/*auth_succeeded=*/true)); + authenticator()->Authenticate(BiometricAuthRequester::kAllPasswordsList, + result_callback.Get()); + + EXPECT_THAT( + histogram_tester.GetAllSamples( + "PasswordManager.BiometricAuthPwdFill.AuthResult"), + ElementsAre( + Bucket(static_cast<int>( + BiometricAuthFinalResult::kSuccessWithBiometrics), + 1), + Bucket(static_cast<int>(BiometricAuthFinalResult::kFailed), 1))); +} + +TEST_F(BiometricAuthenticatorAndroidTest, CancelsOngoingAuthIfSameRequester) { + EXPECT_CALL(bridge(), Authenticate); + authenticator()->Authenticate(BiometricAuthRequester::kAllPasswordsList, + base::DoNothing()); + EXPECT_CALL(bridge(), Cancel); + authenticator()->Cancel(BiometricAuthRequester::kAllPasswordsList); +} + +TEST_F(BiometricAuthenticatorAndroidTest, DoesntCancelAuthIfNotSameRequester) { + EXPECT_CALL(bridge(), Authenticate); + authenticator()->Authenticate(BiometricAuthRequester::kAllPasswordsList, + base::DoNothing()); + EXPECT_CALL(bridge(), Cancel).Times(0); + authenticator()->Cancel(BiometricAuthRequester::kAccountChooserDialog); +}
diff --git a/chrome/browser/password_manager/android/biometric_authenticator_bridge.h b/chrome/browser/password_manager/android/biometric_authenticator_bridge.h new file mode 100644 index 0000000..e5ea8a06 --- /dev/null +++ b/chrome/browser/password_manager/android/biometric_authenticator_bridge.h
@@ -0,0 +1,48 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef CHROME_BROWSER_PASSWORD_MANAGER_ANDROID_BIOMETRIC_AUTHENTICATOR_BRIDGE_H_ +#define CHROME_BROWSER_PASSWORD_MANAGER_ANDROID_BIOMETRIC_AUTHENTICATOR_BRIDGE_H_ + +#include "base/callback_forward.h" +#include "chrome/browser/password_manager/android/biometric_authenticator_android.h" +#include "components/password_manager/core/browser/biometric_authenticator.h" + +namespace password_manager { + +// The biometric authentication result as returned by the biometric prompt. +// +// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.password_manager +enum class BiometricAuthUIResult { + kSuccessWithUnknownMethod = 0, + kSuccessWithBiometrics = 1, + kSuccessWithDeviceLock = 2, + kCanceledByUser = 3, + kFailed = 4, +}; + +} // namespace password_manager + +// Interface for the biometric authenticator bridge connecting the C++ side +// of the implementation to the Java one. +class BiometricAuthenticatorBridge { + public: + virtual ~BiometricAuthenticatorBridge() = default; + + // Checks whether biometrics are available. + virtual password_manager::BiometricsAvailability CanAuthenticate() = 0; + + // Trigges an authentication flow based on biometrics, with the + // screen lock as fallback. Note: this only supports one authentication + // request at a time. + virtual void Authenticate( + base::OnceCallback<void(password_manager::BiometricAuthUIResult)> + response_callback) = 0; + + // Called when the authentication flow becomes obsolete (e.g. the original + // purpose doesn't exist anymore, the tab was destroyed, etc). + virtual void Cancel() = 0; +}; + +#endif // CHROME_BROWSER_PASSWORD_MANAGER_ANDROID_BIOMETRIC_AUTHENTICATOR_BRIDGE_H_
diff --git a/chrome/browser/password_manager/android/biometric_authenticator_bridge_impl.cc b/chrome/browser/password_manager/android/biometric_authenticator_bridge_impl.cc new file mode 100644 index 0000000..69133ae --- /dev/null +++ b/chrome/browser/password_manager/android/biometric_authenticator_bridge_impl.cc
@@ -0,0 +1,53 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "chrome/browser/password_manager/android/biometric_authenticator_bridge_impl.h" + +#include "base/android/jni_android.h" +#include "base/callback.h" +#include "chrome/browser/password_manager/android/biometric_authenticator_android.h" +#include "chrome/browser/password_manager/android/jni_headers/BiometricAuthenticatorBridge_jni.h" +#include "components/password_manager/core/browser/biometric_authenticator.h" +#include "ui/android/window_android.h" + +using base::android::AttachCurrentThread; +using password_manager::BiometricAuthUIResult; +using password_manager::BiometricsAvailability; + +BiometricAuthenticatorBridgeImpl::BiometricAuthenticatorBridgeImpl( + ui::WindowAndroid* window_android) { + java_object_ = Java_BiometricAuthenticatorBridge_create( + AttachCurrentThread(), reinterpret_cast<intptr_t>(this), + window_android->GetJavaObject()); +} + +BiometricAuthenticatorBridgeImpl::~BiometricAuthenticatorBridgeImpl() { + Java_BiometricAuthenticatorBridge_destroy(AttachCurrentThread(), + java_object_); +} + +BiometricsAvailability BiometricAuthenticatorBridgeImpl::CanAuthenticate() { + return static_cast<BiometricsAvailability>( + Java_BiometricAuthenticatorBridge_canAuthenticate(AttachCurrentThread(), + java_object_)); +} + +void BiometricAuthenticatorBridgeImpl::Authenticate( + base::OnceCallback<void(password_manager::BiometricAuthUIResult)> + response_callback) { + response_callback_ = std::move(response_callback); + Java_BiometricAuthenticatorBridge_authenticate(AttachCurrentThread(), + java_object_); +} + +void BiometricAuthenticatorBridgeImpl::Cancel() { + Java_BiometricAuthenticatorBridge_cancel(AttachCurrentThread(), java_object_); +} + +void BiometricAuthenticatorBridgeImpl::OnAuthenticationCompleted(JNIEnv* env, + jint result) { + if (!response_callback_) + return; + std::move(response_callback_).Run(static_cast<BiometricAuthUIResult>(result)); +}
diff --git a/chrome/browser/password_manager/android/biometric_authenticator_bridge_impl.h b/chrome/browser/password_manager/android/biometric_authenticator_bridge_impl.h new file mode 100644 index 0000000..c1e0eac --- /dev/null +++ b/chrome/browser/password_manager/android/biometric_authenticator_bridge_impl.h
@@ -0,0 +1,49 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef CHROME_BROWSER_PASSWORD_MANAGER_ANDROID_BIOMETRIC_AUTHENTICATOR_BRIDGE_IMPL_H_ +#define CHROME_BROWSER_PASSWORD_MANAGER_ANDROID_BIOMETRIC_AUTHENTICATOR_BRIDGE_IMPL_H_ + +#include "base/callback_forward.h" +#include "chrome/browser/password_manager/android/biometric_authenticator_android.h" +#include "ui/android/window_android.h" + +class BiometricAuthenticatorBridgeImpl : public BiometricAuthenticatorBridge { + public: + explicit BiometricAuthenticatorBridgeImpl(ui::WindowAndroid* controller); + ~BiometricAuthenticatorBridgeImpl() override; + + BiometricAuthenticatorBridgeImpl(const BiometricAuthenticatorBridgeImpl&) = + delete; + BiometricAuthenticatorBridgeImpl& operator=( + const BiometricAuthenticatorBridgeImpl&) = delete; + BiometricAuthenticatorBridgeImpl(const BiometricAuthenticatorBridgeImpl&&) = + delete; + BiometricAuthenticatorBridgeImpl&& operator=( + const BiometricAuthenticatorBridgeImpl&&) = delete; + + password_manager::BiometricsAvailability CanAuthenticate() override; + + // Starts the authentication. + void Authenticate( + base::OnceCallback<void(password_manager::BiometricAuthUIResult)> + response_callback) override; + + // Cancels the ongoing authentication. + void Cancel() override; + + // Called by Java when the authentication completes with the `result`. + void OnAuthenticationCompleted(JNIEnv* env, jint result); + + private: + // Called when the authentication completes. + base::OnceCallback<void(password_manager::BiometricAuthUIResult)> + response_callback_; + + // This object is an instance of BiometricAuthenticatorBridge, i.e. the Java + // counterpart to this class. + base::android::ScopedJavaGlobalRef<jobject> java_object_; +}; + +#endif // CHROME_BROWSER_PASSWORD_MANAGER_ANDROID_BIOMETRIC_AUTHENTICATOR_BRIDGE_IMPL_H_
diff --git a/chrome/browser/password_manager/android/java/src/org/chromium/chrome/browser/password_manager/BiometricAuthenticatorBridge.java b/chrome/browser/password_manager/android/java/src/org/chromium/chrome/browser/password_manager/BiometricAuthenticatorBridge.java index df06b92..92627c83 100644 --- a/chrome/browser/password_manager/android/java/src/org/chromium/chrome/browser/password_manager/BiometricAuthenticatorBridge.java +++ b/chrome/browser/password_manager/android/java/src/org/chromium/chrome/browser/password_manager/BiometricAuthenticatorBridge.java
@@ -150,6 +150,6 @@ @NativeMethods interface Natives { - void onAuthenticationCompleted(long nativeBiometricAuthenticatorAndroid, int result); + void onAuthenticationCompleted(long nativeBiometricAuthenticatorBridgeImpl, int result); } }
diff --git a/chrome/browser/password_manager/password_manager_util_win.cc b/chrome/browser/password_manager/password_manager_util_win.cc index 34e483d2..d8c8c64 100644 --- a/chrome/browser/password_manager/password_manager_util_win.cc +++ b/chrome/browser/password_manager/password_manager_util_win.cc
@@ -388,9 +388,10 @@ cui.pszCaptionText = base::as_wcstr(product_name); cui.hbmBanner = nullptr; - // Disable hang watching until the end of the function since the user can take - // unbounded time to answer the password prompt. (http://crbug.com/806174) - base::IgnoreHangsInScope disabler; + // Never consider the current scope as hung. The hang watching deadline (if + // any) is not valid since the user can take unbounded time to answer the + // password prompt (http://crbug.com/806174) + base::HangWatcher::InvalidateActiveExpectations(); CredentialBufferValidator validator;
diff --git a/chrome/browser/policy/policy_prefs_browsertest.cc b/chrome/browser/policy/policy_prefs_browsertest.cc index e1549d6..546770dc 100644 --- a/chrome/browser/policy/policy_prefs_browsertest.cc +++ b/chrome/browser/policy/policy_prefs_browsertest.cc
@@ -20,6 +20,7 @@ #include "base/no_destructor.h" #include "base/path_service.h" #include "base/run_loop.h" +#include "build/build_config.h" #include "build/chromeos_buildflags.h" #include "chrome/browser/browser_process.h" #include "chrome/browser/profiles/profile.h" @@ -112,9 +113,16 @@ #endif // !defined(OS_ANDROID) }; +// Disabled due to flakiness on Win10 https://crbug.com/1228821 +#if defined(OS_WIN) +#define MAYBE_PolicyToPrefsMapping DISABLED_PolicyToPrefsMapping +#else +#define MAYBE_PolicyToPrefsMapping PolicyToPrefsMapping +#endif + // Verifies that policies make their corresponding preferences become managed, // and that the user can't override that setting. -IN_PROC_BROWSER_TEST_F(PolicyPrefsTest, PolicyToPrefsMapping) { +IN_PROC_BROWSER_TEST_F(PolicyPrefsTest, MAYBE_PolicyToPrefsMapping) { #if !BUILDFLAG(IS_CHROMEOS_ASH) policy::FakeBrowserDMTokenStorage storage; policy::BrowserDMTokenStorage::SetForTesting(&storage);
diff --git a/chrome/browser/prefetch/no_state_prefetch/prerender_nostate_prefetch_browsertest.cc b/chrome/browser/prefetch/no_state_prefetch/prerender_nostate_prefetch_browsertest.cc index 56ab0c1..aad3f768 100644 --- a/chrome/browser/prefetch/no_state_prefetch/prerender_nostate_prefetch_browsertest.cc +++ b/chrome/browser/prefetch/no_state_prefetch/prerender_nostate_prefetch_browsertest.cc
@@ -58,6 +58,7 @@ #include "content/public/common/content_switches.h" #include "content/public/common/result_codes.h" #include "content/public/common/url_constants.h" +#include "content/public/test/back_forward_cache_util.h" #include "content/public/test/browser_test.h" #include "content/public/test/browser_test_utils.h" #include "content/public/test/browsing_data_remover_test_util.h" @@ -1100,6 +1101,11 @@ // Checks that a second prefetch request, started before the first stops, // succeeds. IN_PROC_BROWSER_TEST_F(NoStatePrefetchBrowserTest, PrefetchSimultaneous) { + // The test assumes the previous page gets deleted after navigation. Disable + // back/forward cache to ensure that it doesn't get preserved in the cache. + content::DisableBackForwardCacheForTesting( + GetActiveWebContents(), + content::BackForwardCache::TEST_ASSUMES_NO_CACHING); GURL first_url = src_server()->GetURL("/hung"); // Start the first prefetch directly instead of via PrefetchFromFile for the @@ -1900,6 +1906,11 @@ IN_PROC_BROWSER_TEST_F(SpeculationNoStatePrefetchBrowserTest, HungSpeculationTimedOutByNavigation) { + // The test assumes the previous page gets deleted after navigation. Disable + // back/forward cache to ensure that it doesn't get preserved in the cache. + content::DisableBackForwardCacheForTesting( + browser()->tab_strip_model()->GetActiveWebContents(), + content::BackForwardCache::TEST_ASSUMES_NO_CACHING); UseHttpsSrcServer(); GetNoStatePrefetchManager()->mutable_config().abandon_time_to_live = base::TimeDelta::FromMilliseconds(500);
diff --git a/chrome/browser/prefetch/prefetch_proxy/prefetch_proxy_browsertest.cc b/chrome/browser/prefetch/prefetch_proxy/prefetch_proxy_browsertest.cc index 4627dcb..7b1a929 100644 --- a/chrome/browser/prefetch/prefetch_proxy/prefetch_proxy_browsertest.cc +++ b/chrome/browser/prefetch/prefetch_proxy/prefetch_proxy_browsertest.cc
@@ -85,6 +85,7 @@ #include "content/public/common/network_service_util.h" #include "content/public/common/page_type.h" #include "content/public/common/user_agent.h" +#include "content/public/test/back_forward_cache_util.h" #include "content/public/test/browser_test.h" #include "content/public/test/browser_test_base.h" #include "content/public/test/browser_test_utils.h" @@ -1291,6 +1292,10 @@ IN_PROC_BROWSER_TEST_F(PrefetchProxyBrowserTest, DISABLE_ON_WIN_MAC_CHROMEOS(ConnectProxyEndtoEnd)) { + // The test assumes the previous page gets deleted after navigation. Disable + // back/forward cache to ensure that it doesn't get preserved in the cache. + content::DisableBackForwardCacheForTesting( + GetWebContents(), content::BackForwardCache::TEST_ASSUMES_NO_CACHING); SetDataSaverEnabled(true); ui_test_utils::NavigateToURL(browser(), GetOriginServerURL("/simple.html")); WaitForUpdatedCustomProxyConfig(); @@ -1958,6 +1963,10 @@ IN_PROC_BROWSER_TEST_F(PrefetchProxyBrowserTest, DISABLE_ON_WIN_MAC_CHROMEOS(CookiesUsedAndCopied)) { + // The test assumes the previous page gets deleted after navigation. Disable + // back/forward cache to ensure that it doesn't get preserved in the cache. + content::DisableBackForwardCacheForTesting( + GetWebContents(), content::BackForwardCache::TEST_ASSUMES_NO_CACHING); GURL starting_page = GetOriginServerURL("/simple.html"); SetDataSaverEnabled(true); ui_test_utils::NavigateToURL(browser(), starting_page); @@ -2974,6 +2983,10 @@ IN_PROC_BROWSER_TEST_F(PrefetchProxyWithNSPBrowserTest, DISABLE_ON_WIN_MAC_CHROMEOS(SuccessfulNSPEndToEnd)) { + // The test assumes the previous page gets deleted after navigation. Disable + // back/forward cache to ensure that it doesn't get preserved in the cache. + content::DisableBackForwardCacheForTesting( + GetWebContents(), content::BackForwardCache::TEST_ASSUMES_NO_CACHING); base::HistogramTester histogram_tester; SetDataSaverEnabled(true); @@ -3890,6 +3903,10 @@ IN_PROC_BROWSER_TEST_F(ProbingAndNSPEnabledPrefetchProxyBrowserTest, DISABLE_ON_WIN_MAC_CHROMEOS(ProbeBad_NSPSuccess)) { + // The test assumes the previous page gets deleted after navigation. Disable + // back/forward cache to ensure that it doesn't get preserved in the cache. + content::DisableBackForwardCacheForTesting( + GetWebContents(), content::BackForwardCache::TEST_ASSUMES_NO_CACHING); SetDataSaverEnabled(true); GURL starting_page = GetOriginServerURL("/simple.html"); ui_test_utils::NavigateToURL(browser(), starting_page); @@ -4160,6 +4177,10 @@ IN_PROC_BROWSER_TEST_F(SpeculationPrefetchProxyTest, DISABLE_ON_WIN_MAC_CHROMEOS(SuccessfulNSPEndToEnd)) { + // The test assumes the previous page gets deleted after navigation. Disable + // back/forward cache to ensure that it doesn't get preserved in the cache. + content::DisableBackForwardCacheForTesting( + GetWebContents(), content::BackForwardCache::TEST_ASSUMES_NO_CACHING); base::HistogramTester histogram_tester; SetDataSaverEnabled(true);
diff --git a/chrome/browser/prefetch/search_prefetch/search_prefetch_service_browsertest.cc b/chrome/browser/prefetch/search_prefetch/search_prefetch_service_browsertest.cc index 579c498a2..ca4656f 100644 --- a/chrome/browser/prefetch/search_prefetch/search_prefetch_service_browsertest.cc +++ b/chrome/browser/prefetch/search_prefetch/search_prefetch_service_browsertest.cc
@@ -44,6 +44,7 @@ #include "content/public/common/content_client.h" #include "content/public/common/content_features.h" #include "content/public/common/referrer.h" +#include "content/public/test/back_forward_cache_util.h" #include "content/public/test/browser_test.h" #include "content/public/test/browser_test_utils.h" #include "content/public/test/browsing_data_remover_test_util.h" @@ -1229,6 +1230,11 @@ SearchPrefetchServiceFactory::GetForProfile(browser()->profile()); EXPECT_NE(nullptr, search_prefetch_service); + // Disable back/forward cache to ensure that it doesn't get preserved in the + // back/forward cache. + content::DisableBackForwardCacheForTesting( + GetWebContents(), content::BackForwardCache::TEST_ASSUMES_NO_CACHING); + std::string search_terms = "prefetch_content"; GURL prefetch_url = GetSearchServerQueryURL(search_terms + "&pf=cs"); EXPECT_TRUE(search_prefetch_service->MaybePrefetchURL(prefetch_url)); @@ -1292,6 +1298,11 @@ SearchPrefetchServiceFactory::GetForProfile(browser()->profile()); EXPECT_NE(nullptr, search_prefetch_service); + // Disable back/forward cache to ensure that it doesn't get preserved in the + // back/forward cache. + content::DisableBackForwardCacheForTesting( + GetWebContents(), content::BackForwardCache::TEST_ASSUMES_NO_CACHING); + std::string search_terms = "prefetch_content"; GURL prefetch_url = GetSearchServerQueryURL(search_terms + "&pf=cs"); EXPECT_TRUE(search_prefetch_service->MaybePrefetchURL(prefetch_url)); @@ -1410,6 +1421,11 @@ SearchPrefetchServiceFactory::GetForProfile(browser()->profile()); EXPECT_NE(nullptr, search_prefetch_service); + // Disable back/forward cache to ensure that it doesn't get preserved in the + // back/forward cache. + content::DisableBackForwardCacheForTesting( + GetWebContents(), content::BackForwardCache::TEST_ASSUMES_NO_CACHING); + std::string search_terms = "prefetch_content"; GURL prefetch_url = GetSearchServerQueryURL(search_terms + "&pf=cs"); EXPECT_TRUE(search_prefetch_service->MaybePrefetchURL(prefetch_url));
diff --git a/chrome/browser/printing/print_job.cc b/chrome/browser/printing/print_job.cc index 7f35eb1..ccaff12 100644 --- a/chrome/browser/printing/print_job.cc +++ b/chrome/browser/printing/print_job.cc
@@ -504,15 +504,8 @@ Stop(); break; } - case JobEventDetails::USER_INIT_DONE: - case JobEventDetails::DEFAULT_INIT_DONE: - case JobEventDetails::USER_INIT_CANCELED: { - DCHECK_EQ(event_details.document(), document_.get()); - break; - } case JobEventDetails::NEW_DOC: - case JobEventDetails::JOB_DONE: - case JobEventDetails::ALL_PAGES_REQUESTED: { + case JobEventDetails::JOB_DONE: { // Don't care. break; }
diff --git a/chrome/browser/printing/print_job.h b/chrome/browser/printing/print_job.h index ae319ec..b8b8352 100644 --- a/chrome/browser/printing/print_job.h +++ b/chrome/browser/printing/print_job.h
@@ -242,15 +242,6 @@ public: // Event type. enum Type { - // Print... dialog box has been closed with OK button. - USER_INIT_DONE, - - // Print... dialog box has been closed with CANCEL button. - USER_INIT_CANCELED, - - // An automated initialization has been done, e.g. Init(false, NULL). - DEFAULT_INIT_DONE, - // A new document started printing. NEW_DOC, @@ -262,9 +253,6 @@ // PrintJob. JOB_DONE, - // All missing pages have been requested. - ALL_PAGES_REQUESTED, - // An error occured. Printing is canceled. FAILED,
diff --git a/chrome/browser/printing/print_job_manager.cc b/chrome/browser/printing/print_job_manager.cc index 5524407..842bced 100644 --- a/chrome/browser/printing/print_job_manager.cc +++ b/chrome/browser/printing/print_job_manager.cc
@@ -144,14 +144,10 @@ current_jobs_.erase(print_job); break; } - case JobEventDetails::USER_INIT_DONE: - case JobEventDetails::USER_INIT_CANCELED: - case JobEventDetails::DEFAULT_INIT_DONE: #if defined(OS_WIN) case JobEventDetails::PAGE_DONE: #endif - case JobEventDetails::DOC_DONE: - case JobEventDetails::ALL_PAGES_REQUESTED: { + case JobEventDetails::DOC_DONE: { // Don't care. break; }
diff --git a/chrome/browser/printing/print_job_worker.h b/chrome/browser/printing/print_job_worker.h index 2494da2..4c03b36 100644 --- a/chrome/browser/printing/print_job_worker.h +++ b/chrome/browser/printing/print_job_worker.h
@@ -111,9 +111,8 @@ private: // The shared NotificationService service can only be accessed from the UI // thread, so this class encloses the necessary information to send the - // notification from the right thread. Most NOTIFY_PRINT_JOB_EVENT - // notifications are sent this way, except USER_INIT_DONE, USER_INIT_CANCELED - // and DEFAULT_INIT_DONE. These three are sent through PrintJob::InitDone(). + // notification from the right thread. All NOTIFY_PRINT_JOB_EVENT + // notifications are sent this way. class NotificationTask; // Posts a task to call OnNewPage(). Used to wait for pages/document to be
diff --git a/chrome/browser/printing/print_view_manager_base.cc b/chrome/browser/printing/print_view_manager_base.cc index 9f570fe8..e39b90a 100644 --- a/chrome/browser/printing/print_view_manager_base.cc +++ b/chrome/browser/printing/print_view_manager_base.cc
@@ -775,16 +775,6 @@ TerminatePrintJob(true); break; } - case JobEventDetails::USER_INIT_DONE: - case JobEventDetails::DEFAULT_INIT_DONE: - case JobEventDetails::USER_INIT_CANCELED: { - NOTREACHED(); - break; - } - case JobEventDetails::ALL_PAGES_REQUESTED: { - ShouldQuitFromInnerMessageLoop(); - break; - } #if defined(OS_WIN) case JobEventDetails::PAGE_DONE: #endif @@ -850,11 +840,9 @@ // pages in an hurry if a print_job_ is still pending. No need to wait for it // to actually spool the pages, only to have the renderer generate them. Run // a message loop until we get our signal that the print job is satisfied. - // PrintJob will send a ALL_PAGES_REQUESTED after having received all the - // pages it needs. |quit_inner_loop_| will be called as soon as - // print_job_->document()->IsComplete() is true on either ALL_PAGES_REQUESTED - // or in DidPrintDocument(). The check is done in - // ShouldQuitFromInnerMessageLoop(). + // |quit_inner_loop_| will be called as soon as + // print_job_->document()->IsComplete() is true in DidPrintDocument(). The + // check is done in ShouldQuitFromInnerMessageLoop(). // BLOCKS until all the pages are received. (Need to enable recursive task) if (!RunInnerMessageLoop()) { // This function is always called from DisconnectFromCurrentPrintJob() so we
diff --git a/chrome/browser/printing/print_view_manager_base.h b/chrome/browser/printing/print_view_manager_base.h index b19ee441..48e2baa 100644 --- a/chrome/browser/printing/print_view_manager_base.h +++ b/chrome/browser/printing/print_view_manager_base.h
@@ -195,9 +195,8 @@ // Quits the current message loop if these conditions hold true: a document is // loaded and is complete and waiting_for_pages_to_be_rendered_ is true. This - // function is called in DidPrintDocument() or on ALL_PAGES_REQUESTED - // notification. The inner message loop is created was created by - // RenderAllMissingPagesNow(). + // function is called in DidPrintDocument(). The inner message loop was + // created by RenderAllMissingPagesNow(). void ShouldQuitFromInnerMessageLoop(); // Terminates the print job. No-op if no print job has been created. If
diff --git a/chrome/browser/privacy_budget/privacy_budget_browsertest.cc b/chrome/browser/privacy_budget/privacy_budget_browsertest.cc index 647808c82d..2d79302 100644 --- a/chrome/browser/privacy_budget/privacy_budget_browsertest.cc +++ b/chrome/browser/privacy_budget/privacy_budget_browsertest.cc
@@ -30,6 +30,7 @@ #include "components/ukm/ukm_test_helper.h" #include "components/unified_consent/unified_consent_service.h" #include "components/variations/service/buildflags.h" +#include "content/public/browser/back_forward_cache.h" #include "content/public/test/browser_test.h" #include "content/public/test/browser_test_utils.h" #include "content/public/test/test_utils.h" @@ -164,6 +165,12 @@ IN_PROC_BROWSER_TEST_F(PrivacyBudgetBrowserTest, SamplingScreenAPIs) { ASSERT_TRUE(embedded_test_server()->Start()); + // Ensure that the previous page won't be stored in the back/forward cache, so + // that the histogram will be recorded when the previous page is unloaded. + // TODO(https://crbug.com/1229122): Investigate if this needs further fix. + web_contents()->GetController().GetBackForwardCache().DisableForTesting( + content::BackForwardCache::TEST_ASSUMES_NO_CACHING); + content::DOMMessageQueue messages; base::RunLoop run_loop; @@ -218,6 +225,12 @@ IN_PROC_BROWSER_TEST_F(PrivacyBudgetBrowserTest, CallsCanvasToBlob) { ASSERT_TRUE(embedded_test_server()->Start()); + + // Ensure that the previous page won't be stored in the back/forward cache, so + // that the histogram will be recorded when the previous page is unloaded. + web_contents()->GetController().GetBackForwardCache().DisableForTesting( + content::BackForwardCache::TEST_ASSUMES_NO_CACHING); + content::DOMMessageQueue messages; base::RunLoop run_loop; @@ -263,6 +276,11 @@ IN_PROC_BROWSER_TEST_F(PrivacyBudgetBrowserTest, CanvasToBlobDifferentDocument) { ASSERT_TRUE(embedded_test_server()->Start()); + // Ensure that the previous page won't be stored in the back/forward cache, so + // that the histogram will be recorded when the previous page is unloaded. + web_contents()->GetController().GetBackForwardCache().DisableForTesting( + content::BackForwardCache::TEST_ASSUMES_NO_CACHING); + content::DOMMessageQueue messages; base::RunLoop run_loop;
diff --git a/chrome/browser/resources/settings/settings.html b/chrome/browser/resources/settings/settings.html index af261fd..50cb169 100644 --- a/chrome/browser/resources/settings/settings.html +++ b/chrome/browser/resources/settings/settings.html
@@ -1,6 +1,7 @@ <!doctype html> <html dir="$i18n{textdirection}" lang="$i18n{language}" class="loading" - $i18n{enableLandingPageRedesignAttribute}> + $i18n{enableLandingPageRedesignAttribute} + $i18n{enableBrandingUpdateAttribute}> <head> <meta charset="utf-8"> <meta name="color-scheme" content="light dark">
diff --git a/chrome/browser/resources/tab_search/app.js b/chrome/browser/resources/tab_search/app.js index 74ad3f6..4d49cd1 100644 --- a/chrome/browser/resources/tab_search/app.js +++ b/chrome/browser/resources/tab_search/app.js
@@ -382,11 +382,13 @@ return; case TabItemType.RECENTLY_CLOSED_TAB: this.apiProxy_.openRecentlyClosedEntry( - /** @type {!TabData} */ (itemData).tab.tabId); + /** @type {!TabData} */ (itemData).tab.tabId, !!this.searchText_, + true); return; case TabItemType.RECENTLY_CLOSED_TAB_GROUP: this.apiProxy_.openRecentlyClosedEntry( - /** @type {!TabGroupData} */ (itemData).tabGroup.sessionId); + /** @type {!TabGroupData} */ (itemData).tabGroup.sessionId, + !!this.searchText_, false); return; default: throw new Error('ItemData is of invalid type.');
diff --git a/chrome/browser/resources/tab_search/tab_search_api_proxy.js b/chrome/browser/resources/tab_search/tab_search_api_proxy.js index 105f1c8..f22e7ff 100644 --- a/chrome/browser/resources/tab_search/tab_search_api_proxy.js +++ b/chrome/browser/resources/tab_search/tab_search_api_proxy.js
@@ -11,6 +11,16 @@ * See tools/metrics/histograms/enums.xml. * @enum {number} */ +export const RecentlyClosedItemOpenAction = { + WITHOUT_SEARCH: 0, + WITH_SEARCH: 1, +}; + +/** + * These values are persisted to logs and should not be renumbered or re-used. + * See tools/metrics/histograms/enums.xml. + * @enum {number} + */ export const TabSwitchAction = { WITHOUT_SEARCH : 0, WITH_SEARCH : 1, @@ -28,8 +38,12 @@ /** @return {Promise<{profileData: ProfileData}>} */ getProfileData() {} - /** @param {number} id */ - openRecentlyClosedEntry(id) {} + /** + * @param {number} id + * @param {boolean} withSearch + * @param {boolean} isTab + */ + openRecentlyClosedEntry(id, withSearch, isTab) {} /** * @param {!SwitchToTabInfo} info @@ -74,7 +88,14 @@ } /** @override */ - openRecentlyClosedEntry(id) { + openRecentlyClosedEntry(id, withSearch, isTab) { + chrome.metricsPrivate.recordEnumerationValue( + isTab ? 'Tabs.TabSearch.WebUI.RecentlyClosedTabOpenAction' : + 'Tabs.TabSearch.WebUI.RecentlyClosedGroupOpenAction', + withSearch ? RecentlyClosedItemOpenAction.WITH_SEARCH : + RecentlyClosedItemOpenAction.WITHOUT_SEARCH, + Object.keys(RecentlyClosedItemOpenAction).length); + this.handler.openRecentlyClosedEntry(id); }
diff --git a/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc b/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc index ef853f54..7b0ac93 100644 --- a/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc +++ b/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
@@ -40,6 +40,7 @@ #include "components/security_interstitials/content/unsafe_resource_util.h" #include "components/security_interstitials/core/unsafe_resource.h" #include "components/signin/public/identity_manager/identity_test_environment.h" +#include "content/public/browser/back_forward_cache.h" #include "content/public/browser/browser_task_traits.h" #include "content/public/browser/browser_thread.h" #include "content/public/browser/navigation_entry.h"
diff --git a/chrome/browser/safe_browsing/ui_manager.cc b/chrome/browser/safe_browsing/ui_manager.cc index 9892f54..5eb9652f 100644 --- a/chrome/browser/safe_browsing/ui_manager.cc +++ b/chrome/browser/safe_browsing/ui_manager.cc
@@ -113,17 +113,20 @@ scoped_refptr<SafeBrowsingUIManager> ui_manager, const security_interstitials::UnsafeResource& resource) { content::WebContents* web_contents = resource.web_contents_getter.Run(); + + if (!web_contents) { + // Tab is gone. + resource.DispatchCallback(FROM_HERE, false /*proceed*/, + false /*showed_interstitial*/); + return; + } + prerender::NoStatePrefetchContents* no_state_prefetch_contents = - web_contents - ? prerender::ChromeNoStatePrefetchContentsDelegate::FromWebContents( - web_contents) - : nullptr; - if (!web_contents || no_state_prefetch_contents) { - if (no_state_prefetch_contents) { - no_state_prefetch_contents->Destroy( - prerender::FINAL_STATUS_SAFE_BROWSING); - } - // Tab is gone or it's being prerendered. + prerender::ChromeNoStatePrefetchContentsDelegate::FromWebContents( + web_contents); + if (no_state_prefetch_contents) { + no_state_prefetch_contents->Destroy(prerender::FINAL_STATUS_SAFE_BROWSING); + // Tab is being prerendered. resource.DispatchCallback(FROM_HERE, false /*proceed*/, false /*showed_interstitial*/); return;
diff --git a/chrome/browser/search/search_unittest.cc b/chrome/browser/search/search_unittest.cc index 6001ba5e..388675c 100644 --- a/chrome/browser/search/search_unittest.cc +++ b/chrome/browser/search/search_unittest.cc
@@ -97,6 +97,39 @@ return instant_service->IsInstantProcess( contents->GetMainFrame()->GetProcess()->GetID()); } + + // Each test case represents a navigation to |start_url| followed by a + // navigation to |end_url|. We will check whether each navigation lands in an + // Instant process, and also whether the navigation from start to end re-uses + // the same SiteInstance (and hence the same RenderViewHost, etc.). + // Note that we need to define this here because the flags needed to check + // content::CanSameSiteMainFrameNavigationsChangeSiteInstances() might not + // be set yet if we define this immediately (e.g. outside of the test class). + const struct ProcessIsolationTestCase { + const char* description; + const char* start_url; + bool start_in_instant_process; + const char* end_url; + bool end_in_instant_process; + bool same_site_instance; + bool same_process; + } kProcessIsolationTestCases[5] = { + {"Remote NTP -> SRP", "https://foo.com/newtab", true, + "https://foo.com/url", false, false, false}, + {"Remote NTP -> Regular", "https://foo.com/newtab", true, + "https://foo.com/other", false, false, false}, + {"SRP -> SRP", "https://foo.com/url", false, "https://foo.com/url", false, + true, true}, + // Same-site (but not same URL) navigations might switch site instances + // but keep the same process when ProactivelySwapBrowsingInstance is + // enabled on same-site navigations. + {"SRP -> Regular", "https://foo.com/url", false, "https://foo.com/other", + false, !content::CanSameSiteMainFrameNavigationsChangeSiteInstances(), + true}, + {"Regular -> SRP", "https://foo.com/other", false, "https://foo.com/url", + false, !content::CanSameSiteMainFrameNavigationsChangeSiteInstances(), + true}, + }; }; struct SearchTestCase { @@ -151,36 +184,6 @@ } } -// Each test case represents a navigation to |start_url| followed by a -// navigation to |end_url|. We will check whether each navigation lands in an -// Instant process, and also whether the navigation from start to end re-uses -// the same SiteInstance (and hence the same RenderViewHost, etc.). -const struct ProcessIsolationTestCase { - const char* description; - const char* start_url; - bool start_in_instant_process; - const char* end_url; - bool end_in_instant_process; - bool same_site_instance; - bool same_process; -} kProcessIsolationTestCases[] = { - {"Remote NTP -> SRP", "https://foo.com/newtab", true, "https://foo.com/url", - false, false, false}, - {"Remote NTP -> Regular", "https://foo.com/newtab", true, - "https://foo.com/other", false, false, false}, - {"SRP -> SRP", "https://foo.com/url", false, "https://foo.com/url", false, - true, true}, - // Same-site (but not same URL) navigations might switch site instances but - // keep the same process when ProactivelySwapBrowsingInstance is enabled on - // same-site navigations. - {"SRP -> Regular", "https://foo.com/url", false, "https://foo.com/other", - false, !content::CanSameSiteMainFrameNavigationsChangeSiteInstances(), - true}, - {"Regular -> SRP", "https://foo.com/other", false, "https://foo.com/url", - false, !content::CanSameSiteMainFrameNavigationsChangeSiteInstances(), - true}, -}; - TEST_F(SearchTest, ProcessIsolation) { for (size_t i = 0; i < base::size(kProcessIsolationTestCases); ++i) { const ProcessIsolationTestCase& test = kProcessIsolationTestCases[i];
diff --git a/chrome/browser/share/core/resources/share_targets.asciipb b/chrome/browser/share/core/resources/share_targets.asciipb index d419da72..289e8ad5 100644 --- a/chrome/browser/share/core/resources/share_targets.asciipb +++ b/chrome/browser/share/core/resources/share_targets.asciipb
@@ -5,7 +5,7 @@ ## ## Top level settings ## -version_id: 2 +version_id: 3 ## ## Share Targets @@ -17,7 +17,7 @@ targets { nickname: "reddit" - url: "http://reddit.com/submit?url=%(escaped_url)s&title=%(escaped_title)s" + url: "http://reddit.com/submit?url=%(escaped_url)&title=%(escaped_title)" icon: "iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAAXNSR0IArs4c6QAA" "AERlWElmTU0AKgAAAAgAAYdpAAQAAAABAAAAGgAAAAAAA6ABAAMAAAABAAEAAKAC" @@ -151,7 +151,7 @@ targets { nickname: "whatsapp" - url: "https://web.whatsapp.com/send?text=%(escpaed_url)" + url: "https://web.whatsapp.com/send?text=%(escaped_url)" icon: "iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAAXNSR0IArs4c6QAA" "AERlWElmTU0AKgAAAAgAAYdpAAQAAAABAAAAGgAAAAAAA6ABAAMAAAABAAEAAKAC" @@ -307,7 +307,7 @@ targets { nickname: "facebook" - url: "http://www.facebook.com/dialog/share?app_id=966242223397117&href=%(escaped_url)s&" + url: "https://www.facebook.com/sharer/sharer.php?u=%(escaped_url)" icon: "iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAAXNSR0IArs4c6QAA" "AERlWElmTU0AKgAAAAgAAYdpAAQAAAABAAAAGgAAAAAAA6ABAAMAAAABAAEAAKAC" @@ -361,7 +361,7 @@ targets { nickname: "linkedin" - url: "http://www.linkedin.com/shareArticle?url=%(escaped_url)s&title=%(escaped_title)s&summary=%(escaped_description)s" + url: "http://www.linkedin.com/shareArticle?url=%(escaped_url)&title=%(escaped_title)" icon: "iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAAXNSR0IArs4c6QAA" "AERlWElmTU0AKgAAAAgAAYdpAAQAAAABAAAAGgAAAAAAA6ABAAMAAAABAAEAAKAC" @@ -457,7 +457,7 @@ targets { nickname: "pinterest" - url: "http://pinterest.com/pin/create/button/?url=%(escaped_url)s&description=%(escaped_title)s" + url: "http://pinterest.com/pin/create/button/?url=%(escaped_url)&description=%(escaped_title)" icon: "iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAAXNSR0IArs4c6QAA" "AERlWElmTU0AKgAAAAgAAYdpAAQAAAABAAAAGgAAAAAAA6ABAAMAAAABAAEAAKAC" @@ -611,7 +611,7 @@ targets { nickname: "twitter" - url: "https://twitter.com/intent/tweet?url=%(escaped_shortened_url)s&text=%(escaped_title)s" + url: "https://twitter.com/intent/tweet?url=%(escaped_url)&text=%(escaped_title)" icon: "iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAAXNSR0IArs4c6QAA" "AERlWElmTU0AKgAAAAgAAYdpAAQAAAABAAAAGgAAAAAAA6ABAAMAAAABAAEAAKAC" @@ -705,7 +705,7 @@ targets { nickname: "vkontakte" - url: "http://vkontakte.ru/share.php?url=%(escaped_url)s" + url: "http://vkontakte.ru/share.php?url=%(escaped_url)" icon: "iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAAXNSR0IArs4c6QAA" "AERlWElmTU0AKgAAAAgAAYdpAAQAAAABAAAAGgAAAAAAA6ABAAMAAAABAAEAAKAC"
diff --git a/chrome/browser/sharing_hub/sharing_hub_model.cc b/chrome/browser/sharing_hub/sharing_hub_model.cc index 398f566..67284484 100644 --- a/chrome/browser/sharing_hub/sharing_hub_model.cc +++ b/chrome/browser/sharing_hub/sharing_hub_model.cc
@@ -5,6 +5,7 @@ #include "chrome/browser/sharing_hub/sharing_hub_model.h" #include "base/base64.h" +#include "base/logging.h" #include "base/strings/utf_string_conversions.h" #include "base/task/post_task.h" #include "base/task/thread_pool.h" @@ -37,6 +38,10 @@ return gfx::Image::CreateFrom1xPNGBytes( reinterpret_cast<const unsigned char*>(icon_str.data()), icon_str.size()); } + +const char kUrlReplace[] = "%(escaped_url)"; +const char kTitleReplace[] = "%(escaped_title)"; + } // namespace SharingHubModel::SharingHubModel(content::BrowserContext* context) @@ -76,12 +81,30 @@ } } -void SharingHubModel::ExecuteThirdPartyAction(Profile* profile, int id) { +void SharingHubModel::ExecuteThirdPartyAction(Profile* profile, + int id, + const std::string& url, + const std::u16string& title) { auto url_it = third_party_action_urls_.find(id); if (url_it == third_party_action_urls_.end()) return; + std::string url_found = url_it->second.spec(); + size_t location_shared_url = url_found.find(kUrlReplace); + if (location_shared_url != std::string::npos) { + url_found.replace(location_shared_url, strlen(kUrlReplace), url); + } else { + LOG(ERROR) << "Third Party Share API did not contain URL param."; + } - NavigateParams params(profile, url_it->second, ui::PAGE_TRANSITION_LINK); + size_t location_title = url_found.find(kTitleReplace); + if (location_title != std::string::npos) { + std::string title_utf8 = base::UTF16ToUTF8(title); + url_found.replace(location_title, strlen(kTitleReplace), title_utf8); + } + + // TODO (crbug.com/1229421) support descriptions in third party targets. + + NavigateParams params(profile, GURL(url_found), ui::PAGE_TRANSITION_LINK); params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB; params.tabstrip_add_types = TabStripModel::ADD_ACTIVE; Navigate(¶ms); @@ -125,7 +148,6 @@ void SharingHubModel::PopulateThirdPartyActions() { // Note: The third party action id must be greater than 0, otherwise the // action will be disabled in the app menu. - std::string locale = "GLOBAL"; int id = 1; if (third_party_targets_) { for (const sharing::mojom::ShareTarget& target :
diff --git a/chrome/browser/sharing_hub/sharing_hub_model.h b/chrome/browser/sharing_hub/sharing_hub_model.h index 502eb7c..c714901 100644 --- a/chrome/browser/sharing_hub/sharing_hub_model.h +++ b/chrome/browser/sharing_hub/sharing_hub_model.h
@@ -48,6 +48,8 @@ class SharingHubModel : public sharing::ShareTargetsObserver { public: explicit SharingHubModel(content::BrowserContext* context); + SharingHubModel(const SharingHubModel&) = delete; + SharingHubModel& operator=(const SharingHubModel&) = delete; ~SharingHubModel() override; // Populates the vector with first party Sharing Hub actions, ordered by @@ -62,7 +64,10 @@ // Executes the third party action indicated by |id|, i.e. opens a new tab to // the corresponding webpage. - void ExecuteThirdPartyAction(Profile* profile, int id); + void ExecuteThirdPartyAction(Profile* profile, + int id, + const std::string& url, + const std::u16string& title); // sharing::ShareTargetsObserver implementation. void OnShareTargetsUpdated( @@ -85,8 +90,6 @@ content::BrowserContext* context_; std::unique_ptr<sharing::mojom::ShareTargets> third_party_targets_; - - DISALLOW_COPY_AND_ASSIGN(SharingHubModel); }; } // namespace sharing_hub
diff --git a/chrome/browser/signin/dice_tab_helper_unittest.cc b/chrome/browser/signin/dice_tab_helper_unittest.cc index 2af5c3b..fea78b1 100644 --- a/chrome/browser/signin/dice_tab_helper_unittest.cc +++ b/chrome/browser/signin/dice_tab_helper_unittest.cc
@@ -10,6 +10,7 @@ #include "chrome/test/base/testing_profile.h" #include "components/signin/public/base/signin_metrics.h" #include "content/public/common/content_features.h" +#include "content/public/test/back_forward_cache_util.h" #include "content/public/test/navigation_simulator.h" #include "content/public/test/test_renderer_host.h" #include "google_apis/gaia/gaia_urls.h" @@ -70,6 +71,11 @@ } TEST_F(DiceTabHelperTest, SigninPageStatus) { + // The test assumes the previous page gets deleted after navigation and will + // be recreated after navigation (which resets the signin page state). Disable + // back/forward cache to ensure that it doesn't get preserved in the cache. + content::DisableBackForwardCacheForTesting( + web_contents(), content::BackForwardCache::TEST_ASSUMES_NO_CACHING); DiceTabHelper::CreateForWebContents(web_contents()); DiceTabHelper* dice_tab_helper = DiceTabHelper::FromWebContents(web_contents());
diff --git a/chrome/browser/sync/test/integration/single_client_nigori_sync_test.cc b/chrome/browser/sync/test/integration/single_client_nigori_sync_test.cc index 199306c..aa1c1ea 100644 --- a/chrome/browser/sync/test/integration/single_client_nigori_sync_test.cc +++ b/chrome/browser/sync/test/integration/single_client_nigori_sync_test.cc
@@ -1400,8 +1400,6 @@ // Let's resolve the error. Mimic opening a web page where the user would // interact with the degraded recoverability flow. Add an extra tab so the // flow tab can be closed via javascript. - // TODO(crbug.com/1081649): This should use a dedicated page, instead of the - // retrieval page. chrome::AddTabAt(GetBrowser(0), GURL(url::kAboutBlankURL), /*index=*/0, /*foreground=*/true); OpenTabForSyncTrustedVaultUserActionForTesting(
diff --git a/chrome/browser/task_manager/providers/web_contents/devtools_tag_browsertest.cc b/chrome/browser/task_manager/providers/web_contents/devtools_tag_browsertest.cc index 14eee660..58b9a6d 100644 --- a/chrome/browser/task_manager/providers/web_contents/devtools_tag_browsertest.cc +++ b/chrome/browser/task_manager/providers/web_contents/devtools_tag_browsertest.cc
@@ -9,6 +9,7 @@ #include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/test/base/in_process_browser_test.h" #include "chrome/test/base/ui_test_utils.h" +#include "content/public/browser/back_forward_cache.h" #include "content/public/test/browser_test.h" #include "content/public/test/test_utils.h" #include "net/test/embedded_test_server/embedded_test_server.h" @@ -126,10 +127,23 @@ } EXPECT_NE(task_manager.tasks()[0]->title(), task_manager.tasks()[1]->title()); + // If same-site back-forward cache is enabled, the task for the previous page + // will still be around. + EXPECT_EQ( + content::BackForwardCache::IsSameSiteBackForwardCacheFeatureEnabled() + ? 3U + : 2U, + task_manager.tasks().size()); + // Close the DevTools window. CloseDevToolsWindow(); EXPECT_EQ(1U, tags_manager()->tracked_tags().size()); - EXPECT_EQ(1U, task_manager.tasks().size()); + + EXPECT_EQ( + content::BackForwardCache::IsSameSiteBackForwardCacheFeatureEnabled() + ? 2U + : 1U, + task_manager.tasks().size()); } } // namespace task_manager
diff --git a/chrome/browser/task_manager/providers/web_contents/subframe_task_browsertest.cc b/chrome/browser/task_manager/providers/web_contents/subframe_task_browsertest.cc index ac34978..417e0bc2 100644 --- a/chrome/browser/task_manager/providers/web_contents/subframe_task_browsertest.cc +++ b/chrome/browser/task_manager/providers/web_contents/subframe_task_browsertest.cc
@@ -10,6 +10,7 @@ #include "chrome/grit/generated_resources.h" #include "chrome/test/base/in_process_browser_test.h" #include "chrome/test/base/ui_test_utils.h" +#include "content/public/browser/back_forward_cache.h" #include "content/public/browser/render_frame_host.h" #include "content/public/browser/render_widget_host.h" #include "content/public/browser/render_widget_host_view.h" @@ -122,10 +123,15 @@ } // If we navigate to the simple page on a.com which doesn't have cross-site - // iframes, we expect not to have any SubframeTasks. + // iframes, we expect not to have any SubframeTasks, except if the previous + // page is saved in the back-forward cache. NavigateTo(kSimplePageUrl); - ASSERT_EQ(1U, task_manager.tasks().size()); + ASSERT_EQ( + content::BackForwardCache::IsSameSiteBackForwardCacheFeatureEnabled() + ? 4U + : 1U, + task_manager.tasks().size()); const Task* simple_page_task = task_manager.tasks().front(); EXPECT_EQ(Task::RENDERER, simple_page_task->GetType()); EXPECT_EQ(PrefixExpectedTabTitle("Title Of Awesomeness"),
diff --git a/chrome/browser/task_manager/providers/web_contents/tab_contents_tag_browsertest.cc b/chrome/browser/task_manager/providers/web_contents/tab_contents_tag_browsertest.cc index e1c95d0..7703416 100644 --- a/chrome/browser/task_manager/providers/web_contents/tab_contents_tag_browsertest.cc +++ b/chrome/browser/task_manager/providers/web_contents/tab_contents_tag_browsertest.cc
@@ -21,6 +21,7 @@ #include "components/favicon/content/content_favicon_driver.h" #include "components/favicon/core/favicon_driver.h" #include "components/favicon/core/favicon_driver_observer.h" +#include "content/public/browser/back_forward_cache.h" #include "content/public/browser/favicon_status.h" #include "content/public/browser/navigation_entry.h" #include "content/public/test/browser_test.h" @@ -319,9 +320,14 @@ if (content::CanSameSiteMainFrameNavigationsChangeRenderFrameHosts()) { // When ProactivelySwapBrowsingInstance or RenderDocument is enabled on // same-site main frame navigations, we'll get a new task because we are - // changing RenderFrameHosts. - ASSERT_EQ(1U, task_manager.tasks().size()); - task = task_manager.tasks().back(); + // changing RenderFrameHosts. Note that the previous page's task might still + // be around if the previous page is saved in the back-forward cache. + ASSERT_EQ( + content::BackForwardCache::IsSameSiteBackForwardCacheFeatureEnabled() + ? 2U + : 1U, + task_manager.tasks().size()); + task = task_manager.tasks().front(); } ASSERT_EQ(GetDefaultTitleForUrl(no_favicon_page_url), task->title());
diff --git a/chrome/browser/themes/browser_theme_pack.cc b/chrome/browser/themes/browser_theme_pack.cc index b6d7b18..e8d761e 100644 --- a/chrome/browser/themes/browser_theme_pack.cc +++ b/chrome/browser/themes/browser_theme_pack.cc
@@ -1222,8 +1222,7 @@ } } -void BrowserThemePack::SetColorsFromJSON( - const base::DictionaryValue* colors_value) { +void BrowserThemePack::SetColorsFromJSON(const base::Value* colors_value) { DCHECK(colors_); std::map<int, SkColor> temp_colors; @@ -1240,15 +1239,15 @@ } } -void BrowserThemePack::ReadColorsFromJSON( - const base::DictionaryValue* colors_value, - std::map<int, SkColor>* temp_colors) { +void BrowserThemePack::ReadColorsFromJSON(const base::Value* colors_value, + std::map<int, SkColor>* temp_colors) { + DCHECK(colors_value); + DCHECK(colors_value->is_dict()); // Parse the incoming data from |colors_value| into an intermediary structure. - for (base::DictionaryValue::Iterator iter(*colors_value); !iter.IsAtEnd(); - iter.Advance()) { - if (!iter.value().is_list()) + for (const auto& iter : colors_value->DictItems()) { + if (!iter.second.is_list()) continue; - base::Value::ConstListView color_list = iter.value().GetList(); + base::Value::ConstListView color_list = iter.second.GetList(); if (!(color_list.size() == 3 || color_list.size() == 4)) continue; @@ -1285,14 +1284,14 @@ color = SkColorSetRGB(*r, *g, *b); } - if (iter.key() == "ntp_section") { + if (iter.first == "ntp_section") { // We no longer use ntp_section, but to support legacy // themes we still need to use it as a fallback for // ntp_header. if (!temp_colors->count(TP::COLOR_NTP_HEADER)) (*temp_colors)[TP::COLOR_NTP_HEADER] = color; } else { - int id = GetIntForString(iter.key(), kOverwritableColorTable, + int id = GetIntForString(iter.first, kOverwritableColorTable, kOverwritableColorTableLength); if (id != -1) (*temp_colors)[id] = color;
diff --git a/chrome/browser/themes/browser_theme_pack.h b/chrome/browser/themes/browser_theme_pack.h index 8812031..0aa61b1d 100644 --- a/chrome/browser/themes/browser_theme_pack.h +++ b/chrome/browser/themes/browser_theme_pack.h
@@ -180,10 +180,10 @@ // Transforms the JSON color values into their final versions in the // |colors_| array and also fills in unspecified colors based on tint values. - void SetColorsFromJSON(const base::DictionaryValue* color_value); + void SetColorsFromJSON(const base::Value* color_value); // Implementation details of BuildColorsFromJSON(). - void ReadColorsFromJSON(const base::DictionaryValue* colors_value, + void ReadColorsFromJSON(const base::Value* colors_value, std::map<int, SkColor>* temp_colors); // Transforms the JSON display properties into |display_properties_|.
diff --git a/chrome/browser/ui/omnibox/chrome_omnibox_client.cc b/chrome/browser/ui/omnibox/chrome_omnibox_client.cc index 0e56b3d1..c0371e6 100644 --- a/chrome/browser/ui/omnibox/chrome_omnibox_client.cc +++ b/chrome/browser/ui/omnibox/chrome_omnibox_client.cc
@@ -417,7 +417,7 @@ if (translate_client) { DCHECK_NE(nullptr, translate_client->GetTranslateManager()); translate_client->GetTranslateManager()->ShowTranslateUI( - /*auto_translate=*/true); + /*auto_translate=*/true, /*triggered_from_menu=*/true); } } }
diff --git a/chrome/browser/ui/omnibox/omnibox_pedals_unittest.cc b/chrome/browser/ui/omnibox/omnibox_pedals_unittest.cc index c7ade08..d0efafd 100644 --- a/chrome/browser/ui/omnibox/omnibox_pedals_unittest.cc +++ b/chrome/browser/ui/omnibox/omnibox_pedals_unittest.cc
@@ -18,19 +18,24 @@ // testing things that depend on Chrome resources, for example the localization // pak files generated by chrome:packed_resources. -TEST(OmniboxPedals, DataLoadsForAllLocales) { +void TestDataLoadsForAllLocales(bool with_translation_console) { // Locale selection is platform sensitive. On Linux, environment is used. std::unique_ptr<base::Environment> env = base::Environment::Create(); MockAutocompleteProviderClient client; base::test::ScopedFeatureList feature_list; - // TODO(orinj): Consider loading sets of cover cases from translation - // data since pedal_processor-generated tests won't be available. - // Once a new source of test data is established, enable - // the kOmniboxPedalsTranslationConsole feature here. - feature_list.InitWithFeatures( - {omnibox::kOmniboxPedalsBatch2, omnibox::kOmniboxPedalsBatch2NonEnglish, - omnibox::kOmniboxPedalsBatch3}, - {}); + std::vector<base::Feature> features = { + omnibox::kOmniboxPedalsBatch2, + omnibox::kOmniboxPedalsBatch2NonEnglish, + omnibox::kOmniboxPedalsBatch3, + }; + if (with_translation_console) { + // TODO(orinj): Consider loading sets of cover cases from translation + // data since pedal_processor-generated tests won't be available. + // Once a new source of test data is established, enable + // the `kOmniboxPedalsTranslationConsole` feature here. + features.push_back(omnibox::kOmniboxPedalsTranslationConsole); + } + feature_list.InitWithFeatures(features, {}); struct TestCase { std::string locale; @@ -600,26 +605,43 @@ ui::ResourceBundle::GetSharedInstance().ReloadLocaleResources( test_case.locale); - // Instantiating the provider loads concept data from shared ResourceBundle. + // Instantiating the provider loads concept data from shared ResourceBundle, + // or from omnibox_pedal_synonyms.grd if using translation console. OmniboxPedalProvider provider(client, true); - EXPECT_EQ(provider.FindPedalMatch(u""), nullptr); + + // Note, with translation console process, we don't have specific cover + // cases to test, and there is no fallback to English. Skip the trigger + // checks. Just instantiating the provider above confirms that any + // available translation data loads. + if (!with_translation_console) { #if BUILDFLAG(IS_CHROMEOS_ASH) - // TODO(orinj): Get ChromeOS to use the right dataset, but for now make this - // a soft failure so as to not block all other platforms. To ensure this - // is not going to cause failure in production, still test that English - // triggering functions. Data is there; it works; but warn about locale. - if (!provider.FindPedalMatch(base::UTF8ToUTF16(test_case.triggers[0]))) { - EXPECT_NE(provider.FindPedalMatch(u"clear history"), nullptr); - LOG(WARNING) << "ChromeOS using English for locale " << test_case.locale; - continue; - } + // TODO(orinj): Get ChromeOS to use the right dataset, but for now make + // this + // a soft failure so as to not block all other platforms. To ensure this + // is not going to cause failure in production, still test that English + // triggering functions. Data is there; it works; but warn about locale. + if (!provider.FindPedalMatch(base::UTF8ToUTF16(test_case.triggers[0]))) { + EXPECT_NE(provider.FindPedalMatch(u"clear history"), nullptr); + LOG(WARNING) << "ChromeOS using English for locale " + << test_case.locale; + continue; + } #endif - for (const std::string& trigger : test_case.triggers) { - EXPECT_NE(provider.FindPedalMatch(base::UTF8ToUTF16(trigger)), nullptr) - << "locale: " << test_case.locale << std::endl - << "trigger: " << trigger; + for (const std::string& trigger : test_case.triggers) { + EXPECT_NE(provider.FindPedalMatch(base::UTF8ToUTF16(trigger)), nullptr) + << "locale: " << test_case.locale << std::endl + << "trigger: " << trigger; + } } } } + +TEST(OmniboxPedals, DataLoadsForAllLocales) { + TestDataLoadsForAllLocales(true); +} + +TEST(OmniboxPedals, DataLoadsForAllLocalesWithoutTranslationConsole) { + TestDataLoadsForAllLocales(false); +}
diff --git a/chrome/browser/ui/search_engines/search_engine_tab_helper.cc b/chrome/browser/ui/search_engines/search_engine_tab_helper.cc index 8efc2a0..91b3973 100644 --- a/chrome/browser/ui/search_engines/search_engine_tab_helper.cc +++ b/chrome/browser/ui/search_engines/search_engine_tab_helper.cc
@@ -40,6 +40,20 @@ } // namespace +// static +void SearchEngineTabHelper::BindOpenSearchDescriptionDocumentHandler( + mojo::PendingAssociatedReceiver< + chrome::mojom::OpenSearchDescriptionDocumentHandler> receiver, + content::RenderFrameHost* rfh) { + auto* web_contents = content::WebContents::FromRenderFrameHost(rfh); + if (!web_contents) + return; + auto* tab_helper = SearchEngineTabHelper::FromWebContents(web_contents); + if (!tab_helper) + return; + tab_helper->osdd_handler_receivers_.Bind(rfh, std::move(receiver)); +} + SearchEngineTabHelper::~SearchEngineTabHelper() = default; void SearchEngineTabHelper::DidFinishNavigation( @@ -84,9 +98,7 @@ SearchEngineTabHelper::SearchEngineTabHelper(WebContents* web_contents) : content::WebContentsObserver(web_contents), - osdd_handler_receivers_(web_contents, - this, - content::WebContentsFrameReceiverSetPassKey()) { + osdd_handler_receivers_(web_contents, this) { DCHECK(web_contents); favicon::CreateContentFaviconDriverForWebContents(web_contents);
diff --git a/chrome/browser/ui/search_engines/search_engine_tab_helper.h b/chrome/browser/ui/search_engines/search_engine_tab_helper.h index ad1af83b..6492852 100644 --- a/chrome/browser/ui/search_engines/search_engine_tab_helper.h +++ b/chrome/browser/ui/search_engines/search_engine_tab_helper.h
@@ -12,8 +12,8 @@ #include "components/favicon/core/favicon_driver.h" #include "components/favicon/core/favicon_driver_observer.h" #include "components/find_in_page/find_notification_details.h" +#include "content/public/browser/render_frame_host_receiver_set.h" #include "content/public/browser/web_contents_observer.h" -#include "content/public/browser/web_contents_receiver_set.h" #include "content/public/browser/web_contents_user_data.h" namespace content { @@ -28,6 +28,11 @@ public chrome::mojom::OpenSearchDescriptionDocumentHandler, public favicon::FaviconDriverObserver { public: + static void BindOpenSearchDescriptionDocumentHandler( + mojo::PendingAssociatedReceiver< + chrome::mojom::OpenSearchDescriptionDocumentHandler> receiver, + content::RenderFrameHost* rfh); + ~SearchEngineTabHelper() override; // content::WebContentsObserver overrides. @@ -57,7 +62,7 @@ // If params has a searchable form, this tries to create a new keyword. void GenerateKeywordIfNecessary(content::NavigationHandle* handle); - content::WebContentsFrameReceiverSet< + content::RenderFrameHostReceiverSet< chrome::mojom::OpenSearchDescriptionDocumentHandler> osdd_handler_receivers_;
diff --git a/chrome/browser/ui/sharing_hub/sharing_hub_bubble_controller.cc b/chrome/browser/ui/sharing_hub/sharing_hub_bubble_controller.cc index 0ceb32c..78a2ddb 100644 --- a/chrome/browser/ui/sharing_hub/sharing_hub_bubble_controller.cc +++ b/chrome/browser/ui/sharing_hub/sharing_hub_bubble_controller.cc
@@ -157,7 +157,9 @@ } else { SharingHubModel* model = GetSharingHubModel(); DCHECK(model); - model->ExecuteThirdPartyAction(GetProfile(), command_id); + model->ExecuteThirdPartyAction(GetProfile(), command_id, + web_contents_->GetLastCommittedURL().spec(), + web_contents_->GetTitle()); } }
diff --git a/chrome/browser/ui/sharing_hub/sharing_hub_sub_menu_model.cc b/chrome/browser/ui/sharing_hub/sharing_hub_sub_menu_model.cc index 2ef8849..17f793c 100644 --- a/chrome/browser/ui/sharing_hub/sharing_hub_sub_menu_model.cc +++ b/chrome/browser/ui/sharing_hub/sharing_hub_sub_menu_model.cc
@@ -37,7 +37,9 @@ SharingHubModel* const model = GetSharingHubModel(); if (!model) return; - model->ExecuteThirdPartyAction(browser_->profile(), command_id); + model->ExecuteThirdPartyAction(browser_->profile(), command_id, + web_contents_->GetLastCommittedURL().spec(), + web_contents_->GetTitle()); } else { GlobalError* error = GlobalErrorServiceFactory::GetForProfile(browser_->profile()) @@ -60,7 +62,7 @@ void SharingHubSubMenuModel::Build(content::WebContents* web_contents) { if (!web_contents) return; - + web_contents_ = web_contents; SharingHubModel* const model = GetSharingHubModel(); if (!model) return;
diff --git a/chrome/browser/ui/sharing_hub/sharing_hub_sub_menu_model.h b/chrome/browser/ui/sharing_hub/sharing_hub_sub_menu_model.h index c8b3cff..6c684e8c 100644 --- a/chrome/browser/ui/sharing_hub/sharing_hub_sub_menu_model.h +++ b/chrome/browser/ui/sharing_hub/sharing_hub_sub_menu_model.h
@@ -30,6 +30,7 @@ bool IsThirdPartyAction(int id); Browser* browser_; + content::WebContents* web_contents_; std::vector<int> third_party_action_ids_; DISALLOW_COPY_AND_ASSIGN(SharingHubSubMenuModel);
diff --git a/chrome/browser/ui/ui_features.cc b/chrome/browser/ui/ui_features.cc index c7049254..e482b61 100644 --- a/chrome/browser/ui/ui_features.cc +++ b/chrome/browser/ui/ui_features.cc
@@ -212,6 +212,11 @@ const base::Feature kWebUIBubblePerProfilePersistence{ "WebUIBubblePerProfilePersistence", base::FEATURE_DISABLED_BY_DEFAULT}; +#if !defined(ANDROID) +const base::Feature kWebUIBrandingUpdate{"WebUIBrandingUpdate", + base::FEATURE_DISABLED_BY_DEFAULT}; +#endif + // Enables the WebUI Download Shelf instead of the Views framework Download // Shelf. See https://crbug.com/1180372. const base::Feature kWebUIDownloadShelf{"WebUIDownloadShelf",
diff --git a/chrome/browser/ui/ui_features.h b/chrome/browser/ui/ui_features.h index f8e78a0..6688b58e 100644 --- a/chrome/browser/ui/ui_features.h +++ b/chrome/browser/ui/ui_features.h
@@ -159,6 +159,10 @@ extern const base::Feature kWebUIBubblePerProfilePersistence; +#if !defined(ANDROID) +extern const base::Feature kWebUIBrandingUpdate; +#endif + extern const base::Feature kWebUIDownloadShelf; extern const base::Feature kWebUITabStrip;
diff --git a/chrome/browser/ui/views/download/download_item_view.cc b/chrome/browser/ui/views/download/download_item_view.cc index 46a0c2e5..294a50ab 100644 --- a/chrome/browser/ui/views/download/download_item_view.cc +++ b/chrome/browser/ui/views/download/download_item_view.cc
@@ -349,6 +349,8 @@ void DownloadItemView::AddedToWidget() { current_scale_ = GetDPIScaleForView(this); + // As the icon depends upon DPI, reload the icon when DPI changes. + StartLoadIcons(); } void DownloadItemView::Layout() { @@ -763,6 +765,9 @@ } void DownloadItemView::StartLoadIcons() { + // The correct scale_factor is set only in the AddedToWidget() + if (!GetWidget()) + return; // The small icon is not stored directly, but will be requested in other // functions, so ask the icon manager to load it so it's cached. IconManager* const im = g_browser_process->icon_manager();
diff --git a/chrome/browser/ui/views/location_bar/omnibox_chip_button.cc b/chrome/browser/ui/views/location_bar/omnibox_chip_button.cc index 63747e4..a8c73fda 100644 --- a/chrome/browser/ui/views/location_bar/omnibox_chip_button.cc +++ b/chrome/browser/ui/views/location_bar/omnibox_chip_button.cc
@@ -6,6 +6,7 @@ #include "chrome/browser/themes/theme_properties.h" #include "chrome/browser/ui/layout_constants.h" +#include "components/vector_icons/vector_icons.h" #include "ui/base/metadata/metadata_impl_macros.h" #include "ui/base/theme_provider.h" #include "ui/gfx/paint_vector_icon.h" @@ -38,7 +39,7 @@ animation_ = std::make_unique<gfx::SlideAnimation>(this); animation_->SetSlideDuration(kAnimationDuration); - UpdateColors(); + UpdateIconAndColors(); } OmniboxChipButton::~OmniboxChipButton() = default; @@ -77,7 +78,7 @@ void OmniboxChipButton::OnThemeChanged() { MdTextButton::OnThemeChanged(); - UpdateColors(); + UpdateIconAndColors(); } void OmniboxChipButton::AnimationEnded(const gfx::Animation* animation) { @@ -96,20 +97,22 @@ void OmniboxChipButton::SetTheme(Theme theme) { theme_ = theme; - UpdateColors(); + UpdateIconAndColors(); } int OmniboxChipButton::GetIconSize() const { return GetLayoutConstant(LOCATION_BAR_ICON_SIZE); } -void OmniboxChipButton::UpdateColors() { +void OmniboxChipButton::UpdateIconAndColors() { if (!GetWidget()) return; SetEnabledTextColors(GetForegroundColor()); - SetImageModel(views::Button::STATE_NORMAL, - ui::ImageModel::FromVectorIcon(icon_, GetForegroundColor(), - GetIconSize())); + SetImageModel( + views::Button::STATE_NORMAL, + ui::ImageModel::FromVectorIcon( + icon_, GetForegroundColor(), GetIconSize(), + show_blocked_badge_ ? &vector_icons::kBlockedBadgeIcon : nullptr)); SetBgColorOverride(GetBackgroundColor()); } @@ -145,6 +148,13 @@ force_expanded_for_testing_ = force_expanded_for_testing; } +void OmniboxChipButton::SetShowBlockedBadge(bool show_blocked_badge) { + if (show_blocked_badge_ != show_blocked_badge) { + show_blocked_badge_ = show_blocked_badge; + UpdateIconAndColors(); + } +} + BEGIN_METADATA(OmniboxChipButton, views::MdTextButton) ADD_READONLY_PROPERTY_METADATA(int, IconSize) END_METADATA
diff --git a/chrome/browser/ui/views/location_bar/omnibox_chip_button.h b/chrome/browser/ui/views/location_bar/omnibox_chip_button.h index 84316fe..bd61bda 100644 --- a/chrome/browser/ui/views/location_bar/omnibox_chip_button.h +++ b/chrome/browser/ui/views/location_bar/omnibox_chip_button.h
@@ -49,13 +49,16 @@ void SetTheme(Theme theme); void SetForceExpandedForTesting(bool force_expanded_for_testing); + void SetShowBlockedBadge(bool show_blocked_badge); + Theme get_theme_for_testing() { return theme_; } private: int GetIconSize() const; - // Apply colors to text, icon and background of the button. - void UpdateColors(); + // Updates the icon, and then updates text, icon, and background colors from + // the theme. + void UpdateIconAndColors(); // Returns the primary theme color. SkColor GetMainColor(); @@ -84,6 +87,8 @@ const gfx::VectorIcon& icon_; + bool show_blocked_badge_ = false; + base::RepeatingCallback<void()> expand_animation_ended_callback_; bool force_expanded_for_testing_ = false;
diff --git a/chrome/browser/ui/views/location_bar/permission_chip.cc b/chrome/browser/ui/views/location_bar/permission_chip.cc index 1bc10c0..20f3fe4d 100644 --- a/chrome/browser/ui/views/location_bar/permission_chip.cc +++ b/chrome/browser/ui/views/location_bar/permission_chip.cc
@@ -94,6 +94,19 @@ Show(/*always_open_bubble=*/false); } +void PermissionChip::Collapse(bool allow_restart) { + if (allow_restart && (IsMouseHovered() || IsBubbleShowing())) { + StartCollapseTimer(); + } else { + chip_button_->AnimateCollapse(); + StartDismissTimer(); + } +} + +void PermissionChip::ShowBlockedBadge() { + chip_button_->SetShowBlockedBadge(true); +} + void PermissionChip::OnMouseEntered(const ui::MouseEvent& event) { if (!chip_button_->is_animating()) RestartTimersOnInteraction(); @@ -158,15 +171,6 @@ /*allow_restart=*/true)); } -void PermissionChip::Collapse(bool allow_restart) { - if (allow_restart && (IsMouseHovered() || IsBubbleShowing())) { - StartCollapseTimer(); - } else { - chip_button_->AnimateCollapse(); - StartDismissTimer(); - } -} - void PermissionChip::StartDismissTimer() { if (should_expand_) { if (base::FeatureList::IsEnabled(
diff --git a/chrome/browser/ui/views/location_bar/permission_chip.h b/chrome/browser/ui/views/location_bar/permission_chip.h index e9b11213..5625e025 100644 --- a/chrome/browser/ui/views/location_bar/permission_chip.h +++ b/chrome/browser/ui/views/location_bar/permission_chip.h
@@ -78,13 +78,15 @@ return delegate_; } + virtual void Collapse(bool allow_restart); + void ShowBlockedBadge(); + private: void Show(bool always_open_bubble); void ExpandAnimationEnded(); void ChipButtonPressed(); void RestartTimersOnInteraction(); void StartCollapseTimer(); - void Collapse(bool allow_restart); void StartDismissTimer(); void Dismiss();
diff --git a/chrome/browser/ui/views/location_bar/permission_request_chip.cc b/chrome/browser/ui/views/location_bar/permission_request_chip.cc index 58a25bf7..0c35189 100644 --- a/chrome/browser/ui/views/location_bar/permission_request_chip.cc +++ b/chrome/browser/ui/views/location_bar/permission_request_chip.cc
@@ -116,7 +116,9 @@ : PermissionChip( delegate, {GetPermissionIconId(delegate), GetPermissionMessage(delegate), - ShouldBubbleStartOpen(delegate), /*is_prominent=*/true, + ShouldBubbleStartOpen(delegate), + base::FeatureList::IsEnabled( + permissions::features::kPermissionChipIsProminentStyle), OmniboxChipButton::Theme::kBlue, /*should_expand=*/true}), browser_(browser) { chip_shown_time_ = base::TimeTicks::Now(); @@ -160,6 +162,11 @@ return prompt_bubble_; } +void PermissionRequestChip::Collapse(bool allow_restart) { + PermissionChip::Collapse(allow_restart); + ShowBlockedBadge(); +} + void PermissionRequestChip::RecordChipButtonPressed() { base::UmaHistogramMediumTimes("Permissions.Chip.TimeToInteraction", base::TimeTicks::Now() - chip_shown_time_);
diff --git a/chrome/browser/ui/views/location_bar/permission_request_chip.h b/chrome/browser/ui/views/location_bar/permission_request_chip.h index bcbce6d..6e71ee3 100644 --- a/chrome/browser/ui/views/location_bar/permission_request_chip.h +++ b/chrome/browser/ui/views/location_bar/permission_request_chip.h
@@ -32,6 +32,9 @@ bool IsBubbleShowing() const override; private: + // PermissionChip: + void Collapse(bool allow_restart) override; + void RecordChipButtonPressed(); Browser* browser_ = nullptr;
diff --git a/chrome/browser/ui/views/permission_bubble/permission_prompt_bubble_view_browsertest.cc b/chrome/browser/ui/views/permission_bubble/permission_prompt_bubble_view_browsertest.cc index 8fdf20b1..bb2ffc0b 100644 --- a/chrome/browser/ui/views/permission_bubble/permission_prompt_bubble_view_browsertest.cc +++ b/chrome/browser/ui/views/permission_bubble/permission_prompt_bubble_view_browsertest.cc
@@ -227,7 +227,6 @@ ASSERT_TRUE(chip); EXPECT_FALSE(chip->should_expand_for_testing()); - EXPECT_FALSE(chip->get_chip_button_for_testing()->GetProminent()); EXPECT_FALSE(chip->get_chip_button_for_testing()->is_animating()); EXPECT_EQ(OmniboxChipButton::Theme::kGray, chip->get_chip_button_for_testing()->get_theme_for_testing()); @@ -242,7 +241,6 @@ ASSERT_TRUE(chip); EXPECT_TRUE(chip->should_expand_for_testing()); - EXPECT_FALSE(chip->get_chip_button_for_testing()->GetProminent()); EXPECT_TRUE(chip->get_chip_button_for_testing()->is_animating()); EXPECT_EQ(OmniboxChipButton::Theme::kGray, chip->get_chip_button_for_testing()->get_theme_for_testing()); @@ -256,7 +254,6 @@ ASSERT_TRUE(chip); EXPECT_TRUE(chip->should_expand_for_testing()); - EXPECT_TRUE(chip->get_chip_button_for_testing()->GetProminent()); EXPECT_TRUE(chip->get_chip_button_for_testing()->is_animating()); EXPECT_EQ(OmniboxChipButton::Theme::kBlue, chip->get_chip_button_for_testing()->get_theme_for_testing());
diff --git a/chrome/browser/ui/webui/settings/safety_check_handler.cc b/chrome/browser/ui/webui/settings/safety_check_handler.cc index acc87b37..73bf7307 100644 --- a/chrome/browser/ui/webui/settings/safety_check_handler.cc +++ b/chrome/browser/ui/webui/settings/safety_check_handler.cc
@@ -18,7 +18,6 @@ #include "build/chromeos_buildflags.h" #include "chrome/browser/browser_process.h" #include "chrome/browser/extensions/api/passwords_private/passwords_private_delegate_factory.h" -#include "chrome/browser/extensions/blocklist_extension_prefs.h" #include "chrome/browser/password_manager/bulk_leak_check_service_factory.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/webui/version/version_ui.h" @@ -34,6 +33,7 @@ #include "components/version_info/version_info.h" #include "content/public/browser/browser_context.h" #include "content/public/browser/storage_partition.h" +#include "extensions/browser/blocklist_extension_prefs.h" #include "extensions/browser/extension_prefs_factory.h" #include "extensions/browser/extension_system.h" #include "extensions/common/extension_id.h"
diff --git a/chrome/browser/ui/webui/settings/settings_ui.cc b/chrome/browser/ui/webui/settings/settings_ui.cc index 4330ca0b..0af16f8c 100644 --- a/chrome/browser/ui/webui/settings/settings_ui.cc +++ b/chrome/browser/ui/webui/settings/settings_ui.cc
@@ -266,6 +266,12 @@ html_source->AddBoolean("enableLandingPageRedesign", enable_landing_page_redesign); + html_source->AddString( + "enableBrandingUpdateAttribute", + base::FeatureList::IsEnabled(features::kWebUIBrandingUpdate) + ? "enable-branding-update" + : ""); + html_source->AddBoolean("signinAllowed", !profile->IsGuestSession() && profile->GetPrefs()->GetBoolean( prefs::kSigninAllowed));
diff --git a/chrome/browser/usb/web_usb_service_impl_unittest.cc b/chrome/browser/usb/web_usb_service_impl_unittest.cc index 2365b07..29d2d768 100644 --- a/chrome/browser/usb/web_usb_service_impl_unittest.cc +++ b/chrome/browser/usb/web_usb_service_impl_unittest.cc
@@ -21,6 +21,7 @@ #include "chrome/browser/usb/usb_tab_helper.h" #include "chrome/test/base/chrome_render_view_host_test_harness.h" #include "chrome/test/base/testing_profile.h" +#include "content/public/test/back_forward_cache_util.h" #include "extensions/buildflags/buildflags.h" #include "mojo/public/cpp/bindings/associated_receiver.h" #include "mojo/public/cpp/bindings/pending_remote.h" @@ -378,6 +379,15 @@ } TEST_F(WebUsbServiceImplTest, OpenAndNavigateCrossOrigin) { + // The test assumes the previous page gets deleted after navigation, + // disconnecting the device. Disable back/forward cache to ensure that it + // doesn't get preserved in the cache. + // TODO(https://crbug.com/1220314): WebUSB actually already disables + // back/forward cache in RenderFrameHostImpl::CreateWebUsbService(), but that + // path is not triggered in unit tests, so this test fails. Fix this. + content::DisableBackForwardCacheForTesting( + web_contents(), content::BackForwardCache::TEST_ASSUMES_NO_CACHING); + const auto origin = url::Origin::Create(GURL(kDefaultTestUrl)); auto* context = GetChooserContext();
diff --git a/chrome/common/extensions/manifest_handlers/theme_handler.cc b/chrome/common/extensions/manifest_handlers/theme_handler.cc index 9d323fbf..a41367e 100644 --- a/chrome/common/extensions/manifest_handlers/theme_handler.cc +++ b/chrome/common/extensions/manifest_handlers/theme_handler.cc
@@ -56,34 +56,45 @@ return true; } -bool LoadColors(const base::DictionaryValue* theme_value, +bool LoadColors(const base::Value* theme_value, std::u16string* error, ThemeInfo* theme_info) { - const base::DictionaryValue* colors_value = NULL; - if (theme_value->GetDictionary(keys::kThemeColors, &colors_value)) { + DCHECK(theme_value); + DCHECK(theme_value->is_dict()); + const base::Value* colors_value = + theme_value->FindDictPath(keys::kThemeColors); + if (colors_value) { // Validate that the colors are RGB or RGBA lists. - for (base::DictionaryValue::Iterator iter(*colors_value); !iter.IsAtEnd(); - iter.Advance()) { - const base::ListValue* color_list = NULL; - double alpha = 0.0; - int color = 0; - // The color must be a list... - if (!iter.value().GetAsList(&color_list) || - // ... and either 3 items (RGB) or 4 (RGBA). - ((color_list->GetSize() != 3) && - ((color_list->GetSize() != 4) || - // For RGBA, the fourth item must be a real or int alpha value. - // Note that GetDouble() can get an integer value. - !color_list->GetDouble(3, &alpha))) || - // For both RGB and RGBA, the first three items must be ints (R,G,B). - !color_list->GetInteger(0, &color) || - !color_list->GetInteger(1, &color) || - !color_list->GetInteger(2, &color)) { + for (const auto& it : colors_value->DictItems()) { + if (!it.second.is_list()) { + *error = base::ASCIIToUTF16(errors::kInvalidThemeColors); + return false; + } + base::Value::ConstListView color_list = it.second.GetList(); + + // There must be either 3 items (RGB), or 4 (RGBA). + if (!(color_list.size() == 3 || color_list.size() == 4)) { + *error = base::ASCIIToUTF16(errors::kInvalidThemeColors); + return false; + } + + // The first three items (RGB), must be ints: + if (!(color_list[0].is_int() && color_list[1].is_int() && + color_list[2].is_int())) { + *error = base::ASCIIToUTF16(errors::kInvalidThemeColors); + return false; + } + + // If there is a 4th item (alpha), it may be either int or double: + if (color_list.size() == 4 && + !(color_list[3].is_int() || color_list[3].is_double())) { *error = base::ASCIIToUTF16(errors::kInvalidThemeColors); return false; } } - theme_info->theme_colors_.reset(colors_value->DeepCopy()); + + theme_info->theme_colors_ = + base::Value::ToUniquePtrValue(colors_value->Clone()); } return true; } @@ -144,7 +155,7 @@ } // static -const base::DictionaryValue* ThemeInfo::GetColors(const Extension* extension) { +const base::Value* ThemeInfo::GetColors(const Extension* extension) { const ThemeInfo* theme_info = GetInfo(extension); return theme_info ? theme_info->theme_colors_.get() : NULL; }
diff --git a/chrome/common/extensions/manifest_handlers/theme_handler.h b/chrome/common/extensions/manifest_handlers/theme_handler.h index 3d471ce..36a9486 100644 --- a/chrome/common/extensions/manifest_handlers/theme_handler.h +++ b/chrome/common/extensions/manifest_handlers/theme_handler.h
@@ -24,7 +24,7 @@ ~ThemeInfo() override; static const base::DictionaryValue* GetImages(const Extension* extension); - static const base::DictionaryValue* GetColors(const Extension* extension); + static const base::Value* GetColors(const Extension* extension); static const base::DictionaryValue* GetTints(const Extension* extension); static const base::DictionaryValue* GetDisplayProperties( const Extension* extension); @@ -33,7 +33,7 @@ std::unique_ptr<base::DictionaryValue> theme_images_; // A map of color names to colors. - std::unique_ptr<base::DictionaryValue> theme_colors_; + std::unique_ptr<base::Value> theme_colors_; // A map of color names to colors. std::unique_ptr<base::DictionaryValue> theme_tints_;
diff --git a/chrome/services/keymaster/public/mojom/cert_store.mojom b/chrome/services/keymaster/public/mojom/cert_store.mojom index 6339c7b7..15c2f4d 100644 --- a/chrome/services/keymaster/public/mojom/cert_store.mojom +++ b/chrome/services/keymaster/public/mojom/cert_store.mojom
@@ -33,10 +33,25 @@ kUnsupportedAlgorithm, }; -// Metadata to uniquely identify a Chaps key. +// The possible chaps slots relevant for arc-keymaster. Note this does NOT map +// to the PKCS#11 CK_SLOT_ID, but rather to an abstract representation of the +// value. The corresponding CK_SLOT_ID must be queried from cryptohome. +[Extensible] +enum ChapsSlot { + // The key is stored in the user slot. + [Default] kUser, + // The key is stored in the system slot. + kSystem, +}; + +// Metadata to uniquely identify a chaps key. struct ChapsKeyData { + // Maps to the CKA_LABEL of the CKO_PRIVATE_KEY in PKCS#11. string label; + // Maps to the CKA_ID of the CKO_PRIVATE_KEY in PKCS#11. string id; + // The slot where this key is stored. Does NOT map to the PKCS#11 CK_SLOT_ID. + [MinVersion=1] ChapsSlot slot; }; // Union of Chrome OS keys from different sources.
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn index 199ffa31..979bf8e7 100644 --- a/chrome/test/BUILD.gn +++ b/chrome/test/BUILD.gn
@@ -4672,6 +4672,7 @@ "../browser/metrics/thread_watcher_android_unittest.cc", "../browser/notifications/notification_channels_provider_android_unittest.cc", "../browser/optimization_guide/android/optimization_guide_tab_url_provider_android_unittest.cc", + "../browser/password_manager/android/biometric_authenticator_android_unittest.cc", "../browser/password_manager/android/password_ui_view_android_unittest.cc", "../browser/search/contextual_search_policy_handler_android_unittest.cc", "../browser/share/share_history_unittest.cc",
diff --git a/chrome/test/data/webui/chromeos/diagnostics/BUILD.gn b/chrome/test/data/webui/chromeos/diagnostics/BUILD.gn index c19eb0c..8864fac 100644 --- a/chrome/test/data/webui/chromeos/diagnostics/BUILD.gn +++ b/chrome/test/data/webui/chromeos/diagnostics/BUILD.gn
@@ -24,6 +24,7 @@ ":fake_system_data_provider_test", ":fake_system_routine_controller_test", ":input_list_test", + ":ip_config_info_drawer_test", ":memory_card_test", ":mojo_interface_provider_test", ":network_card_test", @@ -182,6 +183,16 @@ externs_list = [ "$externs_path/mocha-2.5.js" ] } +js_library("ip_config_info_drawer_test") { + deps = [ + "../..:chai_assert", + "../..:test_util.m", + "//ash/webui/diagnostics_ui/resources:diagnostics_types", + "//ash/webui/diagnostics_ui/resources:ip_config_info_drawer", + ] + externs_list = [ "$externs_path/mocha-2.5.js" ] +} + js_library("memory_card_test") { deps = [ "../..:chai_assert",
diff --git a/chrome/test/data/webui/chromeos/diagnostics/diagnostics_app_unified_test.js b/chrome/test/data/webui/chromeos/diagnostics/diagnostics_app_unified_test.js index 4890d67..695e648 100644 --- a/chrome/test/data/webui/chromeos/diagnostics/diagnostics_app_unified_test.js +++ b/chrome/test/data/webui/chromeos/diagnostics/diagnostics_app_unified_test.js
@@ -17,6 +17,7 @@ import {fakeSystemDataProviderTestSuite} from './fake_system_data_provider_test.js'; import {fakeSystemRoutineContollerTestSuite} from './fake_system_routine_controller_test.js'; import {inputListTestSuite} from './input_list_test.js'; +import {ipConfigInfoDrawerTestSuite} from './ip_config_info_drawer_test.js'; import {memoryCardTestSuite} from './memory_card_test.js'; import {fakeMojoProviderTestSuite} from './mojo_interface_provider_test.js'; import {networkCardTestSuite} from './network_card_test.js'; @@ -60,6 +61,7 @@ runSuite('FakeSystemDataProvider', fakeSystemDataProviderTestSuite); runSuite('FakeSystemRoutineContoller', fakeSystemRoutineContollerTestSuite); runSuite('InputList', inputListTestSuite, 'input'); +runSuite('IpConfigInfoDrawer', ipConfigInfoDrawerTestSuite, 'network'); runSuite('MemoryCard', memoryCardTestSuite); runSuite('NetworkCard', networkCardTestSuite, 'network'); runSuite('NetworkInfo', networkInfoTestSuite, 'network');
diff --git a/chrome/test/data/webui/chromeos/diagnostics/diagnostics_browsertest.js b/chrome/test/data/webui/chromeos/diagnostics/diagnostics_browsertest.js index 76eed71..c76d047 100644 --- a/chrome/test/data/webui/chromeos/diagnostics/diagnostics_browsertest.js +++ b/chrome/test/data/webui/chromeos/diagnostics/diagnostics_browsertest.js
@@ -92,6 +92,7 @@ 'FakeSystemDataProvider', 'FakeSystemRoutineContoller', 'InputList', + 'IpConfigInfoDrawer', 'MemoryCard', 'NetworkCard', 'NetworkInfo',
diff --git a/chrome/test/data/webui/chromeos/diagnostics/ip_config_info_drawer_test.js b/chrome/test/data/webui/chromeos/diagnostics/ip_config_info_drawer_test.js new file mode 100644 index 0000000..6e01155a --- /dev/null +++ b/chrome/test/data/webui/chromeos/diagnostics/ip_config_info_drawer_test.js
@@ -0,0 +1,36 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +import 'chrome://diagnostics/ip_config_info_drawer.js'; + +import {assertTrue} from '../../chai_assert.js'; +import {flushTasks, isVisible} from '../../test_util.m.js'; + +export function ipConfigInfoDrawerTestSuite() { + /** @type {?IpConfigInfoDrawerElement} */ + let ipConfigInfoDrawerElement = null; + + setup(() => { + document.body.innerHTML = ''; + }); + + teardown(() => { + ipConfigInfoDrawerElement.remove(); + ipConfigInfoDrawerElement = null; + }); + + function initializeIpConfigInfoDrawerElement() { + ipConfigInfoDrawerElement = /** @type {!IpConfigInfoDrawerElement} */ ( + document.createElement('ip-config-info-drawer')); + document.body.appendChild(ipConfigInfoDrawerElement); + assertTrue(!!ipConfigInfoDrawerElement); + return flushTasks(); + } + + test('IpConfigInfoDrawerInitialized', () => { + return initializeIpConfigInfoDrawerElement().then(() => { + assertTrue(!!ipConfigInfoDrawerElement.$$('#ipConfigInfoElement')); + }); + }); +}
diff --git a/chrome/test/data/webui/chromeos/diagnostics/system_page_test.js b/chrome/test/data/webui/chromeos/diagnostics/system_page_test.js index 87a18a6..a75d9e9a 100644 --- a/chrome/test/data/webui/chromeos/diagnostics/system_page_test.js +++ b/chrome/test/data/webui/chromeos/diagnostics/system_page_test.js
@@ -128,7 +128,7 @@ document.createElement('system-page')); assertTrue(!!page); document.body.appendChild(page); - + page.showSessionLogButton = true; return flushTasks(); }
diff --git a/chrome/test/data/webui/tab_search/tab_search_app_test.js b/chrome/test/data/webui/tab_search/tab_search_app_test.js index 6564f3bc..279d274 100644 --- a/chrome/test/data/webui/tab_search/tab_search_app_test.js +++ b/chrome/test/data/webui/tab_search/tab_search_app_test.js
@@ -260,8 +260,11 @@ (tabSearchApp.shadowRoot.querySelector('#tabsList') .querySelector('tab-search-item[id="100"]')); tabSearchItem.click(); - const tabId = await testProxy.whenCalled('openRecentlyClosedEntry'); + const [tabId, withSearch, isTab] = + await testProxy.whenCalled('openRecentlyClosedEntry'); assertEquals(tabData.tabId, tabId); + assertFalse(withSearch); + assertTrue(isTab); }); test('Click on recently closed tab group item triggers action', async () => { @@ -295,8 +298,11 @@ (tabSearchApp.shadowRoot.querySelector('#tabsList') .querySelector('tab-search-group-item')); tabSearchItem.click(); - const id = await testProxy.whenCalled('openRecentlyClosedEntry'); + const [id, withSearch, isTab] = + await testProxy.whenCalled('openRecentlyClosedEntry'); assertEquals(tabGroupData.sessionId, id); + assertFalse(withSearch); + assertFalse(isTab); }); test('Keyboard navigation on an empty list', async () => {
diff --git a/chrome/test/data/webui/tab_search/test_tab_search_api_proxy.js b/chrome/test/data/webui/tab_search/test_tab_search_api_proxy.js index de7b946..e873010 100644 --- a/chrome/test/data/webui/tab_search/test_tab_search_api_proxy.js +++ b/chrome/test/data/webui/tab_search/test_tab_search_api_proxy.js
@@ -40,8 +40,8 @@ } /** @override */ - openRecentlyClosedEntry(id) { - this.methodCalled('openRecentlyClosedEntry', id); + openRecentlyClosedEntry(id, withSearch, isTab) { + this.methodCalled('openRecentlyClosedEntry', [id, withSearch, isTab]); } /** @override */
diff --git a/chrome/updater/mac/setup/setup.mm b/chrome/updater/mac/setup/setup.mm index 693f63e8..cda20bd 100644 --- a/chrome/updater/mac/setup/setup.mm +++ b/chrome/updater/mac/setup/setup.mm
@@ -14,6 +14,7 @@ #include "base/logging.h" #include "base/mac/bundle_locations.h" #include "base/mac/foundation_util.h" +#include "base/mac/mac_util.h" #include "base/mac/scoped_nsobject.h" #include "base/path_service.h" #include "base/process/launch.h" @@ -323,9 +324,30 @@ return DeleteFolder(GetBaseDirectory(scope)); } -} // namespace +void CleanAfterInstallFailure(UpdaterScope scope) { + // If install fails at any point, attempt to clean the install. + DeleteCandidateInstallFolder(scope); + RemoveUpdateWakeJobFromLaunchd(scope); + RemoveUpdateServiceInternalJobFromLaunchd(scope); +} -int Setup(UpdaterScope scope) { +bool RemoveQuarantineAttributes(const base::FilePath& updater_bundle_path, + const base::FilePath& updater_executable_path) { + if (!base::mac::RemoveQuarantineAttribute(updater_bundle_path)) { + VPLOG(1) << "Could not remove com.apple.quarantine for the bundle."; + return false; + } + + if (!base::mac::RemoveQuarantineAttribute(updater_executable_path)) { + VPLOG(1) << "Could not remove com.apple.quarantine for the " + "executable."; + return false; + } + + return true; +} + +int DoSetup(UpdaterScope scope) { const absl::optional<base::FilePath> dest_path = GetVersionedUpdaterFolderPath(scope); @@ -338,6 +360,14 @@ dest_path->Append(GetUpdaterAppName()) .Append(GetUpdaterAppExecutablePath()); + // Quarantine attribute needs to be removed here as the copied bundle might be + // given com.apple.quarantine attribute, and the server is attempted to be + // launched below, Gatekeeper could prompt the user. + if (!RemoveQuarantineAttributes(*dest_path, updater_executable_path)) { + VLOG(1) << "Couldn't remove quarantine bits for updater. This will likely " + "cause Gatekeeper to show a prompt to the user."; + } + if (!CreateWakeLaunchdJobPlist(scope, updater_executable_path)) return setup_exit_codes::kFailedToCreateWakeLaunchdJobPlist; @@ -355,6 +385,15 @@ return setup_exit_codes::kSuccess; } +} // namespace + +int Setup(UpdaterScope scope) { + int error = DoSetup(scope); + if (error) + CleanAfterInstallFailure(scope); + return error; +} + int PromoteCandidate(UpdaterScope scope) { const absl::optional<base::FilePath> dest_path = GetVersionedUpdaterFolderPath(scope);
diff --git a/chromecast/media/cma/base/decoder_config_adapter.cc b/chromecast/media/cma/base/decoder_config_adapter.cc index dac3c3f..3130c68 100644 --- a/chromecast/media/cma/base/decoder_config_adapter.cc +++ b/chromecast/media/cma/base/decoder_config_adapter.cc
@@ -340,8 +340,8 @@ video_config.hdr_metadata.max_frame_average_light_level = hdr_metadata->max_frame_average_light_level; - const auto& mm1 = hdr_metadata->mastering_metadata; - auto& mm2 = video_config.hdr_metadata.mastering_metadata; + const auto& mm1 = hdr_metadata->color_volume_metadata; + auto& mm2 = video_config.hdr_metadata.color_volume_metadata; mm2.primary_r_chromaticity_x = mm1.primary_r.x(); mm2.primary_r_chromaticity_y = mm1.primary_r.y(); mm2.primary_g_chromaticity_x = mm1.primary_g.x();
diff --git a/chromecast/public/media/decoder_config.h b/chromecast/public/media/decoder_config.h index 85cb791..2f03e75a 100644 --- a/chromecast/public/media/decoder_config.h +++ b/chromecast/public/media/decoder_config.h
@@ -228,8 +228,8 @@ // ---- Begin copy/paste from //ui/gfx/color_space.h ---- // ---- Begin copy/paste from //ui/gfx/hdr_metadata.h ---- -// SMPTE ST 2086 mastering metadata. -struct MasteringMetadata { +// SMPTE ST 2086 color volume metadata. +struct ColorVolumeMetadata { float primary_r_chromaticity_x = 0; float primary_r_chromaticity_y = 0; float primary_g_chromaticity_x = 0; @@ -241,14 +241,14 @@ float luminance_max = 0; float luminance_min = 0; - MasteringMetadata(); - MasteringMetadata(const MasteringMetadata& rhs); - MasteringMetadata& operator=(const MasteringMetadata& rhs); + ColorVolumeMetadata(); + ColorVolumeMetadata(const ColorVolumeMetadata& rhs); + ColorVolumeMetadata& operator=(const ColorVolumeMetadata& rhs); }; // HDR metadata common for HDR10 and WebM/VP9-based HDR formats. struct HDRMetadata { - MasteringMetadata mastering_metadata; + ColorVolumeMetadata color_volume_metadata; unsigned max_content_light_level = 0; unsigned max_frame_average_light_level = 0; @@ -257,10 +257,11 @@ HDRMetadata& operator=(const HDRMetadata& rhs); }; -inline MasteringMetadata::MasteringMetadata() {} -inline MasteringMetadata::MasteringMetadata(const MasteringMetadata&) = default; -inline MasteringMetadata& MasteringMetadata::operator=( - const MasteringMetadata&) = default; +inline ColorVolumeMetadata::ColorVolumeMetadata() {} +inline ColorVolumeMetadata::ColorVolumeMetadata(const ColorVolumeMetadata&) = + default; +inline ColorVolumeMetadata& ColorVolumeMetadata::operator=( + const ColorVolumeMetadata&) = default; inline HDRMetadata::HDRMetadata() {} inline HDRMetadata::HDRMetadata(const HDRMetadata&) = default;
diff --git a/chromeos/components/phonehub/OWNERS b/chromeos/components/phonehub/OWNERS index 01f3df46..b4f631c 100644 --- a/chromeos/components/phonehub/OWNERS +++ b/chromeos/components/phonehub/OWNERS
@@ -1,3 +1,3 @@ +hansberry@chromium.org khorimoto@chromium.org nohle@chromium.org -vecore@google.com
diff --git a/components/autofill/content/renderer/form_cache.cc b/components/autofill/content/renderer/form_cache.cc index 946ee19..d201f15 100644 --- a/components/autofill/content/renderer/form_cache.cc +++ b/components/autofill/content/renderer/form_cache.cc
@@ -14,6 +14,7 @@ #include "base/containers/cxx20_erase.h" #include "base/feature_list.h" #include "base/macros.h" +#include "base/metrics/histogram_macros.h" #include "base/strings/strcat.h" #include "base/strings/string_number_conversions.h" #include "base/strings/string_piece.h" @@ -236,6 +237,10 @@ } void FormCache::Reset() { + // Record the size of |parsed_forms_| every time it reaches its peak size. The + // peak size is reached right before the cache is cleared. + UMA_HISTOGRAM_COUNTS_1000("Autofill.FormCacheSize", parsed_forms_.size()); + synthetic_form_ = FormData(); parsed_forms_.clear(); initial_select_values_.clear();
diff --git a/components/autofill_assistant/browser/web/web_controller.cc b/components/autofill_assistant/browser/web/web_controller.cc index f4c68cb..1793d36 100644 --- a/components/autofill_assistant/browser/web/web_controller.cc +++ b/components/autofill_assistant/browser/web/web_controller.cc
@@ -131,7 +131,8 @@ let numResults = 0; let newIndex = -1; for (let i = 0; i < this.options.length; ++i) { - if (regexp.test(this.options[i][valueSourceAttribute])) { + if (!this.options[i].disabled && + regexp.test(this.options[i][valueSourceAttribute])) { ++numResults; if (newIndex === -1) { newIndex = i;
diff --git a/components/autofill_assistant/browser/web/web_controller_browsertest.cc b/components/autofill_assistant/browser/web/web_controller_browsertest.cc index 81b5cd4..92a7c8a 100644 --- a/components/autofill_assistant/browser/web/web_controller_browsertest.cc +++ b/components/autofill_assistant/browser/web/web_controller_browsertest.cc
@@ -1757,6 +1757,17 @@ SelectOptionProto::VALUE, /* strict= */ true) .proto_status()); EXPECT_EQ("One", content::EvalJs(shell(), javascript)); + + // Ignore disabled options. + EXPECT_EQ(OPTION_VALUE_NOT_FOUND, + SelectOption(selector, "five", /* case_sensitive= */ true, + SelectOptionProto::VALUE, /* strict= */ true) + .proto_status()); + EXPECT_EQ(ACTION_APPLIED, + SelectOption(selector, "^\\w{4}$", /* case_sensitive= */ false, + SelectOptionProto::VALUE, /* strict= */ true) + .proto_status()); + EXPECT_EQ("Four", content::EvalJs(shell(), javascript)); } IN_PROC_BROWSER_TEST_F(WebControllerBrowserTest, SelectOptionInIFrame) {
diff --git a/components/cdm/browser/cdm_message_filter_android.cc b/components/cdm/browser/cdm_message_filter_android.cc index 63eb9bd6..84ca02d 100644 --- a/components/cdm/browser/cdm_message_filter_android.cc +++ b/components/cdm/browser/cdm_message_filter_android.cc
@@ -21,6 +21,7 @@ #include "media/base/android/media_codec_util.h" #include "media/base/android/media_drm_bridge.h" #include "media/base/audio_codecs.h" +#include "media/base/eme_constants.h" #include "media/base/media_switches.h" #include "media/base/video_codecs.h" #include "media/media_buildflags.h" @@ -60,7 +61,6 @@ #endif // BUILDFLAG(USE_PROPRIETARY_CODECS) }; -// FLAC is not supported. See https://crbug.com/747050 for details. // Vorbis is not supported. See http://crbug.com/710924 for details. const CodecInfo<media::AudioCodec> kWebMAudioCodecsToQuery[] = { @@ -68,6 +68,7 @@ }; const CodecInfo<media::AudioCodec> kMP4AudioCodecsToQuery[] = { + {media::EME_CODEC_FLAC, media::kCodecFLAC}, #if BUILDFLAG(USE_PROPRIETARY_CODECS) {media::EME_CODEC_AAC, media::kCodecAAC}, #if BUILDFLAG(ENABLE_PLATFORM_AC3_EAC3_AUDIO)
diff --git a/components/component_updater/android/BUILD.gn b/components/component_updater/android/BUILD.gn index 21e34fc..d7dfca0 100644 --- a/components/component_updater/android/BUILD.gn +++ b/components/component_updater/android/BUILD.gn
@@ -56,6 +56,7 @@ ":component_provider_service_aidl_java", ":embedded_component_loader_jni_headers", "//base:base_java", + "//third_party/androidx:androidx_annotation_annotation_java", ] annotation_processor_deps = [ "//base/android/jni_generator:jni_processor" ] }
diff --git a/components/component_updater/android/component_loader_policy.cc b/components/component_updater/android/component_loader_policy.cc index ba95ef2..5e5c54b 100644 --- a/components/component_updater/android/component_loader_policy.cc +++ b/components/component_updater/android/component_loader_policy.cc
@@ -115,7 +115,7 @@ } if (manifest_fd == -1) { - loader_policy_->ComponentLoadFailed(); + loader_policy_->ComponentLoadFailed(ComponentLoadError::kMissingManifest); return; } @@ -127,9 +127,15 @@ base::Owned(this), base::OwnedRef(std::move(fd_map)))); } -void AndroidComponentLoaderPolicy::ComponentLoadFailed(JNIEnv* env) { +void AndroidComponentLoaderPolicy::ComponentLoadFailed(JNIEnv* env, + jint error_code) { DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_); - loader_policy_->ComponentLoadFailed(); + DCHECK(error_code >= + static_cast<int>( + ComponentLoadError::kFailedToConnectToComponentsProviderService)); + DCHECK(error_code <= static_cast<int>(ComponentLoadError::kMaxValue)); + loader_policy_->ComponentLoadFailed( + static_cast<ComponentLoadError>(error_code)); delete this; } @@ -147,16 +153,17 @@ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_); if (!manifest) { - loader_policy_->ComponentLoadFailed(); + loader_policy_->ComponentLoadFailed(ComponentLoadError::kMalformedManifest); return; } std::string version_ascii; manifest->GetStringASCII("version", &version_ascii); base::Version version(version_ascii); if (!version.IsValid()) { - loader_policy_->ComponentLoadFailed(); + loader_policy_->ComponentLoadFailed(ComponentLoadError::kInvalidVersion); return; } + loader_policy_->ComponentLoaded(version, fd_map, std::move(manifest)); }
diff --git a/components/component_updater/android/component_loader_policy.h b/components/component_updater/android/component_loader_policy.h index 9a15f2c..66ca1f3e 100644 --- a/components/component_updater/android/component_loader_policy.h +++ b/components/component_updater/android/component_loader_policy.h
@@ -26,6 +26,20 @@ namespace component_updater { +// Errors that causes failure when loading a component. These values may be +// persisted to logs. Entries should not be renumbered and numeric values +// should never be reused. Should be kept synced with its Java counterpart in +// ComponentLoaderPolicyBridge. +enum class ComponentLoadError { + kFailedToConnectToComponentsProviderService = 0, + kRemoteException = 1, + kComponentsProviderServiceError = 2, + kMissingManifest = 3, + kMalformedManifest = 4, + kInvalidVersion = 5, + kMaxValue = kInvalidVersion, +}; + // Components should use `AndroidComponentLoaderPolicy` by defining a class that // implements the members of `ComponentLoaderPolicy`, and then registering a // `AndroidComponentLoaderPolicy` that has been constructed with an instance of @@ -67,9 +81,7 @@ // // Will be called at most once. This is mutually exclusive with // ComponentLoaded; if this is called then ComponentLoaded won't be called. - // - // TODO(crbug.com/1180966) accept error code for different types of errors. - virtual void ComponentLoadFailed() = 0; + virtual void ComponentLoadFailed(ComponentLoadError error) = 0; // Returns the component's SHA2 hash as raw bytes, the hash value is used as // the unique id of the component and will be used to request components files @@ -106,7 +118,7 @@ void ComponentLoaded(JNIEnv* env, const base::android::JavaRef<jobjectArray>& jfile_names, const base::android::JavaRef<jintArray>& jfds); - void ComponentLoadFailed(JNIEnv* env); + void ComponentLoadFailed(JNIEnv* env, jint error_code); base::android::ScopedJavaLocalRef<jstring> GetComponentId(JNIEnv* env); private:
diff --git a/components/component_updater/android/component_loader_policy_unittests.cc b/components/component_updater/android/component_loader_policy_unittests.cc index 500f2df..840db3d 100644 --- a/components/component_updater/android/component_loader_policy_unittests.cc +++ b/components/component_updater/android/component_loader_policy_unittests.cc
@@ -27,6 +27,7 @@ #include "base/files/scoped_file.h" #include "base/files/scoped_temp_dir.h" #include "base/run_loop.h" +#include "base/test/bind.h" #include "base/test/task_environment.h" #include "base/values.h" #include "base/version.h" @@ -61,11 +62,12 @@ base::OnceCallback<void(const base::Version&, base::flat_map<std::string, base::ScopedFD>&, std::unique_ptr<base::DictionaryValue>)>; +using OnFailedTestCallBack = base::OnceCallback<void(ComponentLoadError)>; class MockLoaderPolicy : public ComponentLoaderPolicy { public: explicit MockLoaderPolicy(OnLoadedTestCallBack on_loaded, - base::OnceClosure on_failed) + OnFailedTestCallBack on_failed) : on_loaded_(std::move(on_loaded)), on_failed_(std::move(on_failed)) {} MockLoaderPolicy() @@ -73,7 +75,7 @@ base::DoNothing::Once<const base::Version&, base::flat_map<std::string, base::ScopedFD>&, std::unique_ptr<base::DictionaryValue>>()), - on_failed_(base::DoNothing::Once()) {} + on_failed_(base::DoNothing::Once<ComponentLoadError>()) {} ~MockLoaderPolicy() override = default; @@ -87,13 +89,15 @@ std::move(on_loaded_).Run(version, fd_map, std::move(manifest)); } - void ComponentLoadFailed() override { std::move(on_failed_).Run(); } + void ComponentLoadFailed(ComponentLoadError error) override { + std::move(on_failed_).Run(error); + } void GetHash(std::vector<uint8_t>* hash) const override { GetPkHash(hash); } private: OnLoadedTestCallBack on_loaded_; - base::OnceClosure on_failed_; + OnFailedTestCallBack on_failed_; }; void VerifyComponentLoaded(base::OnceClosure on_done, @@ -155,7 +159,7 @@ auto* android_policy = new AndroidComponentLoaderPolicy(std::make_unique<MockLoaderPolicy>( base::BindOnce(&VerifyComponentLoaded, run_loop.QuitClosure()), - base::BindOnce([]() { FAIL(); }))); + base::BindOnce([](ComponentLoadError) { FAIL(); }))); android_policy->ComponentLoaded( env_, base::android::ToJavaArrayOfStrings(env_, files_), @@ -175,7 +179,10 @@ [](const base::Version& version, base::flat_map<std::string, base::ScopedFD>& fd_map, std::unique_ptr<base::DictionaryValue> manifest) { FAIL(); }), - run_loop.QuitClosure())); + base::BindLambdaForTesting([&](ComponentLoadError error) { + ASSERT_EQ(error, ComponentLoadError::kMissingManifest); + run_loop.Quit(); + }))); android_policy->ComponentLoaded( env_, base::android::ToJavaArrayOfStrings(env_, files_), @@ -197,7 +204,10 @@ [](const base::Version& version, base::flat_map<std::string, base::ScopedFD>& fd_map, std::unique_ptr<base::DictionaryValue> manifest) { FAIL(); }), - run_loop.QuitClosure())); + base::BindLambdaForTesting([&](ComponentLoadError error) { + ASSERT_EQ(error, ComponentLoadError::kInvalidVersion); + run_loop.Quit(); + }))); android_policy->ComponentLoaded( env_, base::android::ToJavaArrayOfStrings(env_, files_), @@ -218,7 +228,10 @@ [](const base::Version& version, base::flat_map<std::string, base::ScopedFD>& fd_map, std::unique_ptr<base::DictionaryValue> manifest) { FAIL(); }), - run_loop.QuitClosure())); + base::BindLambdaForTesting([&](ComponentLoadError error) { + ASSERT_EQ(error, ComponentLoadError::kMalformedManifest); + run_loop.Quit(); + }))); android_policy->ComponentLoaded( env_, base::android::ToJavaArrayOfStrings(env_, files_),
diff --git a/components/component_updater/android/java/src/org/chromium/components/component_updater/ComponentLoaderPolicyBridge.java b/components/component_updater/android/java/src/org/chromium/components/component_updater/ComponentLoaderPolicyBridge.java index 68c22f6..2ba81e0 100644 --- a/components/component_updater/android/java/src/org/chromium/components/component_updater/ComponentLoaderPolicyBridge.java +++ b/components/component_updater/android/java/src/org/chromium/components/component_updater/ComponentLoaderPolicyBridge.java
@@ -6,6 +6,8 @@ import android.os.ParcelFileDescriptor; +import androidx.annotation.IntDef; + import org.chromium.base.LifetimeAssert; import org.chromium.base.ThreadUtils; import org.chromium.base.annotations.CalledByNative; @@ -25,6 +27,26 @@ private long mNativeAndroidComponentLoaderPolicy = NATIVE_NULL; + // These values maybe persisted to logs. Entries should not be renumbered and + // numeric values should never be reused. They have to be kept in synce with the native enum + // class component_updater::ComponentLoadError. + @IntDef({ + ComponentLoadError.FAILED_TO_CONNECT_TO_COMPONENTS_PROVIDER_SERVICE, + ComponentLoadError.REMOTE_EXCEPTION, + ComponentLoadError.COMPONENTS_PROVIDER_SERVICE_ERROR, + ComponentLoadError.MISSING_MANIFEST, + ComponentLoadError.MALFORMED_MANIFEST, + ComponentLoadError.INVALID_VERSION, + }) + /* package */ static @interface ComponentLoadError { + int FAILED_TO_CONNECT_TO_COMPONENTS_PROVIDER_SERVICE = 0; + int REMOTE_EXCEPTION = 1; + int COMPONENTS_PROVIDER_SERVICE_ERROR = 2; + int MISSING_MANIFEST = 3; + int MALFORMED_MANIFEST = 4; + int INVALID_VERSION = 5; + } + @CalledByNative private ComponentLoaderPolicyBridge(long nativeAndroidComponentLoaderPolicy) { mNativeAndroidComponentLoaderPolicy = nativeAndroidComponentLoaderPolicy; @@ -69,13 +91,15 @@ * file is missing or invalid. Can be called on a background thread. * * Exactly one of componentLoaded or componentLoadFailed should be called exactly once. + * + * @param errorCode the code of the error that caused the failure. */ - public void componentLoadFailed() { + public void componentLoadFailed(@ComponentLoadError int errorCode) { ThreadUtils.assertOnUiThread(); assert mNativeAndroidComponentLoaderPolicy != NATIVE_NULL; ComponentLoaderPolicyBridgeJni.get().componentLoadFailed( - mNativeAndroidComponentLoaderPolicy); + mNativeAndroidComponentLoaderPolicy, errorCode); // Setting it to null, because it is deleted after componentLoadFailed is called. mNativeAndroidComponentLoaderPolicy = NATIVE_NULL; @@ -111,7 +135,7 @@ interface Natives { void componentLoaded( long nativeAndroidComponentLoaderPolicy, String[] fileNames, int[] fds); - void componentLoadFailed(long nativeAndroidComponentLoaderPolicy); + void componentLoadFailed(long nativeAndroidComponentLoaderPolicy, int errorCode); String getComponentId(long nativeAndroidComponentLoaderPolicy); } }
diff --git a/components/component_updater/android/java/src/org/chromium/components/component_updater/EmbeddedComponentLoader.java b/components/component_updater/android/java/src/org/chromium/components/component_updater/EmbeddedComponentLoader.java index dbeff3f7..92f7f48 100644 --- a/components/component_updater/android/java/src/org/chromium/components/component_updater/EmbeddedComponentLoader.java +++ b/components/component_updater/android/java/src/org/chromium/components/component_updater/EmbeddedComponentLoader.java
@@ -17,6 +17,7 @@ import org.chromium.base.ContextUtils; import org.chromium.base.Log; import org.chromium.base.ThreadUtils; +import org.chromium.components.component_updater.ComponentLoaderPolicyBridge.ComponentLoadError; import java.util.Collection; import java.util.HashSet; @@ -71,13 +72,15 @@ } if (resultCode != 0) { - mComponent.componentLoadFailed(); + mComponent.componentLoadFailed( + ComponentLoadError.COMPONENTS_PROVIDER_SERVICE_ERROR); return; } Map<String, ParcelFileDescriptor> resultMap = (Map<String, ParcelFileDescriptor>) resultData.getSerializable(KEY_RESULT); if (resultMap == null) { - mComponent.componentLoadFailed(); + mComponent.componentLoadFailed( + ComponentLoadError.COMPONENTS_PROVIDER_SERVICE_ERROR); return; } mComponent.componentLoaded(resultMap); @@ -106,7 +109,8 @@ // This means if some receivers get their result after this step, their results // will be ignored. for (ComponentResultReceiver receiver : mComponentsResultReceivers) { - receiver.getComponentLoaderPolicy().componentLoadFailed(); + receiver.getComponentLoaderPolicy().componentLoadFailed( + ComponentLoadError.REMOTE_EXCEPTION); } mComponentsResultReceivers.clear(); ContextUtils.getApplicationContext().unbindService(this); @@ -135,7 +139,8 @@ if (!appContext.bindService(intent, this, Context.BIND_AUTO_CREATE)) { Log.d(TAG, "Could not bind to " + intent); for (ComponentResultReceiver receiver : mComponentsResultReceivers) { - receiver.getComponentLoaderPolicy().componentLoadFailed(); + receiver.getComponentLoaderPolicy().componentLoadFailed( + ComponentLoadError.FAILED_TO_CONNECT_TO_COMPONENTS_PROVIDER_SERVICE); } mComponentsResultReceivers.clear(); }
diff --git a/components/component_updater/android/loader_policies/trust_token_key_commitments_component_loader_policy.cc b/components/component_updater/android/loader_policies/trust_token_key_commitments_component_loader_policy.cc index a7f5834..78dc42f 100644 --- a/components/component_updater/android/loader_policies/trust_token_key_commitments_component_loader_policy.cc +++ b/components/component_updater/android/loader_policies/trust_token_key_commitments_component_loader_policy.cc
@@ -20,6 +20,7 @@ #include "base/logging.h" #include "base/values.h" #include "base/version.h" +#include "components/component_updater/android/component_loader_policy.h" #include "components/component_updater/installer_policies/trust_token_key_commitments_component_installer_policy.h" #include "third_party/abseil-cpp/absl/types/optional.h" @@ -61,7 +62,6 @@ if (keys_fd_iterator == fd_map.end()) { VLOG(1) << "TrustTokenKeyCommitmentsComponentLoaderPolicy#ComponentLoaded " "failed because keys.json is not found in the fd map"; - ComponentLoadFailed(); return; } component_updater::TrustTokenKeyCommitmentsComponentInstallerPolicy:: @@ -71,7 +71,8 @@ on_commitments_ready_); } -void TrustTokenKeyCommitmentsComponentLoaderPolicy::ComponentLoadFailed() {} +void TrustTokenKeyCommitmentsComponentLoaderPolicy::ComponentLoadFailed( + ComponentLoadError /*error*/) {} void TrustTokenKeyCommitmentsComponentLoaderPolicy::GetHash( std::vector<uint8_t>* hash) const {
diff --git a/components/component_updater/android/loader_policies/trust_token_key_commitments_component_loader_policy.h b/components/component_updater/android/loader_policies/trust_token_key_commitments_component_loader_policy.h index 4f10a4e..60d1be7 100644 --- a/components/component_updater/android/loader_policies/trust_token_key_commitments_component_loader_policy.h +++ b/components/component_updater/android/loader_policies/trust_token_key_commitments_component_loader_policy.h
@@ -46,7 +46,7 @@ const base::Version& version, base::flat_map<std::string, base::ScopedFD>& fd_map, std::unique_ptr<base::DictionaryValue> manifest) override; - void ComponentLoadFailed() override; + void ComponentLoadFailed(ComponentLoadError error) override; void GetHash(std::vector<uint8_t>* hash) const override; base::RepeatingCallback<void(const std::string&)> on_commitments_ready_;
diff --git a/components/download/internal/common/download_file_impl.cc b/components/download/internal/common/download_file_impl.cc index 7d9ae871..7728e71 100644 --- a/components/download/internal/common/download_file_impl.cc +++ b/components/download/internal/common/download_file_impl.cc
@@ -548,6 +548,10 @@ record_stream_bandwidth_ = false; for (auto& stream : source_streams_) stream.second->ClearDataReadyCallback(); + + // Stop sending updates since meaningless after paused. + if (update_timer_ && update_timer_->IsRunning()) + update_timer_->Stop(); } void DownloadFileImpl::Resume() {
diff --git a/components/embedder_support/android/metrics/android_metrics_service_client.cc b/components/embedder_support/android/metrics/android_metrics_service_client.cc index b826bc8..3e6fd76 100644 --- a/components/embedder_support/android/metrics/android_metrics_service_client.cc +++ b/components/embedder_support/android/metrics/android_metrics_service_client.cc
@@ -27,6 +27,8 @@ #include "components/metrics/android_metrics_provider.h" #include "components/metrics/call_stack_profile_metrics_provider.h" #include "components/metrics/content/accessibility_metrics_provider.h" +#include "components/metrics/content/content_stability_metrics_provider.h" +#include "components/metrics/content/extensions_helper.h" #include "components/metrics/content/gpu_metrics_provider.h" #include "components/metrics/content/subprocess_metrics_provider.h" #include "components/metrics/cpu_metrics_provider.h" @@ -337,6 +339,9 @@ GetSampleRatePerMille())); metrics_service_->RegisterMetricsProvider( std::make_unique<AccessibilityMetricsProvider>()); + metrics_service_->RegisterMetricsProvider( + std::make_unique<ContentStabilityMetricsProvider>( + pref_service(), /*extensions_helper=*/nullptr)); RegisterAdditionalMetricsProviders(metrics_service_.get()); // The file metrics provider performs IO.
diff --git a/components/embedder_support/user_agent_utils.cc b/components/embedder_support/user_agent_utils.cc index 777bbfd..46f67d07 100644 --- a/components/embedder_support/user_agent_utils.cc +++ b/components/embedder_support/user_agent_utils.cc
@@ -35,7 +35,7 @@ LOG(WARNING) << "Ignored invalid value for flag --" << kUserAgent; } - if (base::FeatureList::IsEnabled(blink::features::kFreezeUserAgent)) { + if (base::FeatureList::IsEnabled(blink::features::kReduceUserAgent)) { return content::GetReducedUserAgent( command_line->HasSwitch(switches::kUseMobileUserAgent), version_info::GetMajorVersionNumber());
diff --git a/components/embedder_support/user_agent_utils_unittest.cc b/components/embedder_support/user_agent_utils_unittest.cc index da6b21e..f8cdae2 100644 --- a/components/embedder_support/user_agent_utils_unittest.cc +++ b/components/embedder_support/user_agent_utils_unittest.cc
@@ -212,7 +212,7 @@ TEST(UserAgentUtilsTest, UserAgentStringFrozen) { base::test::ScopedFeatureList scoped_feature_list; - scoped_feature_list.InitAndEnableFeature(blink::features::kFreezeUserAgent); + scoped_feature_list.InitAndEnableFeature(blink::features::kReduceUserAgent); #if defined(OS_ANDROID) // Verify the correct user agent is returned when the UseMobileUserAgent
diff --git a/components/omnibox/browser/actions/omnibox_pedal_implementations_unittest.cc b/components/omnibox/browser/actions/omnibox_pedal_implementations_unittest.cc index 2bcbe5af..b825071 100644 --- a/components/omnibox/browser/actions/omnibox_pedal_implementations_unittest.cc +++ b/components/omnibox/browser/actions/omnibox_pedal_implementations_unittest.cc
@@ -36,12 +36,16397 @@ return omnibox_edit_controller_->destination_url(); } + // Exhaustive test of unordered synonym groups for concept matches; this is + // useful in detecting possible clashes between cross-group synonym strings. + // By ensuring that each set matches for exactly one Pedal, we can also + // prevent clashes between concepts for different Pedals. + void TestLiteralConceptExpressions() { + const std::vector<std::vector<const char*>> literal_concept_expressions = { + // clang-format off + // Note: The lists below are auto-generated from raw synonym group data. + + // ID#1 + { + // Generated suggestions: + "browser cache clear", + "browser cache delete", + "browser cache erase", + "browser cache remove", + "browser cache wipe", + "browser clear cache", + "browser clear cookies", + "browser clear data", + "browser clear history", + "browser clear info", + "browser clear information", + "browser cookies clear", + "browser cookies delete", + "browser cookies erase", + "browser cookies remove", + "browser cookies wipe", + "browser data clear", + "browser data delete", + "browser data erase", + "browser data remove", + "browser data wipe", + "browser delete cache", + "browser delete cookies", + "browser delete data", + "browser delete history", + "browser delete info", + "browser delete information", + "browser erase cache", + "browser erase cookies", + "browser erase data", + "browser erase history", + "browser erase info", + "browser erase information", + "browser history clear", + "browser history delete", + "browser history erase", + "browser history remove", + "browser history wipe", + "browser info clear", + "browser info delete", + "browser info erase", + "browser info remove", + "browser info wipe", + "browser information clear", + "browser information delete", + "browser information erase", + "browser information remove", + "browser information wipe", + "browser remove cache", + "browser remove cookies", + "browser remove data", + "browser remove history", + "browser remove info", + "browser remove information", + "browser wipe cache", + "browser wipe cookies", + "browser wipe data", + "browser wipe history", + "browser wipe info", + "browser wipe information", + "browsing cache clear", + "browsing cache delete", + "browsing cache erase", + "browsing cache remove", + "browsing cache wipe", + "browsing clear cache", + "browsing clear cookies", + "browsing clear data", + "browsing clear history", + "browsing clear info", + "browsing clear information", + "browsing cookies clear", + "browsing cookies delete", + "browsing cookies erase", + "browsing cookies remove", + "browsing cookies wipe", + "browsing data clear", + "browsing data delete", + "browsing data erase", + "browsing data remove", + "browsing data wipe", + "browsing delete cache", + "browsing delete cookies", + "browsing delete data", + "browsing delete history", + "browsing delete info", + "browsing delete information", + "browsing erase cache", + "browsing erase cookies", + "browsing erase data", + "browsing erase history", + "browsing erase info", + "browsing erase information", + "browsing history clear", + "browsing history delete", + "browsing history erase", + "browsing history remove", + "browsing history wipe", + "browsing info clear", + "browsing info delete", + "browsing info erase", + "browsing info remove", + "browsing info wipe", + "browsing information clear", + "browsing information delete", + "browsing information erase", + "browsing information remove", + "browsing information wipe", + "browsing remove cache", + "browsing remove cookies", + "browsing remove data", + "browsing remove history", + "browsing remove info", + "browsing remove information", + "browsing wipe cache", + "browsing wipe cookies", + "browsing wipe data", + "browsing wipe history", + "browsing wipe info", + "browsing wipe information", + "cache browser clear", + "cache browser delete", + "cache browser erase", + "cache browser remove", + "cache browser wipe", + "cache browsing clear", + "cache browsing delete", + "cache browsing erase", + "cache browsing remove", + "cache browsing wipe", + "cache chrome clear", + "cache chrome delete", + "cache chrome erase", + "cache chrome remove", + "cache chrome wipe", + "cache clear", + "cache clear browser", + "cache clear browsing", + "cache clear chrome", + "cache clear google chrome", + "cache delete", + "cache delete browser", + "cache delete browsing", + "cache delete chrome", + "cache delete google chrome", + "cache erase", + "cache erase browser", + "cache erase browsing", + "cache erase chrome", + "cache erase google chrome", + "cache google chrome clear", + "cache google chrome delete", + "cache google chrome erase", + "cache google chrome remove", + "cache google chrome wipe", + "cache remove", + "cache remove browser", + "cache remove browsing", + "cache remove chrome", + "cache remove google chrome", + "cache wipe", + "cache wipe browser", + "cache wipe browsing", + "cache wipe chrome", + "cache wipe google chrome", + "chrome cache clear", + "chrome cache delete", + "chrome cache erase", + "chrome cache remove", + "chrome cache wipe", + "chrome clear cache", + "chrome clear cookies", + "chrome clear data", + "chrome clear history", + "chrome clear info", + "chrome clear information", + "chrome cookies clear", + "chrome cookies delete", + "chrome cookies erase", + "chrome cookies remove", + "chrome cookies wipe", + "chrome data clear", + "chrome data delete", + "chrome data erase", + "chrome data remove", + "chrome data wipe", + "chrome delete cache", + "chrome delete cookies", + "chrome delete data", + "chrome delete history", + "chrome delete info", + "chrome delete information", + "chrome erase cache", + "chrome erase cookies", + "chrome erase data", + "chrome erase history", + "chrome erase info", + "chrome erase information", + "chrome history clear", + "chrome history delete", + "chrome history erase", + "chrome history remove", + "chrome history wipe", + "chrome info clear", + "chrome info delete", + "chrome info erase", + "chrome info remove", + "chrome info wipe", + "chrome information clear", + "chrome information delete", + "chrome information erase", + "chrome information remove", + "chrome information wipe", + "chrome remove cache", + "chrome remove cookies", + "chrome remove data", + "chrome remove history", + "chrome remove info", + "chrome remove information", + "chrome wipe cache", + "chrome wipe cookies", + "chrome wipe data", + "chrome wipe history", + "chrome wipe info", + "chrome wipe information", + "clear browser cache", + "clear browser cookies", + "clear browser data", + "clear browser history", + "clear browser info", + "clear browser information", + "clear browsing cache", + "clear browsing cookies", + "clear browsing data", + "clear browsing history", + "clear browsing info", + "clear browsing information", + "clear cache", + "clear cache browser", + "clear cache browsing", + "clear cache chrome", + "clear cache google chrome", + "clear chrome cache", + "clear chrome cookies", + "clear chrome data", + "clear chrome history", + "clear chrome info", + "clear chrome information", + "clear cookies", + "clear cookies browser", + "clear cookies browsing", + "clear cookies chrome", + "clear cookies google chrome", + "clear data", + "clear data browser", + "clear data browsing", + "clear data chrome", + "clear data google chrome", + "clear google chrome cache", + "clear google chrome cookies", + "clear google chrome data", + "clear google chrome history", + "clear google chrome info", + "clear google chrome information", + "clear history", + "clear history browser", + "clear history browsing", + "clear history chrome", + "clear history google chrome", + "clear info", + "clear info browser", + "clear info browsing", + "clear info chrome", + "clear info google chrome", + "clear information", + "clear information browser", + "clear information browsing", + "clear information chrome", + "clear information google chrome", + "cookies browser clear", + "cookies browser delete", + "cookies browser erase", + "cookies browser remove", + "cookies browser wipe", + "cookies browsing clear", + "cookies browsing delete", + "cookies browsing erase", + "cookies browsing remove", + "cookies browsing wipe", + "cookies chrome clear", + "cookies chrome delete", + "cookies chrome erase", + "cookies chrome remove", + "cookies chrome wipe", + "cookies clear", + "cookies clear browser", + "cookies clear browsing", + "cookies clear chrome", + "cookies clear google chrome", + "cookies delete", + "cookies delete browser", + "cookies delete browsing", + "cookies delete chrome", + "cookies delete google chrome", + "cookies erase", + "cookies erase browser", + "cookies erase browsing", + "cookies erase chrome", + "cookies erase google chrome", + "cookies google chrome clear", + "cookies google chrome delete", + "cookies google chrome erase", + "cookies google chrome remove", + "cookies google chrome wipe", + "cookies remove", + "cookies remove browser", + "cookies remove browsing", + "cookies remove chrome", + "cookies remove google chrome", + "cookies wipe", + "cookies wipe browser", + "cookies wipe browsing", + "cookies wipe chrome", + "cookies wipe google chrome", + "data browser clear", + "data browser delete", + "data browser erase", + "data browser remove", + "data browser wipe", + "data browsing clear", + "data browsing delete", + "data browsing erase", + "data browsing remove", + "data browsing wipe", + "data chrome clear", + "data chrome delete", + "data chrome erase", + "data chrome remove", + "data chrome wipe", + "data clear", + "data clear browser", + "data clear browsing", + "data clear chrome", + "data clear google chrome", + "data delete", + "data delete browser", + "data delete browsing", + "data delete chrome", + "data delete google chrome", + "data erase", + "data erase browser", + "data erase browsing", + "data erase chrome", + "data erase google chrome", + "data google chrome clear", + "data google chrome delete", + "data google chrome erase", + "data google chrome remove", + "data google chrome wipe", + "data remove", + "data remove browser", + "data remove browsing", + "data remove chrome", + "data remove google chrome", + "data wipe", + "data wipe browser", + "data wipe browsing", + "data wipe chrome", + "data wipe google chrome", + "delete browser cache", + "delete browser cookies", + "delete browser data", + "delete browser history", + "delete browser info", + "delete browser information", + "delete browsing cache", + "delete browsing cookies", + "delete browsing data", + "delete browsing history", + "delete browsing info", + "delete browsing information", + "delete cache", + "delete cache browser", + "delete cache browsing", + "delete cache chrome", + "delete cache google chrome", + "delete chrome cache", + "delete chrome cookies", + "delete chrome data", + "delete chrome history", + "delete chrome info", + "delete chrome information", + "delete cookies", + "delete cookies browser", + "delete cookies browsing", + "delete cookies chrome", + "delete cookies google chrome", + "delete data", + "delete data browser", + "delete data browsing", + "delete data chrome", + "delete data google chrome", + "delete google chrome cache", + "delete google chrome cookies", + "delete google chrome data", + "delete google chrome history", + "delete google chrome info", + "delete google chrome information", + "delete history", + "delete history browser", + "delete history browsing", + "delete history chrome", + "delete history google chrome", + "delete info", + "delete info browser", + "delete info browsing", + "delete info chrome", + "delete info google chrome", + "delete information", + "delete information browser", + "delete information browsing", + "delete information chrome", + "delete information google chrome", + "erase browser cache", + "erase browser cookies", + "erase browser data", + "erase browser history", + "erase browser info", + "erase browser information", + "erase browsing cache", + "erase browsing cookies", + "erase browsing data", + "erase browsing history", + "erase browsing info", + "erase browsing information", + "erase cache", + "erase cache browser", + "erase cache browsing", + "erase cache chrome", + "erase cache google chrome", + "erase chrome cache", + "erase chrome cookies", + "erase chrome data", + "erase chrome history", + "erase chrome info", + "erase chrome information", + "erase cookies", + "erase cookies browser", + "erase cookies browsing", + "erase cookies chrome", + "erase cookies google chrome", + "erase data", + "erase data browser", + "erase data browsing", + "erase data chrome", + "erase data google chrome", + "erase google chrome cache", + "erase google chrome cookies", + "erase google chrome data", + "erase google chrome history", + "erase google chrome info", + "erase google chrome information", + "erase history", + "erase history browser", + "erase history browsing", + "erase history chrome", + "erase history google chrome", + "erase info", + "erase info browser", + "erase info browsing", + "erase info chrome", + "erase info google chrome", + "erase information", + "erase information browser", + "erase information browsing", + "erase information chrome", + "erase information google chrome", + "google chrome cache clear", + "google chrome cache delete", + "google chrome cache erase", + "google chrome cache remove", + "google chrome cache wipe", + "google chrome clear cache", + "google chrome clear cookies", + "google chrome clear data", + "google chrome clear history", + "google chrome clear info", + "google chrome clear information", + "google chrome cookies clear", + "google chrome cookies delete", + "google chrome cookies erase", + "google chrome cookies remove", + "google chrome cookies wipe", + "google chrome data clear", + "google chrome data delete", + "google chrome data erase", + "google chrome data remove", + "google chrome data wipe", + "google chrome delete cache", + "google chrome delete cookies", + "google chrome delete data", + "google chrome delete history", + "google chrome delete info", + "google chrome delete information", + "google chrome erase cache", + "google chrome erase cookies", + "google chrome erase data", + "google chrome erase history", + "google chrome erase info", + "google chrome erase information", + "google chrome history clear", + "google chrome history delete", + "google chrome history erase", + "google chrome history remove", + "google chrome history wipe", + "google chrome info clear", + "google chrome info delete", + "google chrome info erase", + "google chrome info remove", + "google chrome info wipe", + "google chrome information clear", + "google chrome information delete", + "google chrome information erase", + "google chrome information remove", + "google chrome information wipe", + "google chrome remove cache", + "google chrome remove cookies", + "google chrome remove data", + "google chrome remove history", + "google chrome remove info", + "google chrome remove information", + "google chrome wipe cache", + "google chrome wipe cookies", + "google chrome wipe data", + "google chrome wipe history", + "google chrome wipe info", + "google chrome wipe information", + "history browser clear", + "history browser delete", + "history browser erase", + "history browser remove", + "history browser wipe", + "history browsing clear", + "history browsing delete", + "history browsing erase", + "history browsing remove", + "history browsing wipe", + "history chrome clear", + "history chrome delete", + "history chrome erase", + "history chrome remove", + "history chrome wipe", + "history clear", + "history clear browser", + "history clear browsing", + "history clear chrome", + "history clear google chrome", + "history delete", + "history delete browser", + "history delete browsing", + "history delete chrome", + "history delete google chrome", + "history erase", + "history erase browser", + "history erase browsing", + "history erase chrome", + "history erase google chrome", + "history google chrome clear", + "history google chrome delete", + "history google chrome erase", + "history google chrome remove", + "history google chrome wipe", + "history remove", + "history remove browser", + "history remove browsing", + "history remove chrome", + "history remove google chrome", + "history wipe", + "history wipe browser", + "history wipe browsing", + "history wipe chrome", + "history wipe google chrome", + "info browser clear", + "info browser delete", + "info browser erase", + "info browser remove", + "info browser wipe", + "info browsing clear", + "info browsing delete", + "info browsing erase", + "info browsing remove", + "info browsing wipe", + "info chrome clear", + "info chrome delete", + "info chrome erase", + "info chrome remove", + "info chrome wipe", + "info clear", + "info clear browser", + "info clear browsing", + "info clear chrome", + "info clear google chrome", + "info delete", + "info delete browser", + "info delete browsing", + "info delete chrome", + "info delete google chrome", + "info erase", + "info erase browser", + "info erase browsing", + "info erase chrome", + "info erase google chrome", + "info google chrome clear", + "info google chrome delete", + "info google chrome erase", + "info google chrome remove", + "info google chrome wipe", + "info remove", + "info remove browser", + "info remove browsing", + "info remove chrome", + "info remove google chrome", + "info wipe", + "info wipe browser", + "info wipe browsing", + "info wipe chrome", + "info wipe google chrome", + "information browser clear", + "information browser delete", + "information browser erase", + "information browser remove", + "information browser wipe", + "information browsing clear", + "information browsing delete", + "information browsing erase", + "information browsing remove", + "information browsing wipe", + "information chrome clear", + "information chrome delete", + "information chrome erase", + "information chrome remove", + "information chrome wipe", + "information clear", + "information clear browser", + "information clear browsing", + "information clear chrome", + "information clear google chrome", + "information delete", + "information delete browser", + "information delete browsing", + "information delete chrome", + "information delete google chrome", + "information erase", + "information erase browser", + "information erase browsing", + "information erase chrome", + "information erase google chrome", + "information google chrome clear", + "information google chrome delete", + "information google chrome erase", + "information google chrome remove", + "information google chrome wipe", + "information remove", + "information remove browser", + "information remove browsing", + "information remove chrome", + "information remove google chrome", + "information wipe", + "information wipe browser", + "information wipe browsing", + "information wipe chrome", + "information wipe google chrome", + "remove browser cache", + "remove browser cookies", + "remove browser data", + "remove browser history", + "remove browser info", + "remove browser information", + "remove browsing cache", + "remove browsing cookies", + "remove browsing data", + "remove browsing history", + "remove browsing info", + "remove browsing information", + "remove cache", + "remove cache browser", + "remove cache browsing", + "remove cache chrome", + "remove cache google chrome", + "remove chrome cache", + "remove chrome cookies", + "remove chrome data", + "remove chrome history", + "remove chrome info", + "remove chrome information", + "remove cookies", + "remove cookies browser", + "remove cookies browsing", + "remove cookies chrome", + "remove cookies google chrome", + "remove data", + "remove data browser", + "remove data browsing", + "remove data chrome", + "remove data google chrome", + "remove google chrome cache", + "remove google chrome cookies", + "remove google chrome data", + "remove google chrome history", + "remove google chrome info", + "remove google chrome information", + "remove history", + "remove history browser", + "remove history browsing", + "remove history chrome", + "remove history google chrome", + "remove info", + "remove info browser", + "remove info browsing", + "remove info chrome", + "remove info google chrome", + "remove information", + "remove information browser", + "remove information browsing", + "remove information chrome", + "remove information google chrome", + "wipe browser cache", + "wipe browser cookies", + "wipe browser data", + "wipe browser history", + "wipe browser info", + "wipe browser information", + "wipe browsing cache", + "wipe browsing cookies", + "wipe browsing data", + "wipe browsing history", + "wipe browsing info", + "wipe browsing information", + "wipe cache", + "wipe cache browser", + "wipe cache browsing", + "wipe cache chrome", + "wipe cache google chrome", + "wipe chrome cache", + "wipe chrome cookies", + "wipe chrome data", + "wipe chrome history", + "wipe chrome info", + "wipe chrome information", + "wipe cookies", + "wipe cookies browser", + "wipe cookies browsing", + "wipe cookies chrome", + "wipe cookies google chrome", + "wipe data", + "wipe data browser", + "wipe data browsing", + "wipe data chrome", + "wipe data google chrome", + "wipe google chrome cache", + "wipe google chrome cookies", + "wipe google chrome data", + "wipe google chrome history", + "wipe google chrome info", + "wipe google chrome information", + "wipe history", + "wipe history browser", + "wipe history browsing", + "wipe history chrome", + "wipe history google chrome", + "wipe info", + "wipe info browser", + "wipe info browsing", + "wipe info chrome", + "wipe info google chrome", + "wipe information", + "wipe information browser", + "wipe information browsing", + "wipe information chrome", + "wipe information google chrome", + }, + + // ID#2 + { + // Generated suggestions: + "browser change credentials", + "browser change password", + "browser change passwords", + "browser credentials change", + "browser credentials edit", + "browser credentials manage", + "browser credentials manager", + "browser credentials save", + "browser credentials show", + "browser credentials update", + "browser credentials view", + "browser edit credentials", + "browser edit password", + "browser edit passwords", + "browser manage credentials", + "browser manage password", + "browser manage passwords", + "browser manager credentials", + "browser manager password", + "browser manager passwords", + "browser password change", + "browser password edit", + "browser password manage", + "browser password manager", + "browser password save", + "browser password show", + "browser password update", + "browser password view", + "browser passwords change", + "browser passwords edit", + "browser passwords manage", + "browser passwords manager", + "browser passwords save", + "browser passwords show", + "browser passwords update", + "browser passwords view", + "browser save credentials", + "browser save password", + "browser save passwords", + "browser show credentials", + "browser show password", + "browser show passwords", + "browser update credentials", + "browser update password", + "browser update passwords", + "browser view credentials", + "browser view password", + "browser view passwords", + "change browser credentials", + "change browser password", + "change browser passwords", + "change chrome credentials", + "change chrome password", + "change chrome passwords", + "change credentials", + "change credentials browser", + "change credentials chrome", + "change credentials google chrome", + "change google chrome credentials", + "change google chrome password", + "change google chrome passwords", + "change password", + "change password browser", + "change password chrome", + "change password google chrome", + "change passwords", + "change passwords browser", + "change passwords chrome", + "change passwords google chrome", + "chrome change credentials", + "chrome change password", + "chrome change passwords", + "chrome credentials change", + "chrome credentials edit", + "chrome credentials manage", + "chrome credentials manager", + "chrome credentials save", + "chrome credentials show", + "chrome credentials update", + "chrome credentials view", + "chrome edit credentials", + "chrome edit password", + "chrome edit passwords", + "chrome manage credentials", + "chrome manage password", + "chrome manage passwords", + "chrome manager credentials", + "chrome manager password", + "chrome manager passwords", + "chrome password change", + "chrome password edit", + "chrome password manage", + "chrome password manager", + "chrome password save", + "chrome password show", + "chrome password update", + "chrome password view", + "chrome passwords change", + "chrome passwords edit", + "chrome passwords manage", + "chrome passwords manager", + "chrome passwords save", + "chrome passwords show", + "chrome passwords update", + "chrome passwords view", + "chrome save credentials", + "chrome save password", + "chrome save passwords", + "chrome show credentials", + "chrome show password", + "chrome show passwords", + "chrome update credentials", + "chrome update password", + "chrome update passwords", + "chrome view credentials", + "chrome view password", + "chrome view passwords", + "credentials browser change", + "credentials browser edit", + "credentials browser manage", + "credentials browser manager", + "credentials browser save", + "credentials browser show", + "credentials browser update", + "credentials browser view", + "credentials change", + "credentials change browser", + "credentials change chrome", + "credentials change google chrome", + "credentials chrome change", + "credentials chrome edit", + "credentials chrome manage", + "credentials chrome manager", + "credentials chrome save", + "credentials chrome show", + "credentials chrome update", + "credentials chrome view", + "credentials edit", + "credentials edit browser", + "credentials edit chrome", + "credentials edit google chrome", + "credentials google chrome change", + "credentials google chrome edit", + "credentials google chrome manage", + "credentials google chrome manager", + "credentials google chrome save", + "credentials google chrome show", + "credentials google chrome update", + "credentials google chrome view", + "credentials manage", + "credentials manage browser", + "credentials manage chrome", + "credentials manage google chrome", + "credentials manager", + "credentials manager browser", + "credentials manager chrome", + "credentials manager google chrome", + "credentials save", + "credentials save browser", + "credentials save chrome", + "credentials save google chrome", + "credentials show", + "credentials show browser", + "credentials show chrome", + "credentials show google chrome", + "credentials update", + "credentials update browser", + "credentials update chrome", + "credentials update google chrome", + "credentials view", + "credentials view browser", + "credentials view chrome", + "credentials view google chrome", + "edit browser credentials", + "edit browser password", + "edit browser passwords", + "edit chrome credentials", + "edit chrome password", + "edit chrome passwords", + "edit credentials", + "edit credentials browser", + "edit credentials chrome", + "edit credentials google chrome", + "edit google chrome credentials", + "edit google chrome password", + "edit google chrome passwords", + "edit password", + "edit password browser", + "edit password chrome", + "edit password google chrome", + "edit passwords", + "edit passwords browser", + "edit passwords chrome", + "edit passwords google chrome", + "google chrome change credentials", + "google chrome change password", + "google chrome change passwords", + "google chrome credentials change", + "google chrome credentials edit", + "google chrome credentials manage", + "google chrome credentials manager", + "google chrome credentials save", + "google chrome credentials show", + "google chrome credentials update", + "google chrome credentials view", + "google chrome edit credentials", + "google chrome edit password", + "google chrome edit passwords", + "google chrome manage credentials", + "google chrome manage password", + "google chrome manage passwords", + "google chrome manager credentials", + "google chrome manager password", + "google chrome manager passwords", + "google chrome password change", + "google chrome password edit", + "google chrome password manage", + "google chrome password manager", + "google chrome password save", + "google chrome password show", + "google chrome password update", + "google chrome password view", + "google chrome passwords change", + "google chrome passwords edit", + "google chrome passwords manage", + "google chrome passwords manager", + "google chrome passwords save", + "google chrome passwords show", + "google chrome passwords update", + "google chrome passwords view", + "google chrome save credentials", + "google chrome save password", + "google chrome save passwords", + "google chrome show credentials", + "google chrome show password", + "google chrome show passwords", + "google chrome update credentials", + "google chrome update password", + "google chrome update passwords", + "google chrome view credentials", + "google chrome view password", + "google chrome view passwords", + "manage browser credentials", + "manage browser password", + "manage browser passwords", + "manage chrome credentials", + "manage chrome password", + "manage chrome passwords", + "manage credentials", + "manage credentials browser", + "manage credentials chrome", + "manage credentials google chrome", + "manage google chrome credentials", + "manage google chrome password", + "manage google chrome passwords", + "manage password", + "manage password browser", + "manage password chrome", + "manage password google chrome", + "manage passwords", + "manage passwords browser", + "manage passwords chrome", + "manage passwords google chrome", + "manager browser credentials", + "manager browser password", + "manager browser passwords", + "manager chrome credentials", + "manager chrome password", + "manager chrome passwords", + "manager credentials", + "manager credentials browser", + "manager credentials chrome", + "manager credentials google chrome", + "manager google chrome credentials", + "manager google chrome password", + "manager google chrome passwords", + "manager password", + "manager password browser", + "manager password chrome", + "manager password google chrome", + "manager passwords", + "manager passwords browser", + "manager passwords chrome", + "manager passwords google chrome", + "password browser change", + "password browser edit", + "password browser manage", + "password browser manager", + "password browser save", + "password browser show", + "password browser update", + "password browser view", + "password change", + "password change browser", + "password change chrome", + "password change google chrome", + "password chrome change", + "password chrome edit", + "password chrome manage", + "password chrome manager", + "password chrome save", + "password chrome show", + "password chrome update", + "password chrome view", + "password edit", + "password edit browser", + "password edit chrome", + "password edit google chrome", + "password google chrome change", + "password google chrome edit", + "password google chrome manage", + "password google chrome manager", + "password google chrome save", + "password google chrome show", + "password google chrome update", + "password google chrome view", + "password manage", + "password manage browser", + "password manage chrome", + "password manage google chrome", + "password manager", + "password manager browser", + "password manager chrome", + "password manager google chrome", + "password save", + "password save browser", + "password save chrome", + "password save google chrome", + "password show", + "password show browser", + "password show chrome", + "password show google chrome", + "password update", + "password update browser", + "password update chrome", + "password update google chrome", + "password view", + "password view browser", + "password view chrome", + "password view google chrome", + "passwords browser change", + "passwords browser edit", + "passwords browser manage", + "passwords browser manager", + "passwords browser save", + "passwords browser show", + "passwords browser update", + "passwords browser view", + "passwords change", + "passwords change browser", + "passwords change chrome", + "passwords change google chrome", + "passwords chrome change", + "passwords chrome edit", + "passwords chrome manage", + "passwords chrome manager", + "passwords chrome save", + "passwords chrome show", + "passwords chrome update", + "passwords chrome view", + "passwords edit", + "passwords edit browser", + "passwords edit chrome", + "passwords edit google chrome", + "passwords google chrome change", + "passwords google chrome edit", + "passwords google chrome manage", + "passwords google chrome manager", + "passwords google chrome save", + "passwords google chrome show", + "passwords google chrome update", + "passwords google chrome view", + "passwords manage", + "passwords manage browser", + "passwords manage chrome", + "passwords manage google chrome", + "passwords manager", + "passwords manager browser", + "passwords manager chrome", + "passwords manager google chrome", + "passwords save", + "passwords save browser", + "passwords save chrome", + "passwords save google chrome", + "passwords show", + "passwords show browser", + "passwords show chrome", + "passwords show google chrome", + "passwords update", + "passwords update browser", + "passwords update chrome", + "passwords update google chrome", + "passwords view", + "passwords view browser", + "passwords view chrome", + "passwords view google chrome", + "save browser credentials", + "save browser password", + "save browser passwords", + "save chrome credentials", + "save chrome password", + "save chrome passwords", + "save credentials", + "save credentials browser", + "save credentials chrome", + "save credentials google chrome", + "save google chrome credentials", + "save google chrome password", + "save google chrome passwords", + "save password", + "save password browser", + "save password chrome", + "save password google chrome", + "save passwords", + "save passwords browser", + "save passwords chrome", + "save passwords google chrome", + "show browser credentials", + "show browser password", + "show browser passwords", + "show chrome credentials", + "show chrome password", + "show chrome passwords", + "show credentials", + "show credentials browser", + "show credentials chrome", + "show credentials google chrome", + "show google chrome credentials", + "show google chrome password", + "show google chrome passwords", + "show password", + "show password browser", + "show password chrome", + "show password google chrome", + "show passwords", + "show passwords browser", + "show passwords chrome", + "show passwords google chrome", + "update browser credentials", + "update browser password", + "update browser passwords", + "update chrome credentials", + "update chrome password", + "update chrome passwords", + "update credentials", + "update credentials browser", + "update credentials chrome", + "update credentials google chrome", + "update google chrome credentials", + "update google chrome password", + "update google chrome passwords", + "update password", + "update password browser", + "update password chrome", + "update password google chrome", + "update passwords", + "update passwords browser", + "update passwords chrome", + "update passwords google chrome", + "view browser credentials", + "view browser password", + "view browser passwords", + "view chrome credentials", + "view chrome password", + "view chrome passwords", + "view credentials", + "view credentials browser", + "view credentials chrome", + "view credentials google chrome", + "view google chrome credentials", + "view google chrome password", + "view google chrome passwords", + "view password", + "view password browser", + "view password chrome", + "view password google chrome", + "view passwords", + "view passwords browser", + "view passwords chrome", + "view passwords google chrome", + }, + + // ID#3 + { + // Generated suggestions: + "browser card info change", + "browser card info edit", + "browser card info manage", + "browser card info save", + "browser card info update", + "browser card information change", + "browser card information edit", + "browser card information manage", + "browser card information save", + "browser card information update", + "browser cards change", + "browser cards edit", + "browser cards manage", + "browser cards save", + "browser cards update", + "browser change card info", + "browser change card information", + "browser change cards", + "browser change credit card", + "browser change credit card info", + "browser change credit card information", + "browser change credit cards", + "browser change payment", + "browser change payment methods", + "browser change payments", + "browser credit card change", + "browser credit card edit", + "browser credit card info change", + "browser credit card info edit", + "browser credit card info manage", + "browser credit card info save", + "browser credit card info update", + "browser credit card information change", + "browser credit card information edit", + "browser credit card information manage", + "browser credit card information save", + "browser credit card information update", + "browser credit card manage", + "browser credit card save", + "browser credit card update", + "browser credit cards change", + "browser credit cards edit", + "browser credit cards manage", + "browser credit cards save", + "browser credit cards update", + "browser edit card info", + "browser edit card information", + "browser edit cards", + "browser edit credit card", + "browser edit credit card info", + "browser edit credit card information", + "browser edit credit cards", + "browser edit payment", + "browser edit payment methods", + "browser edit payments", + "browser manage card info", + "browser manage card information", + "browser manage cards", + "browser manage credit card", + "browser manage credit card info", + "browser manage credit card information", + "browser manage credit cards", + "browser manage payment", + "browser manage payment methods", + "browser manage payments", + "browser payment change", + "browser payment edit", + "browser payment manage", + "browser payment methods change", + "browser payment methods edit", + "browser payment methods manage", + "browser payment methods save", + "browser payment methods update", + "browser payment save", + "browser payment update", + "browser payments change", + "browser payments edit", + "browser payments manage", + "browser payments save", + "browser payments update", + "browser save card info", + "browser save card information", + "browser save cards", + "browser save credit card", + "browser save credit card info", + "browser save credit card information", + "browser save credit cards", + "browser save payment", + "browser save payment methods", + "browser save payments", + "browser update card info", + "browser update card information", + "browser update cards", + "browser update credit card", + "browser update credit card info", + "browser update credit card information", + "browser update credit cards", + "browser update payment", + "browser update payment methods", + "browser update payments", + "card info browser change", + "card info browser edit", + "card info browser manage", + "card info browser save", + "card info browser update", + "card info change", + "card info change browser", + "card info change chrome", + "card info change google chrome", + "card info chrome change", + "card info chrome edit", + "card info chrome manage", + "card info chrome save", + "card info chrome update", + "card info edit", + "card info edit browser", + "card info edit chrome", + "card info edit google chrome", + "card info google chrome change", + "card info google chrome edit", + "card info google chrome manage", + "card info google chrome save", + "card info google chrome update", + "card info manage", + "card info manage browser", + "card info manage chrome", + "card info manage google chrome", + "card info save", + "card info save browser", + "card info save chrome", + "card info save google chrome", + "card info update", + "card info update browser", + "card info update chrome", + "card info update google chrome", + "card information browser change", + "card information browser edit", + "card information browser manage", + "card information browser save", + "card information browser update", + "card information change", + "card information change browser", + "card information change chrome", + "card information change google chrome", + "card information chrome change", + "card information chrome edit", + "card information chrome manage", + "card information chrome save", + "card information chrome update", + "card information edit", + "card information edit browser", + "card information edit chrome", + "card information edit google chrome", + "card information google chrome change", + "card information google chrome edit", + "card information google chrome manage", + "card information google chrome save", + "card information google chrome update", + "card information manage", + "card information manage browser", + "card information manage chrome", + "card information manage google chrome", + "card information save", + "card information save browser", + "card information save chrome", + "card information save google chrome", + "card information update", + "card information update browser", + "card information update chrome", + "card information update google chrome", + "cards browser change", + "cards browser edit", + "cards browser manage", + "cards browser save", + "cards browser update", + "cards change", + "cards change browser", + "cards change chrome", + "cards change google chrome", + "cards chrome change", + "cards chrome edit", + "cards chrome manage", + "cards chrome save", + "cards chrome update", + "cards edit", + "cards edit browser", + "cards edit chrome", + "cards edit google chrome", + "cards google chrome change", + "cards google chrome edit", + "cards google chrome manage", + "cards google chrome save", + "cards google chrome update", + "cards manage", + "cards manage browser", + "cards manage chrome", + "cards manage google chrome", + "cards save", + "cards save browser", + "cards save chrome", + "cards save google chrome", + "cards update", + "cards update browser", + "cards update chrome", + "cards update google chrome", + "change browser card info", + "change browser card information", + "change browser cards", + "change browser credit card", + "change browser credit card info", + "change browser credit card information", + "change browser credit cards", + "change browser payment", + "change browser payment methods", + "change browser payments", + "change card info", + "change card info browser", + "change card info chrome", + "change card info google chrome", + "change card information", + "change card information browser", + "change card information chrome", + "change card information google chrome", + "change cards", + "change cards browser", + "change cards chrome", + "change cards google chrome", + "change chrome card info", + "change chrome card information", + "change chrome cards", + "change chrome credit card", + "change chrome credit card info", + "change chrome credit card information", + "change chrome credit cards", + "change chrome payment", + "change chrome payment methods", + "change chrome payments", + "change credit card", + "change credit card browser", + "change credit card chrome", + "change credit card google chrome", + "change credit card info", + "change credit card info browser", + "change credit card info chrome", + "change credit card info google chrome", + "change credit card information", + "change credit card information browser", + "change credit card information chrome", + "change credit card information google chrome", + "change credit cards", + "change credit cards browser", + "change credit cards chrome", + "change credit cards google chrome", + "change google chrome card info", + "change google chrome card information", + "change google chrome cards", + "change google chrome credit card", + "change google chrome credit card info", + "change google chrome credit card information", + "change google chrome credit cards", + "change google chrome payment", + "change google chrome payment methods", + "change google chrome payments", + "change payment", + "change payment browser", + "change payment chrome", + "change payment google chrome", + "change payment methods", + "change payment methods browser", + "change payment methods chrome", + "change payment methods google chrome", + "change payments", + "change payments browser", + "change payments chrome", + "change payments google chrome", + "chrome card info change", + "chrome card info edit", + "chrome card info manage", + "chrome card info save", + "chrome card info update", + "chrome card information change", + "chrome card information edit", + "chrome card information manage", + "chrome card information save", + "chrome card information update", + "chrome cards change", + "chrome cards edit", + "chrome cards manage", + "chrome cards save", + "chrome cards update", + "chrome change card info", + "chrome change card information", + "chrome change cards", + "chrome change credit card", + "chrome change credit card info", + "chrome change credit card information", + "chrome change credit cards", + "chrome change payment", + "chrome change payment methods", + "chrome change payments", + "chrome credit card change", + "chrome credit card edit", + "chrome credit card info change", + "chrome credit card info edit", + "chrome credit card info manage", + "chrome credit card info save", + "chrome credit card info update", + "chrome credit card information change", + "chrome credit card information edit", + "chrome credit card information manage", + "chrome credit card information save", + "chrome credit card information update", + "chrome credit card manage", + "chrome credit card save", + "chrome credit card update", + "chrome credit cards change", + "chrome credit cards edit", + "chrome credit cards manage", + "chrome credit cards save", + "chrome credit cards update", + "chrome edit card info", + "chrome edit card information", + "chrome edit cards", + "chrome edit credit card", + "chrome edit credit card info", + "chrome edit credit card information", + "chrome edit credit cards", + "chrome edit payment", + "chrome edit payment methods", + "chrome edit payments", + "chrome manage card info", + "chrome manage card information", + "chrome manage cards", + "chrome manage credit card", + "chrome manage credit card info", + "chrome manage credit card information", + "chrome manage credit cards", + "chrome manage payment", + "chrome manage payment methods", + "chrome manage payments", + "chrome payment change", + "chrome payment edit", + "chrome payment manage", + "chrome payment methods change", + "chrome payment methods edit", + "chrome payment methods manage", + "chrome payment methods save", + "chrome payment methods update", + "chrome payment save", + "chrome payment update", + "chrome payments change", + "chrome payments edit", + "chrome payments manage", + "chrome payments save", + "chrome payments update", + "chrome save card info", + "chrome save card information", + "chrome save cards", + "chrome save credit card", + "chrome save credit card info", + "chrome save credit card information", + "chrome save credit cards", + "chrome save payment", + "chrome save payment methods", + "chrome save payments", + "chrome update card info", + "chrome update card information", + "chrome update cards", + "chrome update credit card", + "chrome update credit card info", + "chrome update credit card information", + "chrome update credit cards", + "chrome update payment", + "chrome update payment methods", + "chrome update payments", + "credit card browser change", + "credit card browser edit", + "credit card browser manage", + "credit card browser save", + "credit card browser update", + "credit card change", + "credit card change browser", + "credit card change chrome", + "credit card change google chrome", + "credit card chrome change", + "credit card chrome edit", + "credit card chrome manage", + "credit card chrome save", + "credit card chrome update", + "credit card edit", + "credit card edit browser", + "credit card edit chrome", + "credit card edit google chrome", + "credit card google chrome change", + "credit card google chrome edit", + "credit card google chrome manage", + "credit card google chrome save", + "credit card google chrome update", + "credit card info browser change", + "credit card info browser edit", + "credit card info browser manage", + "credit card info browser save", + "credit card info browser update", + "credit card info change", + "credit card info change browser", + "credit card info change chrome", + "credit card info change google chrome", + "credit card info chrome change", + "credit card info chrome edit", + "credit card info chrome manage", + "credit card info chrome save", + "credit card info chrome update", + "credit card info edit", + "credit card info edit browser", + "credit card info edit chrome", + "credit card info edit google chrome", + "credit card info google chrome change", + "credit card info google chrome edit", + "credit card info google chrome manage", + "credit card info google chrome save", + "credit card info google chrome update", + "credit card info manage", + "credit card info manage browser", + "credit card info manage chrome", + "credit card info manage google chrome", + "credit card info save", + "credit card info save browser", + "credit card info save chrome", + "credit card info save google chrome", + "credit card info update", + "credit card info update browser", + "credit card info update chrome", + "credit card info update google chrome", + "credit card information browser change", + "credit card information browser edit", + "credit card information browser manage", + "credit card information browser save", + "credit card information browser update", + "credit card information change", + "credit card information change browser", + "credit card information change chrome", + "credit card information change google chrome", + "credit card information chrome change", + "credit card information chrome edit", + "credit card information chrome manage", + "credit card information chrome save", + "credit card information chrome update", + "credit card information edit", + "credit card information edit browser", + "credit card information edit chrome", + "credit card information edit google chrome", + "credit card information google chrome change", + "credit card information google chrome edit", + "credit card information google chrome manage", + "credit card information google chrome save", + "credit card information google chrome update", + "credit card information manage", + "credit card information manage browser", + "credit card information manage chrome", + "credit card information manage google chrome", + "credit card information save", + "credit card information save browser", + "credit card information save chrome", + "credit card information save google chrome", + "credit card information update", + "credit card information update browser", + "credit card information update chrome", + "credit card information update google chrome", + "credit card manage", + "credit card manage browser", + "credit card manage chrome", + "credit card manage google chrome", + "credit card save", + "credit card save browser", + "credit card save chrome", + "credit card save google chrome", + "credit card update", + "credit card update browser", + "credit card update chrome", + "credit card update google chrome", + "credit cards browser change", + "credit cards browser edit", + "credit cards browser manage", + "credit cards browser save", + "credit cards browser update", + "credit cards change", + "credit cards change browser", + "credit cards change chrome", + "credit cards change google chrome", + "credit cards chrome change", + "credit cards chrome edit", + "credit cards chrome manage", + "credit cards chrome save", + "credit cards chrome update", + "credit cards edit", + "credit cards edit browser", + "credit cards edit chrome", + "credit cards edit google chrome", + "credit cards google chrome change", + "credit cards google chrome edit", + "credit cards google chrome manage", + "credit cards google chrome save", + "credit cards google chrome update", + "credit cards manage", + "credit cards manage browser", + "credit cards manage chrome", + "credit cards manage google chrome", + "credit cards save", + "credit cards save browser", + "credit cards save chrome", + "credit cards save google chrome", + "credit cards update", + "credit cards update browser", + "credit cards update chrome", + "credit cards update google chrome", + "edit browser card info", + "edit browser card information", + "edit browser cards", + "edit browser credit card", + "edit browser credit card info", + "edit browser credit card information", + "edit browser credit cards", + "edit browser payment", + "edit browser payment methods", + "edit browser payments", + "edit card info", + "edit card info browser", + "edit card info chrome", + "edit card info google chrome", + "edit card information", + "edit card information browser", + "edit card information chrome", + "edit card information google chrome", + "edit cards", + "edit cards browser", + "edit cards chrome", + "edit cards google chrome", + "edit chrome card info", + "edit chrome card information", + "edit chrome cards", + "edit chrome credit card", + "edit chrome credit card info", + "edit chrome credit card information", + "edit chrome credit cards", + "edit chrome payment", + "edit chrome payment methods", + "edit chrome payments", + "edit credit card", + "edit credit card browser", + "edit credit card chrome", + "edit credit card google chrome", + "edit credit card info", + "edit credit card info browser", + "edit credit card info chrome", + "edit credit card info google chrome", + "edit credit card information", + "edit credit card information browser", + "edit credit card information chrome", + "edit credit card information google chrome", + "edit credit cards", + "edit credit cards browser", + "edit credit cards chrome", + "edit credit cards google chrome", + "edit google chrome card info", + "edit google chrome card information", + "edit google chrome cards", + "edit google chrome credit card", + "edit google chrome credit card info", + "edit google chrome credit card information", + "edit google chrome credit cards", + "edit google chrome payment", + "edit google chrome payment methods", + "edit google chrome payments", + "edit payment", + "edit payment browser", + "edit payment chrome", + "edit payment google chrome", + "edit payment methods", + "edit payment methods browser", + "edit payment methods chrome", + "edit payment methods google chrome", + "edit payments", + "edit payments browser", + "edit payments chrome", + "edit payments google chrome", + "google chrome card info change", + "google chrome card info edit", + "google chrome card info manage", + "google chrome card info save", + "google chrome card info update", + "google chrome card information change", + "google chrome card information edit", + "google chrome card information manage", + "google chrome card information save", + "google chrome card information update", + "google chrome cards change", + "google chrome cards edit", + "google chrome cards manage", + "google chrome cards save", + "google chrome cards update", + "google chrome change card info", + "google chrome change card information", + "google chrome change cards", + "google chrome change credit card", + "google chrome change credit card info", + "google chrome change credit card information", + "google chrome change credit cards", + "google chrome change payment", + "google chrome change payment methods", + "google chrome change payments", + "google chrome credit card change", + "google chrome credit card edit", + "google chrome credit card info change", + "google chrome credit card info edit", + "google chrome credit card info manage", + "google chrome credit card info save", + "google chrome credit card info update", + "google chrome credit card information change", + "google chrome credit card information edit", + "google chrome credit card information manage", + "google chrome credit card information save", + "google chrome credit card information update", + "google chrome credit card manage", + "google chrome credit card save", + "google chrome credit card update", + "google chrome credit cards change", + "google chrome credit cards edit", + "google chrome credit cards manage", + "google chrome credit cards save", + "google chrome credit cards update", + "google chrome edit card info", + "google chrome edit card information", + "google chrome edit cards", + "google chrome edit credit card", + "google chrome edit credit card info", + "google chrome edit credit card information", + "google chrome edit credit cards", + "google chrome edit payment", + "google chrome edit payment methods", + "google chrome edit payments", + "google chrome manage card info", + "google chrome manage card information", + "google chrome manage cards", + "google chrome manage credit card", + "google chrome manage credit card info", + "google chrome manage credit card information", + "google chrome manage credit cards", + "google chrome manage payment", + "google chrome manage payment methods", + "google chrome manage payments", + "google chrome payment change", + "google chrome payment edit", + "google chrome payment manage", + "google chrome payment methods change", + "google chrome payment methods edit", + "google chrome payment methods manage", + "google chrome payment methods save", + "google chrome payment methods update", + "google chrome payment save", + "google chrome payment update", + "google chrome payments change", + "google chrome payments edit", + "google chrome payments manage", + "google chrome payments save", + "google chrome payments update", + "google chrome save card info", + "google chrome save card information", + "google chrome save cards", + "google chrome save credit card", + "google chrome save credit card info", + "google chrome save credit card information", + "google chrome save credit cards", + "google chrome save payment", + "google chrome save payment methods", + "google chrome save payments", + "google chrome update card info", + "google chrome update card information", + "google chrome update cards", + "google chrome update credit card", + "google chrome update credit card info", + "google chrome update credit card information", + "google chrome update credit cards", + "google chrome update payment", + "google chrome update payment methods", + "google chrome update payments", + "manage browser card info", + "manage browser card information", + "manage browser cards", + "manage browser credit card", + "manage browser credit card info", + "manage browser credit card information", + "manage browser credit cards", + "manage browser payment", + "manage browser payment methods", + "manage browser payments", + "manage card info", + "manage card info browser", + "manage card info chrome", + "manage card info google chrome", + "manage card information", + "manage card information browser", + "manage card information chrome", + "manage card information google chrome", + "manage cards", + "manage cards browser", + "manage cards chrome", + "manage cards google chrome", + "manage chrome card info", + "manage chrome card information", + "manage chrome cards", + "manage chrome credit card", + "manage chrome credit card info", + "manage chrome credit card information", + "manage chrome credit cards", + "manage chrome payment", + "manage chrome payment methods", + "manage chrome payments", + "manage credit card", + "manage credit card browser", + "manage credit card chrome", + "manage credit card google chrome", + "manage credit card info", + "manage credit card info browser", + "manage credit card info chrome", + "manage credit card info google chrome", + "manage credit card information", + "manage credit card information browser", + "manage credit card information chrome", + "manage credit card information google chrome", + "manage credit cards", + "manage credit cards browser", + "manage credit cards chrome", + "manage credit cards google chrome", + "manage google chrome card info", + "manage google chrome card information", + "manage google chrome cards", + "manage google chrome credit card", + "manage google chrome credit card info", + "manage google chrome credit card information", + "manage google chrome credit cards", + "manage google chrome payment", + "manage google chrome payment methods", + "manage google chrome payments", + "manage payment", + "manage payment browser", + "manage payment chrome", + "manage payment google chrome", + "manage payment methods", + "manage payment methods browser", + "manage payment methods chrome", + "manage payment methods google chrome", + "manage payments", + "manage payments browser", + "manage payments chrome", + "manage payments google chrome", + "payment browser change", + "payment browser edit", + "payment browser manage", + "payment browser save", + "payment browser update", + "payment change", + "payment change browser", + "payment change chrome", + "payment change google chrome", + "payment chrome change", + "payment chrome edit", + "payment chrome manage", + "payment chrome save", + "payment chrome update", + "payment edit", + "payment edit browser", + "payment edit chrome", + "payment edit google chrome", + "payment google chrome change", + "payment google chrome edit", + "payment google chrome manage", + "payment google chrome save", + "payment google chrome update", + "payment manage", + "payment manage browser", + "payment manage chrome", + "payment manage google chrome", + "payment methods browser change", + "payment methods browser edit", + "payment methods browser manage", + "payment methods browser save", + "payment methods browser update", + "payment methods change", + "payment methods change browser", + "payment methods change chrome", + "payment methods change google chrome", + "payment methods chrome change", + "payment methods chrome edit", + "payment methods chrome manage", + "payment methods chrome save", + "payment methods chrome update", + "payment methods edit", + "payment methods edit browser", + "payment methods edit chrome", + "payment methods edit google chrome", + "payment methods google chrome change", + "payment methods google chrome edit", + "payment methods google chrome manage", + "payment methods google chrome save", + "payment methods google chrome update", + "payment methods manage", + "payment methods manage browser", + "payment methods manage chrome", + "payment methods manage google chrome", + "payment methods save", + "payment methods save browser", + "payment methods save chrome", + "payment methods save google chrome", + "payment methods update", + "payment methods update browser", + "payment methods update chrome", + "payment methods update google chrome", + "payment save", + "payment save browser", + "payment save chrome", + "payment save google chrome", + "payment update", + "payment update browser", + "payment update chrome", + "payment update google chrome", + "payments browser change", + "payments browser edit", + "payments browser manage", + "payments browser save", + "payments browser update", + "payments change", + "payments change browser", + "payments change chrome", + "payments change google chrome", + "payments chrome change", + "payments chrome edit", + "payments chrome manage", + "payments chrome save", + "payments chrome update", + "payments edit", + "payments edit browser", + "payments edit chrome", + "payments edit google chrome", + "payments google chrome change", + "payments google chrome edit", + "payments google chrome manage", + "payments google chrome save", + "payments google chrome update", + "payments manage", + "payments manage browser", + "payments manage chrome", + "payments manage google chrome", + "payments save", + "payments save browser", + "payments save chrome", + "payments save google chrome", + "payments update", + "payments update browser", + "payments update chrome", + "payments update google chrome", + "save browser card info", + "save browser card information", + "save browser cards", + "save browser credit card", + "save browser credit card info", + "save browser credit card information", + "save browser credit cards", + "save browser payment", + "save browser payment methods", + "save browser payments", + "save card info", + "save card info browser", + "save card info chrome", + "save card info google chrome", + "save card information", + "save card information browser", + "save card information chrome", + "save card information google chrome", + "save cards", + "save cards browser", + "save cards chrome", + "save cards google chrome", + "save chrome card info", + "save chrome card information", + "save chrome cards", + "save chrome credit card", + "save chrome credit card info", + "save chrome credit card information", + "save chrome credit cards", + "save chrome payment", + "save chrome payment methods", + "save chrome payments", + "save credit card", + "save credit card browser", + "save credit card chrome", + "save credit card google chrome", + "save credit card info", + "save credit card info browser", + "save credit card info chrome", + "save credit card info google chrome", + "save credit card information", + "save credit card information browser", + "save credit card information chrome", + "save credit card information google chrome", + "save credit cards", + "save credit cards browser", + "save credit cards chrome", + "save credit cards google chrome", + "save google chrome card info", + "save google chrome card information", + "save google chrome cards", + "save google chrome credit card", + "save google chrome credit card info", + "save google chrome credit card information", + "save google chrome credit cards", + "save google chrome payment", + "save google chrome payment methods", + "save google chrome payments", + "save payment", + "save payment browser", + "save payment chrome", + "save payment google chrome", + "save payment methods", + "save payment methods browser", + "save payment methods chrome", + "save payment methods google chrome", + "save payments", + "save payments browser", + "save payments chrome", + "save payments google chrome", + "update browser card info", + "update browser card information", + "update browser cards", + "update browser credit card", + "update browser credit card info", + "update browser credit card information", + "update browser credit cards", + "update browser payment", + "update browser payment methods", + "update browser payments", + "update card info", + "update card info browser", + "update card info chrome", + "update card info google chrome", + "update card information", + "update card information browser", + "update card information chrome", + "update card information google chrome", + "update cards", + "update cards browser", + "update cards chrome", + "update cards google chrome", + "update chrome card info", + "update chrome card information", + "update chrome cards", + "update chrome credit card", + "update chrome credit card info", + "update chrome credit card information", + "update chrome credit cards", + "update chrome payment", + "update chrome payment methods", + "update chrome payments", + "update credit card", + "update credit card browser", + "update credit card chrome", + "update credit card google chrome", + "update credit card info", + "update credit card info browser", + "update credit card info chrome", + "update credit card info google chrome", + "update credit card information", + "update credit card information browser", + "update credit card information chrome", + "update credit card information google chrome", + "update credit cards", + "update credit cards browser", + "update credit cards chrome", + "update credit cards google chrome", + "update google chrome card info", + "update google chrome card information", + "update google chrome cards", + "update google chrome credit card", + "update google chrome credit card info", + "update google chrome credit card information", + "update google chrome credit cards", + "update google chrome payment", + "update google chrome payment methods", + "update google chrome payments", + "update payment", + "update payment browser", + "update payment chrome", + "update payment google chrome", + "update payment methods", + "update payment methods browser", + "update payment methods chrome", + "update payment methods google chrome", + "update payments", + "update payments browser", + "update payments chrome", + "update payments google chrome", + }, + + // ID#4 + { + // Generated suggestions: + "browser create incognito", + "browser create incognito mode", + "browser create incognito tab", + "browser create incognito window", + "browser create private mode", + "browser create private tab", + "browser create private window", + "browser enter incognito", + "browser enter incognito mode", + "browser enter incognito tab", + "browser enter incognito window", + "browser enter private mode", + "browser enter private tab", + "browser enter private window", + "browser incognito", + "browser incognito create", + "browser incognito enter", + "browser incognito launch", + "browser incognito mode", + "browser incognito mode create", + "browser incognito mode enter", + "browser incognito mode launch", + "browser incognito mode open", + "browser incognito mode start", + "browser incognito open", + "browser incognito start", + "browser incognito tab", + "browser incognito tab create", + "browser incognito tab enter", + "browser incognito tab launch", + "browser incognito tab open", + "browser incognito tab start", + "browser incognito window", + "browser incognito window create", + "browser incognito window enter", + "browser incognito window launch", + "browser incognito window open", + "browser incognito window start", + "browser launch incognito", + "browser launch incognito mode", + "browser launch incognito tab", + "browser launch incognito window", + "browser launch private mode", + "browser launch private tab", + "browser launch private window", + "browser open incognito", + "browser open incognito mode", + "browser open incognito tab", + "browser open incognito window", + "browser open private mode", + "browser open private tab", + "browser open private window", + "browser private mode", + "browser private mode create", + "browser private mode enter", + "browser private mode launch", + "browser private mode open", + "browser private mode start", + "browser private tab", + "browser private tab create", + "browser private tab enter", + "browser private tab launch", + "browser private tab open", + "browser private tab start", + "browser private window", + "browser private window create", + "browser private window enter", + "browser private window launch", + "browser private window open", + "browser private window start", + "browser start incognito", + "browser start incognito mode", + "browser start incognito tab", + "browser start incognito window", + "browser start private mode", + "browser start private tab", + "browser start private window", + "chrome create incognito", + "chrome create incognito mode", + "chrome create incognito tab", + "chrome create incognito window", + "chrome create private mode", + "chrome create private tab", + "chrome create private window", + "chrome enter incognito", + "chrome enter incognito mode", + "chrome enter incognito tab", + "chrome enter incognito window", + "chrome enter private mode", + "chrome enter private tab", + "chrome enter private window", + "chrome incognito", + "chrome incognito create", + "chrome incognito enter", + "chrome incognito launch", + "chrome incognito mode", + "chrome incognito mode create", + "chrome incognito mode enter", + "chrome incognito mode launch", + "chrome incognito mode open", + "chrome incognito mode start", + "chrome incognito open", + "chrome incognito start", + "chrome incognito tab", + "chrome incognito tab create", + "chrome incognito tab enter", + "chrome incognito tab launch", + "chrome incognito tab open", + "chrome incognito tab start", + "chrome incognito window", + "chrome incognito window create", + "chrome incognito window enter", + "chrome incognito window launch", + "chrome incognito window open", + "chrome incognito window start", + "chrome launch incognito", + "chrome launch incognito mode", + "chrome launch incognito tab", + "chrome launch incognito window", + "chrome launch private mode", + "chrome launch private tab", + "chrome launch private window", + "chrome open incognito", + "chrome open incognito mode", + "chrome open incognito tab", + "chrome open incognito window", + "chrome open private mode", + "chrome open private tab", + "chrome open private window", + "chrome private mode", + "chrome private mode create", + "chrome private mode enter", + "chrome private mode launch", + "chrome private mode open", + "chrome private mode start", + "chrome private tab", + "chrome private tab create", + "chrome private tab enter", + "chrome private tab launch", + "chrome private tab open", + "chrome private tab start", + "chrome private window", + "chrome private window create", + "chrome private window enter", + "chrome private window launch", + "chrome private window open", + "chrome private window start", + "chrome start incognito", + "chrome start incognito mode", + "chrome start incognito tab", + "chrome start incognito window", + "chrome start private mode", + "chrome start private tab", + "chrome start private window", + "create browser incognito", + "create browser incognito mode", + "create browser incognito tab", + "create browser incognito window", + "create browser private mode", + "create browser private tab", + "create browser private window", + "create chrome incognito", + "create chrome incognito mode", + "create chrome incognito tab", + "create chrome incognito window", + "create chrome private mode", + "create chrome private tab", + "create chrome private window", + "create google chrome incognito", + "create google chrome incognito mode", + "create google chrome incognito tab", + "create google chrome incognito window", + "create google chrome private mode", + "create google chrome private tab", + "create google chrome private window", + "create incognito", + "create incognito browser", + "create incognito chrome", + "create incognito google chrome", + "create incognito mode", + "create incognito mode browser", + "create incognito mode chrome", + "create incognito mode google chrome", + "create incognito tab", + "create incognito tab browser", + "create incognito tab chrome", + "create incognito tab google chrome", + "create incognito window", + "create incognito window browser", + "create incognito window chrome", + "create incognito window google chrome", + "create private mode", + "create private mode browser", + "create private mode chrome", + "create private mode google chrome", + "create private tab", + "create private tab browser", + "create private tab chrome", + "create private tab google chrome", + "create private window", + "create private window browser", + "create private window chrome", + "create private window google chrome", + "enter browser incognito", + "enter browser incognito mode", + "enter browser incognito tab", + "enter browser incognito window", + "enter browser private mode", + "enter browser private tab", + "enter browser private window", + "enter chrome incognito", + "enter chrome incognito mode", + "enter chrome incognito tab", + "enter chrome incognito window", + "enter chrome private mode", + "enter chrome private tab", + "enter chrome private window", + "enter google chrome incognito", + "enter google chrome incognito mode", + "enter google chrome incognito tab", + "enter google chrome incognito window", + "enter google chrome private mode", + "enter google chrome private tab", + "enter google chrome private window", + "enter incognito", + "enter incognito browser", + "enter incognito chrome", + "enter incognito google chrome", + "enter incognito mode", + "enter incognito mode browser", + "enter incognito mode chrome", + "enter incognito mode google chrome", + "enter incognito tab", + "enter incognito tab browser", + "enter incognito tab chrome", + "enter incognito tab google chrome", + "enter incognito window", + "enter incognito window browser", + "enter incognito window chrome", + "enter incognito window google chrome", + "enter private mode", + "enter private mode browser", + "enter private mode chrome", + "enter private mode google chrome", + "enter private tab", + "enter private tab browser", + "enter private tab chrome", + "enter private tab google chrome", + "enter private window", + "enter private window browser", + "enter private window chrome", + "enter private window google chrome", + "google chrome create incognito", + "google chrome create incognito mode", + "google chrome create incognito tab", + "google chrome create incognito window", + "google chrome create private mode", + "google chrome create private tab", + "google chrome create private window", + "google chrome enter incognito", + "google chrome enter incognito mode", + "google chrome enter incognito tab", + "google chrome enter incognito window", + "google chrome enter private mode", + "google chrome enter private tab", + "google chrome enter private window", + "google chrome incognito", + "google chrome incognito create", + "google chrome incognito enter", + "google chrome incognito launch", + "google chrome incognito mode", + "google chrome incognito mode create", + "google chrome incognito mode enter", + "google chrome incognito mode launch", + "google chrome incognito mode open", + "google chrome incognito mode start", + "google chrome incognito open", + "google chrome incognito start", + "google chrome incognito tab", + "google chrome incognito tab create", + "google chrome incognito tab enter", + "google chrome incognito tab launch", + "google chrome incognito tab open", + "google chrome incognito tab start", + "google chrome incognito window", + "google chrome incognito window create", + "google chrome incognito window enter", + "google chrome incognito window launch", + "google chrome incognito window open", + "google chrome incognito window start", + "google chrome launch incognito", + "google chrome launch incognito mode", + "google chrome launch incognito tab", + "google chrome launch incognito window", + "google chrome launch private mode", + "google chrome launch private tab", + "google chrome launch private window", + "google chrome open incognito", + "google chrome open incognito mode", + "google chrome open incognito tab", + "google chrome open incognito window", + "google chrome open private mode", + "google chrome open private tab", + "google chrome open private window", + "google chrome private mode", + "google chrome private mode create", + "google chrome private mode enter", + "google chrome private mode launch", + "google chrome private mode open", + "google chrome private mode start", + "google chrome private tab", + "google chrome private tab create", + "google chrome private tab enter", + "google chrome private tab launch", + "google chrome private tab open", + "google chrome private tab start", + "google chrome private window", + "google chrome private window create", + "google chrome private window enter", + "google chrome private window launch", + "google chrome private window open", + "google chrome private window start", + "google chrome start incognito", + "google chrome start incognito mode", + "google chrome start incognito tab", + "google chrome start incognito window", + "google chrome start private mode", + "google chrome start private tab", + "google chrome start private window", + "incognito", + "incognito browser", + "incognito browser create", + "incognito browser enter", + "incognito browser launch", + "incognito browser open", + "incognito browser start", + "incognito chrome", + "incognito chrome create", + "incognito chrome enter", + "incognito chrome launch", + "incognito chrome open", + "incognito chrome start", + "incognito create", + "incognito create browser", + "incognito create chrome", + "incognito create google chrome", + "incognito enter", + "incognito enter browser", + "incognito enter chrome", + "incognito enter google chrome", + "incognito google chrome", + "incognito google chrome create", + "incognito google chrome enter", + "incognito google chrome launch", + "incognito google chrome open", + "incognito google chrome start", + "incognito launch", + "incognito launch browser", + "incognito launch chrome", + "incognito launch google chrome", + "incognito mode", + "incognito mode browser", + "incognito mode browser create", + "incognito mode browser enter", + "incognito mode browser launch", + "incognito mode browser open", + "incognito mode browser start", + "incognito mode chrome", + "incognito mode chrome create", + "incognito mode chrome enter", + "incognito mode chrome launch", + "incognito mode chrome open", + "incognito mode chrome start", + "incognito mode create", + "incognito mode create browser", + "incognito mode create chrome", + "incognito mode create google chrome", + "incognito mode enter", + "incognito mode enter browser", + "incognito mode enter chrome", + "incognito mode enter google chrome", + "incognito mode google chrome", + "incognito mode google chrome create", + "incognito mode google chrome enter", + "incognito mode google chrome launch", + "incognito mode google chrome open", + "incognito mode google chrome start", + "incognito mode launch", + "incognito mode launch browser", + "incognito mode launch chrome", + "incognito mode launch google chrome", + "incognito mode open", + "incognito mode open browser", + "incognito mode open chrome", + "incognito mode open google chrome", + "incognito mode start", + "incognito mode start browser", + "incognito mode start chrome", + "incognito mode start google chrome", + "incognito open", + "incognito open browser", + "incognito open chrome", + "incognito open google chrome", + "incognito start", + "incognito start browser", + "incognito start chrome", + "incognito start google chrome", + "incognito tab", + "incognito tab browser", + "incognito tab browser create", + "incognito tab browser enter", + "incognito tab browser launch", + "incognito tab browser open", + "incognito tab browser start", + "incognito tab chrome", + "incognito tab chrome create", + "incognito tab chrome enter", + "incognito tab chrome launch", + "incognito tab chrome open", + "incognito tab chrome start", + "incognito tab create", + "incognito tab create browser", + "incognito tab create chrome", + "incognito tab create google chrome", + "incognito tab enter", + "incognito tab enter browser", + "incognito tab enter chrome", + "incognito tab enter google chrome", + "incognito tab google chrome", + "incognito tab google chrome create", + "incognito tab google chrome enter", + "incognito tab google chrome launch", + "incognito tab google chrome open", + "incognito tab google chrome start", + "incognito tab launch", + "incognito tab launch browser", + "incognito tab launch chrome", + "incognito tab launch google chrome", + "incognito tab open", + "incognito tab open browser", + "incognito tab open chrome", + "incognito tab open google chrome", + "incognito tab start", + "incognito tab start browser", + "incognito tab start chrome", + "incognito tab start google chrome", + "incognito window", + "incognito window browser", + "incognito window browser create", + "incognito window browser enter", + "incognito window browser launch", + "incognito window browser open", + "incognito window browser start", + "incognito window chrome", + "incognito window chrome create", + "incognito window chrome enter", + "incognito window chrome launch", + "incognito window chrome open", + "incognito window chrome start", + "incognito window create", + "incognito window create browser", + "incognito window create chrome", + "incognito window create google chrome", + "incognito window enter", + "incognito window enter browser", + "incognito window enter chrome", + "incognito window enter google chrome", + "incognito window google chrome", + "incognito window google chrome create", + "incognito window google chrome enter", + "incognito window google chrome launch", + "incognito window google chrome open", + "incognito window google chrome start", + "incognito window launch", + "incognito window launch browser", + "incognito window launch chrome", + "incognito window launch google chrome", + "incognito window open", + "incognito window open browser", + "incognito window open chrome", + "incognito window open google chrome", + "incognito window start", + "incognito window start browser", + "incognito window start chrome", + "incognito window start google chrome", + "launch browser incognito", + "launch browser incognito mode", + "launch browser incognito tab", + "launch browser incognito window", + "launch browser private mode", + "launch browser private tab", + "launch browser private window", + "launch chrome incognito", + "launch chrome incognito mode", + "launch chrome incognito tab", + "launch chrome incognito window", + "launch chrome private mode", + "launch chrome private tab", + "launch chrome private window", + "launch google chrome incognito", + "launch google chrome incognito mode", + "launch google chrome incognito tab", + "launch google chrome incognito window", + "launch google chrome private mode", + "launch google chrome private tab", + "launch google chrome private window", + "launch incognito", + "launch incognito browser", + "launch incognito chrome", + "launch incognito google chrome", + "launch incognito mode", + "launch incognito mode browser", + "launch incognito mode chrome", + "launch incognito mode google chrome", + "launch incognito tab", + "launch incognito tab browser", + "launch incognito tab chrome", + "launch incognito tab google chrome", + "launch incognito window", + "launch incognito window browser", + "launch incognito window chrome", + "launch incognito window google chrome", + "launch private mode", + "launch private mode browser", + "launch private mode chrome", + "launch private mode google chrome", + "launch private tab", + "launch private tab browser", + "launch private tab chrome", + "launch private tab google chrome", + "launch private window", + "launch private window browser", + "launch private window chrome", + "launch private window google chrome", + "open browser incognito", + "open browser incognito mode", + "open browser incognito tab", + "open browser incognito window", + "open browser private mode", + "open browser private tab", + "open browser private window", + "open chrome incognito", + "open chrome incognito mode", + "open chrome incognito tab", + "open chrome incognito window", + "open chrome private mode", + "open chrome private tab", + "open chrome private window", + "open google chrome incognito", + "open google chrome incognito mode", + "open google chrome incognito tab", + "open google chrome incognito window", + "open google chrome private mode", + "open google chrome private tab", + "open google chrome private window", + "open incognito", + "open incognito browser", + "open incognito chrome", + "open incognito google chrome", + "open incognito mode", + "open incognito mode browser", + "open incognito mode chrome", + "open incognito mode google chrome", + "open incognito tab", + "open incognito tab browser", + "open incognito tab chrome", + "open incognito tab google chrome", + "open incognito window", + "open incognito window browser", + "open incognito window chrome", + "open incognito window google chrome", + "open private mode", + "open private mode browser", + "open private mode chrome", + "open private mode google chrome", + "open private tab", + "open private tab browser", + "open private tab chrome", + "open private tab google chrome", + "open private window", + "open private window browser", + "open private window chrome", + "open private window google chrome", + "private mode", + "private mode browser", + "private mode browser create", + "private mode browser enter", + "private mode browser launch", + "private mode browser open", + "private mode browser start", + "private mode chrome", + "private mode chrome create", + "private mode chrome enter", + "private mode chrome launch", + "private mode chrome open", + "private mode chrome start", + "private mode create", + "private mode create browser", + "private mode create chrome", + "private mode create google chrome", + "private mode enter", + "private mode enter browser", + "private mode enter chrome", + "private mode enter google chrome", + "private mode google chrome", + "private mode google chrome create", + "private mode google chrome enter", + "private mode google chrome launch", + "private mode google chrome open", + "private mode google chrome start", + "private mode launch", + "private mode launch browser", + "private mode launch chrome", + "private mode launch google chrome", + "private mode open", + "private mode open browser", + "private mode open chrome", + "private mode open google chrome", + "private mode start", + "private mode start browser", + "private mode start chrome", + "private mode start google chrome", + "private tab", + "private tab browser", + "private tab browser create", + "private tab browser enter", + "private tab browser launch", + "private tab browser open", + "private tab browser start", + "private tab chrome", + "private tab chrome create", + "private tab chrome enter", + "private tab chrome launch", + "private tab chrome open", + "private tab chrome start", + "private tab create", + "private tab create browser", + "private tab create chrome", + "private tab create google chrome", + "private tab enter", + "private tab enter browser", + "private tab enter chrome", + "private tab enter google chrome", + "private tab google chrome", + "private tab google chrome create", + "private tab google chrome enter", + "private tab google chrome launch", + "private tab google chrome open", + "private tab google chrome start", + "private tab launch", + "private tab launch browser", + "private tab launch chrome", + "private tab launch google chrome", + "private tab open", + "private tab open browser", + "private tab open chrome", + "private tab open google chrome", + "private tab start", + "private tab start browser", + "private tab start chrome", + "private tab start google chrome", + "private window", + "private window browser", + "private window browser create", + "private window browser enter", + "private window browser launch", + "private window browser open", + "private window browser start", + "private window chrome", + "private window chrome create", + "private window chrome enter", + "private window chrome launch", + "private window chrome open", + "private window chrome start", + "private window create", + "private window create browser", + "private window create chrome", + "private window create google chrome", + "private window enter", + "private window enter browser", + "private window enter chrome", + "private window enter google chrome", + "private window google chrome", + "private window google chrome create", + "private window google chrome enter", + "private window google chrome launch", + "private window google chrome open", + "private window google chrome start", + "private window launch", + "private window launch browser", + "private window launch chrome", + "private window launch google chrome", + "private window open", + "private window open browser", + "private window open chrome", + "private window open google chrome", + "private window start", + "private window start browser", + "private window start chrome", + "private window start google chrome", + "start browser incognito", + "start browser incognito mode", + "start browser incognito tab", + "start browser incognito window", + "start browser private mode", + "start browser private tab", + "start browser private window", + "start chrome incognito", + "start chrome incognito mode", + "start chrome incognito tab", + "start chrome incognito window", + "start chrome private mode", + "start chrome private tab", + "start chrome private window", + "start google chrome incognito", + "start google chrome incognito mode", + "start google chrome incognito tab", + "start google chrome incognito window", + "start google chrome private mode", + "start google chrome private tab", + "start google chrome private window", + "start incognito", + "start incognito browser", + "start incognito chrome", + "start incognito google chrome", + "start incognito mode", + "start incognito mode browser", + "start incognito mode chrome", + "start incognito mode google chrome", + "start incognito tab", + "start incognito tab browser", + "start incognito tab chrome", + "start incognito tab google chrome", + "start incognito window", + "start incognito window browser", + "start incognito window chrome", + "start incognito window google chrome", + "start private mode", + "start private mode browser", + "start private mode chrome", + "start private mode google chrome", + "start private tab", + "start private tab browser", + "start private tab chrome", + "start private tab google chrome", + "start private window", + "start private window browser", + "start private window chrome", + "start private window google chrome", + }, + + // ID#5 + { + // Generated suggestions: + "browser change language page", + "browser change language this", + "browser change language this page", + "browser change language web page", + "browser change language webpage", + "browser page change language", + "browser page translate", + "browser this change language", + "browser this page change language", + "browser this page translate", + "browser this translate", + "browser translate page", + "browser translate this", + "browser translate this page", + "browser translate web page", + "browser translate webpage", + "browser web page change language", + "browser web page translate", + "browser webpage change language", + "browser webpage translate", + "change language browser page", + "change language browser this", + "change language browser this page", + "change language browser web page", + "change language browser webpage", + "change language chrome page", + "change language chrome this", + "change language chrome this page", + "change language chrome web page", + "change language chrome webpage", + "change language google chrome page", + "change language google chrome this", + "change language google chrome this page", + "change language google chrome web page", + "change language google chrome webpage", + "change language page", + "change language page browser", + "change language page chrome", + "change language page google chrome", + "change language this", + "change language this browser", + "change language this chrome", + "change language this google chrome", + "change language this page", + "change language this page browser", + "change language this page chrome", + "change language this page google chrome", + "change language web page", + "change language web page browser", + "change language web page chrome", + "change language web page google chrome", + "change language webpage", + "change language webpage browser", + "change language webpage chrome", + "change language webpage google chrome", + "chrome change language page", + "chrome change language this", + "chrome change language this page", + "chrome change language web page", + "chrome change language webpage", + "chrome page change language", + "chrome page translate", + "chrome this change language", + "chrome this page change language", + "chrome this page translate", + "chrome this translate", + "chrome translate page", + "chrome translate this", + "chrome translate this page", + "chrome translate web page", + "chrome translate webpage", + "chrome web page change language", + "chrome web page translate", + "chrome webpage change language", + "chrome webpage translate", + "google chrome change language page", + "google chrome change language this", + "google chrome change language this page", + "google chrome change language web page", + "google chrome change language webpage", + "google chrome page change language", + "google chrome page translate", + "google chrome this change language", + "google chrome this page change language", + "google chrome this page translate", + "google chrome this translate", + "google chrome translate page", + "google chrome translate this", + "google chrome translate this page", + "google chrome translate web page", + "google chrome translate webpage", + "google chrome web page change language", + "google chrome web page translate", + "google chrome webpage change language", + "google chrome webpage translate", + "page browser change language", + "page browser translate", + "page change language", + "page change language browser", + "page change language chrome", + "page change language google chrome", + "page chrome change language", + "page chrome translate", + "page google chrome change language", + "page google chrome translate", + "page translate", + "page translate browser", + "page translate chrome", + "page translate google chrome", + "this browser change language", + "this browser translate", + "this change language", + "this change language browser", + "this change language chrome", + "this change language google chrome", + "this chrome change language", + "this chrome translate", + "this google chrome change language", + "this google chrome translate", + "this page browser change language", + "this page browser translate", + "this page change language", + "this page change language browser", + "this page change language chrome", + "this page change language google chrome", + "this page chrome change language", + "this page chrome translate", + "this page google chrome change language", + "this page google chrome translate", + "this page translate", + "this page translate browser", + "this page translate chrome", + "this page translate google chrome", + "this translate", + "this translate browser", + "this translate chrome", + "this translate google chrome", + "translate browser page", + "translate browser this", + "translate browser this page", + "translate browser web page", + "translate browser webpage", + "translate chrome page", + "translate chrome this", + "translate chrome this page", + "translate chrome web page", + "translate chrome webpage", + "translate google chrome page", + "translate google chrome this", + "translate google chrome this page", + "translate google chrome web page", + "translate google chrome webpage", + "translate page", + "translate page browser", + "translate page chrome", + "translate page google chrome", + "translate this", + "translate this browser", + "translate this chrome", + "translate this google chrome", + "translate this page", + "translate this page browser", + "translate this page chrome", + "translate this page google chrome", + "translate web page", + "translate web page browser", + "translate web page chrome", + "translate web page google chrome", + "translate webpage", + "translate webpage browser", + "translate webpage chrome", + "translate webpage google chrome", + "web page browser change language", + "web page browser translate", + "web page change language", + "web page change language browser", + "web page change language chrome", + "web page change language google chrome", + "web page chrome change language", + "web page chrome translate", + "web page google chrome change language", + "web page google chrome translate", + "web page translate", + "web page translate browser", + "web page translate chrome", + "web page translate google chrome", + "webpage browser change language", + "webpage browser translate", + "webpage change language", + "webpage change language browser", + "webpage change language chrome", + "webpage change language google chrome", + "webpage chrome change language", + "webpage chrome translate", + "webpage google chrome change language", + "webpage google chrome translate", + "webpage translate", + "webpage translate browser", + "webpage translate chrome", + "webpage translate google chrome", + }, + + // ID#6 + { + // Generated suggestions: + "browser install", + "browser update", + "browser updates", + "browser upgrade", + "chrome install", + "chrome update", + "chrome updates", + "chrome upgrade", + "google chrome install", + "google chrome update", + "google chrome updates", + "google chrome upgrade", + "install browser", + "install chrome", + "install google chrome", + "update browser", + "update chrome", + "update google chrome", + "updates browser", + "updates chrome", + "updates google chrome", + "upgrade browser", + "upgrade chrome", + "upgrade google chrome", + }, + + // ID#7 + { + // Generated suggestions: + "activate browser check password", + "activate browser check passwords", + "activate browser check safety", + "activate browser check security", + "activate browser checks password", + "activate browser checks passwords", + "activate browser checks safety", + "activate browser checks security", + "activate browser checkup password", + "activate browser checkup passwords", + "activate browser checkup safety", + "activate browser checkup security", + "activate browser password check", + "activate browser password checks", + "activate browser password checkup", + "activate browser passwords check", + "activate browser passwords checks", + "activate browser passwords checkup", + "activate browser safety check", + "activate browser safety checks", + "activate browser safety checkup", + "activate browser security check", + "activate browser security checks", + "activate browser security checkup", + "activate check browser password", + "activate check browser passwords", + "activate check browser safety", + "activate check browser security", + "activate check chrome password", + "activate check chrome passwords", + "activate check chrome safety", + "activate check chrome security", + "activate check google chrome password", + "activate check google chrome passwords", + "activate check google chrome safety", + "activate check google chrome security", + "activate check google password", + "activate check google passwords", + "activate check google safety", + "activate check google security", + "activate check password", + "activate check password browser", + "activate check password chrome", + "activate check password google", + "activate check password google chrome", + "activate check passwords", + "activate check passwords browser", + "activate check passwords chrome", + "activate check passwords google", + "activate check passwords google chrome", + "activate check safety", + "activate check safety browser", + "activate check safety chrome", + "activate check safety google", + "activate check safety google chrome", + "activate check security", + "activate check security browser", + "activate check security chrome", + "activate check security google", + "activate check security google chrome", + "activate checks browser password", + "activate checks browser passwords", + "activate checks browser safety", + "activate checks browser security", + "activate checks chrome password", + "activate checks chrome passwords", + "activate checks chrome safety", + "activate checks chrome security", + "activate checks google chrome password", + "activate checks google chrome passwords", + "activate checks google chrome safety", + "activate checks google chrome security", + "activate checks google password", + "activate checks google passwords", + "activate checks google safety", + "activate checks google security", + "activate checks password", + "activate checks password browser", + "activate checks password chrome", + "activate checks password google", + "activate checks password google chrome", + "activate checks passwords", + "activate checks passwords browser", + "activate checks passwords chrome", + "activate checks passwords google", + "activate checks passwords google chrome", + "activate checks safety", + "activate checks safety browser", + "activate checks safety chrome", + "activate checks safety google", + "activate checks safety google chrome", + "activate checks security", + "activate checks security browser", + "activate checks security chrome", + "activate checks security google", + "activate checks security google chrome", + "activate checkup browser password", + "activate checkup browser passwords", + "activate checkup browser safety", + "activate checkup browser security", + "activate checkup chrome password", + "activate checkup chrome passwords", + "activate checkup chrome safety", + "activate checkup chrome security", + "activate checkup google chrome password", + "activate checkup google chrome passwords", + "activate checkup google chrome safety", + "activate checkup google chrome security", + "activate checkup google password", + "activate checkup google passwords", + "activate checkup google safety", + "activate checkup google security", + "activate checkup password", + "activate checkup password browser", + "activate checkup password chrome", + "activate checkup password google", + "activate checkup password google chrome", + "activate checkup passwords", + "activate checkup passwords browser", + "activate checkup passwords chrome", + "activate checkup passwords google", + "activate checkup passwords google chrome", + "activate checkup safety", + "activate checkup safety browser", + "activate checkup safety chrome", + "activate checkup safety google", + "activate checkup safety google chrome", + "activate checkup security", + "activate checkup security browser", + "activate checkup security chrome", + "activate checkup security google", + "activate checkup security google chrome", + "activate chrome check password", + "activate chrome check passwords", + "activate chrome check safety", + "activate chrome check security", + "activate chrome checks password", + "activate chrome checks passwords", + "activate chrome checks safety", + "activate chrome checks security", + "activate chrome checkup password", + "activate chrome checkup passwords", + "activate chrome checkup safety", + "activate chrome checkup security", + "activate chrome password check", + "activate chrome password checks", + "activate chrome password checkup", + "activate chrome passwords check", + "activate chrome passwords checks", + "activate chrome passwords checkup", + "activate chrome safety check", + "activate chrome safety checks", + "activate chrome safety checkup", + "activate chrome security check", + "activate chrome security checks", + "activate chrome security checkup", + "activate google check password", + "activate google check passwords", + "activate google check safety", + "activate google check security", + "activate google checks password", + "activate google checks passwords", + "activate google checks safety", + "activate google checks security", + "activate google checkup password", + "activate google checkup passwords", + "activate google checkup safety", + "activate google checkup security", + "activate google chrome check password", + "activate google chrome check passwords", + "activate google chrome check safety", + "activate google chrome check security", + "activate google chrome checks password", + "activate google chrome checks passwords", + "activate google chrome checks safety", + "activate google chrome checks security", + "activate google chrome checkup password", + "activate google chrome checkup passwords", + "activate google chrome checkup safety", + "activate google chrome checkup security", + "activate google chrome password check", + "activate google chrome password checks", + "activate google chrome password checkup", + "activate google chrome passwords check", + "activate google chrome passwords checks", + "activate google chrome passwords checkup", + "activate google chrome safety check", + "activate google chrome safety checks", + "activate google chrome safety checkup", + "activate google chrome security check", + "activate google chrome security checks", + "activate google chrome security checkup", + "activate google password check", + "activate google password checks", + "activate google password checkup", + "activate google passwords check", + "activate google passwords checks", + "activate google passwords checkup", + "activate google safety check", + "activate google safety checks", + "activate google safety checkup", + "activate google security check", + "activate google security checks", + "activate google security checkup", + "activate password browser check", + "activate password browser checks", + "activate password browser checkup", + "activate password check", + "activate password check browser", + "activate password check chrome", + "activate password check google", + "activate password check google chrome", + "activate password checks", + "activate password checks browser", + "activate password checks chrome", + "activate password checks google", + "activate password checks google chrome", + "activate password checkup", + "activate password checkup browser", + "activate password checkup chrome", + "activate password checkup google", + "activate password checkup google chrome", + "activate password chrome check", + "activate password chrome checks", + "activate password chrome checkup", + "activate password google check", + "activate password google checks", + "activate password google checkup", + "activate password google chrome check", + "activate password google chrome checks", + "activate password google chrome checkup", + "activate passwords browser check", + "activate passwords browser checks", + "activate passwords browser checkup", + "activate passwords check", + "activate passwords check browser", + "activate passwords check chrome", + "activate passwords check google", + "activate passwords check google chrome", + "activate passwords checks", + "activate passwords checks browser", + "activate passwords checks chrome", + "activate passwords checks google", + "activate passwords checks google chrome", + "activate passwords checkup", + "activate passwords checkup browser", + "activate passwords checkup chrome", + "activate passwords checkup google", + "activate passwords checkup google chrome", + "activate passwords chrome check", + "activate passwords chrome checks", + "activate passwords chrome checkup", + "activate passwords google check", + "activate passwords google checks", + "activate passwords google checkup", + "activate passwords google chrome check", + "activate passwords google chrome checks", + "activate passwords google chrome checkup", + "activate safety browser check", + "activate safety browser checks", + "activate safety browser checkup", + "activate safety check", + "activate safety check browser", + "activate safety check chrome", + "activate safety check google", + "activate safety check google chrome", + "activate safety checks", + "activate safety checks browser", + "activate safety checks chrome", + "activate safety checks google", + "activate safety checks google chrome", + "activate safety checkup", + "activate safety checkup browser", + "activate safety checkup chrome", + "activate safety checkup google", + "activate safety checkup google chrome", + "activate safety chrome check", + "activate safety chrome checks", + "activate safety chrome checkup", + "activate safety google check", + "activate safety google checks", + "activate safety google checkup", + "activate safety google chrome check", + "activate safety google chrome checks", + "activate safety google chrome checkup", + "activate security browser check", + "activate security browser checks", + "activate security browser checkup", + "activate security check", + "activate security check browser", + "activate security check chrome", + "activate security check google", + "activate security check google chrome", + "activate security checks", + "activate security checks browser", + "activate security checks chrome", + "activate security checks google", + "activate security checks google chrome", + "activate security checkup", + "activate security checkup browser", + "activate security checkup chrome", + "activate security checkup google", + "activate security checkup google chrome", + "activate security chrome check", + "activate security chrome checks", + "activate security chrome checkup", + "activate security google check", + "activate security google checks", + "activate security google checkup", + "activate security google chrome check", + "activate security google chrome checks", + "activate security google chrome checkup", + "browser activate check password", + "browser activate check passwords", + "browser activate check safety", + "browser activate check security", + "browser activate checks password", + "browser activate checks passwords", + "browser activate checks safety", + "browser activate checks security", + "browser activate checkup password", + "browser activate checkup passwords", + "browser activate checkup safety", + "browser activate checkup security", + "browser activate password check", + "browser activate password checks", + "browser activate password checkup", + "browser activate passwords check", + "browser activate passwords checks", + "browser activate passwords checkup", + "browser activate safety check", + "browser activate safety checks", + "browser activate safety checkup", + "browser activate security check", + "browser activate security checks", + "browser activate security checkup", + "browser check activate password", + "browser check activate passwords", + "browser check activate safety", + "browser check activate security", + "browser check password", + "browser check password activate", + "browser check password perform", + "browser check password run", + "browser check password use", + "browser check passwords", + "browser check passwords activate", + "browser check passwords perform", + "browser check passwords run", + "browser check passwords use", + "browser check perform password", + "browser check perform passwords", + "browser check perform safety", + "browser check perform security", + "browser check run password", + "browser check run passwords", + "browser check run safety", + "browser check run security", + "browser check safety", + "browser check safety activate", + "browser check safety perform", + "browser check safety run", + "browser check safety use", + "browser check security", + "browser check security activate", + "browser check security perform", + "browser check security run", + "browser check security use", + "browser check use password", + "browser check use passwords", + "browser check use safety", + "browser check use security", + "browser checks activate password", + "browser checks activate passwords", + "browser checks activate safety", + "browser checks activate security", + "browser checks password", + "browser checks password activate", + "browser checks password perform", + "browser checks password run", + "browser checks password use", + "browser checks passwords", + "browser checks passwords activate", + "browser checks passwords perform", + "browser checks passwords run", + "browser checks passwords use", + "browser checks perform password", + "browser checks perform passwords", + "browser checks perform safety", + "browser checks perform security", + "browser checks run password", + "browser checks run passwords", + "browser checks run safety", + "browser checks run security", + "browser checks safety", + "browser checks safety activate", + "browser checks safety perform", + "browser checks safety run", + "browser checks safety use", + "browser checks security", + "browser checks security activate", + "browser checks security perform", + "browser checks security run", + "browser checks security use", + "browser checks use password", + "browser checks use passwords", + "browser checks use safety", + "browser checks use security", + "browser checkup activate password", + "browser checkup activate passwords", + "browser checkup activate safety", + "browser checkup activate security", + "browser checkup password", + "browser checkup password activate", + "browser checkup password perform", + "browser checkup password run", + "browser checkup password use", + "browser checkup passwords", + "browser checkup passwords activate", + "browser checkup passwords perform", + "browser checkup passwords run", + "browser checkup passwords use", + "browser checkup perform password", + "browser checkup perform passwords", + "browser checkup perform safety", + "browser checkup perform security", + "browser checkup run password", + "browser checkup run passwords", + "browser checkup run safety", + "browser checkup run security", + "browser checkup safety", + "browser checkup safety activate", + "browser checkup safety perform", + "browser checkup safety run", + "browser checkup safety use", + "browser checkup security", + "browser checkup security activate", + "browser checkup security perform", + "browser checkup security run", + "browser checkup security use", + "browser checkup use password", + "browser checkup use passwords", + "browser checkup use safety", + "browser checkup use security", + "browser password activate check", + "browser password activate checks", + "browser password activate checkup", + "browser password check", + "browser password check activate", + "browser password check perform", + "browser password check run", + "browser password check use", + "browser password checks", + "browser password checks activate", + "browser password checks perform", + "browser password checks run", + "browser password checks use", + "browser password checkup", + "browser password checkup activate", + "browser password checkup perform", + "browser password checkup run", + "browser password checkup use", + "browser password perform check", + "browser password perform checks", + "browser password perform checkup", + "browser password run check", + "browser password run checks", + "browser password run checkup", + "browser password use check", + "browser password use checks", + "browser password use checkup", + "browser passwords activate check", + "browser passwords activate checks", + "browser passwords activate checkup", + "browser passwords check", + "browser passwords check activate", + "browser passwords check perform", + "browser passwords check run", + "browser passwords check use", + "browser passwords checks", + "browser passwords checks activate", + "browser passwords checks perform", + "browser passwords checks run", + "browser passwords checks use", + "browser passwords checkup", + "browser passwords checkup activate", + "browser passwords checkup perform", + "browser passwords checkup run", + "browser passwords checkup use", + "browser passwords perform check", + "browser passwords perform checks", + "browser passwords perform checkup", + "browser passwords run check", + "browser passwords run checks", + "browser passwords run checkup", + "browser passwords use check", + "browser passwords use checks", + "browser passwords use checkup", + "browser perform check password", + "browser perform check passwords", + "browser perform check safety", + "browser perform check security", + "browser perform checks password", + "browser perform checks passwords", + "browser perform checks safety", + "browser perform checks security", + "browser perform checkup password", + "browser perform checkup passwords", + "browser perform checkup safety", + "browser perform checkup security", + "browser perform password check", + "browser perform password checks", + "browser perform password checkup", + "browser perform passwords check", + "browser perform passwords checks", + "browser perform passwords checkup", + "browser perform safety check", + "browser perform safety checks", + "browser perform safety checkup", + "browser perform security check", + "browser perform security checks", + "browser perform security checkup", + "browser run check password", + "browser run check passwords", + "browser run check safety", + "browser run check security", + "browser run checks password", + "browser run checks passwords", + "browser run checks safety", + "browser run checks security", + "browser run checkup password", + "browser run checkup passwords", + "browser run checkup safety", + "browser run checkup security", + "browser run password check", + "browser run password checks", + "browser run password checkup", + "browser run passwords check", + "browser run passwords checks", + "browser run passwords checkup", + "browser run safety check", + "browser run safety checks", + "browser run safety checkup", + "browser run security check", + "browser run security checks", + "browser run security checkup", + "browser safety activate check", + "browser safety activate checks", + "browser safety activate checkup", + "browser safety check", + "browser safety check activate", + "browser safety check perform", + "browser safety check run", + "browser safety check use", + "browser safety checks", + "browser safety checks activate", + "browser safety checks perform", + "browser safety checks run", + "browser safety checks use", + "browser safety checkup", + "browser safety checkup activate", + "browser safety checkup perform", + "browser safety checkup run", + "browser safety checkup use", + "browser safety perform check", + "browser safety perform checks", + "browser safety perform checkup", + "browser safety run check", + "browser safety run checks", + "browser safety run checkup", + "browser safety use check", + "browser safety use checks", + "browser safety use checkup", + "browser security activate check", + "browser security activate checks", + "browser security activate checkup", + "browser security check", + "browser security check activate", + "browser security check perform", + "browser security check run", + "browser security check use", + "browser security checks", + "browser security checks activate", + "browser security checks perform", + "browser security checks run", + "browser security checks use", + "browser security checkup", + "browser security checkup activate", + "browser security checkup perform", + "browser security checkup run", + "browser security checkup use", + "browser security perform check", + "browser security perform checks", + "browser security perform checkup", + "browser security run check", + "browser security run checks", + "browser security run checkup", + "browser security use check", + "browser security use checks", + "browser security use checkup", + "browser use check password", + "browser use check passwords", + "browser use check safety", + "browser use check security", + "browser use checks password", + "browser use checks passwords", + "browser use checks safety", + "browser use checks security", + "browser use checkup password", + "browser use checkup passwords", + "browser use checkup safety", + "browser use checkup security", + "browser use password check", + "browser use password checks", + "browser use password checkup", + "browser use passwords check", + "browser use passwords checks", + "browser use passwords checkup", + "browser use safety check", + "browser use safety checks", + "browser use safety checkup", + "browser use security check", + "browser use security checks", + "browser use security checkup", + "check activate browser password", + "check activate browser passwords", + "check activate browser safety", + "check activate browser security", + "check activate chrome password", + "check activate chrome passwords", + "check activate chrome safety", + "check activate chrome security", + "check activate google chrome password", + "check activate google chrome passwords", + "check activate google chrome safety", + "check activate google chrome security", + "check activate google password", + "check activate google passwords", + "check activate google safety", + "check activate google security", + "check activate password", + "check activate password browser", + "check activate password chrome", + "check activate password google", + "check activate password google chrome", + "check activate passwords", + "check activate passwords browser", + "check activate passwords chrome", + "check activate passwords google", + "check activate passwords google chrome", + "check activate safety", + "check activate safety browser", + "check activate safety chrome", + "check activate safety google", + "check activate safety google chrome", + "check activate security", + "check activate security browser", + "check activate security chrome", + "check activate security google", + "check activate security google chrome", + "check browser activate password", + "check browser activate passwords", + "check browser activate safety", + "check browser activate security", + "check browser password", + "check browser password activate", + "check browser password perform", + "check browser password run", + "check browser password use", + "check browser passwords", + "check browser passwords activate", + "check browser passwords perform", + "check browser passwords run", + "check browser passwords use", + "check browser perform password", + "check browser perform passwords", + "check browser perform safety", + "check browser perform security", + "check browser run password", + "check browser run passwords", + "check browser run safety", + "check browser run security", + "check browser safety", + "check browser safety activate", + "check browser safety perform", + "check browser safety run", + "check browser safety use", + "check browser security", + "check browser security activate", + "check browser security perform", + "check browser security run", + "check browser security use", + "check browser use password", + "check browser use passwords", + "check browser use safety", + "check browser use security", + "check chrome activate password", + "check chrome activate passwords", + "check chrome activate safety", + "check chrome activate security", + "check chrome password", + "check chrome password activate", + "check chrome password perform", + "check chrome password run", + "check chrome password use", + "check chrome passwords", + "check chrome passwords activate", + "check chrome passwords perform", + "check chrome passwords run", + "check chrome passwords use", + "check chrome perform password", + "check chrome perform passwords", + "check chrome perform safety", + "check chrome perform security", + "check chrome run password", + "check chrome run passwords", + "check chrome run safety", + "check chrome run security", + "check chrome safety", + "check chrome safety activate", + "check chrome safety perform", + "check chrome safety run", + "check chrome safety use", + "check chrome security", + "check chrome security activate", + "check chrome security perform", + "check chrome security run", + "check chrome security use", + "check chrome use password", + "check chrome use passwords", + "check chrome use safety", + "check chrome use security", + "check google activate password", + "check google activate passwords", + "check google activate safety", + "check google activate security", + "check google chrome activate password", + "check google chrome activate passwords", + "check google chrome activate safety", + "check google chrome activate security", + "check google chrome password", + "check google chrome password activate", + "check google chrome password perform", + "check google chrome password run", + "check google chrome password use", + "check google chrome passwords", + "check google chrome passwords activate", + "check google chrome passwords perform", + "check google chrome passwords run", + "check google chrome passwords use", + "check google chrome perform password", + "check google chrome perform passwords", + "check google chrome perform safety", + "check google chrome perform security", + "check google chrome run password", + "check google chrome run passwords", + "check google chrome run safety", + "check google chrome run security", + "check google chrome safety", + "check google chrome safety activate", + "check google chrome safety perform", + "check google chrome safety run", + "check google chrome safety use", + "check google chrome security", + "check google chrome security activate", + "check google chrome security perform", + "check google chrome security run", + "check google chrome security use", + "check google chrome use password", + "check google chrome use passwords", + "check google chrome use safety", + "check google chrome use security", + "check google password", + "check google password activate", + "check google password perform", + "check google password run", + "check google password use", + "check google passwords", + "check google passwords activate", + "check google passwords perform", + "check google passwords run", + "check google passwords use", + "check google perform password", + "check google perform passwords", + "check google perform safety", + "check google perform security", + "check google run password", + "check google run passwords", + "check google run safety", + "check google run security", + "check google safety", + "check google safety activate", + "check google safety perform", + "check google safety run", + "check google safety use", + "check google security", + "check google security activate", + "check google security perform", + "check google security run", + "check google security use", + "check google use password", + "check google use passwords", + "check google use safety", + "check google use security", + "check password", + "check password activate", + "check password activate browser", + "check password activate chrome", + "check password activate google", + "check password activate google chrome", + "check password browser", + "check password browser activate", + "check password browser perform", + "check password browser run", + "check password browser use", + "check password chrome", + "check password chrome activate", + "check password chrome perform", + "check password chrome run", + "check password chrome use", + "check password google", + "check password google activate", + "check password google chrome", + "check password google chrome activate", + "check password google chrome perform", + "check password google chrome run", + "check password google chrome use", + "check password google perform", + "check password google run", + "check password google use", + "check password perform", + "check password perform browser", + "check password perform chrome", + "check password perform google", + "check password perform google chrome", + "check password run", + "check password run browser", + "check password run chrome", + "check password run google", + "check password run google chrome", + "check password use", + "check password use browser", + "check password use chrome", + "check password use google", + "check password use google chrome", + "check passwords", + "check passwords activate", + "check passwords activate browser", + "check passwords activate chrome", + "check passwords activate google", + "check passwords activate google chrome", + "check passwords browser", + "check passwords browser activate", + "check passwords browser perform", + "check passwords browser run", + "check passwords browser use", + "check passwords chrome", + "check passwords chrome activate", + "check passwords chrome perform", + "check passwords chrome run", + "check passwords chrome use", + "check passwords google", + "check passwords google activate", + "check passwords google chrome", + "check passwords google chrome activate", + "check passwords google chrome perform", + "check passwords google chrome run", + "check passwords google chrome use", + "check passwords google perform", + "check passwords google run", + "check passwords google use", + "check passwords perform", + "check passwords perform browser", + "check passwords perform chrome", + "check passwords perform google", + "check passwords perform google chrome", + "check passwords run", + "check passwords run browser", + "check passwords run chrome", + "check passwords run google", + "check passwords run google chrome", + "check passwords use", + "check passwords use browser", + "check passwords use chrome", + "check passwords use google", + "check passwords use google chrome", + "check perform browser password", + "check perform browser passwords", + "check perform browser safety", + "check perform browser security", + "check perform chrome password", + "check perform chrome passwords", + "check perform chrome safety", + "check perform chrome security", + "check perform google chrome password", + "check perform google chrome passwords", + "check perform google chrome safety", + "check perform google chrome security", + "check perform google password", + "check perform google passwords", + "check perform google safety", + "check perform google security", + "check perform password", + "check perform password browser", + "check perform password chrome", + "check perform password google", + "check perform password google chrome", + "check perform passwords", + "check perform passwords browser", + "check perform passwords chrome", + "check perform passwords google", + "check perform passwords google chrome", + "check perform safety", + "check perform safety browser", + "check perform safety chrome", + "check perform safety google", + "check perform safety google chrome", + "check perform security", + "check perform security browser", + "check perform security chrome", + "check perform security google", + "check perform security google chrome", + "check run browser password", + "check run browser passwords", + "check run browser safety", + "check run browser security", + "check run chrome password", + "check run chrome passwords", + "check run chrome safety", + "check run chrome security", + "check run google chrome password", + "check run google chrome passwords", + "check run google chrome safety", + "check run google chrome security", + "check run google password", + "check run google passwords", + "check run google safety", + "check run google security", + "check run password", + "check run password browser", + "check run password chrome", + "check run password google", + "check run password google chrome", + "check run passwords", + "check run passwords browser", + "check run passwords chrome", + "check run passwords google", + "check run passwords google chrome", + "check run safety", + "check run safety browser", + "check run safety chrome", + "check run safety google", + "check run safety google chrome", + "check run security", + "check run security browser", + "check run security chrome", + "check run security google", + "check run security google chrome", + "check safety", + "check safety activate", + "check safety activate browser", + "check safety activate chrome", + "check safety activate google", + "check safety activate google chrome", + "check safety browser", + "check safety browser activate", + "check safety browser perform", + "check safety browser run", + "check safety browser use", + "check safety chrome", + "check safety chrome activate", + "check safety chrome perform", + "check safety chrome run", + "check safety chrome use", + "check safety google", + "check safety google activate", + "check safety google chrome", + "check safety google chrome activate", + "check safety google chrome perform", + "check safety google chrome run", + "check safety google chrome use", + "check safety google perform", + "check safety google run", + "check safety google use", + "check safety perform", + "check safety perform browser", + "check safety perform chrome", + "check safety perform google", + "check safety perform google chrome", + "check safety run", + "check safety run browser", + "check safety run chrome", + "check safety run google", + "check safety run google chrome", + "check safety use", + "check safety use browser", + "check safety use chrome", + "check safety use google", + "check safety use google chrome", + "check security", + "check security activate", + "check security activate browser", + "check security activate chrome", + "check security activate google", + "check security activate google chrome", + "check security browser", + "check security browser activate", + "check security browser perform", + "check security browser run", + "check security browser use", + "check security chrome", + "check security chrome activate", + "check security chrome perform", + "check security chrome run", + "check security chrome use", + "check security google", + "check security google activate", + "check security google chrome", + "check security google chrome activate", + "check security google chrome perform", + "check security google chrome run", + "check security google chrome use", + "check security google perform", + "check security google run", + "check security google use", + "check security perform", + "check security perform browser", + "check security perform chrome", + "check security perform google", + "check security perform google chrome", + "check security run", + "check security run browser", + "check security run chrome", + "check security run google", + "check security run google chrome", + "check security use", + "check security use browser", + "check security use chrome", + "check security use google", + "check security use google chrome", + "check use browser password", + "check use browser passwords", + "check use browser safety", + "check use browser security", + "check use chrome password", + "check use chrome passwords", + "check use chrome safety", + "check use chrome security", + "check use google chrome password", + "check use google chrome passwords", + "check use google chrome safety", + "check use google chrome security", + "check use google password", + "check use google passwords", + "check use google safety", + "check use google security", + "check use password", + "check use password browser", + "check use password chrome", + "check use password google", + "check use password google chrome", + "check use passwords", + "check use passwords browser", + "check use passwords chrome", + "check use passwords google", + "check use passwords google chrome", + "check use safety", + "check use safety browser", + "check use safety chrome", + "check use safety google", + "check use safety google chrome", + "check use security", + "check use security browser", + "check use security chrome", + "check use security google", + "check use security google chrome", + "checks activate browser password", + "checks activate browser passwords", + "checks activate browser safety", + "checks activate browser security", + "checks activate chrome password", + "checks activate chrome passwords", + "checks activate chrome safety", + "checks activate chrome security", + "checks activate google chrome password", + "checks activate google chrome passwords", + "checks activate google chrome safety", + "checks activate google chrome security", + "checks activate google password", + "checks activate google passwords", + "checks activate google safety", + "checks activate google security", + "checks activate password", + "checks activate password browser", + "checks activate password chrome", + "checks activate password google", + "checks activate password google chrome", + "checks activate passwords", + "checks activate passwords browser", + "checks activate passwords chrome", + "checks activate passwords google", + "checks activate passwords google chrome", + "checks activate safety", + "checks activate safety browser", + "checks activate safety chrome", + "checks activate safety google", + "checks activate safety google chrome", + "checks activate security", + "checks activate security browser", + "checks activate security chrome", + "checks activate security google", + "checks activate security google chrome", + "checks browser activate password", + "checks browser activate passwords", + "checks browser activate safety", + "checks browser activate security", + "checks browser password", + "checks browser password activate", + "checks browser password perform", + "checks browser password run", + "checks browser password use", + "checks browser passwords", + "checks browser passwords activate", + "checks browser passwords perform", + "checks browser passwords run", + "checks browser passwords use", + "checks browser perform password", + "checks browser perform passwords", + "checks browser perform safety", + "checks browser perform security", + "checks browser run password", + "checks browser run passwords", + "checks browser run safety", + "checks browser run security", + "checks browser safety", + "checks browser safety activate", + "checks browser safety perform", + "checks browser safety run", + "checks browser safety use", + "checks browser security", + "checks browser security activate", + "checks browser security perform", + "checks browser security run", + "checks browser security use", + "checks browser use password", + "checks browser use passwords", + "checks browser use safety", + "checks browser use security", + "checks chrome activate password", + "checks chrome activate passwords", + "checks chrome activate safety", + "checks chrome activate security", + "checks chrome password", + "checks chrome password activate", + "checks chrome password perform", + "checks chrome password run", + "checks chrome password use", + "checks chrome passwords", + "checks chrome passwords activate", + "checks chrome passwords perform", + "checks chrome passwords run", + "checks chrome passwords use", + "checks chrome perform password", + "checks chrome perform passwords", + "checks chrome perform safety", + "checks chrome perform security", + "checks chrome run password", + "checks chrome run passwords", + "checks chrome run safety", + "checks chrome run security", + "checks chrome safety", + "checks chrome safety activate", + "checks chrome safety perform", + "checks chrome safety run", + "checks chrome safety use", + "checks chrome security", + "checks chrome security activate", + "checks chrome security perform", + "checks chrome security run", + "checks chrome security use", + "checks chrome use password", + "checks chrome use passwords", + "checks chrome use safety", + "checks chrome use security", + "checks google activate password", + "checks google activate passwords", + "checks google activate safety", + "checks google activate security", + "checks google chrome activate password", + "checks google chrome activate passwords", + "checks google chrome activate safety", + "checks google chrome activate security", + "checks google chrome password", + "checks google chrome password activate", + "checks google chrome password perform", + "checks google chrome password run", + "checks google chrome password use", + "checks google chrome passwords", + "checks google chrome passwords activate", + "checks google chrome passwords perform", + "checks google chrome passwords run", + "checks google chrome passwords use", + "checks google chrome perform password", + "checks google chrome perform passwords", + "checks google chrome perform safety", + "checks google chrome perform security", + "checks google chrome run password", + "checks google chrome run passwords", + "checks google chrome run safety", + "checks google chrome run security", + "checks google chrome safety", + "checks google chrome safety activate", + "checks google chrome safety perform", + "checks google chrome safety run", + "checks google chrome safety use", + "checks google chrome security", + "checks google chrome security activate", + "checks google chrome security perform", + "checks google chrome security run", + "checks google chrome security use", + "checks google chrome use password", + "checks google chrome use passwords", + "checks google chrome use safety", + "checks google chrome use security", + "checks google password", + "checks google password activate", + "checks google password perform", + "checks google password run", + "checks google password use", + "checks google passwords", + "checks google passwords activate", + "checks google passwords perform", + "checks google passwords run", + "checks google passwords use", + "checks google perform password", + "checks google perform passwords", + "checks google perform safety", + "checks google perform security", + "checks google run password", + "checks google run passwords", + "checks google run safety", + "checks google run security", + "checks google safety", + "checks google safety activate", + "checks google safety perform", + "checks google safety run", + "checks google safety use", + "checks google security", + "checks google security activate", + "checks google security perform", + "checks google security run", + "checks google security use", + "checks google use password", + "checks google use passwords", + "checks google use safety", + "checks google use security", + "checks password", + "checks password activate", + "checks password activate browser", + "checks password activate chrome", + "checks password activate google", + "checks password activate google chrome", + "checks password browser", + "checks password browser activate", + "checks password browser perform", + "checks password browser run", + "checks password browser use", + "checks password chrome", + "checks password chrome activate", + "checks password chrome perform", + "checks password chrome run", + "checks password chrome use", + "checks password google", + "checks password google activate", + "checks password google chrome", + "checks password google chrome activate", + "checks password google chrome perform", + "checks password google chrome run", + "checks password google chrome use", + "checks password google perform", + "checks password google run", + "checks password google use", + "checks password perform", + "checks password perform browser", + "checks password perform chrome", + "checks password perform google", + "checks password perform google chrome", + "checks password run", + "checks password run browser", + "checks password run chrome", + "checks password run google", + "checks password run google chrome", + "checks password use", + "checks password use browser", + "checks password use chrome", + "checks password use google", + "checks password use google chrome", + "checks passwords", + "checks passwords activate", + "checks passwords activate browser", + "checks passwords activate chrome", + "checks passwords activate google", + "checks passwords activate google chrome", + "checks passwords browser", + "checks passwords browser activate", + "checks passwords browser perform", + "checks passwords browser run", + "checks passwords browser use", + "checks passwords chrome", + "checks passwords chrome activate", + "checks passwords chrome perform", + "checks passwords chrome run", + "checks passwords chrome use", + "checks passwords google", + "checks passwords google activate", + "checks passwords google chrome", + "checks passwords google chrome activate", + "checks passwords google chrome perform", + "checks passwords google chrome run", + "checks passwords google chrome use", + "checks passwords google perform", + "checks passwords google run", + "checks passwords google use", + "checks passwords perform", + "checks passwords perform browser", + "checks passwords perform chrome", + "checks passwords perform google", + "checks passwords perform google chrome", + "checks passwords run", + "checks passwords run browser", + "checks passwords run chrome", + "checks passwords run google", + "checks passwords run google chrome", + "checks passwords use", + "checks passwords use browser", + "checks passwords use chrome", + "checks passwords use google", + "checks passwords use google chrome", + "checks perform browser password", + "checks perform browser passwords", + "checks perform browser safety", + "checks perform browser security", + "checks perform chrome password", + "checks perform chrome passwords", + "checks perform chrome safety", + "checks perform chrome security", + "checks perform google chrome password", + "checks perform google chrome passwords", + "checks perform google chrome safety", + "checks perform google chrome security", + "checks perform google password", + "checks perform google passwords", + "checks perform google safety", + "checks perform google security", + "checks perform password", + "checks perform password browser", + "checks perform password chrome", + "checks perform password google", + "checks perform password google chrome", + "checks perform passwords", + "checks perform passwords browser", + "checks perform passwords chrome", + "checks perform passwords google", + "checks perform passwords google chrome", + "checks perform safety", + "checks perform safety browser", + "checks perform safety chrome", + "checks perform safety google", + "checks perform safety google chrome", + "checks perform security", + "checks perform security browser", + "checks perform security chrome", + "checks perform security google", + "checks perform security google chrome", + "checks run browser password", + "checks run browser passwords", + "checks run browser safety", + "checks run browser security", + "checks run chrome password", + "checks run chrome passwords", + "checks run chrome safety", + "checks run chrome security", + "checks run google chrome password", + "checks run google chrome passwords", + "checks run google chrome safety", + "checks run google chrome security", + "checks run google password", + "checks run google passwords", + "checks run google safety", + "checks run google security", + "checks run password", + "checks run password browser", + "checks run password chrome", + "checks run password google", + "checks run password google chrome", + "checks run passwords", + "checks run passwords browser", + "checks run passwords chrome", + "checks run passwords google", + "checks run passwords google chrome", + "checks run safety", + "checks run safety browser", + "checks run safety chrome", + "checks run safety google", + "checks run safety google chrome", + "checks run security", + "checks run security browser", + "checks run security chrome", + "checks run security google", + "checks run security google chrome", + "checks safety", + "checks safety activate", + "checks safety activate browser", + "checks safety activate chrome", + "checks safety activate google", + "checks safety activate google chrome", + "checks safety browser", + "checks safety browser activate", + "checks safety browser perform", + "checks safety browser run", + "checks safety browser use", + "checks safety chrome", + "checks safety chrome activate", + "checks safety chrome perform", + "checks safety chrome run", + "checks safety chrome use", + "checks safety google", + "checks safety google activate", + "checks safety google chrome", + "checks safety google chrome activate", + "checks safety google chrome perform", + "checks safety google chrome run", + "checks safety google chrome use", + "checks safety google perform", + "checks safety google run", + "checks safety google use", + "checks safety perform", + "checks safety perform browser", + "checks safety perform chrome", + "checks safety perform google", + "checks safety perform google chrome", + "checks safety run", + "checks safety run browser", + "checks safety run chrome", + "checks safety run google", + "checks safety run google chrome", + "checks safety use", + "checks safety use browser", + "checks safety use chrome", + "checks safety use google", + "checks safety use google chrome", + "checks security", + "checks security activate", + "checks security activate browser", + "checks security activate chrome", + "checks security activate google", + "checks security activate google chrome", + "checks security browser", + "checks security browser activate", + "checks security browser perform", + "checks security browser run", + "checks security browser use", + "checks security chrome", + "checks security chrome activate", + "checks security chrome perform", + "checks security chrome run", + "checks security chrome use", + "checks security google", + "checks security google activate", + "checks security google chrome", + "checks security google chrome activate", + "checks security google chrome perform", + "checks security google chrome run", + "checks security google chrome use", + "checks security google perform", + "checks security google run", + "checks security google use", + "checks security perform", + "checks security perform browser", + "checks security perform chrome", + "checks security perform google", + "checks security perform google chrome", + "checks security run", + "checks security run browser", + "checks security run chrome", + "checks security run google", + "checks security run google chrome", + "checks security use", + "checks security use browser", + "checks security use chrome", + "checks security use google", + "checks security use google chrome", + "checks use browser password", + "checks use browser passwords", + "checks use browser safety", + "checks use browser security", + "checks use chrome password", + "checks use chrome passwords", + "checks use chrome safety", + "checks use chrome security", + "checks use google chrome password", + "checks use google chrome passwords", + "checks use google chrome safety", + "checks use google chrome security", + "checks use google password", + "checks use google passwords", + "checks use google safety", + "checks use google security", + "checks use password", + "checks use password browser", + "checks use password chrome", + "checks use password google", + "checks use password google chrome", + "checks use passwords", + "checks use passwords browser", + "checks use passwords chrome", + "checks use passwords google", + "checks use passwords google chrome", + "checks use safety", + "checks use safety browser", + "checks use safety chrome", + "checks use safety google", + "checks use safety google chrome", + "checks use security", + "checks use security browser", + "checks use security chrome", + "checks use security google", + "checks use security google chrome", + "checkup activate browser password", + "checkup activate browser passwords", + "checkup activate browser safety", + "checkup activate browser security", + "checkup activate chrome password", + "checkup activate chrome passwords", + "checkup activate chrome safety", + "checkup activate chrome security", + "checkup activate google chrome password", + "checkup activate google chrome passwords", + "checkup activate google chrome safety", + "checkup activate google chrome security", + "checkup activate google password", + "checkup activate google passwords", + "checkup activate google safety", + "checkup activate google security", + "checkup activate password", + "checkup activate password browser", + "checkup activate password chrome", + "checkup activate password google", + "checkup activate password google chrome", + "checkup activate passwords", + "checkup activate passwords browser", + "checkup activate passwords chrome", + "checkup activate passwords google", + "checkup activate passwords google chrome", + "checkup activate safety", + "checkup activate safety browser", + "checkup activate safety chrome", + "checkup activate safety google", + "checkup activate safety google chrome", + "checkup activate security", + "checkup activate security browser", + "checkup activate security chrome", + "checkup activate security google", + "checkup activate security google chrome", + "checkup browser activate password", + "checkup browser activate passwords", + "checkup browser activate safety", + "checkup browser activate security", + "checkup browser password", + "checkup browser password activate", + "checkup browser password perform", + "checkup browser password run", + "checkup browser password use", + "checkup browser passwords", + "checkup browser passwords activate", + "checkup browser passwords perform", + "checkup browser passwords run", + "checkup browser passwords use", + "checkup browser perform password", + "checkup browser perform passwords", + "checkup browser perform safety", + "checkup browser perform security", + "checkup browser run password", + "checkup browser run passwords", + "checkup browser run safety", + "checkup browser run security", + "checkup browser safety", + "checkup browser safety activate", + "checkup browser safety perform", + "checkup browser safety run", + "checkup browser safety use", + "checkup browser security", + "checkup browser security activate", + "checkup browser security perform", + "checkup browser security run", + "checkup browser security use", + "checkup browser use password", + "checkup browser use passwords", + "checkup browser use safety", + "checkup browser use security", + "checkup chrome activate password", + "checkup chrome activate passwords", + "checkup chrome activate safety", + "checkup chrome activate security", + "checkup chrome password", + "checkup chrome password activate", + "checkup chrome password perform", + "checkup chrome password run", + "checkup chrome password use", + "checkup chrome passwords", + "checkup chrome passwords activate", + "checkup chrome passwords perform", + "checkup chrome passwords run", + "checkup chrome passwords use", + "checkup chrome perform password", + "checkup chrome perform passwords", + "checkup chrome perform safety", + "checkup chrome perform security", + "checkup chrome run password", + "checkup chrome run passwords", + "checkup chrome run safety", + "checkup chrome run security", + "checkup chrome safety", + "checkup chrome safety activate", + "checkup chrome safety perform", + "checkup chrome safety run", + "checkup chrome safety use", + "checkup chrome security", + "checkup chrome security activate", + "checkup chrome security perform", + "checkup chrome security run", + "checkup chrome security use", + "checkup chrome use password", + "checkup chrome use passwords", + "checkup chrome use safety", + "checkup chrome use security", + "checkup google activate password", + "checkup google activate passwords", + "checkup google activate safety", + "checkup google activate security", + "checkup google chrome activate password", + "checkup google chrome activate passwords", + "checkup google chrome activate safety", + "checkup google chrome activate security", + "checkup google chrome password", + "checkup google chrome password activate", + "checkup google chrome password perform", + "checkup google chrome password run", + "checkup google chrome password use", + "checkup google chrome passwords", + "checkup google chrome passwords activate", + "checkup google chrome passwords perform", + "checkup google chrome passwords run", + "checkup google chrome passwords use", + "checkup google chrome perform password", + "checkup google chrome perform passwords", + "checkup google chrome perform safety", + "checkup google chrome perform security", + "checkup google chrome run password", + "checkup google chrome run passwords", + "checkup google chrome run safety", + "checkup google chrome run security", + "checkup google chrome safety", + "checkup google chrome safety activate", + "checkup google chrome safety perform", + "checkup google chrome safety run", + "checkup google chrome safety use", + "checkup google chrome security", + "checkup google chrome security activate", + "checkup google chrome security perform", + "checkup google chrome security run", + "checkup google chrome security use", + "checkup google chrome use password", + "checkup google chrome use passwords", + "checkup google chrome use safety", + "checkup google chrome use security", + "checkup google password", + "checkup google password activate", + "checkup google password perform", + "checkup google password run", + "checkup google password use", + "checkup google passwords", + "checkup google passwords activate", + "checkup google passwords perform", + "checkup google passwords run", + "checkup google passwords use", + "checkup google perform password", + "checkup google perform passwords", + "checkup google perform safety", + "checkup google perform security", + "checkup google run password", + "checkup google run passwords", + "checkup google run safety", + "checkup google run security", + "checkup google safety", + "checkup google safety activate", + "checkup google safety perform", + "checkup google safety run", + "checkup google safety use", + "checkup google security", + "checkup google security activate", + "checkup google security perform", + "checkup google security run", + "checkup google security use", + "checkup google use password", + "checkup google use passwords", + "checkup google use safety", + "checkup google use security", + "checkup password", + "checkup password activate", + "checkup password activate browser", + "checkup password activate chrome", + "checkup password activate google", + "checkup password activate google chrome", + "checkup password browser", + "checkup password browser activate", + "checkup password browser perform", + "checkup password browser run", + "checkup password browser use", + "checkup password chrome", + "checkup password chrome activate", + "checkup password chrome perform", + "checkup password chrome run", + "checkup password chrome use", + "checkup password google", + "checkup password google activate", + "checkup password google chrome", + "checkup password google chrome activate", + "checkup password google chrome perform", + "checkup password google chrome run", + "checkup password google chrome use", + "checkup password google perform", + "checkup password google run", + "checkup password google use", + "checkup password perform", + "checkup password perform browser", + "checkup password perform chrome", + "checkup password perform google", + "checkup password perform google chrome", + "checkup password run", + "checkup password run browser", + "checkup password run chrome", + "checkup password run google", + "checkup password run google chrome", + "checkup password use", + "checkup password use browser", + "checkup password use chrome", + "checkup password use google", + "checkup password use google chrome", + "checkup passwords", + "checkup passwords activate", + "checkup passwords activate browser", + "checkup passwords activate chrome", + "checkup passwords activate google", + "checkup passwords activate google chrome", + "checkup passwords browser", + "checkup passwords browser activate", + "checkup passwords browser perform", + "checkup passwords browser run", + "checkup passwords browser use", + "checkup passwords chrome", + "checkup passwords chrome activate", + "checkup passwords chrome perform", + "checkup passwords chrome run", + "checkup passwords chrome use", + "checkup passwords google", + "checkup passwords google activate", + "checkup passwords google chrome", + "checkup passwords google chrome activate", + "checkup passwords google chrome perform", + "checkup passwords google chrome run", + "checkup passwords google chrome use", + "checkup passwords google perform", + "checkup passwords google run", + "checkup passwords google use", + "checkup passwords perform", + "checkup passwords perform browser", + "checkup passwords perform chrome", + "checkup passwords perform google", + "checkup passwords perform google chrome", + "checkup passwords run", + "checkup passwords run browser", + "checkup passwords run chrome", + "checkup passwords run google", + "checkup passwords run google chrome", + "checkup passwords use", + "checkup passwords use browser", + "checkup passwords use chrome", + "checkup passwords use google", + "checkup passwords use google chrome", + "checkup perform browser password", + "checkup perform browser passwords", + "checkup perform browser safety", + "checkup perform browser security", + "checkup perform chrome password", + "checkup perform chrome passwords", + "checkup perform chrome safety", + "checkup perform chrome security", + "checkup perform google chrome password", + "checkup perform google chrome passwords", + "checkup perform google chrome safety", + "checkup perform google chrome security", + "checkup perform google password", + "checkup perform google passwords", + "checkup perform google safety", + "checkup perform google security", + "checkup perform password", + "checkup perform password browser", + "checkup perform password chrome", + "checkup perform password google", + "checkup perform password google chrome", + "checkup perform passwords", + "checkup perform passwords browser", + "checkup perform passwords chrome", + "checkup perform passwords google", + "checkup perform passwords google chrome", + "checkup perform safety", + "checkup perform safety browser", + "checkup perform safety chrome", + "checkup perform safety google", + "checkup perform safety google chrome", + "checkup perform security", + "checkup perform security browser", + "checkup perform security chrome", + "checkup perform security google", + "checkup perform security google chrome", + "checkup run browser password", + "checkup run browser passwords", + "checkup run browser safety", + "checkup run browser security", + "checkup run chrome password", + "checkup run chrome passwords", + "checkup run chrome safety", + "checkup run chrome security", + "checkup run google chrome password", + "checkup run google chrome passwords", + "checkup run google chrome safety", + "checkup run google chrome security", + "checkup run google password", + "checkup run google passwords", + "checkup run google safety", + "checkup run google security", + "checkup run password", + "checkup run password browser", + "checkup run password chrome", + "checkup run password google", + "checkup run password google chrome", + "checkup run passwords", + "checkup run passwords browser", + "checkup run passwords chrome", + "checkup run passwords google", + "checkup run passwords google chrome", + "checkup run safety", + "checkup run safety browser", + "checkup run safety chrome", + "checkup run safety google", + "checkup run safety google chrome", + "checkup run security", + "checkup run security browser", + "checkup run security chrome", + "checkup run security google", + "checkup run security google chrome", + "checkup safety", + "checkup safety activate", + "checkup safety activate browser", + "checkup safety activate chrome", + "checkup safety activate google", + "checkup safety activate google chrome", + "checkup safety browser", + "checkup safety browser activate", + "checkup safety browser perform", + "checkup safety browser run", + "checkup safety browser use", + "checkup safety chrome", + "checkup safety chrome activate", + "checkup safety chrome perform", + "checkup safety chrome run", + "checkup safety chrome use", + "checkup safety google", + "checkup safety google activate", + "checkup safety google chrome", + "checkup safety google chrome activate", + "checkup safety google chrome perform", + "checkup safety google chrome run", + "checkup safety google chrome use", + "checkup safety google perform", + "checkup safety google run", + "checkup safety google use", + "checkup safety perform", + "checkup safety perform browser", + "checkup safety perform chrome", + "checkup safety perform google", + "checkup safety perform google chrome", + "checkup safety run", + "checkup safety run browser", + "checkup safety run chrome", + "checkup safety run google", + "checkup safety run google chrome", + "checkup safety use", + "checkup safety use browser", + "checkup safety use chrome", + "checkup safety use google", + "checkup safety use google chrome", + "checkup security", + "checkup security activate", + "checkup security activate browser", + "checkup security activate chrome", + "checkup security activate google", + "checkup security activate google chrome", + "checkup security browser", + "checkup security browser activate", + "checkup security browser perform", + "checkup security browser run", + "checkup security browser use", + "checkup security chrome", + "checkup security chrome activate", + "checkup security chrome perform", + "checkup security chrome run", + "checkup security chrome use", + "checkup security google", + "checkup security google activate", + "checkup security google chrome", + "checkup security google chrome activate", + "checkup security google chrome perform", + "checkup security google chrome run", + "checkup security google chrome use", + "checkup security google perform", + "checkup security google run", + "checkup security google use", + "checkup security perform", + "checkup security perform browser", + "checkup security perform chrome", + "checkup security perform google", + "checkup security perform google chrome", + "checkup security run", + "checkup security run browser", + "checkup security run chrome", + "checkup security run google", + "checkup security run google chrome", + "checkup security use", + "checkup security use browser", + "checkup security use chrome", + "checkup security use google", + "checkup security use google chrome", + "checkup use browser password", + "checkup use browser passwords", + "checkup use browser safety", + "checkup use browser security", + "checkup use chrome password", + "checkup use chrome passwords", + "checkup use chrome safety", + "checkup use chrome security", + "checkup use google chrome password", + "checkup use google chrome passwords", + "checkup use google chrome safety", + "checkup use google chrome security", + "checkup use google password", + "checkup use google passwords", + "checkup use google safety", + "checkup use google security", + "checkup use password", + "checkup use password browser", + "checkup use password chrome", + "checkup use password google", + "checkup use password google chrome", + "checkup use passwords", + "checkup use passwords browser", + "checkup use passwords chrome", + "checkup use passwords google", + "checkup use passwords google chrome", + "checkup use safety", + "checkup use safety browser", + "checkup use safety chrome", + "checkup use safety google", + "checkup use safety google chrome", + "checkup use security", + "checkup use security browser", + "checkup use security chrome", + "checkup use security google", + "checkup use security google chrome", + "chrome activate check password", + "chrome activate check passwords", + "chrome activate check safety", + "chrome activate check security", + "chrome activate checks password", + "chrome activate checks passwords", + "chrome activate checks safety", + "chrome activate checks security", + "chrome activate checkup password", + "chrome activate checkup passwords", + "chrome activate checkup safety", + "chrome activate checkup security", + "chrome activate password check", + "chrome activate password checks", + "chrome activate password checkup", + "chrome activate passwords check", + "chrome activate passwords checks", + "chrome activate passwords checkup", + "chrome activate safety check", + "chrome activate safety checks", + "chrome activate safety checkup", + "chrome activate security check", + "chrome activate security checks", + "chrome activate security checkup", + "chrome check activate password", + "chrome check activate passwords", + "chrome check activate safety", + "chrome check activate security", + "chrome check password", + "chrome check password activate", + "chrome check password perform", + "chrome check password run", + "chrome check password use", + "chrome check passwords", + "chrome check passwords activate", + "chrome check passwords perform", + "chrome check passwords run", + "chrome check passwords use", + "chrome check perform password", + "chrome check perform passwords", + "chrome check perform safety", + "chrome check perform security", + "chrome check run password", + "chrome check run passwords", + "chrome check run safety", + "chrome check run security", + "chrome check safety", + "chrome check safety activate", + "chrome check safety perform", + "chrome check safety run", + "chrome check safety use", + "chrome check security", + "chrome check security activate", + "chrome check security perform", + "chrome check security run", + "chrome check security use", + "chrome check use password", + "chrome check use passwords", + "chrome check use safety", + "chrome check use security", + "chrome checks activate password", + "chrome checks activate passwords", + "chrome checks activate safety", + "chrome checks activate security", + "chrome checks password", + "chrome checks password activate", + "chrome checks password perform", + "chrome checks password run", + "chrome checks password use", + "chrome checks passwords", + "chrome checks passwords activate", + "chrome checks passwords perform", + "chrome checks passwords run", + "chrome checks passwords use", + "chrome checks perform password", + "chrome checks perform passwords", + "chrome checks perform safety", + "chrome checks perform security", + "chrome checks run password", + "chrome checks run passwords", + "chrome checks run safety", + "chrome checks run security", + "chrome checks safety", + "chrome checks safety activate", + "chrome checks safety perform", + "chrome checks safety run", + "chrome checks safety use", + "chrome checks security", + "chrome checks security activate", + "chrome checks security perform", + "chrome checks security run", + "chrome checks security use", + "chrome checks use password", + "chrome checks use passwords", + "chrome checks use safety", + "chrome checks use security", + "chrome checkup activate password", + "chrome checkup activate passwords", + "chrome checkup activate safety", + "chrome checkup activate security", + "chrome checkup password", + "chrome checkup password activate", + "chrome checkup password perform", + "chrome checkup password run", + "chrome checkup password use", + "chrome checkup passwords", + "chrome checkup passwords activate", + "chrome checkup passwords perform", + "chrome checkup passwords run", + "chrome checkup passwords use", + "chrome checkup perform password", + "chrome checkup perform passwords", + "chrome checkup perform safety", + "chrome checkup perform security", + "chrome checkup run password", + "chrome checkup run passwords", + "chrome checkup run safety", + "chrome checkup run security", + "chrome checkup safety", + "chrome checkup safety activate", + "chrome checkup safety perform", + "chrome checkup safety run", + "chrome checkup safety use", + "chrome checkup security", + "chrome checkup security activate", + "chrome checkup security perform", + "chrome checkup security run", + "chrome checkup security use", + "chrome checkup use password", + "chrome checkup use passwords", + "chrome checkup use safety", + "chrome checkup use security", + "chrome password activate check", + "chrome password activate checks", + "chrome password activate checkup", + "chrome password check", + "chrome password check activate", + "chrome password check perform", + "chrome password check run", + "chrome password check use", + "chrome password checks", + "chrome password checks activate", + "chrome password checks perform", + "chrome password checks run", + "chrome password checks use", + "chrome password checkup", + "chrome password checkup activate", + "chrome password checkup perform", + "chrome password checkup run", + "chrome password checkup use", + "chrome password perform check", + "chrome password perform checks", + "chrome password perform checkup", + "chrome password run check", + "chrome password run checks", + "chrome password run checkup", + "chrome password use check", + "chrome password use checks", + "chrome password use checkup", + "chrome passwords activate check", + "chrome passwords activate checks", + "chrome passwords activate checkup", + "chrome passwords check", + "chrome passwords check activate", + "chrome passwords check perform", + "chrome passwords check run", + "chrome passwords check use", + "chrome passwords checks", + "chrome passwords checks activate", + "chrome passwords checks perform", + "chrome passwords checks run", + "chrome passwords checks use", + "chrome passwords checkup", + "chrome passwords checkup activate", + "chrome passwords checkup perform", + "chrome passwords checkup run", + "chrome passwords checkup use", + "chrome passwords perform check", + "chrome passwords perform checks", + "chrome passwords perform checkup", + "chrome passwords run check", + "chrome passwords run checks", + "chrome passwords run checkup", + "chrome passwords use check", + "chrome passwords use checks", + "chrome passwords use checkup", + "chrome perform check password", + "chrome perform check passwords", + "chrome perform check safety", + "chrome perform check security", + "chrome perform checks password", + "chrome perform checks passwords", + "chrome perform checks safety", + "chrome perform checks security", + "chrome perform checkup password", + "chrome perform checkup passwords", + "chrome perform checkup safety", + "chrome perform checkup security", + "chrome perform password check", + "chrome perform password checks", + "chrome perform password checkup", + "chrome perform passwords check", + "chrome perform passwords checks", + "chrome perform passwords checkup", + "chrome perform safety check", + "chrome perform safety checks", + "chrome perform safety checkup", + "chrome perform security check", + "chrome perform security checks", + "chrome perform security checkup", + "chrome run check password", + "chrome run check passwords", + "chrome run check safety", + "chrome run check security", + "chrome run checks password", + "chrome run checks passwords", + "chrome run checks safety", + "chrome run checks security", + "chrome run checkup password", + "chrome run checkup passwords", + "chrome run checkup safety", + "chrome run checkup security", + "chrome run password check", + "chrome run password checks", + "chrome run password checkup", + "chrome run passwords check", + "chrome run passwords checks", + "chrome run passwords checkup", + "chrome run safety check", + "chrome run safety checks", + "chrome run safety checkup", + "chrome run security check", + "chrome run security checks", + "chrome run security checkup", + "chrome safety activate check", + "chrome safety activate checks", + "chrome safety activate checkup", + "chrome safety check", + "chrome safety check activate", + "chrome safety check perform", + "chrome safety check run", + "chrome safety check use", + "chrome safety checks", + "chrome safety checks activate", + "chrome safety checks perform", + "chrome safety checks run", + "chrome safety checks use", + "chrome safety checkup", + "chrome safety checkup activate", + "chrome safety checkup perform", + "chrome safety checkup run", + "chrome safety checkup use", + "chrome safety perform check", + "chrome safety perform checks", + "chrome safety perform checkup", + "chrome safety run check", + "chrome safety run checks", + "chrome safety run checkup", + "chrome safety use check", + "chrome safety use checks", + "chrome safety use checkup", + "chrome security activate check", + "chrome security activate checks", + "chrome security activate checkup", + "chrome security check", + "chrome security check activate", + "chrome security check perform", + "chrome security check run", + "chrome security check use", + "chrome security checks", + "chrome security checks activate", + "chrome security checks perform", + "chrome security checks run", + "chrome security checks use", + "chrome security checkup", + "chrome security checkup activate", + "chrome security checkup perform", + "chrome security checkup run", + "chrome security checkup use", + "chrome security perform check", + "chrome security perform checks", + "chrome security perform checkup", + "chrome security run check", + "chrome security run checks", + "chrome security run checkup", + "chrome security use check", + "chrome security use checks", + "chrome security use checkup", + "chrome use check password", + "chrome use check passwords", + "chrome use check safety", + "chrome use check security", + "chrome use checks password", + "chrome use checks passwords", + "chrome use checks safety", + "chrome use checks security", + "chrome use checkup password", + "chrome use checkup passwords", + "chrome use checkup safety", + "chrome use checkup security", + "chrome use password check", + "chrome use password checks", + "chrome use password checkup", + "chrome use passwords check", + "chrome use passwords checks", + "chrome use passwords checkup", + "chrome use safety check", + "chrome use safety checks", + "chrome use safety checkup", + "chrome use security check", + "chrome use security checks", + "chrome use security checkup", + "google activate check password", + "google activate check passwords", + "google activate check safety", + "google activate check security", + "google activate checks password", + "google activate checks passwords", + "google activate checks safety", + "google activate checks security", + "google activate checkup password", + "google activate checkup passwords", + "google activate checkup safety", + "google activate checkup security", + "google activate password check", + "google activate password checks", + "google activate password checkup", + "google activate passwords check", + "google activate passwords checks", + "google activate passwords checkup", + "google activate safety check", + "google activate safety checks", + "google activate safety checkup", + "google activate security check", + "google activate security checks", + "google activate security checkup", + "google check activate password", + "google check activate passwords", + "google check activate safety", + "google check activate security", + "google check password", + "google check password activate", + "google check password perform", + "google check password run", + "google check password use", + "google check passwords", + "google check passwords activate", + "google check passwords perform", + "google check passwords run", + "google check passwords use", + "google check perform password", + "google check perform passwords", + "google check perform safety", + "google check perform security", + "google check run password", + "google check run passwords", + "google check run safety", + "google check run security", + "google check safety", + "google check safety activate", + "google check safety perform", + "google check safety run", + "google check safety use", + "google check security", + "google check security activate", + "google check security perform", + "google check security run", + "google check security use", + "google check use password", + "google check use passwords", + "google check use safety", + "google check use security", + "google checks activate password", + "google checks activate passwords", + "google checks activate safety", + "google checks activate security", + "google checks password", + "google checks password activate", + "google checks password perform", + "google checks password run", + "google checks password use", + "google checks passwords", + "google checks passwords activate", + "google checks passwords perform", + "google checks passwords run", + "google checks passwords use", + "google checks perform password", + "google checks perform passwords", + "google checks perform safety", + "google checks perform security", + "google checks run password", + "google checks run passwords", + "google checks run safety", + "google checks run security", + "google checks safety", + "google checks safety activate", + "google checks safety perform", + "google checks safety run", + "google checks safety use", + "google checks security", + "google checks security activate", + "google checks security perform", + "google checks security run", + "google checks security use", + "google checks use password", + "google checks use passwords", + "google checks use safety", + "google checks use security", + "google checkup activate password", + "google checkup activate passwords", + "google checkup activate safety", + "google checkup activate security", + "google checkup password", + "google checkup password activate", + "google checkup password perform", + "google checkup password run", + "google checkup password use", + "google checkup passwords", + "google checkup passwords activate", + "google checkup passwords perform", + "google checkup passwords run", + "google checkup passwords use", + "google checkup perform password", + "google checkup perform passwords", + "google checkup perform safety", + "google checkup perform security", + "google checkup run password", + "google checkup run passwords", + "google checkup run safety", + "google checkup run security", + "google checkup safety", + "google checkup safety activate", + "google checkup safety perform", + "google checkup safety run", + "google checkup safety use", + "google checkup security", + "google checkup security activate", + "google checkup security perform", + "google checkup security run", + "google checkup security use", + "google checkup use password", + "google checkup use passwords", + "google checkup use safety", + "google checkup use security", + "google chrome activate check password", + "google chrome activate check passwords", + "google chrome activate check safety", + "google chrome activate check security", + "google chrome activate checks password", + "google chrome activate checks passwords", + "google chrome activate checks safety", + "google chrome activate checks security", + "google chrome activate checkup password", + "google chrome activate checkup passwords", + "google chrome activate checkup safety", + "google chrome activate checkup security", + "google chrome activate password check", + "google chrome activate password checks", + "google chrome activate password checkup", + "google chrome activate passwords check", + "google chrome activate passwords checks", + "google chrome activate passwords checkup", + "google chrome activate safety check", + "google chrome activate safety checks", + "google chrome activate safety checkup", + "google chrome activate security check", + "google chrome activate security checks", + "google chrome activate security checkup", + "google chrome check activate password", + "google chrome check activate passwords", + "google chrome check activate safety", + "google chrome check activate security", + "google chrome check password", + "google chrome check password activate", + "google chrome check password perform", + "google chrome check password run", + "google chrome check password use", + "google chrome check passwords", + "google chrome check passwords activate", + "google chrome check passwords perform", + "google chrome check passwords run", + "google chrome check passwords use", + "google chrome check perform password", + "google chrome check perform passwords", + "google chrome check perform safety", + "google chrome check perform security", + "google chrome check run password", + "google chrome check run passwords", + "google chrome check run safety", + "google chrome check run security", + "google chrome check safety", + "google chrome check safety activate", + "google chrome check safety perform", + "google chrome check safety run", + "google chrome check safety use", + "google chrome check security", + "google chrome check security activate", + "google chrome check security perform", + "google chrome check security run", + "google chrome check security use", + "google chrome check use password", + "google chrome check use passwords", + "google chrome check use safety", + "google chrome check use security", + "google chrome checks activate password", + "google chrome checks activate passwords", + "google chrome checks activate safety", + "google chrome checks activate security", + "google chrome checks password", + "google chrome checks password activate", + "google chrome checks password perform", + "google chrome checks password run", + "google chrome checks password use", + "google chrome checks passwords", + "google chrome checks passwords activate", + "google chrome checks passwords perform", + "google chrome checks passwords run", + "google chrome checks passwords use", + "google chrome checks perform password", + "google chrome checks perform passwords", + "google chrome checks perform safety", + "google chrome checks perform security", + "google chrome checks run password", + "google chrome checks run passwords", + "google chrome checks run safety", + "google chrome checks run security", + "google chrome checks safety", + "google chrome checks safety activate", + "google chrome checks safety perform", + "google chrome checks safety run", + "google chrome checks safety use", + "google chrome checks security", + "google chrome checks security activate", + "google chrome checks security perform", + "google chrome checks security run", + "google chrome checks security use", + "google chrome checks use password", + "google chrome checks use passwords", + "google chrome checks use safety", + "google chrome checks use security", + "google chrome checkup activate password", + "google chrome checkup activate passwords", + "google chrome checkup activate safety", + "google chrome checkup activate security", + "google chrome checkup password", + "google chrome checkup password activate", + "google chrome checkup password perform", + "google chrome checkup password run", + "google chrome checkup password use", + "google chrome checkup passwords", + "google chrome checkup passwords activate", + "google chrome checkup passwords perform", + "google chrome checkup passwords run", + "google chrome checkup passwords use", + "google chrome checkup perform password", + "google chrome checkup perform passwords", + "google chrome checkup perform safety", + "google chrome checkup perform security", + "google chrome checkup run password", + "google chrome checkup run passwords", + "google chrome checkup run safety", + "google chrome checkup run security", + "google chrome checkup safety", + "google chrome checkup safety activate", + "google chrome checkup safety perform", + "google chrome checkup safety run", + "google chrome checkup safety use", + "google chrome checkup security", + "google chrome checkup security activate", + "google chrome checkup security perform", + "google chrome checkup security run", + "google chrome checkup security use", + "google chrome checkup use password", + "google chrome checkup use passwords", + "google chrome checkup use safety", + "google chrome checkup use security", + "google chrome password activate check", + "google chrome password activate checks", + "google chrome password activate checkup", + "google chrome password check", + "google chrome password check activate", + "google chrome password check perform", + "google chrome password check run", + "google chrome password check use", + "google chrome password checks", + "google chrome password checks activate", + "google chrome password checks perform", + "google chrome password checks run", + "google chrome password checks use", + "google chrome password checkup", + "google chrome password checkup activate", + "google chrome password checkup perform", + "google chrome password checkup run", + "google chrome password checkup use", + "google chrome password perform check", + "google chrome password perform checks", + "google chrome password perform checkup", + "google chrome password run check", + "google chrome password run checks", + "google chrome password run checkup", + "google chrome password use check", + "google chrome password use checks", + "google chrome password use checkup", + "google chrome passwords activate check", + "google chrome passwords activate checks", + "google chrome passwords activate checkup", + "google chrome passwords check", + "google chrome passwords check activate", + "google chrome passwords check perform", + "google chrome passwords check run", + "google chrome passwords check use", + "google chrome passwords checks", + "google chrome passwords checks activate", + "google chrome passwords checks perform", + "google chrome passwords checks run", + "google chrome passwords checks use", + "google chrome passwords checkup", + "google chrome passwords checkup activate", + "google chrome passwords checkup perform", + "google chrome passwords checkup run", + "google chrome passwords checkup use", + "google chrome passwords perform check", + "google chrome passwords perform checks", + "google chrome passwords perform checkup", + "google chrome passwords run check", + "google chrome passwords run checks", + "google chrome passwords run checkup", + "google chrome passwords use check", + "google chrome passwords use checks", + "google chrome passwords use checkup", + "google chrome perform check password", + "google chrome perform check passwords", + "google chrome perform check safety", + "google chrome perform check security", + "google chrome perform checks password", + "google chrome perform checks passwords", + "google chrome perform checks safety", + "google chrome perform checks security", + "google chrome perform checkup password", + "google chrome perform checkup passwords", + "google chrome perform checkup safety", + "google chrome perform checkup security", + "google chrome perform password check", + "google chrome perform password checks", + "google chrome perform password checkup", + "google chrome perform passwords check", + "google chrome perform passwords checks", + "google chrome perform passwords checkup", + "google chrome perform safety check", + "google chrome perform safety checks", + "google chrome perform safety checkup", + "google chrome perform security check", + "google chrome perform security checks", + "google chrome perform security checkup", + "google chrome run check password", + "google chrome run check passwords", + "google chrome run check safety", + "google chrome run check security", + "google chrome run checks password", + "google chrome run checks passwords", + "google chrome run checks safety", + "google chrome run checks security", + "google chrome run checkup password", + "google chrome run checkup passwords", + "google chrome run checkup safety", + "google chrome run checkup security", + "google chrome run password check", + "google chrome run password checks", + "google chrome run password checkup", + "google chrome run passwords check", + "google chrome run passwords checks", + "google chrome run passwords checkup", + "google chrome run safety check", + "google chrome run safety checks", + "google chrome run safety checkup", + "google chrome run security check", + "google chrome run security checks", + "google chrome run security checkup", + "google chrome safety activate check", + "google chrome safety activate checks", + "google chrome safety activate checkup", + "google chrome safety check", + "google chrome safety check activate", + "google chrome safety check perform", + "google chrome safety check run", + "google chrome safety check use", + "google chrome safety checks", + "google chrome safety checks activate", + "google chrome safety checks perform", + "google chrome safety checks run", + "google chrome safety checks use", + "google chrome safety checkup", + "google chrome safety checkup activate", + "google chrome safety checkup perform", + "google chrome safety checkup run", + "google chrome safety checkup use", + "google chrome safety perform check", + "google chrome safety perform checks", + "google chrome safety perform checkup", + "google chrome safety run check", + "google chrome safety run checks", + "google chrome safety run checkup", + "google chrome safety use check", + "google chrome safety use checks", + "google chrome safety use checkup", + "google chrome security activate check", + "google chrome security activate checks", + "google chrome security activate checkup", + "google chrome security check", + "google chrome security check activate", + "google chrome security check perform", + "google chrome security check run", + "google chrome security check use", + "google chrome security checks", + "google chrome security checks activate", + "google chrome security checks perform", + "google chrome security checks run", + "google chrome security checks use", + "google chrome security checkup", + "google chrome security checkup activate", + "google chrome security checkup perform", + "google chrome security checkup run", + "google chrome security checkup use", + "google chrome security perform check", + "google chrome security perform checks", + "google chrome security perform checkup", + "google chrome security run check", + "google chrome security run checks", + "google chrome security run checkup", + "google chrome security use check", + "google chrome security use checks", + "google chrome security use checkup", + "google chrome use check password", + "google chrome use check passwords", + "google chrome use check safety", + "google chrome use check security", + "google chrome use checks password", + "google chrome use checks passwords", + "google chrome use checks safety", + "google chrome use checks security", + "google chrome use checkup password", + "google chrome use checkup passwords", + "google chrome use checkup safety", + "google chrome use checkup security", + "google chrome use password check", + "google chrome use password checks", + "google chrome use password checkup", + "google chrome use passwords check", + "google chrome use passwords checks", + "google chrome use passwords checkup", + "google chrome use safety check", + "google chrome use safety checks", + "google chrome use safety checkup", + "google chrome use security check", + "google chrome use security checks", + "google chrome use security checkup", + "google password activate check", + "google password activate checks", + "google password activate checkup", + "google password check", + "google password check activate", + "google password check perform", + "google password check run", + "google password check use", + "google password checks", + "google password checks activate", + "google password checks perform", + "google password checks run", + "google password checks use", + "google password checkup", + "google password checkup activate", + "google password checkup perform", + "google password checkup run", + "google password checkup use", + "google password perform check", + "google password perform checks", + "google password perform checkup", + "google password run check", + "google password run checks", + "google password run checkup", + "google password use check", + "google password use checks", + "google password use checkup", + "google passwords activate check", + "google passwords activate checks", + "google passwords activate checkup", + "google passwords check", + "google passwords check activate", + "google passwords check perform", + "google passwords check run", + "google passwords check use", + "google passwords checks", + "google passwords checks activate", + "google passwords checks perform", + "google passwords checks run", + "google passwords checks use", + "google passwords checkup", + "google passwords checkup activate", + "google passwords checkup perform", + "google passwords checkup run", + "google passwords checkup use", + "google passwords perform check", + "google passwords perform checks", + "google passwords perform checkup", + "google passwords run check", + "google passwords run checks", + "google passwords run checkup", + "google passwords use check", + "google passwords use checks", + "google passwords use checkup", + "google perform check password", + "google perform check passwords", + "google perform check safety", + "google perform check security", + "google perform checks password", + "google perform checks passwords", + "google perform checks safety", + "google perform checks security", + "google perform checkup password", + "google perform checkup passwords", + "google perform checkup safety", + "google perform checkup security", + "google perform password check", + "google perform password checks", + "google perform password checkup", + "google perform passwords check", + "google perform passwords checks", + "google perform passwords checkup", + "google perform safety check", + "google perform safety checks", + "google perform safety checkup", + "google perform security check", + "google perform security checks", + "google perform security checkup", + "google run check password", + "google run check passwords", + "google run check safety", + "google run check security", + "google run checks password", + "google run checks passwords", + "google run checks safety", + "google run checks security", + "google run checkup password", + "google run checkup passwords", + "google run checkup safety", + "google run checkup security", + "google run password check", + "google run password checks", + "google run password checkup", + "google run passwords check", + "google run passwords checks", + "google run passwords checkup", + "google run safety check", + "google run safety checks", + "google run safety checkup", + "google run security check", + "google run security checks", + "google run security checkup", + "google safety activate check", + "google safety activate checks", + "google safety activate checkup", + "google safety check", + "google safety check activate", + "google safety check perform", + "google safety check run", + "google safety check use", + "google safety checks", + "google safety checks activate", + "google safety checks perform", + "google safety checks run", + "google safety checks use", + "google safety checkup", + "google safety checkup activate", + "google safety checkup perform", + "google safety checkup run", + "google safety checkup use", + "google safety perform check", + "google safety perform checks", + "google safety perform checkup", + "google safety run check", + "google safety run checks", + "google safety run checkup", + "google safety use check", + "google safety use checks", + "google safety use checkup", + "google security activate check", + "google security activate checks", + "google security activate checkup", + "google security check", + "google security check activate", + "google security check perform", + "google security check run", + "google security check use", + "google security checks", + "google security checks activate", + "google security checks perform", + "google security checks run", + "google security checks use", + "google security checkup", + "google security checkup activate", + "google security checkup perform", + "google security checkup run", + "google security checkup use", + "google security perform check", + "google security perform checks", + "google security perform checkup", + "google security run check", + "google security run checks", + "google security run checkup", + "google security use check", + "google security use checks", + "google security use checkup", + "google use check password", + "google use check passwords", + "google use check safety", + "google use check security", + "google use checks password", + "google use checks passwords", + "google use checks safety", + "google use checks security", + "google use checkup password", + "google use checkup passwords", + "google use checkup safety", + "google use checkup security", + "google use password check", + "google use password checks", + "google use password checkup", + "google use passwords check", + "google use passwords checks", + "google use passwords checkup", + "google use safety check", + "google use safety checks", + "google use safety checkup", + "google use security check", + "google use security checks", + "google use security checkup", + "password activate browser check", + "password activate browser checks", + "password activate browser checkup", + "password activate check", + "password activate check browser", + "password activate check chrome", + "password activate check google", + "password activate check google chrome", + "password activate checks", + "password activate checks browser", + "password activate checks chrome", + "password activate checks google", + "password activate checks google chrome", + "password activate checkup", + "password activate checkup browser", + "password activate checkup chrome", + "password activate checkup google", + "password activate checkup google chrome", + "password activate chrome check", + "password activate chrome checks", + "password activate chrome checkup", + "password activate google check", + "password activate google checks", + "password activate google checkup", + "password activate google chrome check", + "password activate google chrome checks", + "password activate google chrome checkup", + "password browser activate check", + "password browser activate checks", + "password browser activate checkup", + "password browser check", + "password browser check activate", + "password browser check perform", + "password browser check run", + "password browser check use", + "password browser checks", + "password browser checks activate", + "password browser checks perform", + "password browser checks run", + "password browser checks use", + "password browser checkup", + "password browser checkup activate", + "password browser checkup perform", + "password browser checkup run", + "password browser checkup use", + "password browser perform check", + "password browser perform checks", + "password browser perform checkup", + "password browser run check", + "password browser run checks", + "password browser run checkup", + "password browser use check", + "password browser use checks", + "password browser use checkup", + "password check", + "password check activate", + "password check activate browser", + "password check activate chrome", + "password check activate google", + "password check activate google chrome", + "password check browser", + "password check browser activate", + "password check browser perform", + "password check browser run", + "password check browser use", + "password check chrome", + "password check chrome activate", + "password check chrome perform", + "password check chrome run", + "password check chrome use", + "password check google", + "password check google activate", + "password check google chrome", + "password check google chrome activate", + "password check google chrome perform", + "password check google chrome run", + "password check google chrome use", + "password check google perform", + "password check google run", + "password check google use", + "password check perform", + "password check perform browser", + "password check perform chrome", + "password check perform google", + "password check perform google chrome", + "password check run", + "password check run browser", + "password check run chrome", + "password check run google", + "password check run google chrome", + "password check use", + "password check use browser", + "password check use chrome", + "password check use google", + "password check use google chrome", + "password checks", + "password checks activate", + "password checks activate browser", + "password checks activate chrome", + "password checks activate google", + "password checks activate google chrome", + "password checks browser", + "password checks browser activate", + "password checks browser perform", + "password checks browser run", + "password checks browser use", + "password checks chrome", + "password checks chrome activate", + "password checks chrome perform", + "password checks chrome run", + "password checks chrome use", + "password checks google", + "password checks google activate", + "password checks google chrome", + "password checks google chrome activate", + "password checks google chrome perform", + "password checks google chrome run", + "password checks google chrome use", + "password checks google perform", + "password checks google run", + "password checks google use", + "password checks perform", + "password checks perform browser", + "password checks perform chrome", + "password checks perform google", + "password checks perform google chrome", + "password checks run", + "password checks run browser", + "password checks run chrome", + "password checks run google", + "password checks run google chrome", + "password checks use", + "password checks use browser", + "password checks use chrome", + "password checks use google", + "password checks use google chrome", + "password checkup", + "password checkup activate", + "password checkup activate browser", + "password checkup activate chrome", + "password checkup activate google", + "password checkup activate google chrome", + "password checkup browser", + "password checkup browser activate", + "password checkup browser perform", + "password checkup browser run", + "password checkup browser use", + "password checkup chrome", + "password checkup chrome activate", + "password checkup chrome perform", + "password checkup chrome run", + "password checkup chrome use", + "password checkup google", + "password checkup google activate", + "password checkup google chrome", + "password checkup google chrome activate", + "password checkup google chrome perform", + "password checkup google chrome run", + "password checkup google chrome use", + "password checkup google perform", + "password checkup google run", + "password checkup google use", + "password checkup perform", + "password checkup perform browser", + "password checkup perform chrome", + "password checkup perform google", + "password checkup perform google chrome", + "password checkup run", + "password checkup run browser", + "password checkup run chrome", + "password checkup run google", + "password checkup run google chrome", + "password checkup use", + "password checkup use browser", + "password checkup use chrome", + "password checkup use google", + "password checkup use google chrome", + "password chrome activate check", + "password chrome activate checks", + "password chrome activate checkup", + "password chrome check", + "password chrome check activate", + "password chrome check perform", + "password chrome check run", + "password chrome check use", + "password chrome checks", + "password chrome checks activate", + "password chrome checks perform", + "password chrome checks run", + "password chrome checks use", + "password chrome checkup", + "password chrome checkup activate", + "password chrome checkup perform", + "password chrome checkup run", + "password chrome checkup use", + "password chrome perform check", + "password chrome perform checks", + "password chrome perform checkup", + "password chrome run check", + "password chrome run checks", + "password chrome run checkup", + "password chrome use check", + "password chrome use checks", + "password chrome use checkup", + "password google activate check", + "password google activate checks", + "password google activate checkup", + "password google check", + "password google check activate", + "password google check perform", + "password google check run", + "password google check use", + "password google checks", + "password google checks activate", + "password google checks perform", + "password google checks run", + "password google checks use", + "password google checkup", + "password google checkup activate", + "password google checkup perform", + "password google checkup run", + "password google checkup use", + "password google chrome activate check", + "password google chrome activate checks", + "password google chrome activate checkup", + "password google chrome check", + "password google chrome check activate", + "password google chrome check perform", + "password google chrome check run", + "password google chrome check use", + "password google chrome checks", + "password google chrome checks activate", + "password google chrome checks perform", + "password google chrome checks run", + "password google chrome checks use", + "password google chrome checkup", + "password google chrome checkup activate", + "password google chrome checkup perform", + "password google chrome checkup run", + "password google chrome checkup use", + "password google chrome perform check", + "password google chrome perform checks", + "password google chrome perform checkup", + "password google chrome run check", + "password google chrome run checks", + "password google chrome run checkup", + "password google chrome use check", + "password google chrome use checks", + "password google chrome use checkup", + "password google perform check", + "password google perform checks", + "password google perform checkup", + "password google run check", + "password google run checks", + "password google run checkup", + "password google use check", + "password google use checks", + "password google use checkup", + "password perform browser check", + "password perform browser checks", + "password perform browser checkup", + "password perform check", + "password perform check browser", + "password perform check chrome", + "password perform check google", + "password perform check google chrome", + "password perform checks", + "password perform checks browser", + "password perform checks chrome", + "password perform checks google", + "password perform checks google chrome", + "password perform checkup", + "password perform checkup browser", + "password perform checkup chrome", + "password perform checkup google", + "password perform checkup google chrome", + "password perform chrome check", + "password perform chrome checks", + "password perform chrome checkup", + "password perform google check", + "password perform google checks", + "password perform google checkup", + "password perform google chrome check", + "password perform google chrome checks", + "password perform google chrome checkup", + "password run browser check", + "password run browser checks", + "password run browser checkup", + "password run check", + "password run check browser", + "password run check chrome", + "password run check google", + "password run check google chrome", + "password run checks", + "password run checks browser", + "password run checks chrome", + "password run checks google", + "password run checks google chrome", + "password run checkup", + "password run checkup browser", + "password run checkup chrome", + "password run checkup google", + "password run checkup google chrome", + "password run chrome check", + "password run chrome checks", + "password run chrome checkup", + "password run google check", + "password run google checks", + "password run google checkup", + "password run google chrome check", + "password run google chrome checks", + "password run google chrome checkup", + "password use browser check", + "password use browser checks", + "password use browser checkup", + "password use check", + "password use check browser", + "password use check chrome", + "password use check google", + "password use check google chrome", + "password use checks", + "password use checks browser", + "password use checks chrome", + "password use checks google", + "password use checks google chrome", + "password use checkup", + "password use checkup browser", + "password use checkup chrome", + "password use checkup google", + "password use checkup google chrome", + "password use chrome check", + "password use chrome checks", + "password use chrome checkup", + "password use google check", + "password use google checks", + "password use google checkup", + "password use google chrome check", + "password use google chrome checks", + "password use google chrome checkup", + "passwords activate browser check", + "passwords activate browser checks", + "passwords activate browser checkup", + "passwords activate check", + "passwords activate check browser", + "passwords activate check chrome", + "passwords activate check google", + "passwords activate check google chrome", + "passwords activate checks", + "passwords activate checks browser", + "passwords activate checks chrome", + "passwords activate checks google", + "passwords activate checks google chrome", + "passwords activate checkup", + "passwords activate checkup browser", + "passwords activate checkup chrome", + "passwords activate checkup google", + "passwords activate checkup google chrome", + "passwords activate chrome check", + "passwords activate chrome checks", + "passwords activate chrome checkup", + "passwords activate google check", + "passwords activate google checks", + "passwords activate google checkup", + "passwords activate google chrome check", + "passwords activate google chrome checks", + "passwords activate google chrome checkup", + "passwords browser activate check", + "passwords browser activate checks", + "passwords browser activate checkup", + "passwords browser check", + "passwords browser check activate", + "passwords browser check perform", + "passwords browser check run", + "passwords browser check use", + "passwords browser checks", + "passwords browser checks activate", + "passwords browser checks perform", + "passwords browser checks run", + "passwords browser checks use", + "passwords browser checkup", + "passwords browser checkup activate", + "passwords browser checkup perform", + "passwords browser checkup run", + "passwords browser checkup use", + "passwords browser perform check", + "passwords browser perform checks", + "passwords browser perform checkup", + "passwords browser run check", + "passwords browser run checks", + "passwords browser run checkup", + "passwords browser use check", + "passwords browser use checks", + "passwords browser use checkup", + "passwords check", + "passwords check activate", + "passwords check activate browser", + "passwords check activate chrome", + "passwords check activate google", + "passwords check activate google chrome", + "passwords check browser", + "passwords check browser activate", + "passwords check browser perform", + "passwords check browser run", + "passwords check browser use", + "passwords check chrome", + "passwords check chrome activate", + "passwords check chrome perform", + "passwords check chrome run", + "passwords check chrome use", + "passwords check google", + "passwords check google activate", + "passwords check google chrome", + "passwords check google chrome activate", + "passwords check google chrome perform", + "passwords check google chrome run", + "passwords check google chrome use", + "passwords check google perform", + "passwords check google run", + "passwords check google use", + "passwords check perform", + "passwords check perform browser", + "passwords check perform chrome", + "passwords check perform google", + "passwords check perform google chrome", + "passwords check run", + "passwords check run browser", + "passwords check run chrome", + "passwords check run google", + "passwords check run google chrome", + "passwords check use", + "passwords check use browser", + "passwords check use chrome", + "passwords check use google", + "passwords check use google chrome", + "passwords checks", + "passwords checks activate", + "passwords checks activate browser", + "passwords checks activate chrome", + "passwords checks activate google", + "passwords checks activate google chrome", + "passwords checks browser", + "passwords checks browser activate", + "passwords checks browser perform", + "passwords checks browser run", + "passwords checks browser use", + "passwords checks chrome", + "passwords checks chrome activate", + "passwords checks chrome perform", + "passwords checks chrome run", + "passwords checks chrome use", + "passwords checks google", + "passwords checks google activate", + "passwords checks google chrome", + "passwords checks google chrome activate", + "passwords checks google chrome perform", + "passwords checks google chrome run", + "passwords checks google chrome use", + "passwords checks google perform", + "passwords checks google run", + "passwords checks google use", + "passwords checks perform", + "passwords checks perform browser", + "passwords checks perform chrome", + "passwords checks perform google", + "passwords checks perform google chrome", + "passwords checks run", + "passwords checks run browser", + "passwords checks run chrome", + "passwords checks run google", + "passwords checks run google chrome", + "passwords checks use", + "passwords checks use browser", + "passwords checks use chrome", + "passwords checks use google", + "passwords checks use google chrome", + "passwords checkup", + "passwords checkup activate", + "passwords checkup activate browser", + "passwords checkup activate chrome", + "passwords checkup activate google", + "passwords checkup activate google chrome", + "passwords checkup browser", + "passwords checkup browser activate", + "passwords checkup browser perform", + "passwords checkup browser run", + "passwords checkup browser use", + "passwords checkup chrome", + "passwords checkup chrome activate", + "passwords checkup chrome perform", + "passwords checkup chrome run", + "passwords checkup chrome use", + "passwords checkup google", + "passwords checkup google activate", + "passwords checkup google chrome", + "passwords checkup google chrome activate", + "passwords checkup google chrome perform", + "passwords checkup google chrome run", + "passwords checkup google chrome use", + "passwords checkup google perform", + "passwords checkup google run", + "passwords checkup google use", + "passwords checkup perform", + "passwords checkup perform browser", + "passwords checkup perform chrome", + "passwords checkup perform google", + "passwords checkup perform google chrome", + "passwords checkup run", + "passwords checkup run browser", + "passwords checkup run chrome", + "passwords checkup run google", + "passwords checkup run google chrome", + "passwords checkup use", + "passwords checkup use browser", + "passwords checkup use chrome", + "passwords checkup use google", + "passwords checkup use google chrome", + "passwords chrome activate check", + "passwords chrome activate checks", + "passwords chrome activate checkup", + "passwords chrome check", + "passwords chrome check activate", + "passwords chrome check perform", + "passwords chrome check run", + "passwords chrome check use", + "passwords chrome checks", + "passwords chrome checks activate", + "passwords chrome checks perform", + "passwords chrome checks run", + "passwords chrome checks use", + "passwords chrome checkup", + "passwords chrome checkup activate", + "passwords chrome checkup perform", + "passwords chrome checkup run", + "passwords chrome checkup use", + "passwords chrome perform check", + "passwords chrome perform checks", + "passwords chrome perform checkup", + "passwords chrome run check", + "passwords chrome run checks", + "passwords chrome run checkup", + "passwords chrome use check", + "passwords chrome use checks", + "passwords chrome use checkup", + "passwords google activate check", + "passwords google activate checks", + "passwords google activate checkup", + "passwords google check", + "passwords google check activate", + "passwords google check perform", + "passwords google check run", + "passwords google check use", + "passwords google checks", + "passwords google checks activate", + "passwords google checks perform", + "passwords google checks run", + "passwords google checks use", + "passwords google checkup", + "passwords google checkup activate", + "passwords google checkup perform", + "passwords google checkup run", + "passwords google checkup use", + "passwords google chrome activate check", + "passwords google chrome activate checks", + "passwords google chrome activate checkup", + "passwords google chrome check", + "passwords google chrome check activate", + "passwords google chrome check perform", + "passwords google chrome check run", + "passwords google chrome check use", + "passwords google chrome checks", + "passwords google chrome checks activate", + "passwords google chrome checks perform", + "passwords google chrome checks run", + "passwords google chrome checks use", + "passwords google chrome checkup", + "passwords google chrome checkup activate", + "passwords google chrome checkup perform", + "passwords google chrome checkup run", + "passwords google chrome checkup use", + "passwords google chrome perform check", + "passwords google chrome perform checks", + "passwords google chrome perform checkup", + "passwords google chrome run check", + "passwords google chrome run checks", + "passwords google chrome run checkup", + "passwords google chrome use check", + "passwords google chrome use checks", + "passwords google chrome use checkup", + "passwords google perform check", + "passwords google perform checks", + "passwords google perform checkup", + "passwords google run check", + "passwords google run checks", + "passwords google run checkup", + "passwords google use check", + "passwords google use checks", + "passwords google use checkup", + "passwords perform browser check", + "passwords perform browser checks", + "passwords perform browser checkup", + "passwords perform check", + "passwords perform check browser", + "passwords perform check chrome", + "passwords perform check google", + "passwords perform check google chrome", + "passwords perform checks", + "passwords perform checks browser", + "passwords perform checks chrome", + "passwords perform checks google", + "passwords perform checks google chrome", + "passwords perform checkup", + "passwords perform checkup browser", + "passwords perform checkup chrome", + "passwords perform checkup google", + "passwords perform checkup google chrome", + "passwords perform chrome check", + "passwords perform chrome checks", + "passwords perform chrome checkup", + "passwords perform google check", + "passwords perform google checks", + "passwords perform google checkup", + "passwords perform google chrome check", + "passwords perform google chrome checks", + "passwords perform google chrome checkup", + "passwords run browser check", + "passwords run browser checks", + "passwords run browser checkup", + "passwords run check", + "passwords run check browser", + "passwords run check chrome", + "passwords run check google", + "passwords run check google chrome", + "passwords run checks", + "passwords run checks browser", + "passwords run checks chrome", + "passwords run checks google", + "passwords run checks google chrome", + "passwords run checkup", + "passwords run checkup browser", + "passwords run checkup chrome", + "passwords run checkup google", + "passwords run checkup google chrome", + "passwords run chrome check", + "passwords run chrome checks", + "passwords run chrome checkup", + "passwords run google check", + "passwords run google checks", + "passwords run google checkup", + "passwords run google chrome check", + "passwords run google chrome checks", + "passwords run google chrome checkup", + "passwords use browser check", + "passwords use browser checks", + "passwords use browser checkup", + "passwords use check", + "passwords use check browser", + "passwords use check chrome", + "passwords use check google", + "passwords use check google chrome", + "passwords use checks", + "passwords use checks browser", + "passwords use checks chrome", + "passwords use checks google", + "passwords use checks google chrome", + "passwords use checkup", + "passwords use checkup browser", + "passwords use checkup chrome", + "passwords use checkup google", + "passwords use checkup google chrome", + "passwords use chrome check", + "passwords use chrome checks", + "passwords use chrome checkup", + "passwords use google check", + "passwords use google checks", + "passwords use google checkup", + "passwords use google chrome check", + "passwords use google chrome checks", + "passwords use google chrome checkup", + "perform browser check password", + "perform browser check passwords", + "perform browser check safety", + "perform browser check security", + "perform browser checks password", + "perform browser checks passwords", + "perform browser checks safety", + "perform browser checks security", + "perform browser checkup password", + "perform browser checkup passwords", + "perform browser checkup safety", + "perform browser checkup security", + "perform browser password check", + "perform browser password checks", + "perform browser password checkup", + "perform browser passwords check", + "perform browser passwords checks", + "perform browser passwords checkup", + "perform browser safety check", + "perform browser safety checks", + "perform browser safety checkup", + "perform browser security check", + "perform browser security checks", + "perform browser security checkup", + "perform check browser password", + "perform check browser passwords", + "perform check browser safety", + "perform check browser security", + "perform check chrome password", + "perform check chrome passwords", + "perform check chrome safety", + "perform check chrome security", + "perform check google chrome password", + "perform check google chrome passwords", + "perform check google chrome safety", + "perform check google chrome security", + "perform check google password", + "perform check google passwords", + "perform check google safety", + "perform check google security", + "perform check password", + "perform check password browser", + "perform check password chrome", + "perform check password google", + "perform check password google chrome", + "perform check passwords", + "perform check passwords browser", + "perform check passwords chrome", + "perform check passwords google", + "perform check passwords google chrome", + "perform check safety", + "perform check safety browser", + "perform check safety chrome", + "perform check safety google", + "perform check safety google chrome", + "perform check security", + "perform check security browser", + "perform check security chrome", + "perform check security google", + "perform check security google chrome", + "perform checks browser password", + "perform checks browser passwords", + "perform checks browser safety", + "perform checks browser security", + "perform checks chrome password", + "perform checks chrome passwords", + "perform checks chrome safety", + "perform checks chrome security", + "perform checks google chrome password", + "perform checks google chrome passwords", + "perform checks google chrome safety", + "perform checks google chrome security", + "perform checks google password", + "perform checks google passwords", + "perform checks google safety", + "perform checks google security", + "perform checks password", + "perform checks password browser", + "perform checks password chrome", + "perform checks password google", + "perform checks password google chrome", + "perform checks passwords", + "perform checks passwords browser", + "perform checks passwords chrome", + "perform checks passwords google", + "perform checks passwords google chrome", + "perform checks safety", + "perform checks safety browser", + "perform checks safety chrome", + "perform checks safety google", + "perform checks safety google chrome", + "perform checks security", + "perform checks security browser", + "perform checks security chrome", + "perform checks security google", + "perform checks security google chrome", + "perform checkup browser password", + "perform checkup browser passwords", + "perform checkup browser safety", + "perform checkup browser security", + "perform checkup chrome password", + "perform checkup chrome passwords", + "perform checkup chrome safety", + "perform checkup chrome security", + "perform checkup google chrome password", + "perform checkup google chrome passwords", + "perform checkup google chrome safety", + "perform checkup google chrome security", + "perform checkup google password", + "perform checkup google passwords", + "perform checkup google safety", + "perform checkup google security", + "perform checkup password", + "perform checkup password browser", + "perform checkup password chrome", + "perform checkup password google", + "perform checkup password google chrome", + "perform checkup passwords", + "perform checkup passwords browser", + "perform checkup passwords chrome", + "perform checkup passwords google", + "perform checkup passwords google chrome", + "perform checkup safety", + "perform checkup safety browser", + "perform checkup safety chrome", + "perform checkup safety google", + "perform checkup safety google chrome", + "perform checkup security", + "perform checkup security browser", + "perform checkup security chrome", + "perform checkup security google", + "perform checkup security google chrome", + "perform chrome check password", + "perform chrome check passwords", + "perform chrome check safety", + "perform chrome check security", + "perform chrome checks password", + "perform chrome checks passwords", + "perform chrome checks safety", + "perform chrome checks security", + "perform chrome checkup password", + "perform chrome checkup passwords", + "perform chrome checkup safety", + "perform chrome checkup security", + "perform chrome password check", + "perform chrome password checks", + "perform chrome password checkup", + "perform chrome passwords check", + "perform chrome passwords checks", + "perform chrome passwords checkup", + "perform chrome safety check", + "perform chrome safety checks", + "perform chrome safety checkup", + "perform chrome security check", + "perform chrome security checks", + "perform chrome security checkup", + "perform google check password", + "perform google check passwords", + "perform google check safety", + "perform google check security", + "perform google checks password", + "perform google checks passwords", + "perform google checks safety", + "perform google checks security", + "perform google checkup password", + "perform google checkup passwords", + "perform google checkup safety", + "perform google checkup security", + "perform google chrome check password", + "perform google chrome check passwords", + "perform google chrome check safety", + "perform google chrome check security", + "perform google chrome checks password", + "perform google chrome checks passwords", + "perform google chrome checks safety", + "perform google chrome checks security", + "perform google chrome checkup password", + "perform google chrome checkup passwords", + "perform google chrome checkup safety", + "perform google chrome checkup security", + "perform google chrome password check", + "perform google chrome password checks", + "perform google chrome password checkup", + "perform google chrome passwords check", + "perform google chrome passwords checks", + "perform google chrome passwords checkup", + "perform google chrome safety check", + "perform google chrome safety checks", + "perform google chrome safety checkup", + "perform google chrome security check", + "perform google chrome security checks", + "perform google chrome security checkup", + "perform google password check", + "perform google password checks", + "perform google password checkup", + "perform google passwords check", + "perform google passwords checks", + "perform google passwords checkup", + "perform google safety check", + "perform google safety checks", + "perform google safety checkup", + "perform google security check", + "perform google security checks", + "perform google security checkup", + "perform password browser check", + "perform password browser checks", + "perform password browser checkup", + "perform password check", + "perform password check browser", + "perform password check chrome", + "perform password check google", + "perform password check google chrome", + "perform password checks", + "perform password checks browser", + "perform password checks chrome", + "perform password checks google", + "perform password checks google chrome", + "perform password checkup", + "perform password checkup browser", + "perform password checkup chrome", + "perform password checkup google", + "perform password checkup google chrome", + "perform password chrome check", + "perform password chrome checks", + "perform password chrome checkup", + "perform password google check", + "perform password google checks", + "perform password google checkup", + "perform password google chrome check", + "perform password google chrome checks", + "perform password google chrome checkup", + "perform passwords browser check", + "perform passwords browser checks", + "perform passwords browser checkup", + "perform passwords check", + "perform passwords check browser", + "perform passwords check chrome", + "perform passwords check google", + "perform passwords check google chrome", + "perform passwords checks", + "perform passwords checks browser", + "perform passwords checks chrome", + "perform passwords checks google", + "perform passwords checks google chrome", + "perform passwords checkup", + "perform passwords checkup browser", + "perform passwords checkup chrome", + "perform passwords checkup google", + "perform passwords checkup google chrome", + "perform passwords chrome check", + "perform passwords chrome checks", + "perform passwords chrome checkup", + "perform passwords google check", + "perform passwords google checks", + "perform passwords google checkup", + "perform passwords google chrome check", + "perform passwords google chrome checks", + "perform passwords google chrome checkup", + "perform safety browser check", + "perform safety browser checks", + "perform safety browser checkup", + "perform safety check", + "perform safety check browser", + "perform safety check chrome", + "perform safety check google", + "perform safety check google chrome", + "perform safety checks", + "perform safety checks browser", + "perform safety checks chrome", + "perform safety checks google", + "perform safety checks google chrome", + "perform safety checkup", + "perform safety checkup browser", + "perform safety checkup chrome", + "perform safety checkup google", + "perform safety checkup google chrome", + "perform safety chrome check", + "perform safety chrome checks", + "perform safety chrome checkup", + "perform safety google check", + "perform safety google checks", + "perform safety google checkup", + "perform safety google chrome check", + "perform safety google chrome checks", + "perform safety google chrome checkup", + "perform security browser check", + "perform security browser checks", + "perform security browser checkup", + "perform security check", + "perform security check browser", + "perform security check chrome", + "perform security check google", + "perform security check google chrome", + "perform security checks", + "perform security checks browser", + "perform security checks chrome", + "perform security checks google", + "perform security checks google chrome", + "perform security checkup", + "perform security checkup browser", + "perform security checkup chrome", + "perform security checkup google", + "perform security checkup google chrome", + "perform security chrome check", + "perform security chrome checks", + "perform security chrome checkup", + "perform security google check", + "perform security google checks", + "perform security google checkup", + "perform security google chrome check", + "perform security google chrome checks", + "perform security google chrome checkup", + "run browser check password", + "run browser check passwords", + "run browser check safety", + "run browser check security", + "run browser checks password", + "run browser checks passwords", + "run browser checks safety", + "run browser checks security", + "run browser checkup password", + "run browser checkup passwords", + "run browser checkup safety", + "run browser checkup security", + "run browser password check", + "run browser password checks", + "run browser password checkup", + "run browser passwords check", + "run browser passwords checks", + "run browser passwords checkup", + "run browser safety check", + "run browser safety checks", + "run browser safety checkup", + "run browser security check", + "run browser security checks", + "run browser security checkup", + "run check browser password", + "run check browser passwords", + "run check browser safety", + "run check browser security", + "run check chrome password", + "run check chrome passwords", + "run check chrome safety", + "run check chrome security", + "run check google chrome password", + "run check google chrome passwords", + "run check google chrome safety", + "run check google chrome security", + "run check google password", + "run check google passwords", + "run check google safety", + "run check google security", + "run check password", + "run check password browser", + "run check password chrome", + "run check password google", + "run check password google chrome", + "run check passwords", + "run check passwords browser", + "run check passwords chrome", + "run check passwords google", + "run check passwords google chrome", + "run check safety", + "run check safety browser", + "run check safety chrome", + "run check safety google", + "run check safety google chrome", + "run check security", + "run check security browser", + "run check security chrome", + "run check security google", + "run check security google chrome", + "run checks browser password", + "run checks browser passwords", + "run checks browser safety", + "run checks browser security", + "run checks chrome password", + "run checks chrome passwords", + "run checks chrome safety", + "run checks chrome security", + "run checks google chrome password", + "run checks google chrome passwords", + "run checks google chrome safety", + "run checks google chrome security", + "run checks google password", + "run checks google passwords", + "run checks google safety", + "run checks google security", + "run checks password", + "run checks password browser", + "run checks password chrome", + "run checks password google", + "run checks password google chrome", + "run checks passwords", + "run checks passwords browser", + "run checks passwords chrome", + "run checks passwords google", + "run checks passwords google chrome", + "run checks safety", + "run checks safety browser", + "run checks safety chrome", + "run checks safety google", + "run checks safety google chrome", + "run checks security", + "run checks security browser", + "run checks security chrome", + "run checks security google", + "run checks security google chrome", + "run checkup browser password", + "run checkup browser passwords", + "run checkup browser safety", + "run checkup browser security", + "run checkup chrome password", + "run checkup chrome passwords", + "run checkup chrome safety", + "run checkup chrome security", + "run checkup google chrome password", + "run checkup google chrome passwords", + "run checkup google chrome safety", + "run checkup google chrome security", + "run checkup google password", + "run checkup google passwords", + "run checkup google safety", + "run checkup google security", + "run checkup password", + "run checkup password browser", + "run checkup password chrome", + "run checkup password google", + "run checkup password google chrome", + "run checkup passwords", + "run checkup passwords browser", + "run checkup passwords chrome", + "run checkup passwords google", + "run checkup passwords google chrome", + "run checkup safety", + "run checkup safety browser", + "run checkup safety chrome", + "run checkup safety google", + "run checkup safety google chrome", + "run checkup security", + "run checkup security browser", + "run checkup security chrome", + "run checkup security google", + "run checkup security google chrome", + "run chrome check password", + "run chrome check passwords", + "run chrome check safety", + "run chrome check security", + "run chrome checks password", + "run chrome checks passwords", + "run chrome checks safety", + "run chrome checks security", + "run chrome checkup password", + "run chrome checkup passwords", + "run chrome checkup safety", + "run chrome checkup security", + "run chrome password check", + "run chrome password checks", + "run chrome password checkup", + "run chrome passwords check", + "run chrome passwords checks", + "run chrome passwords checkup", + "run chrome safety check", + "run chrome safety checks", + "run chrome safety checkup", + "run chrome security check", + "run chrome security checks", + "run chrome security checkup", + "run google check password", + "run google check passwords", + "run google check safety", + "run google check security", + "run google checks password", + "run google checks passwords", + "run google checks safety", + "run google checks security", + "run google checkup password", + "run google checkup passwords", + "run google checkup safety", + "run google checkup security", + "run google chrome check password", + "run google chrome check passwords", + "run google chrome check safety", + "run google chrome check security", + "run google chrome checks password", + "run google chrome checks passwords", + "run google chrome checks safety", + "run google chrome checks security", + "run google chrome checkup password", + "run google chrome checkup passwords", + "run google chrome checkup safety", + "run google chrome checkup security", + "run google chrome password check", + "run google chrome password checks", + "run google chrome password checkup", + "run google chrome passwords check", + "run google chrome passwords checks", + "run google chrome passwords checkup", + "run google chrome safety check", + "run google chrome safety checks", + "run google chrome safety checkup", + "run google chrome security check", + "run google chrome security checks", + "run google chrome security checkup", + "run google password check", + "run google password checks", + "run google password checkup", + "run google passwords check", + "run google passwords checks", + "run google passwords checkup", + "run google safety check", + "run google safety checks", + "run google safety checkup", + "run google security check", + "run google security checks", + "run google security checkup", + "run password browser check", + "run password browser checks", + "run password browser checkup", + "run password check", + "run password check browser", + "run password check chrome", + "run password check google", + "run password check google chrome", + "run password checks", + "run password checks browser", + "run password checks chrome", + "run password checks google", + "run password checks google chrome", + "run password checkup", + "run password checkup browser", + "run password checkup chrome", + "run password checkup google", + "run password checkup google chrome", + "run password chrome check", + "run password chrome checks", + "run password chrome checkup", + "run password google check", + "run password google checks", + "run password google checkup", + "run password google chrome check", + "run password google chrome checks", + "run password google chrome checkup", + "run passwords browser check", + "run passwords browser checks", + "run passwords browser checkup", + "run passwords check", + "run passwords check browser", + "run passwords check chrome", + "run passwords check google", + "run passwords check google chrome", + "run passwords checks", + "run passwords checks browser", + "run passwords checks chrome", + "run passwords checks google", + "run passwords checks google chrome", + "run passwords checkup", + "run passwords checkup browser", + "run passwords checkup chrome", + "run passwords checkup google", + "run passwords checkup google chrome", + "run passwords chrome check", + "run passwords chrome checks", + "run passwords chrome checkup", + "run passwords google check", + "run passwords google checks", + "run passwords google checkup", + "run passwords google chrome check", + "run passwords google chrome checks", + "run passwords google chrome checkup", + "run safety browser check", + "run safety browser checks", + "run safety browser checkup", + "run safety check", + "run safety check browser", + "run safety check chrome", + "run safety check google", + "run safety check google chrome", + "run safety checks", + "run safety checks browser", + "run safety checks chrome", + "run safety checks google", + "run safety checks google chrome", + "run safety checkup", + "run safety checkup browser", + "run safety checkup chrome", + "run safety checkup google", + "run safety checkup google chrome", + "run safety chrome check", + "run safety chrome checks", + "run safety chrome checkup", + "run safety google check", + "run safety google checks", + "run safety google checkup", + "run safety google chrome check", + "run safety google chrome checks", + "run safety google chrome checkup", + "run security browser check", + "run security browser checks", + "run security browser checkup", + "run security check", + "run security check browser", + "run security check chrome", + "run security check google", + "run security check google chrome", + "run security checks", + "run security checks browser", + "run security checks chrome", + "run security checks google", + "run security checks google chrome", + "run security checkup", + "run security checkup browser", + "run security checkup chrome", + "run security checkup google", + "run security checkup google chrome", + "run security chrome check", + "run security chrome checks", + "run security chrome checkup", + "run security google check", + "run security google checks", + "run security google checkup", + "run security google chrome check", + "run security google chrome checks", + "run security google chrome checkup", + "safety activate browser check", + "safety activate browser checks", + "safety activate browser checkup", + "safety activate check", + "safety activate check browser", + "safety activate check chrome", + "safety activate check google", + "safety activate check google chrome", + "safety activate checks", + "safety activate checks browser", + "safety activate checks chrome", + "safety activate checks google", + "safety activate checks google chrome", + "safety activate checkup", + "safety activate checkup browser", + "safety activate checkup chrome", + "safety activate checkup google", + "safety activate checkup google chrome", + "safety activate chrome check", + "safety activate chrome checks", + "safety activate chrome checkup", + "safety activate google check", + "safety activate google checks", + "safety activate google checkup", + "safety activate google chrome check", + "safety activate google chrome checks", + "safety activate google chrome checkup", + "safety browser activate check", + "safety browser activate checks", + "safety browser activate checkup", + "safety browser check", + "safety browser check activate", + "safety browser check perform", + "safety browser check run", + "safety browser check use", + "safety browser checks", + "safety browser checks activate", + "safety browser checks perform", + "safety browser checks run", + "safety browser checks use", + "safety browser checkup", + "safety browser checkup activate", + "safety browser checkup perform", + "safety browser checkup run", + "safety browser checkup use", + "safety browser perform check", + "safety browser perform checks", + "safety browser perform checkup", + "safety browser run check", + "safety browser run checks", + "safety browser run checkup", + "safety browser use check", + "safety browser use checks", + "safety browser use checkup", + "safety check", + "safety check activate", + "safety check activate browser", + "safety check activate chrome", + "safety check activate google", + "safety check activate google chrome", + "safety check browser", + "safety check browser activate", + "safety check browser perform", + "safety check browser run", + "safety check browser use", + "safety check chrome", + "safety check chrome activate", + "safety check chrome perform", + "safety check chrome run", + "safety check chrome use", + "safety check google", + "safety check google activate", + "safety check google chrome", + "safety check google chrome activate", + "safety check google chrome perform", + "safety check google chrome run", + "safety check google chrome use", + "safety check google perform", + "safety check google run", + "safety check google use", + "safety check perform", + "safety check perform browser", + "safety check perform chrome", + "safety check perform google", + "safety check perform google chrome", + "safety check run", + "safety check run browser", + "safety check run chrome", + "safety check run google", + "safety check run google chrome", + "safety check use", + "safety check use browser", + "safety check use chrome", + "safety check use google", + "safety check use google chrome", + "safety checks", + "safety checks activate", + "safety checks activate browser", + "safety checks activate chrome", + "safety checks activate google", + "safety checks activate google chrome", + "safety checks browser", + "safety checks browser activate", + "safety checks browser perform", + "safety checks browser run", + "safety checks browser use", + "safety checks chrome", + "safety checks chrome activate", + "safety checks chrome perform", + "safety checks chrome run", + "safety checks chrome use", + "safety checks google", + "safety checks google activate", + "safety checks google chrome", + "safety checks google chrome activate", + "safety checks google chrome perform", + "safety checks google chrome run", + "safety checks google chrome use", + "safety checks google perform", + "safety checks google run", + "safety checks google use", + "safety checks perform", + "safety checks perform browser", + "safety checks perform chrome", + "safety checks perform google", + "safety checks perform google chrome", + "safety checks run", + "safety checks run browser", + "safety checks run chrome", + "safety checks run google", + "safety checks run google chrome", + "safety checks use", + "safety checks use browser", + "safety checks use chrome", + "safety checks use google", + "safety checks use google chrome", + "safety checkup", + "safety checkup activate", + "safety checkup activate browser", + "safety checkup activate chrome", + "safety checkup activate google", + "safety checkup activate google chrome", + "safety checkup browser", + "safety checkup browser activate", + "safety checkup browser perform", + "safety checkup browser run", + "safety checkup browser use", + "safety checkup chrome", + "safety checkup chrome activate", + "safety checkup chrome perform", + "safety checkup chrome run", + "safety checkup chrome use", + "safety checkup google", + "safety checkup google activate", + "safety checkup google chrome", + "safety checkup google chrome activate", + "safety checkup google chrome perform", + "safety checkup google chrome run", + "safety checkup google chrome use", + "safety checkup google perform", + "safety checkup google run", + "safety checkup google use", + "safety checkup perform", + "safety checkup perform browser", + "safety checkup perform chrome", + "safety checkup perform google", + "safety checkup perform google chrome", + "safety checkup run", + "safety checkup run browser", + "safety checkup run chrome", + "safety checkup run google", + "safety checkup run google chrome", + "safety checkup use", + "safety checkup use browser", + "safety checkup use chrome", + "safety checkup use google", + "safety checkup use google chrome", + "safety chrome activate check", + "safety chrome activate checks", + "safety chrome activate checkup", + "safety chrome check", + "safety chrome check activate", + "safety chrome check perform", + "safety chrome check run", + "safety chrome check use", + "safety chrome checks", + "safety chrome checks activate", + "safety chrome checks perform", + "safety chrome checks run", + "safety chrome checks use", + "safety chrome checkup", + "safety chrome checkup activate", + "safety chrome checkup perform", + "safety chrome checkup run", + "safety chrome checkup use", + "safety chrome perform check", + "safety chrome perform checks", + "safety chrome perform checkup", + "safety chrome run check", + "safety chrome run checks", + "safety chrome run checkup", + "safety chrome use check", + "safety chrome use checks", + "safety chrome use checkup", + "safety google activate check", + "safety google activate checks", + "safety google activate checkup", + "safety google check", + "safety google check activate", + "safety google check perform", + "safety google check run", + "safety google check use", + "safety google checks", + "safety google checks activate", + "safety google checks perform", + "safety google checks run", + "safety google checks use", + "safety google checkup", + "safety google checkup activate", + "safety google checkup perform", + "safety google checkup run", + "safety google checkup use", + "safety google chrome activate check", + "safety google chrome activate checks", + "safety google chrome activate checkup", + "safety google chrome check", + "safety google chrome check activate", + "safety google chrome check perform", + "safety google chrome check run", + "safety google chrome check use", + "safety google chrome checks", + "safety google chrome checks activate", + "safety google chrome checks perform", + "safety google chrome checks run", + "safety google chrome checks use", + "safety google chrome checkup", + "safety google chrome checkup activate", + "safety google chrome checkup perform", + "safety google chrome checkup run", + "safety google chrome checkup use", + "safety google chrome perform check", + "safety google chrome perform checks", + "safety google chrome perform checkup", + "safety google chrome run check", + "safety google chrome run checks", + "safety google chrome run checkup", + "safety google chrome use check", + "safety google chrome use checks", + "safety google chrome use checkup", + "safety google perform check", + "safety google perform checks", + "safety google perform checkup", + "safety google run check", + "safety google run checks", + "safety google run checkup", + "safety google use check", + "safety google use checks", + "safety google use checkup", + "safety perform browser check", + "safety perform browser checks", + "safety perform browser checkup", + "safety perform check", + "safety perform check browser", + "safety perform check chrome", + "safety perform check google", + "safety perform check google chrome", + "safety perform checks", + "safety perform checks browser", + "safety perform checks chrome", + "safety perform checks google", + "safety perform checks google chrome", + "safety perform checkup", + "safety perform checkup browser", + "safety perform checkup chrome", + "safety perform checkup google", + "safety perform checkup google chrome", + "safety perform chrome check", + "safety perform chrome checks", + "safety perform chrome checkup", + "safety perform google check", + "safety perform google checks", + "safety perform google checkup", + "safety perform google chrome check", + "safety perform google chrome checks", + "safety perform google chrome checkup", + "safety run browser check", + "safety run browser checks", + "safety run browser checkup", + "safety run check", + "safety run check browser", + "safety run check chrome", + "safety run check google", + "safety run check google chrome", + "safety run checks", + "safety run checks browser", + "safety run checks chrome", + "safety run checks google", + "safety run checks google chrome", + "safety run checkup", + "safety run checkup browser", + "safety run checkup chrome", + "safety run checkup google", + "safety run checkup google chrome", + "safety run chrome check", + "safety run chrome checks", + "safety run chrome checkup", + "safety run google check", + "safety run google checks", + "safety run google checkup", + "safety run google chrome check", + "safety run google chrome checks", + "safety run google chrome checkup", + "safety use browser check", + "safety use browser checks", + "safety use browser checkup", + "safety use check", + "safety use check browser", + "safety use check chrome", + "safety use check google", + "safety use check google chrome", + "safety use checks", + "safety use checks browser", + "safety use checks chrome", + "safety use checks google", + "safety use checks google chrome", + "safety use checkup", + "safety use checkup browser", + "safety use checkup chrome", + "safety use checkup google", + "safety use checkup google chrome", + "safety use chrome check", + "safety use chrome checks", + "safety use chrome checkup", + "safety use google check", + "safety use google checks", + "safety use google checkup", + "safety use google chrome check", + "safety use google chrome checks", + "safety use google chrome checkup", + "security activate browser check", + "security activate browser checks", + "security activate browser checkup", + "security activate check", + "security activate check browser", + "security activate check chrome", + "security activate check google", + "security activate check google chrome", + "security activate checks", + "security activate checks browser", + "security activate checks chrome", + "security activate checks google", + "security activate checks google chrome", + "security activate checkup", + "security activate checkup browser", + "security activate checkup chrome", + "security activate checkup google", + "security activate checkup google chrome", + "security activate chrome check", + "security activate chrome checks", + "security activate chrome checkup", + "security activate google check", + "security activate google checks", + "security activate google checkup", + "security activate google chrome check", + "security activate google chrome checks", + "security activate google chrome checkup", + "security browser activate check", + "security browser activate checks", + "security browser activate checkup", + "security browser check", + "security browser check activate", + "security browser check perform", + "security browser check run", + "security browser check use", + "security browser checks", + "security browser checks activate", + "security browser checks perform", + "security browser checks run", + "security browser checks use", + "security browser checkup", + "security browser checkup activate", + "security browser checkup perform", + "security browser checkup run", + "security browser checkup use", + "security browser perform check", + "security browser perform checks", + "security browser perform checkup", + "security browser run check", + "security browser run checks", + "security browser run checkup", + "security browser use check", + "security browser use checks", + "security browser use checkup", + "security check", + "security check activate", + "security check activate browser", + "security check activate chrome", + "security check activate google", + "security check activate google chrome", + "security check browser", + "security check browser activate", + "security check browser perform", + "security check browser run", + "security check browser use", + "security check chrome", + "security check chrome activate", + "security check chrome perform", + "security check chrome run", + "security check chrome use", + "security check google", + "security check google activate", + "security check google chrome", + "security check google chrome activate", + "security check google chrome perform", + "security check google chrome run", + "security check google chrome use", + "security check google perform", + "security check google run", + "security check google use", + "security check perform", + "security check perform browser", + "security check perform chrome", + "security check perform google", + "security check perform google chrome", + "security check run", + "security check run browser", + "security check run chrome", + "security check run google", + "security check run google chrome", + "security check use", + "security check use browser", + "security check use chrome", + "security check use google", + "security check use google chrome", + "security checks", + "security checks activate", + "security checks activate browser", + "security checks activate chrome", + "security checks activate google", + "security checks activate google chrome", + "security checks browser", + "security checks browser activate", + "security checks browser perform", + "security checks browser run", + "security checks browser use", + "security checks chrome", + "security checks chrome activate", + "security checks chrome perform", + "security checks chrome run", + "security checks chrome use", + "security checks google", + "security checks google activate", + "security checks google chrome", + "security checks google chrome activate", + "security checks google chrome perform", + "security checks google chrome run", + "security checks google chrome use", + "security checks google perform", + "security checks google run", + "security checks google use", + "security checks perform", + "security checks perform browser", + "security checks perform chrome", + "security checks perform google", + "security checks perform google chrome", + "security checks run", + "security checks run browser", + "security checks run chrome", + "security checks run google", + "security checks run google chrome", + "security checks use", + "security checks use browser", + "security checks use chrome", + "security checks use google", + "security checks use google chrome", + "security checkup", + "security checkup activate", + "security checkup activate browser", + "security checkup activate chrome", + "security checkup activate google", + "security checkup activate google chrome", + "security checkup browser", + "security checkup browser activate", + "security checkup browser perform", + "security checkup browser run", + "security checkup browser use", + "security checkup chrome", + "security checkup chrome activate", + "security checkup chrome perform", + "security checkup chrome run", + "security checkup chrome use", + "security checkup google", + "security checkup google activate", + "security checkup google chrome", + "security checkup google chrome activate", + "security checkup google chrome perform", + "security checkup google chrome run", + "security checkup google chrome use", + "security checkup google perform", + "security checkup google run", + "security checkup google use", + "security checkup perform", + "security checkup perform browser", + "security checkup perform chrome", + "security checkup perform google", + "security checkup perform google chrome", + "security checkup run", + "security checkup run browser", + "security checkup run chrome", + "security checkup run google", + "security checkup run google chrome", + "security checkup use", + "security checkup use browser", + "security checkup use chrome", + "security checkup use google", + "security checkup use google chrome", + "security chrome activate check", + "security chrome activate checks", + "security chrome activate checkup", + "security chrome check", + "security chrome check activate", + "security chrome check perform", + "security chrome check run", + "security chrome check use", + "security chrome checks", + "security chrome checks activate", + "security chrome checks perform", + "security chrome checks run", + "security chrome checks use", + "security chrome checkup", + "security chrome checkup activate", + "security chrome checkup perform", + "security chrome checkup run", + "security chrome checkup use", + "security chrome perform check", + "security chrome perform checks", + "security chrome perform checkup", + "security chrome run check", + "security chrome run checks", + "security chrome run checkup", + "security chrome use check", + "security chrome use checks", + "security chrome use checkup", + "security google activate check", + "security google activate checks", + "security google activate checkup", + "security google check", + "security google check activate", + "security google check perform", + "security google check run", + "security google check use", + "security google checks", + "security google checks activate", + "security google checks perform", + "security google checks run", + "security google checks use", + "security google checkup", + "security google checkup activate", + "security google checkup perform", + "security google checkup run", + "security google checkup use", + "security google chrome activate check", + "security google chrome activate checks", + "security google chrome activate checkup", + "security google chrome check", + "security google chrome check activate", + "security google chrome check perform", + "security google chrome check run", + "security google chrome check use", + "security google chrome checks", + "security google chrome checks activate", + "security google chrome checks perform", + "security google chrome checks run", + "security google chrome checks use", + "security google chrome checkup", + "security google chrome checkup activate", + "security google chrome checkup perform", + "security google chrome checkup run", + "security google chrome checkup use", + "security google chrome perform check", + "security google chrome perform checks", + "security google chrome perform checkup", + "security google chrome run check", + "security google chrome run checks", + "security google chrome run checkup", + "security google chrome use check", + "security google chrome use checks", + "security google chrome use checkup", + "security google perform check", + "security google perform checks", + "security google perform checkup", + "security google run check", + "security google run checks", + "security google run checkup", + "security google use check", + "security google use checks", + "security google use checkup", + "security perform browser check", + "security perform browser checks", + "security perform browser checkup", + "security perform check", + "security perform check browser", + "security perform check chrome", + "security perform check google", + "security perform check google chrome", + "security perform checks", + "security perform checks browser", + "security perform checks chrome", + "security perform checks google", + "security perform checks google chrome", + "security perform checkup", + "security perform checkup browser", + "security perform checkup chrome", + "security perform checkup google", + "security perform checkup google chrome", + "security perform chrome check", + "security perform chrome checks", + "security perform chrome checkup", + "security perform google check", + "security perform google checks", + "security perform google checkup", + "security perform google chrome check", + "security perform google chrome checks", + "security perform google chrome checkup", + "security run browser check", + "security run browser checks", + "security run browser checkup", + "security run check", + "security run check browser", + "security run check chrome", + "security run check google", + "security run check google chrome", + "security run checks", + "security run checks browser", + "security run checks chrome", + "security run checks google", + "security run checks google chrome", + "security run checkup", + "security run checkup browser", + "security run checkup chrome", + "security run checkup google", + "security run checkup google chrome", + "security run chrome check", + "security run chrome checks", + "security run chrome checkup", + "security run google check", + "security run google checks", + "security run google checkup", + "security run google chrome check", + "security run google chrome checks", + "security run google chrome checkup", + "security use browser check", + "security use browser checks", + "security use browser checkup", + "security use check", + "security use check browser", + "security use check chrome", + "security use check google", + "security use check google chrome", + "security use checks", + "security use checks browser", + "security use checks chrome", + "security use checks google", + "security use checks google chrome", + "security use checkup", + "security use checkup browser", + "security use checkup chrome", + "security use checkup google", + "security use checkup google chrome", + "security use chrome check", + "security use chrome checks", + "security use chrome checkup", + "security use google check", + "security use google checks", + "security use google checkup", + "security use google chrome check", + "security use google chrome checks", + "security use google chrome checkup", + "use browser check password", + "use browser check passwords", + "use browser check safety", + "use browser check security", + "use browser checks password", + "use browser checks passwords", + "use browser checks safety", + "use browser checks security", + "use browser checkup password", + "use browser checkup passwords", + "use browser checkup safety", + "use browser checkup security", + "use browser password check", + "use browser password checks", + "use browser password checkup", + "use browser passwords check", + "use browser passwords checks", + "use browser passwords checkup", + "use browser safety check", + "use browser safety checks", + "use browser safety checkup", + "use browser security check", + "use browser security checks", + "use browser security checkup", + "use check browser password", + "use check browser passwords", + "use check browser safety", + "use check browser security", + "use check chrome password", + "use check chrome passwords", + "use check chrome safety", + "use check chrome security", + "use check google chrome password", + "use check google chrome passwords", + "use check google chrome safety", + "use check google chrome security", + "use check google password", + "use check google passwords", + "use check google safety", + "use check google security", + "use check password", + "use check password browser", + "use check password chrome", + "use check password google", + "use check password google chrome", + "use check passwords", + "use check passwords browser", + "use check passwords chrome", + "use check passwords google", + "use check passwords google chrome", + "use check safety", + "use check safety browser", + "use check safety chrome", + "use check safety google", + "use check safety google chrome", + "use check security", + "use check security browser", + "use check security chrome", + "use check security google", + "use check security google chrome", + "use checks browser password", + "use checks browser passwords", + "use checks browser safety", + "use checks browser security", + "use checks chrome password", + "use checks chrome passwords", + "use checks chrome safety", + "use checks chrome security", + "use checks google chrome password", + "use checks google chrome passwords", + "use checks google chrome safety", + "use checks google chrome security", + "use checks google password", + "use checks google passwords", + "use checks google safety", + "use checks google security", + "use checks password", + "use checks password browser", + "use checks password chrome", + "use checks password google", + "use checks password google chrome", + "use checks passwords", + "use checks passwords browser", + "use checks passwords chrome", + "use checks passwords google", + "use checks passwords google chrome", + "use checks safety", + "use checks safety browser", + "use checks safety chrome", + "use checks safety google", + "use checks safety google chrome", + "use checks security", + "use checks security browser", + "use checks security chrome", + "use checks security google", + "use checks security google chrome", + "use checkup browser password", + "use checkup browser passwords", + "use checkup browser safety", + "use checkup browser security", + "use checkup chrome password", + "use checkup chrome passwords", + "use checkup chrome safety", + "use checkup chrome security", + "use checkup google chrome password", + "use checkup google chrome passwords", + "use checkup google chrome safety", + "use checkup google chrome security", + "use checkup google password", + "use checkup google passwords", + "use checkup google safety", + "use checkup google security", + "use checkup password", + "use checkup password browser", + "use checkup password chrome", + "use checkup password google", + "use checkup password google chrome", + "use checkup passwords", + "use checkup passwords browser", + "use checkup passwords chrome", + "use checkup passwords google", + "use checkup passwords google chrome", + "use checkup safety", + "use checkup safety browser", + "use checkup safety chrome", + "use checkup safety google", + "use checkup safety google chrome", + "use checkup security", + "use checkup security browser", + "use checkup security chrome", + "use checkup security google", + "use checkup security google chrome", + "use chrome check password", + "use chrome check passwords", + "use chrome check safety", + "use chrome check security", + "use chrome checks password", + "use chrome checks passwords", + "use chrome checks safety", + "use chrome checks security", + "use chrome checkup password", + "use chrome checkup passwords", + "use chrome checkup safety", + "use chrome checkup security", + "use chrome password check", + "use chrome password checks", + "use chrome password checkup", + "use chrome passwords check", + "use chrome passwords checks", + "use chrome passwords checkup", + "use chrome safety check", + "use chrome safety checks", + "use chrome safety checkup", + "use chrome security check", + "use chrome security checks", + "use chrome security checkup", + "use google check password", + "use google check passwords", + "use google check safety", + "use google check security", + "use google checks password", + "use google checks passwords", + "use google checks safety", + "use google checks security", + "use google checkup password", + "use google checkup passwords", + "use google checkup safety", + "use google checkup security", + "use google chrome check password", + "use google chrome check passwords", + "use google chrome check safety", + "use google chrome check security", + "use google chrome checks password", + "use google chrome checks passwords", + "use google chrome checks safety", + "use google chrome checks security", + "use google chrome checkup password", + "use google chrome checkup passwords", + "use google chrome checkup safety", + "use google chrome checkup security", + "use google chrome password check", + "use google chrome password checks", + "use google chrome password checkup", + "use google chrome passwords check", + "use google chrome passwords checks", + "use google chrome passwords checkup", + "use google chrome safety check", + "use google chrome safety checks", + "use google chrome safety checkup", + "use google chrome security check", + "use google chrome security checks", + "use google chrome security checkup", + "use google password check", + "use google password checks", + "use google password checkup", + "use google passwords check", + "use google passwords checks", + "use google passwords checkup", + "use google safety check", + "use google safety checks", + "use google safety checkup", + "use google security check", + "use google security checks", + "use google security checkup", + "use password browser check", + "use password browser checks", + "use password browser checkup", + "use password check", + "use password check browser", + "use password check chrome", + "use password check google", + "use password check google chrome", + "use password checks", + "use password checks browser", + "use password checks chrome", + "use password checks google", + "use password checks google chrome", + "use password checkup", + "use password checkup browser", + "use password checkup chrome", + "use password checkup google", + "use password checkup google chrome", + "use password chrome check", + "use password chrome checks", + "use password chrome checkup", + "use password google check", + "use password google checks", + "use password google checkup", + "use password google chrome check", + "use password google chrome checks", + "use password google chrome checkup", + "use passwords browser check", + "use passwords browser checks", + "use passwords browser checkup", + "use passwords check", + "use passwords check browser", + "use passwords check chrome", + "use passwords check google", + "use passwords check google chrome", + "use passwords checks", + "use passwords checks browser", + "use passwords checks chrome", + "use passwords checks google", + "use passwords checks google chrome", + "use passwords checkup", + "use passwords checkup browser", + "use passwords checkup chrome", + "use passwords checkup google", + "use passwords checkup google chrome", + "use passwords chrome check", + "use passwords chrome checks", + "use passwords chrome checkup", + "use passwords google check", + "use passwords google checks", + "use passwords google checkup", + "use passwords google chrome check", + "use passwords google chrome checks", + "use passwords google chrome checkup", + "use safety browser check", + "use safety browser checks", + "use safety browser checkup", + "use safety check", + "use safety check browser", + "use safety check chrome", + "use safety check google", + "use safety check google chrome", + "use safety checks", + "use safety checks browser", + "use safety checks chrome", + "use safety checks google", + "use safety checks google chrome", + "use safety checkup", + "use safety checkup browser", + "use safety checkup chrome", + "use safety checkup google", + "use safety checkup google chrome", + "use safety chrome check", + "use safety chrome checks", + "use safety chrome checkup", + "use safety google check", + "use safety google checks", + "use safety google checkup", + "use safety google chrome check", + "use safety google chrome checks", + "use safety google chrome checkup", + "use security browser check", + "use security browser checks", + "use security browser checkup", + "use security check", + "use security check browser", + "use security check chrome", + "use security check google", + "use security check google chrome", + "use security checks", + "use security checks browser", + "use security checks chrome", + "use security checks google", + "use security checks google chrome", + "use security checkup", + "use security checkup browser", + "use security checkup chrome", + "use security checkup google", + "use security checkup google chrome", + "use security chrome check", + "use security chrome checks", + "use security chrome checkup", + "use security google check", + "use security google checks", + "use security google checkup", + "use security google chrome check", + "use security google chrome checks", + "use security google chrome checkup", + }, + + // ID#8 + { + // Generated suggestions: + "alter browse certificates", + "alter browse enhanced protection", + "alter browse safely", + "alter browse secure dns", + "alter browse securely", + "alter browse security keys", + "alter browse security settings", + "alter browse standard protection", + "alter browser certificates", + "alter browser enhanced protection", + "alter browser safely", + "alter browser secure dns", + "alter browser securely", + "alter browser security keys", + "alter browser security settings", + "alter browser standard protection", + "alter browsing certificates", + "alter browsing enhanced protection", + "alter browsing safely", + "alter browsing secure dns", + "alter browsing securely", + "alter browsing security keys", + "alter browsing security settings", + "alter browsing standard protection", + "alter certificates", + "alter certificates browse", + "alter certificates browser", + "alter certificates browsing", + "alter certificates change", + "alter certificates chrome", + "alter certificates google", + "alter certificates google chrome", + "alter certificates manage", + "alter change certificates", + "alter change enhanced protection", + "alter change safely", + "alter change secure dns", + "alter change securely", + "alter change security keys", + "alter change security settings", + "alter change standard protection", + "alter chrome certificates", + "alter chrome enhanced protection", + "alter chrome safely", + "alter chrome secure dns", + "alter chrome securely", + "alter chrome security keys", + "alter chrome security settings", + "alter chrome standard protection", + "alter enhanced protection", + "alter enhanced protection browse", + "alter enhanced protection browser", + "alter enhanced protection browsing", + "alter enhanced protection change", + "alter enhanced protection chrome", + "alter enhanced protection google", + "alter enhanced protection google chrome", + "alter enhanced protection manage", + "alter google certificates", + "alter google chrome certificates", + "alter google chrome enhanced protection", + "alter google chrome safely", + "alter google chrome secure dns", + "alter google chrome securely", + "alter google chrome security keys", + "alter google chrome security settings", + "alter google chrome standard protection", + "alter google enhanced protection", + "alter google safely", + "alter google secure dns", + "alter google securely", + "alter google security keys", + "alter google security settings", + "alter google standard protection", + "alter manage certificates", + "alter manage enhanced protection", + "alter manage safely", + "alter manage secure dns", + "alter manage securely", + "alter manage security keys", + "alter manage security settings", + "alter manage standard protection", + "alter safely", + "alter safely browse", + "alter safely browser", + "alter safely browsing", + "alter safely change", + "alter safely chrome", + "alter safely google", + "alter safely google chrome", + "alter safely manage", + "alter secure dns", + "alter secure dns browse", + "alter secure dns browser", + "alter secure dns browsing", + "alter secure dns change", + "alter secure dns chrome", + "alter secure dns google", + "alter secure dns google chrome", + "alter secure dns manage", + "alter securely", + "alter securely browse", + "alter securely browser", + "alter securely browsing", + "alter securely change", + "alter securely chrome", + "alter securely google", + "alter securely google chrome", + "alter securely manage", + "alter security keys", + "alter security keys browse", + "alter security keys browser", + "alter security keys browsing", + "alter security keys change", + "alter security keys chrome", + "alter security keys google", + "alter security keys google chrome", + "alter security keys manage", + "alter security settings", + "alter security settings browse", + "alter security settings browser", + "alter security settings browsing", + "alter security settings change", + "alter security settings chrome", + "alter security settings google", + "alter security settings google chrome", + "alter security settings manage", + "alter standard protection", + "alter standard protection browse", + "alter standard protection browser", + "alter standard protection browsing", + "alter standard protection change", + "alter standard protection chrome", + "alter standard protection google", + "alter standard protection google chrome", + "alter standard protection manage", + "browse alter certificates", + "browse alter enhanced protection", + "browse alter safely", + "browse alter secure dns", + "browse alter securely", + "browse alter security keys", + "browse alter security settings", + "browse alter standard protection", + "browse certificates", + "browse certificates alter", + "browse certificates use", + "browse enhanced protection", + "browse enhanced protection alter", + "browse enhanced protection use", + "browse safely", + "browse safely alter", + "browse safely use", + "browse secure dns", + "browse secure dns alter", + "browse secure dns use", + "browse securely", + "browse securely alter", + "browse securely use", + "browse security keys", + "browse security keys alter", + "browse security keys use", + "browse security settings", + "browse security settings alter", + "browse security settings use", + "browse standard protection", + "browse standard protection alter", + "browse standard protection use", + "browse use certificates", + "browse use enhanced protection", + "browse use safely", + "browse use secure dns", + "browse use securely", + "browse use security keys", + "browse use security settings", + "browse use standard protection", + "browser alter certificates", + "browser alter enhanced protection", + "browser alter safely", + "browser alter secure dns", + "browser alter securely", + "browser alter security keys", + "browser alter security settings", + "browser alter standard protection", + "browser certificates", + "browser certificates alter", + "browser certificates use", + "browser enhanced protection", + "browser enhanced protection alter", + "browser enhanced protection use", + "browser safely", + "browser safely alter", + "browser safely use", + "browser secure dns", + "browser secure dns alter", + "browser secure dns use", + "browser securely", + "browser securely alter", + "browser securely use", + "browser security keys", + "browser security keys alter", + "browser security keys use", + "browser security settings", + "browser security settings alter", + "browser security settings use", + "browser standard protection", + "browser standard protection alter", + "browser standard protection use", + "browser use certificates", + "browser use enhanced protection", + "browser use safely", + "browser use secure dns", + "browser use securely", + "browser use security keys", + "browser use security settings", + "browser use standard protection", + "browsing alter certificates", + "browsing alter enhanced protection", + "browsing alter safely", + "browsing alter secure dns", + "browsing alter securely", + "browsing alter security keys", + "browsing alter security settings", + "browsing alter standard protection", + "browsing certificates", + "browsing certificates alter", + "browsing certificates use", + "browsing enhanced protection", + "browsing enhanced protection alter", + "browsing enhanced protection use", + "browsing safely", + "browsing safely alter", + "browsing safely use", + "browsing secure dns", + "browsing secure dns alter", + "browsing secure dns use", + "browsing securely", + "browsing securely alter", + "browsing securely use", + "browsing security keys", + "browsing security keys alter", + "browsing security keys use", + "browsing security settings", + "browsing security settings alter", + "browsing security settings use", + "browsing standard protection", + "browsing standard protection alter", + "browsing standard protection use", + "browsing use certificates", + "browsing use enhanced protection", + "browsing use safely", + "browsing use secure dns", + "browsing use securely", + "browsing use security keys", + "browsing use security settings", + "browsing use standard protection", + "certificates", + "certificates alter", + "certificates alter browse", + "certificates alter browser", + "certificates alter browsing", + "certificates alter change", + "certificates alter chrome", + "certificates alter google", + "certificates alter google chrome", + "certificates alter manage", + "certificates browse", + "certificates browse alter", + "certificates browse use", + "certificates browser", + "certificates browser alter", + "certificates browser use", + "certificates browsing", + "certificates browsing alter", + "certificates browsing use", + "certificates change", + "certificates change alter", + "certificates change use", + "certificates chrome", + "certificates chrome alter", + "certificates chrome use", + "certificates google", + "certificates google alter", + "certificates google chrome", + "certificates google chrome alter", + "certificates google chrome use", + "certificates google use", + "certificates manage", + "certificates manage alter", + "certificates manage use", + "certificates use", + "certificates use browse", + "certificates use browser", + "certificates use browsing", + "certificates use change", + "certificates use chrome", + "certificates use google", + "certificates use google chrome", + "certificates use manage", + "change alter certificates", + "change alter enhanced protection", + "change alter safely", + "change alter secure dns", + "change alter securely", + "change alter security keys", + "change alter security settings", + "change alter standard protection", + "change certificates", + "change certificates alter", + "change certificates use", + "change enhanced protection", + "change enhanced protection alter", + "change enhanced protection use", + "change safely", + "change safely alter", + "change safely use", + "change secure dns", + "change secure dns alter", + "change secure dns use", + "change securely", + "change securely alter", + "change securely use", + "change security keys", + "change security keys alter", + "change security keys use", + "change security settings", + "change security settings alter", + "change security settings use", + "change standard protection", + "change standard protection alter", + "change standard protection use", + "change use certificates", + "change use enhanced protection", + "change use safely", + "change use secure dns", + "change use securely", + "change use security keys", + "change use security settings", + "change use standard protection", + "chrome alter certificates", + "chrome alter enhanced protection", + "chrome alter safely", + "chrome alter secure dns", + "chrome alter securely", + "chrome alter security keys", + "chrome alter security settings", + "chrome alter standard protection", + "chrome certificates", + "chrome certificates alter", + "chrome certificates use", + "chrome enhanced protection", + "chrome enhanced protection alter", + "chrome enhanced protection use", + "chrome safely", + "chrome safely alter", + "chrome safely use", + "chrome secure dns", + "chrome secure dns alter", + "chrome secure dns use", + "chrome securely", + "chrome securely alter", + "chrome securely use", + "chrome security keys", + "chrome security keys alter", + "chrome security keys use", + "chrome security settings", + "chrome security settings alter", + "chrome security settings use", + "chrome standard protection", + "chrome standard protection alter", + "chrome standard protection use", + "chrome use certificates", + "chrome use enhanced protection", + "chrome use safely", + "chrome use secure dns", + "chrome use securely", + "chrome use security keys", + "chrome use security settings", + "chrome use standard protection", + "enhanced protection", + "enhanced protection alter", + "enhanced protection alter browse", + "enhanced protection alter browser", + "enhanced protection alter browsing", + "enhanced protection alter change", + "enhanced protection alter chrome", + "enhanced protection alter google", + "enhanced protection alter google chrome", + "enhanced protection alter manage", + "enhanced protection browse", + "enhanced protection browse alter", + "enhanced protection browse use", + "enhanced protection browser", + "enhanced protection browser alter", + "enhanced protection browser use", + "enhanced protection browsing", + "enhanced protection browsing alter", + "enhanced protection browsing use", + "enhanced protection change", + "enhanced protection change alter", + "enhanced protection change use", + "enhanced protection chrome", + "enhanced protection chrome alter", + "enhanced protection chrome use", + "enhanced protection google", + "enhanced protection google alter", + "enhanced protection google chrome", + "enhanced protection google chrome alter", + "enhanced protection google chrome use", + "enhanced protection google use", + "enhanced protection manage", + "enhanced protection manage alter", + "enhanced protection manage use", + "enhanced protection use", + "enhanced protection use browse", + "enhanced protection use browser", + "enhanced protection use browsing", + "enhanced protection use change", + "enhanced protection use chrome", + "enhanced protection use google", + "enhanced protection use google chrome", + "enhanced protection use manage", + "google alter certificates", + "google alter enhanced protection", + "google alter safely", + "google alter secure dns", + "google alter securely", + "google alter security keys", + "google alter security settings", + "google alter standard protection", + "google certificates", + "google certificates alter", + "google certificates use", + "google chrome alter certificates", + "google chrome alter enhanced protection", + "google chrome alter safely", + "google chrome alter secure dns", + "google chrome alter securely", + "google chrome alter security keys", + "google chrome alter security settings", + "google chrome alter standard protection", + "google chrome certificates", + "google chrome certificates alter", + "google chrome certificates use", + "google chrome enhanced protection", + "google chrome enhanced protection alter", + "google chrome enhanced protection use", + "google chrome safely", + "google chrome safely alter", + "google chrome safely use", + "google chrome secure dns", + "google chrome secure dns alter", + "google chrome secure dns use", + "google chrome securely", + "google chrome securely alter", + "google chrome securely use", + "google chrome security keys", + "google chrome security keys alter", + "google chrome security keys use", + "google chrome security settings", + "google chrome security settings alter", + "google chrome security settings use", + "google chrome standard protection", + "google chrome standard protection alter", + "google chrome standard protection use", + "google chrome use certificates", + "google chrome use enhanced protection", + "google chrome use safely", + "google chrome use secure dns", + "google chrome use securely", + "google chrome use security keys", + "google chrome use security settings", + "google chrome use standard protection", + "google enhanced protection", + "google enhanced protection alter", + "google enhanced protection use", + "google safely", + "google safely alter", + "google safely use", + "google secure dns", + "google secure dns alter", + "google secure dns use", + "google securely", + "google securely alter", + "google securely use", + "google security keys", + "google security keys alter", + "google security keys use", + "google security settings", + "google security settings alter", + "google security settings use", + "google standard protection", + "google standard protection alter", + "google standard protection use", + "google use certificates", + "google use enhanced protection", + "google use safely", + "google use secure dns", + "google use securely", + "google use security keys", + "google use security settings", + "google use standard protection", + "manage alter certificates", + "manage alter enhanced protection", + "manage alter safely", + "manage alter secure dns", + "manage alter securely", + "manage alter security keys", + "manage alter security settings", + "manage alter standard protection", + "manage certificates", + "manage certificates alter", + "manage certificates use", + "manage enhanced protection", + "manage enhanced protection alter", + "manage enhanced protection use", + "manage safely", + "manage safely alter", + "manage safely use", + "manage secure dns", + "manage secure dns alter", + "manage secure dns use", + "manage securely", + "manage securely alter", + "manage securely use", + "manage security keys", + "manage security keys alter", + "manage security keys use", + "manage security settings", + "manage security settings alter", + "manage security settings use", + "manage standard protection", + "manage standard protection alter", + "manage standard protection use", + "manage use certificates", + "manage use enhanced protection", + "manage use safely", + "manage use secure dns", + "manage use securely", + "manage use security keys", + "manage use security settings", + "manage use standard protection", + "safely", + "safely alter", + "safely alter browse", + "safely alter browser", + "safely alter browsing", + "safely alter change", + "safely alter chrome", + "safely alter google", + "safely alter google chrome", + "safely alter manage", + "safely browse", + "safely browse alter", + "safely browse use", + "safely browser", + "safely browser alter", + "safely browser use", + "safely browsing", + "safely browsing alter", + "safely browsing use", + "safely change", + "safely change alter", + "safely change use", + "safely chrome", + "safely chrome alter", + "safely chrome use", + "safely google", + "safely google alter", + "safely google chrome", + "safely google chrome alter", + "safely google chrome use", + "safely google use", + "safely manage", + "safely manage alter", + "safely manage use", + "safely use", + "safely use browse", + "safely use browser", + "safely use browsing", + "safely use change", + "safely use chrome", + "safely use google", + "safely use google chrome", + "safely use manage", + "secure dns", + "secure dns alter", + "secure dns alter browse", + "secure dns alter browser", + "secure dns alter browsing", + "secure dns alter change", + "secure dns alter chrome", + "secure dns alter google", + "secure dns alter google chrome", + "secure dns alter manage", + "secure dns browse", + "secure dns browse alter", + "secure dns browse use", + "secure dns browser", + "secure dns browser alter", + "secure dns browser use", + "secure dns browsing", + "secure dns browsing alter", + "secure dns browsing use", + "secure dns change", + "secure dns change alter", + "secure dns change use", + "secure dns chrome", + "secure dns chrome alter", + "secure dns chrome use", + "secure dns google", + "secure dns google alter", + "secure dns google chrome", + "secure dns google chrome alter", + "secure dns google chrome use", + "secure dns google use", + "secure dns manage", + "secure dns manage alter", + "secure dns manage use", + "secure dns use", + "secure dns use browse", + "secure dns use browser", + "secure dns use browsing", + "secure dns use change", + "secure dns use chrome", + "secure dns use google", + "secure dns use google chrome", + "secure dns use manage", + "securely", + "securely alter", + "securely alter browse", + "securely alter browser", + "securely alter browsing", + "securely alter change", + "securely alter chrome", + "securely alter google", + "securely alter google chrome", + "securely alter manage", + "securely browse", + "securely browse alter", + "securely browse use", + "securely browser", + "securely browser alter", + "securely browser use", + "securely browsing", + "securely browsing alter", + "securely browsing use", + "securely change", + "securely change alter", + "securely change use", + "securely chrome", + "securely chrome alter", + "securely chrome use", + "securely google", + "securely google alter", + "securely google chrome", + "securely google chrome alter", + "securely google chrome use", + "securely google use", + "securely manage", + "securely manage alter", + "securely manage use", + "securely use", + "securely use browse", + "securely use browser", + "securely use browsing", + "securely use change", + "securely use chrome", + "securely use google", + "securely use google chrome", + "securely use manage", + "security keys", + "security keys alter", + "security keys alter browse", + "security keys alter browser", + "security keys alter browsing", + "security keys alter change", + "security keys alter chrome", + "security keys alter google", + "security keys alter google chrome", + "security keys alter manage", + "security keys browse", + "security keys browse alter", + "security keys browse use", + "security keys browser", + "security keys browser alter", + "security keys browser use", + "security keys browsing", + "security keys browsing alter", + "security keys browsing use", + "security keys change", + "security keys change alter", + "security keys change use", + "security keys chrome", + "security keys chrome alter", + "security keys chrome use", + "security keys google", + "security keys google alter", + "security keys google chrome", + "security keys google chrome alter", + "security keys google chrome use", + "security keys google use", + "security keys manage", + "security keys manage alter", + "security keys manage use", + "security keys use", + "security keys use browse", + "security keys use browser", + "security keys use browsing", + "security keys use change", + "security keys use chrome", + "security keys use google", + "security keys use google chrome", + "security keys use manage", + "security settings", + "security settings alter", + "security settings alter browse", + "security settings alter browser", + "security settings alter browsing", + "security settings alter change", + "security settings alter chrome", + "security settings alter google", + "security settings alter google chrome", + "security settings alter manage", + "security settings browse", + "security settings browse alter", + "security settings browse use", + "security settings browser", + "security settings browser alter", + "security settings browser use", + "security settings browsing", + "security settings browsing alter", + "security settings browsing use", + "security settings change", + "security settings change alter", + "security settings change use", + "security settings chrome", + "security settings chrome alter", + "security settings chrome use", + "security settings google", + "security settings google alter", + "security settings google chrome", + "security settings google chrome alter", + "security settings google chrome use", + "security settings google use", + "security settings manage", + "security settings manage alter", + "security settings manage use", + "security settings use", + "security settings use browse", + "security settings use browser", + "security settings use browsing", + "security settings use change", + "security settings use chrome", + "security settings use google", + "security settings use google chrome", + "security settings use manage", + "standard protection", + "standard protection alter", + "standard protection alter browse", + "standard protection alter browser", + "standard protection alter browsing", + "standard protection alter change", + "standard protection alter chrome", + "standard protection alter google", + "standard protection alter google chrome", + "standard protection alter manage", + "standard protection browse", + "standard protection browse alter", + "standard protection browse use", + "standard protection browser", + "standard protection browser alter", + "standard protection browser use", + "standard protection browsing", + "standard protection browsing alter", + "standard protection browsing use", + "standard protection change", + "standard protection change alter", + "standard protection change use", + "standard protection chrome", + "standard protection chrome alter", + "standard protection chrome use", + "standard protection google", + "standard protection google alter", + "standard protection google chrome", + "standard protection google chrome alter", + "standard protection google chrome use", + "standard protection google use", + "standard protection manage", + "standard protection manage alter", + "standard protection manage use", + "standard protection use", + "standard protection use browse", + "standard protection use browser", + "standard protection use browsing", + "standard protection use change", + "standard protection use chrome", + "standard protection use google", + "standard protection use google chrome", + "standard protection use manage", + "use browse certificates", + "use browse enhanced protection", + "use browse safely", + "use browse secure dns", + "use browse securely", + "use browse security keys", + "use browse security settings", + "use browse standard protection", + "use browser certificates", + "use browser enhanced protection", + "use browser safely", + "use browser secure dns", + "use browser securely", + "use browser security keys", + "use browser security settings", + "use browser standard protection", + "use browsing certificates", + "use browsing enhanced protection", + "use browsing safely", + "use browsing secure dns", + "use browsing securely", + "use browsing security keys", + "use browsing security settings", + "use browsing standard protection", + "use certificates", + "use certificates browse", + "use certificates browser", + "use certificates browsing", + "use certificates change", + "use certificates chrome", + "use certificates google", + "use certificates google chrome", + "use certificates manage", + "use change certificates", + "use change enhanced protection", + "use change safely", + "use change secure dns", + "use change securely", + "use change security keys", + "use change security settings", + "use change standard protection", + "use chrome certificates", + "use chrome enhanced protection", + "use chrome safely", + "use chrome secure dns", + "use chrome securely", + "use chrome security keys", + "use chrome security settings", + "use chrome standard protection", + "use enhanced protection", + "use enhanced protection browse", + "use enhanced protection browser", + "use enhanced protection browsing", + "use enhanced protection change", + "use enhanced protection chrome", + "use enhanced protection google", + "use enhanced protection google chrome", + "use enhanced protection manage", + "use google certificates", + "use google chrome certificates", + "use google chrome enhanced protection", + "use google chrome safely", + "use google chrome secure dns", + "use google chrome securely", + "use google chrome security keys", + "use google chrome security settings", + "use google chrome standard protection", + "use google enhanced protection", + "use google safely", + "use google secure dns", + "use google securely", + "use google security keys", + "use google security settings", + "use google standard protection", + "use manage certificates", + "use manage enhanced protection", + "use manage safely", + "use manage secure dns", + "use manage securely", + "use manage security keys", + "use manage security settings", + "use manage standard protection", + "use safely", + "use safely browse", + "use safely browser", + "use safely browsing", + "use safely change", + "use safely chrome", + "use safely google", + "use safely google chrome", + "use safely manage", + "use secure dns", + "use secure dns browse", + "use secure dns browser", + "use secure dns browsing", + "use secure dns change", + "use secure dns chrome", + "use secure dns google", + "use secure dns google chrome", + "use secure dns manage", + "use securely", + "use securely browse", + "use securely browser", + "use securely browsing", + "use securely change", + "use securely chrome", + "use securely google", + "use securely google chrome", + "use securely manage", + "use security keys", + "use security keys browse", + "use security keys browser", + "use security keys browsing", + "use security keys change", + "use security keys chrome", + "use security keys google", + "use security keys google chrome", + "use security keys manage", + "use security settings", + "use security settings browse", + "use security settings browser", + "use security settings browsing", + "use security settings change", + "use security settings chrome", + "use security settings google", + "use security settings google chrome", + "use security settings manage", + "use standard protection", + "use standard protection browse", + "use standard protection browser", + "use standard protection browsing", + "use standard protection change", + "use standard protection chrome", + "use standard protection google", + "use standard protection google chrome", + "use standard protection manage", + }, + + // ID#9 + { + // Generated suggestions: + "all allow cookie settings", + "all allow cookies", + "all allow do not track", + "all alter cookie settings", + "all alter cookies", + "all alter do not track", + "all block cookie settings", + "all block cookies", + "all block do not track", + "all browser cookie settings", + "all browser cookies", + "all browser do not track", + "all chrome cookie settings", + "all chrome cookies", + "all chrome do not track", + "all control cookie settings", + "all control cookies", + "all control do not track", + "all cookie settings allow", + "all cookie settings alter", + "all cookie settings block", + "all cookie settings browser", + "all cookie settings chrome", + "all cookie settings control", + "all cookie settings disallow", + "all cookie settings google", + "all cookie settings google chrome", + "all cookie settings manage", + "all cookie settings use", + "all cookies allow", + "all cookies alter", + "all cookies block", + "all cookies browser", + "all cookies chrome", + "all cookies control", + "all cookies disallow", + "all cookies google", + "all cookies google chrome", + "all cookies manage", + "all cookies use", + "all disallow cookie settings", + "all disallow cookies", + "all disallow do not track", + "all do not track allow", + "all do not track alter", + "all do not track block", + "all do not track browser", + "all do not track chrome", + "all do not track control", + "all do not track disallow", + "all do not track google", + "all do not track google chrome", + "all do not track manage", + "all do not track use", + "all google chrome cookie settings", + "all google chrome cookies", + "all google chrome do not track", + "all google cookie settings", + "all google cookies", + "all google do not track", + "all manage cookie settings", + "all manage cookies", + "all manage do not track", + "all use cookie settings", + "all use cookies", + "all use do not track", + "allow all cookie settings", + "allow all cookies", + "allow all do not track", + "allow cookie settings", + "allow cookie settings all", + "allow cookie settings third party", + "allow cookies", + "allow cookies all", + "allow cookies third party", + "allow do not track", + "allow do not track all", + "allow do not track third party", + "allow third party cookie settings", + "allow third party cookies", + "allow third party do not track", + "alter all cookie settings", + "alter all cookies", + "alter all do not track", + "alter cookie settings", + "alter cookie settings all", + "alter cookie settings third party", + "alter cookies", + "alter cookies all", + "alter cookies third party", + "alter do not track", + "alter do not track all", + "alter do not track third party", + "alter third party cookie settings", + "alter third party cookies", + "alter third party do not track", + "block all cookie settings", + "block all cookies", + "block all do not track", + "block cookie settings", + "block cookie settings all", + "block cookie settings third party", + "block cookies", + "block cookies all", + "block cookies third party", + "block do not track", + "block do not track all", + "block do not track third party", + "block third party cookie settings", + "block third party cookies", + "block third party do not track", + "browser all cookie settings", + "browser all cookies", + "browser all do not track", + "browser cookie settings", + "browser cookie settings all", + "browser cookie settings third party", + "browser cookies", + "browser cookies all", + "browser cookies third party", + "browser do not track", + "browser do not track all", + "browser do not track third party", + "browser third party cookie settings", + "browser third party cookies", + "browser third party do not track", + "chrome all cookie settings", + "chrome all cookies", + "chrome all do not track", + "chrome cookie settings", + "chrome cookie settings all", + "chrome cookie settings third party", + "chrome cookies", + "chrome cookies all", + "chrome cookies third party", + "chrome do not track", + "chrome do not track all", + "chrome do not track third party", + "chrome third party cookie settings", + "chrome third party cookies", + "chrome third party do not track", + "control all cookie settings", + "control all cookies", + "control all do not track", + "control cookie settings", + "control cookie settings all", + "control cookie settings third party", + "control cookies", + "control cookies all", + "control cookies third party", + "control do not track", + "control do not track all", + "control do not track third party", + "control third party cookie settings", + "control third party cookies", + "control third party do not track", + "cookie settings all allow", + "cookie settings all alter", + "cookie settings all block", + "cookie settings all browser", + "cookie settings all chrome", + "cookie settings all control", + "cookie settings all disallow", + "cookie settings all google", + "cookie settings all google chrome", + "cookie settings all manage", + "cookie settings all use", + "cookie settings allow", + "cookie settings allow all", + "cookie settings allow third party", + "cookie settings alter", + "cookie settings alter all", + "cookie settings alter third party", + "cookie settings block", + "cookie settings block all", + "cookie settings block third party", + "cookie settings browser", + "cookie settings browser all", + "cookie settings browser third party", + "cookie settings chrome", + "cookie settings chrome all", + "cookie settings chrome third party", + "cookie settings control", + "cookie settings control all", + "cookie settings control third party", + "cookie settings disallow", + "cookie settings disallow all", + "cookie settings disallow third party", + "cookie settings google", + "cookie settings google all", + "cookie settings google chrome", + "cookie settings google chrome all", + "cookie settings google chrome third party", + "cookie settings google third party", + "cookie settings manage", + "cookie settings manage all", + "cookie settings manage third party", + "cookie settings third party allow", + "cookie settings third party alter", + "cookie settings third party block", + "cookie settings third party browser", + "cookie settings third party chrome", + "cookie settings third party control", + "cookie settings third party disallow", + "cookie settings third party google", + "cookie settings third party google chrome", + "cookie settings third party manage", + "cookie settings third party use", + "cookie settings use", + "cookie settings use all", + "cookie settings use third party", + "cookies all allow", + "cookies all alter", + "cookies all block", + "cookies all browser", + "cookies all chrome", + "cookies all control", + "cookies all disallow", + "cookies all google", + "cookies all google chrome", + "cookies all manage", + "cookies all use", + "cookies allow", + "cookies allow all", + "cookies allow third party", + "cookies alter", + "cookies alter all", + "cookies alter third party", + "cookies block", + "cookies block all", + "cookies block third party", + "cookies browser", + "cookies browser all", + "cookies browser third party", + "cookies chrome", + "cookies chrome all", + "cookies chrome third party", + "cookies control", + "cookies control all", + "cookies control third party", + "cookies disallow", + "cookies disallow all", + "cookies disallow third party", + "cookies google", + "cookies google all", + "cookies google chrome", + "cookies google chrome all", + "cookies google chrome third party", + "cookies google third party", + "cookies manage", + "cookies manage all", + "cookies manage third party", + "cookies third party allow", + "cookies third party alter", + "cookies third party block", + "cookies third party browser", + "cookies third party chrome", + "cookies third party control", + "cookies third party disallow", + "cookies third party google", + "cookies third party google chrome", + "cookies third party manage", + "cookies third party use", + "cookies use", + "cookies use all", + "cookies use third party", + "disallow all cookie settings", + "disallow all cookies", + "disallow all do not track", + "disallow cookie settings", + "disallow cookie settings all", + "disallow cookie settings third party", + "disallow cookies", + "disallow cookies all", + "disallow cookies third party", + "disallow do not track", + "disallow do not track all", + "disallow do not track third party", + "disallow third party cookie settings", + "disallow third party cookies", + "disallow third party do not track", + "do not track all allow", + "do not track all alter", + "do not track all block", + "do not track all browser", + "do not track all chrome", + "do not track all control", + "do not track all disallow", + "do not track all google", + "do not track all google chrome", + "do not track all manage", + "do not track all use", + "do not track allow", + "do not track allow all", + "do not track allow third party", + "do not track alter", + "do not track alter all", + "do not track alter third party", + "do not track block", + "do not track block all", + "do not track block third party", + "do not track browser", + "do not track browser all", + "do not track browser third party", + "do not track chrome", + "do not track chrome all", + "do not track chrome third party", + "do not track control", + "do not track control all", + "do not track control third party", + "do not track disallow", + "do not track disallow all", + "do not track disallow third party", + "do not track google", + "do not track google all", + "do not track google chrome", + "do not track google chrome all", + "do not track google chrome third party", + "do not track google third party", + "do not track manage", + "do not track manage all", + "do not track manage third party", + "do not track third party allow", + "do not track third party alter", + "do not track third party block", + "do not track third party browser", + "do not track third party chrome", + "do not track third party control", + "do not track third party disallow", + "do not track third party google", + "do not track third party google chrome", + "do not track third party manage", + "do not track third party use", + "do not track use", + "do not track use all", + "do not track use third party", + "google all cookie settings", + "google all cookies", + "google all do not track", + "google chrome all cookie settings", + "google chrome all cookies", + "google chrome all do not track", + "google chrome cookie settings", + "google chrome cookie settings all", + "google chrome cookie settings third party", + "google chrome cookies", + "google chrome cookies all", + "google chrome cookies third party", + "google chrome do not track", + "google chrome do not track all", + "google chrome do not track third party", + "google chrome third party cookie settings", + "google chrome third party cookies", + "google chrome third party do not track", + "google cookie settings", + "google cookie settings all", + "google cookie settings third party", + "google cookies", + "google cookies all", + "google cookies third party", + "google do not track", + "google do not track all", + "google do not track third party", + "google third party cookie settings", + "google third party cookies", + "google third party do not track", + "manage all cookie settings", + "manage all cookies", + "manage all do not track", + "manage cookie settings", + "manage cookie settings all", + "manage cookie settings third party", + "manage cookies", + "manage cookies all", + "manage cookies third party", + "manage do not track", + "manage do not track all", + "manage do not track third party", + "manage third party cookie settings", + "manage third party cookies", + "manage third party do not track", + "third party allow cookie settings", + "third party allow cookies", + "third party allow do not track", + "third party alter cookie settings", + "third party alter cookies", + "third party alter do not track", + "third party block cookie settings", + "third party block cookies", + "third party block do not track", + "third party browser cookie settings", + "third party browser cookies", + "third party browser do not track", + "third party chrome cookie settings", + "third party chrome cookies", + "third party chrome do not track", + "third party control cookie settings", + "third party control cookies", + "third party control do not track", + "third party cookie settings allow", + "third party cookie settings alter", + "third party cookie settings block", + "third party cookie settings browser", + "third party cookie settings chrome", + "third party cookie settings control", + "third party cookie settings disallow", + "third party cookie settings google", + "third party cookie settings google chrome", + "third party cookie settings manage", + "third party cookie settings use", + "third party cookies allow", + "third party cookies alter", + "third party cookies block", + "third party cookies browser", + "third party cookies chrome", + "third party cookies control", + "third party cookies disallow", + "third party cookies google", + "third party cookies google chrome", + "third party cookies manage", + "third party cookies use", + "third party disallow cookie settings", + "third party disallow cookies", + "third party disallow do not track", + "third party do not track allow", + "third party do not track alter", + "third party do not track block", + "third party do not track browser", + "third party do not track chrome", + "third party do not track control", + "third party do not track disallow", + "third party do not track google", + "third party do not track google chrome", + "third party do not track manage", + "third party do not track use", + "third party google chrome cookie settings", + "third party google chrome cookies", + "third party google chrome do not track", + "third party google cookie settings", + "third party google cookies", + "third party google do not track", + "third party manage cookie settings", + "third party manage cookies", + "third party manage do not track", + "third party use cookie settings", + "third party use cookies", + "third party use do not track", + "use all cookie settings", + "use all cookies", + "use all do not track", + "use cookie settings", + "use cookie settings all", + "use cookie settings third party", + "use cookies", + "use cookies all", + "use cookies third party", + "use do not track", + "use do not track all", + "use do not track third party", + "use third party cookie settings", + "use third party cookies", + "use third party do not track", + }, + + // ID#10 + { + // Generated suggestions: + "add address", + "add address browser", + "add address chrome", + "add address google", + "add address google chrome", + "add addresses", + "add addresses browser", + "add addresses chrome", + "add addresses google", + "add addresses google chrome", + "add browser address", + "add browser addresses", + "add browser new address", + "add browser shipping address", + "add browser shipping addresses", + "add chrome address", + "add chrome addresses", + "add chrome new address", + "add chrome shipping address", + "add chrome shipping addresses", + "add google address", + "add google addresses", + "add google chrome address", + "add google chrome addresses", + "add google chrome new address", + "add google chrome shipping address", + "add google chrome shipping addresses", + "add google new address", + "add google shipping address", + "add google shipping addresses", + "add new address", + "add new address browser", + "add new address chrome", + "add new address google", + "add new address google chrome", + "add shipping address", + "add shipping address browser", + "add shipping address chrome", + "add shipping address google", + "add shipping address google chrome", + "add shipping addresses", + "add shipping addresses browser", + "add shipping addresses chrome", + "add shipping addresses google", + "add shipping addresses google chrome", + "address add", + "address add browser", + "address add chrome", + "address add google", + "address add google chrome", + "address adjust", + "address adjust browser", + "address adjust chrome", + "address adjust google", + "address adjust google chrome", + "address browser add", + "address browser adjust", + "address browser change", + "address browser control", + "address browser delete", + "address browser edit", + "address browser manage", + "address browser store", + "address change", + "address change browser", + "address change chrome", + "address change google", + "address change google chrome", + "address chrome add", + "address chrome adjust", + "address chrome change", + "address chrome control", + "address chrome delete", + "address chrome edit", + "address chrome manage", + "address chrome store", + "address control", + "address control browser", + "address control chrome", + "address control google", + "address control google chrome", + "address delete", + "address delete browser", + "address delete chrome", + "address delete google", + "address delete google chrome", + "address edit", + "address edit browser", + "address edit chrome", + "address edit google", + "address edit google chrome", + "address google add", + "address google adjust", + "address google change", + "address google chrome add", + "address google chrome adjust", + "address google chrome change", + "address google chrome control", + "address google chrome delete", + "address google chrome edit", + "address google chrome manage", + "address google chrome store", + "address google control", + "address google delete", + "address google edit", + "address google manage", + "address google store", + "address manage", + "address manage browser", + "address manage chrome", + "address manage google", + "address manage google chrome", + "address store", + "address store browser", + "address store chrome", + "address store google", + "address store google chrome", + "addresses add", + "addresses add browser", + "addresses add chrome", + "addresses add google", + "addresses add google chrome", + "addresses adjust", + "addresses adjust browser", + "addresses adjust chrome", + "addresses adjust google", + "addresses adjust google chrome", + "addresses browser add", + "addresses browser adjust", + "addresses browser change", + "addresses browser control", + "addresses browser delete", + "addresses browser edit", + "addresses browser manage", + "addresses browser store", + "addresses change", + "addresses change browser", + "addresses change chrome", + "addresses change google", + "addresses change google chrome", + "addresses chrome add", + "addresses chrome adjust", + "addresses chrome change", + "addresses chrome control", + "addresses chrome delete", + "addresses chrome edit", + "addresses chrome manage", + "addresses chrome store", + "addresses control", + "addresses control browser", + "addresses control chrome", + "addresses control google", + "addresses control google chrome", + "addresses delete", + "addresses delete browser", + "addresses delete chrome", + "addresses delete google", + "addresses delete google chrome", + "addresses edit", + "addresses edit browser", + "addresses edit chrome", + "addresses edit google", + "addresses edit google chrome", + "addresses google add", + "addresses google adjust", + "addresses google change", + "addresses google chrome add", + "addresses google chrome adjust", + "addresses google chrome change", + "addresses google chrome control", + "addresses google chrome delete", + "addresses google chrome edit", + "addresses google chrome manage", + "addresses google chrome store", + "addresses google control", + "addresses google delete", + "addresses google edit", + "addresses google manage", + "addresses google store", + "addresses manage", + "addresses manage browser", + "addresses manage chrome", + "addresses manage google", + "addresses manage google chrome", + "addresses store", + "addresses store browser", + "addresses store chrome", + "addresses store google", + "addresses store google chrome", + "adjust address", + "adjust address browser", + "adjust address chrome", + "adjust address google", + "adjust address google chrome", + "adjust addresses", + "adjust addresses browser", + "adjust addresses chrome", + "adjust addresses google", + "adjust addresses google chrome", + "adjust browser address", + "adjust browser addresses", + "adjust browser new address", + "adjust browser shipping address", + "adjust browser shipping addresses", + "adjust chrome address", + "adjust chrome addresses", + "adjust chrome new address", + "adjust chrome shipping address", + "adjust chrome shipping addresses", + "adjust google address", + "adjust google addresses", + "adjust google chrome address", + "adjust google chrome addresses", + "adjust google chrome new address", + "adjust google chrome shipping address", + "adjust google chrome shipping addresses", + "adjust google new address", + "adjust google shipping address", + "adjust google shipping addresses", + "adjust new address", + "adjust new address browser", + "adjust new address chrome", + "adjust new address google", + "adjust new address google chrome", + "adjust shipping address", + "adjust shipping address browser", + "adjust shipping address chrome", + "adjust shipping address google", + "adjust shipping address google chrome", + "adjust shipping addresses", + "adjust shipping addresses browser", + "adjust shipping addresses chrome", + "adjust shipping addresses google", + "adjust shipping addresses google chrome", + "browser add address", + "browser add addresses", + "browser add new address", + "browser add shipping address", + "browser add shipping addresses", + "browser address add", + "browser address adjust", + "browser address change", + "browser address control", + "browser address delete", + "browser address edit", + "browser address manage", + "browser address store", + "browser addresses add", + "browser addresses adjust", + "browser addresses change", + "browser addresses control", + "browser addresses delete", + "browser addresses edit", + "browser addresses manage", + "browser addresses store", + "browser adjust address", + "browser adjust addresses", + "browser adjust new address", + "browser adjust shipping address", + "browser adjust shipping addresses", + "browser change address", + "browser change addresses", + "browser change new address", + "browser change shipping address", + "browser change shipping addresses", + "browser control address", + "browser control addresses", + "browser control new address", + "browser control shipping address", + "browser control shipping addresses", + "browser delete address", + "browser delete addresses", + "browser delete new address", + "browser delete shipping address", + "browser delete shipping addresses", + "browser edit address", + "browser edit addresses", + "browser edit new address", + "browser edit shipping address", + "browser edit shipping addresses", + "browser manage address", + "browser manage addresses", + "browser manage new address", + "browser manage shipping address", + "browser manage shipping addresses", + "browser new address add", + "browser new address adjust", + "browser new address change", + "browser new address control", + "browser new address delete", + "browser new address edit", + "browser new address manage", + "browser new address store", + "browser shipping address add", + "browser shipping address adjust", + "browser shipping address change", + "browser shipping address control", + "browser shipping address delete", + "browser shipping address edit", + "browser shipping address manage", + "browser shipping address store", + "browser shipping addresses add", + "browser shipping addresses adjust", + "browser shipping addresses change", + "browser shipping addresses control", + "browser shipping addresses delete", + "browser shipping addresses edit", + "browser shipping addresses manage", + "browser shipping addresses store", + "browser store address", + "browser store addresses", + "browser store new address", + "browser store shipping address", + "browser store shipping addresses", + "change address", + "change address browser", + "change address chrome", + "change address google", + "change address google chrome", + "change addresses", + "change addresses browser", + "change addresses chrome", + "change addresses google", + "change addresses google chrome", + "change browser address", + "change browser addresses", + "change browser new address", + "change browser shipping address", + "change browser shipping addresses", + "change chrome address", + "change chrome addresses", + "change chrome new address", + "change chrome shipping address", + "change chrome shipping addresses", + "change google address", + "change google addresses", + "change google chrome address", + "change google chrome addresses", + "change google chrome new address", + "change google chrome shipping address", + "change google chrome shipping addresses", + "change google new address", + "change google shipping address", + "change google shipping addresses", + "change new address", + "change new address browser", + "change new address chrome", + "change new address google", + "change new address google chrome", + "change shipping address", + "change shipping address browser", + "change shipping address chrome", + "change shipping address google", + "change shipping address google chrome", + "change shipping addresses", + "change shipping addresses browser", + "change shipping addresses chrome", + "change shipping addresses google", + "change shipping addresses google chrome", + "chrome add address", + "chrome add addresses", + "chrome add new address", + "chrome add shipping address", + "chrome add shipping addresses", + "chrome address add", + "chrome address adjust", + "chrome address change", + "chrome address control", + "chrome address delete", + "chrome address edit", + "chrome address manage", + "chrome address store", + "chrome addresses add", + "chrome addresses adjust", + "chrome addresses change", + "chrome addresses control", + "chrome addresses delete", + "chrome addresses edit", + "chrome addresses manage", + "chrome addresses store", + "chrome adjust address", + "chrome adjust addresses", + "chrome adjust new address", + "chrome adjust shipping address", + "chrome adjust shipping addresses", + "chrome change address", + "chrome change addresses", + "chrome change new address", + "chrome change shipping address", + "chrome change shipping addresses", + "chrome control address", + "chrome control addresses", + "chrome control new address", + "chrome control shipping address", + "chrome control shipping addresses", + "chrome delete address", + "chrome delete addresses", + "chrome delete new address", + "chrome delete shipping address", + "chrome delete shipping addresses", + "chrome edit address", + "chrome edit addresses", + "chrome edit new address", + "chrome edit shipping address", + "chrome edit shipping addresses", + "chrome manage address", + "chrome manage addresses", + "chrome manage new address", + "chrome manage shipping address", + "chrome manage shipping addresses", + "chrome new address add", + "chrome new address adjust", + "chrome new address change", + "chrome new address control", + "chrome new address delete", + "chrome new address edit", + "chrome new address manage", + "chrome new address store", + "chrome shipping address add", + "chrome shipping address adjust", + "chrome shipping address change", + "chrome shipping address control", + "chrome shipping address delete", + "chrome shipping address edit", + "chrome shipping address manage", + "chrome shipping address store", + "chrome shipping addresses add", + "chrome shipping addresses adjust", + "chrome shipping addresses change", + "chrome shipping addresses control", + "chrome shipping addresses delete", + "chrome shipping addresses edit", + "chrome shipping addresses manage", + "chrome shipping addresses store", + "chrome store address", + "chrome store addresses", + "chrome store new address", + "chrome store shipping address", + "chrome store shipping addresses", + "control address", + "control address browser", + "control address chrome", + "control address google", + "control address google chrome", + "control addresses", + "control addresses browser", + "control addresses chrome", + "control addresses google", + "control addresses google chrome", + "control browser address", + "control browser addresses", + "control browser new address", + "control browser shipping address", + "control browser shipping addresses", + "control chrome address", + "control chrome addresses", + "control chrome new address", + "control chrome shipping address", + "control chrome shipping addresses", + "control google address", + "control google addresses", + "control google chrome address", + "control google chrome addresses", + "control google chrome new address", + "control google chrome shipping address", + "control google chrome shipping addresses", + "control google new address", + "control google shipping address", + "control google shipping addresses", + "control new address", + "control new address browser", + "control new address chrome", + "control new address google", + "control new address google chrome", + "control shipping address", + "control shipping address browser", + "control shipping address chrome", + "control shipping address google", + "control shipping address google chrome", + "control shipping addresses", + "control shipping addresses browser", + "control shipping addresses chrome", + "control shipping addresses google", + "control shipping addresses google chrome", + "delete address", + "delete address browser", + "delete address chrome", + "delete address google", + "delete address google chrome", + "delete addresses", + "delete addresses browser", + "delete addresses chrome", + "delete addresses google", + "delete addresses google chrome", + "delete browser address", + "delete browser addresses", + "delete browser new address", + "delete browser shipping address", + "delete browser shipping addresses", + "delete chrome address", + "delete chrome addresses", + "delete chrome new address", + "delete chrome shipping address", + "delete chrome shipping addresses", + "delete google address", + "delete google addresses", + "delete google chrome address", + "delete google chrome addresses", + "delete google chrome new address", + "delete google chrome shipping address", + "delete google chrome shipping addresses", + "delete google new address", + "delete google shipping address", + "delete google shipping addresses", + "delete new address", + "delete new address browser", + "delete new address chrome", + "delete new address google", + "delete new address google chrome", + "delete shipping address", + "delete shipping address browser", + "delete shipping address chrome", + "delete shipping address google", + "delete shipping address google chrome", + "delete shipping addresses", + "delete shipping addresses browser", + "delete shipping addresses chrome", + "delete shipping addresses google", + "delete shipping addresses google chrome", + "edit address", + "edit address browser", + "edit address chrome", + "edit address google", + "edit address google chrome", + "edit addresses", + "edit addresses browser", + "edit addresses chrome", + "edit addresses google", + "edit addresses google chrome", + "edit browser address", + "edit browser addresses", + "edit browser new address", + "edit browser shipping address", + "edit browser shipping addresses", + "edit chrome address", + "edit chrome addresses", + "edit chrome new address", + "edit chrome shipping address", + "edit chrome shipping addresses", + "edit google address", + "edit google addresses", + "edit google chrome address", + "edit google chrome addresses", + "edit google chrome new address", + "edit google chrome shipping address", + "edit google chrome shipping addresses", + "edit google new address", + "edit google shipping address", + "edit google shipping addresses", + "edit new address", + "edit new address browser", + "edit new address chrome", + "edit new address google", + "edit new address google chrome", + "edit shipping address", + "edit shipping address browser", + "edit shipping address chrome", + "edit shipping address google", + "edit shipping address google chrome", + "edit shipping addresses", + "edit shipping addresses browser", + "edit shipping addresses chrome", + "edit shipping addresses google", + "edit shipping addresses google chrome", + "google add address", + "google add addresses", + "google add new address", + "google add shipping address", + "google add shipping addresses", + "google address add", + "google address adjust", + "google address change", + "google address control", + "google address delete", + "google address edit", + "google address manage", + "google address store", + "google addresses add", + "google addresses adjust", + "google addresses change", + "google addresses control", + "google addresses delete", + "google addresses edit", + "google addresses manage", + "google addresses store", + "google adjust address", + "google adjust addresses", + "google adjust new address", + "google adjust shipping address", + "google adjust shipping addresses", + "google change address", + "google change addresses", + "google change new address", + "google change shipping address", + "google change shipping addresses", + "google chrome add address", + "google chrome add addresses", + "google chrome add new address", + "google chrome add shipping address", + "google chrome add shipping addresses", + "google chrome address add", + "google chrome address adjust", + "google chrome address change", + "google chrome address control", + "google chrome address delete", + "google chrome address edit", + "google chrome address manage", + "google chrome address store", + "google chrome addresses add", + "google chrome addresses adjust", + "google chrome addresses change", + "google chrome addresses control", + "google chrome addresses delete", + "google chrome addresses edit", + "google chrome addresses manage", + "google chrome addresses store", + "google chrome adjust address", + "google chrome adjust addresses", + "google chrome adjust new address", + "google chrome adjust shipping address", + "google chrome adjust shipping addresses", + "google chrome change address", + "google chrome change addresses", + "google chrome change new address", + "google chrome change shipping address", + "google chrome change shipping addresses", + "google chrome control address", + "google chrome control addresses", + "google chrome control new address", + "google chrome control shipping address", + "google chrome control shipping addresses", + "google chrome delete address", + "google chrome delete addresses", + "google chrome delete new address", + "google chrome delete shipping address", + "google chrome delete shipping addresses", + "google chrome edit address", + "google chrome edit addresses", + "google chrome edit new address", + "google chrome edit shipping address", + "google chrome edit shipping addresses", + "google chrome manage address", + "google chrome manage addresses", + "google chrome manage new address", + "google chrome manage shipping address", + "google chrome manage shipping addresses", + "google chrome new address add", + "google chrome new address adjust", + "google chrome new address change", + "google chrome new address control", + "google chrome new address delete", + "google chrome new address edit", + "google chrome new address manage", + "google chrome new address store", + "google chrome shipping address add", + "google chrome shipping address adjust", + "google chrome shipping address change", + "google chrome shipping address control", + "google chrome shipping address delete", + "google chrome shipping address edit", + "google chrome shipping address manage", + "google chrome shipping address store", + "google chrome shipping addresses add", + "google chrome shipping addresses adjust", + "google chrome shipping addresses change", + "google chrome shipping addresses control", + "google chrome shipping addresses delete", + "google chrome shipping addresses edit", + "google chrome shipping addresses manage", + "google chrome shipping addresses store", + "google chrome store address", + "google chrome store addresses", + "google chrome store new address", + "google chrome store shipping address", + "google chrome store shipping addresses", + "google control address", + "google control addresses", + "google control new address", + "google control shipping address", + "google control shipping addresses", + "google delete address", + "google delete addresses", + "google delete new address", + "google delete shipping address", + "google delete shipping addresses", + "google edit address", + "google edit addresses", + "google edit new address", + "google edit shipping address", + "google edit shipping addresses", + "google manage address", + "google manage addresses", + "google manage new address", + "google manage shipping address", + "google manage shipping addresses", + "google new address add", + "google new address adjust", + "google new address change", + "google new address control", + "google new address delete", + "google new address edit", + "google new address manage", + "google new address store", + "google shipping address add", + "google shipping address adjust", + "google shipping address change", + "google shipping address control", + "google shipping address delete", + "google shipping address edit", + "google shipping address manage", + "google shipping address store", + "google shipping addresses add", + "google shipping addresses adjust", + "google shipping addresses change", + "google shipping addresses control", + "google shipping addresses delete", + "google shipping addresses edit", + "google shipping addresses manage", + "google shipping addresses store", + "google store address", + "google store addresses", + "google store new address", + "google store shipping address", + "google store shipping addresses", + "manage address", + "manage address browser", + "manage address chrome", + "manage address google", + "manage address google chrome", + "manage addresses", + "manage addresses browser", + "manage addresses chrome", + "manage addresses google", + "manage addresses google chrome", + "manage browser address", + "manage browser addresses", + "manage browser new address", + "manage browser shipping address", + "manage browser shipping addresses", + "manage chrome address", + "manage chrome addresses", + "manage chrome new address", + "manage chrome shipping address", + "manage chrome shipping addresses", + "manage google address", + "manage google addresses", + "manage google chrome address", + "manage google chrome addresses", + "manage google chrome new address", + "manage google chrome shipping address", + "manage google chrome shipping addresses", + "manage google new address", + "manage google shipping address", + "manage google shipping addresses", + "manage new address", + "manage new address browser", + "manage new address chrome", + "manage new address google", + "manage new address google chrome", + "manage shipping address", + "manage shipping address browser", + "manage shipping address chrome", + "manage shipping address google", + "manage shipping address google chrome", + "manage shipping addresses", + "manage shipping addresses browser", + "manage shipping addresses chrome", + "manage shipping addresses google", + "manage shipping addresses google chrome", + "new address add", + "new address add browser", + "new address add chrome", + "new address add google", + "new address add google chrome", + "new address adjust", + "new address adjust browser", + "new address adjust chrome", + "new address adjust google", + "new address adjust google chrome", + "new address browser add", + "new address browser adjust", + "new address browser change", + "new address browser control", + "new address browser delete", + "new address browser edit", + "new address browser manage", + "new address browser store", + "new address change", + "new address change browser", + "new address change chrome", + "new address change google", + "new address change google chrome", + "new address chrome add", + "new address chrome adjust", + "new address chrome change", + "new address chrome control", + "new address chrome delete", + "new address chrome edit", + "new address chrome manage", + "new address chrome store", + "new address control", + "new address control browser", + "new address control chrome", + "new address control google", + "new address control google chrome", + "new address delete", + "new address delete browser", + "new address delete chrome", + "new address delete google", + "new address delete google chrome", + "new address edit", + "new address edit browser", + "new address edit chrome", + "new address edit google", + "new address edit google chrome", + "new address google add", + "new address google adjust", + "new address google change", + "new address google chrome add", + "new address google chrome adjust", + "new address google chrome change", + "new address google chrome control", + "new address google chrome delete", + "new address google chrome edit", + "new address google chrome manage", + "new address google chrome store", + "new address google control", + "new address google delete", + "new address google edit", + "new address google manage", + "new address google store", + "new address manage", + "new address manage browser", + "new address manage chrome", + "new address manage google", + "new address manage google chrome", + "new address store", + "new address store browser", + "new address store chrome", + "new address store google", + "new address store google chrome", + "shipping address add", + "shipping address add browser", + "shipping address add chrome", + "shipping address add google", + "shipping address add google chrome", + "shipping address adjust", + "shipping address adjust browser", + "shipping address adjust chrome", + "shipping address adjust google", + "shipping address adjust google chrome", + "shipping address browser add", + "shipping address browser adjust", + "shipping address browser change", + "shipping address browser control", + "shipping address browser delete", + "shipping address browser edit", + "shipping address browser manage", + "shipping address browser store", + "shipping address change", + "shipping address change browser", + "shipping address change chrome", + "shipping address change google", + "shipping address change google chrome", + "shipping address chrome add", + "shipping address chrome adjust", + "shipping address chrome change", + "shipping address chrome control", + "shipping address chrome delete", + "shipping address chrome edit", + "shipping address chrome manage", + "shipping address chrome store", + "shipping address control", + "shipping address control browser", + "shipping address control chrome", + "shipping address control google", + "shipping address control google chrome", + "shipping address delete", + "shipping address delete browser", + "shipping address delete chrome", + "shipping address delete google", + "shipping address delete google chrome", + "shipping address edit", + "shipping address edit browser", + "shipping address edit chrome", + "shipping address edit google", + "shipping address edit google chrome", + "shipping address google add", + "shipping address google adjust", + "shipping address google change", + "shipping address google chrome add", + "shipping address google chrome adjust", + "shipping address google chrome change", + "shipping address google chrome control", + "shipping address google chrome delete", + "shipping address google chrome edit", + "shipping address google chrome manage", + "shipping address google chrome store", + "shipping address google control", + "shipping address google delete", + "shipping address google edit", + "shipping address google manage", + "shipping address google store", + "shipping address manage", + "shipping address manage browser", + "shipping address manage chrome", + "shipping address manage google", + "shipping address manage google chrome", + "shipping address store", + "shipping address store browser", + "shipping address store chrome", + "shipping address store google", + "shipping address store google chrome", + "shipping addresses add", + "shipping addresses add browser", + "shipping addresses add chrome", + "shipping addresses add google", + "shipping addresses add google chrome", + "shipping addresses adjust", + "shipping addresses adjust browser", + "shipping addresses adjust chrome", + "shipping addresses adjust google", + "shipping addresses adjust google chrome", + "shipping addresses browser add", + "shipping addresses browser adjust", + "shipping addresses browser change", + "shipping addresses browser control", + "shipping addresses browser delete", + "shipping addresses browser edit", + "shipping addresses browser manage", + "shipping addresses browser store", + "shipping addresses change", + "shipping addresses change browser", + "shipping addresses change chrome", + "shipping addresses change google", + "shipping addresses change google chrome", + "shipping addresses chrome add", + "shipping addresses chrome adjust", + "shipping addresses chrome change", + "shipping addresses chrome control", + "shipping addresses chrome delete", + "shipping addresses chrome edit", + "shipping addresses chrome manage", + "shipping addresses chrome store", + "shipping addresses control", + "shipping addresses control browser", + "shipping addresses control chrome", + "shipping addresses control google", + "shipping addresses control google chrome", + "shipping addresses delete", + "shipping addresses delete browser", + "shipping addresses delete chrome", + "shipping addresses delete google", + "shipping addresses delete google chrome", + "shipping addresses edit", + "shipping addresses edit browser", + "shipping addresses edit chrome", + "shipping addresses edit google", + "shipping addresses edit google chrome", + "shipping addresses google add", + "shipping addresses google adjust", + "shipping addresses google change", + "shipping addresses google chrome add", + "shipping addresses google chrome adjust", + "shipping addresses google chrome change", + "shipping addresses google chrome control", + "shipping addresses google chrome delete", + "shipping addresses google chrome edit", + "shipping addresses google chrome manage", + "shipping addresses google chrome store", + "shipping addresses google control", + "shipping addresses google delete", + "shipping addresses google edit", + "shipping addresses google manage", + "shipping addresses google store", + "shipping addresses manage", + "shipping addresses manage browser", + "shipping addresses manage chrome", + "shipping addresses manage google", + "shipping addresses manage google chrome", + "shipping addresses store", + "shipping addresses store browser", + "shipping addresses store chrome", + "shipping addresses store google", + "shipping addresses store google chrome", + "store address", + "store address browser", + "store address chrome", + "store address google", + "store address google chrome", + "store addresses", + "store addresses browser", + "store addresses chrome", + "store addresses google", + "store addresses google chrome", + "store browser address", + "store browser addresses", + "store browser new address", + "store browser shipping address", + "store browser shipping addresses", + "store chrome address", + "store chrome addresses", + "store chrome new address", + "store chrome shipping address", + "store chrome shipping addresses", + "store google address", + "store google addresses", + "store google chrome address", + "store google chrome addresses", + "store google chrome new address", + "store google chrome shipping address", + "store google chrome shipping addresses", + "store google new address", + "store google shipping address", + "store google shipping addresses", + "store new address", + "store new address browser", + "store new address chrome", + "store new address google", + "store new address google chrome", + "store shipping address", + "store shipping address browser", + "store shipping address chrome", + "store shipping address google", + "store shipping address google chrome", + "store shipping addresses", + "store shipping addresses browser", + "store shipping addresses chrome", + "store shipping addresses google", + "store shipping addresses google chrome", + }, + + // ID#11 + { + // Generated suggestions: + "add sync", + "add sync settings", + "adjust sync", + "adjust sync settings", + "browser sync", + "browser sync settings", + "change sync", + "change sync settings", + "chrome sync", + "chrome sync settings", + "control sync", + "control sync settings", + "customize sync", + "customize sync settings", + "disable sync", + "disable sync settings", + "edit sync", + "edit sync settings", + "google chrome sync", + "google chrome sync settings", + "google sync", + "google sync settings", + "manage sync", + "manage sync settings", + "sync add", + "sync adjust", + "sync browser", + "sync change", + "sync chrome", + "sync control", + "sync customize", + "sync disable", + "sync edit", + "sync google", + "sync google chrome", + "sync manage", + "sync settings add", + "sync settings adjust", + "sync settings browser", + "sync settings change", + "sync settings chrome", + "sync settings control", + "sync settings customize", + "sync settings disable", + "sync settings edit", + "sync settings google", + "sync settings google chrome", + "sync settings manage", + }, + + // ID#12 + { + // Generated suggestions: + "adjust permissions", + "adjust site permissions", + "adjust site settings", + "browser permissions", + "browser site permissions", + "browser site settings", + "change permissions", + "change site permissions", + "change site settings", + "chrome permissions", + "chrome site permissions", + "chrome site settings", + "control permissions", + "control site permissions", + "control site settings", + "customize permissions", + "customize site permissions", + "customize site settings", + "edit permissions", + "edit site permissions", + "edit site settings", + "google chrome permissions", + "google chrome site permissions", + "google chrome site settings", + "google permissions", + "google site permissions", + "google site settings", + "manage permissions", + "manage site permissions", + "manage site settings", + "permissions adjust", + "permissions browser", + "permissions change", + "permissions chrome", + "permissions control", + "permissions customize", + "permissions edit", + "permissions google", + "permissions google chrome", + "permissions manage", + "site permissions adjust", + "site permissions browser", + "site permissions change", + "site permissions chrome", + "site permissions control", + "site permissions customize", + "site permissions edit", + "site permissions google", + "site permissions google chrome", + "site permissions manage", + "site settings adjust", + "site settings browser", + "site settings change", + "site settings chrome", + "site settings control", + "site settings customize", + "site settings edit", + "site settings google", + "site settings google chrome", + "site settings manage", + }, + + // ID#13 + { + // Generated suggestions: + "browser create doc", + "browser create document", + "browser doc create", + "browser doc make", + "browser doc new", + "browser doc open", + "browser doc start", + "browser document create", + "browser document make", + "browser document new", + "browser document open", + "browser document start", + "browser make doc", + "browser make document", + "browser new doc", + "browser new document", + "browser open doc", + "browser open document", + "browser start doc", + "browser start document", + "chrome create doc", + "chrome create document", + "chrome doc create", + "chrome doc make", + "chrome doc new", + "chrome doc open", + "chrome doc start", + "chrome document create", + "chrome document make", + "chrome document new", + "chrome document open", + "chrome document start", + "chrome make doc", + "chrome make document", + "chrome new doc", + "chrome new document", + "chrome open doc", + "chrome open document", + "chrome start doc", + "chrome start document", + "create browser doc", + "create browser document", + "create chrome doc", + "create chrome document", + "create doc browser", + "create doc chrome", + "create doc g suite", + "create doc google", + "create doc google chrome", + "create doc google workspace", + "create doc gsuite", + "create doc workspace", + "create document browser", + "create document chrome", + "create document g suite", + "create document google", + "create document google chrome", + "create document google workspace", + "create document gsuite", + "create document workspace", + "create g suite doc", + "create g suite document", + "create google chrome doc", + "create google chrome document", + "create google doc", + "create google document", + "create google workspace doc", + "create google workspace document", + "create gsuite doc", + "create gsuite document", + "create workspace doc", + "create workspace document", + "doc browser create", + "doc browser make", + "doc browser new", + "doc browser open", + "doc browser start", + "doc chrome create", + "doc chrome make", + "doc chrome new", + "doc chrome open", + "doc chrome start", + "doc create browser", + "doc create chrome", + "doc create g suite", + "doc create google", + "doc create google chrome", + "doc create google workspace", + "doc create gsuite", + "doc create workspace", + "doc g suite create", + "doc g suite make", + "doc g suite new", + "doc g suite open", + "doc g suite start", + "doc google chrome create", + "doc google chrome make", + "doc google chrome new", + "doc google chrome open", + "doc google chrome start", + "doc google create", + "doc google make", + "doc google new", + "doc google open", + "doc google start", + "doc google workspace create", + "doc google workspace make", + "doc google workspace new", + "doc google workspace open", + "doc google workspace start", + "doc gsuite create", + "doc gsuite make", + "doc gsuite new", + "doc gsuite open", + "doc gsuite start", + "doc make browser", + "doc make chrome", + "doc make g suite", + "doc make google", + "doc make google chrome", + "doc make google workspace", + "doc make gsuite", + "doc make workspace", + "doc new browser", + "doc new chrome", + "doc new g suite", + "doc new google", + "doc new google chrome", + "doc new google workspace", + "doc new gsuite", + "doc new workspace", + "doc open browser", + "doc open chrome", + "doc open g suite", + "doc open google", + "doc open google chrome", + "doc open google workspace", + "doc open gsuite", + "doc open workspace", + "doc start browser", + "doc start chrome", + "doc start g suite", + "doc start google", + "doc start google chrome", + "doc start google workspace", + "doc start gsuite", + "doc start workspace", + "doc workspace create", + "doc workspace make", + "doc workspace new", + "doc workspace open", + "doc workspace start", + "document browser create", + "document browser make", + "document browser new", + "document browser open", + "document browser start", + "document chrome create", + "document chrome make", + "document chrome new", + "document chrome open", + "document chrome start", + "document create browser", + "document create chrome", + "document create g suite", + "document create google", + "document create google chrome", + "document create google workspace", + "document create gsuite", + "document create workspace", + "document g suite create", + "document g suite make", + "document g suite new", + "document g suite open", + "document g suite start", + "document google chrome create", + "document google chrome make", + "document google chrome new", + "document google chrome open", + "document google chrome start", + "document google create", + "document google make", + "document google new", + "document google open", + "document google start", + "document google workspace create", + "document google workspace make", + "document google workspace new", + "document google workspace open", + "document google workspace start", + "document gsuite create", + "document gsuite make", + "document gsuite new", + "document gsuite open", + "document gsuite start", + "document make browser", + "document make chrome", + "document make g suite", + "document make google", + "document make google chrome", + "document make google workspace", + "document make gsuite", + "document make workspace", + "document new browser", + "document new chrome", + "document new g suite", + "document new google", + "document new google chrome", + "document new google workspace", + "document new gsuite", + "document new workspace", + "document open browser", + "document open chrome", + "document open g suite", + "document open google", + "document open google chrome", + "document open google workspace", + "document open gsuite", + "document open workspace", + "document start browser", + "document start chrome", + "document start g suite", + "document start google", + "document start google chrome", + "document start google workspace", + "document start gsuite", + "document start workspace", + "document workspace create", + "document workspace make", + "document workspace new", + "document workspace open", + "document workspace start", + "g suite create doc", + "g suite create document", + "g suite doc create", + "g suite doc make", + "g suite doc new", + "g suite doc open", + "g suite doc start", + "g suite document create", + "g suite document make", + "g suite document new", + "g suite document open", + "g suite document start", + "g suite make doc", + "g suite make document", + "g suite new doc", + "g suite new document", + "g suite open doc", + "g suite open document", + "g suite start doc", + "g suite start document", + "google chrome create doc", + "google chrome create document", + "google chrome doc create", + "google chrome doc make", + "google chrome doc new", + "google chrome doc open", + "google chrome doc start", + "google chrome document create", + "google chrome document make", + "google chrome document new", + "google chrome document open", + "google chrome document start", + "google chrome make doc", + "google chrome make document", + "google chrome new doc", + "google chrome new document", + "google chrome open doc", + "google chrome open document", + "google chrome start doc", + "google chrome start document", + "google create doc", + "google create document", + "google doc create", + "google doc make", + "google doc new", + "google doc open", + "google doc start", + "google document create", + "google document make", + "google document new", + "google document open", + "google document start", + "google make doc", + "google make document", + "google new doc", + "google new document", + "google open doc", + "google open document", + "google start doc", + "google start document", + "google workspace create doc", + "google workspace create document", + "google workspace doc create", + "google workspace doc make", + "google workspace doc new", + "google workspace doc open", + "google workspace doc start", + "google workspace document create", + "google workspace document make", + "google workspace document new", + "google workspace document open", + "google workspace document start", + "google workspace make doc", + "google workspace make document", + "google workspace new doc", + "google workspace new document", + "google workspace open doc", + "google workspace open document", + "google workspace start doc", + "google workspace start document", + "gsuite create doc", + "gsuite create document", + "gsuite doc create", + "gsuite doc make", + "gsuite doc new", + "gsuite doc open", + "gsuite doc start", + "gsuite document create", + "gsuite document make", + "gsuite document new", + "gsuite document open", + "gsuite document start", + "gsuite make doc", + "gsuite make document", + "gsuite new doc", + "gsuite new document", + "gsuite open doc", + "gsuite open document", + "gsuite start doc", + "gsuite start document", + "make browser doc", + "make browser document", + "make chrome doc", + "make chrome document", + "make doc browser", + "make doc chrome", + "make doc g suite", + "make doc google", + "make doc google chrome", + "make doc google workspace", + "make doc gsuite", + "make doc workspace", + "make document browser", + "make document chrome", + "make document g suite", + "make document google", + "make document google chrome", + "make document google workspace", + "make document gsuite", + "make document workspace", + "make g suite doc", + "make g suite document", + "make google chrome doc", + "make google chrome document", + "make google doc", + "make google document", + "make google workspace doc", + "make google workspace document", + "make gsuite doc", + "make gsuite document", + "make workspace doc", + "make workspace document", + "new browser doc", + "new browser document", + "new chrome doc", + "new chrome document", + "new doc browser", + "new doc chrome", + "new doc g suite", + "new doc google", + "new doc google chrome", + "new doc google workspace", + "new doc gsuite", + "new doc workspace", + "new document browser", + "new document chrome", + "new document g suite", + "new document google", + "new document google chrome", + "new document google workspace", + "new document gsuite", + "new document workspace", + "new g suite doc", + "new g suite document", + "new google chrome doc", + "new google chrome document", + "new google doc", + "new google document", + "new google workspace doc", + "new google workspace document", + "new gsuite doc", + "new gsuite document", + "new workspace doc", + "new workspace document", + "open browser doc", + "open browser document", + "open chrome doc", + "open chrome document", + "open doc browser", + "open doc chrome", + "open doc g suite", + "open doc google", + "open doc google chrome", + "open doc google workspace", + "open doc gsuite", + "open doc workspace", + "open document browser", + "open document chrome", + "open document g suite", + "open document google", + "open document google chrome", + "open document google workspace", + "open document gsuite", + "open document workspace", + "open g suite doc", + "open g suite document", + "open google chrome doc", + "open google chrome document", + "open google doc", + "open google document", + "open google workspace doc", + "open google workspace document", + "open gsuite doc", + "open gsuite document", + "open workspace doc", + "open workspace document", + "start browser doc", + "start browser document", + "start chrome doc", + "start chrome document", + "start doc browser", + "start doc chrome", + "start doc g suite", + "start doc google", + "start doc google chrome", + "start doc google workspace", + "start doc gsuite", + "start doc workspace", + "start document browser", + "start document chrome", + "start document g suite", + "start document google", + "start document google chrome", + "start document google workspace", + "start document gsuite", + "start document workspace", + "start g suite doc", + "start g suite document", + "start google chrome doc", + "start google chrome document", + "start google doc", + "start google document", + "start google workspace doc", + "start google workspace document", + "start gsuite doc", + "start gsuite document", + "start workspace doc", + "start workspace document", + "workspace create doc", + "workspace create document", + "workspace doc create", + "workspace doc make", + "workspace doc new", + "workspace doc open", + "workspace doc start", + "workspace document create", + "workspace document make", + "workspace document new", + "workspace document open", + "workspace document start", + "workspace make doc", + "workspace make document", + "workspace new doc", + "workspace new document", + "workspace open doc", + "workspace open document", + "workspace start doc", + "workspace start document", + }, + + // ID#14 + { + // Generated suggestions: + "browser create sheet", + "browser create sheets", + "browser create spreadsheet", + "browser create trix", + "browser make sheet", + "browser make sheets", + "browser make spreadsheet", + "browser make trix", + "browser new sheet", + "browser new sheets", + "browser new spreadsheet", + "browser new trix", + "browser open sheet", + "browser open sheets", + "browser open spreadsheet", + "browser open trix", + "browser sheet create", + "browser sheet make", + "browser sheet new", + "browser sheet open", + "browser sheet start", + "browser sheets create", + "browser sheets make", + "browser sheets new", + "browser sheets open", + "browser sheets start", + "browser spreadsheet create", + "browser spreadsheet make", + "browser spreadsheet new", + "browser spreadsheet open", + "browser spreadsheet start", + "browser start sheet", + "browser start sheets", + "browser start spreadsheet", + "browser start trix", + "browser trix create", + "browser trix make", + "browser trix new", + "browser trix open", + "browser trix start", + "chrome create sheet", + "chrome create sheets", + "chrome create spreadsheet", + "chrome create trix", + "chrome make sheet", + "chrome make sheets", + "chrome make spreadsheet", + "chrome make trix", + "chrome new sheet", + "chrome new sheets", + "chrome new spreadsheet", + "chrome new trix", + "chrome open sheet", + "chrome open sheets", + "chrome open spreadsheet", + "chrome open trix", + "chrome sheet create", + "chrome sheet make", + "chrome sheet new", + "chrome sheet open", + "chrome sheet start", + "chrome sheets create", + "chrome sheets make", + "chrome sheets new", + "chrome sheets open", + "chrome sheets start", + "chrome spreadsheet create", + "chrome spreadsheet make", + "chrome spreadsheet new", + "chrome spreadsheet open", + "chrome spreadsheet start", + "chrome start sheet", + "chrome start sheets", + "chrome start spreadsheet", + "chrome start trix", + "chrome trix create", + "chrome trix make", + "chrome trix new", + "chrome trix open", + "chrome trix start", + "create browser sheet", + "create browser sheets", + "create browser spreadsheet", + "create browser trix", + "create chrome sheet", + "create chrome sheets", + "create chrome spreadsheet", + "create chrome trix", + "create g suite sheet", + "create g suite sheets", + "create g suite spreadsheet", + "create g suite trix", + "create google chrome sheet", + "create google chrome sheets", + "create google chrome spreadsheet", + "create google chrome trix", + "create google sheet", + "create google sheets", + "create google spreadsheet", + "create google trix", + "create google workspace sheet", + "create google workspace sheets", + "create google workspace spreadsheet", + "create google workspace trix", + "create sheet browser", + "create sheet chrome", + "create sheet g suite", + "create sheet google", + "create sheet google chrome", + "create sheet google workspace", + "create sheet workspace", + "create sheets browser", + "create sheets chrome", + "create sheets g suite", + "create sheets google", + "create sheets google chrome", + "create sheets google workspace", + "create sheets workspace", + "create spreadsheet browser", + "create spreadsheet chrome", + "create spreadsheet g suite", + "create spreadsheet google", + "create spreadsheet google chrome", + "create spreadsheet google workspace", + "create spreadsheet workspace", + "create trix browser", + "create trix chrome", + "create trix g suite", + "create trix google", + "create trix google chrome", + "create trix google workspace", + "create trix workspace", + "create workspace sheet", + "create workspace sheets", + "create workspace spreadsheet", + "create workspace trix", + "g suite create sheet", + "g suite create sheets", + "g suite create spreadsheet", + "g suite create trix", + "g suite make sheet", + "g suite make sheets", + "g suite make spreadsheet", + "g suite make trix", + "g suite new sheet", + "g suite new sheets", + "g suite new spreadsheet", + "g suite new trix", + "g suite open sheet", + "g suite open sheets", + "g suite open spreadsheet", + "g suite open trix", + "g suite sheet create", + "g suite sheet make", + "g suite sheet new", + "g suite sheet open", + "g suite sheet start", + "g suite sheets create", + "g suite sheets make", + "g suite sheets new", + "g suite sheets open", + "g suite sheets start", + "g suite spreadsheet create", + "g suite spreadsheet make", + "g suite spreadsheet new", + "g suite spreadsheet open", + "g suite spreadsheet start", + "g suite start sheet", + "g suite start sheets", + "g suite start spreadsheet", + "g suite start trix", + "g suite trix create", + "g suite trix make", + "g suite trix new", + "g suite trix open", + "g suite trix start", + "google chrome create sheet", + "google chrome create sheets", + "google chrome create spreadsheet", + "google chrome create trix", + "google chrome make sheet", + "google chrome make sheets", + "google chrome make spreadsheet", + "google chrome make trix", + "google chrome new sheet", + "google chrome new sheets", + "google chrome new spreadsheet", + "google chrome new trix", + "google chrome open sheet", + "google chrome open sheets", + "google chrome open spreadsheet", + "google chrome open trix", + "google chrome sheet create", + "google chrome sheet make", + "google chrome sheet new", + "google chrome sheet open", + "google chrome sheet start", + "google chrome sheets create", + "google chrome sheets make", + "google chrome sheets new", + "google chrome sheets open", + "google chrome sheets start", + "google chrome spreadsheet create", + "google chrome spreadsheet make", + "google chrome spreadsheet new", + "google chrome spreadsheet open", + "google chrome spreadsheet start", + "google chrome start sheet", + "google chrome start sheets", + "google chrome start spreadsheet", + "google chrome start trix", + "google chrome trix create", + "google chrome trix make", + "google chrome trix new", + "google chrome trix open", + "google chrome trix start", + "google create sheet", + "google create sheets", + "google create spreadsheet", + "google create trix", + "google make sheet", + "google make sheets", + "google make spreadsheet", + "google make trix", + "google new sheet", + "google new sheets", + "google new spreadsheet", + "google new trix", + "google open sheet", + "google open sheets", + "google open spreadsheet", + "google open trix", + "google sheet create", + "google sheet make", + "google sheet new", + "google sheet open", + "google sheet start", + "google sheets create", + "google sheets make", + "google sheets new", + "google sheets open", + "google sheets start", + "google spreadsheet create", + "google spreadsheet make", + "google spreadsheet new", + "google spreadsheet open", + "google spreadsheet start", + "google start sheet", + "google start sheets", + "google start spreadsheet", + "google start trix", + "google trix create", + "google trix make", + "google trix new", + "google trix open", + "google trix start", + "google workspace create sheet", + "google workspace create sheets", + "google workspace create spreadsheet", + "google workspace create trix", + "google workspace make sheet", + "google workspace make sheets", + "google workspace make spreadsheet", + "google workspace make trix", + "google workspace new sheet", + "google workspace new sheets", + "google workspace new spreadsheet", + "google workspace new trix", + "google workspace open sheet", + "google workspace open sheets", + "google workspace open spreadsheet", + "google workspace open trix", + "google workspace sheet create", + "google workspace sheet make", + "google workspace sheet new", + "google workspace sheet open", + "google workspace sheet start", + "google workspace sheets create", + "google workspace sheets make", + "google workspace sheets new", + "google workspace sheets open", + "google workspace sheets start", + "google workspace spreadsheet create", + "google workspace spreadsheet make", + "google workspace spreadsheet new", + "google workspace spreadsheet open", + "google workspace spreadsheet start", + "google workspace start sheet", + "google workspace start sheets", + "google workspace start spreadsheet", + "google workspace start trix", + "google workspace trix create", + "google workspace trix make", + "google workspace trix new", + "google workspace trix open", + "google workspace trix start", + "make browser sheet", + "make browser sheets", + "make browser spreadsheet", + "make browser trix", + "make chrome sheet", + "make chrome sheets", + "make chrome spreadsheet", + "make chrome trix", + "make g suite sheet", + "make g suite sheets", + "make g suite spreadsheet", + "make g suite trix", + "make google chrome sheet", + "make google chrome sheets", + "make google chrome spreadsheet", + "make google chrome trix", + "make google sheet", + "make google sheets", + "make google spreadsheet", + "make google trix", + "make google workspace sheet", + "make google workspace sheets", + "make google workspace spreadsheet", + "make google workspace trix", + "make sheet browser", + "make sheet chrome", + "make sheet g suite", + "make sheet google", + "make sheet google chrome", + "make sheet google workspace", + "make sheet workspace", + "make sheets browser", + "make sheets chrome", + "make sheets g suite", + "make sheets google", + "make sheets google chrome", + "make sheets google workspace", + "make sheets workspace", + "make spreadsheet browser", + "make spreadsheet chrome", + "make spreadsheet g suite", + "make spreadsheet google", + "make spreadsheet google chrome", + "make spreadsheet google workspace", + "make spreadsheet workspace", + "make trix browser", + "make trix chrome", + "make trix g suite", + "make trix google", + "make trix google chrome", + "make trix google workspace", + "make trix workspace", + "make workspace sheet", + "make workspace sheets", + "make workspace spreadsheet", + "make workspace trix", + "new browser sheet", + "new browser sheets", + "new browser spreadsheet", + "new browser trix", + "new chrome sheet", + "new chrome sheets", + "new chrome spreadsheet", + "new chrome trix", + "new g suite sheet", + "new g suite sheets", + "new g suite spreadsheet", + "new g suite trix", + "new google chrome sheet", + "new google chrome sheets", + "new google chrome spreadsheet", + "new google chrome trix", + "new google sheet", + "new google sheets", + "new google spreadsheet", + "new google trix", + "new google workspace sheet", + "new google workspace sheets", + "new google workspace spreadsheet", + "new google workspace trix", + "new sheet browser", + "new sheet chrome", + "new sheet g suite", + "new sheet google", + "new sheet google chrome", + "new sheet google workspace", + "new sheet workspace", + "new sheets browser", + "new sheets chrome", + "new sheets g suite", + "new sheets google", + "new sheets google chrome", + "new sheets google workspace", + "new sheets workspace", + "new spreadsheet browser", + "new spreadsheet chrome", + "new spreadsheet g suite", + "new spreadsheet google", + "new spreadsheet google chrome", + "new spreadsheet google workspace", + "new spreadsheet workspace", + "new trix browser", + "new trix chrome", + "new trix g suite", + "new trix google", + "new trix google chrome", + "new trix google workspace", + "new trix workspace", + "new workspace sheet", + "new workspace sheets", + "new workspace spreadsheet", + "new workspace trix", + "open browser sheet", + "open browser sheets", + "open browser spreadsheet", + "open browser trix", + "open chrome sheet", + "open chrome sheets", + "open chrome spreadsheet", + "open chrome trix", + "open g suite sheet", + "open g suite sheets", + "open g suite spreadsheet", + "open g suite trix", + "open google chrome sheet", + "open google chrome sheets", + "open google chrome spreadsheet", + "open google chrome trix", + "open google sheet", + "open google sheets", + "open google spreadsheet", + "open google trix", + "open google workspace sheet", + "open google workspace sheets", + "open google workspace spreadsheet", + "open google workspace trix", + "open sheet browser", + "open sheet chrome", + "open sheet g suite", + "open sheet google", + "open sheet google chrome", + "open sheet google workspace", + "open sheet workspace", + "open sheets browser", + "open sheets chrome", + "open sheets g suite", + "open sheets google", + "open sheets google chrome", + "open sheets google workspace", + "open sheets workspace", + "open spreadsheet browser", + "open spreadsheet chrome", + "open spreadsheet g suite", + "open spreadsheet google", + "open spreadsheet google chrome", + "open spreadsheet google workspace", + "open spreadsheet workspace", + "open trix browser", + "open trix chrome", + "open trix g suite", + "open trix google", + "open trix google chrome", + "open trix google workspace", + "open trix workspace", + "open workspace sheet", + "open workspace sheets", + "open workspace spreadsheet", + "open workspace trix", + "sheet browser create", + "sheet browser make", + "sheet browser new", + "sheet browser open", + "sheet browser start", + "sheet chrome create", + "sheet chrome make", + "sheet chrome new", + "sheet chrome open", + "sheet chrome start", + "sheet create browser", + "sheet create chrome", + "sheet create g suite", + "sheet create google", + "sheet create google chrome", + "sheet create google workspace", + "sheet create workspace", + "sheet g suite create", + "sheet g suite make", + "sheet g suite new", + "sheet g suite open", + "sheet g suite start", + "sheet google chrome create", + "sheet google chrome make", + "sheet google chrome new", + "sheet google chrome open", + "sheet google chrome start", + "sheet google create", + "sheet google make", + "sheet google new", + "sheet google open", + "sheet google start", + "sheet google workspace create", + "sheet google workspace make", + "sheet google workspace new", + "sheet google workspace open", + "sheet google workspace start", + "sheet make browser", + "sheet make chrome", + "sheet make g suite", + "sheet make google", + "sheet make google chrome", + "sheet make google workspace", + "sheet make workspace", + "sheet new browser", + "sheet new chrome", + "sheet new g suite", + "sheet new google", + "sheet new google chrome", + "sheet new google workspace", + "sheet new workspace", + "sheet open browser", + "sheet open chrome", + "sheet open g suite", + "sheet open google", + "sheet open google chrome", + "sheet open google workspace", + "sheet open workspace", + "sheet start browser", + "sheet start chrome", + "sheet start g suite", + "sheet start google", + "sheet start google chrome", + "sheet start google workspace", + "sheet start workspace", + "sheet workspace create", + "sheet workspace make", + "sheet workspace new", + "sheet workspace open", + "sheet workspace start", + "sheets browser create", + "sheets browser make", + "sheets browser new", + "sheets browser open", + "sheets browser start", + "sheets chrome create", + "sheets chrome make", + "sheets chrome new", + "sheets chrome open", + "sheets chrome start", + "sheets create browser", + "sheets create chrome", + "sheets create g suite", + "sheets create google", + "sheets create google chrome", + "sheets create google workspace", + "sheets create workspace", + "sheets g suite create", + "sheets g suite make", + "sheets g suite new", + "sheets g suite open", + "sheets g suite start", + "sheets google chrome create", + "sheets google chrome make", + "sheets google chrome new", + "sheets google chrome open", + "sheets google chrome start", + "sheets google create", + "sheets google make", + "sheets google new", + "sheets google open", + "sheets google start", + "sheets google workspace create", + "sheets google workspace make", + "sheets google workspace new", + "sheets google workspace open", + "sheets google workspace start", + "sheets make browser", + "sheets make chrome", + "sheets make g suite", + "sheets make google", + "sheets make google chrome", + "sheets make google workspace", + "sheets make workspace", + "sheets new browser", + "sheets new chrome", + "sheets new g suite", + "sheets new google", + "sheets new google chrome", + "sheets new google workspace", + "sheets new workspace", + "sheets open browser", + "sheets open chrome", + "sheets open g suite", + "sheets open google", + "sheets open google chrome", + "sheets open google workspace", + "sheets open workspace", + "sheets start browser", + "sheets start chrome", + "sheets start g suite", + "sheets start google", + "sheets start google chrome", + "sheets start google workspace", + "sheets start workspace", + "sheets workspace create", + "sheets workspace make", + "sheets workspace new", + "sheets workspace open", + "sheets workspace start", + "spreadsheet browser create", + "spreadsheet browser make", + "spreadsheet browser new", + "spreadsheet browser open", + "spreadsheet browser start", + "spreadsheet chrome create", + "spreadsheet chrome make", + "spreadsheet chrome new", + "spreadsheet chrome open", + "spreadsheet chrome start", + "spreadsheet create browser", + "spreadsheet create chrome", + "spreadsheet create g suite", + "spreadsheet create google", + "spreadsheet create google chrome", + "spreadsheet create google workspace", + "spreadsheet create workspace", + "spreadsheet g suite create", + "spreadsheet g suite make", + "spreadsheet g suite new", + "spreadsheet g suite open", + "spreadsheet g suite start", + "spreadsheet google chrome create", + "spreadsheet google chrome make", + "spreadsheet google chrome new", + "spreadsheet google chrome open", + "spreadsheet google chrome start", + "spreadsheet google create", + "spreadsheet google make", + "spreadsheet google new", + "spreadsheet google open", + "spreadsheet google start", + "spreadsheet google workspace create", + "spreadsheet google workspace make", + "spreadsheet google workspace new", + "spreadsheet google workspace open", + "spreadsheet google workspace start", + "spreadsheet make browser", + "spreadsheet make chrome", + "spreadsheet make g suite", + "spreadsheet make google", + "spreadsheet make google chrome", + "spreadsheet make google workspace", + "spreadsheet make workspace", + "spreadsheet new browser", + "spreadsheet new chrome", + "spreadsheet new g suite", + "spreadsheet new google", + "spreadsheet new google chrome", + "spreadsheet new google workspace", + "spreadsheet new workspace", + "spreadsheet open browser", + "spreadsheet open chrome", + "spreadsheet open g suite", + "spreadsheet open google", + "spreadsheet open google chrome", + "spreadsheet open google workspace", + "spreadsheet open workspace", + "spreadsheet start browser", + "spreadsheet start chrome", + "spreadsheet start g suite", + "spreadsheet start google", + "spreadsheet start google chrome", + "spreadsheet start google workspace", + "spreadsheet start workspace", + "spreadsheet workspace create", + "spreadsheet workspace make", + "spreadsheet workspace new", + "spreadsheet workspace open", + "spreadsheet workspace start", + "start browser sheet", + "start browser sheets", + "start browser spreadsheet", + "start browser trix", + "start chrome sheet", + "start chrome sheets", + "start chrome spreadsheet", + "start chrome trix", + "start g suite sheet", + "start g suite sheets", + "start g suite spreadsheet", + "start g suite trix", + "start google chrome sheet", + "start google chrome sheets", + "start google chrome spreadsheet", + "start google chrome trix", + "start google sheet", + "start google sheets", + "start google spreadsheet", + "start google trix", + "start google workspace sheet", + "start google workspace sheets", + "start google workspace spreadsheet", + "start google workspace trix", + "start sheet browser", + "start sheet chrome", + "start sheet g suite", + "start sheet google", + "start sheet google chrome", + "start sheet google workspace", + "start sheet workspace", + "start sheets browser", + "start sheets chrome", + "start sheets g suite", + "start sheets google", + "start sheets google chrome", + "start sheets google workspace", + "start sheets workspace", + "start spreadsheet browser", + "start spreadsheet chrome", + "start spreadsheet g suite", + "start spreadsheet google", + "start spreadsheet google chrome", + "start spreadsheet google workspace", + "start spreadsheet workspace", + "start trix browser", + "start trix chrome", + "start trix g suite", + "start trix google", + "start trix google chrome", + "start trix google workspace", + "start trix workspace", + "start workspace sheet", + "start workspace sheets", + "start workspace spreadsheet", + "start workspace trix", + "trix browser create", + "trix browser make", + "trix browser new", + "trix browser open", + "trix browser start", + "trix chrome create", + "trix chrome make", + "trix chrome new", + "trix chrome open", + "trix chrome start", + "trix create browser", + "trix create chrome", + "trix create g suite", + "trix create google", + "trix create google chrome", + "trix create google workspace", + "trix create workspace", + "trix g suite create", + "trix g suite make", + "trix g suite new", + "trix g suite open", + "trix g suite start", + "trix google chrome create", + "trix google chrome make", + "trix google chrome new", + "trix google chrome open", + "trix google chrome start", + "trix google create", + "trix google make", + "trix google new", + "trix google open", + "trix google start", + "trix google workspace create", + "trix google workspace make", + "trix google workspace new", + "trix google workspace open", + "trix google workspace start", + "trix make browser", + "trix make chrome", + "trix make g suite", + "trix make google", + "trix make google chrome", + "trix make google workspace", + "trix make workspace", + "trix new browser", + "trix new chrome", + "trix new g suite", + "trix new google", + "trix new google chrome", + "trix new google workspace", + "trix new workspace", + "trix open browser", + "trix open chrome", + "trix open g suite", + "trix open google", + "trix open google chrome", + "trix open google workspace", + "trix open workspace", + "trix start browser", + "trix start chrome", + "trix start g suite", + "trix start google", + "trix start google chrome", + "trix start google workspace", + "trix start workspace", + "trix workspace create", + "trix workspace make", + "trix workspace new", + "trix workspace open", + "trix workspace start", + "workspace create sheet", + "workspace create sheets", + "workspace create spreadsheet", + "workspace create trix", + "workspace make sheet", + "workspace make sheets", + "workspace make spreadsheet", + "workspace make trix", + "workspace new sheet", + "workspace new sheets", + "workspace new spreadsheet", + "workspace new trix", + "workspace open sheet", + "workspace open sheets", + "workspace open spreadsheet", + "workspace open trix", + "workspace sheet create", + "workspace sheet make", + "workspace sheet new", + "workspace sheet open", + "workspace sheet start", + "workspace sheets create", + "workspace sheets make", + "workspace sheets new", + "workspace sheets open", + "workspace sheets start", + "workspace spreadsheet create", + "workspace spreadsheet make", + "workspace spreadsheet new", + "workspace spreadsheet open", + "workspace spreadsheet start", + "workspace start sheet", + "workspace start sheets", + "workspace start spreadsheet", + "workspace start trix", + "workspace trix create", + "workspace trix make", + "workspace trix new", + "workspace trix open", + "workspace trix start", + }, + + // ID#15 + { + // Generated suggestions: + "browser create deck", + "browser create presentation", + "browser create preso", + "browser create slide", + "browser create slides", + "browser deck create", + "browser deck make", + "browser deck new", + "browser deck open", + "browser deck start", + "browser make deck", + "browser make presentation", + "browser make preso", + "browser make slide", + "browser make slides", + "browser new deck", + "browser new presentation", + "browser new preso", + "browser new slide", + "browser new slides", + "browser open deck", + "browser open presentation", + "browser open preso", + "browser open slide", + "browser open slides", + "browser presentation create", + "browser presentation make", + "browser presentation new", + "browser presentation open", + "browser presentation start", + "browser preso create", + "browser preso make", + "browser preso new", + "browser preso open", + "browser preso start", + "browser slide create", + "browser slide make", + "browser slide new", + "browser slide open", + "browser slide start", + "browser slides create", + "browser slides make", + "browser slides new", + "browser slides open", + "browser slides start", + "browser start deck", + "browser start presentation", + "browser start preso", + "browser start slide", + "browser start slides", + "chrome create deck", + "chrome create presentation", + "chrome create preso", + "chrome create slide", + "chrome create slides", + "chrome deck create", + "chrome deck make", + "chrome deck new", + "chrome deck open", + "chrome deck start", + "chrome make deck", + "chrome make presentation", + "chrome make preso", + "chrome make slide", + "chrome make slides", + "chrome new deck", + "chrome new presentation", + "chrome new preso", + "chrome new slide", + "chrome new slides", + "chrome open deck", + "chrome open presentation", + "chrome open preso", + "chrome open slide", + "chrome open slides", + "chrome presentation create", + "chrome presentation make", + "chrome presentation new", + "chrome presentation open", + "chrome presentation start", + "chrome preso create", + "chrome preso make", + "chrome preso new", + "chrome preso open", + "chrome preso start", + "chrome slide create", + "chrome slide make", + "chrome slide new", + "chrome slide open", + "chrome slide start", + "chrome slides create", + "chrome slides make", + "chrome slides new", + "chrome slides open", + "chrome slides start", + "chrome start deck", + "chrome start presentation", + "chrome start preso", + "chrome start slide", + "chrome start slides", + "create browser deck", + "create browser presentation", + "create browser preso", + "create browser slide", + "create browser slides", + "create chrome deck", + "create chrome presentation", + "create chrome preso", + "create chrome slide", + "create chrome slides", + "create deck browser", + "create deck chrome", + "create deck g suite", + "create deck google", + "create deck workspace", + "create g suite deck", + "create g suite presentation", + "create g suite preso", + "create g suite slide", + "create g suite slides", + "create google deck", + "create google presentation", + "create google preso", + "create google slide", + "create google slides", + "create presentation browser", + "create presentation chrome", + "create presentation g suite", + "create presentation google", + "create presentation workspace", + "create preso browser", + "create preso chrome", + "create preso g suite", + "create preso google", + "create preso workspace", + "create slide browser", + "create slide chrome", + "create slide g suite", + "create slide google", + "create slide workspace", + "create slides browser", + "create slides chrome", + "create slides g suite", + "create slides google", + "create slides workspace", + "create workspace deck", + "create workspace presentation", + "create workspace preso", + "create workspace slide", + "create workspace slides", + "deck browser create", + "deck browser make", + "deck browser new", + "deck browser open", + "deck browser start", + "deck chrome create", + "deck chrome make", + "deck chrome new", + "deck chrome open", + "deck chrome start", + "deck create browser", + "deck create chrome", + "deck create g suite", + "deck create google", + "deck create workspace", + "deck g suite create", + "deck g suite make", + "deck g suite new", + "deck g suite open", + "deck g suite start", + "deck google create", + "deck google make", + "deck google new", + "deck google open", + "deck google start", + "deck make browser", + "deck make chrome", + "deck make g suite", + "deck make google", + "deck make workspace", + "deck new browser", + "deck new chrome", + "deck new g suite", + "deck new google", + "deck new workspace", + "deck open browser", + "deck open chrome", + "deck open g suite", + "deck open google", + "deck open workspace", + "deck start browser", + "deck start chrome", + "deck start g suite", + "deck start google", + "deck start workspace", + "deck workspace create", + "deck workspace make", + "deck workspace new", + "deck workspace open", + "deck workspace start", + "g suite create deck", + "g suite create presentation", + "g suite create preso", + "g suite create slide", + "g suite create slides", + "g suite deck create", + "g suite deck make", + "g suite deck new", + "g suite deck open", + "g suite deck start", + "g suite make deck", + "g suite make presentation", + "g suite make preso", + "g suite make slide", + "g suite make slides", + "g suite new deck", + "g suite new presentation", + "g suite new preso", + "g suite new slide", + "g suite new slides", + "g suite open deck", + "g suite open presentation", + "g suite open preso", + "g suite open slide", + "g suite open slides", + "g suite presentation create", + "g suite presentation make", + "g suite presentation new", + "g suite presentation open", + "g suite presentation start", + "g suite preso create", + "g suite preso make", + "g suite preso new", + "g suite preso open", + "g suite preso start", + "g suite slide create", + "g suite slide make", + "g suite slide new", + "g suite slide open", + "g suite slide start", + "g suite slides create", + "g suite slides make", + "g suite slides new", + "g suite slides open", + "g suite slides start", + "g suite start deck", + "g suite start presentation", + "g suite start preso", + "g suite start slide", + "g suite start slides", + "google create deck", + "google create presentation", + "google create preso", + "google create slide", + "google create slides", + "google deck create", + "google deck make", + "google deck new", + "google deck open", + "google deck start", + "google make deck", + "google make presentation", + "google make preso", + "google make slide", + "google make slides", + "google new deck", + "google new presentation", + "google new preso", + "google new slide", + "google new slides", + "google open deck", + "google open presentation", + "google open preso", + "google open slide", + "google open slides", + "google presentation create", + "google presentation make", + "google presentation new", + "google presentation open", + "google presentation start", + "google preso create", + "google preso make", + "google preso new", + "google preso open", + "google preso start", + "google slide create", + "google slide make", + "google slide new", + "google slide open", + "google slide start", + "google slides create", + "google slides make", + "google slides new", + "google slides open", + "google slides start", + "google start deck", + "google start presentation", + "google start preso", + "google start slide", + "google start slides", + "make browser deck", + "make browser presentation", + "make browser preso", + "make browser slide", + "make browser slides", + "make chrome deck", + "make chrome presentation", + "make chrome preso", + "make chrome slide", + "make chrome slides", + "make deck browser", + "make deck chrome", + "make deck g suite", + "make deck google", + "make deck workspace", + "make g suite deck", + "make g suite presentation", + "make g suite preso", + "make g suite slide", + "make g suite slides", + "make google deck", + "make google presentation", + "make google preso", + "make google slide", + "make google slides", + "make presentation browser", + "make presentation chrome", + "make presentation g suite", + "make presentation google", + "make presentation workspace", + "make preso browser", + "make preso chrome", + "make preso g suite", + "make preso google", + "make preso workspace", + "make slide browser", + "make slide chrome", + "make slide g suite", + "make slide google", + "make slide workspace", + "make slides browser", + "make slides chrome", + "make slides g suite", + "make slides google", + "make slides workspace", + "make workspace deck", + "make workspace presentation", + "make workspace preso", + "make workspace slide", + "make workspace slides", + "new browser deck", + "new browser presentation", + "new browser preso", + "new browser slide", + "new browser slides", + "new chrome deck", + "new chrome presentation", + "new chrome preso", + "new chrome slide", + "new chrome slides", + "new deck browser", + "new deck chrome", + "new deck g suite", + "new deck google", + "new deck workspace", + "new g suite deck", + "new g suite presentation", + "new g suite preso", + "new g suite slide", + "new g suite slides", + "new google deck", + "new google presentation", + "new google preso", + "new google slide", + "new google slides", + "new presentation browser", + "new presentation chrome", + "new presentation g suite", + "new presentation google", + "new presentation workspace", + "new preso browser", + "new preso chrome", + "new preso g suite", + "new preso google", + "new preso workspace", + "new slide browser", + "new slide chrome", + "new slide g suite", + "new slide google", + "new slide workspace", + "new slides browser", + "new slides chrome", + "new slides g suite", + "new slides google", + "new slides workspace", + "new workspace deck", + "new workspace presentation", + "new workspace preso", + "new workspace slide", + "new workspace slides", + "open browser deck", + "open browser presentation", + "open browser preso", + "open browser slide", + "open browser slides", + "open chrome deck", + "open chrome presentation", + "open chrome preso", + "open chrome slide", + "open chrome slides", + "open deck browser", + "open deck chrome", + "open deck g suite", + "open deck google", + "open deck workspace", + "open g suite deck", + "open g suite presentation", + "open g suite preso", + "open g suite slide", + "open g suite slides", + "open google deck", + "open google presentation", + "open google preso", + "open google slide", + "open google slides", + "open presentation browser", + "open presentation chrome", + "open presentation g suite", + "open presentation google", + "open presentation workspace", + "open preso browser", + "open preso chrome", + "open preso g suite", + "open preso google", + "open preso workspace", + "open slide browser", + "open slide chrome", + "open slide g suite", + "open slide google", + "open slide workspace", + "open slides browser", + "open slides chrome", + "open slides g suite", + "open slides google", + "open slides workspace", + "open workspace deck", + "open workspace presentation", + "open workspace preso", + "open workspace slide", + "open workspace slides", + "presentation browser create", + "presentation browser make", + "presentation browser new", + "presentation browser open", + "presentation browser start", + "presentation chrome create", + "presentation chrome make", + "presentation chrome new", + "presentation chrome open", + "presentation chrome start", + "presentation create browser", + "presentation create chrome", + "presentation create g suite", + "presentation create google", + "presentation create workspace", + "presentation g suite create", + "presentation g suite make", + "presentation g suite new", + "presentation g suite open", + "presentation g suite start", + "presentation google create", + "presentation google make", + "presentation google new", + "presentation google open", + "presentation google start", + "presentation make browser", + "presentation make chrome", + "presentation make g suite", + "presentation make google", + "presentation make workspace", + "presentation new browser", + "presentation new chrome", + "presentation new g suite", + "presentation new google", + "presentation new workspace", + "presentation open browser", + "presentation open chrome", + "presentation open g suite", + "presentation open google", + "presentation open workspace", + "presentation start browser", + "presentation start chrome", + "presentation start g suite", + "presentation start google", + "presentation start workspace", + "presentation workspace create", + "presentation workspace make", + "presentation workspace new", + "presentation workspace open", + "presentation workspace start", + "preso browser create", + "preso browser make", + "preso browser new", + "preso browser open", + "preso browser start", + "preso chrome create", + "preso chrome make", + "preso chrome new", + "preso chrome open", + "preso chrome start", + "preso create browser", + "preso create chrome", + "preso create g suite", + "preso create google", + "preso create workspace", + "preso g suite create", + "preso g suite make", + "preso g suite new", + "preso g suite open", + "preso g suite start", + "preso google create", + "preso google make", + "preso google new", + "preso google open", + "preso google start", + "preso make browser", + "preso make chrome", + "preso make g suite", + "preso make google", + "preso make workspace", + "preso new browser", + "preso new chrome", + "preso new g suite", + "preso new google", + "preso new workspace", + "preso open browser", + "preso open chrome", + "preso open g suite", + "preso open google", + "preso open workspace", + "preso start browser", + "preso start chrome", + "preso start g suite", + "preso start google", + "preso start workspace", + "preso workspace create", + "preso workspace make", + "preso workspace new", + "preso workspace open", + "preso workspace start", + "slide browser create", + "slide browser make", + "slide browser new", + "slide browser open", + "slide browser start", + "slide chrome create", + "slide chrome make", + "slide chrome new", + "slide chrome open", + "slide chrome start", + "slide create browser", + "slide create chrome", + "slide create g suite", + "slide create google", + "slide create workspace", + "slide g suite create", + "slide g suite make", + "slide g suite new", + "slide g suite open", + "slide g suite start", + "slide google create", + "slide google make", + "slide google new", + "slide google open", + "slide google start", + "slide make browser", + "slide make chrome", + "slide make g suite", + "slide make google", + "slide make workspace", + "slide new browser", + "slide new chrome", + "slide new g suite", + "slide new google", + "slide new workspace", + "slide open browser", + "slide open chrome", + "slide open g suite", + "slide open google", + "slide open workspace", + "slide start browser", + "slide start chrome", + "slide start g suite", + "slide start google", + "slide start workspace", + "slide workspace create", + "slide workspace make", + "slide workspace new", + "slide workspace open", + "slide workspace start", + "slides browser create", + "slides browser make", + "slides browser new", + "slides browser open", + "slides browser start", + "slides chrome create", + "slides chrome make", + "slides chrome new", + "slides chrome open", + "slides chrome start", + "slides create browser", + "slides create chrome", + "slides create g suite", + "slides create google", + "slides create workspace", + "slides g suite create", + "slides g suite make", + "slides g suite new", + "slides g suite open", + "slides g suite start", + "slides google create", + "slides google make", + "slides google new", + "slides google open", + "slides google start", + "slides make browser", + "slides make chrome", + "slides make g suite", + "slides make google", + "slides make workspace", + "slides new browser", + "slides new chrome", + "slides new g suite", + "slides new google", + "slides new workspace", + "slides open browser", + "slides open chrome", + "slides open g suite", + "slides open google", + "slides open workspace", + "slides start browser", + "slides start chrome", + "slides start g suite", + "slides start google", + "slides start workspace", + "slides workspace create", + "slides workspace make", + "slides workspace new", + "slides workspace open", + "slides workspace start", + "start browser deck", + "start browser presentation", + "start browser preso", + "start browser slide", + "start browser slides", + "start chrome deck", + "start chrome presentation", + "start chrome preso", + "start chrome slide", + "start chrome slides", + "start deck browser", + "start deck chrome", + "start deck g suite", + "start deck google", + "start deck workspace", + "start g suite deck", + "start g suite presentation", + "start g suite preso", + "start g suite slide", + "start g suite slides", + "start google deck", + "start google presentation", + "start google preso", + "start google slide", + "start google slides", + "start presentation browser", + "start presentation chrome", + "start presentation g suite", + "start presentation google", + "start presentation workspace", + "start preso browser", + "start preso chrome", + "start preso g suite", + "start preso google", + "start preso workspace", + "start slide browser", + "start slide chrome", + "start slide g suite", + "start slide google", + "start slide workspace", + "start slides browser", + "start slides chrome", + "start slides g suite", + "start slides google", + "start slides workspace", + "start workspace deck", + "start workspace presentation", + "start workspace preso", + "start workspace slide", + "start workspace slides", + "workspace create deck", + "workspace create presentation", + "workspace create preso", + "workspace create slide", + "workspace create slides", + "workspace deck create", + "workspace deck make", + "workspace deck new", + "workspace deck open", + "workspace deck start", + "workspace make deck", + "workspace make presentation", + "workspace make preso", + "workspace make slide", + "workspace make slides", + "workspace new deck", + "workspace new presentation", + "workspace new preso", + "workspace new slide", + "workspace new slides", + "workspace open deck", + "workspace open presentation", + "workspace open preso", + "workspace open slide", + "workspace open slides", + "workspace presentation create", + "workspace presentation make", + "workspace presentation new", + "workspace presentation open", + "workspace presentation start", + "workspace preso create", + "workspace preso make", + "workspace preso new", + "workspace preso open", + "workspace preso start", + "workspace slide create", + "workspace slide make", + "workspace slide new", + "workspace slide open", + "workspace slide start", + "workspace slides create", + "workspace slides make", + "workspace slides new", + "workspace slides open", + "workspace slides start", + "workspace start deck", + "workspace start presentation", + "workspace start preso", + "workspace start slide", + "workspace start slides", + }, + + // ID#16 + { + // Generated suggestions: + "add browser event", + "add browser invite", + "add browser meeting", + "add cal event", + "add cal invite", + "add cal meeting", + "add calendar event", + "add calendar invite", + "add calendar meeting", + "add chrome event", + "add chrome invite", + "add chrome meeting", + "add event browser", + "add event cal", + "add event calendar", + "add event chrome", + "add event g suite", + "add event google", + "add event workspace", + "add g suite event", + "add g suite invite", + "add g suite meeting", + "add google event", + "add google invite", + "add google meeting", + "add invite browser", + "add invite cal", + "add invite calendar", + "add invite chrome", + "add invite g suite", + "add invite google", + "add invite workspace", + "add meeting browser", + "add meeting cal", + "add meeting calendar", + "add meeting chrome", + "add meeting g suite", + "add meeting google", + "add meeting workspace", + "add workspace event", + "add workspace invite", + "add workspace meeting", + "browser add event", + "browser add invite", + "browser add meeting", + "browser create event", + "browser create invite", + "browser create meeting", + "browser event add", + "browser event create", + "browser event make", + "browser event new", + "browser event open", + "browser event schedule", + "browser event start", + "browser invite add", + "browser invite create", + "browser invite make", + "browser invite new", + "browser invite open", + "browser invite schedule", + "browser invite start", + "browser make event", + "browser make invite", + "browser make meeting", + "browser meeting add", + "browser meeting create", + "browser meeting make", + "browser meeting new", + "browser meeting open", + "browser meeting schedule", + "browser meeting start", + "browser new event", + "browser new invite", + "browser new meeting", + "browser open event", + "browser open invite", + "browser open meeting", + "browser schedule event", + "browser schedule invite", + "browser schedule meeting", + "browser start event", + "browser start invite", + "browser start meeting", + "cal add event", + "cal add invite", + "cal add meeting", + "cal create event", + "cal create invite", + "cal create meeting", + "cal event add", + "cal event create", + "cal event make", + "cal event new", + "cal event open", + "cal event schedule", + "cal event start", + "cal invite add", + "cal invite create", + "cal invite make", + "cal invite new", + "cal invite open", + "cal invite schedule", + "cal invite start", + "cal make event", + "cal make invite", + "cal make meeting", + "cal meeting add", + "cal meeting create", + "cal meeting make", + "cal meeting new", + "cal meeting open", + "cal meeting schedule", + "cal meeting start", + "cal new event", + "cal new invite", + "cal new meeting", + "cal open event", + "cal open invite", + "cal open meeting", + "cal schedule event", + "cal schedule invite", + "cal schedule meeting", + "cal start event", + "cal start invite", + "cal start meeting", + "calendar add event", + "calendar add invite", + "calendar add meeting", + "calendar create event", + "calendar create invite", + "calendar create meeting", + "calendar event add", + "calendar event create", + "calendar event make", + "calendar event new", + "calendar event open", + "calendar event schedule", + "calendar event start", + "calendar invite add", + "calendar invite create", + "calendar invite make", + "calendar invite new", + "calendar invite open", + "calendar invite schedule", + "calendar invite start", + "calendar make event", + "calendar make invite", + "calendar make meeting", + "calendar meeting add", + "calendar meeting create", + "calendar meeting make", + "calendar meeting new", + "calendar meeting open", + "calendar meeting schedule", + "calendar meeting start", + "calendar new event", + "calendar new invite", + "calendar new meeting", + "calendar open event", + "calendar open invite", + "calendar open meeting", + "calendar schedule event", + "calendar schedule invite", + "calendar schedule meeting", + "calendar start event", + "calendar start invite", + "calendar start meeting", + "chrome add event", + "chrome add invite", + "chrome add meeting", + "chrome create event", + "chrome create invite", + "chrome create meeting", + "chrome event add", + "chrome event create", + "chrome event make", + "chrome event new", + "chrome event open", + "chrome event schedule", + "chrome event start", + "chrome invite add", + "chrome invite create", + "chrome invite make", + "chrome invite new", + "chrome invite open", + "chrome invite schedule", + "chrome invite start", + "chrome make event", + "chrome make invite", + "chrome make meeting", + "chrome meeting add", + "chrome meeting create", + "chrome meeting make", + "chrome meeting new", + "chrome meeting open", + "chrome meeting schedule", + "chrome meeting start", + "chrome new event", + "chrome new invite", + "chrome new meeting", + "chrome open event", + "chrome open invite", + "chrome open meeting", + "chrome schedule event", + "chrome schedule invite", + "chrome schedule meeting", + "chrome start event", + "chrome start invite", + "chrome start meeting", + "create browser event", + "create browser invite", + "create browser meeting", + "create cal event", + "create cal invite", + "create cal meeting", + "create calendar event", + "create calendar invite", + "create calendar meeting", + "create chrome event", + "create chrome invite", + "create chrome meeting", + "create event browser", + "create event cal", + "create event calendar", + "create event chrome", + "create event g suite", + "create event google", + "create event workspace", + "create g suite event", + "create g suite invite", + "create g suite meeting", + "create google event", + "create google invite", + "create google meeting", + "create invite browser", + "create invite cal", + "create invite calendar", + "create invite chrome", + "create invite g suite", + "create invite google", + "create invite workspace", + "create meeting browser", + "create meeting cal", + "create meeting calendar", + "create meeting chrome", + "create meeting g suite", + "create meeting google", + "create meeting workspace", + "create workspace event", + "create workspace invite", + "create workspace meeting", + "event add browser", + "event add cal", + "event add calendar", + "event add chrome", + "event add g suite", + "event add google", + "event add workspace", + "event browser add", + "event browser create", + "event browser make", + "event browser new", + "event browser open", + "event browser schedule", + "event browser start", + "event cal add", + "event cal create", + "event cal make", + "event cal new", + "event cal open", + "event cal schedule", + "event cal start", + "event calendar add", + "event calendar create", + "event calendar make", + "event calendar new", + "event calendar open", + "event calendar schedule", + "event calendar start", + "event chrome add", + "event chrome create", + "event chrome make", + "event chrome new", + "event chrome open", + "event chrome schedule", + "event chrome start", + "event create browser", + "event create cal", + "event create calendar", + "event create chrome", + "event create g suite", + "event create google", + "event create workspace", + "event g suite add", + "event g suite create", + "event g suite make", + "event g suite new", + "event g suite open", + "event g suite schedule", + "event g suite start", + "event google add", + "event google create", + "event google make", + "event google new", + "event google open", + "event google schedule", + "event google start", + "event make browser", + "event make cal", + "event make calendar", + "event make chrome", + "event make g suite", + "event make google", + "event make workspace", + "event new browser", + "event new cal", + "event new calendar", + "event new chrome", + "event new g suite", + "event new google", + "event new workspace", + "event open browser", + "event open cal", + "event open calendar", + "event open chrome", + "event open g suite", + "event open google", + "event open workspace", + "event schedule browser", + "event schedule cal", + "event schedule calendar", + "event schedule chrome", + "event schedule g suite", + "event schedule google", + "event schedule workspace", + "event start browser", + "event start cal", + "event start calendar", + "event start chrome", + "event start g suite", + "event start google", + "event start workspace", + "event workspace add", + "event workspace create", + "event workspace make", + "event workspace new", + "event workspace open", + "event workspace schedule", + "event workspace start", + "g suite add event", + "g suite add invite", + "g suite add meeting", + "g suite create event", + "g suite create invite", + "g suite create meeting", + "g suite event add", + "g suite event create", + "g suite event make", + "g suite event new", + "g suite event open", + "g suite event schedule", + "g suite event start", + "g suite invite add", + "g suite invite create", + "g suite invite make", + "g suite invite new", + "g suite invite open", + "g suite invite schedule", + "g suite invite start", + "g suite make event", + "g suite make invite", + "g suite make meeting", + "g suite meeting add", + "g suite meeting create", + "g suite meeting make", + "g suite meeting new", + "g suite meeting open", + "g suite meeting schedule", + "g suite meeting start", + "g suite new event", + "g suite new invite", + "g suite new meeting", + "g suite open event", + "g suite open invite", + "g suite open meeting", + "g suite schedule event", + "g suite schedule invite", + "g suite schedule meeting", + "g suite start event", + "g suite start invite", + "g suite start meeting", + "google add event", + "google add invite", + "google add meeting", + "google create event", + "google create invite", + "google create meeting", + "google event add", + "google event create", + "google event make", + "google event new", + "google event open", + "google event schedule", + "google event start", + "google invite add", + "google invite create", + "google invite make", + "google invite new", + "google invite open", + "google invite schedule", + "google invite start", + "google make event", + "google make invite", + "google make meeting", + "google meeting add", + "google meeting create", + "google meeting make", + "google meeting new", + "google meeting open", + "google meeting schedule", + "google meeting start", + "google new event", + "google new invite", + "google new meeting", + "google open event", + "google open invite", + "google open meeting", + "google schedule event", + "google schedule invite", + "google schedule meeting", + "google start event", + "google start invite", + "google start meeting", + "invite add browser", + "invite add cal", + "invite add calendar", + "invite add chrome", + "invite add g suite", + "invite add google", + "invite add workspace", + "invite browser add", + "invite browser create", + "invite browser make", + "invite browser new", + "invite browser open", + "invite browser schedule", + "invite browser start", + "invite cal add", + "invite cal create", + "invite cal make", + "invite cal new", + "invite cal open", + "invite cal schedule", + "invite cal start", + "invite calendar add", + "invite calendar create", + "invite calendar make", + "invite calendar new", + "invite calendar open", + "invite calendar schedule", + "invite calendar start", + "invite chrome add", + "invite chrome create", + "invite chrome make", + "invite chrome new", + "invite chrome open", + "invite chrome schedule", + "invite chrome start", + "invite create browser", + "invite create cal", + "invite create calendar", + "invite create chrome", + "invite create g suite", + "invite create google", + "invite create workspace", + "invite g suite add", + "invite g suite create", + "invite g suite make", + "invite g suite new", + "invite g suite open", + "invite g suite schedule", + "invite g suite start", + "invite google add", + "invite google create", + "invite google make", + "invite google new", + "invite google open", + "invite google schedule", + "invite google start", + "invite make browser", + "invite make cal", + "invite make calendar", + "invite make chrome", + "invite make g suite", + "invite make google", + "invite make workspace", + "invite new browser", + "invite new cal", + "invite new calendar", + "invite new chrome", + "invite new g suite", + "invite new google", + "invite new workspace", + "invite open browser", + "invite open cal", + "invite open calendar", + "invite open chrome", + "invite open g suite", + "invite open google", + "invite open workspace", + "invite schedule browser", + "invite schedule cal", + "invite schedule calendar", + "invite schedule chrome", + "invite schedule g suite", + "invite schedule google", + "invite schedule workspace", + "invite start browser", + "invite start cal", + "invite start calendar", + "invite start chrome", + "invite start g suite", + "invite start google", + "invite start workspace", + "invite workspace add", + "invite workspace create", + "invite workspace make", + "invite workspace new", + "invite workspace open", + "invite workspace schedule", + "invite workspace start", + "make browser event", + "make browser invite", + "make browser meeting", + "make cal event", + "make cal invite", + "make cal meeting", + "make calendar event", + "make calendar invite", + "make calendar meeting", + "make chrome event", + "make chrome invite", + "make chrome meeting", + "make event browser", + "make event cal", + "make event calendar", + "make event chrome", + "make event g suite", + "make event google", + "make event workspace", + "make g suite event", + "make g suite invite", + "make g suite meeting", + "make google event", + "make google invite", + "make google meeting", + "make invite browser", + "make invite cal", + "make invite calendar", + "make invite chrome", + "make invite g suite", + "make invite google", + "make invite workspace", + "make meeting browser", + "make meeting cal", + "make meeting calendar", + "make meeting chrome", + "make meeting g suite", + "make meeting google", + "make meeting workspace", + "make workspace event", + "make workspace invite", + "make workspace meeting", + "meeting add browser", + "meeting add cal", + "meeting add calendar", + "meeting add chrome", + "meeting add g suite", + "meeting add google", + "meeting add workspace", + "meeting browser add", + "meeting browser create", + "meeting browser make", + "meeting browser new", + "meeting browser open", + "meeting browser schedule", + "meeting browser start", + "meeting cal add", + "meeting cal create", + "meeting cal make", + "meeting cal new", + "meeting cal open", + "meeting cal schedule", + "meeting cal start", + "meeting calendar add", + "meeting calendar create", + "meeting calendar make", + "meeting calendar new", + "meeting calendar open", + "meeting calendar schedule", + "meeting calendar start", + "meeting chrome add", + "meeting chrome create", + "meeting chrome make", + "meeting chrome new", + "meeting chrome open", + "meeting chrome schedule", + "meeting chrome start", + "meeting create browser", + "meeting create cal", + "meeting create calendar", + "meeting create chrome", + "meeting create g suite", + "meeting create google", + "meeting create workspace", + "meeting g suite add", + "meeting g suite create", + "meeting g suite make", + "meeting g suite new", + "meeting g suite open", + "meeting g suite schedule", + "meeting g suite start", + "meeting google add", + "meeting google create", + "meeting google make", + "meeting google new", + "meeting google open", + "meeting google schedule", + "meeting google start", + "meeting make browser", + "meeting make cal", + "meeting make calendar", + "meeting make chrome", + "meeting make g suite", + "meeting make google", + "meeting make workspace", + "meeting new browser", + "meeting new cal", + "meeting new calendar", + "meeting new chrome", + "meeting new g suite", + "meeting new google", + "meeting new workspace", + "meeting open browser", + "meeting open cal", + "meeting open calendar", + "meeting open chrome", + "meeting open g suite", + "meeting open google", + "meeting open workspace", + "meeting schedule browser", + "meeting schedule cal", + "meeting schedule calendar", + "meeting schedule chrome", + "meeting schedule g suite", + "meeting schedule google", + "meeting schedule workspace", + "meeting start browser", + "meeting start cal", + "meeting start calendar", + "meeting start chrome", + "meeting start g suite", + "meeting start google", + "meeting start workspace", + "meeting workspace add", + "meeting workspace create", + "meeting workspace make", + "meeting workspace new", + "meeting workspace open", + "meeting workspace schedule", + "meeting workspace start", + "new browser event", + "new browser invite", + "new browser meeting", + "new cal event", + "new cal invite", + "new cal meeting", + "new calendar event", + "new calendar invite", + "new calendar meeting", + "new chrome event", + "new chrome invite", + "new chrome meeting", + "new event browser", + "new event cal", + "new event calendar", + "new event chrome", + "new event g suite", + "new event google", + "new event workspace", + "new g suite event", + "new g suite invite", + "new g suite meeting", + "new google event", + "new google invite", + "new google meeting", + "new invite browser", + "new invite cal", + "new invite calendar", + "new invite chrome", + "new invite g suite", + "new invite google", + "new invite workspace", + "new meeting browser", + "new meeting cal", + "new meeting calendar", + "new meeting chrome", + "new meeting g suite", + "new meeting google", + "new meeting workspace", + "new workspace event", + "new workspace invite", + "new workspace meeting", + "open browser event", + "open browser invite", + "open browser meeting", + "open cal event", + "open cal invite", + "open cal meeting", + "open calendar event", + "open calendar invite", + "open calendar meeting", + "open chrome event", + "open chrome invite", + "open chrome meeting", + "open event browser", + "open event cal", + "open event calendar", + "open event chrome", + "open event g suite", + "open event google", + "open event workspace", + "open g suite event", + "open g suite invite", + "open g suite meeting", + "open google event", + "open google invite", + "open google meeting", + "open invite browser", + "open invite cal", + "open invite calendar", + "open invite chrome", + "open invite g suite", + "open invite google", + "open invite workspace", + "open meeting browser", + "open meeting cal", + "open meeting calendar", + "open meeting chrome", + "open meeting g suite", + "open meeting google", + "open meeting workspace", + "open workspace event", + "open workspace invite", + "open workspace meeting", + "schedule browser event", + "schedule browser invite", + "schedule browser meeting", + "schedule cal event", + "schedule cal invite", + "schedule cal meeting", + "schedule calendar event", + "schedule calendar invite", + "schedule calendar meeting", + "schedule chrome event", + "schedule chrome invite", + "schedule chrome meeting", + "schedule event browser", + "schedule event cal", + "schedule event calendar", + "schedule event chrome", + "schedule event g suite", + "schedule event google", + "schedule event workspace", + "schedule g suite event", + "schedule g suite invite", + "schedule g suite meeting", + "schedule google event", + "schedule google invite", + "schedule google meeting", + "schedule invite browser", + "schedule invite cal", + "schedule invite calendar", + "schedule invite chrome", + "schedule invite g suite", + "schedule invite google", + "schedule invite workspace", + "schedule meeting browser", + "schedule meeting cal", + "schedule meeting calendar", + "schedule meeting chrome", + "schedule meeting g suite", + "schedule meeting google", + "schedule meeting workspace", + "schedule workspace event", + "schedule workspace invite", + "schedule workspace meeting", + "start browser event", + "start browser invite", + "start browser meeting", + "start cal event", + "start cal invite", + "start cal meeting", + "start calendar event", + "start calendar invite", + "start calendar meeting", + "start chrome event", + "start chrome invite", + "start chrome meeting", + "start event browser", + "start event cal", + "start event calendar", + "start event chrome", + "start event g suite", + "start event google", + "start event workspace", + "start g suite event", + "start g suite invite", + "start g suite meeting", + "start google event", + "start google invite", + "start google meeting", + "start invite browser", + "start invite cal", + "start invite calendar", + "start invite chrome", + "start invite g suite", + "start invite google", + "start invite workspace", + "start meeting browser", + "start meeting cal", + "start meeting calendar", + "start meeting chrome", + "start meeting g suite", + "start meeting google", + "start meeting workspace", + "start workspace event", + "start workspace invite", + "start workspace meeting", + "workspace add event", + "workspace add invite", + "workspace add meeting", + "workspace create event", + "workspace create invite", + "workspace create meeting", + "workspace event add", + "workspace event create", + "workspace event make", + "workspace event new", + "workspace event open", + "workspace event schedule", + "workspace event start", + "workspace invite add", + "workspace invite create", + "workspace invite make", + "workspace invite new", + "workspace invite open", + "workspace invite schedule", + "workspace invite start", + "workspace make event", + "workspace make invite", + "workspace make meeting", + "workspace meeting add", + "workspace meeting create", + "workspace meeting make", + "workspace meeting new", + "workspace meeting open", + "workspace meeting schedule", + "workspace meeting start", + "workspace new event", + "workspace new invite", + "workspace new meeting", + "workspace open event", + "workspace open invite", + "workspace open meeting", + "workspace schedule event", + "workspace schedule invite", + "workspace schedule meeting", + "workspace start event", + "workspace start invite", + "workspace start meeting", + }, + + // ID#17 + { + // Generated suggestions: + "browser create site", + "browser create website", + "browser make site", + "browser make website", + "browser new site", + "browser new website", + "browser open site", + "browser open website", + "browser site create", + "browser site make", + "browser site new", + "browser site open", + "browser site start", + "browser start site", + "browser start website", + "browser website create", + "browser website make", + "browser website new", + "browser website open", + "browser website start", + "chrome create site", + "chrome create website", + "chrome make site", + "chrome make website", + "chrome new site", + "chrome new website", + "chrome open site", + "chrome open website", + "chrome site create", + "chrome site make", + "chrome site new", + "chrome site open", + "chrome site start", + "chrome start site", + "chrome start website", + "chrome website create", + "chrome website make", + "chrome website new", + "chrome website open", + "chrome website start", + "create browser site", + "create browser website", + "create chrome site", + "create chrome website", + "create g suite site", + "create g suite website", + "create google site", + "create google website", + "create site browser", + "create site chrome", + "create site g suite", + "create site google", + "create site workspace", + "create website browser", + "create website chrome", + "create website g suite", + "create website google", + "create website workspace", + "create workspace site", + "create workspace website", + "g suite create site", + "g suite create website", + "g suite make site", + "g suite make website", + "g suite new site", + "g suite new website", + "g suite open site", + "g suite open website", + "g suite site create", + "g suite site make", + "g suite site new", + "g suite site open", + "g suite site start", + "g suite start site", + "g suite start website", + "g suite website create", + "g suite website make", + "g suite website new", + "g suite website open", + "g suite website start", + "google create site", + "google create website", + "google make site", + "google make website", + "google new site", + "google new website", + "google open site", + "google open website", + "google site create", + "google site make", + "google site new", + "google site open", + "google site start", + "google start site", + "google start website", + "google website create", + "google website make", + "google website new", + "google website open", + "google website start", + "make browser site", + "make browser website", + "make chrome site", + "make chrome website", + "make g suite site", + "make g suite website", + "make google site", + "make google website", + "make site browser", + "make site chrome", + "make site g suite", + "make site google", + "make site workspace", + "make website browser", + "make website chrome", + "make website g suite", + "make website google", + "make website workspace", + "make workspace site", + "make workspace website", + "new browser site", + "new browser website", + "new chrome site", + "new chrome website", + "new g suite site", + "new g suite website", + "new google site", + "new google website", + "new site browser", + "new site chrome", + "new site g suite", + "new site google", + "new site workspace", + "new website browser", + "new website chrome", + "new website g suite", + "new website google", + "new website workspace", + "new workspace site", + "new workspace website", + "open browser site", + "open browser website", + "open chrome site", + "open chrome website", + "open g suite site", + "open g suite website", + "open google site", + "open google website", + "open site browser", + "open site chrome", + "open site g suite", + "open site google", + "open site workspace", + "open website browser", + "open website chrome", + "open website g suite", + "open website google", + "open website workspace", + "open workspace site", + "open workspace website", + "site browser create", + "site browser make", + "site browser new", + "site browser open", + "site browser start", + "site chrome create", + "site chrome make", + "site chrome new", + "site chrome open", + "site chrome start", + "site create browser", + "site create chrome", + "site create g suite", + "site create google", + "site create workspace", + "site g suite create", + "site g suite make", + "site g suite new", + "site g suite open", + "site g suite start", + "site google create", + "site google make", + "site google new", + "site google open", + "site google start", + "site make browser", + "site make chrome", + "site make g suite", + "site make google", + "site make workspace", + "site new browser", + "site new chrome", + "site new g suite", + "site new google", + "site new workspace", + "site open browser", + "site open chrome", + "site open g suite", + "site open google", + "site open workspace", + "site start browser", + "site start chrome", + "site start g suite", + "site start google", + "site start workspace", + "site workspace create", + "site workspace make", + "site workspace new", + "site workspace open", + "site workspace start", + "start browser site", + "start browser website", + "start chrome site", + "start chrome website", + "start g suite site", + "start g suite website", + "start google site", + "start google website", + "start site browser", + "start site chrome", + "start site g suite", + "start site google", + "start site workspace", + "start website browser", + "start website chrome", + "start website g suite", + "start website google", + "start website workspace", + "start workspace site", + "start workspace website", + "website browser create", + "website browser make", + "website browser new", + "website browser open", + "website browser start", + "website chrome create", + "website chrome make", + "website chrome new", + "website chrome open", + "website chrome start", + "website create browser", + "website create chrome", + "website create g suite", + "website create google", + "website create workspace", + "website g suite create", + "website g suite make", + "website g suite new", + "website g suite open", + "website g suite start", + "website google create", + "website google make", + "website google new", + "website google open", + "website google start", + "website make browser", + "website make chrome", + "website make g suite", + "website make google", + "website make workspace", + "website new browser", + "website new chrome", + "website new g suite", + "website new google", + "website new workspace", + "website open browser", + "website open chrome", + "website open g suite", + "website open google", + "website open workspace", + "website start browser", + "website start chrome", + "website start g suite", + "website start google", + "website start workspace", + "website workspace create", + "website workspace make", + "website workspace new", + "website workspace open", + "website workspace start", + "workspace create site", + "workspace create website", + "workspace make site", + "workspace make website", + "workspace new site", + "workspace new website", + "workspace open site", + "workspace open website", + "workspace site create", + "workspace site make", + "workspace site new", + "workspace site open", + "workspace site start", + "workspace start site", + "workspace start website", + "workspace website create", + "workspace website make", + "workspace website new", + "workspace website open", + "workspace website start", + }, + + // ID#18 + { + // Generated suggestions: + "browser create note", + "browser create notes", + "browser make note", + "browser make notes", + "browser new note", + "browser new notes", + "browser note create", + "browser note make", + "browser note new", + "browser note open", + "browser note start", + "browser notes create", + "browser notes make", + "browser notes new", + "browser notes open", + "browser notes start", + "browser open note", + "browser open notes", + "browser start note", + "browser start notes", + "chrome create note", + "chrome create notes", + "chrome make note", + "chrome make notes", + "chrome new note", + "chrome new notes", + "chrome note create", + "chrome note make", + "chrome note new", + "chrome note open", + "chrome note start", + "chrome notes create", + "chrome notes make", + "chrome notes new", + "chrome notes open", + "chrome notes start", + "chrome open note", + "chrome open notes", + "chrome start note", + "chrome start notes", + "create browser note", + "create browser notes", + "create chrome note", + "create chrome notes", + "create g suite note", + "create g suite notes", + "create google note", + "create google notes", + "create keep note", + "create keep notes", + "create note browser", + "create note chrome", + "create note g suite", + "create note google", + "create note keep", + "create note workspace", + "create notes browser", + "create notes chrome", + "create notes g suite", + "create notes google", + "create notes keep", + "create notes workspace", + "create workspace note", + "create workspace notes", + "g suite create note", + "g suite create notes", + "g suite make note", + "g suite make notes", + "g suite new note", + "g suite new notes", + "g suite note create", + "g suite note make", + "g suite note new", + "g suite note open", + "g suite note start", + "g suite notes create", + "g suite notes make", + "g suite notes new", + "g suite notes open", + "g suite notes start", + "g suite open note", + "g suite open notes", + "g suite start note", + "g suite start notes", + "google create note", + "google create notes", + "google make note", + "google make notes", + "google new note", + "google new notes", + "google note create", + "google note make", + "google note new", + "google note open", + "google note start", + "google notes create", + "google notes make", + "google notes new", + "google notes open", + "google notes start", + "google open note", + "google open notes", + "google start note", + "google start notes", + "keep create note", + "keep create notes", + "keep make note", + "keep make notes", + "keep new note", + "keep new notes", + "keep note create", + "keep note make", + "keep note new", + "keep note open", + "keep note start", + "keep notes create", + "keep notes make", + "keep notes new", + "keep notes open", + "keep notes start", + "keep open note", + "keep open notes", + "keep start note", + "keep start notes", + "make browser note", + "make browser notes", + "make chrome note", + "make chrome notes", + "make g suite note", + "make g suite notes", + "make google note", + "make google notes", + "make keep note", + "make keep notes", + "make note browser", + "make note chrome", + "make note g suite", + "make note google", + "make note keep", + "make note workspace", + "make notes browser", + "make notes chrome", + "make notes g suite", + "make notes google", + "make notes keep", + "make notes workspace", + "make workspace note", + "make workspace notes", + "new browser note", + "new browser notes", + "new chrome note", + "new chrome notes", + "new g suite note", + "new g suite notes", + "new google note", + "new google notes", + "new keep note", + "new keep notes", + "new note browser", + "new note chrome", + "new note g suite", + "new note google", + "new note keep", + "new note workspace", + "new notes browser", + "new notes chrome", + "new notes g suite", + "new notes google", + "new notes keep", + "new notes workspace", + "new workspace note", + "new workspace notes", + "note browser create", + "note browser make", + "note browser new", + "note browser open", + "note browser start", + "note chrome create", + "note chrome make", + "note chrome new", + "note chrome open", + "note chrome start", + "note create browser", + "note create chrome", + "note create g suite", + "note create google", + "note create keep", + "note create workspace", + "note g suite create", + "note g suite make", + "note g suite new", + "note g suite open", + "note g suite start", + "note google create", + "note google make", + "note google new", + "note google open", + "note google start", + "note keep create", + "note keep make", + "note keep new", + "note keep open", + "note keep start", + "note make browser", + "note make chrome", + "note make g suite", + "note make google", + "note make keep", + "note make workspace", + "note new browser", + "note new chrome", + "note new g suite", + "note new google", + "note new keep", + "note new workspace", + "note open browser", + "note open chrome", + "note open g suite", + "note open google", + "note open keep", + "note open workspace", + "note start browser", + "note start chrome", + "note start g suite", + "note start google", + "note start keep", + "note start workspace", + "note workspace create", + "note workspace make", + "note workspace new", + "note workspace open", + "note workspace start", + "notes browser create", + "notes browser make", + "notes browser new", + "notes browser open", + "notes browser start", + "notes chrome create", + "notes chrome make", + "notes chrome new", + "notes chrome open", + "notes chrome start", + "notes create browser", + "notes create chrome", + "notes create g suite", + "notes create google", + "notes create keep", + "notes create workspace", + "notes g suite create", + "notes g suite make", + "notes g suite new", + "notes g suite open", + "notes g suite start", + "notes google create", + "notes google make", + "notes google new", + "notes google open", + "notes google start", + "notes keep create", + "notes keep make", + "notes keep new", + "notes keep open", + "notes keep start", + "notes make browser", + "notes make chrome", + "notes make g suite", + "notes make google", + "notes make keep", + "notes make workspace", + "notes new browser", + "notes new chrome", + "notes new g suite", + "notes new google", + "notes new keep", + "notes new workspace", + "notes open browser", + "notes open chrome", + "notes open g suite", + "notes open google", + "notes open keep", + "notes open workspace", + "notes start browser", + "notes start chrome", + "notes start g suite", + "notes start google", + "notes start keep", + "notes start workspace", + "notes workspace create", + "notes workspace make", + "notes workspace new", + "notes workspace open", + "notes workspace start", + "open browser note", + "open browser notes", + "open chrome note", + "open chrome notes", + "open g suite note", + "open g suite notes", + "open google note", + "open google notes", + "open keep note", + "open keep notes", + "open note browser", + "open note chrome", + "open note g suite", + "open note google", + "open note keep", + "open note workspace", + "open notes browser", + "open notes chrome", + "open notes g suite", + "open notes google", + "open notes keep", + "open notes workspace", + "open workspace note", + "open workspace notes", + "start browser note", + "start browser notes", + "start chrome note", + "start chrome notes", + "start g suite note", + "start g suite notes", + "start google note", + "start google notes", + "start keep note", + "start keep notes", + "start note browser", + "start note chrome", + "start note g suite", + "start note google", + "start note keep", + "start note workspace", + "start notes browser", + "start notes chrome", + "start notes g suite", + "start notes google", + "start notes keep", + "start notes workspace", + "start workspace note", + "start workspace notes", + "workspace create note", + "workspace create notes", + "workspace make note", + "workspace make notes", + "workspace new note", + "workspace new notes", + "workspace note create", + "workspace note make", + "workspace note new", + "workspace note open", + "workspace note start", + "workspace notes create", + "workspace notes make", + "workspace notes new", + "workspace notes open", + "workspace notes start", + "workspace open note", + "workspace open notes", + "workspace start note", + "workspace start notes", + }, + + // ID#19 + { + // Generated suggestions: + "browser create form", + "browser create forms", + "browser create quiz", + "browser create survey", + "browser form create", + "browser form make", + "browser form new", + "browser form open", + "browser form start", + "browser forms create", + "browser forms make", + "browser forms new", + "browser forms open", + "browser forms start", + "browser make form", + "browser make forms", + "browser make quiz", + "browser make survey", + "browser new form", + "browser new forms", + "browser new quiz", + "browser new survey", + "browser open form", + "browser open forms", + "browser open quiz", + "browser open survey", + "browser quiz create", + "browser quiz make", + "browser quiz new", + "browser quiz open", + "browser quiz start", + "browser start form", + "browser start forms", + "browser start quiz", + "browser start survey", + "browser survey create", + "browser survey make", + "browser survey new", + "browser survey open", + "browser survey start", + "chrome create form", + "chrome create forms", + "chrome create quiz", + "chrome create survey", + "chrome form create", + "chrome form make", + "chrome form new", + "chrome form open", + "chrome form start", + "chrome forms create", + "chrome forms make", + "chrome forms new", + "chrome forms open", + "chrome forms start", + "chrome make form", + "chrome make forms", + "chrome make quiz", + "chrome make survey", + "chrome new form", + "chrome new forms", + "chrome new quiz", + "chrome new survey", + "chrome open form", + "chrome open forms", + "chrome open quiz", + "chrome open survey", + "chrome quiz create", + "chrome quiz make", + "chrome quiz new", + "chrome quiz open", + "chrome quiz start", + "chrome start form", + "chrome start forms", + "chrome start quiz", + "chrome start survey", + "chrome survey create", + "chrome survey make", + "chrome survey new", + "chrome survey open", + "chrome survey start", + "create browser form", + "create browser forms", + "create browser quiz", + "create browser survey", + "create chrome form", + "create chrome forms", + "create chrome quiz", + "create chrome survey", + "create form browser", + "create form chrome", + "create form g suite", + "create form google", + "create form workspace", + "create forms browser", + "create forms chrome", + "create forms g suite", + "create forms google", + "create forms workspace", + "create g suite form", + "create g suite forms", + "create g suite quiz", + "create g suite survey", + "create google form", + "create google forms", + "create google quiz", + "create google survey", + "create quiz browser", + "create quiz chrome", + "create quiz g suite", + "create quiz google", + "create quiz workspace", + "create survey browser", + "create survey chrome", + "create survey g suite", + "create survey google", + "create survey workspace", + "create workspace form", + "create workspace forms", + "create workspace quiz", + "create workspace survey", + "form browser create", + "form browser make", + "form browser new", + "form browser open", + "form browser start", + "form chrome create", + "form chrome make", + "form chrome new", + "form chrome open", + "form chrome start", + "form create browser", + "form create chrome", + "form create g suite", + "form create google", + "form create workspace", + "form g suite create", + "form g suite make", + "form g suite new", + "form g suite open", + "form g suite start", + "form google create", + "form google make", + "form google new", + "form google open", + "form google start", + "form make browser", + "form make chrome", + "form make g suite", + "form make google", + "form make workspace", + "form new browser", + "form new chrome", + "form new g suite", + "form new google", + "form new workspace", + "form open browser", + "form open chrome", + "form open g suite", + "form open google", + "form open workspace", + "form start browser", + "form start chrome", + "form start g suite", + "form start google", + "form start workspace", + "form workspace create", + "form workspace make", + "form workspace new", + "form workspace open", + "form workspace start", + "forms browser create", + "forms browser make", + "forms browser new", + "forms browser open", + "forms browser start", + "forms chrome create", + "forms chrome make", + "forms chrome new", + "forms chrome open", + "forms chrome start", + "forms create browser", + "forms create chrome", + "forms create g suite", + "forms create google", + "forms create workspace", + "forms g suite create", + "forms g suite make", + "forms g suite new", + "forms g suite open", + "forms g suite start", + "forms google create", + "forms google make", + "forms google new", + "forms google open", + "forms google start", + "forms make browser", + "forms make chrome", + "forms make g suite", + "forms make google", + "forms make workspace", + "forms new browser", + "forms new chrome", + "forms new g suite", + "forms new google", + "forms new workspace", + "forms open browser", + "forms open chrome", + "forms open g suite", + "forms open google", + "forms open workspace", + "forms start browser", + "forms start chrome", + "forms start g suite", + "forms start google", + "forms start workspace", + "forms workspace create", + "forms workspace make", + "forms workspace new", + "forms workspace open", + "forms workspace start", + "g suite create form", + "g suite create forms", + "g suite create quiz", + "g suite create survey", + "g suite form create", + "g suite form make", + "g suite form new", + "g suite form open", + "g suite form start", + "g suite forms create", + "g suite forms make", + "g suite forms new", + "g suite forms open", + "g suite forms start", + "g suite make form", + "g suite make forms", + "g suite make quiz", + "g suite make survey", + "g suite new form", + "g suite new forms", + "g suite new quiz", + "g suite new survey", + "g suite open form", + "g suite open forms", + "g suite open quiz", + "g suite open survey", + "g suite quiz create", + "g suite quiz make", + "g suite quiz new", + "g suite quiz open", + "g suite quiz start", + "g suite start form", + "g suite start forms", + "g suite start quiz", + "g suite start survey", + "g suite survey create", + "g suite survey make", + "g suite survey new", + "g suite survey open", + "g suite survey start", + "google create form", + "google create forms", + "google create quiz", + "google create survey", + "google form create", + "google form make", + "google form new", + "google form open", + "google form start", + "google forms create", + "google forms make", + "google forms new", + "google forms open", + "google forms start", + "google make form", + "google make forms", + "google make quiz", + "google make survey", + "google new form", + "google new forms", + "google new quiz", + "google new survey", + "google open form", + "google open forms", + "google open quiz", + "google open survey", + "google quiz create", + "google quiz make", + "google quiz new", + "google quiz open", + "google quiz start", + "google start form", + "google start forms", + "google start quiz", + "google start survey", + "google survey create", + "google survey make", + "google survey new", + "google survey open", + "google survey start", + "make browser form", + "make browser forms", + "make browser quiz", + "make browser survey", + "make chrome form", + "make chrome forms", + "make chrome quiz", + "make chrome survey", + "make form browser", + "make form chrome", + "make form g suite", + "make form google", + "make form workspace", + "make forms browser", + "make forms chrome", + "make forms g suite", + "make forms google", + "make forms workspace", + "make g suite form", + "make g suite forms", + "make g suite quiz", + "make g suite survey", + "make google form", + "make google forms", + "make google quiz", + "make google survey", + "make quiz browser", + "make quiz chrome", + "make quiz g suite", + "make quiz google", + "make quiz workspace", + "make survey browser", + "make survey chrome", + "make survey g suite", + "make survey google", + "make survey workspace", + "make workspace form", + "make workspace forms", + "make workspace quiz", + "make workspace survey", + "new browser form", + "new browser forms", + "new browser quiz", + "new browser survey", + "new chrome form", + "new chrome forms", + "new chrome quiz", + "new chrome survey", + "new form browser", + "new form chrome", + "new form g suite", + "new form google", + "new form workspace", + "new forms browser", + "new forms chrome", + "new forms g suite", + "new forms google", + "new forms workspace", + "new g suite form", + "new g suite forms", + "new g suite quiz", + "new g suite survey", + "new google form", + "new google forms", + "new google quiz", + "new google survey", + "new quiz browser", + "new quiz chrome", + "new quiz g suite", + "new quiz google", + "new quiz workspace", + "new survey browser", + "new survey chrome", + "new survey g suite", + "new survey google", + "new survey workspace", + "new workspace form", + "new workspace forms", + "new workspace quiz", + "new workspace survey", + "open browser form", + "open browser forms", + "open browser quiz", + "open browser survey", + "open chrome form", + "open chrome forms", + "open chrome quiz", + "open chrome survey", + "open form browser", + "open form chrome", + "open form g suite", + "open form google", + "open form workspace", + "open forms browser", + "open forms chrome", + "open forms g suite", + "open forms google", + "open forms workspace", + "open g suite form", + "open g suite forms", + "open g suite quiz", + "open g suite survey", + "open google form", + "open google forms", + "open google quiz", + "open google survey", + "open quiz browser", + "open quiz chrome", + "open quiz g suite", + "open quiz google", + "open quiz workspace", + "open survey browser", + "open survey chrome", + "open survey g suite", + "open survey google", + "open survey workspace", + "open workspace form", + "open workspace forms", + "open workspace quiz", + "open workspace survey", + "quiz browser create", + "quiz browser make", + "quiz browser new", + "quiz browser open", + "quiz browser start", + "quiz chrome create", + "quiz chrome make", + "quiz chrome new", + "quiz chrome open", + "quiz chrome start", + "quiz create browser", + "quiz create chrome", + "quiz create g suite", + "quiz create google", + "quiz create workspace", + "quiz g suite create", + "quiz g suite make", + "quiz g suite new", + "quiz g suite open", + "quiz g suite start", + "quiz google create", + "quiz google make", + "quiz google new", + "quiz google open", + "quiz google start", + "quiz make browser", + "quiz make chrome", + "quiz make g suite", + "quiz make google", + "quiz make workspace", + "quiz new browser", + "quiz new chrome", + "quiz new g suite", + "quiz new google", + "quiz new workspace", + "quiz open browser", + "quiz open chrome", + "quiz open g suite", + "quiz open google", + "quiz open workspace", + "quiz start browser", + "quiz start chrome", + "quiz start g suite", + "quiz start google", + "quiz start workspace", + "quiz workspace create", + "quiz workspace make", + "quiz workspace new", + "quiz workspace open", + "quiz workspace start", + "start browser form", + "start browser forms", + "start browser quiz", + "start browser survey", + "start chrome form", + "start chrome forms", + "start chrome quiz", + "start chrome survey", + "start form browser", + "start form chrome", + "start form g suite", + "start form google", + "start form workspace", + "start forms browser", + "start forms chrome", + "start forms g suite", + "start forms google", + "start forms workspace", + "start g suite form", + "start g suite forms", + "start g suite quiz", + "start g suite survey", + "start google form", + "start google forms", + "start google quiz", + "start google survey", + "start quiz browser", + "start quiz chrome", + "start quiz g suite", + "start quiz google", + "start quiz workspace", + "start survey browser", + "start survey chrome", + "start survey g suite", + "start survey google", + "start survey workspace", + "start workspace form", + "start workspace forms", + "start workspace quiz", + "start workspace survey", + "survey browser create", + "survey browser make", + "survey browser new", + "survey browser open", + "survey browser start", + "survey chrome create", + "survey chrome make", + "survey chrome new", + "survey chrome open", + "survey chrome start", + "survey create browser", + "survey create chrome", + "survey create g suite", + "survey create google", + "survey create workspace", + "survey g suite create", + "survey g suite make", + "survey g suite new", + "survey g suite open", + "survey g suite start", + "survey google create", + "survey google make", + "survey google new", + "survey google open", + "survey google start", + "survey make browser", + "survey make chrome", + "survey make g suite", + "survey make google", + "survey make workspace", + "survey new browser", + "survey new chrome", + "survey new g suite", + "survey new google", + "survey new workspace", + "survey open browser", + "survey open chrome", + "survey open g suite", + "survey open google", + "survey open workspace", + "survey start browser", + "survey start chrome", + "survey start g suite", + "survey start google", + "survey start workspace", + "survey workspace create", + "survey workspace make", + "survey workspace new", + "survey workspace open", + "survey workspace start", + "workspace create form", + "workspace create forms", + "workspace create quiz", + "workspace create survey", + "workspace form create", + "workspace form make", + "workspace form new", + "workspace form open", + "workspace form start", + "workspace forms create", + "workspace forms make", + "workspace forms new", + "workspace forms open", + "workspace forms start", + "workspace make form", + "workspace make forms", + "workspace make quiz", + "workspace make survey", + "workspace new form", + "workspace new forms", + "workspace new quiz", + "workspace new survey", + "workspace open form", + "workspace open forms", + "workspace open quiz", + "workspace open survey", + "workspace quiz create", + "workspace quiz make", + "workspace quiz new", + "workspace quiz open", + "workspace quiz start", + "workspace start form", + "workspace start forms", + "workspace start quiz", + "workspace start survey", + "workspace survey create", + "workspace survey make", + "workspace survey new", + "workspace survey open", + "workspace survey start", + }, + + // ID#21 + { + // Generated suggestions: + "browser chrome features", + "browser chrome features explore", + "browser chrome features learn", + "browser chrome features make the most of", + "browser chrome features see", + "browser chrome features understand", + "browser chrome features visit", + "browser chrome tips", + "browser chrome tips center", + "browser chrome tips center explore", + "browser chrome tips center learn", + "browser chrome tips center make the most of", + "browser chrome tips center see", + "browser chrome tips center understand", + "browser chrome tips center visit", + "browser chrome tips explore", + "browser chrome tips learn", + "browser chrome tips make the most of", + "browser chrome tips see", + "browser chrome tips understand", + "browser chrome tips visit", + "browser explore chrome features", + "browser explore chrome tips", + "browser explore chrome tips center", + "browser explore new chrome features", + "browser learn chrome features", + "browser learn chrome tips", + "browser learn chrome tips center", + "browser learn new chrome features", + "browser make the most of chrome features", + "browser make the most of chrome tips", + "browser make the most of chrome tips center", + "browser make the most of new chrome features", + "browser new chrome features", + "browser new chrome features explore", + "browser new chrome features learn", + "browser new chrome features make the most of", + "browser new chrome features see", + "browser new chrome features understand", + "browser new chrome features visit", + "browser see chrome features", + "browser see chrome tips", + "browser see chrome tips center", + "browser see new chrome features", + "browser understand chrome features", + "browser understand chrome tips", + "browser understand chrome tips center", + "browser understand new chrome features", + "browser visit chrome features", + "browser visit chrome tips", + "browser visit chrome tips center", + "browser visit new chrome features", + "chrome features", + "chrome features browser", + "chrome features browser explore", + "chrome features browser learn", + "chrome features browser make the most of", + "chrome features browser see", + "chrome features browser understand", + "chrome features browser visit", + "chrome features explore", + "chrome features explore browser", + "chrome features explore google", + "chrome features google", + "chrome features google explore", + "chrome features google learn", + "chrome features google make the most of", + "chrome features google see", + "chrome features google understand", + "chrome features google visit", + "chrome features learn", + "chrome features learn browser", + "chrome features learn google", + "chrome features make the most of", + "chrome features make the most of browser", + "chrome features make the most of google", + "chrome features see", + "chrome features see browser", + "chrome features see google", + "chrome features understand", + "chrome features understand browser", + "chrome features understand google", + "chrome features visit", + "chrome features visit browser", + "chrome features visit google", + "chrome tips", + "chrome tips browser", + "chrome tips browser explore", + "chrome tips browser learn", + "chrome tips browser make the most of", + "chrome tips browser see", + "chrome tips browser understand", + "chrome tips browser visit", + "chrome tips center", + "chrome tips center browser", + "chrome tips center browser explore", + "chrome tips center browser learn", + "chrome tips center browser make the most of", + "chrome tips center browser see", + "chrome tips center browser understand", + "chrome tips center browser visit", + "chrome tips center explore", + "chrome tips center explore browser", + "chrome tips center explore google", + "chrome tips center google", + "chrome tips center google explore", + "chrome tips center google learn", + "chrome tips center google make the most of", + "chrome tips center google see", + "chrome tips center google understand", + "chrome tips center google visit", + "chrome tips center learn", + "chrome tips center learn browser", + "chrome tips center learn google", + "chrome tips center make the most of", + "chrome tips center make the most of browser", + "chrome tips center make the most of google", + "chrome tips center see", + "chrome tips center see browser", + "chrome tips center see google", + "chrome tips center understand", + "chrome tips center understand browser", + "chrome tips center understand google", + "chrome tips center visit", + "chrome tips center visit browser", + "chrome tips center visit google", + "chrome tips explore", + "chrome tips explore browser", + "chrome tips explore google", + "chrome tips google", + "chrome tips google explore", + "chrome tips google learn", + "chrome tips google make the most of", + "chrome tips google see", + "chrome tips google understand", + "chrome tips google visit", + "chrome tips learn", + "chrome tips learn browser", + "chrome tips learn google", + "chrome tips make the most of", + "chrome tips make the most of browser", + "chrome tips make the most of google", + "chrome tips see", + "chrome tips see browser", + "chrome tips see google", + "chrome tips understand", + "chrome tips understand browser", + "chrome tips understand google", + "chrome tips visit", + "chrome tips visit browser", + "chrome tips visit google", + "explore browser chrome features", + "explore browser chrome tips", + "explore browser chrome tips center", + "explore browser new chrome features", + "explore chrome features", + "explore chrome features browser", + "explore chrome features google", + "explore chrome tips", + "explore chrome tips browser", + "explore chrome tips center", + "explore chrome tips center browser", + "explore chrome tips center google", + "explore chrome tips google", + "explore google chrome features", + "explore google chrome tips", + "explore google chrome tips center", + "explore google new chrome features", + "explore new chrome features", + "explore new chrome features browser", + "explore new chrome features google", + "google chrome features", + "google chrome features explore", + "google chrome features learn", + "google chrome features make the most of", + "google chrome features see", + "google chrome features understand", + "google chrome features visit", + "google chrome tips", + "google chrome tips center", + "google chrome tips center explore", + "google chrome tips center learn", + "google chrome tips center make the most of", + "google chrome tips center see", + "google chrome tips center understand", + "google chrome tips center visit", + "google chrome tips explore", + "google chrome tips learn", + "google chrome tips make the most of", + "google chrome tips see", + "google chrome tips understand", + "google chrome tips visit", + "google explore chrome features", + "google explore chrome tips", + "google explore chrome tips center", + "google explore new chrome features", + "google learn chrome features", + "google learn chrome tips", + "google learn chrome tips center", + "google learn new chrome features", + "google make the most of chrome features", + "google make the most of chrome tips", + "google make the most of chrome tips center", + "google make the most of new chrome features", + "google new chrome features", + "google new chrome features explore", + "google new chrome features learn", + "google new chrome features make the most of", + "google new chrome features see", + "google new chrome features understand", + "google new chrome features visit", + "google see chrome features", + "google see chrome tips", + "google see chrome tips center", + "google see new chrome features", + "google understand chrome features", + "google understand chrome tips", + "google understand chrome tips center", + "google understand new chrome features", + "google visit chrome features", + "google visit chrome tips", + "google visit chrome tips center", + "google visit new chrome features", + "learn browser chrome features", + "learn browser chrome tips", + "learn browser chrome tips center", + "learn browser new chrome features", + "learn chrome features", + "learn chrome features browser", + "learn chrome features google", + "learn chrome tips", + "learn chrome tips browser", + "learn chrome tips center", + "learn chrome tips center browser", + "learn chrome tips center google", + "learn chrome tips google", + "learn google chrome features", + "learn google chrome tips", + "learn google chrome tips center", + "learn google new chrome features", + "learn new chrome features", + "learn new chrome features browser", + "learn new chrome features google", + "make the most of browser chrome features", + "make the most of browser chrome tips", + "make the most of browser chrome tips center", + "make the most of browser new chrome features", + "make the most of chrome features", + "make the most of chrome features browser", + "make the most of chrome features google", + "make the most of chrome tips", + "make the most of chrome tips browser", + "make the most of chrome tips center", + "make the most of chrome tips center browser", + "make the most of chrome tips center google", + "make the most of chrome tips google", + "make the most of google chrome features", + "make the most of google chrome tips", + "make the most of google chrome tips center", + "make the most of google new chrome features", + "make the most of new chrome features", + "make the most of new chrome features browser", + "make the most of new chrome features google", + "new chrome features", + "new chrome features browser", + "new chrome features browser explore", + "new chrome features browser learn", + "new chrome features browser make the most of", + "new chrome features browser see", + "new chrome features browser understand", + "new chrome features browser visit", + "new chrome features explore", + "new chrome features explore browser", + "new chrome features explore google", + "new chrome features google", + "new chrome features google explore", + "new chrome features google learn", + "new chrome features google make the most of", + "new chrome features google see", + "new chrome features google understand", + "new chrome features google visit", + "new chrome features learn", + "new chrome features learn browser", + "new chrome features learn google", + "new chrome features make the most of", + "new chrome features make the most of browser", + "new chrome features make the most of google", + "new chrome features see", + "new chrome features see browser", + "new chrome features see google", + "new chrome features understand", + "new chrome features understand browser", + "new chrome features understand google", + "new chrome features visit", + "new chrome features visit browser", + "new chrome features visit google", + "see browser chrome features", + "see browser chrome tips", + "see browser chrome tips center", + "see browser new chrome features", + "see chrome features", + "see chrome features browser", + "see chrome features google", + "see chrome tips", + "see chrome tips browser", + "see chrome tips center", + "see chrome tips center browser", + "see chrome tips center google", + "see chrome tips google", + "see google chrome features", + "see google chrome tips", + "see google chrome tips center", + "see google new chrome features", + "see new chrome features", + "see new chrome features browser", + "see new chrome features google", + "understand browser chrome features", + "understand browser chrome tips", + "understand browser chrome tips center", + "understand browser new chrome features", + "understand chrome features", + "understand chrome features browser", + "understand chrome features google", + "understand chrome tips", + "understand chrome tips browser", + "understand chrome tips center", + "understand chrome tips center browser", + "understand chrome tips center google", + "understand chrome tips google", + "understand google chrome features", + "understand google chrome tips", + "understand google chrome tips center", + "understand google new chrome features", + "understand new chrome features", + "understand new chrome features browser", + "understand new chrome features google", + "visit browser chrome features", + "visit browser chrome tips", + "visit browser chrome tips center", + "visit browser new chrome features", + "visit chrome features", + "visit chrome features browser", + "visit chrome features google", + "visit chrome tips", + "visit chrome tips browser", + "visit chrome tips center", + "visit chrome tips center browser", + "visit chrome tips center google", + "visit chrome tips google", + "visit google chrome features", + "visit google chrome tips", + "visit google chrome tips center", + "visit google new chrome features", + "visit new chrome features", + "visit new chrome features browser", + "visit new chrome features google", + }, + + // ID#22 + { + // Generated suggestions: + "adjust browser google account", + "adjust chrome google account", + "adjust google account", + "adjust google account browser", + "adjust google account chrome", + "browser adjust google account", + "browser control google account", + "browser fix google account", + "browser google account adjust", + "browser google account control", + "browser google account fix", + "browser google account manage", + "browser manage google account", + "chrome adjust google account", + "chrome control google account", + "chrome fix google account", + "chrome google account adjust", + "chrome google account control", + "chrome google account fix", + "chrome google account manage", + "chrome manage google account", + "control browser google account", + "control chrome google account", + "control google account", + "control google account browser", + "control google account chrome", + "fix browser google account", + "fix chrome google account", + "fix google account", + "fix google account browser", + "fix google account chrome", + "google account adjust", + "google account adjust browser", + "google account adjust chrome", + "google account browser adjust", + "google account browser control", + "google account browser fix", + "google account browser manage", + "google account chrome adjust", + "google account chrome control", + "google account chrome fix", + "google account chrome manage", + "google account control", + "google account control browser", + "google account control chrome", + "google account fix", + "google account fix browser", + "google account fix chrome", + "google account manage", + "google account manage browser", + "google account manage chrome", + "manage browser google account", + "manage chrome google account", + "manage google account", + "manage google account browser", + "manage google account chrome", + }, + + // ID#24 + { + // Generated suggestions: + "browser change gmail account password", + "browser change gmail password", + "browser change google account password", + "browser change google password", + "browser fix gmail account password", + "browser fix gmail password", + "browser fix google account password", + "browser fix google password", + "browser gmail account password change", + "browser gmail account password fix", + "browser gmail account password reset", + "browser gmail account password update", + "browser gmail password change", + "browser gmail password fix", + "browser gmail password reset", + "browser gmail password update", + "browser google account password change", + "browser google account password fix", + "browser google account password reset", + "browser google account password update", + "browser google password change", + "browser google password fix", + "browser google password reset", + "browser google password update", + "browser reset gmail account password", + "browser reset gmail password", + "browser reset google account password", + "browser reset google password", + "browser update gmail account password", + "browser update gmail password", + "browser update google account password", + "browser update google password", + "change browser gmail account password", + "change browser gmail password", + "change browser google account password", + "change browser google password", + "change chrome gmail account password", + "change chrome gmail password", + "change chrome google account password", + "change chrome google password", + "change gmail account password", + "change gmail account password browser", + "change gmail account password chrome", + "change gmail account password google", + "change gmail password", + "change gmail password browser", + "change gmail password chrome", + "change gmail password google", + "change google account password", + "change google account password browser", + "change google account password chrome", + "change google account password google", + "change google gmail account password", + "change google gmail password", + "change google google account password", + "change google google password", + "change google password", + "change google password browser", + "change google password chrome", + "change google password google", + "chrome change gmail account password", + "chrome change gmail password", + "chrome change google account password", + "chrome change google password", + "chrome fix gmail account password", + "chrome fix gmail password", + "chrome fix google account password", + "chrome fix google password", + "chrome gmail account password change", + "chrome gmail account password fix", + "chrome gmail account password reset", + "chrome gmail account password update", + "chrome gmail password change", + "chrome gmail password fix", + "chrome gmail password reset", + "chrome gmail password update", + "chrome google account password change", + "chrome google account password fix", + "chrome google account password reset", + "chrome google account password update", + "chrome google password change", + "chrome google password fix", + "chrome google password reset", + "chrome google password update", + "chrome reset gmail account password", + "chrome reset gmail password", + "chrome reset google account password", + "chrome reset google password", + "chrome update gmail account password", + "chrome update gmail password", + "chrome update google account password", + "chrome update google password", + "fix browser gmail account password", + "fix browser gmail password", + "fix browser google account password", + "fix browser google password", + "fix chrome gmail account password", + "fix chrome gmail password", + "fix chrome google account password", + "fix chrome google password", + "fix gmail account password", + "fix gmail account password browser", + "fix gmail account password chrome", + "fix gmail account password google", + "fix gmail password", + "fix gmail password browser", + "fix gmail password chrome", + "fix gmail password google", + "fix google account password", + "fix google account password browser", + "fix google account password chrome", + "fix google account password google", + "fix google gmail account password", + "fix google gmail password", + "fix google google account password", + "fix google google password", + "fix google password", + "fix google password browser", + "fix google password chrome", + "fix google password google", + "gmail account password browser change", + "gmail account password browser fix", + "gmail account password browser reset", + "gmail account password browser update", + "gmail account password change", + "gmail account password change browser", + "gmail account password change chrome", + "gmail account password change google", + "gmail account password chrome change", + "gmail account password chrome fix", + "gmail account password chrome reset", + "gmail account password chrome update", + "gmail account password fix", + "gmail account password fix browser", + "gmail account password fix chrome", + "gmail account password fix google", + "gmail account password google change", + "gmail account password google fix", + "gmail account password google reset", + "gmail account password google update", + "gmail account password reset", + "gmail account password reset browser", + "gmail account password reset chrome", + "gmail account password reset google", + "gmail account password update", + "gmail account password update browser", + "gmail account password update chrome", + "gmail account password update google", + "gmail password browser change", + "gmail password browser fix", + "gmail password browser reset", + "gmail password browser update", + "gmail password change", + "gmail password change browser", + "gmail password change chrome", + "gmail password change google", + "gmail password chrome change", + "gmail password chrome fix", + "gmail password chrome reset", + "gmail password chrome update", + "gmail password fix", + "gmail password fix browser", + "gmail password fix chrome", + "gmail password fix google", + "gmail password google change", + "gmail password google fix", + "gmail password google reset", + "gmail password google update", + "gmail password reset", + "gmail password reset browser", + "gmail password reset chrome", + "gmail password reset google", + "gmail password update", + "gmail password update browser", + "gmail password update chrome", + "gmail password update google", + "google account password browser change", + "google account password browser fix", + "google account password browser reset", + "google account password browser update", + "google account password change", + "google account password change browser", + "google account password change chrome", + "google account password change google", + "google account password chrome change", + "google account password chrome fix", + "google account password chrome reset", + "google account password chrome update", + "google account password fix", + "google account password fix browser", + "google account password fix chrome", + "google account password fix google", + "google account password google change", + "google account password google fix", + "google account password google reset", + "google account password google update", + "google account password reset", + "google account password reset browser", + "google account password reset chrome", + "google account password reset google", + "google account password update", + "google account password update browser", + "google account password update chrome", + "google account password update google", + "google change gmail account password", + "google change gmail password", + "google change google account password", + "google change google password", + "google fix gmail account password", + "google fix gmail password", + "google fix google account password", + "google fix google password", + "google gmail account password change", + "google gmail account password fix", + "google gmail account password reset", + "google gmail account password update", + "google gmail password change", + "google gmail password fix", + "google gmail password reset", + "google gmail password update", + "google google account password change", + "google google account password fix", + "google google account password reset", + "google google account password update", + "google google password change", + "google google password fix", + "google google password reset", + "google google password update", + "google password browser change", + "google password browser fix", + "google password browser reset", + "google password browser update", + "google password change", + "google password change browser", + "google password change chrome", + "google password change google", + "google password chrome change", + "google password chrome fix", + "google password chrome reset", + "google password chrome update", + "google password fix", + "google password fix browser", + "google password fix chrome", + "google password fix google", + "google password google change", + "google password google fix", + "google password google reset", + "google password google update", + "google password reset", + "google password reset browser", + "google password reset chrome", + "google password reset google", + "google password update", + "google password update browser", + "google password update chrome", + "google password update google", + "google reset gmail account password", + "google reset gmail password", + "google reset google account password", + "google reset google password", + "google update gmail account password", + "google update gmail password", + "google update google account password", + "google update google password", + "reset browser gmail account password", + "reset browser gmail password", + "reset browser google account password", + "reset browser google password", + "reset chrome gmail account password", + "reset chrome gmail password", + "reset chrome google account password", + "reset chrome google password", + "reset gmail account password", + "reset gmail account password browser", + "reset gmail account password chrome", + "reset gmail account password google", + "reset gmail password", + "reset gmail password browser", + "reset gmail password chrome", + "reset gmail password google", + "reset google account password", + "reset google account password browser", + "reset google account password chrome", + "reset google account password google", + "reset google gmail account password", + "reset google gmail password", + "reset google google account password", + "reset google google password", + "reset google password", + "reset google password browser", + "reset google password chrome", + "reset google password google", + "update browser gmail account password", + "update browser gmail password", + "update browser google account password", + "update browser google password", + "update chrome gmail account password", + "update chrome gmail password", + "update chrome google account password", + "update chrome google password", + "update gmail account password", + "update gmail account password browser", + "update gmail account password chrome", + "update gmail account password google", + "update gmail password", + "update gmail password browser", + "update gmail password chrome", + "update gmail password google", + "update google account password", + "update google account password browser", + "update google account password chrome", + "update google account password google", + "update google gmail account password", + "update google gmail password", + "update google google account password", + "update google google password", + "update google password", + "update google password browser", + "update google password chrome", + "update google password google", + }, + + // ID#27 + { + // Generated suggestions: + "chrome dino", + "chrome dino game", + "chrome dino game play", + "chrome dino game run", + "chrome dino play", + "chrome dino play game", + "chrome dino run", + "chrome dino run game", + "chrome dinosaur", + "chrome dinosaur game", + "chrome dinosaur game play", + "chrome dinosaur game run", + "chrome dinosaur play", + "chrome dinosaur play game", + "chrome dinosaur run", + "chrome dinosaur run game", + "chrome game dino", + "chrome game dino play", + "chrome game dino run", + "chrome game dinosaur", + "chrome game dinosaur play", + "chrome game dinosaur run", + "chrome game play dino", + "chrome game play dinosaur", + "chrome game run dino", + "chrome game run dinosaur", + "chrome play dino", + "chrome play dino game", + "chrome play dinosaur", + "chrome play dinosaur game", + "chrome play game dino", + "chrome play game dinosaur", + "chrome run dino", + "chrome run dino game", + "chrome run dinosaur", + "chrome run dinosaur game", + "chrome run game dino", + "chrome run game dinosaur", + "dino chrome", + "dino chrome game", + "dino chrome game play", + "dino chrome game run", + "dino chrome play", + "dino chrome play game", + "dino chrome run", + "dino chrome run game", + "dino game chrome", + "dino game chrome play", + "dino game chrome run", + "dino game google chrome", + "dino game google chrome play", + "dino game google chrome run", + "dino game play chrome", + "dino game play google chrome", + "dino game run chrome", + "dino game run google chrome", + "dino google chrome", + "dino google chrome game", + "dino google chrome game play", + "dino google chrome game run", + "dino google chrome play", + "dino google chrome play game", + "dino google chrome run", + "dino google chrome run game", + "dino play chrome", + "dino play chrome game", + "dino play game chrome", + "dino play game google chrome", + "dino play google chrome", + "dino play google chrome game", + "dino run chrome", + "dino run chrome game", + "dino run game chrome", + "dino run game google chrome", + "dino run google chrome", + "dino run google chrome game", + "dinosaur chrome", + "dinosaur chrome game", + "dinosaur chrome game play", + "dinosaur chrome game run", + "dinosaur chrome play", + "dinosaur chrome play game", + "dinosaur chrome run", + "dinosaur chrome run game", + "dinosaur game chrome", + "dinosaur game chrome play", + "dinosaur game chrome run", + "dinosaur game google chrome", + "dinosaur game google chrome play", + "dinosaur game google chrome run", + "dinosaur game play chrome", + "dinosaur game play google chrome", + "dinosaur game run chrome", + "dinosaur game run google chrome", + "dinosaur google chrome", + "dinosaur google chrome game", + "dinosaur google chrome game play", + "dinosaur google chrome game run", + "dinosaur google chrome play", + "dinosaur google chrome play game", + "dinosaur google chrome run", + "dinosaur google chrome run game", + "dinosaur play chrome", + "dinosaur play chrome game", + "dinosaur play game chrome", + "dinosaur play game google chrome", + "dinosaur play google chrome", + "dinosaur play google chrome game", + "dinosaur run chrome", + "dinosaur run chrome game", + "dinosaur run game chrome", + "dinosaur run game google chrome", + "dinosaur run google chrome", + "dinosaur run google chrome game", + "game chrome dino", + "game chrome dino play", + "game chrome dino run", + "game chrome dinosaur", + "game chrome dinosaur play", + "game chrome dinosaur run", + "game chrome play dino", + "game chrome play dinosaur", + "game chrome run dino", + "game chrome run dinosaur", + "game dino chrome", + "game dino chrome play", + "game dino chrome run", + "game dino google chrome", + "game dino google chrome play", + "game dino google chrome run", + "game dino play chrome", + "game dino play google chrome", + "game dino run chrome", + "game dino run google chrome", + "game dinosaur chrome", + "game dinosaur chrome play", + "game dinosaur chrome run", + "game dinosaur google chrome", + "game dinosaur google chrome play", + "game dinosaur google chrome run", + "game dinosaur play chrome", + "game dinosaur play google chrome", + "game dinosaur run chrome", + "game dinosaur run google chrome", + "game google chrome dino", + "game google chrome dino play", + "game google chrome dino run", + "game google chrome dinosaur", + "game google chrome dinosaur play", + "game google chrome dinosaur run", + "game google chrome play dino", + "game google chrome play dinosaur", + "game google chrome run dino", + "game google chrome run dinosaur", + "game play chrome dino", + "game play chrome dinosaur", + "game play dino chrome", + "game play dino google chrome", + "game play dinosaur chrome", + "game play dinosaur google chrome", + "game play google chrome dino", + "game play google chrome dinosaur", + "game run chrome dino", + "game run chrome dinosaur", + "game run dino chrome", + "game run dino google chrome", + "game run dinosaur chrome", + "game run dinosaur google chrome", + "game run google chrome dino", + "game run google chrome dinosaur", + "google chrome dino", + "google chrome dino game", + "google chrome dino game play", + "google chrome dino game run", + "google chrome dino play", + "google chrome dino play game", + "google chrome dino run", + "google chrome dino run game", + "google chrome dinosaur", + "google chrome dinosaur game", + "google chrome dinosaur game play", + "google chrome dinosaur game run", + "google chrome dinosaur play", + "google chrome dinosaur play game", + "google chrome dinosaur run", + "google chrome dinosaur run game", + "google chrome game dino", + "google chrome game dino play", + "google chrome game dino run", + "google chrome game dinosaur", + "google chrome game dinosaur play", + "google chrome game dinosaur run", + "google chrome game play dino", + "google chrome game play dinosaur", + "google chrome game run dino", + "google chrome game run dinosaur", + "google chrome play dino", + "google chrome play dino game", + "google chrome play dinosaur", + "google chrome play dinosaur game", + "google chrome play game dino", + "google chrome play game dinosaur", + "google chrome run dino", + "google chrome run dino game", + "google chrome run dinosaur", + "google chrome run dinosaur game", + "google chrome run game dino", + "google chrome run game dinosaur", + "play chrome dino", + "play chrome dino game", + "play chrome dinosaur", + "play chrome dinosaur game", + "play chrome game dino", + "play chrome game dinosaur", + "play dino chrome", + "play dino chrome game", + "play dino game chrome", + "play dino game google chrome", + "play dino google chrome", + "play dino google chrome game", + "play dinosaur chrome", + "play dinosaur chrome game", + "play dinosaur game chrome", + "play dinosaur game google chrome", + "play dinosaur google chrome", + "play dinosaur google chrome game", + "play game chrome dino", + "play game chrome dinosaur", + "play game dino chrome", + "play game dino google chrome", + "play game dinosaur chrome", + "play game dinosaur google chrome", + "play game google chrome dino", + "play game google chrome dinosaur", + "play google chrome dino", + "play google chrome dino game", + "play google chrome dinosaur", + "play google chrome dinosaur game", + "play google chrome game dino", + "play google chrome game dinosaur", + "run chrome dino", + "run chrome dino game", + "run chrome dinosaur", + "run chrome dinosaur game", + "run chrome game dino", + "run chrome game dinosaur", + "run dino chrome", + "run dino chrome game", + "run dino game chrome", + "run dino game google chrome", + "run dino google chrome", + "run dino google chrome game", + "run dinosaur chrome", + "run dinosaur chrome game", + "run dinosaur game chrome", + "run dinosaur game google chrome", + "run dinosaur google chrome", + "run dinosaur google chrome game", + "run game chrome dino", + "run game chrome dinosaur", + "run game dino chrome", + "run game dino google chrome", + "run game dinosaur chrome", + "run game dinosaur google chrome", + "run game google chrome dino", + "run game google chrome dinosaur", + "run google chrome dino", + "run google chrome dino game", + "run google chrome dinosaur", + "run google chrome dinosaur game", + "run google chrome game dino", + "run google chrome game dinosaur", + }, + + // End of generated test code + // clang-format on + }; + + // The test code below ensures that each element of the outer vector above, + // |literal_concept_expressions|, fully corresponds to exactly one Pedal + // implementation. For each one, the full list of literal expressions are + // confirmed as concept matches for the Pedal. Finally, we verify that + // every implemented Pedal has been tested using set logic. + MockAutocompleteProviderClient client; + OmniboxPedalProvider provider(client, true); + const auto& pedals = provider.pedals_; + std::unordered_set<const OmniboxPedal*> found_pedals(pedals.size()); + LOG(INFO) << "Pedal count: " << pedals.size(); + for (const auto& pedal_concept : literal_concept_expressions) { + const std::u16string first_trigger = base::ASCIIToUTF16(pedal_concept[0]); + const OmniboxPedal* canonical_pedal = + provider.FindPedalMatch(first_trigger); + EXPECT_NE(canonical_pedal, nullptr) + << "Canonical pedal not found for: " << first_trigger; + const bool is_newly_found = found_pedals.insert(canonical_pedal).second; + EXPECT_TRUE(is_newly_found) + << "Found the same Pedal more than once with: " << first_trigger; + for (const char* literal : pedal_concept) { + const std::u16string expression = base::ASCIIToUTF16(literal); + const auto is_match = [&](const auto& pedal) { + OmniboxPedal::TokenSequence sequence(0); + provider.Tokenize(sequence, expression); + provider.ignore_group_.EraseMatchesIn(sequence, true); + sequence.ResetLinks(); + return pedal.second->IsConceptMatch(sequence); + }; + auto iter = std::find_if(pedals.begin(), pedals.end(), is_match); + EXPECT_NE(iter, pedals.end()) << "Pedal not found for: " << expression; + EXPECT_EQ(iter->second.get(), canonical_pedal) + << "Found wrong Pedal for: " << expression; + std::advance(iter, 1); + iter = std::find_if(iter, pedals.end(), is_match); + EXPECT_EQ(iter, pedals.end()) + << "Found more than one Pedal match for: " << expression; + } + } + } + base::test::ScopedFeatureList feature_list_; base::test::TaskEnvironment task_environment_; std::unique_ptr<TestOmniboxClient> omnibox_client_; std::unique_ptr<TestOmniboxEditController> omnibox_edit_controller_; }; +class OmniboxPedalImplementationsWithoutTranslationConsoleTest + : public OmniboxPedalImplementationsTest { + protected: + void SetUp() override { + feature_list_.InitWithFeatures( + { + omnibox::kOmniboxPedalsBatch2, + omnibox::kOmniboxPedalsBatch2NonEnglish, + omnibox::kOmniboxPedalsBatch3, + }, + {}); + } +}; + TEST_F(OmniboxPedalImplementationsTest, PedalClearBrowsingDataExecutes) { MockAutocompleteProviderClient client; OmniboxPedalProvider provider(client, true); @@ -53,6 +16438,18 @@ ExecuteContextAndReturnResult(pedal)); } +TEST_F(OmniboxPedalImplementationsWithoutTranslationConsoleTest, + PedalClearBrowsingDataExecutes) { + MockAutocompleteProviderClient client; + OmniboxPedalProvider provider(client, true); + + const OmniboxPedal* pedal = provider.FindPedalMatch(u"clear browser data"); + EXPECT_EQ(OmniboxPedalId::CLEAR_BROWSING_DATA, pedal->id()); + + EXPECT_EQ(GURL("chrome://settings/clearBrowserData"), + ExecuteContextAndReturnResult(pedal)); +} + TEST_F(OmniboxPedalImplementationsTest, PedalIncognitoClearBrowsingDataExecutes) { MockAutocompleteProviderClient client; @@ -67,16374 +16464,26 @@ EXPECT_EQ(GURL(""), ExecuteContextAndReturnResult(pedal)); } -// Exhaustive test of unordered synonym groups for concept matches; this is -// useful in detecting possible clashes between cross-group synonym strings. -// By ensuring that each set matches for exactly one Pedal, we can also -// prevent clashes between concepts for different Pedals. +TEST_F(OmniboxPedalImplementationsWithoutTranslationConsoleTest, + PedalIncognitoClearBrowsingDataExecutes) { + MockAutocompleteProviderClient client; + EXPECT_CALL(client, IsOffTheRecord()).WillOnce(testing::Return(true)); + OmniboxPedalProvider provider(client, true); + + const OmniboxPedal* pedal = provider.FindPedalMatch(u"clear browser data"); + // Note, there is only one Pedal for clearing browser data but it behaves + // differently depending on incognito status. The incognito behavior does + // not navigate but the non-incognito behavior does navigate. + EXPECT_EQ(OmniboxPedalId::CLEAR_BROWSING_DATA, pedal->id()); + EXPECT_EQ(GURL(""), ExecuteContextAndReturnResult(pedal)); +} + TEST_F(OmniboxPedalImplementationsTest, UnorderedSynonymExpressionsAreConceptMatches) { - const std::vector<std::vector<const char*>> literal_concept_expressions = { - // clang-format off - // Note: The lists below are auto-generated from raw synonym group data. + TestLiteralConceptExpressions(); +} - // ID#1 - { - // Generated suggestions: - "browser cache clear", - "browser cache delete", - "browser cache erase", - "browser cache remove", - "browser cache wipe", - "browser clear cache", - "browser clear cookies", - "browser clear data", - "browser clear history", - "browser clear info", - "browser clear information", - "browser cookies clear", - "browser cookies delete", - "browser cookies erase", - "browser cookies remove", - "browser cookies wipe", - "browser data clear", - "browser data delete", - "browser data erase", - "browser data remove", - "browser data wipe", - "browser delete cache", - "browser delete cookies", - "browser delete data", - "browser delete history", - "browser delete info", - "browser delete information", - "browser erase cache", - "browser erase cookies", - "browser erase data", - "browser erase history", - "browser erase info", - "browser erase information", - "browser history clear", - "browser history delete", - "browser history erase", - "browser history remove", - "browser history wipe", - "browser info clear", - "browser info delete", - "browser info erase", - "browser info remove", - "browser info wipe", - "browser information clear", - "browser information delete", - "browser information erase", - "browser information remove", - "browser information wipe", - "browser remove cache", - "browser remove cookies", - "browser remove data", - "browser remove history", - "browser remove info", - "browser remove information", - "browser wipe cache", - "browser wipe cookies", - "browser wipe data", - "browser wipe history", - "browser wipe info", - "browser wipe information", - "browsing cache clear", - "browsing cache delete", - "browsing cache erase", - "browsing cache remove", - "browsing cache wipe", - "browsing clear cache", - "browsing clear cookies", - "browsing clear data", - "browsing clear history", - "browsing clear info", - "browsing clear information", - "browsing cookies clear", - "browsing cookies delete", - "browsing cookies erase", - "browsing cookies remove", - "browsing cookies wipe", - "browsing data clear", - "browsing data delete", - "browsing data erase", - "browsing data remove", - "browsing data wipe", - "browsing delete cache", - "browsing delete cookies", - "browsing delete data", - "browsing delete history", - "browsing delete info", - "browsing delete information", - "browsing erase cache", - "browsing erase cookies", - "browsing erase data", - "browsing erase history", - "browsing erase info", - "browsing erase information", - "browsing history clear", - "browsing history delete", - "browsing history erase", - "browsing history remove", - "browsing history wipe", - "browsing info clear", - "browsing info delete", - "browsing info erase", - "browsing info remove", - "browsing info wipe", - "browsing information clear", - "browsing information delete", - "browsing information erase", - "browsing information remove", - "browsing information wipe", - "browsing remove cache", - "browsing remove cookies", - "browsing remove data", - "browsing remove history", - "browsing remove info", - "browsing remove information", - "browsing wipe cache", - "browsing wipe cookies", - "browsing wipe data", - "browsing wipe history", - "browsing wipe info", - "browsing wipe information", - "cache browser clear", - "cache browser delete", - "cache browser erase", - "cache browser remove", - "cache browser wipe", - "cache browsing clear", - "cache browsing delete", - "cache browsing erase", - "cache browsing remove", - "cache browsing wipe", - "cache chrome clear", - "cache chrome delete", - "cache chrome erase", - "cache chrome remove", - "cache chrome wipe", - "cache clear", - "cache clear browser", - "cache clear browsing", - "cache clear chrome", - "cache clear google chrome", - "cache delete", - "cache delete browser", - "cache delete browsing", - "cache delete chrome", - "cache delete google chrome", - "cache erase", - "cache erase browser", - "cache erase browsing", - "cache erase chrome", - "cache erase google chrome", - "cache google chrome clear", - "cache google chrome delete", - "cache google chrome erase", - "cache google chrome remove", - "cache google chrome wipe", - "cache remove", - "cache remove browser", - "cache remove browsing", - "cache remove chrome", - "cache remove google chrome", - "cache wipe", - "cache wipe browser", - "cache wipe browsing", - "cache wipe chrome", - "cache wipe google chrome", - "chrome cache clear", - "chrome cache delete", - "chrome cache erase", - "chrome cache remove", - "chrome cache wipe", - "chrome clear cache", - "chrome clear cookies", - "chrome clear data", - "chrome clear history", - "chrome clear info", - "chrome clear information", - "chrome cookies clear", - "chrome cookies delete", - "chrome cookies erase", - "chrome cookies remove", - "chrome cookies wipe", - "chrome data clear", - "chrome data delete", - "chrome data erase", - "chrome data remove", - "chrome data wipe", - "chrome delete cache", - "chrome delete cookies", - "chrome delete data", - "chrome delete history", - "chrome delete info", - "chrome delete information", - "chrome erase cache", - "chrome erase cookies", - "chrome erase data", - "chrome erase history", - "chrome erase info", - "chrome erase information", - "chrome history clear", - "chrome history delete", - "chrome history erase", - "chrome history remove", - "chrome history wipe", - "chrome info clear", - "chrome info delete", - "chrome info erase", - "chrome info remove", - "chrome info wipe", - "chrome information clear", - "chrome information delete", - "chrome information erase", - "chrome information remove", - "chrome information wipe", - "chrome remove cache", - "chrome remove cookies", - "chrome remove data", - "chrome remove history", - "chrome remove info", - "chrome remove information", - "chrome wipe cache", - "chrome wipe cookies", - "chrome wipe data", - "chrome wipe history", - "chrome wipe info", - "chrome wipe information", - "clear browser cache", - "clear browser cookies", - "clear browser data", - "clear browser history", - "clear browser info", - "clear browser information", - "clear browsing cache", - "clear browsing cookies", - "clear browsing data", - "clear browsing history", - "clear browsing info", - "clear browsing information", - "clear cache", - "clear cache browser", - "clear cache browsing", - "clear cache chrome", - "clear cache google chrome", - "clear chrome cache", - "clear chrome cookies", - "clear chrome data", - "clear chrome history", - "clear chrome info", - "clear chrome information", - "clear cookies", - "clear cookies browser", - "clear cookies browsing", - "clear cookies chrome", - "clear cookies google chrome", - "clear data", - "clear data browser", - "clear data browsing", - "clear data chrome", - "clear data google chrome", - "clear google chrome cache", - "clear google chrome cookies", - "clear google chrome data", - "clear google chrome history", - "clear google chrome info", - "clear google chrome information", - "clear history", - "clear history browser", - "clear history browsing", - "clear history chrome", - "clear history google chrome", - "clear info", - "clear info browser", - "clear info browsing", - "clear info chrome", - "clear info google chrome", - "clear information", - "clear information browser", - "clear information browsing", - "clear information chrome", - "clear information google chrome", - "cookies browser clear", - "cookies browser delete", - "cookies browser erase", - "cookies browser remove", - "cookies browser wipe", - "cookies browsing clear", - "cookies browsing delete", - "cookies browsing erase", - "cookies browsing remove", - "cookies browsing wipe", - "cookies chrome clear", - "cookies chrome delete", - "cookies chrome erase", - "cookies chrome remove", - "cookies chrome wipe", - "cookies clear", - "cookies clear browser", - "cookies clear browsing", - "cookies clear chrome", - "cookies clear google chrome", - "cookies delete", - "cookies delete browser", - "cookies delete browsing", - "cookies delete chrome", - "cookies delete google chrome", - "cookies erase", - "cookies erase browser", - "cookies erase browsing", - "cookies erase chrome", - "cookies erase google chrome", - "cookies google chrome clear", - "cookies google chrome delete", - "cookies google chrome erase", - "cookies google chrome remove", - "cookies google chrome wipe", - "cookies remove", - "cookies remove browser", - "cookies remove browsing", - "cookies remove chrome", - "cookies remove google chrome", - "cookies wipe", - "cookies wipe browser", - "cookies wipe browsing", - "cookies wipe chrome", - "cookies wipe google chrome", - "data browser clear", - "data browser delete", - "data browser erase", - "data browser remove", - "data browser wipe", - "data browsing clear", - "data browsing delete", - "data browsing erase", - "data browsing remove", - "data browsing wipe", - "data chrome clear", - "data chrome delete", - "data chrome erase", - "data chrome remove", - "data chrome wipe", - "data clear", - "data clear browser", - "data clear browsing", - "data clear chrome", - "data clear google chrome", - "data delete", - "data delete browser", - "data delete browsing", - "data delete chrome", - "data delete google chrome", - "data erase", - "data erase browser", - "data erase browsing", - "data erase chrome", - "data erase google chrome", - "data google chrome clear", - "data google chrome delete", - "data google chrome erase", - "data google chrome remove", - "data google chrome wipe", - "data remove", - "data remove browser", - "data remove browsing", - "data remove chrome", - "data remove google chrome", - "data wipe", - "data wipe browser", - "data wipe browsing", - "data wipe chrome", - "data wipe google chrome", - "delete browser cache", - "delete browser cookies", - "delete browser data", - "delete browser history", - "delete browser info", - "delete browser information", - "delete browsing cache", - "delete browsing cookies", - "delete browsing data", - "delete browsing history", - "delete browsing info", - "delete browsing information", - "delete cache", - "delete cache browser", - "delete cache browsing", - "delete cache chrome", - "delete cache google chrome", - "delete chrome cache", - "delete chrome cookies", - "delete chrome data", - "delete chrome history", - "delete chrome info", - "delete chrome information", - "delete cookies", - "delete cookies browser", - "delete cookies browsing", - "delete cookies chrome", - "delete cookies google chrome", - "delete data", - "delete data browser", - "delete data browsing", - "delete data chrome", - "delete data google chrome", - "delete google chrome cache", - "delete google chrome cookies", - "delete google chrome data", - "delete google chrome history", - "delete google chrome info", - "delete google chrome information", - "delete history", - "delete history browser", - "delete history browsing", - "delete history chrome", - "delete history google chrome", - "delete info", - "delete info browser", - "delete info browsing", - "delete info chrome", - "delete info google chrome", - "delete information", - "delete information browser", - "delete information browsing", - "delete information chrome", - "delete information google chrome", - "erase browser cache", - "erase browser cookies", - "erase browser data", - "erase browser history", - "erase browser info", - "erase browser information", - "erase browsing cache", - "erase browsing cookies", - "erase browsing data", - "erase browsing history", - "erase browsing info", - "erase browsing information", - "erase cache", - "erase cache browser", - "erase cache browsing", - "erase cache chrome", - "erase cache google chrome", - "erase chrome cache", - "erase chrome cookies", - "erase chrome data", - "erase chrome history", - "erase chrome info", - "erase chrome information", - "erase cookies", - "erase cookies browser", - "erase cookies browsing", - "erase cookies chrome", - "erase cookies google chrome", - "erase data", - "erase data browser", - "erase data browsing", - "erase data chrome", - "erase data google chrome", - "erase google chrome cache", - "erase google chrome cookies", - "erase google chrome data", - "erase google chrome history", - "erase google chrome info", - "erase google chrome information", - "erase history", - "erase history browser", - "erase history browsing", - "erase history chrome", - "erase history google chrome", - "erase info", - "erase info browser", - "erase info browsing", - "erase info chrome", - "erase info google chrome", - "erase information", - "erase information browser", - "erase information browsing", - "erase information chrome", - "erase information google chrome", - "google chrome cache clear", - "google chrome cache delete", - "google chrome cache erase", - "google chrome cache remove", - "google chrome cache wipe", - "google chrome clear cache", - "google chrome clear cookies", - "google chrome clear data", - "google chrome clear history", - "google chrome clear info", - "google chrome clear information", - "google chrome cookies clear", - "google chrome cookies delete", - "google chrome cookies erase", - "google chrome cookies remove", - "google chrome cookies wipe", - "google chrome data clear", - "google chrome data delete", - "google chrome data erase", - "google chrome data remove", - "google chrome data wipe", - "google chrome delete cache", - "google chrome delete cookies", - "google chrome delete data", - "google chrome delete history", - "google chrome delete info", - "google chrome delete information", - "google chrome erase cache", - "google chrome erase cookies", - "google chrome erase data", - "google chrome erase history", - "google chrome erase info", - "google chrome erase information", - "google chrome history clear", - "google chrome history delete", - "google chrome history erase", - "google chrome history remove", - "google chrome history wipe", - "google chrome info clear", - "google chrome info delete", - "google chrome info erase", - "google chrome info remove", - "google chrome info wipe", - "google chrome information clear", - "google chrome information delete", - "google chrome information erase", - "google chrome information remove", - "google chrome information wipe", - "google chrome remove cache", - "google chrome remove cookies", - "google chrome remove data", - "google chrome remove history", - "google chrome remove info", - "google chrome remove information", - "google chrome wipe cache", - "google chrome wipe cookies", - "google chrome wipe data", - "google chrome wipe history", - "google chrome wipe info", - "google chrome wipe information", - "history browser clear", - "history browser delete", - "history browser erase", - "history browser remove", - "history browser wipe", - "history browsing clear", - "history browsing delete", - "history browsing erase", - "history browsing remove", - "history browsing wipe", - "history chrome clear", - "history chrome delete", - "history chrome erase", - "history chrome remove", - "history chrome wipe", - "history clear", - "history clear browser", - "history clear browsing", - "history clear chrome", - "history clear google chrome", - "history delete", - "history delete browser", - "history delete browsing", - "history delete chrome", - "history delete google chrome", - "history erase", - "history erase browser", - "history erase browsing", - "history erase chrome", - "history erase google chrome", - "history google chrome clear", - "history google chrome delete", - "history google chrome erase", - "history google chrome remove", - "history google chrome wipe", - "history remove", - "history remove browser", - "history remove browsing", - "history remove chrome", - "history remove google chrome", - "history wipe", - "history wipe browser", - "history wipe browsing", - "history wipe chrome", - "history wipe google chrome", - "info browser clear", - "info browser delete", - "info browser erase", - "info browser remove", - "info browser wipe", - "info browsing clear", - "info browsing delete", - "info browsing erase", - "info browsing remove", - "info browsing wipe", - "info chrome clear", - "info chrome delete", - "info chrome erase", - "info chrome remove", - "info chrome wipe", - "info clear", - "info clear browser", - "info clear browsing", - "info clear chrome", - "info clear google chrome", - "info delete", - "info delete browser", - "info delete browsing", - "info delete chrome", - "info delete google chrome", - "info erase", - "info erase browser", - "info erase browsing", - "info erase chrome", - "info erase google chrome", - "info google chrome clear", - "info google chrome delete", - "info google chrome erase", - "info google chrome remove", - "info google chrome wipe", - "info remove", - "info remove browser", - "info remove browsing", - "info remove chrome", - "info remove google chrome", - "info wipe", - "info wipe browser", - "info wipe browsing", - "info wipe chrome", - "info wipe google chrome", - "information browser clear", - "information browser delete", - "information browser erase", - "information browser remove", - "information browser wipe", - "information browsing clear", - "information browsing delete", - "information browsing erase", - "information browsing remove", - "information browsing wipe", - "information chrome clear", - "information chrome delete", - "information chrome erase", - "information chrome remove", - "information chrome wipe", - "information clear", - "information clear browser", - "information clear browsing", - "information clear chrome", - "information clear google chrome", - "information delete", - "information delete browser", - "information delete browsing", - "information delete chrome", - "information delete google chrome", - "information erase", - "information erase browser", - "information erase browsing", - "information erase chrome", - "information erase google chrome", - "information google chrome clear", - "information google chrome delete", - "information google chrome erase", - "information google chrome remove", - "information google chrome wipe", - "information remove", - "information remove browser", - "information remove browsing", - "information remove chrome", - "information remove google chrome", - "information wipe", - "information wipe browser", - "information wipe browsing", - "information wipe chrome", - "information wipe google chrome", - "remove browser cache", - "remove browser cookies", - "remove browser data", - "remove browser history", - "remove browser info", - "remove browser information", - "remove browsing cache", - "remove browsing cookies", - "remove browsing data", - "remove browsing history", - "remove browsing info", - "remove browsing information", - "remove cache", - "remove cache browser", - "remove cache browsing", - "remove cache chrome", - "remove cache google chrome", - "remove chrome cache", - "remove chrome cookies", - "remove chrome data", - "remove chrome history", - "remove chrome info", - "remove chrome information", - "remove cookies", - "remove cookies browser", - "remove cookies browsing", - "remove cookies chrome", - "remove cookies google chrome", - "remove data", - "remove data browser", - "remove data browsing", - "remove data chrome", - "remove data google chrome", - "remove google chrome cache", - "remove google chrome cookies", - "remove google chrome data", - "remove google chrome history", - "remove google chrome info", - "remove google chrome information", - "remove history", - "remove history browser", - "remove history browsing", - "remove history chrome", - "remove history google chrome", - "remove info", - "remove info browser", - "remove info browsing", - "remove info chrome", - "remove info google chrome", - "remove information", - "remove information browser", - "remove information browsing", - "remove information chrome", - "remove information google chrome", - "wipe browser cache", - "wipe browser cookies", - "wipe browser data", - "wipe browser history", - "wipe browser info", - "wipe browser information", - "wipe browsing cache", - "wipe browsing cookies", - "wipe browsing data", - "wipe browsing history", - "wipe browsing info", - "wipe browsing information", - "wipe cache", - "wipe cache browser", - "wipe cache browsing", - "wipe cache chrome", - "wipe cache google chrome", - "wipe chrome cache", - "wipe chrome cookies", - "wipe chrome data", - "wipe chrome history", - "wipe chrome info", - "wipe chrome information", - "wipe cookies", - "wipe cookies browser", - "wipe cookies browsing", - "wipe cookies chrome", - "wipe cookies google chrome", - "wipe data", - "wipe data browser", - "wipe data browsing", - "wipe data chrome", - "wipe data google chrome", - "wipe google chrome cache", - "wipe google chrome cookies", - "wipe google chrome data", - "wipe google chrome history", - "wipe google chrome info", - "wipe google chrome information", - "wipe history", - "wipe history browser", - "wipe history browsing", - "wipe history chrome", - "wipe history google chrome", - "wipe info", - "wipe info browser", - "wipe info browsing", - "wipe info chrome", - "wipe info google chrome", - "wipe information", - "wipe information browser", - "wipe information browsing", - "wipe information chrome", - "wipe information google chrome", - }, - - // ID#2 - { - // Generated suggestions: - "browser change credentials", - "browser change password", - "browser change passwords", - "browser credentials change", - "browser credentials edit", - "browser credentials manage", - "browser credentials manager", - "browser credentials save", - "browser credentials show", - "browser credentials update", - "browser credentials view", - "browser edit credentials", - "browser edit password", - "browser edit passwords", - "browser manage credentials", - "browser manage password", - "browser manage passwords", - "browser manager credentials", - "browser manager password", - "browser manager passwords", - "browser password change", - "browser password edit", - "browser password manage", - "browser password manager", - "browser password save", - "browser password show", - "browser password update", - "browser password view", - "browser passwords change", - "browser passwords edit", - "browser passwords manage", - "browser passwords manager", - "browser passwords save", - "browser passwords show", - "browser passwords update", - "browser passwords view", - "browser save credentials", - "browser save password", - "browser save passwords", - "browser show credentials", - "browser show password", - "browser show passwords", - "browser update credentials", - "browser update password", - "browser update passwords", - "browser view credentials", - "browser view password", - "browser view passwords", - "change browser credentials", - "change browser password", - "change browser passwords", - "change chrome credentials", - "change chrome password", - "change chrome passwords", - "change credentials", - "change credentials browser", - "change credentials chrome", - "change credentials google chrome", - "change google chrome credentials", - "change google chrome password", - "change google chrome passwords", - "change password", - "change password browser", - "change password chrome", - "change password google chrome", - "change passwords", - "change passwords browser", - "change passwords chrome", - "change passwords google chrome", - "chrome change credentials", - "chrome change password", - "chrome change passwords", - "chrome credentials change", - "chrome credentials edit", - "chrome credentials manage", - "chrome credentials manager", - "chrome credentials save", - "chrome credentials show", - "chrome credentials update", - "chrome credentials view", - "chrome edit credentials", - "chrome edit password", - "chrome edit passwords", - "chrome manage credentials", - "chrome manage password", - "chrome manage passwords", - "chrome manager credentials", - "chrome manager password", - "chrome manager passwords", - "chrome password change", - "chrome password edit", - "chrome password manage", - "chrome password manager", - "chrome password save", - "chrome password show", - "chrome password update", - "chrome password view", - "chrome passwords change", - "chrome passwords edit", - "chrome passwords manage", - "chrome passwords manager", - "chrome passwords save", - "chrome passwords show", - "chrome passwords update", - "chrome passwords view", - "chrome save credentials", - "chrome save password", - "chrome save passwords", - "chrome show credentials", - "chrome show password", - "chrome show passwords", - "chrome update credentials", - "chrome update password", - "chrome update passwords", - "chrome view credentials", - "chrome view password", - "chrome view passwords", - "credentials browser change", - "credentials browser edit", - "credentials browser manage", - "credentials browser manager", - "credentials browser save", - "credentials browser show", - "credentials browser update", - "credentials browser view", - "credentials change", - "credentials change browser", - "credentials change chrome", - "credentials change google chrome", - "credentials chrome change", - "credentials chrome edit", - "credentials chrome manage", - "credentials chrome manager", - "credentials chrome save", - "credentials chrome show", - "credentials chrome update", - "credentials chrome view", - "credentials edit", - "credentials edit browser", - "credentials edit chrome", - "credentials edit google chrome", - "credentials google chrome change", - "credentials google chrome edit", - "credentials google chrome manage", - "credentials google chrome manager", - "credentials google chrome save", - "credentials google chrome show", - "credentials google chrome update", - "credentials google chrome view", - "credentials manage", - "credentials manage browser", - "credentials manage chrome", - "credentials manage google chrome", - "credentials manager", - "credentials manager browser", - "credentials manager chrome", - "credentials manager google chrome", - "credentials save", - "credentials save browser", - "credentials save chrome", - "credentials save google chrome", - "credentials show", - "credentials show browser", - "credentials show chrome", - "credentials show google chrome", - "credentials update", - "credentials update browser", - "credentials update chrome", - "credentials update google chrome", - "credentials view", - "credentials view browser", - "credentials view chrome", - "credentials view google chrome", - "edit browser credentials", - "edit browser password", - "edit browser passwords", - "edit chrome credentials", - "edit chrome password", - "edit chrome passwords", - "edit credentials", - "edit credentials browser", - "edit credentials chrome", - "edit credentials google chrome", - "edit google chrome credentials", - "edit google chrome password", - "edit google chrome passwords", - "edit password", - "edit password browser", - "edit password chrome", - "edit password google chrome", - "edit passwords", - "edit passwords browser", - "edit passwords chrome", - "edit passwords google chrome", - "google chrome change credentials", - "google chrome change password", - "google chrome change passwords", - "google chrome credentials change", - "google chrome credentials edit", - "google chrome credentials manage", - "google chrome credentials manager", - "google chrome credentials save", - "google chrome credentials show", - "google chrome credentials update", - "google chrome credentials view", - "google chrome edit credentials", - "google chrome edit password", - "google chrome edit passwords", - "google chrome manage credentials", - "google chrome manage password", - "google chrome manage passwords", - "google chrome manager credentials", - "google chrome manager password", - "google chrome manager passwords", - "google chrome password change", - "google chrome password edit", - "google chrome password manage", - "google chrome password manager", - "google chrome password save", - "google chrome password show", - "google chrome password update", - "google chrome password view", - "google chrome passwords change", - "google chrome passwords edit", - "google chrome passwords manage", - "google chrome passwords manager", - "google chrome passwords save", - "google chrome passwords show", - "google chrome passwords update", - "google chrome passwords view", - "google chrome save credentials", - "google chrome save password", - "google chrome save passwords", - "google chrome show credentials", - "google chrome show password", - "google chrome show passwords", - "google chrome update credentials", - "google chrome update password", - "google chrome update passwords", - "google chrome view credentials", - "google chrome view password", - "google chrome view passwords", - "manage browser credentials", - "manage browser password", - "manage browser passwords", - "manage chrome credentials", - "manage chrome password", - "manage chrome passwords", - "manage credentials", - "manage credentials browser", - "manage credentials chrome", - "manage credentials google chrome", - "manage google chrome credentials", - "manage google chrome password", - "manage google chrome passwords", - "manage password", - "manage password browser", - "manage password chrome", - "manage password google chrome", - "manage passwords", - "manage passwords browser", - "manage passwords chrome", - "manage passwords google chrome", - "manager browser credentials", - "manager browser password", - "manager browser passwords", - "manager chrome credentials", - "manager chrome password", - "manager chrome passwords", - "manager credentials", - "manager credentials browser", - "manager credentials chrome", - "manager credentials google chrome", - "manager google chrome credentials", - "manager google chrome password", - "manager google chrome passwords", - "manager password", - "manager password browser", - "manager password chrome", - "manager password google chrome", - "manager passwords", - "manager passwords browser", - "manager passwords chrome", - "manager passwords google chrome", - "password browser change", - "password browser edit", - "password browser manage", - "password browser manager", - "password browser save", - "password browser show", - "password browser update", - "password browser view", - "password change", - "password change browser", - "password change chrome", - "password change google chrome", - "password chrome change", - "password chrome edit", - "password chrome manage", - "password chrome manager", - "password chrome save", - "password chrome show", - "password chrome update", - "password chrome view", - "password edit", - "password edit browser", - "password edit chrome", - "password edit google chrome", - "password google chrome change", - "password google chrome edit", - "password google chrome manage", - "password google chrome manager", - "password google chrome save", - "password google chrome show", - "password google chrome update", - "password google chrome view", - "password manage", - "password manage browser", - "password manage chrome", - "password manage google chrome", - "password manager", - "password manager browser", - "password manager chrome", - "password manager google chrome", - "password save", - "password save browser", - "password save chrome", - "password save google chrome", - "password show", - "password show browser", - "password show chrome", - "password show google chrome", - "password update", - "password update browser", - "password update chrome", - "password update google chrome", - "password view", - "password view browser", - "password view chrome", - "password view google chrome", - "passwords browser change", - "passwords browser edit", - "passwords browser manage", - "passwords browser manager", - "passwords browser save", - "passwords browser show", - "passwords browser update", - "passwords browser view", - "passwords change", - "passwords change browser", - "passwords change chrome", - "passwords change google chrome", - "passwords chrome change", - "passwords chrome edit", - "passwords chrome manage", - "passwords chrome manager", - "passwords chrome save", - "passwords chrome show", - "passwords chrome update", - "passwords chrome view", - "passwords edit", - "passwords edit browser", - "passwords edit chrome", - "passwords edit google chrome", - "passwords google chrome change", - "passwords google chrome edit", - "passwords google chrome manage", - "passwords google chrome manager", - "passwords google chrome save", - "passwords google chrome show", - "passwords google chrome update", - "passwords google chrome view", - "passwords manage", - "passwords manage browser", - "passwords manage chrome", - "passwords manage google chrome", - "passwords manager", - "passwords manager browser", - "passwords manager chrome", - "passwords manager google chrome", - "passwords save", - "passwords save browser", - "passwords save chrome", - "passwords save google chrome", - "passwords show", - "passwords show browser", - "passwords show chrome", - "passwords show google chrome", - "passwords update", - "passwords update browser", - "passwords update chrome", - "passwords update google chrome", - "passwords view", - "passwords view browser", - "passwords view chrome", - "passwords view google chrome", - "save browser credentials", - "save browser password", - "save browser passwords", - "save chrome credentials", - "save chrome password", - "save chrome passwords", - "save credentials", - "save credentials browser", - "save credentials chrome", - "save credentials google chrome", - "save google chrome credentials", - "save google chrome password", - "save google chrome passwords", - "save password", - "save password browser", - "save password chrome", - "save password google chrome", - "save passwords", - "save passwords browser", - "save passwords chrome", - "save passwords google chrome", - "show browser credentials", - "show browser password", - "show browser passwords", - "show chrome credentials", - "show chrome password", - "show chrome passwords", - "show credentials", - "show credentials browser", - "show credentials chrome", - "show credentials google chrome", - "show google chrome credentials", - "show google chrome password", - "show google chrome passwords", - "show password", - "show password browser", - "show password chrome", - "show password google chrome", - "show passwords", - "show passwords browser", - "show passwords chrome", - "show passwords google chrome", - "update browser credentials", - "update browser password", - "update browser passwords", - "update chrome credentials", - "update chrome password", - "update chrome passwords", - "update credentials", - "update credentials browser", - "update credentials chrome", - "update credentials google chrome", - "update google chrome credentials", - "update google chrome password", - "update google chrome passwords", - "update password", - "update password browser", - "update password chrome", - "update password google chrome", - "update passwords", - "update passwords browser", - "update passwords chrome", - "update passwords google chrome", - "view browser credentials", - "view browser password", - "view browser passwords", - "view chrome credentials", - "view chrome password", - "view chrome passwords", - "view credentials", - "view credentials browser", - "view credentials chrome", - "view credentials google chrome", - "view google chrome credentials", - "view google chrome password", - "view google chrome passwords", - "view password", - "view password browser", - "view password chrome", - "view password google chrome", - "view passwords", - "view passwords browser", - "view passwords chrome", - "view passwords google chrome", - }, - - // ID#3 - { - // Generated suggestions: - "browser card info change", - "browser card info edit", - "browser card info manage", - "browser card info save", - "browser card info update", - "browser card information change", - "browser card information edit", - "browser card information manage", - "browser card information save", - "browser card information update", - "browser cards change", - "browser cards edit", - "browser cards manage", - "browser cards save", - "browser cards update", - "browser change card info", - "browser change card information", - "browser change cards", - "browser change credit card", - "browser change credit card info", - "browser change credit card information", - "browser change credit cards", - "browser change payment", - "browser change payment methods", - "browser change payments", - "browser credit card change", - "browser credit card edit", - "browser credit card info change", - "browser credit card info edit", - "browser credit card info manage", - "browser credit card info save", - "browser credit card info update", - "browser credit card information change", - "browser credit card information edit", - "browser credit card information manage", - "browser credit card information save", - "browser credit card information update", - "browser credit card manage", - "browser credit card save", - "browser credit card update", - "browser credit cards change", - "browser credit cards edit", - "browser credit cards manage", - "browser credit cards save", - "browser credit cards update", - "browser edit card info", - "browser edit card information", - "browser edit cards", - "browser edit credit card", - "browser edit credit card info", - "browser edit credit card information", - "browser edit credit cards", - "browser edit payment", - "browser edit payment methods", - "browser edit payments", - "browser manage card info", - "browser manage card information", - "browser manage cards", - "browser manage credit card", - "browser manage credit card info", - "browser manage credit card information", - "browser manage credit cards", - "browser manage payment", - "browser manage payment methods", - "browser manage payments", - "browser payment change", - "browser payment edit", - "browser payment manage", - "browser payment methods change", - "browser payment methods edit", - "browser payment methods manage", - "browser payment methods save", - "browser payment methods update", - "browser payment save", - "browser payment update", - "browser payments change", - "browser payments edit", - "browser payments manage", - "browser payments save", - "browser payments update", - "browser save card info", - "browser save card information", - "browser save cards", - "browser save credit card", - "browser save credit card info", - "browser save credit card information", - "browser save credit cards", - "browser save payment", - "browser save payment methods", - "browser save payments", - "browser update card info", - "browser update card information", - "browser update cards", - "browser update credit card", - "browser update credit card info", - "browser update credit card information", - "browser update credit cards", - "browser update payment", - "browser update payment methods", - "browser update payments", - "card info browser change", - "card info browser edit", - "card info browser manage", - "card info browser save", - "card info browser update", - "card info change", - "card info change browser", - "card info change chrome", - "card info change google chrome", - "card info chrome change", - "card info chrome edit", - "card info chrome manage", - "card info chrome save", - "card info chrome update", - "card info edit", - "card info edit browser", - "card info edit chrome", - "card info edit google chrome", - "card info google chrome change", - "card info google chrome edit", - "card info google chrome manage", - "card info google chrome save", - "card info google chrome update", - "card info manage", - "card info manage browser", - "card info manage chrome", - "card info manage google chrome", - "card info save", - "card info save browser", - "card info save chrome", - "card info save google chrome", - "card info update", - "card info update browser", - "card info update chrome", - "card info update google chrome", - "card information browser change", - "card information browser edit", - "card information browser manage", - "card information browser save", - "card information browser update", - "card information change", - "card information change browser", - "card information change chrome", - "card information change google chrome", - "card information chrome change", - "card information chrome edit", - "card information chrome manage", - "card information chrome save", - "card information chrome update", - "card information edit", - "card information edit browser", - "card information edit chrome", - "card information edit google chrome", - "card information google chrome change", - "card information google chrome edit", - "card information google chrome manage", - "card information google chrome save", - "card information google chrome update", - "card information manage", - "card information manage browser", - "card information manage chrome", - "card information manage google chrome", - "card information save", - "card information save browser", - "card information save chrome", - "card information save google chrome", - "card information update", - "card information update browser", - "card information update chrome", - "card information update google chrome", - "cards browser change", - "cards browser edit", - "cards browser manage", - "cards browser save", - "cards browser update", - "cards change", - "cards change browser", - "cards change chrome", - "cards change google chrome", - "cards chrome change", - "cards chrome edit", - "cards chrome manage", - "cards chrome save", - "cards chrome update", - "cards edit", - "cards edit browser", - "cards edit chrome", - "cards edit google chrome", - "cards google chrome change", - "cards google chrome edit", - "cards google chrome manage", - "cards google chrome save", - "cards google chrome update", - "cards manage", - "cards manage browser", - "cards manage chrome", - "cards manage google chrome", - "cards save", - "cards save browser", - "cards save chrome", - "cards save google chrome", - "cards update", - "cards update browser", - "cards update chrome", - "cards update google chrome", - "change browser card info", - "change browser card information", - "change browser cards", - "change browser credit card", - "change browser credit card info", - "change browser credit card information", - "change browser credit cards", - "change browser payment", - "change browser payment methods", - "change browser payments", - "change card info", - "change card info browser", - "change card info chrome", - "change card info google chrome", - "change card information", - "change card information browser", - "change card information chrome", - "change card information google chrome", - "change cards", - "change cards browser", - "change cards chrome", - "change cards google chrome", - "change chrome card info", - "change chrome card information", - "change chrome cards", - "change chrome credit card", - "change chrome credit card info", - "change chrome credit card information", - "change chrome credit cards", - "change chrome payment", - "change chrome payment methods", - "change chrome payments", - "change credit card", - "change credit card browser", - "change credit card chrome", - "change credit card google chrome", - "change credit card info", - "change credit card info browser", - "change credit card info chrome", - "change credit card info google chrome", - "change credit card information", - "change credit card information browser", - "change credit card information chrome", - "change credit card information google chrome", - "change credit cards", - "change credit cards browser", - "change credit cards chrome", - "change credit cards google chrome", - "change google chrome card info", - "change google chrome card information", - "change google chrome cards", - "change google chrome credit card", - "change google chrome credit card info", - "change google chrome credit card information", - "change google chrome credit cards", - "change google chrome payment", - "change google chrome payment methods", - "change google chrome payments", - "change payment", - "change payment browser", - "change payment chrome", - "change payment google chrome", - "change payment methods", - "change payment methods browser", - "change payment methods chrome", - "change payment methods google chrome", - "change payments", - "change payments browser", - "change payments chrome", - "change payments google chrome", - "chrome card info change", - "chrome card info edit", - "chrome card info manage", - "chrome card info save", - "chrome card info update", - "chrome card information change", - "chrome card information edit", - "chrome card information manage", - "chrome card information save", - "chrome card information update", - "chrome cards change", - "chrome cards edit", - "chrome cards manage", - "chrome cards save", - "chrome cards update", - "chrome change card info", - "chrome change card information", - "chrome change cards", - "chrome change credit card", - "chrome change credit card info", - "chrome change credit card information", - "chrome change credit cards", - "chrome change payment", - "chrome change payment methods", - "chrome change payments", - "chrome credit card change", - "chrome credit card edit", - "chrome credit card info change", - "chrome credit card info edit", - "chrome credit card info manage", - "chrome credit card info save", - "chrome credit card info update", - "chrome credit card information change", - "chrome credit card information edit", - "chrome credit card information manage", - "chrome credit card information save", - "chrome credit card information update", - "chrome credit card manage", - "chrome credit card save", - "chrome credit card update", - "chrome credit cards change", - "chrome credit cards edit", - "chrome credit cards manage", - "chrome credit cards save", - "chrome credit cards update", - "chrome edit card info", - "chrome edit card information", - "chrome edit cards", - "chrome edit credit card", - "chrome edit credit card info", - "chrome edit credit card information", - "chrome edit credit cards", - "chrome edit payment", - "chrome edit payment methods", - "chrome edit payments", - "chrome manage card info", - "chrome manage card information", - "chrome manage cards", - "chrome manage credit card", - "chrome manage credit card info", - "chrome manage credit card information", - "chrome manage credit cards", - "chrome manage payment", - "chrome manage payment methods", - "chrome manage payments", - "chrome payment change", - "chrome payment edit", - "chrome payment manage", - "chrome payment methods change", - "chrome payment methods edit", - "chrome payment methods manage", - "chrome payment methods save", - "chrome payment methods update", - "chrome payment save", - "chrome payment update", - "chrome payments change", - "chrome payments edit", - "chrome payments manage", - "chrome payments save", - "chrome payments update", - "chrome save card info", - "chrome save card information", - "chrome save cards", - "chrome save credit card", - "chrome save credit card info", - "chrome save credit card information", - "chrome save credit cards", - "chrome save payment", - "chrome save payment methods", - "chrome save payments", - "chrome update card info", - "chrome update card information", - "chrome update cards", - "chrome update credit card", - "chrome update credit card info", - "chrome update credit card information", - "chrome update credit cards", - "chrome update payment", - "chrome update payment methods", - "chrome update payments", - "credit card browser change", - "credit card browser edit", - "credit card browser manage", - "credit card browser save", - "credit card browser update", - "credit card change", - "credit card change browser", - "credit card change chrome", - "credit card change google chrome", - "credit card chrome change", - "credit card chrome edit", - "credit card chrome manage", - "credit card chrome save", - "credit card chrome update", - "credit card edit", - "credit card edit browser", - "credit card edit chrome", - "credit card edit google chrome", - "credit card google chrome change", - "credit card google chrome edit", - "credit card google chrome manage", - "credit card google chrome save", - "credit card google chrome update", - "credit card info browser change", - "credit card info browser edit", - "credit card info browser manage", - "credit card info browser save", - "credit card info browser update", - "credit card info change", - "credit card info change browser", - "credit card info change chrome", - "credit card info change google chrome", - "credit card info chrome change", - "credit card info chrome edit", - "credit card info chrome manage", - "credit card info chrome save", - "credit card info chrome update", - "credit card info edit", - "credit card info edit browser", - "credit card info edit chrome", - "credit card info edit google chrome", - "credit card info google chrome change", - "credit card info google chrome edit", - "credit card info google chrome manage", - "credit card info google chrome save", - "credit card info google chrome update", - "credit card info manage", - "credit card info manage browser", - "credit card info manage chrome", - "credit card info manage google chrome", - "credit card info save", - "credit card info save browser", - "credit card info save chrome", - "credit card info save google chrome", - "credit card info update", - "credit card info update browser", - "credit card info update chrome", - "credit card info update google chrome", - "credit card information browser change", - "credit card information browser edit", - "credit card information browser manage", - "credit card information browser save", - "credit card information browser update", - "credit card information change", - "credit card information change browser", - "credit card information change chrome", - "credit card information change google chrome", - "credit card information chrome change", - "credit card information chrome edit", - "credit card information chrome manage", - "credit card information chrome save", - "credit card information chrome update", - "credit card information edit", - "credit card information edit browser", - "credit card information edit chrome", - "credit card information edit google chrome", - "credit card information google chrome change", - "credit card information google chrome edit", - "credit card information google chrome manage", - "credit card information google chrome save", - "credit card information google chrome update", - "credit card information manage", - "credit card information manage browser", - "credit card information manage chrome", - "credit card information manage google chrome", - "credit card information save", - "credit card information save browser", - "credit card information save chrome", - "credit card information save google chrome", - "credit card information update", - "credit card information update browser", - "credit card information update chrome", - "credit card information update google chrome", - "credit card manage", - "credit card manage browser", - "credit card manage chrome", - "credit card manage google chrome", - "credit card save", - "credit card save browser", - "credit card save chrome", - "credit card save google chrome", - "credit card update", - "credit card update browser", - "credit card update chrome", - "credit card update google chrome", - "credit cards browser change", - "credit cards browser edit", - "credit cards browser manage", - "credit cards browser save", - "credit cards browser update", - "credit cards change", - "credit cards change browser", - "credit cards change chrome", - "credit cards change google chrome", - "credit cards chrome change", - "credit cards chrome edit", - "credit cards chrome manage", - "credit cards chrome save", - "credit cards chrome update", - "credit cards edit", - "credit cards edit browser", - "credit cards edit chrome", - "credit cards edit google chrome", - "credit cards google chrome change", - "credit cards google chrome edit", - "credit cards google chrome manage", - "credit cards google chrome save", - "credit cards google chrome update", - "credit cards manage", - "credit cards manage browser", - "credit cards manage chrome", - "credit cards manage google chrome", - "credit cards save", - "credit cards save browser", - "credit cards save chrome", - "credit cards save google chrome", - "credit cards update", - "credit cards update browser", - "credit cards update chrome", - "credit cards update google chrome", - "edit browser card info", - "edit browser card information", - "edit browser cards", - "edit browser credit card", - "edit browser credit card info", - "edit browser credit card information", - "edit browser credit cards", - "edit browser payment", - "edit browser payment methods", - "edit browser payments", - "edit card info", - "edit card info browser", - "edit card info chrome", - "edit card info google chrome", - "edit card information", - "edit card information browser", - "edit card information chrome", - "edit card information google chrome", - "edit cards", - "edit cards browser", - "edit cards chrome", - "edit cards google chrome", - "edit chrome card info", - "edit chrome card information", - "edit chrome cards", - "edit chrome credit card", - "edit chrome credit card info", - "edit chrome credit card information", - "edit chrome credit cards", - "edit chrome payment", - "edit chrome payment methods", - "edit chrome payments", - "edit credit card", - "edit credit card browser", - "edit credit card chrome", - "edit credit card google chrome", - "edit credit card info", - "edit credit card info browser", - "edit credit card info chrome", - "edit credit card info google chrome", - "edit credit card information", - "edit credit card information browser", - "edit credit card information chrome", - "edit credit card information google chrome", - "edit credit cards", - "edit credit cards browser", - "edit credit cards chrome", - "edit credit cards google chrome", - "edit google chrome card info", - "edit google chrome card information", - "edit google chrome cards", - "edit google chrome credit card", - "edit google chrome credit card info", - "edit google chrome credit card information", - "edit google chrome credit cards", - "edit google chrome payment", - "edit google chrome payment methods", - "edit google chrome payments", - "edit payment", - "edit payment browser", - "edit payment chrome", - "edit payment google chrome", - "edit payment methods", - "edit payment methods browser", - "edit payment methods chrome", - "edit payment methods google chrome", - "edit payments", - "edit payments browser", - "edit payments chrome", - "edit payments google chrome", - "google chrome card info change", - "google chrome card info edit", - "google chrome card info manage", - "google chrome card info save", - "google chrome card info update", - "google chrome card information change", - "google chrome card information edit", - "google chrome card information manage", - "google chrome card information save", - "google chrome card information update", - "google chrome cards change", - "google chrome cards edit", - "google chrome cards manage", - "google chrome cards save", - "google chrome cards update", - "google chrome change card info", - "google chrome change card information", - "google chrome change cards", - "google chrome change credit card", - "google chrome change credit card info", - "google chrome change credit card information", - "google chrome change credit cards", - "google chrome change payment", - "google chrome change payment methods", - "google chrome change payments", - "google chrome credit card change", - "google chrome credit card edit", - "google chrome credit card info change", - "google chrome credit card info edit", - "google chrome credit card info manage", - "google chrome credit card info save", - "google chrome credit card info update", - "google chrome credit card information change", - "google chrome credit card information edit", - "google chrome credit card information manage", - "google chrome credit card information save", - "google chrome credit card information update", - "google chrome credit card manage", - "google chrome credit card save", - "google chrome credit card update", - "google chrome credit cards change", - "google chrome credit cards edit", - "google chrome credit cards manage", - "google chrome credit cards save", - "google chrome credit cards update", - "google chrome edit card info", - "google chrome edit card information", - "google chrome edit cards", - "google chrome edit credit card", - "google chrome edit credit card info", - "google chrome edit credit card information", - "google chrome edit credit cards", - "google chrome edit payment", - "google chrome edit payment methods", - "google chrome edit payments", - "google chrome manage card info", - "google chrome manage card information", - "google chrome manage cards", - "google chrome manage credit card", - "google chrome manage credit card info", - "google chrome manage credit card information", - "google chrome manage credit cards", - "google chrome manage payment", - "google chrome manage payment methods", - "google chrome manage payments", - "google chrome payment change", - "google chrome payment edit", - "google chrome payment manage", - "google chrome payment methods change", - "google chrome payment methods edit", - "google chrome payment methods manage", - "google chrome payment methods save", - "google chrome payment methods update", - "google chrome payment save", - "google chrome payment update", - "google chrome payments change", - "google chrome payments edit", - "google chrome payments manage", - "google chrome payments save", - "google chrome payments update", - "google chrome save card info", - "google chrome save card information", - "google chrome save cards", - "google chrome save credit card", - "google chrome save credit card info", - "google chrome save credit card information", - "google chrome save credit cards", - "google chrome save payment", - "google chrome save payment methods", - "google chrome save payments", - "google chrome update card info", - "google chrome update card information", - "google chrome update cards", - "google chrome update credit card", - "google chrome update credit card info", - "google chrome update credit card information", - "google chrome update credit cards", - "google chrome update payment", - "google chrome update payment methods", - "google chrome update payments", - "manage browser card info", - "manage browser card information", - "manage browser cards", - "manage browser credit card", - "manage browser credit card info", - "manage browser credit card information", - "manage browser credit cards", - "manage browser payment", - "manage browser payment methods", - "manage browser payments", - "manage card info", - "manage card info browser", - "manage card info chrome", - "manage card info google chrome", - "manage card information", - "manage card information browser", - "manage card information chrome", - "manage card information google chrome", - "manage cards", - "manage cards browser", - "manage cards chrome", - "manage cards google chrome", - "manage chrome card info", - "manage chrome card information", - "manage chrome cards", - "manage chrome credit card", - "manage chrome credit card info", - "manage chrome credit card information", - "manage chrome credit cards", - "manage chrome payment", - "manage chrome payment methods", - "manage chrome payments", - "manage credit card", - "manage credit card browser", - "manage credit card chrome", - "manage credit card google chrome", - "manage credit card info", - "manage credit card info browser", - "manage credit card info chrome", - "manage credit card info google chrome", - "manage credit card information", - "manage credit card information browser", - "manage credit card information chrome", - "manage credit card information google chrome", - "manage credit cards", - "manage credit cards browser", - "manage credit cards chrome", - "manage credit cards google chrome", - "manage google chrome card info", - "manage google chrome card information", - "manage google chrome cards", - "manage google chrome credit card", - "manage google chrome credit card info", - "manage google chrome credit card information", - "manage google chrome credit cards", - "manage google chrome payment", - "manage google chrome payment methods", - "manage google chrome payments", - "manage payment", - "manage payment browser", - "manage payment chrome", - "manage payment google chrome", - "manage payment methods", - "manage payment methods browser", - "manage payment methods chrome", - "manage payment methods google chrome", - "manage payments", - "manage payments browser", - "manage payments chrome", - "manage payments google chrome", - "payment browser change", - "payment browser edit", - "payment browser manage", - "payment browser save", - "payment browser update", - "payment change", - "payment change browser", - "payment change chrome", - "payment change google chrome", - "payment chrome change", - "payment chrome edit", - "payment chrome manage", - "payment chrome save", - "payment chrome update", - "payment edit", - "payment edit browser", - "payment edit chrome", - "payment edit google chrome", - "payment google chrome change", - "payment google chrome edit", - "payment google chrome manage", - "payment google chrome save", - "payment google chrome update", - "payment manage", - "payment manage browser", - "payment manage chrome", - "payment manage google chrome", - "payment methods browser change", - "payment methods browser edit", - "payment methods browser manage", - "payment methods browser save", - "payment methods browser update", - "payment methods change", - "payment methods change browser", - "payment methods change chrome", - "payment methods change google chrome", - "payment methods chrome change", - "payment methods chrome edit", - "payment methods chrome manage", - "payment methods chrome save", - "payment methods chrome update", - "payment methods edit", - "payment methods edit browser", - "payment methods edit chrome", - "payment methods edit google chrome", - "payment methods google chrome change", - "payment methods google chrome edit", - "payment methods google chrome manage", - "payment methods google chrome save", - "payment methods google chrome update", - "payment methods manage", - "payment methods manage browser", - "payment methods manage chrome", - "payment methods manage google chrome", - "payment methods save", - "payment methods save browser", - "payment methods save chrome", - "payment methods save google chrome", - "payment methods update", - "payment methods update browser", - "payment methods update chrome", - "payment methods update google chrome", - "payment save", - "payment save browser", - "payment save chrome", - "payment save google chrome", - "payment update", - "payment update browser", - "payment update chrome", - "payment update google chrome", - "payments browser change", - "payments browser edit", - "payments browser manage", - "payments browser save", - "payments browser update", - "payments change", - "payments change browser", - "payments change chrome", - "payments change google chrome", - "payments chrome change", - "payments chrome edit", - "payments chrome manage", - "payments chrome save", - "payments chrome update", - "payments edit", - "payments edit browser", - "payments edit chrome", - "payments edit google chrome", - "payments google chrome change", - "payments google chrome edit", - "payments google chrome manage", - "payments google chrome save", - "payments google chrome update", - "payments manage", - "payments manage browser", - "payments manage chrome", - "payments manage google chrome", - "payments save", - "payments save browser", - "payments save chrome", - "payments save google chrome", - "payments update", - "payments update browser", - "payments update chrome", - "payments update google chrome", - "save browser card info", - "save browser card information", - "save browser cards", - "save browser credit card", - "save browser credit card info", - "save browser credit card information", - "save browser credit cards", - "save browser payment", - "save browser payment methods", - "save browser payments", - "save card info", - "save card info browser", - "save card info chrome", - "save card info google chrome", - "save card information", - "save card information browser", - "save card information chrome", - "save card information google chrome", - "save cards", - "save cards browser", - "save cards chrome", - "save cards google chrome", - "save chrome card info", - "save chrome card information", - "save chrome cards", - "save chrome credit card", - "save chrome credit card info", - "save chrome credit card information", - "save chrome credit cards", - "save chrome payment", - "save chrome payment methods", - "save chrome payments", - "save credit card", - "save credit card browser", - "save credit card chrome", - "save credit card google chrome", - "save credit card info", - "save credit card info browser", - "save credit card info chrome", - "save credit card info google chrome", - "save credit card information", - "save credit card information browser", - "save credit card information chrome", - "save credit card information google chrome", - "save credit cards", - "save credit cards browser", - "save credit cards chrome", - "save credit cards google chrome", - "save google chrome card info", - "save google chrome card information", - "save google chrome cards", - "save google chrome credit card", - "save google chrome credit card info", - "save google chrome credit card information", - "save google chrome credit cards", - "save google chrome payment", - "save google chrome payment methods", - "save google chrome payments", - "save payment", - "save payment browser", - "save payment chrome", - "save payment google chrome", - "save payment methods", - "save payment methods browser", - "save payment methods chrome", - "save payment methods google chrome", - "save payments", - "save payments browser", - "save payments chrome", - "save payments google chrome", - "update browser card info", - "update browser card information", - "update browser cards", - "update browser credit card", - "update browser credit card info", - "update browser credit card information", - "update browser credit cards", - "update browser payment", - "update browser payment methods", - "update browser payments", - "update card info", - "update card info browser", - "update card info chrome", - "update card info google chrome", - "update card information", - "update card information browser", - "update card information chrome", - "update card information google chrome", - "update cards", - "update cards browser", - "update cards chrome", - "update cards google chrome", - "update chrome card info", - "update chrome card information", - "update chrome cards", - "update chrome credit card", - "update chrome credit card info", - "update chrome credit card information", - "update chrome credit cards", - "update chrome payment", - "update chrome payment methods", - "update chrome payments", - "update credit card", - "update credit card browser", - "update credit card chrome", - "update credit card google chrome", - "update credit card info", - "update credit card info browser", - "update credit card info chrome", - "update credit card info google chrome", - "update credit card information", - "update credit card information browser", - "update credit card information chrome", - "update credit card information google chrome", - "update credit cards", - "update credit cards browser", - "update credit cards chrome", - "update credit cards google chrome", - "update google chrome card info", - "update google chrome card information", - "update google chrome cards", - "update google chrome credit card", - "update google chrome credit card info", - "update google chrome credit card information", - "update google chrome credit cards", - "update google chrome payment", - "update google chrome payment methods", - "update google chrome payments", - "update payment", - "update payment browser", - "update payment chrome", - "update payment google chrome", - "update payment methods", - "update payment methods browser", - "update payment methods chrome", - "update payment methods google chrome", - "update payments", - "update payments browser", - "update payments chrome", - "update payments google chrome", - }, - - // ID#4 - { - // Generated suggestions: - "browser create incognito", - "browser create incognito mode", - "browser create incognito tab", - "browser create incognito window", - "browser create private mode", - "browser create private tab", - "browser create private window", - "browser enter incognito", - "browser enter incognito mode", - "browser enter incognito tab", - "browser enter incognito window", - "browser enter private mode", - "browser enter private tab", - "browser enter private window", - "browser incognito", - "browser incognito create", - "browser incognito enter", - "browser incognito launch", - "browser incognito mode", - "browser incognito mode create", - "browser incognito mode enter", - "browser incognito mode launch", - "browser incognito mode open", - "browser incognito mode start", - "browser incognito open", - "browser incognito start", - "browser incognito tab", - "browser incognito tab create", - "browser incognito tab enter", - "browser incognito tab launch", - "browser incognito tab open", - "browser incognito tab start", - "browser incognito window", - "browser incognito window create", - "browser incognito window enter", - "browser incognito window launch", - "browser incognito window open", - "browser incognito window start", - "browser launch incognito", - "browser launch incognito mode", - "browser launch incognito tab", - "browser launch incognito window", - "browser launch private mode", - "browser launch private tab", - "browser launch private window", - "browser open incognito", - "browser open incognito mode", - "browser open incognito tab", - "browser open incognito window", - "browser open private mode", - "browser open private tab", - "browser open private window", - "browser private mode", - "browser private mode create", - "browser private mode enter", - "browser private mode launch", - "browser private mode open", - "browser private mode start", - "browser private tab", - "browser private tab create", - "browser private tab enter", - "browser private tab launch", - "browser private tab open", - "browser private tab start", - "browser private window", - "browser private window create", - "browser private window enter", - "browser private window launch", - "browser private window open", - "browser private window start", - "browser start incognito", - "browser start incognito mode", - "browser start incognito tab", - "browser start incognito window", - "browser start private mode", - "browser start private tab", - "browser start private window", - "chrome create incognito", - "chrome create incognito mode", - "chrome create incognito tab", - "chrome create incognito window", - "chrome create private mode", - "chrome create private tab", - "chrome create private window", - "chrome enter incognito", - "chrome enter incognito mode", - "chrome enter incognito tab", - "chrome enter incognito window", - "chrome enter private mode", - "chrome enter private tab", - "chrome enter private window", - "chrome incognito", - "chrome incognito create", - "chrome incognito enter", - "chrome incognito launch", - "chrome incognito mode", - "chrome incognito mode create", - "chrome incognito mode enter", - "chrome incognito mode launch", - "chrome incognito mode open", - "chrome incognito mode start", - "chrome incognito open", - "chrome incognito start", - "chrome incognito tab", - "chrome incognito tab create", - "chrome incognito tab enter", - "chrome incognito tab launch", - "chrome incognito tab open", - "chrome incognito tab start", - "chrome incognito window", - "chrome incognito window create", - "chrome incognito window enter", - "chrome incognito window launch", - "chrome incognito window open", - "chrome incognito window start", - "chrome launch incognito", - "chrome launch incognito mode", - "chrome launch incognito tab", - "chrome launch incognito window", - "chrome launch private mode", - "chrome launch private tab", - "chrome launch private window", - "chrome open incognito", - "chrome open incognito mode", - "chrome open incognito tab", - "chrome open incognito window", - "chrome open private mode", - "chrome open private tab", - "chrome open private window", - "chrome private mode", - "chrome private mode create", - "chrome private mode enter", - "chrome private mode launch", - "chrome private mode open", - "chrome private mode start", - "chrome private tab", - "chrome private tab create", - "chrome private tab enter", - "chrome private tab launch", - "chrome private tab open", - "chrome private tab start", - "chrome private window", - "chrome private window create", - "chrome private window enter", - "chrome private window launch", - "chrome private window open", - "chrome private window start", - "chrome start incognito", - "chrome start incognito mode", - "chrome start incognito tab", - "chrome start incognito window", - "chrome start private mode", - "chrome start private tab", - "chrome start private window", - "create browser incognito", - "create browser incognito mode", - "create browser incognito tab", - "create browser incognito window", - "create browser private mode", - "create browser private tab", - "create browser private window", - "create chrome incognito", - "create chrome incognito mode", - "create chrome incognito tab", - "create chrome incognito window", - "create chrome private mode", - "create chrome private tab", - "create chrome private window", - "create google chrome incognito", - "create google chrome incognito mode", - "create google chrome incognito tab", - "create google chrome incognito window", - "create google chrome private mode", - "create google chrome private tab", - "create google chrome private window", - "create incognito", - "create incognito browser", - "create incognito chrome", - "create incognito google chrome", - "create incognito mode", - "create incognito mode browser", - "create incognito mode chrome", - "create incognito mode google chrome", - "create incognito tab", - "create incognito tab browser", - "create incognito tab chrome", - "create incognito tab google chrome", - "create incognito window", - "create incognito window browser", - "create incognito window chrome", - "create incognito window google chrome", - "create private mode", - "create private mode browser", - "create private mode chrome", - "create private mode google chrome", - "create private tab", - "create private tab browser", - "create private tab chrome", - "create private tab google chrome", - "create private window", - "create private window browser", - "create private window chrome", - "create private window google chrome", - "enter browser incognito", - "enter browser incognito mode", - "enter browser incognito tab", - "enter browser incognito window", - "enter browser private mode", - "enter browser private tab", - "enter browser private window", - "enter chrome incognito", - "enter chrome incognito mode", - "enter chrome incognito tab", - "enter chrome incognito window", - "enter chrome private mode", - "enter chrome private tab", - "enter chrome private window", - "enter google chrome incognito", - "enter google chrome incognito mode", - "enter google chrome incognito tab", - "enter google chrome incognito window", - "enter google chrome private mode", - "enter google chrome private tab", - "enter google chrome private window", - "enter incognito", - "enter incognito browser", - "enter incognito chrome", - "enter incognito google chrome", - "enter incognito mode", - "enter incognito mode browser", - "enter incognito mode chrome", - "enter incognito mode google chrome", - "enter incognito tab", - "enter incognito tab browser", - "enter incognito tab chrome", - "enter incognito tab google chrome", - "enter incognito window", - "enter incognito window browser", - "enter incognito window chrome", - "enter incognito window google chrome", - "enter private mode", - "enter private mode browser", - "enter private mode chrome", - "enter private mode google chrome", - "enter private tab", - "enter private tab browser", - "enter private tab chrome", - "enter private tab google chrome", - "enter private window", - "enter private window browser", - "enter private window chrome", - "enter private window google chrome", - "google chrome create incognito", - "google chrome create incognito mode", - "google chrome create incognito tab", - "google chrome create incognito window", - "google chrome create private mode", - "google chrome create private tab", - "google chrome create private window", - "google chrome enter incognito", - "google chrome enter incognito mode", - "google chrome enter incognito tab", - "google chrome enter incognito window", - "google chrome enter private mode", - "google chrome enter private tab", - "google chrome enter private window", - "google chrome incognito", - "google chrome incognito create", - "google chrome incognito enter", - "google chrome incognito launch", - "google chrome incognito mode", - "google chrome incognito mode create", - "google chrome incognito mode enter", - "google chrome incognito mode launch", - "google chrome incognito mode open", - "google chrome incognito mode start", - "google chrome incognito open", - "google chrome incognito start", - "google chrome incognito tab", - "google chrome incognito tab create", - "google chrome incognito tab enter", - "google chrome incognito tab launch", - "google chrome incognito tab open", - "google chrome incognito tab start", - "google chrome incognito window", - "google chrome incognito window create", - "google chrome incognito window enter", - "google chrome incognito window launch", - "google chrome incognito window open", - "google chrome incognito window start", - "google chrome launch incognito", - "google chrome launch incognito mode", - "google chrome launch incognito tab", - "google chrome launch incognito window", - "google chrome launch private mode", - "google chrome launch private tab", - "google chrome launch private window", - "google chrome open incognito", - "google chrome open incognito mode", - "google chrome open incognito tab", - "google chrome open incognito window", - "google chrome open private mode", - "google chrome open private tab", - "google chrome open private window", - "google chrome private mode", - "google chrome private mode create", - "google chrome private mode enter", - "google chrome private mode launch", - "google chrome private mode open", - "google chrome private mode start", - "google chrome private tab", - "google chrome private tab create", - "google chrome private tab enter", - "google chrome private tab launch", - "google chrome private tab open", - "google chrome private tab start", - "google chrome private window", - "google chrome private window create", - "google chrome private window enter", - "google chrome private window launch", - "google chrome private window open", - "google chrome private window start", - "google chrome start incognito", - "google chrome start incognito mode", - "google chrome start incognito tab", - "google chrome start incognito window", - "google chrome start private mode", - "google chrome start private tab", - "google chrome start private window", - "incognito", - "incognito browser", - "incognito browser create", - "incognito browser enter", - "incognito browser launch", - "incognito browser open", - "incognito browser start", - "incognito chrome", - "incognito chrome create", - "incognito chrome enter", - "incognito chrome launch", - "incognito chrome open", - "incognito chrome start", - "incognito create", - "incognito create browser", - "incognito create chrome", - "incognito create google chrome", - "incognito enter", - "incognito enter browser", - "incognito enter chrome", - "incognito enter google chrome", - "incognito google chrome", - "incognito google chrome create", - "incognito google chrome enter", - "incognito google chrome launch", - "incognito google chrome open", - "incognito google chrome start", - "incognito launch", - "incognito launch browser", - "incognito launch chrome", - "incognito launch google chrome", - "incognito mode", - "incognito mode browser", - "incognito mode browser create", - "incognito mode browser enter", - "incognito mode browser launch", - "incognito mode browser open", - "incognito mode browser start", - "incognito mode chrome", - "incognito mode chrome create", - "incognito mode chrome enter", - "incognito mode chrome launch", - "incognito mode chrome open", - "incognito mode chrome start", - "incognito mode create", - "incognito mode create browser", - "incognito mode create chrome", - "incognito mode create google chrome", - "incognito mode enter", - "incognito mode enter browser", - "incognito mode enter chrome", - "incognito mode enter google chrome", - "incognito mode google chrome", - "incognito mode google chrome create", - "incognito mode google chrome enter", - "incognito mode google chrome launch", - "incognito mode google chrome open", - "incognito mode google chrome start", - "incognito mode launch", - "incognito mode launch browser", - "incognito mode launch chrome", - "incognito mode launch google chrome", - "incognito mode open", - "incognito mode open browser", - "incognito mode open chrome", - "incognito mode open google chrome", - "incognito mode start", - "incognito mode start browser", - "incognito mode start chrome", - "incognito mode start google chrome", - "incognito open", - "incognito open browser", - "incognito open chrome", - "incognito open google chrome", - "incognito start", - "incognito start browser", - "incognito start chrome", - "incognito start google chrome", - "incognito tab", - "incognito tab browser", - "incognito tab browser create", - "incognito tab browser enter", - "incognito tab browser launch", - "incognito tab browser open", - "incognito tab browser start", - "incognito tab chrome", - "incognito tab chrome create", - "incognito tab chrome enter", - "incognito tab chrome launch", - "incognito tab chrome open", - "incognito tab chrome start", - "incognito tab create", - "incognito tab create browser", - "incognito tab create chrome", - "incognito tab create google chrome", - "incognito tab enter", - "incognito tab enter browser", - "incognito tab enter chrome", - "incognito tab enter google chrome", - "incognito tab google chrome", - "incognito tab google chrome create", - "incognito tab google chrome enter", - "incognito tab google chrome launch", - "incognito tab google chrome open", - "incognito tab google chrome start", - "incognito tab launch", - "incognito tab launch browser", - "incognito tab launch chrome", - "incognito tab launch google chrome", - "incognito tab open", - "incognito tab open browser", - "incognito tab open chrome", - "incognito tab open google chrome", - "incognito tab start", - "incognito tab start browser", - "incognito tab start chrome", - "incognito tab start google chrome", - "incognito window", - "incognito window browser", - "incognito window browser create", - "incognito window browser enter", - "incognito window browser launch", - "incognito window browser open", - "incognito window browser start", - "incognito window chrome", - "incognito window chrome create", - "incognito window chrome enter", - "incognito window chrome launch", - "incognito window chrome open", - "incognito window chrome start", - "incognito window create", - "incognito window create browser", - "incognito window create chrome", - "incognito window create google chrome", - "incognito window enter", - "incognito window enter browser", - "incognito window enter chrome", - "incognito window enter google chrome", - "incognito window google chrome", - "incognito window google chrome create", - "incognito window google chrome enter", - "incognito window google chrome launch", - "incognito window google chrome open", - "incognito window google chrome start", - "incognito window launch", - "incognito window launch browser", - "incognito window launch chrome", - "incognito window launch google chrome", - "incognito window open", - "incognito window open browser", - "incognito window open chrome", - "incognito window open google chrome", - "incognito window start", - "incognito window start browser", - "incognito window start chrome", - "incognito window start google chrome", - "launch browser incognito", - "launch browser incognito mode", - "launch browser incognito tab", - "launch browser incognito window", - "launch browser private mode", - "launch browser private tab", - "launch browser private window", - "launch chrome incognito", - "launch chrome incognito mode", - "launch chrome incognito tab", - "launch chrome incognito window", - "launch chrome private mode", - "launch chrome private tab", - "launch chrome private window", - "launch google chrome incognito", - "launch google chrome incognito mode", - "launch google chrome incognito tab", - "launch google chrome incognito window", - "launch google chrome private mode", - "launch google chrome private tab", - "launch google chrome private window", - "launch incognito", - "launch incognito browser", - "launch incognito chrome", - "launch incognito google chrome", - "launch incognito mode", - "launch incognito mode browser", - "launch incognito mode chrome", - "launch incognito mode google chrome", - "launch incognito tab", - "launch incognito tab browser", - "launch incognito tab chrome", - "launch incognito tab google chrome", - "launch incognito window", - "launch incognito window browser", - "launch incognito window chrome", - "launch incognito window google chrome", - "launch private mode", - "launch private mode browser", - "launch private mode chrome", - "launch private mode google chrome", - "launch private tab", - "launch private tab browser", - "launch private tab chrome", - "launch private tab google chrome", - "launch private window", - "launch private window browser", - "launch private window chrome", - "launch private window google chrome", - "open browser incognito", - "open browser incognito mode", - "open browser incognito tab", - "open browser incognito window", - "open browser private mode", - "open browser private tab", - "open browser private window", - "open chrome incognito", - "open chrome incognito mode", - "open chrome incognito tab", - "open chrome incognito window", - "open chrome private mode", - "open chrome private tab", - "open chrome private window", - "open google chrome incognito", - "open google chrome incognito mode", - "open google chrome incognito tab", - "open google chrome incognito window", - "open google chrome private mode", - "open google chrome private tab", - "open google chrome private window", - "open incognito", - "open incognito browser", - "open incognito chrome", - "open incognito google chrome", - "open incognito mode", - "open incognito mode browser", - "open incognito mode chrome", - "open incognito mode google chrome", - "open incognito tab", - "open incognito tab browser", - "open incognito tab chrome", - "open incognito tab google chrome", - "open incognito window", - "open incognito window browser", - "open incognito window chrome", - "open incognito window google chrome", - "open private mode", - "open private mode browser", - "open private mode chrome", - "open private mode google chrome", - "open private tab", - "open private tab browser", - "open private tab chrome", - "open private tab google chrome", - "open private window", - "open private window browser", - "open private window chrome", - "open private window google chrome", - "private mode", - "private mode browser", - "private mode browser create", - "private mode browser enter", - "private mode browser launch", - "private mode browser open", - "private mode browser start", - "private mode chrome", - "private mode chrome create", - "private mode chrome enter", - "private mode chrome launch", - "private mode chrome open", - "private mode chrome start", - "private mode create", - "private mode create browser", - "private mode create chrome", - "private mode create google chrome", - "private mode enter", - "private mode enter browser", - "private mode enter chrome", - "private mode enter google chrome", - "private mode google chrome", - "private mode google chrome create", - "private mode google chrome enter", - "private mode google chrome launch", - "private mode google chrome open", - "private mode google chrome start", - "private mode launch", - "private mode launch browser", - "private mode launch chrome", - "private mode launch google chrome", - "private mode open", - "private mode open browser", - "private mode open chrome", - "private mode open google chrome", - "private mode start", - "private mode start browser", - "private mode start chrome", - "private mode start google chrome", - "private tab", - "private tab browser", - "private tab browser create", - "private tab browser enter", - "private tab browser launch", - "private tab browser open", - "private tab browser start", - "private tab chrome", - "private tab chrome create", - "private tab chrome enter", - "private tab chrome launch", - "private tab chrome open", - "private tab chrome start", - "private tab create", - "private tab create browser", - "private tab create chrome", - "private tab create google chrome", - "private tab enter", - "private tab enter browser", - "private tab enter chrome", - "private tab enter google chrome", - "private tab google chrome", - "private tab google chrome create", - "private tab google chrome enter", - "private tab google chrome launch", - "private tab google chrome open", - "private tab google chrome start", - "private tab launch", - "private tab launch browser", - "private tab launch chrome", - "private tab launch google chrome", - "private tab open", - "private tab open browser", - "private tab open chrome", - "private tab open google chrome", - "private tab start", - "private tab start browser", - "private tab start chrome", - "private tab start google chrome", - "private window", - "private window browser", - "private window browser create", - "private window browser enter", - "private window browser launch", - "private window browser open", - "private window browser start", - "private window chrome", - "private window chrome create", - "private window chrome enter", - "private window chrome launch", - "private window chrome open", - "private window chrome start", - "private window create", - "private window create browser", - "private window create chrome", - "private window create google chrome", - "private window enter", - "private window enter browser", - "private window enter chrome", - "private window enter google chrome", - "private window google chrome", - "private window google chrome create", - "private window google chrome enter", - "private window google chrome launch", - "private window google chrome open", - "private window google chrome start", - "private window launch", - "private window launch browser", - "private window launch chrome", - "private window launch google chrome", - "private window open", - "private window open browser", - "private window open chrome", - "private window open google chrome", - "private window start", - "private window start browser", - "private window start chrome", - "private window start google chrome", - "start browser incognito", - "start browser incognito mode", - "start browser incognito tab", - "start browser incognito window", - "start browser private mode", - "start browser private tab", - "start browser private window", - "start chrome incognito", - "start chrome incognito mode", - "start chrome incognito tab", - "start chrome incognito window", - "start chrome private mode", - "start chrome private tab", - "start chrome private window", - "start google chrome incognito", - "start google chrome incognito mode", - "start google chrome incognito tab", - "start google chrome incognito window", - "start google chrome private mode", - "start google chrome private tab", - "start google chrome private window", - "start incognito", - "start incognito browser", - "start incognito chrome", - "start incognito google chrome", - "start incognito mode", - "start incognito mode browser", - "start incognito mode chrome", - "start incognito mode google chrome", - "start incognito tab", - "start incognito tab browser", - "start incognito tab chrome", - "start incognito tab google chrome", - "start incognito window", - "start incognito window browser", - "start incognito window chrome", - "start incognito window google chrome", - "start private mode", - "start private mode browser", - "start private mode chrome", - "start private mode google chrome", - "start private tab", - "start private tab browser", - "start private tab chrome", - "start private tab google chrome", - "start private window", - "start private window browser", - "start private window chrome", - "start private window google chrome", - }, - - // ID#5 - { - // Generated suggestions: - "browser change language page", - "browser change language this", - "browser change language this page", - "browser change language web page", - "browser change language webpage", - "browser page change language", - "browser page translate", - "browser this change language", - "browser this page change language", - "browser this page translate", - "browser this translate", - "browser translate page", - "browser translate this", - "browser translate this page", - "browser translate web page", - "browser translate webpage", - "browser web page change language", - "browser web page translate", - "browser webpage change language", - "browser webpage translate", - "change language browser page", - "change language browser this", - "change language browser this page", - "change language browser web page", - "change language browser webpage", - "change language chrome page", - "change language chrome this", - "change language chrome this page", - "change language chrome web page", - "change language chrome webpage", - "change language google chrome page", - "change language google chrome this", - "change language google chrome this page", - "change language google chrome web page", - "change language google chrome webpage", - "change language page", - "change language page browser", - "change language page chrome", - "change language page google chrome", - "change language this", - "change language this browser", - "change language this chrome", - "change language this google chrome", - "change language this page", - "change language this page browser", - "change language this page chrome", - "change language this page google chrome", - "change language web page", - "change language web page browser", - "change language web page chrome", - "change language web page google chrome", - "change language webpage", - "change language webpage browser", - "change language webpage chrome", - "change language webpage google chrome", - "chrome change language page", - "chrome change language this", - "chrome change language this page", - "chrome change language web page", - "chrome change language webpage", - "chrome page change language", - "chrome page translate", - "chrome this change language", - "chrome this page change language", - "chrome this page translate", - "chrome this translate", - "chrome translate page", - "chrome translate this", - "chrome translate this page", - "chrome translate web page", - "chrome translate webpage", - "chrome web page change language", - "chrome web page translate", - "chrome webpage change language", - "chrome webpage translate", - "google chrome change language page", - "google chrome change language this", - "google chrome change language this page", - "google chrome change language web page", - "google chrome change language webpage", - "google chrome page change language", - "google chrome page translate", - "google chrome this change language", - "google chrome this page change language", - "google chrome this page translate", - "google chrome this translate", - "google chrome translate page", - "google chrome translate this", - "google chrome translate this page", - "google chrome translate web page", - "google chrome translate webpage", - "google chrome web page change language", - "google chrome web page translate", - "google chrome webpage change language", - "google chrome webpage translate", - "page browser change language", - "page browser translate", - "page change language", - "page change language browser", - "page change language chrome", - "page change language google chrome", - "page chrome change language", - "page chrome translate", - "page google chrome change language", - "page google chrome translate", - "page translate", - "page translate browser", - "page translate chrome", - "page translate google chrome", - "this browser change language", - "this browser translate", - "this change language", - "this change language browser", - "this change language chrome", - "this change language google chrome", - "this chrome change language", - "this chrome translate", - "this google chrome change language", - "this google chrome translate", - "this page browser change language", - "this page browser translate", - "this page change language", - "this page change language browser", - "this page change language chrome", - "this page change language google chrome", - "this page chrome change language", - "this page chrome translate", - "this page google chrome change language", - "this page google chrome translate", - "this page translate", - "this page translate browser", - "this page translate chrome", - "this page translate google chrome", - "this translate", - "this translate browser", - "this translate chrome", - "this translate google chrome", - "translate browser page", - "translate browser this", - "translate browser this page", - "translate browser web page", - "translate browser webpage", - "translate chrome page", - "translate chrome this", - "translate chrome this page", - "translate chrome web page", - "translate chrome webpage", - "translate google chrome page", - "translate google chrome this", - "translate google chrome this page", - "translate google chrome web page", - "translate google chrome webpage", - "translate page", - "translate page browser", - "translate page chrome", - "translate page google chrome", - "translate this", - "translate this browser", - "translate this chrome", - "translate this google chrome", - "translate this page", - "translate this page browser", - "translate this page chrome", - "translate this page google chrome", - "translate web page", - "translate web page browser", - "translate web page chrome", - "translate web page google chrome", - "translate webpage", - "translate webpage browser", - "translate webpage chrome", - "translate webpage google chrome", - "web page browser change language", - "web page browser translate", - "web page change language", - "web page change language browser", - "web page change language chrome", - "web page change language google chrome", - "web page chrome change language", - "web page chrome translate", - "web page google chrome change language", - "web page google chrome translate", - "web page translate", - "web page translate browser", - "web page translate chrome", - "web page translate google chrome", - "webpage browser change language", - "webpage browser translate", - "webpage change language", - "webpage change language browser", - "webpage change language chrome", - "webpage change language google chrome", - "webpage chrome change language", - "webpage chrome translate", - "webpage google chrome change language", - "webpage google chrome translate", - "webpage translate", - "webpage translate browser", - "webpage translate chrome", - "webpage translate google chrome", - }, - - // ID#6 - { - // Generated suggestions: - "browser install", - "browser update", - "browser updates", - "browser upgrade", - "chrome install", - "chrome update", - "chrome updates", - "chrome upgrade", - "google chrome install", - "google chrome update", - "google chrome updates", - "google chrome upgrade", - "install browser", - "install chrome", - "install google chrome", - "update browser", - "update chrome", - "update google chrome", - "updates browser", - "updates chrome", - "updates google chrome", - "upgrade browser", - "upgrade chrome", - "upgrade google chrome", - }, - - // ID#7 - { - // Generated suggestions: - "activate browser check password", - "activate browser check passwords", - "activate browser check safety", - "activate browser check security", - "activate browser checks password", - "activate browser checks passwords", - "activate browser checks safety", - "activate browser checks security", - "activate browser checkup password", - "activate browser checkup passwords", - "activate browser checkup safety", - "activate browser checkup security", - "activate browser password check", - "activate browser password checks", - "activate browser password checkup", - "activate browser passwords check", - "activate browser passwords checks", - "activate browser passwords checkup", - "activate browser safety check", - "activate browser safety checks", - "activate browser safety checkup", - "activate browser security check", - "activate browser security checks", - "activate browser security checkup", - "activate check browser password", - "activate check browser passwords", - "activate check browser safety", - "activate check browser security", - "activate check chrome password", - "activate check chrome passwords", - "activate check chrome safety", - "activate check chrome security", - "activate check google chrome password", - "activate check google chrome passwords", - "activate check google chrome safety", - "activate check google chrome security", - "activate check google password", - "activate check google passwords", - "activate check google safety", - "activate check google security", - "activate check password", - "activate check password browser", - "activate check password chrome", - "activate check password google", - "activate check password google chrome", - "activate check passwords", - "activate check passwords browser", - "activate check passwords chrome", - "activate check passwords google", - "activate check passwords google chrome", - "activate check safety", - "activate check safety browser", - "activate check safety chrome", - "activate check safety google", - "activate check safety google chrome", - "activate check security", - "activate check security browser", - "activate check security chrome", - "activate check security google", - "activate check security google chrome", - "activate checks browser password", - "activate checks browser passwords", - "activate checks browser safety", - "activate checks browser security", - "activate checks chrome password", - "activate checks chrome passwords", - "activate checks chrome safety", - "activate checks chrome security", - "activate checks google chrome password", - "activate checks google chrome passwords", - "activate checks google chrome safety", - "activate checks google chrome security", - "activate checks google password", - "activate checks google passwords", - "activate checks google safety", - "activate checks google security", - "activate checks password", - "activate checks password browser", - "activate checks password chrome", - "activate checks password google", - "activate checks password google chrome", - "activate checks passwords", - "activate checks passwords browser", - "activate checks passwords chrome", - "activate checks passwords google", - "activate checks passwords google chrome", - "activate checks safety", - "activate checks safety browser", - "activate checks safety chrome", - "activate checks safety google", - "activate checks safety google chrome", - "activate checks security", - "activate checks security browser", - "activate checks security chrome", - "activate checks security google", - "activate checks security google chrome", - "activate checkup browser password", - "activate checkup browser passwords", - "activate checkup browser safety", - "activate checkup browser security", - "activate checkup chrome password", - "activate checkup chrome passwords", - "activate checkup chrome safety", - "activate checkup chrome security", - "activate checkup google chrome password", - "activate checkup google chrome passwords", - "activate checkup google chrome safety", - "activate checkup google chrome security", - "activate checkup google password", - "activate checkup google passwords", - "activate checkup google safety", - "activate checkup google security", - "activate checkup password", - "activate checkup password browser", - "activate checkup password chrome", - "activate checkup password google", - "activate checkup password google chrome", - "activate checkup passwords", - "activate checkup passwords browser", - "activate checkup passwords chrome", - "activate checkup passwords google", - "activate checkup passwords google chrome", - "activate checkup safety", - "activate checkup safety browser", - "activate checkup safety chrome", - "activate checkup safety google", - "activate checkup safety google chrome", - "activate checkup security", - "activate checkup security browser", - "activate checkup security chrome", - "activate checkup security google", - "activate checkup security google chrome", - "activate chrome check password", - "activate chrome check passwords", - "activate chrome check safety", - "activate chrome check security", - "activate chrome checks password", - "activate chrome checks passwords", - "activate chrome checks safety", - "activate chrome checks security", - "activate chrome checkup password", - "activate chrome checkup passwords", - "activate chrome checkup safety", - "activate chrome checkup security", - "activate chrome password check", - "activate chrome password checks", - "activate chrome password checkup", - "activate chrome passwords check", - "activate chrome passwords checks", - "activate chrome passwords checkup", - "activate chrome safety check", - "activate chrome safety checks", - "activate chrome safety checkup", - "activate chrome security check", - "activate chrome security checks", - "activate chrome security checkup", - "activate google check password", - "activate google check passwords", - "activate google check safety", - "activate google check security", - "activate google checks password", - "activate google checks passwords", - "activate google checks safety", - "activate google checks security", - "activate google checkup password", - "activate google checkup passwords", - "activate google checkup safety", - "activate google checkup security", - "activate google chrome check password", - "activate google chrome check passwords", - "activate google chrome check safety", - "activate google chrome check security", - "activate google chrome checks password", - "activate google chrome checks passwords", - "activate google chrome checks safety", - "activate google chrome checks security", - "activate google chrome checkup password", - "activate google chrome checkup passwords", - "activate google chrome checkup safety", - "activate google chrome checkup security", - "activate google chrome password check", - "activate google chrome password checks", - "activate google chrome password checkup", - "activate google chrome passwords check", - "activate google chrome passwords checks", - "activate google chrome passwords checkup", - "activate google chrome safety check", - "activate google chrome safety checks", - "activate google chrome safety checkup", - "activate google chrome security check", - "activate google chrome security checks", - "activate google chrome security checkup", - "activate google password check", - "activate google password checks", - "activate google password checkup", - "activate google passwords check", - "activate google passwords checks", - "activate google passwords checkup", - "activate google safety check", - "activate google safety checks", - "activate google safety checkup", - "activate google security check", - "activate google security checks", - "activate google security checkup", - "activate password browser check", - "activate password browser checks", - "activate password browser checkup", - "activate password check", - "activate password check browser", - "activate password check chrome", - "activate password check google", - "activate password check google chrome", - "activate password checks", - "activate password checks browser", - "activate password checks chrome", - "activate password checks google", - "activate password checks google chrome", - "activate password checkup", - "activate password checkup browser", - "activate password checkup chrome", - "activate password checkup google", - "activate password checkup google chrome", - "activate password chrome check", - "activate password chrome checks", - "activate password chrome checkup", - "activate password google check", - "activate password google checks", - "activate password google checkup", - "activate password google chrome check", - "activate password google chrome checks", - "activate password google chrome checkup", - "activate passwords browser check", - "activate passwords browser checks", - "activate passwords browser checkup", - "activate passwords check", - "activate passwords check browser", - "activate passwords check chrome", - "activate passwords check google", - "activate passwords check google chrome", - "activate passwords checks", - "activate passwords checks browser", - "activate passwords checks chrome", - "activate passwords checks google", - "activate passwords checks google chrome", - "activate passwords checkup", - "activate passwords checkup browser", - "activate passwords checkup chrome", - "activate passwords checkup google", - "activate passwords checkup google chrome", - "activate passwords chrome check", - "activate passwords chrome checks", - "activate passwords chrome checkup", - "activate passwords google check", - "activate passwords google checks", - "activate passwords google checkup", - "activate passwords google chrome check", - "activate passwords google chrome checks", - "activate passwords google chrome checkup", - "activate safety browser check", - "activate safety browser checks", - "activate safety browser checkup", - "activate safety check", - "activate safety check browser", - "activate safety check chrome", - "activate safety check google", - "activate safety check google chrome", - "activate safety checks", - "activate safety checks browser", - "activate safety checks chrome", - "activate safety checks google", - "activate safety checks google chrome", - "activate safety checkup", - "activate safety checkup browser", - "activate safety checkup chrome", - "activate safety checkup google", - "activate safety checkup google chrome", - "activate safety chrome check", - "activate safety chrome checks", - "activate safety chrome checkup", - "activate safety google check", - "activate safety google checks", - "activate safety google checkup", - "activate safety google chrome check", - "activate safety google chrome checks", - "activate safety google chrome checkup", - "activate security browser check", - "activate security browser checks", - "activate security browser checkup", - "activate security check", - "activate security check browser", - "activate security check chrome", - "activate security check google", - "activate security check google chrome", - "activate security checks", - "activate security checks browser", - "activate security checks chrome", - "activate security checks google", - "activate security checks google chrome", - "activate security checkup", - "activate security checkup browser", - "activate security checkup chrome", - "activate security checkup google", - "activate security checkup google chrome", - "activate security chrome check", - "activate security chrome checks", - "activate security chrome checkup", - "activate security google check", - "activate security google checks", - "activate security google checkup", - "activate security google chrome check", - "activate security google chrome checks", - "activate security google chrome checkup", - "browser activate check password", - "browser activate check passwords", - "browser activate check safety", - "browser activate check security", - "browser activate checks password", - "browser activate checks passwords", - "browser activate checks safety", - "browser activate checks security", - "browser activate checkup password", - "browser activate checkup passwords", - "browser activate checkup safety", - "browser activate checkup security", - "browser activate password check", - "browser activate password checks", - "browser activate password checkup", - "browser activate passwords check", - "browser activate passwords checks", - "browser activate passwords checkup", - "browser activate safety check", - "browser activate safety checks", - "browser activate safety checkup", - "browser activate security check", - "browser activate security checks", - "browser activate security checkup", - "browser check activate password", - "browser check activate passwords", - "browser check activate safety", - "browser check activate security", - "browser check password", - "browser check password activate", - "browser check password perform", - "browser check password run", - "browser check password use", - "browser check passwords", - "browser check passwords activate", - "browser check passwords perform", - "browser check passwords run", - "browser check passwords use", - "browser check perform password", - "browser check perform passwords", - "browser check perform safety", - "browser check perform security", - "browser check run password", - "browser check run passwords", - "browser check run safety", - "browser check run security", - "browser check safety", - "browser check safety activate", - "browser check safety perform", - "browser check safety run", - "browser check safety use", - "browser check security", - "browser check security activate", - "browser check security perform", - "browser check security run", - "browser check security use", - "browser check use password", - "browser check use passwords", - "browser check use safety", - "browser check use security", - "browser checks activate password", - "browser checks activate passwords", - "browser checks activate safety", - "browser checks activate security", - "browser checks password", - "browser checks password activate", - "browser checks password perform", - "browser checks password run", - "browser checks password use", - "browser checks passwords", - "browser checks passwords activate", - "browser checks passwords perform", - "browser checks passwords run", - "browser checks passwords use", - "browser checks perform password", - "browser checks perform passwords", - "browser checks perform safety", - "browser checks perform security", - "browser checks run password", - "browser checks run passwords", - "browser checks run safety", - "browser checks run security", - "browser checks safety", - "browser checks safety activate", - "browser checks safety perform", - "browser checks safety run", - "browser checks safety use", - "browser checks security", - "browser checks security activate", - "browser checks security perform", - "browser checks security run", - "browser checks security use", - "browser checks use password", - "browser checks use passwords", - "browser checks use safety", - "browser checks use security", - "browser checkup activate password", - "browser checkup activate passwords", - "browser checkup activate safety", - "browser checkup activate security", - "browser checkup password", - "browser checkup password activate", - "browser checkup password perform", - "browser checkup password run", - "browser checkup password use", - "browser checkup passwords", - "browser checkup passwords activate", - "browser checkup passwords perform", - "browser checkup passwords run", - "browser checkup passwords use", - "browser checkup perform password", - "browser checkup perform passwords", - "browser checkup perform safety", - "browser checkup perform security", - "browser checkup run password", - "browser checkup run passwords", - "browser checkup run safety", - "browser checkup run security", - "browser checkup safety", - "browser checkup safety activate", - "browser checkup safety perform", - "browser checkup safety run", - "browser checkup safety use", - "browser checkup security", - "browser checkup security activate", - "browser checkup security perform", - "browser checkup security run", - "browser checkup security use", - "browser checkup use password", - "browser checkup use passwords", - "browser checkup use safety", - "browser checkup use security", - "browser password activate check", - "browser password activate checks", - "browser password activate checkup", - "browser password check", - "browser password check activate", - "browser password check perform", - "browser password check run", - "browser password check use", - "browser password checks", - "browser password checks activate", - "browser password checks perform", - "browser password checks run", - "browser password checks use", - "browser password checkup", - "browser password checkup activate", - "browser password checkup perform", - "browser password checkup run", - "browser password checkup use", - "browser password perform check", - "browser password perform checks", - "browser password perform checkup", - "browser password run check", - "browser password run checks", - "browser password run checkup", - "browser password use check", - "browser password use checks", - "browser password use checkup", - "browser passwords activate check", - "browser passwords activate checks", - "browser passwords activate checkup", - "browser passwords check", - "browser passwords check activate", - "browser passwords check perform", - "browser passwords check run", - "browser passwords check use", - "browser passwords checks", - "browser passwords checks activate", - "browser passwords checks perform", - "browser passwords checks run", - "browser passwords checks use", - "browser passwords checkup", - "browser passwords checkup activate", - "browser passwords checkup perform", - "browser passwords checkup run", - "browser passwords checkup use", - "browser passwords perform check", - "browser passwords perform checks", - "browser passwords perform checkup", - "browser passwords run check", - "browser passwords run checks", - "browser passwords run checkup", - "browser passwords use check", - "browser passwords use checks", - "browser passwords use checkup", - "browser perform check password", - "browser perform check passwords", - "browser perform check safety", - "browser perform check security", - "browser perform checks password", - "browser perform checks passwords", - "browser perform checks safety", - "browser perform checks security", - "browser perform checkup password", - "browser perform checkup passwords", - "browser perform checkup safety", - "browser perform checkup security", - "browser perform password check", - "browser perform password checks", - "browser perform password checkup", - "browser perform passwords check", - "browser perform passwords checks", - "browser perform passwords checkup", - "browser perform safety check", - "browser perform safety checks", - "browser perform safety checkup", - "browser perform security check", - "browser perform security checks", - "browser perform security checkup", - "browser run check password", - "browser run check passwords", - "browser run check safety", - "browser run check security", - "browser run checks password", - "browser run checks passwords", - "browser run checks safety", - "browser run checks security", - "browser run checkup password", - "browser run checkup passwords", - "browser run checkup safety", - "browser run checkup security", - "browser run password check", - "browser run password checks", - "browser run password checkup", - "browser run passwords check", - "browser run passwords checks", - "browser run passwords checkup", - "browser run safety check", - "browser run safety checks", - "browser run safety checkup", - "browser run security check", - "browser run security checks", - "browser run security checkup", - "browser safety activate check", - "browser safety activate checks", - "browser safety activate checkup", - "browser safety check", - "browser safety check activate", - "browser safety check perform", - "browser safety check run", - "browser safety check use", - "browser safety checks", - "browser safety checks activate", - "browser safety checks perform", - "browser safety checks run", - "browser safety checks use", - "browser safety checkup", - "browser safety checkup activate", - "browser safety checkup perform", - "browser safety checkup run", - "browser safety checkup use", - "browser safety perform check", - "browser safety perform checks", - "browser safety perform checkup", - "browser safety run check", - "browser safety run checks", - "browser safety run checkup", - "browser safety use check", - "browser safety use checks", - "browser safety use checkup", - "browser security activate check", - "browser security activate checks", - "browser security activate checkup", - "browser security check", - "browser security check activate", - "browser security check perform", - "browser security check run", - "browser security check use", - "browser security checks", - "browser security checks activate", - "browser security checks perform", - "browser security checks run", - "browser security checks use", - "browser security checkup", - "browser security checkup activate", - "browser security checkup perform", - "browser security checkup run", - "browser security checkup use", - "browser security perform check", - "browser security perform checks", - "browser security perform checkup", - "browser security run check", - "browser security run checks", - "browser security run checkup", - "browser security use check", - "browser security use checks", - "browser security use checkup", - "browser use check password", - "browser use check passwords", - "browser use check safety", - "browser use check security", - "browser use checks password", - "browser use checks passwords", - "browser use checks safety", - "browser use checks security", - "browser use checkup password", - "browser use checkup passwords", - "browser use checkup safety", - "browser use checkup security", - "browser use password check", - "browser use password checks", - "browser use password checkup", - "browser use passwords check", - "browser use passwords checks", - "browser use passwords checkup", - "browser use safety check", - "browser use safety checks", - "browser use safety checkup", - "browser use security check", - "browser use security checks", - "browser use security checkup", - "check activate browser password", - "check activate browser passwords", - "check activate browser safety", - "check activate browser security", - "check activate chrome password", - "check activate chrome passwords", - "check activate chrome safety", - "check activate chrome security", - "check activate google chrome password", - "check activate google chrome passwords", - "check activate google chrome safety", - "check activate google chrome security", - "check activate google password", - "check activate google passwords", - "check activate google safety", - "check activate google security", - "check activate password", - "check activate password browser", - "check activate password chrome", - "check activate password google", - "check activate password google chrome", - "check activate passwords", - "check activate passwords browser", - "check activate passwords chrome", - "check activate passwords google", - "check activate passwords google chrome", - "check activate safety", - "check activate safety browser", - "check activate safety chrome", - "check activate safety google", - "check activate safety google chrome", - "check activate security", - "check activate security browser", - "check activate security chrome", - "check activate security google", - "check activate security google chrome", - "check browser activate password", - "check browser activate passwords", - "check browser activate safety", - "check browser activate security", - "check browser password", - "check browser password activate", - "check browser password perform", - "check browser password run", - "check browser password use", - "check browser passwords", - "check browser passwords activate", - "check browser passwords perform", - "check browser passwords run", - "check browser passwords use", - "check browser perform password", - "check browser perform passwords", - "check browser perform safety", - "check browser perform security", - "check browser run password", - "check browser run passwords", - "check browser run safety", - "check browser run security", - "check browser safety", - "check browser safety activate", - "check browser safety perform", - "check browser safety run", - "check browser safety use", - "check browser security", - "check browser security activate", - "check browser security perform", - "check browser security run", - "check browser security use", - "check browser use password", - "check browser use passwords", - "check browser use safety", - "check browser use security", - "check chrome activate password", - "check chrome activate passwords", - "check chrome activate safety", - "check chrome activate security", - "check chrome password", - "check chrome password activate", - "check chrome password perform", - "check chrome password run", - "check chrome password use", - "check chrome passwords", - "check chrome passwords activate", - "check chrome passwords perform", - "check chrome passwords run", - "check chrome passwords use", - "check chrome perform password", - "check chrome perform passwords", - "check chrome perform safety", - "check chrome perform security", - "check chrome run password", - "check chrome run passwords", - "check chrome run safety", - "check chrome run security", - "check chrome safety", - "check chrome safety activate", - "check chrome safety perform", - "check chrome safety run", - "check chrome safety use", - "check chrome security", - "check chrome security activate", - "check chrome security perform", - "check chrome security run", - "check chrome security use", - "check chrome use password", - "check chrome use passwords", - "check chrome use safety", - "check chrome use security", - "check google activate password", - "check google activate passwords", - "check google activate safety", - "check google activate security", - "check google chrome activate password", - "check google chrome activate passwords", - "check google chrome activate safety", - "check google chrome activate security", - "check google chrome password", - "check google chrome password activate", - "check google chrome password perform", - "check google chrome password run", - "check google chrome password use", - "check google chrome passwords", - "check google chrome passwords activate", - "check google chrome passwords perform", - "check google chrome passwords run", - "check google chrome passwords use", - "check google chrome perform password", - "check google chrome perform passwords", - "check google chrome perform safety", - "check google chrome perform security", - "check google chrome run password", - "check google chrome run passwords", - "check google chrome run safety", - "check google chrome run security", - "check google chrome safety", - "check google chrome safety activate", - "check google chrome safety perform", - "check google chrome safety run", - "check google chrome safety use", - "check google chrome security", - "check google chrome security activate", - "check google chrome security perform", - "check google chrome security run", - "check google chrome security use", - "check google chrome use password", - "check google chrome use passwords", - "check google chrome use safety", - "check google chrome use security", - "check google password", - "check google password activate", - "check google password perform", - "check google password run", - "check google password use", - "check google passwords", - "check google passwords activate", - "check google passwords perform", - "check google passwords run", - "check google passwords use", - "check google perform password", - "check google perform passwords", - "check google perform safety", - "check google perform security", - "check google run password", - "check google run passwords", - "check google run safety", - "check google run security", - "check google safety", - "check google safety activate", - "check google safety perform", - "check google safety run", - "check google safety use", - "check google security", - "check google security activate", - "check google security perform", - "check google security run", - "check google security use", - "check google use password", - "check google use passwords", - "check google use safety", - "check google use security", - "check password", - "check password activate", - "check password activate browser", - "check password activate chrome", - "check password activate google", - "check password activate google chrome", - "check password browser", - "check password browser activate", - "check password browser perform", - "check password browser run", - "check password browser use", - "check password chrome", - "check password chrome activate", - "check password chrome perform", - "check password chrome run", - "check password chrome use", - "check password google", - "check password google activate", - "check password google chrome", - "check password google chrome activate", - "check password google chrome perform", - "check password google chrome run", - "check password google chrome use", - "check password google perform", - "check password google run", - "check password google use", - "check password perform", - "check password perform browser", - "check password perform chrome", - "check password perform google", - "check password perform google chrome", - "check password run", - "check password run browser", - "check password run chrome", - "check password run google", - "check password run google chrome", - "check password use", - "check password use browser", - "check password use chrome", - "check password use google", - "check password use google chrome", - "check passwords", - "check passwords activate", - "check passwords activate browser", - "check passwords activate chrome", - "check passwords activate google", - "check passwords activate google chrome", - "check passwords browser", - "check passwords browser activate", - "check passwords browser perform", - "check passwords browser run", - "check passwords browser use", - "check passwords chrome", - "check passwords chrome activate", - "check passwords chrome perform", - "check passwords chrome run", - "check passwords chrome use", - "check passwords google", - "check passwords google activate", - "check passwords google chrome", - "check passwords google chrome activate", - "check passwords google chrome perform", - "check passwords google chrome run", - "check passwords google chrome use", - "check passwords google perform", - "check passwords google run", - "check passwords google use", - "check passwords perform", - "check passwords perform browser", - "check passwords perform chrome", - "check passwords perform google", - "check passwords perform google chrome", - "check passwords run", - "check passwords run browser", - "check passwords run chrome", - "check passwords run google", - "check passwords run google chrome", - "check passwords use", - "check passwords use browser", - "check passwords use chrome", - "check passwords use google", - "check passwords use google chrome", - "check perform browser password", - "check perform browser passwords", - "check perform browser safety", - "check perform browser security", - "check perform chrome password", - "check perform chrome passwords", - "check perform chrome safety", - "check perform chrome security", - "check perform google chrome password", - "check perform google chrome passwords", - "check perform google chrome safety", - "check perform google chrome security", - "check perform google password", - "check perform google passwords", - "check perform google safety", - "check perform google security", - "check perform password", - "check perform password browser", - "check perform password chrome", - "check perform password google", - "check perform password google chrome", - "check perform passwords", - "check perform passwords browser", - "check perform passwords chrome", - "check perform passwords google", - "check perform passwords google chrome", - "check perform safety", - "check perform safety browser", - "check perform safety chrome", - "check perform safety google", - "check perform safety google chrome", - "check perform security", - "check perform security browser", - "check perform security chrome", - "check perform security google", - "check perform security google chrome", - "check run browser password", - "check run browser passwords", - "check run browser safety", - "check run browser security", - "check run chrome password", - "check run chrome passwords", - "check run chrome safety", - "check run chrome security", - "check run google chrome password", - "check run google chrome passwords", - "check run google chrome safety", - "check run google chrome security", - "check run google password", - "check run google passwords", - "check run google safety", - "check run google security", - "check run password", - "check run password browser", - "check run password chrome", - "check run password google", - "check run password google chrome", - "check run passwords", - "check run passwords browser", - "check run passwords chrome", - "check run passwords google", - "check run passwords google chrome", - "check run safety", - "check run safety browser", - "check run safety chrome", - "check run safety google", - "check run safety google chrome", - "check run security", - "check run security browser", - "check run security chrome", - "check run security google", - "check run security google chrome", - "check safety", - "check safety activate", - "check safety activate browser", - "check safety activate chrome", - "check safety activate google", - "check safety activate google chrome", - "check safety browser", - "check safety browser activate", - "check safety browser perform", - "check safety browser run", - "check safety browser use", - "check safety chrome", - "check safety chrome activate", - "check safety chrome perform", - "check safety chrome run", - "check safety chrome use", - "check safety google", - "check safety google activate", - "check safety google chrome", - "check safety google chrome activate", - "check safety google chrome perform", - "check safety google chrome run", - "check safety google chrome use", - "check safety google perform", - "check safety google run", - "check safety google use", - "check safety perform", - "check safety perform browser", - "check safety perform chrome", - "check safety perform google", - "check safety perform google chrome", - "check safety run", - "check safety run browser", - "check safety run chrome", - "check safety run google", - "check safety run google chrome", - "check safety use", - "check safety use browser", - "check safety use chrome", - "check safety use google", - "check safety use google chrome", - "check security", - "check security activate", - "check security activate browser", - "check security activate chrome", - "check security activate google", - "check security activate google chrome", - "check security browser", - "check security browser activate", - "check security browser perform", - "check security browser run", - "check security browser use", - "check security chrome", - "check security chrome activate", - "check security chrome perform", - "check security chrome run", - "check security chrome use", - "check security google", - "check security google activate", - "check security google chrome", - "check security google chrome activate", - "check security google chrome perform", - "check security google chrome run", - "check security google chrome use", - "check security google perform", - "check security google run", - "check security google use", - "check security perform", - "check security perform browser", - "check security perform chrome", - "check security perform google", - "check security perform google chrome", - "check security run", - "check security run browser", - "check security run chrome", - "check security run google", - "check security run google chrome", - "check security use", - "check security use browser", - "check security use chrome", - "check security use google", - "check security use google chrome", - "check use browser password", - "check use browser passwords", - "check use browser safety", - "check use browser security", - "check use chrome password", - "check use chrome passwords", - "check use chrome safety", - "check use chrome security", - "check use google chrome password", - "check use google chrome passwords", - "check use google chrome safety", - "check use google chrome security", - "check use google password", - "check use google passwords", - "check use google safety", - "check use google security", - "check use password", - "check use password browser", - "check use password chrome", - "check use password google", - "check use password google chrome", - "check use passwords", - "check use passwords browser", - "check use passwords chrome", - "check use passwords google", - "check use passwords google chrome", - "check use safety", - "check use safety browser", - "check use safety chrome", - "check use safety google", - "check use safety google chrome", - "check use security", - "check use security browser", - "check use security chrome", - "check use security google", - "check use security google chrome", - "checks activate browser password", - "checks activate browser passwords", - "checks activate browser safety", - "checks activate browser security", - "checks activate chrome password", - "checks activate chrome passwords", - "checks activate chrome safety", - "checks activate chrome security", - "checks activate google chrome password", - "checks activate google chrome passwords", - "checks activate google chrome safety", - "checks activate google chrome security", - "checks activate google password", - "checks activate google passwords", - "checks activate google safety", - "checks activate google security", - "checks activate password", - "checks activate password browser", - "checks activate password chrome", - "checks activate password google", - "checks activate password google chrome", - "checks activate passwords", - "checks activate passwords browser", - "checks activate passwords chrome", - "checks activate passwords google", - "checks activate passwords google chrome", - "checks activate safety", - "checks activate safety browser", - "checks activate safety chrome", - "checks activate safety google", - "checks activate safety google chrome", - "checks activate security", - "checks activate security browser", - "checks activate security chrome", - "checks activate security google", - "checks activate security google chrome", - "checks browser activate password", - "checks browser activate passwords", - "checks browser activate safety", - "checks browser activate security", - "checks browser password", - "checks browser password activate", - "checks browser password perform", - "checks browser password run", - "checks browser password use", - "checks browser passwords", - "checks browser passwords activate", - "checks browser passwords perform", - "checks browser passwords run", - "checks browser passwords use", - "checks browser perform password", - "checks browser perform passwords", - "checks browser perform safety", - "checks browser perform security", - "checks browser run password", - "checks browser run passwords", - "checks browser run safety", - "checks browser run security", - "checks browser safety", - "checks browser safety activate", - "checks browser safety perform", - "checks browser safety run", - "checks browser safety use", - "checks browser security", - "checks browser security activate", - "checks browser security perform", - "checks browser security run", - "checks browser security use", - "checks browser use password", - "checks browser use passwords", - "checks browser use safety", - "checks browser use security", - "checks chrome activate password", - "checks chrome activate passwords", - "checks chrome activate safety", - "checks chrome activate security", - "checks chrome password", - "checks chrome password activate", - "checks chrome password perform", - "checks chrome password run", - "checks chrome password use", - "checks chrome passwords", - "checks chrome passwords activate", - "checks chrome passwords perform", - "checks chrome passwords run", - "checks chrome passwords use", - "checks chrome perform password", - "checks chrome perform passwords", - "checks chrome perform safety", - "checks chrome perform security", - "checks chrome run password", - "checks chrome run passwords", - "checks chrome run safety", - "checks chrome run security", - "checks chrome safety", - "checks chrome safety activate", - "checks chrome safety perform", - "checks chrome safety run", - "checks chrome safety use", - "checks chrome security", - "checks chrome security activate", - "checks chrome security perform", - "checks chrome security run", - "checks chrome security use", - "checks chrome use password", - "checks chrome use passwords", - "checks chrome use safety", - "checks chrome use security", - "checks google activate password", - "checks google activate passwords", - "checks google activate safety", - "checks google activate security", - "checks google chrome activate password", - "checks google chrome activate passwords", - "checks google chrome activate safety", - "checks google chrome activate security", - "checks google chrome password", - "checks google chrome password activate", - "checks google chrome password perform", - "checks google chrome password run", - "checks google chrome password use", - "checks google chrome passwords", - "checks google chrome passwords activate", - "checks google chrome passwords perform", - "checks google chrome passwords run", - "checks google chrome passwords use", - "checks google chrome perform password", - "checks google chrome perform passwords", - "checks google chrome perform safety", - "checks google chrome perform security", - "checks google chrome run password", - "checks google chrome run passwords", - "checks google chrome run safety", - "checks google chrome run security", - "checks google chrome safety", - "checks google chrome safety activate", - "checks google chrome safety perform", - "checks google chrome safety run", - "checks google chrome safety use", - "checks google chrome security", - "checks google chrome security activate", - "checks google chrome security perform", - "checks google chrome security run", - "checks google chrome security use", - "checks google chrome use password", - "checks google chrome use passwords", - "checks google chrome use safety", - "checks google chrome use security", - "checks google password", - "checks google password activate", - "checks google password perform", - "checks google password run", - "checks google password use", - "checks google passwords", - "checks google passwords activate", - "checks google passwords perform", - "checks google passwords run", - "checks google passwords use", - "checks google perform password", - "checks google perform passwords", - "checks google perform safety", - "checks google perform security", - "checks google run password", - "checks google run passwords", - "checks google run safety", - "checks google run security", - "checks google safety", - "checks google safety activate", - "checks google safety perform", - "checks google safety run", - "checks google safety use", - "checks google security", - "checks google security activate", - "checks google security perform", - "checks google security run", - "checks google security use", - "checks google use password", - "checks google use passwords", - "checks google use safety", - "checks google use security", - "checks password", - "checks password activate", - "checks password activate browser", - "checks password activate chrome", - "checks password activate google", - "checks password activate google chrome", - "checks password browser", - "checks password browser activate", - "checks password browser perform", - "checks password browser run", - "checks password browser use", - "checks password chrome", - "checks password chrome activate", - "checks password chrome perform", - "checks password chrome run", - "checks password chrome use", - "checks password google", - "checks password google activate", - "checks password google chrome", - "checks password google chrome activate", - "checks password google chrome perform", - "checks password google chrome run", - "checks password google chrome use", - "checks password google perform", - "checks password google run", - "checks password google use", - "checks password perform", - "checks password perform browser", - "checks password perform chrome", - "checks password perform google", - "checks password perform google chrome", - "checks password run", - "checks password run browser", - "checks password run chrome", - "checks password run google", - "checks password run google chrome", - "checks password use", - "checks password use browser", - "checks password use chrome", - "checks password use google", - "checks password use google chrome", - "checks passwords", - "checks passwords activate", - "checks passwords activate browser", - "checks passwords activate chrome", - "checks passwords activate google", - "checks passwords activate google chrome", - "checks passwords browser", - "checks passwords browser activate", - "checks passwords browser perform", - "checks passwords browser run", - "checks passwords browser use", - "checks passwords chrome", - "checks passwords chrome activate", - "checks passwords chrome perform", - "checks passwords chrome run", - "checks passwords chrome use", - "checks passwords google", - "checks passwords google activate", - "checks passwords google chrome", - "checks passwords google chrome activate", - "checks passwords google chrome perform", - "checks passwords google chrome run", - "checks passwords google chrome use", - "checks passwords google perform", - "checks passwords google run", - "checks passwords google use", - "checks passwords perform", - "checks passwords perform browser", - "checks passwords perform chrome", - "checks passwords perform google", - "checks passwords perform google chrome", - "checks passwords run", - "checks passwords run browser", - "checks passwords run chrome", - "checks passwords run google", - "checks passwords run google chrome", - "checks passwords use", - "checks passwords use browser", - "checks passwords use chrome", - "checks passwords use google", - "checks passwords use google chrome", - "checks perform browser password", - "checks perform browser passwords", - "checks perform browser safety", - "checks perform browser security", - "checks perform chrome password", - "checks perform chrome passwords", - "checks perform chrome safety", - "checks perform chrome security", - "checks perform google chrome password", - "checks perform google chrome passwords", - "checks perform google chrome safety", - "checks perform google chrome security", - "checks perform google password", - "checks perform google passwords", - "checks perform google safety", - "checks perform google security", - "checks perform password", - "checks perform password browser", - "checks perform password chrome", - "checks perform password google", - "checks perform password google chrome", - "checks perform passwords", - "checks perform passwords browser", - "checks perform passwords chrome", - "checks perform passwords google", - "checks perform passwords google chrome", - "checks perform safety", - "checks perform safety browser", - "checks perform safety chrome", - "checks perform safety google", - "checks perform safety google chrome", - "checks perform security", - "checks perform security browser", - "checks perform security chrome", - "checks perform security google", - "checks perform security google chrome", - "checks run browser password", - "checks run browser passwords", - "checks run browser safety", - "checks run browser security", - "checks run chrome password", - "checks run chrome passwords", - "checks run chrome safety", - "checks run chrome security", - "checks run google chrome password", - "checks run google chrome passwords", - "checks run google chrome safety", - "checks run google chrome security", - "checks run google password", - "checks run google passwords", - "checks run google safety", - "checks run google security", - "checks run password", - "checks run password browser", - "checks run password chrome", - "checks run password google", - "checks run password google chrome", - "checks run passwords", - "checks run passwords browser", - "checks run passwords chrome", - "checks run passwords google", - "checks run passwords google chrome", - "checks run safety", - "checks run safety browser", - "checks run safety chrome", - "checks run safety google", - "checks run safety google chrome", - "checks run security", - "checks run security browser", - "checks run security chrome", - "checks run security google", - "checks run security google chrome", - "checks safety", - "checks safety activate", - "checks safety activate browser", - "checks safety activate chrome", - "checks safety activate google", - "checks safety activate google chrome", - "checks safety browser", - "checks safety browser activate", - "checks safety browser perform", - "checks safety browser run", - "checks safety browser use", - "checks safety chrome", - "checks safety chrome activate", - "checks safety chrome perform", - "checks safety chrome run", - "checks safety chrome use", - "checks safety google", - "checks safety google activate", - "checks safety google chrome", - "checks safety google chrome activate", - "checks safety google chrome perform", - "checks safety google chrome run", - "checks safety google chrome use", - "checks safety google perform", - "checks safety google run", - "checks safety google use", - "checks safety perform", - "checks safety perform browser", - "checks safety perform chrome", - "checks safety perform google", - "checks safety perform google chrome", - "checks safety run", - "checks safety run browser", - "checks safety run chrome", - "checks safety run google", - "checks safety run google chrome", - "checks safety use", - "checks safety use browser", - "checks safety use chrome", - "checks safety use google", - "checks safety use google chrome", - "checks security", - "checks security activate", - "checks security activate browser", - "checks security activate chrome", - "checks security activate google", - "checks security activate google chrome", - "checks security browser", - "checks security browser activate", - "checks security browser perform", - "checks security browser run", - "checks security browser use", - "checks security chrome", - "checks security chrome activate", - "checks security chrome perform", - "checks security chrome run", - "checks security chrome use", - "checks security google", - "checks security google activate", - "checks security google chrome", - "checks security google chrome activate", - "checks security google chrome perform", - "checks security google chrome run", - "checks security google chrome use", - "checks security google perform", - "checks security google run", - "checks security google use", - "checks security perform", - "checks security perform browser", - "checks security perform chrome", - "checks security perform google", - "checks security perform google chrome", - "checks security run", - "checks security run browser", - "checks security run chrome", - "checks security run google", - "checks security run google chrome", - "checks security use", - "checks security use browser", - "checks security use chrome", - "checks security use google", - "checks security use google chrome", - "checks use browser password", - "checks use browser passwords", - "checks use browser safety", - "checks use browser security", - "checks use chrome password", - "checks use chrome passwords", - "checks use chrome safety", - "checks use chrome security", - "checks use google chrome password", - "checks use google chrome passwords", - "checks use google chrome safety", - "checks use google chrome security", - "checks use google password", - "checks use google passwords", - "checks use google safety", - "checks use google security", - "checks use password", - "checks use password browser", - "checks use password chrome", - "checks use password google", - "checks use password google chrome", - "checks use passwords", - "checks use passwords browser", - "checks use passwords chrome", - "checks use passwords google", - "checks use passwords google chrome", - "checks use safety", - "checks use safety browser", - "checks use safety chrome", - "checks use safety google", - "checks use safety google chrome", - "checks use security", - "checks use security browser", - "checks use security chrome", - "checks use security google", - "checks use security google chrome", - "checkup activate browser password", - "checkup activate browser passwords", - "checkup activate browser safety", - "checkup activate browser security", - "checkup activate chrome password", - "checkup activate chrome passwords", - "checkup activate chrome safety", - "checkup activate chrome security", - "checkup activate google chrome password", - "checkup activate google chrome passwords", - "checkup activate google chrome safety", - "checkup activate google chrome security", - "checkup activate google password", - "checkup activate google passwords", - "checkup activate google safety", - "checkup activate google security", - "checkup activate password", - "checkup activate password browser", - "checkup activate password chrome", - "checkup activate password google", - "checkup activate password google chrome", - "checkup activate passwords", - "checkup activate passwords browser", - "checkup activate passwords chrome", - "checkup activate passwords google", - "checkup activate passwords google chrome", - "checkup activate safety", - "checkup activate safety browser", - "checkup activate safety chrome", - "checkup activate safety google", - "checkup activate safety google chrome", - "checkup activate security", - "checkup activate security browser", - "checkup activate security chrome", - "checkup activate security google", - "checkup activate security google chrome", - "checkup browser activate password", - "checkup browser activate passwords", - "checkup browser activate safety", - "checkup browser activate security", - "checkup browser password", - "checkup browser password activate", - "checkup browser password perform", - "checkup browser password run", - "checkup browser password use", - "checkup browser passwords", - "checkup browser passwords activate", - "checkup browser passwords perform", - "checkup browser passwords run", - "checkup browser passwords use", - "checkup browser perform password", - "checkup browser perform passwords", - "checkup browser perform safety", - "checkup browser perform security", - "checkup browser run password", - "checkup browser run passwords", - "checkup browser run safety", - "checkup browser run security", - "checkup browser safety", - "checkup browser safety activate", - "checkup browser safety perform", - "checkup browser safety run", - "checkup browser safety use", - "checkup browser security", - "checkup browser security activate", - "checkup browser security perform", - "checkup browser security run", - "checkup browser security use", - "checkup browser use password", - "checkup browser use passwords", - "checkup browser use safety", - "checkup browser use security", - "checkup chrome activate password", - "checkup chrome activate passwords", - "checkup chrome activate safety", - "checkup chrome activate security", - "checkup chrome password", - "checkup chrome password activate", - "checkup chrome password perform", - "checkup chrome password run", - "checkup chrome password use", - "checkup chrome passwords", - "checkup chrome passwords activate", - "checkup chrome passwords perform", - "checkup chrome passwords run", - "checkup chrome passwords use", - "checkup chrome perform password", - "checkup chrome perform passwords", - "checkup chrome perform safety", - "checkup chrome perform security", - "checkup chrome run password", - "checkup chrome run passwords", - "checkup chrome run safety", - "checkup chrome run security", - "checkup chrome safety", - "checkup chrome safety activate", - "checkup chrome safety perform", - "checkup chrome safety run", - "checkup chrome safety use", - "checkup chrome security", - "checkup chrome security activate", - "checkup chrome security perform", - "checkup chrome security run", - "checkup chrome security use", - "checkup chrome use password", - "checkup chrome use passwords", - "checkup chrome use safety", - "checkup chrome use security", - "checkup google activate password", - "checkup google activate passwords", - "checkup google activate safety", - "checkup google activate security", - "checkup google chrome activate password", - "checkup google chrome activate passwords", - "checkup google chrome activate safety", - "checkup google chrome activate security", - "checkup google chrome password", - "checkup google chrome password activate", - "checkup google chrome password perform", - "checkup google chrome password run", - "checkup google chrome password use", - "checkup google chrome passwords", - "checkup google chrome passwords activate", - "checkup google chrome passwords perform", - "checkup google chrome passwords run", - "checkup google chrome passwords use", - "checkup google chrome perform password", - "checkup google chrome perform passwords", - "checkup google chrome perform safety", - "checkup google chrome perform security", - "checkup google chrome run password", - "checkup google chrome run passwords", - "checkup google chrome run safety", - "checkup google chrome run security", - "checkup google chrome safety", - "checkup google chrome safety activate", - "checkup google chrome safety perform", - "checkup google chrome safety run", - "checkup google chrome safety use", - "checkup google chrome security", - "checkup google chrome security activate", - "checkup google chrome security perform", - "checkup google chrome security run", - "checkup google chrome security use", - "checkup google chrome use password", - "checkup google chrome use passwords", - "checkup google chrome use safety", - "checkup google chrome use security", - "checkup google password", - "checkup google password activate", - "checkup google password perform", - "checkup google password run", - "checkup google password use", - "checkup google passwords", - "checkup google passwords activate", - "checkup google passwords perform", - "checkup google passwords run", - "checkup google passwords use", - "checkup google perform password", - "checkup google perform passwords", - "checkup google perform safety", - "checkup google perform security", - "checkup google run password", - "checkup google run passwords", - "checkup google run safety", - "checkup google run security", - "checkup google safety", - "checkup google safety activate", - "checkup google safety perform", - "checkup google safety run", - "checkup google safety use", - "checkup google security", - "checkup google security activate", - "checkup google security perform", - "checkup google security run", - "checkup google security use", - "checkup google use password", - "checkup google use passwords", - "checkup google use safety", - "checkup google use security", - "checkup password", - "checkup password activate", - "checkup password activate browser", - "checkup password activate chrome", - "checkup password activate google", - "checkup password activate google chrome", - "checkup password browser", - "checkup password browser activate", - "checkup password browser perform", - "checkup password browser run", - "checkup password browser use", - "checkup password chrome", - "checkup password chrome activate", - "checkup password chrome perform", - "checkup password chrome run", - "checkup password chrome use", - "checkup password google", - "checkup password google activate", - "checkup password google chrome", - "checkup password google chrome activate", - "checkup password google chrome perform", - "checkup password google chrome run", - "checkup password google chrome use", - "checkup password google perform", - "checkup password google run", - "checkup password google use", - "checkup password perform", - "checkup password perform browser", - "checkup password perform chrome", - "checkup password perform google", - "checkup password perform google chrome", - "checkup password run", - "checkup password run browser", - "checkup password run chrome", - "checkup password run google", - "checkup password run google chrome", - "checkup password use", - "checkup password use browser", - "checkup password use chrome", - "checkup password use google", - "checkup password use google chrome", - "checkup passwords", - "checkup passwords activate", - "checkup passwords activate browser", - "checkup passwords activate chrome", - "checkup passwords activate google", - "checkup passwords activate google chrome", - "checkup passwords browser", - "checkup passwords browser activate", - "checkup passwords browser perform", - "checkup passwords browser run", - "checkup passwords browser use", - "checkup passwords chrome", - "checkup passwords chrome activate", - "checkup passwords chrome perform", - "checkup passwords chrome run", - "checkup passwords chrome use", - "checkup passwords google", - "checkup passwords google activate", - "checkup passwords google chrome", - "checkup passwords google chrome activate", - "checkup passwords google chrome perform", - "checkup passwords google chrome run", - "checkup passwords google chrome use", - "checkup passwords google perform", - "checkup passwords google run", - "checkup passwords google use", - "checkup passwords perform", - "checkup passwords perform browser", - "checkup passwords perform chrome", - "checkup passwords perform google", - "checkup passwords perform google chrome", - "checkup passwords run", - "checkup passwords run browser", - "checkup passwords run chrome", - "checkup passwords run google", - "checkup passwords run google chrome", - "checkup passwords use", - "checkup passwords use browser", - "checkup passwords use chrome", - "checkup passwords use google", - "checkup passwords use google chrome", - "checkup perform browser password", - "checkup perform browser passwords", - "checkup perform browser safety", - "checkup perform browser security", - "checkup perform chrome password", - "checkup perform chrome passwords", - "checkup perform chrome safety", - "checkup perform chrome security", - "checkup perform google chrome password", - "checkup perform google chrome passwords", - "checkup perform google chrome safety", - "checkup perform google chrome security", - "checkup perform google password", - "checkup perform google passwords", - "checkup perform google safety", - "checkup perform google security", - "checkup perform password", - "checkup perform password browser", - "checkup perform password chrome", - "checkup perform password google", - "checkup perform password google chrome", - "checkup perform passwords", - "checkup perform passwords browser", - "checkup perform passwords chrome", - "checkup perform passwords google", - "checkup perform passwords google chrome", - "checkup perform safety", - "checkup perform safety browser", - "checkup perform safety chrome", - "checkup perform safety google", - "checkup perform safety google chrome", - "checkup perform security", - "checkup perform security browser", - "checkup perform security chrome", - "checkup perform security google", - "checkup perform security google chrome", - "checkup run browser password", - "checkup run browser passwords", - "checkup run browser safety", - "checkup run browser security", - "checkup run chrome password", - "checkup run chrome passwords", - "checkup run chrome safety", - "checkup run chrome security", - "checkup run google chrome password", - "checkup run google chrome passwords", - "checkup run google chrome safety", - "checkup run google chrome security", - "checkup run google password", - "checkup run google passwords", - "checkup run google safety", - "checkup run google security", - "checkup run password", - "checkup run password browser", - "checkup run password chrome", - "checkup run password google", - "checkup run password google chrome", - "checkup run passwords", - "checkup run passwords browser", - "checkup run passwords chrome", - "checkup run passwords google", - "checkup run passwords google chrome", - "checkup run safety", - "checkup run safety browser", - "checkup run safety chrome", - "checkup run safety google", - "checkup run safety google chrome", - "checkup run security", - "checkup run security browser", - "checkup run security chrome", - "checkup run security google", - "checkup run security google chrome", - "checkup safety", - "checkup safety activate", - "checkup safety activate browser", - "checkup safety activate chrome", - "checkup safety activate google", - "checkup safety activate google chrome", - "checkup safety browser", - "checkup safety browser activate", - "checkup safety browser perform", - "checkup safety browser run", - "checkup safety browser use", - "checkup safety chrome", - "checkup safety chrome activate", - "checkup safety chrome perform", - "checkup safety chrome run", - "checkup safety chrome use", - "checkup safety google", - "checkup safety google activate", - "checkup safety google chrome", - "checkup safety google chrome activate", - "checkup safety google chrome perform", - "checkup safety google chrome run", - "checkup safety google chrome use", - "checkup safety google perform", - "checkup safety google run", - "checkup safety google use", - "checkup safety perform", - "checkup safety perform browser", - "checkup safety perform chrome", - "checkup safety perform google", - "checkup safety perform google chrome", - "checkup safety run", - "checkup safety run browser", - "checkup safety run chrome", - "checkup safety run google", - "checkup safety run google chrome", - "checkup safety use", - "checkup safety use browser", - "checkup safety use chrome", - "checkup safety use google", - "checkup safety use google chrome", - "checkup security", - "checkup security activate", - "checkup security activate browser", - "checkup security activate chrome", - "checkup security activate google", - "checkup security activate google chrome", - "checkup security browser", - "checkup security browser activate", - "checkup security browser perform", - "checkup security browser run", - "checkup security browser use", - "checkup security chrome", - "checkup security chrome activate", - "checkup security chrome perform", - "checkup security chrome run", - "checkup security chrome use", - "checkup security google", - "checkup security google activate", - "checkup security google chrome", - "checkup security google chrome activate", - "checkup security google chrome perform", - "checkup security google chrome run", - "checkup security google chrome use", - "checkup security google perform", - "checkup security google run", - "checkup security google use", - "checkup security perform", - "checkup security perform browser", - "checkup security perform chrome", - "checkup security perform google", - "checkup security perform google chrome", - "checkup security run", - "checkup security run browser", - "checkup security run chrome", - "checkup security run google", - "checkup security run google chrome", - "checkup security use", - "checkup security use browser", - "checkup security use chrome", - "checkup security use google", - "checkup security use google chrome", - "checkup use browser password", - "checkup use browser passwords", - "checkup use browser safety", - "checkup use browser security", - "checkup use chrome password", - "checkup use chrome passwords", - "checkup use chrome safety", - "checkup use chrome security", - "checkup use google chrome password", - "checkup use google chrome passwords", - "checkup use google chrome safety", - "checkup use google chrome security", - "checkup use google password", - "checkup use google passwords", - "checkup use google safety", - "checkup use google security", - "checkup use password", - "checkup use password browser", - "checkup use password chrome", - "checkup use password google", - "checkup use password google chrome", - "checkup use passwords", - "checkup use passwords browser", - "checkup use passwords chrome", - "checkup use passwords google", - "checkup use passwords google chrome", - "checkup use safety", - "checkup use safety browser", - "checkup use safety chrome", - "checkup use safety google", - "checkup use safety google chrome", - "checkup use security", - "checkup use security browser", - "checkup use security chrome", - "checkup use security google", - "checkup use security google chrome", - "chrome activate check password", - "chrome activate check passwords", - "chrome activate check safety", - "chrome activate check security", - "chrome activate checks password", - "chrome activate checks passwords", - "chrome activate checks safety", - "chrome activate checks security", - "chrome activate checkup password", - "chrome activate checkup passwords", - "chrome activate checkup safety", - "chrome activate checkup security", - "chrome activate password check", - "chrome activate password checks", - "chrome activate password checkup", - "chrome activate passwords check", - "chrome activate passwords checks", - "chrome activate passwords checkup", - "chrome activate safety check", - "chrome activate safety checks", - "chrome activate safety checkup", - "chrome activate security check", - "chrome activate security checks", - "chrome activate security checkup", - "chrome check activate password", - "chrome check activate passwords", - "chrome check activate safety", - "chrome check activate security", - "chrome check password", - "chrome check password activate", - "chrome check password perform", - "chrome check password run", - "chrome check password use", - "chrome check passwords", - "chrome check passwords activate", - "chrome check passwords perform", - "chrome check passwords run", - "chrome check passwords use", - "chrome check perform password", - "chrome check perform passwords", - "chrome check perform safety", - "chrome check perform security", - "chrome check run password", - "chrome check run passwords", - "chrome check run safety", - "chrome check run security", - "chrome check safety", - "chrome check safety activate", - "chrome check safety perform", - "chrome check safety run", - "chrome check safety use", - "chrome check security", - "chrome check security activate", - "chrome check security perform", - "chrome check security run", - "chrome check security use", - "chrome check use password", - "chrome check use passwords", - "chrome check use safety", - "chrome check use security", - "chrome checks activate password", - "chrome checks activate passwords", - "chrome checks activate safety", - "chrome checks activate security", - "chrome checks password", - "chrome checks password activate", - "chrome checks password perform", - "chrome checks password run", - "chrome checks password use", - "chrome checks passwords", - "chrome checks passwords activate", - "chrome checks passwords perform", - "chrome checks passwords run", - "chrome checks passwords use", - "chrome checks perform password", - "chrome checks perform passwords", - "chrome checks perform safety", - "chrome checks perform security", - "chrome checks run password", - "chrome checks run passwords", - "chrome checks run safety", - "chrome checks run security", - "chrome checks safety", - "chrome checks safety activate", - "chrome checks safety perform", - "chrome checks safety run", - "chrome checks safety use", - "chrome checks security", - "chrome checks security activate", - "chrome checks security perform", - "chrome checks security run", - "chrome checks security use", - "chrome checks use password", - "chrome checks use passwords", - "chrome checks use safety", - "chrome checks use security", - "chrome checkup activate password", - "chrome checkup activate passwords", - "chrome checkup activate safety", - "chrome checkup activate security", - "chrome checkup password", - "chrome checkup password activate", - "chrome checkup password perform", - "chrome checkup password run", - "chrome checkup password use", - "chrome checkup passwords", - "chrome checkup passwords activate", - "chrome checkup passwords perform", - "chrome checkup passwords run", - "chrome checkup passwords use", - "chrome checkup perform password", - "chrome checkup perform passwords", - "chrome checkup perform safety", - "chrome checkup perform security", - "chrome checkup run password", - "chrome checkup run passwords", - "chrome checkup run safety", - "chrome checkup run security", - "chrome checkup safety", - "chrome checkup safety activate", - "chrome checkup safety perform", - "chrome checkup safety run", - "chrome checkup safety use", - "chrome checkup security", - "chrome checkup security activate", - "chrome checkup security perform", - "chrome checkup security run", - "chrome checkup security use", - "chrome checkup use password", - "chrome checkup use passwords", - "chrome checkup use safety", - "chrome checkup use security", - "chrome password activate check", - "chrome password activate checks", - "chrome password activate checkup", - "chrome password check", - "chrome password check activate", - "chrome password check perform", - "chrome password check run", - "chrome password check use", - "chrome password checks", - "chrome password checks activate", - "chrome password checks perform", - "chrome password checks run", - "chrome password checks use", - "chrome password checkup", - "chrome password checkup activate", - "chrome password checkup perform", - "chrome password checkup run", - "chrome password checkup use", - "chrome password perform check", - "chrome password perform checks", - "chrome password perform checkup", - "chrome password run check", - "chrome password run checks", - "chrome password run checkup", - "chrome password use check", - "chrome password use checks", - "chrome password use checkup", - "chrome passwords activate check", - "chrome passwords activate checks", - "chrome passwords activate checkup", - "chrome passwords check", - "chrome passwords check activate", - "chrome passwords check perform", - "chrome passwords check run", - "chrome passwords check use", - "chrome passwords checks", - "chrome passwords checks activate", - "chrome passwords checks perform", - "chrome passwords checks run", - "chrome passwords checks use", - "chrome passwords checkup", - "chrome passwords checkup activate", - "chrome passwords checkup perform", - "chrome passwords checkup run", - "chrome passwords checkup use", - "chrome passwords perform check", - "chrome passwords perform checks", - "chrome passwords perform checkup", - "chrome passwords run check", - "chrome passwords run checks", - "chrome passwords run checkup", - "chrome passwords use check", - "chrome passwords use checks", - "chrome passwords use checkup", - "chrome perform check password", - "chrome perform check passwords", - "chrome perform check safety", - "chrome perform check security", - "chrome perform checks password", - "chrome perform checks passwords", - "chrome perform checks safety", - "chrome perform checks security", - "chrome perform checkup password", - "chrome perform checkup passwords", - "chrome perform checkup safety", - "chrome perform checkup security", - "chrome perform password check", - "chrome perform password checks", - "chrome perform password checkup", - "chrome perform passwords check", - "chrome perform passwords checks", - "chrome perform passwords checkup", - "chrome perform safety check", - "chrome perform safety checks", - "chrome perform safety checkup", - "chrome perform security check", - "chrome perform security checks", - "chrome perform security checkup", - "chrome run check password", - "chrome run check passwords", - "chrome run check safety", - "chrome run check security", - "chrome run checks password", - "chrome run checks passwords", - "chrome run checks safety", - "chrome run checks security", - "chrome run checkup password", - "chrome run checkup passwords", - "chrome run checkup safety", - "chrome run checkup security", - "chrome run password check", - "chrome run password checks", - "chrome run password checkup", - "chrome run passwords check", - "chrome run passwords checks", - "chrome run passwords checkup", - "chrome run safety check", - "chrome run safety checks", - "chrome run safety checkup", - "chrome run security check", - "chrome run security checks", - "chrome run security checkup", - "chrome safety activate check", - "chrome safety activate checks", - "chrome safety activate checkup", - "chrome safety check", - "chrome safety check activate", - "chrome safety check perform", - "chrome safety check run", - "chrome safety check use", - "chrome safety checks", - "chrome safety checks activate", - "chrome safety checks perform", - "chrome safety checks run", - "chrome safety checks use", - "chrome safety checkup", - "chrome safety checkup activate", - "chrome safety checkup perform", - "chrome safety checkup run", - "chrome safety checkup use", - "chrome safety perform check", - "chrome safety perform checks", - "chrome safety perform checkup", - "chrome safety run check", - "chrome safety run checks", - "chrome safety run checkup", - "chrome safety use check", - "chrome safety use checks", - "chrome safety use checkup", - "chrome security activate check", - "chrome security activate checks", - "chrome security activate checkup", - "chrome security check", - "chrome security check activate", - "chrome security check perform", - "chrome security check run", - "chrome security check use", - "chrome security checks", - "chrome security checks activate", - "chrome security checks perform", - "chrome security checks run", - "chrome security checks use", - "chrome security checkup", - "chrome security checkup activate", - "chrome security checkup perform", - "chrome security checkup run", - "chrome security checkup use", - "chrome security perform check", - "chrome security perform checks", - "chrome security perform checkup", - "chrome security run check", - "chrome security run checks", - "chrome security run checkup", - "chrome security use check", - "chrome security use checks", - "chrome security use checkup", - "chrome use check password", - "chrome use check passwords", - "chrome use check safety", - "chrome use check security", - "chrome use checks password", - "chrome use checks passwords", - "chrome use checks safety", - "chrome use checks security", - "chrome use checkup password", - "chrome use checkup passwords", - "chrome use checkup safety", - "chrome use checkup security", - "chrome use password check", - "chrome use password checks", - "chrome use password checkup", - "chrome use passwords check", - "chrome use passwords checks", - "chrome use passwords checkup", - "chrome use safety check", - "chrome use safety checks", - "chrome use safety checkup", - "chrome use security check", - "chrome use security checks", - "chrome use security checkup", - "google activate check password", - "google activate check passwords", - "google activate check safety", - "google activate check security", - "google activate checks password", - "google activate checks passwords", - "google activate checks safety", - "google activate checks security", - "google activate checkup password", - "google activate checkup passwords", - "google activate checkup safety", - "google activate checkup security", - "google activate password check", - "google activate password checks", - "google activate password checkup", - "google activate passwords check", - "google activate passwords checks", - "google activate passwords checkup", - "google activate safety check", - "google activate safety checks", - "google activate safety checkup", - "google activate security check", - "google activate security checks", - "google activate security checkup", - "google check activate password", - "google check activate passwords", - "google check activate safety", - "google check activate security", - "google check password", - "google check password activate", - "google check password perform", - "google check password run", - "google check password use", - "google check passwords", - "google check passwords activate", - "google check passwords perform", - "google check passwords run", - "google check passwords use", - "google check perform password", - "google check perform passwords", - "google check perform safety", - "google check perform security", - "google check run password", - "google check run passwords", - "google check run safety", - "google check run security", - "google check safety", - "google check safety activate", - "google check safety perform", - "google check safety run", - "google check safety use", - "google check security", - "google check security activate", - "google check security perform", - "google check security run", - "google check security use", - "google check use password", - "google check use passwords", - "google check use safety", - "google check use security", - "google checks activate password", - "google checks activate passwords", - "google checks activate safety", - "google checks activate security", - "google checks password", - "google checks password activate", - "google checks password perform", - "google checks password run", - "google checks password use", - "google checks passwords", - "google checks passwords activate", - "google checks passwords perform", - "google checks passwords run", - "google checks passwords use", - "google checks perform password", - "google checks perform passwords", - "google checks perform safety", - "google checks perform security", - "google checks run password", - "google checks run passwords", - "google checks run safety", - "google checks run security", - "google checks safety", - "google checks safety activate", - "google checks safety perform", - "google checks safety run", - "google checks safety use", - "google checks security", - "google checks security activate", - "google checks security perform", - "google checks security run", - "google checks security use", - "google checks use password", - "google checks use passwords", - "google checks use safety", - "google checks use security", - "google checkup activate password", - "google checkup activate passwords", - "google checkup activate safety", - "google checkup activate security", - "google checkup password", - "google checkup password activate", - "google checkup password perform", - "google checkup password run", - "google checkup password use", - "google checkup passwords", - "google checkup passwords activate", - "google checkup passwords perform", - "google checkup passwords run", - "google checkup passwords use", - "google checkup perform password", - "google checkup perform passwords", - "google checkup perform safety", - "google checkup perform security", - "google checkup run password", - "google checkup run passwords", - "google checkup run safety", - "google checkup run security", - "google checkup safety", - "google checkup safety activate", - "google checkup safety perform", - "google checkup safety run", - "google checkup safety use", - "google checkup security", - "google checkup security activate", - "google checkup security perform", - "google checkup security run", - "google checkup security use", - "google checkup use password", - "google checkup use passwords", - "google checkup use safety", - "google checkup use security", - "google chrome activate check password", - "google chrome activate check passwords", - "google chrome activate check safety", - "google chrome activate check security", - "google chrome activate checks password", - "google chrome activate checks passwords", - "google chrome activate checks safety", - "google chrome activate checks security", - "google chrome activate checkup password", - "google chrome activate checkup passwords", - "google chrome activate checkup safety", - "google chrome activate checkup security", - "google chrome activate password check", - "google chrome activate password checks", - "google chrome activate password checkup", - "google chrome activate passwords check", - "google chrome activate passwords checks", - "google chrome activate passwords checkup", - "google chrome activate safety check", - "google chrome activate safety checks", - "google chrome activate safety checkup", - "google chrome activate security check", - "google chrome activate security checks", - "google chrome activate security checkup", - "google chrome check activate password", - "google chrome check activate passwords", - "google chrome check activate safety", - "google chrome check activate security", - "google chrome check password", - "google chrome check password activate", - "google chrome check password perform", - "google chrome check password run", - "google chrome check password use", - "google chrome check passwords", - "google chrome check passwords activate", - "google chrome check passwords perform", - "google chrome check passwords run", - "google chrome check passwords use", - "google chrome check perform password", - "google chrome check perform passwords", - "google chrome check perform safety", - "google chrome check perform security", - "google chrome check run password", - "google chrome check run passwords", - "google chrome check run safety", - "google chrome check run security", - "google chrome check safety", - "google chrome check safety activate", - "google chrome check safety perform", - "google chrome check safety run", - "google chrome check safety use", - "google chrome check security", - "google chrome check security activate", - "google chrome check security perform", - "google chrome check security run", - "google chrome check security use", - "google chrome check use password", - "google chrome check use passwords", - "google chrome check use safety", - "google chrome check use security", - "google chrome checks activate password", - "google chrome checks activate passwords", - "google chrome checks activate safety", - "google chrome checks activate security", - "google chrome checks password", - "google chrome checks password activate", - "google chrome checks password perform", - "google chrome checks password run", - "google chrome checks password use", - "google chrome checks passwords", - "google chrome checks passwords activate", - "google chrome checks passwords perform", - "google chrome checks passwords run", - "google chrome checks passwords use", - "google chrome checks perform password", - "google chrome checks perform passwords", - "google chrome checks perform safety", - "google chrome checks perform security", - "google chrome checks run password", - "google chrome checks run passwords", - "google chrome checks run safety", - "google chrome checks run security", - "google chrome checks safety", - "google chrome checks safety activate", - "google chrome checks safety perform", - "google chrome checks safety run", - "google chrome checks safety use", - "google chrome checks security", - "google chrome checks security activate", - "google chrome checks security perform", - "google chrome checks security run", - "google chrome checks security use", - "google chrome checks use password", - "google chrome checks use passwords", - "google chrome checks use safety", - "google chrome checks use security", - "google chrome checkup activate password", - "google chrome checkup activate passwords", - "google chrome checkup activate safety", - "google chrome checkup activate security", - "google chrome checkup password", - "google chrome checkup password activate", - "google chrome checkup password perform", - "google chrome checkup password run", - "google chrome checkup password use", - "google chrome checkup passwords", - "google chrome checkup passwords activate", - "google chrome checkup passwords perform", - "google chrome checkup passwords run", - "google chrome checkup passwords use", - "google chrome checkup perform password", - "google chrome checkup perform passwords", - "google chrome checkup perform safety", - "google chrome checkup perform security", - "google chrome checkup run password", - "google chrome checkup run passwords", - "google chrome checkup run safety", - "google chrome checkup run security", - "google chrome checkup safety", - "google chrome checkup safety activate", - "google chrome checkup safety perform", - "google chrome checkup safety run", - "google chrome checkup safety use", - "google chrome checkup security", - "google chrome checkup security activate", - "google chrome checkup security perform", - "google chrome checkup security run", - "google chrome checkup security use", - "google chrome checkup use password", - "google chrome checkup use passwords", - "google chrome checkup use safety", - "google chrome checkup use security", - "google chrome password activate check", - "google chrome password activate checks", - "google chrome password activate checkup", - "google chrome password check", - "google chrome password check activate", - "google chrome password check perform", - "google chrome password check run", - "google chrome password check use", - "google chrome password checks", - "google chrome password checks activate", - "google chrome password checks perform", - "google chrome password checks run", - "google chrome password checks use", - "google chrome password checkup", - "google chrome password checkup activate", - "google chrome password checkup perform", - "google chrome password checkup run", - "google chrome password checkup use", - "google chrome password perform check", - "google chrome password perform checks", - "google chrome password perform checkup", - "google chrome password run check", - "google chrome password run checks", - "google chrome password run checkup", - "google chrome password use check", - "google chrome password use checks", - "google chrome password use checkup", - "google chrome passwords activate check", - "google chrome passwords activate checks", - "google chrome passwords activate checkup", - "google chrome passwords check", - "google chrome passwords check activate", - "google chrome passwords check perform", - "google chrome passwords check run", - "google chrome passwords check use", - "google chrome passwords checks", - "google chrome passwords checks activate", - "google chrome passwords checks perform", - "google chrome passwords checks run", - "google chrome passwords checks use", - "google chrome passwords checkup", - "google chrome passwords checkup activate", - "google chrome passwords checkup perform", - "google chrome passwords checkup run", - "google chrome passwords checkup use", - "google chrome passwords perform check", - "google chrome passwords perform checks", - "google chrome passwords perform checkup", - "google chrome passwords run check", - "google chrome passwords run checks", - "google chrome passwords run checkup", - "google chrome passwords use check", - "google chrome passwords use checks", - "google chrome passwords use checkup", - "google chrome perform check password", - "google chrome perform check passwords", - "google chrome perform check safety", - "google chrome perform check security", - "google chrome perform checks password", - "google chrome perform checks passwords", - "google chrome perform checks safety", - "google chrome perform checks security", - "google chrome perform checkup password", - "google chrome perform checkup passwords", - "google chrome perform checkup safety", - "google chrome perform checkup security", - "google chrome perform password check", - "google chrome perform password checks", - "google chrome perform password checkup", - "google chrome perform passwords check", - "google chrome perform passwords checks", - "google chrome perform passwords checkup", - "google chrome perform safety check", - "google chrome perform safety checks", - "google chrome perform safety checkup", - "google chrome perform security check", - "google chrome perform security checks", - "google chrome perform security checkup", - "google chrome run check password", - "google chrome run check passwords", - "google chrome run check safety", - "google chrome run check security", - "google chrome run checks password", - "google chrome run checks passwords", - "google chrome run checks safety", - "google chrome run checks security", - "google chrome run checkup password", - "google chrome run checkup passwords", - "google chrome run checkup safety", - "google chrome run checkup security", - "google chrome run password check", - "google chrome run password checks", - "google chrome run password checkup", - "google chrome run passwords check", - "google chrome run passwords checks", - "google chrome run passwords checkup", - "google chrome run safety check", - "google chrome run safety checks", - "google chrome run safety checkup", - "google chrome run security check", - "google chrome run security checks", - "google chrome run security checkup", - "google chrome safety activate check", - "google chrome safety activate checks", - "google chrome safety activate checkup", - "google chrome safety check", - "google chrome safety check activate", - "google chrome safety check perform", - "google chrome safety check run", - "google chrome safety check use", - "google chrome safety checks", - "google chrome safety checks activate", - "google chrome safety checks perform", - "google chrome safety checks run", - "google chrome safety checks use", - "google chrome safety checkup", - "google chrome safety checkup activate", - "google chrome safety checkup perform", - "google chrome safety checkup run", - "google chrome safety checkup use", - "google chrome safety perform check", - "google chrome safety perform checks", - "google chrome safety perform checkup", - "google chrome safety run check", - "google chrome safety run checks", - "google chrome safety run checkup", - "google chrome safety use check", - "google chrome safety use checks", - "google chrome safety use checkup", - "google chrome security activate check", - "google chrome security activate checks", - "google chrome security activate checkup", - "google chrome security check", - "google chrome security check activate", - "google chrome security check perform", - "google chrome security check run", - "google chrome security check use", - "google chrome security checks", - "google chrome security checks activate", - "google chrome security checks perform", - "google chrome security checks run", - "google chrome security checks use", - "google chrome security checkup", - "google chrome security checkup activate", - "google chrome security checkup perform", - "google chrome security checkup run", - "google chrome security checkup use", - "google chrome security perform check", - "google chrome security perform checks", - "google chrome security perform checkup", - "google chrome security run check", - "google chrome security run checks", - "google chrome security run checkup", - "google chrome security use check", - "google chrome security use checks", - "google chrome security use checkup", - "google chrome use check password", - "google chrome use check passwords", - "google chrome use check safety", - "google chrome use check security", - "google chrome use checks password", - "google chrome use checks passwords", - "google chrome use checks safety", - "google chrome use checks security", - "google chrome use checkup password", - "google chrome use checkup passwords", - "google chrome use checkup safety", - "google chrome use checkup security", - "google chrome use password check", - "google chrome use password checks", - "google chrome use password checkup", - "google chrome use passwords check", - "google chrome use passwords checks", - "google chrome use passwords checkup", - "google chrome use safety check", - "google chrome use safety checks", - "google chrome use safety checkup", - "google chrome use security check", - "google chrome use security checks", - "google chrome use security checkup", - "google password activate check", - "google password activate checks", - "google password activate checkup", - "google password check", - "google password check activate", - "google password check perform", - "google password check run", - "google password check use", - "google password checks", - "google password checks activate", - "google password checks perform", - "google password checks run", - "google password checks use", - "google password checkup", - "google password checkup activate", - "google password checkup perform", - "google password checkup run", - "google password checkup use", - "google password perform check", - "google password perform checks", - "google password perform checkup", - "google password run check", - "google password run checks", - "google password run checkup", - "google password use check", - "google password use checks", - "google password use checkup", - "google passwords activate check", - "google passwords activate checks", - "google passwords activate checkup", - "google passwords check", - "google passwords check activate", - "google passwords check perform", - "google passwords check run", - "google passwords check use", - "google passwords checks", - "google passwords checks activate", - "google passwords checks perform", - "google passwords checks run", - "google passwords checks use", - "google passwords checkup", - "google passwords checkup activate", - "google passwords checkup perform", - "google passwords checkup run", - "google passwords checkup use", - "google passwords perform check", - "google passwords perform checks", - "google passwords perform checkup", - "google passwords run check", - "google passwords run checks", - "google passwords run checkup", - "google passwords use check", - "google passwords use checks", - "google passwords use checkup", - "google perform check password", - "google perform check passwords", - "google perform check safety", - "google perform check security", - "google perform checks password", - "google perform checks passwords", - "google perform checks safety", - "google perform checks security", - "google perform checkup password", - "google perform checkup passwords", - "google perform checkup safety", - "google perform checkup security", - "google perform password check", - "google perform password checks", - "google perform password checkup", - "google perform passwords check", - "google perform passwords checks", - "google perform passwords checkup", - "google perform safety check", - "google perform safety checks", - "google perform safety checkup", - "google perform security check", - "google perform security checks", - "google perform security checkup", - "google run check password", - "google run check passwords", - "google run check safety", - "google run check security", - "google run checks password", - "google run checks passwords", - "google run checks safety", - "google run checks security", - "google run checkup password", - "google run checkup passwords", - "google run checkup safety", - "google run checkup security", - "google run password check", - "google run password checks", - "google run password checkup", - "google run passwords check", - "google run passwords checks", - "google run passwords checkup", - "google run safety check", - "google run safety checks", - "google run safety checkup", - "google run security check", - "google run security checks", - "google run security checkup", - "google safety activate check", - "google safety activate checks", - "google safety activate checkup", - "google safety check", - "google safety check activate", - "google safety check perform", - "google safety check run", - "google safety check use", - "google safety checks", - "google safety checks activate", - "google safety checks perform", - "google safety checks run", - "google safety checks use", - "google safety checkup", - "google safety checkup activate", - "google safety checkup perform", - "google safety checkup run", - "google safety checkup use", - "google safety perform check", - "google safety perform checks", - "google safety perform checkup", - "google safety run check", - "google safety run checks", - "google safety run checkup", - "google safety use check", - "google safety use checks", - "google safety use checkup", - "google security activate check", - "google security activate checks", - "google security activate checkup", - "google security check", - "google security check activate", - "google security check perform", - "google security check run", - "google security check use", - "google security checks", - "google security checks activate", - "google security checks perform", - "google security checks run", - "google security checks use", - "google security checkup", - "google security checkup activate", - "google security checkup perform", - "google security checkup run", - "google security checkup use", - "google security perform check", - "google security perform checks", - "google security perform checkup", - "google security run check", - "google security run checks", - "google security run checkup", - "google security use check", - "google security use checks", - "google security use checkup", - "google use check password", - "google use check passwords", - "google use check safety", - "google use check security", - "google use checks password", - "google use checks passwords", - "google use checks safety", - "google use checks security", - "google use checkup password", - "google use checkup passwords", - "google use checkup safety", - "google use checkup security", - "google use password check", - "google use password checks", - "google use password checkup", - "google use passwords check", - "google use passwords checks", - "google use passwords checkup", - "google use safety check", - "google use safety checks", - "google use safety checkup", - "google use security check", - "google use security checks", - "google use security checkup", - "password activate browser check", - "password activate browser checks", - "password activate browser checkup", - "password activate check", - "password activate check browser", - "password activate check chrome", - "password activate check google", - "password activate check google chrome", - "password activate checks", - "password activate checks browser", - "password activate checks chrome", - "password activate checks google", - "password activate checks google chrome", - "password activate checkup", - "password activate checkup browser", - "password activate checkup chrome", - "password activate checkup google", - "password activate checkup google chrome", - "password activate chrome check", - "password activate chrome checks", - "password activate chrome checkup", - "password activate google check", - "password activate google checks", - "password activate google checkup", - "password activate google chrome check", - "password activate google chrome checks", - "password activate google chrome checkup", - "password browser activate check", - "password browser activate checks", - "password browser activate checkup", - "password browser check", - "password browser check activate", - "password browser check perform", - "password browser check run", - "password browser check use", - "password browser checks", - "password browser checks activate", - "password browser checks perform", - "password browser checks run", - "password browser checks use", - "password browser checkup", - "password browser checkup activate", - "password browser checkup perform", - "password browser checkup run", - "password browser checkup use", - "password browser perform check", - "password browser perform checks", - "password browser perform checkup", - "password browser run check", - "password browser run checks", - "password browser run checkup", - "password browser use check", - "password browser use checks", - "password browser use checkup", - "password check", - "password check activate", - "password check activate browser", - "password check activate chrome", - "password check activate google", - "password check activate google chrome", - "password check browser", - "password check browser activate", - "password check browser perform", - "password check browser run", - "password check browser use", - "password check chrome", - "password check chrome activate", - "password check chrome perform", - "password check chrome run", - "password check chrome use", - "password check google", - "password check google activate", - "password check google chrome", - "password check google chrome activate", - "password check google chrome perform", - "password check google chrome run", - "password check google chrome use", - "password check google perform", - "password check google run", - "password check google use", - "password check perform", - "password check perform browser", - "password check perform chrome", - "password check perform google", - "password check perform google chrome", - "password check run", - "password check run browser", - "password check run chrome", - "password check run google", - "password check run google chrome", - "password check use", - "password check use browser", - "password check use chrome", - "password check use google", - "password check use google chrome", - "password checks", - "password checks activate", - "password checks activate browser", - "password checks activate chrome", - "password checks activate google", - "password checks activate google chrome", - "password checks browser", - "password checks browser activate", - "password checks browser perform", - "password checks browser run", - "password checks browser use", - "password checks chrome", - "password checks chrome activate", - "password checks chrome perform", - "password checks chrome run", - "password checks chrome use", - "password checks google", - "password checks google activate", - "password checks google chrome", - "password checks google chrome activate", - "password checks google chrome perform", - "password checks google chrome run", - "password checks google chrome use", - "password checks google perform", - "password checks google run", - "password checks google use", - "password checks perform", - "password checks perform browser", - "password checks perform chrome", - "password checks perform google", - "password checks perform google chrome", - "password checks run", - "password checks run browser", - "password checks run chrome", - "password checks run google", - "password checks run google chrome", - "password checks use", - "password checks use browser", - "password checks use chrome", - "password checks use google", - "password checks use google chrome", - "password checkup", - "password checkup activate", - "password checkup activate browser", - "password checkup activate chrome", - "password checkup activate google", - "password checkup activate google chrome", - "password checkup browser", - "password checkup browser activate", - "password checkup browser perform", - "password checkup browser run", - "password checkup browser use", - "password checkup chrome", - "password checkup chrome activate", - "password checkup chrome perform", - "password checkup chrome run", - "password checkup chrome use", - "password checkup google", - "password checkup google activate", - "password checkup google chrome", - "password checkup google chrome activate", - "password checkup google chrome perform", - "password checkup google chrome run", - "password checkup google chrome use", - "password checkup google perform", - "password checkup google run", - "password checkup google use", - "password checkup perform", - "password checkup perform browser", - "password checkup perform chrome", - "password checkup perform google", - "password checkup perform google chrome", - "password checkup run", - "password checkup run browser", - "password checkup run chrome", - "password checkup run google", - "password checkup run google chrome", - "password checkup use", - "password checkup use browser", - "password checkup use chrome", - "password checkup use google", - "password checkup use google chrome", - "password chrome activate check", - "password chrome activate checks", - "password chrome activate checkup", - "password chrome check", - "password chrome check activate", - "password chrome check perform", - "password chrome check run", - "password chrome check use", - "password chrome checks", - "password chrome checks activate", - "password chrome checks perform", - "password chrome checks run", - "password chrome checks use", - "password chrome checkup", - "password chrome checkup activate", - "password chrome checkup perform", - "password chrome checkup run", - "password chrome checkup use", - "password chrome perform check", - "password chrome perform checks", - "password chrome perform checkup", - "password chrome run check", - "password chrome run checks", - "password chrome run checkup", - "password chrome use check", - "password chrome use checks", - "password chrome use checkup", - "password google activate check", - "password google activate checks", - "password google activate checkup", - "password google check", - "password google check activate", - "password google check perform", - "password google check run", - "password google check use", - "password google checks", - "password google checks activate", - "password google checks perform", - "password google checks run", - "password google checks use", - "password google checkup", - "password google checkup activate", - "password google checkup perform", - "password google checkup run", - "password google checkup use", - "password google chrome activate check", - "password google chrome activate checks", - "password google chrome activate checkup", - "password google chrome check", - "password google chrome check activate", - "password google chrome check perform", - "password google chrome check run", - "password google chrome check use", - "password google chrome checks", - "password google chrome checks activate", - "password google chrome checks perform", - "password google chrome checks run", - "password google chrome checks use", - "password google chrome checkup", - "password google chrome checkup activate", - "password google chrome checkup perform", - "password google chrome checkup run", - "password google chrome checkup use", - "password google chrome perform check", - "password google chrome perform checks", - "password google chrome perform checkup", - "password google chrome run check", - "password google chrome run checks", - "password google chrome run checkup", - "password google chrome use check", - "password google chrome use checks", - "password google chrome use checkup", - "password google perform check", - "password google perform checks", - "password google perform checkup", - "password google run check", - "password google run checks", - "password google run checkup", - "password google use check", - "password google use checks", - "password google use checkup", - "password perform browser check", - "password perform browser checks", - "password perform browser checkup", - "password perform check", - "password perform check browser", - "password perform check chrome", - "password perform check google", - "password perform check google chrome", - "password perform checks", - "password perform checks browser", - "password perform checks chrome", - "password perform checks google", - "password perform checks google chrome", - "password perform checkup", - "password perform checkup browser", - "password perform checkup chrome", - "password perform checkup google", - "password perform checkup google chrome", - "password perform chrome check", - "password perform chrome checks", - "password perform chrome checkup", - "password perform google check", - "password perform google checks", - "password perform google checkup", - "password perform google chrome check", - "password perform google chrome checks", - "password perform google chrome checkup", - "password run browser check", - "password run browser checks", - "password run browser checkup", - "password run check", - "password run check browser", - "password run check chrome", - "password run check google", - "password run check google chrome", - "password run checks", - "password run checks browser", - "password run checks chrome", - "password run checks google", - "password run checks google chrome", - "password run checkup", - "password run checkup browser", - "password run checkup chrome", - "password run checkup google", - "password run checkup google chrome", - "password run chrome check", - "password run chrome checks", - "password run chrome checkup", - "password run google check", - "password run google checks", - "password run google checkup", - "password run google chrome check", - "password run google chrome checks", - "password run google chrome checkup", - "password use browser check", - "password use browser checks", - "password use browser checkup", - "password use check", - "password use check browser", - "password use check chrome", - "password use check google", - "password use check google chrome", - "password use checks", - "password use checks browser", - "password use checks chrome", - "password use checks google", - "password use checks google chrome", - "password use checkup", - "password use checkup browser", - "password use checkup chrome", - "password use checkup google", - "password use checkup google chrome", - "password use chrome check", - "password use chrome checks", - "password use chrome checkup", - "password use google check", - "password use google checks", - "password use google checkup", - "password use google chrome check", - "password use google chrome checks", - "password use google chrome checkup", - "passwords activate browser check", - "passwords activate browser checks", - "passwords activate browser checkup", - "passwords activate check", - "passwords activate check browser", - "passwords activate check chrome", - "passwords activate check google", - "passwords activate check google chrome", - "passwords activate checks", - "passwords activate checks browser", - "passwords activate checks chrome", - "passwords activate checks google", - "passwords activate checks google chrome", - "passwords activate checkup", - "passwords activate checkup browser", - "passwords activate checkup chrome", - "passwords activate checkup google", - "passwords activate checkup google chrome", - "passwords activate chrome check", - "passwords activate chrome checks", - "passwords activate chrome checkup", - "passwords activate google check", - "passwords activate google checks", - "passwords activate google checkup", - "passwords activate google chrome check", - "passwords activate google chrome checks", - "passwords activate google chrome checkup", - "passwords browser activate check", - "passwords browser activate checks", - "passwords browser activate checkup", - "passwords browser check", - "passwords browser check activate", - "passwords browser check perform", - "passwords browser check run", - "passwords browser check use", - "passwords browser checks", - "passwords browser checks activate", - "passwords browser checks perform", - "passwords browser checks run", - "passwords browser checks use", - "passwords browser checkup", - "passwords browser checkup activate", - "passwords browser checkup perform", - "passwords browser checkup run", - "passwords browser checkup use", - "passwords browser perform check", - "passwords browser perform checks", - "passwords browser perform checkup", - "passwords browser run check", - "passwords browser run checks", - "passwords browser run checkup", - "passwords browser use check", - "passwords browser use checks", - "passwords browser use checkup", - "passwords check", - "passwords check activate", - "passwords check activate browser", - "passwords check activate chrome", - "passwords check activate google", - "passwords check activate google chrome", - "passwords check browser", - "passwords check browser activate", - "passwords check browser perform", - "passwords check browser run", - "passwords check browser use", - "passwords check chrome", - "passwords check chrome activate", - "passwords check chrome perform", - "passwords check chrome run", - "passwords check chrome use", - "passwords check google", - "passwords check google activate", - "passwords check google chrome", - "passwords check google chrome activate", - "passwords check google chrome perform", - "passwords check google chrome run", - "passwords check google chrome use", - "passwords check google perform", - "passwords check google run", - "passwords check google use", - "passwords check perform", - "passwords check perform browser", - "passwords check perform chrome", - "passwords check perform google", - "passwords check perform google chrome", - "passwords check run", - "passwords check run browser", - "passwords check run chrome", - "passwords check run google", - "passwords check run google chrome", - "passwords check use", - "passwords check use browser", - "passwords check use chrome", - "passwords check use google", - "passwords check use google chrome", - "passwords checks", - "passwords checks activate", - "passwords checks activate browser", - "passwords checks activate chrome", - "passwords checks activate google", - "passwords checks activate google chrome", - "passwords checks browser", - "passwords checks browser activate", - "passwords checks browser perform", - "passwords checks browser run", - "passwords checks browser use", - "passwords checks chrome", - "passwords checks chrome activate", - "passwords checks chrome perform", - "passwords checks chrome run", - "passwords checks chrome use", - "passwords checks google", - "passwords checks google activate", - "passwords checks google chrome", - "passwords checks google chrome activate", - "passwords checks google chrome perform", - "passwords checks google chrome run", - "passwords checks google chrome use", - "passwords checks google perform", - "passwords checks google run", - "passwords checks google use", - "passwords checks perform", - "passwords checks perform browser", - "passwords checks perform chrome", - "passwords checks perform google", - "passwords checks perform google chrome", - "passwords checks run", - "passwords checks run browser", - "passwords checks run chrome", - "passwords checks run google", - "passwords checks run google chrome", - "passwords checks use", - "passwords checks use browser", - "passwords checks use chrome", - "passwords checks use google", - "passwords checks use google chrome", - "passwords checkup", - "passwords checkup activate", - "passwords checkup activate browser", - "passwords checkup activate chrome", - "passwords checkup activate google", - "passwords checkup activate google chrome", - "passwords checkup browser", - "passwords checkup browser activate", - "passwords checkup browser perform", - "passwords checkup browser run", - "passwords checkup browser use", - "passwords checkup chrome", - "passwords checkup chrome activate", - "passwords checkup chrome perform", - "passwords checkup chrome run", - "passwords checkup chrome use", - "passwords checkup google", - "passwords checkup google activate", - "passwords checkup google chrome", - "passwords checkup google chrome activate", - "passwords checkup google chrome perform", - "passwords checkup google chrome run", - "passwords checkup google chrome use", - "passwords checkup google perform", - "passwords checkup google run", - "passwords checkup google use", - "passwords checkup perform", - "passwords checkup perform browser", - "passwords checkup perform chrome", - "passwords checkup perform google", - "passwords checkup perform google chrome", - "passwords checkup run", - "passwords checkup run browser", - "passwords checkup run chrome", - "passwords checkup run google", - "passwords checkup run google chrome", - "passwords checkup use", - "passwords checkup use browser", - "passwords checkup use chrome", - "passwords checkup use google", - "passwords checkup use google chrome", - "passwords chrome activate check", - "passwords chrome activate checks", - "passwords chrome activate checkup", - "passwords chrome check", - "passwords chrome check activate", - "passwords chrome check perform", - "passwords chrome check run", - "passwords chrome check use", - "passwords chrome checks", - "passwords chrome checks activate", - "passwords chrome checks perform", - "passwords chrome checks run", - "passwords chrome checks use", - "passwords chrome checkup", - "passwords chrome checkup activate", - "passwords chrome checkup perform", - "passwords chrome checkup run", - "passwords chrome checkup use", - "passwords chrome perform check", - "passwords chrome perform checks", - "passwords chrome perform checkup", - "passwords chrome run check", - "passwords chrome run checks", - "passwords chrome run checkup", - "passwords chrome use check", - "passwords chrome use checks", - "passwords chrome use checkup", - "passwords google activate check", - "passwords google activate checks", - "passwords google activate checkup", - "passwords google check", - "passwords google check activate", - "passwords google check perform", - "passwords google check run", - "passwords google check use", - "passwords google checks", - "passwords google checks activate", - "passwords google checks perform", - "passwords google checks run", - "passwords google checks use", - "passwords google checkup", - "passwords google checkup activate", - "passwords google checkup perform", - "passwords google checkup run", - "passwords google checkup use", - "passwords google chrome activate check", - "passwords google chrome activate checks", - "passwords google chrome activate checkup", - "passwords google chrome check", - "passwords google chrome check activate", - "passwords google chrome check perform", - "passwords google chrome check run", - "passwords google chrome check use", - "passwords google chrome checks", - "passwords google chrome checks activate", - "passwords google chrome checks perform", - "passwords google chrome checks run", - "passwords google chrome checks use", - "passwords google chrome checkup", - "passwords google chrome checkup activate", - "passwords google chrome checkup perform", - "passwords google chrome checkup run", - "passwords google chrome checkup use", - "passwords google chrome perform check", - "passwords google chrome perform checks", - "passwords google chrome perform checkup", - "passwords google chrome run check", - "passwords google chrome run checks", - "passwords google chrome run checkup", - "passwords google chrome use check", - "passwords google chrome use checks", - "passwords google chrome use checkup", - "passwords google perform check", - "passwords google perform checks", - "passwords google perform checkup", - "passwords google run check", - "passwords google run checks", - "passwords google run checkup", - "passwords google use check", - "passwords google use checks", - "passwords google use checkup", - "passwords perform browser check", - "passwords perform browser checks", - "passwords perform browser checkup", - "passwords perform check", - "passwords perform check browser", - "passwords perform check chrome", - "passwords perform check google", - "passwords perform check google chrome", - "passwords perform checks", - "passwords perform checks browser", - "passwords perform checks chrome", - "passwords perform checks google", - "passwords perform checks google chrome", - "passwords perform checkup", - "passwords perform checkup browser", - "passwords perform checkup chrome", - "passwords perform checkup google", - "passwords perform checkup google chrome", - "passwords perform chrome check", - "passwords perform chrome checks", - "passwords perform chrome checkup", - "passwords perform google check", - "passwords perform google checks", - "passwords perform google checkup", - "passwords perform google chrome check", - "passwords perform google chrome checks", - "passwords perform google chrome checkup", - "passwords run browser check", - "passwords run browser checks", - "passwords run browser checkup", - "passwords run check", - "passwords run check browser", - "passwords run check chrome", - "passwords run check google", - "passwords run check google chrome", - "passwords run checks", - "passwords run checks browser", - "passwords run checks chrome", - "passwords run checks google", - "passwords run checks google chrome", - "passwords run checkup", - "passwords run checkup browser", - "passwords run checkup chrome", - "passwords run checkup google", - "passwords run checkup google chrome", - "passwords run chrome check", - "passwords run chrome checks", - "passwords run chrome checkup", - "passwords run google check", - "passwords run google checks", - "passwords run google checkup", - "passwords run google chrome check", - "passwords run google chrome checks", - "passwords run google chrome checkup", - "passwords use browser check", - "passwords use browser checks", - "passwords use browser checkup", - "passwords use check", - "passwords use check browser", - "passwords use check chrome", - "passwords use check google", - "passwords use check google chrome", - "passwords use checks", - "passwords use checks browser", - "passwords use checks chrome", - "passwords use checks google", - "passwords use checks google chrome", - "passwords use checkup", - "passwords use checkup browser", - "passwords use checkup chrome", - "passwords use checkup google", - "passwords use checkup google chrome", - "passwords use chrome check", - "passwords use chrome checks", - "passwords use chrome checkup", - "passwords use google check", - "passwords use google checks", - "passwords use google checkup", - "passwords use google chrome check", - "passwords use google chrome checks", - "passwords use google chrome checkup", - "perform browser check password", - "perform browser check passwords", - "perform browser check safety", - "perform browser check security", - "perform browser checks password", - "perform browser checks passwords", - "perform browser checks safety", - "perform browser checks security", - "perform browser checkup password", - "perform browser checkup passwords", - "perform browser checkup safety", - "perform browser checkup security", - "perform browser password check", - "perform browser password checks", - "perform browser password checkup", - "perform browser passwords check", - "perform browser passwords checks", - "perform browser passwords checkup", - "perform browser safety check", - "perform browser safety checks", - "perform browser safety checkup", - "perform browser security check", - "perform browser security checks", - "perform browser security checkup", - "perform check browser password", - "perform check browser passwords", - "perform check browser safety", - "perform check browser security", - "perform check chrome password", - "perform check chrome passwords", - "perform check chrome safety", - "perform check chrome security", - "perform check google chrome password", - "perform check google chrome passwords", - "perform check google chrome safety", - "perform check google chrome security", - "perform check google password", - "perform check google passwords", - "perform check google safety", - "perform check google security", - "perform check password", - "perform check password browser", - "perform check password chrome", - "perform check password google", - "perform check password google chrome", - "perform check passwords", - "perform check passwords browser", - "perform check passwords chrome", - "perform check passwords google", - "perform check passwords google chrome", - "perform check safety", - "perform check safety browser", - "perform check safety chrome", - "perform check safety google", - "perform check safety google chrome", - "perform check security", - "perform check security browser", - "perform check security chrome", - "perform check security google", - "perform check security google chrome", - "perform checks browser password", - "perform checks browser passwords", - "perform checks browser safety", - "perform checks browser security", - "perform checks chrome password", - "perform checks chrome passwords", - "perform checks chrome safety", - "perform checks chrome security", - "perform checks google chrome password", - "perform checks google chrome passwords", - "perform checks google chrome safety", - "perform checks google chrome security", - "perform checks google password", - "perform checks google passwords", - "perform checks google safety", - "perform checks google security", - "perform checks password", - "perform checks password browser", - "perform checks password chrome", - "perform checks password google", - "perform checks password google chrome", - "perform checks passwords", - "perform checks passwords browser", - "perform checks passwords chrome", - "perform checks passwords google", - "perform checks passwords google chrome", - "perform checks safety", - "perform checks safety browser", - "perform checks safety chrome", - "perform checks safety google", - "perform checks safety google chrome", - "perform checks security", - "perform checks security browser", - "perform checks security chrome", - "perform checks security google", - "perform checks security google chrome", - "perform checkup browser password", - "perform checkup browser passwords", - "perform checkup browser safety", - "perform checkup browser security", - "perform checkup chrome password", - "perform checkup chrome passwords", - "perform checkup chrome safety", - "perform checkup chrome security", - "perform checkup google chrome password", - "perform checkup google chrome passwords", - "perform checkup google chrome safety", - "perform checkup google chrome security", - "perform checkup google password", - "perform checkup google passwords", - "perform checkup google safety", - "perform checkup google security", - "perform checkup password", - "perform checkup password browser", - "perform checkup password chrome", - "perform checkup password google", - "perform checkup password google chrome", - "perform checkup passwords", - "perform checkup passwords browser", - "perform checkup passwords chrome", - "perform checkup passwords google", - "perform checkup passwords google chrome", - "perform checkup safety", - "perform checkup safety browser", - "perform checkup safety chrome", - "perform checkup safety google", - "perform checkup safety google chrome", - "perform checkup security", - "perform checkup security browser", - "perform checkup security chrome", - "perform checkup security google", - "perform checkup security google chrome", - "perform chrome check password", - "perform chrome check passwords", - "perform chrome check safety", - "perform chrome check security", - "perform chrome checks password", - "perform chrome checks passwords", - "perform chrome checks safety", - "perform chrome checks security", - "perform chrome checkup password", - "perform chrome checkup passwords", - "perform chrome checkup safety", - "perform chrome checkup security", - "perform chrome password check", - "perform chrome password checks", - "perform chrome password checkup", - "perform chrome passwords check", - "perform chrome passwords checks", - "perform chrome passwords checkup", - "perform chrome safety check", - "perform chrome safety checks", - "perform chrome safety checkup", - "perform chrome security check", - "perform chrome security checks", - "perform chrome security checkup", - "perform google check password", - "perform google check passwords", - "perform google check safety", - "perform google check security", - "perform google checks password", - "perform google checks passwords", - "perform google checks safety", - "perform google checks security", - "perform google checkup password", - "perform google checkup passwords", - "perform google checkup safety", - "perform google checkup security", - "perform google chrome check password", - "perform google chrome check passwords", - "perform google chrome check safety", - "perform google chrome check security", - "perform google chrome checks password", - "perform google chrome checks passwords", - "perform google chrome checks safety", - "perform google chrome checks security", - "perform google chrome checkup password", - "perform google chrome checkup passwords", - "perform google chrome checkup safety", - "perform google chrome checkup security", - "perform google chrome password check", - "perform google chrome password checks", - "perform google chrome password checkup", - "perform google chrome passwords check", - "perform google chrome passwords checks", - "perform google chrome passwords checkup", - "perform google chrome safety check", - "perform google chrome safety checks", - "perform google chrome safety checkup", - "perform google chrome security check", - "perform google chrome security checks", - "perform google chrome security checkup", - "perform google password check", - "perform google password checks", - "perform google password checkup", - "perform google passwords check", - "perform google passwords checks", - "perform google passwords checkup", - "perform google safety check", - "perform google safety checks", - "perform google safety checkup", - "perform google security check", - "perform google security checks", - "perform google security checkup", - "perform password browser check", - "perform password browser checks", - "perform password browser checkup", - "perform password check", - "perform password check browser", - "perform password check chrome", - "perform password check google", - "perform password check google chrome", - "perform password checks", - "perform password checks browser", - "perform password checks chrome", - "perform password checks google", - "perform password checks google chrome", - "perform password checkup", - "perform password checkup browser", - "perform password checkup chrome", - "perform password checkup google", - "perform password checkup google chrome", - "perform password chrome check", - "perform password chrome checks", - "perform password chrome checkup", - "perform password google check", - "perform password google checks", - "perform password google checkup", - "perform password google chrome check", - "perform password google chrome checks", - "perform password google chrome checkup", - "perform passwords browser check", - "perform passwords browser checks", - "perform passwords browser checkup", - "perform passwords check", - "perform passwords check browser", - "perform passwords check chrome", - "perform passwords check google", - "perform passwords check google chrome", - "perform passwords checks", - "perform passwords checks browser", - "perform passwords checks chrome", - "perform passwords checks google", - "perform passwords checks google chrome", - "perform passwords checkup", - "perform passwords checkup browser", - "perform passwords checkup chrome", - "perform passwords checkup google", - "perform passwords checkup google chrome", - "perform passwords chrome check", - "perform passwords chrome checks", - "perform passwords chrome checkup", - "perform passwords google check", - "perform passwords google checks", - "perform passwords google checkup", - "perform passwords google chrome check", - "perform passwords google chrome checks", - "perform passwords google chrome checkup", - "perform safety browser check", - "perform safety browser checks", - "perform safety browser checkup", - "perform safety check", - "perform safety check browser", - "perform safety check chrome", - "perform safety check google", - "perform safety check google chrome", - "perform safety checks", - "perform safety checks browser", - "perform safety checks chrome", - "perform safety checks google", - "perform safety checks google chrome", - "perform safety checkup", - "perform safety checkup browser", - "perform safety checkup chrome", - "perform safety checkup google", - "perform safety checkup google chrome", - "perform safety chrome check", - "perform safety chrome checks", - "perform safety chrome checkup", - "perform safety google check", - "perform safety google checks", - "perform safety google checkup", - "perform safety google chrome check", - "perform safety google chrome checks", - "perform safety google chrome checkup", - "perform security browser check", - "perform security browser checks", - "perform security browser checkup", - "perform security check", - "perform security check browser", - "perform security check chrome", - "perform security check google", - "perform security check google chrome", - "perform security checks", - "perform security checks browser", - "perform security checks chrome", - "perform security checks google", - "perform security checks google chrome", - "perform security checkup", - "perform security checkup browser", - "perform security checkup chrome", - "perform security checkup google", - "perform security checkup google chrome", - "perform security chrome check", - "perform security chrome checks", - "perform security chrome checkup", - "perform security google check", - "perform security google checks", - "perform security google checkup", - "perform security google chrome check", - "perform security google chrome checks", - "perform security google chrome checkup", - "run browser check password", - "run browser check passwords", - "run browser check safety", - "run browser check security", - "run browser checks password", - "run browser checks passwords", - "run browser checks safety", - "run browser checks security", - "run browser checkup password", - "run browser checkup passwords", - "run browser checkup safety", - "run browser checkup security", - "run browser password check", - "run browser password checks", - "run browser password checkup", - "run browser passwords check", - "run browser passwords checks", - "run browser passwords checkup", - "run browser safety check", - "run browser safety checks", - "run browser safety checkup", - "run browser security check", - "run browser security checks", - "run browser security checkup", - "run check browser password", - "run check browser passwords", - "run check browser safety", - "run check browser security", - "run check chrome password", - "run check chrome passwords", - "run check chrome safety", - "run check chrome security", - "run check google chrome password", - "run check google chrome passwords", - "run check google chrome safety", - "run check google chrome security", - "run check google password", - "run check google passwords", - "run check google safety", - "run check google security", - "run check password", - "run check password browser", - "run check password chrome", - "run check password google", - "run check password google chrome", - "run check passwords", - "run check passwords browser", - "run check passwords chrome", - "run check passwords google", - "run check passwords google chrome", - "run check safety", - "run check safety browser", - "run check safety chrome", - "run check safety google", - "run check safety google chrome", - "run check security", - "run check security browser", - "run check security chrome", - "run check security google", - "run check security google chrome", - "run checks browser password", - "run checks browser passwords", - "run checks browser safety", - "run checks browser security", - "run checks chrome password", - "run checks chrome passwords", - "run checks chrome safety", - "run checks chrome security", - "run checks google chrome password", - "run checks google chrome passwords", - "run checks google chrome safety", - "run checks google chrome security", - "run checks google password", - "run checks google passwords", - "run checks google safety", - "run checks google security", - "run checks password", - "run checks password browser", - "run checks password chrome", - "run checks password google", - "run checks password google chrome", - "run checks passwords", - "run checks passwords browser", - "run checks passwords chrome", - "run checks passwords google", - "run checks passwords google chrome", - "run checks safety", - "run checks safety browser", - "run checks safety chrome", - "run checks safety google", - "run checks safety google chrome", - "run checks security", - "run checks security browser", - "run checks security chrome", - "run checks security google", - "run checks security google chrome", - "run checkup browser password", - "run checkup browser passwords", - "run checkup browser safety", - "run checkup browser security", - "run checkup chrome password", - "run checkup chrome passwords", - "run checkup chrome safety", - "run checkup chrome security", - "run checkup google chrome password", - "run checkup google chrome passwords", - "run checkup google chrome safety", - "run checkup google chrome security", - "run checkup google password", - "run checkup google passwords", - "run checkup google safety", - "run checkup google security", - "run checkup password", - "run checkup password browser", - "run checkup password chrome", - "run checkup password google", - "run checkup password google chrome", - "run checkup passwords", - "run checkup passwords browser", - "run checkup passwords chrome", - "run checkup passwords google", - "run checkup passwords google chrome", - "run checkup safety", - "run checkup safety browser", - "run checkup safety chrome", - "run checkup safety google", - "run checkup safety google chrome", - "run checkup security", - "run checkup security browser", - "run checkup security chrome", - "run checkup security google", - "run checkup security google chrome", - "run chrome check password", - "run chrome check passwords", - "run chrome check safety", - "run chrome check security", - "run chrome checks password", - "run chrome checks passwords", - "run chrome checks safety", - "run chrome checks security", - "run chrome checkup password", - "run chrome checkup passwords", - "run chrome checkup safety", - "run chrome checkup security", - "run chrome password check", - "run chrome password checks", - "run chrome password checkup", - "run chrome passwords check", - "run chrome passwords checks", - "run chrome passwords checkup", - "run chrome safety check", - "run chrome safety checks", - "run chrome safety checkup", - "run chrome security check", - "run chrome security checks", - "run chrome security checkup", - "run google check password", - "run google check passwords", - "run google check safety", - "run google check security", - "run google checks password", - "run google checks passwords", - "run google checks safety", - "run google checks security", - "run google checkup password", - "run google checkup passwords", - "run google checkup safety", - "run google checkup security", - "run google chrome check password", - "run google chrome check passwords", - "run google chrome check safety", - "run google chrome check security", - "run google chrome checks password", - "run google chrome checks passwords", - "run google chrome checks safety", - "run google chrome checks security", - "run google chrome checkup password", - "run google chrome checkup passwords", - "run google chrome checkup safety", - "run google chrome checkup security", - "run google chrome password check", - "run google chrome password checks", - "run google chrome password checkup", - "run google chrome passwords check", - "run google chrome passwords checks", - "run google chrome passwords checkup", - "run google chrome safety check", - "run google chrome safety checks", - "run google chrome safety checkup", - "run google chrome security check", - "run google chrome security checks", - "run google chrome security checkup", - "run google password check", - "run google password checks", - "run google password checkup", - "run google passwords check", - "run google passwords checks", - "run google passwords checkup", - "run google safety check", - "run google safety checks", - "run google safety checkup", - "run google security check", - "run google security checks", - "run google security checkup", - "run password browser check", - "run password browser checks", - "run password browser checkup", - "run password check", - "run password check browser", - "run password check chrome", - "run password check google", - "run password check google chrome", - "run password checks", - "run password checks browser", - "run password checks chrome", - "run password checks google", - "run password checks google chrome", - "run password checkup", - "run password checkup browser", - "run password checkup chrome", - "run password checkup google", - "run password checkup google chrome", - "run password chrome check", - "run password chrome checks", - "run password chrome checkup", - "run password google check", - "run password google checks", - "run password google checkup", - "run password google chrome check", - "run password google chrome checks", - "run password google chrome checkup", - "run passwords browser check", - "run passwords browser checks", - "run passwords browser checkup", - "run passwords check", - "run passwords check browser", - "run passwords check chrome", - "run passwords check google", - "run passwords check google chrome", - "run passwords checks", - "run passwords checks browser", - "run passwords checks chrome", - "run passwords checks google", - "run passwords checks google chrome", - "run passwords checkup", - "run passwords checkup browser", - "run passwords checkup chrome", - "run passwords checkup google", - "run passwords checkup google chrome", - "run passwords chrome check", - "run passwords chrome checks", - "run passwords chrome checkup", - "run passwords google check", - "run passwords google checks", - "run passwords google checkup", - "run passwords google chrome check", - "run passwords google chrome checks", - "run passwords google chrome checkup", - "run safety browser check", - "run safety browser checks", - "run safety browser checkup", - "run safety check", - "run safety check browser", - "run safety check chrome", - "run safety check google", - "run safety check google chrome", - "run safety checks", - "run safety checks browser", - "run safety checks chrome", - "run safety checks google", - "run safety checks google chrome", - "run safety checkup", - "run safety checkup browser", - "run safety checkup chrome", - "run safety checkup google", - "run safety checkup google chrome", - "run safety chrome check", - "run safety chrome checks", - "run safety chrome checkup", - "run safety google check", - "run safety google checks", - "run safety google checkup", - "run safety google chrome check", - "run safety google chrome checks", - "run safety google chrome checkup", - "run security browser check", - "run security browser checks", - "run security browser checkup", - "run security check", - "run security check browser", - "run security check chrome", - "run security check google", - "run security check google chrome", - "run security checks", - "run security checks browser", - "run security checks chrome", - "run security checks google", - "run security checks google chrome", - "run security checkup", - "run security checkup browser", - "run security checkup chrome", - "run security checkup google", - "run security checkup google chrome", - "run security chrome check", - "run security chrome checks", - "run security chrome checkup", - "run security google check", - "run security google checks", - "run security google checkup", - "run security google chrome check", - "run security google chrome checks", - "run security google chrome checkup", - "safety activate browser check", - "safety activate browser checks", - "safety activate browser checkup", - "safety activate check", - "safety activate check browser", - "safety activate check chrome", - "safety activate check google", - "safety activate check google chrome", - "safety activate checks", - "safety activate checks browser", - "safety activate checks chrome", - "safety activate checks google", - "safety activate checks google chrome", - "safety activate checkup", - "safety activate checkup browser", - "safety activate checkup chrome", - "safety activate checkup google", - "safety activate checkup google chrome", - "safety activate chrome check", - "safety activate chrome checks", - "safety activate chrome checkup", - "safety activate google check", - "safety activate google checks", - "safety activate google checkup", - "safety activate google chrome check", - "safety activate google chrome checks", - "safety activate google chrome checkup", - "safety browser activate check", - "safety browser activate checks", - "safety browser activate checkup", - "safety browser check", - "safety browser check activate", - "safety browser check perform", - "safety browser check run", - "safety browser check use", - "safety browser checks", - "safety browser checks activate", - "safety browser checks perform", - "safety browser checks run", - "safety browser checks use", - "safety browser checkup", - "safety browser checkup activate", - "safety browser checkup perform", - "safety browser checkup run", - "safety browser checkup use", - "safety browser perform check", - "safety browser perform checks", - "safety browser perform checkup", - "safety browser run check", - "safety browser run checks", - "safety browser run checkup", - "safety browser use check", - "safety browser use checks", - "safety browser use checkup", - "safety check", - "safety check activate", - "safety check activate browser", - "safety check activate chrome", - "safety check activate google", - "safety check activate google chrome", - "safety check browser", - "safety check browser activate", - "safety check browser perform", - "safety check browser run", - "safety check browser use", - "safety check chrome", - "safety check chrome activate", - "safety check chrome perform", - "safety check chrome run", - "safety check chrome use", - "safety check google", - "safety check google activate", - "safety check google chrome", - "safety check google chrome activate", - "safety check google chrome perform", - "safety check google chrome run", - "safety check google chrome use", - "safety check google perform", - "safety check google run", - "safety check google use", - "safety check perform", - "safety check perform browser", - "safety check perform chrome", - "safety check perform google", - "safety check perform google chrome", - "safety check run", - "safety check run browser", - "safety check run chrome", - "safety check run google", - "safety check run google chrome", - "safety check use", - "safety check use browser", - "safety check use chrome", - "safety check use google", - "safety check use google chrome", - "safety checks", - "safety checks activate", - "safety checks activate browser", - "safety checks activate chrome", - "safety checks activate google", - "safety checks activate google chrome", - "safety checks browser", - "safety checks browser activate", - "safety checks browser perform", - "safety checks browser run", - "safety checks browser use", - "safety checks chrome", - "safety checks chrome activate", - "safety checks chrome perform", - "safety checks chrome run", - "safety checks chrome use", - "safety checks google", - "safety checks google activate", - "safety checks google chrome", - "safety checks google chrome activate", - "safety checks google chrome perform", - "safety checks google chrome run", - "safety checks google chrome use", - "safety checks google perform", - "safety checks google run", - "safety checks google use", - "safety checks perform", - "safety checks perform browser", - "safety checks perform chrome", - "safety checks perform google", - "safety checks perform google chrome", - "safety checks run", - "safety checks run browser", - "safety checks run chrome", - "safety checks run google", - "safety checks run google chrome", - "safety checks use", - "safety checks use browser", - "safety checks use chrome", - "safety checks use google", - "safety checks use google chrome", - "safety checkup", - "safety checkup activate", - "safety checkup activate browser", - "safety checkup activate chrome", - "safety checkup activate google", - "safety checkup activate google chrome", - "safety checkup browser", - "safety checkup browser activate", - "safety checkup browser perform", - "safety checkup browser run", - "safety checkup browser use", - "safety checkup chrome", - "safety checkup chrome activate", - "safety checkup chrome perform", - "safety checkup chrome run", - "safety checkup chrome use", - "safety checkup google", - "safety checkup google activate", - "safety checkup google chrome", - "safety checkup google chrome activate", - "safety checkup google chrome perform", - "safety checkup google chrome run", - "safety checkup google chrome use", - "safety checkup google perform", - "safety checkup google run", - "safety checkup google use", - "safety checkup perform", - "safety checkup perform browser", - "safety checkup perform chrome", - "safety checkup perform google", - "safety checkup perform google chrome", - "safety checkup run", - "safety checkup run browser", - "safety checkup run chrome", - "safety checkup run google", - "safety checkup run google chrome", - "safety checkup use", - "safety checkup use browser", - "safety checkup use chrome", - "safety checkup use google", - "safety checkup use google chrome", - "safety chrome activate check", - "safety chrome activate checks", - "safety chrome activate checkup", - "safety chrome check", - "safety chrome check activate", - "safety chrome check perform", - "safety chrome check run", - "safety chrome check use", - "safety chrome checks", - "safety chrome checks activate", - "safety chrome checks perform", - "safety chrome checks run", - "safety chrome checks use", - "safety chrome checkup", - "safety chrome checkup activate", - "safety chrome checkup perform", - "safety chrome checkup run", - "safety chrome checkup use", - "safety chrome perform check", - "safety chrome perform checks", - "safety chrome perform checkup", - "safety chrome run check", - "safety chrome run checks", - "safety chrome run checkup", - "safety chrome use check", - "safety chrome use checks", - "safety chrome use checkup", - "safety google activate check", - "safety google activate checks", - "safety google activate checkup", - "safety google check", - "safety google check activate", - "safety google check perform", - "safety google check run", - "safety google check use", - "safety google checks", - "safety google checks activate", - "safety google checks perform", - "safety google checks run", - "safety google checks use", - "safety google checkup", - "safety google checkup activate", - "safety google checkup perform", - "safety google checkup run", - "safety google checkup use", - "safety google chrome activate check", - "safety google chrome activate checks", - "safety google chrome activate checkup", - "safety google chrome check", - "safety google chrome check activate", - "safety google chrome check perform", - "safety google chrome check run", - "safety google chrome check use", - "safety google chrome checks", - "safety google chrome checks activate", - "safety google chrome checks perform", - "safety google chrome checks run", - "safety google chrome checks use", - "safety google chrome checkup", - "safety google chrome checkup activate", - "safety google chrome checkup perform", - "safety google chrome checkup run", - "safety google chrome checkup use", - "safety google chrome perform check", - "safety google chrome perform checks", - "safety google chrome perform checkup", - "safety google chrome run check", - "safety google chrome run checks", - "safety google chrome run checkup", - "safety google chrome use check", - "safety google chrome use checks", - "safety google chrome use checkup", - "safety google perform check", - "safety google perform checks", - "safety google perform checkup", - "safety google run check", - "safety google run checks", - "safety google run checkup", - "safety google use check", - "safety google use checks", - "safety google use checkup", - "safety perform browser check", - "safety perform browser checks", - "safety perform browser checkup", - "safety perform check", - "safety perform check browser", - "safety perform check chrome", - "safety perform check google", - "safety perform check google chrome", - "safety perform checks", - "safety perform checks browser", - "safety perform checks chrome", - "safety perform checks google", - "safety perform checks google chrome", - "safety perform checkup", - "safety perform checkup browser", - "safety perform checkup chrome", - "safety perform checkup google", - "safety perform checkup google chrome", - "safety perform chrome check", - "safety perform chrome checks", - "safety perform chrome checkup", - "safety perform google check", - "safety perform google checks", - "safety perform google checkup", - "safety perform google chrome check", - "safety perform google chrome checks", - "safety perform google chrome checkup", - "safety run browser check", - "safety run browser checks", - "safety run browser checkup", - "safety run check", - "safety run check browser", - "safety run check chrome", - "safety run check google", - "safety run check google chrome", - "safety run checks", - "safety run checks browser", - "safety run checks chrome", - "safety run checks google", - "safety run checks google chrome", - "safety run checkup", - "safety run checkup browser", - "safety run checkup chrome", - "safety run checkup google", - "safety run checkup google chrome", - "safety run chrome check", - "safety run chrome checks", - "safety run chrome checkup", - "safety run google check", - "safety run google checks", - "safety run google checkup", - "safety run google chrome check", - "safety run google chrome checks", - "safety run google chrome checkup", - "safety use browser check", - "safety use browser checks", - "safety use browser checkup", - "safety use check", - "safety use check browser", - "safety use check chrome", - "safety use check google", - "safety use check google chrome", - "safety use checks", - "safety use checks browser", - "safety use checks chrome", - "safety use checks google", - "safety use checks google chrome", - "safety use checkup", - "safety use checkup browser", - "safety use checkup chrome", - "safety use checkup google", - "safety use checkup google chrome", - "safety use chrome check", - "safety use chrome checks", - "safety use chrome checkup", - "safety use google check", - "safety use google checks", - "safety use google checkup", - "safety use google chrome check", - "safety use google chrome checks", - "safety use google chrome checkup", - "security activate browser check", - "security activate browser checks", - "security activate browser checkup", - "security activate check", - "security activate check browser", - "security activate check chrome", - "security activate check google", - "security activate check google chrome", - "security activate checks", - "security activate checks browser", - "security activate checks chrome", - "security activate checks google", - "security activate checks google chrome", - "security activate checkup", - "security activate checkup browser", - "security activate checkup chrome", - "security activate checkup google", - "security activate checkup google chrome", - "security activate chrome check", - "security activate chrome checks", - "security activate chrome checkup", - "security activate google check", - "security activate google checks", - "security activate google checkup", - "security activate google chrome check", - "security activate google chrome checks", - "security activate google chrome checkup", - "security browser activate check", - "security browser activate checks", - "security browser activate checkup", - "security browser check", - "security browser check activate", - "security browser check perform", - "security browser check run", - "security browser check use", - "security browser checks", - "security browser checks activate", - "security browser checks perform", - "security browser checks run", - "security browser checks use", - "security browser checkup", - "security browser checkup activate", - "security browser checkup perform", - "security browser checkup run", - "security browser checkup use", - "security browser perform check", - "security browser perform checks", - "security browser perform checkup", - "security browser run check", - "security browser run checks", - "security browser run checkup", - "security browser use check", - "security browser use checks", - "security browser use checkup", - "security check", - "security check activate", - "security check activate browser", - "security check activate chrome", - "security check activate google", - "security check activate google chrome", - "security check browser", - "security check browser activate", - "security check browser perform", - "security check browser run", - "security check browser use", - "security check chrome", - "security check chrome activate", - "security check chrome perform", - "security check chrome run", - "security check chrome use", - "security check google", - "security check google activate", - "security check google chrome", - "security check google chrome activate", - "security check google chrome perform", - "security check google chrome run", - "security check google chrome use", - "security check google perform", - "security check google run", - "security check google use", - "security check perform", - "security check perform browser", - "security check perform chrome", - "security check perform google", - "security check perform google chrome", - "security check run", - "security check run browser", - "security check run chrome", - "security check run google", - "security check run google chrome", - "security check use", - "security check use browser", - "security check use chrome", - "security check use google", - "security check use google chrome", - "security checks", - "security checks activate", - "security checks activate browser", - "security checks activate chrome", - "security checks activate google", - "security checks activate google chrome", - "security checks browser", - "security checks browser activate", - "security checks browser perform", - "security checks browser run", - "security checks browser use", - "security checks chrome", - "security checks chrome activate", - "security checks chrome perform", - "security checks chrome run", - "security checks chrome use", - "security checks google", - "security checks google activate", - "security checks google chrome", - "security checks google chrome activate", - "security checks google chrome perform", - "security checks google chrome run", - "security checks google chrome use", - "security checks google perform", - "security checks google run", - "security checks google use", - "security checks perform", - "security checks perform browser", - "security checks perform chrome", - "security checks perform google", - "security checks perform google chrome", - "security checks run", - "security checks run browser", - "security checks run chrome", - "security checks run google", - "security checks run google chrome", - "security checks use", - "security checks use browser", - "security checks use chrome", - "security checks use google", - "security checks use google chrome", - "security checkup", - "security checkup activate", - "security checkup activate browser", - "security checkup activate chrome", - "security checkup activate google", - "security checkup activate google chrome", - "security checkup browser", - "security checkup browser activate", - "security checkup browser perform", - "security checkup browser run", - "security checkup browser use", - "security checkup chrome", - "security checkup chrome activate", - "security checkup chrome perform", - "security checkup chrome run", - "security checkup chrome use", - "security checkup google", - "security checkup google activate", - "security checkup google chrome", - "security checkup google chrome activate", - "security checkup google chrome perform", - "security checkup google chrome run", - "security checkup google chrome use", - "security checkup google perform", - "security checkup google run", - "security checkup google use", - "security checkup perform", - "security checkup perform browser", - "security checkup perform chrome", - "security checkup perform google", - "security checkup perform google chrome", - "security checkup run", - "security checkup run browser", - "security checkup run chrome", - "security checkup run google", - "security checkup run google chrome", - "security checkup use", - "security checkup use browser", - "security checkup use chrome", - "security checkup use google", - "security checkup use google chrome", - "security chrome activate check", - "security chrome activate checks", - "security chrome activate checkup", - "security chrome check", - "security chrome check activate", - "security chrome check perform", - "security chrome check run", - "security chrome check use", - "security chrome checks", - "security chrome checks activate", - "security chrome checks perform", - "security chrome checks run", - "security chrome checks use", - "security chrome checkup", - "security chrome checkup activate", - "security chrome checkup perform", - "security chrome checkup run", - "security chrome checkup use", - "security chrome perform check", - "security chrome perform checks", - "security chrome perform checkup", - "security chrome run check", - "security chrome run checks", - "security chrome run checkup", - "security chrome use check", - "security chrome use checks", - "security chrome use checkup", - "security google activate check", - "security google activate checks", - "security google activate checkup", - "security google check", - "security google check activate", - "security google check perform", - "security google check run", - "security google check use", - "security google checks", - "security google checks activate", - "security google checks perform", - "security google checks run", - "security google checks use", - "security google checkup", - "security google checkup activate", - "security google checkup perform", - "security google checkup run", - "security google checkup use", - "security google chrome activate check", - "security google chrome activate checks", - "security google chrome activate checkup", - "security google chrome check", - "security google chrome check activate", - "security google chrome check perform", - "security google chrome check run", - "security google chrome check use", - "security google chrome checks", - "security google chrome checks activate", - "security google chrome checks perform", - "security google chrome checks run", - "security google chrome checks use", - "security google chrome checkup", - "security google chrome checkup activate", - "security google chrome checkup perform", - "security google chrome checkup run", - "security google chrome checkup use", - "security google chrome perform check", - "security google chrome perform checks", - "security google chrome perform checkup", - "security google chrome run check", - "security google chrome run checks", - "security google chrome run checkup", - "security google chrome use check", - "security google chrome use checks", - "security google chrome use checkup", - "security google perform check", - "security google perform checks", - "security google perform checkup", - "security google run check", - "security google run checks", - "security google run checkup", - "security google use check", - "security google use checks", - "security google use checkup", - "security perform browser check", - "security perform browser checks", - "security perform browser checkup", - "security perform check", - "security perform check browser", - "security perform check chrome", - "security perform check google", - "security perform check google chrome", - "security perform checks", - "security perform checks browser", - "security perform checks chrome", - "security perform checks google", - "security perform checks google chrome", - "security perform checkup", - "security perform checkup browser", - "security perform checkup chrome", - "security perform checkup google", - "security perform checkup google chrome", - "security perform chrome check", - "security perform chrome checks", - "security perform chrome checkup", - "security perform google check", - "security perform google checks", - "security perform google checkup", - "security perform google chrome check", - "security perform google chrome checks", - "security perform google chrome checkup", - "security run browser check", - "security run browser checks", - "security run browser checkup", - "security run check", - "security run check browser", - "security run check chrome", - "security run check google", - "security run check google chrome", - "security run checks", - "security run checks browser", - "security run checks chrome", - "security run checks google", - "security run checks google chrome", - "security run checkup", - "security run checkup browser", - "security run checkup chrome", - "security run checkup google", - "security run checkup google chrome", - "security run chrome check", - "security run chrome checks", - "security run chrome checkup", - "security run google check", - "security run google checks", - "security run google checkup", - "security run google chrome check", - "security run google chrome checks", - "security run google chrome checkup", - "security use browser check", - "security use browser checks", - "security use browser checkup", - "security use check", - "security use check browser", - "security use check chrome", - "security use check google", - "security use check google chrome", - "security use checks", - "security use checks browser", - "security use checks chrome", - "security use checks google", - "security use checks google chrome", - "security use checkup", - "security use checkup browser", - "security use checkup chrome", - "security use checkup google", - "security use checkup google chrome", - "security use chrome check", - "security use chrome checks", - "security use chrome checkup", - "security use google check", - "security use google checks", - "security use google checkup", - "security use google chrome check", - "security use google chrome checks", - "security use google chrome checkup", - "use browser check password", - "use browser check passwords", - "use browser check safety", - "use browser check security", - "use browser checks password", - "use browser checks passwords", - "use browser checks safety", - "use browser checks security", - "use browser checkup password", - "use browser checkup passwords", - "use browser checkup safety", - "use browser checkup security", - "use browser password check", - "use browser password checks", - "use browser password checkup", - "use browser passwords check", - "use browser passwords checks", - "use browser passwords checkup", - "use browser safety check", - "use browser safety checks", - "use browser safety checkup", - "use browser security check", - "use browser security checks", - "use browser security checkup", - "use check browser password", - "use check browser passwords", - "use check browser safety", - "use check browser security", - "use check chrome password", - "use check chrome passwords", - "use check chrome safety", - "use check chrome security", - "use check google chrome password", - "use check google chrome passwords", - "use check google chrome safety", - "use check google chrome security", - "use check google password", - "use check google passwords", - "use check google safety", - "use check google security", - "use check password", - "use check password browser", - "use check password chrome", - "use check password google", - "use check password google chrome", - "use check passwords", - "use check passwords browser", - "use check passwords chrome", - "use check passwords google", - "use check passwords google chrome", - "use check safety", - "use check safety browser", - "use check safety chrome", - "use check safety google", - "use check safety google chrome", - "use check security", - "use check security browser", - "use check security chrome", - "use check security google", - "use check security google chrome", - "use checks browser password", - "use checks browser passwords", - "use checks browser safety", - "use checks browser security", - "use checks chrome password", - "use checks chrome passwords", - "use checks chrome safety", - "use checks chrome security", - "use checks google chrome password", - "use checks google chrome passwords", - "use checks google chrome safety", - "use checks google chrome security", - "use checks google password", - "use checks google passwords", - "use checks google safety", - "use checks google security", - "use checks password", - "use checks password browser", - "use checks password chrome", - "use checks password google", - "use checks password google chrome", - "use checks passwords", - "use checks passwords browser", - "use checks passwords chrome", - "use checks passwords google", - "use checks passwords google chrome", - "use checks safety", - "use checks safety browser", - "use checks safety chrome", - "use checks safety google", - "use checks safety google chrome", - "use checks security", - "use checks security browser", - "use checks security chrome", - "use checks security google", - "use checks security google chrome", - "use checkup browser password", - "use checkup browser passwords", - "use checkup browser safety", - "use checkup browser security", - "use checkup chrome password", - "use checkup chrome passwords", - "use checkup chrome safety", - "use checkup chrome security", - "use checkup google chrome password", - "use checkup google chrome passwords", - "use checkup google chrome safety", - "use checkup google chrome security", - "use checkup google password", - "use checkup google passwords", - "use checkup google safety", - "use checkup google security", - "use checkup password", - "use checkup password browser", - "use checkup password chrome", - "use checkup password google", - "use checkup password google chrome", - "use checkup passwords", - "use checkup passwords browser", - "use checkup passwords chrome", - "use checkup passwords google", - "use checkup passwords google chrome", - "use checkup safety", - "use checkup safety browser", - "use checkup safety chrome", - "use checkup safety google", - "use checkup safety google chrome", - "use checkup security", - "use checkup security browser", - "use checkup security chrome", - "use checkup security google", - "use checkup security google chrome", - "use chrome check password", - "use chrome check passwords", - "use chrome check safety", - "use chrome check security", - "use chrome checks password", - "use chrome checks passwords", - "use chrome checks safety", - "use chrome checks security", - "use chrome checkup password", - "use chrome checkup passwords", - "use chrome checkup safety", - "use chrome checkup security", - "use chrome password check", - "use chrome password checks", - "use chrome password checkup", - "use chrome passwords check", - "use chrome passwords checks", - "use chrome passwords checkup", - "use chrome safety check", - "use chrome safety checks", - "use chrome safety checkup", - "use chrome security check", - "use chrome security checks", - "use chrome security checkup", - "use google check password", - "use google check passwords", - "use google check safety", - "use google check security", - "use google checks password", - "use google checks passwords", - "use google checks safety", - "use google checks security", - "use google checkup password", - "use google checkup passwords", - "use google checkup safety", - "use google checkup security", - "use google chrome check password", - "use google chrome check passwords", - "use google chrome check safety", - "use google chrome check security", - "use google chrome checks password", - "use google chrome checks passwords", - "use google chrome checks safety", - "use google chrome checks security", - "use google chrome checkup password", - "use google chrome checkup passwords", - "use google chrome checkup safety", - "use google chrome checkup security", - "use google chrome password check", - "use google chrome password checks", - "use google chrome password checkup", - "use google chrome passwords check", - "use google chrome passwords checks", - "use google chrome passwords checkup", - "use google chrome safety check", - "use google chrome safety checks", - "use google chrome safety checkup", - "use google chrome security check", - "use google chrome security checks", - "use google chrome security checkup", - "use google password check", - "use google password checks", - "use google password checkup", - "use google passwords check", - "use google passwords checks", - "use google passwords checkup", - "use google safety check", - "use google safety checks", - "use google safety checkup", - "use google security check", - "use google security checks", - "use google security checkup", - "use password browser check", - "use password browser checks", - "use password browser checkup", - "use password check", - "use password check browser", - "use password check chrome", - "use password check google", - "use password check google chrome", - "use password checks", - "use password checks browser", - "use password checks chrome", - "use password checks google", - "use password checks google chrome", - "use password checkup", - "use password checkup browser", - "use password checkup chrome", - "use password checkup google", - "use password checkup google chrome", - "use password chrome check", - "use password chrome checks", - "use password chrome checkup", - "use password google check", - "use password google checks", - "use password google checkup", - "use password google chrome check", - "use password google chrome checks", - "use password google chrome checkup", - "use passwords browser check", - "use passwords browser checks", - "use passwords browser checkup", - "use passwords check", - "use passwords check browser", - "use passwords check chrome", - "use passwords check google", - "use passwords check google chrome", - "use passwords checks", - "use passwords checks browser", - "use passwords checks chrome", - "use passwords checks google", - "use passwords checks google chrome", - "use passwords checkup", - "use passwords checkup browser", - "use passwords checkup chrome", - "use passwords checkup google", - "use passwords checkup google chrome", - "use passwords chrome check", - "use passwords chrome checks", - "use passwords chrome checkup", - "use passwords google check", - "use passwords google checks", - "use passwords google checkup", - "use passwords google chrome check", - "use passwords google chrome checks", - "use passwords google chrome checkup", - "use safety browser check", - "use safety browser checks", - "use safety browser checkup", - "use safety check", - "use safety check browser", - "use safety check chrome", - "use safety check google", - "use safety check google chrome", - "use safety checks", - "use safety checks browser", - "use safety checks chrome", - "use safety checks google", - "use safety checks google chrome", - "use safety checkup", - "use safety checkup browser", - "use safety checkup chrome", - "use safety checkup google", - "use safety checkup google chrome", - "use safety chrome check", - "use safety chrome checks", - "use safety chrome checkup", - "use safety google check", - "use safety google checks", - "use safety google checkup", - "use safety google chrome check", - "use safety google chrome checks", - "use safety google chrome checkup", - "use security browser check", - "use security browser checks", - "use security browser checkup", - "use security check", - "use security check browser", - "use security check chrome", - "use security check google", - "use security check google chrome", - "use security checks", - "use security checks browser", - "use security checks chrome", - "use security checks google", - "use security checks google chrome", - "use security checkup", - "use security checkup browser", - "use security checkup chrome", - "use security checkup google", - "use security checkup google chrome", - "use security chrome check", - "use security chrome checks", - "use security chrome checkup", - "use security google check", - "use security google checks", - "use security google checkup", - "use security google chrome check", - "use security google chrome checks", - "use security google chrome checkup", - }, - - // ID#8 - { - // Generated suggestions: - "alter browse certificates", - "alter browse enhanced protection", - "alter browse safely", - "alter browse secure dns", - "alter browse securely", - "alter browse security keys", - "alter browse security settings", - "alter browse standard protection", - "alter browser certificates", - "alter browser enhanced protection", - "alter browser safely", - "alter browser secure dns", - "alter browser securely", - "alter browser security keys", - "alter browser security settings", - "alter browser standard protection", - "alter browsing certificates", - "alter browsing enhanced protection", - "alter browsing safely", - "alter browsing secure dns", - "alter browsing securely", - "alter browsing security keys", - "alter browsing security settings", - "alter browsing standard protection", - "alter certificates", - "alter certificates browse", - "alter certificates browser", - "alter certificates browsing", - "alter certificates change", - "alter certificates chrome", - "alter certificates google", - "alter certificates google chrome", - "alter certificates manage", - "alter change certificates", - "alter change enhanced protection", - "alter change safely", - "alter change secure dns", - "alter change securely", - "alter change security keys", - "alter change security settings", - "alter change standard protection", - "alter chrome certificates", - "alter chrome enhanced protection", - "alter chrome safely", - "alter chrome secure dns", - "alter chrome securely", - "alter chrome security keys", - "alter chrome security settings", - "alter chrome standard protection", - "alter enhanced protection", - "alter enhanced protection browse", - "alter enhanced protection browser", - "alter enhanced protection browsing", - "alter enhanced protection change", - "alter enhanced protection chrome", - "alter enhanced protection google", - "alter enhanced protection google chrome", - "alter enhanced protection manage", - "alter google certificates", - "alter google chrome certificates", - "alter google chrome enhanced protection", - "alter google chrome safely", - "alter google chrome secure dns", - "alter google chrome securely", - "alter google chrome security keys", - "alter google chrome security settings", - "alter google chrome standard protection", - "alter google enhanced protection", - "alter google safely", - "alter google secure dns", - "alter google securely", - "alter google security keys", - "alter google security settings", - "alter google standard protection", - "alter manage certificates", - "alter manage enhanced protection", - "alter manage safely", - "alter manage secure dns", - "alter manage securely", - "alter manage security keys", - "alter manage security settings", - "alter manage standard protection", - "alter safely", - "alter safely browse", - "alter safely browser", - "alter safely browsing", - "alter safely change", - "alter safely chrome", - "alter safely google", - "alter safely google chrome", - "alter safely manage", - "alter secure dns", - "alter secure dns browse", - "alter secure dns browser", - "alter secure dns browsing", - "alter secure dns change", - "alter secure dns chrome", - "alter secure dns google", - "alter secure dns google chrome", - "alter secure dns manage", - "alter securely", - "alter securely browse", - "alter securely browser", - "alter securely browsing", - "alter securely change", - "alter securely chrome", - "alter securely google", - "alter securely google chrome", - "alter securely manage", - "alter security keys", - "alter security keys browse", - "alter security keys browser", - "alter security keys browsing", - "alter security keys change", - "alter security keys chrome", - "alter security keys google", - "alter security keys google chrome", - "alter security keys manage", - "alter security settings", - "alter security settings browse", - "alter security settings browser", - "alter security settings browsing", - "alter security settings change", - "alter security settings chrome", - "alter security settings google", - "alter security settings google chrome", - "alter security settings manage", - "alter standard protection", - "alter standard protection browse", - "alter standard protection browser", - "alter standard protection browsing", - "alter standard protection change", - "alter standard protection chrome", - "alter standard protection google", - "alter standard protection google chrome", - "alter standard protection manage", - "browse alter certificates", - "browse alter enhanced protection", - "browse alter safely", - "browse alter secure dns", - "browse alter securely", - "browse alter security keys", - "browse alter security settings", - "browse alter standard protection", - "browse certificates", - "browse certificates alter", - "browse certificates use", - "browse enhanced protection", - "browse enhanced protection alter", - "browse enhanced protection use", - "browse safely", - "browse safely alter", - "browse safely use", - "browse secure dns", - "browse secure dns alter", - "browse secure dns use", - "browse securely", - "browse securely alter", - "browse securely use", - "browse security keys", - "browse security keys alter", - "browse security keys use", - "browse security settings", - "browse security settings alter", - "browse security settings use", - "browse standard protection", - "browse standard protection alter", - "browse standard protection use", - "browse use certificates", - "browse use enhanced protection", - "browse use safely", - "browse use secure dns", - "browse use securely", - "browse use security keys", - "browse use security settings", - "browse use standard protection", - "browser alter certificates", - "browser alter enhanced protection", - "browser alter safely", - "browser alter secure dns", - "browser alter securely", - "browser alter security keys", - "browser alter security settings", - "browser alter standard protection", - "browser certificates", - "browser certificates alter", - "browser certificates use", - "browser enhanced protection", - "browser enhanced protection alter", - "browser enhanced protection use", - "browser safely", - "browser safely alter", - "browser safely use", - "browser secure dns", - "browser secure dns alter", - "browser secure dns use", - "browser securely", - "browser securely alter", - "browser securely use", - "browser security keys", - "browser security keys alter", - "browser security keys use", - "browser security settings", - "browser security settings alter", - "browser security settings use", - "browser standard protection", - "browser standard protection alter", - "browser standard protection use", - "browser use certificates", - "browser use enhanced protection", - "browser use safely", - "browser use secure dns", - "browser use securely", - "browser use security keys", - "browser use security settings", - "browser use standard protection", - "browsing alter certificates", - "browsing alter enhanced protection", - "browsing alter safely", - "browsing alter secure dns", - "browsing alter securely", - "browsing alter security keys", - "browsing alter security settings", - "browsing alter standard protection", - "browsing certificates", - "browsing certificates alter", - "browsing certificates use", - "browsing enhanced protection", - "browsing enhanced protection alter", - "browsing enhanced protection use", - "browsing safely", - "browsing safely alter", - "browsing safely use", - "browsing secure dns", - "browsing secure dns alter", - "browsing secure dns use", - "browsing securely", - "browsing securely alter", - "browsing securely use", - "browsing security keys", - "browsing security keys alter", - "browsing security keys use", - "browsing security settings", - "browsing security settings alter", - "browsing security settings use", - "browsing standard protection", - "browsing standard protection alter", - "browsing standard protection use", - "browsing use certificates", - "browsing use enhanced protection", - "browsing use safely", - "browsing use secure dns", - "browsing use securely", - "browsing use security keys", - "browsing use security settings", - "browsing use standard protection", - "certificates", - "certificates alter", - "certificates alter browse", - "certificates alter browser", - "certificates alter browsing", - "certificates alter change", - "certificates alter chrome", - "certificates alter google", - "certificates alter google chrome", - "certificates alter manage", - "certificates browse", - "certificates browse alter", - "certificates browse use", - "certificates browser", - "certificates browser alter", - "certificates browser use", - "certificates browsing", - "certificates browsing alter", - "certificates browsing use", - "certificates change", - "certificates change alter", - "certificates change use", - "certificates chrome", - "certificates chrome alter", - "certificates chrome use", - "certificates google", - "certificates google alter", - "certificates google chrome", - "certificates google chrome alter", - "certificates google chrome use", - "certificates google use", - "certificates manage", - "certificates manage alter", - "certificates manage use", - "certificates use", - "certificates use browse", - "certificates use browser", - "certificates use browsing", - "certificates use change", - "certificates use chrome", - "certificates use google", - "certificates use google chrome", - "certificates use manage", - "change alter certificates", - "change alter enhanced protection", - "change alter safely", - "change alter secure dns", - "change alter securely", - "change alter security keys", - "change alter security settings", - "change alter standard protection", - "change certificates", - "change certificates alter", - "change certificates use", - "change enhanced protection", - "change enhanced protection alter", - "change enhanced protection use", - "change safely", - "change safely alter", - "change safely use", - "change secure dns", - "change secure dns alter", - "change secure dns use", - "change securely", - "change securely alter", - "change securely use", - "change security keys", - "change security keys alter", - "change security keys use", - "change security settings", - "change security settings alter", - "change security settings use", - "change standard protection", - "change standard protection alter", - "change standard protection use", - "change use certificates", - "change use enhanced protection", - "change use safely", - "change use secure dns", - "change use securely", - "change use security keys", - "change use security settings", - "change use standard protection", - "chrome alter certificates", - "chrome alter enhanced protection", - "chrome alter safely", - "chrome alter secure dns", - "chrome alter securely", - "chrome alter security keys", - "chrome alter security settings", - "chrome alter standard protection", - "chrome certificates", - "chrome certificates alter", - "chrome certificates use", - "chrome enhanced protection", - "chrome enhanced protection alter", - "chrome enhanced protection use", - "chrome safely", - "chrome safely alter", - "chrome safely use", - "chrome secure dns", - "chrome secure dns alter", - "chrome secure dns use", - "chrome securely", - "chrome securely alter", - "chrome securely use", - "chrome security keys", - "chrome security keys alter", - "chrome security keys use", - "chrome security settings", - "chrome security settings alter", - "chrome security settings use", - "chrome standard protection", - "chrome standard protection alter", - "chrome standard protection use", - "chrome use certificates", - "chrome use enhanced protection", - "chrome use safely", - "chrome use secure dns", - "chrome use securely", - "chrome use security keys", - "chrome use security settings", - "chrome use standard protection", - "enhanced protection", - "enhanced protection alter", - "enhanced protection alter browse", - "enhanced protection alter browser", - "enhanced protection alter browsing", - "enhanced protection alter change", - "enhanced protection alter chrome", - "enhanced protection alter google", - "enhanced protection alter google chrome", - "enhanced protection alter manage", - "enhanced protection browse", - "enhanced protection browse alter", - "enhanced protection browse use", - "enhanced protection browser", - "enhanced protection browser alter", - "enhanced protection browser use", - "enhanced protection browsing", - "enhanced protection browsing alter", - "enhanced protection browsing use", - "enhanced protection change", - "enhanced protection change alter", - "enhanced protection change use", - "enhanced protection chrome", - "enhanced protection chrome alter", - "enhanced protection chrome use", - "enhanced protection google", - "enhanced protection google alter", - "enhanced protection google chrome", - "enhanced protection google chrome alter", - "enhanced protection google chrome use", - "enhanced protection google use", - "enhanced protection manage", - "enhanced protection manage alter", - "enhanced protection manage use", - "enhanced protection use", - "enhanced protection use browse", - "enhanced protection use browser", - "enhanced protection use browsing", - "enhanced protection use change", - "enhanced protection use chrome", - "enhanced protection use google", - "enhanced protection use google chrome", - "enhanced protection use manage", - "google alter certificates", - "google alter enhanced protection", - "google alter safely", - "google alter secure dns", - "google alter securely", - "google alter security keys", - "google alter security settings", - "google alter standard protection", - "google certificates", - "google certificates alter", - "google certificates use", - "google chrome alter certificates", - "google chrome alter enhanced protection", - "google chrome alter safely", - "google chrome alter secure dns", - "google chrome alter securely", - "google chrome alter security keys", - "google chrome alter security settings", - "google chrome alter standard protection", - "google chrome certificates", - "google chrome certificates alter", - "google chrome certificates use", - "google chrome enhanced protection", - "google chrome enhanced protection alter", - "google chrome enhanced protection use", - "google chrome safely", - "google chrome safely alter", - "google chrome safely use", - "google chrome secure dns", - "google chrome secure dns alter", - "google chrome secure dns use", - "google chrome securely", - "google chrome securely alter", - "google chrome securely use", - "google chrome security keys", - "google chrome security keys alter", - "google chrome security keys use", - "google chrome security settings", - "google chrome security settings alter", - "google chrome security settings use", - "google chrome standard protection", - "google chrome standard protection alter", - "google chrome standard protection use", - "google chrome use certificates", - "google chrome use enhanced protection", - "google chrome use safely", - "google chrome use secure dns", - "google chrome use securely", - "google chrome use security keys", - "google chrome use security settings", - "google chrome use standard protection", - "google enhanced protection", - "google enhanced protection alter", - "google enhanced protection use", - "google safely", - "google safely alter", - "google safely use", - "google secure dns", - "google secure dns alter", - "google secure dns use", - "google securely", - "google securely alter", - "google securely use", - "google security keys", - "google security keys alter", - "google security keys use", - "google security settings", - "google security settings alter", - "google security settings use", - "google standard protection", - "google standard protection alter", - "google standard protection use", - "google use certificates", - "google use enhanced protection", - "google use safely", - "google use secure dns", - "google use securely", - "google use security keys", - "google use security settings", - "google use standard protection", - "manage alter certificates", - "manage alter enhanced protection", - "manage alter safely", - "manage alter secure dns", - "manage alter securely", - "manage alter security keys", - "manage alter security settings", - "manage alter standard protection", - "manage certificates", - "manage certificates alter", - "manage certificates use", - "manage enhanced protection", - "manage enhanced protection alter", - "manage enhanced protection use", - "manage safely", - "manage safely alter", - "manage safely use", - "manage secure dns", - "manage secure dns alter", - "manage secure dns use", - "manage securely", - "manage securely alter", - "manage securely use", - "manage security keys", - "manage security keys alter", - "manage security keys use", - "manage security settings", - "manage security settings alter", - "manage security settings use", - "manage standard protection", - "manage standard protection alter", - "manage standard protection use", - "manage use certificates", - "manage use enhanced protection", - "manage use safely", - "manage use secure dns", - "manage use securely", - "manage use security keys", - "manage use security settings", - "manage use standard protection", - "safely", - "safely alter", - "safely alter browse", - "safely alter browser", - "safely alter browsing", - "safely alter change", - "safely alter chrome", - "safely alter google", - "safely alter google chrome", - "safely alter manage", - "safely browse", - "safely browse alter", - "safely browse use", - "safely browser", - "safely browser alter", - "safely browser use", - "safely browsing", - "safely browsing alter", - "safely browsing use", - "safely change", - "safely change alter", - "safely change use", - "safely chrome", - "safely chrome alter", - "safely chrome use", - "safely google", - "safely google alter", - "safely google chrome", - "safely google chrome alter", - "safely google chrome use", - "safely google use", - "safely manage", - "safely manage alter", - "safely manage use", - "safely use", - "safely use browse", - "safely use browser", - "safely use browsing", - "safely use change", - "safely use chrome", - "safely use google", - "safely use google chrome", - "safely use manage", - "secure dns", - "secure dns alter", - "secure dns alter browse", - "secure dns alter browser", - "secure dns alter browsing", - "secure dns alter change", - "secure dns alter chrome", - "secure dns alter google", - "secure dns alter google chrome", - "secure dns alter manage", - "secure dns browse", - "secure dns browse alter", - "secure dns browse use", - "secure dns browser", - "secure dns browser alter", - "secure dns browser use", - "secure dns browsing", - "secure dns browsing alter", - "secure dns browsing use", - "secure dns change", - "secure dns change alter", - "secure dns change use", - "secure dns chrome", - "secure dns chrome alter", - "secure dns chrome use", - "secure dns google", - "secure dns google alter", - "secure dns google chrome", - "secure dns google chrome alter", - "secure dns google chrome use", - "secure dns google use", - "secure dns manage", - "secure dns manage alter", - "secure dns manage use", - "secure dns use", - "secure dns use browse", - "secure dns use browser", - "secure dns use browsing", - "secure dns use change", - "secure dns use chrome", - "secure dns use google", - "secure dns use google chrome", - "secure dns use manage", - "securely", - "securely alter", - "securely alter browse", - "securely alter browser", - "securely alter browsing", - "securely alter change", - "securely alter chrome", - "securely alter google", - "securely alter google chrome", - "securely alter manage", - "securely browse", - "securely browse alter", - "securely browse use", - "securely browser", - "securely browser alter", - "securely browser use", - "securely browsing", - "securely browsing alter", - "securely browsing use", - "securely change", - "securely change alter", - "securely change use", - "securely chrome", - "securely chrome alter", - "securely chrome use", - "securely google", - "securely google alter", - "securely google chrome", - "securely google chrome alter", - "securely google chrome use", - "securely google use", - "securely manage", - "securely manage alter", - "securely manage use", - "securely use", - "securely use browse", - "securely use browser", - "securely use browsing", - "securely use change", - "securely use chrome", - "securely use google", - "securely use google chrome", - "securely use manage", - "security keys", - "security keys alter", - "security keys alter browse", - "security keys alter browser", - "security keys alter browsing", - "security keys alter change", - "security keys alter chrome", - "security keys alter google", - "security keys alter google chrome", - "security keys alter manage", - "security keys browse", - "security keys browse alter", - "security keys browse use", - "security keys browser", - "security keys browser alter", - "security keys browser use", - "security keys browsing", - "security keys browsing alter", - "security keys browsing use", - "security keys change", - "security keys change alter", - "security keys change use", - "security keys chrome", - "security keys chrome alter", - "security keys chrome use", - "security keys google", - "security keys google alter", - "security keys google chrome", - "security keys google chrome alter", - "security keys google chrome use", - "security keys google use", - "security keys manage", - "security keys manage alter", - "security keys manage use", - "security keys use", - "security keys use browse", - "security keys use browser", - "security keys use browsing", - "security keys use change", - "security keys use chrome", - "security keys use google", - "security keys use google chrome", - "security keys use manage", - "security settings", - "security settings alter", - "security settings alter browse", - "security settings alter browser", - "security settings alter browsing", - "security settings alter change", - "security settings alter chrome", - "security settings alter google", - "security settings alter google chrome", - "security settings alter manage", - "security settings browse", - "security settings browse alter", - "security settings browse use", - "security settings browser", - "security settings browser alter", - "security settings browser use", - "security settings browsing", - "security settings browsing alter", - "security settings browsing use", - "security settings change", - "security settings change alter", - "security settings change use", - "security settings chrome", - "security settings chrome alter", - "security settings chrome use", - "security settings google", - "security settings google alter", - "security settings google chrome", - "security settings google chrome alter", - "security settings google chrome use", - "security settings google use", - "security settings manage", - "security settings manage alter", - "security settings manage use", - "security settings use", - "security settings use browse", - "security settings use browser", - "security settings use browsing", - "security settings use change", - "security settings use chrome", - "security settings use google", - "security settings use google chrome", - "security settings use manage", - "standard protection", - "standard protection alter", - "standard protection alter browse", - "standard protection alter browser", - "standard protection alter browsing", - "standard protection alter change", - "standard protection alter chrome", - "standard protection alter google", - "standard protection alter google chrome", - "standard protection alter manage", - "standard protection browse", - "standard protection browse alter", - "standard protection browse use", - "standard protection browser", - "standard protection browser alter", - "standard protection browser use", - "standard protection browsing", - "standard protection browsing alter", - "standard protection browsing use", - "standard protection change", - "standard protection change alter", - "standard protection change use", - "standard protection chrome", - "standard protection chrome alter", - "standard protection chrome use", - "standard protection google", - "standard protection google alter", - "standard protection google chrome", - "standard protection google chrome alter", - "standard protection google chrome use", - "standard protection google use", - "standard protection manage", - "standard protection manage alter", - "standard protection manage use", - "standard protection use", - "standard protection use browse", - "standard protection use browser", - "standard protection use browsing", - "standard protection use change", - "standard protection use chrome", - "standard protection use google", - "standard protection use google chrome", - "standard protection use manage", - "use browse certificates", - "use browse enhanced protection", - "use browse safely", - "use browse secure dns", - "use browse securely", - "use browse security keys", - "use browse security settings", - "use browse standard protection", - "use browser certificates", - "use browser enhanced protection", - "use browser safely", - "use browser secure dns", - "use browser securely", - "use browser security keys", - "use browser security settings", - "use browser standard protection", - "use browsing certificates", - "use browsing enhanced protection", - "use browsing safely", - "use browsing secure dns", - "use browsing securely", - "use browsing security keys", - "use browsing security settings", - "use browsing standard protection", - "use certificates", - "use certificates browse", - "use certificates browser", - "use certificates browsing", - "use certificates change", - "use certificates chrome", - "use certificates google", - "use certificates google chrome", - "use certificates manage", - "use change certificates", - "use change enhanced protection", - "use change safely", - "use change secure dns", - "use change securely", - "use change security keys", - "use change security settings", - "use change standard protection", - "use chrome certificates", - "use chrome enhanced protection", - "use chrome safely", - "use chrome secure dns", - "use chrome securely", - "use chrome security keys", - "use chrome security settings", - "use chrome standard protection", - "use enhanced protection", - "use enhanced protection browse", - "use enhanced protection browser", - "use enhanced protection browsing", - "use enhanced protection change", - "use enhanced protection chrome", - "use enhanced protection google", - "use enhanced protection google chrome", - "use enhanced protection manage", - "use google certificates", - "use google chrome certificates", - "use google chrome enhanced protection", - "use google chrome safely", - "use google chrome secure dns", - "use google chrome securely", - "use google chrome security keys", - "use google chrome security settings", - "use google chrome standard protection", - "use google enhanced protection", - "use google safely", - "use google secure dns", - "use google securely", - "use google security keys", - "use google security settings", - "use google standard protection", - "use manage certificates", - "use manage enhanced protection", - "use manage safely", - "use manage secure dns", - "use manage securely", - "use manage security keys", - "use manage security settings", - "use manage standard protection", - "use safely", - "use safely browse", - "use safely browser", - "use safely browsing", - "use safely change", - "use safely chrome", - "use safely google", - "use safely google chrome", - "use safely manage", - "use secure dns", - "use secure dns browse", - "use secure dns browser", - "use secure dns browsing", - "use secure dns change", - "use secure dns chrome", - "use secure dns google", - "use secure dns google chrome", - "use secure dns manage", - "use securely", - "use securely browse", - "use securely browser", - "use securely browsing", - "use securely change", - "use securely chrome", - "use securely google", - "use securely google chrome", - "use securely manage", - "use security keys", - "use security keys browse", - "use security keys browser", - "use security keys browsing", - "use security keys change", - "use security keys chrome", - "use security keys google", - "use security keys google chrome", - "use security keys manage", - "use security settings", - "use security settings browse", - "use security settings browser", - "use security settings browsing", - "use security settings change", - "use security settings chrome", - "use security settings google", - "use security settings google chrome", - "use security settings manage", - "use standard protection", - "use standard protection browse", - "use standard protection browser", - "use standard protection browsing", - "use standard protection change", - "use standard protection chrome", - "use standard protection google", - "use standard protection google chrome", - "use standard protection manage", - }, - - // ID#9 - { - // Generated suggestions: - "all allow cookie settings", - "all allow cookies", - "all allow do not track", - "all alter cookie settings", - "all alter cookies", - "all alter do not track", - "all block cookie settings", - "all block cookies", - "all block do not track", - "all browser cookie settings", - "all browser cookies", - "all browser do not track", - "all chrome cookie settings", - "all chrome cookies", - "all chrome do not track", - "all control cookie settings", - "all control cookies", - "all control do not track", - "all cookie settings allow", - "all cookie settings alter", - "all cookie settings block", - "all cookie settings browser", - "all cookie settings chrome", - "all cookie settings control", - "all cookie settings disallow", - "all cookie settings google", - "all cookie settings google chrome", - "all cookie settings manage", - "all cookie settings use", - "all cookies allow", - "all cookies alter", - "all cookies block", - "all cookies browser", - "all cookies chrome", - "all cookies control", - "all cookies disallow", - "all cookies google", - "all cookies google chrome", - "all cookies manage", - "all cookies use", - "all disallow cookie settings", - "all disallow cookies", - "all disallow do not track", - "all do not track allow", - "all do not track alter", - "all do not track block", - "all do not track browser", - "all do not track chrome", - "all do not track control", - "all do not track disallow", - "all do not track google", - "all do not track google chrome", - "all do not track manage", - "all do not track use", - "all google chrome cookie settings", - "all google chrome cookies", - "all google chrome do not track", - "all google cookie settings", - "all google cookies", - "all google do not track", - "all manage cookie settings", - "all manage cookies", - "all manage do not track", - "all use cookie settings", - "all use cookies", - "all use do not track", - "allow all cookie settings", - "allow all cookies", - "allow all do not track", - "allow cookie settings", - "allow cookie settings all", - "allow cookie settings third party", - "allow cookies", - "allow cookies all", - "allow cookies third party", - "allow do not track", - "allow do not track all", - "allow do not track third party", - "allow third party cookie settings", - "allow third party cookies", - "allow third party do not track", - "alter all cookie settings", - "alter all cookies", - "alter all do not track", - "alter cookie settings", - "alter cookie settings all", - "alter cookie settings third party", - "alter cookies", - "alter cookies all", - "alter cookies third party", - "alter do not track", - "alter do not track all", - "alter do not track third party", - "alter third party cookie settings", - "alter third party cookies", - "alter third party do not track", - "block all cookie settings", - "block all cookies", - "block all do not track", - "block cookie settings", - "block cookie settings all", - "block cookie settings third party", - "block cookies", - "block cookies all", - "block cookies third party", - "block do not track", - "block do not track all", - "block do not track third party", - "block third party cookie settings", - "block third party cookies", - "block third party do not track", - "browser all cookie settings", - "browser all cookies", - "browser all do not track", - "browser cookie settings", - "browser cookie settings all", - "browser cookie settings third party", - "browser cookies", - "browser cookies all", - "browser cookies third party", - "browser do not track", - "browser do not track all", - "browser do not track third party", - "browser third party cookie settings", - "browser third party cookies", - "browser third party do not track", - "chrome all cookie settings", - "chrome all cookies", - "chrome all do not track", - "chrome cookie settings", - "chrome cookie settings all", - "chrome cookie settings third party", - "chrome cookies", - "chrome cookies all", - "chrome cookies third party", - "chrome do not track", - "chrome do not track all", - "chrome do not track third party", - "chrome third party cookie settings", - "chrome third party cookies", - "chrome third party do not track", - "control all cookie settings", - "control all cookies", - "control all do not track", - "control cookie settings", - "control cookie settings all", - "control cookie settings third party", - "control cookies", - "control cookies all", - "control cookies third party", - "control do not track", - "control do not track all", - "control do not track third party", - "control third party cookie settings", - "control third party cookies", - "control third party do not track", - "cookie settings all allow", - "cookie settings all alter", - "cookie settings all block", - "cookie settings all browser", - "cookie settings all chrome", - "cookie settings all control", - "cookie settings all disallow", - "cookie settings all google", - "cookie settings all google chrome", - "cookie settings all manage", - "cookie settings all use", - "cookie settings allow", - "cookie settings allow all", - "cookie settings allow third party", - "cookie settings alter", - "cookie settings alter all", - "cookie settings alter third party", - "cookie settings block", - "cookie settings block all", - "cookie settings block third party", - "cookie settings browser", - "cookie settings browser all", - "cookie settings browser third party", - "cookie settings chrome", - "cookie settings chrome all", - "cookie settings chrome third party", - "cookie settings control", - "cookie settings control all", - "cookie settings control third party", - "cookie settings disallow", - "cookie settings disallow all", - "cookie settings disallow third party", - "cookie settings google", - "cookie settings google all", - "cookie settings google chrome", - "cookie settings google chrome all", - "cookie settings google chrome third party", - "cookie settings google third party", - "cookie settings manage", - "cookie settings manage all", - "cookie settings manage third party", - "cookie settings third party allow", - "cookie settings third party alter", - "cookie settings third party block", - "cookie settings third party browser", - "cookie settings third party chrome", - "cookie settings third party control", - "cookie settings third party disallow", - "cookie settings third party google", - "cookie settings third party google chrome", - "cookie settings third party manage", - "cookie settings third party use", - "cookie settings use", - "cookie settings use all", - "cookie settings use third party", - "cookies all allow", - "cookies all alter", - "cookies all block", - "cookies all browser", - "cookies all chrome", - "cookies all control", - "cookies all disallow", - "cookies all google", - "cookies all google chrome", - "cookies all manage", - "cookies all use", - "cookies allow", - "cookies allow all", - "cookies allow third party", - "cookies alter", - "cookies alter all", - "cookies alter third party", - "cookies block", - "cookies block all", - "cookies block third party", - "cookies browser", - "cookies browser all", - "cookies browser third party", - "cookies chrome", - "cookies chrome all", - "cookies chrome third party", - "cookies control", - "cookies control all", - "cookies control third party", - "cookies disallow", - "cookies disallow all", - "cookies disallow third party", - "cookies google", - "cookies google all", - "cookies google chrome", - "cookies google chrome all", - "cookies google chrome third party", - "cookies google third party", - "cookies manage", - "cookies manage all", - "cookies manage third party", - "cookies third party allow", - "cookies third party alter", - "cookies third party block", - "cookies third party browser", - "cookies third party chrome", - "cookies third party control", - "cookies third party disallow", - "cookies third party google", - "cookies third party google chrome", - "cookies third party manage", - "cookies third party use", - "cookies use", - "cookies use all", - "cookies use third party", - "disallow all cookie settings", - "disallow all cookies", - "disallow all do not track", - "disallow cookie settings", - "disallow cookie settings all", - "disallow cookie settings third party", - "disallow cookies", - "disallow cookies all", - "disallow cookies third party", - "disallow do not track", - "disallow do not track all", - "disallow do not track third party", - "disallow third party cookie settings", - "disallow third party cookies", - "disallow third party do not track", - "do not track all allow", - "do not track all alter", - "do not track all block", - "do not track all browser", - "do not track all chrome", - "do not track all control", - "do not track all disallow", - "do not track all google", - "do not track all google chrome", - "do not track all manage", - "do not track all use", - "do not track allow", - "do not track allow all", - "do not track allow third party", - "do not track alter", - "do not track alter all", - "do not track alter third party", - "do not track block", - "do not track block all", - "do not track block third party", - "do not track browser", - "do not track browser all", - "do not track browser third party", - "do not track chrome", - "do not track chrome all", - "do not track chrome third party", - "do not track control", - "do not track control all", - "do not track control third party", - "do not track disallow", - "do not track disallow all", - "do not track disallow third party", - "do not track google", - "do not track google all", - "do not track google chrome", - "do not track google chrome all", - "do not track google chrome third party", - "do not track google third party", - "do not track manage", - "do not track manage all", - "do not track manage third party", - "do not track third party allow", - "do not track third party alter", - "do not track third party block", - "do not track third party browser", - "do not track third party chrome", - "do not track third party control", - "do not track third party disallow", - "do not track third party google", - "do not track third party google chrome", - "do not track third party manage", - "do not track third party use", - "do not track use", - "do not track use all", - "do not track use third party", - "google all cookie settings", - "google all cookies", - "google all do not track", - "google chrome all cookie settings", - "google chrome all cookies", - "google chrome all do not track", - "google chrome cookie settings", - "google chrome cookie settings all", - "google chrome cookie settings third party", - "google chrome cookies", - "google chrome cookies all", - "google chrome cookies third party", - "google chrome do not track", - "google chrome do not track all", - "google chrome do not track third party", - "google chrome third party cookie settings", - "google chrome third party cookies", - "google chrome third party do not track", - "google cookie settings", - "google cookie settings all", - "google cookie settings third party", - "google cookies", - "google cookies all", - "google cookies third party", - "google do not track", - "google do not track all", - "google do not track third party", - "google third party cookie settings", - "google third party cookies", - "google third party do not track", - "manage all cookie settings", - "manage all cookies", - "manage all do not track", - "manage cookie settings", - "manage cookie settings all", - "manage cookie settings third party", - "manage cookies", - "manage cookies all", - "manage cookies third party", - "manage do not track", - "manage do not track all", - "manage do not track third party", - "manage third party cookie settings", - "manage third party cookies", - "manage third party do not track", - "third party allow cookie settings", - "third party allow cookies", - "third party allow do not track", - "third party alter cookie settings", - "third party alter cookies", - "third party alter do not track", - "third party block cookie settings", - "third party block cookies", - "third party block do not track", - "third party browser cookie settings", - "third party browser cookies", - "third party browser do not track", - "third party chrome cookie settings", - "third party chrome cookies", - "third party chrome do not track", - "third party control cookie settings", - "third party control cookies", - "third party control do not track", - "third party cookie settings allow", - "third party cookie settings alter", - "third party cookie settings block", - "third party cookie settings browser", - "third party cookie settings chrome", - "third party cookie settings control", - "third party cookie settings disallow", - "third party cookie settings google", - "third party cookie settings google chrome", - "third party cookie settings manage", - "third party cookie settings use", - "third party cookies allow", - "third party cookies alter", - "third party cookies block", - "third party cookies browser", - "third party cookies chrome", - "third party cookies control", - "third party cookies disallow", - "third party cookies google", - "third party cookies google chrome", - "third party cookies manage", - "third party cookies use", - "third party disallow cookie settings", - "third party disallow cookies", - "third party disallow do not track", - "third party do not track allow", - "third party do not track alter", - "third party do not track block", - "third party do not track browser", - "third party do not track chrome", - "third party do not track control", - "third party do not track disallow", - "third party do not track google", - "third party do not track google chrome", - "third party do not track manage", - "third party do not track use", - "third party google chrome cookie settings", - "third party google chrome cookies", - "third party google chrome do not track", - "third party google cookie settings", - "third party google cookies", - "third party google do not track", - "third party manage cookie settings", - "third party manage cookies", - "third party manage do not track", - "third party use cookie settings", - "third party use cookies", - "third party use do not track", - "use all cookie settings", - "use all cookies", - "use all do not track", - "use cookie settings", - "use cookie settings all", - "use cookie settings third party", - "use cookies", - "use cookies all", - "use cookies third party", - "use do not track", - "use do not track all", - "use do not track third party", - "use third party cookie settings", - "use third party cookies", - "use third party do not track", - }, - - // ID#10 - { - // Generated suggestions: - "add address", - "add address browser", - "add address chrome", - "add address google", - "add address google chrome", - "add addresses", - "add addresses browser", - "add addresses chrome", - "add addresses google", - "add addresses google chrome", - "add browser address", - "add browser addresses", - "add browser new address", - "add browser shipping address", - "add browser shipping addresses", - "add chrome address", - "add chrome addresses", - "add chrome new address", - "add chrome shipping address", - "add chrome shipping addresses", - "add google address", - "add google addresses", - "add google chrome address", - "add google chrome addresses", - "add google chrome new address", - "add google chrome shipping address", - "add google chrome shipping addresses", - "add google new address", - "add google shipping address", - "add google shipping addresses", - "add new address", - "add new address browser", - "add new address chrome", - "add new address google", - "add new address google chrome", - "add shipping address", - "add shipping address browser", - "add shipping address chrome", - "add shipping address google", - "add shipping address google chrome", - "add shipping addresses", - "add shipping addresses browser", - "add shipping addresses chrome", - "add shipping addresses google", - "add shipping addresses google chrome", - "address add", - "address add browser", - "address add chrome", - "address add google", - "address add google chrome", - "address adjust", - "address adjust browser", - "address adjust chrome", - "address adjust google", - "address adjust google chrome", - "address browser add", - "address browser adjust", - "address browser change", - "address browser control", - "address browser delete", - "address browser edit", - "address browser manage", - "address browser store", - "address change", - "address change browser", - "address change chrome", - "address change google", - "address change google chrome", - "address chrome add", - "address chrome adjust", - "address chrome change", - "address chrome control", - "address chrome delete", - "address chrome edit", - "address chrome manage", - "address chrome store", - "address control", - "address control browser", - "address control chrome", - "address control google", - "address control google chrome", - "address delete", - "address delete browser", - "address delete chrome", - "address delete google", - "address delete google chrome", - "address edit", - "address edit browser", - "address edit chrome", - "address edit google", - "address edit google chrome", - "address google add", - "address google adjust", - "address google change", - "address google chrome add", - "address google chrome adjust", - "address google chrome change", - "address google chrome control", - "address google chrome delete", - "address google chrome edit", - "address google chrome manage", - "address google chrome store", - "address google control", - "address google delete", - "address google edit", - "address google manage", - "address google store", - "address manage", - "address manage browser", - "address manage chrome", - "address manage google", - "address manage google chrome", - "address store", - "address store browser", - "address store chrome", - "address store google", - "address store google chrome", - "addresses add", - "addresses add browser", - "addresses add chrome", - "addresses add google", - "addresses add google chrome", - "addresses adjust", - "addresses adjust browser", - "addresses adjust chrome", - "addresses adjust google", - "addresses adjust google chrome", - "addresses browser add", - "addresses browser adjust", - "addresses browser change", - "addresses browser control", - "addresses browser delete", - "addresses browser edit", - "addresses browser manage", - "addresses browser store", - "addresses change", - "addresses change browser", - "addresses change chrome", - "addresses change google", - "addresses change google chrome", - "addresses chrome add", - "addresses chrome adjust", - "addresses chrome change", - "addresses chrome control", - "addresses chrome delete", - "addresses chrome edit", - "addresses chrome manage", - "addresses chrome store", - "addresses control", - "addresses control browser", - "addresses control chrome", - "addresses control google", - "addresses control google chrome", - "addresses delete", - "addresses delete browser", - "addresses delete chrome", - "addresses delete google", - "addresses delete google chrome", - "addresses edit", - "addresses edit browser", - "addresses edit chrome", - "addresses edit google", - "addresses edit google chrome", - "addresses google add", - "addresses google adjust", - "addresses google change", - "addresses google chrome add", - "addresses google chrome adjust", - "addresses google chrome change", - "addresses google chrome control", - "addresses google chrome delete", - "addresses google chrome edit", - "addresses google chrome manage", - "addresses google chrome store", - "addresses google control", - "addresses google delete", - "addresses google edit", - "addresses google manage", - "addresses google store", - "addresses manage", - "addresses manage browser", - "addresses manage chrome", - "addresses manage google", - "addresses manage google chrome", - "addresses store", - "addresses store browser", - "addresses store chrome", - "addresses store google", - "addresses store google chrome", - "adjust address", - "adjust address browser", - "adjust address chrome", - "adjust address google", - "adjust address google chrome", - "adjust addresses", - "adjust addresses browser", - "adjust addresses chrome", - "adjust addresses google", - "adjust addresses google chrome", - "adjust browser address", - "adjust browser addresses", - "adjust browser new address", - "adjust browser shipping address", - "adjust browser shipping addresses", - "adjust chrome address", - "adjust chrome addresses", - "adjust chrome new address", - "adjust chrome shipping address", - "adjust chrome shipping addresses", - "adjust google address", - "adjust google addresses", - "adjust google chrome address", - "adjust google chrome addresses", - "adjust google chrome new address", - "adjust google chrome shipping address", - "adjust google chrome shipping addresses", - "adjust google new address", - "adjust google shipping address", - "adjust google shipping addresses", - "adjust new address", - "adjust new address browser", - "adjust new address chrome", - "adjust new address google", - "adjust new address google chrome", - "adjust shipping address", - "adjust shipping address browser", - "adjust shipping address chrome", - "adjust shipping address google", - "adjust shipping address google chrome", - "adjust shipping addresses", - "adjust shipping addresses browser", - "adjust shipping addresses chrome", - "adjust shipping addresses google", - "adjust shipping addresses google chrome", - "browser add address", - "browser add addresses", - "browser add new address", - "browser add shipping address", - "browser add shipping addresses", - "browser address add", - "browser address adjust", - "browser address change", - "browser address control", - "browser address delete", - "browser address edit", - "browser address manage", - "browser address store", - "browser addresses add", - "browser addresses adjust", - "browser addresses change", - "browser addresses control", - "browser addresses delete", - "browser addresses edit", - "browser addresses manage", - "browser addresses store", - "browser adjust address", - "browser adjust addresses", - "browser adjust new address", - "browser adjust shipping address", - "browser adjust shipping addresses", - "browser change address", - "browser change addresses", - "browser change new address", - "browser change shipping address", - "browser change shipping addresses", - "browser control address", - "browser control addresses", - "browser control new address", - "browser control shipping address", - "browser control shipping addresses", - "browser delete address", - "browser delete addresses", - "browser delete new address", - "browser delete shipping address", - "browser delete shipping addresses", - "browser edit address", - "browser edit addresses", - "browser edit new address", - "browser edit shipping address", - "browser edit shipping addresses", - "browser manage address", - "browser manage addresses", - "browser manage new address", - "browser manage shipping address", - "browser manage shipping addresses", - "browser new address add", - "browser new address adjust", - "browser new address change", - "browser new address control", - "browser new address delete", - "browser new address edit", - "browser new address manage", - "browser new address store", - "browser shipping address add", - "browser shipping address adjust", - "browser shipping address change", - "browser shipping address control", - "browser shipping address delete", - "browser shipping address edit", - "browser shipping address manage", - "browser shipping address store", - "browser shipping addresses add", - "browser shipping addresses adjust", - "browser shipping addresses change", - "browser shipping addresses control", - "browser shipping addresses delete", - "browser shipping addresses edit", - "browser shipping addresses manage", - "browser shipping addresses store", - "browser store address", - "browser store addresses", - "browser store new address", - "browser store shipping address", - "browser store shipping addresses", - "change address", - "change address browser", - "change address chrome", - "change address google", - "change address google chrome", - "change addresses", - "change addresses browser", - "change addresses chrome", - "change addresses google", - "change addresses google chrome", - "change browser address", - "change browser addresses", - "change browser new address", - "change browser shipping address", - "change browser shipping addresses", - "change chrome address", - "change chrome addresses", - "change chrome new address", - "change chrome shipping address", - "change chrome shipping addresses", - "change google address", - "change google addresses", - "change google chrome address", - "change google chrome addresses", - "change google chrome new address", - "change google chrome shipping address", - "change google chrome shipping addresses", - "change google new address", - "change google shipping address", - "change google shipping addresses", - "change new address", - "change new address browser", - "change new address chrome", - "change new address google", - "change new address google chrome", - "change shipping address", - "change shipping address browser", - "change shipping address chrome", - "change shipping address google", - "change shipping address google chrome", - "change shipping addresses", - "change shipping addresses browser", - "change shipping addresses chrome", - "change shipping addresses google", - "change shipping addresses google chrome", - "chrome add address", - "chrome add addresses", - "chrome add new address", - "chrome add shipping address", - "chrome add shipping addresses", - "chrome address add", - "chrome address adjust", - "chrome address change", - "chrome address control", - "chrome address delete", - "chrome address edit", - "chrome address manage", - "chrome address store", - "chrome addresses add", - "chrome addresses adjust", - "chrome addresses change", - "chrome addresses control", - "chrome addresses delete", - "chrome addresses edit", - "chrome addresses manage", - "chrome addresses store", - "chrome adjust address", - "chrome adjust addresses", - "chrome adjust new address", - "chrome adjust shipping address", - "chrome adjust shipping addresses", - "chrome change address", - "chrome change addresses", - "chrome change new address", - "chrome change shipping address", - "chrome change shipping addresses", - "chrome control address", - "chrome control addresses", - "chrome control new address", - "chrome control shipping address", - "chrome control shipping addresses", - "chrome delete address", - "chrome delete addresses", - "chrome delete new address", - "chrome delete shipping address", - "chrome delete shipping addresses", - "chrome edit address", - "chrome edit addresses", - "chrome edit new address", - "chrome edit shipping address", - "chrome edit shipping addresses", - "chrome manage address", - "chrome manage addresses", - "chrome manage new address", - "chrome manage shipping address", - "chrome manage shipping addresses", - "chrome new address add", - "chrome new address adjust", - "chrome new address change", - "chrome new address control", - "chrome new address delete", - "chrome new address edit", - "chrome new address manage", - "chrome new address store", - "chrome shipping address add", - "chrome shipping address adjust", - "chrome shipping address change", - "chrome shipping address control", - "chrome shipping address delete", - "chrome shipping address edit", - "chrome shipping address manage", - "chrome shipping address store", - "chrome shipping addresses add", - "chrome shipping addresses adjust", - "chrome shipping addresses change", - "chrome shipping addresses control", - "chrome shipping addresses delete", - "chrome shipping addresses edit", - "chrome shipping addresses manage", - "chrome shipping addresses store", - "chrome store address", - "chrome store addresses", - "chrome store new address", - "chrome store shipping address", - "chrome store shipping addresses", - "control address", - "control address browser", - "control address chrome", - "control address google", - "control address google chrome", - "control addresses", - "control addresses browser", - "control addresses chrome", - "control addresses google", - "control addresses google chrome", - "control browser address", - "control browser addresses", - "control browser new address", - "control browser shipping address", - "control browser shipping addresses", - "control chrome address", - "control chrome addresses", - "control chrome new address", - "control chrome shipping address", - "control chrome shipping addresses", - "control google address", - "control google addresses", - "control google chrome address", - "control google chrome addresses", - "control google chrome new address", - "control google chrome shipping address", - "control google chrome shipping addresses", - "control google new address", - "control google shipping address", - "control google shipping addresses", - "control new address", - "control new address browser", - "control new address chrome", - "control new address google", - "control new address google chrome", - "control shipping address", - "control shipping address browser", - "control shipping address chrome", - "control shipping address google", - "control shipping address google chrome", - "control shipping addresses", - "control shipping addresses browser", - "control shipping addresses chrome", - "control shipping addresses google", - "control shipping addresses google chrome", - "delete address", - "delete address browser", - "delete address chrome", - "delete address google", - "delete address google chrome", - "delete addresses", - "delete addresses browser", - "delete addresses chrome", - "delete addresses google", - "delete addresses google chrome", - "delete browser address", - "delete browser addresses", - "delete browser new address", - "delete browser shipping address", - "delete browser shipping addresses", - "delete chrome address", - "delete chrome addresses", - "delete chrome new address", - "delete chrome shipping address", - "delete chrome shipping addresses", - "delete google address", - "delete google addresses", - "delete google chrome address", - "delete google chrome addresses", - "delete google chrome new address", - "delete google chrome shipping address", - "delete google chrome shipping addresses", - "delete google new address", - "delete google shipping address", - "delete google shipping addresses", - "delete new address", - "delete new address browser", - "delete new address chrome", - "delete new address google", - "delete new address google chrome", - "delete shipping address", - "delete shipping address browser", - "delete shipping address chrome", - "delete shipping address google", - "delete shipping address google chrome", - "delete shipping addresses", - "delete shipping addresses browser", - "delete shipping addresses chrome", - "delete shipping addresses google", - "delete shipping addresses google chrome", - "edit address", - "edit address browser", - "edit address chrome", - "edit address google", - "edit address google chrome", - "edit addresses", - "edit addresses browser", - "edit addresses chrome", - "edit addresses google", - "edit addresses google chrome", - "edit browser address", - "edit browser addresses", - "edit browser new address", - "edit browser shipping address", - "edit browser shipping addresses", - "edit chrome address", - "edit chrome addresses", - "edit chrome new address", - "edit chrome shipping address", - "edit chrome shipping addresses", - "edit google address", - "edit google addresses", - "edit google chrome address", - "edit google chrome addresses", - "edit google chrome new address", - "edit google chrome shipping address", - "edit google chrome shipping addresses", - "edit google new address", - "edit google shipping address", - "edit google shipping addresses", - "edit new address", - "edit new address browser", - "edit new address chrome", - "edit new address google", - "edit new address google chrome", - "edit shipping address", - "edit shipping address browser", - "edit shipping address chrome", - "edit shipping address google", - "edit shipping address google chrome", - "edit shipping addresses", - "edit shipping addresses browser", - "edit shipping addresses chrome", - "edit shipping addresses google", - "edit shipping addresses google chrome", - "google add address", - "google add addresses", - "google add new address", - "google add shipping address", - "google add shipping addresses", - "google address add", - "google address adjust", - "google address change", - "google address control", - "google address delete", - "google address edit", - "google address manage", - "google address store", - "google addresses add", - "google addresses adjust", - "google addresses change", - "google addresses control", - "google addresses delete", - "google addresses edit", - "google addresses manage", - "google addresses store", - "google adjust address", - "google adjust addresses", - "google adjust new address", - "google adjust shipping address", - "google adjust shipping addresses", - "google change address", - "google change addresses", - "google change new address", - "google change shipping address", - "google change shipping addresses", - "google chrome add address", - "google chrome add addresses", - "google chrome add new address", - "google chrome add shipping address", - "google chrome add shipping addresses", - "google chrome address add", - "google chrome address adjust", - "google chrome address change", - "google chrome address control", - "google chrome address delete", - "google chrome address edit", - "google chrome address manage", - "google chrome address store", - "google chrome addresses add", - "google chrome addresses adjust", - "google chrome addresses change", - "google chrome addresses control", - "google chrome addresses delete", - "google chrome addresses edit", - "google chrome addresses manage", - "google chrome addresses store", - "google chrome adjust address", - "google chrome adjust addresses", - "google chrome adjust new address", - "google chrome adjust shipping address", - "google chrome adjust shipping addresses", - "google chrome change address", - "google chrome change addresses", - "google chrome change new address", - "google chrome change shipping address", - "google chrome change shipping addresses", - "google chrome control address", - "google chrome control addresses", - "google chrome control new address", - "google chrome control shipping address", - "google chrome control shipping addresses", - "google chrome delete address", - "google chrome delete addresses", - "google chrome delete new address", - "google chrome delete shipping address", - "google chrome delete shipping addresses", - "google chrome edit address", - "google chrome edit addresses", - "google chrome edit new address", - "google chrome edit shipping address", - "google chrome edit shipping addresses", - "google chrome manage address", - "google chrome manage addresses", - "google chrome manage new address", - "google chrome manage shipping address", - "google chrome manage shipping addresses", - "google chrome new address add", - "google chrome new address adjust", - "google chrome new address change", - "google chrome new address control", - "google chrome new address delete", - "google chrome new address edit", - "google chrome new address manage", - "google chrome new address store", - "google chrome shipping address add", - "google chrome shipping address adjust", - "google chrome shipping address change", - "google chrome shipping address control", - "google chrome shipping address delete", - "google chrome shipping address edit", - "google chrome shipping address manage", - "google chrome shipping address store", - "google chrome shipping addresses add", - "google chrome shipping addresses adjust", - "google chrome shipping addresses change", - "google chrome shipping addresses control", - "google chrome shipping addresses delete", - "google chrome shipping addresses edit", - "google chrome shipping addresses manage", - "google chrome shipping addresses store", - "google chrome store address", - "google chrome store addresses", - "google chrome store new address", - "google chrome store shipping address", - "google chrome store shipping addresses", - "google control address", - "google control addresses", - "google control new address", - "google control shipping address", - "google control shipping addresses", - "google delete address", - "google delete addresses", - "google delete new address", - "google delete shipping address", - "google delete shipping addresses", - "google edit address", - "google edit addresses", - "google edit new address", - "google edit shipping address", - "google edit shipping addresses", - "google manage address", - "google manage addresses", - "google manage new address", - "google manage shipping address", - "google manage shipping addresses", - "google new address add", - "google new address adjust", - "google new address change", - "google new address control", - "google new address delete", - "google new address edit", - "google new address manage", - "google new address store", - "google shipping address add", - "google shipping address adjust", - "google shipping address change", - "google shipping address control", - "google shipping address delete", - "google shipping address edit", - "google shipping address manage", - "google shipping address store", - "google shipping addresses add", - "google shipping addresses adjust", - "google shipping addresses change", - "google shipping addresses control", - "google shipping addresses delete", - "google shipping addresses edit", - "google shipping addresses manage", - "google shipping addresses store", - "google store address", - "google store addresses", - "google store new address", - "google store shipping address", - "google store shipping addresses", - "manage address", - "manage address browser", - "manage address chrome", - "manage address google", - "manage address google chrome", - "manage addresses", - "manage addresses browser", - "manage addresses chrome", - "manage addresses google", - "manage addresses google chrome", - "manage browser address", - "manage browser addresses", - "manage browser new address", - "manage browser shipping address", - "manage browser shipping addresses", - "manage chrome address", - "manage chrome addresses", - "manage chrome new address", - "manage chrome shipping address", - "manage chrome shipping addresses", - "manage google address", - "manage google addresses", - "manage google chrome address", - "manage google chrome addresses", - "manage google chrome new address", - "manage google chrome shipping address", - "manage google chrome shipping addresses", - "manage google new address", - "manage google shipping address", - "manage google shipping addresses", - "manage new address", - "manage new address browser", - "manage new address chrome", - "manage new address google", - "manage new address google chrome", - "manage shipping address", - "manage shipping address browser", - "manage shipping address chrome", - "manage shipping address google", - "manage shipping address google chrome", - "manage shipping addresses", - "manage shipping addresses browser", - "manage shipping addresses chrome", - "manage shipping addresses google", - "manage shipping addresses google chrome", - "new address add", - "new address add browser", - "new address add chrome", - "new address add google", - "new address add google chrome", - "new address adjust", - "new address adjust browser", - "new address adjust chrome", - "new address adjust google", - "new address adjust google chrome", - "new address browser add", - "new address browser adjust", - "new address browser change", - "new address browser control", - "new address browser delete", - "new address browser edit", - "new address browser manage", - "new address browser store", - "new address change", - "new address change browser", - "new address change chrome", - "new address change google", - "new address change google chrome", - "new address chrome add", - "new address chrome adjust", - "new address chrome change", - "new address chrome control", - "new address chrome delete", - "new address chrome edit", - "new address chrome manage", - "new address chrome store", - "new address control", - "new address control browser", - "new address control chrome", - "new address control google", - "new address control google chrome", - "new address delete", - "new address delete browser", - "new address delete chrome", - "new address delete google", - "new address delete google chrome", - "new address edit", - "new address edit browser", - "new address edit chrome", - "new address edit google", - "new address edit google chrome", - "new address google add", - "new address google adjust", - "new address google change", - "new address google chrome add", - "new address google chrome adjust", - "new address google chrome change", - "new address google chrome control", - "new address google chrome delete", - "new address google chrome edit", - "new address google chrome manage", - "new address google chrome store", - "new address google control", - "new address google delete", - "new address google edit", - "new address google manage", - "new address google store", - "new address manage", - "new address manage browser", - "new address manage chrome", - "new address manage google", - "new address manage google chrome", - "new address store", - "new address store browser", - "new address store chrome", - "new address store google", - "new address store google chrome", - "shipping address add", - "shipping address add browser", - "shipping address add chrome", - "shipping address add google", - "shipping address add google chrome", - "shipping address adjust", - "shipping address adjust browser", - "shipping address adjust chrome", - "shipping address adjust google", - "shipping address adjust google chrome", - "shipping address browser add", - "shipping address browser adjust", - "shipping address browser change", - "shipping address browser control", - "shipping address browser delete", - "shipping address browser edit", - "shipping address browser manage", - "shipping address browser store", - "shipping address change", - "shipping address change browser", - "shipping address change chrome", - "shipping address change google", - "shipping address change google chrome", - "shipping address chrome add", - "shipping address chrome adjust", - "shipping address chrome change", - "shipping address chrome control", - "shipping address chrome delete", - "shipping address chrome edit", - "shipping address chrome manage", - "shipping address chrome store", - "shipping address control", - "shipping address control browser", - "shipping address control chrome", - "shipping address control google", - "shipping address control google chrome", - "shipping address delete", - "shipping address delete browser", - "shipping address delete chrome", - "shipping address delete google", - "shipping address delete google chrome", - "shipping address edit", - "shipping address edit browser", - "shipping address edit chrome", - "shipping address edit google", - "shipping address edit google chrome", - "shipping address google add", - "shipping address google adjust", - "shipping address google change", - "shipping address google chrome add", - "shipping address google chrome adjust", - "shipping address google chrome change", - "shipping address google chrome control", - "shipping address google chrome delete", - "shipping address google chrome edit", - "shipping address google chrome manage", - "shipping address google chrome store", - "shipping address google control", - "shipping address google delete", - "shipping address google edit", - "shipping address google manage", - "shipping address google store", - "shipping address manage", - "shipping address manage browser", - "shipping address manage chrome", - "shipping address manage google", - "shipping address manage google chrome", - "shipping address store", - "shipping address store browser", - "shipping address store chrome", - "shipping address store google", - "shipping address store google chrome", - "shipping addresses add", - "shipping addresses add browser", - "shipping addresses add chrome", - "shipping addresses add google", - "shipping addresses add google chrome", - "shipping addresses adjust", - "shipping addresses adjust browser", - "shipping addresses adjust chrome", - "shipping addresses adjust google", - "shipping addresses adjust google chrome", - "shipping addresses browser add", - "shipping addresses browser adjust", - "shipping addresses browser change", - "shipping addresses browser control", - "shipping addresses browser delete", - "shipping addresses browser edit", - "shipping addresses browser manage", - "shipping addresses browser store", - "shipping addresses change", - "shipping addresses change browser", - "shipping addresses change chrome", - "shipping addresses change google", - "shipping addresses change google chrome", - "shipping addresses chrome add", - "shipping addresses chrome adjust", - "shipping addresses chrome change", - "shipping addresses chrome control", - "shipping addresses chrome delete", - "shipping addresses chrome edit", - "shipping addresses chrome manage", - "shipping addresses chrome store", - "shipping addresses control", - "shipping addresses control browser", - "shipping addresses control chrome", - "shipping addresses control google", - "shipping addresses control google chrome", - "shipping addresses delete", - "shipping addresses delete browser", - "shipping addresses delete chrome", - "shipping addresses delete google", - "shipping addresses delete google chrome", - "shipping addresses edit", - "shipping addresses edit browser", - "shipping addresses edit chrome", - "shipping addresses edit google", - "shipping addresses edit google chrome", - "shipping addresses google add", - "shipping addresses google adjust", - "shipping addresses google change", - "shipping addresses google chrome add", - "shipping addresses google chrome adjust", - "shipping addresses google chrome change", - "shipping addresses google chrome control", - "shipping addresses google chrome delete", - "shipping addresses google chrome edit", - "shipping addresses google chrome manage", - "shipping addresses google chrome store", - "shipping addresses google control", - "shipping addresses google delete", - "shipping addresses google edit", - "shipping addresses google manage", - "shipping addresses google store", - "shipping addresses manage", - "shipping addresses manage browser", - "shipping addresses manage chrome", - "shipping addresses manage google", - "shipping addresses manage google chrome", - "shipping addresses store", - "shipping addresses store browser", - "shipping addresses store chrome", - "shipping addresses store google", - "shipping addresses store google chrome", - "store address", - "store address browser", - "store address chrome", - "store address google", - "store address google chrome", - "store addresses", - "store addresses browser", - "store addresses chrome", - "store addresses google", - "store addresses google chrome", - "store browser address", - "store browser addresses", - "store browser new address", - "store browser shipping address", - "store browser shipping addresses", - "store chrome address", - "store chrome addresses", - "store chrome new address", - "store chrome shipping address", - "store chrome shipping addresses", - "store google address", - "store google addresses", - "store google chrome address", - "store google chrome addresses", - "store google chrome new address", - "store google chrome shipping address", - "store google chrome shipping addresses", - "store google new address", - "store google shipping address", - "store google shipping addresses", - "store new address", - "store new address browser", - "store new address chrome", - "store new address google", - "store new address google chrome", - "store shipping address", - "store shipping address browser", - "store shipping address chrome", - "store shipping address google", - "store shipping address google chrome", - "store shipping addresses", - "store shipping addresses browser", - "store shipping addresses chrome", - "store shipping addresses google", - "store shipping addresses google chrome", - }, - - // ID#11 - { - // Generated suggestions: - "add sync", - "add sync settings", - "adjust sync", - "adjust sync settings", - "browser sync", - "browser sync settings", - "change sync", - "change sync settings", - "chrome sync", - "chrome sync settings", - "control sync", - "control sync settings", - "customize sync", - "customize sync settings", - "disable sync", - "disable sync settings", - "edit sync", - "edit sync settings", - "google chrome sync", - "google chrome sync settings", - "google sync", - "google sync settings", - "manage sync", - "manage sync settings", - "sync add", - "sync adjust", - "sync browser", - "sync change", - "sync chrome", - "sync control", - "sync customize", - "sync disable", - "sync edit", - "sync google", - "sync google chrome", - "sync manage", - "sync settings add", - "sync settings adjust", - "sync settings browser", - "sync settings change", - "sync settings chrome", - "sync settings control", - "sync settings customize", - "sync settings disable", - "sync settings edit", - "sync settings google", - "sync settings google chrome", - "sync settings manage", - }, - - // ID#12 - { - // Generated suggestions: - "adjust permissions", - "adjust site permissions", - "adjust site settings", - "browser permissions", - "browser site permissions", - "browser site settings", - "change permissions", - "change site permissions", - "change site settings", - "chrome permissions", - "chrome site permissions", - "chrome site settings", - "control permissions", - "control site permissions", - "control site settings", - "customize permissions", - "customize site permissions", - "customize site settings", - "edit permissions", - "edit site permissions", - "edit site settings", - "google chrome permissions", - "google chrome site permissions", - "google chrome site settings", - "google permissions", - "google site permissions", - "google site settings", - "manage permissions", - "manage site permissions", - "manage site settings", - "permissions adjust", - "permissions browser", - "permissions change", - "permissions chrome", - "permissions control", - "permissions customize", - "permissions edit", - "permissions google", - "permissions google chrome", - "permissions manage", - "site permissions adjust", - "site permissions browser", - "site permissions change", - "site permissions chrome", - "site permissions control", - "site permissions customize", - "site permissions edit", - "site permissions google", - "site permissions google chrome", - "site permissions manage", - "site settings adjust", - "site settings browser", - "site settings change", - "site settings chrome", - "site settings control", - "site settings customize", - "site settings edit", - "site settings google", - "site settings google chrome", - "site settings manage", - }, - - // ID#13 - { - // Generated suggestions: - "browser create doc", - "browser create document", - "browser doc create", - "browser doc make", - "browser doc new", - "browser doc open", - "browser doc start", - "browser document create", - "browser document make", - "browser document new", - "browser document open", - "browser document start", - "browser make doc", - "browser make document", - "browser new doc", - "browser new document", - "browser open doc", - "browser open document", - "browser start doc", - "browser start document", - "chrome create doc", - "chrome create document", - "chrome doc create", - "chrome doc make", - "chrome doc new", - "chrome doc open", - "chrome doc start", - "chrome document create", - "chrome document make", - "chrome document new", - "chrome document open", - "chrome document start", - "chrome make doc", - "chrome make document", - "chrome new doc", - "chrome new document", - "chrome open doc", - "chrome open document", - "chrome start doc", - "chrome start document", - "create browser doc", - "create browser document", - "create chrome doc", - "create chrome document", - "create doc browser", - "create doc chrome", - "create doc g suite", - "create doc google", - "create doc google chrome", - "create doc google workspace", - "create doc gsuite", - "create doc workspace", - "create document browser", - "create document chrome", - "create document g suite", - "create document google", - "create document google chrome", - "create document google workspace", - "create document gsuite", - "create document workspace", - "create g suite doc", - "create g suite document", - "create google chrome doc", - "create google chrome document", - "create google doc", - "create google document", - "create google workspace doc", - "create google workspace document", - "create gsuite doc", - "create gsuite document", - "create workspace doc", - "create workspace document", - "doc browser create", - "doc browser make", - "doc browser new", - "doc browser open", - "doc browser start", - "doc chrome create", - "doc chrome make", - "doc chrome new", - "doc chrome open", - "doc chrome start", - "doc create browser", - "doc create chrome", - "doc create g suite", - "doc create google", - "doc create google chrome", - "doc create google workspace", - "doc create gsuite", - "doc create workspace", - "doc g suite create", - "doc g suite make", - "doc g suite new", - "doc g suite open", - "doc g suite start", - "doc google chrome create", - "doc google chrome make", - "doc google chrome new", - "doc google chrome open", - "doc google chrome start", - "doc google create", - "doc google make", - "doc google new", - "doc google open", - "doc google start", - "doc google workspace create", - "doc google workspace make", - "doc google workspace new", - "doc google workspace open", - "doc google workspace start", - "doc gsuite create", - "doc gsuite make", - "doc gsuite new", - "doc gsuite open", - "doc gsuite start", - "doc make browser", - "doc make chrome", - "doc make g suite", - "doc make google", - "doc make google chrome", - "doc make google workspace", - "doc make gsuite", - "doc make workspace", - "doc new browser", - "doc new chrome", - "doc new g suite", - "doc new google", - "doc new google chrome", - "doc new google workspace", - "doc new gsuite", - "doc new workspace", - "doc open browser", - "doc open chrome", - "doc open g suite", - "doc open google", - "doc open google chrome", - "doc open google workspace", - "doc open gsuite", - "doc open workspace", - "doc start browser", - "doc start chrome", - "doc start g suite", - "doc start google", - "doc start google chrome", - "doc start google workspace", - "doc start gsuite", - "doc start workspace", - "doc workspace create", - "doc workspace make", - "doc workspace new", - "doc workspace open", - "doc workspace start", - "document browser create", - "document browser make", - "document browser new", - "document browser open", - "document browser start", - "document chrome create", - "document chrome make", - "document chrome new", - "document chrome open", - "document chrome start", - "document create browser", - "document create chrome", - "document create g suite", - "document create google", - "document create google chrome", - "document create google workspace", - "document create gsuite", - "document create workspace", - "document g suite create", - "document g suite make", - "document g suite new", - "document g suite open", - "document g suite start", - "document google chrome create", - "document google chrome make", - "document google chrome new", - "document google chrome open", - "document google chrome start", - "document google create", - "document google make", - "document google new", - "document google open", - "document google start", - "document google workspace create", - "document google workspace make", - "document google workspace new", - "document google workspace open", - "document google workspace start", - "document gsuite create", - "document gsuite make", - "document gsuite new", - "document gsuite open", - "document gsuite start", - "document make browser", - "document make chrome", - "document make g suite", - "document make google", - "document make google chrome", - "document make google workspace", - "document make gsuite", - "document make workspace", - "document new browser", - "document new chrome", - "document new g suite", - "document new google", - "document new google chrome", - "document new google workspace", - "document new gsuite", - "document new workspace", - "document open browser", - "document open chrome", - "document open g suite", - "document open google", - "document open google chrome", - "document open google workspace", - "document open gsuite", - "document open workspace", - "document start browser", - "document start chrome", - "document start g suite", - "document start google", - "document start google chrome", - "document start google workspace", - "document start gsuite", - "document start workspace", - "document workspace create", - "document workspace make", - "document workspace new", - "document workspace open", - "document workspace start", - "g suite create doc", - "g suite create document", - "g suite doc create", - "g suite doc make", - "g suite doc new", - "g suite doc open", - "g suite doc start", - "g suite document create", - "g suite document make", - "g suite document new", - "g suite document open", - "g suite document start", - "g suite make doc", - "g suite make document", - "g suite new doc", - "g suite new document", - "g suite open doc", - "g suite open document", - "g suite start doc", - "g suite start document", - "google chrome create doc", - "google chrome create document", - "google chrome doc create", - "google chrome doc make", - "google chrome doc new", - "google chrome doc open", - "google chrome doc start", - "google chrome document create", - "google chrome document make", - "google chrome document new", - "google chrome document open", - "google chrome document start", - "google chrome make doc", - "google chrome make document", - "google chrome new doc", - "google chrome new document", - "google chrome open doc", - "google chrome open document", - "google chrome start doc", - "google chrome start document", - "google create doc", - "google create document", - "google doc create", - "google doc make", - "google doc new", - "google doc open", - "google doc start", - "google document create", - "google document make", - "google document new", - "google document open", - "google document start", - "google make doc", - "google make document", - "google new doc", - "google new document", - "google open doc", - "google open document", - "google start doc", - "google start document", - "google workspace create doc", - "google workspace create document", - "google workspace doc create", - "google workspace doc make", - "google workspace doc new", - "google workspace doc open", - "google workspace doc start", - "google workspace document create", - "google workspace document make", - "google workspace document new", - "google workspace document open", - "google workspace document start", - "google workspace make doc", - "google workspace make document", - "google workspace new doc", - "google workspace new document", - "google workspace open doc", - "google workspace open document", - "google workspace start doc", - "google workspace start document", - "gsuite create doc", - "gsuite create document", - "gsuite doc create", - "gsuite doc make", - "gsuite doc new", - "gsuite doc open", - "gsuite doc start", - "gsuite document create", - "gsuite document make", - "gsuite document new", - "gsuite document open", - "gsuite document start", - "gsuite make doc", - "gsuite make document", - "gsuite new doc", - "gsuite new document", - "gsuite open doc", - "gsuite open document", - "gsuite start doc", - "gsuite start document", - "make browser doc", - "make browser document", - "make chrome doc", - "make chrome document", - "make doc browser", - "make doc chrome", - "make doc g suite", - "make doc google", - "make doc google chrome", - "make doc google workspace", - "make doc gsuite", - "make doc workspace", - "make document browser", - "make document chrome", - "make document g suite", - "make document google", - "make document google chrome", - "make document google workspace", - "make document gsuite", - "make document workspace", - "make g suite doc", - "make g suite document", - "make google chrome doc", - "make google chrome document", - "make google doc", - "make google document", - "make google workspace doc", - "make google workspace document", - "make gsuite doc", - "make gsuite document", - "make workspace doc", - "make workspace document", - "new browser doc", - "new browser document", - "new chrome doc", - "new chrome document", - "new doc browser", - "new doc chrome", - "new doc g suite", - "new doc google", - "new doc google chrome", - "new doc google workspace", - "new doc gsuite", - "new doc workspace", - "new document browser", - "new document chrome", - "new document g suite", - "new document google", - "new document google chrome", - "new document google workspace", - "new document gsuite", - "new document workspace", - "new g suite doc", - "new g suite document", - "new google chrome doc", - "new google chrome document", - "new google doc", - "new google document", - "new google workspace doc", - "new google workspace document", - "new gsuite doc", - "new gsuite document", - "new workspace doc", - "new workspace document", - "open browser doc", - "open browser document", - "open chrome doc", - "open chrome document", - "open doc browser", - "open doc chrome", - "open doc g suite", - "open doc google", - "open doc google chrome", - "open doc google workspace", - "open doc gsuite", - "open doc workspace", - "open document browser", - "open document chrome", - "open document g suite", - "open document google", - "open document google chrome", - "open document google workspace", - "open document gsuite", - "open document workspace", - "open g suite doc", - "open g suite document", - "open google chrome doc", - "open google chrome document", - "open google doc", - "open google document", - "open google workspace doc", - "open google workspace document", - "open gsuite doc", - "open gsuite document", - "open workspace doc", - "open workspace document", - "start browser doc", - "start browser document", - "start chrome doc", - "start chrome document", - "start doc browser", - "start doc chrome", - "start doc g suite", - "start doc google", - "start doc google chrome", - "start doc google workspace", - "start doc gsuite", - "start doc workspace", - "start document browser", - "start document chrome", - "start document g suite", - "start document google", - "start document google chrome", - "start document google workspace", - "start document gsuite", - "start document workspace", - "start g suite doc", - "start g suite document", - "start google chrome doc", - "start google chrome document", - "start google doc", - "start google document", - "start google workspace doc", - "start google workspace document", - "start gsuite doc", - "start gsuite document", - "start workspace doc", - "start workspace document", - "workspace create doc", - "workspace create document", - "workspace doc create", - "workspace doc make", - "workspace doc new", - "workspace doc open", - "workspace doc start", - "workspace document create", - "workspace document make", - "workspace document new", - "workspace document open", - "workspace document start", - "workspace make doc", - "workspace make document", - "workspace new doc", - "workspace new document", - "workspace open doc", - "workspace open document", - "workspace start doc", - "workspace start document", - }, - - // ID#14 - { - // Generated suggestions: - "browser create sheet", - "browser create sheets", - "browser create spreadsheet", - "browser create trix", - "browser make sheet", - "browser make sheets", - "browser make spreadsheet", - "browser make trix", - "browser new sheet", - "browser new sheets", - "browser new spreadsheet", - "browser new trix", - "browser open sheet", - "browser open sheets", - "browser open spreadsheet", - "browser open trix", - "browser sheet create", - "browser sheet make", - "browser sheet new", - "browser sheet open", - "browser sheet start", - "browser sheets create", - "browser sheets make", - "browser sheets new", - "browser sheets open", - "browser sheets start", - "browser spreadsheet create", - "browser spreadsheet make", - "browser spreadsheet new", - "browser spreadsheet open", - "browser spreadsheet start", - "browser start sheet", - "browser start sheets", - "browser start spreadsheet", - "browser start trix", - "browser trix create", - "browser trix make", - "browser trix new", - "browser trix open", - "browser trix start", - "chrome create sheet", - "chrome create sheets", - "chrome create spreadsheet", - "chrome create trix", - "chrome make sheet", - "chrome make sheets", - "chrome make spreadsheet", - "chrome make trix", - "chrome new sheet", - "chrome new sheets", - "chrome new spreadsheet", - "chrome new trix", - "chrome open sheet", - "chrome open sheets", - "chrome open spreadsheet", - "chrome open trix", - "chrome sheet create", - "chrome sheet make", - "chrome sheet new", - "chrome sheet open", - "chrome sheet start", - "chrome sheets create", - "chrome sheets make", - "chrome sheets new", - "chrome sheets open", - "chrome sheets start", - "chrome spreadsheet create", - "chrome spreadsheet make", - "chrome spreadsheet new", - "chrome spreadsheet open", - "chrome spreadsheet start", - "chrome start sheet", - "chrome start sheets", - "chrome start spreadsheet", - "chrome start trix", - "chrome trix create", - "chrome trix make", - "chrome trix new", - "chrome trix open", - "chrome trix start", - "create browser sheet", - "create browser sheets", - "create browser spreadsheet", - "create browser trix", - "create chrome sheet", - "create chrome sheets", - "create chrome spreadsheet", - "create chrome trix", - "create g suite sheet", - "create g suite sheets", - "create g suite spreadsheet", - "create g suite trix", - "create google chrome sheet", - "create google chrome sheets", - "create google chrome spreadsheet", - "create google chrome trix", - "create google sheet", - "create google sheets", - "create google spreadsheet", - "create google trix", - "create google workspace sheet", - "create google workspace sheets", - "create google workspace spreadsheet", - "create google workspace trix", - "create sheet browser", - "create sheet chrome", - "create sheet g suite", - "create sheet google", - "create sheet google chrome", - "create sheet google workspace", - "create sheet workspace", - "create sheets browser", - "create sheets chrome", - "create sheets g suite", - "create sheets google", - "create sheets google chrome", - "create sheets google workspace", - "create sheets workspace", - "create spreadsheet browser", - "create spreadsheet chrome", - "create spreadsheet g suite", - "create spreadsheet google", - "create spreadsheet google chrome", - "create spreadsheet google workspace", - "create spreadsheet workspace", - "create trix browser", - "create trix chrome", - "create trix g suite", - "create trix google", - "create trix google chrome", - "create trix google workspace", - "create trix workspace", - "create workspace sheet", - "create workspace sheets", - "create workspace spreadsheet", - "create workspace trix", - "g suite create sheet", - "g suite create sheets", - "g suite create spreadsheet", - "g suite create trix", - "g suite make sheet", - "g suite make sheets", - "g suite make spreadsheet", - "g suite make trix", - "g suite new sheet", - "g suite new sheets", - "g suite new spreadsheet", - "g suite new trix", - "g suite open sheet", - "g suite open sheets", - "g suite open spreadsheet", - "g suite open trix", - "g suite sheet create", - "g suite sheet make", - "g suite sheet new", - "g suite sheet open", - "g suite sheet start", - "g suite sheets create", - "g suite sheets make", - "g suite sheets new", - "g suite sheets open", - "g suite sheets start", - "g suite spreadsheet create", - "g suite spreadsheet make", - "g suite spreadsheet new", - "g suite spreadsheet open", - "g suite spreadsheet start", - "g suite start sheet", - "g suite start sheets", - "g suite start spreadsheet", - "g suite start trix", - "g suite trix create", - "g suite trix make", - "g suite trix new", - "g suite trix open", - "g suite trix start", - "google chrome create sheet", - "google chrome create sheets", - "google chrome create spreadsheet", - "google chrome create trix", - "google chrome make sheet", - "google chrome make sheets", - "google chrome make spreadsheet", - "google chrome make trix", - "google chrome new sheet", - "google chrome new sheets", - "google chrome new spreadsheet", - "google chrome new trix", - "google chrome open sheet", - "google chrome open sheets", - "google chrome open spreadsheet", - "google chrome open trix", - "google chrome sheet create", - "google chrome sheet make", - "google chrome sheet new", - "google chrome sheet open", - "google chrome sheet start", - "google chrome sheets create", - "google chrome sheets make", - "google chrome sheets new", - "google chrome sheets open", - "google chrome sheets start", - "google chrome spreadsheet create", - "google chrome spreadsheet make", - "google chrome spreadsheet new", - "google chrome spreadsheet open", - "google chrome spreadsheet start", - "google chrome start sheet", - "google chrome start sheets", - "google chrome start spreadsheet", - "google chrome start trix", - "google chrome trix create", - "google chrome trix make", - "google chrome trix new", - "google chrome trix open", - "google chrome trix start", - "google create sheet", - "google create sheets", - "google create spreadsheet", - "google create trix", - "google make sheet", - "google make sheets", - "google make spreadsheet", - "google make trix", - "google new sheet", - "google new sheets", - "google new spreadsheet", - "google new trix", - "google open sheet", - "google open sheets", - "google open spreadsheet", - "google open trix", - "google sheet create", - "google sheet make", - "google sheet new", - "google sheet open", - "google sheet start", - "google sheets create", - "google sheets make", - "google sheets new", - "google sheets open", - "google sheets start", - "google spreadsheet create", - "google spreadsheet make", - "google spreadsheet new", - "google spreadsheet open", - "google spreadsheet start", - "google start sheet", - "google start sheets", - "google start spreadsheet", - "google start trix", - "google trix create", - "google trix make", - "google trix new", - "google trix open", - "google trix start", - "google workspace create sheet", - "google workspace create sheets", - "google workspace create spreadsheet", - "google workspace create trix", - "google workspace make sheet", - "google workspace make sheets", - "google workspace make spreadsheet", - "google workspace make trix", - "google workspace new sheet", - "google workspace new sheets", - "google workspace new spreadsheet", - "google workspace new trix", - "google workspace open sheet", - "google workspace open sheets", - "google workspace open spreadsheet", - "google workspace open trix", - "google workspace sheet create", - "google workspace sheet make", - "google workspace sheet new", - "google workspace sheet open", - "google workspace sheet start", - "google workspace sheets create", - "google workspace sheets make", - "google workspace sheets new", - "google workspace sheets open", - "google workspace sheets start", - "google workspace spreadsheet create", - "google workspace spreadsheet make", - "google workspace spreadsheet new", - "google workspace spreadsheet open", - "google workspace spreadsheet start", - "google workspace start sheet", - "google workspace start sheets", - "google workspace start spreadsheet", - "google workspace start trix", - "google workspace trix create", - "google workspace trix make", - "google workspace trix new", - "google workspace trix open", - "google workspace trix start", - "make browser sheet", - "make browser sheets", - "make browser spreadsheet", - "make browser trix", - "make chrome sheet", - "make chrome sheets", - "make chrome spreadsheet", - "make chrome trix", - "make g suite sheet", - "make g suite sheets", - "make g suite spreadsheet", - "make g suite trix", - "make google chrome sheet", - "make google chrome sheets", - "make google chrome spreadsheet", - "make google chrome trix", - "make google sheet", - "make google sheets", - "make google spreadsheet", - "make google trix", - "make google workspace sheet", - "make google workspace sheets", - "make google workspace spreadsheet", - "make google workspace trix", - "make sheet browser", - "make sheet chrome", - "make sheet g suite", - "make sheet google", - "make sheet google chrome", - "make sheet google workspace", - "make sheet workspace", - "make sheets browser", - "make sheets chrome", - "make sheets g suite", - "make sheets google", - "make sheets google chrome", - "make sheets google workspace", - "make sheets workspace", - "make spreadsheet browser", - "make spreadsheet chrome", - "make spreadsheet g suite", - "make spreadsheet google", - "make spreadsheet google chrome", - "make spreadsheet google workspace", - "make spreadsheet workspace", - "make trix browser", - "make trix chrome", - "make trix g suite", - "make trix google", - "make trix google chrome", - "make trix google workspace", - "make trix workspace", - "make workspace sheet", - "make workspace sheets", - "make workspace spreadsheet", - "make workspace trix", - "new browser sheet", - "new browser sheets", - "new browser spreadsheet", - "new browser trix", - "new chrome sheet", - "new chrome sheets", - "new chrome spreadsheet", - "new chrome trix", - "new g suite sheet", - "new g suite sheets", - "new g suite spreadsheet", - "new g suite trix", - "new google chrome sheet", - "new google chrome sheets", - "new google chrome spreadsheet", - "new google chrome trix", - "new google sheet", - "new google sheets", - "new google spreadsheet", - "new google trix", - "new google workspace sheet", - "new google workspace sheets", - "new google workspace spreadsheet", - "new google workspace trix", - "new sheet browser", - "new sheet chrome", - "new sheet g suite", - "new sheet google", - "new sheet google chrome", - "new sheet google workspace", - "new sheet workspace", - "new sheets browser", - "new sheets chrome", - "new sheets g suite", - "new sheets google", - "new sheets google chrome", - "new sheets google workspace", - "new sheets workspace", - "new spreadsheet browser", - "new spreadsheet chrome", - "new spreadsheet g suite", - "new spreadsheet google", - "new spreadsheet google chrome", - "new spreadsheet google workspace", - "new spreadsheet workspace", - "new trix browser", - "new trix chrome", - "new trix g suite", - "new trix google", - "new trix google chrome", - "new trix google workspace", - "new trix workspace", - "new workspace sheet", - "new workspace sheets", - "new workspace spreadsheet", - "new workspace trix", - "open browser sheet", - "open browser sheets", - "open browser spreadsheet", - "open browser trix", - "open chrome sheet", - "open chrome sheets", - "open chrome spreadsheet", - "open chrome trix", - "open g suite sheet", - "open g suite sheets", - "open g suite spreadsheet", - "open g suite trix", - "open google chrome sheet", - "open google chrome sheets", - "open google chrome spreadsheet", - "open google chrome trix", - "open google sheet", - "open google sheets", - "open google spreadsheet", - "open google trix", - "open google workspace sheet", - "open google workspace sheets", - "open google workspace spreadsheet", - "open google workspace trix", - "open sheet browser", - "open sheet chrome", - "open sheet g suite", - "open sheet google", - "open sheet google chrome", - "open sheet google workspace", - "open sheet workspace", - "open sheets browser", - "open sheets chrome", - "open sheets g suite", - "open sheets google", - "open sheets google chrome", - "open sheets google workspace", - "open sheets workspace", - "open spreadsheet browser", - "open spreadsheet chrome", - "open spreadsheet g suite", - "open spreadsheet google", - "open spreadsheet google chrome", - "open spreadsheet google workspace", - "open spreadsheet workspace", - "open trix browser", - "open trix chrome", - "open trix g suite", - "open trix google", - "open trix google chrome", - "open trix google workspace", - "open trix workspace", - "open workspace sheet", - "open workspace sheets", - "open workspace spreadsheet", - "open workspace trix", - "sheet browser create", - "sheet browser make", - "sheet browser new", - "sheet browser open", - "sheet browser start", - "sheet chrome create", - "sheet chrome make", - "sheet chrome new", - "sheet chrome open", - "sheet chrome start", - "sheet create browser", - "sheet create chrome", - "sheet create g suite", - "sheet create google", - "sheet create google chrome", - "sheet create google workspace", - "sheet create workspace", - "sheet g suite create", - "sheet g suite make", - "sheet g suite new", - "sheet g suite open", - "sheet g suite start", - "sheet google chrome create", - "sheet google chrome make", - "sheet google chrome new", - "sheet google chrome open", - "sheet google chrome start", - "sheet google create", - "sheet google make", - "sheet google new", - "sheet google open", - "sheet google start", - "sheet google workspace create", - "sheet google workspace make", - "sheet google workspace new", - "sheet google workspace open", - "sheet google workspace start", - "sheet make browser", - "sheet make chrome", - "sheet make g suite", - "sheet make google", - "sheet make google chrome", - "sheet make google workspace", - "sheet make workspace", - "sheet new browser", - "sheet new chrome", - "sheet new g suite", - "sheet new google", - "sheet new google chrome", - "sheet new google workspace", - "sheet new workspace", - "sheet open browser", - "sheet open chrome", - "sheet open g suite", - "sheet open google", - "sheet open google chrome", - "sheet open google workspace", - "sheet open workspace", - "sheet start browser", - "sheet start chrome", - "sheet start g suite", - "sheet start google", - "sheet start google chrome", - "sheet start google workspace", - "sheet start workspace", - "sheet workspace create", - "sheet workspace make", - "sheet workspace new", - "sheet workspace open", - "sheet workspace start", - "sheets browser create", - "sheets browser make", - "sheets browser new", - "sheets browser open", - "sheets browser start", - "sheets chrome create", - "sheets chrome make", - "sheets chrome new", - "sheets chrome open", - "sheets chrome start", - "sheets create browser", - "sheets create chrome", - "sheets create g suite", - "sheets create google", - "sheets create google chrome", - "sheets create google workspace", - "sheets create workspace", - "sheets g suite create", - "sheets g suite make", - "sheets g suite new", - "sheets g suite open", - "sheets g suite start", - "sheets google chrome create", - "sheets google chrome make", - "sheets google chrome new", - "sheets google chrome open", - "sheets google chrome start", - "sheets google create", - "sheets google make", - "sheets google new", - "sheets google open", - "sheets google start", - "sheets google workspace create", - "sheets google workspace make", - "sheets google workspace new", - "sheets google workspace open", - "sheets google workspace start", - "sheets make browser", - "sheets make chrome", - "sheets make g suite", - "sheets make google", - "sheets make google chrome", - "sheets make google workspace", - "sheets make workspace", - "sheets new browser", - "sheets new chrome", - "sheets new g suite", - "sheets new google", - "sheets new google chrome", - "sheets new google workspace", - "sheets new workspace", - "sheets open browser", - "sheets open chrome", - "sheets open g suite", - "sheets open google", - "sheets open google chrome", - "sheets open google workspace", - "sheets open workspace", - "sheets start browser", - "sheets start chrome", - "sheets start g suite", - "sheets start google", - "sheets start google chrome", - "sheets start google workspace", - "sheets start workspace", - "sheets workspace create", - "sheets workspace make", - "sheets workspace new", - "sheets workspace open", - "sheets workspace start", - "spreadsheet browser create", - "spreadsheet browser make", - "spreadsheet browser new", - "spreadsheet browser open", - "spreadsheet browser start", - "spreadsheet chrome create", - "spreadsheet chrome make", - "spreadsheet chrome new", - "spreadsheet chrome open", - "spreadsheet chrome start", - "spreadsheet create browser", - "spreadsheet create chrome", - "spreadsheet create g suite", - "spreadsheet create google", - "spreadsheet create google chrome", - "spreadsheet create google workspace", - "spreadsheet create workspace", - "spreadsheet g suite create", - "spreadsheet g suite make", - "spreadsheet g suite new", - "spreadsheet g suite open", - "spreadsheet g suite start", - "spreadsheet google chrome create", - "spreadsheet google chrome make", - "spreadsheet google chrome new", - "spreadsheet google chrome open", - "spreadsheet google chrome start", - "spreadsheet google create", - "spreadsheet google make", - "spreadsheet google new", - "spreadsheet google open", - "spreadsheet google start", - "spreadsheet google workspace create", - "spreadsheet google workspace make", - "spreadsheet google workspace new", - "spreadsheet google workspace open", - "spreadsheet google workspace start", - "spreadsheet make browser", - "spreadsheet make chrome", - "spreadsheet make g suite", - "spreadsheet make google", - "spreadsheet make google chrome", - "spreadsheet make google workspace", - "spreadsheet make workspace", - "spreadsheet new browser", - "spreadsheet new chrome", - "spreadsheet new g suite", - "spreadsheet new google", - "spreadsheet new google chrome", - "spreadsheet new google workspace", - "spreadsheet new workspace", - "spreadsheet open browser", - "spreadsheet open chrome", - "spreadsheet open g suite", - "spreadsheet open google", - "spreadsheet open google chrome", - "spreadsheet open google workspace", - "spreadsheet open workspace", - "spreadsheet start browser", - "spreadsheet start chrome", - "spreadsheet start g suite", - "spreadsheet start google", - "spreadsheet start google chrome", - "spreadsheet start google workspace", - "spreadsheet start workspace", - "spreadsheet workspace create", - "spreadsheet workspace make", - "spreadsheet workspace new", - "spreadsheet workspace open", - "spreadsheet workspace start", - "start browser sheet", - "start browser sheets", - "start browser spreadsheet", - "start browser trix", - "start chrome sheet", - "start chrome sheets", - "start chrome spreadsheet", - "start chrome trix", - "start g suite sheet", - "start g suite sheets", - "start g suite spreadsheet", - "start g suite trix", - "start google chrome sheet", - "start google chrome sheets", - "start google chrome spreadsheet", - "start google chrome trix", - "start google sheet", - "start google sheets", - "start google spreadsheet", - "start google trix", - "start google workspace sheet", - "start google workspace sheets", - "start google workspace spreadsheet", - "start google workspace trix", - "start sheet browser", - "start sheet chrome", - "start sheet g suite", - "start sheet google", - "start sheet google chrome", - "start sheet google workspace", - "start sheet workspace", - "start sheets browser", - "start sheets chrome", - "start sheets g suite", - "start sheets google", - "start sheets google chrome", - "start sheets google workspace", - "start sheets workspace", - "start spreadsheet browser", - "start spreadsheet chrome", - "start spreadsheet g suite", - "start spreadsheet google", - "start spreadsheet google chrome", - "start spreadsheet google workspace", - "start spreadsheet workspace", - "start trix browser", - "start trix chrome", - "start trix g suite", - "start trix google", - "start trix google chrome", - "start trix google workspace", - "start trix workspace", - "start workspace sheet", - "start workspace sheets", - "start workspace spreadsheet", - "start workspace trix", - "trix browser create", - "trix browser make", - "trix browser new", - "trix browser open", - "trix browser start", - "trix chrome create", - "trix chrome make", - "trix chrome new", - "trix chrome open", - "trix chrome start", - "trix create browser", - "trix create chrome", - "trix create g suite", - "trix create google", - "trix create google chrome", - "trix create google workspace", - "trix create workspace", - "trix g suite create", - "trix g suite make", - "trix g suite new", - "trix g suite open", - "trix g suite start", - "trix google chrome create", - "trix google chrome make", - "trix google chrome new", - "trix google chrome open", - "trix google chrome start", - "trix google create", - "trix google make", - "trix google new", - "trix google open", - "trix google start", - "trix google workspace create", - "trix google workspace make", - "trix google workspace new", - "trix google workspace open", - "trix google workspace start", - "trix make browser", - "trix make chrome", - "trix make g suite", - "trix make google", - "trix make google chrome", - "trix make google workspace", - "trix make workspace", - "trix new browser", - "trix new chrome", - "trix new g suite", - "trix new google", - "trix new google chrome", - "trix new google workspace", - "trix new workspace", - "trix open browser", - "trix open chrome", - "trix open g suite", - "trix open google", - "trix open google chrome", - "trix open google workspace", - "trix open workspace", - "trix start browser", - "trix start chrome", - "trix start g suite", - "trix start google", - "trix start google chrome", - "trix start google workspace", - "trix start workspace", - "trix workspace create", - "trix workspace make", - "trix workspace new", - "trix workspace open", - "trix workspace start", - "workspace create sheet", - "workspace create sheets", - "workspace create spreadsheet", - "workspace create trix", - "workspace make sheet", - "workspace make sheets", - "workspace make spreadsheet", - "workspace make trix", - "workspace new sheet", - "workspace new sheets", - "workspace new spreadsheet", - "workspace new trix", - "workspace open sheet", - "workspace open sheets", - "workspace open spreadsheet", - "workspace open trix", - "workspace sheet create", - "workspace sheet make", - "workspace sheet new", - "workspace sheet open", - "workspace sheet start", - "workspace sheets create", - "workspace sheets make", - "workspace sheets new", - "workspace sheets open", - "workspace sheets start", - "workspace spreadsheet create", - "workspace spreadsheet make", - "workspace spreadsheet new", - "workspace spreadsheet open", - "workspace spreadsheet start", - "workspace start sheet", - "workspace start sheets", - "workspace start spreadsheet", - "workspace start trix", - "workspace trix create", - "workspace trix make", - "workspace trix new", - "workspace trix open", - "workspace trix start", - }, - - // ID#15 - { - // Generated suggestions: - "browser create deck", - "browser create presentation", - "browser create preso", - "browser create slide", - "browser create slides", - "browser deck create", - "browser deck make", - "browser deck new", - "browser deck open", - "browser deck start", - "browser make deck", - "browser make presentation", - "browser make preso", - "browser make slide", - "browser make slides", - "browser new deck", - "browser new presentation", - "browser new preso", - "browser new slide", - "browser new slides", - "browser open deck", - "browser open presentation", - "browser open preso", - "browser open slide", - "browser open slides", - "browser presentation create", - "browser presentation make", - "browser presentation new", - "browser presentation open", - "browser presentation start", - "browser preso create", - "browser preso make", - "browser preso new", - "browser preso open", - "browser preso start", - "browser slide create", - "browser slide make", - "browser slide new", - "browser slide open", - "browser slide start", - "browser slides create", - "browser slides make", - "browser slides new", - "browser slides open", - "browser slides start", - "browser start deck", - "browser start presentation", - "browser start preso", - "browser start slide", - "browser start slides", - "chrome create deck", - "chrome create presentation", - "chrome create preso", - "chrome create slide", - "chrome create slides", - "chrome deck create", - "chrome deck make", - "chrome deck new", - "chrome deck open", - "chrome deck start", - "chrome make deck", - "chrome make presentation", - "chrome make preso", - "chrome make slide", - "chrome make slides", - "chrome new deck", - "chrome new presentation", - "chrome new preso", - "chrome new slide", - "chrome new slides", - "chrome open deck", - "chrome open presentation", - "chrome open preso", - "chrome open slide", - "chrome open slides", - "chrome presentation create", - "chrome presentation make", - "chrome presentation new", - "chrome presentation open", - "chrome presentation start", - "chrome preso create", - "chrome preso make", - "chrome preso new", - "chrome preso open", - "chrome preso start", - "chrome slide create", - "chrome slide make", - "chrome slide new", - "chrome slide open", - "chrome slide start", - "chrome slides create", - "chrome slides make", - "chrome slides new", - "chrome slides open", - "chrome slides start", - "chrome start deck", - "chrome start presentation", - "chrome start preso", - "chrome start slide", - "chrome start slides", - "create browser deck", - "create browser presentation", - "create browser preso", - "create browser slide", - "create browser slides", - "create chrome deck", - "create chrome presentation", - "create chrome preso", - "create chrome slide", - "create chrome slides", - "create deck browser", - "create deck chrome", - "create deck g suite", - "create deck google", - "create deck workspace", - "create g suite deck", - "create g suite presentation", - "create g suite preso", - "create g suite slide", - "create g suite slides", - "create google deck", - "create google presentation", - "create google preso", - "create google slide", - "create google slides", - "create presentation browser", - "create presentation chrome", - "create presentation g suite", - "create presentation google", - "create presentation workspace", - "create preso browser", - "create preso chrome", - "create preso g suite", - "create preso google", - "create preso workspace", - "create slide browser", - "create slide chrome", - "create slide g suite", - "create slide google", - "create slide workspace", - "create slides browser", - "create slides chrome", - "create slides g suite", - "create slides google", - "create slides workspace", - "create workspace deck", - "create workspace presentation", - "create workspace preso", - "create workspace slide", - "create workspace slides", - "deck browser create", - "deck browser make", - "deck browser new", - "deck browser open", - "deck browser start", - "deck chrome create", - "deck chrome make", - "deck chrome new", - "deck chrome open", - "deck chrome start", - "deck create browser", - "deck create chrome", - "deck create g suite", - "deck create google", - "deck create workspace", - "deck g suite create", - "deck g suite make", - "deck g suite new", - "deck g suite open", - "deck g suite start", - "deck google create", - "deck google make", - "deck google new", - "deck google open", - "deck google start", - "deck make browser", - "deck make chrome", - "deck make g suite", - "deck make google", - "deck make workspace", - "deck new browser", - "deck new chrome", - "deck new g suite", - "deck new google", - "deck new workspace", - "deck open browser", - "deck open chrome", - "deck open g suite", - "deck open google", - "deck open workspace", - "deck start browser", - "deck start chrome", - "deck start g suite", - "deck start google", - "deck start workspace", - "deck workspace create", - "deck workspace make", - "deck workspace new", - "deck workspace open", - "deck workspace start", - "g suite create deck", - "g suite create presentation", - "g suite create preso", - "g suite create slide", - "g suite create slides", - "g suite deck create", - "g suite deck make", - "g suite deck new", - "g suite deck open", - "g suite deck start", - "g suite make deck", - "g suite make presentation", - "g suite make preso", - "g suite make slide", - "g suite make slides", - "g suite new deck", - "g suite new presentation", - "g suite new preso", - "g suite new slide", - "g suite new slides", - "g suite open deck", - "g suite open presentation", - "g suite open preso", - "g suite open slide", - "g suite open slides", - "g suite presentation create", - "g suite presentation make", - "g suite presentation new", - "g suite presentation open", - "g suite presentation start", - "g suite preso create", - "g suite preso make", - "g suite preso new", - "g suite preso open", - "g suite preso start", - "g suite slide create", - "g suite slide make", - "g suite slide new", - "g suite slide open", - "g suite slide start", - "g suite slides create", - "g suite slides make", - "g suite slides new", - "g suite slides open", - "g suite slides start", - "g suite start deck", - "g suite start presentation", - "g suite start preso", - "g suite start slide", - "g suite start slides", - "google create deck", - "google create presentation", - "google create preso", - "google create slide", - "google create slides", - "google deck create", - "google deck make", - "google deck new", - "google deck open", - "google deck start", - "google make deck", - "google make presentation", - "google make preso", - "google make slide", - "google make slides", - "google new deck", - "google new presentation", - "google new preso", - "google new slide", - "google new slides", - "google open deck", - "google open presentation", - "google open preso", - "google open slide", - "google open slides", - "google presentation create", - "google presentation make", - "google presentation new", - "google presentation open", - "google presentation start", - "google preso create", - "google preso make", - "google preso new", - "google preso open", - "google preso start", - "google slide create", - "google slide make", - "google slide new", - "google slide open", - "google slide start", - "google slides create", - "google slides make", - "google slides new", - "google slides open", - "google slides start", - "google start deck", - "google start presentation", - "google start preso", - "google start slide", - "google start slides", - "make browser deck", - "make browser presentation", - "make browser preso", - "make browser slide", - "make browser slides", - "make chrome deck", - "make chrome presentation", - "make chrome preso", - "make chrome slide", - "make chrome slides", - "make deck browser", - "make deck chrome", - "make deck g suite", - "make deck google", - "make deck workspace", - "make g suite deck", - "make g suite presentation", - "make g suite preso", - "make g suite slide", - "make g suite slides", - "make google deck", - "make google presentation", - "make google preso", - "make google slide", - "make google slides", - "make presentation browser", - "make presentation chrome", - "make presentation g suite", - "make presentation google", - "make presentation workspace", - "make preso browser", - "make preso chrome", - "make preso g suite", - "make preso google", - "make preso workspace", - "make slide browser", - "make slide chrome", - "make slide g suite", - "make slide google", - "make slide workspace", - "make slides browser", - "make slides chrome", - "make slides g suite", - "make slides google", - "make slides workspace", - "make workspace deck", - "make workspace presentation", - "make workspace preso", - "make workspace slide", - "make workspace slides", - "new browser deck", - "new browser presentation", - "new browser preso", - "new browser slide", - "new browser slides", - "new chrome deck", - "new chrome presentation", - "new chrome preso", - "new chrome slide", - "new chrome slides", - "new deck browser", - "new deck chrome", - "new deck g suite", - "new deck google", - "new deck workspace", - "new g suite deck", - "new g suite presentation", - "new g suite preso", - "new g suite slide", - "new g suite slides", - "new google deck", - "new google presentation", - "new google preso", - "new google slide", - "new google slides", - "new presentation browser", - "new presentation chrome", - "new presentation g suite", - "new presentation google", - "new presentation workspace", - "new preso browser", - "new preso chrome", - "new preso g suite", - "new preso google", - "new preso workspace", - "new slide browser", - "new slide chrome", - "new slide g suite", - "new slide google", - "new slide workspace", - "new slides browser", - "new slides chrome", - "new slides g suite", - "new slides google", - "new slides workspace", - "new workspace deck", - "new workspace presentation", - "new workspace preso", - "new workspace slide", - "new workspace slides", - "open browser deck", - "open browser presentation", - "open browser preso", - "open browser slide", - "open browser slides", - "open chrome deck", - "open chrome presentation", - "open chrome preso", - "open chrome slide", - "open chrome slides", - "open deck browser", - "open deck chrome", - "open deck g suite", - "open deck google", - "open deck workspace", - "open g suite deck", - "open g suite presentation", - "open g suite preso", - "open g suite slide", - "open g suite slides", - "open google deck", - "open google presentation", - "open google preso", - "open google slide", - "open google slides", - "open presentation browser", - "open presentation chrome", - "open presentation g suite", - "open presentation google", - "open presentation workspace", - "open preso browser", - "open preso chrome", - "open preso g suite", - "open preso google", - "open preso workspace", - "open slide browser", - "open slide chrome", - "open slide g suite", - "open slide google", - "open slide workspace", - "open slides browser", - "open slides chrome", - "open slides g suite", - "open slides google", - "open slides workspace", - "open workspace deck", - "open workspace presentation", - "open workspace preso", - "open workspace slide", - "open workspace slides", - "presentation browser create", - "presentation browser make", - "presentation browser new", - "presentation browser open", - "presentation browser start", - "presentation chrome create", - "presentation chrome make", - "presentation chrome new", - "presentation chrome open", - "presentation chrome start", - "presentation create browser", - "presentation create chrome", - "presentation create g suite", - "presentation create google", - "presentation create workspace", - "presentation g suite create", - "presentation g suite make", - "presentation g suite new", - "presentation g suite open", - "presentation g suite start", - "presentation google create", - "presentation google make", - "presentation google new", - "presentation google open", - "presentation google start", - "presentation make browser", - "presentation make chrome", - "presentation make g suite", - "presentation make google", - "presentation make workspace", - "presentation new browser", - "presentation new chrome", - "presentation new g suite", - "presentation new google", - "presentation new workspace", - "presentation open browser", - "presentation open chrome", - "presentation open g suite", - "presentation open google", - "presentation open workspace", - "presentation start browser", - "presentation start chrome", - "presentation start g suite", - "presentation start google", - "presentation start workspace", - "presentation workspace create", - "presentation workspace make", - "presentation workspace new", - "presentation workspace open", - "presentation workspace start", - "preso browser create", - "preso browser make", - "preso browser new", - "preso browser open", - "preso browser start", - "preso chrome create", - "preso chrome make", - "preso chrome new", - "preso chrome open", - "preso chrome start", - "preso create browser", - "preso create chrome", - "preso create g suite", - "preso create google", - "preso create workspace", - "preso g suite create", - "preso g suite make", - "preso g suite new", - "preso g suite open", - "preso g suite start", - "preso google create", - "preso google make", - "preso google new", - "preso google open", - "preso google start", - "preso make browser", - "preso make chrome", - "preso make g suite", - "preso make google", - "preso make workspace", - "preso new browser", - "preso new chrome", - "preso new g suite", - "preso new google", - "preso new workspace", - "preso open browser", - "preso open chrome", - "preso open g suite", - "preso open google", - "preso open workspace", - "preso start browser", - "preso start chrome", - "preso start g suite", - "preso start google", - "preso start workspace", - "preso workspace create", - "preso workspace make", - "preso workspace new", - "preso workspace open", - "preso workspace start", - "slide browser create", - "slide browser make", - "slide browser new", - "slide browser open", - "slide browser start", - "slide chrome create", - "slide chrome make", - "slide chrome new", - "slide chrome open", - "slide chrome start", - "slide create browser", - "slide create chrome", - "slide create g suite", - "slide create google", - "slide create workspace", - "slide g suite create", - "slide g suite make", - "slide g suite new", - "slide g suite open", - "slide g suite start", - "slide google create", - "slide google make", - "slide google new", - "slide google open", - "slide google start", - "slide make browser", - "slide make chrome", - "slide make g suite", - "slide make google", - "slide make workspace", - "slide new browser", - "slide new chrome", - "slide new g suite", - "slide new google", - "slide new workspace", - "slide open browser", - "slide open chrome", - "slide open g suite", - "slide open google", - "slide open workspace", - "slide start browser", - "slide start chrome", - "slide start g suite", - "slide start google", - "slide start workspace", - "slide workspace create", - "slide workspace make", - "slide workspace new", - "slide workspace open", - "slide workspace start", - "slides browser create", - "slides browser make", - "slides browser new", - "slides browser open", - "slides browser start", - "slides chrome create", - "slides chrome make", - "slides chrome new", - "slides chrome open", - "slides chrome start", - "slides create browser", - "slides create chrome", - "slides create g suite", - "slides create google", - "slides create workspace", - "slides g suite create", - "slides g suite make", - "slides g suite new", - "slides g suite open", - "slides g suite start", - "slides google create", - "slides google make", - "slides google new", - "slides google open", - "slides google start", - "slides make browser", - "slides make chrome", - "slides make g suite", - "slides make google", - "slides make workspace", - "slides new browser", - "slides new chrome", - "slides new g suite", - "slides new google", - "slides new workspace", - "slides open browser", - "slides open chrome", - "slides open g suite", - "slides open google", - "slides open workspace", - "slides start browser", - "slides start chrome", - "slides start g suite", - "slides start google", - "slides start workspace", - "slides workspace create", - "slides workspace make", - "slides workspace new", - "slides workspace open", - "slides workspace start", - "start browser deck", - "start browser presentation", - "start browser preso", - "start browser slide", - "start browser slides", - "start chrome deck", - "start chrome presentation", - "start chrome preso", - "start chrome slide", - "start chrome slides", - "start deck browser", - "start deck chrome", - "start deck g suite", - "start deck google", - "start deck workspace", - "start g suite deck", - "start g suite presentation", - "start g suite preso", - "start g suite slide", - "start g suite slides", - "start google deck", - "start google presentation", - "start google preso", - "start google slide", - "start google slides", - "start presentation browser", - "start presentation chrome", - "start presentation g suite", - "start presentation google", - "start presentation workspace", - "start preso browser", - "start preso chrome", - "start preso g suite", - "start preso google", - "start preso workspace", - "start slide browser", - "start slide chrome", - "start slide g suite", - "start slide google", - "start slide workspace", - "start slides browser", - "start slides chrome", - "start slides g suite", - "start slides google", - "start slides workspace", - "start workspace deck", - "start workspace presentation", - "start workspace preso", - "start workspace slide", - "start workspace slides", - "workspace create deck", - "workspace create presentation", - "workspace create preso", - "workspace create slide", - "workspace create slides", - "workspace deck create", - "workspace deck make", - "workspace deck new", - "workspace deck open", - "workspace deck start", - "workspace make deck", - "workspace make presentation", - "workspace make preso", - "workspace make slide", - "workspace make slides", - "workspace new deck", - "workspace new presentation", - "workspace new preso", - "workspace new slide", - "workspace new slides", - "workspace open deck", - "workspace open presentation", - "workspace open preso", - "workspace open slide", - "workspace open slides", - "workspace presentation create", - "workspace presentation make", - "workspace presentation new", - "workspace presentation open", - "workspace presentation start", - "workspace preso create", - "workspace preso make", - "workspace preso new", - "workspace preso open", - "workspace preso start", - "workspace slide create", - "workspace slide make", - "workspace slide new", - "workspace slide open", - "workspace slide start", - "workspace slides create", - "workspace slides make", - "workspace slides new", - "workspace slides open", - "workspace slides start", - "workspace start deck", - "workspace start presentation", - "workspace start preso", - "workspace start slide", - "workspace start slides", - }, - - // ID#16 - { - // Generated suggestions: - "add browser event", - "add browser invite", - "add browser meeting", - "add cal event", - "add cal invite", - "add cal meeting", - "add calendar event", - "add calendar invite", - "add calendar meeting", - "add chrome event", - "add chrome invite", - "add chrome meeting", - "add event browser", - "add event cal", - "add event calendar", - "add event chrome", - "add event g suite", - "add event google", - "add event workspace", - "add g suite event", - "add g suite invite", - "add g suite meeting", - "add google event", - "add google invite", - "add google meeting", - "add invite browser", - "add invite cal", - "add invite calendar", - "add invite chrome", - "add invite g suite", - "add invite google", - "add invite workspace", - "add meeting browser", - "add meeting cal", - "add meeting calendar", - "add meeting chrome", - "add meeting g suite", - "add meeting google", - "add meeting workspace", - "add workspace event", - "add workspace invite", - "add workspace meeting", - "browser add event", - "browser add invite", - "browser add meeting", - "browser create event", - "browser create invite", - "browser create meeting", - "browser event add", - "browser event create", - "browser event make", - "browser event new", - "browser event open", - "browser event schedule", - "browser event start", - "browser invite add", - "browser invite create", - "browser invite make", - "browser invite new", - "browser invite open", - "browser invite schedule", - "browser invite start", - "browser make event", - "browser make invite", - "browser make meeting", - "browser meeting add", - "browser meeting create", - "browser meeting make", - "browser meeting new", - "browser meeting open", - "browser meeting schedule", - "browser meeting start", - "browser new event", - "browser new invite", - "browser new meeting", - "browser open event", - "browser open invite", - "browser open meeting", - "browser schedule event", - "browser schedule invite", - "browser schedule meeting", - "browser start event", - "browser start invite", - "browser start meeting", - "cal add event", - "cal add invite", - "cal add meeting", - "cal create event", - "cal create invite", - "cal create meeting", - "cal event add", - "cal event create", - "cal event make", - "cal event new", - "cal event open", - "cal event schedule", - "cal event start", - "cal invite add", - "cal invite create", - "cal invite make", - "cal invite new", - "cal invite open", - "cal invite schedule", - "cal invite start", - "cal make event", - "cal make invite", - "cal make meeting", - "cal meeting add", - "cal meeting create", - "cal meeting make", - "cal meeting new", - "cal meeting open", - "cal meeting schedule", - "cal meeting start", - "cal new event", - "cal new invite", - "cal new meeting", - "cal open event", - "cal open invite", - "cal open meeting", - "cal schedule event", - "cal schedule invite", - "cal schedule meeting", - "cal start event", - "cal start invite", - "cal start meeting", - "calendar add event", - "calendar add invite", - "calendar add meeting", - "calendar create event", - "calendar create invite", - "calendar create meeting", - "calendar event add", - "calendar event create", - "calendar event make", - "calendar event new", - "calendar event open", - "calendar event schedule", - "calendar event start", - "calendar invite add", - "calendar invite create", - "calendar invite make", - "calendar invite new", - "calendar invite open", - "calendar invite schedule", - "calendar invite start", - "calendar make event", - "calendar make invite", - "calendar make meeting", - "calendar meeting add", - "calendar meeting create", - "calendar meeting make", - "calendar meeting new", - "calendar meeting open", - "calendar meeting schedule", - "calendar meeting start", - "calendar new event", - "calendar new invite", - "calendar new meeting", - "calendar open event", - "calendar open invite", - "calendar open meeting", - "calendar schedule event", - "calendar schedule invite", - "calendar schedule meeting", - "calendar start event", - "calendar start invite", - "calendar start meeting", - "chrome add event", - "chrome add invite", - "chrome add meeting", - "chrome create event", - "chrome create invite", - "chrome create meeting", - "chrome event add", - "chrome event create", - "chrome event make", - "chrome event new", - "chrome event open", - "chrome event schedule", - "chrome event start", - "chrome invite add", - "chrome invite create", - "chrome invite make", - "chrome invite new", - "chrome invite open", - "chrome invite schedule", - "chrome invite start", - "chrome make event", - "chrome make invite", - "chrome make meeting", - "chrome meeting add", - "chrome meeting create", - "chrome meeting make", - "chrome meeting new", - "chrome meeting open", - "chrome meeting schedule", - "chrome meeting start", - "chrome new event", - "chrome new invite", - "chrome new meeting", - "chrome open event", - "chrome open invite", - "chrome open meeting", - "chrome schedule event", - "chrome schedule invite", - "chrome schedule meeting", - "chrome start event", - "chrome start invite", - "chrome start meeting", - "create browser event", - "create browser invite", - "create browser meeting", - "create cal event", - "create cal invite", - "create cal meeting", - "create calendar event", - "create calendar invite", - "create calendar meeting", - "create chrome event", - "create chrome invite", - "create chrome meeting", - "create event browser", - "create event cal", - "create event calendar", - "create event chrome", - "create event g suite", - "create event google", - "create event workspace", - "create g suite event", - "create g suite invite", - "create g suite meeting", - "create google event", - "create google invite", - "create google meeting", - "create invite browser", - "create invite cal", - "create invite calendar", - "create invite chrome", - "create invite g suite", - "create invite google", - "create invite workspace", - "create meeting browser", - "create meeting cal", - "create meeting calendar", - "create meeting chrome", - "create meeting g suite", - "create meeting google", - "create meeting workspace", - "create workspace event", - "create workspace invite", - "create workspace meeting", - "event add browser", - "event add cal", - "event add calendar", - "event add chrome", - "event add g suite", - "event add google", - "event add workspace", - "event browser add", - "event browser create", - "event browser make", - "event browser new", - "event browser open", - "event browser schedule", - "event browser start", - "event cal add", - "event cal create", - "event cal make", - "event cal new", - "event cal open", - "event cal schedule", - "event cal start", - "event calendar add", - "event calendar create", - "event calendar make", - "event calendar new", - "event calendar open", - "event calendar schedule", - "event calendar start", - "event chrome add", - "event chrome create", - "event chrome make", - "event chrome new", - "event chrome open", - "event chrome schedule", - "event chrome start", - "event create browser", - "event create cal", - "event create calendar", - "event create chrome", - "event create g suite", - "event create google", - "event create workspace", - "event g suite add", - "event g suite create", - "event g suite make", - "event g suite new", - "event g suite open", - "event g suite schedule", - "event g suite start", - "event google add", - "event google create", - "event google make", - "event google new", - "event google open", - "event google schedule", - "event google start", - "event make browser", - "event make cal", - "event make calendar", - "event make chrome", - "event make g suite", - "event make google", - "event make workspace", - "event new browser", - "event new cal", - "event new calendar", - "event new chrome", - "event new g suite", - "event new google", - "event new workspace", - "event open browser", - "event open cal", - "event open calendar", - "event open chrome", - "event open g suite", - "event open google", - "event open workspace", - "event schedule browser", - "event schedule cal", - "event schedule calendar", - "event schedule chrome", - "event schedule g suite", - "event schedule google", - "event schedule workspace", - "event start browser", - "event start cal", - "event start calendar", - "event start chrome", - "event start g suite", - "event start google", - "event start workspace", - "event workspace add", - "event workspace create", - "event workspace make", - "event workspace new", - "event workspace open", - "event workspace schedule", - "event workspace start", - "g suite add event", - "g suite add invite", - "g suite add meeting", - "g suite create event", - "g suite create invite", - "g suite create meeting", - "g suite event add", - "g suite event create", - "g suite event make", - "g suite event new", - "g suite event open", - "g suite event schedule", - "g suite event start", - "g suite invite add", - "g suite invite create", - "g suite invite make", - "g suite invite new", - "g suite invite open", - "g suite invite schedule", - "g suite invite start", - "g suite make event", - "g suite make invite", - "g suite make meeting", - "g suite meeting add", - "g suite meeting create", - "g suite meeting make", - "g suite meeting new", - "g suite meeting open", - "g suite meeting schedule", - "g suite meeting start", - "g suite new event", - "g suite new invite", - "g suite new meeting", - "g suite open event", - "g suite open invite", - "g suite open meeting", - "g suite schedule event", - "g suite schedule invite", - "g suite schedule meeting", - "g suite start event", - "g suite start invite", - "g suite start meeting", - "google add event", - "google add invite", - "google add meeting", - "google create event", - "google create invite", - "google create meeting", - "google event add", - "google event create", - "google event make", - "google event new", - "google event open", - "google event schedule", - "google event start", - "google invite add", - "google invite create", - "google invite make", - "google invite new", - "google invite open", - "google invite schedule", - "google invite start", - "google make event", - "google make invite", - "google make meeting", - "google meeting add", - "google meeting create", - "google meeting make", - "google meeting new", - "google meeting open", - "google meeting schedule", - "google meeting start", - "google new event", - "google new invite", - "google new meeting", - "google open event", - "google open invite", - "google open meeting", - "google schedule event", - "google schedule invite", - "google schedule meeting", - "google start event", - "google start invite", - "google start meeting", - "invite add browser", - "invite add cal", - "invite add calendar", - "invite add chrome", - "invite add g suite", - "invite add google", - "invite add workspace", - "invite browser add", - "invite browser create", - "invite browser make", - "invite browser new", - "invite browser open", - "invite browser schedule", - "invite browser start", - "invite cal add", - "invite cal create", - "invite cal make", - "invite cal new", - "invite cal open", - "invite cal schedule", - "invite cal start", - "invite calendar add", - "invite calendar create", - "invite calendar make", - "invite calendar new", - "invite calendar open", - "invite calendar schedule", - "invite calendar start", - "invite chrome add", - "invite chrome create", - "invite chrome make", - "invite chrome new", - "invite chrome open", - "invite chrome schedule", - "invite chrome start", - "invite create browser", - "invite create cal", - "invite create calendar", - "invite create chrome", - "invite create g suite", - "invite create google", - "invite create workspace", - "invite g suite add", - "invite g suite create", - "invite g suite make", - "invite g suite new", - "invite g suite open", - "invite g suite schedule", - "invite g suite start", - "invite google add", - "invite google create", - "invite google make", - "invite google new", - "invite google open", - "invite google schedule", - "invite google start", - "invite make browser", - "invite make cal", - "invite make calendar", - "invite make chrome", - "invite make g suite", - "invite make google", - "invite make workspace", - "invite new browser", - "invite new cal", - "invite new calendar", - "invite new chrome", - "invite new g suite", - "invite new google", - "invite new workspace", - "invite open browser", - "invite open cal", - "invite open calendar", - "invite open chrome", - "invite open g suite", - "invite open google", - "invite open workspace", - "invite schedule browser", - "invite schedule cal", - "invite schedule calendar", - "invite schedule chrome", - "invite schedule g suite", - "invite schedule google", - "invite schedule workspace", - "invite start browser", - "invite start cal", - "invite start calendar", - "invite start chrome", - "invite start g suite", - "invite start google", - "invite start workspace", - "invite workspace add", - "invite workspace create", - "invite workspace make", - "invite workspace new", - "invite workspace open", - "invite workspace schedule", - "invite workspace start", - "make browser event", - "make browser invite", - "make browser meeting", - "make cal event", - "make cal invite", - "make cal meeting", - "make calendar event", - "make calendar invite", - "make calendar meeting", - "make chrome event", - "make chrome invite", - "make chrome meeting", - "make event browser", - "make event cal", - "make event calendar", - "make event chrome", - "make event g suite", - "make event google", - "make event workspace", - "make g suite event", - "make g suite invite", - "make g suite meeting", - "make google event", - "make google invite", - "make google meeting", - "make invite browser", - "make invite cal", - "make invite calendar", - "make invite chrome", - "make invite g suite", - "make invite google", - "make invite workspace", - "make meeting browser", - "make meeting cal", - "make meeting calendar", - "make meeting chrome", - "make meeting g suite", - "make meeting google", - "make meeting workspace", - "make workspace event", - "make workspace invite", - "make workspace meeting", - "meeting add browser", - "meeting add cal", - "meeting add calendar", - "meeting add chrome", - "meeting add g suite", - "meeting add google", - "meeting add workspace", - "meeting browser add", - "meeting browser create", - "meeting browser make", - "meeting browser new", - "meeting browser open", - "meeting browser schedule", - "meeting browser start", - "meeting cal add", - "meeting cal create", - "meeting cal make", - "meeting cal new", - "meeting cal open", - "meeting cal schedule", - "meeting cal start", - "meeting calendar add", - "meeting calendar create", - "meeting calendar make", - "meeting calendar new", - "meeting calendar open", - "meeting calendar schedule", - "meeting calendar start", - "meeting chrome add", - "meeting chrome create", - "meeting chrome make", - "meeting chrome new", - "meeting chrome open", - "meeting chrome schedule", - "meeting chrome start", - "meeting create browser", - "meeting create cal", - "meeting create calendar", - "meeting create chrome", - "meeting create g suite", - "meeting create google", - "meeting create workspace", - "meeting g suite add", - "meeting g suite create", - "meeting g suite make", - "meeting g suite new", - "meeting g suite open", - "meeting g suite schedule", - "meeting g suite start", - "meeting google add", - "meeting google create", - "meeting google make", - "meeting google new", - "meeting google open", - "meeting google schedule", - "meeting google start", - "meeting make browser", - "meeting make cal", - "meeting make calendar", - "meeting make chrome", - "meeting make g suite", - "meeting make google", - "meeting make workspace", - "meeting new browser", - "meeting new cal", - "meeting new calendar", - "meeting new chrome", - "meeting new g suite", - "meeting new google", - "meeting new workspace", - "meeting open browser", - "meeting open cal", - "meeting open calendar", - "meeting open chrome", - "meeting open g suite", - "meeting open google", - "meeting open workspace", - "meeting schedule browser", - "meeting schedule cal", - "meeting schedule calendar", - "meeting schedule chrome", - "meeting schedule g suite", - "meeting schedule google", - "meeting schedule workspace", - "meeting start browser", - "meeting start cal", - "meeting start calendar", - "meeting start chrome", - "meeting start g suite", - "meeting start google", - "meeting start workspace", - "meeting workspace add", - "meeting workspace create", - "meeting workspace make", - "meeting workspace new", - "meeting workspace open", - "meeting workspace schedule", - "meeting workspace start", - "new browser event", - "new browser invite", - "new browser meeting", - "new cal event", - "new cal invite", - "new cal meeting", - "new calendar event", - "new calendar invite", - "new calendar meeting", - "new chrome event", - "new chrome invite", - "new chrome meeting", - "new event browser", - "new event cal", - "new event calendar", - "new event chrome", - "new event g suite", - "new event google", - "new event workspace", - "new g suite event", - "new g suite invite", - "new g suite meeting", - "new google event", - "new google invite", - "new google meeting", - "new invite browser", - "new invite cal", - "new invite calendar", - "new invite chrome", - "new invite g suite", - "new invite google", - "new invite workspace", - "new meeting browser", - "new meeting cal", - "new meeting calendar", - "new meeting chrome", - "new meeting g suite", - "new meeting google", - "new meeting workspace", - "new workspace event", - "new workspace invite", - "new workspace meeting", - "open browser event", - "open browser invite", - "open browser meeting", - "open cal event", - "open cal invite", - "open cal meeting", - "open calendar event", - "open calendar invite", - "open calendar meeting", - "open chrome event", - "open chrome invite", - "open chrome meeting", - "open event browser", - "open event cal", - "open event calendar", - "open event chrome", - "open event g suite", - "open event google", - "open event workspace", - "open g suite event", - "open g suite invite", - "open g suite meeting", - "open google event", - "open google invite", - "open google meeting", - "open invite browser", - "open invite cal", - "open invite calendar", - "open invite chrome", - "open invite g suite", - "open invite google", - "open invite workspace", - "open meeting browser", - "open meeting cal", - "open meeting calendar", - "open meeting chrome", - "open meeting g suite", - "open meeting google", - "open meeting workspace", - "open workspace event", - "open workspace invite", - "open workspace meeting", - "schedule browser event", - "schedule browser invite", - "schedule browser meeting", - "schedule cal event", - "schedule cal invite", - "schedule cal meeting", - "schedule calendar event", - "schedule calendar invite", - "schedule calendar meeting", - "schedule chrome event", - "schedule chrome invite", - "schedule chrome meeting", - "schedule event browser", - "schedule event cal", - "schedule event calendar", - "schedule event chrome", - "schedule event g suite", - "schedule event google", - "schedule event workspace", - "schedule g suite event", - "schedule g suite invite", - "schedule g suite meeting", - "schedule google event", - "schedule google invite", - "schedule google meeting", - "schedule invite browser", - "schedule invite cal", - "schedule invite calendar", - "schedule invite chrome", - "schedule invite g suite", - "schedule invite google", - "schedule invite workspace", - "schedule meeting browser", - "schedule meeting cal", - "schedule meeting calendar", - "schedule meeting chrome", - "schedule meeting g suite", - "schedule meeting google", - "schedule meeting workspace", - "schedule workspace event", - "schedule workspace invite", - "schedule workspace meeting", - "start browser event", - "start browser invite", - "start browser meeting", - "start cal event", - "start cal invite", - "start cal meeting", - "start calendar event", - "start calendar invite", - "start calendar meeting", - "start chrome event", - "start chrome invite", - "start chrome meeting", - "start event browser", - "start event cal", - "start event calendar", - "start event chrome", - "start event g suite", - "start event google", - "start event workspace", - "start g suite event", - "start g suite invite", - "start g suite meeting", - "start google event", - "start google invite", - "start google meeting", - "start invite browser", - "start invite cal", - "start invite calendar", - "start invite chrome", - "start invite g suite", - "start invite google", - "start invite workspace", - "start meeting browser", - "start meeting cal", - "start meeting calendar", - "start meeting chrome", - "start meeting g suite", - "start meeting google", - "start meeting workspace", - "start workspace event", - "start workspace invite", - "start workspace meeting", - "workspace add event", - "workspace add invite", - "workspace add meeting", - "workspace create event", - "workspace create invite", - "workspace create meeting", - "workspace event add", - "workspace event create", - "workspace event make", - "workspace event new", - "workspace event open", - "workspace event schedule", - "workspace event start", - "workspace invite add", - "workspace invite create", - "workspace invite make", - "workspace invite new", - "workspace invite open", - "workspace invite schedule", - "workspace invite start", - "workspace make event", - "workspace make invite", - "workspace make meeting", - "workspace meeting add", - "workspace meeting create", - "workspace meeting make", - "workspace meeting new", - "workspace meeting open", - "workspace meeting schedule", - "workspace meeting start", - "workspace new event", - "workspace new invite", - "workspace new meeting", - "workspace open event", - "workspace open invite", - "workspace open meeting", - "workspace schedule event", - "workspace schedule invite", - "workspace schedule meeting", - "workspace start event", - "workspace start invite", - "workspace start meeting", - }, - - // ID#17 - { - // Generated suggestions: - "browser create site", - "browser create website", - "browser make site", - "browser make website", - "browser new site", - "browser new website", - "browser open site", - "browser open website", - "browser site create", - "browser site make", - "browser site new", - "browser site open", - "browser site start", - "browser start site", - "browser start website", - "browser website create", - "browser website make", - "browser website new", - "browser website open", - "browser website start", - "chrome create site", - "chrome create website", - "chrome make site", - "chrome make website", - "chrome new site", - "chrome new website", - "chrome open site", - "chrome open website", - "chrome site create", - "chrome site make", - "chrome site new", - "chrome site open", - "chrome site start", - "chrome start site", - "chrome start website", - "chrome website create", - "chrome website make", - "chrome website new", - "chrome website open", - "chrome website start", - "create browser site", - "create browser website", - "create chrome site", - "create chrome website", - "create g suite site", - "create g suite website", - "create google site", - "create google website", - "create site browser", - "create site chrome", - "create site g suite", - "create site google", - "create site workspace", - "create website browser", - "create website chrome", - "create website g suite", - "create website google", - "create website workspace", - "create workspace site", - "create workspace website", - "g suite create site", - "g suite create website", - "g suite make site", - "g suite make website", - "g suite new site", - "g suite new website", - "g suite open site", - "g suite open website", - "g suite site create", - "g suite site make", - "g suite site new", - "g suite site open", - "g suite site start", - "g suite start site", - "g suite start website", - "g suite website create", - "g suite website make", - "g suite website new", - "g suite website open", - "g suite website start", - "google create site", - "google create website", - "google make site", - "google make website", - "google new site", - "google new website", - "google open site", - "google open website", - "google site create", - "google site make", - "google site new", - "google site open", - "google site start", - "google start site", - "google start website", - "google website create", - "google website make", - "google website new", - "google website open", - "google website start", - "make browser site", - "make browser website", - "make chrome site", - "make chrome website", - "make g suite site", - "make g suite website", - "make google site", - "make google website", - "make site browser", - "make site chrome", - "make site g suite", - "make site google", - "make site workspace", - "make website browser", - "make website chrome", - "make website g suite", - "make website google", - "make website workspace", - "make workspace site", - "make workspace website", - "new browser site", - "new browser website", - "new chrome site", - "new chrome website", - "new g suite site", - "new g suite website", - "new google site", - "new google website", - "new site browser", - "new site chrome", - "new site g suite", - "new site google", - "new site workspace", - "new website browser", - "new website chrome", - "new website g suite", - "new website google", - "new website workspace", - "new workspace site", - "new workspace website", - "open browser site", - "open browser website", - "open chrome site", - "open chrome website", - "open g suite site", - "open g suite website", - "open google site", - "open google website", - "open site browser", - "open site chrome", - "open site g suite", - "open site google", - "open site workspace", - "open website browser", - "open website chrome", - "open website g suite", - "open website google", - "open website workspace", - "open workspace site", - "open workspace website", - "site browser create", - "site browser make", - "site browser new", - "site browser open", - "site browser start", - "site chrome create", - "site chrome make", - "site chrome new", - "site chrome open", - "site chrome start", - "site create browser", - "site create chrome", - "site create g suite", - "site create google", - "site create workspace", - "site g suite create", - "site g suite make", - "site g suite new", - "site g suite open", - "site g suite start", - "site google create", - "site google make", - "site google new", - "site google open", - "site google start", - "site make browser", - "site make chrome", - "site make g suite", - "site make google", - "site make workspace", - "site new browser", - "site new chrome", - "site new g suite", - "site new google", - "site new workspace", - "site open browser", - "site open chrome", - "site open g suite", - "site open google", - "site open workspace", - "site start browser", - "site start chrome", - "site start g suite", - "site start google", - "site start workspace", - "site workspace create", - "site workspace make", - "site workspace new", - "site workspace open", - "site workspace start", - "start browser site", - "start browser website", - "start chrome site", - "start chrome website", - "start g suite site", - "start g suite website", - "start google site", - "start google website", - "start site browser", - "start site chrome", - "start site g suite", - "start site google", - "start site workspace", - "start website browser", - "start website chrome", - "start website g suite", - "start website google", - "start website workspace", - "start workspace site", - "start workspace website", - "website browser create", - "website browser make", - "website browser new", - "website browser open", - "website browser start", - "website chrome create", - "website chrome make", - "website chrome new", - "website chrome open", - "website chrome start", - "website create browser", - "website create chrome", - "website create g suite", - "website create google", - "website create workspace", - "website g suite create", - "website g suite make", - "website g suite new", - "website g suite open", - "website g suite start", - "website google create", - "website google make", - "website google new", - "website google open", - "website google start", - "website make browser", - "website make chrome", - "website make g suite", - "website make google", - "website make workspace", - "website new browser", - "website new chrome", - "website new g suite", - "website new google", - "website new workspace", - "website open browser", - "website open chrome", - "website open g suite", - "website open google", - "website open workspace", - "website start browser", - "website start chrome", - "website start g suite", - "website start google", - "website start workspace", - "website workspace create", - "website workspace make", - "website workspace new", - "website workspace open", - "website workspace start", - "workspace create site", - "workspace create website", - "workspace make site", - "workspace make website", - "workspace new site", - "workspace new website", - "workspace open site", - "workspace open website", - "workspace site create", - "workspace site make", - "workspace site new", - "workspace site open", - "workspace site start", - "workspace start site", - "workspace start website", - "workspace website create", - "workspace website make", - "workspace website new", - "workspace website open", - "workspace website start", - }, - - // ID#18 - { - // Generated suggestions: - "browser create note", - "browser create notes", - "browser make note", - "browser make notes", - "browser new note", - "browser new notes", - "browser note create", - "browser note make", - "browser note new", - "browser note open", - "browser note start", - "browser notes create", - "browser notes make", - "browser notes new", - "browser notes open", - "browser notes start", - "browser open note", - "browser open notes", - "browser start note", - "browser start notes", - "chrome create note", - "chrome create notes", - "chrome make note", - "chrome make notes", - "chrome new note", - "chrome new notes", - "chrome note create", - "chrome note make", - "chrome note new", - "chrome note open", - "chrome note start", - "chrome notes create", - "chrome notes make", - "chrome notes new", - "chrome notes open", - "chrome notes start", - "chrome open note", - "chrome open notes", - "chrome start note", - "chrome start notes", - "create browser note", - "create browser notes", - "create chrome note", - "create chrome notes", - "create g suite note", - "create g suite notes", - "create google note", - "create google notes", - "create keep note", - "create keep notes", - "create note browser", - "create note chrome", - "create note g suite", - "create note google", - "create note keep", - "create note workspace", - "create notes browser", - "create notes chrome", - "create notes g suite", - "create notes google", - "create notes keep", - "create notes workspace", - "create workspace note", - "create workspace notes", - "g suite create note", - "g suite create notes", - "g suite make note", - "g suite make notes", - "g suite new note", - "g suite new notes", - "g suite note create", - "g suite note make", - "g suite note new", - "g suite note open", - "g suite note start", - "g suite notes create", - "g suite notes make", - "g suite notes new", - "g suite notes open", - "g suite notes start", - "g suite open note", - "g suite open notes", - "g suite start note", - "g suite start notes", - "google create note", - "google create notes", - "google make note", - "google make notes", - "google new note", - "google new notes", - "google note create", - "google note make", - "google note new", - "google note open", - "google note start", - "google notes create", - "google notes make", - "google notes new", - "google notes open", - "google notes start", - "google open note", - "google open notes", - "google start note", - "google start notes", - "keep create note", - "keep create notes", - "keep make note", - "keep make notes", - "keep new note", - "keep new notes", - "keep note create", - "keep note make", - "keep note new", - "keep note open", - "keep note start", - "keep notes create", - "keep notes make", - "keep notes new", - "keep notes open", - "keep notes start", - "keep open note", - "keep open notes", - "keep start note", - "keep start notes", - "make browser note", - "make browser notes", - "make chrome note", - "make chrome notes", - "make g suite note", - "make g suite notes", - "make google note", - "make google notes", - "make keep note", - "make keep notes", - "make note browser", - "make note chrome", - "make note g suite", - "make note google", - "make note keep", - "make note workspace", - "make notes browser", - "make notes chrome", - "make notes g suite", - "make notes google", - "make notes keep", - "make notes workspace", - "make workspace note", - "make workspace notes", - "new browser note", - "new browser notes", - "new chrome note", - "new chrome notes", - "new g suite note", - "new g suite notes", - "new google note", - "new google notes", - "new keep note", - "new keep notes", - "new note browser", - "new note chrome", - "new note g suite", - "new note google", - "new note keep", - "new note workspace", - "new notes browser", - "new notes chrome", - "new notes g suite", - "new notes google", - "new notes keep", - "new notes workspace", - "new workspace note", - "new workspace notes", - "note browser create", - "note browser make", - "note browser new", - "note browser open", - "note browser start", - "note chrome create", - "note chrome make", - "note chrome new", - "note chrome open", - "note chrome start", - "note create browser", - "note create chrome", - "note create g suite", - "note create google", - "note create keep", - "note create workspace", - "note g suite create", - "note g suite make", - "note g suite new", - "note g suite open", - "note g suite start", - "note google create", - "note google make", - "note google new", - "note google open", - "note google start", - "note keep create", - "note keep make", - "note keep new", - "note keep open", - "note keep start", - "note make browser", - "note make chrome", - "note make g suite", - "note make google", - "note make keep", - "note make workspace", - "note new browser", - "note new chrome", - "note new g suite", - "note new google", - "note new keep", - "note new workspace", - "note open browser", - "note open chrome", - "note open g suite", - "note open google", - "note open keep", - "note open workspace", - "note start browser", - "note start chrome", - "note start g suite", - "note start google", - "note start keep", - "note start workspace", - "note workspace create", - "note workspace make", - "note workspace new", - "note workspace open", - "note workspace start", - "notes browser create", - "notes browser make", - "notes browser new", - "notes browser open", - "notes browser start", - "notes chrome create", - "notes chrome make", - "notes chrome new", - "notes chrome open", - "notes chrome start", - "notes create browser", - "notes create chrome", - "notes create g suite", - "notes create google", - "notes create keep", - "notes create workspace", - "notes g suite create", - "notes g suite make", - "notes g suite new", - "notes g suite open", - "notes g suite start", - "notes google create", - "notes google make", - "notes google new", - "notes google open", - "notes google start", - "notes keep create", - "notes keep make", - "notes keep new", - "notes keep open", - "notes keep start", - "notes make browser", - "notes make chrome", - "notes make g suite", - "notes make google", - "notes make keep", - "notes make workspace", - "notes new browser", - "notes new chrome", - "notes new g suite", - "notes new google", - "notes new keep", - "notes new workspace", - "notes open browser", - "notes open chrome", - "notes open g suite", - "notes open google", - "notes open keep", - "notes open workspace", - "notes start browser", - "notes start chrome", - "notes start g suite", - "notes start google", - "notes start keep", - "notes start workspace", - "notes workspace create", - "notes workspace make", - "notes workspace new", - "notes workspace open", - "notes workspace start", - "open browser note", - "open browser notes", - "open chrome note", - "open chrome notes", - "open g suite note", - "open g suite notes", - "open google note", - "open google notes", - "open keep note", - "open keep notes", - "open note browser", - "open note chrome", - "open note g suite", - "open note google", - "open note keep", - "open note workspace", - "open notes browser", - "open notes chrome", - "open notes g suite", - "open notes google", - "open notes keep", - "open notes workspace", - "open workspace note", - "open workspace notes", - "start browser note", - "start browser notes", - "start chrome note", - "start chrome notes", - "start g suite note", - "start g suite notes", - "start google note", - "start google notes", - "start keep note", - "start keep notes", - "start note browser", - "start note chrome", - "start note g suite", - "start note google", - "start note keep", - "start note workspace", - "start notes browser", - "start notes chrome", - "start notes g suite", - "start notes google", - "start notes keep", - "start notes workspace", - "start workspace note", - "start workspace notes", - "workspace create note", - "workspace create notes", - "workspace make note", - "workspace make notes", - "workspace new note", - "workspace new notes", - "workspace note create", - "workspace note make", - "workspace note new", - "workspace note open", - "workspace note start", - "workspace notes create", - "workspace notes make", - "workspace notes new", - "workspace notes open", - "workspace notes start", - "workspace open note", - "workspace open notes", - "workspace start note", - "workspace start notes", - }, - - // ID#19 - { - // Generated suggestions: - "browser create form", - "browser create forms", - "browser create quiz", - "browser create survey", - "browser form create", - "browser form make", - "browser form new", - "browser form open", - "browser form start", - "browser forms create", - "browser forms make", - "browser forms new", - "browser forms open", - "browser forms start", - "browser make form", - "browser make forms", - "browser make quiz", - "browser make survey", - "browser new form", - "browser new forms", - "browser new quiz", - "browser new survey", - "browser open form", - "browser open forms", - "browser open quiz", - "browser open survey", - "browser quiz create", - "browser quiz make", - "browser quiz new", - "browser quiz open", - "browser quiz start", - "browser start form", - "browser start forms", - "browser start quiz", - "browser start survey", - "browser survey create", - "browser survey make", - "browser survey new", - "browser survey open", - "browser survey start", - "chrome create form", - "chrome create forms", - "chrome create quiz", - "chrome create survey", - "chrome form create", - "chrome form make", - "chrome form new", - "chrome form open", - "chrome form start", - "chrome forms create", - "chrome forms make", - "chrome forms new", - "chrome forms open", - "chrome forms start", - "chrome make form", - "chrome make forms", - "chrome make quiz", - "chrome make survey", - "chrome new form", - "chrome new forms", - "chrome new quiz", - "chrome new survey", - "chrome open form", - "chrome open forms", - "chrome open quiz", - "chrome open survey", - "chrome quiz create", - "chrome quiz make", - "chrome quiz new", - "chrome quiz open", - "chrome quiz start", - "chrome start form", - "chrome start forms", - "chrome start quiz", - "chrome start survey", - "chrome survey create", - "chrome survey make", - "chrome survey new", - "chrome survey open", - "chrome survey start", - "create browser form", - "create browser forms", - "create browser quiz", - "create browser survey", - "create chrome form", - "create chrome forms", - "create chrome quiz", - "create chrome survey", - "create form browser", - "create form chrome", - "create form g suite", - "create form google", - "create form workspace", - "create forms browser", - "create forms chrome", - "create forms g suite", - "create forms google", - "create forms workspace", - "create g suite form", - "create g suite forms", - "create g suite quiz", - "create g suite survey", - "create google form", - "create google forms", - "create google quiz", - "create google survey", - "create quiz browser", - "create quiz chrome", - "create quiz g suite", - "create quiz google", - "create quiz workspace", - "create survey browser", - "create survey chrome", - "create survey g suite", - "create survey google", - "create survey workspace", - "create workspace form", - "create workspace forms", - "create workspace quiz", - "create workspace survey", - "form browser create", - "form browser make", - "form browser new", - "form browser open", - "form browser start", - "form chrome create", - "form chrome make", - "form chrome new", - "form chrome open", - "form chrome start", - "form create browser", - "form create chrome", - "form create g suite", - "form create google", - "form create workspace", - "form g suite create", - "form g suite make", - "form g suite new", - "form g suite open", - "form g suite start", - "form google create", - "form google make", - "form google new", - "form google open", - "form google start", - "form make browser", - "form make chrome", - "form make g suite", - "form make google", - "form make workspace", - "form new browser", - "form new chrome", - "form new g suite", - "form new google", - "form new workspace", - "form open browser", - "form open chrome", - "form open g suite", - "form open google", - "form open workspace", - "form start browser", - "form start chrome", - "form start g suite", - "form start google", - "form start workspace", - "form workspace create", - "form workspace make", - "form workspace new", - "form workspace open", - "form workspace start", - "forms browser create", - "forms browser make", - "forms browser new", - "forms browser open", - "forms browser start", - "forms chrome create", - "forms chrome make", - "forms chrome new", - "forms chrome open", - "forms chrome start", - "forms create browser", - "forms create chrome", - "forms create g suite", - "forms create google", - "forms create workspace", - "forms g suite create", - "forms g suite make", - "forms g suite new", - "forms g suite open", - "forms g suite start", - "forms google create", - "forms google make", - "forms google new", - "forms google open", - "forms google start", - "forms make browser", - "forms make chrome", - "forms make g suite", - "forms make google", - "forms make workspace", - "forms new browser", - "forms new chrome", - "forms new g suite", - "forms new google", - "forms new workspace", - "forms open browser", - "forms open chrome", - "forms open g suite", - "forms open google", - "forms open workspace", - "forms start browser", - "forms start chrome", - "forms start g suite", - "forms start google", - "forms start workspace", - "forms workspace create", - "forms workspace make", - "forms workspace new", - "forms workspace open", - "forms workspace start", - "g suite create form", - "g suite create forms", - "g suite create quiz", - "g suite create survey", - "g suite form create", - "g suite form make", - "g suite form new", - "g suite form open", - "g suite form start", - "g suite forms create", - "g suite forms make", - "g suite forms new", - "g suite forms open", - "g suite forms start", - "g suite make form", - "g suite make forms", - "g suite make quiz", - "g suite make survey", - "g suite new form", - "g suite new forms", - "g suite new quiz", - "g suite new survey", - "g suite open form", - "g suite open forms", - "g suite open quiz", - "g suite open survey", - "g suite quiz create", - "g suite quiz make", - "g suite quiz new", - "g suite quiz open", - "g suite quiz start", - "g suite start form", - "g suite start forms", - "g suite start quiz", - "g suite start survey", - "g suite survey create", - "g suite survey make", - "g suite survey new", - "g suite survey open", - "g suite survey start", - "google create form", - "google create forms", - "google create quiz", - "google create survey", - "google form create", - "google form make", - "google form new", - "google form open", - "google form start", - "google forms create", - "google forms make", - "google forms new", - "google forms open", - "google forms start", - "google make form", - "google make forms", - "google make quiz", - "google make survey", - "google new form", - "google new forms", - "google new quiz", - "google new survey", - "google open form", - "google open forms", - "google open quiz", - "google open survey", - "google quiz create", - "google quiz make", - "google quiz new", - "google quiz open", - "google quiz start", - "google start form", - "google start forms", - "google start quiz", - "google start survey", - "google survey create", - "google survey make", - "google survey new", - "google survey open", - "google survey start", - "make browser form", - "make browser forms", - "make browser quiz", - "make browser survey", - "make chrome form", - "make chrome forms", - "make chrome quiz", - "make chrome survey", - "make form browser", - "make form chrome", - "make form g suite", - "make form google", - "make form workspace", - "make forms browser", - "make forms chrome", - "make forms g suite", - "make forms google", - "make forms workspace", - "make g suite form", - "make g suite forms", - "make g suite quiz", - "make g suite survey", - "make google form", - "make google forms", - "make google quiz", - "make google survey", - "make quiz browser", - "make quiz chrome", - "make quiz g suite", - "make quiz google", - "make quiz workspace", - "make survey browser", - "make survey chrome", - "make survey g suite", - "make survey google", - "make survey workspace", - "make workspace form", - "make workspace forms", - "make workspace quiz", - "make workspace survey", - "new browser form", - "new browser forms", - "new browser quiz", - "new browser survey", - "new chrome form", - "new chrome forms", - "new chrome quiz", - "new chrome survey", - "new form browser", - "new form chrome", - "new form g suite", - "new form google", - "new form workspace", - "new forms browser", - "new forms chrome", - "new forms g suite", - "new forms google", - "new forms workspace", - "new g suite form", - "new g suite forms", - "new g suite quiz", - "new g suite survey", - "new google form", - "new google forms", - "new google quiz", - "new google survey", - "new quiz browser", - "new quiz chrome", - "new quiz g suite", - "new quiz google", - "new quiz workspace", - "new survey browser", - "new survey chrome", - "new survey g suite", - "new survey google", - "new survey workspace", - "new workspace form", - "new workspace forms", - "new workspace quiz", - "new workspace survey", - "open browser form", - "open browser forms", - "open browser quiz", - "open browser survey", - "open chrome form", - "open chrome forms", - "open chrome quiz", - "open chrome survey", - "open form browser", - "open form chrome", - "open form g suite", - "open form google", - "open form workspace", - "open forms browser", - "open forms chrome", - "open forms g suite", - "open forms google", - "open forms workspace", - "open g suite form", - "open g suite forms", - "open g suite quiz", - "open g suite survey", - "open google form", - "open google forms", - "open google quiz", - "open google survey", - "open quiz browser", - "open quiz chrome", - "open quiz g suite", - "open quiz google", - "open quiz workspace", - "open survey browser", - "open survey chrome", - "open survey g suite", - "open survey google", - "open survey workspace", - "open workspace form", - "open workspace forms", - "open workspace quiz", - "open workspace survey", - "quiz browser create", - "quiz browser make", - "quiz browser new", - "quiz browser open", - "quiz browser start", - "quiz chrome create", - "quiz chrome make", - "quiz chrome new", - "quiz chrome open", - "quiz chrome start", - "quiz create browser", - "quiz create chrome", - "quiz create g suite", - "quiz create google", - "quiz create workspace", - "quiz g suite create", - "quiz g suite make", - "quiz g suite new", - "quiz g suite open", - "quiz g suite start", - "quiz google create", - "quiz google make", - "quiz google new", - "quiz google open", - "quiz google start", - "quiz make browser", - "quiz make chrome", - "quiz make g suite", - "quiz make google", - "quiz make workspace", - "quiz new browser", - "quiz new chrome", - "quiz new g suite", - "quiz new google", - "quiz new workspace", - "quiz open browser", - "quiz open chrome", - "quiz open g suite", - "quiz open google", - "quiz open workspace", - "quiz start browser", - "quiz start chrome", - "quiz start g suite", - "quiz start google", - "quiz start workspace", - "quiz workspace create", - "quiz workspace make", - "quiz workspace new", - "quiz workspace open", - "quiz workspace start", - "start browser form", - "start browser forms", - "start browser quiz", - "start browser survey", - "start chrome form", - "start chrome forms", - "start chrome quiz", - "start chrome survey", - "start form browser", - "start form chrome", - "start form g suite", - "start form google", - "start form workspace", - "start forms browser", - "start forms chrome", - "start forms g suite", - "start forms google", - "start forms workspace", - "start g suite form", - "start g suite forms", - "start g suite quiz", - "start g suite survey", - "start google form", - "start google forms", - "start google quiz", - "start google survey", - "start quiz browser", - "start quiz chrome", - "start quiz g suite", - "start quiz google", - "start quiz workspace", - "start survey browser", - "start survey chrome", - "start survey g suite", - "start survey google", - "start survey workspace", - "start workspace form", - "start workspace forms", - "start workspace quiz", - "start workspace survey", - "survey browser create", - "survey browser make", - "survey browser new", - "survey browser open", - "survey browser start", - "survey chrome create", - "survey chrome make", - "survey chrome new", - "survey chrome open", - "survey chrome start", - "survey create browser", - "survey create chrome", - "survey create g suite", - "survey create google", - "survey create workspace", - "survey g suite create", - "survey g suite make", - "survey g suite new", - "survey g suite open", - "survey g suite start", - "survey google create", - "survey google make", - "survey google new", - "survey google open", - "survey google start", - "survey make browser", - "survey make chrome", - "survey make g suite", - "survey make google", - "survey make workspace", - "survey new browser", - "survey new chrome", - "survey new g suite", - "survey new google", - "survey new workspace", - "survey open browser", - "survey open chrome", - "survey open g suite", - "survey open google", - "survey open workspace", - "survey start browser", - "survey start chrome", - "survey start g suite", - "survey start google", - "survey start workspace", - "survey workspace create", - "survey workspace make", - "survey workspace new", - "survey workspace open", - "survey workspace start", - "workspace create form", - "workspace create forms", - "workspace create quiz", - "workspace create survey", - "workspace form create", - "workspace form make", - "workspace form new", - "workspace form open", - "workspace form start", - "workspace forms create", - "workspace forms make", - "workspace forms new", - "workspace forms open", - "workspace forms start", - "workspace make form", - "workspace make forms", - "workspace make quiz", - "workspace make survey", - "workspace new form", - "workspace new forms", - "workspace new quiz", - "workspace new survey", - "workspace open form", - "workspace open forms", - "workspace open quiz", - "workspace open survey", - "workspace quiz create", - "workspace quiz make", - "workspace quiz new", - "workspace quiz open", - "workspace quiz start", - "workspace start form", - "workspace start forms", - "workspace start quiz", - "workspace start survey", - "workspace survey create", - "workspace survey make", - "workspace survey new", - "workspace survey open", - "workspace survey start", - }, - - // ID#21 - { - // Generated suggestions: - "browser chrome features", - "browser chrome features explore", - "browser chrome features learn", - "browser chrome features make the most of", - "browser chrome features see", - "browser chrome features understand", - "browser chrome features visit", - "browser chrome tips", - "browser chrome tips center", - "browser chrome tips center explore", - "browser chrome tips center learn", - "browser chrome tips center make the most of", - "browser chrome tips center see", - "browser chrome tips center understand", - "browser chrome tips center visit", - "browser chrome tips explore", - "browser chrome tips learn", - "browser chrome tips make the most of", - "browser chrome tips see", - "browser chrome tips understand", - "browser chrome tips visit", - "browser explore chrome features", - "browser explore chrome tips", - "browser explore chrome tips center", - "browser explore new chrome features", - "browser learn chrome features", - "browser learn chrome tips", - "browser learn chrome tips center", - "browser learn new chrome features", - "browser make the most of chrome features", - "browser make the most of chrome tips", - "browser make the most of chrome tips center", - "browser make the most of new chrome features", - "browser new chrome features", - "browser new chrome features explore", - "browser new chrome features learn", - "browser new chrome features make the most of", - "browser new chrome features see", - "browser new chrome features understand", - "browser new chrome features visit", - "browser see chrome features", - "browser see chrome tips", - "browser see chrome tips center", - "browser see new chrome features", - "browser understand chrome features", - "browser understand chrome tips", - "browser understand chrome tips center", - "browser understand new chrome features", - "browser visit chrome features", - "browser visit chrome tips", - "browser visit chrome tips center", - "browser visit new chrome features", - "chrome features", - "chrome features browser", - "chrome features browser explore", - "chrome features browser learn", - "chrome features browser make the most of", - "chrome features browser see", - "chrome features browser understand", - "chrome features browser visit", - "chrome features explore", - "chrome features explore browser", - "chrome features explore google", - "chrome features google", - "chrome features google explore", - "chrome features google learn", - "chrome features google make the most of", - "chrome features google see", - "chrome features google understand", - "chrome features google visit", - "chrome features learn", - "chrome features learn browser", - "chrome features learn google", - "chrome features make the most of", - "chrome features make the most of browser", - "chrome features make the most of google", - "chrome features see", - "chrome features see browser", - "chrome features see google", - "chrome features understand", - "chrome features understand browser", - "chrome features understand google", - "chrome features visit", - "chrome features visit browser", - "chrome features visit google", - "chrome tips", - "chrome tips browser", - "chrome tips browser explore", - "chrome tips browser learn", - "chrome tips browser make the most of", - "chrome tips browser see", - "chrome tips browser understand", - "chrome tips browser visit", - "chrome tips center", - "chrome tips center browser", - "chrome tips center browser explore", - "chrome tips center browser learn", - "chrome tips center browser make the most of", - "chrome tips center browser see", - "chrome tips center browser understand", - "chrome tips center browser visit", - "chrome tips center explore", - "chrome tips center explore browser", - "chrome tips center explore google", - "chrome tips center google", - "chrome tips center google explore", - "chrome tips center google learn", - "chrome tips center google make the most of", - "chrome tips center google see", - "chrome tips center google understand", - "chrome tips center google visit", - "chrome tips center learn", - "chrome tips center learn browser", - "chrome tips center learn google", - "chrome tips center make the most of", - "chrome tips center make the most of browser", - "chrome tips center make the most of google", - "chrome tips center see", - "chrome tips center see browser", - "chrome tips center see google", - "chrome tips center understand", - "chrome tips center understand browser", - "chrome tips center understand google", - "chrome tips center visit", - "chrome tips center visit browser", - "chrome tips center visit google", - "chrome tips explore", - "chrome tips explore browser", - "chrome tips explore google", - "chrome tips google", - "chrome tips google explore", - "chrome tips google learn", - "chrome tips google make the most of", - "chrome tips google see", - "chrome tips google understand", - "chrome tips google visit", - "chrome tips learn", - "chrome tips learn browser", - "chrome tips learn google", - "chrome tips make the most of", - "chrome tips make the most of browser", - "chrome tips make the most of google", - "chrome tips see", - "chrome tips see browser", - "chrome tips see google", - "chrome tips understand", - "chrome tips understand browser", - "chrome tips understand google", - "chrome tips visit", - "chrome tips visit browser", - "chrome tips visit google", - "explore browser chrome features", - "explore browser chrome tips", - "explore browser chrome tips center", - "explore browser new chrome features", - "explore chrome features", - "explore chrome features browser", - "explore chrome features google", - "explore chrome tips", - "explore chrome tips browser", - "explore chrome tips center", - "explore chrome tips center browser", - "explore chrome tips center google", - "explore chrome tips google", - "explore google chrome features", - "explore google chrome tips", - "explore google chrome tips center", - "explore google new chrome features", - "explore new chrome features", - "explore new chrome features browser", - "explore new chrome features google", - "google chrome features", - "google chrome features explore", - "google chrome features learn", - "google chrome features make the most of", - "google chrome features see", - "google chrome features understand", - "google chrome features visit", - "google chrome tips", - "google chrome tips center", - "google chrome tips center explore", - "google chrome tips center learn", - "google chrome tips center make the most of", - "google chrome tips center see", - "google chrome tips center understand", - "google chrome tips center visit", - "google chrome tips explore", - "google chrome tips learn", - "google chrome tips make the most of", - "google chrome tips see", - "google chrome tips understand", - "google chrome tips visit", - "google explore chrome features", - "google explore chrome tips", - "google explore chrome tips center", - "google explore new chrome features", - "google learn chrome features", - "google learn chrome tips", - "google learn chrome tips center", - "google learn new chrome features", - "google make the most of chrome features", - "google make the most of chrome tips", - "google make the most of chrome tips center", - "google make the most of new chrome features", - "google new chrome features", - "google new chrome features explore", - "google new chrome features learn", - "google new chrome features make the most of", - "google new chrome features see", - "google new chrome features understand", - "google new chrome features visit", - "google see chrome features", - "google see chrome tips", - "google see chrome tips center", - "google see new chrome features", - "google understand chrome features", - "google understand chrome tips", - "google understand chrome tips center", - "google understand new chrome features", - "google visit chrome features", - "google visit chrome tips", - "google visit chrome tips center", - "google visit new chrome features", - "learn browser chrome features", - "learn browser chrome tips", - "learn browser chrome tips center", - "learn browser new chrome features", - "learn chrome features", - "learn chrome features browser", - "learn chrome features google", - "learn chrome tips", - "learn chrome tips browser", - "learn chrome tips center", - "learn chrome tips center browser", - "learn chrome tips center google", - "learn chrome tips google", - "learn google chrome features", - "learn google chrome tips", - "learn google chrome tips center", - "learn google new chrome features", - "learn new chrome features", - "learn new chrome features browser", - "learn new chrome features google", - "make the most of browser chrome features", - "make the most of browser chrome tips", - "make the most of browser chrome tips center", - "make the most of browser new chrome features", - "make the most of chrome features", - "make the most of chrome features browser", - "make the most of chrome features google", - "make the most of chrome tips", - "make the most of chrome tips browser", - "make the most of chrome tips center", - "make the most of chrome tips center browser", - "make the most of chrome tips center google", - "make the most of chrome tips google", - "make the most of google chrome features", - "make the most of google chrome tips", - "make the most of google chrome tips center", - "make the most of google new chrome features", - "make the most of new chrome features", - "make the most of new chrome features browser", - "make the most of new chrome features google", - "new chrome features", - "new chrome features browser", - "new chrome features browser explore", - "new chrome features browser learn", - "new chrome features browser make the most of", - "new chrome features browser see", - "new chrome features browser understand", - "new chrome features browser visit", - "new chrome features explore", - "new chrome features explore browser", - "new chrome features explore google", - "new chrome features google", - "new chrome features google explore", - "new chrome features google learn", - "new chrome features google make the most of", - "new chrome features google see", - "new chrome features google understand", - "new chrome features google visit", - "new chrome features learn", - "new chrome features learn browser", - "new chrome features learn google", - "new chrome features make the most of", - "new chrome features make the most of browser", - "new chrome features make the most of google", - "new chrome features see", - "new chrome features see browser", - "new chrome features see google", - "new chrome features understand", - "new chrome features understand browser", - "new chrome features understand google", - "new chrome features visit", - "new chrome features visit browser", - "new chrome features visit google", - "see browser chrome features", - "see browser chrome tips", - "see browser chrome tips center", - "see browser new chrome features", - "see chrome features", - "see chrome features browser", - "see chrome features google", - "see chrome tips", - "see chrome tips browser", - "see chrome tips center", - "see chrome tips center browser", - "see chrome tips center google", - "see chrome tips google", - "see google chrome features", - "see google chrome tips", - "see google chrome tips center", - "see google new chrome features", - "see new chrome features", - "see new chrome features browser", - "see new chrome features google", - "understand browser chrome features", - "understand browser chrome tips", - "understand browser chrome tips center", - "understand browser new chrome features", - "understand chrome features", - "understand chrome features browser", - "understand chrome features google", - "understand chrome tips", - "understand chrome tips browser", - "understand chrome tips center", - "understand chrome tips center browser", - "understand chrome tips center google", - "understand chrome tips google", - "understand google chrome features", - "understand google chrome tips", - "understand google chrome tips center", - "understand google new chrome features", - "understand new chrome features", - "understand new chrome features browser", - "understand new chrome features google", - "visit browser chrome features", - "visit browser chrome tips", - "visit browser chrome tips center", - "visit browser new chrome features", - "visit chrome features", - "visit chrome features browser", - "visit chrome features google", - "visit chrome tips", - "visit chrome tips browser", - "visit chrome tips center", - "visit chrome tips center browser", - "visit chrome tips center google", - "visit chrome tips google", - "visit google chrome features", - "visit google chrome tips", - "visit google chrome tips center", - "visit google new chrome features", - "visit new chrome features", - "visit new chrome features browser", - "visit new chrome features google", - }, - - // ID#22 - { - // Generated suggestions: - "adjust browser google account", - "adjust chrome google account", - "adjust google account", - "adjust google account browser", - "adjust google account chrome", - "browser adjust google account", - "browser control google account", - "browser fix google account", - "browser google account adjust", - "browser google account control", - "browser google account fix", - "browser google account manage", - "browser manage google account", - "chrome adjust google account", - "chrome control google account", - "chrome fix google account", - "chrome google account adjust", - "chrome google account control", - "chrome google account fix", - "chrome google account manage", - "chrome manage google account", - "control browser google account", - "control chrome google account", - "control google account", - "control google account browser", - "control google account chrome", - "fix browser google account", - "fix chrome google account", - "fix google account", - "fix google account browser", - "fix google account chrome", - "google account adjust", - "google account adjust browser", - "google account adjust chrome", - "google account browser adjust", - "google account browser control", - "google account browser fix", - "google account browser manage", - "google account chrome adjust", - "google account chrome control", - "google account chrome fix", - "google account chrome manage", - "google account control", - "google account control browser", - "google account control chrome", - "google account fix", - "google account fix browser", - "google account fix chrome", - "google account manage", - "google account manage browser", - "google account manage chrome", - "manage browser google account", - "manage chrome google account", - "manage google account", - "manage google account browser", - "manage google account chrome", - }, - - // ID#24 - { - // Generated suggestions: - "browser change gmail account password", - "browser change gmail password", - "browser change google account password", - "browser change google password", - "browser fix gmail account password", - "browser fix gmail password", - "browser fix google account password", - "browser fix google password", - "browser gmail account password change", - "browser gmail account password fix", - "browser gmail account password reset", - "browser gmail account password update", - "browser gmail password change", - "browser gmail password fix", - "browser gmail password reset", - "browser gmail password update", - "browser google account password change", - "browser google account password fix", - "browser google account password reset", - "browser google account password update", - "browser google password change", - "browser google password fix", - "browser google password reset", - "browser google password update", - "browser reset gmail account password", - "browser reset gmail password", - "browser reset google account password", - "browser reset google password", - "browser update gmail account password", - "browser update gmail password", - "browser update google account password", - "browser update google password", - "change browser gmail account password", - "change browser gmail password", - "change browser google account password", - "change browser google password", - "change chrome gmail account password", - "change chrome gmail password", - "change chrome google account password", - "change chrome google password", - "change gmail account password", - "change gmail account password browser", - "change gmail account password chrome", - "change gmail account password google", - "change gmail password", - "change gmail password browser", - "change gmail password chrome", - "change gmail password google", - "change google account password", - "change google account password browser", - "change google account password chrome", - "change google account password google", - "change google gmail account password", - "change google gmail password", - "change google google account password", - "change google google password", - "change google password", - "change google password browser", - "change google password chrome", - "change google password google", - "chrome change gmail account password", - "chrome change gmail password", - "chrome change google account password", - "chrome change google password", - "chrome fix gmail account password", - "chrome fix gmail password", - "chrome fix google account password", - "chrome fix google password", - "chrome gmail account password change", - "chrome gmail account password fix", - "chrome gmail account password reset", - "chrome gmail account password update", - "chrome gmail password change", - "chrome gmail password fix", - "chrome gmail password reset", - "chrome gmail password update", - "chrome google account password change", - "chrome google account password fix", - "chrome google account password reset", - "chrome google account password update", - "chrome google password change", - "chrome google password fix", - "chrome google password reset", - "chrome google password update", - "chrome reset gmail account password", - "chrome reset gmail password", - "chrome reset google account password", - "chrome reset google password", - "chrome update gmail account password", - "chrome update gmail password", - "chrome update google account password", - "chrome update google password", - "fix browser gmail account password", - "fix browser gmail password", - "fix browser google account password", - "fix browser google password", - "fix chrome gmail account password", - "fix chrome gmail password", - "fix chrome google account password", - "fix chrome google password", - "fix gmail account password", - "fix gmail account password browser", - "fix gmail account password chrome", - "fix gmail account password google", - "fix gmail password", - "fix gmail password browser", - "fix gmail password chrome", - "fix gmail password google", - "fix google account password", - "fix google account password browser", - "fix google account password chrome", - "fix google account password google", - "fix google gmail account password", - "fix google gmail password", - "fix google google account password", - "fix google google password", - "fix google password", - "fix google password browser", - "fix google password chrome", - "fix google password google", - "gmail account password browser change", - "gmail account password browser fix", - "gmail account password browser reset", - "gmail account password browser update", - "gmail account password change", - "gmail account password change browser", - "gmail account password change chrome", - "gmail account password change google", - "gmail account password chrome change", - "gmail account password chrome fix", - "gmail account password chrome reset", - "gmail account password chrome update", - "gmail account password fix", - "gmail account password fix browser", - "gmail account password fix chrome", - "gmail account password fix google", - "gmail account password google change", - "gmail account password google fix", - "gmail account password google reset", - "gmail account password google update", - "gmail account password reset", - "gmail account password reset browser", - "gmail account password reset chrome", - "gmail account password reset google", - "gmail account password update", - "gmail account password update browser", - "gmail account password update chrome", - "gmail account password update google", - "gmail password browser change", - "gmail password browser fix", - "gmail password browser reset", - "gmail password browser update", - "gmail password change", - "gmail password change browser", - "gmail password change chrome", - "gmail password change google", - "gmail password chrome change", - "gmail password chrome fix", - "gmail password chrome reset", - "gmail password chrome update", - "gmail password fix", - "gmail password fix browser", - "gmail password fix chrome", - "gmail password fix google", - "gmail password google change", - "gmail password google fix", - "gmail password google reset", - "gmail password google update", - "gmail password reset", - "gmail password reset browser", - "gmail password reset chrome", - "gmail password reset google", - "gmail password update", - "gmail password update browser", - "gmail password update chrome", - "gmail password update google", - "google account password browser change", - "google account password browser fix", - "google account password browser reset", - "google account password browser update", - "google account password change", - "google account password change browser", - "google account password change chrome", - "google account password change google", - "google account password chrome change", - "google account password chrome fix", - "google account password chrome reset", - "google account password chrome update", - "google account password fix", - "google account password fix browser", - "google account password fix chrome", - "google account password fix google", - "google account password google change", - "google account password google fix", - "google account password google reset", - "google account password google update", - "google account password reset", - "google account password reset browser", - "google account password reset chrome", - "google account password reset google", - "google account password update", - "google account password update browser", - "google account password update chrome", - "google account password update google", - "google change gmail account password", - "google change gmail password", - "google change google account password", - "google change google password", - "google fix gmail account password", - "google fix gmail password", - "google fix google account password", - "google fix google password", - "google gmail account password change", - "google gmail account password fix", - "google gmail account password reset", - "google gmail account password update", - "google gmail password change", - "google gmail password fix", - "google gmail password reset", - "google gmail password update", - "google google account password change", - "google google account password fix", - "google google account password reset", - "google google account password update", - "google google password change", - "google google password fix", - "google google password reset", - "google google password update", - "google password browser change", - "google password browser fix", - "google password browser reset", - "google password browser update", - "google password change", - "google password change browser", - "google password change chrome", - "google password change google", - "google password chrome change", - "google password chrome fix", - "google password chrome reset", - "google password chrome update", - "google password fix", - "google password fix browser", - "google password fix chrome", - "google password fix google", - "google password google change", - "google password google fix", - "google password google reset", - "google password google update", - "google password reset", - "google password reset browser", - "google password reset chrome", - "google password reset google", - "google password update", - "google password update browser", - "google password update chrome", - "google password update google", - "google reset gmail account password", - "google reset gmail password", - "google reset google account password", - "google reset google password", - "google update gmail account password", - "google update gmail password", - "google update google account password", - "google update google password", - "reset browser gmail account password", - "reset browser gmail password", - "reset browser google account password", - "reset browser google password", - "reset chrome gmail account password", - "reset chrome gmail password", - "reset chrome google account password", - "reset chrome google password", - "reset gmail account password", - "reset gmail account password browser", - "reset gmail account password chrome", - "reset gmail account password google", - "reset gmail password", - "reset gmail password browser", - "reset gmail password chrome", - "reset gmail password google", - "reset google account password", - "reset google account password browser", - "reset google account password chrome", - "reset google account password google", - "reset google gmail account password", - "reset google gmail password", - "reset google google account password", - "reset google google password", - "reset google password", - "reset google password browser", - "reset google password chrome", - "reset google password google", - "update browser gmail account password", - "update browser gmail password", - "update browser google account password", - "update browser google password", - "update chrome gmail account password", - "update chrome gmail password", - "update chrome google account password", - "update chrome google password", - "update gmail account password", - "update gmail account password browser", - "update gmail account password chrome", - "update gmail account password google", - "update gmail password", - "update gmail password browser", - "update gmail password chrome", - "update gmail password google", - "update google account password", - "update google account password browser", - "update google account password chrome", - "update google account password google", - "update google gmail account password", - "update google gmail password", - "update google google account password", - "update google google password", - "update google password", - "update google password browser", - "update google password chrome", - "update google password google", - }, - - // ID#27 - { - // Generated suggestions: - "chrome dino", - "chrome dino game", - "chrome dino game play", - "chrome dino game run", - "chrome dino play", - "chrome dino play game", - "chrome dino run", - "chrome dino run game", - "chrome dinosaur", - "chrome dinosaur game", - "chrome dinosaur game play", - "chrome dinosaur game run", - "chrome dinosaur play", - "chrome dinosaur play game", - "chrome dinosaur run", - "chrome dinosaur run game", - "chrome game dino", - "chrome game dino play", - "chrome game dino run", - "chrome game dinosaur", - "chrome game dinosaur play", - "chrome game dinosaur run", - "chrome game play dino", - "chrome game play dinosaur", - "chrome game run dino", - "chrome game run dinosaur", - "chrome play dino", - "chrome play dino game", - "chrome play dinosaur", - "chrome play dinosaur game", - "chrome play game dino", - "chrome play game dinosaur", - "chrome run dino", - "chrome run dino game", - "chrome run dinosaur", - "chrome run dinosaur game", - "chrome run game dino", - "chrome run game dinosaur", - "dino chrome", - "dino chrome game", - "dino chrome game play", - "dino chrome game run", - "dino chrome play", - "dino chrome play game", - "dino chrome run", - "dino chrome run game", - "dino game chrome", - "dino game chrome play", - "dino game chrome run", - "dino game google chrome", - "dino game google chrome play", - "dino game google chrome run", - "dino game play chrome", - "dino game play google chrome", - "dino game run chrome", - "dino game run google chrome", - "dino google chrome", - "dino google chrome game", - "dino google chrome game play", - "dino google chrome game run", - "dino google chrome play", - "dino google chrome play game", - "dino google chrome run", - "dino google chrome run game", - "dino play chrome", - "dino play chrome game", - "dino play game chrome", - "dino play game google chrome", - "dino play google chrome", - "dino play google chrome game", - "dino run chrome", - "dino run chrome game", - "dino run game chrome", - "dino run game google chrome", - "dino run google chrome", - "dino run google chrome game", - "dinosaur chrome", - "dinosaur chrome game", - "dinosaur chrome game play", - "dinosaur chrome game run", - "dinosaur chrome play", - "dinosaur chrome play game", - "dinosaur chrome run", - "dinosaur chrome run game", - "dinosaur game chrome", - "dinosaur game chrome play", - "dinosaur game chrome run", - "dinosaur game google chrome", - "dinosaur game google chrome play", - "dinosaur game google chrome run", - "dinosaur game play chrome", - "dinosaur game play google chrome", - "dinosaur game run chrome", - "dinosaur game run google chrome", - "dinosaur google chrome", - "dinosaur google chrome game", - "dinosaur google chrome game play", - "dinosaur google chrome game run", - "dinosaur google chrome play", - "dinosaur google chrome play game", - "dinosaur google chrome run", - "dinosaur google chrome run game", - "dinosaur play chrome", - "dinosaur play chrome game", - "dinosaur play game chrome", - "dinosaur play game google chrome", - "dinosaur play google chrome", - "dinosaur play google chrome game", - "dinosaur run chrome", - "dinosaur run chrome game", - "dinosaur run game chrome", - "dinosaur run game google chrome", - "dinosaur run google chrome", - "dinosaur run google chrome game", - "game chrome dino", - "game chrome dino play", - "game chrome dino run", - "game chrome dinosaur", - "game chrome dinosaur play", - "game chrome dinosaur run", - "game chrome play dino", - "game chrome play dinosaur", - "game chrome run dino", - "game chrome run dinosaur", - "game dino chrome", - "game dino chrome play", - "game dino chrome run", - "game dino google chrome", - "game dino google chrome play", - "game dino google chrome run", - "game dino play chrome", - "game dino play google chrome", - "game dino run chrome", - "game dino run google chrome", - "game dinosaur chrome", - "game dinosaur chrome play", - "game dinosaur chrome run", - "game dinosaur google chrome", - "game dinosaur google chrome play", - "game dinosaur google chrome run", - "game dinosaur play chrome", - "game dinosaur play google chrome", - "game dinosaur run chrome", - "game dinosaur run google chrome", - "game google chrome dino", - "game google chrome dino play", - "game google chrome dino run", - "game google chrome dinosaur", - "game google chrome dinosaur play", - "game google chrome dinosaur run", - "game google chrome play dino", - "game google chrome play dinosaur", - "game google chrome run dino", - "game google chrome run dinosaur", - "game play chrome dino", - "game play chrome dinosaur", - "game play dino chrome", - "game play dino google chrome", - "game play dinosaur chrome", - "game play dinosaur google chrome", - "game play google chrome dino", - "game play google chrome dinosaur", - "game run chrome dino", - "game run chrome dinosaur", - "game run dino chrome", - "game run dino google chrome", - "game run dinosaur chrome", - "game run dinosaur google chrome", - "game run google chrome dino", - "game run google chrome dinosaur", - "google chrome dino", - "google chrome dino game", - "google chrome dino game play", - "google chrome dino game run", - "google chrome dino play", - "google chrome dino play game", - "google chrome dino run", - "google chrome dino run game", - "google chrome dinosaur", - "google chrome dinosaur game", - "google chrome dinosaur game play", - "google chrome dinosaur game run", - "google chrome dinosaur play", - "google chrome dinosaur play game", - "google chrome dinosaur run", - "google chrome dinosaur run game", - "google chrome game dino", - "google chrome game dino play", - "google chrome game dino run", - "google chrome game dinosaur", - "google chrome game dinosaur play", - "google chrome game dinosaur run", - "google chrome game play dino", - "google chrome game play dinosaur", - "google chrome game run dino", - "google chrome game run dinosaur", - "google chrome play dino", - "google chrome play dino game", - "google chrome play dinosaur", - "google chrome play dinosaur game", - "google chrome play game dino", - "google chrome play game dinosaur", - "google chrome run dino", - "google chrome run dino game", - "google chrome run dinosaur", - "google chrome run dinosaur game", - "google chrome run game dino", - "google chrome run game dinosaur", - "play chrome dino", - "play chrome dino game", - "play chrome dinosaur", - "play chrome dinosaur game", - "play chrome game dino", - "play chrome game dinosaur", - "play dino chrome", - "play dino chrome game", - "play dino game chrome", - "play dino game google chrome", - "play dino google chrome", - "play dino google chrome game", - "play dinosaur chrome", - "play dinosaur chrome game", - "play dinosaur game chrome", - "play dinosaur game google chrome", - "play dinosaur google chrome", - "play dinosaur google chrome game", - "play game chrome dino", - "play game chrome dinosaur", - "play game dino chrome", - "play game dino google chrome", - "play game dinosaur chrome", - "play game dinosaur google chrome", - "play game google chrome dino", - "play game google chrome dinosaur", - "play google chrome dino", - "play google chrome dino game", - "play google chrome dinosaur", - "play google chrome dinosaur game", - "play google chrome game dino", - "play google chrome game dinosaur", - "run chrome dino", - "run chrome dino game", - "run chrome dinosaur", - "run chrome dinosaur game", - "run chrome game dino", - "run chrome game dinosaur", - "run dino chrome", - "run dino chrome game", - "run dino game chrome", - "run dino game google chrome", - "run dino google chrome", - "run dino google chrome game", - "run dinosaur chrome", - "run dinosaur chrome game", - "run dinosaur game chrome", - "run dinosaur game google chrome", - "run dinosaur google chrome", - "run dinosaur google chrome game", - "run game chrome dino", - "run game chrome dinosaur", - "run game dino chrome", - "run game dino google chrome", - "run game dinosaur chrome", - "run game dinosaur google chrome", - "run game google chrome dino", - "run game google chrome dinosaur", - "run google chrome dino", - "run google chrome dino game", - "run google chrome dinosaur", - "run google chrome dinosaur game", - "run google chrome game dino", - "run google chrome game dinosaur", - }, - - // End of generated test code - // clang-format on - }; - - // The test code below ensures that each element of the outer vector above, - // |literal_concept_expressions|, fully corresponds to exactly one Pedal - // implementation. For each one, the full list of literal expressions are - // confirmed as concept matches for the Pedal. Finally, we verify that every - // implemented Pedal has been tested using set logic. - MockAutocompleteProviderClient client; - OmniboxPedalProvider provider(client, true); - const auto& pedals = provider.pedals_; - std::unordered_set<const OmniboxPedal*> found_pedals(pedals.size()); - LOG(INFO) << "Pedal count: " << pedals.size(); - for (const auto& pedal_concept : literal_concept_expressions) { - const std::u16string first_trigger = base::ASCIIToUTF16(pedal_concept[0]); - const OmniboxPedal* canonical_pedal = - provider.FindPedalMatch(first_trigger); - EXPECT_NE(canonical_pedal, nullptr) - << "Canonical pedal not found for: " << first_trigger; - const bool is_newly_found = found_pedals.insert(canonical_pedal).second; - EXPECT_TRUE(is_newly_found) - << "Found the same Pedal more than once with: " << first_trigger; - for (const char* literal : pedal_concept) { - const std::u16string expression = base::ASCIIToUTF16(literal); - const auto is_match = [&](const auto& pedal) { - OmniboxPedal::TokenSequence sequence(0); - provider.Tokenize(sequence, expression); - provider.ignore_group_.EraseMatchesIn(sequence, true); - sequence.ResetLinks(); - return pedal.second->IsConceptMatch(sequence); - }; - auto iter = std::find_if(pedals.begin(), pedals.end(), is_match); - EXPECT_NE(iter, pedals.end()) << "Pedal not found for: " << expression; - EXPECT_EQ(iter->second.get(), canonical_pedal) - << "Found wrong Pedal for: " << expression; - std::advance(iter, 1); - iter = std::find_if(iter, pedals.end(), is_match); - EXPECT_EQ(iter, pedals.end()) - << "Found more than one Pedal match for: " << expression; - } - } +TEST_F(OmniboxPedalImplementationsWithoutTranslationConsoleTest, + UnorderedSynonymExpressionsAreConceptMatches) { + TestLiteralConceptExpressions(); }
diff --git a/components/omnibox/browser/actions/omnibox_pedal_provider.h b/components/omnibox/browser/actions/omnibox_pedal_provider.h index a6d755fc..1b0f812 100644 --- a/components/omnibox/browser/actions/omnibox_pedal_provider.h +++ b/components/omnibox/browser/actions/omnibox_pedal_provider.h
@@ -56,10 +56,19 @@ size_t EstimateMemoryUsage() const; protected: + // Befriending this test base class prevents duplication of a long exhaustive + // unit test (specifically the TestLiteralConceptExpressions method). + friend class OmniboxPedalImplementationsTest; FRIEND_TEST_ALL_PREFIXES(OmniboxPedalImplementationsTest, ProviderFiltersPedalUpdateChrome); + FRIEND_TEST_ALL_PREFIXES( + OmniboxPedalImplementationsWithoutTranslationConsoleTest, + ProviderFiltersPedalUpdateChrome); FRIEND_TEST_ALL_PREFIXES(OmniboxPedalImplementationsTest, UnorderedSynonymExpressionsAreConceptMatches); + FRIEND_TEST_ALL_PREFIXES( + OmniboxPedalImplementationsWithoutTranslationConsoleTest, + UnorderedSynonymExpressionsAreConceptMatches); // Generate a token sequence for text using internal dictionary & delimiters. // Outputs empty sequence if any delimited part of text is not in dictionary.
diff --git a/components/omnibox/browser/search_provider.cc b/components/omnibox/browser/search_provider.cc index 3d03370..483c1c87 100644 --- a/components/omnibox/browser/search_provider.cc +++ b/components/omnibox/browser/search_provider.cc
@@ -233,14 +233,17 @@ matches_.clear(); set_field_trial_triggered(false); - // Unless warming up the suggest server on focus, SearchProvider doesn't do - // do anything useful for on-focus inputs or empty inputs. Exit early. - if (!base::FeatureList::IsEnabled(omnibox::kSearchProviderWarmUpOnFocus) && - (input.focus_type() != OmniboxFocusType::DEFAULT || - input.type() == metrics::OmniboxInputType::EMPTY)) { - Stop(true, false); - return; - } + // At this point, we could exit early if the input is on-focus or empty, + // because offering suggestions in those scenarios is handled by + // ZeroSuggestProvider. But we continue here anyway in order to send a request + // to warm up the suggest server. It's possible this warmup request could be + // combined or deduped with the request from ZeroSuggestProvider but that + // provider doesn't always run, based on a variety of factors (sign in state, + // experiments, input type (on-focus vs. on-clobber)). Ensuring that we always + // send a request here allows the suggest server to, for example, load + // per-user models into memory. Having a per-user model in memory allows the + // suggest server to respond more quickly with personalized suggestions as the + // user types. keyword_input_ = input; const TemplateURL* keyword_provider =
diff --git a/components/omnibox/browser/search_provider.h b/components/omnibox/browser/search_provider.h index 026bb31..fc463ff 100644 --- a/components/omnibox/browser/search_provider.h +++ b/components/omnibox/browser/search_provider.h
@@ -102,13 +102,13 @@ FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, AnswersCache); FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, RemoveExtraAnswers); FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, DoesNotProvideOnFocus); + FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, SendsWarmUpRequestOnFocus); FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, DoTrimHttpScheme); FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, DontTrimHttpSchemeIfInputHasScheme); FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, DontTrimHttpsSchemeIfInputHasScheme); FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, DoTrimHttpsScheme); - FRIEND_TEST_ALL_PREFIXES(SearchProviderWarmUpTest, SendsWarmUpRequestOnFocus); // Manages the providers (TemplateURLs) used by SearchProvider. Two providers // may be used:
diff --git a/components/omnibox/common/omnibox_features.cc b/components/omnibox/common/omnibox_features.cc index 6ed9b213..0f80d23 100644 --- a/components/omnibox/common/omnibox_features.cc +++ b/components/omnibox/common/omnibox_features.cc
@@ -60,14 +60,6 @@ const base::Feature kImageSearchSuggestionThumbnail{ "ImageSearchSuggestionThumbnail", enabled_by_default_android_only}; -// Feature to enable the search provider to send a request to the suggest -// server on focus. This allows the suggest server to warm up, by, for -// example, loading per-user models into memory. Having a per-user model -// in memory allows the suggest server to respond more quickly with -// personalized suggestions as the user types. -const base::Feature kSearchProviderWarmUpOnFocus{ - "OmniboxWarmUpSearchProviderOnFocus", enabled_by_default_desktop_android}; - // Feature used to display the title of the current URL match. const base::Feature kDisplayTitleForCurrentUrl{ "OmniboxDisplayTitleForCurrentUrl", base::FEATURE_ENABLED_BY_DEFAULT};
diff --git a/components/omnibox/common/omnibox_features.h b/components/omnibox/common/omnibox_features.h index 57f29ed1..7ab4181 100644 --- a/components/omnibox/common/omnibox_features.h +++ b/components/omnibox/common/omnibox_features.h
@@ -15,7 +15,6 @@ extern const base::Feature kOmniboxTabSwitchSuggestions; extern const base::Feature kExperimentalKeywordMode; extern const base::Feature kImageSearchSuggestionThumbnail; -extern const base::Feature kSearchProviderWarmUpOnFocus; extern const base::Feature kDisplayTitleForCurrentUrl; extern const base::Feature kOmniboxRemoveSuggestionsFromClipboard;
diff --git a/components/page_info/page_info_ui.cc b/components/page_info/page_info_ui.cc index 8be144c..e1438562 100644 --- a/components/page_info/page_info_ui.cc +++ b/components/page_info/page_info_ui.cc
@@ -281,7 +281,7 @@ message_id = IDS_PAGE_INFO_STATE_TEXT_CAMERA_ASK; break; case ContentSettingsType::CAMERA_PAN_TILT_ZOOM: - message_id = IDS_PAGE_INFO_STATE_TEXT_CAMERA_ASK; + message_id = IDS_PAGE_INFO_STATE_TEXT_CAMERA_PAN_TILT_ZOOM_ASK; break; case ContentSettingsType::MEDIASTREAM_MIC: message_id = IDS_PAGE_INFO_STATE_TEXT_MIC_ASK; @@ -652,7 +652,8 @@ if (!auto_blocked_text.empty()) return auto_blocked_text; - if (permission.is_one_time || permission.setting == CONTENT_SETTING_DEFAULT) { + if (permission.is_one_time || permission.setting == CONTENT_SETTING_DEFAULT || + permission.setting == CONTENT_SETTING_ASK) { return PermissionStateToUIString(delegate, permission); }
diff --git a/components/page_info_strings.grdp b/components/page_info_strings.grdp index 8c102569..7e8dedb5 100644 --- a/components/page_info_strings.grdp +++ b/components/page_info_strings.grdp
@@ -512,6 +512,9 @@ <message name="IDS_PAGE_INFO_STATE_TEXT_CAMERA_ASK" desc="The Page Info permission subpage and the main page info page contain a label which shows the state of the site permission. This is the text shown if the camera permission is in the ask state and the site can prompt the user to ask if they allow the site to use their camera."> Can ask to use your camera </message> + <message name="IDS_PAGE_INFO_STATE_TEXT_CAMERA_PAN_TILT_ZOOM_ASK" desc="The Page Info permission subpage and the main page info page contain a label which shows the state of the site permission. This is the text shown if the camera and movement permission is in the ask state and the site can prompt the user to ask if they allow the site to use and move their camera."> + Can ask to use & move your camera + </message> <message name="IDS_PAGE_INFO_STATE_TEXT_CLIPBOARD_ASK" desc="The Page Info permission subpage and the main page info page contain a label which shows the state of the site permission. This is the text shown if the clipboard permission is in the ask state and the site can prompt the user to ask if they allow the site to see text and images on their clipboard."> Can ask to see text and images on your clipboard </message>
diff --git a/components/page_info_strings_grdp/IDS_PAGE_INFO_STATE_TEXT_CAMERA_PAN_TILT_ZOOM_ASK.png.sha1 b/components/page_info_strings_grdp/IDS_PAGE_INFO_STATE_TEXT_CAMERA_PAN_TILT_ZOOM_ASK.png.sha1 new file mode 100644 index 0000000..ccdad65 --- /dev/null +++ b/components/page_info_strings_grdp/IDS_PAGE_INFO_STATE_TEXT_CAMERA_PAN_TILT_ZOOM_ASK.png.sha1
@@ -0,0 +1 @@ +aa2d8c9fcc43a09193ca64f059d00c6dd666da98 \ No newline at end of file
diff --git a/components/password_manager/core/browser/password_store.cc b/components/password_manager/core/browser/password_store.cc index 9900ee7a..5c20d0d 100644 --- a/components/password_manager/core/browser/password_store.cc +++ b/components/password_manager/core/browser/password_store.cc
@@ -177,12 +177,25 @@ const PasswordForm& new_form, const PasswordForm& old_primary_key) { DCHECK(main_task_runner_->RunsTasksInCurrentSequence()); + PasswordForm new_form_with_correct_password_issues = new_form; + // TODO(crbug.com/1223022): Re-evaluate this once all places that call + // UpdateLoginWithPrimaryKey() have properly set the |password_issues| + // field. + if (new_form.username_value != old_primary_key.username_value || + new_form.password_value != old_primary_key.password_value) { + // If the password or the username changes, the password issues aren't valid + // any more. Make sure they are cleared before storing the new form. + new_form_with_correct_password_issues.password_issues = + base::flat_map<InsecureType, InsecurityMetadata>(); + } + OperationHandler* handler = OperationHandler::CreateOperationHandler(); handler->AwaitOperation( base::BindOnce(&PasswordStoreBackend::RemoveLoginAsync, base::Unretained(backend_), old_primary_key)); - handler->AwaitOperation(base::BindOnce(&PasswordStoreBackend::AddLoginAsync, - base::Unretained(backend_), new_form)); + handler->AwaitOperation(base::BindOnce( + &PasswordStoreBackend::AddLoginAsync, base::Unretained(backend_), + new_form_with_correct_password_issues)); handler->InvokeOnCompletion( base::BindOnce(&PasswordStore::NotifyLoginsChangedOnMainSequence, this)); }
diff --git a/components/password_manager/core/browser/password_store_factory_util.cc b/components/password_manager/core/browser/password_store_factory_util.cc index 35c0a8e..afacfc390 100644 --- a/components/password_manager/core/browser/password_store_factory_util.cc +++ b/components/password_manager/core/browser/password_store_factory_util.cc
@@ -112,14 +112,7 @@ } bool ShouldAffiliationBasedMatchingBeActive(syncer::SyncService* sync_service) { - if (base::FeatureList::IsEnabled( - password_manager::features::kUseOfHashAffiliationFetcher)) { - return true; - } - return sync_service && sync_service->IsSyncFeatureActive() && - sync_service->GetUserSettings()->GetSelectedTypes().Has( - syncer::UserSelectableType::kPasswords) && - !sync_service->GetUserSettings()->IsUsingExplicitPassphrase(); + return true; } } // namespace password_manager
diff --git a/components/password_manager/core/browser/password_store_unittest.cc b/components/password_manager/core/browser/password_store_unittest.cc index a47f10ae..21c82bd 100644 --- a/components/password_manager/core/browser/password_store_unittest.cc +++ b/components/password_manager/core/browser/password_store_unittest.cc
@@ -288,6 +288,9 @@ std::unique_ptr<PasswordForm> old_form( FillPasswordFormWithData(kTestCredentials[0])); + old_form->password_issues = { + {InsecureType::kLeaked, + InsecurityMetadata(base::Time(), IsMuted(false))}}; store->AddLogin(*old_form); WaitForPasswordStore(); @@ -296,6 +299,7 @@ std::unique_ptr<PasswordForm> new_form( FillPasswordFormWithData(kTestCredentials[1])); + new_form->password_issues = old_form->password_issues; EXPECT_CALL(mock_observer, OnLoginsChanged(_, testing::SizeIs(2u))); PasswordForm old_primary_key; old_primary_key.signon_realm = old_form->signon_realm; @@ -310,6 +314,9 @@ MockPasswordStoreConsumer mock_consumer; std::vector<std::unique_ptr<PasswordForm>> expected_forms; expected_forms.push_back(std::move(new_form)); + // The expected form should have no password_issues. + expected_forms[0]->password_issues = + base::flat_map<InsecureType, InsecurityMetadata>(); EXPECT_CALL(mock_consumer, OnGetPasswordStoreResultsConstRef( UnorderedPasswordFormElementsAre(&expected_forms)));
diff --git a/components/password_manager/core/browser/site_affiliation/affiliation_fetcher_factory_impl.cc b/components/password_manager/core/browser/site_affiliation/affiliation_fetcher_factory_impl.cc index fcaff30c..efd836f 100644 --- a/components/password_manager/core/browser/site_affiliation/affiliation_fetcher_factory_impl.cc +++ b/components/password_manager/core/browser/site_affiliation/affiliation_fetcher_factory_impl.cc
@@ -18,13 +18,8 @@ AffiliationFetcherFactoryImpl::CreateInstance( scoped_refptr<network::SharedURLLoaderFactory> url_loader_factory, AffiliationFetcherDelegate* delegate) { - if (base::FeatureList::IsEnabled( - password_manager::features::kUseOfHashAffiliationFetcher)) { - return std::make_unique<HashAffiliationFetcher>( - std::move(url_loader_factory), delegate); - } - return std::make_unique<AffiliationFetcher>(std::move(url_loader_factory), - delegate); + return std::make_unique<HashAffiliationFetcher>(std::move(url_loader_factory), + delegate); } } // namespace password_manager
diff --git a/components/password_manager/core/browser/site_affiliation/affiliation_fetcher_factory_impl_unittest.cc b/components/password_manager/core/browser/site_affiliation/affiliation_fetcher_factory_impl_unittest.cc index 44e3625..a8f6288 100644 --- a/components/password_manager/core/browser/site_affiliation/affiliation_fetcher_factory_impl_unittest.cc +++ b/components/password_manager/core/browser/site_affiliation/affiliation_fetcher_factory_impl_unittest.cc
@@ -6,12 +6,10 @@ #include "base/test/bind.h" #include "base/test/gmock_move_support.h" -#include "base/test/scoped_feature_list.h" #include "base/test/task_environment.h" #include "components/password_manager/core/browser/android_affiliation/affiliation_fetcher.h" #include "components/password_manager/core/browser/android_affiliation/affiliation_fetcher_interface.h" #include "components/password_manager/core/browser/android_affiliation/mock_affiliation_fetcher_delegate.h" -#include "components/password_manager/core/common/password_manager_features.h" #include "components/variations/scoped_variations_ids_provider.h" #include "services/network/public/cpp/weak_wrapper_shared_url_loader_factory.h" #include "services/network/test/test_url_loader_factory.h" @@ -37,18 +35,7 @@ const GURL& url() const { return url_; } - void EnableHashAffiliationService() { - feature_list_.InitAndEnableFeature( - password_manager::features::kUseOfHashAffiliationFetcher); - } - - void DisableHashAffiliationService() { - feature_list_.InitAndDisableFeature( - password_manager::features::kUseOfHashAffiliationFetcher); - } - private: - base::test::ScopedFeatureList feature_list_; base::test::TaskEnvironment task_env_; variations::ScopedVariationsIdsProvider scoped_variations_ids_provider_{ variations::VariationsIdsProvider::Mode::kUseSignedInState}; @@ -60,14 +47,7 @@ GURL url_; }; -TEST_F(AffiliationFetcherFactoryImplTest, NormalAffiliationFetcher) { - DisableHashAffiliationService(); - CreateAndStartFetcher(); - EXPECT_TRUE(base::EndsWith(url().path_piece(), "lookup")); -} - TEST_F(AffiliationFetcherFactoryImplTest, HashAffiliationFetcher) { - EnableHashAffiliationService(); CreateAndStartFetcher(); EXPECT_TRUE(base::EndsWith(url().path_piece(), "lookupByHashPrefix")); }
diff --git a/components/password_manager/core/browser/ui/saved_passwords_presenter_unittest.cc b/components/password_manager/core/browser/ui/saved_passwords_presenter_unittest.cc index 25d9ee5..165191bc 100644 --- a/components/password_manager/core/browser/ui/saved_passwords_presenter_unittest.cc +++ b/components/password_manager/core/browser/ui/saved_passwords_presenter_unittest.cc
@@ -180,6 +180,11 @@ base::HistogramTester histogram_tester; EXPECT_CALL(observer, OnEdited(updated_username)); + // TODO(crbug.com/1223022): Once all places that operate changes on forms + // properly set |password_issues|, setting them to an empty map should be part + // of the default constructor. + updated_username.password_issues = + base::flat_map<InsecureType, InsecurityMetadata>(); EXPECT_CALL(observer, OnSavedPasswordsChanged(ElementsAre(updated_username))); EXPECT_TRUE( presenter().EditSavedPasswords(forms, new_username, form.password_value)); @@ -260,6 +265,11 @@ base::HistogramTester histogram_tester; // Verify that editing username and password triggers the right notifications. EXPECT_CALL(observer, OnEdited(updated_both)); + // TODO(crbug.com/1223022): Once all places that operate changes on forms + // properly set |password_issues|, setting them to an empty map should be part + // of the default constructor. + updated_both.password_issues = + base::flat_map<InsecureType, InsecurityMetadata>(); EXPECT_CALL(observer, OnSavedPasswordsChanged(ElementsAre(updated_both))); EXPECT_TRUE( presenter().EditSavedPasswords(forms, new_username, new_password)); @@ -530,6 +540,11 @@ forms_to_edit, new_username, profile_store_form.password_value)); RunUntilIdle(); profile_store_form.username_value = new_username; + // TODO(crbug.com/1223022): Once all places that operate changes on forms + // properly set |password_issues|, setting them to an empty map should be + // part of the default constructor. + profile_store_form.password_issues = + base::flat_map<InsecureType, InsecurityMetadata>(); EXPECT_THAT(profile_store().stored_passwords(), ElementsAre(Pair(profile_store_form.signon_realm, ElementsAre(profile_store_form)))); @@ -794,6 +809,14 @@ PasswordForm expected_account_store_form = expected_profile_store_form; expected_account_store_form.in_store = PasswordForm::Store::kAccountStore; + // TODO(crbug.com/1223022): Once all places that operate changes on forms + // via properly set |password_issues|, setting them to an empty + // map should be part of the default constructor. + expected_profile_store_form.password_issues = + base::flat_map<InsecureType, InsecurityMetadata>(); + expected_account_store_form.password_issues = + base::flat_map<InsecureType, InsecurityMetadata>(); + EXPECT_THAT(profile_store().stored_passwords(), ElementsAre(Pair(profile_store_form.signon_realm, ElementsAre(expected_profile_store_form))));
diff --git a/components/password_manager/core/common/password_manager_features.cc b/components/password_manager/core/common/password_manager_features.cc index c282692..305600a 100644 --- a/components/password_manager/core/common/password_manager_features.cc +++ b/components/password_manager/core/common/password_manager_features.cc
@@ -161,10 +161,6 @@ "UseNewHeaderForSavePasswordWithAccountStoreBubble", base::FEATURE_ENABLED_BY_DEFAULT}; -// Enables use of Hash Affiliation fetcher for all requests. -const base::Feature kUseOfHashAffiliationFetcher = { - "UseOfHashAffiliationFetcher", base::FEATURE_ENABLED_BY_DEFAULT}; - // Enables support of sending votes on username first flow. const base::Feature kUsernameFirstFlow = {"UsernameFirstFlow", base::FEATURE_DISABLED_BY_DEFAULT};
diff --git a/components/password_manager/core/common/password_manager_features.h b/components/password_manager/core/common/password_manager_features.h index c9a57983..48a3f6e0 100644 --- a/components/password_manager/core/common/password_manager_features.h +++ b/components/password_manager/core/common/password_manager_features.h
@@ -43,7 +43,6 @@ extern const base::Feature kUnifiedPasswordManagerAndroid; extern const base::Feature kUseNewHeaderForLegacySavePasswordBubble; extern const base::Feature kUseNewHeaderForSavePasswordWithAccountStoreBubble; -extern const base::Feature kUseOfHashAffiliationFetcher; extern const base::Feature kUsernameFirstFlow; extern const base::Feature kUsernameFirstFlowFilling;
diff --git a/components/permissions/features.cc b/components/permissions/features.cc index 05ff442..47bbb07 100644 --- a/components/permissions/features.cc +++ b/components/permissions/features.cc
@@ -55,6 +55,12 @@ const base::Feature kPermissionChipRequestTypeSensitive{ "PermissionChipRequestTypeSensitive", base::FEATURE_DISABLED_BY_DEFAULT}; +// When kPermissionChip (above) is enabled, controls whether or not the +// permission chip should be shown in the prominent style (white on blue) or in +// the secondary style (blue on white). +const base::Feature kPermissionChipIsProminentStyle{ + "PermissionChipIsProminentStyle", base::FEATURE_DISABLED_BY_DEFAULT}; + // When enabled, use the value of the `service_url` FeatureParam as the url // for the Web Permission Predictions Service. const base::Feature kPermissionPredictionServiceUseUrlOverride{
diff --git a/components/permissions/features.h b/components/permissions/features.h index 81feb02b..53a5b10 100644 --- a/components/permissions/features.h +++ b/components/permissions/features.h
@@ -43,6 +43,9 @@ extern const base::Feature kPermissionChipRequestTypeSensitive; COMPONENT_EXPORT(PERMISSIONS_COMMON) +extern const base::Feature kPermissionChipIsProminentStyle; + +COMPONENT_EXPORT(PERMISSIONS_COMMON) extern const base::Feature kPermissionPredictionServiceUseUrlOverride; COMPONENT_EXPORT(PERMISSIONS_COMMON)
diff --git a/components/policy/resources/policy_templates.json b/components/policy/resources/policy_templates.json index 787139e..cb60549 100644 --- a/components/policy/resources/policy_templates.json +++ b/components/policy/resources/policy_templates.json
@@ -17441,7 +17441,7 @@ }, { 'name': 'PhoneHubAllowed', - 'owners': ['khorimoto@google.com', 'vecore@chromium.org', 'better-together-dev@google.com'], + 'owners': ['khorimoto@google.com', 'danlee@google.com', 'better-together-dev@google.com'], 'type': 'main', 'schema': { 'type': 'boolean' }, 'supported_on': ['chrome_os:89-'], @@ -17462,7 +17462,7 @@ }, { 'name': 'PhoneHubNotificationsAllowed', - 'owners': ['khorimoto@google.com', 'vecore@chromium.org', 'better-together-dev@google.com'], + 'owners': ['khorimoto@google.com', 'danlee@google.com', 'better-together-dev@google.com'], 'type': 'main', 'schema': { 'type': 'boolean' }, 'supported_on': ['chrome_os:89-'], @@ -17482,7 +17482,7 @@ }, { 'name': 'PhoneHubTaskContinuationAllowed', - 'owners': ['khorimoto@google.com', 'vecore@chromium.org', 'better-together-dev@google.com'], + 'owners': ['khorimoto@google.com', 'danlee@google.com', 'better-together-dev@google.com'], 'type': 'main', 'schema': { 'type': 'boolean' }, 'supported_on': ['chrome_os:89-'], @@ -17502,7 +17502,7 @@ }, { 'name': 'NearbyShareAllowed', - 'owners': ['vecore@google.com', 'hansberry@chromium.org', 'better-together-dev@google.com'], + 'owners': ['danlee@google.com', 'hansberry@chromium.org', 'better-together-dev@google.com'], 'type': 'main', 'schema': { 'type': 'boolean' }, 'supported_on': ['chrome_os:91-'],
diff --git a/components/policy/tools/template_writers/writers/adml_writer.py b/components/policy/tools/template_writers/writers/adml_writer.py index e40dcb1..6f7233a 100755 --- a/components/policy/tools/template_writers/writers/adml_writer.py +++ b/components/policy/tools/template_writers/writers/adml_writer.py
@@ -263,5 +263,4 @@ # (gpedit.msc) because it interprets whitespace characters in text between # the "string" tags. This prevents gpedit.msc from displaying the category # names correctly. - # TODO(markusheintz): Find a better formatting that works with gpedit. return self._doc.toxml()
diff --git a/components/query_tiles/internal/tile_manager.cc b/components/query_tiles/internal/tile_manager.cc index 46a5f45..b0c180e 100644 --- a/components/query_tiles/internal/tile_manager.cc +++ b/components/query_tiles/internal/tile_manager.cc
@@ -191,7 +191,8 @@ loaded_groups.erase(kTileStatsGroup); if (tile_group_) { SortTilesAndClearUnusedStats(&tile_group_->tiles, - &tile_stats_group_->tile_stats); + &tile_stats_group_->tile_stats, + TileShuffler()); } } trending_tile_handler_.Reset();
diff --git a/components/query_tiles/internal/tile_utils.cc b/components/query_tiles/internal/tile_utils.cc index 7e95266..aa1e13fe 100644 --- a/components/query_tiles/internal/tile_utils.cc +++ b/components/query_tiles/internal/tile_utils.cc
@@ -2,13 +2,14 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include "components/query_tiles/internal/tile_utils.h" + #include <algorithm> #include <limits> #include "base/rand_util.h" #include "base/strings/string_util.h" #include "components/query_tiles/internal/tile_config.h" -#include "components/query_tiles/internal/tile_utils.h" namespace query_tiles { namespace { @@ -25,28 +26,22 @@ std::map<std::string, double>* tile_score_map; }; -// Shuffle unclicked tiles from index starting with |GetTileShufflePosition()|, -// so that they have a chance to be displayed. Trending tiles are excluded. -void ShuffleUnclickedTiles(std::vector<std::unique_ptr<Tile>>* tiles, - std::map<std::string, double>* tile_score_map) { +// Shuffle tiles from index starting with |GetTileShufflePosition()|, +// so that they have a chance to be displayed. +void ShuffleTiles(std::vector<std::unique_ptr<Tile>>* tiles, + std::map<std::string, double>* tile_score_map, + const TileShuffler& shuffler) { size_t starting_index = TileConfig::GetTileShufflePosition(); - if (tiles->empty() || tiles->size() <= starting_index + 1) + if (tiles->size() <= starting_index + 1) return; - auto iter = --tiles->end(); - while (iter >= tiles->begin() + starting_index) { - const std::string& id = iter->get()->id; - if ((*tile_score_map)[id] > 0 || IsTrendingTile(id)) - break; - --iter; - } - if (iter + 1 != tiles->end()) - base::RandomShuffle(iter + 1, tiles->end()); + shuffler.Shuffle(tiles, starting_index); } void SortTiles(std::vector<std::unique_ptr<Tile>>* tiles, std::map<std::string, TileStats>* tile_stats, - std::map<std::string, double>* score_map) { + std::map<std::string, double>* score_map, + const TileShuffler& shuffler) { if (!tiles || tiles->empty()) return; @@ -108,21 +103,26 @@ // Randomly shuffle tiles that are never clicked so they get a chance // to show up on the display. - ShuffleUnclickedTiles(tiles, score_map); + ShuffleTiles(tiles, score_map, shuffler); for (auto& tile : *tiles) - SortTiles(&tile->sub_tiles, tile_stats, score_map); + SortTiles(&tile->sub_tiles, tile_stats, score_map, shuffler); } } // namespace -void SortTilesAndClearUnusedStats( - std::vector<std::unique_ptr<Tile>>* tiles, - std::map<std::string, TileStats>* tile_stats) { +void TileShuffler::Shuffle(std::vector<std::unique_ptr<Tile>>* tiles, + int start) const { + base::RandomShuffle(tiles->begin() + start, tiles->end()); +} + +void SortTilesAndClearUnusedStats(std::vector<std::unique_ptr<Tile>>* tiles, + std::map<std::string, TileStats>* tile_stats, + const TileShuffler& shuffler) { if (!tiles || tiles->empty()) return; std::map<std::string, double> score_map; - SortTiles(tiles, tile_stats, &score_map); + SortTiles(tiles, tile_stats, &score_map, shuffler); auto iter = tile_stats->begin(); while (iter != tile_stats->end()) { if (score_map.find(iter->first) == score_map.end()) {
diff --git a/components/query_tiles/internal/tile_utils.h b/components/query_tiles/internal/tile_utils.h index 0a7a141..feea6e6 100644 --- a/components/query_tiles/internal/tile_utils.h +++ b/components/query_tiles/internal/tile_utils.h
@@ -13,6 +13,17 @@ namespace query_tiles { +// Helper class to shuffle a vector of tiles beginning at the |start| position. +class TileShuffler { + public: + TileShuffler() = default; + TileShuffler(const TileShuffler& other) = delete; + TileShuffler& operator=(const TileShuffler& other) = delete; + + virtual void Shuffle(std::vector<std::unique_ptr<Tile>>* tiles, + int start) const; +}; + // Function to sort a vector of tiles based on their score in |tile_stats|. If // a tile ID doesn't exists in |tile_stats|, a new entry will be created and // a score will be calculated. If a tile ID in |tile_stats| doesn't show up in @@ -31,8 +42,11 @@ // will result in (0.5, 0.5, 0.7, 0). And for new tiles at the front, they are // guaranteed a minimum score. So that if all the other tiles haven't been // clicked for a while, it will have a chance to be placed at the front. +// After sorting, tiles from position |TileConfig::GetTileShufflePosition()| +// are randomly shuffled so that low score tiles has a chance to be seen. void SortTilesAndClearUnusedStats(std::vector<std::unique_ptr<Tile>>* tiles, - std::map<std::string, TileStats>* tile_stats); + std::map<std::string, TileStats>* tile_stats, + const TileShuffler& shuffler); // Calculates the current tile score based on |current_time|. Tile score will // decay over time.
diff --git a/components/query_tiles/internal/tile_utils_unittest.cc b/components/query_tiles/internal/tile_utils_unittest.cc index 7b7042fe..2aa2df2 100644 --- a/components/query_tiles/internal/tile_utils_unittest.cc +++ b/components/query_tiles/internal/tile_utils_unittest.cc
@@ -14,6 +14,15 @@ namespace query_tiles { namespace { +// Class to reverse shuffle a list of tiles, starting at a given position. +class ReverseTileShuffler : public TileShuffler { + public: + void Shuffle(std::vector<std::unique_ptr<Tile>>* tiles, + int start) const override { + std::reverse(tiles->begin() + start, tiles->end()); + } +}; + // Tests that nothing happens when sorting an empty TileGroup. TEST(TileUtilsTest, SortEmptyTileGroup) { TileGroup group; @@ -21,7 +30,8 @@ tile_stats["guid-1-3"] = TileStats(group.last_updated_ts, 0.7); tile_stats["guid-1-4"] = TileStats(group.last_updated_ts, 0.4); - SortTilesAndClearUnusedStats(&group.tiles, &tile_stats); + SortTilesAndClearUnusedStats(&group.tiles, &tile_stats, + ReverseTileShuffler()); EXPECT_EQ(tile_stats["guid-1-3"].score, 0.7); EXPECT_EQ(tile_stats["guid-1-4"].score, 0.4); } @@ -30,7 +40,8 @@ TileGroup group; test::ResetTestGroup(&group); - SortTilesAndClearUnusedStats(&group.tiles, &group.tile_stats); + SortTilesAndClearUnusedStats(&group.tiles, &group.tile_stats, + ReverseTileShuffler()); EXPECT_EQ(group.tiles[0]->id, "guid-1-3"); EXPECT_EQ(group.tiles[1]->id, "guid-1-1"); EXPECT_EQ(group.tiles[2]->id, "guid-1-2"); @@ -46,7 +57,8 @@ std::map<std::string, TileStats> tile_stats; - SortTilesAndClearUnusedStats(&group.tiles, &tile_stats); + SortTilesAndClearUnusedStats(&group.tiles, &tile_stats, + ReverseTileShuffler()); EXPECT_EQ(group.tiles[0]->id, "guid-1-1"); EXPECT_EQ(group.tiles[1]->id, "guid-1-2"); EXPECT_EQ(group.tiles[2]->id, "guid-1-3"); @@ -66,16 +78,39 @@ std::map<std::string, TileStats> tile_stats; // First tile should be in place. - SortTilesAndClearUnusedStats(&group.tiles, &tile_stats); + SortTilesAndClearUnusedStats(&group.tiles, &tile_stats, + ReverseTileShuffler()); EXPECT_EQ(group.tiles[0]->id, "guid-1-1"); - - EXPECT_TRUE( - (group.tiles[1]->id == "guid-1-2" && group.tiles[2]->id == "guid-1-3") || - (group.tiles[1]->id == "guid-1-3" && group.tiles[2]->id == "guid-1-2")); + EXPECT_EQ(group.tiles[1]->id, "guid-1-3"); + EXPECT_EQ(group.tiles[2]->id, "guid-1-2"); EXPECT_EQ(group.tiles[0]->sub_tiles[0]->id, "guid-2-1"); EXPECT_EQ(group.tiles[0]->sub_tiles[1]->id, "guid-2-2"); } +TEST(TileUtilsTest, SortWithTrendingTilesAndShuffle) { + base::test::ScopedFeatureList feature_list; + TileGroup group; + test::ResetTestGroup(&group); + std::vector<std::unique_ptr<Tile>> trending = test::GetTestTrendingTileList(); + // Insert trending tiles after the first tile. + group.tiles.insert(group.tiles.begin() + 1, + std::make_move_iterator(trending.begin()), + std::make_move_iterator(trending.end())); + std::map<std::string, TileStats> tile_stats; + + // First two tile should be in place. + SortTilesAndClearUnusedStats(&group.tiles, &tile_stats, + ReverseTileShuffler()); + EXPECT_EQ(group.tiles[0]->id, "guid-1-1"); + EXPECT_EQ(group.tiles[1]->id, "trending_1"); + + // Remaining tiles are reversed. + EXPECT_EQ(group.tiles[2]->id, "guid-1-3"); + EXPECT_EQ(group.tiles[3]->id, "guid-1-2"); + EXPECT_EQ(group.tiles[4]->id, "trending_3"); + EXPECT_EQ(group.tiles[5]->id, "trending_2"); +} + // If new tiles are at the front, tile ordering should be kept after // sort. TEST(TileUtilsTest, SortWithNewTilesAtTheFront) { @@ -87,7 +122,8 @@ tile_stats["guid-1-4"] = TileStats(group.last_updated_ts, 0.4); tile_stats["guid-2-2"] = TileStats(group.last_updated_ts, 0.6); - SortTilesAndClearUnusedStats(&group.tiles, &tile_stats); + SortTilesAndClearUnusedStats(&group.tiles, &tile_stats, + ReverseTileShuffler()); EXPECT_EQ(group.tiles[0]->id, "guid-1-1"); EXPECT_EQ(group.tiles[1]->id, "guid-1-2"); EXPECT_EQ(group.tiles[2]->id, "guid-1-3"); @@ -113,7 +149,8 @@ tile_stats["guid-1-2"] = TileStats(group.last_updated_ts, 0.2); tile_stats["guid-2-1"] = TileStats(group.last_updated_ts, 0.3); - SortTilesAndClearUnusedStats(&group.tiles, &tile_stats); + SortTilesAndClearUnusedStats(&group.tiles, &tile_stats, + ReverseTileShuffler()); EXPECT_EQ(group.tiles[0]->id, "guid-1-1"); EXPECT_EQ(group.tiles[1]->id, "guid-1-2"); EXPECT_EQ(group.tiles[2]->id, "guid-1-3"); @@ -132,7 +169,8 @@ tile_stats["guid-1-1"] = TileStats(group.last_updated_ts, 0.5); tile_stats["guid-1-3"] = TileStats(group.last_updated_ts, 0.7); - SortTilesAndClearUnusedStats(&group.tiles, &tile_stats); + SortTilesAndClearUnusedStats(&group.tiles, &tile_stats, + ReverseTileShuffler()); EXPECT_EQ(group.tiles[0]->id, "guid-1-3"); EXPECT_EQ(group.tiles[1]->id, "guid-1-1"); EXPECT_EQ(group.tiles[2]->id, "guid-1-2"); @@ -153,7 +191,8 @@ tile_stats["guid-2-1"] = TileStats(past_time, 0.3); tile_stats["guid-2-2"] = TileStats(group.last_updated_ts, 0.3); - SortTilesAndClearUnusedStats(&group.tiles, &tile_stats); + SortTilesAndClearUnusedStats(&group.tiles, &tile_stats, + ReverseTileShuffler()); EXPECT_EQ(group.tiles[0]->id, "guid-1-1"); EXPECT_EQ(group.tiles[1]->id, "guid-1-3"); EXPECT_EQ(group.tiles[2]->id, "guid-1-2"); @@ -173,7 +212,8 @@ // Stats for a tile that is no longer used. tile_stats[unsed_tile_id] = TileStats(group.last_updated_ts, 0.1); - SortTilesAndClearUnusedStats(&group.tiles, &tile_stats); + SortTilesAndClearUnusedStats(&group.tiles, &tile_stats, + ReverseTileShuffler()); EXPECT_EQ(group.tiles[0]->id, "guid-1-3"); EXPECT_EQ(group.tiles[1]->id, "guid-1-1"); EXPECT_EQ(group.tiles[2]->id, "guid-1-2");
diff --git a/components/quirks/BUILD.gn b/components/quirks/BUILD.gn index 36587f8..7a841c2 100644 --- a/components/quirks/BUILD.gn +++ b/components/quirks/BUILD.gn
@@ -20,6 +20,7 @@ "//components/prefs", "//components/version_info", "//services/network/public/cpp", + "//services/network/public/mojom", "//url", ] }
diff --git a/components/quirks/DEPS b/components/quirks/DEPS index 7f14ac6..4ceb8cf 100644 --- a/components/quirks/DEPS +++ b/components/quirks/DEPS
@@ -5,4 +5,5 @@ "+net/http", "+net/traffic_annotation", "+services/network/public/cpp", + "+services/network/public/mojom", ]
diff --git a/components/quirks/quirks_client.cc b/components/quirks/quirks_client.cc index f2282c0b6..b039e93 100644 --- a/components/quirks/quirks_client.cc +++ b/components/quirks/quirks_client.cc
@@ -18,6 +18,7 @@ #include "net/http/http_status_code.h" #include "services/network/public/cpp/resource_request.h" #include "services/network/public/cpp/simple_url_loader.h" +#include "services/network/public/mojom/url_response_head.mojom.h" namespace quirks {
diff --git a/components/segmentation_platform/internal/database/database_maintenance_impl_unittest.cc b/components/segmentation_platform/internal/database/database_maintenance_impl_unittest.cc index bea2a26..45ba1a05 100644 --- a/components/segmentation_platform/internal/database/database_maintenance_impl_unittest.cc +++ b/components/segmentation_platform/internal/database/database_maintenance_impl_unittest.cc
@@ -186,8 +186,8 @@ // Verify that for each of the signal data, we get a compaction request for // each day within the correct range. for (auto& sd : signal_datas) { - for (uint64_t days_ago = kEarliestCompactionDaysAgo; - days_ago <= kLatestCompactionDaysAgo; ++days_ago) { + for (uint64_t days_ago = kLatestCompactionDaysAgo; + days_ago <= kEarliestCompactionDaysAgo; ++days_ago) { EXPECT_CALL(*signal_database_, CompactSamplesForDay( sd.signal_type, sd.name_hash,
diff --git a/components/spellcheck/browser/BUILD.gn b/components/spellcheck/browser/BUILD.gn index 1e00fa0..63acbd08 100644 --- a/components/spellcheck/browser/BUILD.gn +++ b/components/spellcheck/browser/BUILD.gn
@@ -49,6 +49,7 @@ "//google_apis", "//net", "//services/network/public/cpp", + "//services/network/public/mojom", ] if (is_mac) {
diff --git a/components/spellcheck/browser/DEPS b/components/spellcheck/browser/DEPS index 8ce8e280..0abd6cf8 100644 --- a/components/spellcheck/browser/DEPS +++ b/components/spellcheck/browser/DEPS
@@ -9,5 +9,6 @@ "+mojo/public/cpp/bindings", "+net", "+services/network/public/cpp", + "+services/network/public/mojom", "+services/network/test", ]
diff --git a/components/spellcheck/browser/spelling_service_client.cc b/components/spellcheck/browser/spelling_service_client.cc index ecebc3fd..a8a62757 100644 --- a/components/spellcheck/browser/spelling_service_client.cc +++ b/components/spellcheck/browser/spelling_service_client.cc
@@ -32,6 +32,7 @@ #include "services/network/public/cpp/resource_request.h" #include "services/network/public/cpp/shared_url_loader_factory.h" #include "services/network/public/cpp/simple_url_loader.h" +#include "services/network/public/mojom/url_response_head.mojom.h" #include "url/gurl.h" namespace {
diff --git a/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc b/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc index 9153fce..e3846a5 100644 --- a/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc +++ b/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc
@@ -41,6 +41,7 @@ #include "content/public/browser/navigation_handle.h" #include "content/public/browser/navigation_throttle.h" #include "content/public/browser/web_contents.h" +#include "content/public/test/back_forward_cache_util.h" #include "content/public/test/mock_render_process_host.h" #include "content/public/test/navigation_simulator.h" #include "content/public/test/test_renderer_host.h" @@ -725,6 +726,12 @@ TEST_P(ContentSubresourceFilterThrottleManagerTest, SameSiteNavigation_RulesetGoesAway) { + // The test assumes the previous page gets deleted after navigation and + // ManagerHasRulesetHandle() will return false. Disable back/forward cache to + // ensure that it doesn't get preserved in the cache. + DisableBackForwardCacheForTesting( + RenderViewHostTestHarness::web_contents(), + content::BackForwardCache::TEST_ASSUMES_NO_CACHING); // This test assumes that we're not in DryRun mode. base::test::ScopedFeatureList scoped_feature; scoped_feature.InitAndDisableFeature(kAdTagging); @@ -799,7 +806,6 @@ CreateTestNavigation(same_site_inactive_url, main_rfh()); SimulateFailedNavigation(navigation_simulator(), net::ERR_FAILED); - EXPECT_FALSE(ManagerHasRulesetHandle()); ExpectActivationSignalForFrame(main_rfh(), false /* expect_activation */); CreateSubframeWithTestNavigation(
diff --git a/components/sync/driver/sync_service_crypto.cc b/components/sync/driver/sync_service_crypto.cc index 019ec0fa..2e13322 100644 --- a/components/sync/driver/sync_service_crypto.cc +++ b/components/sync/driver/sync_service_crypto.cc
@@ -718,6 +718,11 @@ } void SyncServiceCrypto::RefreshIsRecoverabilityDegraded() { + if (state_.cached_passphrase_type != + PassphraseType::kTrustedVaultPassphrase) { + return; + } + switch (state_.required_user_action) { case RequiredUserAction::kUnknownDuringInitialization: case RequiredUserAction::kFetchingTrustedVaultKeys:
diff --git a/components/sync/driver/sync_service_crypto_unittest.cc b/components/sync/driver/sync_service_crypto_unittest.cc index 0e3aa2c97..6179470 100644 --- a/components/sync/driver/sync_service_crypto_unittest.cc +++ b/components/sync/driver/sync_service_crypto_unittest.cc
@@ -795,6 +795,26 @@ } TEST_F(SyncServiceCryptoTest, + ShouldNotGetRecoverabilityIfKeystorePassphraseUsed) { + base::test::ScopedFeatureList override_features; + override_features.InitAndEnableFeature( + switches::kSyncTrustedVaultPassphraseRecovery); + + trusted_vault_client_.SetIsRecoverabilityDegraded(true); + crypto_.OnPassphraseTypeChanged(PassphraseType::kKeystorePassphrase, + base::Time::Now()); + crypto_.SetSyncEngine(CoreAccountInfo(), &engine_); + ASSERT_THAT(crypto_.GetPassphraseType(), + Eq(PassphraseType::kKeystorePassphrase)); + ASSERT_TRUE(crypto_.IsTrustedVaultKeyRequiredStateKnown()); + ASSERT_FALSE(crypto_.IsTrustedVaultKeyRequired()); + + EXPECT_THAT(trusted_vault_client_.get_is_recoverablity_degraded_call_count(), + Eq(0)); + EXPECT_FALSE(crypto_.IsTrustedVaultRecoverabilityDegraded()); +} + +TEST_F(SyncServiceCryptoTest, ShouldNotReportDegradedRecoverabilityUponInitialization) { base::test::ScopedFeatureList override_features; override_features.InitAndEnableFeature(
diff --git a/components/sync/driver/sync_service_impl.cc b/components/sync/driver/sync_service_impl.cc index a7d8b3c52..b73821a 100644 --- a/components/sync/driver/sync_service_impl.cc +++ b/components/sync/driver/sync_service_impl.cc
@@ -40,6 +40,7 @@ #include "components/sync/engine/engine_components_factory_impl.h" #include "components/sync/engine/net/http_bridge.h" #include "components/sync/engine/net/http_post_provider_factory.h" +#include "components/sync/engine/shutdown_reason.h" #include "components/sync/engine/sync_encryption_handler.h" #include "components/sync/invalidations/switches.h" #include "components/sync/invalidations/sync_invalidations_service.h" @@ -237,7 +238,7 @@ if (HasDisableReason(DISABLE_REASON_ENTERPRISE_POLICY) || (HasDisableReason(DISABLE_REASON_NOT_SIGNED_IN) && auth_manager_->IsActiveAccountInfoFullyLoaded())) { - StopImpl(CLEAR_DATA); + StopAndClearImpl(); } // Note: We need to record the initial state *after* calling @@ -351,7 +352,7 @@ if (!IsSignedIn()) { // The account was signed out, so shut down. sync_disabled_by_admin_ = false; - StopImpl(CLEAR_DATA); + StopAndClearImpl(); DCHECK(!engine_); } else { // Either a new account was signed in, or the existing account's @@ -382,14 +383,14 @@ // then shut down. This happens when the user signs out on the web, i.e. we're // in the "Sync paused" state. if (!IsEngineAllowedToRun()) { - // If the engine currently exists, then StopImpl() will notify observers + // If the engine currently exists, then ShutdownImpl() will notify observers // anyway. Otherwise, notify them here. (One relevant case is when entering // the PAUSED state before the engine was created, e.g. during deferred // startup.) if (!engine_) { NotifyObservers(); } - StopImpl(KEEP_DATA); + ShutdownImpl(ShutdownReason::STOP_SYNC); return; } @@ -513,7 +514,7 @@ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_); NotifyShutdown(); - ShutdownImpl(BROWSER_SHUTDOWN); + ShutdownImpl(ShutdownReason::BROWSER_SHUTDOWN); DCHECK(!data_type_manager_); data_type_controllers_.clear(); @@ -590,30 +591,23 @@ NotifyObservers(); } -void SyncServiceImpl::StopImpl(SyncStopDataFate data_fate) { - switch (data_fate) { - case KEEP_DATA: - ShutdownImpl(STOP_SYNC); - break; - case CLEAR_DATA: - ClearUnrecoverableError(); - ShutdownImpl(DISABLE_SYNC); - // Note: ShutdownImpl(DISABLE_SYNC) does *not* clear prefs which are - // directly user-controlled such as the set of selected types here, so - // that if the user ever chooses to enable Sync again, they start off - // with their previous settings by default. We do however require going - // through first-time setup again and set SyncRequested to false. - sync_prefs_.ClearFirstSetupComplete(); - sync_prefs_.ClearPassphrasePromptMutedProductVersion(); - // For explicit passphrase users, clear the encryption key, such that they - // will need to reenter it if sync gets re-enabled. - sync_prefs_.ClearEncryptionBootstrapToken(); - SetSyncRequestedAndIgnoreNotification(false); - // Also let observers know that Sync-the-feature is now fully disabled - // (before it possibly starts up again in transport-only mode). - NotifyObservers(); - break; - } +void SyncServiceImpl::StopAndClearImpl() { + ClearUnrecoverableError(); + ShutdownImpl(ShutdownReason::DISABLE_SYNC); + // Note: ShutdownImpl(DISABLE_SYNC) does *not* clear prefs which are + // directly user-controlled such as the set of selected types here, so + // that if the user ever chooses to enable Sync again, they start off + // with their previous settings by default. We do however require going + // through first-time setup again and set SyncRequested to false. + sync_prefs_.ClearFirstSetupComplete(); + sync_prefs_.ClearPassphrasePromptMutedProductVersion(); + // For explicit passphrase users, clear the encryption key, such that they + // will need to reenter it if sync gets re-enabled. + sync_prefs_.ClearEncryptionBootstrapToken(); + SetSyncRequestedAndIgnoreNotification(false); + // Also let observers know that Sync-the-feature is now fully disabled + // (before it possibly starts up again in transport-only mode). + NotifyObservers(); } SyncUserSettings* SyncServiceImpl::GetUserSettings() { @@ -744,8 +738,7 @@ LOG(ERROR) << "Unrecoverable error detected at " << from_here.ToString() << " -- SyncServiceImpl unusable: " << message; - // Shut all data types down. - ShutdownImpl(DISABLE_SYNC); + ShutdownImpl(ShutdownReason::DISABLE_SYNC); } void SyncServiceImpl::DataTypePreconditionChanged(ModelType type) { @@ -874,7 +867,7 @@ // actions in the popup. The current experience might not be optimal for // the user. We just dismiss the dialog. if (IsSetupInProgress()) { - StopImpl(CLEAR_DATA); + StopAndClearImpl(); expect_sync_configuration_aborted_ = true; } // Trigger an unrecoverable error to stop syncing. @@ -887,9 +880,9 @@ UMA_HISTOGRAM_ENUMERATION("Sync.StopSource", BIRTHDAY_ERROR, STOP_SOURCE_LIMIT); } - // Note: Here we explicitly want StopAndClear (rather than StopImpl), so - // that IsSyncRequested gets set to false, and Sync won't start again on - // the next browser startup. + // Note: Here we explicitly want StopAndClear (rather than + // StopAndClearImpl), so that IsSyncRequested gets set to false, and Sync + // won't start again on the next browser startup. StopAndClear(); #if !BUILDFLAG(IS_CHROMEOS_ASH) // On every platform except ChromeOS, revoke the Sync consent in @@ -910,13 +903,12 @@ #endif break; case STOP_SYNC_FOR_DISABLED_ACCOUNT: - // Sync disabled by domain admin. we should stop syncing until next - // restart. + // Sync disabled by domain admin. Stop syncing until next restart. sync_disabled_by_admin_ = true; - ShutdownImpl(DISABLE_SYNC); + ShutdownImpl(ShutdownReason::DISABLE_SYNC); break; case RESET_LOCAL_SYNC_DATA: - ShutdownImpl(DISABLE_SYNC); + ShutdownImpl(ShutdownReason::DISABLE_SYNC); startup_controller_->TryStart(/*force_immediate=*/true); break; case UNKNOWN_ACTION: @@ -1421,7 +1413,7 @@ } if (is_sync_managed) { - StopImpl(CLEAR_DATA); + StopAndClearImpl(); } else { // Sync is no longer disabled by policy. Try starting it up if appropriate. DCHECK(!engine_); @@ -1459,7 +1451,7 @@ // This will notify the observers. // TODO(crbug.com/856179): Evaluate whether we can get away without a // full restart in this case (i.e. just reconfigure). - StopImpl(KEEP_DATA); + ShutdownImpl(ShutdownReason::STOP_SYNC); // Try to start up again (in transport-only mode). startup_controller_->TryStart(/*force_immediate=*/true); @@ -1672,7 +1664,7 @@ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_); SetSyncRequestedAndIgnoreNotification(false); - StopImpl(CLEAR_DATA); + StopAndClearImpl(); // Try to start up again (in transport-only mode). startup_controller_->TryStart(/*force_immediate=*/true); } @@ -1685,7 +1677,7 @@ sync_allowed_by_platform_ = allowed; if (!sync_allowed_by_platform_) { - StopImpl(KEEP_DATA); + ShutdownImpl(ShutdownReason::STOP_SYNC); // Try to start up again (in transport-only mode). // TODO(crbug.com/856179): Evaluate whether we can get away without a full // restart (i.e. just reconfigure). See also similar comment in @@ -1750,7 +1742,7 @@ // callback in the ctor instead of adding it retroactively. bool restart = false; if (engine_) { - StopImpl(KEEP_DATA); + ShutdownImpl(ShutdownReason::STOP_SYNC); restart = true; } DCHECK(!engine_);
diff --git a/components/sync/driver/sync_service_impl.h b/components/sync/driver/sync_service_impl.h index a241c23a..47d5562 100644 --- a/components/sync/driver/sync_service_impl.h +++ b/components/sync/driver/sync_service_impl.h
@@ -252,14 +252,6 @@ SyncClient* GetSyncClientForTest(); private: - // Passed as an argument to StopImpl to control whether or not the sync - // engine should clear its data when it shuts down. See StopImpl for more - // information. - enum SyncStopDataFate { - KEEP_DATA, - CLEAR_DATA, - }; - enum UnrecoverableErrorReason { ERROR_REASON_ENGINE_INIT_FAILURE, ERROR_REASON_ACTIONABLE_ERROR, @@ -312,11 +304,12 @@ const std::string& message, UnrecoverableErrorReason reason); - // Stops the sync engine. |data_fate| controls whether the local sync data is - // deleted or kept when the engine shuts down. + // Stops the sync engine and clears the local sync data. // Does NOT set IsSyncRequested to false, use StopAndClear() or // SyncUserSettings::SetSyncRequested() for that. - void StopImpl(SyncStopDataFate data_fate); + // TODO(crbug.com/1229171): Either rename this method, or merge it with + // StopAndClear. + void StopAndClearImpl(); // Puts the engine's sync scheduler into NORMAL mode. // Called when configuration is complete.
diff --git a/components/sync/trusted_vault/standalone_trusted_vault_backend.cc b/components/sync/trusted_vault/standalone_trusted_vault_backend.cc index 2c15bb8..1f0f623 100644 --- a/components/sync/trusted_vault/standalone_trusted_vault_backend.cc +++ b/components/sync/trusted_vault/standalone_trusted_vault_backend.cc
@@ -83,7 +83,7 @@ return vault_keys; } -void RetrieveIsRecoverabilityDegradedCompleted( +void DownloadIsRecoverabilityDegradedCompleted( base::OnceCallback<void(bool)> cb, TrustedVaultRecoverabilityStatus status) { std::move(cb).Run(status == TrustedVaultRecoverabilityStatus::kDegraded); @@ -324,9 +324,9 @@ // TODO(crbug.com/1201659): Improve this logic properly and add test coverage, // including throttling and periodic polling. ongoing_get_recoverability_request_ = - connection_->RetrieveIsRecoverabilityDegraded( + connection_->DownloadIsRecoverabilityDegraded( account_info, - base::BindOnce(&RetrieveIsRecoverabilityDegradedCompleted, + base::BindOnce(&DownloadIsRecoverabilityDegradedCompleted, std::move(cb))); }
diff --git a/components/sync/trusted_vault/standalone_trusted_vault_backend_unittest.cc b/components/sync/trusted_vault/standalone_trusted_vault_backend_unittest.cc index 8239be7..837fc40 100644 --- a/components/sync/trusted_vault/standalone_trusted_vault_backend_unittest.cc +++ b/components/sync/trusted_vault/standalone_trusted_vault_backend_unittest.cc
@@ -119,7 +119,7 @@ DownloadNewKeysCallback callback), (override)); MOCK_METHOD(std::unique_ptr<Request>, - RetrieveIsRecoverabilityDegraded, + DownloadIsRecoverabilityDegraded, (const CoreAccountInfo& account_info, IsRecoverabilityDegradedCallback), (override));
diff --git a/components/sync/trusted_vault/trusted_vault_connection.h b/components/sync/trusted_vault/trusted_vault_connection.h index 0504516..fdd8ff4 100644 --- a/components/sync/trusted_vault/trusted_vault_connection.h +++ b/components/sync/trusted_vault/trusted_vault_connection.h
@@ -129,11 +129,10 @@ std::unique_ptr<SecureBoxKeyPair> device_key_pair, DownloadNewKeysCallback callback) WARN_UNUSED_RESULT = 0; - // Asynchronously attempts to retrieve degraded recoverability status from the + // Asynchronously attempts to download degraded recoverability status from the // trusted vault server. Caller should hold returned request object until // |callback| call or until request needs to be cancelled. - // TODO(crbug.com/1081649): Avoid term 'retrieve' in this name. - virtual std::unique_ptr<Request> RetrieveIsRecoverabilityDegraded( + virtual std::unique_ptr<Request> DownloadIsRecoverabilityDegraded( const CoreAccountInfo& account_info, IsRecoverabilityDegradedCallback callback) WARN_UNUSED_RESULT = 0; };
diff --git a/components/sync/trusted_vault/trusted_vault_connection_impl.cc b/components/sync/trusted_vault/trusted_vault_connection_impl.cc index 630cbd5..190f0f2 100644 --- a/components/sync/trusted_vault/trusted_vault_connection_impl.cc +++ b/components/sync/trusted_vault/trusted_vault_connection_impl.cc
@@ -169,7 +169,7 @@ processed_response.last_key_version); } -void ProcessRetrieveIsRecoverabilityDegradedResponse( +void ProcessDownloadIsRecoverabilityDegradedResponse( TrustedVaultConnection::IsRecoverabilityDegradedCallback callback, TrustedVaultRequest::HttpStatus http_status, const std::string& response_body) { @@ -273,7 +273,7 @@ } std::unique_ptr<TrustedVaultConnection::Request> -TrustedVaultConnectionImpl::RetrieveIsRecoverabilityDegraded( +TrustedVaultConnectionImpl::DownloadIsRecoverabilityDegraded( const CoreAccountInfo& account_info, IsRecoverabilityDegradedCallback callback) { auto request = std::make_unique<TrustedVaultRequest>( @@ -285,7 +285,7 @@ request->FetchAccessTokenAndSendRequest( account_info.account_id, GetOrCreateURLLoaderFactory(), access_token_fetcher_.get(), - base::BindOnce(&ProcessRetrieveIsRecoverabilityDegradedResponse, + base::BindOnce(&ProcessDownloadIsRecoverabilityDegradedResponse, std::move(callback))); return request;
diff --git a/components/sync/trusted_vault/trusted_vault_connection_impl.h b/components/sync/trusted_vault/trusted_vault_connection_impl.h index 1ddc085..19a96ba 100644 --- a/components/sync/trusted_vault/trusted_vault_connection_impl.h +++ b/components/sync/trusted_vault/trusted_vault_connection_impl.h
@@ -59,7 +59,7 @@ std::unique_ptr<SecureBoxKeyPair> device_key_pair, DownloadNewKeysCallback callback) override; - std::unique_ptr<Request> RetrieveIsRecoverabilityDegraded( + std::unique_ptr<Request> DownloadIsRecoverabilityDegraded( const CoreAccountInfo& account_info, IsRecoverabilityDegradedCallback callback) override;
diff --git a/components/sync/trusted_vault/trusted_vault_connection_impl_unittest.cc b/components/sync/trusted_vault/trusted_vault_connection_impl_unittest.cc index 0179ff4..2a82fd8 100644 --- a/components/sync/trusted_vault/trusted_vault_connection_impl_unittest.cc +++ b/components/sync/trusted_vault/trusted_vault_connection_impl_unittest.cc
@@ -649,7 +649,7 @@ TEST_F(TrustedVaultConnectionImplTest, ShouldSendGetSecurityDomainRequestWhenRetrievingRecoverability) { std::unique_ptr<TrustedVaultConnection::Request> request = - connection()->RetrieveIsRecoverabilityDegraded( + connection()->DownloadIsRecoverabilityDegraded( /*account_info=*/CoreAccountInfo(), TrustedVaultConnection::IsRecoverabilityDegradedCallback()); ASSERT_THAT(request, NotNull()); @@ -671,7 +671,7 @@ callback; std::unique_ptr<TrustedVaultConnection::Request> request = - connection()->RetrieveIsRecoverabilityDegraded( + connection()->DownloadIsRecoverabilityDegraded( /*account_info=*/CoreAccountInfo(), callback.Get()); ASSERT_THAT(request, NotNull()); @@ -683,7 +683,7 @@ .SerializeAsString())); testing::Mock::VerifyAndClearExpectations(&callback); - request = connection()->RetrieveIsRecoverabilityDegraded( + request = connection()->DownloadIsRecoverabilityDegraded( /*account_info=*/CoreAccountInfo(), callback.Get()); ASSERT_THAT(request, NotNull()); @@ -701,7 +701,7 @@ callback; std::unique_ptr<TrustedVaultConnection::Request> request = - connection()->RetrieveIsRecoverabilityDegraded( + connection()->DownloadIsRecoverabilityDegraded( /*account_info=*/CoreAccountInfo(), callback.Get()); ASSERT_THAT(request, NotNull()); @@ -719,7 +719,7 @@ callback; std::unique_ptr<TrustedVaultConnection::Request> request = - connection()->RetrieveIsRecoverabilityDegraded( + connection()->DownloadIsRecoverabilityDegraded( /*account_info=*/CoreAccountInfo(), callback.Get()); ASSERT_THAT(request, NotNull()); @@ -729,7 +729,7 @@ RespondToGetSecurityDomainRequest(net::HTTP_OK, /*response_body=*/"invalid proto")); - request = connection()->RetrieveIsRecoverabilityDegraded( + request = connection()->DownloadIsRecoverabilityDegraded( /*account_info=*/CoreAccountInfo(), callback.Get()); ASSERT_THAT(request, NotNull()); @@ -746,7 +746,7 @@ callback; std::unique_ptr<TrustedVaultConnection::Request> request = - connection()->RetrieveIsRecoverabilityDegraded( + connection()->DownloadIsRecoverabilityDegraded( /*account_info=*/CoreAccountInfo(), callback.Get()); ASSERT_THAT(request, NotNull());
diff --git a/components/test/data/autofill_assistant/html/autofill_assistant_target_website.html b/components/test/data/autofill_assistant/html/autofill_assistant_target_website.html index cbbb567..1423a15 100644 --- a/components/test/data/autofill_assistant/html/autofill_assistant_target_website.html +++ b/components/test/data/autofill_assistant/html/autofill_assistant_target_website.html
@@ -239,6 +239,8 @@ <option value="two">Zürich Hauptbahnhof</option> <option value="three">Three</option> <option value="Aü万𠜎">Character Test Entry</option> + <option value="four">Four</option> + <option value="five" disabled>Five</option> </select> </div>
diff --git a/components/viz/service/display/gl_renderer.cc b/components/viz/service/display/gl_renderer.cc index db57099..2cd58b0 100644 --- a/components/viz/service/display/gl_renderer.cc +++ b/components/viz/service/display/gl_renderer.cc
@@ -3697,9 +3697,9 @@ if (adjust_src_white_level && src_color_space.IsHDR()) { // TODO(b/183236148): consider using the destination's HDR static metadata // in current_frame()->display_color_spaces.hdr_static_metadata() and the - // mastering metadata in |src_hdr_metadata| for the tone mapping; e.g. the - // content might be mastered in 0-1000 nits but the display only be able to - // represent 0 to 500. + // color volume metadata in |src_hdr_metadata| for the tone mapping; e.g. + // the content might be mastered in 0-1000 nits but the display only be able + // to represent 0 to 500. adjusted_src_color_space = src_color_space.GetWithSDRWhiteLevel( current_frame()->display_color_spaces.GetSDRWhiteLevel()); }
diff --git a/content/browser/accessibility/accessibility_scripts_mac_browsertest.mm b/content/browser/accessibility/accessibility_scripts_mac_browsertest.mm index 3101501..e302816 100644 --- a/content/browser/accessibility/accessibility_scripts_mac_browsertest.mm +++ b/content/browser/accessibility/accessibility_scripts_mac_browsertest.mm
@@ -154,121 +154,6 @@ } // namespace IN_PROC_BROWSER_TEST_F(AccessibilityScriptsMacBrowserTest, - SetSelectedTextMarkerRange_ContentEditable) { - LoadFile("set-selection-contenteditable.html"); - // Select the 1st word via text marker associated with container AXTextArea. - { - AttributeInvoker textarea = GetInvokerAndAssertRole(":2", "AXTextArea"); - OptionalNSObject text_range = - textarea.GetValue("AXTextMarkerRangeForUIElement", - GetNodeAndAssertRole(":2", "AXTextArea")); - - OptionalNSObject marker_0 = a11y::TextMarkerRangeGetStartMarker(text_range); - OptionalNSObject marker_1 = - textarea.GetValue("AXNextWordEndTextMarkerForTextMarker", marker_0); - OptionalNSObject target_selected_marker_range = - textarea.GetValue("AXTextMarkerRangeForUnorderedTextMarkers", - a11y::MakePairArray(marker_0, marker_1)); - textarea.SetValue("AXSelectedTextMarkerRange", - target_selected_marker_range); - - WaitForEvent(ax::mojom::Event::kTextSelectionChanged); - - OptionalNSObject selected_text = textarea.GetValue("AXSelectedText"); - Print(selected_text); - } - // Select the 2nd word via the marker associated with AXStaticText. - { - AttributeInvoker textarea = GetInvokerAndAssertRole(":2", "AXTextArea"); - AttributeInvoker text = GetInvokerAndAssertRole(":4", "AXStaticText"); - OptionalNSObject text_range = - text.GetValue("AXTextMarkerRangeForUIElement", - GetNodeAndAssertRole(":4", "AXStaticText")); - - OptionalNSObject marker_0 = a11y::TextMarkerRangeGetStartMarker(text_range); - OptionalNSObject marker_1 = - text.GetValue("AXNextWordEndTextMarkerForTextMarker", marker_0); - OptionalNSObject marker_2 = - text.GetValue("AXNextWordEndTextMarkerForTextMarker", marker_1); - OptionalNSObject marker_3 = - text.GetValue("AXPreviousWordStartTextMarkerForTextMarker", marker_2); - OptionalNSObject target_selected_marker_range = - text.GetValue("AXTextMarkerRangeForUnorderedTextMarkers", - a11y::MakePairArray(marker_2, marker_3)); - textarea.SetValue("AXSelectedTextMarkerRange", - target_selected_marker_range); - - WaitForEvent(ax::mojom::Event::kTextSelectionChanged); - - OptionalNSObject selected_text = textarea.GetValue("AXSelectedText"); - Print(selected_text); - } - // Select text inside a span. - { - AttributeInvoker textarea = GetInvokerAndAssertRole(":2", "AXTextArea"); - AttributeInvoker text = GetInvokerAndAssertRole(":8", "AXStaticText"); - OptionalNSObject text_range = - text.GetValue("AXTextMarkerRangeForUIElement", - GetNodeAndAssertRole(":8", "AXStaticText")); - - OptionalNSObject marker_0 = a11y::TextMarkerRangeGetStartMarker(text_range); - OptionalNSObject marker_1 = a11y::TextMarkerRangeGetEndMarker(text_range); - OptionalNSObject marker_2 = - text.GetValue("AXPreviousTextMarkerForTextMarker", marker_1); - OptionalNSObject target_selected_marker_range = - text.GetValue("AXTextMarkerRangeForUnorderedTextMarkers", - a11y::MakePairArray(marker_0, marker_2)); - textarea.SetValue("AXSelectedTextMarkerRange", - target_selected_marker_range); - - WaitForEvent(ax::mojom::Event::kTextSelectionChanged); - - OptionalNSObject selected_text = textarea.GetValue("AXSelectedText"); - Print(selected_text); - } - // Select the text inside the block with incorrect grammar. - { - AttributeInvoker textarea = GetInvokerAndAssertRole(":2", "AXTextArea"); - AttributeInvoker text = GetInvokerAndAssertRole(":6", "AXStaticText"); - OptionalNSObject text_range = - text.GetValue("AXTextMarkerRangeForUIElement", - GetNodeAndAssertRole(":6", "AXStaticText")); - - OptionalNSObject target_selected_marker_range = text_range; - textarea.SetValue("AXSelectedTextMarkerRange", - target_selected_marker_range); - - WaitForEvent(ax::mojom::Event::kTextSelectionChanged); - - OptionalNSObject selected_text = textarea.GetValue("AXSelectedText"); - Print(selected_text); - } - // Select the text after a forced break. - { - AttributeInvoker textarea = GetInvokerAndAssertRole(":10", "AXTextArea"); - AttributeInvoker text = GetInvokerAndAssertRole(":14", "AXStaticText"); - OptionalNSObject text_range = - text.GetValue("AXTextMarkerRangeForUIElement", - GetNodeAndAssertRole(":14", "AXStaticText")); - - OptionalNSObject marker_0 = a11y::TextMarkerRangeGetStartMarker(text_range); - OptionalNSObject marker_1 = - text.GetValue("AXNextWordEndTextMarkerForTextMarker", marker_0); - OptionalNSObject target_selected_marker_range = - text.GetValue("AXTextMarkerRangeForUnorderedTextMarkers", - a11y::MakePairArray(marker_0, marker_1)); - textarea.SetValue("AXSelectedTextMarkerRange", - target_selected_marker_range); - - WaitForEvent(ax::mojom::Event::kTextSelectionChanged); - - OptionalNSObject selected_text = textarea.GetValue("AXSelectedText"); - Print(selected_text); - } - AssertOutputMatchesExpectations(); -} - -IN_PROC_BROWSER_TEST_F(AccessibilityScriptsMacBrowserTest, SetSelectedTextMarkerRange_TextArea) { LoadFile("set-selection-textarea.html");
diff --git a/content/browser/accessibility/browser_accessibility_manager.cc b/content/browser/accessibility/browser_accessibility_manager.cc index 1e482bd..f44c85d8 100644 --- a/content/browser/accessibility/browser_accessibility_manager.cc +++ b/content/browser/accessibility/browser_accessibility_manager.cc
@@ -606,6 +606,8 @@ change->new_location.transform.get()); } SendLocationChangeEvents(changes); + if (!location_change_callback_for_testing_.is_null()) + location_change_callback_for_testing_.Run(); } void BrowserAccessibilityManager::SendLocationChangeEvents( @@ -797,6 +799,11 @@ generated_event_callback_for_testing_ = callback; } +void BrowserAccessibilityManager::SetLocationChangeCallbackForTesting( + const base::RepeatingClosure& callback) { + location_change_callback_for_testing_ = callback; +} + // static void BrowserAccessibilityManager::NeverSuppressOrDelayEventsForTesting() { never_suppress_or_delay_events_for_testing_ = true;
diff --git a/content/browser/accessibility/browser_accessibility_manager.h b/content/browser/accessibility/browser_accessibility_manager.h index 08119a55..570ccbf 100644 --- a/content/browser/accessibility/browser_accessibility_manager.h +++ b/content/browser/accessibility/browser_accessibility_manager.h
@@ -245,6 +245,11 @@ void SetGeneratedEventCallbackForTesting( const GeneratedEventCallbackForTesting& callback); + // For testing only, register a function to be called when nodes + // change location / bounding box in this BrowserAccessibilityManager. + void SetLocationChangeCallbackForTesting( + const base::RepeatingClosure& callback); + // Normally we avoid firing accessibility focus events when the containing // native window isn't focused, and we also delay some other events like // live region events to improve screen reader compatibility. @@ -580,6 +585,9 @@ // For testing only: A function to call when a generated event is fired. GeneratedEventCallbackForTesting generated_event_callback_for_testing_; + // For testing only; A function to call when locations change. + base::RepeatingClosure location_change_callback_for_testing_; + // Keeps track of the nested popup root's id, if it exists. See GetPopupRoot() // for details. std::set<int32_t> popup_root_ids_;
diff --git a/content/browser/accessibility/cross_platform_accessibility_browsertest.cc b/content/browser/accessibility/cross_platform_accessibility_browsertest.cc index 49031e3..711f4d3c 100644 --- a/content/browser/accessibility/cross_platform_accessibility_browsertest.cc +++ b/content/browser/accessibility/cross_platform_accessibility_browsertest.cc
@@ -1993,4 +1993,49 @@ ax::mojom::BoolAttribute::kSelectedFromFocus)); } +// We do not run this test on Android because only the Java code can change the +// size of the web contents, instead see the associated test in +// WebContentsAccessibilityTest#testBoundingBoxUpdatesOnWindowResize(). +#if !defined(OS_ANDROID) +IN_PROC_BROWSER_TEST_F(CrossPlatformAccessibilityBrowserTest, + FlexBoxBoundingBoxUpdatesOnWindowResize) { + // This is an edge case that was discovered on a mobile sign-in page. + // The size of the outer flexbox is tied to the vertical height of the + // window, so ensure that the bounding box of the button is correctly + // recomputed if the window is resized, causing the button to move up. + LoadInitialAccessibilityTreeFromHtml(R"HTML( + <div style="display: flex; min-height: 90vh;"> + <div style="display: flex; flex-grow: 1; align-items: flex-end;"> + <div> + <button style="display: inline-flex; will-change: transform;"> + Next + </button> + </div> + </div> + </div>)HTML"); + + BrowserAccessibility* button = + FindFirstNodeWithRole(ax::mojom::Role::kButton); + gfx::Rect bounds0 = button->GetUnclippedRootFrameBoundsRect(); + + // Resize the viewport, making it half the height. + gfx::Rect view_bounds = shell()->web_contents()->GetViewBounds(); + view_bounds.set_height(view_bounds.height() / 2); + shell()->web_contents()->Resize(view_bounds); + + gfx::Rect bounds1; + do { + // Wait for any event + AccessibilityNotificationWaiter waiter( + shell()->web_contents(), ui::AXMode(), ax::mojom::Event::kNone); + waiter.WaitForNotification(); + bounds1 = button->GetUnclippedRootFrameBoundsRect(); + } while (bounds1.y() == bounds0.y()); + + // The top coordinate of the button should be less than half of its + // original top coordinate. + EXPECT_LT(bounds1.y(), bounds0.y() / 2); +} +#endif + } // namespace content
diff --git a/content/browser/accessibility/dump_accessibility_scripts_browsertest.cc b/content/browser/accessibility/dump_accessibility_scripts_browsertest.cc index cf54cd7..10ec0c9 100644 --- a/content/browser/accessibility/dump_accessibility_scripts_browsertest.cc +++ b/content/browser/accessibility/dump_accessibility_scripts_browsertest.cc
@@ -163,6 +163,11 @@ } IN_PROC_BROWSER_TEST_P(DumpAccessibilityScriptTest, + SetSelectionContenteditable) { + RunMacSelectionTest(FILE_PATH_LITERAL("set-selection-contenteditable.html")); +} + +IN_PROC_BROWSER_TEST_P(DumpAccessibilityScriptTest, AXNextWordEndTextMarkerForTextMarker) { RunMacTextMarkerTest( FILE_PATH_LITERAL("ax-next-word-end-text-marker-for-text-marker.html"));
diff --git a/content/browser/back_forward_cache_browsertest.cc b/content/browser/back_forward_cache_browsertest.cc index bb98355..00956ce 100644 --- a/content/browser/back_forward_cache_browsertest.cc +++ b/content/browser/back_forward_cache_browsertest.cc
@@ -5767,6 +5767,9 @@ void SetUpCommandLine(base::CommandLine* command_line) override { same_site_back_forward_cache_enabled_ = false; DisableFeature(features::kProactivelySwapBrowsingInstance); + // Ensure that the bot flags won't override the same-site back/forward cache + // disabling. + DisableFeature(features::kBackForwardCacheSameSiteForBots); BackForwardCacheBrowserTest::SetUpCommandLine(command_line); } };
diff --git a/content/browser/cross_origin_opener_policy_browsertest.cc b/content/browser/cross_origin_opener_policy_browsertest.cc index 8334736..a003fd0d 100644 --- a/content/browser/cross_origin_opener_policy_browsertest.cc +++ b/content/browser/cross_origin_opener_policy_browsertest.cc
@@ -13,6 +13,7 @@ #include "content/common/content_navigation_policy.h" #include "content/public/common/content_features.h" #include "content/public/test/browser_test.h" +#include "content/public/test/browser_test_utils.h" #include "content/public/test/content_browser_test.h" #include "content/public/test/content_browser_test_utils.h" #include "content/public/test/url_loader_interceptor.h" @@ -1206,8 +1207,12 @@ // Try to host into the same cross-origin isolated process, two cross-origin // documents. The second's response sets CSP:sandbox, so its origin is opaque // and derived from the first. +// +// Variants: +// 1. CrossOriginIsolatedOpeneeCspSandbox +// 2. CrossOriginIsolatedOpeneeOpenerSandbox IN_PROC_BROWSER_TEST_P(CrossOriginOpenerPolicyBrowserTest, - CrossOriginIsolatedWithDifferentOrigin) { + CrossOriginIsolatedWithOpeneeCspSandbox) { GURL opener_url = https_server()->GetURL("a.com", "/set-header?" @@ -1243,18 +1248,70 @@ EXPECT_EQ(opener_current_main_document->last_http_status_code(), 200); EXPECT_EQ(openee_current_main_document->last_http_status_code(), 200); - // We have two main documents in the same cross-origin isolated process from a - // different origin. - // TODO(https://crbug.com/1115426): Investigate what needs to be done. + // We have two main documents in different cross-origin isolated process. EXPECT_NE(opener_current_main_document->GetLastCommittedOrigin(), openee_current_main_document->GetLastCommittedOrigin()); - EXPECT_EQ(opener_current_main_document->GetProcess(), + EXPECT_NE(opener_current_main_document->GetProcess(), openee_current_main_document->GetProcess()); - EXPECT_EQ(opener_current_main_document->GetSiteInstance(), + EXPECT_NE(opener_current_main_document->GetSiteInstance(), openee_current_main_document->GetSiteInstance()); - // TODO(arthursonzogni): Check whether the processes are marked as - // cross-origin isolated or not. + EXPECT_TRUE( + opener_current_main_document->GetSiteInstance()->IsCrossOriginIsolated()); + EXPECT_TRUE( + openee_current_main_document->GetSiteInstance()->IsCrossOriginIsolated()); +} + +// Variants: +// 1. CrossOriginIsolatedOpeneeCspSandbox +// 2. CrossOriginIsolatedOpeneeOpenerSandbox +IN_PROC_BROWSER_TEST_P(CrossOriginOpenerPolicyBrowserTest, + CrossOriginIsolatedOpeneeOpenerSandbox) { + // The URL used by both the openee and the opener. + GURL url = https_server()->GetURL( + "a.com", + "/set-header?" + "Cross-Origin-Opener-Policy: same-origin&" + "Cross-Origin-Embedder-Policy: require-corp&" + "Content-Security-Policy: sandbox allow-scripts allow-popups"); + + // Load the first window. + EXPECT_TRUE(NavigateToURL(shell(), url)); + RenderFrameHostImpl* opener_current_main_document = current_frame_host(); + + // Load the second window. + ShellAddedObserver shell_observer; + EXPECT_TRUE(ExecJs(current_frame_host(), JsReplace("window.open($1)", url))); + WebContents* popup = shell_observer.GetShell()->web_contents(); + WaitForLoadStop(popup); + + RenderFrameHostImpl* openee_current_main_document = + static_cast<WebContentsImpl*>(popup) + ->GetFrameTree() + ->root() + ->current_frame_host(); + + // Popups with a sandboxing flag, inherited from their opener, are not + // allowed to navigate to a document with a Cross-Origin-Opener-Policy that + // is not "unsafe-none". As a result, the navigation in the popup ended up + // loading an error document. + + EXPECT_EQ(opener_current_main_document->GetLastCommittedURL(), url); + EXPECT_EQ(openee_current_main_document->GetLastCommittedURL(), url); + EXPECT_EQ(opener_current_main_document->last_http_status_code(), 200); + EXPECT_EQ(openee_current_main_document->last_http_status_code(), 0); + + EXPECT_NE(opener_current_main_document->GetLastCommittedOrigin(), + openee_current_main_document->GetLastCommittedOrigin()); + EXPECT_NE(opener_current_main_document->GetProcess(), + openee_current_main_document->GetProcess()); + EXPECT_NE(opener_current_main_document->GetSiteInstance(), + openee_current_main_document->GetSiteInstance()); + + EXPECT_TRUE( + opener_current_main_document->GetSiteInstance()->IsCrossOriginIsolated()); + EXPECT_FALSE( + openee_current_main_document->GetSiteInstance()->IsCrossOriginIsolated()); } // Navigate in between two documents. Check the virtual browsing context group @@ -2520,6 +2577,70 @@ } } +// Regression test for https://crbug.com/1226909. +IN_PROC_BROWSER_TEST_P(CrossOriginOpenerPolicyBrowserTest, + NavigatePopupToErrorAndCrash) { + GURL isolated_page( + https_server()->GetURL("a.com", + "/set-header?" + "Cross-Origin-Opener-Policy: same-origin&" + "Cross-Origin-Embedder-Policy: require-corp")); + + // Initial cross-origin isolated page. + EXPECT_TRUE(NavigateToURL(shell(), isolated_page)); + SiteInstanceImpl* main_si = current_frame_host()->GetSiteInstance(); + EXPECT_TRUE(main_si->IsCrossOriginIsolated()); + + ShellAddedObserver shell_observer; + GURL error_url(embedded_test_server()->GetURL("/close-socket")); + EXPECT_TRUE(ExecJs(current_frame_host(), + JsReplace("window.w = open($1);", error_url))); + WebContentsImpl* popup_web_contents = + static_cast<WebContentsImpl*>(shell_observer.GetShell()->web_contents()); + WaitForLoadStop(popup_web_contents); + + // The popup should commit an error page with default COOP. + EXPECT_EQ(PAGE_TYPE_ERROR, popup_web_contents->GetController() + .GetLastCommittedEntry() + ->GetPageType()); + EXPECT_FALSE(popup_web_contents->GetMainFrame() + ->GetSiteInstance() + ->IsCrossOriginIsolated()); + EXPECT_EQ(CoopUnsafeNone(), + popup_web_contents->GetMainFrame()->cross_origin_opener_policy()); + + url::Origin error_origin = + popup_web_contents->GetMainFrame()->GetLastCommittedOrigin(); + + // Simulate the popup renderer process crashing. + RenderProcessHost* popup_process = + popup_web_contents->GetMainFrame()->GetProcess(); + EXPECT_NE(popup_process, current_frame_host()->GetProcess()); + + ASSERT_TRUE(popup_process); + { + RenderProcessHostWatcher crash_observer( + popup_process, RenderProcessHostWatcher::WATCH_FOR_PROCESS_EXIT); + popup_process->Shutdown(0); + crash_observer.Wait(); + } + + // Try to navigate the popup. This should not be possible, since the opener + // relationship should be closed. + EXPECT_TRUE( + ExecJs(current_frame_host(), "window.w.location = 'about:blank';")); + WaitForLoadStop(popup_web_contents); + + // The popup should not have navigated. + EXPECT_EQ(error_origin, + popup_web_contents->GetMainFrame()->GetLastCommittedOrigin()); + EXPECT_FALSE(popup_web_contents->GetMainFrame() + ->GetSiteInstance() + ->IsCrossOriginIsolated()); + EXPECT_EQ(CoopUnsafeNone(), + popup_web_contents->GetMainFrame()->cross_origin_opener_policy()); +} + IN_PROC_BROWSER_TEST_P(CrossOriginOpenerPolicyBrowserTest, CrossOriginRedirectHasProperCrossOriginIsolatedState) { GURL non_isolated_page(
diff --git a/content/browser/prerender/prerender_browsertest.cc b/content/browser/prerender/prerender_browsertest.cc index cb29076..826b39c 100644 --- a/content/browser/prerender/prerender_browsertest.cc +++ b/content/browser/prerender/prerender_browsertest.cc
@@ -3304,9 +3304,12 @@ base::FieldTrialParams feature_params; feature_params["TimeToLiveInBackForwardCacheInSeconds"] = "3600"; - // Allow the BFCache for all devices regardless of their memory. + // Allow the BFCache for all devices regardless of their memory, and ensure + // bot flags won't enable BFCache (as we want to control BFCache + // enabling/disabling ourselves). std::vector<base::Feature> disabled_features{ - features::kBackForwardCacheMemoryControls}; + features::kBackForwardCacheMemoryControls, + features::kBackForwardCacheSameSiteForBots}; switch (GetParam()) { case BackForwardCacheType::kDisabled:
diff --git a/content/browser/renderer_host/back_forward_cache_impl.cc b/content/browser/renderer_host/back_forward_cache_impl.cc index 3b364eb..55b59f89 100644 --- a/content/browser/renderer_host/back_forward_cache_impl.cc +++ b/content/browser/renderer_host/back_forward_cache_impl.cc
@@ -970,6 +970,11 @@ } // static +bool BackForwardCache::IsSameSiteBackForwardCacheFeatureEnabled() { + return IsSameSiteBackForwardCacheEnabled(); +} + +// static void BackForwardCache::DisableForRenderFrameHost( RenderFrameHost* render_frame_host, BackForwardCache::DisabledReason reason) {
diff --git a/content/browser/renderer_host/cross_origin_opener_policy_status.cc b/content/browser/renderer_host/cross_origin_opener_policy_status.cc index 9858d02..066d1c9 100644 --- a/content/browser/renderer_host/cross_origin_opener_policy_status.cc +++ b/content/browser/renderer_host/cross_origin_opener_policy_status.cc
@@ -114,41 +114,21 @@ CrossOriginOpenerPolicyStatus::~CrossOriginOpenerPolicyStatus() = default; -network::CrossOriginOpenerPolicy& -CrossOriginOpenerPolicyStatus::RetrieveCOOPFromResponse( - network::mojom::URLResponseHead* response_head, - const url::Origin& response_origin) { - const GURL& response_url = navigation_request_->common_params().url; - - SanitizeCoopHeaders(response_url, response_origin, response_head); - - network::mojom::ParsedHeaders* parsed_headers = - response_head->parsed_headers.get(); - - return parsed_headers->cross_origin_opener_policy; -} - absl::optional<network::mojom::BlockedByResponseReason> -CrossOriginOpenerPolicyStatus::EnforceCOOP( - const network::CrossOriginOpenerPolicy& response_coop, - const url::Origin& response_origin, - const net::NetworkIsolationKey& network_isolation_key) { - // COOP only applies to top level browsing contexts. - if (!frame_tree_node_->IsMainFrame()) { - return absl::nullopt; - } - +CrossOriginOpenerPolicyStatus::SanitizeResponse( + network::mojom::URLResponseHead* response) const { const GURL& response_url = navigation_request_->common_params().url; - const GURL& response_referrer_url = - navigation_request_->common_params().referrer->url; + SanitizeCoopHeaders(response_url, response); + + network::CrossOriginOpenerPolicy& coop = + response->parsed_headers->cross_origin_opener_policy; // Popups with a sandboxing flag, inherited from their opener, are not // allowed to navigate to a document with a Cross-Origin-Opener-Policy that // is not "unsafe-none". This ensures a COOP document does not inherit any // property from an opener. // https://gist.github.com/annevk/6f2dd8c79c77123f39797f6bdac43f3e - if (response_coop.value != - network::mojom::CrossOriginOpenerPolicyValue::kUnsafeNone && + if (coop.value != network::mojom::CrossOriginOpenerPolicyValue::kUnsafeNone && (frame_tree_node_->pending_frame_policy().sandbox_flags != network::mojom::WebSandboxFlags::kNone)) { // Blob and Filesystem documents' cross-origin-opener-policy values are @@ -162,6 +142,21 @@ kCoopSandboxedIFrameCannotNavigateToCoopPage; } + return absl::nullopt; +} + +void CrossOriginOpenerPolicyStatus::EnforceCOOP( + const network::CrossOriginOpenerPolicy& response_coop, + const url::Origin& response_origin, + const net::NetworkIsolationKey& network_isolation_key) { + // COOP only applies to top level browsing contexts. + if (!frame_tree_node_->IsMainFrame()) + return; + + const GURL& response_url = navigation_request_->common_params().url; + const GURL& response_referrer_url = + navigation_request_->common_params().referrer->url; + StoragePartition* storage_partition = frame_tree_node_->current_frame_host() ->GetProcess() ->GetStoragePartition(); @@ -269,8 +264,6 @@ // Any subsequent response means this response was a redirect, and the source // of the navigation to the subsequent response. is_navigation_source_ = true; - - return absl::nullopt; } std::unique_ptr<CrossOriginOpenerPolicyReporter> @@ -289,11 +282,10 @@ // - For subframes. // - When the feature is disabled. // We also strip the "reporting" parts when the reporting feature is disabled -// for the |response_origin|. +// for the |response_url|. void CrossOriginOpenerPolicyStatus::SanitizeCoopHeaders( const GURL& response_url, - const url::Origin& response_origin, - network::mojom::URLResponseHead* response_head) { + network::mojom::URLResponseHead* response_head) const { network::CrossOriginOpenerPolicy& coop = response_head->parsed_headers->cross_origin_opener_policy; if (coop == network::CrossOriginOpenerPolicy()) @@ -306,19 +298,26 @@ // 1. If reservedEnvironment is a non-secure context, then return // "unsafe-none". // ``` - !network::IsOriginPotentiallyTrustworthy(response_origin) || + // + // https://html.spec.whatwg.org/multipage/webappapis.html#secure-contexts + // ``` + // 2. If the result of Is url potentially trustworthy? given environment's + // top-level creation URL is "Potentially Trustworthy", then return true. + // ``` + !network::IsUrlPotentiallyTrustworthy(response_url) || // The COOP header must be ignored outside of the top-level context. It is // removed as a defensive measure. !frame_tree_node_->IsMainFrame()) { coop = network::CrossOriginOpenerPolicy(); - if (!network::IsOriginPotentiallyTrustworthy(response_origin)) { + if (!network::IsUrlPotentiallyTrustworthy(response_url)) { navigation_request_->AddDeferredConsoleMessage( blink::mojom::ConsoleMessageLevel::kError, - "The Cross-Origin-Opener-Policy header has been ignored, because the " - "origin was untrustworthy. It was defined either in the final " - "response or a redirect. Please deliver the response using the HTTPS " - "protocol. You can also use the 'localhost' origin instead. See " + "The Cross-Origin-Opener-Policy header has been ignored, because " + "the URL's origin was untrustworthy. It was defined either in the " + "final response or a redirect. Please deliver the response using " + "the HTTPS protocol. You can also use the 'localhost' origin " + "instead. See " "https://www.w3.org/TR/powerful-features/" "#potentially-trustworthy-origin and " "https://html.spec.whatwg.org/"
diff --git a/content/browser/renderer_host/cross_origin_opener_policy_status.h b/content/browser/renderer_host/cross_origin_opener_policy_status.h index c1946a1..0075425 100644 --- a/content/browser/renderer_host/cross_origin_opener_policy_status.h +++ b/content/browser/renderer_host/cross_origin_opener_policy_status.h
@@ -30,19 +30,15 @@ explicit CrossOriginOpenerPolicyStatus(NavigationRequest* navigation_request); ~CrossOriginOpenerPolicyStatus(); - // Called after receiving a network response. Returns the - // Cross-Origin-Opener-Policy contained in the response. - network::CrossOriginOpenerPolicy& RetrieveCOOPFromResponse( - network::mojom::URLResponseHead* response_head, - const url::Origin& response_origin); + // Sanitize the COOP header from the `response`. + // Return an error when COOP is used on sandboxed popups. + absl::optional<network::mojom::BlockedByResponseReason> SanitizeResponse( + network::mojom::URLResponseHead* response) const; - // Called when receiving a redirect or the final response. Returns a - // BlockedByResponse reason if the navigation should be blocked, nullopt - // otherwise. - absl::optional<network::mojom::BlockedByResponseReason> EnforceCOOP( - const network::CrossOriginOpenerPolicy& response_coop, - const url::Origin& response_origin, - const net::NetworkIsolationKey& network_isolation_key); + // Called when receiving a redirect or the final response. + void EnforceCOOP(const network::CrossOriginOpenerPolicy& response_coop, + const url::Origin& response_origin, + const net::NetworkIsolationKey& network_isolation_key); // Set to true whenever the Cross-Origin-Opener-Policy spec requires a // "BrowsingContext group" swap: @@ -81,9 +77,9 @@ private: // Make sure COOP is relevant or clear the COOP headers. - void SanitizeCoopHeaders(const GURL& response_url, - const url::Origin& response_origin, - network::mojom::URLResponseHead* response_head); + void SanitizeCoopHeaders( + const GURL& response_url, + network::mojom::URLResponseHead* response_head) const; // The NavigationRequest which owns this object. NavigationRequest* const navigation_request_;
diff --git a/content/browser/renderer_host/frame_tree.cc b/content/browser/renderer_host/frame_tree.cc index a5173546..75def203 100644 --- a/content/browser/renderer_host/frame_tree.cc +++ b/content/browser/renderer_host/frame_tree.cc
@@ -76,20 +76,30 @@ FrameTree::NodeIterator& FrameTree::NodeIterator::operator++() { if (current_node_ != root_of_subtree_to_skip_) { + // Reserve enough space in the queue to accommodate the nodes we're + // going to add, to avoid repeated resize calls. + queue_.reserve(queue_.size() + current_node_->child_count()); + for (size_t i = 0; i < current_node_->child_count(); ++i) { FrameTreeNode* child = current_node_->child_at(i); FrameTreeNode* inner_tree_main_ftn = GetInnerTreeMainFrameNode(child); - queue_.push((should_descend_into_inner_trees_ && inner_tree_main_ftn) - ? inner_tree_main_ftn - : child); + queue_.push_back((should_descend_into_inner_trees_ && inner_tree_main_ftn) + ? inner_tree_main_ftn + : child); } if (should_descend_into_inner_trees_) { - for (auto* unattached_node : - current_node_->current_frame_host() - ->delegate() - ->GetUnattachedOwnedNodes(current_node_->current_frame_host())) { - queue_.push(unattached_node); + auto unattached_nodes = + current_node_->current_frame_host() + ->delegate() + ->GetUnattachedOwnedNodes(current_node_->current_frame_host()); + + // Reserve enough space in the queue to accommodate the nodes we're + // going to add. + queue_.reserve(queue_.size() + unattached_nodes.size()); + + for (auto* unattached_node : unattached_nodes) { + queue_.push_back(unattached_node); } } } @@ -110,7 +120,7 @@ void FrameTree::NodeIterator::AdvanceNode() { if (!queue_.empty()) { current_node_ = queue_.front(); - queue_.pop(); + queue_.pop_front(); } else { current_node_ = nullptr; } @@ -123,8 +133,7 @@ : current_node_(nullptr), root_of_subtree_to_skip_(root_of_subtree_to_skip), should_descend_into_inner_trees_(should_descend_into_inner_trees), - queue_(base::circular_deque<FrameTreeNode*>(starting_nodes.begin(), - starting_nodes.end())) { + queue_(starting_nodes.begin(), starting_nodes.end()) { AdvanceNode(); }
diff --git a/content/browser/renderer_host/frame_tree.h b/content/browser/renderer_host/frame_tree.h index d355707b..ca79497 100644 --- a/content/browser/renderer_host/frame_tree.h +++ b/content/browser/renderer_host/frame_tree.h
@@ -74,6 +74,7 @@ FrameTreeNode* operator*() { return current_node_; } private: + friend class FrameTreeTest; friend class NodeRange; NodeIterator(const std::vector<FrameTreeNode*>& starting_nodes, @@ -85,7 +86,7 @@ FrameTreeNode* current_node_; const FrameTreeNode* const root_of_subtree_to_skip_; const bool should_descend_into_inner_trees_; - base::queue<FrameTreeNode*> queue_; + base::circular_deque<FrameTreeNode*> queue_; }; class CONTENT_EXPORT NodeRange {
diff --git a/content/browser/renderer_host/frame_tree_unittest.cc b/content/browser/renderer_host/frame_tree_unittest.cc index d6dad1b2..d8bd5fd 100644 --- a/content/browser/renderer_host/frame_tree_unittest.cc +++ b/content/browser/renderer_host/frame_tree_unittest.cc
@@ -150,8 +150,63 @@ } return result; } + + size_t GetIteratorSize(FrameTree::NodeIterator iterator) { + return iterator.queue_.size(); + } }; +// Confirm expected operation of the node queue that supports node iterators. +TEST_F(FrameTreeTest, FrameNodeQueue) { + main_test_rfh()->InitializeRenderFrameIfNeeded(); + + // Use the FrameTree of the WebContents so that it has all the delegates it + // needs. We may want to consider a test version of this. + FrameTree* frame_tree = contents()->GetFrameTree(); + FrameTreeNode* root = frame_tree->root(); + + constexpr auto kOwnerType = blink::mojom::FrameOwnerElementType::kIframe; + int process_id = root->current_frame_host()->GetProcess()->GetID(); + frame_tree->AddFrame(root->current_frame_host(), process_id, 14, + CreateStubFrameRemote(), + CreateStubBrowserInterfaceBrokerReceiver(), + CreateStubPolicyContainerBindParams(), + blink::mojom::TreeScopeType::kDocument, std::string(), + "uniqueName0", false, blink::LocalFrameToken(), + base::UnguessableToken::Create(), blink::FramePolicy(), + blink::mojom::FrameOwnerProperties(), false, kOwnerType); + frame_tree->AddFrame(root->current_frame_host(), process_id, 15, + CreateStubFrameRemote(), + CreateStubBrowserInterfaceBrokerReceiver(), + CreateStubPolicyContainerBindParams(), + blink::mojom::TreeScopeType::kDocument, std::string(), + "uniqueName1", false, blink::LocalFrameToken(), + base::UnguessableToken::Create(), blink::FramePolicy(), + blink::mojom::FrameOwnerProperties(), false, kOwnerType); + frame_tree->AddFrame(root->current_frame_host(), process_id, 16, + CreateStubFrameRemote(), + CreateStubBrowserInterfaceBrokerReceiver(), + CreateStubPolicyContainerBindParams(), + blink::mojom::TreeScopeType::kDocument, std::string(), + "uniqueName2", false, blink::LocalFrameToken(), + base::UnguessableToken::Create(), blink::FramePolicy(), + blink::mojom::FrameOwnerProperties(), false, kOwnerType); + + EXPECT_EQ(3U, root->child_count()); + FrameTree::NodeIterator node_iterator = frame_tree->Nodes().begin(); + + // Before the iterator advances the frame node queue should be empty. + EXPECT_EQ(0U, GetIteratorSize(node_iterator)); + + std::advance(node_iterator, 1); + + // Advancing the iterator should fill the queue, then pop the first node + // from the front of the queue and make it the current node (available by + // dereferencing the iterator). + EXPECT_EQ(2U, GetIteratorSize(node_iterator)); + EXPECT_EQ(root->child_at(0), *node_iterator); +} + // Exercise tree manipulation routines. // - Add a series of nodes and verify tree structure. // - Remove a series of nodes and verify tree structure.
diff --git a/content/browser/renderer_host/navigation_request.cc b/content/browser/renderer_host/navigation_request.cc index e10dedb..5b830ec 100644 --- a/content/browser/renderer_host/navigation_request.cc +++ b/content/browser/renderer_host/navigation_request.cc
@@ -1818,12 +1818,10 @@ // Enforce cross-origin-opener-policy for about:blank, about:srcdoc and // MHTML iframe, before selecting the RenderFrameHost. const url::Origin origin = GetOriginForURLLoaderFactoryUnchecked(this); - const absl::optional<network::mojom::BlockedByResponseReason> - coop_requires_blocking = coop_status_.EnforceCOOP( - policy_container_navigation_bundle_->FinalPolicies() - .cross_origin_opener_policy, - origin, net::NetworkIsolationKey(origin, origin)); - DCHECK(!coop_requires_blocking); + coop_status_.EnforceCOOP( + policy_container_navigation_bundle_->FinalPolicies() + .cross_origin_opener_policy, + origin, net::NetworkIsolationKey(origin, origin)); // Select an appropriate RenderFrameHost. std::string frame_host_choice_reason; @@ -2315,11 +2313,9 @@ return; } - const url::Origin origin = GetOriginForURLLoaderFactoryUnchecked(this); const absl::optional<network::mojom::BlockedByResponseReason> - coop_requires_blocking = coop_status_.EnforceCOOP( - coop_status_.RetrieveCOOPFromResponse(response_head_.get(), origin), - origin, network_isolation_key); + coop_requires_blocking = + coop_status_.SanitizeResponse(response_head_.get()); if (coop_requires_blocking) { OnRequestFailedInternal( network::URLLoaderCompletionStatus(*coop_requires_blocking), @@ -2329,6 +2325,10 @@ // OnRequestFailedInternal has destroyed the NavigationRequest. return; } + const url::Origin origin = GetOriginForURLLoaderFactoryUnchecked(this); + coop_status_.EnforceCOOP( + response()->parsed_headers->cross_origin_opener_policy, origin, + network_isolation_key); const absl::optional<network::mojom::BlockedByResponseReason> coep_requires_blocking = EnforceCOEP(); @@ -2800,16 +2800,9 @@ } { - const url::Origin origin = GetOriginForURLLoaderFactoryUnchecked(this); - // TODO(pmeuleman) Move the enforcement of COOP to after - // ComputePoliciesToCommit and use the origin from - // GetOriginForURLLoaderFactory. const absl::optional<network::mojom::BlockedByResponseReason> - coop_requires_blocking = coop_status_.EnforceCOOP( - coop_status_.RetrieveCOOPFromResponse(response_head_.get(), origin), - origin, network_isolation_key); - policy_container_navigation_bundle_->SetCrossOriginOpenerPolicy( - coop_status_.current_coop()); + coop_requires_blocking = + coop_status_.SanitizeResponse(response_head_.get()); if (coop_requires_blocking) { // TODO(https://crbug.com/1172169): Investigate what must be done in case // of a download. @@ -2821,9 +2814,22 @@ // OnRequestFailedInternal has destroyed the NavigationRequest. return; } + policy_container_navigation_bundle_->SetCrossOriginOpenerPolicy( + response_head_->parsed_headers->cross_origin_opener_policy); } ComputePoliciesToCommit(); + // After this line. The sandbox flags to commit have been computed. The origin + // can be determined. This is needed for enforcing COOP below. + + { + const url::Origin origin = + GetOriginForURLLoaderFactoryWithoutFinalFrameHost(); + const PolicyContainerPolicies& policies = + policy_container_navigation_bundle_->FinalPolicies(); + coop_status_.EnforceCOOP(policies.cross_origin_opener_policy, origin, + network_isolation_key); + } // The navigation may have encountered a header that requests isolation for // the url's origin. Before we pick the renderer, make sure we update the @@ -3265,6 +3271,19 @@ frame_tree_node_->SetCollapsed(true); } + is_mhtml_or_subframe_ = false; + sandbox_flags_to_commit_.reset(); + // TODO(https://crbug.com/1158370): Apparently, error pages inherit sandbox + // flags from their parent/opener. Document loaded from the network + // shouldn't have any influence over Chrome's internal error page. We should + // define our own flags, preferably the strictest ones instead. + ComputePoliciesToCommitForError(); + + coop_status_.EnforceCOOP(policy_container_navigation_bundle_->FinalPolicies() + .cross_origin_opener_policy, + url::Origin(), + net::NetworkIsolationKey::CreateTransient()); + RenderFrameHostImpl* render_frame_host = nullptr; switch (ComputeErrorPageProcess(status.error_code)) { case ErrorPageProcess::kCurrentProcess: @@ -3953,14 +3972,6 @@ } } - is_mhtml_or_subframe_ = false; - sandbox_flags_to_commit_.reset(); - // TODO(https://crbug.com/1158370): Apparently, error pages inherit sandbox - // flags from their parent/opener. Document loaded from the network - // shouldn't have any influence over Chrome's internal error page. We should - // define our own flags, preferably the strictest ones instead. - ComputePoliciesToCommitForError(); - // On failed navigations, the redirect chain should only contain the last URL. redirect_chain_.clear(); redirect_chain_.push_back(GetURL());
diff --git a/content/browser/renderer_host/policy_container_navigation_bundle.cc b/content/browser/renderer_host/policy_container_navigation_bundle.cc index d8e649db..7fb62e4 100644 --- a/content/browser/renderer_host/policy_container_navigation_bundle.cc +++ b/content/browser/renderer_host/policy_container_navigation_bundle.cc
@@ -160,15 +160,6 @@ // crbug.com/1180140. policies->ip_address_space = delivered_policies_->ip_address_space; - // TODO(https://crbug.com/1153648) This keeps the existing behavior which is - // to keep the last value stored in cross_origin_opener_policy_status for the - // error page. This will be the previous document COOP value or the last - // redirect. This should be changed to a default value to be decided, for that - // this will need to be executed before determining the render frame host to - // use for the error. - policies->cross_origin_opener_policy = - delivered_policies_->cross_origin_opener_policy; - SetFinalPolicies(std::move(policies)); DCHECK(HasComputedPolicies());
diff --git a/content/browser/webrtc/webrtc_browsertest.cc b/content/browser/webrtc/webrtc_browsertest.cc index 20e9843..ad0347c 100644 --- a/content/browser/webrtc/webrtc_browsertest.cc +++ b/content/browser/webrtc/webrtc_browsertest.cc
@@ -24,12 +24,18 @@ namespace content { -#if defined(OS_ANDROID) && defined(ADDRESS_SANITIZER) +#if defined(OS_ANDROID) +#if defined(ADDRESS_SANITIZER) // Renderer crashes under Android ASAN: https://crbug.com/408496. #define MAYBE_WebRtcBrowserTest DISABLED_WebRtcBrowserTest #else +// WebRtcBrowserTest.CanSetupVideoCallWith16To9AspectRatio fails consistently +// on android +#define MAYBE_WebRtcBrowserTest DISABLED_WebRtcBrowserTest +#endif // defined(ADDRESS_SANITIZER) +#else #define MAYBE_WebRtcBrowserTest WebRtcBrowserTest -#endif +#endif // defined(OS_ANDROID) // This class tests the scenario when permission to access mic or camera is // granted.
diff --git a/content/common/content_navigation_policy.cc b/content/common/content_navigation_policy.cc index 56f6174..0d5c2fd 100644 --- a/content/common/content_navigation_policy.cc +++ b/content/common/content_navigation_policy.cc
@@ -70,9 +70,19 @@ bool IsSameSiteBackForwardCacheEnabled() { if (!IsBackForwardCacheEnabled()) return false; + + // Same-site back-forward cache is enabled through kBackForwardCache's + // "enable_same_site" param. static constexpr base::FeatureParam<bool> enable_same_site_back_forward_cache( &features::kBackForwardCache, "enable_same_site", false); - return enable_same_site_back_forward_cache.Get(); + if (enable_same_site_back_forward_cache.Get()) + return true; + + // Additionally, same-site back-forward cache might be enabled through the + // BackForwardCacheSameSiteForBots feature flag (only by trybots) due to + // https://crbug.com/1211818. + return base::FeatureList::IsEnabled( + features::kBackForwardCacheSameSiteForBots); } bool ShouldSkipSameSiteBackForwardCacheForPageWithUnload() {
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityTest.java b/content/public/android/javatests/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityTest.java index c199dc9..71e925f 100644 --- a/content/public/android/javatests/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityTest.java +++ b/content/public/android/javatests/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityTest.java
@@ -29,6 +29,7 @@ import android.annotation.SuppressLint; import android.annotation.TargetApi; +import android.graphics.Rect; import android.graphics.RectF; import android.os.Build; import android.os.Bundle; @@ -100,6 +101,8 @@ "Conversion of event masks to event types not correct."; private static final String TEXT_SELECTION_AND_TRAVERSAL_ERROR = "Expected to receive both a traversal and selection text event"; + private static final String BOUNDING_BOX_ERROR = + "Expected bounding box to change after web contents was resized."; // Constant values for unit tests private static final int UNSUPPRESSED_EXPECTED_COUNT = 25; @@ -1366,6 +1369,47 @@ Assert.assertEquals(EVENT_TYPE_MASK_ERROR, expected_test, outcome_test); } + /** + * Test that changing the window size properly updates bounding boxes. + */ + @Test + @SmallTest + public void testBoundingBoxUpdatesOnWindowResize() { + // Build a simple web page with a flex and a will-change: transform button. + setupTestWithHTML("<div style=\"display: flex; min-height: 90vh;\">\n" + + " <div style=\"display: flex; flex-grow: 1; align-items: flex-end;\">\n" + + " <div>\n" + + " <button style=\"display: inline-flex; will-change: transform;\">\n" + + " Next\n" + + " </button>\n" + + " </div>\n" + + " </div>\n" + + "</div>"); + + // Find the button and get the current bounding box. + int buttonvvId = waitForNodeMatching(sClassNameMatcher, "android.widget.Button"); + mNodeInfo = createAccessibilityNodeInfo(buttonvvId); + Assert.assertNotNull(NODE_TIMEOUT_ERROR, mNodeInfo); + Assert.assertEquals(NODE_TIMEOUT_ERROR, "Next", mNodeInfo.getText()); + + Rect beforeBounds = new Rect(); + mNodeInfo.getBoundsInScreen(beforeBounds); + + // Resize the web contents. + TestThreadUtils.runOnUiThreadBlocking( + () -> mActivityTestRule.getWebContents().setSize(1080, beforeBounds.top / 3)); + + // Send end of test signal. + mActivityTestRule.sendEndOfTestSignal(); + + // Fetch the bounding box again and assert top has shrunk by at least half. + mNodeInfo = createAccessibilityNodeInfo(buttonvvId); + Rect afterBounds = new Rect(); + mNodeInfo.getBoundsInScreen(afterBounds); + + Assert.assertTrue(BOUNDING_BOX_ERROR, afterBounds.top < (beforeBounds.top / 2)); + } + @MinAndroidSdkLevel(Build.VERSION_CODES.M) private void assertActionsContainNoScrolls(AccessibilityNodeInfo nodeInfo) { Assert.assertFalse(nodeInfo.getActionList().contains(ACTION_SCROLL_FORWARD));
diff --git a/content/public/browser/back_forward_cache.h b/content/public/browser/back_forward_cache.h index 32f7697..bfb018f5 100644 --- a/content/public/browser/back_forward_cache.h +++ b/content/public/browser/back_forward_cache.h
@@ -32,6 +32,8 @@ public: // Returns true if BackForwardCache is enabled. static bool IsBackForwardCacheFeatureEnabled(); + // Returns true if BackForwardCache is enabled for same-site navigations. + static bool IsSameSiteBackForwardCacheFeatureEnabled(); // Back/forward cache can be disabled from within content and also from // embedders. This means we cannot have a unified enum that covers reasons
diff --git a/content/public/browser/web_contents_receiver_set.h b/content/public/browser/web_contents_receiver_set.h index c7d806b..725e64c 100644 --- a/content/public/browser/web_contents_receiver_set.h +++ b/content/public/browser/web_contents_receiver_set.h
@@ -23,7 +23,6 @@ class LiteVideoObserver; class OfflinePageTabHelper; class PluginObserver; -class SearchEngineTabHelper; class SupervisedUserNavigationObserver; class SyncEncryptionKeysTabHelper; @@ -127,7 +126,6 @@ friend class ::EmbeddedSearchClientFactoryImpl; friend class ::LiteVideoObserver; friend class ::PluginObserver; - friend class ::SearchEngineTabHelper; friend class ::SupervisedUserNavigationObserver; friend class ::SyncEncryptionKeysTabHelper; friend class ::android_webview::AwRenderViewHostExt;
diff --git a/content/public/common/content_features.cc b/content/public/common/content_features.cc index 611951d..3752d74 100644 --- a/content/public/common/content_features.cc +++ b/content/public/common/content_features.cc
@@ -86,6 +86,12 @@ base::FEATURE_DISABLED_BY_DEFAULT}; #endif +// Enable same-site back-forward cache for trybots. This is here because of +// https://crbug.com/1211818 and should only used for trybots. For normal use +// cases, please set BackForwardCache's enable_same_site param to true. +const base::Feature kBackForwardCacheSameSiteForBots{ + "BackForwardCacheSameSiteForBots", base::FEATURE_DISABLED_BY_DEFAULT}; + // BackForwardCache is disabled on low memory devices. The threshold is defined // via a field trial param: "memory_threshold_for_back_forward_cache_in_mb" // It is compared against base::SysInfo::AmountOfPhysicalMemoryMB().
diff --git a/content/public/common/content_features.h b/content/public/common/content_features.h index 4555b52..d569e91c 100644 --- a/content/public/common/content_features.h +++ b/content/public/common/content_features.h
@@ -29,6 +29,7 @@ CONTENT_EXPORT extern const base::Feature kAudioServiceSandbox; CONTENT_EXPORT extern const base::Feature kBackgroundFetch; CONTENT_EXPORT extern const base::Feature kBackForwardCache; +CONTENT_EXPORT extern const base::Feature kBackForwardCacheSameSiteForBots; CONTENT_EXPORT extern const base::Feature kBackForwardCacheMemoryControls; CONTENT_EXPORT extern const base::Feature kBlockCredentialedSubresources; CONTENT_EXPORT extern const base::Feature kBlockInsecurePrivateNetworkRequests;
diff --git a/content/public/test/accessibility_notification_waiter.cc b/content/public/test/accessibility_notification_waiter.cc index e0c437a5..2a3aa29 100644 --- a/content/public/test/accessibility_notification_waiter.cc +++ b/content/public/test/accessibility_notification_waiter.cc
@@ -106,6 +106,11 @@ BindOnAccessibilityEvent(frame_host); if (generated_event_to_wait_for_) BindOnGeneratedEvent(frame_host); + + if (event_to_wait_for_ == ax::mojom::Event::kNone || + event_to_wait_for_ == ax::mojom::Event::kLocationChanged) { + BindOnLocationsChanged(frame_host); + } } void AccessibilityNotificationWaiter::WaitForNotification() { @@ -170,6 +175,15 @@ } } +void AccessibilityNotificationWaiter::BindOnLocationsChanged( + RenderFrameHostImpl* frame_host) { + if (auto* manager = frame_host->browser_accessibility_manager()) { + manager->SetLocationChangeCallbackForTesting(base::BindRepeating( + &AccessibilityNotificationWaiter::OnLocationsChanged, + weak_factory_.GetWeakPtr())); + } +} + void AccessibilityNotificationWaiter::OnGeneratedEvent( BrowserAccessibilityDelegate* delegate, ui::AXEventGenerator::Event event, @@ -184,6 +198,13 @@ } } +void AccessibilityNotificationWaiter::OnLocationsChanged() { + if (IsAboutBlank()) + return; + + loop_runner_quit_closure_.Run(); +} + // TODO(982776): Remove this method once we migrate to using AXEventGenerator // for focus changed events. void AccessibilityNotificationWaiter::OnFocusChanged() {
diff --git a/content/public/test/accessibility_notification_waiter.h b/content/public/test/accessibility_notification_waiter.h index 25669a09..2aa24aa 100644 --- a/content/public/test/accessibility_notification_waiter.h +++ b/content/public/test/accessibility_notification_waiter.h
@@ -82,12 +82,15 @@ // for a given frame within the WebContent's frame tree. void ListenToFrame(RenderFrameHostImpl* frame_host); - // Helper to bind the OnAccessibilityEvent callback + // Helper to bind the OnAccessibilityEvent callback. void BindOnAccessibilityEvent(RenderFrameHostImpl* frame_host); - // Helper to bind the OnGeneratedEvent callback + // Helper to bind the OnGeneratedEvent callback. void BindOnGeneratedEvent(RenderFrameHostImpl* frame_host); + // Helper to bind the OnLocationsChanged callback. + void BindOnLocationsChanged(RenderFrameHostImpl* frame_host); + // Callback from RenderViewHostImpl. void OnAccessibilityEvent(RenderFrameHostImpl* rfhi, ax::mojom::Event event, @@ -98,6 +101,10 @@ ui::AXEventGenerator::Event event, int event_target_id); + // Callback from BrowserAccessibilityManager when locations / bounding + // boxes change. + void OnLocationsChanged(); + // Callback from BrowserAccessibilityManager for the focus changed event. // // TODO(982776): Remove this method once we migrate to using AXEventGenerator
diff --git a/content/renderer/pepper/pepper_plugin_instance_impl.cc b/content/renderer/pepper/pepper_plugin_instance_impl.cc index b5f55de72..221e05f 100644 --- a/content/renderer/pepper/pepper_plugin_instance_impl.cc +++ b/content/renderer/pepper/pepper_plugin_instance_impl.cc
@@ -2319,11 +2319,8 @@ blink::WebScriptSource script( blink::WebString::FromUTF8(script_string.c_str())); v8::Local<v8::Value> result; - if (HasTransientUserActivation()) { - result = frame->ExecuteScriptAndReturnValue(script); - } else { - result = frame->ExecuteScriptAndReturnValue(script); - } + + result = frame->ExecuteScriptAndReturnValue(script); ScopedPPVar var_result = try_catch.FromV8(result); if (try_catch.HasException())
diff --git a/content/shell/browser/shell_content_browser_client.cc b/content/shell/browser/shell_content_browser_client.cc index 2a7fff7..1eb3cf4 100644 --- a/content/shell/browser/shell_content_browser_client.cc +++ b/content/shell/browser/shell_content_browser_client.cc
@@ -194,7 +194,7 @@ std::string GetShellUserAgent() { std::string product = "Chrome/" CONTENT_SHELL_VERSION; base::CommandLine* command_line = base::CommandLine::ForCurrentProcess(); - if (base::FeatureList::IsEnabled(blink::features::kFreezeUserAgent)) { + if (base::FeatureList::IsEnabled(blink::features::kReduceUserAgent)) { return content::GetReducedUserAgent( command_line->HasSwitch(switches::kUseMobileUserAgent), CONTENT_SHELL_MAJOR_VERSION);
diff --git a/content/test/content_browser_test_utils_internal.cc b/content/test/content_browser_test_utils_internal.cc index a1c6a66..621451f 100644 --- a/content/test/content_browser_test_utils_internal.cc +++ b/content/test/content_browser_test_utils_internal.cc
@@ -886,7 +886,7 @@ for (RenderFrameHost* rfh : CollectAllRenderFrameHosts(web_contents())) { // Keep track of all currently inactive RenderFrameHosts so that we can wait // for all of them to be deleted. - if (!rfh->IsActive()) + if (!rfh->IsActive() && rfh->IsRenderFrameLive()) inactive_rfhs_.insert(rfh); } loop_ = std::make_unique<base::RunLoop>();
diff --git a/content/test/data/accessibility/mac/selection/set-selection-contenteditable-expected-mac.txt b/content/test/data/accessibility/mac/selection/set-selection-contenteditable-expected-mac.txt new file mode 100644 index 0000000..5f26ec90 --- /dev/null +++ b/content/test/data/accessibility/mac/selection/set-selection-contenteditable-expected-mac.txt
@@ -0,0 +1,39 @@ +text_range={anchor: {:2, 0, down}, focus: {:2, 45, down}} +marker_0={:2, 0, down} +marker_1={:2, 3, down} +target_selected_marker_range={anchor: {:2, 0, down}, focus: {:2, 3, down}} +AXSelectedTextChanged on AXTextArea AXValue="The quick brown foxes jumps over the lazy dog" AXTextSelectionDirection=AXTextSelectionDirectionUnknown AXTextSelectionGranularity=AXTextSelectionGranularityUnknown AXTextStateChangeType=AXTextStateChangeTypeSelectionMove +ce1.AXSelectedText='The' +text=:4 +text.AXValue='The quick brown foxes ' +text_range={anchor: {:4, 0, down}, focus: {:4, 22, down}} +marker_0={:4, 0, down} +marker_1={:4, 3, down} +marker_2={:4, 9, down} +marker_3={:4, 4, down} +target_selected_marker_range={anchor: {:4, 4, down}, focus: {:4, 9, down}} +AXSelectedTextChanged on AXTextArea AXValue="The quick brown foxes jumps over the lazy dog" AXTextSelectionDirection=AXTextSelectionDirectionUnknown AXTextSelectionGranularity=AXTextSelectionGranularityUnknown AXTextStateChangeType=AXTextStateChangeTypeUnknown +ce1.AXSelectedText='quick' +text=:8 +text.AXValue='lazy' +text_range={anchor: {:8, 0, down}, focus: {:8, 4, down}} +marker_0={:8, 0, down} +marker_1={:8, 4, down} +marker_2={:8, 3, down} +target_selected_marker_range={anchor: {:8, 0, down}, focus: {:8, 3, down}} +AXSelectedTextChanged on AXTextArea AXValue="The quick brown foxes jumps over the lazy dog" AXTextSelectionDirection=AXTextSelectionDirectionUnknown AXTextSelectionGranularity=AXTextSelectionGranularityUnknown AXTextStateChangeType=AXTextStateChangeTypeUnknown +ce1.AXSelectedText='laz' +text=:6 +text.AXValue='jumps' +text_range={anchor: {:6, 0, down}, focus: {:6, 5, down}} +AXSelectedTextChanged on AXTextArea AXValue="The quick brown foxes jumps over the lazy dog" AXTextSelectionDirection=AXTextSelectionDirectionUnknown AXTextSelectionGranularity=AXTextSelectionGranularityUnknown AXTextStateChangeType=AXTextStateChangeTypeUnknown +ce1.AXSelectedText='jumps' +text=:14 +text.AXValue='with five dozen liquor jugs.' +text_range={anchor: {:14, 0, down}, focus: {:14, 28, down}} +marker_0={:14, 0, down} +marker_1={:14, 4, down} +target_selected_marker_range={anchor: {:14, 0, down}, focus: {:14, 4, down}} +AXSelectedTextChanged on AXTextArea AXValue="Pack my box +with five dozen liquor jugs." AXTextSelectionDirection=AXTextSelectionDirectionUnknown AXTextSelectionGranularity=AXTextSelectionGranularityUnknown AXTextStateChangeType=AXTextStateChangeTypeSelectionMove +ce2.AXSelectedText='with'
diff --git a/content/test/data/accessibility/mac/selection/set-selection-contenteditable.html b/content/test/data/accessibility/mac/selection/set-selection-contenteditable.html new file mode 100644 index 0000000..3e55998 --- /dev/null +++ b/content/test/data/accessibility/mac/selection/set-selection-contenteditable.html
@@ -0,0 +1,70 @@ +<!-- +@MAC-SCRIPT: + // Select the 1st word via text marker associated with container AXTextArea. + text_range:= ce1.AXTextMarkerRangeForUIElement(ce1) + marker_0:= text_range.anchor + marker_1:= ce1.AXNextWordEndTextMarkerForTextMarker(marker_0) + target_selected_marker_range:= ce1.AXTextMarkerRangeForUnorderedTextMarkers([marker_0, marker_1]) + ce1.AXSelectedTextMarkerRange = target_selected_marker_range + wait for AXSelectedTextChanged on AXTextArea + ce1.AXSelectedText + +@MAC-SCRIPT: + // Select the 2nd word via the marker associated with AXStaticText. + text:= ce1.AXChildren[0].AXChildren[0] + text.AXValue + text_range:= text.AXTextMarkerRangeForUIElement(text) + marker_0:= text_range.anchor + marker_1:= text.AXNextWordEndTextMarkerForTextMarker(marker_0) + marker_2:= text.AXNextWordEndTextMarkerForTextMarker(marker_1) + marker_3:= text.AXPreviousWordStartTextMarkerForTextMarker(marker_2) + target_selected_marker_range:= text.AXTextMarkerRangeForUnorderedTextMarkers([marker_2, marker_3]) + ce1.AXSelectedTextMarkerRange = target_selected_marker_range + wait for AXSelectedTextChanged on AXTextArea + ce1.AXSelectedText + +@MAC-SCRIPT: + // Select text inside a span. + text:= ce1.AXChildren[0].AXChildren[3] + text.AXValue + text_range:= text.AXTextMarkerRangeForUIElement(text) + marker_0:= text_range.anchor + marker_1:= text_range.focus + marker_2:= text.AXPreviousTextMarkerForTextMarker(marker_1) + target_selected_marker_range:= text.AXTextMarkerRangeForUnorderedTextMarkers([marker_0, marker_2]) + ce1.AXSelectedTextMarkerRange = target_selected_marker_range + wait for AXSelectedTextChanged on AXTextArea + ce1.AXSelectedText + +@MAC-SCRIPT: + // Select the text inside the block with incorrect grammar. + text:= ce1.AXChildren[0].AXChildren[1].AXChildren[0] + text.AXValue + text_range:= text.AXTextMarkerRangeForUIElement(text) + ce1.AXSelectedTextMarkerRange = text_range + wait for AXSelectedTextChanged on AXTextArea + ce1.AXSelectedText + +@MAC-SCRIPT: + // Select the text after a forced break. + text:= ce2.AXChildren[0].AXChildren[2] + text.AXValue + text_range:= text.AXTextMarkerRangeForUIElement(text) + marker_0:= text_range.anchor + marker_1:= text.AXNextWordEndTextMarkerForTextMarker(marker_0) + target_selected_marker_range:= text.AXTextMarkerRangeForUnorderedTextMarkers([marker_0, marker_1]) + ce2.AXSelectedTextMarkerRange = target_selected_marker_range + wait for AXSelectedTextChanged on AXTextArea + ce2.AXSelectedText +--> +<!DOCTYPE html> +<html> +<body> + <div id="ce1" contenteditable="true"> + <p>The quick brown foxes <span aria-invalid="grammar">jumps</span> over the <em>lazy</em> dog</p> + </div> + <div id="ce2" contenteditable="true"> + <p><span>Pack my box</span><br><span>with five dozen liquor jugs.</span></p> + </div> +</body> +</html>
diff --git a/content/test/data/accessibility/scripts/set-selection-contenteditable-expected-mac.txt b/content/test/data/accessibility/scripts/set-selection-contenteditable-expected-mac.txt deleted file mode 100644 index 7725b8f..0000000 --- a/content/test/data/accessibility/scripts/set-selection-contenteditable-expected-mac.txt +++ /dev/null
@@ -1,19 +0,0 @@ -AXWebArea -++AXTextArea AXValue='The quick brown foxes jumps over the lazy dog' -++++AXGroup -++++++AXStaticText AXValue='The quick brown foxes ' -++++++AXGroup -++++++++AXStaticText AXValue='jumps' -++++++AXStaticText AXValue=' over the ' -++++++AXStaticText AXValue='lazy' -++++++AXStaticText AXValue=' dog' -++AXTextArea AXValue='Pack my box<newline>with five dozen liquor jugs.' -++++AXGroup -++++++AXStaticText AXValue='Pack my box' -++++++AXGroup AXTitle='<newline>' -++++++AXStaticText AXValue='with five dozen liquor jugs.' -The -quick -laz -jumps -with
diff --git a/content/test/data/accessibility/scripts/set-selection-contenteditable.html b/content/test/data/accessibility/scripts/set-selection-contenteditable.html deleted file mode 100644 index dc20784..0000000 --- a/content/test/data/accessibility/scripts/set-selection-contenteditable.html +++ /dev/null
@@ -1,11 +0,0 @@ -<!DOCTYPE html> -<html> -<body> - <div contenteditable="true"> - <p>The quick brown foxes <span aria-invalid="grammar">jumps</span> over the <em>lazy</em> dog</p> - </div> - <div contenteditable="true"> - <p><span>Pack my box</span><br><span>with five dozen liquor jugs.</span></p> - </div> -</body> -</html> \ No newline at end of file
diff --git a/device/bluetooth/chromeos/OWNERS b/device/bluetooth/chromeos/OWNERS index c231301..d84943c 100644 --- a/device/bluetooth/chromeos/OWNERS +++ b/device/bluetooth/chromeos/OWNERS
@@ -1 +1,2 @@ hansberry@chromium.org +khorimoto@chromium.org
diff --git a/docs/threading_and_tasks.md b/docs/threading_and_tasks.md index 2e8ee16..ebe88fbc 100644 --- a/docs/threading_and_tasks.md +++ b/docs/threading_and_tasks.md
@@ -20,8 +20,8 @@ live on only one (often virtual -- we'll get to that later!) thread and we pass messages between those threads for communication. Absent external requirements about latency or workload, Chrome attempts to be a [highly concurrent, but not -necessarily parallel](https://stackoverflow.com/questions/1050222/what-is-the-difference-between-concurrency-and-parallelism#:~:text=Concurrency%20is%20when%20two%20or,e.g.%2C%20on%20a%20multicore%20processor.) -, system. +necessarily parallel](https://stackoverflow.com/questions/1050222/what-is-the-difference-between-concurrency-and-parallelism#:~:text=Concurrency%20is%20when%20two%20or,e.g.%2C%20on%20a%20multicore%20processor.), +system. This documentation assumes familiarity with computer science [threading concepts](https://en.wikipedia.org/wiki/Thread_(computing)). @@ -261,7 +261,7 @@ FROM_HERE, base::BindOnce(&Task); ``` -Note that SequencedTaskRunnerHandle::Get() returns the default queue for the +Note that `SequencedTaskRunnerHandle::Get()` returns the default queue for the current virtual thread. On threads with multiple task queues (e.g. BrowserThread::UI) this can be a different queue than the one the current task belongs to. The "current" task runner is intentionally not exposed via a static @@ -678,7 +678,7 @@ other work. This yield-semantic allows, for example, a user-visible job to use all cores but get out of the way when a user-blocking task comes in. -### Adding additional work to a running job. +### Adding additional work to a running job When new work items are added and the API user wants additional threads to invoke the worker task in parallel, @@ -773,7 +773,7 @@ // This initializes and starts ThreadPoolInstance with default params. base::ThreadPoolInstance::CreateAndStartWithDefaultParams(“process_name”); // The base/task/post_task.h API can now be used with base::ThreadPool trait. -// Tasks will be // scheduled as they are posted. +// Tasks will be scheduled as they are posted. // This initializes ThreadPoolInstance. base::ThreadPoolInstance::Create(“process_name”); @@ -798,7 +798,7 @@ ## TaskRunner ownership (encourage no dependency injection) TaskRunners shouldn't be passed through several components. Instead, the -components that uses a TaskRunner should be the one that creates it. +component that uses a TaskRunner should be the one that creates it. See [this example](https://codereview.chromium.org/2885173002/) of a refactoring where a TaskRunner was passed through a lot of components only to be @@ -870,7 +870,7 @@ ### RunLoop -RunLoop is s helper class to run the RunLoop::Delegate associated with the +RunLoop is a helper class to run the RunLoop::Delegate associated with the current thread (usually a SequenceManager). Create a RunLoop on the stack and call Run/Quit to run a nested RunLoop but please avoid nested loops in production code! @@ -928,6 +928,7 @@ You might come across references to MessageLoop or MessageLoopCurrent in the code or documentation. These classes no longer exist and we are in the process -or getting rid of all references to them. base::MessageLoopCurrent was replaced -by base::CurrentThread and the drop in replacements for base::MessageLoop are -base::SingleThreadTaskExecutor and base::Test::TaskEnvironment. +or getting rid of all references to them. `base::MessageLoopCurrent` was +replaced by `base::CurrentThread` and the drop in replacements for +`base::MessageLoop` are `base::SingleThreadTaskExecutor` and +`base::Test::TaskEnvironment`.
diff --git a/docs/threading_and_tasks_faq.md b/docs/threading_and_tasks_faq.md index ea5eef4..e534361 100644 --- a/docs/threading_and_tasks_faq.md +++ b/docs/threading_and_tasks_faq.md
@@ -21,14 +21,14 @@ * If the task is posted through a `SingleThreadTaskRunner` obtained from `CreateSingleThreadTaskRunner(..., mode)`: * Where `mode` is `SingleThreadTaskRunnerThreadMode::DEDICATED`: - * The task runs on a thread that only runs tasks from that - SingleThreadTaskRunner. This is not the main thread nor the IO - thread. + * The task runs on a thread that only runs tasks from that + SingleThreadTaskRunner. This is not the main thread nor the IO + thread. * Where `mode` is `SingleThreadTaskRunnerThreadMode::SHARED`: - * The task runs on a thread that runs tasks from one or many - unrelated SingleThreadTaskRunners. This is not the main thread - nor the IO thread. + * The task runs on a thread that runs tasks from one or many + unrelated SingleThreadTaskRunners. This is not the main thread nor + the IO thread. * Otherwise: * The task runs in a thread pool. @@ -85,7 +85,7 @@ returns). [base/threading/scoped_blocking_call.h](https://cs.chromium.org/chromium/src/base/threading/scoped_blocking_call.h) -explains the difference between `MAY_BLOCK ` and `WILL_BLOCK` and gives +explains the difference between `MAY_BLOCK` and `WILL_BLOCK` and gives examples of blocking operations. ### How to make a blocking call that may never return without preventing other tasks from being scheduled? @@ -104,15 +104,15 @@ ### Do calls to blocking //base APIs need to be annotated with ScopedBlockingCall? -No. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read, -base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their -own internal annotations. See +No. All blocking //base APIs (e.g. `base::ReadFileToString`, `base::File::Read`, +`base::SysInfo::AmountOfFreeDiskSpace`, `base::WaitableEvent::Wait`, etc.) have +their own internal annotations. See [base/threading/scoped_blocking_call.h](https://cs.chromium.org/chromium/src/base/threading/scoped_blocking_call.h). ### Can multiple ScopedBlockingCall be nested for the purpose of documentation? Nested `ScopedBlockingCall` are supported. Most of the time, the inner -ScopedBlockingCalls will no-op (the exception is WILL_BLOCK nested in MAY_BLOCK). +ScopedBlockingCalls will no-op (the exception is `WILL_BLOCK` nested in `MAY_BLOCK`). As such, it is permitted to add a ScopedBlockingCall in the scope where a function that is already annotated is called for documentation purposes.:
diff --git a/docs/trusted_types_on_webui.md b/docs/trusted_types_on_webui.md index 33e0eb5..21dfcb6f 100644 --- a/docs/trusted_types_on_webui.md +++ b/docs/trusted_types_on_webui.md
@@ -206,15 +206,13 @@ ## How to add a test for Trusted Types on a WebUI page? -You can add your WebUI page to [this list] -(https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/webui/chrome_url_data_manager_browsertest.cc;l=194;drc=de8ade0753244ff6d1ef20cb2a38fe292fe9ba0a) and it will check for -Trusted Types violations on your WebUI page. +You can add your WebUI page to [this list][browsertest-list] and it will check +for Trusted Types violations on your WebUI page. + +[browsertest-list]: https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/webui/chrome_url_data_manager_browsertest.cc;l=194;drc=de8ade0753244ff6d1ef20cb2a38fe292fe9ba0a ## Sample CLs -1. [Remove innerHTML usage in chrome://interstitials] -(https://chromium-review.googlesource.com/c/chromium/src/+/2245937) -2. [Trusted Type various WebUI] -(https://chromium-review.googlesource.com/c/chromium/src/+/2236992) -3. [Trusted Type WebRTC internals] -(https://chromium-review.googlesource.com/c/chromium/src/+/2208950) \ No newline at end of file +1. [Remove innerHTML usage in chrome://interstitials](https://crrev.com/c/2245937) +2. [Trusted Type various WebUI](https://crrev.com/c/2236992) +3. [Trusted Type WebRTC internals](https://crrev.com/c/2208950)
diff --git a/extensions/browser/BUILD.gn b/extensions/browser/BUILD.gn index 11f44309..bcc88982 100644 --- a/extensions/browser/BUILD.gn +++ b/extensions/browser/BUILD.gn
@@ -215,6 +215,8 @@ "blob_reader.cc", "blob_reader.h", "blocked_action_type.h", + "blocklist_extension_prefs.cc", + "blocklist_extension_prefs.h", "blocklist_state.h", "browser_context_keyed_api_factory.h", "component_extension_resource_manager.h",
diff --git a/chrome/browser/extensions/blocklist_extension_prefs.cc b/extensions/browser/blocklist_extension_prefs.cc similarity index 98% rename from chrome/browser/extensions/blocklist_extension_prefs.cc rename to extensions/browser/blocklist_extension_prefs.cc index 5fa502d..587fef6 100644 --- a/chrome/browser/extensions/blocklist_extension_prefs.cc +++ b/extensions/browser/blocklist_extension_prefs.cc
@@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "chrome/browser/extensions/blocklist_extension_prefs.h" +#include "extensions/browser/blocklist_extension_prefs.h" #include "extensions/browser/blocklist_state.h" #include "extensions/browser/extension_prefs.h"
diff --git a/chrome/browser/extensions/blocklist_extension_prefs.h b/extensions/browser/blocklist_extension_prefs.h similarity index 93% rename from chrome/browser/extensions/blocklist_extension_prefs.h rename to extensions/browser/blocklist_extension_prefs.h index 6fcceac..5ebcfd9 100644 --- a/chrome/browser/extensions/blocklist_extension_prefs.h +++ b/extensions/browser/blocklist_extension_prefs.h
@@ -2,12 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef CHROME_BROWSER_EXTENSIONS_BLOCKLIST_EXTENSION_PREFS_H_ -#define CHROME_BROWSER_EXTENSIONS_BLOCKLIST_EXTENSION_PREFS_H_ +#ifndef EXTENSIONS_BROWSER_BLOCKLIST_EXTENSION_PREFS_H_ +#define EXTENSIONS_BROWSER_BLOCKLIST_EXTENSION_PREFS_H_ #include <string> -#include "chrome/browser/extensions/blocklist.h" #include "extensions/browser/blocklist_state.h" namespace extensions { @@ -75,4 +74,4 @@ } // namespace blocklist_prefs } // namespace extensions -#endif // CHROME_BROWSER_EXTENSIONS_BLOCKLIST_EXTENSION_PREFS_H_ +#endif // EXTENSIONS_BROWSER_BLOCKLIST_EXTENSION_PREFS_H_
diff --git a/extensions/browser/quota_service.cc b/extensions/browser/quota_service.cc index 0b0a2306..8f6a3705 100644 --- a/extensions/browser/quota_service.cc +++ b/extensions/browser/quota_service.cc
@@ -40,7 +40,7 @@ std::string QuotaService::Assess(const std::string& extension_id, ExtensionFunction* function, - const base::ListValue* args, + const base::Value* args, const base::TimeTicks& event_time) { DCHECK_CALLED_ON_VALID_THREAD(thread_checker_); @@ -100,7 +100,7 @@ } void QuotaLimitHeuristic::SingletonBucketMapper::GetBucketsForArgs( - const base::ListValue* args, + const base::Value* args, BucketList* buckets) { buckets->push_back(&bucket_); } @@ -112,7 +112,7 @@ QuotaLimitHeuristic::~QuotaLimitHeuristic() {} -bool QuotaLimitHeuristic::ApplyToArgs(const base::ListValue* args, +bool QuotaLimitHeuristic::ApplyToArgs(const base::Value* args, const base::TimeTicks& event_time) { BucketList buckets; bucket_mapper_->GetBucketsForArgs(args, &buckets);
diff --git a/extensions/browser/quota_service.h b/extensions/browser/quota_service.h index 0916f50..613e8ea 100644 --- a/extensions/browser/quota_service.h +++ b/extensions/browser/quota_service.h
@@ -55,9 +55,10 @@ // extension specified by |extension_id| results in a quota limit violation. // Returns an error message representing the failure if quota was exceeded, // or empty-string if the request is fine and can proceed. + // |args| must be a list. std::string Assess(const std::string& extension_id, ExtensionFunction* function, - const base::ListValue* args, + const base::Value* args, const base::TimeTicks& event_time); // An active ScopedDisablePurgeForTesting prevents QuotaService's constructor @@ -155,7 +156,8 @@ // occurs while parsing |args|, the function aborts - buckets may be non- // empty). The expectation is that invalid args and associated errors are // handled by the ExtensionFunction itself so we don't concern ourselves. - virtual void GetBucketsForArgs(const base::ListValue* args, + // |args| must be a list. + virtual void GetBucketsForArgs(const base::Value* args, BucketList* buckets) = 0; }; @@ -165,7 +167,7 @@ public: SingletonBucketMapper() {} ~SingletonBucketMapper() override {} - void GetBucketsForArgs(const base::ListValue* args, + void GetBucketsForArgs(const base::Value* args, BucketList* buckets) override; private: @@ -182,8 +184,8 @@ // implementation of a derived class) to perform an operation with |args|, // based on the history of similar operations with similar arguments (which // is retrieved using the BucketMapper). - bool ApplyToArgs(const base::ListValue* args, - const base::TimeTicks& event_time); + // |args| must be a list. + bool ApplyToArgs(const base::Value* args, const base::TimeTicks& event_time); // Returns an error formatted according to this heuristic. std::string GetError() const;
diff --git a/extensions/browser/quota_service_unittest.cc b/extensions/browser/quota_service_unittest.cc index 5ff6d43..c7bacaf 100644 --- a/extensions/browser/quota_service_unittest.cc +++ b/extensions/browser/quota_service_unittest.cc
@@ -38,14 +38,15 @@ public: Mapper() {} ~Mapper() override {} - void GetBucketsForArgs(const base::ListValue* args, + void GetBucketsForArgs(const base::Value* args, BucketList* buckets) override { - for (size_t i = 0; i < args->GetSize(); i++) { - int id; - ASSERT_TRUE(args->GetInteger(i, &id)); - if (buckets_.find(id) == buckets_.end()) - buckets_[id] = std::make_unique<Bucket>(); - buckets->push_back(buckets_[id].get()); + ASSERT_TRUE(args->is_list()); + for (const auto& val : args->GetList()) { + absl::optional<int> id = val.GetIfInt(); + ASSERT_TRUE(id.has_value()); + if (buckets_.find(*id) == buckets_.end()) + buckets_[*id] = std::make_unique<Bucket>(); + buckets->push_back(buckets_[*id].get()); } } @@ -56,7 +57,7 @@ class MockMapper : public QuotaLimitHeuristic::BucketMapper { public: - void GetBucketsForArgs(const base::ListValue* args, + void GetBucketsForArgs(const base::Value* args, BucketList* buckets) override {} }; @@ -163,21 +164,21 @@ TEST_F(QuotaServiceTest, NoHeuristic) { scoped_refptr<MockFunction> f(new MockFunction("foo")); - base::ListValue args; + base::Value args(base::Value::Type::LIST); EXPECT_EQ("", service_->Assess(extension_a_, f.get(), &args, kStartTime)); } TEST_F(QuotaServiceTest, FrozenHeuristic) { scoped_refptr<MockFunction> f(new FrozenMockFunction("foo")); - base::ListValue args; - args.AppendInteger(1); + base::Value args(base::Value::Type::LIST); + args.Append(1); EXPECT_NE("", service_->Assess(extension_a_, f.get(), &args, kStartTime)); } TEST_F(QuotaServiceTest, SingleHeuristic) { scoped_refptr<MockFunction> f(new TimedLimitMockFunction("foo")); - base::ListValue args; - args.AppendInteger(1); + base::Value args(base::Value::Type::LIST); + args.Append(1); EXPECT_EQ("", service_->Assess(extension_a_, f.get(), &args, kStartTime)); EXPECT_EQ("", service_->Assess(extension_a_, @@ -190,9 +191,9 @@ &args, kStartTime + TimeDelta::FromSeconds(15))); - base::ListValue args2; - args2.AppendInteger(1); - args2.AppendInteger(2); + base::Value args2(base::Value::Type::LIST); + args2.Append(1); + args2.Append(2); EXPECT_EQ("", service_->Assess(extension_b_, f.get(), &args2, kStartTime)); EXPECT_EQ("", service_->Assess(extension_b_, @@ -215,8 +216,8 @@ kStartTime + peace + TimeDelta::FromSeconds(15))); // Test that items are independent. - base::ListValue args3; - args3.AppendInteger(3); + base::Value args3(base::Value::Type::LIST); + args3.Append(3); EXPECT_EQ("", service_->Assess(extension_c_, f.get(), &args, kStartTime)); EXPECT_EQ("", service_->Assess(extension_c_, @@ -249,10 +250,10 @@ scoped_refptr<MockFunction> f(new TimedLimitMockFunction("foo")); scoped_refptr<MockFunction> g(new TimedLimitMockFunction("bar")); - base::ListValue args_f; - base::ListValue args_g; - args_f.AppendInteger(1); - args_g.AppendInteger(2); + base::Value args_f(base::Value::Type::LIST); + base::Value args_g(base::Value::Type::LIST); + args_f.Append(1); + args_g.Append(2); EXPECT_EQ("", service_->Assess(extension_a_, f.get(), &args_f, kStartTime)); EXPECT_EQ("", service_->Assess(extension_a_, g.get(), &args_g, kStartTime)); @@ -280,8 +281,8 @@ TEST_F(QuotaServiceTest, ViolatorsWillBeForgiven) { scoped_refptr<MockFunction> f(new TimedLimitMockFunction("foo")); - base::ListValue arg; - arg.AppendInteger(1); + base::Value arg(base::Value::Type::LIST); + arg.Append(1); EXPECT_EQ("", service_->Assess(extension_a_, f.get(), &arg, kStartTime)); EXPECT_EQ("", service_->Assess(extension_a_,
diff --git a/infra/config/generated/cr-buildbucket.cfg b/infra/config/generated/cr-buildbucket.cfg index 053f3a4..5bd983b8 100644 --- a/infra/config/generated/cr-buildbucket.cfg +++ b/infra/config/generated/cr-buildbucket.cfg
@@ -58683,7 +58683,7 @@ name: "angle-try-mac-amd-exp" swarming_host: "chromium-swarm.appspot.com" swarming_tags: "vpython:native-python-wrapper" - dimensions: "builder:angle-try-mac-amd-exp" + dimensions: "builderless:1" dimensions: "cpu:x86-64" dimensions: "os:Mac" dimensions: "pool:luci.chromium.gpu.mac.retina.amd.try" @@ -58695,7 +58695,6 @@ properties: '{' ' "$build/goma": {' - ' "jobs": 150,' ' "rpc_extra_params": "?prod",' ' "server_host": "goma.chromium.org",' ' "use_luci_auth": true' @@ -60661,7 +60660,7 @@ name: "dawn-try-mac-amd-exp" swarming_host: "chromium-swarm.appspot.com" swarming_tags: "vpython:native-python-wrapper" - dimensions: "builder:dawn-try-mac-amd-exp" + dimensions: "builderless:1" dimensions: "cpu:x86-64" dimensions: "os:Mac" dimensions: "pool:luci.chromium.gpu.mac.retina.amd.try"
diff --git a/infra/config/generated/luci-milo.cfg b/infra/config/generated/luci-milo.cfg index b6d93152..2c77969 100644 --- a/infra/config/generated/luci-milo.cfg +++ b/infra/config/generated/luci-milo.cfg
@@ -5153,12 +5153,12 @@ builders { name: "buildbucket/luci.chromium.ci/Dawn Mac x64 Builder" category: "ToT|Mac|Builder" - short_name: "exp" + short_name: "x64" } builders { name: "buildbucket/luci.chromium.ci/Dawn Mac x64 Experimental Release (AMD)" category: "ToT|Mac|AMD" - short_name: "x64" + short_name: "exp" } builders { name: "buildbucket/luci.chromium.ci/Dawn Mac x64 Release (AMD)"
diff --git a/infra/config/lib/try.star b/infra/config/lib/try.star index 15caeaf..9e81d3c 100644 --- a/infra/config/lib/try.star +++ b/infra/config/lib/try.star
@@ -309,6 +309,17 @@ **kwargs ) +def chromium_dawn_builderless_builder(*, name, **kwargs): + return try_builder( + name = name, + builder_group = "tryserver.chromium.dawn", + builderless = True, + cores = None, + goma_backend = builders.goma.backend.RBE_PROD, + service_account = "chromium-try-gpu-builder@chops-service-accounts.iam.gserviceaccount.com", + **kwargs + ) + def chromium_linux_builder(*, name, goma_backend = builders.goma.backend.RBE_PROD, **kwargs): kwargs.setdefault("os", builders.os.LINUX_BIONIC_REMOVE) return try_builder( @@ -563,8 +574,10 @@ chromium_angle_builder = chromium_angle_builder, chromium_angle_ios_builder = chromium_angle_ios_builder, chromium_angle_mac_builder = chromium_angle_mac_builder, + chromium_angle_pinned_builder = chromium_angle_pinned_builder, chromium_chromiumos_builder = chromium_chromiumos_builder, chromium_dawn_builder = chromium_dawn_builder, + chromium_dawn_builderless_builder = chromium_dawn_builderless_builder, chromium_linux_builder = chromium_linux_builder, chromium_mac_builder = chromium_mac_builder, chromium_mac_ios_builder = chromium_mac_ios_builder,
diff --git a/infra/config/subprojects/chromium/ci.star b/infra/config/subprojects/chromium/ci.star index 6c953a8..7fb0aa8 100644 --- a/infra/config/subprojects/chromium/ci.star +++ b/infra/config/subprojects/chromium/ci.star
@@ -2542,7 +2542,7 @@ name = "Dawn Mac x64 Builder", console_view_entry = consoles.console_view_entry( category = "ToT|Mac|Builder", - short_name = "exp", + short_name = "x64", ), ) @@ -2587,7 +2587,7 @@ name = "Dawn Mac x64 Experimental Release (AMD)", console_view_entry = consoles.console_view_entry( category = "ToT|Mac|AMD", - short_name = "x64", + short_name = "exp", ), triggered_by = ["Dawn Mac x64 Builder"], )
diff --git a/infra/config/subprojects/chromium/try.star b/infra/config/subprojects/chromium/try.star index 7908b0d6..a861420 100644 --- a/infra/config/subprojects/chromium/try.star +++ b/infra/config/subprojects/chromium/try.star
@@ -728,12 +728,11 @@ executable = "recipe:angle_chromium_trybot", ) -try_.chromium_angle_builder( +try_.chromium_angle_pinned_builder( name = "angle-try-mac-amd-exp", cores = None, os = os.MAC_ANY, pool = "luci.chromium.gpu.mac.retina.amd.try", - executable = "recipe:angle_chromium_trybot", ) try_.chromium_angle_builder( @@ -989,7 +988,7 @@ os = os.MAC_ANY, ) -try_.chromium_dawn_builder( +try_.chromium_dawn_builderless_builder( name = "dawn-try-mac-amd-exp", os = os.MAC_ANY, pool = "luci.chromium.gpu.mac.retina.amd.try",
diff --git a/ios/chrome/app/strings/ios_strings.grd b/ios/chrome/app/strings/ios_strings.grd index 9666e160..0a4986d 100644 --- a/ios/chrome/app/strings/ios_strings.grd +++ b/ios/chrome/app/strings/ios_strings.grd
@@ -2460,6 +2460,9 @@ <message name="IDS_IOS_SYNC_PASSWORDS_ERROR_TITLE" desc="Title of the error message shown for sync errors when it affects passwords only. [iOS only]"> Password Sync Isn't Working </message> + <message name="IDS_SYNC_NEEDS_VERIFICATION_TITLE" desc="Title of the error message shown when sync needs to verify the user. [iOS only]"> + Sync Needs To Verify It's You + </message> <message name="IDS_IOS_SYNC_SETTINGS_NOT_CONFIRMED" desc="The error message to display when sign-in was interrupted and the user didn't review the sync settings."> Initial sync setup was not finished. Sync is off. </message>
diff --git a/ios/chrome/app/strings/ios_strings_grd/IDS_SYNC_NEEDS_VERIFICATION_TITLE.png.sha1 b/ios/chrome/app/strings/ios_strings_grd/IDS_SYNC_NEEDS_VERIFICATION_TITLE.png.sha1 new file mode 100644 index 0000000..35b12733 --- /dev/null +++ b/ios/chrome/app/strings/ios_strings_grd/IDS_SYNC_NEEDS_VERIFICATION_TITLE.png.sha1
@@ -0,0 +1 @@ +25bb989b18148b9d789e9c643267b1b928dd6b12 \ No newline at end of file
diff --git a/ios/chrome/browser/flags/about_flags.mm b/ios/chrome/browser/flags/about_flags.mm index b10f9a3..7bfbae3 100644 --- a/ios/chrome/browser/flags/about_flags.mm +++ b/ios/chrome/browser/flags/about_flags.mm
@@ -646,12 +646,6 @@ flag_descriptions::kIOSPersistCrashRestoreName, flag_descriptions::kIOSPersistCrashRestoreDescription, flags_ui::kOsIos, FEATURE_VALUE_TYPE(kIOSPersistCrashRestore)}, - {"use-of-hash-affiliation-fetcher", - flag_descriptions::kUseOfHashAffiliationFetcherName, - flag_descriptions::kUseOfHashAffiliationFetcherDescription, - flags_ui::kOsIos, - FEATURE_VALUE_TYPE( - password_manager::features::kUseOfHashAffiliationFetcher)}, {"omnibox-new-textfield-implementation", flag_descriptions::kOmniboxNewImplementationName, flag_descriptions::kOmniboxNewImplementationDescription, flags_ui::kOsIos,
diff --git a/ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc b/ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc index acb1a5f9..5baaeed 100644 --- a/ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc +++ b/ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc
@@ -510,12 +510,6 @@ const char kUseJSForErrorPageDescription[] = "Use JavaScript for the error pages"; -const char kUseOfHashAffiliationFetcherName[] = - "Use of Hash Affiliation Fetcher"; -const char kUseOfHashAffiliationFetcherDescription[] = - "All requests to the affiliation fetcher are made through the hash prefix " - "lookup. Enables use of Hash Affiliation Service for non-synced users."; - const char kWalletServiceUseSandboxName[] = "Use Google Payments sandbox"; const char kWalletServiceUseSandboxDescription[] = "Uses the sandbox service for Google Payments API calls.";
diff --git a/ios/chrome/browser/flags/ios_chrome_flag_descriptions.h b/ios/chrome/browser/flags/ios_chrome_flag_descriptions.h index 2e0d3869..d0d80be 100644 --- a/ios/chrome/browser/flags/ios_chrome_flag_descriptions.h +++ b/ios/chrome/browser/flags/ios_chrome_flag_descriptions.h
@@ -447,10 +447,6 @@ extern const char kUseJSForErrorPageName[]; extern const char kUseJSForErrorPageDescription[]; -// Title and description for the flag to enable use of hash affiliation service. -extern const char kUseOfHashAffiliationFetcherName[]; -extern const char kUseOfHashAffiliationFetcherDescription[]; - // Title and description for the flag to control if Google Payments API calls // should use the sandbox servers. extern const char kWalletServiceUseSandboxName[];
diff --git a/ios/chrome/browser/reading_list/BUILD.gn b/ios/chrome/browser/reading_list/BUILD.gn index a0506645..a862fd8f 100644 --- a/ios/chrome/browser/reading_list/BUILD.gn +++ b/ios/chrome/browser/reading_list/BUILD.gn
@@ -52,6 +52,8 @@ "//ios/web/public/deprecated", "//ios/web/public/security", "//net", + "//services/network/public/cpp", + "//services/network/public/mojom", "//ui/base", "//url", ]
diff --git a/ios/chrome/browser/reading_list/url_downloader.cc b/ios/chrome/browser/reading_list/url_downloader.cc index e5258b2..8326814 100644 --- a/ios/chrome/browser/reading_list/url_downloader.cc +++ b/ios/chrome/browser/reading_list/url_downloader.cc
@@ -30,6 +30,7 @@ #include "services/network/public/cpp/resource_request.h" #include "services/network/public/cpp/shared_url_loader_factory.h" #include "services/network/public/cpp/simple_url_loader.h" +#include "services/network/public/mojom/url_response_head.mojom.h" #include "url/gurl.h" namespace {
diff --git a/ios/chrome/browser/ui/infobars/modals/autofill_address_profile/infobar_save_address_profile_table_view_controller.mm b/ios/chrome/browser/ui/infobars/modals/autofill_address_profile/infobar_save_address_profile_table_view_controller.mm index 99d92547..71f3f38 100644 --- a/ios/chrome/browser/ui/infobars/modals/autofill_address_profile/infobar_save_address_profile_table_view_controller.mm +++ b/ios/chrome/browser/ui/infobars/modals/autofill_address_profile/infobar_save_address_profile_table_view_controller.mm
@@ -4,9 +4,11 @@ #import "ios/chrome/browser/ui/infobars/modals/autofill_address_profile/infobar_save_address_profile_table_view_controller.h" +#include "base/feature_list.h" #include "base/mac/foundation_util.h" #include "base/metrics/user_metrics.h" #include "base/metrics/user_metrics_action.h" +#include "components/autofill/core/common/autofill_features.h" #include "components/strings/grit/components_strings.h" #include "ios/chrome/browser/infobars/infobar_metrics_recorder.h" #import "ios/chrome/browser/ui/autofill/autofill_ui_type.h" @@ -178,9 +180,13 @@ didSelectRowAtIndexPath:(NSIndexPath*)indexPath { TableViewModel* model = self.tableViewModel; NSInteger itemType = [model itemTypeForIndexPath:indexPath]; - if (itemType == ItemTypeSaveModalFields || - itemType == ItemTypeUpdateModalFields) { - [self ensureContextMenuShownForItemType:itemType atIndexPath:indexPath]; + if (base::FeatureList::IsEnabled( + autofill::features:: + kAutofillAddressProfileSavePromptAddressVerificationSupport)) { + if (itemType == ItemTypeSaveModalFields || + itemType == ItemTypeUpdateModalFields) { + [self ensureContextMenuShownForItemType:itemType atIndexPath:indexPath]; + } } }
diff --git a/ios/chrome/browser/ui/main/scene_controller.mm b/ios/chrome/browser/ui/main/scene_controller.mm index b205be5..651340f 100644 --- a/ios/chrome/browser/ui/main/scene_controller.mm +++ b/ios/chrome/browser/ui/main/scene_controller.mm
@@ -1429,8 +1429,10 @@ // This dispatch is necessary to give enough time for the tools menu to // disappear before taking a screenshot. dispatch_async(dispatch_get_main_queue(), ^{ - DCHECK(!self.signinCoordinator) << base::SysNSStringToUTF8( - NSStringFromClass(self.signinCoordinator.class)); + DCHECK(!self.signinCoordinator) + << "self.signinCoordinator class: " + << base::SysNSStringToUTF8( + NSStringFromClass(self.signinCoordinator.class)); if (self.settingsNavigationController) return; Browser* browser = self.mainInterface.browser; @@ -2325,8 +2327,10 @@ ProceduralBlock completionWithBVC = ^{ DCHECK(self.currentInterface.viewController); DCHECK(!self.mainCoordinator.isTabGridActive); - DCHECK(!self.signinCoordinator) << base::SysNSStringToUTF8( - NSStringFromClass(self.signinCoordinator.class)); + DCHECK(!self.signinCoordinator) + << "self.signinCoordinator class: " + << base::SysNSStringToUTF8( + NSStringFromClass(self.signinCoordinator.class)); // This will dismiss the SSO view controller. [self.interfaceProvider.currentInterface clearPresentedStateWithCompletion:completion @@ -2336,8 +2340,10 @@ // |self.currentInterface.bvc| may exist but tab switcher should be // active. DCHECK(self.mainCoordinator.isTabGridActive); - DCHECK(!self.signinCoordinator) << base::SysNSStringToUTF8( - NSStringFromClass(self.signinCoordinator.class)); + DCHECK(!self.signinCoordinator) + << "self.signinCoordinator class: " + << base::SysNSStringToUTF8( + NSStringFromClass(self.signinCoordinator.class)); // History coordinator can be started on top of the tab grid. // This is not true of the other tab switchers. DCHECK(self.mainCoordinator);
diff --git a/ios/chrome/browser/ui/settings/google_services/google_services_settings_coordinator.mm b/ios/chrome/browser/ui/settings/google_services/google_services_settings_coordinator.mm index 4b34a11..e3f0b861c 100644 --- a/ios/chrome/browser/ui/settings/google_services/google_services_settings_coordinator.mm +++ b/ios/chrome/browser/ui/settings/google_services/google_services_settings_coordinator.mm
@@ -301,17 +301,27 @@ self.browser->GetBrowserState()); BOOL isSyncConsentGiven = syncSetupService && syncSetupService->IsFirstSetupComplete(); - NSString* message = - isSyncConsentGiven - ? l10n_util::GetNSString(IDS_IOS_SIGNOUT_DIALOG_MESSAGE_WITH_SYNC) - : nil; + self.signOutCoordinator = [[ActionSheetCoordinator alloc] initWithBaseViewController:self.viewController browser:self.browser title:nil - message:message + message:nil rect:targetRect view:self.viewController.view]; + // Because setting |title| to nil automatically forces the title-style text on + // |message| in the UIAlertController, the attributed message below + // specifically denotes the font style to apply. + if (isSyncConsentGiven) { + self.signOutCoordinator.attributedMessage = [[NSAttributedString alloc] + initWithString:l10n_util::GetNSString( + IDS_IOS_SIGNOUT_DIALOG_MESSAGE_WITH_SYNC) + attributes:@{ + NSFontAttributeName : + [UIFont preferredFontForTextStyle:UIFontTextStyleSubheadline] + }]; + [self.signOutCoordinator updateAttributedText]; + } __weak GoogleServicesSettingsCoordinator* weakSelf = self; [self.signOutCoordinator
diff --git a/ios/chrome/browser/ui/settings/google_services/google_services_settings_mediator.mm b/ios/chrome/browser/ui/settings/google_services/google_services_settings_mediator.mm index 7229e5c..63963eb0 100644 --- a/ios/chrome/browser/ui/settings/google_services/google_services_settings_mediator.mm +++ b/ios/chrome/browser/ui/settings/google_services/google_services_settings_mediator.mm
@@ -896,11 +896,8 @@ ? IDS_IOS_GOOGLE_SERVICES_SETTINGS_SYNC_FIX_RECOVERABILITY_DEGRADED_FOR_EVERYTHING : IDS_IOS_GOOGLE_SERVICES_SETTINGS_SYNC_FIX_RECOVERABILITY_DEGRADED_FOR_PASSWORDS); - // Also override the title to be more accurate, if only passwords are - // being encrypted. - if (!self.syncSetupService->IsEncryptEverythingEnabled()) { - syncErrorItem.text = GetNSString(IDS_IOS_SYNC_PASSWORDS_ERROR_TITLE); - } + // Also override the title to be more accurate. + syncErrorItem.text = GetNSString(IDS_SYNC_NEEDS_VERIFICATION_TITLE); break; }
diff --git a/ios/chrome/browser/ui/settings/google_services/manage_sync_settings_mediator.mm b/ios/chrome/browser/ui/settings/google_services/manage_sync_settings_mediator.mm index 24e684f..c19d9bd 100644 --- a/ios/chrome/browser/ui/settings/google_services/manage_sync_settings_mediator.mm +++ b/ios/chrome/browser/ui/settings/google_services/manage_sync_settings_mediator.mm
@@ -667,11 +667,8 @@ ? IDS_IOS_GOOGLE_SERVICES_SETTINGS_SYNC_FIX_RECOVERABILITY_DEGRADED_FOR_EVERYTHING : IDS_IOS_GOOGLE_SERVICES_SETTINGS_SYNC_FIX_RECOVERABILITY_DEGRADED_FOR_PASSWORDS); - // Also override the title to be more accurate, if only passwords are - // being encrypted. - if (!self.syncSetupService->IsEncryptEverythingEnabled()) { - syncErrorItem.text = GetNSString(IDS_IOS_SYNC_PASSWORDS_ERROR_TITLE); - } + // Also override the title to be more accurate. + syncErrorItem.text = GetNSString(IDS_SYNC_NEEDS_VERIFICATION_TITLE); break; } syncErrorItem.image = [UIImage imageNamed:kGoogleServicesSyncErrorImage];
diff --git a/ios/chrome/browser/ui/tab_switcher/tab_grid/grid/BUILD.gn b/ios/chrome/browser/ui/tab_switcher/tab_grid/grid/BUILD.gn index 4d48d89..5f628860 100644 --- a/ios/chrome/browser/ui/tab_switcher/tab_grid/grid/BUILD.gn +++ b/ios/chrome/browser/ui/tab_switcher/tab_grid/grid/BUILD.gn
@@ -29,6 +29,7 @@ "grid_layout.h", "grid_layout.mm", "grid_menu_actions_data_source.h", + "grid_shareable_items_provider.h", "grid_theme.h", "grid_view_controller.h", "grid_view_controller.mm",
diff --git a/ios/chrome/browser/ui/tab_switcher/tab_grid/grid/grid_shareable_items_provider.h b/ios/chrome/browser/ui/tab_switcher/tab_grid/grid/grid_shareable_items_provider.h new file mode 100644 index 0000000..3749d6f --- /dev/null +++ b/ios/chrome/browser/ui/tab_switcher/tab_grid/grid/grid_shareable_items_provider.h
@@ -0,0 +1,19 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef IOS_CHROME_BROWSER_UI_TAB_SWITCHER_TAB_GRID_GRID_GRID_SHAREABLE_ITEMS_PROVIDER_H_ +#define IOS_CHROME_BROWSER_UI_TAB_SWITCHER_TAB_GRID_GRID_GRID_SHAREABLE_ITEMS_PROVIDER_H_ + +#import <Foundation/Foundation.h> + +// Protocol for instances that will provide shareable state for items in the +// Grid view. +@protocol GridShareableItemsProvider + +// Returns whether the item with |identifier| is shareable. +- (BOOL)isItemWithIdentifierSharable:(NSString*)identifier; + +@end + +#endif // IOS_CHROME_BROWSER_UI_TAB_SWITCHER_TAB_GRID_GRID_GRID_SHAREABLE_ITEMS_PROVIDER_H_
diff --git a/ios/chrome/browser/ui/tab_switcher/tab_grid/grid/grid_view_controller.h b/ios/chrome/browser/ui/tab_switcher/tab_grid/grid/grid_view_controller.h index 94d11ce..9eafd0fc 100644 --- a/ios/chrome/browser/ui/tab_switcher/tab_grid/grid/grid_view_controller.h +++ b/ios/chrome/browser/ui/tab_switcher/tab_grid/grid/grid_view_controller.h
@@ -14,14 +14,15 @@ #import "ios/chrome/browser/ui/tab_switcher/tab_grid/tab_grid_paging.h" #import "ios/chrome/browser/ui/thumb_strip/thumb_strip_supporting.h" +@protocol GridContextMenuProvider; @protocol GridDragDropHandler; @protocol GridEmptyView; @protocol GridImageDataSource; +@protocol GridShareableItemsProvider; @class GridTransitionLayout; @class GridViewController; @protocol IncognitoReauthCommands; @protocol ThumbStripCommands; -@protocol GridContextMenuProvider; // Protocol used to relay relevant user interactions from a grid UI. @protocol GridViewControllerDelegate @@ -101,9 +102,16 @@ @property(nonatomic, assign) BOOL contentNeedsAuthentication; // Provider of context menu configurations for the tabs in the grid. @property(nonatomic, weak) id<GridContextMenuProvider> menuProvider; +// Provider of shareable state for tabs in the grid. +@property(nonatomic, weak) id<GridShareableItemsProvider> + shareableItemsProvider; // The item IDs of selected items for editing. @property(nonatomic, readonly) NSArray<NSString*>* selectedItemIDsForEditing; +// The item IDs of selected items for editing which are shareable outside of the +// application. +@property(nonatomic, readonly) + NSArray<NSString*>* selectedShareableItemIDsForEditing; // Returns the layout of the grid for use in an animated transition. - (GridTransitionLayout*)transitionLayout;
diff --git a/ios/chrome/browser/ui/tab_switcher/tab_grid/grid/grid_view_controller.mm b/ios/chrome/browser/ui/tab_switcher/tab_grid/grid/grid_view_controller.mm index 7ca48a0..b593825 100644 --- a/ios/chrome/browser/ui/tab_switcher/tab_grid/grid/grid_view_controller.mm +++ b/ios/chrome/browser/ui/tab_switcher/tab_grid/grid/grid_view_controller.mm
@@ -25,6 +25,7 @@ #import "ios/chrome/browser/ui/tab_switcher/tab_grid/grid/grid_empty_view.h" #import "ios/chrome/browser/ui/tab_switcher/tab_grid/grid/grid_image_data_source.h" #import "ios/chrome/browser/ui/tab_switcher/tab_grid/grid/grid_layout.h" +#import "ios/chrome/browser/ui/tab_switcher/tab_grid/grid/grid_shareable_items_provider.h" #import "ios/chrome/browser/ui/tab_switcher/tab_grid/grid/horizontal_layout.h" #import "ios/chrome/browser/ui/tab_switcher/tab_grid/grid/plus_sign_cell.h" #import "ios/chrome/browser/ui/tab_switcher/tab_grid/transitions/grid_transition_layout.h" @@ -78,6 +79,9 @@ @property(nonatomic, readonly) NSUInteger selectedIndex; // Items selected for editing. @property(nonatomic, strong) NSMutableSet<NSString*>* selectedEditingItemIDs; +// Items selected for editing which are shareable outside of the app. +@property(nonatomic, strong) + NSMutableSet<NSString*>* selectedSharableEditingItemIDs; // ID of the last item to be inserted. This is used to track if the active tab // was newly created when building the animation layout for transitions. @property(nonatomic, copy) NSString* lastInsertedItemID; @@ -120,6 +124,7 @@ if (self = [super init]) { _items = [[NSMutableArray<TabSwitcherItem*> alloc] init]; _selectedEditingItemIDs = [[NSMutableSet<NSString*> alloc] init]; + _selectedSharableEditingItemIDs = [[NSMutableSet<NSString*> alloc] init]; _showsSelectionUpdates = YES; _mode = TabGridModeNormal; } @@ -237,6 +242,7 @@ // Clear items when exiting selection mode. if (mode == TabGridModeNormal) { [self.selectedEditingItemIDs removeAllObjects]; + [self.selectedSharableEditingItemIDs removeAllObjects]; } [self.collectionView reloadData]; } @@ -664,6 +670,7 @@ self.items = [items mutableCopy]; self.selectedItemID = selectedItemID; [self.selectedEditingItemIDs removeAllObjects]; + [self.selectedSharableEditingItemIDs removeAllObjects]; [self.collectionView reloadData]; [self.collectionView selectItemAtIndexPath:CreateIndexPath(self.selectedIndex) animated:YES @@ -1144,6 +1151,10 @@ return [self.selectedEditingItemIDs allObjects]; } +- (NSArray<NSString*>*)selectedShareableItemIDsForEditing { + return [self.selectedSharableEditingItemIDs allObjects]; +} + #pragma mark - Private Editing Mode Selection - (BOOL)isItemWithIDSelectedForEditing:(NSString*)identifier { @@ -1152,10 +1163,14 @@ - (void)selectItemWithIDForEditing:(NSString*)identifier { [self.selectedEditingItemIDs addObject:identifier]; + if ([self.shareableItemsProvider isItemWithIdentifierSharable:identifier]) { + [self.selectedSharableEditingItemIDs addObject:identifier]; + } } - (void)deselectItemWithIDForEditing:(NSString*)identifier { [self.selectedEditingItemIDs removeObject:identifier]; + [self.selectedSharableEditingItemIDs removeObject:identifier]; } #pragma mark - ThumbStripSupporting
diff --git a/ios/chrome/browser/ui/tab_switcher/tab_grid/tab_grid_bottom_toolbar.mm b/ios/chrome/browser/ui/tab_switcher/tab_grid/tab_grid_bottom_toolbar.mm index e978e8a3..a09264d 100644 --- a/ios/chrome/browser/ui/tab_switcher/tab_grid/tab_grid_bottom_toolbar.mm +++ b/ios/chrome/browser/ui/tab_switcher/tab_grid/tab_grid_bottom_toolbar.mm
@@ -99,7 +99,7 @@ - (void)setSelectedTabsCount:(int)count { _selectedTabsCount = count; - [self updateSelectionButtons]; + [self updateCloseTabsButtonTitle]; } - (void)setNewTabButtonTarget:(id)target action:(SEL)action { @@ -255,7 +255,7 @@ _closeTabsButton.tintColor = UIColorFromRGB(kTabGridToolbarTextButtonColor); _closeTabsButton.accessibilityIdentifier = kTabGridEditCloseTabsButtonIdentifier; - [self updateSelectionButtons]; + [self updateCloseTabsButtonTitle]; } _compactConstraints = @[ @@ -301,12 +301,9 @@ _newTabButtonItem.title = _largeNewTabButton.accessibilityLabel; } -- (void)updateSelectionButtons { +- (void)updateCloseTabsButtonTitle { _closeTabsButton.title = l10n_util::GetPluralNSStringF( IDS_IOS_TAB_GRID_CLOSE_TABS_BUTTON, _selectedTabsCount); - _addToButton.enabled = _selectedTabsCount > 0; - _closeTabsButton.enabled = _selectedTabsCount > 0; - _shareButton.enabled = _selectedTabsCount > 0; } - (void)updateLayout {
diff --git a/ios/chrome/browser/ui/tab_switcher/tab_grid/tab_grid_coordinator.mm b/ios/chrome/browser/ui/tab_switcher/tab_grid/tab_grid_coordinator.mm index 5097c0b..6d2e2fc 100644 --- a/ios/chrome/browser/ui/tab_switcher/tab_grid/tab_grid_coordinator.mm +++ b/ios/chrome/browser/ui/tab_switcher/tab_grid/tab_grid_coordinator.mm
@@ -592,6 +592,10 @@ baseViewController.incognitoTabsDragDropHandler = self.incognitoTabsMediator; baseViewController.regularTabsImageDataSource = self.regularTabsMediator; baseViewController.incognitoTabsImageDataSource = self.incognitoTabsMediator; + baseViewController.regularTabsShareableItemsProvider = + self.regularTabsMediator; + baseViewController.incognitoTabsShareableItemsProvider = + self.incognitoTabsMediator; self.incognitoAuthMediator = [[IncognitoReauthMediator alloc] initWithConsumer:self.baseViewController.incognitoTabsConsumer
diff --git a/ios/chrome/browser/ui/tab_switcher/tab_grid/tab_grid_mediator.h b/ios/chrome/browser/ui/tab_switcher/tab_grid/tab_grid_mediator.h index edf51c6..a8f4019 100644 --- a/ios/chrome/browser/ui/tab_switcher/tab_grid/tab_grid_mediator.h +++ b/ios/chrome/browser/ui/tab_switcher/tab_grid/tab_grid_mediator.h
@@ -11,6 +11,7 @@ #import "ios/chrome/browser/ui/tab_switcher/tab_grid/grid/grid_drag_drop_handler.h" #import "ios/chrome/browser/ui/tab_switcher/tab_grid/grid/grid_image_data_source.h" #import "ios/chrome/browser/ui/tab_switcher/tab_grid/grid/grid_menu_actions_data_source.h" +#import "ios/chrome/browser/ui/tab_switcher/tab_grid/grid/grid_shareable_items_provider.h" class Browser; @protocol GridConsumer; @@ -53,7 +54,8 @@ @interface TabGridMediator : NSObject <GridCommands, GridDragDropHandler, GridImageDataSource, - GridMenuActionsDataSource> + GridMenuActionsDataSource, + GridShareableItemsProvider> // The source browser. @property(nonatomic, assign) Browser* browser;
diff --git a/ios/chrome/browser/ui/tab_switcher/tab_grid/tab_grid_mediator.mm b/ios/chrome/browser/ui/tab_switcher/tab_grid/tab_grid_mediator.mm index 8f0ff88..85c9fdcc 100644 --- a/ios/chrome/browser/ui/tab_switcher/tab_grid/tab_grid_mediator.mm +++ b/ios/chrome/browser/ui/tab_switcher/tab_grid/tab_grid_mediator.mm
@@ -479,10 +479,12 @@ __weak TabGridMediator* weakSelf = self; return @[ [actionFactory actionToAddToReadingListWithBlock:^{ - [weakSelf addItemsToReadingList:weakGrid.selectedItemIDsForEditing]; + [weakSelf + addItemsToReadingList:weakGrid.selectedShareableItemIDsForEditing]; }], [actionFactory actionToBookmarkWithBlock:^{ - [weakSelf addItemsToBookmarks:weakGrid.selectedItemIDsForEditing]; + [weakSelf + addItemsToBookmarks:weakGrid.selectedShareableItemIDsForEditing]; }] ]; } @@ -678,6 +680,14 @@ bookmarkModel->GetMostRecentlyAddedUserNodeForURL(item.URL); } +#pragma mark - GridShareableItemsProvider + +- (BOOL)isItemWithIdentifierSharable:(NSString*)identifier { + web::WebState* webState = GetWebStateWithId(self.webStateList, identifier); + const GURL& URL = webState->GetVisibleURL(); + return URL.is_valid() && URL.SchemeIsHTTPOrHTTPS(); +} + #pragma mark - Private // Calls |-populateItems:selectedItemID:| on the consumer.
diff --git a/ios/chrome/browser/ui/tab_switcher/tab_grid/tab_grid_view_controller.h b/ios/chrome/browser/ui/tab_switcher/tab_grid/tab_grid_view_controller.h index 43dd869..421944b 100644 --- a/ios/chrome/browser/ui/tab_switcher/tab_grid/tab_grid_view_controller.h +++ b/ios/chrome/browser/ui/tab_switcher/tab_grid/tab_grid_view_controller.h
@@ -18,6 +18,7 @@ @protocol GridCommands; @protocol GridDragDropHandler; @protocol GridImageDataSource; +@protocol GridShareableItemsProvider; class GURL; @protocol IncognitoReauthCommands; @protocol IncognitoReauthConsumer; @@ -109,6 +110,11 @@ @property(nonatomic, weak) id<GridImageDataSource> regularTabsImageDataSource; @property(nonatomic, weak) id<GridImageDataSource> incognitoTabsImageDataSource; +@property(nonatomic, weak) id<GridShareableItemsProvider> + regularTabsShareableItemsProvider; +@property(nonatomic, weak) id<GridShareableItemsProvider> + incognitoTabsShareableItemsProvider; + // An optional object to be notified whenever the trait collection of this view // controller changes. @property(nonatomic, weak) id<ViewControllerTraitCollectionObserver>
diff --git a/ios/chrome/browser/ui/tab_switcher/tab_grid/tab_grid_view_controller.mm b/ios/chrome/browser/ui/tab_switcher/tab_grid/tab_grid_view_controller.mm index 5669b67..84de14f 100644 --- a/ios/chrome/browser/ui/tab_switcher/tab_grid/tab_grid_view_controller.mm +++ b/ios/chrome/browser/ui/tab_switcher/tab_grid/tab_grid_view_controller.mm
@@ -531,6 +531,18 @@ return self.remoteTabsViewController; } +- (void)setRegularTabsShareableItemsProvider: + (id<GridShareableItemsProvider>)provider { + self.regularTabsViewController.shareableItemsProvider = provider; + _regularTabsShareableItemsProvider = provider; +} + +- (void)setIncognitoTabsShareableItemsProvider: + (id<GridShareableItemsProvider>)provider { + self.incognitoTabsViewController.shareableItemsProvider = provider; + _incognitoTabsShareableItemsProvider = provider; +} + - (void)setReauthHandler:(id<IncognitoReauthCommands>)reauthHandler { if (_reauthHandler == reauthHandler) return; @@ -1500,9 +1512,14 @@ [self gridViewControllerForPage:self.currentPage]; NSUInteger selectedItemsCount = [currentGridViewController.selectedItemIDsForEditing count]; + NSUInteger sharableSelectedItemsCount = + [currentGridViewController.selectedShareableItemIDsForEditing count]; self.topToolbar.selectedTabsCount = selectedItemsCount; + self.bottomToolbar.selectedTabsCount = selectedItemsCount; [self.bottomToolbar setCloseAllButtonEnabled:selectedItemsCount > 0]; + [self.bottomToolbar setShareTabsButtonEnabled:sharableSelectedItemsCount > 0]; + [self.bottomToolbar setAddToButtonEnabled:sharableSelectedItemsCount > 0]; } // Records when the user switches between incognito and regular pages in the tab @@ -1959,7 +1976,8 @@ - (void)shareSelectedTabs:(id)sender { GridViewController* gridViewController = [self gridViewControllerForPage:self.currentPage]; - NSArray<NSString*>* items = gridViewController.selectedItemIDsForEditing; + NSArray<NSString*>* items = + gridViewController.selectedShareableItemIDsForEditing; switch (self.currentPage) { case TabGridPageIncognitoTabs:
diff --git a/ios/chrome/browser/ui/toolbar/adaptive_toolbar_egtest.mm b/ios/chrome/browser/ui/toolbar/adaptive_toolbar_egtest.mm index 2effcee2..54e663c 100644 --- a/ios/chrome/browser/ui/toolbar/adaptive_toolbar_egtest.mm +++ b/ios/chrome/browser/ui/toolbar/adaptive_toolbar_egtest.mm
@@ -560,7 +560,8 @@ // Test that the bottom toolbar is still visible after closing the last // incognito tab using long press. See https://crbug.com/849937. -- (void)testBottomToolbarHeightAfterClosingTab { +// TODO(crbug.com/1229034): Fix flakiness +- (void)DISABLED_testBottomToolbarHeightAfterClosingTab { if (![ChromeEarlGrey isSplitToolbarMode]) EARL_GREY_TEST_SKIPPED(@"This test needs a bottom toolbar."); // Close all tabs.
diff --git a/ios/web/BUILD.gn b/ios/web/BUILD.gn index efebd4c..c4bbcae 100644 --- a/ios/web/BUILD.gn +++ b/ios/web/BUILD.gn
@@ -585,6 +585,8 @@ "//mojo/core/embedder", "//net:test_support", "//services/network/public/cpp", + "//services/network/public/cpp", + "//services/network/public/mojom", "//testing/gtest", "//ui/base:test_support", "//ui/resources",
diff --git a/ios/web/url_loader_inttest.mm b/ios/web/url_loader_inttest.mm index 5cd3fcd..c654f2d 100644 --- a/ios/web/url_loader_inttest.mm +++ b/ios/web/url_loader_inttest.mm
@@ -13,6 +13,7 @@ #include "net/traffic_annotation/network_traffic_annotation_test_helper.h" #include "services/network/public/cpp/resource_request.h" #include "services/network/public/cpp/simple_url_loader.h" +#include "services/network/public/mojom/url_response_head.mojom.h" #if !defined(__has_feature) || !__has_feature(objc_arc) #error "This file requires ARC support."
diff --git a/media/base/android/java/src/org/chromium/media/HdrMetadata.java b/media/base/android/java/src/org/chromium/media/HdrMetadata.java index add144d..8568ddc1 100644 --- a/media/base/android/java/src/org/chromium/media/HdrMetadata.java +++ b/media/base/android/java/src/org/chromium/media/HdrMetadata.java
@@ -83,8 +83,8 @@ hdrStaticInfo.putShort((short) ((primaryBChromaticityY() * MAX_CHROMATICITY) + 0.5f)); hdrStaticInfo.putShort((short) ((whitePointChromaticityX() * MAX_CHROMATICITY) + 0.5f)); hdrStaticInfo.putShort((short) ((whitePointChromaticityY() * MAX_CHROMATICITY) + 0.5f)); - hdrStaticInfo.putShort((short) (maxMasteringLuminance() + 0.5f)); - hdrStaticInfo.putShort((short) (minMasteringLuminance() + 0.5f)); + hdrStaticInfo.putShort((short) (maxColorVolumeLuminance() + 0.5f)); + hdrStaticInfo.putShort((short) (minColorVolumeLuminance() + 0.5f)); hdrStaticInfo.putShort((short) maxContentLuminance()); hdrStaticInfo.putShort((short) maxFrameAverageLuminance()); @@ -174,12 +174,14 @@ mNativeJniHdrMetadata, HdrMetadata.this); } - private float maxMasteringLuminance() { - return HdrMetadataJni.get().maxMasteringLuminance(mNativeJniHdrMetadata, HdrMetadata.this); + private float maxColorVolumeLuminance() { + return HdrMetadataJni.get().maxColorVolumeLuminance( + mNativeJniHdrMetadata, HdrMetadata.this); } - private float minMasteringLuminance() { - return HdrMetadataJni.get().minMasteringLuminance(mNativeJniHdrMetadata, HdrMetadata.this); + private float minColorVolumeLuminance() { + return HdrMetadataJni.get().minColorVolumeLuminance( + mNativeJniHdrMetadata, HdrMetadata.this); } private int maxContentLuminance() { @@ -204,8 +206,8 @@ float primaryBChromaticityY(long nativeJniHdrMetadata, HdrMetadata caller); float whitePointChromaticityX(long nativeJniHdrMetadata, HdrMetadata caller); float whitePointChromaticityY(long nativeJniHdrMetadata, HdrMetadata caller); - float maxMasteringLuminance(long nativeJniHdrMetadata, HdrMetadata caller); - float minMasteringLuminance(long nativeJniHdrMetadata, HdrMetadata caller); + float maxColorVolumeLuminance(long nativeJniHdrMetadata, HdrMetadata caller); + float minColorVolumeLuminance(long nativeJniHdrMetadata, HdrMetadata caller); int maxContentLuminance(long nativeJniHdrMetadata, HdrMetadata caller); int maxFrameAverageLuminance(long nativeJniHdrMetadata, HdrMetadata caller); }
diff --git a/media/base/android/jni_hdr_metadata.cc b/media/base/android/jni_hdr_metadata.cc index de67784..eebeb4d52 100644 --- a/media/base/android/jni_hdr_metadata.cc +++ b/media/base/android/jni_hdr_metadata.cc
@@ -43,61 +43,61 @@ jfloat JniHdrMetadata::PrimaryRChromaticityX( JNIEnv* env, const base::android::JavaParamRef<jobject>& obj) { - return hdr_metadata_.mastering_metadata.primary_r.x(); + return hdr_metadata_.color_volume_metadata.primary_r.x(); } jfloat JniHdrMetadata::PrimaryRChromaticityY( JNIEnv* env, const base::android::JavaParamRef<jobject>& obj) { - return hdr_metadata_.mastering_metadata.primary_r.y(); + return hdr_metadata_.color_volume_metadata.primary_r.y(); } jfloat JniHdrMetadata::PrimaryGChromaticityX( JNIEnv* env, const base::android::JavaParamRef<jobject>& obj) { - return hdr_metadata_.mastering_metadata.primary_g.x(); + return hdr_metadata_.color_volume_metadata.primary_g.x(); } jfloat JniHdrMetadata::PrimaryGChromaticityY( JNIEnv* env, const base::android::JavaParamRef<jobject>& obj) { - return hdr_metadata_.mastering_metadata.primary_g.y(); + return hdr_metadata_.color_volume_metadata.primary_g.y(); } jfloat JniHdrMetadata::PrimaryBChromaticityX( JNIEnv* env, const base::android::JavaParamRef<jobject>& obj) { - return hdr_metadata_.mastering_metadata.primary_b.x(); + return hdr_metadata_.color_volume_metadata.primary_b.x(); } jfloat JniHdrMetadata::PrimaryBChromaticityY( JNIEnv* env, const base::android::JavaParamRef<jobject>& obj) { - return hdr_metadata_.mastering_metadata.primary_b.y(); + return hdr_metadata_.color_volume_metadata.primary_b.y(); } jfloat JniHdrMetadata::WhitePointChromaticityX( JNIEnv* env, const base::android::JavaParamRef<jobject>& obj) { - return hdr_metadata_.mastering_metadata.white_point.x(); + return hdr_metadata_.color_volume_metadata.white_point.x(); } jfloat JniHdrMetadata::WhitePointChromaticityY( JNIEnv* env, const base::android::JavaParamRef<jobject>& obj) { - return hdr_metadata_.mastering_metadata.white_point.y(); + return hdr_metadata_.color_volume_metadata.white_point.y(); } -jfloat JniHdrMetadata::MaxMasteringLuminance( +jfloat JniHdrMetadata::MaxColorVolumeLuminance( JNIEnv* env, const base::android::JavaParamRef<jobject>& obj) { - return hdr_metadata_.mastering_metadata.luminance_max; + return hdr_metadata_.color_volume_metadata.luminance_max; } -jfloat JniHdrMetadata::MinMasteringLuminance( +jfloat JniHdrMetadata::MinColorVolumeLuminance( JNIEnv* env, const base::android::JavaParamRef<jobject>& obj) { - return hdr_metadata_.mastering_metadata.luminance_min; + return hdr_metadata_.color_volume_metadata.luminance_min; } jint JniHdrMetadata::MaxContentLuminance(
diff --git a/media/base/android/jni_hdr_metadata.h b/media/base/android/jni_hdr_metadata.h index f7ea005..eb2bf5f 100644 --- a/media/base/android/jni_hdr_metadata.h +++ b/media/base/android/jni_hdr_metadata.h
@@ -46,10 +46,12 @@ jfloat WhitePointChromaticityY( JNIEnv* env, const base::android::JavaParamRef<jobject>& obj); - jfloat MaxMasteringLuminance(JNIEnv* env, - const base::android::JavaParamRef<jobject>& obj); - jfloat MinMasteringLuminance(JNIEnv* env, - const base::android::JavaParamRef<jobject>& obj); + jfloat MaxColorVolumeLuminance( + JNIEnv* env, + const base::android::JavaParamRef<jobject>& obj); + jfloat MinColorVolumeLuminance( + JNIEnv* env, + const base::android::JavaParamRef<jobject>& obj); jint MaxContentLuminance(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj); jint MaxFrameAverageLuminance(
diff --git a/media/base/android/media_codec_bridge_impl.cc b/media/base/android/media_codec_bridge_impl.cc index 3ef58ae..54d9ede5 100644 --- a/media/base/android/media_codec_bridge_impl.cc +++ b/media/base/android/media_codec_bridge_impl.cc
@@ -118,6 +118,19 @@ extra_data + extra_data_size); break; } + case kCodecFLAC: { + // According to MediaCodec spec, CSB buffer #0 for FLAC should be: + // "fLaC", the FLAC stream marker in ASCII, followed by the STREAMINFO + // block (the mandatory metadata block), optionally followed by any number + // of other metadata blocks. + output_csd0->emplace_back('f'); + output_csd0->emplace_back('L'); + output_csd0->emplace_back('a'); + output_csd0->emplace_back('C'); + output_csd0->insert(output_csd0->end(), extra_data, + extra_data + extra_data_size); + break; + } case kCodecAAC: { output_csd0->assign(extra_data, extra_data + extra_data_size); *output_frame_has_adts_header =
diff --git a/media/base/android/media_codec_util.cc b/media/base/android/media_codec_util.cc index 61fdd23..84e4c1b 100644 --- a/media/base/android/media_codec_util.cc +++ b/media/base/android/media_codec_util.cc
@@ -39,6 +39,7 @@ const char kAacMimeType[] = "audio/mp4a-latm"; const char kOpusMimeType[] = "audio/opus"; const char kVorbisMimeType[] = "audio/vorbis"; +const char kFLACMimeType[] = "audio/flac"; const char kAc3MimeType[] = "audio/ac3"; const char kEac3MimeType[] = "audio/eac3"; const char kBitstreamAudioMimeType[] = "audio/raw"; @@ -130,6 +131,8 @@ return kMp3MimeType; case kCodecVorbis: return kVorbisMimeType; + case kCodecFLAC: + return kFLACMimeType; case kCodecOpus: return kOpusMimeType; case kCodecAAC:
diff --git a/media/base/ipc/media_param_traits_macros.h b/media/base/ipc/media_param_traits_macros.h index 8781f28a..0d06c00 100644 --- a/media/base/ipc/media_param_traits_macros.h +++ b/media/base/ipc/media_param_traits_macros.h
@@ -194,7 +194,7 @@ IPC_STRUCT_TRAITS_MEMBER(range) IPC_STRUCT_TRAITS_END() -IPC_STRUCT_TRAITS_BEGIN(gfx::MasteringMetadata) +IPC_STRUCT_TRAITS_BEGIN(gfx::ColorVolumeMetadata) IPC_STRUCT_TRAITS_MEMBER(primary_r) IPC_STRUCT_TRAITS_MEMBER(primary_g) IPC_STRUCT_TRAITS_MEMBER(primary_b) @@ -204,7 +204,7 @@ IPC_STRUCT_TRAITS_END() IPC_STRUCT_TRAITS_BEGIN(gfx::HDRMetadata) - IPC_STRUCT_TRAITS_MEMBER(mastering_metadata) + IPC_STRUCT_TRAITS_MEMBER(color_volume_metadata) IPC_STRUCT_TRAITS_MEMBER(max_content_light_level) IPC_STRUCT_TRAITS_MEMBER(max_frame_average_light_level) IPC_STRUCT_TRAITS_END()
diff --git a/media/base/mac/color_space_util_mac.mm b/media/base/mac/color_space_util_mac.mm index 799cfe29..aeba778 100644 --- a/media/base/mac/color_space_util_mac.mm +++ b/media/base/mac/color_space_util_mac.mm
@@ -304,7 +304,7 @@ "Must be 24 bytes"); // Make a copy which we can manipulate. - auto md = hdr_metadata.mastering_metadata; + auto md = hdr_metadata.color_volume_metadata; constexpr float kColorCoordinateUpperBound = 50000.0f; md.primary_r.Scale(kColorCoordinateUpperBound);
diff --git a/media/base/media_serializers.h b/media/base/media_serializers.h index 5d86dbf8..a94da6f4 100644 --- a/media/base/media_serializers.h +++ b/media/base/media_serializers.h
@@ -234,21 +234,22 @@ static base::Value Serialize(const gfx::HDRMetadata& value) { // TODO(tmathmeyer) serialize more fields here potentially. base::Value result(base::Value::Type::DICTIONARY); - FIELD_SERIALIZE("luminance range", - base::StringPrintf("%.2f => %.2f", - value.mastering_metadata.luminance_min, - value.mastering_metadata.luminance_max)); + FIELD_SERIALIZE( + "luminance range", + base::StringPrintf("%.2f => %.2f", + value.color_volume_metadata.luminance_min, + value.color_volume_metadata.luminance_max)); FIELD_SERIALIZE("primaries", base::StringPrintf( "[r:%.4f,%.4f, g:%.4f,%.4f, b:%.4f,%.4f, wp:%.4f,%.4f]", - value.mastering_metadata.primary_r.x(), - value.mastering_metadata.primary_r.y(), - value.mastering_metadata.primary_g.x(), - value.mastering_metadata.primary_g.y(), - value.mastering_metadata.primary_b.x(), - value.mastering_metadata.primary_b.y(), - value.mastering_metadata.white_point.x(), - value.mastering_metadata.white_point.y())); + value.color_volume_metadata.primary_r.x(), + value.color_volume_metadata.primary_r.y(), + value.color_volume_metadata.primary_g.x(), + value.color_volume_metadata.primary_g.y(), + value.color_volume_metadata.primary_b.x(), + value.color_volume_metadata.primary_b.y(), + value.color_volume_metadata.white_point.x(), + value.color_volume_metadata.white_point.y())); return result; } };
diff --git a/media/base/video_decoder_config.cc b/media/base/video_decoder_config.cc index af4f4f1a..40c9707 100644 --- a/media/base/video_decoder_config.cc +++ b/media/base/video_decoder_config.cc
@@ -109,16 +109,17 @@ if (hdr_metadata().has_value()) { s << std::setprecision(4) << ", luminance range: " - << hdr_metadata()->mastering_metadata.luminance_min << "-" - << hdr_metadata()->mastering_metadata.luminance_max << ", primaries: r(" - << hdr_metadata()->mastering_metadata.primary_r.x() << "," - << hdr_metadata()->mastering_metadata.primary_r.y() << ") g(" - << hdr_metadata()->mastering_metadata.primary_g.x() << "," - << hdr_metadata()->mastering_metadata.primary_g.y() << ") b(" - << hdr_metadata()->mastering_metadata.primary_b.x() << "," - << hdr_metadata()->mastering_metadata.primary_b.y() << ") wp(" - << hdr_metadata()->mastering_metadata.white_point.x() << "," - << hdr_metadata()->mastering_metadata.white_point.y() + << hdr_metadata()->color_volume_metadata.luminance_min << "-" + << hdr_metadata()->color_volume_metadata.luminance_max + << ", primaries: r(" + << hdr_metadata()->color_volume_metadata.primary_r.x() << "," + << hdr_metadata()->color_volume_metadata.primary_r.y() << ") g(" + << hdr_metadata()->color_volume_metadata.primary_g.x() << "," + << hdr_metadata()->color_volume_metadata.primary_g.y() << ") b(" + << hdr_metadata()->color_volume_metadata.primary_b.x() << "," + << hdr_metadata()->color_volume_metadata.primary_b.y() << ") wp(" + << hdr_metadata()->color_volume_metadata.white_point.x() << "," + << hdr_metadata()->color_volume_metadata.white_point.y() << "), max_content_light_level=" << hdr_metadata()->max_content_light_level << ", max_frame_average_light_level="
diff --git a/media/ffmpeg/ffmpeg_common.cc b/media/ffmpeg/ffmpeg_common.cc index 0a7afd4..faa8de7 100644 --- a/media/ffmpeg/ffmpeg_common.cc +++ b/media/ffmpeg/ffmpeg_common.cc
@@ -672,22 +672,22 @@ AVMasteringDisplayMetadata* metadata = reinterpret_cast<AVMasteringDisplayMetadata*>(side_data.data); if (metadata->has_primaries) { - hdr_metadata.mastering_metadata.primary_r = + hdr_metadata.color_volume_metadata.primary_r = gfx::PointF(av_q2d(metadata->display_primaries[0][0]), av_q2d(metadata->display_primaries[0][1])); - hdr_metadata.mastering_metadata.primary_g = + hdr_metadata.color_volume_metadata.primary_g = gfx::PointF(av_q2d(metadata->display_primaries[1][0]), av_q2d(metadata->display_primaries[1][1])); - hdr_metadata.mastering_metadata.primary_b = + hdr_metadata.color_volume_metadata.primary_b = gfx::PointF(av_q2d(metadata->display_primaries[2][0]), av_q2d(metadata->display_primaries[2][1])); - hdr_metadata.mastering_metadata.white_point = gfx::PointF( + hdr_metadata.color_volume_metadata.white_point = gfx::PointF( av_q2d(metadata->white_point[0]), av_q2d(metadata->white_point[1])); } if (metadata->has_luminance) { - hdr_metadata.mastering_metadata.luminance_max = + hdr_metadata.color_volume_metadata.luminance_max = av_q2d(metadata->max_luminance); - hdr_metadata.mastering_metadata.luminance_min = + hdr_metadata.color_volume_metadata.luminance_min = av_q2d(metadata->min_luminance); } config->set_hdr_metadata(hdr_metadata);
diff --git a/media/ffmpeg/ffmpeg_common_unittest.cc b/media/ffmpeg/ffmpeg_common_unittest.cc index 369cab5..9146072a 100644 --- a/media/ffmpeg/ffmpeg_common_unittest.cc +++ b/media/ffmpeg/ffmpeg_common_unittest.cc
@@ -345,17 +345,17 @@ EXPECT_TRUE(AVStreamToVideoDecoderConfig(stream, &video_config)); ASSERT_TRUE(video_config.hdr_metadata().has_value()); EXPECT_EQ(30.0, - video_config.hdr_metadata()->mastering_metadata.luminance_min); + video_config.hdr_metadata()->color_volume_metadata.luminance_min); EXPECT_EQ(40.0, - video_config.hdr_metadata()->mastering_metadata.luminance_max); + video_config.hdr_metadata()->color_volume_metadata.luminance_max); EXPECT_EQ(gfx::PointF(0.1, 0.2), - video_config.hdr_metadata()->mastering_metadata.primary_r); + video_config.hdr_metadata()->color_volume_metadata.primary_r); EXPECT_EQ(gfx::PointF(0.1, 0.2), - video_config.hdr_metadata()->mastering_metadata.primary_g); + video_config.hdr_metadata()->color_volume_metadata.primary_g); EXPECT_EQ(gfx::PointF(0.1, 0.2), - video_config.hdr_metadata()->mastering_metadata.primary_b); + video_config.hdr_metadata()->color_volume_metadata.primary_b); EXPECT_EQ(gfx::PointF(0.1, 0.2), - video_config.hdr_metadata()->mastering_metadata.white_point); + video_config.hdr_metadata()->color_volume_metadata.white_point); EXPECT_EQ(VideoColorSpace(VideoColorSpace::PrimaryID::SMPTEST428_1, VideoColorSpace::TransferID::LOG,
diff --git a/media/filters/android/media_codec_audio_decoder.cc b/media/filters/android/media_codec_audio_decoder.cc index a2840b7..a89182ae 100644 --- a/media/filters/android/media_codec_audio_decoder.cc +++ b/media/filters/android/media_codec_audio_decoder.cc
@@ -89,8 +89,9 @@ // TODO(xhwang): Get this list from MediaCodecBridge or just rely on // attempting to create one to determine whether the codec is supported. const bool is_codec_supported = - config.codec() == kCodecVorbis || config.codec() == kCodecAAC || - config.codec() == kCodecOpus || is_passthrough_; + config.codec() == kCodecVorbis || config.codec() == kCodecFLAC || + config.codec() == kCodecAAC || config.codec() == kCodecOpus || + is_passthrough_; if (!is_codec_supported) { DVLOG(1) << "Unsuported codec " << GetCodecName(config.codec()); BindToCurrentLoop(std::move(init_cb))
diff --git a/media/formats/mp4/mp4_stream_parser.cc b/media/formats/mp4/mp4_stream_parser.cc index a7e5bcc..fb83b2eb 100644 --- a/media/formats/mp4/mp4_stream_parser.cc +++ b/media/formats/mp4/mp4_stream_parser.cc
@@ -60,23 +60,23 @@ return EncryptionScheme::kUnencrypted; } -gfx::MasteringMetadata ConvertMdcvToMasteringMetadata( +gfx::ColorVolumeMetadata ConvertMdcvToColorVolumeMetadata( const MasteringDisplayColorVolume& mdcv) { - gfx::MasteringMetadata mastering_metadata; + gfx::ColorVolumeMetadata color_volume_metadata; - mastering_metadata.primary_r = gfx::MasteringMetadata::Chromaticity( + color_volume_metadata.primary_r = gfx::ColorVolumeMetadata::Chromaticity( mdcv.display_primaries_rx, mdcv.display_primaries_ry); - mastering_metadata.primary_g = gfx::MasteringMetadata::Chromaticity( + color_volume_metadata.primary_g = gfx::ColorVolumeMetadata::Chromaticity( mdcv.display_primaries_gx, mdcv.display_primaries_gy); - mastering_metadata.primary_b = gfx::MasteringMetadata::Chromaticity( + color_volume_metadata.primary_b = gfx::ColorVolumeMetadata::Chromaticity( mdcv.display_primaries_bx, mdcv.display_primaries_by); - mastering_metadata.white_point = gfx::MasteringMetadata::Chromaticity( + color_volume_metadata.white_point = gfx::ColorVolumeMetadata::Chromaticity( mdcv.white_point_x, mdcv.white_point_y); - mastering_metadata.luminance_max = mdcv.max_display_mastering_luminance; - mastering_metadata.luminance_min = mdcv.min_display_mastering_luminance; + color_volume_metadata.luminance_max = mdcv.max_display_mastering_luminance; + color_volume_metadata.luminance_min = mdcv.min_display_mastering_luminance; - return mastering_metadata; + return color_volume_metadata; } } // namespace @@ -547,7 +547,7 @@ entry.content_light_level_information) { gfx::HDRMetadata hdr_metadata; if (entry.mastering_display_color_volume) { - hdr_metadata.mastering_metadata = ConvertMdcvToMasteringMetadata( + hdr_metadata.color_volume_metadata = ConvertMdcvToColorVolumeMetadata( *entry.mastering_display_color_volume); }
diff --git a/media/formats/mp4/mp4_stream_parser_unittest.cc b/media/formats/mp4/mp4_stream_parser_unittest.cc index 18ea82e..e5f745c 100644 --- a/media/formats/mp4/mp4_stream_parser_unittest.cc +++ b/media/formats/mp4/mp4_stream_parser_unittest.cc
@@ -718,23 +718,29 @@ EXPECT_EQ(hdr_metadata.max_content_light_level, 1000u); EXPECT_EQ(hdr_metadata.max_frame_average_light_level, 640u); - const auto& mastering_metadata = hdr_metadata.mastering_metadata; + const auto& color_volume_metadata = hdr_metadata.color_volume_metadata; constexpr float kColorCoordinateUnit = 1 / 16.0f; - EXPECT_NEAR(mastering_metadata.primary_r.x(), 0.68, kColorCoordinateUnit); - EXPECT_NEAR(mastering_metadata.primary_r.y(), 0.31998, kColorCoordinateUnit); - EXPECT_NEAR(mastering_metadata.primary_g.x(), 0.26496, kColorCoordinateUnit); - EXPECT_NEAR(mastering_metadata.primary_g.y(), 0.68998, kColorCoordinateUnit); - EXPECT_NEAR(mastering_metadata.primary_b.x(), 0.15, kColorCoordinateUnit); - EXPECT_NEAR(mastering_metadata.primary_b.y(), 0.05998, kColorCoordinateUnit); - EXPECT_NEAR(mastering_metadata.white_point.x(), 0.314, kColorCoordinateUnit); - EXPECT_NEAR(mastering_metadata.white_point.y(), 0.351, kColorCoordinateUnit); + EXPECT_NEAR(color_volume_metadata.primary_r.x(), 0.68, kColorCoordinateUnit); + EXPECT_NEAR(color_volume_metadata.primary_r.y(), 0.31998, + kColorCoordinateUnit); + EXPECT_NEAR(color_volume_metadata.primary_g.x(), 0.26496, + kColorCoordinateUnit); + EXPECT_NEAR(color_volume_metadata.primary_g.y(), 0.68998, + kColorCoordinateUnit); + EXPECT_NEAR(color_volume_metadata.primary_b.x(), 0.15, kColorCoordinateUnit); + EXPECT_NEAR(color_volume_metadata.primary_b.y(), 0.05998, + kColorCoordinateUnit); + EXPECT_NEAR(color_volume_metadata.white_point.x(), 0.314, + kColorCoordinateUnit); + EXPECT_NEAR(color_volume_metadata.white_point.y(), 0.351, + kColorCoordinateUnit); constexpr float kLuminanceMaxUnit = 1 / 8.0f; - EXPECT_NEAR(mastering_metadata.luminance_max, 1000.0f, kLuminanceMaxUnit); + EXPECT_NEAR(color_volume_metadata.luminance_max, 1000.0f, kLuminanceMaxUnit); constexpr float kLuminanceMinUnit = 1 / 14.0; - EXPECT_NEAR(mastering_metadata.luminance_min, 0.01f, kLuminanceMinUnit); + EXPECT_NEAR(color_volume_metadata.luminance_min, 0.01f, kLuminanceMinUnit); } TEST_F(MP4StreamParserTest, FourCCToString) {
diff --git a/media/formats/webm/webm_colour_parser.cc b/media/formats/webm/webm_colour_parser.cc index 7deee8e..ee28b27 100644 --- a/media/formats/webm/webm_colour_parser.cc +++ b/media/formats/webm/webm_colour_parser.cc
@@ -14,43 +14,43 @@ WebMColorMetadata::WebMColorMetadata() = default; WebMColorMetadata::WebMColorMetadata(const WebMColorMetadata& rhs) = default; -WebMMasteringMetadataParser::WebMMasteringMetadataParser() = default; -WebMMasteringMetadataParser::~WebMMasteringMetadataParser() = default; +WebMColorVolumeMetadataParser::WebMColorVolumeMetadataParser() = default; +WebMColorVolumeMetadataParser::~WebMColorVolumeMetadataParser() = default; -bool WebMMasteringMetadataParser::OnFloat(int id, double val) { +bool WebMColorVolumeMetadataParser::OnFloat(int id, double val) { switch (id) { case kWebMIdPrimaryRChromaticityX: - mastering_metadata_.primary_r.set_x(val); + color_volume_metadata_.primary_r.set_x(val); break; case kWebMIdPrimaryRChromaticityY: - mastering_metadata_.primary_r.set_y(val); + color_volume_metadata_.primary_r.set_y(val); break; case kWebMIdPrimaryGChromaticityX: - mastering_metadata_.primary_g.set_x(val); + color_volume_metadata_.primary_g.set_x(val); break; case kWebMIdPrimaryGChromaticityY: - mastering_metadata_.primary_g.set_y(val); + color_volume_metadata_.primary_g.set_y(val); break; case kWebMIdPrimaryBChromaticityX: - mastering_metadata_.primary_b.set_x(val); + color_volume_metadata_.primary_b.set_x(val); break; case kWebMIdPrimaryBChromaticityY: - mastering_metadata_.primary_b.set_y(val); + color_volume_metadata_.primary_b.set_y(val); break; case kWebMIdWhitePointChromaticityX: - mastering_metadata_.white_point.set_x(val); + color_volume_metadata_.white_point.set_x(val); break; case kWebMIdWhitePointChromaticityY: - mastering_metadata_.white_point.set_y(val); + color_volume_metadata_.white_point.set_y(val); break; case kWebMIdLuminanceMax: - mastering_metadata_.luminance_max = val; + color_volume_metadata_.luminance_max = val; break; case kWebMIdLuminanceMin: - mastering_metadata_.luminance_min = val; + color_volume_metadata_.luminance_min = val; break; default: - DVLOG(1) << "Unexpected id in MasteringMetadata: 0x" << std::hex << id; + DVLOG(1) << "Unexpected id in ColorVolumeMetadata: 0x" << std::hex << id; return false; } return true; @@ -79,17 +79,17 @@ } WebMParserClient* WebMColourParser::OnListStart(int id) { - if (id == kWebMIdMasteringMetadata) { - mastering_metadata_parsed_ = false; - return &mastering_metadata_parser_; + if (id == kWebMIdColorVolumeMetadata) { + color_volume_metadata_parsed_ = false; + return &color_volume_metadata_parser_; } return this; } bool WebMColourParser::OnListEnd(int id) { - if (id == kWebMIdMasteringMetadata) - mastering_metadata_parsed_ = true; + if (id == kWebMIdColorVolumeMetadata) + color_volume_metadata_parsed_ = true; return true; } @@ -192,7 +192,7 @@ primaries_, transfer_characteristics_, matrix_coefficients_, range_id); if (max_content_light_level_ != -1 || max_frame_average_light_level_ != -1 || - mastering_metadata_parsed_) { + color_volume_metadata_parsed_) { color_metadata.hdr_metadata = gfx::HDRMetadata(); if (max_content_light_level_ != -1) { @@ -205,9 +205,9 @@ max_frame_average_light_level_; } - if (mastering_metadata_parsed_) { - color_metadata.hdr_metadata->mastering_metadata = - mastering_metadata_parser_.GetMasteringMetadata(); + if (color_volume_metadata_parsed_) { + color_metadata.hdr_metadata->color_volume_metadata = + color_volume_metadata_parser_.GetColorVolumeMetadata(); } }
diff --git a/media/formats/webm/webm_colour_parser.h b/media/formats/webm/webm_colour_parser.h index 2a97bc7..90b86f1 100644 --- a/media/formats/webm/webm_colour_parser.h +++ b/media/formats/webm/webm_colour_parser.h
@@ -34,21 +34,21 @@ // Parser for WebM MasteringMetadata within Colour element: // http://www.webmproject.org/docs/container/#MasteringMetadata -class WebMMasteringMetadataParser : public WebMParserClient { +class WebMColorVolumeMetadataParser : public WebMParserClient { public: - WebMMasteringMetadataParser(); - ~WebMMasteringMetadataParser() override; + WebMColorVolumeMetadataParser(); + ~WebMColorVolumeMetadataParser() override; - gfx::MasteringMetadata GetMasteringMetadata() const { - return mastering_metadata_; + gfx::ColorVolumeMetadata GetColorVolumeMetadata() const { + return color_volume_metadata_; } private: // WebMParserClient implementation. bool OnFloat(int id, double val) override; - gfx::MasteringMetadata mastering_metadata_; - DISALLOW_COPY_AND_ASSIGN(WebMMasteringMetadataParser); + gfx::ColorVolumeMetadata color_volume_metadata_; + DISALLOW_COPY_AND_ASSIGN(WebMColorVolumeMetadataParser); }; // Parser for WebM Colour element: @@ -82,8 +82,8 @@ int64_t max_content_light_level_; int64_t max_frame_average_light_level_; - WebMMasteringMetadataParser mastering_metadata_parser_; - bool mastering_metadata_parsed_ = false; + WebMColorVolumeMetadataParser color_volume_metadata_parser_; + bool color_volume_metadata_parsed_ = false; DISALLOW_COPY_AND_ASSIGN(WebMColourParser); };
diff --git a/media/formats/webm/webm_constants.h b/media/formats/webm/webm_constants.h index d971ba8..91a525b 100644 --- a/media/formats/webm/webm_constants.h +++ b/media/formats/webm/webm_constants.h
@@ -136,7 +136,7 @@ const int kWebMIdLanguage = 0x22B59C; const int kWebMIdLuminanceMax = 0x55D9; const int kWebMIdLuminanceMin = 0x55DA; -const int kWebMIdMasteringMetadata = 0x55D0; +const int kWebMIdColorVolumeMetadata = 0x55D0; const int kWebMIdMatrixCoefficients = 0x55B1; const int kWebMIdMaxBlockAdditionId = 0x55EE; const int kWebMIdMaxCache = 0x6DF8;
diff --git a/media/formats/webm/webm_parser.cc b/media/formats/webm/webm_parser.cc index ea7f050..d9c4e679 100644 --- a/media/formats/webm/webm_parser.cc +++ b/media/formats/webm/webm_parser.cc
@@ -208,10 +208,10 @@ {UINT, kWebMIdPrimaries}, {UINT, kWebMIdMaxCLL}, {UINT, kWebMIdMaxFALL}, - {LIST, kWebMIdMasteringMetadata}, + {LIST, kWebMIdColorVolumeMetadata}, }; -static const ElementIdInfo kMasteringMetadataIds[] = { +static const ElementIdInfo kColorVolumeMetadataIds[] = { {FLOAT, kWebMIdPrimaryRChromaticityX}, {FLOAT, kWebMIdPrimaryRChromaticityY}, {FLOAT, kWebMIdPrimaryGChromaticityX}, @@ -432,7 +432,7 @@ LIST_ELEMENT_INFO(kWebMIdTargets, 3, kTargetsIds), LIST_ELEMENT_INFO(kWebMIdSimpleTag, 3, kSimpleTagIds), LIST_ELEMENT_INFO(kWebMIdColour, 4, kColourIds), - LIST_ELEMENT_INFO(kWebMIdMasteringMetadata, 5, kMasteringMetadataIds), + LIST_ELEMENT_INFO(kWebMIdColorVolumeMetadata, 5, kColorVolumeMetadataIds), LIST_ELEMENT_INFO(kWebMIdProjection, 4, kProjectionIds), };
diff --git a/media/formats/webm/webm_stream_parser_unittest.cc b/media/formats/webm/webm_stream_parser_unittest.cc index c6fb3bb..bdd4850 100644 --- a/media/formats/webm/webm_stream_parser_unittest.cc +++ b/media/formats/webm/webm_stream_parser_unittest.cc
@@ -181,7 +181,7 @@ EXPECT_EQ(hdr_metadata->max_content_light_level, 11u); EXPECT_EQ(hdr_metadata->max_frame_average_light_level, 12u); - const gfx::MasteringMetadata& mmdata = hdr_metadata->mastering_metadata; + const gfx::ColorVolumeMetadata& mmdata = hdr_metadata->color_volume_metadata; EXPECT_FLOAT_EQ(mmdata.primary_r.x(), 0.1f); EXPECT_FLOAT_EQ(mmdata.primary_r.y(), 0.2f); EXPECT_FLOAT_EQ(mmdata.primary_g.x(), 0.1f);
diff --git a/media/formats/webm/webm_video_client_unittest.cc b/media/formats/webm/webm_video_client_unittest.cc index 85fdd3ec..eb422b2 100644 --- a/media/formats/webm/webm_video_client_unittest.cc +++ b/media/formats/webm/webm_video_client_unittest.cc
@@ -106,9 +106,9 @@ const bool has_valid_codec_private = GetParam().codec_private.size() > 3; auto* color_parser = OnListStart(kWebMIdColour); - auto* metadata_parser = color_parser->OnListStart(kWebMIdMasteringMetadata); + auto* metadata_parser = color_parser->OnListStart(kWebMIdColorVolumeMetadata); metadata_parser->OnFloat(kWebMIdPrimaryRChromaticityX, 1.0); - color_parser->OnListEnd(kWebMIdMasteringMetadata); + color_parser->OnListEnd(kWebMIdColorVolumeMetadata); OnListEnd(kWebMIdColour); VideoDecoderConfig config;
diff --git a/media/gpu/android/media_codec_video_decoder_unittest.cc b/media/gpu/android/media_codec_video_decoder_unittest.cc index f8b383a..be2509f 100644 --- a/media/gpu/android/media_codec_video_decoder_unittest.cc +++ b/media/gpu/android/media_codec_video_decoder_unittest.cc
@@ -967,16 +967,16 @@ gfx::HDRMetadata hdr_metadata; hdr_metadata.max_frame_average_light_level = 123; hdr_metadata.max_content_light_level = 456; - hdr_metadata.mastering_metadata.primary_r.set_x(0.1f); - hdr_metadata.mastering_metadata.primary_r.set_y(0.2f); - hdr_metadata.mastering_metadata.primary_g.set_x(0.3f); - hdr_metadata.mastering_metadata.primary_g.set_y(0.4f); - hdr_metadata.mastering_metadata.primary_b.set_x(0.5f); - hdr_metadata.mastering_metadata.primary_b.set_y(0.6f); - hdr_metadata.mastering_metadata.white_point.set_x(0.7f); - hdr_metadata.mastering_metadata.white_point.set_y(0.8f); - hdr_metadata.mastering_metadata.luminance_max = 1000; - hdr_metadata.mastering_metadata.luminance_min = 0; + hdr_metadata.color_volume_metadata.primary_r.set_x(0.1f); + hdr_metadata.color_volume_metadata.primary_r.set_y(0.2f); + hdr_metadata.color_volume_metadata.primary_g.set_x(0.3f); + hdr_metadata.color_volume_metadata.primary_g.set_y(0.4f); + hdr_metadata.color_volume_metadata.primary_b.set_x(0.5f); + hdr_metadata.color_volume_metadata.primary_b.set_y(0.6f); + hdr_metadata.color_volume_metadata.white_point.set_x(0.7f); + hdr_metadata.color_volume_metadata.white_point.set_y(0.8f); + hdr_metadata.color_volume_metadata.luminance_max = 1000; + hdr_metadata.color_volume_metadata.luminance_min = 0; config.set_hdr_metadata(hdr_metadata);
diff --git a/media/gpu/mac/vt_config_util.mm b/media/gpu/mac/vt_config_util.mm index 8e659e6..f426ff8 100644 --- a/media/gpu/mac/vt_config_util.mm +++ b/media/gpu/mac/vt_config_util.mm
@@ -164,8 +164,8 @@ } } -void SetMasteringMetadata(const gfx::HDRMetadata& hdr_metadata, - NSMutableDictionary<NSString*, id>* extensions) { +void SetColorVolumeMetadata(const gfx::HDRMetadata& hdr_metadata, + NSMutableDictionary<NSString*, id>* extensions) { if (@available(macos 10.13, *)) { SetDictionaryValue( extensions, kCMFormatDescriptionExtension_MasteringDisplayColorVolume, @@ -262,7 +262,7 @@ if (hdr_metadata) { SetContentLightLevelInfo(*hdr_metadata, extensions); - SetMasteringMetadata(*hdr_metadata, extensions); + SetColorVolumeMetadata(*hdr_metadata, extensions); } if (profile >= VP9PROFILE_MIN && profile <= VP9PROFILE_MAX)
diff --git a/media/gpu/mac/vt_config_util_unittest.cc b/media/gpu/mac/vt_config_util_unittest.cc index 6fbb4144..dcc045c 100644 --- a/media/gpu/mac/vt_config_util_unittest.cc +++ b/media/gpu/mac/vt_config_util_unittest.cc
@@ -211,13 +211,13 @@ gfx::HDRMetadata hdr_meta; hdr_meta.max_content_light_level = 1000; hdr_meta.max_frame_average_light_level = 600; - auto& mastering = hdr_meta.mastering_metadata; - mastering.luminance_min = 0; - mastering.luminance_max = 1000; - mastering.primary_r = gfx::PointF(0.68, 0.32); - mastering.primary_g = gfx::PointF(0.2649, 0.69); - mastering.primary_b = gfx::PointF(0.15, 0.06); - mastering.white_point = gfx::PointF(0.3127, 0.3290); + auto& cv_metadata = hdr_meta.color_volume_metadata; + cv_metadata.luminance_min = 0; + cv_metadata.luminance_max = 1000; + cv_metadata.primary_r = gfx::PointF(0.68, 0.32); + cv_metadata.primary_g = gfx::PointF(0.2649, 0.69); + cv_metadata.primary_b = gfx::PointF(0.15, 0.06); + cv_metadata.white_point = gfx::PointF(0.3127, 0.3290); base::ScopedCFTypeRef<CFDictionaryRef> fmt(CreateFormatExtensions( kCMVideoCodecType_H264, H264PROFILE_MAIN, @@ -236,18 +236,18 @@ nullptr)); mp4::MasteringDisplayColorVolume mdcv_box; ASSERT_TRUE(mdcv_box.Parse(box_reader.get())); - EXPECT_EQ(mdcv_box.display_primaries_gx, mastering.primary_g.x()); - EXPECT_EQ(mdcv_box.display_primaries_gy, mastering.primary_g.y()); - EXPECT_EQ(mdcv_box.display_primaries_bx, mastering.primary_b.x()); - EXPECT_EQ(mdcv_box.display_primaries_by, mastering.primary_b.y()); - EXPECT_EQ(mdcv_box.display_primaries_rx, mastering.primary_r.x()); - EXPECT_EQ(mdcv_box.display_primaries_ry, mastering.primary_r.y()); - EXPECT_EQ(mdcv_box.white_point_x, mastering.white_point.x()); - EXPECT_EQ(mdcv_box.white_point_y, mastering.white_point.y()); + EXPECT_EQ(mdcv_box.display_primaries_gx, cv_metadata.primary_g.x()); + EXPECT_EQ(mdcv_box.display_primaries_gy, cv_metadata.primary_g.y()); + EXPECT_EQ(mdcv_box.display_primaries_bx, cv_metadata.primary_b.x()); + EXPECT_EQ(mdcv_box.display_primaries_by, cv_metadata.primary_b.y()); + EXPECT_EQ(mdcv_box.display_primaries_rx, cv_metadata.primary_r.x()); + EXPECT_EQ(mdcv_box.display_primaries_ry, cv_metadata.primary_r.y()); + EXPECT_EQ(mdcv_box.white_point_x, cv_metadata.white_point.x()); + EXPECT_EQ(mdcv_box.white_point_y, cv_metadata.white_point.y()); EXPECT_EQ(mdcv_box.max_display_mastering_luminance, - mastering.luminance_max); + cv_metadata.luminance_max); EXPECT_EQ(mdcv_box.min_display_mastering_luminance, - mastering.luminance_min); + cv_metadata.luminance_min); } {
diff --git a/media/gpu/windows/d3d11_copying_texture_wrapper_unittest.cc b/media/gpu/windows/d3d11_copying_texture_wrapper_unittest.cc index 4119647..ca25feba 100644 --- a/media/gpu/windows/d3d11_copying_texture_wrapper_unittest.cc +++ b/media/gpu/windows/d3d11_copying_texture_wrapper_unittest.cc
@@ -259,16 +259,16 @@ TEST_P(D3D11CopyingTexture2DWrapperTest, HDRMetadataIsSentToVideoProcessor) { gfx::HDRMetadata metadata; - metadata.mastering_metadata.primary_r = - gfx::MasteringMetadata::Chromaticity(0.1, 0.2); - metadata.mastering_metadata.primary_g = - gfx::MasteringMetadata::Chromaticity(0.3, 0.4); - metadata.mastering_metadata.primary_b = - gfx::MasteringMetadata::Chromaticity(0.5, 0.6); - metadata.mastering_metadata.white_point = - gfx::MasteringMetadata::Chromaticity(0.7, 0.8); - metadata.mastering_metadata.luminance_max = 0.9; - metadata.mastering_metadata.luminance_min = 0.05; + metadata.color_volume_metadata.primary_r = + gfx::ColorVolumeMetadata::Chromaticity(0.1, 0.2); + metadata.color_volume_metadata.primary_g = + gfx::ColorVolumeMetadata::Chromaticity(0.3, 0.4); + metadata.color_volume_metadata.primary_b = + gfx::ColorVolumeMetadata::Chromaticity(0.5, 0.6); + metadata.color_volume_metadata.white_point = + gfx::ColorVolumeMetadata::Chromaticity(0.7, 0.8); + metadata.color_volume_metadata.luminance_max = 0.9; + metadata.color_volume_metadata.luminance_min = 0.05; metadata.max_content_light_level = 1000; metadata.max_frame_average_light_level = 10000;
diff --git a/media/mojo/mojom/video_decoder_config_mojom_traits_unittest.cc b/media/mojo/mojom/video_decoder_config_mojom_traits_unittest.cc index 3b96c72..e62e951 100644 --- a/media/mojo/mojom/video_decoder_config_mojom_traits_unittest.cc +++ b/media/mojo/mojom/video_decoder_config_mojom_traits_unittest.cc
@@ -91,16 +91,16 @@ gfx::HDRMetadata hdr_metadata; hdr_metadata.max_frame_average_light_level = 123; hdr_metadata.max_content_light_level = 456; - hdr_metadata.mastering_metadata.primary_r.set_x(0.1f); - hdr_metadata.mastering_metadata.primary_r.set_y(0.2f); - hdr_metadata.mastering_metadata.primary_g.set_x(0.3f); - hdr_metadata.mastering_metadata.primary_g.set_y(0.4f); - hdr_metadata.mastering_metadata.primary_b.set_x(0.5f); - hdr_metadata.mastering_metadata.primary_b.set_y(0.6f); - hdr_metadata.mastering_metadata.white_point.set_x(0.7f); - hdr_metadata.mastering_metadata.white_point.set_y(0.8f); - hdr_metadata.mastering_metadata.luminance_max = 1000; - hdr_metadata.mastering_metadata.luminance_min = 0; + hdr_metadata.color_volume_metadata.primary_r.set_x(0.1f); + hdr_metadata.color_volume_metadata.primary_r.set_y(0.2f); + hdr_metadata.color_volume_metadata.primary_g.set_x(0.3f); + hdr_metadata.color_volume_metadata.primary_g.set_y(0.4f); + hdr_metadata.color_volume_metadata.primary_b.set_x(0.5f); + hdr_metadata.color_volume_metadata.primary_b.set_y(0.6f); + hdr_metadata.color_volume_metadata.white_point.set_x(0.7f); + hdr_metadata.color_volume_metadata.white_point.set_y(0.8f); + hdr_metadata.color_volume_metadata.luminance_max = 1000; + hdr_metadata.color_volume_metadata.luminance_min = 0; input.set_hdr_metadata(hdr_metadata); std::vector<uint8_t> data = media::mojom::VideoDecoderConfig::Serialize(&input);
diff --git a/media/mojo/services/media_foundation_service.cc b/media/mojo/services/media_foundation_service.cc index 41df154..3cbb55a 100644 --- a/media/mojo/services/media_foundation_service.cc +++ b/media/mojo/services/media_foundation_service.cc
@@ -8,14 +8,252 @@ #include "base/bind.h" #include "base/check.h" +#include "base/stl_util.h" +#include "base/strings/string_number_conversions.h" +#include "base/strings/string_util.h" +#include "media/base/audio_codecs.h" +#include "media/base/content_decryption_module.h" +#include "media/base/encryption_scheme.h" +#include "media/base/video_codecs.h" +#include "media/cdm/cdm_capability.h" #include "media/cdm/win/media_foundation_cdm_module.h" #include "media/media_buildflags.h" #include "media/mojo/mojom/interface_factory.mojom.h" #include "media/mojo/mojom/key_system_support.mojom.h" #include "media/mojo/services/interface_factory_impl.h" +using Microsoft::WRL::ComPtr; + namespace media { +namespace { + +// The feature parameters follow Windows API documentation: +// https://docs.microsoft.com/en-us/uwp/api/windows.media.protection.protectioncapabilities.istypesupported?view=winrt-19041 +// This default feature string is required to query capability related to video +// decoder. Since we only care about the codec support rather than the specific +// resolution or bitrate capability, we use the following typical values which +// should be supported by most devices for a certain video codec. +const char kDefaultFeatures[] = + "decode-bpp=8,decode-res-x=1920,decode-res-y=1080,decode-bitrate=10000000," + "decode-fps=30"; + +// These three parameters are an extension of the parameters supported +// in the above documentation to support the encryption capability query. +const char kRobustnessQueryName[] = "encryption-robustness"; +const char kEncryptionSchemeQueryName[] = "encryption-type"; +const char kEncryptionIvQueryName[] = "encryption-iv-size"; + +const char kSwSecureRobustness[] = "SW_SECURE_DECODE"; +const char kHwSecureRobustness[] = "HW_SECURE_ALL"; + +// The followings define the supported codecs and encryption schemes that we try +// to query. +constexpr VideoCodec kAllVideoCodecs[] = { +#if BUILDFLAG(USE_PROPRIETARY_CODECS) + VideoCodec::kCodecH264, +#if BUILDFLAG(ENABLE_PLATFORM_HEVC) + VideoCodec::kCodecHEVC, +#if BUILDFLAG(ENABLE_PLATFORM_DOLBY_VISION) + VideoCodec::kCodecDolbyVision, +#endif // BUILDFLAG(ENABLE_PLATFORM_DOLBY_VISION) +#endif // BUILDFLAG(ENABLE_PLATFORM_HEVC) +#endif // BUILDFLAG(USE_PROPRIETARY_CODECS) + VideoCodec::kCodecVP9, VideoCodec::kCodecAV1}; + +constexpr AudioCodec kAllAudioCodecs[] = { +#if BUILDFLAG(USE_PROPRIETARY_CODECS) + AudioCodec::kCodecAAC, AudioCodec::kCodecEAC3, + AudioCodec::kCodecAC3, AudioCodec::kCodecMpegHAudio, +#endif + AudioCodec::kCodecVorbis, AudioCodec::kCodecFLAC, + AudioCodec::kCodecOpus}; + +constexpr EncryptionScheme kAllEncryptionSchemes[] = {EncryptionScheme::kCenc, + EncryptionScheme::kCbcs}; +using IsTypeSupportedCB = + base::RepeatingCallback<bool(const std::string& content_type)>; + +bool IsTypeSupportedInternal( + ComPtr<IMFContentDecryptionModuleFactory> cdm_factory, + const std::string& key_system, + const std::string& content_type) { + return cdm_factory->IsTypeSupported(base::UTF8ToWide(key_system).c_str(), + base::UTF8ToWide(content_type).c_str()); +} + +std::string GetFourCCString(VideoCodec codec) { + switch (codec) { + case VideoCodec::kCodecH264: + return "avc1"; + case VideoCodec::kCodecVP9: + return "vp09"; + case VideoCodec::kCodecHEVC: + return "hvc1"; + case VideoCodec::kCodecDolbyVision: + return "dvhe"; + case VideoCodec::kCodecAV1: + return "av01"; + default: + NOTREACHED() + << "This video codec is not supported by MediaFoundationCDM. codec=" + << GetCodecName(codec); + } + return ""; +} + +std::string GetFourCCString(AudioCodec codec) { + switch (codec) { + case AudioCodec::kCodecAAC: + return "mp4a"; + case AudioCodec::kCodecVorbis: + return "vrbs"; + case AudioCodec::kCodecFLAC: + return "fLaC"; + case AudioCodec::kCodecOpus: + return "Opus"; + case AudioCodec::kCodecEAC3: + return "ec-3"; + case AudioCodec::kCodecAC3: + return "ac-3"; + case AudioCodec::kCodecMpegHAudio: + return "mhm1"; + default: + NOTREACHED() + << "This audio codec is not supported by MediaFoundationCDM. codec=" + << GetCodecName(codec); + } + return ""; +} + +std::string GetName(EncryptionScheme scheme) { + switch (scheme) { + case EncryptionScheme::kCenc: + return "cenc"; + case EncryptionScheme::kCbcs: + return "cbcs"; + default: + NOTREACHED() << "Only cenc and cbcs are supported"; + } + return ""; +} + +// According to the common encryption spec, both 8 and 16 bytes IV are allowed +// for CENC and CBCS. But some platforms may only support 8 byte IV CENC and +// Chromium does not differentiate IV size for each encryption scheme, so we use +// 8 for CENC and 16 for CBCS to provide the best coverage as those combination +// are recommended. +int GetIvSize(EncryptionScheme scheme) { + switch (scheme) { + case EncryptionScheme::kCenc: + return 8; + case EncryptionScheme::kCbcs: + return 16; + default: + NOTREACHED() << "Only cenc and cbcs are supported"; + } + return 0; +} + +base::flat_set<EncryptionScheme> GetSupportedEncryptionSchemes( + IsTypeSupportedCB callback, + VideoCodec codec, + const std::string& robustness) { + base::flat_set<EncryptionScheme> supported_schemes; + for (const auto scheme : kAllEncryptionSchemes) { + auto type = base::ReplaceStringPlaceholders( + "video/mp4;codecs=\"$1\";features=\"$2,$3=$4,$5=$6,$7=$8\"", + {GetFourCCString(codec), kDefaultFeatures, kEncryptionSchemeQueryName, + GetName(scheme), kEncryptionIvQueryName, + base::NumberToString(GetIvSize(scheme)), kRobustnessQueryName, + robustness.c_str()}, + 0); + + if (callback.Run(type)) + supported_schemes.insert(scheme); + } + return supported_schemes; +} + +absl::optional<CdmCapability> GetCdmCapability(IsTypeSupportedCB callback, + bool is_hw_secure) { + DVLOG(2) << __func__ << ", is_hw_secure=" << is_hw_secure; + + // TODO(hmchen): make this generic for more key systems. + const std::string robustness = + is_hw_secure ? kHwSecureRobustness : kSwSecureRobustness; + + CdmCapability capability; + + // Query video codecs. + for (const auto codec : kAllVideoCodecs) { + auto content_type = base::ReplaceStringPlaceholders( + "video/mp4;codecs=\"$1\";features=\"$2,$3=$4\"", + {GetFourCCString(codec), kDefaultFeatures, kRobustnessQueryName, + robustness}, + /*offsets=*/nullptr); + + if (callback.Run(content_type)) { + // IsTypeSupported() does not support querying profiling, so specify {} + // to indicate all relevant profiles should be considered supported. + const std::vector<media::VideoCodecProfile> kAllProfiles = {}; + capability.video_codecs.emplace(codec, kAllProfiles); + } + } + + // IsTypeSupported query string requires video codec, so stops if no video + // codecs are supported. + if (capability.video_codecs.empty()) { + DVLOG(2) << "No video codecs are supported."; + return absl::nullopt; + } + + // Query audio codecs. + // Audio is usually independent to the video codec. So we use <one of the + // supported video codecs> + <audio codec> to query the audio capability. + for (const auto codec : kAllAudioCodecs) { + auto type = base::ReplaceStringPlaceholders( + "video/mp4;codecs=\"$1,$2\";features=\"$3,$4=$5\"", + {GetFourCCString(capability.video_codecs.begin()->first), + GetFourCCString(codec), kDefaultFeatures, kRobustnessQueryName, + robustness}, + /*offsets=*/nullptr); + + if (callback.Run(type)) + capability.audio_codecs.push_back(codec); + } + + // Query encryption scheme. + + // Note that the CdmCapability assumes all `video_codecs` + `encryotion_ + // schemes` combinations are supported. However, in Media Foundation, + // encryption scheme may be dependent on video codecs, so we query the + // encryption scheme for all supported video codecs and get the intersection + // of the encryption schemes which work for all codecs. + base::flat_set<EncryptionScheme> intersection( + std::begin(kAllEncryptionSchemes), std::end(kAllEncryptionSchemes)); + for (auto codec : capability.video_codecs) { + const auto schemes = + GetSupportedEncryptionSchemes(callback, codec.first, robustness); + intersection = base::STLSetIntersection<base::flat_set<EncryptionScheme>>( + intersection, schemes); + } + + if (intersection.empty()) { + // Fail if no supported encryption scheme. + return absl::nullopt; + } + + capability.encryption_schemes = intersection; + + // IsTypeSupported does not support session type yet. So just use temporary + // session which is required by EME spec. + capability.session_types.insert(CdmSessionType::kTemporary); + return capability; +} + +} // namespace + MediaFoundationService::MediaFoundationService( mojo::PendingReceiver<mojom::MediaFoundationService> receiver, const base::FilePath& user_data_dir) @@ -31,11 +269,35 @@ void MediaFoundationService::IsKeySystemSupported( const std::string& key_system, IsKeySystemSupportedCallback callback) { - DVLOG(2) << __func__; - // TODO(crbug.com/1115687): Implement MediaFoundation-based key system support - // query. - NOTIMPLEMENTED(); - std::move(callback).Run(false, nullptr); + DVLOG(2) << __func__ << ", key_system=" << key_system; + ComPtr<IMFContentDecryptionModuleFactory> cdm_factory; + HRESULT hr = MediaFoundationCdmModule::GetInstance()->GetCdmFactory( + key_system, cdm_factory); + + if (FAILED(hr)) { + DLOG(ERROR) << "Failed to GetCdmFactory."; + std::move(callback).Run(false, nullptr); + return; + } + + IsTypeSupportedCB is_type_supported_cb = + base::BindRepeating(&IsTypeSupportedInternal, cdm_factory, key_system); + + absl::optional<CdmCapability> sw_secure_capability = + GetCdmCapability(is_type_supported_cb, /*is_hw_secure=*/false); + absl::optional<CdmCapability> hw_secure_capability = + GetCdmCapability(is_type_supported_cb, /*is_hw_secure=*/true); + + if (!sw_secure_capability && !hw_secure_capability) { + DVLOG(2) << "Get empty CdmCapbility."; + std::move(callback).Run(false, nullptr); + return; + } + + auto capability = media::mojom::KeySystemCapability::New(); + capability->sw_secure_capability = sw_secure_capability; + capability->hw_secure_capability = hw_secure_capability; + std::move(callback).Run(true, std::move(capability)); } void MediaFoundationService::CreateInterfaceFactory(
diff --git a/media/renderers/video_resource_updater_unittest.cc b/media/renderers/video_resource_updater_unittest.cc index 286a083..32dee8d7e 100644 --- a/media/renderers/video_resource_updater_unittest.cc +++ b/media/renderers/video_resource_updater_unittest.cc
@@ -796,7 +796,7 @@ TEST_F(VideoResourceUpdaterTest, CreateForHardwarePlanes_SingleP016HDR) { constexpr auto kHDR10ColorSpace = gfx::ColorSpace::CreateHDR10(); gfx::HDRMetadata hdr_metadata{}; - hdr_metadata.mastering_metadata.luminance_max = 1000; + hdr_metadata.color_volume_metadata.luminance_max = 1000; std::unique_ptr<VideoResourceUpdater> updater = CreateUpdaterForHardware(); EXPECT_EQ(0u, GetSharedImageCount()); scoped_refptr<VideoFrame> video_frame = CreateTestHardwareVideoFrame(
diff --git a/ppapi/native_client/nacl_test_data.gni b/ppapi/native_client/nacl_test_data.gni index e2e8ac4..a4733af 100644 --- a/ppapi/native_client/nacl_test_data.gni +++ b/ppapi/native_client/nacl_test_data.gni
@@ -184,8 +184,7 @@ # This is a template so it can be invoked twice in the # defined(extra_tc_cpu) case below. template("nacl_test_data_pretranslate_pexe") { - # TODO(crbug.com/1112471): Get this to run cleanly under Python 3. - python2_action(target_name) { + action(target_name) { translate_cpu = invoker.translate_cpu visibility = [ ":$nexe_copy_target_name" ]
diff --git a/rlz/lib/financial_ping.cc b/rlz/lib/financial_ping.cc index 8f92160..c7822b8 100644 --- a/rlz/lib/financial_ping.cc +++ b/rlz/lib/financial_ping.cc
@@ -35,6 +35,7 @@ #include "services/network/public/cpp/resource_request.h" #include "services/network/public/cpp/shared_url_loader_factory.h" #include "services/network/public/cpp/simple_url_loader.h" +#include "services/network/public/mojom/url_response_head.mojom.h" #if !defined(OS_WIN) #include "base/time/time.h"
diff --git a/services/cert_verifier/cert_net_url_loader/cert_net_fetcher_url_loader.cc b/services/cert_verifier/cert_net_url_loader/cert_net_fetcher_url_loader.cc index 807858d..b268ff5 100644 --- a/services/cert_verifier/cert_net_url_loader/cert_net_fetcher_url_loader.cc +++ b/services/cert_verifier/cert_net_url_loader/cert_net_fetcher_url_loader.cc
@@ -84,6 +84,7 @@ #include "services/network/public/cpp/resource_request.h" #include "services/network/public/cpp/simple_url_loader.h" #include "services/network/public/mojom/url_loader_factory.mojom.h" +#include "services/network/public/mojom/url_response_head.mojom.h" // TODO(eroman): Add support for POST parameters. // TODO(eroman): Add controls for bypassing the cache.
diff --git a/third_party/blink/common/features.cc b/third_party/blink/common/features.cc index 0705963..4d25cfa 100644 --- a/third_party/blink/common/features.cc +++ b/third_party/blink/common/features.cc
@@ -76,7 +76,7 @@ "FreezePurgeMemoryAllPagesFrozen", base::FEATURE_DISABLED_BY_DEFAULT}; // Freezes the user-agent as part of https://github.com/WICG/ua-client-hints. -const base::Feature kFreezeUserAgent{"FreezeUserAgent", +const base::Feature kReduceUserAgent{"ReduceUserAgent", base::FEATURE_DISABLED_BY_DEFAULT}; // Enables the frequency capping for detecting overlay popups. Overlay-popups
diff --git a/third_party/blink/public/common/features.h b/third_party/blink/public/common/features.h index 2be1493..32ee81e 100644 --- a/third_party/blink/public/common/features.h +++ b/third_party/blink/public/common/features.h
@@ -33,7 +33,7 @@ BLINK_COMMON_EXPORT extern const base::Feature kSmallScriptStreaming; BLINK_COMMON_EXPORT extern const base::Feature kUserLevelMemoryPressureSignal; BLINK_COMMON_EXPORT extern const base::Feature kFreezePurgeMemoryAllPagesFrozen; -BLINK_COMMON_EXPORT extern const base::Feature kFreezeUserAgent; +BLINK_COMMON_EXPORT extern const base::Feature kReduceUserAgent; BLINK_COMMON_EXPORT extern const base::Feature kFrequencyCappingForOverlayPopupDetection; BLINK_COMMON_EXPORT extern const base::Feature
diff --git a/third_party/blink/renderer/core/BUILD.gn b/third_party/blink/renderer/core/BUILD.gn index 50e944a..318e550f 100644 --- a/third_party/blink/renderer/core/BUILD.gn +++ b/third_party/blink/renderer/core/BUILD.gn
@@ -7,6 +7,7 @@ import("//build/config/dcheck_always_on.gni") import("//build/config/ui.gni") import("//build/toolchain/toolchain.gni") +import("//media/media_options.gni") import("//printing/buildflags/buildflags.gni") import("//testing/libfuzzer/fuzzer_test.gni") import("//third_party/blink/renderer/bindings/bindings.gni") @@ -1665,6 +1666,22 @@ if (use_aura) { sources += [ "scroll/scrollbar_theme_aura_test.cc" ] } + + if (media_use_ffmpeg || !is_android) { + sources += [ "exported/web_media_player_impl_unittest.cc" ] + data = [ "//media/test/data/" ] + deps += [ + "//media", + "//media:test_support", + "//media/mojo/services", + "//third_party/blink/public:blink", + "//third_party/blink/public:test_support", + "//third_party/blink/public/common/tokens:tokens_headers", + "//third_party/blink/public/platform/media", + "//third_party/blink/renderer/platform/media", + "//ui/gfx/geometry", + ] + } } group("unit_tests_data") {
diff --git a/third_party/blink/renderer/core/css/counter_style.cc b/third_party/blink/renderer/core/css/counter_style.cc index ce62f9f3..cc804dbc 100644 --- a/third_party/blink/renderer/core/css/counter_style.cc +++ b/third_party/blink/renderer/core/css/counter_style.cc
@@ -196,7 +196,7 @@ return result; } -namespace list_marker_text { +namespace { // TODO(xiaochengh): Reorganize these legacy implementations. Get rid of the // EListStyleType enum, and merge them into their callers if possible. @@ -472,81 +472,12 @@ return String(characters, length); } -String GetText(EListStyleType type, int count) { - switch (type) { - case EListStyleType::kKoreanHangulFormal: { - static const UChar kKoreanHangulFormalTable[26] = { - kKorean, 0xB9CC, 0x0000, 0xC5B5, 0x0000, 0xC870, 0x0000, - 0xC2ED, 0xBC31, 0xCC9C, 0xC601, 0xC77C, 0xC774, 0xC0BC, - 0xC0AC, 0xC624, 0xC721, 0xCE60, 0xD314, 0xAD6C, 0xB9C8, - 0xC774, 0xB108, 0xC2A4, 0x0020, 0x0000}; - return ToCJKIdeographic(count, kKoreanHangulFormalTable, kFormal); - } - case EListStyleType::kKoreanHanjaFormal: { - static const UChar kKoreanHanjaFormalTable[26] = { - kKorean, 0x842C, 0x0000, 0x5104, 0x0000, 0x5146, 0x0000, - 0x62FE, 0x767E, 0x4EDF, 0x96F6, 0x58F9, 0x8CB3, 0x53C3, - 0x56DB, 0x4E94, 0x516D, 0x4E03, 0x516B, 0x4E5D, 0xB9C8, - 0xC774, 0xB108, 0xC2A4, 0x0020, 0x0000}; - return ToCJKIdeographic(count, kKoreanHanjaFormalTable, kFormal); - } - case EListStyleType::kKoreanHanjaInformal: { - static const UChar kKoreanHanjaInformalTable[26] = { - kKorean, 0x842C, 0x0000, 0x5104, 0x0000, 0x5146, 0x0000, - 0x5341, 0x767E, 0x5343, 0x96F6, 0x4E00, 0x4E8C, 0x4E09, - 0x56DB, 0x4E94, 0x516D, 0x4E03, 0x516B, 0x4E5D, 0xB9C8, - 0xC774, 0xB108, 0xC2A4, 0x0020, 0x0000}; - return ToCJKIdeographic(count, kKoreanHanjaInformalTable, kInformal); - } - case EListStyleType::kTradChineseInformal: { - static const UChar kTraditionalChineseInformalTable[22] = { - kChinese, 0x842C, 0x0000, 0x5104, 0x0000, 0x5146, 0x0000, 0x5341, - 0x767E, 0x5343, 0x96F6, 0x4E00, 0x4E8C, 0x4E09, 0x56DB, 0x4E94, - 0x516D, 0x4E03, 0x516B, 0x4E5D, 0x8CA0, 0x0000}; - return ToCJKIdeographic(count, kTraditionalChineseInformalTable, - kInformal); - } - case EListStyleType::kSimpChineseInformal: { - static const UChar kSimpleChineseInformalTable[22] = { - kChinese, 0x4E07, 0x0000, 0x4EBF, 0x0000, 0x4E07, 0x4EBF, 0x5341, - 0x767E, 0x5343, 0x96F6, 0x4E00, 0x4E8C, 0x4E09, 0x56DB, 0x4E94, - 0x516D, 0x4E03, 0x516B, 0x4E5D, 0x8D1F, 0x0000}; - return ToCJKIdeographic(count, kSimpleChineseInformalTable, kInformal); - } - case EListStyleType::kTradChineseFormal: { - static const UChar kTraditionalChineseFormalTable[22] = { - kChinese, 0x842C, 0x0000, 0x5104, 0x0000, 0x5146, 0x0000, 0x62FE, - 0x4F70, 0x4EDF, 0x96F6, 0x58F9, 0x8CB3, 0x53C3, 0x8086, 0x4F0D, - 0x9678, 0x67D2, 0x634C, 0x7396, 0x8CA0, 0x0000}; - return ToCJKIdeographic(count, kTraditionalChineseFormalTable, kFormal); - } - case EListStyleType::kSimpChineseFormal: { - static const UChar kSimpleChineseFormalTable[22] = { - kChinese, 0x4E07, 0x0000, 0x4EBF, 0x0000, 0x4E07, 0x4EBF, 0x62FE, - 0x4F70, 0x4EDF, 0x96F6, 0x58F9, 0x8D30, 0x53C1, 0x8086, 0x4F0D, - 0x9646, 0x67D2, 0x634C, 0x7396, 0x8D1F, 0x0000}; - return ToCJKIdeographic(count, kSimpleChineseFormalTable, kFormal); - } - - case EListStyleType::kUpperArmenian: - return ToArmenian(count, true); - case EListStyleType::kLowerArmenian: - return ToArmenian(count, false); - case EListStyleType::kHebrew: - return ToHebrew(count); - - default: - NOTREACHED(); - return ""; - } -} - -} // namespace list_marker_text +} // namespace String HebrewAlgorithm(unsigned value) { if (value > 999999) return String(); - return list_marker_text::GetText(EListStyleType::kHebrew, value); + return ToHebrew(value); } int AbsoluteValueForLegacyCJKAlgorithms(int value) { @@ -560,50 +491,80 @@ } String SimpChineseInformalAlgorithm(int value) { - return list_marker_text::GetText(EListStyleType::kSimpChineseInformal, - AbsoluteValueForLegacyCJKAlgorithms(value)); + static const UChar kSimpleChineseInformalTable[22] = { + kChinese, 0x4E07, 0x0000, 0x4EBF, 0x0000, 0x4E07, 0x4EBF, 0x5341, + 0x767E, 0x5343, 0x96F6, 0x4E00, 0x4E8C, 0x4E09, 0x56DB, 0x4E94, + 0x516D, 0x4E03, 0x516B, 0x4E5D, 0x8D1F, 0x0000}; + return ToCJKIdeographic(AbsoluteValueForLegacyCJKAlgorithms(value), + kSimpleChineseInformalTable, kInformal); } String SimpChineseFormalAlgorithm(int value) { - return list_marker_text::GetText(EListStyleType::kSimpChineseFormal, - AbsoluteValueForLegacyCJKAlgorithms(value)); + static const UChar kSimpleChineseFormalTable[22] = { + kChinese, 0x4E07, 0x0000, 0x4EBF, 0x0000, 0x4E07, 0x4EBF, 0x62FE, + 0x4F70, 0x4EDF, 0x96F6, 0x58F9, 0x8D30, 0x53C1, 0x8086, 0x4F0D, + 0x9646, 0x67D2, 0x634C, 0x7396, 0x8D1F, 0x0000}; + return ToCJKIdeographic(AbsoluteValueForLegacyCJKAlgorithms(value), + kSimpleChineseFormalTable, kFormal); } String TradChineseInformalAlgorithm(int value) { - return list_marker_text::GetText(EListStyleType::kTradChineseInformal, - AbsoluteValueForLegacyCJKAlgorithms(value)); + static const UChar kTraditionalChineseInformalTable[22] = { + kChinese, 0x842C, 0x0000, 0x5104, 0x0000, 0x5146, 0x0000, 0x5341, + 0x767E, 0x5343, 0x96F6, 0x4E00, 0x4E8C, 0x4E09, 0x56DB, 0x4E94, + 0x516D, 0x4E03, 0x516B, 0x4E5D, 0x8CA0, 0x0000}; + return ToCJKIdeographic(AbsoluteValueForLegacyCJKAlgorithms(value), + kTraditionalChineseInformalTable, kInformal); } String TradChineseFormalAlgorithm(int value) { - return list_marker_text::GetText(EListStyleType::kTradChineseFormal, - AbsoluteValueForLegacyCJKAlgorithms(value)); + static const UChar kTraditionalChineseFormalTable[22] = { + kChinese, 0x842C, 0x0000, 0x5104, 0x0000, 0x5146, 0x0000, 0x62FE, + 0x4F70, 0x4EDF, 0x96F6, 0x58F9, 0x8CB3, 0x53C3, 0x8086, 0x4F0D, + 0x9678, 0x67D2, 0x634C, 0x7396, 0x8CA0, 0x0000}; + return ToCJKIdeographic(AbsoluteValueForLegacyCJKAlgorithms(value), + kTraditionalChineseFormalTable, kFormal); } String KoreanHangulFormalAlgorithm(int value) { - return list_marker_text::GetText(EListStyleType::kKoreanHangulFormal, - AbsoluteValueForLegacyCJKAlgorithms(value)); + static const UChar kKoreanHangulFormalTable[26] = { + kKorean, 0xB9CC, 0x0000, 0xC5B5, 0x0000, 0xC870, 0x0000, 0xC2ED, 0xBC31, + 0xCC9C, 0xC601, 0xC77C, 0xC774, 0xC0BC, 0xC0AC, 0xC624, 0xC721, 0xCE60, + 0xD314, 0xAD6C, 0xB9C8, 0xC774, 0xB108, 0xC2A4, 0x0020, 0x0000}; + return ToCJKIdeographic(AbsoluteValueForLegacyCJKAlgorithms(value), + kKoreanHangulFormalTable, kFormal); } String KoreanHanjaInformalAlgorithm(int value) { - return list_marker_text::GetText(EListStyleType::kKoreanHanjaInformal, - AbsoluteValueForLegacyCJKAlgorithms(value)); + static const UChar kKoreanHanjaInformalTable[26] = { + kKorean, 0x842C, 0x0000, 0x5104, 0x0000, 0x5146, 0x0000, 0x5341, 0x767E, + 0x5343, 0x96F6, 0x4E00, 0x4E8C, 0x4E09, 0x56DB, 0x4E94, 0x516D, 0x4E03, + 0x516B, 0x4E5D, 0xB9C8, 0xC774, 0xB108, 0xC2A4, 0x0020, 0x0000}; + return ToCJKIdeographic(AbsoluteValueForLegacyCJKAlgorithms(value), + kKoreanHanjaInformalTable, kInformal); } String KoreanHanjaFormalAlgorithm(int value) { - return list_marker_text::GetText(EListStyleType::kKoreanHanjaFormal, - AbsoluteValueForLegacyCJKAlgorithms(value)); + static const UChar kKoreanHanjaFormalTable[26] = { + kKorean, 0x842C, 0x0000, 0x5104, 0x0000, 0x5146, 0x0000, 0x62FE, 0x767E, + 0x4EDF, 0x96F6, 0x58F9, 0x8CB3, 0x53C3, 0x56DB, 0x4E94, 0x516D, 0x4E03, + 0x516B, 0x4E5D, 0xB9C8, 0xC774, 0xB108, 0xC2A4, 0x0020, 0x0000}; + return ToCJKIdeographic(AbsoluteValueForLegacyCJKAlgorithms(value), + kKoreanHanjaFormalTable, kFormal); } String LowerArmenianAlgorithm(unsigned value) { if (value > 99999999) return String(); - return list_marker_text::GetText(EListStyleType::kLowerArmenian, value); + const bool lower_case = false; + return ToArmenian(value, lower_case); } String UpperArmenianAlgorithm(unsigned value) { if (value > 99999999) return String(); - return list_marker_text::GetText(EListStyleType::kUpperArmenian, value); + const bool upper_case = true; + return ToArmenian(value, upper_case); } // https://drafts.csswg.org/css-counter-styles-3/#ethiopic-numeric-counter-style
diff --git a/third_party/blink/renderer/core/exported/DEPS b/third_party/blink/renderer/core/exported/DEPS index 71b99d7..0469eab 100644 --- a/third_party/blink/renderer/core/exported/DEPS +++ b/third_party/blink/renderer/core/exported/DEPS
@@ -14,4 +14,25 @@ "+third_party/icu/source/common/unicode/uscript.h", "+ui/gfx/font_render_params.h", ], + "web_media_player_impl_unittest.cc": [ + "+base/command_line.h", + "+base/memory/ref_counted.h", + "+base/run_loop.h", + "+base/strings/string_number_conversions.h", + "+base/strings/string_split.h", + "+base/strings/utf_string_conversions.h", + "+base/task/current_thread.h", + "+base/task_runner_util.h", + "+base/threading/thread.h", + "+components/viz/test", + "+media/base", + "+media/filters", + "+media/mojo/services", + "+media/renderers", + "+gin/v8_initializer.h", + "+mojo/core/embedder/embedder.h", + + # Allow test support dependencies. + "+third_party/blink/renderer/platform/media/testing", + ], }
diff --git a/third_party/blink/renderer/core/exported/web_element.cc b/third_party/blink/renderer/core/exported/web_element.cc index 7d6faf2..b1d1c8b 100644 --- a/third_party/blink/renderer/core/exported/web_element.cc +++ b/third_party/blink/renderer/core/exported/web_element.cc
@@ -176,7 +176,7 @@ std::vector<uint8_t> WebElement::CopyOfImageData() { Image* image = GetImage(); - if (!image || !image->Data()) + if (!image || !image->HasData()) return std::vector<uint8_t>(); return image->Data()->CopyAs<std::vector<uint8_t>>(); }
diff --git a/third_party/blink/renderer/platform/media/web_media_player_impl_unittest.cc b/third_party/blink/renderer/core/exported/web_media_player_impl_unittest.cc similarity index 98% rename from third_party/blink/renderer/platform/media/web_media_player_impl_unittest.cc rename to third_party/blink/renderer/core/exported/web_media_player_impl_unittest.cc index b523344..85e04823 100644 --- a/third_party/blink/renderer/platform/media/web_media_player_impl_unittest.cc +++ b/third_party/blink/renderer/core/exported/web_media_player_impl_unittest.cc
@@ -69,6 +69,7 @@ #include "third_party/blink/public/web/web_testing_support.h" #include "third_party/blink/public/web/web_view.h" #include "third_party/blink/public/web/web_widget.h" +#include "third_party/blink/renderer/core/frame/frame_test_helpers.h" #include "third_party/blink/renderer/platform/media/resource_multi_buffer_data_provider.h" #include "third_party/blink/renderer/platform/media/testing/mock_resource_fetch_context.h" #include "third_party/blink/renderer/platform/media/testing/mock_web_associated_url_loader.h" @@ -324,28 +325,12 @@ explicit WebMediaPlayerImplTest( std::unique_ptr<scheduler::WebAgentGroupScheduler> agent_group_scheduler) : media_thread_("MediaThreadForTest"), - web_view_(WebView::Create( - /*client=*/nullptr, - /*is_hidden=*/false, - /*is_prerendering=*/false, - /*is_inside_portal=*/false, - /*compositing_enabled=*/false, - /*widgets_never_composited=*/false, - /*opener=*/nullptr, - mojo::NullAssociatedReceiver(), - *agent_group_scheduler, - /*session_storage_namespace_id=*/base::EmptyString(), - /*page_base_background_color=*/absl::nullopt)), - web_local_frame_(WebLocalFrame::CreateMainFrame(web_view_, - &web_frame_client_, - nullptr, - LocalFrameToken(), - nullptr)), context_provider_(viz::TestContextProvider::Create()), audio_parameters_(media::TestAudioParameters::Normal()), memory_dump_manager_( base::trace_event::MemoryDumpManager::CreateInstanceForTesting()), agent_group_scheduler_(std::move(agent_group_scheduler)) { + web_view_helper_.Initialize(); media_thread_.StartAndWaitForTesting(); } @@ -378,8 +363,6 @@ CycleThreads(); - web_view_->Close(); - agent_group_scheduler_ = nullptr; } @@ -457,7 +440,7 @@ compositor_ = compositor.get(); wmpi_ = std::make_unique<WebMediaPlayerImpl>( - web_local_frame_, &client_, &encrypted_client_, &delegate_, + GetWebLocalFrame(), &client_, &encrypted_client_, &delegate_, std::move(factory_selector), url_index_.get(), std::move(compositor), std::move(params)); } @@ -468,7 +451,9 @@ return std::move(surface_layer_bridge_); } - WebLocalFrame* GetWebLocalFrame() { return web_local_frame_; } + WebLocalFrame* GetWebLocalFrame() { + return web_view_helper_.LocalMainFrame(); + } int64_t OnAdjustAllocatedMemory(int64_t delta) { reported_memory_ += delta; @@ -713,13 +698,12 @@ // network stack and "serve" an in memory file to the DataSource. WebAssociatedURLLoaderClient* client = nullptr; EXPECT_CALL(mock_resource_fetch_context_, CreateUrlLoader(_)) - .WillRepeatedly( - Invoke([&client](const WebAssociatedURLLoaderOptions&) { - auto a = std::make_unique<NiceMock<MockWebAssociatedURLLoader>>(); - EXPECT_CALL(*a, LoadAsynchronously(_, _)) - .WillRepeatedly(testing::SaveArg<1>(&client)); - return a; - })); + .WillRepeatedly(Invoke([&client](const WebAssociatedURLLoaderOptions&) { + auto a = std::make_unique<NiceMock<MockWebAssociatedURLLoader>>(); + EXPECT_CALL(*a, LoadAsynchronously(_, _)) + .WillRepeatedly(testing::SaveArg<1>(&client)); + return a; + })); wmpi_->Load(WebMediaPlayer::kLoadTypeURL, WebMediaPlayerSource(WebURL(kTestURL)), @@ -842,9 +826,7 @@ base::Thread media_thread_; // Blink state. - WebLocalFrameClient web_frame_client_; - WebView* web_view_; - WebLocalFrame* web_local_frame_; + frame_test_helpers::WebViewHelper web_view_helper_; scoped_refptr<viz::TestContextProvider> context_provider_; NiceMock<MockVideoFrameCompositor>* compositor_;
diff --git a/third_party/blink/renderer/core/frame/navigator.cc b/third_party/blink/renderer/core/frame/navigator.cc index ff2573f..be67aa3 100644 --- a/third_party/blink/renderer/core/frame/navigator.cc +++ b/third_party/blink/renderer/core/frame/navigator.cc
@@ -59,7 +59,7 @@ String Navigator::platform() const { // TODO(955620): Consider changing devtools overrides to only allow overriding // the platform with a frozen platform to distinguish between - // mobile and desktop when FreezeUserAgent is enabled. + // mobile and desktop when ReduceUserAgent is enabled. if (!DomWindow()) return NavigatorID::platform(); const String& platform_override =
diff --git a/third_party/blink/renderer/core/frame/navigator_id.cc b/third_party/blink/renderer/core/frame/navigator_id.cc index 8d66a90..a19e3fb 100644 --- a/third_party/blink/renderer/core/frame/navigator_id.cc +++ b/third_party/blink/renderer/core/frame/navigator_id.cc
@@ -65,7 +65,7 @@ // If the User-Agent string is frozen, platform should be a value // matching the frozen string per https://github.com/WICG/ua-client-hints. See // content::frozen_user_agent_strings. - if (base::FeatureList::IsEnabled(features::kFreezeUserAgent)) { + if (base::FeatureList::IsEnabled(features::kReduceUserAgent)) { #if defined(OS_ANDROID) return "Linux armv81"; #elif defined(OS_MAC)
diff --git a/third_party/blink/renderer/core/imagebitmap/image_bitmap.cc b/third_party/blink/renderer/core/imagebitmap/image_bitmap.cc index 5db3b74..f40671c 100644 --- a/third_party/blink/renderer/core/imagebitmap/image_bitmap.cc +++ b/third_party/blink/renderer/core/imagebitmap/image_bitmap.cc
@@ -423,7 +423,7 @@ scoped_refptr<StaticBitmapImage>&& image, ImageBitmap::ParsedOptions& parsed_options) { DCHECK(image); - DCHECK(!image->Data()); + DCHECK(!image->HasData()); IntRect img_rect(IntPoint(), IntSize(image->width(), image->height())); const IntRect& src_rect{parsed_options.crop_rect}; @@ -535,7 +535,7 @@ DCHECK(!paint_image.IsTextureBacked()); if (input->IsBitmapImage()) { // A BitmapImage indicates that this is a coded backed image. - if (!input->Data()) + if (!input->HasData()) return; DCHECK(paint_image.IsLazyGenerated());
diff --git a/third_party/blink/renderer/core/layout/ng/inline/inline_containing_block_utils.cc b/third_party/blink/renderer/core/layout/ng/inline/inline_containing_block_utils.cc index b3ab8404..04427ff4 100644 --- a/third_party/blink/renderer/core/layout/ng/inline/inline_containing_block_utils.cc +++ b/third_party/blink/renderer/core/layout/ng/inline/inline_containing_block_utils.cc
@@ -89,7 +89,8 @@ containing_lineboxes.second = linebox; containing_block_geometry = InlineContainingBlockUtils::InlineContainingBlockGeometry{ - fragment_rect, fragment_rect}; + fragment_rect, fragment_rect, + containing_block_geometry->relative_offset}; } if (containing_lineboxes.second == linebox) {
diff --git a/third_party/blink/renderer/core/layout/ng/inline/inline_containing_block_utils.h b/third_party/blink/renderer/core/layout/ng/inline/inline_containing_block_utils.h index dc9a25f..9dbf29e 100644 --- a/third_party/blink/renderer/core/layout/ng/inline/inline_containing_block_utils.h +++ b/third_party/blink/renderer/core/layout/ng/inline/inline_containing_block_utils.h
@@ -28,6 +28,9 @@ PhysicalRect start_fragment_union_rect; // Union of fragments generated on the last line. PhysicalRect end_fragment_union_rect; + // The accumulated relative offset of the inline container to be applied to + // any descendants after fragmentation. + LogicalOffset relative_offset; }; using InlineContainingBlockMap =
diff --git a/third_party/blink/renderer/core/layout/ng/inline/ng_inline_box_state.cc b/third_party/blink/renderer/core/layout/ng/inline/ng_inline_box_state.cc index 29befce..5503e635 100644 --- a/third_party/blink/renderer/core/layout/ng/inline/ng_inline_box_state.cc +++ b/third_party/blink/renderer/core/layout/ng/inline/ng_inline_box_state.cc
@@ -416,15 +416,13 @@ // An empty box fragment is still flat that we do not have to defer. // Also, placeholders cannot be reordred if empty. placeholder.rect.offset.inline_offset += box_data.margin_line_left; - // TODO(almaher): Handle inline relative positioning correctly for OOF - // fragmentation. placeholder.rect.offset += ComputeRelativeOffsetForInline(space, *box_data.item->Style()); LayoutUnit advance = box_data.margin_border_padding_line_left + box_data.margin_border_padding_line_right; box_data.rect.size.inline_size = advance - box_data.margin_line_left - box_data.margin_line_right; - placeholder.layout_result = box_data.CreateBoxFragment(line_box); + placeholder.layout_result = box_data.CreateBoxFragment(space, line_box); placeholder.inline_size = advance; DCHECK(!placeholder.children_count); box_data_list_.pop_back(); @@ -686,8 +684,6 @@ for (BoxData& box_data : box_data_list_) { unsigned start = box_data.fragment_start; unsigned end = box_data.fragment_end; - // TODO(almaher): Handle inline relative positioning correctly for OOF - // fragmentation. const LogicalOffset relative_offset = ComputeRelativeOffsetForInline(space, *box_data.item->Style()); @@ -705,6 +701,7 @@ } void NGInlineLayoutStateStack::CreateBoxFragments( + const NGConstraintSpace& space, NGLogicalLineItems* line_box) { DCHECK(!box_data_list_.IsEmpty()); @@ -715,7 +712,7 @@ NGLogicalLineItem* child = &(*line_box)[start]; DCHECK(box_data.item->ShouldCreateBoxFragment()); scoped_refptr<const NGLayoutResult> box_fragment = - box_data.CreateBoxFragment(line_box); + box_data.CreateBoxFragment(space, line_box); if (child->IsPlaceholder()) { child->layout_result = std::move(box_fragment); child->rect = box_data.rect; @@ -735,6 +732,7 @@ scoped_refptr<const NGLayoutResult> NGInlineLayoutStateStack::BoxData::CreateBoxFragment( + const NGConstraintSpace& space, NGLogicalLineItems* line_box) { DCHECK(item); DCHECK(item->Style()); @@ -759,6 +757,11 @@ // supported today. box.SetSidesToInclude({true, has_line_right_edge, true, has_line_left_edge}); + // We don't use ComputeRelativeOffsetForInline() when storing the relative + // offset for OOF descendants to avoid any line-logical conversions. + const LogicalOffset relative_offset = ComputeRelativeOffset( + style, space.GetWritingDirection(), space.AvailableSize()); + for (unsigned i = fragment_start; i < fragment_end; i++) { NGLogicalLineItem& child = (*line_box)[i]; @@ -784,11 +787,8 @@ // Propagate any OOF-positioned descendants from any atomic-inlines, etc. if (child.layout_result) { - // TODO(almaher): Handle the inline case correctly for OOF fragmentation. - // The relative offset should not always be set to LogicalOffset() here. box.PropagateChildData(child.layout_result->PhysicalFragment(), - child.rect.offset - rect.offset, - /* relative_offset */ LogicalOffset()); + child.rect.offset - rect.offset, relative_offset); } // |NGFragmentItems| has a flat list of all descendants, except @@ -800,7 +800,7 @@ // invalidations. item->GetLayoutObject()->SetShouldDoFullPaintInvalidation(); - box.MoveOutOfFlowDescendantCandidatesToDescendants(); + box.MoveOutOfFlowDescendantCandidatesToDescendants(relative_offset); return box.ToInlineBoxFragment(); }
diff --git a/third_party/blink/renderer/core/layout/ng/inline/ng_inline_box_state.h b/third_party/blink/renderer/core/layout/ng/inline/ng_inline_box_state.h index 061acc7..2e957ea9 100644 --- a/third_party/blink/renderer/core/layout/ng/inline/ng_inline_box_state.h +++ b/third_party/blink/renderer/core/layout/ng/inline/ng_inline_box_state.h
@@ -205,7 +205,7 @@ // Create box fragments. This function turns a flat list of children into // a box tree. - void CreateBoxFragments(NGLogicalLineItems*); + void CreateBoxFragments(const NGConstraintSpace&, NGLogicalLineItems*); #if DCHECK_IS_ON() void CheckSame(const NGInlineLayoutStateStack&) const; @@ -292,7 +292,9 @@ void UpdateFragmentEdges(Vector<BoxData, 4>& list); - scoped_refptr<const NGLayoutResult> CreateBoxFragment(NGLogicalLineItems*); + scoped_refptr<const NGLayoutResult> CreateBoxFragment( + const NGConstraintSpace&, + NGLogicalLineItems*); }; Vector<NGInlineBoxState, 4> stack_;
diff --git a/third_party/blink/renderer/core/layout/ng/inline/ng_inline_layout_algorithm.cc b/third_party/blink/renderer/core/layout/ng/inline/ng_inline_layout_algorithm.cc index 6644bc94..26a43b1b 100644 --- a/third_party/blink/renderer/core/layout/ng/inline/ng_inline_layout_algorithm.cc +++ b/third_party/blink/renderer/core/layout/ng/inline/ng_inline_layout_algorithm.cc
@@ -406,7 +406,7 @@ // the children have their layout_result, fragment, (or similar) set to null, // creating a "hole" in the array. if (box_states_->HasBoxFragments()) - box_states_->CreateBoxFragments(line_box); + box_states_->CreateBoxFragments(ConstraintSpace(), line_box); // Update item index of the box states in the context. context_->SetItemIndex(line_info->ItemsData().items, @@ -760,8 +760,6 @@ const auto* physical_fragment = child.PhysicalFragment(); if (!physical_fragment) continue; - // TODO(almaher): Handle inline relative positioning correctly for OOF - // fragmentation. child.rect.offset += ComputeRelativeOffsetForInline( ConstraintSpace(), physical_fragment->Style()); }
diff --git a/third_party/blink/renderer/core/layout/ng/inline/ng_line_box_fragment_builder.cc b/third_party/blink/renderer/core/layout/ng/inline/ng_line_box_fragment_builder.cc index 984f06e7..378fb20 100644 --- a/third_party/blink/renderer/core/layout/ng/inline/ng_line_box_fragment_builder.cc +++ b/third_party/blink/renderer/core/layout/ng/inline/ng_line_box_fragment_builder.cc
@@ -43,8 +43,6 @@ for (unsigned index = 0; index < children.size(); ++index) { auto& child = children[index]; if (child.layout_result) { - // TODO(almaher): Handle the inline case correctly for OOF fragmentation. - // The relative offset should not always be set to LogicalOffset() here. PropagateChildData(child.layout_result->PhysicalFragment(), child.Offset(), /* relative_offset */ LogicalOffset()); @@ -65,7 +63,8 @@ } DCHECK(oof_positioned_descendants_.IsEmpty()); - MoveOutOfFlowDescendantCandidatesToDescendants(); + MoveOutOfFlowDescendantCandidatesToDescendants( + /* relative_offset */ LogicalOffset()); } scoped_refptr<const NGLayoutResult>
diff --git a/third_party/blink/renderer/core/layout/ng/ng_box_fragment_builder.cc b/third_party/blink/renderer/core/layout/ng/ng_box_fragment_builder.cc index 18965cdf..ab8f5f1 100644 --- a/third_party/blink/renderer/core/layout/ng/ng_box_fragment_builder.cc +++ b/third_party/blink/renderer/core/layout/ng/ng_box_fragment_builder.cc
@@ -124,7 +124,7 @@ void NGBoxFragmentBuilder::AddChild( const NGPhysicalFragment& child, const LogicalOffset& child_offset, - const LayoutInline* inline_container, + const NGInlineContainer<LogicalOffset>* inline_container, const NGMarginStrut* margin_strut, bool is_self_collapsing, absl::optional<LogicalOffset> relative_offset, @@ -270,10 +270,12 @@ NGBlockNode node, const NGLogicalStaticPosition& static_position, const LayoutInline* inline_container) { + if (inline_container) + inline_container = To<LayoutInline>(inline_container->ContinuationRoot()); oof_positioned_candidates_.emplace_back( node, static_position, - inline_container ? To<LayoutInline>(inline_container->ContinuationRoot()) - : nullptr); + NGInlineContainer<LogicalOffset>(inline_container, + /* relative_offset */ LogicalOffset())); } NGPhysicalFragment::NGBoxType NGBoxFragmentBuilder::BoxType() const {
diff --git a/third_party/blink/renderer/core/layout/ng/ng_box_fragment_builder.h b/third_party/blink/renderer/core/layout/ng/ng_box_fragment_builder.h index 3cdba517..d29bbf8 100644 --- a/third_party/blink/renderer/core/layout/ng/ng_box_fragment_builder.h +++ b/third_party/blink/renderer/core/layout/ng/ng_box_fragment_builder.h
@@ -210,7 +210,7 @@ void AddChild( const NGPhysicalFragment&, const LogicalOffset&, - const LayoutInline* inline_container = nullptr, + const NGInlineContainer<LogicalOffset>* inline_container = nullptr, const NGMarginStrut* margin_strut = nullptr, bool is_self_collapsing = false, absl::optional<LogicalOffset> relative_offset = absl::nullopt,
diff --git a/third_party/blink/renderer/core/layout/ng/ng_container_fragment_builder.cc b/third_party/blink/renderer/core/layout/ng/ng_container_fragment_builder.cc index b4a0d99..8fe23be 100644 --- a/third_party/blink/renderer/core/layout/ng/ng_container_fragment_builder.cc +++ b/third_party/blink/renderer/core/layout/ng/ng_container_fragment_builder.cc
@@ -39,7 +39,7 @@ const NGPhysicalFragment& child, LogicalOffset child_offset, LogicalOffset relative_offset, - const LayoutInline* inline_container, + const NGInlineContainer<LogicalOffset>* inline_container, absl::optional<LayoutUnit> adjustment_for_oof_propagation) { if (adjustment_for_oof_propagation) { PropagateOOFPositionedInfo(child, child_offset, relative_offset, @@ -159,7 +159,7 @@ oof_positioned_candidates_.emplace_back( child, NGLogicalStaticPosition{child_offset, inline_edge, block_edge}, - /* inline_container */ nullptr, needs_block_offset_adjustment, + NGInlineContainer<LogicalOffset>(), needs_block_offset_adjustment, /* containing_block */ NGContainingBlock<LogicalOffset>(), /* fixedpos_containing_block */ NGContainingBlock<LogicalOffset>(), containing_block_rect); @@ -269,8 +269,8 @@ oof_positioned_candidates_.clear(); } -void NGContainerFragmentBuilder:: - MoveOutOfFlowDescendantCandidatesToDescendants() { +void NGContainerFragmentBuilder::MoveOutOfFlowDescendantCandidatesToDescendants( + LogicalOffset relative_offset) { DCHECK(oof_positioned_descendants_.IsEmpty()); std::swap(oof_positioned_candidates_, oof_positioned_descendants_); @@ -284,14 +284,16 @@ // // This checks if the object creating this box will be the container for // the given descendant. - if (!candidate.inline_container && - IsInlineContainerForNode(candidate.Node(), layout_object_)) - candidate.inline_container = To<LayoutInline>(layout_object_); + if (!candidate.inline_container.container && + IsInlineContainerForNode(candidate.Node(), layout_object_)) { + candidate.inline_container = NGInlineContainer<LogicalOffset>( + To<LayoutInline>(layout_object_), relative_offset); + } // Ensure that the inline_container is a continuation root. - if (candidate.inline_container) { - candidate.inline_container = - To<LayoutInline>(candidate.inline_container->ContinuationRoot()); + if (candidate.inline_container.container) { + candidate.inline_container.container = To<LayoutInline>( + candidate.inline_container.container->ContinuationRoot()); } } } @@ -301,11 +303,16 @@ LogicalOffset offset, LogicalOffset relative_offset, LogicalOffset offset_adjustment, - const LayoutInline* inline_container, + const NGInlineContainer<LogicalOffset>* inline_container, LayoutUnit containing_block_adjustment, const NGContainingBlock<LogicalOffset>* fixedpos_containing_block, LogicalOffset additional_fixedpos_offset) { - LogicalOffset adjusted_offset = offset + relative_offset + offset_adjustment; + LogicalOffset adjusted_offset = offset + offset_adjustment; + + // The relative offset is already applied for inlines, so don't include it + // in the |adjusted_offset|, as well. + if (!fragment.IsInlineBox()) + adjusted_offset += relative_offset; // Collect the child's out of flow descendants. const WritingModeConverter converter(GetWritingDirection(), fragment.Size()); @@ -314,10 +321,17 @@ NGLogicalStaticPosition static_position = descendant.StaticPosition().ConvertToLogical(converter); - const LayoutInline* new_inline_container = descendant.inline_container; - if (!new_inline_container && - IsInlineContainerForNode(node, inline_container)) - new_inline_container = inline_container; + NGInlineContainer<LogicalOffset> new_inline_container; + if (descendant.inline_container.container) { + new_inline_container.container = descendant.inline_container.container; + new_inline_container.relative_offset = + converter.ToLogical(descendant.inline_container.relative_offset, + PhysicalSize()) + + relative_offset; + } else if (inline_container && + IsInlineContainerForNode(node, inline_container->container)) { + new_inline_container = *inline_container; + } // If an OOF element is inside a fragmentation context, it will be laid out // once it reaches the fragmentation context root. However, if such OOF @@ -472,6 +486,11 @@ fixedpos_containing_block->relative_offset; } + LogicalOffset inline_relative_offset = converter.ToLogical( + descendant.inline_container.relative_offset, PhysicalSize()); + NGInlineContainer<LogicalOffset> new_inline_container( + descendant.inline_container.container, inline_relative_offset); + // The static position should remain relative to its containing block // fragment. const WritingModeConverter containing_block_converter( @@ -479,8 +498,16 @@ NGLogicalStaticPosition static_position = descendant.StaticPosition().ConvertToLogical( containing_block_converter); + + // The relative offset should be applied after fragmentation. Subtract out + // the accumulated relative offset from the inline container to the + // containing block so that it can be re-applied at the correct time. + if (new_inline_container.container && + containing_block_fragment == box_fragment) + static_position.offset -= inline_relative_offset; + AddOutOfFlowFragmentainerDescendant( - {descendant.Node(), static_position, descendant.inline_container, + {descendant.Node(), static_position, new_inline_container, /* needs_block_offset_adjustment */ false, NGContainingBlock<LogicalOffset>(containing_block_offset, containing_block_rel_offset,
diff --git a/third_party/blink/renderer/core/layout/ng/ng_container_fragment_builder.h b/third_party/blink/renderer/core/layout/ng/ng_container_fragment_builder.h index c70ca738..ab52aaa8 100644 --- a/third_party/blink/renderer/core/layout/ng/ng_container_fragment_builder.h +++ b/third_party/blink/renderer/core/layout/ng/ng_container_fragment_builder.h
@@ -206,7 +206,8 @@ // position OOF candidates yet, (as a containing box may be split over // multiple lines), instead we bubble all the descendants up to the parent // block layout algorithm, to perform the final OOF layout and positioning. - void MoveOutOfFlowDescendantCandidatesToDescendants(); + void MoveOutOfFlowDescendantCandidatesToDescendants( + LogicalOffset relative_offset); // Propagate the OOF descendants from a fragment to the builder. Since the OOF // descendants on the fragment are NGPhysicalOutOfFlowPositionedNodes, we @@ -218,7 +219,7 @@ LogicalOffset offset, LogicalOffset relative_offset, LogicalOffset offset_adjustment = LogicalOffset(), - const LayoutInline* inline_container = nullptr, + const NGInlineContainer<LogicalOffset>* inline_container = nullptr, LayoutUnit containing_block_adjustment = LayoutUnit(), const NGContainingBlock<LogicalOffset>* fixedpos_containing_block = nullptr, @@ -295,7 +296,7 @@ const NGPhysicalFragment& child, LogicalOffset child_offset, LogicalOffset relative_offset, - const LayoutInline* inline_container = nullptr, + const NGInlineContainer<LogicalOffset>* inline_container = nullptr, absl::optional<LayoutUnit> adjustment_for_oof_propagation = LayoutUnit()); void AddChildInternal(scoped_refptr<const NGPhysicalFragment>,
diff --git a/third_party/blink/renderer/core/layout/ng/ng_out_of_flow_layout_part.cc b/third_party/blink/renderer/core/layout/ng/ng_out_of_flow_layout_part.cc index 70e575d..53523358 100644 --- a/third_party/blink/renderer/core/layout/ng/ng_out_of_flow_layout_part.cc +++ b/third_party/blink/renderer/core/layout/ng/ng_out_of_flow_layout_part.cc
@@ -182,11 +182,11 @@ if (absolute_containing_block && absolute_containing_block->CanContainOutOfFlowPositionedElement( candidate.Node().Style().GetPosition())) { - candidate.inline_container = absolute_containing_block; + candidate.inline_container.container = absolute_containing_block; } else if (fixed_containing_block && fixed_containing_block->CanContainOutOfFlowPositionedElement( candidate.Node().Style().GetPosition())) { - candidate.inline_container = fixed_containing_block; + candidate.inline_container.container = fixed_containing_block; } container_builder_->AddOutOfFlowDescendant(candidate); } @@ -308,8 +308,9 @@ const NGLogicalOutOfFlowPositionedNode& candidate) { if (candidate.containing_block_rect) return {default_writing_direction_, *candidate.containing_block_rect}; - if (candidate.inline_container) { - const auto it = containing_blocks_map_.find(candidate.inline_container); + if (candidate.inline_container.container) { + const auto it = + containing_blocks_map_.find(candidate.inline_container.container); DCHECK(it != containing_blocks_map_.end()); return it->value; } @@ -363,11 +364,12 @@ inline_container_fragments; for (auto& candidate : candidates) { - if (candidate.inline_container && - !inline_container_fragments.Contains(candidate.inline_container)) { + if (candidate.inline_container.container && + !inline_container_fragments.Contains( + candidate.inline_container.container)) { InlineContainingBlockUtils::InlineContainingBlockGeometry inline_geometry = {}; - inline_container_fragments.insert(candidate.inline_container, + inline_container_fragments.insert(candidate.inline_container.container, inline_geometry); } } @@ -396,23 +398,30 @@ LayoutUnit block_size; // The fragmentainer index the containing block starts in. wtf_size_t fragmentainer_index; + // The relative offset of the inline's containing block to the + // fragmentation context root. + LogicalOffset relative_offset; }; HashMap<const LayoutBox*, InlineContainingBlockInfo> inline_containg_blocks; // Collect the inline containers by shared containing block. for (auto& descendant : descendants) { - if (descendant.inline_container) { + if (descendant.inline_container.container) { DCHECK(descendant.containing_block.fragment); const LayoutBox* containing_block = To<LayoutBox>( descendant.containing_block.fragment->GetLayoutObject()); InlineContainingBlockUtils::InlineContainingBlockGeometry inline_geometry = {}; + inline_geometry.relative_offset = + descendant.inline_container.relative_offset; auto it = inline_containg_blocks.find(containing_block); if (it != inline_containg_blocks.end()) { - if (!it->value.map.Contains(descendant.inline_container)) - it->value.map.insert(descendant.inline_container, inline_geometry); + if (!it->value.map.Contains(descendant.inline_container.container)) { + it->value.map.insert(descendant.inline_container.container, + inline_geometry); + } continue; } // Find the fragmentainer that the containing block starts in and the @@ -428,9 +437,11 @@ &start_index, &offset); InlineContainingBlockUtils::InlineContainingBlockMap inline_containers; - inline_containers.insert(descendant.inline_container, inline_geometry); + inline_containers.insert(descendant.inline_container.container, + inline_geometry); InlineContainingBlockInfo inline_info{ - inline_containers, offset.block_offset, block_size, start_index}; + inline_containers, offset.block_offset, block_size, start_index, + descendant.containing_block.relative_offset}; inline_containg_blocks.insert(containing_block, inline_info); } } @@ -450,11 +461,11 @@ container_builder_physical_size, *container_builder_, inline_info.fragmentainer_index, &inline_info.map); - // TODO(almaher): Set |relative_offset| and |offset_to_border_box| in the - // final containing block info that gets created. + // TODO(almaher): Set |offset_to_border_box| in the final containing block + // info that gets created. AddInlineContainingBlockInfo( inline_info.map, containing_block->StyleRef().GetWritingDirection(), - container_builder_physical_size); + container_builder_physical_size, inline_info.relative_offset); } } @@ -462,7 +473,8 @@ const InlineContainingBlockUtils::InlineContainingBlockMap& inline_container_fragments, const WritingDirectionMode container_writing_direction, - PhysicalSize container_builder_size) { + PhysicalSize container_builder_size, + LogicalOffset containing_block_relative_offset) { // Transform the start/end fragments into a ContainingBlockInfo. for (const auto& block_info : inline_container_fragments) { DCHECK(block_info.value.has_value()); @@ -563,6 +575,7 @@ std::max(end_offset.inline_offset, start_offset.inline_offset); end_offset.block_offset = std::max(end_offset.block_offset, start_offset.block_offset); + // Step 3 - determine the logical rectangle. // Determine the logical size of the containing block. @@ -572,10 +585,22 @@ DCHECK_GE(inline_cb_size.inline_size, LayoutUnit()); DCHECK_GE(inline_cb_size.block_size, LayoutUnit()); + // Subtract out the inline relative offset, if set, so that it can be + // applied after fragmentation is performed on the fragmentainer + // descendants. + DCHECK((block_info.value->relative_offset == LogicalOffset() && + containing_block_relative_offset == LogicalOffset()) || + container_builder_->IsBlockFragmentationContextRoot()); + LogicalOffset container_offset = + start_offset - block_info.value->relative_offset; + LogicalOffset total_relative_offset = + containing_block_relative_offset + block_info.value->relative_offset; + containing_blocks_map_.insert( block_info.key, ContainingBlockInfo{inline_writing_direction, - LogicalRect(start_offset, inline_cb_size)}); + LogicalRect(container_offset, inline_cb_size), + total_relative_offset}); } } @@ -608,7 +633,7 @@ LayoutOOFNode(node_to_layout, only_layout); container_builder_->AddChild(result->PhysicalFragment(), result->OutOfFlowPositionedOffset(), - candidate.inline_container); + &candidate.inline_container); placed_objects->insert(layout_box); } else { container_builder_->AddOutOfFlowDescendant(candidate); @@ -779,6 +804,11 @@ fixedpos_containing_block_fragment->Size()); } + NGInlineContainer<LogicalOffset> inline_container( + descendant.inline_container.container, + converter.ToLogical(descendant.inline_container.relative_offset, + PhysicalSize())); + // The static position should remain relative to its containing block // fragment. const WritingModeConverter containing_block_converter( @@ -790,7 +820,7 @@ NGLogicalOutOfFlowPositionedNode node = { descendant.Node(), static_position, - descendant.inline_container, + inline_container, /* needs_block_offset_adjustment */ false, NGContainingBlock<LogicalOffset>(containing_block_offset, containing_block_rel_offset, @@ -1042,7 +1072,7 @@ default_writing_direction, /* is_fragmentainer_descendant */ containing_block_fragment, oof_node.fixedpos_containing_block, - oof_node.inline_container); + oof_node.inline_container.container); } scoped_refptr<const NGLayoutResult> NGOutOfFlowLayoutPart::LayoutOOFNode( @@ -1255,9 +1285,9 @@ // Candidates whose containing block is inline are always positioned inside // closest parent block flow. - if (candidate.inline_container) { - DCHECK(candidate.inline_container->CanContainOutOfFlowPositionedElement( - position)); + if (candidate.inline_container.container) { + DCHECK(candidate.inline_container.container + ->CanContainOutOfFlowPositionedElement(position)); return container_builder_->GetLayoutObject() == candidate.box->ContainingBlock(); }
diff --git a/third_party/blink/renderer/core/layout/ng/ng_out_of_flow_layout_part.h b/third_party/blink/renderer/core/layout/ng/ng_out_of_flow_layout_part.h index 3c097ce..c35ac957 100644 --- a/third_party/blink/renderer/core/layout/ng/ng_out_of_flow_layout_part.h +++ b/third_party/blink/renderer/core/layout/ng/ng_out_of_flow_layout_part.h
@@ -194,7 +194,8 @@ void AddInlineContainingBlockInfo( const InlineContainingBlockUtils::InlineContainingBlockMap&, const WritingDirectionMode container_writing_direction, - PhysicalSize container_builder_size); + PhysicalSize container_builder_size, + LogicalOffset containing_block_relative_offset = LogicalOffset()); void LayoutCandidates(Vector<NGLogicalOutOfFlowPositionedNode>* candidates, const LayoutBox* only_layout,
diff --git a/third_party/blink/renderer/core/layout/ng/ng_out_of_flow_positioned_node.h b/third_party/blink/renderer/core/layout/ng/ng_out_of_flow_positioned_node.h index a40e61da..a10e87c 100644 --- a/third_party/blink/renderer/core/layout/ng/ng_out_of_flow_positioned_node.h +++ b/third_party/blink/renderer/core/layout/ng/ng_out_of_flow_positioned_node.h
@@ -43,6 +43,25 @@ fragment(std::move(fragment)) {} }; +// This holds the containing block for an out-of-flow positioned element +// if the containing block is a non-atomic inline. It is the continuation +// root (i.e. the first LayoutInline in the continuation chain for the same +// node) if continuations are involved. +template <typename OffsetType> +struct NGInlineContainer { + DISALLOW_NEW(); + + public: + const LayoutInline* container = nullptr; + // Store the relative offset so that it can be applied after fragmentation, + // if inside a fragmentation context. + OffsetType relative_offset; + + NGInlineContainer() = default; + NGInlineContainer(const LayoutInline* container, OffsetType relative_offset) + : container(container), relative_offset(relative_offset) {} +}; + // If an out-of-flow positioned element is inside a nested fragmentation // context, it will be laid out once it reaches the outermost fragmentation // context root. A multicol with pending OOFs is the inner multicol information @@ -96,21 +115,22 @@ unsigned static_position_vertical_edge : 2; // Whether or not this is an NGPhysicalOOFNodeForFragmentation. unsigned is_for_fragmentation : 1; - // Continuation root of the optional inline container. - const LayoutInline* inline_container; + NGInlineContainer<PhysicalOffset> inline_container; NGPhysicalOutOfFlowPositionedNode( NGBlockNode node, NGPhysicalStaticPosition static_position, - const LayoutInline* inline_container = nullptr) + NGInlineContainer<PhysicalOffset> inline_container = + NGInlineContainer<PhysicalOffset>()) : box(node.GetLayoutBox()), static_position(static_position.offset), static_position_horizontal_edge(static_position.horizontal_edge), static_position_vertical_edge(static_position.vertical_edge), is_for_fragmentation(false), inline_container(inline_container) { - DCHECK(!inline_container || - inline_container == inline_container->ContinuationRoot()); + DCHECK(!inline_container.container || + inline_container.container == + inline_container.container->ContinuationRoot()); DCHECK(node.IsBlock()); } @@ -155,7 +175,8 @@ NGPhysicalOOFNodeForFragmentation( NGBlockNode node, NGPhysicalStaticPosition static_position, - const LayoutInline* inline_container = nullptr, + NGInlineContainer<PhysicalOffset> inline_container = + NGInlineContainer<PhysicalOffset>(), NGContainingBlock<PhysicalOffset> containing_block = NGContainingBlock<PhysicalOffset>(), NGContainingBlock<PhysicalOffset> fixedpos_containing_block = @@ -181,8 +202,7 @@ public: LayoutBox* box; NGLogicalStaticPosition static_position; - // Continuation root of the optional inline container. - const LayoutInline* inline_container; + NGInlineContainer<LogicalOffset> inline_container; bool needs_block_offset_adjustment; const LayoutUnit fragmentainer_consumed_block_size; NGContainingBlock<LogicalOffset> containing_block; @@ -192,7 +212,8 @@ NGLogicalOutOfFlowPositionedNode( NGBlockNode node, NGLogicalStaticPosition static_position, - const LayoutInline* inline_container = nullptr, + NGInlineContainer<LogicalOffset> inline_container = + NGInlineContainer<LogicalOffset>(), bool needs_block_offset_adjustment = false, NGContainingBlock<LogicalOffset> containing_block = NGContainingBlock<LogicalOffset>(), @@ -206,8 +227,9 @@ containing_block(containing_block), fixedpos_containing_block(fixedpos_containing_block), containing_block_rect(containing_block_rect) { - DCHECK(!inline_container || - inline_container == inline_container->ContinuationRoot()); + DCHECK(!inline_container.container || + inline_container.container == + inline_container.container->ContinuationRoot()); DCHECK(node.IsBlock()); }
diff --git a/third_party/blink/renderer/core/layout/ng/ng_physical_box_fragment.cc b/third_party/blink/renderer/core/layout/ng/ng_physical_box_fragment.cc index e778bb16..587b7f77 100644 --- a/third_party/blink/renderer/core/layout/ng/ng_physical_box_fragment.cc +++ b/third_party/blink/renderer/core/layout/ng/ng_physical_box_fragment.cc
@@ -482,19 +482,26 @@ builder->oof_positioned_fragmentainer_descendants_.size()); for (const auto& descendant : builder->oof_positioned_fragmentainer_descendants_) { + WritingDirectionMode writing_direction = builder->GetWritingDirection(); + const WritingModeConverter converter(writing_direction, size); + NGInlineContainer<PhysicalOffset> inline_container( + descendant.inline_container.container, + converter.ToPhysical(descendant.inline_container.relative_offset, + PhysicalSize())); + // The static position should remain relative to the containing block. PhysicalSize containing_block_size = descendant.containing_block.fragment ? descendant.containing_block.fragment->Size() : size; - WritingDirectionMode writing_direction = builder->GetWritingDirection(); - const WritingModeConverter converter(writing_direction, - containing_block_size); + const WritingModeConverter containing_block_converter( + writing_direction, containing_block_size); oof_positioned_fragmentainer_descendants.emplace_back( descendant.Node(), - descendant.static_position.ConvertToPhysical(converter), - descendant.inline_container, + descendant.static_position.ConvertToPhysical( + containing_block_converter), + inline_container, PhysicalContainingBlock(builder, size, containing_block_size, descendant.containing_block), PhysicalContainingBlock(builder, size,
diff --git a/third_party/blink/renderer/core/layout/ng/ng_physical_fragment.cc b/third_party/blink/renderer/core/layout/ng/ng_physical_fragment.cc index 20e15e4..7c54dad4 100644 --- a/third_party/blink/renderer/core/layout/ng/ng_physical_fragment.cc +++ b/third_party/blink/renderer/core/layout/ng/ng_physical_fragment.cc
@@ -368,10 +368,14 @@ const WritingModeConverter converter( {builder->Style().GetWritingMode(), builder->Direction()}, size); for (const auto& descendant : builder->oof_positioned_descendants_) { + NGInlineContainer<PhysicalOffset> inline_container( + descendant.inline_container.container, + converter.ToPhysical(descendant.inline_container.relative_offset, + PhysicalSize())); oof_positioned_descendants_->emplace_back( descendant.Node(), descendant.static_position.ConvertToPhysical(converter), - descendant.inline_container); + inline_container); } } }
diff --git a/third_party/blink/renderer/core/layout/ng/table/layout_ng_table.cc b/third_party/blink/renderer/core/layout/ng/table/layout_ng_table.cc index 32df197..91ec288 100644 --- a/third_party/blink/renderer/core/layout/ng/table/layout_ng_table.cc +++ b/third_party/blink/renderer/core/layout/ng/table/layout_ng_table.cc
@@ -267,13 +267,6 @@ } #endif -void LayoutNGTable::Paint(const PaintInfo& paint_info) const { - NOT_DESTROYED(); - DCHECK_EQ(PhysicalFragmentCount(), 1u); - NGBoxFragmentPainter(*LayoutNGMixin<LayoutBlock>::GetPhysicalFragment(0)) - .Paint(paint_info); -} - LayoutUnit LayoutNGTable::BorderLeft() const { NOT_DESTROYED(); // DCHECK(cached_table_borders_.get())
diff --git a/third_party/blink/renderer/core/layout/ng/table/layout_ng_table.h b/third_party/blink/renderer/core/layout/ng/table/layout_ng_table.h index c87c5732..1d441e5 100644 --- a/third_party/blink/renderer/core/layout/ng/table/layout_ng_table.h +++ b/third_party/blink/renderer/core/layout/ng/table/layout_ng_table.h
@@ -90,8 +90,6 @@ LayoutBox* CreateAnonymousBoxWithSameTypeAs( const LayoutObject* parent) const override; - void Paint(const PaintInfo&) const final; - LayoutUnit BorderTop() const override; LayoutUnit BorderBottom() const override;
diff --git a/third_party/blink/renderer/core/layout/ng/table/ng_table_borders.cc b/third_party/blink/renderer/core/layout/ng/table/ng_table_borders.cc index 30b2bce..da34d5e 100644 --- a/third_party/blink/renderer/core/layout/ng/table/ng_table_borders.cc +++ b/third_party/blink/renderer/core/layout/ng/table/ng_table_borders.cc
@@ -43,73 +43,6 @@ return source_style > edge_border_style; } -// Side of the style the collapsed border belongs to. -enum class LogicalEdgeSide { kInlineStart, kInlineEnd, kBlockStart, kBlockEnd }; - -NGTableBorders::EdgeSide LogicalEdgeToPhysical( - LogicalEdgeSide logical_side, - WritingDirectionMode table_writing_direction) { - // https://www.w3.org/TR/css-writing-modes-4/#logical-to-physical - switch (logical_side) { - case LogicalEdgeSide::kInlineStart: - switch (table_writing_direction.GetWritingMode()) { - case WritingMode::kHorizontalTb: - return table_writing_direction.Direction() == TextDirection::kLtr - ? NGTableBorders::EdgeSide::kLeft - : NGTableBorders::EdgeSide::kRight; - case WritingMode::kVerticalLr: - case WritingMode::kVerticalRl: - case WritingMode::kSidewaysRl: - return table_writing_direction.Direction() == TextDirection::kLtr - ? NGTableBorders::EdgeSide::kTop - : NGTableBorders::EdgeSide::kBottom; - case WritingMode::kSidewaysLr: - return table_writing_direction.Direction() == TextDirection::kLtr - ? NGTableBorders::EdgeSide::kBottom - : NGTableBorders::EdgeSide::kTop; - } - case LogicalEdgeSide::kInlineEnd: - switch (table_writing_direction.GetWritingMode()) { - case WritingMode::kHorizontalTb: - return table_writing_direction.Direction() == TextDirection::kLtr - ? NGTableBorders::EdgeSide::kRight - : NGTableBorders::EdgeSide::kLeft; - case WritingMode::kVerticalLr: - case WritingMode::kVerticalRl: - case WritingMode::kSidewaysRl: - return table_writing_direction.Direction() == TextDirection::kLtr - ? NGTableBorders::EdgeSide::kBottom - : NGTableBorders::EdgeSide::kTop; - case WritingMode::kSidewaysLr: - return table_writing_direction.Direction() == TextDirection::kLtr - ? NGTableBorders::EdgeSide::kTop - : NGTableBorders::EdgeSide::kBottom; - } - case LogicalEdgeSide::kBlockStart: - switch (table_writing_direction.GetWritingMode()) { - case WritingMode::kHorizontalTb: - return NGTableBorders::EdgeSide::kTop; - case WritingMode::kVerticalLr: - case WritingMode::kSidewaysLr: - return NGTableBorders::EdgeSide::kLeft; - case WritingMode::kVerticalRl: - case WritingMode::kSidewaysRl: - return NGTableBorders::EdgeSide::kRight; - } - case LogicalEdgeSide::kBlockEnd: - switch (table_writing_direction.GetWritingMode()) { - case WritingMode::kHorizontalTb: - return NGTableBorders::EdgeSide::kBottom; - case WritingMode::kVerticalLr: - case WritingMode::kSidewaysLr: - return NGTableBorders::EdgeSide::kRight; - case WritingMode::kVerticalRl: - case WritingMode::kSidewaysRl: - return NGTableBorders::EdgeSide::kLeft; - } - } -} - class ColBordersMarker { STACK_ALLOCATED(); @@ -575,22 +508,20 @@ EnsureCellRowFits(cell_start_row + clamped_rowspan - 1); } } + + PhysicalToLogical<EdgeSide> edge_side(table_writing_direction, EdgeSide::kTop, + EdgeSide::kRight, EdgeSide::kBottom, + EdgeSide::kLeft); MergeRowAxisBorder(cell_start_row, cell_start_column, clamped_colspan, - source_style, box_order, - LogicalEdgeToPhysical(LogicalEdgeSide::kBlockStart, - table_writing_direction)); + source_style, box_order, edge_side.BlockStart()); MergeRowAxisBorder(cell_start_row + clamped_rowspan, cell_start_column, clamped_colspan, source_style, box_order, - LogicalEdgeToPhysical(LogicalEdgeSide::kBlockEnd, - table_writing_direction)); + edge_side.BlockEnd()); MergeColumnAxisBorder(cell_start_row, cell_start_column, clamped_rowspan, - source_style, box_order, - LogicalEdgeToPhysical(LogicalEdgeSide::kInlineStart, - table_writing_direction)); + source_style, box_order, edge_side.InlineStart()); MergeColumnAxisBorder(cell_start_row, cell_start_column + clamped_colspan, clamped_rowspan, source_style, box_order, - LogicalEdgeToPhysical(LogicalEdgeSide::kInlineEnd, - table_writing_direction)); + edge_side.InlineEnd()); if (mark_inner_borders) { MarkInnerBordersAsDoNotFill(cell_start_row, cell_start_column, clamped_rowspan, clamped_colspan);
diff --git a/third_party/blink/renderer/core/loader/resource/image_resource.cc b/third_party/blink/renderer/core/loader/resource/image_resource.cc index 8c35036d..2849ca2d5 100644 --- a/third_party/blink/renderer/core/loader/resource/image_resource.cc +++ b/third_party/blink/renderer/core/loader/resource/image_resource.cc
@@ -240,8 +240,8 @@ Resource::OnMemoryDump(level_of_detail, memory_dump); const String name = GetMemoryDumpName() + "/image_content"; auto* dump = memory_dump->CreateMemoryAllocatorDump(name); - if (content_->HasImage() && content_->GetImage()->Data()) - dump->AddScalar("size", "bytes", content_->GetImage()->Data()->size()); + if (content_->HasImage() && content_->GetImage()->HasData()) + dump->AddScalar("size", "bytes", content_->GetImage()->DataSize()); } void ImageResource::Trace(Visitor* visitor) const {
diff --git a/third_party/blink/renderer/core/loader/resource/image_resource_content.cc b/third_party/blink/renderer/core/loader/resource/image_resource_content.cc index ac259cb7..67fec1a 100644 --- a/third_party/blink/renderer/core/loader/resource/image_resource_content.cc +++ b/third_party/blink/renderer/core/loader/resource/image_resource_content.cc
@@ -300,7 +300,7 @@ void ImageResourceContent::ClearImage() { if (!image_) return; - int64_t length = image_->Data() ? image_->Data()->size() : 0; + int64_t length = image_->HasData() ? image_->DataSize() : 0; v8::Isolate::GetCurrent()->AdjustAmountOfExternalAllocatedMemory(-length); // If our Image has an observer, it's always us so we need to clear the back @@ -488,9 +488,9 @@ double resource_length = static_cast<double>(GetResponse().ExpectedContentLength()); - if (resource_length <= 0 && image_->Data()) { + if (resource_length <= 0 && image_->HasData()) { // WPT and LayoutTests server returns -1 or 0 for the content length. - resource_length = static_cast<double>(image_->Data()->size()); + resource_length = static_cast<double>(image_->DataSize()); } // Calculate the image's compression ratio (in bytes per pixel) with both 1k
diff --git a/third_party/blink/renderer/core/paint/compositing/compositing_test.cc b/third_party/blink/renderer/core/paint/compositing/compositing_test.cc index d0d49c6..72db3ec2 100644 --- a/third_party/blink/renderer/core/paint/compositing/compositing_test.cc +++ b/third_party/blink/renderer/core/paint/compositing/compositing_test.cc
@@ -2393,4 +2393,35 @@ EXPECT_TRUE(snap_up->GetRecordingSourceForTesting()->is_solid_color()); } +// While not required for correctness, it is important for performance (e.g., +// the MotionMark Focus benchmark) that we do not decomposite effect nodes (see: +// |PaintArtifactCompositor::DecompositeEffect|) when the author has specified +// 3D transforms which are frequently used as a generic compositing trigger. +TEST_P(CompositingSimTest, EffectCompositedWith3DTransform) { + InitializeWithHTML(R"HTML( + <!DOCTYPE html> + <style> + div { + width: 100px; + height: 100px; + background: rebeccapurple; + transform: translate3d(1px, 1px, 0); + } + </style> + <div id="opacity" style="opacity: 0.5;"></div> + <div id="filter" style="filter: blur(1px);"></div> + )HTML"); + Compositor().BeginFrame(); + + auto* opacity_effect = GetEffectNode(CcLayerByDOMElementId("opacity")); + EXPECT_TRUE(opacity_effect); + EXPECT_EQ(opacity_effect->opacity, 0.5f); + EXPECT_TRUE(opacity_effect->filters.IsEmpty()); + + auto* filter_effect = GetEffectNode(CcLayerByDOMElementId("filter")); + EXPECT_TRUE(filter_effect); + EXPECT_EQ(filter_effect->opacity, 1.f); + EXPECT_FALSE(filter_effect->filters.IsEmpty()); +} + } // namespace blink
diff --git a/third_party/blink/renderer/core/paint/image_painter.cc b/third_party/blink/renderer/core/paint/image_painter.cc index d02bb3c4..9513652 100644 --- a/third_party/blink/renderer/core/paint/image_painter.cc +++ b/third_party/blink/renderer/core/paint/image_painter.cc
@@ -255,7 +255,7 @@ // Does not set an observer for the placeholder image, setting it to null. scoped_refptr<PlaceholderImage> placeholder_image = PlaceholderImage::Create(nullptr, image->Size(), - image->Data() ? image->Data()->size() : 0); + image->HasData() ? image->DataSize() : 0); placeholder_image->SetIconAndTextScaleFactor( layout_image_.GetFrame()->PageZoomFactor()); image = std::move(placeholder_image);
diff --git a/third_party/blink/renderer/core/paint/paint_invalidator.cc b/third_party/blink/renderer/core/paint/paint_invalidator.cc index 72bc523..648f2c0b 100644 --- a/third_party/blink/renderer/core/paint/paint_invalidator.cc +++ b/third_party/blink/renderer/core/paint/paint_invalidator.cc
@@ -323,6 +323,9 @@ } #endif // DCHECK_IS_ON() + if (AXObjectCache* cache = object.GetDocument().ExistingAXObjectCache()) + cache->InvalidateBoundingBox(&object); + if (!object.ShouldCheckForPaintInvalidation() && !context.NeedsSubtreeWalk()) return false; @@ -401,9 +404,6 @@ mf_checker->NotifyInvalidatePaint(object); } - if (AXObjectCache* cache = object.GetDocument().ExistingAXObjectCache()) - cache->InvalidateBoundingBox(&object); - return reason != PaintInvalidationReason::kNone; }
diff --git a/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc b/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc index 3dd46b77..510a103 100644 --- a/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc +++ b/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc
@@ -6971,28 +6971,4 @@ EXPECT_EQ(FloatPoint3D(100, 100, 0), transform_node->Origin()); } -// While not required for correctness, it is important for performance (e.g., -// the MotionMark Focus benchmark) that we do not decomposite effect nodes when -// the author has specified 3d transforms (see: -// |PaintArtifactCompositor::DecompositeEffect|). -TEST_P(PaintPropertyTreeBuilderTest, EffectDirectCompositingReasonWith3D) { - if (!RuntimeEnabledFeatures::CompositeAfterPaintEnabled()) - return; - SetBodyInnerHTML(R"HTML( - <style> - #target { - width: 100px; - height: 100px; - transform: translate3d(1px, 1px, 0); - opacity: 0.5; - filter: blur(1px); - } - </style> - <div id="target"></div> - )HTML"); - const auto* properties = PaintPropertiesForElement("target"); - EXPECT_TRUE(properties->Effect()->HasDirectCompositingReasons()); - EXPECT_TRUE(properties->Filter()->HasDirectCompositingReasons()); -} - } // namespace blink
diff --git a/third_party/blink/renderer/core/svg/graphics/svg_image.cc b/third_party/blink/renderer/core/svg/graphics/svg_image.cc index ff2bf69b..71acf1c 100644 --- a/third_party/blink/renderer/core/svg/graphics/svg_image.cc +++ b/third_party/blink/renderer/core/svg/graphics/svg_image.cc
@@ -770,7 +770,7 @@ TRACE_EVENT0("blink", "SVGImage::dataChanged"); // Don't do anything if is an empty image. - if (!Data()->size()) + if (!DataSize()) return kSizeAvailable; if (!all_data_received)
diff --git a/third_party/blink/renderer/modules/peerconnection/BUILD.gn b/third_party/blink/renderer/modules/peerconnection/BUILD.gn index 7b2edbcf..b91dafbb 100644 --- a/third_party/blink/renderer/modules/peerconnection/BUILD.gn +++ b/third_party/blink/renderer/modules/peerconnection/BUILD.gn
@@ -54,8 +54,10 @@ "rtc_encoded_audio_frame.h", "rtc_encoded_audio_frame_delegate.cc", "rtc_encoded_audio_frame_delegate.h", - "rtc_encoded_audio_receiver_stream_optimizer.cc", - "rtc_encoded_audio_receiver_stream_optimizer.h", + "rtc_encoded_audio_receiver_sink_optimizer.cc", + "rtc_encoded_audio_receiver_sink_optimizer.h", + "rtc_encoded_audio_receiver_source_optimizer.cc", + "rtc_encoded_audio_receiver_source_optimizer.h", "rtc_encoded_audio_underlying_sink.cc", "rtc_encoded_audio_underlying_sink.h", "rtc_encoded_audio_underlying_source.cc",
diff --git a/third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_receiver_sink_optimizer.cc b/third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_receiver_sink_optimizer.cc new file mode 100644 index 0000000..ec1b256 --- /dev/null +++ b/third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_receiver_sink_optimizer.cc
@@ -0,0 +1,24 @@ +#include "third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_receiver_sink_optimizer.h" +#include "third_party/blink/renderer/platform/scheduler/public/post_cross_thread_task.h" +#include "third_party/blink/renderer/platform/wtf/cross_thread_functional.h" + +namespace blink { + +RtcEncodedAudioReceiverSinkOptimizer::RtcEncodedAudioReceiverSinkOptimizer( + UnderlyingSinkSetter set_underlying_sink, + scoped_refptr<blink::RTCEncodedAudioStreamTransformer::Broker> transformer) + : set_underlying_sink_(std::move(set_underlying_sink)), + transformer_(std::move(transformer)) {} + +UnderlyingSinkBase* +RtcEncodedAudioReceiverSinkOptimizer::PerformInProcessOptimization( + ScriptState* script_state) { + auto* new_sink = MakeGarbageCollected<RTCEncodedAudioUnderlyingSink>( + script_state, std::move(transformer_)); + + std::move(set_underlying_sink_).Run(WrapCrossThreadPersistent(new_sink)); + + return new_sink; +} + +} // namespace blink
diff --git a/third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_receiver_sink_optimizer.h b/third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_receiver_sink_optimizer.h new file mode 100644 index 0000000..3a27e40 --- /dev/null +++ b/third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_receiver_sink_optimizer.h
@@ -0,0 +1,38 @@ +// Copyright 2020 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be found +// in the LICENSE file. + +#ifndef THIRD_PARTY_BLINK_RENDERER_MODULES_PEERCONNECTION_RTC_ENCODED_AUDIO_RECEIVER_SINK_OPTIMIZER_H_ +#define THIRD_PARTY_BLINK_RENDERER_MODULES_PEERCONNECTION_RTC_ENCODED_AUDIO_RECEIVER_SINK_OPTIMIZER_H_ + +#include "third_party/blink/renderer/core/core_export.h" +#include "third_party/blink/renderer/core/streams/underlying_sink_base.h" +#include "third_party/blink/renderer/core/streams/writable_stream_transferring_optimizer.h" +#include "third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_underlying_sink.h" + +namespace blink { + +class UnderlyingSinkBase; +class ScriptState; +class RTCEncodedAudioUnderlyingSink; + +class MODULES_EXPORT RtcEncodedAudioReceiverSinkOptimizer + : public WritableStreamTransferringOptimizer { + public: + using UnderlyingSinkSetter = + WTF::CrossThreadOnceFunction<void(RTCEncodedAudioUnderlyingSink*)>; + RtcEncodedAudioReceiverSinkOptimizer( + UnderlyingSinkSetter, + scoped_refptr<blink::RTCEncodedAudioStreamTransformer::Broker> + transformer); + UnderlyingSinkBase* PerformInProcessOptimization( + ScriptState* script_state) override; + + private: + UnderlyingSinkSetter set_underlying_sink_; + scoped_refptr<blink::RTCEncodedAudioStreamTransformer::Broker> transformer_; +}; + +} // namespace blink + +#endif // THIRD_PARTY_BLINK_RENDERER_MODULES_PEERCONNECTION_RTC_ENCODED_AUDIO_RECEIVER_SINK_OPTIMIZER_H_
diff --git a/third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_receiver_stream_optimizer.cc b/third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_receiver_source_optimizer.cc similarity index 84% rename from third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_receiver_stream_optimizer.cc rename to third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_receiver_source_optimizer.cc index 6b8928f..0d540fa 100644 --- a/third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_receiver_stream_optimizer.cc +++ b/third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_receiver_source_optimizer.cc
@@ -1,17 +1,17 @@ -#include "third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_receiver_stream_optimizer.h" +#include "third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_receiver_source_optimizer.h" #include "third_party/blink/renderer/platform/scheduler/public/post_cross_thread_task.h" #include "third_party/blink/renderer/platform/wtf/cross_thread_functional.h" namespace blink { -RtcEncodedAudioReceiverStreamOptimizer::RtcEncodedAudioReceiverStreamOptimizer( +RtcEncodedAudioReceiverSourceOptimizer::RtcEncodedAudioReceiverSourceOptimizer( UnderlyingSourceSetter set_underlying_source, WTF::CrossThreadOnceClosure disconnect_callback) : set_underlying_source_(std::move(set_underlying_source)), disconnect_callback_(std::move(disconnect_callback)) {} UnderlyingSourceBase* -RtcEncodedAudioReceiverStreamOptimizer::PerformInProcessOptimization( +RtcEncodedAudioReceiverSourceOptimizer::PerformInProcessOptimization( ScriptState* script_state) { ExecutionContext* context = ExecutionContext::From(script_state);
diff --git a/third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_receiver_stream_optimizer.h b/third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_receiver_source_optimizer.h similarity index 85% rename from third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_receiver_stream_optimizer.h rename to third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_receiver_source_optimizer.h index a79a244e..eaba785 100644 --- a/third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_receiver_stream_optimizer.h +++ b/third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_receiver_source_optimizer.h
@@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be found // in the LICENSE file. -#ifndef THIRD_PARTY_BLINK_RENDERER_MODULES_PEERCONNECTION_RTC_ENCODED_AUDIO_RECEIVER_STREAM_OPTIMIZER_H_ -#define THIRD_PARTY_BLINK_RENDERER_MODULES_PEERCONNECTION_RTC_ENCODED_AUDIO_RECEIVER_STREAM_OPTIMIZER_H_ +#ifndef THIRD_PARTY_BLINK_RENDERER_MODULES_PEERCONNECTION_RTC_ENCODED_AUDIO_RECEIVER_SOURCE_OPTIMIZER_H_ +#define THIRD_PARTY_BLINK_RENDERER_MODULES_PEERCONNECTION_RTC_ENCODED_AUDIO_RECEIVER_SOURCE_OPTIMIZER_H_ #include "third_party/blink/renderer/core/core_export.h" #include "third_party/blink/renderer/core/streams/readable_stream_transferring_optimizer.h" @@ -16,13 +16,13 @@ class ScriptState; class RTCEncodedAudioUnderlyingSource; -class MODULES_EXPORT RtcEncodedAudioReceiverStreamOptimizer +class MODULES_EXPORT RtcEncodedAudioReceiverSourceOptimizer : public ReadableStreamTransferringOptimizer { public: using UnderlyingSourceSetter = WTF::CrossThreadFunction<void( RTCEncodedAudioUnderlyingSource*, scoped_refptr<base::SingleThreadTaskRunner>)>; - RtcEncodedAudioReceiverStreamOptimizer( + RtcEncodedAudioReceiverSourceOptimizer( UnderlyingSourceSetter, WTF::CrossThreadOnceClosure disconnect_callback); UnderlyingSourceBase* PerformInProcessOptimization( @@ -35,4 +35,4 @@ } // namespace blink -#endif // THIRD_PARTY_BLINK_RENDERER_MODULES_PEERCONNECTION_RTC_ENCODED_AUDIO_RECEIVER_STREAM_OPTIMIZER_H_ +#endif // THIRD_PARTY_BLINK_RENDERER_MODULES_PEERCONNECTION_RTC_ENCODED_AUDIO_RECEIVER_SOURCE_OPTIMIZER_H_
diff --git a/third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_underlying_sink.cc b/third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_underlying_sink.cc index 1e5feaf..ffc16ae 100644 --- a/third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_underlying_sink.cc +++ b/third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_underlying_sink.cc
@@ -14,9 +14,10 @@ RTCEncodedAudioUnderlyingSink::RTCEncodedAudioUnderlyingSink( ScriptState* script_state, - TransformerCallback transformer_callback) - : transformer_callback_(std::move(transformer_callback)) { - DCHECK(transformer_callback_); + scoped_refptr<blink::RTCEncodedAudioStreamTransformer::Broker> + transformer_broker) + : transformer_broker_(std::move(transformer_broker)) { + DCHECK(transformer_broker_); } ScriptPromise RTCEncodedAudioUnderlyingSink::start( @@ -32,6 +33,7 @@ ScriptValue chunk, WritableStreamDefaultController* controller, ExceptionState& exception_state) { + DCHECK_CALLED_ON_VALID_THREAD(thread_checker_); RTCEncodedAudioFrame* encoded_frame = V8RTCEncodedAudioFrame::ToImplWithTypeCheck(script_state->GetIsolate(), chunk.V8Value()); @@ -40,7 +42,7 @@ return ScriptPromise(); } - if (!transformer_callback_) { + if (!transformer_broker_) { exception_state.ThrowDOMException(DOMExceptionCode::kInvalidStateError, "Stream closed"); return ScriptPromise(); @@ -53,22 +55,16 @@ return ScriptPromise(); } - RTCEncodedAudioStreamTransformer* transformer = transformer_callback_.Run(); - if (!transformer) { - exception_state.ThrowDOMException(DOMExceptionCode::kInvalidStateError, - "No underlying sink"); - return ScriptPromise(); - } - - transformer->SendFrameToSink(std::move(webrtc_frame)); + transformer_broker_->SendFrameToSink(std::move(webrtc_frame)); return ScriptPromise::CastUndefined(script_state); } ScriptPromise RTCEncodedAudioUnderlyingSink::close(ScriptState* script_state, ExceptionState&) { + DCHECK_CALLED_ON_VALID_THREAD(thread_checker_); // Disconnect from the transformer if the sink is closed. - if (transformer_callback_) - transformer_callback_.Reset(); + if (transformer_broker_) + transformer_broker_.reset(); return ScriptPromise::CastUndefined(script_state); } @@ -76,6 +72,7 @@ ScriptState* script_state, ScriptValue reason, ExceptionState& exception_state) { + DCHECK_CALLED_ON_VALID_THREAD(thread_checker_); // It is not possible to cancel any frames already sent to the WebRTC sink, // thus abort() has the same effect as close(). return close(script_state, exception_state);
diff --git a/third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_underlying_sink.h b/third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_underlying_sink.h index 7f7cae2..1a640ace2 100644 --- a/third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_underlying_sink.h +++ b/third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_underlying_sink.h
@@ -5,8 +5,10 @@ #ifndef THIRD_PARTY_BLINK_RENDERER_MODULES_PEERCONNECTION_RTC_ENCODED_AUDIO_UNDERLYING_SINK_H_ #define THIRD_PARTY_BLINK_RENDERER_MODULES_PEERCONNECTION_RTC_ENCODED_AUDIO_UNDERLYING_SINK_H_ +#include "base/threading/thread_checker.h" #include "third_party/blink/renderer/core/streams/underlying_sink_base.h" #include "third_party/blink/renderer/modules/modules_export.h" +#include "third_party/blink/renderer/platform/peerconnection/rtc_encoded_audio_stream_transformer.h" namespace blink { @@ -16,9 +18,9 @@ class MODULES_EXPORT RTCEncodedAudioUnderlyingSink final : public UnderlyingSinkBase { public: - using TransformerCallback = - base::RepeatingCallback<RTCEncodedAudioStreamTransformer*()>; - RTCEncodedAudioUnderlyingSink(ScriptState*, TransformerCallback); + RTCEncodedAudioUnderlyingSink( + ScriptState*, + scoped_refptr<blink::RTCEncodedAudioStreamTransformer::Broker>); // UnderlyingSinkBase ScriptPromise start(ScriptState*, @@ -36,7 +38,9 @@ void Trace(Visitor*) const override; private: - TransformerCallback transformer_callback_; + scoped_refptr<blink::RTCEncodedAudioStreamTransformer::Broker> + transformer_broker_; + THREAD_CHECKER(thread_checker_); }; } // namespace blink
diff --git a/third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_underlying_sink_test.cc b/third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_underlying_sink_test.cc index c9e7862d..67b3551c 100644 --- a/third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_underlying_sink_test.cc +++ b/third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_underlying_sink_test.cc
@@ -48,17 +48,6 @@ uint32_t GetSsrc() const override { return 0; } }; -bool IsDOMException(ScriptState* script_state, - ScriptValue value, - DOMExceptionCode code) { - auto* dom_exception = V8DOMException::ToImplWithTypeCheck( - script_state->GetIsolate(), value.V8Value()); - if (!dom_exception) - return false; - - return dom_exception->code() == static_cast<uint16_t>(code); -} - } // namespace class RTCEncodedAudioUnderlyingSinkTest : public testing::Test { @@ -84,17 +73,7 @@ RTCEncodedAudioUnderlyingSink* CreateSink(ScriptState* script_state) { return MakeGarbageCollected<RTCEncodedAudioUnderlyingSink>( - script_state, - WTF::BindRepeating(&RTCEncodedAudioUnderlyingSinkTest::GetTransformer, - WTF::Unretained(this))); - } - - RTCEncodedAudioUnderlyingSink* CreateNullCallbackSink( - ScriptState* script_state) { - return MakeGarbageCollected<RTCEncodedAudioUnderlyingSink>( - script_state, - WTF::BindRepeating( - []() -> RTCEncodedAudioStreamTransformer* { return nullptr; })); + script_state, transformer_.GetBroker()); } RTCEncodedAudioStreamTransformer* GetTransformer() { return &transformer_; } @@ -159,25 +138,4 @@ EXPECT_TRUE(dummy_exception_state.HadException()); } -TEST_F(RTCEncodedAudioUnderlyingSinkTest, WriteToNullCallbackSinkFails) { - V8TestingScope v8_scope; - ScriptState* script_state = v8_scope.GetScriptState(); - auto* sink = CreateNullCallbackSink(script_state); - auto* stream = - WritableStream::CreateWithCountQueueingStrategy(script_state, sink, 1u); - - NonThrowableExceptionState exception_state; - auto* writer = stream->getWriter(script_state, exception_state); - - EXPECT_CALL(*webrtc_callback_, OnTransformedFrame(_)).Times(0); - ScriptPromiseTester write_tester( - script_state, - writer->write(script_state, CreateEncodedAudioFrameChunk(script_state), - exception_state)); - write_tester.WaitUntilSettled(); - EXPECT_TRUE(write_tester.IsRejected()); - EXPECT_TRUE(IsDOMException(script_state, write_tester.Value(), - DOMExceptionCode::kInvalidStateError)); -} - } // namespace blink
diff --git a/third_party/blink/renderer/modules/peerconnection/rtc_rtp_receiver.cc b/third_party/blink/renderer/modules/peerconnection/rtc_rtp_receiver.cc index 8b22234..da8c6a7c 100644 --- a/third_party/blink/renderer/modules/peerconnection/rtc_rtp_receiver.cc +++ b/third_party/blink/renderer/modules/peerconnection/rtc_rtp_receiver.cc
@@ -23,7 +23,8 @@ #include "third_party/blink/renderer/modules/peerconnection/identifiability_metrics.h" #include "third_party/blink/renderer/modules/peerconnection/peer_connection_dependency_factory.h" #include "third_party/blink/renderer/modules/peerconnection/rtc_dtls_transport.h" -#include "third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_receiver_stream_optimizer.h" +#include "third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_receiver_sink_optimizer.h" +#include "third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_receiver_source_optimizer.h" #include "third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_underlying_sink.h" #include "third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_underlying_source.h" #include "third_party/blink/renderer/modules/peerconnection/rtc_encoded_video_underlying_sink.h" @@ -299,7 +300,6 @@ visitor->Trace(transport_); visitor->Trace(streams_); visitor->Trace(transceiver_); - visitor->Trace(audio_to_decoder_underlying_sink_); visitor->Trace(encoded_audio_streams_); visitor->Trace(video_from_depacketizer_underlying_source_); visitor->Trace(video_to_decoder_underlying_sink_); @@ -433,10 +433,15 @@ std::move(new_source_task_runner)); } +void RTCRtpReceiver::SetAudioUnderlyingSink( + RTCEncodedAudioUnderlyingSink* new_underlying_sink) { + WTF::MutexLocker locker(audio_underlying_sink_mutex_); + audio_to_decoder_underlying_sink_ = new_underlying_sink; +} + void RTCRtpReceiver::InitializeEncodedAudioStreams(ScriptState* script_state) { DCHECK_CALLED_ON_VALID_THREAD(thread_checker_); DCHECK(!encoded_audio_streams_); - DCHECK(!audio_to_decoder_underlying_sink_); DCHECK(force_encoded_audio_insertable_streams_); encoded_audio_streams_ = RTCInsertableStreams::Create(); @@ -466,31 +471,36 @@ ReadableStream::CreateWithCountQueueingStrategy( script_state, audio_from_depacketizer_underlying_source_, /*high_water_mark=*/0, AllowPerChunkTransferring(false), - absl::make_unique<RtcEncodedAudioReceiverStreamOptimizer>( + absl::make_unique<RtcEncodedAudioReceiverSourceOptimizer>( std::move(set_underlying_source), std::move(disconnect_callback))); encoded_audio_streams_->setReadableStream(readable_stream); encoded_audio_streams_->setReadable(readable_stream); } - // Set up writable. - audio_to_decoder_underlying_sink_ = - MakeGarbageCollected<RTCEncodedAudioUnderlyingSink>( - script_state, - WTF::BindRepeating( - [](RTCRtpReceiver* receiver) - -> RTCEncodedAudioStreamTransformer* { - return receiver ? receiver->platform_receiver() - ->GetEncodedAudioStreamTransformer() - : nullptr; - }, - WrapWeakPersistent(this))); - // The high water mark for the stream is set to 1 so that the stream seems - // ready to write, but without queuing frames. - WritableStream* writable_stream = - WritableStream::CreateWithCountQueueingStrategy( - script_state, audio_to_decoder_underlying_sink_, - /*high_water_mark=*/1); + WritableStream* writable_stream; + { + WTF::MutexLocker locker(audio_underlying_sink_mutex_); + DCHECK(!audio_to_decoder_underlying_sink_); + + // Set up writable. + audio_to_decoder_underlying_sink_ = + MakeGarbageCollected<RTCEncodedAudioUnderlyingSink>( + script_state, encoded_audio_transformer_); + + auto set_underlying_sink = + WTF::CrossThreadBindOnce(&RTCRtpReceiver::SetAudioUnderlyingSink, + WrapCrossThreadWeakPersistent(this)); + + // The high water mark for the stream is set to 1 so that the stream seems + // ready to write, but without queuing frames. + writable_stream = WritableStream::CreateWithCountQueueingStrategy( + script_state, audio_to_decoder_underlying_sink_, + /*high_water_mark=*/1, + absl::make_unique<RtcEncodedAudioReceiverSinkOptimizer>( + std::move(set_underlying_sink), encoded_audio_transformer_)); + } + encoded_audio_streams_->setWritableStream(writable_stream); encoded_audio_streams_->setWritable(writable_stream); }
diff --git a/third_party/blink/renderer/modules/peerconnection/rtc_rtp_receiver.h b/third_party/blink/renderer/modules/peerconnection/rtc_rtp_receiver.h index d346a6e..bc5e21b 100644 --- a/third_party/blink/renderer/modules/peerconnection/rtc_rtp_receiver.h +++ b/third_party/blink/renderer/modules/peerconnection/rtc_rtp_receiver.h
@@ -93,6 +93,8 @@ void SetAudioUnderlyingSource( RTCEncodedAudioUnderlyingSource* new_underlying_source, scoped_refptr<base::SingleThreadTaskRunner> task_runner); + void SetAudioUnderlyingSink( + RTCEncodedAudioUnderlyingSink* new_underlying_sink); Member<RTCPeerConnection> pc_; std::unique_ptr<RTCRtpReceiverPlatform> receiver_; @@ -117,7 +119,10 @@ CrossThreadPersistent<RTCEncodedAudioUnderlyingSource> audio_from_depacketizer_underlying_source_ GUARDED_BY(audio_underlying_source_mutex_); - Member<RTCEncodedAudioUnderlyingSink> audio_to_decoder_underlying_sink_; + WTF::Mutex audio_underlying_sink_mutex_; + CrossThreadPersistent<RTCEncodedAudioUnderlyingSink> + audio_to_decoder_underlying_sink_ + GUARDED_BY(audio_underlying_sink_mutex_); Member<RTCInsertableStreams> encoded_audio_streams_; scoped_refptr<blink::RTCEncodedAudioStreamTransformer::Broker> encoded_audio_transformer_;
diff --git a/third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.cc b/third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.cc index 8cd7e68..9adbd0b2 100644 --- a/third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.cc +++ b/third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.cc
@@ -881,13 +881,7 @@ audio_to_packetizer_underlying_sink_ = MakeGarbageCollected<RTCEncodedAudioUnderlyingSink>( script_state, - WTF::BindRepeating( - [](RTCRtpSender* sender) -> RTCEncodedAudioStreamTransformer* { - return sender ? sender->web_sender() - ->GetEncodedAudioStreamTransformer() - : nullptr; - }, - WrapWeakPersistent(this))); + web_sender()->GetEncodedAudioStreamTransformer()->GetBroker()); // The high water mark for the stream is set to 1 so that the stream is // ready to write, but without queuing frames. WritableStream* writable_stream =
diff --git a/third_party/blink/renderer/platform/BUILD.gn b/third_party/blink/renderer/platform/BUILD.gn index 32eafdaf..e4ad3c6 100644 --- a/third_party/blink/renderer/platform/BUILD.gn +++ b/third_party/blink/renderer/platform/BUILD.gn
@@ -2617,20 +2617,4 @@ "//third_party/blink/public:test_headers", ] public_deps = [ "//gpu:raster" ] - - if (media_use_ffmpeg || !is_android) { - sources += [ "media/web_media_player_impl_unittest.cc" ] - data = [ "//media/test/data/" ] - deps += [ - "//media", - "//media:test_support", - "//media/mojo/services", - "//third_party/blink/public:blink", - "//third_party/blink/public:test_support", - "//third_party/blink/public/common/tokens:tokens_headers", - "//third_party/blink/public/platform/media", - "//third_party/blink/renderer/platform/media", - "//ui/gfx/geometry", - ] - } }
diff --git a/third_party/blink/renderer/platform/graphics/bitmap_image.cc b/third_party/blink/renderer/platform/graphics/bitmap_image.cc index b0ebec2..bb8a664 100644 --- a/third_party/blink/renderer/platform/graphics/bitmap_image.cc +++ b/third_party/blink/renderer/platform/graphics/bitmap_image.cc
@@ -94,6 +94,15 @@ return decoder_ ? decoder_->Data() : nullptr; } +bool BitmapImage::HasData() const { + return decoder_ ? decoder_->HasData() : false; +} + +size_t BitmapImage::DataSize() const { + DCHECK(decoder_); + return decoder_->DataSize(); +} + void BitmapImage::NotifyMemoryChanged() { if (GetImageObserver()) GetImageObserver()->DecodedSizeChangedTo(this, TotalFrameBytes());
diff --git a/third_party/blink/renderer/platform/graphics/bitmap_image.h b/third_party/blink/renderer/platform/graphics/bitmap_image.h index 6dc38631..0b73021 100644 --- a/third_party/blink/renderer/platform/graphics/bitmap_image.h +++ b/third_party/blink/renderer/platform/graphics/bitmap_image.h
@@ -145,6 +145,8 @@ void DestroyDecodedData() override; scoped_refptr<SharedBuffer> Data() override; + bool HasData() const override; + size_t DataSize() const override; // Notifies observers that the memory footprint has changed. void NotifyMemoryChanged();
diff --git a/third_party/blink/renderer/platform/graphics/deferred_image_decoder.cc b/third_party/blink/renderer/platform/graphics/deferred_image_decoder.cc index 50b56d9..0171ed3 100644 --- a/third_party/blink/renderer/platform/graphics/deferred_image_decoder.cc +++ b/third_party/blink/renderer/platform/graphics/deferred_image_decoder.cc
@@ -252,6 +252,15 @@ return parkable_image_ ? parkable_image_->Data() : nullptr; } +bool DeferredImageDecoder::HasData() const { + return parkable_image_ != nullptr; +} + +size_t DeferredImageDecoder::DataSize() const { + DCHECK(parkable_image_); + return parkable_image_->size(); +} + void DeferredImageDecoder::SetData(scoped_refptr<SharedBuffer> data, bool all_data_received) { SetDataInternal(std::move(data), all_data_received, true);
diff --git a/third_party/blink/renderer/platform/graphics/deferred_image_decoder.h b/third_party/blink/renderer/platform/graphics/deferred_image_decoder.h index 6f95f07..6928275 100644 --- a/third_party/blink/renderer/platform/graphics/deferred_image_decoder.h +++ b/third_party/blink/renderer/platform/graphics/deferred_image_decoder.h
@@ -68,6 +68,8 @@ sk_sp<PaintImageGenerator> CreateGenerator(); scoped_refptr<SharedBuffer> Data(); + bool HasData() const; + size_t DataSize() const; void SetData(scoped_refptr<SharedBuffer> data, bool all_data_received); bool IsSizeAvailable();
diff --git a/third_party/blink/renderer/platform/graphics/gpu/webgl_image_conversion.cc b/third_party/blink/renderer/platform/graphics/gpu/webgl_image_conversion.cc index 8355cb9..16babfa9 100644 --- a/third_party/blink/renderer/platform/graphics/gpu/webgl_image_conversion.cc +++ b/third_party/blink/renderer/platform/graphics/gpu/webgl_image_conversion.cc
@@ -3747,7 +3747,7 @@ !skia_image->colorSpace()->isSRGB(); if ((!skia_image || ignore_color_space || need_unpremultiplied || need_color_conversion) && - image_->Data()) { + image_->HasData()) { // Attempt to get raw unpremultiplied image data. const bool data_complete = true; std::unique_ptr<ImageDecoder> decoder(ImageDecoder::Create(
diff --git a/third_party/blink/renderer/platform/graphics/image.h b/third_party/blink/renderer/platform/graphics/image.h index 04094f1..c2d3739ee 100644 --- a/third_party/blink/renderer/platform/graphics/image.h +++ b/third_party/blink/renderer/platform/graphics/image.h
@@ -192,7 +192,22 @@ virtual void DestroyDecodedData() = 0; + // In some overrides, |Data()| can be somewhat expensive (e.g. in BitmapImage, + // we don't use a SharedBuffer to store the image data, so |Data()| involves a + // copy). |HasData()| and |DataSize()| should be preferred in cases where the + // data itself is not needed. + // + // If a subclass overrides |Data|, it must override |HasData| and |DataSize| + // as well. virtual scoped_refptr<SharedBuffer> Data() { return encoded_image_data_; } + // Returns true iff the encoded image data is available. + virtual bool HasData() const { return encoded_image_data_ != nullptr; } + // Returns the size of the encoded image data, in bytes. Should only be called + // if |HasData()| is true. + virtual size_t DataSize() const { + DCHECK(encoded_image_data_); + return encoded_image_data_->size(); + } // Animation begins whenever someone draws the image, so startAnimation() is // not normally called. It will automatically pause once all observers no
diff --git a/third_party/blink/renderer/platform/media/BUILD.gn b/third_party/blink/renderer/platform/media/BUILD.gn index 609706b..f37f498 100644 --- a/third_party/blink/renderer/platform/media/BUILD.gn +++ b/third_party/blink/renderer/platform/media/BUILD.gn
@@ -8,7 +8,10 @@ # ported to Blink code conventions. component("media") { visibility = [ + # Note: this is here because web_media_player_impl_unittest.cc needs core + # and web, and platform should not depend on either. "//third_party/blink/public/platform/media", + "//third_party/blink/renderer/core:unit_tests", "//third_party/blink/renderer/platform/*", ] output_name = "blink_platform_media"
diff --git a/third_party/blink/renderer/platform/peerconnection/rtc_encoded_audio_stream_transformer.cc b/third_party/blink/renderer/platform/peerconnection/rtc_encoded_audio_stream_transformer.cc index cdec34dc..37392db0 100644 --- a/third_party/blink/renderer/platform/peerconnection/rtc_encoded_audio_stream_transformer.cc +++ b/third_party/blink/renderer/platform/peerconnection/rtc_encoded_audio_stream_transformer.cc
@@ -34,9 +34,8 @@ scoped_refptr<RTCEncodedAudioStreamTransformer::Broker> transformer_broker) : source_task_runner_(realm_task_runner), - sink_task_runner_(realm_task_runner), transformer_broker_(std::move(transformer_broker)) { - DCHECK(sink_task_runner_->BelongsToCurrentThread()); + DCHECK(source_task_runner_->BelongsToCurrentThread()); } void SetSourceTaskRunner( @@ -49,21 +48,12 @@ void RegisterTransformedFrameCallback( rtc::scoped_refptr<webrtc::TransformedFrameCallback> send_frame_to_sink_callback) override { - PostCrossThreadTask( - *sink_task_runner_, FROM_HERE, - CrossThreadBindOnce( - &RTCEncodedAudioStreamTransformer::Broker:: - RegisterTransformedFrameCallbackOnSinkTaskRunner, - transformer_broker_, std::move(send_frame_to_sink_callback))); + transformer_broker_->RegisterTransformedFrameCallback( + std::move(send_frame_to_sink_callback)); } void UnregisterTransformedFrameCallback() override { - PostCrossThreadTask( - *sink_task_runner_, FROM_HERE, - CrossThreadBindOnce( - &RTCEncodedAudioStreamTransformer::Broker:: - UnregisterTransformedFrameCallbackOnSinkTaskRunner, - transformer_broker_)); + transformer_broker_->UnregisterTransformedFrameCallback(); } void Transform( @@ -82,7 +72,6 @@ WTF::Mutex source_task_runner_mutex_; scoped_refptr<base::SingleThreadTaskRunner> source_task_runner_ GUARDED_BY(source_task_runner_mutex_); - scoped_refptr<base::SingleThreadTaskRunner> sink_task_runner_; scoped_refptr<RTCEncodedAudioStreamTransformer::Broker> transformer_broker_; }; @@ -92,10 +81,9 @@ RTCEncodedAudioStreamTransformer* transformer_) : transformer_(transformer_) {} -void RTCEncodedAudioStreamTransformer::Broker:: - RegisterTransformedFrameCallbackOnSinkTaskRunner( - rtc::scoped_refptr<webrtc::TransformedFrameCallback> - send_frame_to_sink_callback) { +void RTCEncodedAudioStreamTransformer::Broker::RegisterTransformedFrameCallback( + rtc::scoped_refptr<webrtc::TransformedFrameCallback> + send_frame_to_sink_callback) { WTF::MutexLocker locker(transformer_mutex_); if (transformer_) { transformer_->RegisterTransformedFrameCallback( @@ -104,7 +92,7 @@ } void RTCEncodedAudioStreamTransformer::Broker:: - UnregisterTransformedFrameCallbackOnSinkTaskRunner() { + UnregisterTransformedFrameCallback() { WTF::MutexLocker locker(transformer_mutex_); if (transformer_) { transformer_->UnregisterTransformedFrameCallback(); @@ -147,6 +135,14 @@ transformer_ = nullptr; } +void RTCEncodedAudioStreamTransformer::Broker::SendFrameToSink( + std::unique_ptr<webrtc::TransformableFrameInterface> frame) { + WTF::MutexLocker locker(transformer_mutex_); + if (transformer_) { + transformer_->SendFrameToSink(std::move(frame)); + } +} + RTCEncodedAudioStreamTransformer::RTCEncodedAudioStreamTransformer( scoped_refptr<base::SingleThreadTaskRunner> realm_task_runner) : broker_(base::AdoptRef(new Broker(this))), @@ -154,9 +150,7 @@ new rtc::RefCountedObject<RTCEncodedAudioStreamTransformerDelegate>( this, std::move(realm_task_runner), - broker_)) { - DCHECK_CALLED_ON_VALID_THREAD(thread_checker_); -} + broker_)) {} RTCEncodedAudioStreamTransformer::~RTCEncodedAudioStreamTransformer() { broker_->ClearTransformer(); @@ -164,12 +158,12 @@ void RTCEncodedAudioStreamTransformer::RegisterTransformedFrameCallback( rtc::scoped_refptr<webrtc::TransformedFrameCallback> callback) { - DCHECK_CALLED_ON_VALID_THREAD(thread_checker_); + WTF::MutexLocker locker(sink_mutex_); send_frame_to_sink_cb_ = callback; } void RTCEncodedAudioStreamTransformer::UnregisterTransformedFrameCallback() { - DCHECK_CALLED_ON_VALID_THREAD(thread_checker_); + WTF::MutexLocker locker(sink_mutex_); send_frame_to_sink_cb_ = nullptr; } @@ -184,7 +178,7 @@ void RTCEncodedAudioStreamTransformer::SendFrameToSink( std::unique_ptr<webrtc::TransformableFrameInterface> frame) { - DCHECK_CALLED_ON_VALID_THREAD(thread_checker_); + WTF::MutexLocker locker(sink_mutex_); if (send_frame_to_sink_cb_) send_frame_to_sink_cb_->OnTransformedFrame(std::move(frame)); } @@ -207,13 +201,12 @@ } bool RTCEncodedAudioStreamTransformer::HasTransformedFrameCallback() const { - DCHECK_CALLED_ON_VALID_THREAD(thread_checker_); + WTF::MutexLocker locker(sink_mutex_); return !!send_frame_to_sink_cb_; } rtc::scoped_refptr<webrtc::FrameTransformerInterface> RTCEncodedAudioStreamTransformer::Delegate() { - DCHECK_CALLED_ON_VALID_THREAD(thread_checker_); return delegate_; }
diff --git a/third_party/blink/renderer/platform/peerconnection/rtc_encoded_audio_stream_transformer.h b/third_party/blink/renderer/platform/peerconnection/rtc_encoded_audio_stream_transformer.h index 408a121..fd644fc0 100644 --- a/third_party/blink/renderer/platform/peerconnection/rtc_encoded_audio_stream_transformer.h +++ b/third_party/blink/renderer/platform/peerconnection/rtc_encoded_audio_stream_transformer.h
@@ -41,11 +41,11 @@ // creating a circular reference. class PLATFORM_EXPORT Broker : public WTF::ThreadSafeRefCounted<Broker> { public: - void RegisterTransformedFrameCallbackOnSinkTaskRunner( + void RegisterTransformedFrameCallback( rtc::scoped_refptr<webrtc::TransformedFrameCallback> send_frame_to_sink_callback); - void UnregisterTransformedFrameCallbackOnSinkTaskRunner(); + void UnregisterTransformedFrameCallback(); void TransformFrameOnSourceTaskRunner( std::unique_ptr<webrtc::TransformableFrameInterface> frame); @@ -57,6 +57,9 @@ void SetSourceTaskRunner( scoped_refptr<base::SingleThreadTaskRunner> task_runner); + void SendFrameToSink( + std::unique_ptr<webrtc::TransformableFrameInterface> frame); + private: explicit Broker(RTCEncodedAudioStreamTransformer* transformer_); void ClearTransformer(); @@ -88,8 +91,7 @@ // the stream is transferred. void TransformFrame(std::unique_ptr<webrtc::TransformableFrameInterface>); - // Send a transformed frame to the WebRTC sink. Must run on the main - // thread. + // Send a transformed frame to the WebRTC sink. Threadsafe. void SendFrameToSink( std::unique_ptr<webrtc::TransformableFrameInterface> frame); @@ -103,27 +105,25 @@ // false otherwise. Is threadsafe. bool HasTransformerCallback(); - // Returns true if a webrtc::TransformedFrameCallback is registered. Must be - // run on the main thread. + // Returns true if a webrtc::TransformedFrameCallback is registered. + // Threadsafe. bool HasTransformedFrameCallback() const; rtc::scoped_refptr<webrtc::FrameTransformerInterface> Delegate(); // Set the TaskRunner used for the Source side - to deliver frames up to the // UnderlyingSource. Is threadsafe. - // TODO(crbug/1103280): Allow the sink side to move too. void SetSourceTaskRunner( scoped_refptr<base::SingleThreadTaskRunner> realm_task_runner); scoped_refptr<Broker> GetBroker(); private: - THREAD_CHECKER(thread_checker_); const scoped_refptr<Broker> broker_; const rtc::scoped_refptr<webrtc::FrameTransformerInterface> delegate_; - // send_frame_to_sink_cb_ is (currently) only modified or accessed on the - // main thread. - rtc::scoped_refptr<webrtc::TransformedFrameCallback> send_frame_to_sink_cb_; + mutable WTF::Mutex sink_mutex_; + rtc::scoped_refptr<webrtc::TransformedFrameCallback> send_frame_to_sink_cb_ + GUARDED_BY(sink_mutex_); WTF::Mutex source_mutex_; TransformerCallback transformer_callback_ GUARDED_BY(source_mutex_); };
diff --git a/third_party/blink/renderer/platform/runtime_enabled_features.json5 b/third_party/blink/renderer/platform/runtime_enabled_features.json5 index 6b1dc23..d3fcf52 100644 --- a/third_party/blink/renderer/platform/runtime_enabled_features.json5 +++ b/third_party/blink/renderer/platform/runtime_enabled_features.json5
@@ -645,7 +645,7 @@ }, { name: "CSSModules", - status: "experimental", + status: "stable", }, { name: "CSSOffsetPathRay",
diff --git a/third_party/blink/renderer/platform/scheduler/common/features.cc b/third_party/blink/renderer/platform/scheduler/common/features.cc index 9ef5952..dc69dfc 100644 --- a/third_party/blink/renderer/platform/scheduler/common/features.cc +++ b/third_party/blink/renderer/platform/scheduler/common/features.cc
@@ -80,6 +80,20 @@ return base::TimeDelta::FromSeconds(seconds); } +const base::Feature kThrottleForegroundTimers{ + "ThrottleForegroundTimers", base::FEATURE_DISABLED_BY_DEFAULT}; + +base::TimeDelta GetForegroundTimersThrottledWakeUpInterval() { + constexpr int kForegroundTimersThrottling_WakeUpIntervalMillis_Default = 100; + static const base::FeatureParam<int> + kForegroundTimersThrottledWakeUpIntervalMills{ + &kThrottleForegroundTimers, + "ForegroundTimersThrottledWakeUpIntervalMills", + kForegroundTimersThrottling_WakeUpIntervalMillis_Default}; + return base::TimeDelta::FromMilliseconds( + kForegroundTimersThrottledWakeUpIntervalMills.Get()); +} + const base::Feature kDeprioritizeDOMTimersDuringPageLoading{ "DeprioritizeDOMTimersDuringPageLoading", base::FEATURE_DISABLED_BY_DEFAULT};
diff --git a/third_party/blink/renderer/platform/scheduler/common/features.h b/third_party/blink/renderer/platform/scheduler/common/features.h index 94a5883c..8dcde21 100644 --- a/third_party/blink/renderer/platform/scheduler/common/features.h +++ b/third_party/blink/renderer/platform/scheduler/common/features.h
@@ -201,10 +201,10 @@ "MbiCompositorTaskRunnerPerAgentSchedulingGroup", base::FEATURE_DISABLED_BY_DEFAULT}; -// If enabled, Javascript timers are throttled to 1 wake up per 100ms on -// foreground pages. -const base::Feature kThrottleForegroundTimers{ - "ThrottleForegroundTimers", base::FEATURE_DISABLED_BY_DEFAULT}; +// If enabled, Javascript timers are throttled to 1 wake up per +// GetForegroundTimersThrottledWakeUpInterval() on foreground pages. +PLATFORM_EXPORT extern const base::Feature kThrottleForegroundTimers; +PLATFORM_EXPORT base::TimeDelta GetForegroundTimersThrottledWakeUpInterval(); // Deprioritizes JS timer tasks during a particular phase of page loading. PLATFORM_EXPORT extern const base::Feature
diff --git a/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc b/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc index ce611e0c..1c82ffe 100644 --- a/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc +++ b/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc
@@ -174,8 +174,6 @@ constexpr base::TimeDelta PageSchedulerImpl::kDefaultThrottledWakeUpInterval; constexpr base::TimeDelta PageSchedulerImpl::kIntensiveThrottledWakeUpInterval; -constexpr base::TimeDelta - PageSchedulerImpl::kForegroundPagesThrottledWakeUpInterval; PageSchedulerImpl::PageSchedulerImpl( PageScheduler::Delegate* delegate, @@ -203,7 +201,9 @@ delay_for_background_and_network_idle_tab_freezing_( GetDelayForBackgroundAndNetworkIdleTabFreezing()), throttle_foreground_timers_( - base::FeatureList::IsEnabled(kThrottleForegroundTimers)) { + base::FeatureList::IsEnabled(kThrottleForegroundTimers)), + foreground_timers_throttled_wake_up_interval_( + GetForegroundTimersThrottledWakeUpInterval()) { page_lifecycle_state_tracker_ = std::make_unique<PageLifecycleStateTracker>( this, kDefaultPageVisibility == PageVisibilityState::kVisible ? PageLifecycleState::kActive @@ -884,7 +884,7 @@ normal_wake_up_budget_pool_->SetWakeUpInterval( lazy_now->Now(), IsBackgrounded() ? kDefaultThrottledWakeUpInterval - : kForegroundPagesThrottledWakeUpInterval); + : foreground_timers_throttled_wake_up_interval_); cross_origin_hidden_normal_wake_up_budget_pool_->SetWakeUpInterval( lazy_now->Now(), kDefaultThrottledWakeUpInterval); same_origin_intensive_wake_up_budget_pool_->SetWakeUpInterval(
diff --git a/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.h b/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.h index cce7d18f..435477d1 100644 --- a/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.h +++ b/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.h
@@ -56,10 +56,6 @@ static constexpr base::TimeDelta kIntensiveThrottledWakeUpInterval = base::TimeDelta::FromMinutes(1); - // Interval between throttled wake ups on a foreground page. - static constexpr base::TimeDelta kForegroundPagesThrottledWakeUpInterval = - base::TimeDelta::FromMilliseconds(100); - PageSchedulerImpl(PageScheduler::Delegate*, AgentGroupSchedulerImpl&); PageSchedulerImpl(const PageSchedulerImpl&) = delete; PageSchedulerImpl& operator=(const PageSchedulerImpl&) = delete; @@ -353,7 +349,8 @@ // * Frame origin changes // // 1: This pool allows 1-second aligned wake ups when the page is backgrounded - // or 100ms aligned wake ups when the page is foregrounded. + // or |foreground_timers_throttled_wake_up_interval_| aligned wake ups when + // the page is foregrounded. WakeUpBudgetPool* normal_wake_up_budget_pool_ = nullptr; // 2: This pool allows 1-second aligned wake ups for hidden frames in // foreground pages. @@ -390,6 +387,8 @@ // Whether foreground timers should be always throttled. const bool throttle_foreground_timers_; + // Interval between throttled wake ups on a foreground page. + const base::TimeDelta foreground_timers_throttled_wake_up_interval_; bool is_stored_in_back_forward_cache_ = false; TaskHandle set_ipc_posted_handler_task_;
diff --git a/third_party/blink/web_tests/FlagExpectations/disable-layout-ng b/third_party/blink/web_tests/FlagExpectations/disable-layout-ng index a4702154..d468f2b6 100644 --- a/third_party/blink/web_tests/FlagExpectations/disable-layout-ng +++ b/third_party/blink/web_tests/FlagExpectations/disable-layout-ng
@@ -830,6 +830,8 @@ # MathML depends on LayoutNG. crbug.com/6606 external/wpt/mathml/* [ Skip ] +crbug.com/6606 external/wpt/css/css-display/display-math-on-pseudo-elements-001.html [ Skip ] +crbug.com/6606 external/wpt/css/css-display/display-math-on-pseudo-elements-002.html [ Skip ] crbug.com/1034944 webexposed/global-interface-listing.html [ Skip ]
diff --git a/third_party/blink/web_tests/NeverFixTests b/third_party/blink/web_tests/NeverFixTests index d309383..c9203fb 100644 --- a/third_party/blink/web_tests/NeverFixTests +++ b/third_party/blink/web_tests/NeverFixTests
@@ -1811,7 +1811,7 @@ crbug.com/630342 http/tests/media/media-source/stream_memory_tests/mediasource-appendbuffer-quota-exceeded-1mb-buffers.html [ Skip ] virtual/mse-1mb-buffers/http/tests/media/media-source/stream_memory_tests/mediasource-appendbuffer-quota-exceeded-1mb-buffers.html [ Pass ] -# Remove from virtual tests when FreezeUserAgent is turned on by default. +# Remove from virtual tests when ReduceUserAgent is turned on by default. crbug.com/955620 http/tests/navigation/frozen-useragent.html [ Skip ] virtual/passive-fingerprinting/http/tests/navigation/frozen-useragent.html [ Pass ]
diff --git a/third_party/blink/web_tests/TestExpectations b/third_party/blink/web_tests/TestExpectations index b1edc0b..f5b2d95 100644 --- a/third_party/blink/web_tests/TestExpectations +++ b/third_party/blink/web_tests/TestExpectations
@@ -1063,6 +1063,12 @@ virtual/layout_ng_block_frag/external/wpt/css/css-break/out-of-flow-in-multicolumn-052.html [ Pass ] virtual/layout_ng_block_frag/external/wpt/css/css-break/out-of-flow-in-multicolumn-054.html [ Pass ] virtual/layout_ng_block_frag/external/wpt/css/css-break/out-of-flow-in-multicolumn-057.html [ Pass ] +virtual/layout_ng_block_frag/external/wpt/css/css-break/out-of-flow-in-multicolumn-058.html [ Pass ] +virtual/layout_ng_block_frag/external/wpt/css/css-break/out-of-flow-in-multicolumn-059.html [ Pass ] +virtual/layout_ng_block_frag/external/wpt/css/css-break/out-of-flow-in-multicolumn-060.html [ Pass ] +virtual/layout_ng_block_frag/external/wpt/css/css-break/out-of-flow-in-multicolumn-061.html [ Pass ] +virtual/layout_ng_block_frag/external/wpt/css/css-break/out-of-flow-in-multicolumn-062.html [ Pass ] +virtual/layout_ng_block_frag/external/wpt/css/css-break/out-of-flow-in-multicolumn-063.html [ Pass ] virtual/layout_ng_block_frag/external/wpt/css/css-break/out-of-flow-in-multicolumn-065.html [ Pass ] virtual/layout_ng_block_frag/external/wpt/css/css-break/out-of-flow-in-multicolumn-066.html [ Pass ] virtual/layout_ng_block_frag/external/wpt/css/css-break/overflow-clip-000.html [ Pass ] @@ -1240,8 +1246,6 @@ crbug.com/1093840 external/wpt/mathml/relations/html5-tree/math-global-event-handlers.tentative.html [ Pass Timeout ] # These tests fail because we don't parse math display values according to the spec. -crbug.com/1127222 external/wpt/css/css-display/display-math-on-pseudo-elements-001.html [ Failure ] -crbug.com/1127222 external/wpt/css/css-display/display-math-on-pseudo-elements-002.html [ Failure ] crbug.com/1127222 external/wpt/mathml/presentation-markup/mrow/legacy-mrow-like-elements-001.html [ Failure ] # This test fails on windows. It should really be made more reliable and take @@ -2603,6 +2607,7 @@ crbug.com/626703 external/wpt/service-workers/service-worker/worker-interception.https.html [ Failure ] # ====== New tests from wpt-importer added here ====== +crbug.com/626703 [ Win10 ] external/wpt/wasm/jsapi/exception/basic.tentative.any.html [ Failure Timeout ] crbug.com/626703 external/wpt/density-size-correction/density-corrected-image-svg-aspect-ratio-cross-origin.sub.html [ Failure ] crbug.com/626703 [ Mac10.12 ] external/wpt/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/location-setter-user-click.html [ Timeout ] crbug.com/626703 [ Mac10.13 ] external/wpt/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/location-setter-user-click.html [ Timeout ] @@ -3772,6 +3777,12 @@ crbug.com/829028 external/wpt/css/css-break/out-of-flow-in-multicolumn-052.html [ Failure ] crbug.com/829028 external/wpt/css/css-break/out-of-flow-in-multicolumn-054.html [ Failure ] crbug.com/829028 external/wpt/css/css-break/out-of-flow-in-multicolumn-057.html [ Failure ] +crbug.com/829028 external/wpt/css/css-break/out-of-flow-in-multicolumn-058.html [ Failure ] +crbug.com/829028 external/wpt/css/css-break/out-of-flow-in-multicolumn-059.html [ Failure ] +crbug.com/829028 external/wpt/css/css-break/out-of-flow-in-multicolumn-060.html [ Failure ] +crbug.com/829028 external/wpt/css/css-break/out-of-flow-in-multicolumn-061.html [ Failure ] +crbug.com/829028 external/wpt/css/css-break/out-of-flow-in-multicolumn-062.html [ Failure ] +crbug.com/829028 external/wpt/css/css-break/out-of-flow-in-multicolumn-063.html [ Failure ] crbug.com/829028 external/wpt/css/css-break/out-of-flow-in-multicolumn-065.html [ Failure ] crbug.com/829028 external/wpt/css/css-break/out-of-flow-in-multicolumn-066.html [ Failure ] crbug.com/829028 external/wpt/css/css-break/overflow-clip-000.html [ Failure ] @@ -5820,7 +5831,7 @@ crbug.com/1204176 virtual/compositor-threaded-percent-based-scrolling/fast/scrolling/no-hover-during-smooth-keyboard-scroll.html [ Failure ] crbug.com/1204176 virtual/compositor-threaded-percent-based-scrolling/fast/scrolling/scroll-animation-on-by-default.html [ Failure ] crbug.com/1204176 virtual/compositor-threaded-percent-based-scrolling/fast/scrolling/wheel-scroll-latching-on-scrollbar.html [ Failure ] -crbug.com/1204176 virtual/compositor-threaded-percent-based-scrolling/fast/scrolling/mouse-scrolling-over-standard-scrollbar.html [ Failure ] +crbug.com/1204176 virtual/compositor-threaded-percent-based-scrolling/fast/scrolling/mouse-scrolling-over-standard-scrollbar.html [ Pass Failure ] # fast/scrolling/events crbug.com/1204176 virtual/main-threaded-percent-based-scrolling/fast/scrolling/events/overscroll-event-fired-to-document.html [ Failure Timeout ] @@ -6610,7 +6621,6 @@ crbug.com/1196201 fast/events/mouse-event-source-device-event-sender.html [ Failure Pass ] # Sheriff 2021-04-13 -crbug.com/1198515 [ Mac ] external/wpt/web-animations/timing-model/animations/playing-an-animation.html [ Failure Pass ] crbug.com/1198698 external/wpt/clear-site-data/storage.https.html [ Pass Timeout ] # Sheriff 2021-04-14 @@ -6638,12 +6648,9 @@ # Sheriff 2021-04-22 crbug.com/1191990 [ Linux ] http/tests/serviceworker/clients-openwindow.html [ Failure Pass ] -crbug.com/1198443 virtual/plz-dedicated-worker/external/wpt/html/cross-origin-embedder-policy/none.https.html [ Failure Pass Timeout ] # Sheriff 2021-04-23 crbug.com/1198832 [ Linux ] external/wpt/css/css-sizing/aspect-ratio/replaced-element-003.html [ Failure Pass ] -crbug.com/1202040 external/wpt/html/cross-origin-embedder-policy/none.https.html [ Failure Pass Timeout ] -crbug.com/1202040 virtual/plz-service-worker/external/wpt/html/cross-origin-embedder-policy/none.https.html [ Failure Pass Timeout ] crbug.com/1202051 virtual/scroll-unification/scrollbars/layout-viewport-scrollbars-hidden.html [ Failure Pass ] crbug.com/1202051 virtual/scroll-unification-prefer_compositing_to_lcd_text/scrollbars/layout-viewport-scrollbars-hidden.html [ Failure Pass ] crbug.com/1197528 [ Linux ] pointer-lock/pointerlockchange-pointerlockerror-events.html [ Failure Pass ] @@ -7304,9 +7311,9 @@ crbug.com/1227710 external/wpt/bluetooth/requestDevice/cross-origin-iframe.sub.https.html [ Failure Pass ] # Sheriff 2021-07-13 -crbug.com/1220114 [ Linux ] external/wpt/webrtc-encoded-transform/RTCPeerConnection-insertable-streams-simulcast.https.html [ Failure Pass ] +crbug.com/1220114 [ Linux ] external/wpt/webrtc-encoded-transform/RTCPeerConnection-insertable-streams-simulcast.https.html [ Failure Pass Timeout ] crbug.com/1228788 [ Linux ] external/wpt/webrtc-encoded-transform/RTCPeerConnection-insertable-streams-audio.https.html [ Failure Pass ] -crbug.com/1228772 [ Linux ] external/wpt/webrtc/simulcast/h264.https.html [ Crash Pass Failure ] +crbug.com/1228772 [ Linux ] external/wpt/webrtc/simulcast/h264.https.html [ Crash Failure Pass ] crbug.com/1228772 [ Linux ] virtual/webrtc-wpt-plan-b/external/wpt/webrtc/RTCPeerConnection-mandatory-getStats.https.html [ Failure Pass ] crbug.com/1228959 [ Linux ] virtual/scroll-unification/fast/scroll-snap/snaps-after-wheel-scrolling-single-tick.html [ Failure Pass ] @@ -7347,5 +7354,7 @@ crbug.com/1229212 inspector-protocol/heap-profiler/heap-samples-in-snapshot.js [ Failure ] # Sheriff 2021-07-15 -crbug.com/1229439 [ Mac10.14 ] virtual/dark-color-scheme/media/audio-focus-ring.html [ Pass Failure ] -crbug.com/1229439 [ Mac10.14 ] media/audio-repaint.html [ Pass Failure ] +crbug.com/1229439 [ Mac10.14 ] virtual/dark-color-scheme/media/audio-focus-ring.html [ Failure Pass ] +crbug.com/1229439 [ Mac10.14 ] media/audio-repaint.html [ Failure Pass ] +crbug.com/1229666 external/wpt/html/semantics/forms/form-submission-0/urlencoded2.window.html [ Pass Timeout ] +crbug.com/1229666 virtual/synchronous_html_parser/external/wpt/html/semantics/forms/form-submission-0/urlencoded2.window.html [ Pass Timeout ]
diff --git a/third_party/blink/web_tests/VirtualTestSuites b/third_party/blink/web_tests/VirtualTestSuites index d20be0c9b..8bf5b44 100644 --- a/third_party/blink/web_tests/VirtualTestSuites +++ b/third_party/blink/web_tests/VirtualTestSuites
@@ -661,7 +661,7 @@ "prefix": "passive-fingerprinting", "bases": ["http/tests/navigation/frozen-useragent.html", "http/tests/navigation/useragent.php"], - "args": ["--enable-features=FreezeUserAgent"] + "args": ["--enable-features=ReduceUserAgent"] }, { "prefix": "file-system-access-access-handle",
diff --git a/third_party/blink/web_tests/android/WebLayerWPTOverrideExpectations b/third_party/blink/web_tests/android/WebLayerWPTOverrideExpectations index 7f79638..e1fd3b80 100644 --- a/third_party/blink/web_tests/android/WebLayerWPTOverrideExpectations +++ b/third_party/blink/web_tests/android/WebLayerWPTOverrideExpectations
@@ -810,6 +810,7 @@ crbug.com/1050754 external/wpt/external/wpt/infrastructure/server/context.any.serviceworker-module.html [ Failure ] crbug.com/1050754 external/wpt/external/wpt/infrastructure/server/context.any.sharedworker-module.html [ Failure ] crbug.com/1050754 external/wpt/external/wpt/infrastructure/server/context.any.sharedworker.html [ Failure ] +crbug.com/1050754 external/wpt/external/wpt/selection/contenteditable/modifying-selection-with-primary-mouse-button.tentative.html [ Crash ] crbug.com/1050754 external/wpt/external/wpt/streams/readable-byte-streams/general.any.html [ Timeout ] crbug.com/1050754 external/wpt/external/wpt/streams/readable-byte-streams/general.any.serviceworker.html [ Timeout ] crbug.com/1050754 external/wpt/external/wpt/streams/readable-byte-streams/general.any.sharedworker.html [ Failure ]
diff --git a/third_party/blink/web_tests/external/WPT_BASE_MANIFEST_8.json b/third_party/blink/web_tests/external/WPT_BASE_MANIFEST_8.json index 425b828c..15ff174 100644 --- a/third_party/blink/web_tests/external/WPT_BASE_MANIFEST_8.json +++ b/third_party/blink/web_tests/external/WPT_BASE_MANIFEST_8.json
@@ -76062,6 +76062,32 @@ {} ] ], + "abspos-in-opacity-000.html": [ + "f41c0353630d41be14ee3d56e89b7796540db673", + [ + null, + [ + [ + "/css/css-break/abspos-in-opacity-000-ref.html", + "==" + ] + ], + {} + ] + ], + "abspos-in-opacity-001.html": [ + "e81c55832175763d92a64da5b81b4fd0772b77be", + [ + null, + [ + [ + "/css/css-break/abspos-in-opacity-001-ref.html", + "==" + ] + ], + {} + ] + ], "avoid-border-break.html": [ "56f47e83c57f0914b87910870d67d5490d9e4eb3", [ @@ -76556,6 +76582,32 @@ {} ] ], + "change-inline-color.html": [ + "c4334af0d7377ad9cdae4d2c13bf36a6b75554f3", + [ + null, + [ + [ + "/css/css-break/change-inline-color-ref.html", + "==" + ] + ], + {} + ] + ], + "contain-strict-with-opacity-and-oof.html": [ + "b3323a60c75247249f4494834bbf2b57dda172d4", + [ + null, + [ + [ + "/css/css-break/contain-strict-with-opacity-and-oof-ref.html", + "==" + ] + ], + {} + ] + ], "fieldset-001.html": [ "d320fe15bebcfbdd332ee9411b548dab60f8fba6", [ @@ -77233,7 +77285,7 @@ ] ], "out-of-flow-in-multicolumn-035.html": [ - "6a2d5276ca0499af0a27ddff373eb4eb0707bbbe", + "f1fff4031b8680efbb666ede87b54376cc908ce3", [ null, [ @@ -77557,6 +77609,32 @@ {} ] ], + "out-of-flow-in-multicolumn-066.html": [ + "024b93f54002a61d04f50144603ddd4b793b9df2", + [ + null, + [ + [ + "/css/reference/ref-filled-green-100px-square.xht", + "==" + ] + ], + {} + ] + ], + "out-of-flow-in-multicolumn-067.html": [ + "4d38c4608e222edf0b1739a26f3aa82164a5d144", + [ + null, + [ + [ + "/css/reference/ref-filled-green-100px-square.xht", + "==" + ] + ], + {} + ] + ], "overflow-clip-000.html": [ "72b10f5cdd3092a042f1f90bff04e9428d61608e", [ @@ -77999,6 +78077,32 @@ {} ] ], + "transform-008.html": [ + "b3b80d72d66587d58a4f4f1ebb7ecd2e478c10e6", + [ + null, + [ + [ + "/css/css-break/transform-008-ref.html", + "==" + ] + ], + {} + ] + ], + "transform-009.html": [ + "f0653f7976b97c7fe9a0cd57fc7725aa7573cf39", + [ + null, + [ + [ + "/css/css-break/transform-009-ref.html", + "==" + ] + ], + {} + ] + ], "widows-001.html": [ "eb453ee64d8cfa1bcee456d614b64a3d67be122e", [ @@ -87291,6 +87395,19 @@ {} ] ], + "counter-styles-shadow-dom-part.html": [ + "2be169c80126c056b244f0d8ae73067523b65ecc", + [ + null, + [ + [ + "/css/css-counter-styles/counter-styles-shadow-dom-part-ref.html", + "==" + ] + ], + {} + ] + ], "cssom": { "cssom-additive-symbols-setter-invalid.html": [ "fd382553df86d6b093d5d580f97b6791dab8b77b", @@ -125215,6 +125332,19 @@ {} ] ], + "spanner-in-opacity.html": [ + "78b1ac80e5f504eabb1a85c87d153260cc436d41", + [ + null, + [ + [ + "/css/css-multicol/spanner-in-opacity-ref.html", + "==" + ] + ], + {} + ] + ], "with-custom-layout-on-same-element.https.html": [ "5388b08cde3936088978f09ccb0fd438347421e1", [ @@ -129272,6 +129402,112 @@ {} ] ], + "multicol": { + "vlr-ltr-ltr-in-multicol.html": [ + "5b597a6377d66add77e32e6964220adf3167f66c", + [ + null, + [ + [ + "/css/css-position/static-position/multicol/vlr-in-multicol-ref.html", + "==" + ] + ], + {} + ] + ], + "vlr-ltr-rtl-in-multicol.tentative.html": [ + "bef4c8559041e089d1599f924dc5a7b8e823f700", + [ + null, + [ + [ + "/css/css-position/static-position/multicol/vlr-in-multicol-ref.html", + "==" + ] + ], + {} + ] + ], + "vlr-rtl-ltr-in-multicol.tentative.html": [ + "ef2e5b76359c4bfc5061bb3c5070a9bf4958827b", + [ + null, + [ + [ + "/css/css-position/static-position/multicol/vlr-in-multicol-ref.html", + "==" + ] + ], + {} + ] + ], + "vlr-rtl-rtl-in-multicol.html": [ + "1bfcf2152518843170cd38efc8ed644cd5bc1a11", + [ + null, + [ + [ + "/css/css-position/static-position/multicol/vlr-in-multicol-ref.html", + "==" + ] + ], + {} + ] + ], + "vrl-ltr-ltr-in-multicol.html": [ + "1d6c584d033e8d700e15b448ca8e32aa55f88015", + [ + null, + [ + [ + "/css/css-position/static-position/multicol/vrl-in-multicol-ref.html", + "==" + ] + ], + {} + ] + ], + "vrl-ltr-rtl-in-multicol.tentative.html": [ + "900a649f6da5ff3384f612a5689201bf8ce18b4e", + [ + null, + [ + [ + "/css/css-position/static-position/multicol/vrl-in-multicol-ref.html", + "==" + ] + ], + {} + ] + ], + "vrl-rtl-ltr-in-multicol.tentative.html": [ + "41951437b881d4b5d109a52342509dff4e9d37f1", + [ + null, + [ + [ + "/css/css-position/static-position/multicol/vrl-in-multicol-ref.html", + "==" + ] + ], + {} + ] + ], + "vrl-rtl-rtl-in-multicol.html": [ + "bb59d4f6936258ae5408b2fb31e41542b6d8d2cc", + [ + null, + [ + [ + "/css/css-position/static-position/multicol/vrl-in-multicol-ref.html", + "==" + ] + ], + {} + ] + ] + }, "vlr-ltr-ltr.html": [ "aa929a7b5085a72acdde7b05b49d9f452fc373e8", [ @@ -141567,6 +141803,19 @@ {} ] ], + "percentage-sizing-of-table-cell-007.html": [ + "371333a24d90afb9550729250432d605a84c098c", + [ + null, + [ + [ + "/css/css-tables/height-distribution/percentage-sizing-of-table-cell-007-ref.html", + "==" + ] + ], + {} + ] + ], "percentage-sizing-of-table-cell-children-002.html": [ "19b02b20315e5600546b8e8d618b17e87abaa755", [ @@ -159493,6 +159742,21 @@ ] ], "individual-transform": { + "animation": { + "individual-transform-ordering.html": [ + "9d127f163bc2b88ba4eedc28bf9eb143846b26c1", + [ + null, + [ + [ + "/css/css-transforms/individual-transform/animation/individual-transform-ordering-ref.html", + "==" + ] + ], + {} + ] + ] + }, "individual-transform-1.html": [ "f21954e01dfc0f8f70c9dd43262d40b3374010b5", [ @@ -210878,7 +211142,7 @@ [] ], "OWNERS": [ - "eec8da94435b0b9f32a894a73615f8c455c84c89", + "b1c630574e26ab387d86c039fe2197a7ff662923", [] ], "async-idlharness.https-expected.txt": [ @@ -223274,6 +223538,14 @@ "b28f7fbbdb4bc0d5c2e152d92a33a309de6887a8", [] ], + "abspos-in-opacity-000-ref.html": [ + "b7013a90ab3834935522850a8cf5e02bf04fe7ef", + [] + ], + "abspos-in-opacity-001-ref.html": [ + "b7013a90ab3834935522850a8cf5e02bf04fe7ef", + [] + ], "block-001-wm-vlr-ref.html": [ "b131b0e486084ed3a127ac07c23425f8e50be93a", [] @@ -223358,6 +223630,14 @@ "3459e25edd64ca8d90cebd4a44f68aa9b4106e25", [] ], + "change-inline-color-ref.html": [ + "7f99f57a67957bfeb57717852b03eb707c6a52f7", + [] + ], + "contain-strict-with-opacity-and-oof-ref.html": [ + "a9c82c4f3e2d717469bd5bc9e9ff9cefb49a25d0", + [] + ], "fieldset-001-ref.html": [ "1422086da71c3e62bde10d499a7a0de220737f3f", [] @@ -223501,6 +223781,14 @@ "transform-007-ref.html": [ "50599b119a7f0ab5246389de57c439e086b8797d", [] + ], + "transform-008-ref.html": [ + "2a16079545c82dd417f8fde6efa66d5a31c90111", + [] + ], + "transform-009-ref.html": [ + "d7d3ebf604c62d80874d4f42a2dc71744c776b75", + [] ] }, "css-cascade": { @@ -225090,6 +225378,10 @@ "aa398f73a7f206a196e35b8a5538200a93353040", [] ], + "counter-styles-shadow-dom-part-ref.html": [ + "7f1af7532075c983e7fc0bcec7cd14830e0c13eb", + [] + ], "cssom": { "cssom-additive-symbols-setter-ref.html": [ "a09788e369a58a35dd92370cc1f25ef2561c1814", @@ -239580,6 +239872,10 @@ [] ] }, + "spanner-in-opacity-ref.html": [ + "e981eac2f27f04fc9955b3839aa0f8107e52d6d7", + [] + ], "support": { "1x1-green.png": [ "b98ca0ba0a03c580ac339e4a3653539cfa8edc71", @@ -240603,6 +240899,16 @@ "bd534b07729131a7e253c8647bf12ce8e04b7fc8", [] ], + "multicol": { + "vlr-in-multicol-ref.html": [ + "908f43a002877096bd57e335e5ac773261cb37ff", + [] + ], + "vrl-in-multicol-ref.html": [ + "0e22219eabdbb3cdd6e748834080da412c5e69a3", + [] + ] + }, "vlr-ref.html": [ "2dc2012f0466c4cd2fd8f3d98da3a6e52af90070", [] @@ -243561,6 +243867,10 @@ ] }, "height-distribution": { + "percentage-sizing-of-table-cell-007-ref.html": [ + "cdd6e7c906280a3dc6b65cf2e098c62ac7f8b137", + [] + ], "percentage-sizing-of-table-cell-children-002-ref.html": [ "f2ed9e15dd2269fcb3d85ba25f7e2b423c9f92ea", [] @@ -247559,6 +247869,12 @@ [] ], "individual-transform": { + "animation": { + "individual-transform-ordering-ref.html": [ + "94e7e439e6bae3c42389a614178d84607ab06901", + [] + ] + }, "individual-transform-1-ref.html": [ "dbc5f05d8925a8ddd37c8a6499b0563d4fdaf71e", [] @@ -266788,6 +267104,14 @@ "16179eb0133a9e14667e127da05f3dc796975875", [] ], + "about-blank-popup.https-expected.txt": [ + "2abf55d6052aee9c9699356c8fcd2a160f91c62b", + [] + ], + "about-blank-popup.https.html.headers": [ + "6604450991a122e3e241e40b1b9e0516c525389d", + [] + ], "anonymous-iframe": { "cookie.tentative.https-expected.txt": [ "377c7296a781adb8ce5792cda50a4ded28472339", @@ -266797,6 +267121,14 @@ "0f6267c7c83b6d4183dc8d273e43e12b80fe07fc", [] ], + "require-corp-embed-anonymous-iframe.tentative.https-expected.txt": [ + "88ba85f7acab67891f9dfda9d3fcaa6dc07b960a", + [] + ], + "require-corp-embed-anonymous-iframe.tentative.https.html.headers": [ + "6604450991a122e3e241e40b1b9e0516c525389d", + [] + ], "resources": { "common.js": [ "9134d2063e606c0858592c69bd20fef8758523eb", @@ -266804,6 +267136,10 @@ ] } }, + "blob.https-expected.txt": [ + "09cd640c1aa5884cef0b07e0bedb9ae90506973d", + [] + ], "blob.https.html.headers": [ "6604450991a122e3e241e40b1b9e0516c525389d", [] @@ -266996,7 +267332,7 @@ ], "resources": { "blob-url-factory.html": [ - "d2039064a8df63021b7c76f9eef5a619de32377d", + "928d404672ddece3576c8f4e1132126c50315873", [] ], "blob-url-factory.html.headers": [ @@ -267040,7 +267376,7 @@ [] ], "navigate-none.sub.html": [ - "c4fb3f4afbdeeb88b450ddedefb364ead394a746", + "f2fc38ff14532c4189339353cd667d2e9045785f", [] ], "navigate-require-corp-same-site.sub.html": [ @@ -267075,6 +267411,10 @@ "30ddeac2e7a3596de3910def1a7066e817873cbe", [] ], + "postmessage-ready.html": [ + "3282711dbc2c9bac534e44fa9d11ef3870a8c563", + [] + ], "report.py": [ "2fe40526ea9523ab4a7de45ffcfdb6ba39f92ce7", [] @@ -278058,6 +278398,12 @@ "013970bedf34612e8aba03571cdf71af6e917b3f", [] ], + "resources": { + "fetch-and-post-result.html": [ + "4df0c4c71acd4a1a4025b3596a956ace8763ab25", + [] + ] + }, "tools": { "ahem-generate-table.py": [ "8790da02e2793664f7e1f0808f8d2b998718d54a", @@ -278468,10 +278814,6 @@ "ed125b6e9febcf10d0fe5d2e926f0576c34fc46f", [] ], - "delete_all_cookies-expected.txt": [ - "18d7bf34a0b005273b1b661476d942794ae620bf", - [] - ], "file_upload.py": [ "9c4dd75438454b852a1590018361ee682f1106df", [] @@ -279341,12 +279683,8 @@ "112266865bb8c5c2dda4a3b76ea4c0be9b7c7749", [] ], - "sanitizer-api.idl": [ - "9db926c478cae7e733d6bffad3ffb1b5bdbae5de", - [] - ], "sanitizer-api.tentative.idl": [ - "e130e4ecb05c46bc0c7c8519d3f10fb66d6e5af2", + "3e843d8eb0cbcc448010dd6a56d3a2ecd1321314", [] ], "savedata.idl": [ @@ -279722,9 +280060,31 @@ [] ], "__dir__.headers": [ - "35b10bd2ccdbfa99feb96079fafab61346d025ed", + "93537b44ded3365d48cce9649697e2823f1a2482", [] - ] + ], + "resources": { + "__dir__.headers": [ + "93537b44ded3365d48cce9649697e2823f1a2482", + [] + ], + "child-frame.html": [ + "7f8125eae74a44e9b3ee0b2743d2b61db1faad44", + [] + ], + "external-script.js": [ + "6f6bd42b255eb994418ff6e7f80006cbd7cead8e", + [] + ], + "external-script.js.headers": [ + "cb762eff806849df46dc758ef7b98b63f27f54c9", + [] + ], + "profile-utils.js": [ + "33338a6c486b8c8d65d6b75038a07c423c3071e4", + [] + ] + } }, "keyboard-lock": { "META.yml": [ @@ -279859,7 +280219,7 @@ ] }, "lint.ignore": [ - "1ca2a941aabee0cbf7e0381021462e1a86b2d877", + "5cdfb48df1d6d47222b3092f6644006777eb6473", [] ], "loading": { @@ -285715,7 +286075,7 @@ [] ], "test-case.sub.js": [ - "6656084d54767f005a61295b8444eef1b78de4fe", + "717cd1a5e75b476a7580626246fb8f75eaae82f5", [] ] }, @@ -286228,14 +286588,6 @@ "c9980e1285b7e14a85cba19f2c870f480e303946", [] ], - "mock-screenenumeration.js": [ - "fc89b11ea106c8bda9f9deec300915e51fd26dd0", - [] - ], - "mock-screenenumeration.js.header": [ - "6805c323df5a975231648b830e33ce183c3cbbd3", - [] - ], "mock-textdetection.js": [ "52ca987e28639a93363b5496a0f0c14a46e2bb50", [] @@ -286544,17 +286896,7 @@ "META.yml": [ "abfee89ffbdd29ccd2741bbd3d4a314387025509", [] - ], - "README.md": [ - "42a5ebfc5169f43fa9289e85fed4d640071fde3d", - [] - ], - "resources": { - "screenenumeration-helpers.js": [ - "d0e0d9c56bc1ec56ee3e5511312ae652c94997e4", - [] - ] - } + ] }, "scroll-animations": { "META.yml": [ @@ -286785,11 +287127,11 @@ [] ], "modifying-selection-with-middle-mouse-button.tentative-expected.txt": [ - "25bd584f5d5bc88aacc07bc2cbfcfb883598dd10", + "f582a36d20f0c36208acc0d3dc8a35f5691cd8a7", [] ], "modifying-selection-with-primary-mouse-button.tentative-expected.txt": [ - "032b11201e7ea038665514dfe7c07c0ea8a3385d", + "73195cac4435e8ff86ffdb96b2c4d7fcdbef112c", [] ] }, @@ -292512,7 +292854,7 @@ [] ], "META.yml": [ - "eaefdd02a1e769e716bc1d17b06dbe6fec34a393", + "a925b52d6f0e9d2ef1b291d50486713d0ee83744", [] ], "README.md": [ @@ -292589,6 +292931,18 @@ [] ], "exception": { + "basic.tentative.any.serviceworker-expected.txt": [ + "73f209a6f8af37976bc6e97587a22d74cb02f222", + [] + ], + "basic.tentative.any.sharedworker-expected.txt": [ + "73f209a6f8af37976bc6e97587a22d74cb02f222", + [] + ], + "basic.tentative.any.worker-expected.txt": [ + "73f209a6f8af37976bc6e97587a22d74cb02f222", + [] + ], "constructor.tentative.any-expected.txt": [ "0456f4d2453e86f913bbd6c88cd49caf11dcacc2", [] @@ -292825,7 +293179,7 @@ ] }, "wasm-module-builder.js": [ - "25fb1c836b05e28a1e692dd31dd6061979483b1f", + "7be72f86dae75240edfa3548826e6f88bfde40c8", [] ] }, @@ -293576,7 +293930,7 @@ [] ], "OWNERS": [ - "a837fc9b778c06fe4102cfd17f889d315b59ca03", + "5248064ba91d4ff2d9cde82c8ceb12e0a7c7b609", [] ], "README.md": [ @@ -294018,7 +294372,7 @@ [] ], "utils.js": [ - "e07d0fdc8d4eaee281c068b0edae413418679d4e", + "70af03cc030cad0af4aa18a826e9246854b0f9f8", [] ], "vp8.webm": [ @@ -410936,6 +411290,13 @@ } }, "cross-origin-embedder-policy": { + "about-blank-popup.https.html": [ + "2dc73c7561ff297ea2cf50c67d8218fef941a194", + [ + null, + {} + ] + ], "anonymous-iframe": { "cookie.tentative.https.html": [ "43282dd246e33757310fd20755678ec9010e3606", @@ -410950,10 +411311,17 @@ null, {} ] + ], + "require-corp-embed-anonymous-iframe.tentative.https.html": [ + "902d91f778f0d3a7c86ce7cbdf23717508c6575c", + [ + null, + {} + ] ] }, "blob.https.html": [ - "77af2bc77de3301bcee344cdfbec6b5761c2e89f", + "ce72f247ef7b6fc6b54196dbc47582b5118d54ca", [ null, {} @@ -422340,7 +422708,7 @@ ] ], "dialog-open.html": [ - "4719f63b853ded4577d09066eb7ef2cedf7cd934", + "e1f4c6ab82a17b8e013fe066b99338beabf3d544", [ null, {} @@ -430931,7 +431299,7 @@ ] ], "non-local-ports.sub.window.js": [ - "16855aae3800504ba735de8dfc4a4c73730d8c8e", + "8c9eb33c4f77ba1b7724a253a3f73d765d7425ab", [ "infrastructure/assumptions/non-local-ports.sub.window.html", {} @@ -432589,13 +432957,78 @@ } }, "js-self-profiling": { + "concurrent-profilers.https.html": [ + "26f37ec8bdcd8b67173c3b83b285ed1e291870a4", + [ + null, + {} + ] + ], + "external-script.https.html": [ + "9f9438ba6d45612446ce3b6a5a58d5017393d5b9", + [ + null, + {} + ] + ], + "function-names.https.html": [ + "1d61248725fbe930e21cdae8f9b490ab6eda6f6d", + [ + null, + {} + ] + ], "idlharness.https.html": [ "3807a6e4fa384479fc50d826f81f53556132f4f2", [ null, {} ] - ] + ], + "iframe-context-filtration.https.html": [ + "4d262642112b7b2c4fd58b10e083cb6bced3252a", + [ + null, + {} + ] + ], + "inline-script.html": [ + "56a7b55c6b99ab75ad3710006398ac98447943e8", + [ + null, + {} + ] + ], + "max-buffer-size.https.html": [ + "399b8048b1304e1079dbea4dc1eef0ccc311a131", + [ + null, + {} + ] + ], + "time-domain.window.js": [ + "5791a3de75feb5754f65a75ba93b8b16b4038909", + [ + "js-self-profiling/time-domain.window.html", + { + "script_metadata": [ + [ + "script", + "resources/profile-utils.js" + ] + ] + } + ] + ], + "without-document-policy": { + "disabled.https.html": [ + "bff9851263b7b34ad4e6a665da9199a7488aebda", + [ + null, + {} + ] + ] + } }, "keyboard-lock": { "idlharness.https.window.js": [ @@ -436151,7 +436584,7 @@ }, "mediacapture-insertable-streams": { "MediaStreamTrackGenerator-audio.https.html": [ - "16bea6a312824ed423b367c49934661c47c229fe", + "df83e7e1b826a0839fcabf08e3f586d445c2080c", [ null, {} @@ -458927,21 +459360,14 @@ ] ], "sanitizer-config.https.tentative.html": [ - "06f41b261295a6dbea99a6ec719807badeb307d5", + "fb29631e33ba184990b4e131e91171ba8a98ec89", [ null, {} ] ], "sanitizer-sanitize.https.tentative.html": [ - "34615f6383b8f6db0330f5b8181e3ef157b7dbf8", - [ - null, - {} - ] - ], - "sanitizer-sanitizeToString.https.tentative.html": [ - "f76560d447b96c022abc10f522b121be9384a427", + "b146290754ad68c63bff1ff36a7ddd9c2fab68fc", [ null, {} @@ -460802,13 +461228,6 @@ } ] ], - "getScreens.values.https.html": [ - "b29ff5ab309d592c5bf940a9d2008655841746a8", - [ - null, - {} - ] - ], "isExtended.tentative.https.window.js": [ "3c814ae3d91d519500f7b44ab8fe4faa8a861d88", [ @@ -460823,35 +461242,6 @@ } ] ], - "isMultiScreen.tentative.https.window.js": [ - "ac32dd05169e0a9cebeab0ff05a32fe36167362e", - [ - "screen_enumeration/isMultiScreen.tentative.https.window.html", - { - "script_metadata": [ - [ - "global", - "window" - ], - [ - "script", - "/resources/testdriver.js" - ], - [ - "script", - "/resources/testdriver-vendor.js" - ] - ] - } - ] - ], - "isMultiScreen.values.https.html": [ - "2a79db4e10ec6e9664807a85df56e9327bdb73eb", - [ - null, - {} - ] - ], "screen_enumeration_permission.https.window.js": [ "00adbfc52acfceedc949093444f24f04f9dc1a27", [ @@ -461430,8 +461820,8 @@ ] }, "secure-payment-confirmation": { - "secure-payment-confirmation.tenative.https.html": [ - "93a3d17c993f0ffdee0ce2835f433ca2c0b3fe49", + "secure-payment-confirmation.tentative.https.html": [ + "671f3287a6f936c193ed4ce2cd1bc123ee127c1a", [ null, { @@ -461692,7 +462082,7 @@ ] ], "modifying-selection-with-middle-mouse-button.tentative.html": [ - "54c3c848012ad9701558ef0f866ebe703c8f8581", + "a8287d900283ce5021ede7bfa06a73d069fc7f0e", [ null, { @@ -461701,7 +462091,7 @@ ] ], "modifying-selection-with-primary-mouse-button.tentative.html": [ - "4955689fe8158603e2f93903d60919097fc0b474", + "57586a60602836e94da2c50f6bf7257d8c9e4192", [ null, { @@ -479519,8 +479909,8 @@ {} ] ], - "virtual-keyboard-type.html": [ - "1ba71f501bebc687fa271f2b4d9ac1ea521d29ac", + "virtual-keyboard-type.https.html": [ + "47d09ce04781a4c7c1aec62336542f8ca06e0d71", [ null, {} @@ -479985,6 +480375,85 @@ ] }, "exception": { + "basic.tentative.any.js": [ + "9ddebae0e968a28135b9c73748fffb80be4468e4", + [ + null, + { + "jsshell": true, + "script_metadata": [ + [ + "global", + "window,worker,jsshell" + ], + [ + "script", + "/wasm/jsapi/wasm-module-builder.js" + ] + ] + } + ], + [ + "wasm/jsapi/exception/basic.tentative.any.html", + { + "script_metadata": [ + [ + "global", + "window,worker,jsshell" + ], + [ + "script", + "/wasm/jsapi/wasm-module-builder.js" + ] + ] + } + ], + [ + "wasm/jsapi/exception/basic.tentative.any.serviceworker.html", + { + "script_metadata": [ + [ + "global", + "window,worker,jsshell" + ], + [ + "script", + "/wasm/jsapi/wasm-module-builder.js" + ] + ] + } + ], + [ + "wasm/jsapi/exception/basic.tentative.any.sharedworker.html", + { + "script_metadata": [ + [ + "global", + "window,worker,jsshell" + ], + [ + "script", + "/wasm/jsapi/wasm-module-builder.js" + ] + ] + } + ], + [ + "wasm/jsapi/exception/basic.tentative.any.worker.html", + { + "script_metadata": [ + [ + "global", + "window,worker,jsshell" + ], + [ + "script", + "/wasm/jsapi/wasm-module-builder.js" + ] + ] + } + ] + ], "constructor.tentative.any.js": [ "0fd47b455e023c7aecd40cf0dfafb175b7bb3e43", [ @@ -487239,7 +487708,7 @@ ] ], "audio-data.any.js": [ - "02d4f8fdfb0e7c04d2c4a6dae93fc5a4dfc93d74", + "6f133ef1c4284e0b3a151848b4835d5f227fb784", [ "webcodecs/audio-data.any.html", { @@ -487345,7 +487814,7 @@ ] ], "audioDecoder-codec-specific.any.js": [ - "6635c335b4255a97069218768121732853ca3e59", + "994aaf1d17b73428eaf6b316aa73fd76e6e29b40", [ "webcodecs/audioDecoder-codec-specific.any.html?adts_aac", { @@ -487815,6 +488284,28 @@ } ] ], + "chunk-serialization.any.js": [ + "e8a0b1318e0f582e5344b728fba003f99cb65514", + [ + "webcodecs/chunk-serialization.any.html", + { + "script_metadata": [ + [ + "global", + "window" + ], + [ + "script", + "/common/media.js" + ], + [ + "script", + "/webcodecs/utils.js" + ] + ] + } + ] + ], "encoded-audio-chunk.any.js": [ "fce35283d198b4090a65d687187c6c20e5816e76", [ @@ -488070,7 +488561,7 @@ ] ], "videoDecoder-codec-specific.any.js": [ - "16a35e3c98b68ae74a2ba7d79b822684e4078f2b", + "f94bee82d18de1da1fa9d685005baac5327402d8", [ "webcodecs/videoDecoder-codec-specific.any.html?av1", { @@ -488440,7 +488931,7 @@ ] ], "videoFrame-createImageBitmap.any.js": [ - "7b08d292084ba79b64f9479df8b91a53f26d8293", + "415d0bbcbd732b722cf4a8c0fb62972a8bc7b3d6", [ "webcodecs/videoFrame-createImageBitmap.any.html", { @@ -488547,7 +489038,7 @@ ] ], "videoFrame.any.js": [ - "a67a1b260d1cc34c1c89544a054eca983204c794", + "827117076ac3aafd7df151ac98113c037b9c7e58", [ "webcodecs/videoFrame.any.html", {
diff --git a/third_party/blink/web_tests/external/wpt/css/css-break/out-of-flow-in-multicolumn-058.html b/third_party/blink/web_tests/external/wpt/css/css-break/out-of-flow-in-multicolumn-058.html new file mode 100644 index 0000000..a8ddcdc --- /dev/null +++ b/third_party/blink/web_tests/external/wpt/css/css-break/out-of-flow-in-multicolumn-058.html
@@ -0,0 +1,40 @@ +<!DOCTYPE html> +<title> + Out-of-flow positioned element in multicol with inline containing block - the + relative offset should apply to the OOF descendant after fragmentation. +</title> +<link rel="help" href="https://www.w3.org/TR/css-position-3/#abspos-breaking"> +<link rel="match" href="../reference/ref-filled-green-100px-square.xht"> +<style> + .multicol { + column-count: 2; + column-fill: auto; + column-gap: 0px; + height: 100px; + width: 100px; + margin-left: -400px; + margin-top: -400px; + } + .rel { + position: relative; + } + .abs { + position: absolute; + background-color: green; + width: 50px; + } +</style> +<p>Test passes if there is a filled green square and <strong>no red</strong>.</p> +<div class="multicol"> + <div class="rel" style="top: 200px; left: 200px;"> + <div class="rel" style="top: 50px; left: 50px;"> + <span class="rel" style="top: 50px; left: 100px;"> + <span class="rel" style="top: 100px; left: 50px;"> + <div style="height: 200px; width: 50px; background: red;"></div> + <div class="abs" style="top: 0px; height: 50px;"></div> + <div class="abs" style="top: 50px; height: 150px;"></div> + </span> + </span> + </div> + </div> +</div>
diff --git a/third_party/blink/web_tests/external/wpt/css/css-break/out-of-flow-in-multicolumn-059.html b/third_party/blink/web_tests/external/wpt/css/css-break/out-of-flow-in-multicolumn-059.html new file mode 100644 index 0000000..3575a75 --- /dev/null +++ b/third_party/blink/web_tests/external/wpt/css/css-break/out-of-flow-in-multicolumn-059.html
@@ -0,0 +1,37 @@ +<!DOCTYPE html> +<title> + Out-of-flow positioned element in multicol - the relative offset should + apply to the OOF descendant after fragmentation. +</title> +<link rel="help" href="https://www.w3.org/TR/css-position-3/#abspos-breaking"> +<link rel="match" href="../reference/ref-filled-green-100px-square.xht"> +<style> + .multicol { + column-count: 2; + column-fill: auto; + column-gap: 0px; + height: 100px; + width: 100px; + margin-left: -150px; + margin-top: -150px; + } + .rel { + position: relative; + } + .abs { + position: absolute; + background-color: green; + height: 200px; + width: 50px; + top: 0px; + } +</style> +<p>Test passes if there is a filled green square and <strong>no red</strong>.</p> +<div class="multicol"> + <span class="rel" style="top: 50px; left: 100px;"> + <div class="rel" style="top: 100px; left: 50px;"> + <div style="height: 200px; width: 50px; background: red;"></div> + <span class="abs"></span> + </div> + </span> +</div>
diff --git a/third_party/blink/web_tests/external/wpt/css/css-break/out-of-flow-in-multicolumn-060.html b/third_party/blink/web_tests/external/wpt/css/css-break/out-of-flow-in-multicolumn-060.html new file mode 100644 index 0000000..8de72c6d --- /dev/null +++ b/third_party/blink/web_tests/external/wpt/css/css-break/out-of-flow-in-multicolumn-060.html
@@ -0,0 +1,38 @@ +<!DOCTYPE html> +<title> + Nested out-of-flow positioned element in multicol with inline containing + block - the relative offset should apply to the OOF descendant after + fragmentation. +</title> +<link rel="help" href="https://www.w3.org/TR/css-position-3/#abspos-breaking"> +<link rel="match" href="../reference/ref-filled-green-100px-square.xht"> +<style> + .multicol { + column-count: 2; + column-fill: auto; + column-gap: 0px; + height: 100px; + width: 100px; + margin-left: -100px; + margin-top: -50px; + } + .rel { + position: relative; + } + .abs { + position: absolute; + background-color: green; + height: 200px; + width: 50px; + top: 0px; + } +</style> +<p>Test passes if there is a filled green square and <strong>no red</strong>.</p> +<div class="multicol"> + <div class="rel" style="top: 50px; left: 100px;"> + <span class="abs"> + <div style="height: 200px; width: 50px; background: red;"></div> + <div class="abs"></div> + </span> + </div> +</div>
diff --git a/third_party/blink/web_tests/external/wpt/css/css-break/out-of-flow-in-multicolumn-061.html b/third_party/blink/web_tests/external/wpt/css/css-break/out-of-flow-in-multicolumn-061.html new file mode 100644 index 0000000..86e515b --- /dev/null +++ b/third_party/blink/web_tests/external/wpt/css/css-break/out-of-flow-in-multicolumn-061.html
@@ -0,0 +1,45 @@ +<!DOCTYPE html> +<title> + Nested out-of-flow positioned element in multicol - the relative offset + should apply to the OOF descendant after fragmentation. +</title> +<link rel="help" href="https://www.w3.org/TR/css-position-3/#abspos-breaking"> +<link rel="match" href="../reference/ref-filled-green-100px-square.xht"> +<style> + .multicol { + column-count: 2; + column-fill: auto; + column-gap: 0px; + height: 100px; + width: 100px; + margin-left: -100px; + } + .rel { + position: relative; + } + .oof { + background-color: green; + height: 100px; + width: 50px; + } + #abs { + position: absolute; + top: 100px; + } + #fixed { + position: fixed; + top: 0px; + left: 100px; + } +</style> +<p>Test passes if there is a filled green square and <strong>no red</strong>.</p> +<div class="multicol"> + <div style="transform: translateX(0);"> + <div class="rel" style="left: 100px;"> + <div style="height: 200px; width: 50px; background: red;"></div> + <span class="oof" id="abs"> + <div class="oof" id="fixed"></div> + </span> + </div> + </div> +</div>
diff --git a/third_party/blink/web_tests/external/wpt/css/css-break/out-of-flow-in-multicolumn-062.html b/third_party/blink/web_tests/external/wpt/css/css-break/out-of-flow-in-multicolumn-062.html new file mode 100644 index 0000000..e01f4a6 --- /dev/null +++ b/third_party/blink/web_tests/external/wpt/css/css-break/out-of-flow-in-multicolumn-062.html
@@ -0,0 +1,45 @@ +<!DOCTYPE html> +<title> + Out-of-flow positioned element in nested multicol with inline containing + block - the relative offset should apply to the OOF descendant after + fragmentation. +</title> +<link rel="help" href="https://www.w3.org/TR/css-position-3/#abspos-breaking"> +<link rel="match" href="../reference/ref-filled-green-100px-square.xht"> +<style> + .multicol { + column-count: 2; + column-fill: auto; + column-gap: 0px; + } + #outer { + height: 100px; + width: 100px; + margin-left: -150px; + margin-top: -150px; + } + #inner { + width: 50px; + } + .rel { + position: relative; + } + .abs { + position: absolute; + background-color: green; + width: 25px; + height: 400px; + left: -100px; + } +</style> +<p>Test passes if there is a filled green square and <strong>no red</strong>.</p> +<div class="multicol" id="outer"> + <div class="multicol" id="inner"> + <div class="rel" style="top: 50px; left: 100px;"> + <span class="rel" style="top: 100px; left: 50px;"> + <div style="height: 400px; width: 25px; background: red;"></div> + <div class="abs"></div> + </span> + </div> + </div> +</div>
diff --git a/third_party/blink/web_tests/external/wpt/css/css-break/out-of-flow-in-multicolumn-063.html b/third_party/blink/web_tests/external/wpt/css/css-break/out-of-flow-in-multicolumn-063.html new file mode 100644 index 0000000..7828e4a --- /dev/null +++ b/third_party/blink/web_tests/external/wpt/css/css-break/out-of-flow-in-multicolumn-063.html
@@ -0,0 +1,42 @@ +<!DOCTYPE html> +<title> + Out-of-flow positioned element in multicol with inline containing + block and vertical-rl writing mode. +</title> +<link rel="help" href="https://www.w3.org/TR/css-position-3/#abspos-breaking"> +<link rel="match" href="../reference/ref-filled-green-100px-square.xht"> +<style> + .multicol { + writing-mode: vertical-lr; + direction: rtl; + columns: 2; + column-fill: auto; + height: 100px; + width: 100px; + column-gap: 0px; + margin-top: 66px; + margin-left: -50px; + } + .rel { + position: relative; + inset-block-start: 50px; + inset-inline-start: 50px; + } + .abs { + position: absolute; + inline-size: 50px; + block-size: 200px; + inset-block-start: 0; + inset-inline-start: 0; + background: green; + } +</style> +<p>Test passes if there is a filled green square and <strong>no red</strong>.</p> +<div class="multicol"> + <div> + <span class="rel"> + <div style="block-size: 200px; inline-size: 50px; background: red;"></div> + <div class="abs"></div> + </span> + </div> +</div>
diff --git a/third_party/blink/web_tests/external/wpt/css/css-display/display-math-on-pseudo-elements-001-expected.txt b/third_party/blink/web_tests/external/wpt/css/css-display/display-math-on-pseudo-elements-001-expected.txt new file mode 100644 index 0000000..efe2ec3 --- /dev/null +++ b/third_party/blink/web_tests/external/wpt/css/css-display/display-math-on-pseudo-elements-001-expected.txt
@@ -0,0 +1,9 @@ +This is a testharness.js-based test. +PASS computed display on ::before and ::after for <div class="block"> +PASS computed display on ::before and ::after for <math class="block"> +PASS computed display on ::before and ::after for <mrow class="block"> +PASS computed display on ::before and ::after for <div class="inline"> +FAIL computed display on ::before and ::after for <math class="inline"> assert_equals: expected "inline" but got "block" +FAIL computed display on ::before and ::after for <mrow class="inline"> assert_equals: expected "inline" but got "block" +Harness: the test ran to completion. +
diff --git a/third_party/blink/web_tests/external/wpt/html/cross-origin-embedder-policy/iframe-history-none-require-corp.https.html b/third_party/blink/web_tests/external/wpt/html/cross-origin-embedder-policy/iframe-history-none-require-corp.https.html new file mode 100644 index 0000000..384c684 --- /dev/null +++ b/third_party/blink/web_tests/external/wpt/html/cross-origin-embedder-policy/iframe-history-none-require-corp.https.html
@@ -0,0 +1,54 @@ +<meta name="timeout" content="long"> +<script src=/resources/testharness.js></script> +<script src=/resources/testharnessreport.js></script> +<script src=/common/utils.js></script +<script src="/common/get-host-info.sub.js"></script> +<script> + +promise_test(async test => { + // TODO(arthursonzogni): Consider switching toward another message passing + // API like: + // /html/cross-origin-embedder-policy/credentialless/resources/dispatcher.js + const bc = new BroadcastChannel(token()); + const futureMessage = () => { + return new Promise(resolve => { + bc.onmessage = event => resolve(event.data); + }); + }; + + const prefix = document.URL.substr(0, document.URL.lastIndexOf('/')) + const attribute = `?channelName=${bc.name}`; + const url_coep_none = + prefix + "/resources/navigate-none.sub.html" + attribute; + const url_coep_require_corp = + prefix + "/resources/navigate-require-corp.sub.html" + attribute; + + const w = window.open(); + test.add_cleanup(() => w.close()); + + // Navigate to COEP:unsafe-none. + w.location.href = url_coep_none; + assert_equals(await futureMessage(), "loaded"); + assert_equals(w.location.href, url_coep_none); + + // For unknown reasons so far. Waiting in between the different navigations + // avoids flakes. + await new Promise(resolve => test.step_timeout(resolve, 1000)); + + // Navigate to COEP:require-corp. + w.location.href = url_coep_require_corp; + assert_equals(await futureMessage(), "loaded"); + assert_equals(w.location.href, url_coep_require_corp); + + // For unknown reasons so far. Waiting in between the different navigations + // avoids flakes. + await new Promise(resolve => test.step_timeout(resolve, 1000)); + + // Navigate back to COEP:unsafe-none, using the history API. + // Note: `url_coep_none` already take the BFCache into account. + w.history.back(); + assert_equals(await futureMessage(), "loaded"); + assert_equals(w.location.href, url_coep_none); +}, `"none" top-level: navigating a frame back from "require-corp" should succeed`); + +</script>
diff --git a/third_party/blink/web_tests/external/wpt/html/cross-origin-embedder-policy/none.https.html b/third_party/blink/web_tests/external/wpt/html/cross-origin-embedder-policy/none.https.html index 3e61e11..004924ad 100644 --- a/third_party/blink/web_tests/external/wpt/html/cross-origin-embedder-policy/none.https.html +++ b/third_party/blink/web_tests/external/wpt/html/cross-origin-embedder-policy/none.https.html
@@ -1,4 +1,3 @@ -<!doctype html> <meta name="timeout" content="long"> <title>Cross-Origin-Embedder-Policy header and nested navigable resource without such header</title> <script src=/resources/testharness.js></script> @@ -7,6 +6,7 @@ <script src="/common/get-host-info.sub.js"></script> <div id=log></div> <script> + const HOST = get_host_info(); const BASE = new URL("resources", location).pathname; @@ -42,38 +42,10 @@ }, `"none" top-level: navigating a frame from "require-corp" to "none" should succeed`); async_test(t => { - Promise.resolve().then(async () => { - const bc = new BroadcastChannel(token()); - const futureMessage = () => { - return new Promise(resolve => { - bc.onmessage = event => resolve(event.data); - }); - }; - - const prefix = document.URL.substr(0, document.URL.lastIndexOf('/')) - const attribute = `?channelName=${bc.name}`; - const url_1 = prefix + "/resources/navigate-none.sub.html" + attribute; - const url_2 = prefix + "/resources/navigate-require-corp.sub.html" + attribute; - - const w = window.open(url_1, "window_name"); - t.add_cleanup(() => w.close()); - assert_equals(await futureMessage(), "loaded"); - assert_equals(w.location.href, url_1); - - w.location.href = url_2; - assert_equals(await futureMessage(), "loaded"); - assert_equals(w.location.href, url_2); - - w.history.back(); - assert_equals(await futureMessage(), "loaded"); - assert_equals(w.location.href, url_1); - - t.done(); - }).catch((e) => t.unreached_func(e)); -}, `"none" top-level: navigating a frame back from "require-corp" should succeed`); - -async_test(t => { let pageLoaded = false; + // TODO(arthursonzogni): Consider switching toward another message passing + // API like: + // /html/cross-origin-embedder-policy/credentialless/resources/dispatcher.js const bc = new BroadcastChannel(token()); let finished = false; let doneCheck = _ => {
diff --git a/third_party/blink/web_tests/external/wpt/html/cross-origin-opener-policy/coop-navigate-same-origin-csp-sandbox-expected.txt b/third_party/blink/web_tests/external/wpt/html/cross-origin-opener-policy/coop-navigate-same-origin-csp-sandbox-expected.txt deleted file mode 100644 index 428a7a9..0000000 --- a/third_party/blink/web_tests/external/wpt/html/cross-origin-opener-policy/coop-navigate-same-origin-csp-sandbox-expected.txt +++ /dev/null
@@ -1,4 +0,0 @@ -This is a testharness.js-based test. -FAIL coop-navigate-same-origin-csp-sandbox assert_equals: expected "Success: no opener" but got "Error: have opener" -Harness: the test ran to completion. -
diff --git a/third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/dialog-open.html b/third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/dialog-open.html index 4719f63..e1f4c6a 100644 --- a/third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/dialog-open.html +++ b/third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/dialog-open.html
@@ -27,4 +27,17 @@ d2.open = false; assert_false(d2.hasAttribute("open")); }, "On setting, the content open attribute must be removed if the IDL open attribute is set to false, and must be present if the IDL open attribute is set to true."); + + async_test(function(t){ + d2.open = true; + assert_true(d2.hasAttribute("open")); + d2.onclose = t.unreached_func("close event should not be fired when just setting the open attribute"); + d2.open = false; + assert_false(d2.hasAttribute("open")); + + // close event is async, give it a chance to be fired + t.step_timeout(function() { + t.done(); + }, 0); + }, "On setting it to false, the close event should not be fired"); </script>
diff --git a/third_party/blink/web_tests/external/wpt/infrastructure/assumptions/non-local-ports.sub.window.js b/third_party/blink/web_tests/external/wpt/infrastructure/assumptions/non-local-ports.sub.window.js index 16855aa..8c9eb33 100644 --- a/third_party/blink/web_tests/external/wpt/infrastructure/assumptions/non-local-ports.sub.window.js +++ b/third_party/blink/web_tests/external/wpt/infrastructure/assumptions/non-local-ports.sub.window.js
@@ -8,6 +8,13 @@ // // More tests can be found in `fetch/private-network-access/`. +const alternatePorts = { + httpPrivate: "{{ports[http-private][0]}}", + httpsPrivate: "{{ports[https-private][0]}}", + httpPublic: "{{ports[http-public][0]}}", + httpsPublic: "{{ports[https-public][0]}}", +}; + // Resolves a URL relative to the current location, returning an absolute URL. // // `url` specifies the relative URL, e.g. "foo.html" or "http://foo.example". @@ -30,38 +37,75 @@ return result; } -promise_test(async () => { - const url = resolveUrl("/common/blank-with-cors.html", { +const alternateOrigins = { + httpPrivate: { + protocol: "http:", + port: alternatePorts.httpPrivate, + }, + httpsPrivate: { protocol: "https:", - port: "{{ports[https-private][0]}}" - }); + port: alternatePorts.httpsPrivate, + }, + httpPublic: { + protocol: "http:", + port: alternatePorts.httpPublic, + }, + httpsPublic: { + protocol: "https:", + port: alternatePorts.httpsPublic, + }, +}; + +promise_test(async () => { + const url = + resolveUrl("/common/blank-with-cors.html", alternateOrigins.httpsPrivate); const response = await fetch(url); assert_true(response.ok); }, "Fetch from https-private port works."); promise_test(async () => { - const url = resolveUrl("/common/blank-with-cors.html", { - protocol: "http:", - port: "{{ports[http-private][0]}}" - }); + const url = + resolveUrl("/common/blank-with-cors.html", alternateOrigins.httpPrivate); const response = await fetch(url); assert_true(response.ok); }, "Fetch from http-private port works."); promise_test(async () => { - const url = resolveUrl("/common/blank-with-cors.html", { - protocol: "https:", - port: "{{ports[https-public][0]}}" - }); + const url = + resolveUrl("/common/blank-with-cors.html", alternateOrigins.httpsPublic); const response = await fetch(url); assert_true(response.ok); }, "Fetch from https-public port works."); promise_test(async () => { - const url = resolveUrl("/common/blank-with-cors.html", { - protocol: "http:", - port: "{{ports[http-public][0]}}" - }); + const url = + resolveUrl("/common/blank-with-cors.html", alternateOrigins.httpPublic); const response = await fetch(url); assert_true(response.ok); }, "Fetch from http-public port works."); + +promise_test(async (t) => { + const futureMessage = new Promise((resolve) => { + window.addEventListener("message", resolve); + }); + + const iframe = await new Promise((resolve, reject) => { + const iframe = document.createElement("iframe"); + iframe.src = resolveUrl("resources/fetch-and-post-result.html", + alternateOrigins.httpPublic); + + iframe.onload = () => { resolve(iframe); }; + iframe.onerror = reject; + + document.body.appendChild(iframe); + t.add_cleanup(() => { + document.body.removeChild(iframe); + }); + }); + + iframe.contentWindow.postMessage( + resolveUrl("/common/blank-with-cors.html").toString(), "*"); + + const evt = await futureMessage; + assert_equals(evt.data, "failure: error = TypeError"); +}, "Fetch from http-public to local http fails.");
diff --git a/third_party/blink/web_tests/external/wpt/infrastructure/assumptions/resources/fetch-and-post-result.html b/third_party/blink/web_tests/external/wpt/infrastructure/assumptions/resources/fetch-and-post-result.html new file mode 100644 index 0000000..4df0c4c --- /dev/null +++ b/third_party/blink/web_tests/external/wpt/infrastructure/assumptions/resources/fetch-and-post-result.html
@@ -0,0 +1,12 @@ +<script> + window.addEventListener("message", function (event) { + fetch(event.data) + .then(response => { + parent.postMessage(`success: status = ${response.status}`, "*"); + }) + .catch(error => { + parent.postMessage(`failure: error = ${error.name}`, "*") + }); + }); +</script> +
diff --git a/third_party/blink/web_tests/external/wpt/referrer-policy/generic/test-case.sub.js b/third_party/blink/web_tests/external/wpt/referrer-policy/generic/test-case.sub.js index 6656084..717cd1a5 100644 --- a/third_party/blink/web_tests/external/wpt/referrer-policy/generic/test-case.sub.js +++ b/third_party/blink/web_tests/external/wpt/referrer-policy/generic/test-case.sub.js
@@ -41,14 +41,20 @@ } const referrerUrlResolver = { + // The spec allows UAs to "enforce arbitrary policy considerations in the + // interests of minimizing data leakage"; to start to vaguely approximate + // this, we allow stronger policies to be used instead of what's specificed. "omitted": function(sourceUrl) { - return undefined; + return [undefined]; }, "origin": function(sourceUrl) { - return stripUrlForUseAsReferrer(sourceUrl, true); + return [stripUrlForUseAsReferrer(sourceUrl, true), + undefined]; }, "stripped-referrer": function(sourceUrl) { - return stripUrlForUseAsReferrer(sourceUrl, false); + return [stripUrlForUseAsReferrer(sourceUrl, false), + stripUrlForUseAsReferrer(sourceUrl, true), + undefined]; } }; @@ -70,18 +76,16 @@ // external <iframe>. referrerSource = location.toString(); } - const expectedReferrerUrl = + const possibleReferrerUrls = referrerUrlResolver[expectation](referrerSource); // Check the reported URL. - assert_equals(result.referrer, - expectedReferrerUrl, - "Reported Referrer URL is '" + - expectation + "'."); - assert_equals(result.headers.referer, - expectedReferrerUrl, - "Reported Referrer URL from HTTP header is '" + - expectedReferrerUrl + "'"); + assert_in_array(result.referrer, + possibleReferrerUrls, + "document.referrer"); + assert_in_array(result.headers.referer, + possibleReferrerUrls, + "HTTP Referer header"); } function runLengthTest(scenario, urlLength, expectation, testDescription) {
diff --git a/third_party/blink/web_tests/external/wpt/selection/contenteditable/modifying-selection-with-middle-mouse-button.tentative-expected.txt b/third_party/blink/web_tests/external/wpt/selection/contenteditable/modifying-selection-with-middle-mouse-button.tentative-expected.txt index 25bd584f..f582a36 100644 --- a/third_party/blink/web_tests/external/wpt/selection/contenteditable/modifying-selection-with-middle-mouse-button.tentative-expected.txt +++ b/third_party/blink/web_tests/external/wpt/selection/contenteditable/modifying-selection-with-middle-mouse-button.tentative-expected.txt
@@ -4,6 +4,7 @@ PASS Middle click shouldn't move caret in an editable element if the default of mousedown event is prevented PASS Middle click shouldn't move caret in an editable element if the default of pointerdown event is prevented FAIL Shift + Middle click should extend the selection promise_test: Unhandled rejection with value: object "Error: we do not support keydown and keyup actions, please use test_driver.send_keys" +FAIL Shift + Middle click in a link shouldn't extend the selection promise_test: Unhandled rejection with value: object "Error: we do not support keydown and keyup actions, please use test_driver.send_keys" PASS Middle mouse button down should move caret, but middle mouse button up shouldn't move caret Harness: the test ran to completion.
diff --git a/third_party/blink/web_tests/external/wpt/selection/contenteditable/modifying-selection-with-middle-mouse-button.tentative.html b/third_party/blink/web_tests/external/wpt/selection/contenteditable/modifying-selection-with-middle-mouse-button.tentative.html index 54c3c848..a8287d9 100644 --- a/third_party/blink/web_tests/external/wpt/selection/contenteditable/modifying-selection-with-middle-mouse-button.tentative.html +++ b/third_party/blink/web_tests/external/wpt/selection/contenteditable/modifying-selection-with-middle-mouse-button.tentative.html
@@ -20,7 +20,7 @@ "use strict"; var editor = document.querySelector("div[contenteditable]"); -var span1, span2; +var span1, span2, link; var selection = getSelection(); function preventDefault(event) { @@ -30,9 +30,10 @@ function resetEditor() { editor.innerHTML = - '<span id="span1">first span.</span><br><span id="span2">second span.</span>'; + '<span id="span1">first span.</span><br><span id="span2">second span.</span><br><a id="link" href="#top">link.</a>'; span1 = document.getElementById("span1"); span2 = document.getElementById("span2"); + link = document.getElementById("link"); } promise_test(async () => { @@ -140,6 +141,26 @@ resetEditor(); editor.focus(); selection.collapse(span1.firstChild, 2); + let actions = new test_driver.Actions(); + await actions + .pointerMove(0, 0) + .pointerMove(0, 0, {origin: link}) + .keyDown("\uE008") + .pointerDown({button: actions.ButtonType.MIDDLE}) + .pointerUp({button: actions.ButtonType.MIDDLE}) + .keyUp("\uE008") + .send(); + + assert_equals(selection.focusNode, link.firstChild, + "Selection#focusNode should be in the <a href> element which was clicked by middle button"); + assert_true(selection.isCollapsed, + "Selection#isCollapsed should be true"); +}, "Shift + Middle click in a link shouldn't extend the selection"); + +promise_test(async () => { + resetEditor(); + editor.focus(); + selection.collapse(span1.firstChild, 2); editor.addEventListener("pointerdown", () => { assert_true(selection.isCollapsed, "Selection shouldn't be modified before pointerdown event");
diff --git a/third_party/blink/web_tests/external/wpt/selection/contenteditable/modifying-selection-with-primary-mouse-button.tentative-expected.txt b/third_party/blink/web_tests/external/wpt/selection/contenteditable/modifying-selection-with-primary-mouse-button.tentative-expected.txt index 032b112..73195cac 100644 --- a/third_party/blink/web_tests/external/wpt/selection/contenteditable/modifying-selection-with-primary-mouse-button.tentative-expected.txt +++ b/third_party/blink/web_tests/external/wpt/selection/contenteditable/modifying-selection-with-primary-mouse-button.tentative-expected.txt
@@ -5,6 +5,7 @@ PASS Primary click shouldn't move caret in an editable element if the default of mousedown event is prevented PASS Primary click shouldn't move caret in an editable element if the default of pointerdown event is prevented FAIL Shift + Primary click should extend the selection promise_test: Unhandled rejection with value: object "Error: we do not support keydown and keyup actions, please use test_driver.send_keys" +FAIL Shift + Primary click in a link shouldn't extend the selection promise_test: Unhandled rejection with value: object "Error: we do not support keydown and keyup actions, please use test_driver.send_keys" FAIL Primary mouse button down should move caret, and primary mouse button up should extend the selection assert_equals: Selection#anchorNode should stay in the second <span> element which mousedown occurred on expected Text node "second span." but got Text node "first span." Harness: the test ran to completion.
diff --git a/third_party/blink/web_tests/external/wpt/selection/contenteditable/modifying-selection-with-primary-mouse-button.tentative.html b/third_party/blink/web_tests/external/wpt/selection/contenteditable/modifying-selection-with-primary-mouse-button.tentative.html index 4955689..57586a60 100644 --- a/third_party/blink/web_tests/external/wpt/selection/contenteditable/modifying-selection-with-primary-mouse-button.tentative.html +++ b/third_party/blink/web_tests/external/wpt/selection/contenteditable/modifying-selection-with-primary-mouse-button.tentative.html
@@ -20,7 +20,7 @@ "use strict"; var editor = document.querySelector("div[contenteditable]"); -var span1, span2; +var span1, span2, link; var selection = getSelection(); function preventDefault(event) { @@ -30,9 +30,10 @@ function resetEditor() { editor.innerHTML = - '<span id="span1">first span.</span><br><span id="span2">second span.</span>'; + '<span id="span1">first span.</span><br><span id="span2">second span.</span><br><a id="link" href="#top">link.</a>'; span1 = document.getElementById("span1"); span2 = document.getElementById("span2"); + link = document.getElementById("link"); } promise_test(async () => { @@ -140,6 +141,26 @@ resetEditor(); editor.focus(); selection.collapse(span1.firstChild, 2); + let actions = new test_driver.Actions(); + await actions + .pointerMove(0, 0) + .pointerMove(0, 0, {origin: link}) + .keyDown("\uE008") + .pointerDown({button: actions.ButtonType.MIDDLE}) + .pointerUp({button: actions.ButtonType.MIDDLE}) + .keyUp("\uE008") + .send(); + + assert_equals(selection.focusNode, link.firstChild, + "Selection#focusNode should be in the <a href> element which was clicked by primary button"); + assert_true(selection.isCollapsed, + "Selection#isCollapsed should be true"); +}, "Shift + Primary click in a link shouldn't extend the selection"); + +promise_test(async () => { + resetEditor(); + editor.focus(); + selection.collapse(span1.firstChild, 2); editor.addEventListener("pointerdown", () => { assert_true(selection.isCollapsed, "Selection shouldn't be modified before pointerdown event");
diff --git a/third_party/blink/web_tests/external/wpt/wasm/jsapi/exception/basic.tentative.any.js b/third_party/blink/web_tests/external/wpt/wasm/jsapi/exception/basic.tentative.any.js new file mode 100644 index 0000000..9ddebae --- /dev/null +++ b/third_party/blink/web_tests/external/wpt/wasm/jsapi/exception/basic.tentative.any.js
@@ -0,0 +1,121 @@ +// META: global=window,worker,jsshell +// META: script=/wasm/jsapi/wasm-module-builder.js + +function assert_throws_wasm(fn, message) { + try { + fn(); + assert_not_reached(`expected to throw with ${message}`); + } catch (e) { + assert_true(e instanceof WebAssembly.Exception, `Error should be a WebAssembly.Exception with ${message}`); + } +} + +promise_test(async () => { + const kWasmAnyRef = 0x6f; + const kSig_v_r = makeSig([kWasmAnyRef], []); + const builder = new WasmModuleBuilder(); + const except = builder.addException(kSig_v_r); + builder.addFunction("throw_param", kSig_v_r) + .addBody([ + kExprLocalGet, 0, + kExprThrow, except, + ]) + .exportFunc(); + const buffer = builder.toBuffer(); + const {instance} = await WebAssembly.instantiate(buffer, {}); + const values = [ + undefined, + null, + true, + false, + "test", + Symbol(), + 0, + 1, + 4.2, + NaN, + Infinity, + {}, + () => {}, + ]; + for (const v of values) { + assert_throws_wasm(() => instance.exports.throw_param(v), String(v)); + } +}, "Wasm function throws argument"); + +promise_test(async () => { + const builder = new WasmModuleBuilder(); + const except = builder.addException(kSig_v_a); + builder.addFunction("throw_null", kSig_v_v) + .addBody([ + kExprRefNull, kWasmAnyFunc, + kExprThrow, except, + ]) + .exportFunc(); + const buffer = builder.toBuffer(); + const {instance} = await WebAssembly.instantiate(buffer, {}); + assert_throws_wasm(() => instance.exports.throw_null()); +}, "Wasm function throws null"); + +promise_test(async () => { + const builder = new WasmModuleBuilder(); + const except = builder.addException(kSig_v_i); + builder.addFunction("throw_int", kSig_v_v) + .addBody([ + ...wasmI32Const(7), + kExprThrow, except, + ]) + .exportFunc(); + const buffer = builder.toBuffer(); + const {instance} = await WebAssembly.instantiate(buffer, {}); + assert_throws_wasm(() => instance.exports.throw_int()); +}, "Wasm function throws integer"); + +promise_test(async () => { + const builder = new WasmModuleBuilder(); + const fnIndex = builder.addImport("module", "fn", kSig_v_v); + const except = builder.addException(kSig_v_r); + builder.addFunction("catch_exception", kSig_r_v) + .addBody([ + kExprTry, kWasmStmt, + kExprCallFunction, fnIndex, + kExprCatch, except, + kExprReturn, + kExprEnd, + kExprRefNull, kWasmAnyRef, + ]) + .exportFunc(); + + const buffer = builder.toBuffer(); + + const error = new Error(); + const fn = () => { throw error }; + const {instance} = await WebAssembly.instantiate(buffer, { + module: { fn } + }); + assert_throws_exactly(error, () => instance.exports.catch_exception()); +}, "Imported JS function throws"); + +promise_test(async () => { + const builder = new WasmModuleBuilder(); + const fnIndex = builder.addImport("module", "fn", kSig_v_v); + builder.addFunction("catch_and_rethrow", kSig_r_v) + .addBody([ + kExprTry, kWasmStmt, + kExprCallFunction, fnIndex, + kExprCatchAll, + kExprRethrow, 0x00, + kExprEnd, + kExprRefNull, kWasmAnyRef, + ]) + .exportFunc(); + + const buffer = builder.toBuffer(); + + const error = new Error(); + const fn = () => { throw error }; + const {instance} = await WebAssembly.instantiate(buffer, { + module: { fn } + }); + assert_throws_exactly(error, () => instance.exports.catch_and_rethrow()); +}, "Imported JS function throws, Wasm catches and rethrows");
diff --git a/third_party/blink/web_tests/external/wpt/wasm/jsapi/exception/basic.tentative.any.serviceworker-expected.txt b/third_party/blink/web_tests/external/wpt/wasm/jsapi/exception/basic.tentative.any.serviceworker-expected.txt new file mode 100644 index 0000000..73f209a --- /dev/null +++ b/third_party/blink/web_tests/external/wpt/wasm/jsapi/exception/basic.tentative.any.serviceworker-expected.txt
@@ -0,0 +1,8 @@ +This is a testharness.js-based test. +FAIL Wasm function throws argument promise_test: Unhandled rejection with value: object "CompileError: WebAssembly.instantiate(): invalid value type 'externref', enable with --experimental-wasm-reftypes @+13" +FAIL Wasm function throws null promise_test: Unhandled rejection with value: object "CompileError: WebAssembly.instantiate(): invalid value type 'funcref', enable with --experimental-wasm-reftypes @+13" +FAIL Wasm function throws integer assert_true: Error should be a WebAssembly.Exception with undefined expected true got false +FAIL Imported JS function throws promise_test: Unhandled rejection with value: object "CompileError: WebAssembly.instantiate(): invalid value type 'externref', enable with --experimental-wasm-reftypes @+16" +FAIL Imported JS function throws, Wasm catches and rethrows promise_test: Unhandled rejection with value: object "CompileError: WebAssembly.instantiate(): invalid value type 'externref', enable with --experimental-wasm-reftypes @+17" +Harness: the test ran to completion. +
diff --git a/third_party/blink/web_tests/external/wpt/wasm/jsapi/exception/basic.tentative.any.sharedworker-expected.txt b/third_party/blink/web_tests/external/wpt/wasm/jsapi/exception/basic.tentative.any.sharedworker-expected.txt new file mode 100644 index 0000000..73f209a --- /dev/null +++ b/third_party/blink/web_tests/external/wpt/wasm/jsapi/exception/basic.tentative.any.sharedworker-expected.txt
@@ -0,0 +1,8 @@ +This is a testharness.js-based test. +FAIL Wasm function throws argument promise_test: Unhandled rejection with value: object "CompileError: WebAssembly.instantiate(): invalid value type 'externref', enable with --experimental-wasm-reftypes @+13" +FAIL Wasm function throws null promise_test: Unhandled rejection with value: object "CompileError: WebAssembly.instantiate(): invalid value type 'funcref', enable with --experimental-wasm-reftypes @+13" +FAIL Wasm function throws integer assert_true: Error should be a WebAssembly.Exception with undefined expected true got false +FAIL Imported JS function throws promise_test: Unhandled rejection with value: object "CompileError: WebAssembly.instantiate(): invalid value type 'externref', enable with --experimental-wasm-reftypes @+16" +FAIL Imported JS function throws, Wasm catches and rethrows promise_test: Unhandled rejection with value: object "CompileError: WebAssembly.instantiate(): invalid value type 'externref', enable with --experimental-wasm-reftypes @+17" +Harness: the test ran to completion. +
diff --git a/third_party/blink/web_tests/external/wpt/wasm/jsapi/exception/basic.tentative.any.worker-expected.txt b/third_party/blink/web_tests/external/wpt/wasm/jsapi/exception/basic.tentative.any.worker-expected.txt new file mode 100644 index 0000000..73f209a --- /dev/null +++ b/third_party/blink/web_tests/external/wpt/wasm/jsapi/exception/basic.tentative.any.worker-expected.txt
@@ -0,0 +1,8 @@ +This is a testharness.js-based test. +FAIL Wasm function throws argument promise_test: Unhandled rejection with value: object "CompileError: WebAssembly.instantiate(): invalid value type 'externref', enable with --experimental-wasm-reftypes @+13" +FAIL Wasm function throws null promise_test: Unhandled rejection with value: object "CompileError: WebAssembly.instantiate(): invalid value type 'funcref', enable with --experimental-wasm-reftypes @+13" +FAIL Wasm function throws integer assert_true: Error should be a WebAssembly.Exception with undefined expected true got false +FAIL Imported JS function throws promise_test: Unhandled rejection with value: object "CompileError: WebAssembly.instantiate(): invalid value type 'externref', enable with --experimental-wasm-reftypes @+16" +FAIL Imported JS function throws, Wasm catches and rethrows promise_test: Unhandled rejection with value: object "CompileError: WebAssembly.instantiate(): invalid value type 'externref', enable with --experimental-wasm-reftypes @+17" +Harness: the test ran to completion. +
diff --git a/third_party/blink/web_tests/external/wpt/wasm/jsapi/wasm-module-builder.js b/third_party/blink/web_tests/external/wpt/wasm/jsapi/wasm-module-builder.js index 25fb1c8..7be72f8 100644 --- a/third_party/blink/web_tests/external/wpt/wasm/jsapi/wasm-module-builder.js +++ b/third_party/blink/web_tests/external/wpt/wasm/jsapi/wasm-module-builder.js
@@ -99,7 +99,6 @@ let kWasmS128 = 0x7b; let kWasmAnyRef = 0x6f; let kWasmAnyFunc = 0x70; -let kWasmExnRef = 0x68; let kExternalFunction = 0; let kExternalTable = 1; @@ -149,17 +148,14 @@ let kSig_d_d = makeSig([kWasmF64], [kWasmF64]); let kSig_r_r = makeSig([kWasmAnyRef], [kWasmAnyRef]); let kSig_a_a = makeSig([kWasmAnyFunc], [kWasmAnyFunc]); -let kSig_e_e = makeSig([kWasmExnRef], [kWasmExnRef]); let kSig_i_r = makeSig([kWasmAnyRef], [kWasmI32]); let kSig_v_r = makeSig([kWasmAnyRef], []); let kSig_v_a = makeSig([kWasmAnyFunc], []); -let kSig_v_e = makeSig([kWasmExnRef], []); let kSig_v_rr = makeSig([kWasmAnyRef, kWasmAnyRef], []); let kSig_v_aa = makeSig([kWasmAnyFunc, kWasmAnyFunc], []); let kSig_r_v = makeSig([], [kWasmAnyRef]); let kSig_a_v = makeSig([], [kWasmAnyFunc]); let kSig_a_i = makeSig([kWasmI32], [kWasmAnyFunc]); -let kSig_e_v = makeSig([], [kWasmExnRef]); function makeSig(params, results) { return {params: params, results: results}; @@ -194,6 +190,7 @@ let kExprElse = 0x05; let kExprTry = 0x06; let kExprCatch = 0x07; +let kExprCatchAll = 0x19; let kExprThrow = 0x08; let kExprRethrow = 0x09; let kExprBrOnExn = 0x0a; @@ -746,9 +743,8 @@ } addTable(type, initial_size, max_size = undefined) { - if (type != kWasmAnyRef && type != kWasmAnyFunc && type != kWasmExnRef) { - throw new Error( - 'Tables must be of type kWasmAnyRef, kWasmAnyFunc, or kWasmExnRef'); + if (type != kWasmAnyRef && type != kWasmAnyFunc) { + throw new Error('Tables must be of type kWasmAnyRef or kWasmAnyFunc'); } let table = new WasmTableBuilder(this, type, initial_size, max_size); table.index = this.tables.length + this.num_imported_tables; @@ -1029,9 +1025,6 @@ section.emit_u8(kExprRefNull); } break; - case kWasmExnRef: - section.emit_u8(kExprRefNull); - break; } } else { // Emit a global-index initializer. @@ -1173,9 +1166,6 @@ if (l.anyfunc_count > 0) { local_decls.push({count: l.anyfunc_count, type: kWasmAnyFunc}); } - if (l.except_count > 0) { - local_decls.push({count: l.except_count, type: kWasmExnRef}); - } } header.emit_u32v(local_decls.length);
diff --git a/third_party/blink/web_tests/external/wpt/web-animations/timing-model/animations/playing-an-animation.html b/third_party/blink/web_tests/external/wpt/web-animations/timing-model/animations/playing-an-animation.html index 969826d..01e036a 100644 --- a/third_party/blink/web_tests/external/wpt/web-animations/timing-model/animations/playing-an-animation.html +++ b/third_party/blink/web_tests/external/wpt/web-animations/timing-model/animations/playing-an-animation.html
@@ -151,7 +151,7 @@ await animation.ready; assert_false(animation.pending, 'animation should no longer be pending'); - assert_greater_than(animation.startTime, playTime, + assert_time_greater_than_equal(animation.startTime, playTime, 'The start time of the playing animation should be set'); }, 'Playing a canceled animation sets the start time'); @@ -169,7 +169,7 @@ await animation.ready; assert_false(animation.pending, 'Animation should no longer be pending'); - assert_greater_than(animation.startTime, playTime + 100 * MS_PER_SEC, + assert_time_greater_than_equal(animation.startTime, playTime + 100 * MS_PER_SEC, 'The start time of the playing animation should be set'); }, 'Playing a canceled animation backwards sets the start time');
diff --git a/third_party/blink/web_tests/fast/scrolling/mouse-scrolling-over-standard-scrollbar.html b/third_party/blink/web_tests/fast/scrolling/mouse-scrolling-over-standard-scrollbar.html index 2b4300f..041e1de8 100644 --- a/third_party/blink/web_tests/fast/scrolling/mouse-scrolling-over-standard-scrollbar.html +++ b/third_party/blink/web_tests/fast/scrolling/mouse-scrolling-over-standard-scrollbar.html
@@ -3,6 +3,9 @@ <script src="../../resources/testharness.js"></script> <script src="../../resources/testharnessreport.js"></script> <script src="../../resources/gesture-util.js"></script> +<script src="../../resources/scrollbar-util.js"></script> +<script src="../../resources/blink-coordinates-util.js"></script> + <style> html,body { margin: 0; @@ -57,28 +60,28 @@ const source_type = GestureSourceType.MOUSE_INPUT; const direction = 'down'; const use_precise_deltas = true; - const SCROLLBAR_WIDTH = 15; - let x = rectSlow.right - SCROLLBAR_WIDTH / 2; - let y = rectSlow.top + 30; - + let thumb = verticalThumb(divSlow); + let scrollPromise = waitForScrollEvent(divSlow); await smoothScroll(distance, - x, y, + thumb.x, thumb.y, source_type, direction, SPEED_INSTANT, use_precise_deltas); + await scrollPromise; assert_greater_than(divSlow.scrollTop, 0, "Main-thread scrolling div didn't scroll."); - x = rectFast.right - SCROLLBAR_WIDTH / 2; - y = rectFast.top + 30; + thumb = verticalThumb(divFast); + scrollPromise = waitForScrollEvent(divFast); await smoothScroll(distance, - x, y, + thumb.x, thumb.y, source_type, direction, SPEED_INSTANT, use_precise_deltas); + await scrollPromise; assert_greater_than(divFast.scrollTop, 0, "Compositor-thread scrolling div didn't scroll."); }, "Test mouse scrolling over non-custom scrollbars"); }
diff --git a/third_party/blink/web_tests/platform/linux/external/wpt/wasm/jsapi/exception/basic.tentative.any-expected.txt b/third_party/blink/web_tests/platform/linux/external/wpt/wasm/jsapi/exception/basic.tentative.any-expected.txt new file mode 100644 index 0000000..73f209a --- /dev/null +++ b/third_party/blink/web_tests/platform/linux/external/wpt/wasm/jsapi/exception/basic.tentative.any-expected.txt
@@ -0,0 +1,8 @@ +This is a testharness.js-based test. +FAIL Wasm function throws argument promise_test: Unhandled rejection with value: object "CompileError: WebAssembly.instantiate(): invalid value type 'externref', enable with --experimental-wasm-reftypes @+13" +FAIL Wasm function throws null promise_test: Unhandled rejection with value: object "CompileError: WebAssembly.instantiate(): invalid value type 'funcref', enable with --experimental-wasm-reftypes @+13" +FAIL Wasm function throws integer assert_true: Error should be a WebAssembly.Exception with undefined expected true got false +FAIL Imported JS function throws promise_test: Unhandled rejection with value: object "CompileError: WebAssembly.instantiate(): invalid value type 'externref', enable with --experimental-wasm-reftypes @+16" +FAIL Imported JS function throws, Wasm catches and rethrows promise_test: Unhandled rejection with value: object "CompileError: WebAssembly.instantiate(): invalid value type 'externref', enable with --experimental-wasm-reftypes @+17" +Harness: the test ran to completion. +
diff --git a/third_party/blink/web_tests/platform/mac-mac-arm11.0/external/wpt/selection/contenteditable/modifying-selection-with-middle-mouse-button.tentative-expected.txt b/third_party/blink/web_tests/platform/mac-mac-arm11.0/external/wpt/selection/contenteditable/modifying-selection-with-middle-mouse-button.tentative-expected.txt new file mode 100644 index 0000000..25bd584f --- /dev/null +++ b/third_party/blink/web_tests/platform/mac-mac-arm11.0/external/wpt/selection/contenteditable/modifying-selection-with-middle-mouse-button.tentative-expected.txt
@@ -0,0 +1,9 @@ +This is a testharness.js-based test. +PASS Middle click should set focus to clicked editable element and collapse selection around the clicked point +PASS Middle click should move caret in an editable element +PASS Middle click shouldn't move caret in an editable element if the default of mousedown event is prevented +PASS Middle click shouldn't move caret in an editable element if the default of pointerdown event is prevented +FAIL Shift + Middle click should extend the selection promise_test: Unhandled rejection with value: object "Error: we do not support keydown and keyup actions, please use test_driver.send_keys" +PASS Middle mouse button down should move caret, but middle mouse button up shouldn't move caret +Harness: the test ran to completion. +
diff --git a/third_party/blink/web_tests/platform/mac-mac-arm11.0/external/wpt/selection/contenteditable/modifying-selection-with-primary-mouse-button.tentative-expected.txt b/third_party/blink/web_tests/platform/mac-mac-arm11.0/external/wpt/selection/contenteditable/modifying-selection-with-primary-mouse-button.tentative-expected.txt new file mode 100644 index 0000000..032b112 --- /dev/null +++ b/third_party/blink/web_tests/platform/mac-mac-arm11.0/external/wpt/selection/contenteditable/modifying-selection-with-primary-mouse-button.tentative-expected.txt
@@ -0,0 +1,10 @@ +This is a testharness.js-based test. +Harness Error. harness_status.status = 1 , harness_status.message = Uncaught Error: assert_true: Selection should be modified before mouseup event expected true got false +PASS Primary click should set focus to clicked editable element and collapse selection around the clicked point +PASS Primary click should move caret in an editable element +PASS Primary click shouldn't move caret in an editable element if the default of mousedown event is prevented +PASS Primary click shouldn't move caret in an editable element if the default of pointerdown event is prevented +FAIL Shift + Primary click should extend the selection promise_test: Unhandled rejection with value: object "Error: we do not support keydown and keyup actions, please use test_driver.send_keys" +FAIL Primary mouse button down should move caret, and primary mouse button up should extend the selection assert_equals: Selection#anchorNode should stay in the second <span> element which mousedown occurred on expected Text node "second span." but got Text node "first span." +Harness: the test ran to completion. +
diff --git a/third_party/blink/web_tests/platform/mac/external/wpt/wasm/jsapi/exception/basic.tentative.any-expected.txt b/third_party/blink/web_tests/platform/mac/external/wpt/wasm/jsapi/exception/basic.tentative.any-expected.txt new file mode 100644 index 0000000..73f209a --- /dev/null +++ b/third_party/blink/web_tests/platform/mac/external/wpt/wasm/jsapi/exception/basic.tentative.any-expected.txt
@@ -0,0 +1,8 @@ +This is a testharness.js-based test. +FAIL Wasm function throws argument promise_test: Unhandled rejection with value: object "CompileError: WebAssembly.instantiate(): invalid value type 'externref', enable with --experimental-wasm-reftypes @+13" +FAIL Wasm function throws null promise_test: Unhandled rejection with value: object "CompileError: WebAssembly.instantiate(): invalid value type 'funcref', enable with --experimental-wasm-reftypes @+13" +FAIL Wasm function throws integer assert_true: Error should be a WebAssembly.Exception with undefined expected true got false +FAIL Imported JS function throws promise_test: Unhandled rejection with value: object "CompileError: WebAssembly.instantiate(): invalid value type 'externref', enable with --experimental-wasm-reftypes @+16" +FAIL Imported JS function throws, Wasm catches and rethrows promise_test: Unhandled rejection with value: object "CompileError: WebAssembly.instantiate(): invalid value type 'externref', enable with --experimental-wasm-reftypes @+17" +Harness: the test ran to completion. +
diff --git a/third_party/blink/web_tests/platform/win7/external/wpt/wasm/jsapi/exception/basic.tentative.any-expected.txt b/third_party/blink/web_tests/platform/win7/external/wpt/wasm/jsapi/exception/basic.tentative.any-expected.txt new file mode 100644 index 0000000..73f209a --- /dev/null +++ b/third_party/blink/web_tests/platform/win7/external/wpt/wasm/jsapi/exception/basic.tentative.any-expected.txt
@@ -0,0 +1,8 @@ +This is a testharness.js-based test. +FAIL Wasm function throws argument promise_test: Unhandled rejection with value: object "CompileError: WebAssembly.instantiate(): invalid value type 'externref', enable with --experimental-wasm-reftypes @+13" +FAIL Wasm function throws null promise_test: Unhandled rejection with value: object "CompileError: WebAssembly.instantiate(): invalid value type 'funcref', enable with --experimental-wasm-reftypes @+13" +FAIL Wasm function throws integer assert_true: Error should be a WebAssembly.Exception with undefined expected true got false +FAIL Imported JS function throws promise_test: Unhandled rejection with value: object "CompileError: WebAssembly.instantiate(): invalid value type 'externref', enable with --experimental-wasm-reftypes @+16" +FAIL Imported JS function throws, Wasm catches and rethrows promise_test: Unhandled rejection with value: object "CompileError: WebAssembly.instantiate(): invalid value type 'externref', enable with --experimental-wasm-reftypes @+17" +Harness: the test ran to completion. +
diff --git a/third_party/blink/web_tests/virtual/passive-fingerprinting/README.md b/third_party/blink/web_tests/virtual/passive-fingerprinting/README.md index 6531fac..933c0e2 100644 --- a/third_party/blink/web_tests/virtual/passive-fingerprinting/README.md +++ b/third_party/blink/web_tests/virtual/passive-fingerprinting/README.md
@@ -1,2 +1,2 @@ # This suite runs the User-Agent tests in http/tests/navigation with -# --enable-features=FreezeUserAgent. +# --enable-features=ReduceUserAgent.
diff --git a/third_party/blink/web_tests/virtual/passive-fingerprinting/http/tests/navigation/README.txt b/third_party/blink/web_tests/virtual/passive-fingerprinting/http/tests/navigation/README.txt index 6531fac..933c0e2 100644 --- a/third_party/blink/web_tests/virtual/passive-fingerprinting/http/tests/navigation/README.txt +++ b/third_party/blink/web_tests/virtual/passive-fingerprinting/http/tests/navigation/README.txt
@@ -1,2 +1,2 @@ # This suite runs the User-Agent tests in http/tests/navigation with -# --enable-features=FreezeUserAgent. +# --enable-features=ReduceUserAgent.
diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml index 8aba7cc..1e2cc50 100644 --- a/tools/metrics/histograms/enums.xml +++ b/tools/metrics/histograms/enums.xml
@@ -46200,6 +46200,7 @@ <int value="-2119530966" label="enable-webrtc-dtls12"/> <int value="-2119493239" label="enable-app-info-dialog-mac"/> <int value="-2118893353" label="WebRtcRemoteEventLog:enabled"/> + <int value="-2118062187" label="WebUIBrandingUpdate:enabled"/> <int value="-2117621241" label="ExperimentalProductivityFeatures:enabled"/> <int value="-2117201726" label="disable-gpu-rasterization"/> <int value="-2117169027" label="UpdateHoverAtBeginFrame:enabled"/> @@ -46329,6 +46330,7 @@ <int value="-2013551096" label="ViewsSimplifiedFullscreenUI:disabled"/> <int value="-2013124655" label="EnableEphemeralFlashPermission:disabled"/> <int value="-2012990889" label="SpannableInlineAutocomplete:enabled"/> + <int value="-2012779758" label="ReduceUserAgent:disabled"/> <int value="-2012449550" label="OmniboxMostVisitedTiles:enabled"/> <int value="-2012266745" label="OmniboxLocalZeroSuggestFrecencyRanking:disabled"/> @@ -48783,6 +48785,7 @@ <int value="-17698200" label="DoubleTapToZoomInTabletMode:disabled"/> <int value="-17373827" label="SharingDeviceExpiration:enabled"/> <int value="-16824589" label="ash-shelf-color"/> + <int value="-16413037" label="ReduceUserAgent:enabled"/> <int value="-16086999" label="TrimOnFreeze:enabled"/> <int value="-15879016" label="OmniboxUIExperimentUnboldSuggestionText:disabled"/> @@ -50128,6 +50131,7 @@ <int value="1106579567" label="ProfilesUIRevamp:enabled"/> <int value="1106890743" label="SafeBrowsingkRealTimeUrlLookupEnterpriseGaEndpoint:enabled"/> + <int value="1107293950" label="WebUIBrandingUpdate:disabled"/> <int value="1107543566" label="enable-one-copy"/> <int value="1108663108" label="disable-device-discovery-notifications"/> <int value="1109907837" @@ -79680,6 +79684,13 @@ <int value="3" label="User opened the Tab Search UI via touch gesture"/> </enum> +<enum name="TabSearchRecentlyClosedItemOpenAction"> + <int value="0" + label="Opened a recently closed item from an unfiltered item list"/> + <int value="1" + label="Opened a recently closed item from a filtered item list"/> +</enum> + <enum name="TabSearchTabSwitchAction"> <int value="0" label="Switch to tab from unfiltered tab list"/> <int value="1" label="Switch to tab from filtered search tab list"/>
diff --git a/tools/metrics/histograms/histograms_xml/android/histograms.xml b/tools/metrics/histograms/histograms_xml/android/histograms.xml index 28cc0759..c01692d 100644 --- a/tools/metrics/histograms/histograms_xml/android/histograms.xml +++ b/tools/metrics/histograms/histograms_xml/android/histograms.xml
@@ -3458,6 +3458,24 @@ </summary> </histogram> +<histogram name="Android.WebView.PageTimeSpent.{Scheme}" units="ms" + expires_after="2022-07-01"> + <owner>mvanouwerkerk@chromium.org</owner> + <owner>src/android_webview/OWNERS</owner> + <summary> + Time spent on a page. This is measured from navigation commit to the start + of the next navigation. + </summary> + <token key="Scheme"> + <variant name="Data"/> + <variant name="File"/> + <variant name="Http"/> + <variant name="Https"/> + <variant name="JavaScript"/> + <variant name="Other"/> + </token> +</histogram> + <histogram name="Android.WebView.PrefLoadTime" units="ms" expires_after="2020-12-01"> <obsolete>
diff --git a/tools/metrics/histograms/histograms_xml/autofill/histograms.xml b/tools/metrics/histograms/histograms_xml/autofill/histograms.xml index 462629d..4567833 100644 --- a/tools/metrics/histograms/histograms_xml/autofill/histograms.xml +++ b/tools/metrics/histograms/histograms_xml/autofill/histograms.xml
@@ -846,6 +846,18 @@ </summary> </histogram> +<histogram name="Autofill.FormCacheSize" units="forms" + expires_after="2022-05-31"> + <owner>evih@google.com</owner> + <owner>schwering@google.com</owner> + <owner>chrome-autofill-alerts@google.com</owner> + <summary> + Records the peak number of the form cache size. The peak size is reached + when navigating to a new page or when the page is refreshed. The metric is + counted once for every loaded frame. + </summary> +</histogram> + <histogram name="Autofill.FormEvents.Address" enum="AutofillFormEvent" expires_after="2021-12-12"> <owner>battre@chromium.org</owner>
diff --git a/tools/metrics/histograms/histograms_xml/chromeos/histograms.xml b/tools/metrics/histograms/histograms_xml/chromeos/histograms.xml index 6bf4a06..771b3e6 100644 --- a/tools/metrics/histograms/histograms_xml/chromeos/histograms.xml +++ b/tools/metrics/histograms/histograms_xml/chromeos/histograms.xml
@@ -44,7 +44,6 @@ </variant> <variant name="NearbyShare" summary="Nearby Share"> <owner>nohle@chromium.org</owner> - <owner>vecore@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> </variant> </variants>
diff --git a/tools/metrics/histograms/histograms_xml/cross_device/histograms.xml b/tools/metrics/histograms/histograms_xml/cross_device/histograms.xml index 744088a..ab55a50 100644 --- a/tools/metrics/histograms/histograms_xml/cross_device/histograms.xml +++ b/tools/metrics/histograms/histograms_xml/cross_device/histograms.xml
@@ -1578,7 +1578,7 @@ <histogram name="MultiDevice.BetterTogetherSuite.MultiDeviceFeatureState" enum="MultiDevice_FeatureState" expires_after="2021-12-12"> - <owner>vecore@google.com</owner> + <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> Indicates the feature state of the Better Together Suite feature. This @@ -1589,7 +1589,7 @@ <histogram name="MultiDevice.DeviceSyncService.FindEligibleDevices.Result" enum="BooleanSuccess" expires_after="2021-12-12"> - <owner>vecore@google.com</owner> + <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary>Result of trying to find eligible devices.</summary> </histogram> @@ -1598,7 +1598,7 @@ name="MultiDevice.DeviceSyncService.FindEligibleDevices.Result.FailureReason" enum="MultiDevice_DeviceSyncService_DeviceSyncRequestFailureReason" expires_after="2021-12-12"> - <owner>vecore@google.com</owner> + <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> Breaks down the percentages of reasons when failure occurs on @@ -1609,7 +1609,7 @@ <histogram name="MultiDevice.DeviceSyncService.ForceEnrollmentNow.Result" enum="MultiDevice_DeviceSyncService_ForceCryptAuthOperationResult" expires_after="2022-02-02"> - <owner>vecore@google.com</owner> + <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary>Result for when ForceEnrollmentNow is called.</summary> </histogram> @@ -1617,7 +1617,7 @@ <histogram name="MultiDevice.DeviceSyncService.ForceSyncNow.Result" enum="MultiDevice_DeviceSyncService_ForceCryptAuthOperationResult" expires_after="2021-12-26"> - <owner>vecore@google.com</owner> + <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary>Result for when ForceSyncNow is called.</summary> </histogram> @@ -1625,7 +1625,7 @@ <histogram name="MultiDevice.DeviceSyncService.SetSoftwareFeatureState.Disable.FailedFeature" enum="MultiDevice_DeviceSyncService_Features" expires_after="2021-12-12"> - <owner>vecore@google.com</owner> + <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> Breaks down which features failed when attempted to disable. @@ -1635,14 +1635,14 @@ <histogram name="MultiDevice.DeviceSyncService.SetSoftwareFeatureState.Enable.FailedFeature" enum="MultiDevice_DeviceSyncService_Features" expires_after="2021-08-09"> - <owner>vecore@google.com</owner> + <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary>Breaks down which features failed when attempted to enable.</summary> </histogram> <histogram name="MultiDevice.DeviceSyncService.SetSoftwareFeatureState.Result" enum="BooleanSuccess" expires_after="2021-11-14"> - <owner>vecore@google.com</owner> + <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary>Result of enabling and disabling features for devices.</summary> </histogram> @@ -1651,7 +1651,7 @@ name="MultiDevice.DeviceSyncService.SetSoftwareFeatureState.Result.FailureReason" enum="MultiDevice_DeviceSyncService_DeviceSyncRequestFailureReason" expires_after="2021-12-12"> - <owner>vecore@google.com</owner> + <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> Breaks down the percentages of reasons when failure occurs on @@ -1662,7 +1662,7 @@ <histogram name="MultiDevice.ForgetHostConfirmed" enum="MultiDevice_VerifyAndForgetHostConfirmationState" expires_after="2021-12-12"> - <owner>vecore@google.com</owner> + <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> Compares when the Forget Host Button is pressed and when setup completes. @@ -1671,7 +1671,7 @@ <histogram name="MultiDevice.PostOOBESetupFlow.PageShown" enum="MultiDevice_PostOOBESetupFlow_Page" expires_after="2021-12-12"> - <owner>vecore@google.com</owner> + <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> Provides a count of how many times each page of the MultiDevice setup flow @@ -1688,7 +1688,7 @@ <histogram name="MultiDevice.SecureChannel.BLE.GattConnectionToAuthentication.EffectiveSuccessRateWithRetries" enum="BooleanSuccess" expires_after="2021-12-12"> - <owner>vecore@google.com</owner> + <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> A histogram measuring the success rate of authenticating a BLE channel once @@ -1701,7 +1701,7 @@ <histogram name="MultiDevice.SecureChannel.BLE.Performance.ConnectionToAuthenticationDuration.Background" units="ms" expires_after="2021-12-26"> - <owner>vecore@google.com</owner> + <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> A time histogram measuring the time from the moment a GATT connection is @@ -1717,7 +1717,7 @@ <histogram name="MultiDevice.SecureChannel.BLE.Performance.ReceiveAdvertisementToConnectionDuration.Background" units="ms" expires_after="2021-12-12"> - <owner>vecore@google.com</owner> + <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> A time histogram measuring the time from the moment a background @@ -1733,7 +1733,7 @@ <histogram name="MultiDevice.SecureChannel.BLE.Performance.StartScanToAuthenticationDuration.Background" units="ms" expires_after="2021-12-12"> - <owner>vecore@google.com</owner> + <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> A time histogram measuring the time it takes to create a secure connection @@ -1750,7 +1750,7 @@ <histogram name="MultiDevice.SecureChannel.BLE.Performance.StartScanToConnectionDuration.Background" units="ms" expires_after="2021-12-12"> - <owner>vecore@google.com</owner> + <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> A time histogram measuring the time it from the moment SecureChannelService @@ -1766,7 +1766,7 @@ <histogram name="MultiDevice.SecureChannel.BLE.Performance.StartScanToReceiveAdvertisementDuration.Background" units="ms" expires_after="2021-12-12"> - <owner>vecore@google.com</owner> + <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> A time histogram measuring the time it from the moment SecureChannelService @@ -1782,7 +1782,7 @@ <histogram name="MultiDevice.SecureChannel.BLE.ReceiveAdvertisementToAuthentication.EffectiveSuccessRateWithRetries" enum="BooleanSuccess" expires_after="2021-12-19"> - <owner>vecore@google.com</owner> + <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> A histogram measuring the success rate of authenticating a BLE channel once @@ -1794,7 +1794,7 @@ <histogram name="MultiDevice.SecureChannel.BLE.ReceiveAdvertisementToGattConnection.EffectiveSuccessRateWithRetries" enum="BooleanSuccess" expires_after="2021-12-12"> - <owner>vecore@google.com</owner> + <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> A histogram measuring the success rate of creating a GATT connection once an @@ -1931,7 +1931,7 @@ <histogram name="MultiDevice.Setup.HostStatus" enum="MultiDevice_Setup_HostStatus" expires_after="2021-12-12"> - <owner>vecore@google.com</owner> + <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> Breaks down percentages of host statuses. This metric is emitted to at the @@ -1957,7 +1957,7 @@ <histogram name="MultiDevice.VerifyButtonClicked" enum="MultiDevice_VerifyAndForgetHostConfirmationState" expires_after="2021-12-12"> - <owner>vecore@google.com</owner> + <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> Compares when the Verify Host Button is pressed to when setup completes. @@ -1966,7 +1966,7 @@ <histogram name="MultiDeviceSetup.OOBE.UserChoice" enum="MultiDeviceSetupOOBEUserChoice" expires_after="2021-12-19"> - <owner>vecore@google.com</owner> + <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <owner>hsuregan@chromium.org</owner> <summary> @@ -1977,7 +1977,7 @@ <histogram name="MultiDeviceSetup_NotificationClicked" enum="MultiDeviceSetupNotification" expires_after="2021-12-12"> - <owner>vecore@google.com</owner> + <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> Counts the number of each MultiDevice setup notification clicked by a user. @@ -1987,7 +1987,7 @@ <histogram name="MultiDeviceSetup_NotificationDismissed" enum="MultiDeviceSetupNotification" expires_after="2021-12-12"> - <owner>vecore@google.com</owner> + <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> Counts the number of each MultiDevice setup notification dismissed by a @@ -1998,7 +1998,7 @@ <histogram name="MultiDeviceSetup_NotificationShown" enum="MultiDeviceSetupNotification" expires_after="2022-10-10"> - <owner>vecore@google.com</owner> + <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> Counts the number of each MultiDevice setup notification shown to a user.
diff --git a/tools/metrics/histograms/histograms_xml/event/histograms.xml b/tools/metrics/histograms/histograms_xml/event/histograms.xml index 53df3b2..f92d8c4f 100644 --- a/tools/metrics/histograms/histograms_xml/event/histograms.xml +++ b/tools/metrics/histograms/histograms_xml/event/histograms.xml
@@ -1069,6 +1069,16 @@ </summary> </histogram> +<histogram name="Event.Latency.ScrollUpdate.JankyDurationPercentage" units="%" + expires_after="2022-07-15"> + <owner>ddrone@google.com</owner> + <owner>chrometto-team@google.com</owner> + <summary> + Percentage of duration of scroll events that are detected as janky during a + particular scroll. + </summary> +</histogram> + <histogram name="Event.Latency.ScrollUpdate.JankyEvents" units="counts" expires_after="2022-05-20"> <owner>ddrone@google.com</owner>
diff --git a/tools/metrics/histograms/histograms_xml/hang_watcher/histograms.xml b/tools/metrics/histograms/histograms_xml/hang_watcher/histograms.xml index 8f849ff..5796fe12 100644 --- a/tools/metrics/histograms/histograms_xml/hang_watcher/histograms.xml +++ b/tools/metrics/histograms/histograms_xml/hang_watcher/histograms.xml
@@ -40,9 +40,9 @@ Every 10 seconds, a boolean is recorded to this histogram to indicate whether the {ProcessType} {ThreadType} was hung. The thread is hung if the current work unit started running more than 10 seconds ago and this was not - labeled as "working as intended" by IgnoreHangsInScope. Recording - is skipped if the hang watcher detects an irregular heartbeat (e.g. when the - machine sleeps). + labeled as "working as intended" by InvalidateActiveExpectations() + (Prior to 2021-07-09 with IgnoreHangsInScope). Recording is skipped if the + hang watcher detects an irregular heartbeat (e.g. when the machine sleeps). </summary> <token key="ProcessType" variants="ProcessType"/> <token key="ThreadType" variants="ThreadType"/>
diff --git a/tools/metrics/histograms/histograms_xml/tab/histograms.xml b/tools/metrics/histograms/histograms_xml/tab/histograms.xml index a9dc34f3..524ac7e 100644 --- a/tools/metrics/histograms/histograms_xml/tab/histograms.xml +++ b/tools/metrics/histograms/histograms_xml/tab/histograms.xml
@@ -2393,6 +2393,22 @@ </summary> </histogram> +<histogram name="Tabs.TabSearch.WebUI.RecentlyClosed{Item}OpenAction" + enum="TabSearchRecentlyClosedItemOpenAction" expires_after="2021-11-21"> + <owner>tluk@chromium.org</owner> + <owner>chrome-cros@chromium.org</owner> + <summary> + Tab Search is a feature that allows users to better search their browsers + for their desired tabs or recently closed tabs and tab groups. This records + whether the user used Tab Search to open a recently closed {Item} from a + filtered search results list or the default unfiltered list. + </summary> + <token key="Item"> + <variant name="Group"/> + <variant name="Tab"/> + </token> +</histogram> + <histogram name="Tabs.TabSearch.WebUI.TabListDataReceived" units="ms" expires_after="2021-11-21"> <owner>tluk@chromium.org</owner>
diff --git a/tools/perf/benchmarks/v8_helper.py b/tools/perf/benchmarks/v8_helper.py index be24190d..ab16780a 100644 --- a/tools/perf/benchmarks/v8_helper.py +++ b/tools/perf/benchmarks/v8_helper.py
@@ -2,10 +2,27 @@ # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. +from devil.android import device_errors # pylint: disable=import-error +from devil.android import device_utils # pylint: disable=import-error from telemetry.web_perf import timeline_based_measurement from telemetry.timeline import chrome_trace_config _JS_FLAGS_SWITCH = '--js-flags=' +LOW_END_DEVICE_MEMORY_KB = 1024 * 1024 # 1 GB + + +def GetDeviceTotalMemory(): + devices = device_utils.DeviceUtils.HealthyDevices() + if not devices: + return None + try: + mem_info = devices[0].ReadFile('/proc/meminfo') + except device_errors.AdbShellCommandFailedError: + return None + for line in mem_info.splitlines(): + if line.startswith('MemTotal:'): + return int(line.split()[1]) + def AppendJSFlags(options, js_flags): existing_js_flags = '' @@ -58,7 +75,13 @@ memory_dump_config.AddTrigger('light', 1000) options.config.chrome_trace_config.SetMemoryDumpConfig(memory_dump_config) - options.config.chrome_trace_config.SetTraceBufferSizeInKb(400 * 1024) + # On low-end devices there's not enough memory to hold 400Mb buffer (See + # crbug.com/1218139). + device_memory = GetDeviceTotalMemory() + if device_memory and device_memory < LOW_END_DEVICE_MEMORY_KB: + options.config.chrome_trace_config.SetTraceBufferSizeInKb(200 * 1024) + else: + options.config.chrome_trace_config.SetTraceBufferSizeInKb(400 * 1024) metrics = [ 'blinkGcMetric',
diff --git a/tools/perf/core/perfetto_binary_roller/binary_deps.json b/tools/perf/core/perfetto_binary_roller/binary_deps.json index 7a70db2a..d9a486844 100644 --- a/tools/perf/core/perfetto_binary_roller/binary_deps.json +++ b/tools/perf/core/perfetto_binary_roller/binary_deps.json
@@ -1,8 +1,8 @@ { "trace_processor_shell": { "win": { - "hash": "06a5bd2018a5bad484645882bbc49324f1de42c0", - "remote_path": "perfetto_binaries/trace_processor_shell/win/97facadd961825cf2b6eb12398e0908a102d0c4a/trace_processor_shell.exe" + "hash": "c799503fd6934940a155f4fadd01f045d75fbaca", + "remote_path": "perfetto_binaries/trace_processor_shell/win/bbc615953ec6e431f158546c282b4f8b857937b8/trace_processor_shell.exe" }, "mac": { "hash": "a62641d093e3c5b3831792002c1115e1091873f4",
diff --git a/tools/perf/expectations.config b/tools/perf/expectations.config index 9c51a68e..fe994150 100644 --- a/tools/perf/expectations.config +++ b/tools/perf/expectations.config
@@ -216,6 +216,7 @@ crbug.com/1211795 [ mac ] rendering.desktop/skelebuddies_wasm_2020 [ Skip ] crbug.com/1211795 [ mac ] rendering.desktop/skelebuddies_wasm_2020_fast_call [ Skip ] crbug.com/1226854 [ mac ] rendering.desktop/text_scrollbar_* [ Skip ] +crbug.com/1229671 [ win ] rendering.desktop/espn_2018 [ Skip ] # Benchmark: rendering.mobile crbug.com/785485 [ android-webview ] rendering.mobile/kevs_3d [ Skip ]
diff --git a/tools/tracing/metadata_extractor.py b/tools/tracing/metadata_extractor.py index 7aeb84a..1af153d0 100644 --- a/tools/tracing/metadata_extractor.py +++ b/tools/tracing/metadata_extractor.py
@@ -140,6 +140,26 @@ else: raise Exception('OS name %s not recognized.' % (raw_os_name)) + def InitializeForTesting(self, + version_number=None, + os_name=None, + architecture=None, + bitness=None, + version_code=None, + modules=None): + """Sets class parameter values for test cases. + + The |trace_processor_path| and |trace_file| parameters should + be specified in the constructor. + """ + self._initialized = True + self.version_number = version_number + self.os_name = os_name + self.architecture = architecture + self.bitness = bitness + self.version_code = version_code + self.modules = modules + def _GetStringValueFromQuery(self, sql): """Runs SQL query on trace processor and returns 'str_value' result. """
diff --git a/tools/tracing/symbol_fetcher.py b/tools/tracing/symbol_fetcher.py new file mode 100644 index 0000000..feebf6c --- /dev/null +++ b/tools/tracing/symbol_fetcher.py
@@ -0,0 +1,144 @@ +# Copyright 2021 The Chromium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. +""" +Extracts breakpad symbol file from Google Cloud Platform. +""" + +import os +import sys +import logging + +import py_utils.cloud_storage as cloud_storage +import metadata_extractor +from metadata_extractor import OSName + + +def GetTraceBreakpadSymbols(cloud_storage_bucket, metadata, + breakpad_output_dir): + """Fetch trace symbols from GCS and convert to breakpad format, if needed. + + Args: + cloud_storage_bucket: bucket in cloud storage where symbols reside. + metadata: MetadataExtractor class that contains necessary + trace file metadata for fetching its symbol file. + breakpad_output_dir: local path to store trace symbol breakpad file. + + Raises: + Exception: if failed to extract trace OS name or version number, or + they are not supported or recognized. + """ + # TODO(rhuckleberry): Cache symbols so we do not have to download symbols + # from GCS for every trace. + + metadata.Initialize() + if metadata.os_name is None: + raise Exception('Failed to extract trace OS name.') + if metadata.version_number is None: + raise Exception('Failed to extract trace version number.') + + # Extract symbols by platform. + if metadata.os_name == OSName.ANDROID: + _FetchAndroidSymbols(cloud_storage_bucket, metadata, breakpad_output_dir) + elif metadata.os_name == OSName.WINDOWS: + _FetchWindowsSymbols(cloud_storage_bucket, metadata, breakpad_output_dir) + elif metadata.os_name == OSName.LINUX or metadata.os_name == OSName.MAC: + _FetchBreakpadSymbols(cloud_storage_bucket, metadata, breakpad_output_dir) + else: + raise Exception('Trace OS is not supported: ' + metadata.os_name) + + logging.info('Breakpad symbols located at: ' + + os.path.abspath(breakpad_output_dir)) + + +def _FetchAndroidSymbols(cloud_storage_bucket, metadata, breakpad_output_dir): + """Fetch and extract Android symbolization file. + """ + # TODO(rhuckleberry): Implement android fetching. + raise Exception('Android platform is not currently supported.') + + +def _FetchBreakpadSymbols(cloud_storage_bucket, metadata, breakpad_output_dir): + """Fetch and extract Mac or Linux breakpad format symbolization file. + + Args: + cloud_storage_bucket: bucket in cloud storage where symbols reside. + metadata: MetadataExtractor class that contains necessary + trace file metadata for fetching its symbol file. + breakpad_output_dir: local path to store trace symbol breakpad file. + + Raises: + Exception: if trace OS is not mac or linux, or failed to extract + version number. + ValueError: if linux trace is of 32 bit bitness. + """ + # Determine GCS folder. + if metadata.os_name == OSName.LINUX: + if metadata.bitness == '32': + raise ValueError('32 bit Linux traces are not supported.') + folder = 'linux64' + elif metadata.os_name == OSName.MAC: + if (metadata.architecture is + not None) and 'arm' in metadata.architecture.lower(): + folder = 'mac-arm64' + else: + if metadata.architecture is None: + logging.warning('Architecture not found, so using x86-64.') + folder = 'mac64' + else: + raise Exception('Expected OS to be Linux or Mac: ' + metadata.os_name) + + # Build Google Cloud Storage path to the symbols. + gsc_folder = 'desktop-*/' + metadata.version_number + '/' + folder + gcs_file = gsc_folder + '/breakpad-info' + gcs_zip_file = gcs_file + '.zip' + + # Local path to downloaded symbols. + breakpad_zip_file = breakpad_output_dir + '/breakpad-info.zip' + + # Fetch symbol files from GCS. + # Some version, like mac, don't have the .zip extension on GCS. + if not _FetchGCSFile(cloud_storage_bucket, gcs_zip_file, breakpad_zip_file): + if not _FetchGCSFile(cloud_storage_bucket, gcs_file, breakpad_zip_file): + raise Exception('Failed to find symbols on GCS: ' + gcs_file + '[.zip]') + + _UnzipAndRenameBreakpadFiles(breakpad_zip_file, breakpad_output_dir) + + +def _FetchWindowsSymbols(cloud_storage_bucket, metadata, breakpad_output_dir): + """Fetch and extract Windows symbolization file. + """ + # TODO(rhuckleberry): Implement windows fetching. + raise Exception('Windows platform is not currently supported.') + + +def _FetchGCSFile(cloud_storage_bucket, gcs_file, output_file): + """Fetch and save file from GCS to |output_file|. + + Args: + cloud_storage_bucket: bucket in cloud storage where symbols reside. + gcs_file: path to file in GCS. + output_file: local file to store fetched GCS file. + + Returns: + True if successfully fetches file; False, otherwise. + """ + if cloud_storage.Exists(cloud_storage_bucket, gcs_file): + logging.info('Downloading files from GCS: ' + gcs_file) + cloud_storage.Get(cloud_storage_bucket, gcs_file, output_file) + logging.info('Saved file locally to: ' + output_file) + return True + return False + + +def _UnzipAndRenameBreakpadFiles(breakpad_zip_file, breakpad_output_dir): + """Unzips and renames breakpad files. + + Args: + breakpad_zip_file: local symbol zip file. + breakpad_output_dir: local path to store trace symbol breakpad file. + """ + # TODO(rhuckleberry): Unzip breakpad file. + + # TODO(rhuckleberry): Rename breakpad files. + pass
diff --git a/tools/tracing/symbol_fetcher_unittests.py b/tools/tracing/symbol_fetcher_unittests.py new file mode 100644 index 0000000..2aecaabf4e --- /dev/null +++ b/tools/tracing/symbol_fetcher_unittests.py
@@ -0,0 +1,214 @@ +# Copyright 2021 The Chromium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. + +import os +import sys +import unittest + +sys.path.insert(0, os.path.join(os.path.dirname(__file__), os.pardir, 'perf')) + +from core import path_util +path_util.AddPyUtilsToPath() +path_util.AddTracingToPath() + +import py_utils.cloud_storage as cloud_storage +import metadata_extractor +from metadata_extractor import OSName +import symbol_fetcher +import mock + + +class SymbolFetcherTestCase(unittest.TestCase): + def setUp(self): + self.trace_processor_path = 'trace_processor_shell' + self.trace_file = 'trace_file.proto' + self.cloud_storage_bucket = 'chrome-unsigned' + self.breakpad_output_dir = 'breakpad-output-dir' + self.breakpad_zip_file = self.breakpad_output_dir + '/breakpad-info.zip' + cloud_storage.Exists = mock.Mock() + cloud_storage.Get = mock.Mock() + + # Default: Cloud storage has |gcs_file| + .zip extension. + # We use |side_effect| because tests that overwrite this + # will need to use |side_effect|. + cloud_storage.Exists.side_effect = [True] + + def tearDown(self): + cloud_storage.Exists.reset_mock() + cloud_storage.Get.reset_mock() + + def _createMetadataExtractor(self, + version_number=None, + os_name=None, + architecture=None, + bitness=None, + version_code=None, + modules=None): + metadata = metadata_extractor.MetadataExtractor(self.trace_processor_path, + self.trace_file) + metadata.InitializeForTesting(version_number, os_name, architecture, + bitness, version_code, modules) + return metadata + + def testSymbolFetcherLinux(self): + metadata = self._createMetadataExtractor(version_number='123', + os_name=OSName.LINUX, + architecture='x86_64', + bitness='64') + + symbol_fetcher.GetTraceBreakpadSymbols(self.cloud_storage_bucket, metadata, + self.breakpad_output_dir) + + cloud_storage.Get.assert_called_once_with( + self.cloud_storage_bucket, 'desktop-*/123/linux64/breakpad-info.zip', + self.breakpad_zip_file) + cloud_storage.Exists.assert_called_once() + + def testSymbolFetcherMacArm(self): + metadata = self._createMetadataExtractor(version_number='123', + os_name=OSName.MAC, + architecture='armv7l', + bitness='64') + + symbol_fetcher.GetTraceBreakpadSymbols(self.cloud_storage_bucket, metadata, + self.breakpad_output_dir) + + cloud_storage.Get.assert_called_once_with( + self.cloud_storage_bucket, 'desktop-*/123/mac-arm64/breakpad-info.zip', + self.breakpad_zip_file) + cloud_storage.Exists.assert_called_once() + + def testSymbolFetcherMac86(self): + metadata = self._createMetadataExtractor(version_number='123', + os_name=OSName.MAC, + architecture='x86_64', + bitness='64') + + symbol_fetcher.GetTraceBreakpadSymbols(self.cloud_storage_bucket, metadata, + self.breakpad_output_dir) + + cloud_storage.Get.assert_called_once_with( + self.cloud_storage_bucket, 'desktop-*/123/mac64/breakpad-info.zip', + self.breakpad_zip_file) + cloud_storage.Exists.assert_called_once() + + def testSymbolFetcherMacNoArchitecture(self): + metadata = self._createMetadataExtractor(version_number='123', + os_name=OSName.MAC, + architecture=None, + bitness='64') + + symbol_fetcher.GetTraceBreakpadSymbols(self.cloud_storage_bucket, metadata, + self.breakpad_output_dir) + + cloud_storage.Get.assert_called_once_with( + self.cloud_storage_bucket, 'desktop-*/123/mac64/breakpad-info.zip', + self.breakpad_zip_file) + cloud_storage.Exists.assert_called_once() + + def testSymbolFetcherMacNotZip(self): + metadata = self._createMetadataExtractor(version_number='123', + os_name=OSName.MAC, + architecture='x86_64', + bitness='64') + # Cloud storage has |gcs_file| without a .zip extension. + cloud_storage.Exists.side_effect = [False, True] + + symbol_fetcher.GetTraceBreakpadSymbols(self.cloud_storage_bucket, metadata, + self.breakpad_output_dir) + + cloud_storage.Get.assert_called_once_with( + self.cloud_storage_bucket, 'desktop-*/123/mac64/breakpad-info', + self.breakpad_zip_file) + # |cloud_storage.Exists| called with |gcs_file| with .zip extension, + # and with |gcs_file| without the .zip extension. + self.assertEqual(cloud_storage.Exists.call_count, 2) + + def testSymbolLinuxFetchFailure(self): + metadata = self._createMetadataExtractor(version_number='123', + os_name=OSName.LINUX, + architecture='x86_64', + bitness='64') + # Cloud storage does not have |gcs_file| or |gcs_file| with .zip extension. + cloud_storage.Exists.side_effect = [False, False] + + with self.assertRaisesRegex( + Exception, ('Failed to find symbols on GCS: desktop-\*/123/linux64/' + 'breakpad-info\[.zip\]')): + symbol_fetcher.GetTraceBreakpadSymbols(self.cloud_storage_bucket, + metadata, self.breakpad_output_dir) + self.assertEqual(cloud_storage.Exists.call_count, 2) + cloud_storage.Get.assert_not_called() + + def testSymbolFetcherNoOSName(self): + metadata = self._createMetadataExtractor(version_number='123', + os_name=None, + architecture='x86_64', + bitness='64') + + with self.assertRaisesRegex(Exception, 'Failed to extract trace OS name.'): + symbol_fetcher.GetTraceBreakpadSymbols(self.cloud_storage_bucket, + metadata, self.breakpad_output_dir) + + cloud_storage.Exists.assert_not_called() + cloud_storage.Get.assert_not_called() + + def testSymbolFetcherOSNameNotRecognized(self): + metadata = self._createMetadataExtractor(version_number='123', + os_name='blah', + architecture='x86_64', + bitness='64') + + with self.assertRaisesRegex(Exception, 'Trace OS is not supported: blah'): + symbol_fetcher.GetTraceBreakpadSymbols(self.cloud_storage_bucket, + metadata, self.breakpad_output_dir) + + cloud_storage.Exists.assert_not_called() + cloud_storage.Get.assert_not_called() + + def testSymbolFetcherLinux32Bit(self): + metadata = self._createMetadataExtractor(version_number='123', + os_name=OSName.LINUX, + architecture='x86_64', + bitness='32') + + with self.assertRaisesRegex(ValueError, + '32 bit Linux traces are not supported.'): + symbol_fetcher.GetTraceBreakpadSymbols(self.cloud_storage_bucket, + metadata, self.breakpad_output_dir) + + cloud_storage.Exists.assert_not_called() + cloud_storage.Get.assert_not_called() + + def testSymbolFetcherNoVersionNumber(self): + metadata = self._createMetadataExtractor(version_number=None, + os_name=OSName.LINUX, + architecture='x86_64', + bitness='64') + + with self.assertRaisesRegex(Exception, + 'Failed to extract trace version number.'): + symbol_fetcher.GetTraceBreakpadSymbols(self.cloud_storage_bucket, + metadata, self.breakpad_output_dir) + + cloud_storage.Exists.assert_not_called() + cloud_storage.Get.assert_not_called() + + def testFetchBreakpadSymbolsWrongOS(self): + metadata = self._createMetadataExtractor(version_number='123', + os_name=OSName.ANDROID, + architecture='x86_64', + bitness='64') + + with self.assertRaisesRegex(Exception, + 'Expected OS to be Linux or Mac: Android'): + symbol_fetcher._FetchBreakpadSymbols(self.cloud_storage_bucket, metadata, + self.breakpad_output_dir) + + cloud_storage.Exists.assert_not_called() + cloud_storage.Get.assert_not_called() + + +if __name__ == '__main__': + unittest.main()
diff --git a/tools/tracing/symbolize_trace b/tools/tracing/symbolize_trace index 94efd5fe..ea95061b 100755 --- a/tools/tracing/symbolize_trace +++ b/tools/tracing/symbolize_trace
@@ -8,6 +8,7 @@ """ import optparse +import logging import sys import symbolize_flags @@ -21,6 +22,9 @@ prog='tools/tracing/symbolize_trace', conflict_handler='resolve') + parser.add_option('-v', '--verbose', help='Increase output verbosity.', + action='count', dest='verbosity') + parser = symbolize_flags.AddSymbolizeOptions(parser) return parser @@ -29,6 +33,14 @@ parser = _CreateOptionParser() options, args = parser.parse_args() + # Setup Logging. + if options.verbosity == 0: + logging.basicConfig(level=logging.WARNING) + elif options.verbosity == 1: + logging.basicConfig(level=logging.INFO) + elif options.verbosity >= 2: + logging.basicConfig(level=logging.DEBUG) + # Argument error checking trace_file = None if not args:
diff --git a/tools/tracing/symbolize_trace.py b/tools/tracing/symbolize_trace.py index 6fb7ad5..3df3b769 100644 --- a/tools/tracing/symbolize_trace.py +++ b/tools/tracing/symbolize_trace.py
@@ -9,6 +9,7 @@ import sys import shutil import tempfile +import logging sys.path.insert( 0, @@ -17,6 +18,7 @@ from systrace import util import metadata_extractor +import symbol_fetcher def SymbolizeTrace(trace_file, @@ -43,24 +45,32 @@ # Temp dir must be cleaned up later. breakpad_output_dir = tempfile.mkdtemp() need_cleanup = True + logging.debug('Created temporary directory to hold symbol files.') else: if not os.path.isdir(breakpad_output_dir): os.makedirs(breakpad_output_dir) + logging.debug('Created directory to hold symbol files.') else: # Assert breakpad_output_dir is empty if os.listdir(breakpad_output_dir): - raise Exception('breakpad_output_dir is not empty.') + raise Exception('Breakpad output directory is not empty: ' + + breakpad_output_dir) # Extract Metadata - print('Extracting proto trace metadata, please wait.') + logging.info('Extracting proto trace metadata.') trace_metadata = metadata_extractor.MetadataExtractor(trace_processor_path, trace_file) trace_metadata.Initialize() + logging.info(trace_metadata) - # TODO(rhuckleberry): Fetch trace breakpad symbols from GCS. + # Fetch trace breakpad symbols from GCS + logging.info('Fetching and extracting trace breakpad symbols.') + symbol_fetcher.GetTraceBreakpadSymbols(cloud_storage_bucket, trace_metadata, + breakpad_output_dir) # TODO(rhuckleberry): use Perfetto's traceconv to symbolize. # Cleanup if need_cleanup: + logging.debug('Cleaning up symbol files.') shutil.rmtree(breakpad_output_dir)
diff --git a/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm b/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm index fc05082..3b362e1 100644 --- a/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm +++ b/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm
@@ -149,7 +149,8 @@ // haven't been able to find a way. gfx::HDRMetadata hdr_metadata; if (IOSurfaceGetHDRMetadata(io_surface, hdr_metadata)) { - if (!(hdr_metadata.mastering_metadata == gfx::MasteringMetadata())) { + if (!(hdr_metadata.color_volume_metadata == + gfx::ColorVolumeMetadata())) { CVBufferSetAttachment( cv_pixel_buffer, kCVImageBufferMasteringDisplayColorVolumeKey, media::GenerateMasteringDisplayColorVolume(hdr_metadata),
diff --git a/ui/gfx/BUILD.gn b/ui/gfx/BUILD.gn index f3f4d91..f026507 100644 --- a/ui/gfx/BUILD.gn +++ b/ui/gfx/BUILD.gn
@@ -763,6 +763,9 @@ "ios/uikit_util_unittest.mm", ] } + if (is_android) { + sources += [ "android/android_surface_control_compat_unittest.cc" ] + } include_dirs = [ "//third_party/skia/include/private" ]
diff --git a/ui/gfx/android/android_surface_control_compat.cc b/ui/gfx/android/android_surface_control_compat.cc index 6f0a99b8..092fa66a3 100644 --- a/ui/gfx/android/android_surface_control_compat.cc +++ b/ui/gfx/android/android_surface_control_compat.cc
@@ -143,12 +143,66 @@ struct SurfaceControlMethods { public: - static const SurfaceControlMethods& Get() { - static const SurfaceControlMethods instance; + static SurfaceControlMethods& GetImpl(bool load_functions) { + static SurfaceControlMethods instance(load_functions); return instance; } - SurfaceControlMethods() { + static const SurfaceControlMethods& Get() { + return GetImpl(/*load_functions=*/true); + } + + void InitWithStubs() { + struct TransactionStub { + ASurfaceTransaction_OnComplete on_complete = nullptr; + void* on_complete_ctx = nullptr; + ASurfaceTransaction_OnCommit on_commit = nullptr; + void* on_commit_ctx = nullptr; + }; + + ASurfaceTransaction_createFn = []() { + return reinterpret_cast<ASurfaceTransaction*>(new TransactionStub); + }; + ASurfaceTransaction_deleteFn = [](ASurfaceTransaction* transaction) { + delete reinterpret_cast<TransactionStub*>(transaction); + }; + ASurfaceTransaction_applyFn = [](ASurfaceTransaction* transaction) { + auto* stub = reinterpret_cast<TransactionStub*>(transaction); + + if (stub->on_commit) + stub->on_commit(stub->on_commit_ctx, nullptr); + stub->on_commit = nullptr; + stub->on_commit_ctx = nullptr; + + if (stub->on_complete) + stub->on_complete(stub->on_complete_ctx, nullptr); + stub->on_complete = nullptr; + stub->on_complete_ctx = nullptr; + + return static_cast<int64_t>(0); + }; + + ASurfaceTransaction_setOnCompleteFn = + [](ASurfaceTransaction* transaction, void* ctx, + ASurfaceTransaction_OnComplete callback) { + auto* stub = reinterpret_cast<TransactionStub*>(transaction); + stub->on_complete = callback; + stub->on_complete_ctx = ctx; + }; + + ASurfaceTransaction_setOnCommitFn = + [](ASurfaceTransaction* transaction, void* ctx, + ASurfaceTransaction_OnCommit callback) { + auto* stub = reinterpret_cast<TransactionStub*>(transaction); + stub->on_commit = callback; + stub->on_commit_ctx = ctx; + }; + } + + SurfaceControlMethods(bool load_functions) { + if (!load_functions) + return; + void* main_dl_handle = dlopen("libandroid.so", RTLD_NOW); if (!main_dl_handle) { LOG(ERROR) << "Couldnt load android so"; @@ -275,6 +329,11 @@ SurfaceControl::TransactionStats ToTransactionStats( ASurfaceTransactionStats* stats) { SurfaceControl::TransactionStats transaction_stats; + + // In unit tests we don't have stats. + if (!stats) + return transaction_stats; + transaction_stats.present_fence = base::ScopedFD( SurfaceControlMethods::Get().ASurfaceTransactionStats_getPresentFenceFdFn( stats)); @@ -391,6 +450,10 @@ nullptr; } +void SurfaceControl::SetStubImplementationForTesting() { + SurfaceControlMethods::GetImpl(/*load_functions=*/false).InitWithStubs(); +} + void SurfaceControl::ApplyTransaction(ASurfaceTransaction* transaction) { SurfaceControlMethods::Get().ASurfaceTransaction_applyFn(transaction); }
diff --git a/ui/gfx/android/android_surface_control_compat.h b/ui/gfx/android/android_surface_control_compat.h index 3d74956..bac53be 100644 --- a/ui/gfx/android/android_surface_control_compat.h +++ b/ui/gfx/android/android_surface_control_compat.h
@@ -56,6 +56,8 @@ // Transaction class below instead. static void ApplyTransaction(ASurfaceTransaction* transaction); + static void SetStubImplementationForTesting(); + class GFX_EXPORT Surface : public base::RefCounted<Surface> { public: // Wraps ASurfaceControl, but doesn't transfer ownership. Will not release
diff --git a/ui/gfx/android/android_surface_control_compat_unittest.cc b/ui/gfx/android/android_surface_control_compat_unittest.cc new file mode 100644 index 0000000..fd7d1819 --- /dev/null +++ b/ui/gfx/android/android_surface_control_compat_unittest.cc
@@ -0,0 +1,163 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "ui/gfx/android/android_surface_control_compat.h" + +#include "base/callback.h" +#include "base/run_loop.h" +#include "base/test/task_environment.h" +#include "base/threading/thread_task_runner_handle.h" +#include "testing/gtest/include/gtest/gtest.h" + +namespace gfx { +namespace { + +class SurfaceControlTransactionTest : public testing::Test { + public: + SurfaceControlTransactionTest() { + gfx::SurfaceControl::SetStubImplementationForTesting(); + } + + protected: + struct CallbackContext { + CallbackContext(bool* called, bool* destroyed) + : called(called), destroyed(destroyed) {} + ~CallbackContext() { *destroyed = true; } + bool* called; + bool* destroyed; + }; + + SurfaceControl::Transaction::OnCompleteCb CreateOnCompleteCb( + bool* called, + bool* destroyed) { + return base::BindOnce( + [](std::unique_ptr<CallbackContext> context, + SurfaceControl::TransactionStats stats) { + DCHECK(!*context->called); + *context->called = true; + }, + std::make_unique<CallbackContext>(called, destroyed)); + } + + SurfaceControl::Transaction::OnCommitCb CreateOnCommitCb(bool* called, + bool* destroyed) { + return base::BindOnce( + [](std::unique_ptr<CallbackContext> context) { + DCHECK(!*context->called); + *context->called = true; + }, + std::make_unique<CallbackContext>(called, destroyed)); + } + + void RunRemainingTasks() { + base::RunLoop runloop; + base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, + runloop.QuitClosure()); + runloop.Run(); + } + + base::test::SingleThreadTaskEnvironment task_environment; +}; + +TEST_F(SurfaceControlTransactionTest, CallbackCalledAfterApply) { + bool on_complete_called = false; + bool on_commit_called = false; + bool on_commit_destroyed = false; + bool on_complete_destroyed = false; + + gfx::SurfaceControl::Transaction transaction; + transaction.SetOnCompleteCb( + CreateOnCompleteCb(&on_complete_called, &on_complete_destroyed), + base::ThreadTaskRunnerHandle::Get()); + transaction.SetOnCommitCb( + CreateOnCommitCb(&on_commit_called, &on_commit_destroyed), + base::ThreadTaskRunnerHandle::Get()); + + // Nothing should have been called yet. + EXPECT_FALSE(on_complete_called); + EXPECT_FALSE(on_commit_called); + + transaction.Apply(); + RunRemainingTasks(); + + // After apply callbacks should be called. + EXPECT_TRUE(on_complete_called); + EXPECT_TRUE(on_commit_called); + + // As this is Once callback naturally it's context should have been destroyed. + EXPECT_TRUE(on_complete_destroyed); + EXPECT_TRUE(on_commit_destroyed); +} + +TEST_F(SurfaceControlTransactionTest, CallbackDestroyedWithoutApply) { + bool on_complete_called = false; + bool on_commit_called = false; + bool on_commit_destroyed = false; + bool on_complete_destroyed = false; + + { + SurfaceControl::Transaction transaction; + transaction.SetOnCompleteCb( + CreateOnCompleteCb(&on_complete_called, &on_complete_destroyed), + base::ThreadTaskRunnerHandle::Get()); + transaction.SetOnCommitCb( + CreateOnCommitCb(&on_commit_called, &on_commit_destroyed), + base::ThreadTaskRunnerHandle::Get()); + + // Nothing should have been called yet. + EXPECT_FALSE(on_complete_called); + EXPECT_FALSE(on_commit_called); + } + + RunRemainingTasks(); + + // Apply wasn't called, but transaction left the scope, so the callback + // contexts should have been destroyed. + EXPECT_TRUE(on_complete_destroyed); + EXPECT_TRUE(on_commit_destroyed); +} + +TEST_F(SurfaceControlTransactionTest, CallbackSetupAfterGetTransaction) { + bool on_complete_called = false; + bool on_commit_called = false; + bool on_commit_destroyed = false; + bool on_complete_destroyed = false; + + gfx::SurfaceControl::Transaction transaction; + transaction.SetOnCompleteCb( + CreateOnCompleteCb(&on_complete_called, &on_complete_destroyed), + base::ThreadTaskRunnerHandle::Get()); + transaction.SetOnCommitCb( + CreateOnCommitCb(&on_commit_called, &on_commit_destroyed), + base::ThreadTaskRunnerHandle::Get()); + + // Nothing should have been called yet. + EXPECT_FALSE(on_complete_called); + EXPECT_FALSE(on_commit_called); + + auto* asurfacetransaction = transaction.GetTransaction(); + + // Should be no task to run, but calling this to make sure nothing is + // scheduled that can call callbacks. + RunRemainingTasks(); + + // And not yet. + EXPECT_FALSE(on_complete_called); + EXPECT_FALSE(on_commit_called); + + // This is usually called by framework. + SurfaceControl::ApplyTransaction(asurfacetransaction); + RunRemainingTasks(); + + // After apply callbacks should be called. + EXPECT_TRUE(on_complete_called); + EXPECT_TRUE(on_commit_called); + + // As this is Once callback naturally it's context should have been destroyed. + EXPECT_TRUE(on_complete_destroyed); + EXPECT_TRUE(on_commit_destroyed); +} + +} // namespace +} // namespace gfx
diff --git a/ui/gfx/hdr_metadata.cc b/ui/gfx/hdr_metadata.cc index 07a6aca..ed20c0f 100644 --- a/ui/gfx/hdr_metadata.cc +++ b/ui/gfx/hdr_metadata.cc
@@ -6,10 +6,11 @@ namespace gfx { -MasteringMetadata::MasteringMetadata() = default; -MasteringMetadata::MasteringMetadata(const MasteringMetadata& rhs) = default; -MasteringMetadata& MasteringMetadata::operator=(const MasteringMetadata& rhs) = +ColorVolumeMetadata::ColorVolumeMetadata() = default; +ColorVolumeMetadata::ColorVolumeMetadata(const ColorVolumeMetadata& rhs) = default; +ColorVolumeMetadata& ColorVolumeMetadata::operator=( + const ColorVolumeMetadata& rhs) = default; HDRMetadata::HDRMetadata() = default; HDRMetadata::HDRMetadata(const HDRMetadata& rhs) = default;
diff --git a/ui/gfx/hdr_metadata.h b/ui/gfx/hdr_metadata.h index 3079a13..5fc0319 100644 --- a/ui/gfx/hdr_metadata.h +++ b/ui/gfx/hdr_metadata.h
@@ -10,8 +10,8 @@ namespace gfx { -// SMPTE ST 2086 mastering metadata. -struct GFX_EXPORT MasteringMetadata { +// SMPTE ST 2086 color volume metadata. +struct GFX_EXPORT ColorVolumeMetadata { using Chromaticity = PointF; Chromaticity primary_r; Chromaticity primary_g; @@ -20,11 +20,11 @@ float luminance_max = 0; float luminance_min = 0; - MasteringMetadata(); - MasteringMetadata(const MasteringMetadata& rhs); - MasteringMetadata& operator=(const MasteringMetadata& rhs); + ColorVolumeMetadata(); + ColorVolumeMetadata(const ColorVolumeMetadata& rhs); + ColorVolumeMetadata& operator=(const ColorVolumeMetadata& rhs); - bool operator==(const MasteringMetadata& rhs) const { + bool operator==(const ColorVolumeMetadata& rhs) const { return ((primary_r == rhs.primary_r) && (primary_g == rhs.primary_g) && (primary_b == rhs.primary_b) && (white_point == rhs.white_point) && (luminance_max == rhs.luminance_max) && @@ -34,7 +34,7 @@ // HDR metadata common for HDR10 and WebM/VP9-based HDR formats. struct GFX_EXPORT HDRMetadata { - MasteringMetadata mastering_metadata; + ColorVolumeMetadata color_volume_metadata; // Max content light level (CLL), i.e. maximum brightness level present in the // stream), in nits. unsigned max_content_light_level = 0; @@ -49,14 +49,14 @@ bool IsValid() const { return !((max_content_light_level == 0) && (max_frame_average_light_level == 0) && - (mastering_metadata == MasteringMetadata())); + (color_volume_metadata == ColorVolumeMetadata())); } bool operator==(const HDRMetadata& rhs) const { return ( (max_content_light_level == rhs.max_content_light_level) && (max_frame_average_light_level == rhs.max_frame_average_light_level) && - (mastering_metadata == rhs.mastering_metadata)); + (color_volume_metadata == rhs.color_volume_metadata)); } };
diff --git a/ui/gfx/mac/io_surface_unittest.cc b/ui/gfx/mac/io_surface_unittest.cc index b35c69c..31eef23d 100644 --- a/ui/gfx/mac/io_surface_unittest.cc +++ b/ui/gfx/mac/io_surface_unittest.cc
@@ -14,12 +14,12 @@ // Check that empty NSBezierPath is returned for empty SkPath. TEST(IOSurface, HDRMetadata) { gfx::HDRMetadata in; - in.mastering_metadata.primary_r = PointF(1.0, 2.0); - in.mastering_metadata.primary_g = PointF(4.0, 5.0); - in.mastering_metadata.primary_b = PointF(7.0, 8.0); - in.mastering_metadata.white_point = PointF(10.0, 11.0); - in.mastering_metadata.luminance_max = 13; - in.mastering_metadata.luminance_min = 14; + in.color_volume_metadata.primary_r = PointF(1.0, 2.0); + in.color_volume_metadata.primary_g = PointF(4.0, 5.0); + in.color_volume_metadata.primary_b = PointF(7.0, 8.0); + in.color_volume_metadata.white_point = PointF(10.0, 11.0); + in.color_volume_metadata.luminance_max = 13; + in.color_volume_metadata.luminance_min = 14; in.max_content_light_level = 15; in.max_frame_average_light_level = 16;
diff --git a/ui/gfx/mojom/BUILD.gn b/ui/gfx/mojom/BUILD.gn index 4139682e..be5f1df 100644 --- a/ui/gfx/mojom/BUILD.gn +++ b/ui/gfx/mojom/BUILD.gn
@@ -230,8 +230,8 @@ { types = [ { - mojom = "gfx.mojom.MasteringMetadata" - cpp = "::gfx::MasteringMetadata" + mojom = "gfx.mojom.ColorVolumeMetadata" + cpp = "::gfx::ColorVolumeMetadata" }, { mojom = "gfx.mojom.HDRMetadata"
diff --git a/ui/gfx/mojom/hdr_metadata.mojom b/ui/gfx/mojom/hdr_metadata.mojom index 24dd81c..e4c8f48 100644 --- a/ui/gfx/mojom/hdr_metadata.mojom +++ b/ui/gfx/mojom/hdr_metadata.mojom
@@ -8,7 +8,7 @@ // This defines a mojo transport format for gfx::HDRMetadata. // See ui/gl/hdr_metadata.h for description. -struct MasteringMetadata { +struct ColorVolumeMetadata { gfx.mojom.PointF primary_r; gfx.mojom.PointF primary_g; gfx.mojom.PointF primary_b; @@ -18,7 +18,7 @@ }; struct HDRMetadata { - MasteringMetadata mastering_metadata; + ColorVolumeMetadata color_volume_metadata; uint32 max_content_light_level; uint32 max_frame_average_light_level; };
diff --git a/ui/gfx/mojom/hdr_metadata_mojom_traits.cc b/ui/gfx/mojom/hdr_metadata_mojom_traits.cc index eba1e96..46212306 100644 --- a/ui/gfx/mojom/hdr_metadata_mojom_traits.cc +++ b/ui/gfx/mojom/hdr_metadata_mojom_traits.cc
@@ -6,10 +6,10 @@ namespace mojo { -bool StructTraits< - gfx::mojom::MasteringMetadataDataView, - gfx::MasteringMetadata>::Read(gfx::mojom::MasteringMetadataDataView data, - gfx::MasteringMetadata* output) { +bool StructTraits<gfx::mojom::ColorVolumeMetadataDataView, + gfx::ColorVolumeMetadata>:: + Read(gfx::mojom::ColorVolumeMetadataDataView data, + gfx::ColorVolumeMetadata* output) { output->luminance_max = data.luminance_max(); output->luminance_min = data.luminance_min(); if (!data.ReadPrimaryR(&output->primary_r)) @@ -28,7 +28,7 @@ gfx::HDRMetadata* output) { output->max_content_light_level = data.max_content_light_level(); output->max_frame_average_light_level = data.max_frame_average_light_level(); - if (!data.ReadMasteringMetadata(&output->mastering_metadata)) + if (!data.ReadColorVolumeMetadata(&output->color_volume_metadata)) return false; return true; }
diff --git a/ui/gfx/mojom/hdr_metadata_mojom_traits.h b/ui/gfx/mojom/hdr_metadata_mojom_traits.h index d8c9037..5c477db 100644 --- a/ui/gfx/mojom/hdr_metadata_mojom_traits.h +++ b/ui/gfx/mojom/hdr_metadata_mojom_traits.h
@@ -11,29 +11,29 @@ namespace mojo { template <> -struct StructTraits<gfx::mojom::MasteringMetadataDataView, - gfx::MasteringMetadata> { - static const gfx::PointF& primary_r(const gfx::MasteringMetadata& input) { +struct StructTraits<gfx::mojom::ColorVolumeMetadataDataView, + gfx::ColorVolumeMetadata> { + static const gfx::PointF& primary_r(const gfx::ColorVolumeMetadata& input) { return input.primary_r; } - static const gfx::PointF& primary_g(const gfx::MasteringMetadata& input) { + static const gfx::PointF& primary_g(const gfx::ColorVolumeMetadata& input) { return input.primary_g; } - static const gfx::PointF& primary_b(const gfx::MasteringMetadata& input) { + static const gfx::PointF& primary_b(const gfx::ColorVolumeMetadata& input) { return input.primary_b; } - static const gfx::PointF& white_point(const gfx::MasteringMetadata& input) { + static const gfx::PointF& white_point(const gfx::ColorVolumeMetadata& input) { return input.white_point; } - static float luminance_max(const gfx::MasteringMetadata& input) { + static float luminance_max(const gfx::ColorVolumeMetadata& input) { return input.luminance_max; } - static float luminance_min(const gfx::MasteringMetadata& input) { + static float luminance_min(const gfx::ColorVolumeMetadata& input) { return input.luminance_min; } - static bool Read(gfx::mojom::MasteringMetadataDataView data, - gfx::MasteringMetadata* output); + static bool Read(gfx::mojom::ColorVolumeMetadataDataView data, + gfx::ColorVolumeMetadata* output); }; template <> @@ -44,9 +44,9 @@ static unsigned max_frame_average_light_level(const gfx::HDRMetadata& input) { return input.max_frame_average_light_level; } - static const gfx::MasteringMetadata& mastering_metadata( + static const gfx::ColorVolumeMetadata& color_volume_metadata( const gfx::HDRMetadata& input) { - return input.mastering_metadata; + return input.color_volume_metadata; } static bool Read(gfx::mojom::HDRMetadataDataView data,
diff --git a/ui/gl/hdr_metadata_helper_win.cc b/ui/gl/hdr_metadata_helper_win.cc index 240d64f..45d4415c 100644 --- a/ui/gl/hdr_metadata_helper_win.cc +++ b/ui/gl/hdr_metadata_helper_win.cc
@@ -107,22 +107,23 @@ const gfx::HDRMetadata& hdr_metadata) { DXGI_HDR_METADATA_HDR10 metadata{}; - auto& primary_r = hdr_metadata.mastering_metadata.primary_r; + auto& primary_r = hdr_metadata.color_volume_metadata.primary_r; metadata.RedPrimary[0] = primary_r.x() * kPrimariesFixedPoint; metadata.RedPrimary[1] = primary_r.y() * kPrimariesFixedPoint; - auto& primary_g = hdr_metadata.mastering_metadata.primary_g; + auto& primary_g = hdr_metadata.color_volume_metadata.primary_g; metadata.GreenPrimary[0] = primary_g.x() * kPrimariesFixedPoint; metadata.GreenPrimary[1] = primary_g.y() * kPrimariesFixedPoint; - auto& primary_b = hdr_metadata.mastering_metadata.primary_b; + auto& primary_b = hdr_metadata.color_volume_metadata.primary_b; metadata.BluePrimary[0] = primary_b.x() * kPrimariesFixedPoint; metadata.BluePrimary[1] = primary_b.y() * kPrimariesFixedPoint; - auto& white_point = hdr_metadata.mastering_metadata.white_point; + auto& white_point = hdr_metadata.color_volume_metadata.white_point; metadata.WhitePoint[0] = white_point.x() * kPrimariesFixedPoint; metadata.WhitePoint[1] = white_point.y() * kPrimariesFixedPoint; metadata.MaxMasteringLuminance = - hdr_metadata.mastering_metadata.luminance_max; + hdr_metadata.color_volume_metadata.luminance_max; metadata.MinMasteringLuminance = - hdr_metadata.mastering_metadata.luminance_min * kMinLuminanceFixedPoint; + hdr_metadata.color_volume_metadata.luminance_min * + kMinLuminanceFixedPoint; metadata.MaxContentLightLevel = hdr_metadata.max_content_light_level; metadata.MaxFrameAverageLightLevel = hdr_metadata.max_frame_average_light_level;
diff --git a/ui/latency/latency_tracker.cc b/ui/latency/latency_tracker.cc index 05cf568..3a854cf 100644 --- a/ui/latency/latency_tracker.cc +++ b/ui/latency/latency_tracker.cc
@@ -153,6 +153,13 @@ total_update_events_); UMA_HISTOGRAM_COUNTS_10000("Event.Latency.ScrollUpdate.JankyEvents", janky_update_events_); + + if (!total_update_duration_.is_zero()) { + UMA_HISTOGRAM_PERCENTAGE( + "Event.Latency.ScrollUpdate.JankyDurationPercentage", + static_cast<int>( + 100 * (janky_update_duration_ / total_update_duration_))); + } } total_update_events_ = 0;
diff --git a/ui/views/widget/desktop_aura/desktop_drag_drop_client_win.cc b/ui/views/widget/desktop_aura/desktop_drag_drop_client_win.cc index cb7cea0..d9ca998 100644 --- a/ui/views/widget/desktop_aura/desktop_drag_drop_client_win.cc +++ b/ui/views/widget/desktop_aura/desktop_drag_drop_client_win.cc
@@ -68,9 +68,11 @@ DWORD effect; - // Disable hang watching until the end of the function since the user can take - // unbounded time to complete the drag. (http://crbug.com/806174) - base::IgnoreHangsInScope disabler; + // Never consider the current scope as hung. The hang watching deadline (if + // any) is not valid since the user can take unbounded time to complete the + // drag. (http://crbug.com/806174) + base::HangWatcher::InvalidateActiveExpectations(); + base::TimeTicks start_time = base::TimeTicks::Now(); HRESULT result = ::DoDragDrop(
diff --git a/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html b/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html index fd733fc..1c26ef4 100644 --- a/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html +++ b/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html
@@ -7,6 +7,12 @@ height: var(--cr-toolbar-height); } + @media (prefers-color-scheme: light) { + :host-context([enable-branding-update]):host { + color: var(--google-grey-900); + } + } + @media (prefers-color-scheme: dark) { :host { border-bottom: var(--cr-separator-line); @@ -25,6 +31,11 @@ padding-inline-end: 12px; } + :host-context([enable-branding-update]):host h1 { + font-size: 170%; + font-weight: 500; + } + @media (prefers-color-scheme: dark) { h1 { color: var(--cr-primary-text-color); @@ -93,6 +104,17 @@ flex: 1 1 0; text-align: end; } + + #product-logo { + display: none; + } + + :host-context([enable-branding-update]):host(:not([narrow])) #product-logo { + display: initial; + height: 24px; + margin-inline-end: 10px; + width: 24px; + } </style> <div id="leftContent"> <div id="leftSpacer"> @@ -103,6 +125,10 @@ title="[[menuLabel]]"> </cr-icon-button> </template> + <img id="product-logo" + srcset="chrome://theme/current-channel-logo@1x 1x, + chrome://theme/current-channel-logo@2x 2x" + role="presentation"> <h1>[[pageName]]</h1> </div> </div>
diff --git a/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html b/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html index 6a860db8..2687916 100644 --- a/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html +++ b/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html
@@ -26,6 +26,12 @@ --cr-toolbar-search-field-input-icon-color, white); } + + :host-context([enable-branding-update]) cr-icon-button { + --cr-icon-button-fill-color: var( + --cr-toolbar-search-field-input-icon-color, + var(--google-grey-refresh-700)); + } } @media (prefers-color-scheme: dark) { @@ -45,6 +51,13 @@ opacity: 0; } + @media (prefers-color-scheme: light) { + :host-context([enable-branding-update]) #prompt { + color: var(--cr-toolbar-search-field-prompt-color, + var(--google-grey-refresh-700)); + } + } + @media (prefers-color-scheme: dark) { #prompt { --cr-toolbar-search-field-prompt-opacity: 1; @@ -63,6 +76,14 @@ width: var(--cr-icon-size); } + @media (prefers-color-scheme: light) { + :host-context([enable-branding-update]) paper-spinner-lite { + --paper-spinner-color: var( + --cr-toolbar-search-field-input-icon-color, + var(--google-grey-refresh-700)); + } + } + paper-spinner-lite[active] { opacity: 1; } @@ -109,6 +130,14 @@ width: 100%; } + @media (prefers-color-scheme: light) { + :host-context([enable-branding-update]) input { + caret-color: var(--google-blue-refresh-700); + color: var(--cr-toolbar-search-field-input-text-color, + var(--google-grey-refresh-700)); + } + } + input[type='search']::-webkit-search-cancel-button { display: none; } @@ -129,6 +158,27 @@ width: var(--cr-toolbar-field-width, 680px); } + :host-context([enable-branding-update]):host(:not([narrow])) { + border-radius: + var(--cr-toolbar-search-field-border-radius, 46px); + } + + @media (prefers-color-scheme: light) { + :host-context([enable-branding-update]):host(:not([narrow])) { + background: + var(--cr-toolbar-search-field-background, + var(--google-grey-refresh-100)); + } + } + + @media (prefers-color-scheme: dark) { + :host-context([enable-branding-update]):host(:not([narrow])) { + background: + var(--cr-toolbar-search-field-background, + rgba(0, 0, 0, 0.22)); + } + } + :host(:not([narrow]):not([showing-search])) #icon { opacity: var(--cr-toolbar-search-field-icon-opacity, .7); }
diff --git a/ui/webui/resources/cr_elements/shared_vars_css.html b/ui/webui/resources/cr_elements/shared_vars_css.html index d8bda6a..b14a6a92 100644 --- a/ui/webui/resources/cr_elements/shared_vars_css.html +++ b/ui/webui/resources/cr_elements/shared_vars_css.html
@@ -103,6 +103,12 @@ --cr-focus-outline-color: rgba(var(--google-blue-600-rgb), .4); } + @media (prefers-color-scheme: light) { + html[enable-branding-update] { + --cr-toolbar-background-color: white; + } + } + @media (prefers-color-scheme: dark) { html { --cr-primary-text-color: var(--google-grey-200);
diff --git a/ui/webui/resources/css/md_colors.css b/ui/webui/resources/css/md_colors.css index 383a5f3..e521dd6d 100644 --- a/ui/webui/resources/css/md_colors.css +++ b/ui/webui/resources/css/md_colors.css
@@ -12,6 +12,13 @@ --md-toolbar-height: 56px; } +@media (prefers-color-scheme: light) { + html[enable-branding-update] { + --md-background-color: white; + --md-toolbar-color: white; + } +} + @media (prefers-color-scheme: dark) { html { --md-background-color: rgb(32, 33, 36); /* --google-grey-900 */
diff --git a/weblayer/BUILD.gn b/weblayer/BUILD.gn index df80a27..2f06df9 100644 --- a/weblayer/BUILD.gn +++ b/weblayer/BUILD.gn
@@ -432,7 +432,6 @@ "//components/language/core/browser", "//components/leveldb_proto", "//components/metrics", - "//components/metrics:content", "//components/network_time", "//components/no_state_prefetch/browser", "//components/no_state_prefetch/common",
diff --git a/weblayer/browser/android/metrics/weblayer_metrics_service_client.cc b/weblayer/browser/android/metrics/weblayer_metrics_service_client.cc index cf70359..d31f4db4 100644 --- a/weblayer/browser/android/metrics/weblayer_metrics_service_client.cc +++ b/weblayer/browser/android/metrics/weblayer_metrics_service_client.cc
@@ -10,8 +10,6 @@ #include "base/base64.h" #include "base/no_destructor.h" -#include "components/metrics/content/content_stability_metrics_provider.h" -#include "components/metrics/content/extensions_helper.h" #include "components/metrics/metrics_provider.h" #include "components/metrics/metrics_service.h" #include "components/page_load_metrics/browser/metrics_web_contents_observer.h" @@ -157,9 +155,6 @@ void WebLayerMetricsServiceClient::RegisterAdditionalMetricsProviders( metrics::MetricsService* service) { - service->RegisterMetricsProvider( - std::make_unique<metrics::ContentStabilityMetricsProvider>(pref_service(), - nullptr)); service->RegisterMetricsProvider(std::make_unique<PageLoadMetricsProvider>()); }
