Compute all webview find options before cloning them In WebViewFindHelper::Find, we're cloning the find options before we've set the value for `new_session`. For requests that are part of the same session, in WebViewFindHelper::FindReply, we're using the incorrect value for `new_session` and we're destroying the FindInfo for what we think is a previous session but is actually for the request we're currently processing. We now fully compute the options before cloning them. Bug: 1443401 Change-Id: Ife6747aedabaf74f9a4855a173349ffe612b6f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4533923 Reviewed-by: James Maclean <wjmaclean@chromium.org> Commit-Queue: James Maclean <wjmaclean@chromium.org> Auto-Submit: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/main@{#1145265}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.