[discard] Ensure FrameTree::Discard clears service workers This CL ensures that any service workers registered against a discarded RenderFrameHostImpl are cleared following the a discard operation. Previously service workers were not being cleared as expected because the commit params used to commit the new empty document for discard copied over the service worker network provider in DocumentLoader::CreateWebNavigationParamsToCloneDocument() [1]. As a result service workers could persist for the discarded frame in the case the associated process was not proactively shut down. This CL addresses this by clearing the ServiceWorkerNetworkProvider when a discarded document is installed. This breaks the container host pipe with the browser and the ServiceWorkerClient is destroyed [2]. The ServiceWorkerNetworkProviderForFrame class lives in //content/ and must be replaced with ServiceWorkerNetworkProviderForFrame::CreateInvalidInstance() instead of being nullified in blink as the network provider is expected to be not-null, see [3]. [1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/loader/document_loader.cc;l=743;drc=492dc9719f6e1845f4f5c0553cd5c7651115f671 [2] https://source.chromium.org/chromium/chromium/src/+/main:content/browser/service_worker/service_worker_context_core.cc;l=527;drc=492dc9719f6e1845f4f5c0553cd5c7651115f671 [3] https://source.chromium.org/chromium/chromium/src/+/main:content/renderer/render_frame_impl.cc;l=3045;drc=4c6d5b3c3ed16fa75258c6b4763188f840cb433d Bug: 404877558 Change-Id: If0d495b94d4b5be38f2832152437a4b460f63692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6367564 Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Tom Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/main@{#1436434}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.