[discard] Ensure FrameTree::Discard clears service workers

This CL ensures that any service workers registered against a
discarded RenderFrameHostImpl are cleared following the a
discard operation.

Previously service workers were not being cleared as expected
because the commit params used to commit the new empty document
for discard copied over the service worker network provider
in DocumentLoader::CreateWebNavigationParamsToCloneDocument() [1].

As a result service workers could persist for the discarded frame
in the case the associated process was not proactively shut down.

This CL addresses this by clearing the ServiceWorkerNetworkProvider
when a discarded document is installed. This breaks the container
host pipe with the browser and the ServiceWorkerClient is
destroyed [2].

The ServiceWorkerNetworkProviderForFrame class lives in //content/
and must be replaced with
ServiceWorkerNetworkProviderForFrame::CreateInvalidInstance()
instead of being nullified in blink as the network provider is
expected to be not-null, see [3].

[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/loader/document_loader.cc;l=743;drc=492dc9719f6e1845f4f5c0553cd5c7651115f671

[2] https://source.chromium.org/chromium/chromium/src/+/main:content/browser/service_worker/service_worker_context_core.cc;l=527;drc=492dc9719f6e1845f4f5c0553cd5c7651115f671

[3] https://source.chromium.org/chromium/chromium/src/+/main:content/renderer/render_frame_impl.cc;l=3045;drc=4c6d5b3c3ed16fa75258c6b4763188f840cb433d

Bug: 404877558
Change-Id: If0d495b94d4b5be38f2832152437a4b460f63692
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6367564
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Tom Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1436434}
6 files changed
tree: f270af8f49cf61b26b39b1ff962fe422b6fd0b01
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .git-blame-ignore-revs
  53. .gitallowed
  54. .gitattributes
  55. .gitignore
  56. .gitmodules
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. CPPLINT.cfg
  68. CRYPTO_OWNERS
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.