commit bbfe1a16111ad56e4c9c6c6496c361cd858ae596
author Darren Shen <shend@chromium.org> Fri Apr 28 05:38:48 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Apr 28 05:38:48 2023
tree 694155534ad6cb4bcc04186e4b4a43e9b9d3e765
parent d4f6f29391d33463ede95f0110fbc28ddd43241e

Reland "inputs: Fix OnCursorPosition/OnCommitString in Lacros."

This reverts commit c91ce23a4fc50122b25d8543327dc1e44f8b2fa3.

Reason for revert: Relanding behind flag with tests.

Because the fix here is not observable without https://crrev.com/c/4394605, we can't write a test in this CL. However, the tests in https://crrev.com/c/4394605 will fail without this CL, showing that this fix is doing something.

Original change's description:
> Revert "inputs: Fix OnCursorPosition/OnCommitString in Lacros."
>
> This reverts commit 0bcbfa3bd4ead1e3ed83160552117d04dafea69a.
>
> Reason for revert: crbug.com/1412998
>
> Original change's description:
> > inputs: Fix OnCursorPosition/OnCommitString in Lacros.
> >
> > In Lacros, ConfirmCompositionText is broken down to two operations:
> > - set_cursor with current selection
> > - commit_string ""
> >
> > When calling set_cursor, we flip the selection start/end [1]. But we
> > forgot to flip it back [2] on the Lacros side.
> >
> > So set_cursor(0, 4) becomes set_cursor(4, 0) on the other end. This
> > completely breaks the ConfirmCompositionText behaviour when there's a
> > selection.
> >
> > We will followup with a CL to add a browser test for this. Right now a
> > browser test is not possible because there's a timing issue that require
> > a new API to wait for surrounding text.
> >
> > Bug: b/265853952
> >
> > [1] https://source.chromium.org/chromium/chromium/src/+/main:components/exo/wayland/zwp_text_input_manager.cc;l=159;drc=c14f4e9399fc4e23a6c4c68fc60086bdceec1c90
> > [2] https://source.chromium.org/chromium/chromium/src/+/main:ui/ozone/platform/wayland/host/wayland_input_method_context.cc;l=508;drc=c149c1657efb82884f21a3deea7678e66cfc422a
> >
> > Change-Id: Icc31a38f4d7219fb75128450ae78add4ad2bc531
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4198597
> > Commit-Queue: Kramer Ge <fangzhoug@chromium.org>
> > Auto-Submit: Darren Shen <shend@chromium.org>
> > Reviewed-by: Kramer Ge <fangzhoug@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1098960}
>
> Bug: b/265853952
> Change-Id: Icd749c240a3de4628ae487a8f0ae400c0a401e70
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4229673
> Owners-Override: Srinivas Sista <srinivassista@chromium.org>
> Commit-Queue: Darren Shen <shend@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1102559}

Bug: b/265853952
Change-Id: I1d27ef7437ad30be7c06eac244c01ff33ab4d83b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4413981
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1136965}