commit bc13c849ee5b713e3752a74a158414adc46ec373
author David Maunder <davidjm@chromium.org> Mon Jun 06 18:00:08 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jun 06 18:00:08 2022
tree eb71e8f9350a7d5e97ce012cdef097039efbeef0
parent 4412b43dd341d1ab04fc19e0103bf8c5cc9a6d4a

Change Tab file saving to use asReadOnlyBuffer()

It is believed that the BufferUnderflowExceptions being seen in
the referenced bug are because there are two threads operating on
the same ByteBuffer. By using asReadOnlyBuffer() each save system
has its own local ByteBuffer (own position, limit etc.) but backed by
the same byte array. Not deep copying the Bytebuffer minimizes the risk
of a performance regression but having a local ByteBuffer with its
own position, limit etc. has a very low performance cost but ensures
there aren't multiple threads operating on the same ByteBuffer.

(cherry picked from commit d73e9f8adc56780ff704528ae5d9756241a816ac)

Bug: 1297894
Change-Id: Ieb1124b36d4a6d1962d36a94ced94eef5a804742
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3685432
Commit-Queue: David Maunder <davidjm@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1010781}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3691380
Owners-Override: Krishna Govind <govind@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/5060@{#609}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}