Google Git
Sign in
chromium / chromium / src / bc16abbc25d71745fc414c65df8046bd87aa2197
commitbc16abbc25d71745fc414c65df8046bd87aa2197[log] [tgz]
authorMarc Treib <treib@chromium.org>Mon Apr 07 15:59:17 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Apr 07 15:59:17 2025
tree37f0cfb5c1f63a5c5d94053729bd86b2daf6c090
parent4c6a839ef3db6b34af833dd48485b2557f7f387b [diff]
[iOS] NTP: Fix "Sign in" briefly flashing while switching accounts

When switching accounts (with chrome://flags/#identity-disc-account-menu
and/or chrome://flags/#separate-profiles-for-managed-accounts enabled),
there was a brief flash of the "Sign in" button between the old and the
new avatar image.
This was previously fixed by listening to
onEndBatchOfPrimaryAccountChanges (which only gets called once both the
sign-out and the sign-in are complete), see bug 397194715, but
https://crrev.com/c/6355423 reintroduced the flashes by adding an extra
setUserSignedIn notification which bypassed the IdentityManager-level
batching.
This CL fixes the issue by removing setUserSignedIn, which wasn't
really necessary in the first place - the signin state could already
be determined from existing calls.

Fixed: 406922383
Change-Id: Id602f0103fbc1019a9b84735441daec1796870bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6433737
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Scott Yoder <scottyoder@google.com>
Cr-Commit-Position: refs/heads/main@{#1443518}
3 files changed
tree: 37f0cfb5c1f63a5c5d94053729bd86b2daf6c090
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.