Google Git
Sign in
chromium / chromium / src / bc41d8cd4ea09ab24e246f652b05375eed71bd73
commitbc41d8cd4ea09ab24e246f652b05375eed71bd73[log] [tgz]
authorJames MacLean <wjmaclean@chromium.org>Mon Feb 01 19:39:37 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Feb 01 19:39:37 2021
treedf867ad30d09a684be5379213d11f8a754b70206
parent9c02acef44b0ee324291cb3f438f2d034d2d0866 [diff]
Revert "Log whether keep_alive > 0 on no-BrowsingInstanceID in CADFO."

This reverts commit 1d58ac95d3cce86bb37fc79a60137a2112234a9c.

Reason for revert: This CL was an experiment to collect crash data, and disabled logic to recover without crashing; now that we have our data, we revert it to avoid allowing further crashes.

Original change's description:
> Log whether keep_alive > 0 on no-BrowsingInstanceID in CADFO.
>
> Temporary experiment to see if the cases where CADFO is called with
> no BrowsingInstanceID can be accounted for by a non-zero keep-alive
> count in RenderProcessHostImpl.
>
> Bug: 1148542
> Change-Id: Ie49a24cdb867f1b9e1aabe8c15d418f5e9363db2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2656937
> Reviewed-by: Charlie Reis <creis@chromium.org>
> Commit-Queue: Charlie Reis <creis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#848348}

TBR=creis@chromium.org,wjmaclean@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1148542
Change-Id: If535d0ba39da564ad4eb197ccace20c3ac7eea6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2664528
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#849211}
1 file changed
tree: df867ad30d09a684be5379213d11f8a754b70206
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.