commit bc8af9cee84568e7f3f5b4be672f1218a5dd5b0b
author Peter Kvitek <kvitekp@chromium.org> Mon Apr 07 17:43:49 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Apr 07 17:43:49 2025
tree b0cc27e5b7ef3ce8b931aac65f0748029fb2814c
parent 22782799e14cac0ac5dcd9791fc25ef71be73bb8

[win] Change ScreenWin public static methods to virtual

CL http://crrev.com/c/6332686 introduced an alternate headless aware
ScreenWin implementation. However, since all ScreenWin public methods
are static, we'll have to resort to some ugly proxy classes in order to
orchestrate access to the public ScreenWin functionality.

A cleaner, albeit somewhat intrusive, solution is to change ScreenWin
public interface methods to be all virtual. This way normal and headless
aware functionality will be seamlessly available using the standard
mechanism of calling virtual methods via the static instance getter.

One issue with this approach is that many tests call ScreenWin public
methods before ScreenWin instance is created. Static ScreenWin methods
return a generic response in this case, however, virtual ScreenWin
methods need an instance to be invoked. Instead of modifying the tests
the ScreenWin instance getter lazily creates a fallback ScreenWin
instance and uses it to serve generic responses until the real ScreenWin
is created or the test terminates.

Most of the files in this CL are ScreenWin public method call sites that
are mechanically updated with
s/display::win::ScreenWin::/display::win::GetScreenWin()->/.

The meaningful changes are in //ui/display/win/screen_win*.

Change-Id: Iafbc6323be41639e4565a4b0c63b1202e8279be9
AX-Relnotes: n/a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6419936
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1443607}