Google Git
Sign in
chromium / chromium / src / bcc9ea75ebf58
commitbcc9ea75ebf58f1c1b73f861fba8238e4d25fb15[log] [tgz]
authorTommy C. Li <tommycli@chromium.org>Wed Sep 21 02:57:46 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Sep 21 02:57:46 2022
treedf8cb3b5dce9c475a1f9012737aae0306622e834
parentf8983ed0dc9eb18a747a47753bbac018c7eb9fe3 [diff]
[omnibox] Fix weird test-only wrong-thread init of InMemoryURLIndex

For some reason, InMemoryURLIndex has fake-initialization step used
only in unit tests that causes History methods to be executed on the
main thread, rather than the History sequence.

It's always been fine before, but ever since I committed this massive
CL below, there's been flakes:
https://chromium-review.googlesource.com/c/chromium/src/+/3871694

But I don't think the solution is to revert that massive CL, I think
we should actually fix the sequence confusion.

This CL does that by deleting this test-only call, and making the
tests follow the production initialization code path. The test only
code was strange and not necessary anyways.

Bug: 1362186, 1141539, 1365413, 1363466
Change-Id: I015b472fc0c7e2f8027710973612c1d22cc68908
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3906645
Reviewed-by: Orin Jaworski <orinj@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1049422}
5 files changed
tree: df8cb3b5dce9c475a1f9012737aae0306622e834
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.