Google Git
Sign in
chromium / chromium / src / bcf61e48f5992beb89219af3005fc6eea0cc1250
commitbcf61e48f5992beb89219af3005fc6eea0cc1250[log] [tgz]
authorSiye Liu <siliu@microsoft.com>Wed Sep 09 01:03:27 2020
committerCommit Bot <commit-bot@chromium.org>Wed Sep 09 01:03:27 2020
tree1fba004881e134c0ebe4ff7c9ec7fd4923af11bf
parentc17a107e02156488f6400964dfab48d39529ff8d [diff]
Should ask hittest frame to invoke context menu on long tap.

During long tap, |WebViewImpl::HandleGestureEvent| asks the main
frame's GestureManager is the long tap should invoke context menu.
However, the previeus long press event was routed to iframe's
GestureManager. Therefore, main frame's GestureManager returns false
in |GestureManager::LongTapShouldInvokeContextMenu|. Therefore, context
menu is not invoked if the link is in an iframe. We should ask the hit
frame to decide whether we should invoke context menu during long tap.

Bug: 1112987
Change-Id: I90f5e1f09380258b6bdf83c9cc78b9764d2adeca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382054
Reviewed-by: Siye Liu <siliu@microsoft.com>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Siye Liu <siliu@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#805167}
3 files changed
tree: 1fba004881e134c0ebe4ff7c9ec7fd4923af11bf
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.