Google Git
Sign in
chromium / chromium / src / be0c33a335c267f3db77e33ef1e647f57e8d1f5d
commitbe0c33a335c267f3db77e33ef1e647f57e8d1f5d[log] [tgz]
authorDrew Davenport <ddavenport@chromium.org>Wed Apr 03 23:33:02 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Apr 03 23:33:02 2024
treec954bf85c0b2bf7c6144dfddf83bd8182cd535ff
parentac0a440a3688c06e7c67a3b8ccf91c0a3758c40b [diff]
ozone/drm: Release PageFlipRequest reference in tests

If a pageflip is committed to FakeDrmDevice, and the pageflip callback
is not cleared, this results in a reference cycle preventing the
FakeDrmDevice from being deleted.

- DrmOverlayPlane holds a scoped_refptr<DrmFramebuffer>
- DrmFramebuffer holds a scoped_refptr<DrmDevice>
- in HardwareDisplayController::SchedulePageFlip the
  vector<DrmOverlayPlane> is bound to a base::OnceCallback
- PageFlipRequest takes ownership of the callback through TakeCallback
- In FakeDrmDevice::CommitProperties, the FakeDrmDevice adds the
  PageFlipRequest to its internal queue, causing a reference cycle.

For tests that run the callbacks via FakeDrmDevice::RunCallbacks, the
PageFlipRequest reference will be dropped and the reference cycle
broken.

FakeDrmDevice::ClearCallbacks provides a mechanism to break the
reference cycle while avoiding any unintended side effects of executing
the callbacks.

Bug: chromium:40263665
TEST: ozone_unittests with detect_leaks=1

Change-Id: I4404b6c339d6fa76da116e070cace36469a8cbbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5410833
Reviewed-by: Gil Dekel <gildekel@chromium.org>
Commit-Queue: Drew Davenport <ddavenport@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1282221}
3 files changed
tree: c954bf85c0b2bf7c6144dfddf83bd8182cd535ff
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.