Google Git
Sign in
chromium / chromium / src / be42d41c6a52d3fd2bfac29a62ade9f73f7579e0
commitbe42d41c6a52d3fd2bfac29a62ade9f73f7579e0[log] [tgz]
authorkylechar <kylechar@chromium.org>Wed Nov 17 18:40:37 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Nov 17 18:40:37 2021
treed2bbcb27630450f9bc2acc12c84c25075dedec98
parentfedef5880a071b6eb7c36b7fa8b2938dc7aac078 [diff]
Set release fence from BeginPresent()

If PresenterImageFuchsia is destroyed while there is a pending present
then |scoped_overlay_read_access_| may not have had a release fence set
on it. When |scoped_overlay_read_access_| is destroyed this will violate
expectation that the semaphore passed to
ExternalVkImageBacking::EndAccessInternal() is not null.

Switch PresenterImageFuchsia so the semaphore is set in BeginPresent()
rather than EndPresent(). This matches the behaviour before when it was
using a skia representation for scoped read access instead of an overlay
representation.

Bug: b/206492798
Change-Id: I886ed4a94732685da5274f3933f7075de0ce0101
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3289883
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#942721}
1 file changed
tree: d2bbcb27630450f9bc2acc12c84c25075dedec98
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.