Google Git
Sign in
chromium / chromium / src / be4826d428fc5f64c6c8628bf3f39e8935b0c7ea
commitbe4826d428fc5f64c6c8628bf3f39e8935b0c7ea[log] [tgz]
authorAaron Leventhal <aleventhal@google.com>Tue Nov 14 23:53:40 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Nov 14 23:53:40 2023
tree2ff068b81022f5e846407efdc7c1fcb590c682ac
parentf180900beaaf487c5a88b2dc3241cbeb1285edaa [diff]
[A11y] Alert events must only be fired on alert roles

In patchset 1, we move the failing check from Linux-specific code to
all of the places it needs to be checked in cross-platform code.
Previously, the alert only failed in some situations on Linux.
This is stricter and catches the error more often.

The last patchset contains all of the necessary fixes. This CL is
necessary to green the a11y CI bot.

As part of this change, I'm simplifying the call sites that had
a hack for MacOS to use alerts where every other OS uses AnnounceText().
I tracked down when we started doing that and spoke with the engineer,
and tested the case in question. It seems that AnnounceText() is working
fine on Mac as long as VoiceOver is running.

Fixed: 1493738,1377831,1369912
Change-Id: I82449659bd6ca10fd66acc6ae4f8681716aaf7f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4980070
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: David Tseng <dtseng@chromium.org>
Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1224618}
15 files changed
tree: 2ff068b81022f5e846407efdc7c1fcb590c682ac
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. DEPS
  75. DIR_METADATA
  76. LICENSE
  77. LICENSE.chromium_os
  78. OWNERS
  79. PRESUBMIT.py
  80. PRESUBMIT_test.py
  81. PRESUBMIT_test_mocks.py
  82. README.md
  83. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.