commit | be4d3432e9db79744dcf8d2a439b5cdc94f5d321 | [log] [tgz] |
---|---|---|
author | Lucas Mudo de Araujo <lucasmud@microsoft.com> | Wed May 08 21:30:28 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed May 08 21:30:28 2024 |
tree | 4331204158dc0abf372ea80e7a1c2f518804ee1f | |
parent | f470e065a91caac87ee648c9ab17422fddee8f0f [diff] |
Reland "Correctly map enums from histograms/metadata/ to ENUMS_XML" This is a reland of commit 3c483eba0b773723bb1864fb35947520b2bc5ef5 Changes since first commit: Updated histogram_paths.py to ensure that files are sorted before generating histograms_xml_files.gni Original change's description: > Correctly map enums from histograms/metadata/ to ENUMS_XML > > Currently, all histograms.xml and enums.xml defined within `histograms/metadata` get mapped to HISTOGRAMS_XMLS. > > This will cause a pre-submit error whenever a metric not defined within `histograms/metadata` leverages an Enum defined within that path. The simplest case to reason through is UKMs. If an UKM uses an enum from `histogram/metadata`, it will fail presubmit because such Enum won't be defined in histogram_paths.ENUMS_XML. > > Bug: 338010629 > Change-Id: Ifbf1e7a7d4852c0855106617d3394ad139cce869 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5499503 > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Commit-Queue: Lucas Mudo de Araujo <lucasmud@microsoft.com> > Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1297138} Bug: 338010629 Change-Id: Ifd6f0317fb319bc979712dcc9312a8f39891361a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5522926 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Commit-Queue: Lucas Mudo de Araujo <lucasmud@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1298365}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.