[UB] Fix UB visibility bugs

Two changes that should address these bugs:
1) Always update the visibility of the icon in StatusChanged, even if
`icon_visible_` is the same. This is because visibility is not just a
product of `icon_visible_`, so it's possible a separate change in the UI
(e.g. omnibox focus) has triggered this call and we need to update

2) Keep track of whether or not we should be showing the UB icon on the
current site as a confirmation of the user changing their protection
state. This avoids the logic from 1) suddenly causing the UB icon to
disappear after animating (e.g. if the site has not taken any action
that we would typically show UB for). Note that leaving the site and
then going back may not cause the icon to show for these cases, which
is WAI as we only want to show UB on the site **directly after** a
protection state change / reload

Bug: b:432231780, b:432365741, b:432382207
Change-Id: I9a39c9fa5a3fbe7cff5a4d3345943ed76b3539fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6777768
Auto-Submit: Fiona Macintosh <fmacintosh@google.com>
Reviewed-by: Michelle Abreo <michelleabreo@google.com>
Commit-Queue: Michelle Abreo <michelleabreo@google.com>
Cr-Commit-Position: refs/heads/main@{#1490844}
3 files changed
tree: edfaf3400045de03d9453fd685b071e0648563fb
  1. .github/
  2. agents/
  3. android_webview/
  4. apps/
  5. ash/
  6. base/
  7. build/
  8. build_overrides/
  9. buildtools/
  10. cc/
  11. chrome/
  12. chromecast/
  13. chromeos/
  14. codelabs/
  15. components/
  16. content/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia_web/
  23. gin/
  24. google_apis/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. net/
  33. pdf/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .cursorignore
  53. .git-blame-ignore-revs
  54. .gitallowed
  55. .gitattributes
  56. .gitignore
  57. .gitmodules
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython3
  62. .yapfignore
  63. ATL_OWNERS
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. CPPLINT.cfg
  69. CRYPTO_OWNERS
  70. DEPS
  71. DIR_METADATA
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. SECURITY_OWNERS
  80. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.