commit | be89b0200cddb42a3dfb2b5b908dd70f0542f1aa | [log] [tgz] |
---|---|---|
author | Justin Donnelly <jdonnelly@chromium.org> | Mon Apr 29 18:06:44 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Apr 29 18:06:44 2024 |
tree | 14926253907686f920eb1cd3bdd24e3e7a77cc4f | |
parent | 704b750e4eb6b7b6dcd9dd960c384d3894c3eed5 [diff] |
[lensoverlay] Fix the "invisible searchbox" issue and adjust styling. Before: https://screenshot.googleplex.com/7CVLwCqxngZUvZC.png After: https://screenshot.googleplex.com/8TPumjrN6c5zCRj.png Specifies the searchbox colors in the side panel HTML rather than relying on the CSS file import, which doesn't work reliably. It's not clear what's the right approach long term, it may depend on whether we need to be responsive to theming or not. If so, I'll need to diagnose and fix the import issue. If not, we may be able to just rely on these new local color definitions. Also makes several other changes that move the UI closer to spec: - Sets "realboxCr23HoverFillShape" to false. - Sets "realboxDefaultIcon" to the Google G. - Replaces the "Search Google or type a URL" hint text with "Search Google". This is just a temporary change until the strings are finalized. - Introduces a new "searchboxInSidePanel" data source value that drives some tweaks to the size and position of elements in the searchbox when it's being shown in the side panel. Bug: b:337291041, b:337657623 Change-Id: Iccc0ffa9c90fce802cb0b0a19443eab8e0cc5114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5494913 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Nihar Majmudar <niharm@google.com> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/main@{#1293817}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.