Google Git
Sign in
chromium / chromium / src / be91d8adfe054c58bbb0ea1711b01ecaeec7e9c4
commitbe91d8adfe054c58bbb0ea1711b01ecaeec7e9c4[log] [tgz]
authorSvend Larsen <svend@chromium.org>Wed Jan 29 19:55:31 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jan 29 19:55:31 2025
tree053620712bf2436b3f5d0c5384ce4df12948b524
parente300acf3e5af2bba91bd8699aebae1f63f5c2994 [diff]
[BTM] Report page visit duration from BtmPageVisitObserver

I computed duration using base::Time (wall-clock time) rather than
base::TimeTicks (monotonically increasing counter) because, although
wall-clock time can produce surprising results like negative durations,
the implementation notes for base::TimeTicks say that it's not
recommended for long durations due to platform-dependent implementation
details, such as whether the counter increments while the process is
asleep. I think a low but consistent rate of wall-clock weirdness is
preferable to skewing visit durations by platform.

Design: go/btm-page-visit-observer

Bug: 390201794
Change-Id: I920a2734f30c0b092d955fedb9600a0b485156e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6208809
Commit-Queue: Svend Larsen <svend@chromium.org>
Reviewed-by: Ryan Tarpine <rtarpine@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1413082}
5 files changed
tree: 053620712bf2436b3f5d0c5384ce4df12948b524
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. description
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.