Google Git
Sign in
chromium / chromium / src / e9a2ec12799144f4bfccc4612a780ddf0902ee3d
commite9a2ec12799144f4bfccc4612a780ddf0902ee3d[log] [tgz]
authorJavier Ernesto Flores Robles <javierrobles@chromium.org>Thu Jun 27 15:30:17 2019
committerCommit Bot <commit-bot@chromium.org>Thu Jun 27 15:30:17 2019
tree1fd6e1535c74ad7b19107253ccc4120133d1b94e
parent2b440785951051d3c67ba6e8ab5dc0e810d7f249 [diff]
[iOS][RBS] Stop observing camera on dealloc.

Uses a new BOOL to decide when to stop KVO from the camera object
instead of checking the camera availability. This fixes a crash that
occurs when the camera starts being observed but this is never stoped
due the camera never being available in the first place. See attached
bug for more info.

Includes minor fixes. Changes |self.cameraState| to |_cameraState| on
init, which was triggering a NOTREACHED condition in debug builds.
Other properties with custom setters where not changed for ivars, this
to prevent undesired changes. Changes an AV string to the proper
constant.


Bug: 972093
Change-Id: I60e86c10fe11c129e2fdd07a01295a7db1673103
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680177
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672907}
1 file changed
tree: 1fd6e1535c74ad7b19107253ccc4120133d1b94e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .