commit | bea1130a321c286611563e16fca36f99d8f0f366 | [log] [tgz] |
---|---|---|
author | Matthias Körber <koerber@google.com> | Tue Feb 02 17:17:35 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Feb 02 17:17:35 2021 |
tree | dad223c393ed0ea71eff09999fd3b2fab035f7e6 | |
parent | 20311e9089343e26b73dfe16f503451cd0cb1bba [diff] |
[Autofill] Make usage of structured name compatible with factory pattern Prior to this change NameInfo had a member for the structured address tree of type NameFull. This CL replaces this member with a unique pointer to the base class AddressComponent. By this, it becomes possible to make a finch-controlled replacement of the structured name tree with a new, differently structured version using a factory. This is necessary for a secure rollout of honorific prefixes, that will introduce a new root node to the address tree that will hold both the old NameFull and an additional honorific prefix. This CL replaces the assignment and comparison operators with methods that are implemented in the base class and work the same for all derived address component classes. By this, the call becomes independent on the type of the calling instance. This CL also changes the concept how nodes are registered as child nodes of a component. Before, the pointers to the child nodes have been supplied on construction time. Now, the child registers itself to its parent node. By this, the code gets simpler and less prone to errors. Change-Id: Iecd123ad4d131835cc6e04e330b6814fda66c612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2657815 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by: Christoph Schwering <schwering@google.com> Reviewed-by: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#849646}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.