[LR] Handle screenshot and download errors

Adds error handling for the cases where a screenshot cannot be taken on
the Lightweight Reactions dialog opening, or where the assets (GIFs
and thumbnails) fail to download to disk the first the feature is used.
In case of error, the dialog isn't launched, and a toast message is
showed instead.


The dialog view is now initialized and showed in
maybeFinishInitialization, to prevent showing the dialog and
immediately dismissing it in case of an asset fetch error. As a result,
the onViewCreated method has been removed in favor of a lambda.

Also adds a metric to record how long the asset fetch took before
failing.

While at it, a callback variable was renamed to remove some
confusion.

Bug: 1268473, 1268474
Change-Id: Idd3143fdd0abaefadbd7b368c03e7bdf0a2bb954
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3297934
Commit-Queue: Guillaume Jenkins <gujen@google.com>
Reviewed-by: sebsg <sebsg@chromium.org>
Reviewed-by: Sophey <sophey@chromium.org>
Cr-Commit-Position: refs/heads/main@{#945051}
4 files changed
tree: b0a33b9f4096344f3284960fc4ef4ab970cd54f7
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.