Google Git
Sign in
chromium / chromium / src / beca91cf4f62e8fe1bbb6c7256b0f70e1536039e
commitbeca91cf4f62e8fe1bbb6c7256b0f70e1536039e[log] [tgz]
authorrbpotter <rbpotter@chromium.org>Fri Feb 12 21:44:49 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Feb 12 21:44:49 2021
treeedae06fac874edeb757e02aec26935e5fd52e29e
parent84c39aecad293e719d132956a7881cadf865244e [diff]
Appcache internals: Migrate to JS modules

- Update appcache_internals to JS modules and remove use of old
  deprecated files like cr.js
- Also remove use of deprecated CallJavascriptFunctionUnsafe, in favor
  of ResolveJavascriptCallback and FireWebUIListener.
- Note: Leaving some callbacks as events currently that could likely
  be converted to promises with further changes in the app cache code
  (e.g., updating the AppCacheResponseInfo struct to include a callback
  id, updating how the proxy calls the service, etc), as this is outside
  the scope of simply trying to remove deprecated function calls/files.
- Restructure the WebUIController to add a WebUIMessageHandler instead
  of registering for messages directly, to align this controller with
  current WebUI practices.

Bug: 1173575
Change-Id: Ifba89b59a7609039f8f308a409385d9491f47f5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2690214
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#853679}
4 files changed
tree: edae06fac874edeb757e02aec26935e5fd52e29e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.