Google Git
Sign in
chromium / chromium / src / bee42ccbb22a090614e2c46995978ceca563298a
commitbee42ccbb22a090614e2c46995978ceca563298a[log] [tgz]
authorGiovanni Ortuño Urquidi <ortuno@chromium.org>Mon May 20 00:42:43 2019
committerCommit Bot <commit-bot@chromium.org>Mon May 20 00:42:43 2019
tree5218bad785b1125dd956cdec437077fbe79428e5
parent63b9cb66b1b8968acd01c5e51ddff01a5c64b7f7 [diff]
desktop-pwas: Rewrite fake BookmarkAppInstallation in PendingAppManager tests

Previously a PendingBookmarkAppManager could be created with either
installation tasks that always succeeded or with installation tasks that
always failed. This made writing tests that needed some tasks to fail
and some to succeed impossible to write.

This CL changes how fake tasks are created and allows tests to control
the result of each specific task.

Bug: 916381
Change-Id: Ie10b5fd8866713414d3878ce7dd38615a2aec44f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615041
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661240}
1 file changed
tree: 5218bad785b1125dd956cdec437077fbe79428e5
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .