Google Git
Sign in
chromium / chromium / src / bee9ae94e99df609a0eb3b4aaae932e17cfef9e4
commitbee9ae94e99df609a0eb3b4aaae932e17cfef9e4[log] [tgz]
authorJonathan Lee <jonathanjlee@google.com>Wed Dec 11 18:01:41 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Dec 11 18:01:41 2024
tree44fdf69e8dafe71037600b00645fdf8641a291f6
parenta390a91c061706053e86331fc6042c91b1a4ef67 [diff]
[wptrunner] Remove obsolete `XDG_CONFIG_HOME` creation

In https://crrev.com/c/5882842, `run_wpt_tests.py` sets up a temporary
`XDG_CONFIG_HOME` so that `headless_shell` or `chrome` discovers test
fonts on Linux (`content_shell` has magic test code to do this).
However, when showing the test results after an interactive run, the
browser spawned would inherit the test-only `XDG_CONFIG_HOME` variable.
Chromium treats that as a user data directory with no profiles [0],
causing the first-run UI to always run.

Just delete the `XDG_CONFIG_HOME` workaround, since it's been recently
superseded by https://crrev.com/c/6079445.

Related drive-by: `os.environ` -> `host.environ`, which are the same in
production but the latter is a fake in tests.

[0]: https://chromium.googlesource.com/chromium/src/+/main/docs/user_data_dir.md

Bug: 381127663
Change-Id: I7df71c1869675406a2c170e4de20895771589195
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6086798
Commit-Queue: Jonathan Lee <jonathanjlee@google.com>
Reviewed-by: Weizhong Xia <weizhong@google.com>
Cr-Commit-Position: refs/heads/main@{#1394922}
2 files changed
tree: 44fdf69e8dafe71037600b00645fdf8641a291f6
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.