Google Git
Sign in
chromium / chromium / src / bef6c6e266131e205cdf7b2e9afed7ecb1d2ea3c
commitbef6c6e266131e205cdf7b2e9afed7ecb1d2ea3c[log] [tgz]
authorLin Guo <sinyu890807@gmail.com>Tue Oct 22 18:32:57 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Oct 22 18:32:57 2024
treecb55355da0c8cfaa33469dce6ff47a5d1c966db5
parentcec453be1f1956aa4d78273f10a16f3a9c1122c5 [diff]
Fix crash when enabling edge-to-edge feature on Android 9 and below.

The Window.setNavigationBarContrastEnforced method should only be called
on Android API 29 (Android 10) and above. Refer link:
https://developer.android.com/reference/android/view/Window#setNavigationBarContrastEnforced(boolean)

In the TabbedNavigationBarColorController.java file, the
updateNavigationBarColor() method calls
Window.setNavigationBarContrastEnforced without checking the API level.
This causes a crash on devices running Android 9 (API 28) and below when
the edge-to-edge feature is enabled.

Bug: 374574269
Change-Id: Ia15b024caebbf0998a2c3ac5aaaf7a5e2ba7dc65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5937007
Reviewed-by: Charles Hager <clhager@google.com>
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Gang Wu <gangwu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1372199}
1 file changed
tree: cb55355da0c8cfaa33469dce6ff47a5d1c966db5
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.