Google Git
Sign in
chromium / chromium / src / 4fb34c25f489dea2e61cb552f984e0fa4a9ccf2f
commit4fb34c25f489dea2e61cb552f984e0fa4a9ccf2f[log] [tgz]
authorRoland Bock <rbock@google.com>Wed Jun 09 12:03:34 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jun 09 12:03:34 2021
tree9883223878498c04c2ec52e52921b5557e16e494
parentee0b79bfc0b440a27492743754511e6d48b3fac1 [diff]
Refactor DeviceManagementService unit tests for more coverage

The unit tests for DeviceManagementService use TestURLLoaderFactory
to intercept and analyse the requests made by the
DeviceManagementService. But they use

service_->OnURLLoaderCompleteInternal(
        service_->GetSimpleURLLoaderForTesting(), ...);

to simulate the answers from the DMServer.
This is relying on implementation details and it is bypassing
DeviceManagementService::OnURLLoaderComplete

This CL uses the TestURLLoaderFactory to simulate DMServer replies
instead. It fixes a few incorrect expectations in the tests, too, and it
will make future strucural changes in the DeviceManagementService
easier.

Bug: 1217037
Change-Id: Idb0755427025c7ced64197493590219f6840d0a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2940806
Commit-Queue: Roland Bock <rbock@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#890711}
1 file changed
tree: 9883223878498c04c2ec52e52921b5557e16e494
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.