Fix missing metrics for Service Worker Synthetic Responses

This change fixes a bug where page load metrics (e.g., FCP, LCP) were
not being recorded for pages served via Service Worker Synthetic
Responses.

The metric recording in `ServiceWorkerPageLoadMetricsObserver` often
depended on the page being fully service worker controlled
(`kLoadingBehaviorServiceWorkerControlled`). However, synthetic
responses can be served even without a fetch handler, meaning the page
isn't "controlled" in the traditional sense, causing metrics to be
missed.

This patch addresses this by:

1.  **Ensuring Correct Flagging:** Modifying `DocumentLoader` to always
    set the `kLoadingBehaviorServiceWorkerSyntheticResponse` flag when a
    synthetic response is used, independent of the controller mode.
2.  **Updating Observer Logic:** Introducing helper functions in
    `ServiceWorkerPageLoadMetricsObserver` to check for *either*
    service worker control or the presence of the synthetic response
    flag (`IsServiceWorkerControlledOrSyntheticResponseEnabled`). This
    ensures metric recording is triggered correctly for synthetic
    response cases.

The unit test mistakenly set `kLoadingBehaviorServiceWorkerControlled`
in the last CL and that introduced this bug. So added CHECK to the
`IsServiceWorkerSyntheticResponseEnabled()` in ServiceWorkerPLMO to
ensure the correct expectation. Ideally, it's better to have a browser
test for the synthetic response page load metrics, but it requires
another complicated test set up. Let me leave it in a future CL.

Bug: 40240298, 352578800
Change-Id: I624fcc4b9f6e4d7216d4dfa2dcc57c628094b48c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6887127
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Commit-Queue: Shunya Shishido <sisidovski@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1506918}
5 files changed
tree: 9c013f04144e66bd5aedb0f4268a09d80da66e5d
  1. .gemini/
  2. .github/
  3. agents/
  4. android_webview/
  5. apps/
  6. ash/
  7. base/
  8. build/
  9. build_overrides/
  10. buildtools/
  11. cc/
  12. chrome/
  13. chromecast/
  14. chromeos/
  15. codelabs/
  16. components/
  17. content/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. fuchsia_web/
  24. gin/
  25. google_apis/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. net/
  34. pdf/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .cursorignore
  54. .geminiignore
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. CPPLINT.cfg
  71. CRYPTO_OWNERS
  72. DEPS
  73. DIR_METADATA
  74. LICENSE
  75. LICENSE.chromium_os
  76. OWNERS
  77. PRESUBMIT.py
  78. PRESUBMIT_test.py
  79. PRESUBMIT_test_mocks.py
  80. README.md
  81. SECURITY_OWNERS
  82. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.