commit e76bff165405080149e04bd0e8fad3d1ee59eea8
author François Doray <fdoray@chromium.org> Tue Mar 12 21:16:11 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Mar 12 21:16:11 2024
tree 111d222067fc48cf66cf80b5aa0db72afa8805b9
parent 2e84768eb493791bd62278a24afea544a7e2c618

[freezing] Remove PageLiveStateDecorator::Delegate.

As part of the effort to freeze "browsing instances" instead of
"pages", we need to move all freezing logic to
//components/performance_manager (see crrev.com/c/5318016).
However, moving //c/b/pm/policies/freezing_policy_unittest.cc to
//components/performance_manager would create a circular dependency:

  c/b/pm/policies/freezing_policy_unittest.cc
  c/b/pm/decorators/page_live_state_decorator_delegate_impl.h
  components/permissions
  components/content_settings/browser
  components/page_load_metrics/browser
  components/performance_manager

To prevent that circular dependency, this CL simply removes
PageLiveStateDecorator::Delegate and moves tracking of the
notification permission to PerformanceManagerTabHelper. This
has benefits in addition to allowing the move of all freezing logic
to //components/performance/manager:

- Reduces complexity (less lines of code)
- Eliminates a thread hop on main frame navigation
- Makes the logic more accurate (previously, PerformanceManager only
  considered the value of ContentSettingsType::NOTIFICATIONS but
  that's not the only factor involved in granting the notification
  permission).

Bug: 325954772
Change-Id: I422a23c2567bf5e69343db9fca3928bedec80e4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5324402
Commit-Queue: Francois Pierre Doray <fdoray@chromium.org>
Reviewed-by: Anthony Vallée-Dubois <anthonyvd@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Alison Gale <agale@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1271824}