Google Git
Sign in
chromium / chromium / src / bf4ece0b5c2fb4aad6aa5120f75feb3f47a8491d
commitbf4ece0b5c2fb4aad6aa5120f75feb3f47a8491d[log] [tgz]
authorHans Wennborg <hans@chromium.org>Tue Jun 29 08:38:26 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jun 29 08:38:26 2021
treedff8c4d436b9c25adbd9abb56d97014b20d8701e
parenta964e92b50e54676cee02fab56a595784ccfe0a9 [diff]
Don't include stl_util.h in integer_to_string_conversion.h

stl_util.h is a big header, and integer_to_string_conversion.h is
included a lot (ca 7k instances or 20% of all translation units, for the
chrome target).

Include graph analysis shows [1] that this edge was responsible for
adding ca 1.6 GB to the source size processed by the compiler for the
chrome target on linux.

[1] https://commondatastorage.googleapis.com/chromium-browser-clang/chrome_includes_2021-06-28_125122.html#view=edges&includer=%5Ethird_party%2Fblink%2Frenderer%2Fplatform%2Fwtf%2Ftext%2Finteger_to_string_conversion%5C.h%24

Bug: 242216, 1194078
Change-Id: Ia51e2c704a7c4e7194f37114b316f3ebcffde147
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2992303
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#896820}
3 files changed
tree: dff8c4d436b9c25adbd9abb56d97014b20d8701e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.