commit | bf5a2432c8cfbc8e08f976422655c775aa0a1010 | [log] [tgz] |
---|---|---|
author | Zijie He <zijiehe@google.com> | Wed Jul 19 23:43:20 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jul 19 23:43:20 2023 |
tree | 7c1bc3adf755ae911e171dbe49e16affe44ceaaf | |
parent | 30ad1b5a20e4d9df8bd92024b8b42a01cee3da71 [diff] |
Enable the consistently passing tests in SharedWorkerServiceImplTest This change is part of the effort to re-enable consistently passing tests across the entire chromium. If the tests are reasonable, please LGTM and I will proceed to submit the change. If the tests are unreasonable, please let me know and I will remove them. ------ How the change is created ------ I do not inspect each individual test case, the idea is to run the disabled tests on reviver builders https://ci.chromium.org/ui/p/chromium/g/reviver/builders and use the aggregated results to decide if a previously disabled test is now consistently passing. Usually I create changes by directly enabling the tests. If the tests are failing on platforms not covered by the reviver builders or explicitly mentioned in the associated bugs, I may conditionally enable them on certain platforms. But other than that, I won't include extra changes except for the ones suggested by `git cl format`. ------ How to inspect the reviver builder results ------ You may choose a platform you are interested, e.g. chromium/reviver/lacros-coordinator. [link: https://ci.chromium.org/p/chromium/builders/reviver/lacros-coordinator] In the baseline builder / buildbucket.schedule step, e.g. chromium/ci/linux-lacros-builder-rel - buildbucket.schedule, there will be a luci run link. [ex: https://ci.chromium.org/ui/p/chromium/builders/reviver/runner/b8776966777608450081/overview] ------ Aggregated results of the tests involved ------ The following list shows how many times the changed tests were *consistently* passing on the relevant builders. content/test:content_unittests/SharedWorkerServiceImplTest.WebContentsDestroyed 127 fuchsia-fyi-arm64-dbg 150 fuchsia-fyi-x64-dbg 192 fuchsia-x64-rel 110 linux-lacros-tester-rel data version: 2023-06-28 16:45:51 Bug: 1380293 Change-Id: I50ffc741565a46e8b292a89ec4fed63f280bd90e Fixed: 1029434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4701307 Reviewed-by: Bo Liu <boliu@chromium.org> Commit-Queue: Zijie He <zijiehe@google.com> Cr-Commit-Position: refs/heads/main@{#1172662}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.