| commit | bf8085f33a0417f23b8d737bc4843f71a006314a | [log] [tgz] |
|---|---|---|
| author | Juan Mojica <juanmojica@google.com> | Tue Nov 19 19:43:08 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Nov 19 19:43:08 2024 |
| tree | a9067f4e88b303c9c5f9a0370ee373ffb6de8195 | |
| parent | ef0a4447e94a75db25377ff5ecc0e9e29a6be500 [diff] |
[lensoverlay] Fix rendering order on selection overlay resize. I had to remove `highlightedLines` being a computed property so it can properly be reset whenever the selection overlay rect resizes. We could not just add `selectionOverlayRect` to the computed binding since the highlighted lines need to be recalculated after the translate bounding boxes are recomputed. See bug for demo. See ordered flow of updates for Polymer elements: https://polymer-library.polymer-project.org/2.0/docs/devguide/data-system#property-effects Change-Id: Id676abfcd753a0c5c9007f265faad6ce2632f68f Bug: b:379322311, 379885040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6034323 Reviewed-by: Duncan Mercer <mercerd@google.com> Commit-Queue: Juan Mojica <juanmojica@google.com> Cr-Commit-Position: refs/heads/main@{#1385138}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.