Google Git
Sign in
chromium / chromium / src / bf9e3d69b44e34cb37f5e64dccff98df46014725
commitbf9e3d69b44e34cb37f5e64dccff98df46014725[log] [tgz]
authorCliff Smolinsky <cliffsmo@microsoft.com>Tue Apr 20 01:50:18 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Apr 20 01:50:18 2021
tree3cada6124b5bddfeeb10eade1c585f4cacf0bd89
parent61f3e49afc17ebaeb29f2a0c1fef12ee3c4abb8d [diff]
Ensure EnableHighDPISupport is always called for tests (behind a switch)

Currently, browser_tests calls EnableHighDPISupport only of the
Interactive flag is passed at the command line and interactive_ui_tests
doesn't call it at all. This works fine in the lab where VMs are always
running at 100% DPI, but when developers try to run tests locally on
non-100% DPI screens it can cause issues. In addition, since the browser
itself always runs with this enabled, it is more correct to have the
tests do it as well.

The first version of this change adds the call behind a command-line
switch. This enables a developer to use it locally. We will then run
the tests using that switch in the full waterfall to validate the
impact. If we determine no impact, we can enable this and remove the
switch.

Bug: 1190303
Change-Id: I8bfa1e17eaa8d33058a1ce0cd6220c6174ca098b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2776359
Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874088}
4 files changed
tree: 3cada6124b5bddfeeb10eade1c585f4cacf0bd89
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.