Revert "Fix app icon context menu window mode radio buttons not being checked"

This reverts commit 9f4aed6bf59c59125e3135011a9f57fef3df4c45.

Reason for revert: Looks caused AppServiceShelfContextMenuWebAppBrowserTest failures.

https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/37396


Original change's description:
> Fix app icon context menu window mode radio buttons not being checked
> 
> This CL affects the context menu for app icons in the Chrome OS shelf
> and app list where you select whether to open it in a window or tab.
> 
> The existing code checked effective display mode when we should be
> checking the user preference. This causes none of the options to be
> selected when the app's effective display mode is minimal-ui.
> 
> This CL updates the check to check the user preference instead.
> 
> Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=444141&signed_aid=5--cm1T-QBhf00TvOb-vug==&inline=1
> After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=444356&signed_aid=Dwn3yRwSjsRR_6VfxkkjAg==&inline=1
> 
> Bug: 1076725
> Change-Id: Ic89dcc4da921fdbe0cfe56746dc92c4afddd53ef
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2175695
> Auto-Submit: Alan Cutter <alancutter@chromium.org>
> Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
> Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
> Commit-Queue: Alan Cutter <alancutter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#764592}

TBR=ericwilligers@chromium.org,alancutter@chromium.org,nancylingwang@chromium.org

Change-Id: I5743cb79b0a1f3b39ab3d45c1ad26669bad55051
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1076725
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172736
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#764598}
3 files changed
tree: b4ea538043f419b9e6d3ebea1cbe850c19436403
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.