Google Git
Sign in
chromium / chromium / src / bfded6ee049a7e90d915119146d0acb53ead882d
commitbfded6ee049a7e90d915119146d0acb53ead882d[log] [tgz]
authorluci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>Sun Feb 02 16:43:05 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Sun Feb 02 16:43:05 2025
tree0101b0fc4dfb3c8e64fa7139e5bbbb1a906bed2d
parent95e5c2b49d87cf417c1f419bae4dd03db4bfc60f [diff]
Revert "[iOS][OR] Refactor omnibox popup mediator before move"

This reverts commit 28356a9e2e64a86737881d9b84cb92663e0adcc5.

Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/4872134217170944

Sample build with failed test: https://ci.chromium.org/b/8724206892391156065
Affected test(s):
[ninja://ios/chrome/test:ios_chrome_unittests/OmniboxPopupMediatorTest.SuggestionsAllVisible](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fios%2Fchrome%2Ftest:ios_chrome_unittests%2FOmniboxPopupMediatorTest.SuggestionsAllVisible?q=VHash%3Ae6fcf249de8f1255)
[ninja://ios/chrome/test:ios_chrome_unittests/OmniboxPopupMediatorTest.SuggestionsAllVisible](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fios%2Fchrome%2Ftest:ios_chrome_unittests%2FOmniboxPopupMediatorTest.SuggestionsAllVisible?q=VHash%3Af313067e1c194d65)
[ninja://ios/chrome/test:ios_chrome_unittests/OmniboxPopupMediatorTest.SuggestionsPartVisible](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fios%2Fchrome%2Ftest:ios_chrome_unittests%2FOmniboxPopupMediatorTest.SuggestionsPartVisible?q=VHash%3Ae6fcf249de8f1255)
[ninja://ios/chrome/test:ios_chrome_unittests/OmniboxPopupMediatorTest.SuggestionsPartVisible](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fios%2Fchrome%2Ftest:ios_chrome_unittests%2FOmniboxPopupMediatorTest.SuggestionsPartVisible?q=VHash%3Af313067e1c194d65)
[ninja://ios/chrome/test:ios_chrome_unittests/OmniboxPopupMediatorTest.UpdateMatchesCount](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fios%2Fchrome%2Ftest:ios_chrome_unittests%2FOmniboxPopupMediatorTest.UpdateMatchesCount?q=VHash%3Ae6fcf249de8f1255)
and 3 more ...

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F4872134217170944&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6218548&type=BUG

Original change's description:
> [iOS][OR] Refactor omnibox popup mediator before move
>
> Refactor some omnibox popup mediator logic before moving it to the popup
> and autocomplete controllers.
> This CL:
> - inlines updateMatches in updateWithResults.
> - removes some references to self.autocompleteResult.
>
> Bug: 390409870
> Change-Id: I5f45563c70d0babe706bbcab2ea3514dcf84c9bc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6218548
> Commit-Queue: Christian Xu <christianxu@chromium.org>
> Reviewed-by: Ameur Hosni <ameurhosni@google.com>
> Cr-Commit-Position: refs/heads/main@{#1414179}
>

Bug: 390409870
Change-Id: Ia6bd7c07829b0c8e807a29d2028ad17026b9a194
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6221425
Commit-Queue: Christian Xu <christianxu@chromium.org>
Reviewed-by: Christian Xu <christianxu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1414682}
3 files changed
tree: 0101b0fc4dfb3c8e64fa7139e5bbbb1a906bed2d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.