Revert "Extensions: CodeHealth: Prefer CHECK_IS_TEST() for test-only methods"

This reverts commit 6d3f5d32c34cbaa88320f6d5475343d659dc829f.

Reason for revert: CHECK_IS_TEST is unnecessary within test-only functions as presubmits already block calling them from production code.

Bug: chromium:346952289
Original change's description:
> Extensions: CodeHealth: Prefer CHECK_IS_TEST() for test-only methods
>
> Reference:
> https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++.md#test_only-code-paths-in-production-code
>
> This CL was uploaded by git cl split.
>
> R=mcnee@chromium.org
>
> Bug: chromium:346952289
> Change-Id: I7a58148940cae4dcfb07cfa832c8eb0aa8bbce86
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6477611
> Auto-Submit: Solomon Kinard <solomonkinard@chromium.org>
> Commit-Queue: Kevin McNee <mcnee@chromium.org>
> Reviewed-by: Kevin McNee <mcnee@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1450131}

Bug: chromium:346952289
Change-Id: Id74f222dd72f44e6461839e17e32110ebf02cfb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6479001
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1450265}
3 files changed
tree: 23d5910861b9871b5bf13bf53b7ebbbd66ecb6c7
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .git-blame-ignore-revs
  53. .gitallowed
  54. .gitattributes
  55. .gitignore
  56. .gitmodules
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. CPPLINT.cfg
  68. CRYPTO_OWNERS
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.