commit | c0cfaeadaddec421c93cf3c72bb20eefc031a652 | [log] [tgz] |
---|---|---|
author | Collin Baker <collinbaker@google.com> | Mon Jan 23 19:44:38 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jan 23 19:44:38 2023 |
tree | 0f0971b9b99ebf0ea33958afcd5d9c4ce3d65c2d | |
parent | cddaf4a1ddfcd76f86fc279cf1ff78fde4afe36a [diff] |
Revert "[resource-timing] Reduce HTMLObjectElement RT entry flakiness" This reverts commit a7dfd525dcc9ecd557ddfd8a419a2f62c802c13a. Reason for revert: test still failing consistently: https://ci.chromium.org/p/chromium/builders/ci/mac11-arm64-rel-tests Original change's description: > [resource-timing] Reduce HTMLObjectElement RT entry flakiness > > Several of our RT tests were suffering from flakiness, which turned out > to be implementation flakiness [1]. Apparently, RT entries weren't > firing in some cases, based on some race related to the mojo pipe > between URLLoader and ObjectNavigationFallbackBodyLoader. > > This CL fixes that flakiness, by not relying on OnDataCompleted calls > from the mojo layer, and instead count the number of bytes received > from the response, and finalize the response when they match the number > of bytes the response contained. > > [1] https://docs.google.com/document/d/1pD640qVkefcnen5yeqd-ZGTrygL_d4jG3ktjq_T78V0/edit# > > Bug: 1408635 > Change-Id: I351493593326dd7c637be55d7c98a19c4159e825 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4176867 > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1095596} Bug: 1408635 Change-Id: I7aa7cddef1deec88f9770582e6f275772500acdf No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4189058 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Collin Baker <collinbaker@google.com> Commit-Queue: Collin Baker <collinbaker@google.com> Cr-Commit-Position: refs/heads/main@{#1095757}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.