Google Git
Sign in
chromium / chromium / src / c110c7f685ee2e8b7832b5af49d03817d0a693f2
commitc110c7f685ee2e8b7832b5af49d03817d0a693f2[log] [tgz]
authorsisidovski <sisidovski@chromium.org>Thu Feb 08 05:50:19 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Feb 08 05:50:19 2024
tree1f4052662af3958670613f8aef768385a225e717
parent1f44552151b999cb1bcce560d55fd8cddd5c5078 [diff]
[SWAutoPreload] Add more crash key and debug code

I noticed SIGBUS happens when accessing the read buffer.

https://crash.corp.google.com/browse?q=product_name+IN+%28%27Chrome_Linux%27%2C%27Chrome_ChromeOS%27%2C%27Chrome_Android%27%29+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27content%3A%3ARaceNetworkRequestWriteBufferManager%3A%3ACopyAndCompleteWriteDataWithSize%27+AND+expanded_custom_data.ChromeCrashProto.channel%3D%27dev%27+AND+ComparableVersion%28product.Version%29%3E%3DComparableVersion%28%27123.0.6262.5%27%29+AND+ComparableVersion%28product.Version%29%3C%3DComparableVersion%28%27123.0.6272.2%27%29&stbtiq=&reportid=e9d5560578beed5e&index=0#4

This buffer comes from the mojo data pipe without any changes on the
caller side. Add another debug code right after calling the
BeginReadData() to get more clarity on this.

Also this CL fixes the mojo flag misuse, but this doesn't introduce any changes because those values are same internally.

Bug: 1472634, 40943349
Change-Id: Ibc38de62c1c100c58b03e08e4208624f69f35ee5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5276403
Commit-Queue: Shunya Shishido <sisidovski@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1257792}
1 file changed
tree: 1f4052662af3958670613f8aef768385a225e717
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.