Google Git
Sign in
chromium / chromium / src / c1207cd847cd85b018f81e29d1f52ffbe163f930
commitc1207cd847cd85b018f81e29d1f52ffbe163f930[log] [tgz]
authorAmit Hilbuch <amithi@chromium.org>Mon Jan 07 18:11:07 2019
committerCommit Bot <commit-bot@chromium.org>Mon Jan 07 18:11:07 2019
treef7d76e7aee5ed7ed51c4696487d7de2f0598d528
parenta60b6a5add634cf45ee443f226a04e99b0f6af42 [diff]
Fixing web platform tests for PeerConnection.setRemoteDescription().

Tests for PeerConnection.setRemoteDescription() did not call
setLocalDescription() on the caller object after creating the offer.
When the local description is not set, the PeerConnection can generate new MIDs
for the existing media sections. This caused tests to fail because the offer
was set on the callee causing the MIDs (and therefore media sections) not to
match.

Bug: None.
Change-Id: I67e98e5abf76a97ab57fc0427672313b44f9c258
Reviewed-on: https://chromium-review.googlesource.com/c/1396854
Reviewed-by: Steve Anton <steveanton@chromium.org>
Commit-Queue: Amit Hilbuch <amithi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620378}
2 files changed
tree: f7d76e7aee5ed7ed51c4696487d7de2f0598d528
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .