Fix leak with CertVerifier::Config additional_untrusted_authorities MultiThreadedCertVerifier::SetConfig was just adding new certs onto the end of `temp_certs_` and never removing the old ones, so `temp_certs_` could grow without bound. Also remove the DCHECK. It is valid and expected that there can be certificates that are accepted by X509Certificate but not by CERTCertificate. Also clarify the variable naming a bit. Change-Id: Ifbbda388a333a87e83bb65babbff0082747c3da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3611965 Reviewed-by: David Benjamin <davidben@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/main@{#996919}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.