| commit | c160b7f12be0a4ff29cae7f2a4b59e89cfb9048c | [log] [tgz] |
|---|---|---|
| author | Vladimir Levin <vmpstr@chromium.org> | Wed Apr 19 21:02:06 2023 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Apr 19 21:02:06 2023 |
| tree | 3b57544ca1eac026e05d96f256a7086b6cd16bfb | |
| parent | aa44a537eced622ad1f0ebfa1e882238e946d447 [diff] |
Revert "Prerender: Fix prerender new content timeout start timing" This reverts commit ff97f6bc463f127de6b8f0f266165176a02d66c2. Reason for revert: Breaks BFCache Original change's description: > Prerender: Fix prerender new content timeout start timing > > Prior to this change, we'd start the new content timeout timer in > DidNavigate. For pre-render this meant starting the timer before > activation. When activated, WasShown is called which reset the > fallback surface if the was a timer running. This caused us to clear > the graphics output immediately on activation and show blank. Without > prerender, we would still show the fallback content for the timeout > duration. > > With this patch we separate DidNavigate from creating the timer. We > conditionally create the timer RenderFrameHostManager::CommitPending > after the show call > > R=​rakina@chromium.org, jonross@chromium.org > > Bug: 1423006 > Change-Id: I1cd3f48837085346935ff5d307ebe8dc79dbe5f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4418087 > Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> > Reviewed-by: Rakina Zata Amni <rakina@chromium.org> > Reviewed-by: Khushal Sagar <khushalsagar@chromium.org> > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Commit-Queue: Vladimir Levin <vmpstr@chromium.org> > Reviewed-by: Bo Liu <boliu@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1132606} Bug: 1423006 Change-Id: Idef95225b0d85a68ae11c0943d5ccfe19a905db9 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4450847 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Vladimir Levin <vmpstr@chromium.org> Reviewed-by: Jonathan Ross <jonross@chromium.org> Owners-Override: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/main@{#1132678}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.