Google Git
Sign in
chromium / chromium / src / c17f37304d2bd6dbb18a06b283ce78f5796d8f14
commitc17f37304d2bd6dbb18a06b283ce78f5796d8f14[log] [tgz]
authorCalder Kitagawa <ckitagawa@chromium.org>Tue Jun 24 13:32:48 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jun 24 13:32:48 2025
tree719258fc8cfd6609acfe90cee47a3e323db7e575
parent9cb07acfc1df60668d169d89278a3df66500d601 [diff]
[Tab Model] Rework TabModelImpl#moveTab

Move tab was highly confusing. It was implemented in such a way that
moving a tab to a higher index required adding a +1 offset to account
for the fact the rest of the list would shift. This is not how list
reorder operations typically work and as a result lots of hacks to
workaround the issue existed in code. Just do what is more intuitive
instead and move the tab directly to the index.

New logic:

Tab Index < Destination Index - all the tabs before or at the
destination index will shuffle one index down to make room.

Tab Index > Destination Index - all tabs at or after the destination
index will shuffle one index up to make room.

Fixed: 425902847
Change-Id: Iaf83324bfde1ea35232c1faa2df29b0dfb25d3c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6652242
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1477877}
16 files changed
tree: 719258fc8cfd6609acfe90cee47a3e323db7e575
  1. .github/
  2. android_webview/
  3. apps/
  4. ash/
  5. base/
  6. build/
  7. build_overrides/
  8. buildtools/
  9. cc/
  10. chrome/
  11. chromecast/
  12. chromeos/
  13. codelabs/
  14. components/
  15. content/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .cursorignore
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. SECURITY_OWNERS
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.