Google Git
Sign in
chromium / chromium / src / c18afd26a96b41392d254ce23bfeb9940b4049b1
commitc18afd26a96b41392d254ce23bfeb9940b4049b1[log] [tgz]
authorTommy C. Li <tommycli@chromium.org>Thu Jan 17 00:59:18 2019
committerCommit Bot <commit-bot@chromium.org>Thu Jan 17 00:59:18 2019
treeb0496e39b81494fbd25467f698364c0de7bac326
parent1082d33dd3ac8dd8d25649f878fd345069028607 [diff]
Omnibox: Steady State Elisions - Fix some model vs. view logic division

Chrome has a bug where when the user focuses the Omnibox via Ctrl+L or
F6, sometimes the page action icons disappear.

This is because OmniboxEditModel::Unelide currently lacks a necessary
check. This CL adds that check and adds a test to verify that.

It moves some logic that existed in the OmniboxViewViews over to
OmniboxEditModel and de-duplicates some logic.

Bug: 921777
Change-Id: Ifed90d61e5b820eaaf16b41ba62a13eac73b10ff
Reviewed-on: https://chromium-review.googlesource.com/c/1410016
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623482}
4 files changed
tree: b0496e39b81494fbd25467f698364c0de7bac326
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .