Define an OptimizationTarget for Reading Mode phrase segmentation.
We would like to serve our phrase segmentation model via Chrome
Intelligence's model delivery infrastructure. Server side proto
was already added in cl/631959503
Bug: 339037155
Change-Id: Ide4115065ff61401fb7889aa3b9a3dae95f808da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5519115
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Commit-Queue: Xiang Xiao <xiangxiao@google.com>
Cr-Commit-Position: refs/heads/main@{#1305773}
diff --git a/components/optimization_guide/core/model_util.cc b/components/optimization_guide/core/model_util.cc
index 53ec6077..1e0ba1c 100644
--- a/components/optimization_guide/core/model_util.cc
+++ b/components/optimization_guide/core/model_util.cc
@@ -125,6 +125,8 @@
return "Compose";
case proto::OPTIMIZATION_TARGET_PASSAGE_EMBEDDER:
return "PassageEmbedder";
+ case proto::OPTIMIZATION_TARGET_PHRASE_SEGMENTATION:
+ return "PhraseSegmentation";
case proto::OPTIMIZATION_TARGET_SEGMENTATION_COMPOSE_PROMOTION:
return "SegmentationComposePromotion";
// Whenever a new value is added, make sure to add it to the OptTarget
diff --git a/components/optimization_guide/proto/models.proto b/components/optimization_guide/proto/models.proto
index cbe1760..b1d9653 100644
--- a/components/optimization_guide/proto/models.proto
+++ b/components/optimization_guide/proto/models.proto
@@ -122,7 +122,7 @@
// The scenarios for which the optimization guide has models for.
enum OptimizationTarget {
- reserved 14, 44;
+ reserved 14;
OPTIMIZATION_TARGET_UNKNOWN = 0;
// Should only be applied when the page load is predicted to be painful.
@@ -214,6 +214,8 @@
OPTIMIZATION_TARGET_COMPOSE = 42;
// Target for generating passage embeddings.
OPTIMIZATION_TARGET_PASSAGE_EMBEDDER = 43;
+ // Target for breaking up sentences into phrases.
+ OPTIMIZATION_TARGET_PHRASE_SEGMENTATION = 44;
// Target to determine whether to show promotion for Compose.
OPTIMIZATION_TARGET_SEGMENTATION_COMPOSE_PROMOTION = 45;
}
diff --git a/tools/metrics/histograms/metadata/optimization/histograms.xml b/tools/metrics/histograms/metadata/optimization/histograms.xml
index b52907f..eaa736f 100644
--- a/tools/metrics/histograms/metadata/optimization/histograms.xml
+++ b/tools/metrics/histograms/metadata/optimization/histograms.xml
@@ -62,6 +62,7 @@
<variant name="PageVisibility" summary="Page visibility"/>
<variant name="PainfulPageLoad" summary="Painful page load"/>
<variant name="PassageEmbedder" summary="Text embedding for passages"/>
+ <variant name="PhraseSegmentation" summary="Phrase segmentation"/>
<variant name="PreloadingHeuristics" summary="Speculation-rule preloading"/>
<variant name="SegmentationAdaptiveToolbar"
summary="Segmentation: Adaptive toolbar button"/>
