Revert of [DevTools] Consolidate overlay-related functionality in Overlay domain (patchset #7 id:120001 of https://codereview.chromium.org/2819183002/ )
Reason for revert:
This seems to be breaking the devtools closure compiler, i.e., closure is reporting an error:
https://luci-milo.appspot.com/buildbot/chromium.linux/Linux%20Tests/55326
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FLinux_Tests%2F55326%2F%2B%2Frecipes%2Fsteps%2Fdevtools_closure_compile%2F0%2Fstdout
Command: /usr/bin/python ../../testing/scripts/run_devtools_check.py ../../third_party/WebKit/Source/devtools/scripts/compile_frontend.py --isolated-script-test-output=/b/s/w/ioH2ERuI/output.json --isolated-script-test-chartjson-output=/b/s/w/ioH2ERuI/chartjson-output.json
Java executable: /usr/bin/java
Compiling frontend...
Compiling devtools_compatibility.js...
Verifying JSDoc comments...
devtools_compatibility.js compilation output:
0 error(s), 0 warning(s), 95.2% typed
devtools frontend compilation output:
/b/s/w/itFkGMoq/tmp_x1qK7/front_end/emulation/DeviceModeModel.js:640: WARNING - Property renderingAgent never defined on SDK.Target
this._target.renderingAgent().setShowViewportSizeOnResize(false);
^^^^^^^^^^^^^^
0 error(s), 1 warning(s), 94.3% typed
ERRORS DETECTED
Running ['/usr/bin/python', '../../third_party/WebKit/Source/devtools/scripts/compile_frontend.py'] in None (env: None)
Command ['/usr/bin/python', '../../third_party/WebKit/Source/devtools/scripts/compile_frontend.py'] returned exit code 1
Original issue's description:
> [DevTools] Consolidate overlay-related functionality in Overlay domain
>
> This turns InspectorOverlay into InspectorOverlayAgent with respective
> lifetime and domain:
> - rendering domain merges into overlay;
> - Page.configureOverlay moves to overlay;
> - highlighting and inspect mode move from DOM to overlay.
>
> BUG=none
> TBR=skyostil@chromium.org
>
> Review-Url: https://codereview.chromium.org/2819183002
> Cr-Original-Original-Commit-Position: refs/heads/master@{#465422}
> Committed: https://chromium.googlesource.com/chromium/src/+/8982f602a8e1f521949d8dd8dae58cff1c787bec
> Review-Url: https://codereview.chromium.org/2819183002
> Cr-Original-Commit-Position: refs/heads/master@{#465812}
> Committed: https://chromium.googlesource.com/chromium/src/+/7afbb9a64fbd30254a2dab9a689648621fa29f14
> Review-Url: https://codereview.chromium.org/2819183002
> Cr-Commit-Position: refs/heads/master@{#466489}
> Committed: https://chromium.googlesource.com/chromium/src/+/c8abe8c3b07d77195777e07180a4122f4d50246a
TBR=pfeldman@chromium.org,skyostil@chromium.org,dgozman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=none
Review-Url: https://codereview.chromium.org/2835843002
Cr-Commit-Position: refs/heads/master@{#466557}
65 files changed
