Google Git
Sign in
chromium / chromium / src / c1c36ea0d4603442c346995a9d55000add57ac11
commitc1c36ea0d4603442c346995a9d55000add57ac11[log] [tgz]
authorluci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>Fri Jul 26 04:34:35 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jul 26 04:34:35 2024
tree061752a88bac9fe61a8bf3a3ba9de437d5293019
parentb903355a321b7a02b416c43672664b734a8e0eb0 [diff]
Revert "Add WillCommitWithoutUrlLoader handling to RendererCancellationThrottle"

This reverts commit a0507e59a8fb68341fa08f3682be1544df52207e.

Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5728683374411776

Sample build with failed test: https://ci.chromium.org/b/8741385485032631025
Affected test(s):
[ninja://content/test:content_browsertests/DeferSpeculativeRFHCreationTest.CreationNotDeferredWithoutURLLoader](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fcontent%2Ftest:content_browsertests%2FDeferSpeculativeRFHCreationTest.CreationNotDeferredWithoutURLLoader?q=VHash%3A64d8154d6a05e06f)

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5728683374411776&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5741319&type=BUG

Original change's description:
> Add WillCommitWithoutUrlLoader handling to RendererCancellationThrottle
>
> Currently it only handles WillProcessResponse, so it didn't capture
> no-URLLoader navigations like about:blank. This CL makes it so that
> it captures both navigations with and without URLLoader.
>
> Bug: 352352911
> Change-Id: I0a75a4f80c04d7ec540ed74c63a07098797293c9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5741319
> Reviewed-by: Mingyu Lei <leimy@chromium.org>
> Commit-Queue: Mingyu Lei <leimy@chromium.org>
> Auto-Submit: Rakina Zata Amni <rakina@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1333343}
>

Bug: 352352911
Change-Id: I845a214f765291d9a3d30715099e04eda849ab64
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5742503
Owners-Override: Mikihito Matsuura <mikt@google.com>
Reviewed-by: Mikihito Matsuura <mikt@google.com>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1333365}
6 files changed
tree: 061752a88bac9fe61a8bf3a3ba9de437d5293019
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.