Google Git
Sign in
chromium / chromium / src / c1c5e0723cf5b8f4702e43023d0b2e1562c441e7
commitc1c5e0723cf5b8f4702e43023d0b2e1562c441e7[log] [tgz]
authorFilipa Senra <fsenra@google.com>Thu Jun 27 12:46:29 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jun 27 12:46:29 2024
treeb53fef9817535dbbf2009e64d232489f26c3e2b4
parent521771df326b3de7b881b578c60dff75cf871bd6 [diff]
[iOS][QD] Delete BrowsingDataCommands in favour of BrowsingDataRemover

This CL deletes the BrowsingDataCommands that trigger deletion of the
browsing data in favour of its clients using BrowsingDataRemover
directly. We moved the logic to show the activity indicator and reload
pages to the BrowsingDataRemover.

We're doing this refactoring because we would like to trigger the
deletion from the QuickDeleteMediator, and the browser state shouldn't
go beyond the Coordinators. As such the mediator doesn't have access to
it. The current BrowsingDataCommands requires the browser state as an
argument. See follow up CL: https://crrev.com/c/5638816

Bug: 341107837, 335387869, 325612973
Change-Id: I8c4afb4f7683680fdddcb4794e0d51eba0e6cd86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5638815
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Filipa Senra <fsenra@google.com>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1320293}
41 files changed
tree: b53fef9817535dbbf2009e64d232489f26c3e2b4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.