commit | c1df332cee094d825117159c0847eb95cf4a6c41 | [log] [tgz] |
---|---|---|
author | Keren Zhu <kerenzhu@chromium.org> | Wed Dec 07 22:04:07 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Dec 07 22:04:07 2022 |
tree | 98ae255e00f853023f0f0898aa7b2640c6c3ef9c | |
parent | 39599b8cc01cca0d5a083967e1cff082e33f2b80 [diff] |
Revert "immersive mode mac: smartly re-parent overlay window and sub-widgets" This reverts commit fddaa1797cdfd403d907a38cc2aa4122b00b388c. Reason for revert: https://crbug.com/1399286 It seems that WidgetLayering and ImmersiveFullscreen are not playing well in concert. Because WidgetLayering is already enabled on Canary and Dev, this revert will roll us back to a known state. Original change's description: > immersive mode mac: smartly re-parent overlay window and sub-widgets > > When entering fullscreen, > * attach the overlay window to NSToolbarFullScreenWindow. > * attach sub-widgets to the overlay window. > > When leaving fullscreen, attach sub-widgets back to the browser window. > > This fixes the issue that persistent sub-widgets are behind the toolbar > when entering fullscreen. > > Also fix permission bubble, find bar and web dialog. They were attached > to the browser window at all times and should be attached to the overlay > widget when in fullscreen. > > screencast: https://drive.google.com/file/d/1HLU_2ctE5xkmikbulRn6CpK7B2UOL7jV/view?usp=sharing&resourcekey=0-SwXVXi_PiHcSXE3GFQkW5A > > Bug: 1349422, 1350595 > Change-Id: I0a5125774a97954c2db45e45f25c90376e1bf749 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4023784 > Reviewed-by: Tom Burgin <bur@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Keren Zhu <kerenzhu@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1080333} Bug: 1349422, 1350595 Change-Id: I3e9978bd1f372834edafb6f2fabdfd370a539015 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4085972 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Tom Burgin <bur@chromium.org> Cr-Commit-Position: refs/heads/main@{#1080588}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.