commit c20c46cc03552fe69908cfaa0e2a5f02546cebf3
author Nancy Wang <nancylingwang@chromium.org> Tue Apr 05 09:23:26 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Apr 05 09:23:26 2022
tree acd9f5db84d41a331f777c7c4856ddd4129d2564
parent aacf6c8aac88e181e1d739592953f57c0f65f11d

Fix the icon loading issue for Chrome apps running in Lacros.

When StandaloneBrowserExtensionApps::OnApps is called, apps are
published to AppRegistryCache, and the OnAppUpdate notifies the shelf to
load icons for apps. However,
StandaloneBrowserExtensionApps::RegisterAppController might not be
called yet to bind the Crosapi controller, so load icon failed for the
shelf. Call sequence:
1) StandaloneBrowserExtensionApps::OnApps
     PublishApps to AppRegistryCache
       Shelf::OnAppUpdate is called
         Shelf calls LoadIcon
2) StandaloneBrowserExtensionApps::LoadIcon {
  if (!controller_.is_bound()) {
    std::move(callback).Run(apps::mojom::IconValue::New());
    return;  // Crosapi is not bound yet, load icon failed.
  }
3) StandaloneBrowserExtensionApps::RegisterAppController is called to
   register Crosapi

This CL modifies StandaloneBrowserExtensionApps::OnApps to check whether
CrosApi is registered, controller is bound. If not, save apps to the
local cache, and when register Crosapi, publish apps in cache.

This CL also modified `should_notify_initialized`. Add a local variable
'should_notify_initialized_' to set the should_notify_initialized as
true when publish apps for the first time. When CrosApi is registered
for the first time, set should_notify_initialized as true if apps
haven't been published yet.

Add tests to verify OnApps, and should_notify_initialized.

Web apps should have the similar issue as well. There will be a follow
up CL to address the issue for web apps running in Lacros.

BUG=1310962

Change-Id: I033df05c19c5dea678bde140873e3e0765707b36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3568007
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#988888}